From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, leif.middelschulte@gmail.com, newren@gmail.com
Subject: Re: [PATCH 3/3] Inform about fast-forwarding of submodules during merge
Date: Wed, 16 May 2018 10:42:26 +0900
Message-ID: <xmqqk1s474vx.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180515200030.88731-6-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
> From: Leif Middelschulte <Leif.Middelschulte@gmail.com>
>
> Inform the user about an automatically fast-forwarded submodule. The
> silent merge behavior was introduced by commit 68d03e4a6e44 ("Implement
> automatic fast-forward merge for submodules", 2010-07-07)).
Oh, another thing I forgot to mention.
These three lines do not convey much useful information. The first
sentence can be read from the patch text, and the rest can be read
from "git blame" and "git log" output.
It is correct that the silent behaviour was introduced long time
ago. The proposed log message does not even say if that silent
behaviour is bad in any way, let alone why it is bad and need to be
changed.
Perhaps Leif can elaborate why this change is a good idea in the
first place?
Thanks.