John Stabinger
added a comment - 12/Jan/11 8:08 PM - edited The fieldset has an ID of #header which is conflicting with the #header div of the theme layout. The fix would be to rename the #header div and corrosponding css.
As a sidenote, because this fieldset has claimed the #header ID, all themes will need to avoid using #header or they could run into the same issue(s).

Petr Skoda
added a comment - 19/Jan/11 12:08 AM Please file the PULL request through this tracker instead, we are not processing the requests on jira at all. I am going to disable the issues and hopefully requests too there.
Thanks.

I've just integrated the changes John made in PULL-172 however the duplicate #header id's is a greater problem.
I've run a quick search of the Moodle source code and #header is used at least four times within the code base, three enrolment plugins, and during installation.
We will either need to change the magazine theme, or change all locations within Moodle using #header.
Has anyone created an issue along these lines yet?

Sam Hemelryk
added a comment - 31/Jan/11 1:47 PM Hi guys,
I've just integrated the changes John made in PULL-172 however the duplicate #header id's is a greater problem.
I've run a quick search of the Moodle source code and #header is used at least four times within the code base, three enrolment plugins, and during installation.
We will either need to change the magazine theme, or change all locations within Moodle using #header.
Has anyone created an issue along these lines yet?
Cheers
Sam

I can create the issue and change the #header for the Magazine theme. However, I would guess that this issue will crop up again in non-core themes as #header was used in many 1.9x themes and people upgrading their themes will probably run into this.

Let me know which way you want to go. I certainly have no problem changing the theme's selector if that is ultimately the decision.

John Stabinger
added a comment - 01/Feb/11 9:29 PM I can create the issue and change the #header for the Magazine theme. However, I would guess that this issue will crop up again in non-core themes as #header was used in many 1.9x themes and people upgrading their themes will probably run into this.
Let me know which way you want to go. I certainly have no problem changing the theme's selector if that is ultimately the decision.
John