tag:blogger.com,1999:blog-8340788719090141711.post454630460325405319..comments2016-10-14T03:21:49.734+02:00Comments on Manfred's Blog: Smelly codeManfred Ramoserhttps://plus.google.com/105450635966487419466noreply@blogger.comBlogger2125tag:blogger.com,1999:blog-8340788719090141711.post-86817729445371304642011-01-19T14:05:16.213+01:002011-01-19T14:05:16.213+01:00important is that works and not how it looks. some...important is that works and not how it looks. some programmers make good looking code, but it works like nothing. that smells!Anonymousnoreply@blogger.comtag:blogger.com,1999:blog-8340788719090141711.post-89803846524938484272010-12-12T14:37:05.037+01:002010-12-12T14:37:05.037+01:00Hi Manfred
Nice.
But I disagree with 6. and 7.
...Hi Manfred<br /><br />Nice. <br />But I disagree with 6. and 7.<br /><br />&gt;&gt;6. The &quot;return false;&quot; statement should be inside the try block because it is logically associated to it<br /><br />Disagree, and you as well ;-) <br />At least you didn&#39;t change your code... <br /><br /><br /><br /><br />&gt;&gt;7. Missing Method documentation<br /><br />What is the value of this documentation?<br /><br />What about changing the method name to: IsInUse or FileIsLocked. Is this method part of the File class?<br /><br />If this a public API, maybe keep the doco...<br /><br />My problem with this:<br />As soon as you refactor this method and you change a little meaning of it, you have to change the code comment as well, which is forgotten most of the times...Peter Gfaderhttps://www.blogger.com/profile/07780415437484280285noreply@blogger.com