67292011-07-01 02:38:00 -0700Article date modified function not found in atom webfeed plugin2012-03-12 10:44:23 -0700111UnclassifiedOJSPlug-ins2.3.7AllAllRESOLVEDFIXEDP3normal---1ales.kladnikmichael.pkpalecales.kladnikchuck.t.parkermichael.pkpmorinpkp-supportoldest_to_newest242140ales.kladnik2011-07-01 02:38:39 -0700I updated OJS to 2.3.5 using a patch from 2.3.4
The function for determining feed updated date in "atom.tpl" has an issue that breaks the execution of the template and ends the feed rendering after the title.
The problematic function is (lines 17-26 in atom.tpl):
{* Figure out feed updated date *}
{assign var=latestDate value=$issue->getDatePublished()}
{foreach name=sections from=$publishedArticles item=section}
{foreach from=$section.articles item=article}
{if $article->getDateModified() > $latestDate}
{assign var=latestDate value=$article->getDateModified()}
{/if}
{/foreach}
{/foreach}
<updated>{$latestDate|date_format:"%Y-%m-%dT%T%z"|regex_replace:"/00$/":":00"}</updated>
I managed to get the feed working again by replacing $article->getDateModified() with $article->getDatePublished(). It seems that getDateModified() doesn't exist for article. I don't know though if the function for estimating feed date is now working as it was intended, but at least it works somehow.2422513585morin2011-07-04 06:09:54 -0700Created attachment 3585
Patch implementing Ales Kladnik's fix242262morin2011-07-04 06:11:05 -0700I had the same problem and Ales' fix worked for me. I've attached it as a patch.242313michael.pkp2011-07-04 10:44:52 -0700Thanks, Ales and Pat for your help with this.
The getDateModified function has since been reneamed to getLastModified -- this was one place where it wasn't updated to the new name.2423243588michael.pkp2011-07-04 10:47:21 -0700Created attachment 3588
Patch against OJS 2.3.6242335michael.pkp2011-07-04 10:51:07 -0700stable:
https://github.com/pkp/ojs/commit/fdee316e3d9033354ccf982b587bbc6f834ada17
master:
https://github.com/pkp/ojs/commit/523f5eed66be1e364d9cea57acfbb7b087270b90242346michael.pkp2011-07-04 10:51:16 -0700Fixed.272597jmacgreg2012-03-12 10:44:23 -0700*** Bug 7025 has been marked as a duplicate of this bug. ***35852011-07-04 06:09:00 -07002011-07-04 10:47:21 -0700Patch implementing Ales Kladnik's fix6729.patchtext/plain644morinLS0tIG9qcy0yLjMuNS9wbHVnaW5zL2dlbmVyaWMvd2ViRmVlZC90ZW1wbGF0ZXMvYXRvbS50cGwJ
MjAxMS0wNS0zMSAxNjowNDo0My4wMDAwMDAwMDAgLTA0MDAKKysrIHB1YmxpY19odG1sL3BsdWdp
bnMvZ2VuZXJpYy93ZWJGZWVkL3RlbXBsYXRlcy9hdG9tLnRwbAkyMDExLTA3LTA0IDA5OjAzOjQw
LjAwMDAwMDAwMCAtMDQwMApAQCAtMTgsOCArMTgsOCBAQAogCXthc3NpZ24gdmFyPWxhdGVzdERh
dGUgdmFsdWU9JGlzc3VlLT5nZXREYXRlUHVibGlzaGVkKCl9CiAJe2ZvcmVhY2ggbmFtZT1zZWN0
aW9ucyBmcm9tPSRwdWJsaXNoZWRBcnRpY2xlcyBpdGVtPXNlY3Rpb259CiAJCXtmb3JlYWNoIGZy
b209JHNlY3Rpb24uYXJ0aWNsZXMgaXRlbT1hcnRpY2xlfQotCQkJe2lmICRhcnRpY2xlLT5nZXRE
YXRlTW9kaWZpZWQoKSA+ICRsYXRlc3REYXRlfQotCQkJCXthc3NpZ24gdmFyPWxhdGVzdERhdGUg
dmFsdWU9JGFydGljbGUtPmdldERhdGVNb2RpZmllZCgpfQorCQkJe2lmICRhcnRpY2xlLT5nZXRE
YXRlUHVibGlzaGVkKCkgPiAkbGF0ZXN0RGF0ZX0KKwkJCQl7YXNzaWduIHZhcj1sYXRlc3REYXRl
IHZhbHVlPSRhcnRpY2xlLT5nZXREYXRlUHVibGlzaGVkKCl9CiAJCQl7L2lmfQogCQl7L2ZvcmVh
Y2h9CiAJey9mb3JlYWNofQo=
35882011-07-04 10:47:00 -07002011-07-04 10:47:21 -0700Patch against OJS 2.3.66729.difftext/plain683michael.pkpZGlmZiAtLWdpdCBhL3BsdWdpbnMvZ2VuZXJpYy93ZWJGZWVkL3RlbXBsYXRlcy9hdG9tLnRwbCBi
L3BsdWdpbnMvZ2VuZXJpYy93ZWJGZWVkL3RlbXBsYXRlcy9hdG9tLnRwbAppbmRleCA0ZTI0OTZl
Li41YTg4MGNhIDEwMDY0NAotLS0gYS9wbHVnaW5zL2dlbmVyaWMvd2ViRmVlZC90ZW1wbGF0ZXMv
YXRvbS50cGwKKysrIGIvcGx1Z2lucy9nZW5lcmljL3dlYkZlZWQvdGVtcGxhdGVzL2F0b20udHBs
CkBAIC0xOCw4ICsxOCw4IEBACiAJe2Fzc2lnbiB2YXI9bGF0ZXN0RGF0ZSB2YWx1ZT0kaXNzdWUt
PmdldERhdGVQdWJsaXNoZWQoKX0KIAl7Zm9yZWFjaCBuYW1lPXNlY3Rpb25zIGZyb209JHB1Ymxp
c2hlZEFydGljbGVzIGl0ZW09c2VjdGlvbn0KIAkJe2ZvcmVhY2ggZnJvbT0kc2VjdGlvbi5hcnRp
Y2xlcyBpdGVtPWFydGljbGV9Ci0JCQl7aWYgJGFydGljbGUtPmdldERhdGVNb2RpZmllZCgpID4g
JGxhdGVzdERhdGV9Ci0JCQkJe2Fzc2lnbiB2YXI9bGF0ZXN0RGF0ZSB2YWx1ZT0kYXJ0aWNsZS0+
Z2V0RGF0ZU1vZGlmaWVkKCl9CisJCQl7aWYgJGFydGljbGUtPmdldExhc3RNb2RpZmllZCgpID4g
JGxhdGVzdERhdGV9CisJCQkJe2Fzc2lnbiB2YXI9bGF0ZXN0RGF0ZSB2YWx1ZT0kYXJ0aWNsZS0+
Z2V0TGFzdE1vZGlmaWVkKCl9CiAJCQl7L2lmfQogCQl7L2ZvcmVhY2h9CiAJey9mb3JlYWNofQo=