I'm noticing a couple assert statements added to odejava which seem to be a bit dubious, first for the fact that assert statements never really became that widely utilized so I'd recommend not using them. Secondly though, the assert seems to modify a variable which is a definate no go since you can turn asserts off at runtime so that line would never be executed.

Nothing wrong with asserts - they are good in the fact that production code doesn't have to enable them - hence reducing some checks. They are binary backward compatable to other JVM's as well so no problem.

I agree that they shouldn't alter variables - we can fix the one assert which does.

However - in the case in question it is harmless as that variable is literally used for nothing else but the assert in question.

Ok, sounds reasonable. I've never seen anyone use asserts in an open source project so I wanted to make sure that everyone was ok with it. Since everyone seems to be me, you and Jani, let's leave em in!

java-gaming.org is not responsible for the content posted by its members, including references to external websites,
and other references that may or may not have a relation with our primarily
gaming and game production oriented community.
inquiries and complaints can be sent via email to the info‑account of the
company managing the website of java‑gaming.org