Original status: 3-Accepted; Suggested Status: NEW
Original submitter: sunlit
Description:
no encoding/locale choice in the property editor
for the project, and no pre-defined drop-down locale/encoding choice menues in
the properties of the jsp pages
user may not and need not know the exact spelling of the encoding variables,
and consequently he is unable to set the property
Evaluation:
There was an editor from JSFCL hooked up to this property, but it was commented
out (see DocumentCompNode, ll. 214-220). There appear to be some insync problems
which prevent the property editor from working.
Note also that references to editors in JSFCL should be migrated to the newer
editors defined in the propertyeditors module.
Evaluation (Entry 2):
It was commented out by Eric (when the source was in com.sun.rave.component.html
package rev 1.24).
I don't know the reason behing (it is mentioned there is some), passing to him.
Evaluation (Entry 3):
- I looked at the code and I dont remember much, and the comment is cryptic even
to me
- the change from what I can recall was made quite a long time ago
- it seems to me that we should attempt to hook up the appropriate domains to
this properties and see what happens
Evaluation (Entry 4):
It looks like the property editors that are designed to be used with design
beans (e.g. those in jsfcl or propertyeditors modules) won't work for the
project properties defined by the designer, because they are not modeled by
inSync, and therefore do not have any DesignProperty object associated with
them. These editors will not work correctly (or sometimes, will not work at all)
unless a DesignProperty has been passed to them.
I recommend putting together a few simple property editors just for the designer.
Re-assigning to webform, as this is not a components problem.
Evaluation (Entry 5):
Talking to Gregory about this, who told me that the designer should implement
the property editor.
I don't agree with that, because designer shouldn't even provide the node
represending the jsp or java file (or both). Also this was never working, so I
wanted to mark this as RFE, but he wanted me to ask for waving, so I am doing
that. Implementing the property editor would consume some time, and also it
wouldn't help much since designer isn't the only place which would need such
editor -> design issue.
Evaluation (Entry 6):
Changing this to RFE, it was never working and it was not specified as must-have
feature.
Evaluation (Entry 7):
Yes, this doesn't belong to the designer at all, it doesn't handle the sources.
Passing to insync.