Comments

FrameLoadRequest should reuse origin instead of recreating it.
FrameLoadRequest is currently constructing the requestor origin from
the URL of the requestor document. However, constructing origins based
on URL is a lossy process and does not preserve precursor origin
information.
Since the requestor document is already passed in as a parameter, the
origin of the document should be used directly. This CL changes that.
It also fixes a bug in the GetDownloadPolicy method where origin
comparison is assigned to a boolean incorrectly.
Bug: 632514, 882053
Change-Id: Ibb386ef7ecddc0b5dcc5b9e2b83f7b5215fdc1e9
Reviewed-on: https://chromium-review.googlesource.com/c/1378587
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616889}

Comments

[Extensions] Remove linked_ptr from ManifestHandler[Registry]
Remove linked_ptrs from ManifestHandler and ManifestHandlerRegistry,
and tweak the ManifestHandlerRegistry interface to be more friendly
about passing ownership.
- Make ManifestHandlerRegistry::RegisterHandler() public, and explicitly
take ownership of the ManifestHandler.
- Register ManifestHandlers with
ManifestHandlerRegistry::RegisterHandler() directly, rather than going
through ManifestHandler::Register().
(The combination of these two changes makes for a less surprising
interface, where we do registry->RegisterHandler(make_unique<Handler>())
rather than (new Handler())->Register())
- Store ManifestHandlers in an unsorted vector in
ManifestHandlerRegistry, which serves only to maintain ownership.
Update the maps to only retain raw pointer references.
TBR=halliwell@chromium.org (mechanical change to cast_extensions_api_provider.cc)
Bug: 914401
Change-Id: Ib53c44095e8b91ef768422ab9ecd8d71726da4a5
Reviewed-on: https://chromium-review.googlesource.com/c/1374389
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616880}

Comments

WebUI: fix input labels for large minimum-font-size
Originally, cr-input's font-size, height, line-height are all set to 0.625rem,
but when the minimum-font setting changes, font-size is forced to not respect
"rem". This CL changes the height/line-height styling to be 1em, such that it
stays in sync with the label's actual font-size, instead of with rem, since
the original intention was for height/line-height to equal the exact font height
anyway.
Bug: 900135
Change-Id: I5a64114fad5d0b7455c6e577b04c3a26e21fbfba
Reviewed-on: https://chromium-review.googlesource.com/c/1376664
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616868}

Comments

lazy-load: Increase timeout value to reduce flakes
The test is still a bit flaky after increasing the value to 400ms (
which did in fact reduce flakiness substantially). This CL will
increase the value even further (600ms) to further reduce the flakiness.
TBR=iclelland@chromium.org
Bug: 915236
Change-Id: I1ad650ed14dbf9b054a966324ec033a4bd2f47f8
Reviewed-on: https://chromium-review.googlesource.com/c/1379105
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616867}

Comments

Fuchsia: Add Connector C++ and JS library for injecting channels to JS.
The Connector JS library allows callers to create asynchronously-bound
ports which can be immediately written to. The Connector will
handle the details of connecting the JS and C++ ports together. All
details pertaining to the port's connected state are abstracted from
the JS side.
It will be used as the transport for cast.__platform__ APIs so that
they can communicate with other components outside the content
boundaries.
* Use shared memory for injected scripts so that renderers don't
have to store their own copies.
* Move some common test code to webrunner/common, including
the browser test base class and launcher.
Bug: 893236
Change-Id: I6e769ed3422a8acadd696b51021d3877323b416d
Reviewed-on: https://chromium-review.googlesource.com/c/1357655
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616866}

Comments

Add image codecs & me to WATCHLISTS
This CL adds a new WATCHLIST area called blink_image_codecs. It includes
both the decoders and encoders. It also included the perf tests for the
codecs.
This CL also adds me to that new blink_image_codecs watchlist.
Change-Id: I2db95a44386533a74d253cb3e18c7f436cb728d6
Reviewed-on: https://chromium-review.googlesource.com/c/1379031
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616861}