Comment on attachment 639071[details][diff][review]
v1
Review of attachment 639071[details][diff][review]:
-----------------------------------------------------------------
::: js/src/frontend/SemanticAnalysis.h
@@ +19,2 @@
> /*
> + * For each function in the compilation unit given by sc and functionList,
This sentence confuses me. Presumably the "given by" refers to "each function" not "the compilation unit"?
Also, "given by parser->tc->sc and parser->tc->functionList" would be clearer.
Now that I look at it, AnalyzeFunctions() could be passed |parser->tc| instead of |parser|. Can you do that? And then you can revert the comment to what it was previously :)
::: js/src/jsprvtd.h
@@ +180,5 @@
> +namespace frontend {
> +
> +struct BytecodeEmitter;
> +struct Definition;
> +struct FunctionBox;
I've never understood the purpose of jsprvtd.h...