See what you think and suggested improvements

This is a discussion on See what you think and suggested improvements within the C++ Programming forums, part of the General Programming Boards category; I wrote an banking system an just want to know what you experts think about it i hope you like ...

I think there's absolutely no way I'm going to look at all that code. Two comments:
1) Your lines are too long. Not only do they mess up this forum, they're also overflowing the lines of most people's IDEs that way.
2) Your main() is waaaaaaay too long. Make every case its own function.

Use std::string, and not chars.
Your code seems to be too much C-esque. You need to learn to think in terms of C++ ways.
And don't store pointers in the vectors. Store actual objects. You currently end up with huge leaks.

Are you sitting down comfortably? This will take some time. Please take these comments as "I've worked for 20 years in programming, and I'm trying to help you". You wouldn't have posted the code if you didn't want comments, I know that, but perhaps you expected just a few small comments.

Why not use C++ string, instead of char arrays?

I get LOTS of warnings for mixing unsigned and signed in comparisons where you are using vector::size().

This whole section would be MUCH easier if you kept one structure of all the customer data, rather than a customer entry, a creditcard entry, a mortgage entry, etc, etc. Store all the data on a customer in one structure (class or struct). If something isn't being used (e.g. no mortgage for a particular customer), then you can just have a special marker value for the mortgage section to say "this customer doesn't have a mortgage".
Also, I presume you set x = 0 to avoid problems when you delete the last entry. Perhaps you'd be better off using the "break" keyword to stop the loop - I presume there isn't more than one entry for any particular customer for any of the vectors.

CurrentAccount and SavingsAccount perhaps should be inheriting from a BaseAccount, to avoid code duplication (in fact, there are many places where code is simply repeated, when it probably should be functions).

Several things here:
Using variables called "o" is a bad idea! They look too much like zero.
Why are you passing in a value2, that is only ever used to store o before it's being returned? Since it is a parameter (and not a reference), the outside variable corresponding to value2 doesn't change, and it is not being used inside the fucntion for any purpose.
The two lines marked in red have a completely useless empty string in them -

Code:

cout << endl;

will do exactly the same thing (but a little bit more efficient, as you are not passing an empty string around to be printed).

Same comment applies to a few other similar functions.

The function main() is VERY much too large - nearly 1400 lines of code, and whilst I may agree with Laserlight that function size is somewhat a coding style issue, that is definitely beyond what ANYONE will recommend. [Exceptions do exist, but this certainly looks like a function that can be split into several portions].

Eeeeeek, that's horrible! You must absolutely LOVE typing, because that program should be about ten times shorter, and no I'm not exaggerating, if anything that's pessimistic...

That code is absolutely screaming out for someone to make a common base class for accounts. Really, it's screaming so painfully loud and screeching! The first 4 members from CurrentAccount at least could go in the base class. Please please pleeeease, learn about polymorphism and virtual functions!

Don't store items by pointer in the vector when you don't have to. Gaaaaah the memory leaks!

Aaaaaargh, the cyclomatic complexity is off the charts!

Oh the torture, I now have to go and purge the last few minutes of memory from my head.