Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/angelscript.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/angelscript-2.30.0-1.fc23.src.rpm
Description:
The AngelCode Scripting Library, or AngelScript as it is also known, is an
extremely flexible cross-platform scripting library designed to allow
applications to extend their functionality through external scripts. It has
been designed from the beginning to be an easy to use component, both for the
application programmer and the script writer.
Efforts have been made to let it call standard C functions and C++ methods
with little to no need for proxy functions. The application simply registers
the functions, objects, and methods that the scripts should be able to work
with and nothing more has to be done with your code. The same functions used
by the application internally can also be used by the scripting engine, which
eliminates the need to duplicate functionality.
Fedora Account System Username: ignatenkobrain

When do you get that error?
> Name: angelscript> %prep
> %setup -q -n sdk
This is not nice, since "-n sdk" implies "rm -rf sdk" in builddir root and may wipe something in a completely unexpected way.
Typically, in such a case where %name is completely different from top source dir, you would use %setup -c and "cd sdk" in %prep, %build and %install:

> -Change the %doc for -devel from "%doc sdk/docs/*" to "%doc sdk/docs/manual/*" to avoid including the files under dk/docs/articles in both the main package and the -devel package
I will fix on import stage. Thanks for review!
New Package SCM Request
=======================
Package Name: angelscript
Short Description: Flexible cross-platform scripting library
Upstream URL: http://www.angelcode.com/angelscript/
Owners: ignatenkobrain
Branches: f21 f22

two notes
- it fails to build on all secondary arches, please either fix it or make it ExclusiveArch - there seem to be some assembler code in source/as_callfunc_x64_gcc.cpp that's being used for non-x86 arches
- there are tons of "dereferencing type-punned pointer will break strict-aliasing rules" warnings, please build with --fno-strict-aliasing, ignoring them can lead to unpredictable results especially in combination with gcc5

(In reply to Dan Horák from comment #15)
> two notes
> - it fails to build on all secondary arches, please either fix it or make it
> ExclusiveArch - there seem to be some assembler code in
> source/as_callfunc_x64_gcc.cpp that's being used for non-x86 arches
I will do now exclusivearch and try to fix in the future if someone will need for secondary arches
> - there are tons of "dereferencing type-punned pointer will break
> strict-aliasing rules" warnings, please build with --fno-strict-aliasing,
> ignoring them can lead to unpredictable results especially in combination
> with gcc5
Will do