Currently my favorite controller is the XBox One Controller, but if I had to pick one of all time it would probably be the PS2. The only reason being that I had that controller in my hands way more than any other controller. I actually had time to play back then. lol.

xBox controller has been my favorite control to use simply for the fact that when it comes to PC gaming the xBox controller comes with everything needed to adapt from xBox over to PC. But for console gaming the gamecube controller is my favorite especially for games like super smash brothers melee.