Please take a look.
This CL was generated automatically.
The base::MayBlock() trait was specified for all call sites and the
base::TaskPriority::BACKGROUND trait was specified for all non-test call sites.
That may not be appropriate for your use case.
Please verify that appropriate traits were used
https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h
If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong.
Thanks.
- FAQ -
What if bots are red? Ignore this CL. A human will look at errors shortly.
What if the shutdown behavior is not set explicitly (no
base::TaskShutdownBehavior)?
If shutdown behavior is important for a task, it should be set explicitly.
It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or
SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in
SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler.
What if the task priority is not set explicitly (no base::TaskPriority)?
When there is no explicit priority, the priority is inherited from the
calling context (e.g. a task posted from a BACKGROUND task without an
explicit priority will have a BACKGROUND priority).

Description was changed from
==========
Use TaskScheduler instead of SequencedWorkerPool in
ios_component_updater_configurator.cc.
SequencedWorkerPool is being deprecated in favor of TaskScheduler.
BUG=667892
R=droger@chromium.org
==========
to
==========
Use TaskScheduler instead of SequencedWorkerPool in
ios_component_updater_configurator.cc.
SequencedWorkerPool is being deprecated in favor of TaskScheduler.
BUG=667892
R=droger@chromium.org
==========

On 2017/05/12 17:40:05, fdoray wrote:
> Please take a look.
>
> This CL was generated automatically.
>
> The base::MayBlock() trait was specified for all call sites and the
> base::TaskPriority::BACKGROUND trait was specified for all non-test call
sites.
> That may not be appropriate for your use case.
>
> Please verify that appropriate traits were used
> https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h
> If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's
wrong.
>
> Thanks.
>
> - FAQ -
>
> What if bots are red? Ignore this CL. A human will look at errors shortly.
>
> What if the shutdown behavior is not set explicitly (no
> base::TaskShutdownBehavior)?
> If shutdown behavior is important for a task, it should be set explicitly.
> It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or
> SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in
> SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler.
>
> What if the task priority is not set explicitly (no base::TaskPriority)?
> When there is no explicit priority, the priority is inherited from the
> calling context (e.g. a task posted from a BACKGROUND task without an
> explicit priority will have a BACKGROUND priority).
+rohitrao@chromium.org (no reply from droger in 1 week)