On 11/03/2010 04:06 PM, Jan Kara wrote:> On Mon 01-11-10 17:15:28, Tejun Heo wrote:> The patch looks OK to me as far as ext3, ext4, and reiserfs are> concerned. One thing I wondered about when I looked at it - does someone> use the 'mode' argument of the blkdev_put() function (well, apart from the> exclusive flag)? Because I've looked at a few random disk ->release()> functions and none of them used it...

Yeah, I thought about removing @mode and make blkdev_put() take@holder for exclusive releases. From what I can see, it doesn't seemlike any implementation cares but it's customary to have access to@mode on ->release(), so I decided to keep it. It's rather flaky asthere's no mechanism to check or enforce it tho.