*Re: [dpdk-dev] [PATCH v2 2/3] docs/guides: updating turbo_sw building steps
2019-06-06 10:34 ` Ferruh Yigit@ 2019-06-06 17:03 ` Chautru, Nicolas0 siblings, 0 replies; 58+ messages in thread
From: Chautru, Nicolas @ 2019-06-06 17:03 UTC (permalink / raw)
To: Yigit, Ferruh, thomas, akhil.goyal, dev; +Cc: Mokhtar, Amr
>-----Original Message-----
>From: Yigit, Ferruh
>Sent: Thursday, June 6, 2019 3:34 AM
>
>On 6/5/2019 9:10 PM, Nicolas Chautru wrote:
>> The documentation is clarified to point to steps on building the SDK
>> libraries which are now publicly available.
>>
>
>I can see new SDK link is in the documentation, but can you please put that information into the commit log too, to highlight it?
Fine with me.
>
>> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
>> ---
>> doc/guides/bbdevs/turbo_sw.rst | 84
>> +++++++++++++++++++++++-------------------
>> 1 file changed, 46 insertions(+), 38 deletions(-)
>>
>> diff --git a/doc/guides/bbdevs/turbo_sw.rst
>> b/doc/guides/bbdevs/turbo_sw.rst index 29f7ec9..196b3d6 100644
>> --- a/doc/guides/bbdevs/turbo_sw.rst
>> +++ b/doc/guides/bbdevs/turbo_sw.rst
>> @@ -1,26 +1,43 @@
>> .. SPDX-License-Identifier: BSD-3-Clause
>> Copyright(c) 2017 Intel Corporation
>>
>> -SW Turbo Poll Mode Driver
>> +SW FEC Poll Mode Driver
>
>There seems two groups of changes in this patch,
>- new SDK related changes,
>- and renaming 's/Turbo/FEC'
>For second one can you please put a brief description into commit log? Why Turbo needs to be FEC. (This even can be a separate patch)
>
Fair enough. Name could be more accurate as Turbo means so different things but this is fairly cosmetic and we can change this in a future patchset.
This would also require changes in the code which is not required now. So will put it back as before now.
>> =========================
>>
>> -The SW Turbo PMD (**baseband_turbo_sw**) provides a poll mode bbdev
>> driver that utilizes -Intel optimized libraries for LTE Layer 1
>> workloads acceleration. This PMD -supports the functions: Turbo FEC, Rate Matching and CRC functions.
>> +The SW FEC PMD (**baseband_turbo_sw**) provides a software only poll
>> +mode bbdev driver that can optionally utilize Intel optimized
>> +libraries for LTE and 5GNR Layer 1 workloads acceleration.
>
>Is 5GNR Layer 1 workloads acceleration available in this stage of the PMD?
>
The SDK provided on the link supports both standards and set of libraries and these how they are referred on the webpage : "FlexRAN LTE and 5G NR FEC Software Development Kit Modules".
Still if you reckon this is confusing given this current PMD only links to the 4G ones then I can remove any mention of 5GNR.
The related turbo_sw in patchwork v1 is extending this and hence documentation will eventually mention back 5GNR anyway. Will change now.
>> +
>> +Note that the driver can also be built without any dependency with
>> +reduced functionality for maintenance purpose.
>> +
>> +To enable linking to the SDK libraries see detailed installation section below.
>> +Two flags can be enabled depending on whether the target machine can
>> +support
>> +AVX2 and AVX512 instructions sets and the related SDK libraries for
>> +vectorized signal processing functions are installed :
>> +- CONFIG_RTE_BBDEV_SDK_AVX2
>> +- CONFIG_RTE_BBDEV_SDK_AVX512
>
>This flag is not available (yet), can you please remove from this doc and add with the patch that adds this flag?
No problem. The intention was to highlight where this is going with 2 sets of functionality depending on HW dependency as it is not necessarily obvious now that these are split into 2 patchsets.
But you are right that this can be rephrased to be limited to AVX2 for now.
Thanks
>
><...>
>
^permalinkrawreply [flat|nested] 58+ messages in thread