Activity

Here is the simple patch (and some screen shots) which I believe will resolve this issue for 1.9. In HEAD, Tim's work was part of a larger project but this request is pretty specific and makes sense to me. I've attached a before and after screen shot to demonstrate - user Tom Castillo is an example of one that has a user id before one of the other Castillos and thus does not get completely sorted. Let me know if there are any concerns (possibly performance or otherwise) about checking this in. Essentially, the same thing is in HEAD so it is just applying this particular part to 1.9 which seems pretty trivial to me but I wanted to double check. Peace - Anthony

Anthony Borrow
added a comment - 20/Oct/09 10:36 PM Here is the simple patch (and some screen shots) which I believe will resolve this issue for 1.9. In HEAD, Tim's work was part of a larger project but this request is pretty specific and makes sense to me. I've attached a before and after screen shot to demonstrate - user Tom Castillo is an example of one that has a user id before one of the other Castillos and thus does not get completely sorted. Let me know if there are any concerns (possibly performance or otherwise) about checking this in. Essentially, the same thing is in HEAD so it is just applying this particular part to 1.9 which seems pretty trivial to me but I wanted to double check. Peace - Anthony

Tim - Thanks you are right, the get_role_users function in /lib/accesslib.php has the firstname secondary sort as a default value so the patch I'm proposing for 1.9 was already implemented in 2.0. I've removed 2.0 as an affected branch. Peace - Anthony