No'Kaled's easily better dps than Souldrinker in practice as well as from the sim. Typically (416) No'Kaled procs account for about 6% of my damage while (416) Souldrinker procs account for about 2%, or a roughly 1200 dps difference. The 250ish strength on Souldrinker is only worth 350 or so DPS iirc. No'Kaled on Morchok, Hagara and Ultraxion compared to Souldrinker on the same bosses the week before. Think I was hit capped and soft exp capped on those bosses in both logs, if not then very close to.

As far as stamina scaling, the proc scales linearly with your hp (though not with the Baleroc hp buff - both weapons scale with Alys buff fwiw), so if with 200k hp it's worth roughly 600 dps, with 300k hp it'd be worth 900 dps. You'd need more HP than it's possible to obtain in this tier for it to get anywhere near to No'Kaled.

Edit: actually checking the weapon comparison chart again, the simmed gap between Souldrinker and No'Kaled seems a lot smaller than what I've seen in practice. Admittedly my sample size is fairly small at the moment but curious if I'm misinterpreting my logs or the sim's undervaluing No'Kaled or there's some other issue. At a guess it's because I'm wearing quite a bit less stamina than the gear set in the sim, and quite a bit more strength (in an actual fight).

Rhiannon wrote:Edit: actually checking the weapon comparison chart again, the simmed gap between Souldrinker and No'Kaled seems a lot smaller than what I've seen in practice. Admittedly my sample size is fairly small at the moment but curious if I'm misinterpreting my logs or the sim's undervaluing No'Kaled or there's some other issue. At a guess it's because I'm wearing quite a bit less stamina than the gear set in the sim, and quite a bit more strength (in an actual fight).

It may be the stamina, or it may be that our modeling of No'Kaled's proc is slightly off. Wowhead seems to indicate that each has its own proc spell, so it's possible that the proc rate is different for each version (iirc we never tested this).

<edit> Also, no wonder you had so little trouble beating my #1 parse. Up until this past weekend, I didn't have a heroic Souldrinker, and I still don't have any No'Kaled. I guess there's no point in trying again until I acquire one, if it's really 6% of your damage.

I got confused and thought the axe scaled with AP in some way, probably got it mixed up with the random trinkets. Now that I look at the logs again it definitely looks like a proc rate issue, as I'm seeing a similar number of No'Kaled procs to Souldrinker procs in kills of similar lengths despite it supposedly having less than half the proc rate (25 axe procs vs 25 drain life procs in 4:01/4:02 Hagara kills, 43 axe procs vs 43 drain life procs in 4:53/4:39 Ultraxion kills). I'll mess around on a dummy later and see if I can pin it down. Initial hunch is that when they "fixed" censure application (edit: seal of truth hits) proccing soul drinker and gurth they might have just fixed those two weapons and not done a class-wide mechanic change but that's just speculation (which wouldn't make a lot of sense from an overall design point of view either).

Rhiannon wrote:Initial hunch is that when they "fixed" censure application (edit: seal of truth hits) proccing soul drinker and gurth they might have just fixed those two weapons and not done a class-wide mechanic change but that's just speculation (which wouldn't make a lot of sense from an overall design point of view either).

I could definitely see that happening.

Regarding Stamina, I was pointing out that Souldrinker heals are based on max health, thus a low-stam gear set will weaken SD with respect to NK.

theckhd wrote:(...) it may be that our modeling of No'Kaled's proc is slightly off. Wowhead seems to indicate that each has its own proc spell, so it's possible that the proc rate is different for each version (iirc we never tested this).

It isn't, as far as I'm aware. It rolls twice for procs, one to determine if it is a proc or not, and another (conditional; assuming the first rolls out favorably) one to determine the specific damage effect.

Rhiannon wrote:Now that I look at the logs again it definitely looks like a proc rate issue, as I'm seeing a similar number of No'Kaled procs to Souldrinker procs in kills of similar lengths despite it supposedly having less than half the proc rate (25 axe procs vs 25 drain life procs in 4:01/4:02 Hagara kills, 43 axe procs vs 43 drain life procs in 4:53/4:39 Ultraxion kills).

I've looked at your logs too, there's nothing out of the ordinary. The sample sizes are nothing to brag about, we can't extract meaningful information from ~4m kills. If you find 1-2h to AFK-parse with NK, we'd be able to check its' proc chance.

"The specific bug was that paladins running Seal of Truth had two chances with every swing to trigger the proc with Gurthalak or Souldrinker. They now have one chance. "

This implies that seal of truth direct damage hits were proccing it, and don't any more, which is what actually happened from what I recall.

"Retribution was getting more than twice as many proc chances than we intended. This was caused by the application of Censure, not the dot itself ticking. "

This implies that hidden censure applications were proccing it. Unless I'm completely mistaken and they've got rid of those hidden censure applications with every attack, or rolled them into seal of truth hits?

Looking at how the sim handles it (though I'm mostly guessing what's going on), you're modelling SotR, CS, HotR, AS and auto-attack as being able to proc the weapons, but not seal of truth hits or judgement hits, correct? If my interpretation is correct then seeing two No'Kaled procs from one auto-attack and seal of truth hit would be sufficient to show that No'Kaled is behaving differently from Souldrinker? I've seen that twice so far while running a log on the dummy at least. I guess to be sure of the difference in behaviour I need to run a log of No'Kaled with just auto-attacks (no seal) and Souldrinker auto-attacks both with and without seal.

Look no further than the diff between r363/r366. Before the hotfix there were up to twice as many procs (depending on hit/exp; at 0% physical hit and 10 exp, for instance, AS triggered roughly 1.6 procs on average). The direct-damage component of SoT (the seal itself) wasn't the parasitic trigger, the application of Censure was.

Use a low-level dummy for 1h+, with AA+SoT, to check both the triggers and the proc chance of NK.