On 2011-03-10, at 12:40, Adam Barth wrote:
> On Thu, Mar 10, 2011 at 12:33 PM, Mark Rowe <mrowe at apple.com> wrote:
>> On 2011-03-10, at 12:27, Adam Barth wrote:
>>> On Thu, Mar 10, 2011 at 12:11 PM, Mark Rowe <mrowe at apple.com> wrote:
>>>> On 2011-03-10, at 12:08, David Levin wrote:
>>>>> tL;dr "Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests?"
>>>>>>>>>> Details:
>>>>> Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests).
>>>>>>>>>> Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be.
>>>>>>>> The SnowLeopard Leaks bot builds and tests the debug configuration.
>>>>>> The problem with the leaks bot is that it's always red. At the moment
>>> it has 10792 leaks.
>>>> Fixing the leaks would help address this, and is obviously beneficial in itself. It certainly didn't have anywhere near this number of leaks last week.
>> What's the best way to tack down when that regression occurred? I
> scrolled to the end of the waterfall for that builder
>>http://build.webkit.org/waterfall?last_time=1299183958&show=SnowLeopard%20Intel%20Leaks>> and the earliest build I could find had 10344 leaks.
Hrm. It used to be possible to track things down by looking at the historical results at <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/>, but we don't appear to keep the results for very long any more. It would be possible to build and bisect locally to track down when they were introduced. However, given the sheer volume of leaks I suspect it would be relatively easy for someone familiar with whatever code is leaking most prominently to track down the leak.
>>>> Would it be possible to report the leaks in a separate column than the test failures/crashes? That way I could look
>>> at the failures/crashes column and see at-a-glance whether I'd broken the Debug build.
>>>> Like most things, it's possible but not particularly easy.
>> Oh, I see that the bot turns golden when there are only leaks but no
> test failures. Can it turn green instead? (Or maybe have the column
> turn green but the leaks box turn gold?) I'm showing my buildbox
> ignorance.
I don't recall whether this is possible.
- Mark