On Wed, Nov 12, 2014 at 12:38:52PM -0800, Jeremy Allison wrote:
> On Tue, Nov 11, 2014 at 03:12:09PM +0100, Stefan (metze) Metzmacher wrote:
> > Hi Richard,
> >
> > if you want review the following patchset.
> >
> > The top 2 patches from
> > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky> > are not included because I haven't tested it with 'clang' instead of 'gcc'.
> > So in order force people using 'clang' to use '--disable-warnings-as-errors'
> > I just make sure that autobuild uses --picky-developer for now (when
> > building samba).
> >
> > Thanks!
>> FYI - I'm going through, reviewing and pushing these !
Got blocked on the early lib/tevent/tevent.c changes.
This is because lib/replace/replace.h doesn't include
unistd.h so there are many warnings/errors due to
missing definitions of things like STDIN_FILENO,
STDOUT_FILENO, STDERR_FILENO etc.
Can I get a second Team reviewer for the following ?
Cheers,
Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-replace-Ensure-replace.h-includes-unistd.h-if-it.patch
Type: text/x-diff
Size: 1232 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141112/3735f969/attachment.patch>