From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood@talktalk.net>
Cc: Git Mailing List <git@vger.kernel.org>,
"Brian M. Carlson" <sandals@crustytoothpaste.net>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v2 4/9] t3701: don't hard code sha1 hash values
Date: Tue, 20 Feb 2018 09:39:58 -0800
Message-ID: <xmqqk1v74l1t.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180219112910.24471-5-phillip.wood@talktalk.net>
Phillip Wood <phillip.wood@talktalk.net> writes:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> Purge the index lines from diffs so we're not hard coding sha1 hash
> values in the expected output.
The motivation of this patch is clear, but all-zero object name for
missing side of deletion or creation patch should not change when we
transition to any hash function. Neither the permission bits shown
in the output (and whether the index line has the bits are shown on
it in the first place, i.e. the index line of a creation patch does
not, whilethe one in a modification patch does).
So I am a bit ambivalent about this change.
Perhaps have a filter that redacts, instead of removes, selected
pieces of information that are likely to change while hash
transition, and use that consistently to filter both the expected
output and the actual output before comparing?