The main dialogue code is attached - the gtkdialog call is on line 659 and the initial startup window is defined on line 515

If I run snap2 in a terminal in Upup Precise 54x4 with gtkdialog version 0.8.3 r473M (C) 2003-2007 Laszlo Pere, 2011-2012 Thunor Built with additional support for: Glade.....
I get the following errors and the main dialogue window does not open

Code:

widget_entry_refresh(): <label> not implemented for this widget.
widget_entry_refresh(): <label> not implemented for this widget.
widget_entry_refresh(): <label> not implemented for this widget.
widget_combobox_input_by_command(): <input> not implemented for this widget.

If I run it in a terminal in Slacko 5.3.9.5 with gtkdialog version 0.8.2 r455M (C) 2003-2007 Laszlo Pere, 2011-2012 Thunor Built with additional support for: Glade, VTE.....
I get the same errors but the main dialogue window does appear and seems to work.

If I run it in a terminal in Puppy Precise 5.4.2 or Slacko 5.3.3 with gtkdialog version 0.8.0 (C) 2003-2007 Laszlo Pere, 2011 Thunor...........
then the errors do not appear.

Can anybody suggest what gtkdialog constructs might have changed between the different versions that I might need to look at to track down this problem - many thanks.

...
If I run snap2 in a terminal in Upup Precise 54x4 with gtkdialog version 0.8.3 r473M (C) 2003-2007 Laszlo Pere, 2011-2012 Thunor Built with additional support for: Glade.....
I get the following errors and the main dialogue window does not open

Code:

widget_entry_refresh(): <label> not implemented for this widget.
widget_entry_refresh(): <label> not implemented for this widget.
widget_entry_refresh(): <label> not implemented for this widget.
widget_combobox_input_by_command(): <input> not implemented for this widget.

If I run it in a terminal in Slacko 5.3.9.5 with gtkdialog version 0.8.2 r455M (C) 2003-2007 Laszlo Pere, 2011-2012 Thunor Built with additional support for: Glade, VTE.....
I get the same errors but the main dialogue window does appear and seems to work.

If I run it in a terminal in Puppy Precise 5.4.2 or Slacko 5.3.3 with gtkdialog version 0.8.0 (C) 2003-2007 Laszlo Pere, 2011 Thunor...........
then the errors do not appear.

Can anybody suggest what gtkdialog constructs might have changed between the different versions that I might need to look at to track down this problem - many thanks.
...

I've been refactoring the code and moving stuff that was everywhere into its own file based on a template. If a widget doesn't support a directive then you'll get a warning message but it's just a warning. In this case the fileselect function is using the entry widget's label directive to store the text that's displayed in the title of the fileselect dialog, but that was the old way to do it and it's still supported although the template isn't compensating for that which I only recently noticed. Technically the entry widget does not support the label directive so I'd rather leave it as is because there is a better and more consistent way to store the text which is with the fs-title custom tag attribute.

If you want to remove these warnings then:
Move the "Select a Directory" text at line 478 into the entry tag using fs-title=\"Select a Directory\" and delete the <label></label>.
Do the same at lines 500 and 517.

The combobox warning message is interesting. The combobox widget does not support the input directive and in fact there is an example in examples/combobox/combobox_input which states this -- maybe it was going to be implemented and an example was created for it but it wasn't -- and within the snap2 code at line 631 is "<input>ls</input>" which I'm guessing was copied and pasted from the broken example so just remove it. It was never implemented but warning messages are a new feature therefore the original developer simply left it in because I guess he forgot it was there.

I don't like the fact that the window doesn't show on Upup Precise 54x4 with gtkdialog version 0.8.3 r473. I suggest checking out the latest gtkdialog version from SVN which is now at r493. I'm going to try it myself.

...
I noticed that pdvdrsab didnt work with previous gtkdialog version either. I hope this version is more compliant.
...

Hi pemasu

I'm currently playing with Upup Precise 54X4 (which is very nice so thank you) and pdvdrsab shows but there's no DVD drive listed although I do have one at /dev/sr0 (CD/DVD Drive Wizard also agrees). The code that is responsible for this is at line 103 and it won't result in anything because it's grepping for "cd-*rom" when probedisk isn't outputting text like that. There are also four dialogs in there which are launched with missing variable directives and the closewindow code is invalid so the quit buttons don't work. I haven't tried ripping anything. I think that the application requires some maintenance. Is anyone maintaining it? These issues are application issues, they are not gtkdialog issues.

snap2 shows for me. I get an initial small dialog saying "Warning: there are missing programs..." and then I get the main dialog so I've tested it to show which is what I wanted.

It sure would make life a lot easier if somebody would create a repository for Puppy apps so that folk can fix these things at source. Then Puppy releases would simply take the source from the repository rather than having modified gzipped apps, patch files and code posted in threads that may or may not get somebody's attention. It could be a great deal easier to maintain this stuff -- just a suggestion, I'm not being critical.

Anway, Rocket's version of pdvdrsab works fine, I've just ripped 100MB of a DVD to test and there are no compliancy issues so I'm going away now

If you want to remove these warnings then:
Move the "Select a Directory" text at line 478 into the entry tag using fs-title=\"Select a Directory\" and delete the <label></label>.
Do the same at lines 500 and 517.

The combobox warning message is interesting. The combobox widget does not support the input directive and in fact there is an example in examples/combobox/combobox_input which states this -- maybe it was going to be implemented and an example was created for it but it wasn't -- and within the snap2 code at line 631 is "<input>ls</input>" which I'm guessing was copied and pasted from the broken example so just remove it.

Hi Thunor

Many thanks for the patches which I can confirm get rid of the warning messages.

However they unfortunately don't make snap2 work on Upup Precise 5.4.X.4

The difference with Slacko 5.4 where Snap2 4.25 does work correctly is that a warning box appears instead of the main window when Snap2 is started and when the warning box is closed the main window opens but on tab #2 and if tab #1 is clicked the warning box reappears.

So Snap2 4.25 is still behaving inconsistently on 2 modern Puppies both with modern but different versions of gtkdialog....

I haven't tried your even newer version of gtkdialog yet....maybe pemasu can see how Snap2 works on his new Upup Precise 5.4.X.n - or I can test when he uploads it.

...
However they unfortunately don't make snap2 work on Upup Precise 5.4.X.4

The difference with Slacko 5.4 where Snap2 4.25 does work correctly is that a warning box appears instead of the main window when Snap2 is started and when the warning box is closed the main window opens but on tab #2 and if tab #1 is clicked the warning box reappears.

So Snap2 4.25 is still behaving inconsistently on 2 modern Puppies both with modern but different versions of gtkdialog....

I haven't tried your even newer version of gtkdialog yet...

What is the text within the initial warning box?

There are six tabs within the main window and they all have text on them, so it's not possible to identify what you mean by tab #2 and tab #1. What is the text on tab #2? What is the text on tab #1?

What is the text within the warning box that shows when clicking tab #1?

Thanks for that. I've installed snap2 v4.25 from here and I've started it up in Upup Precise 54x4 with gtkdialog version 0.8.3 r493 and I don't see that message box.

I've looked through the snap2 code and I've read your post to lstandish.

As I've said before, all the gtkdialog code has been gradually moving across to using a new template that warns developers if they use directives that aren't supported for certain widgets which is a good thing because it helps to catch things like that unsupported combobox <input>ls</input> sitting there dormant waiting to explode when I implement <input> for that widget (I won't though because it's too old and deprecated). This is fine except that I have seen developers using:

Code:

eval `gtkdialog -p MAIN_DIALOG`

or similar which evaluates everything sent to stdout which could be anything from anywhere. I can see that the following code:

is being used in several places within the snap2 source code so I would recommend modifying that at least for you to test. You should try adding " | grep =" to the end of the GKDIALOG part so that you'll get something like:

You cannot post new topics in this forumYou cannot reply to topics in this forumYou cannot edit your posts in this forumYou cannot delete your posts in this forumYou cannot vote in polls in this forumYou cannot attach files in this forumYou can download files in this forum