Ticket #323 (Fixed)Wed Oct 24 12:50:00 UTC 2012

Title bar not highlighted correctly when running single-tasking programs on RPi

Reported by:

Jeffrey Lee (213)

Severity:

Minor

Part:

RISC OS: Module

Release:

Milestone:

Status

Fixed

Details by Jeffrey Lee (213):

I’m making a note of this on the bug tracker, before I inevitably forget to do any further investigation myself.

One thing I spotted a few days ago when testing on the Pi distro was that the window that pops up when you run a single-tasking app (e.g. a simple ‘PRINT “FOO”’ in a BASIC file) doesn’t have the title bar highlighted correctly. The title bar was grey, as if the window didn’t have focus, but it looked like the font had been blended with a yellow background, as if it was expecting the yellow title bar sprites to be used.

My hunch is that this is a bug caused by the keyboard shortcuts in the filer; the filer window I launched the app from still had its focus, with yellow title bar and correct text. And testing on my Iyonix (using a ROM from before the shortcuts were introduced) showed the correct behaviour (app should have yellow title bar to indicate it has focus). However I haven’t yet checked with a filer shortcut ROM on my Iyonix, to determine whether it’s a filer shortcut issue or something specific to the Pi.

Changelog:

Modified by Sprow (202) Wed, October 24 2012 - 19:38:41 GMT

In the case of the RPi it’s most likely to be the nonstandard toolsprites – part of the reason why they’re only offered in ROM until this (and some other) issues are sorted.

You should find error boxes are also wrongly highlighted, and menus with writable icons in too (except that’s the otherway round, they shouldn’t be yellow).

It’s all to do with the toolsprites being opaque (whereas the ‘NewLook’ and ‘Iyonix’ ones use transparent pixels) and some magic the Wimp does with some special classes of window. Ben Avison knew the gritty details, I’m very much paraphrasing here.

To confirm if this is the case, set Wimp$IconTheme somewhere in PreDesk to swap a different theme (eg. Ursula) and rerun the PRINT"FOO" test.

Modified by Jeffrey Lee (213) Wed, October 24 2012 - 20:31:05 GMT

Yes, it does look like it’s a problem specific to the Pi’s theme – testing on my Iyonix with a recent ROM results in the single-tasking window being rendered correctly.

The fact that the filer window retains its yellow highlight while the single-tasking app is running is a red herring I think, since there’s no easy way the Wimp could take the focus away from the filer and redraw its window while the single-tasking app is active. The same dual highlighting is also visible if you use a pre-filer shortcut ROM and leave the focus in a text editor while running the single tasking app.

Modified by Sprow (202) Sat, December 15 2012 - 09:45:42 GMT

Summary changed from Title bar not highlighted correctly when running single-tasking programs to Title bar not highlighted correctly when running single-tasking programs on RPi