When demoing an app, it is important to ensure that the user has the headset on properly. This PR adds a scene that shows a border at the edge of the user's field of view and instructs him/her to adjust the headset until all four edges are visible. The user (or the demonstrator) can then air-tap or say "I'm ready" to proceed to the actual experience. The next scene is then loaded and the experience may begin. This next scene is determined by either the scene build order in the Unity Build Settings dialog or by explicitly specifying the scene name that follows.

This comment has been minimized.

The documentation for SceneManager.LoadScene isn't clear about what happens if the provided sceneBuildIndex is out of range. Do we need to be defensive against the edge-case where the HeadsetAdjustment scene is the only (or last) scene in the build?

edited

Edited 1 time

thebanjomatic edited Mar 3, 2017 (most recent)

Contributor

The documentation for SceneManager.LoadScene isn't clear about what happens if the provided sceneBuildIndex is out of range. Do we need to be defensive against the edge-case where the HeadsetAdjustment scene is the only (or last) scene in the build?

This comment has been minimized.

It throws an exception. I decided not to be defensive about this, since the exception thrown by Unity itself is clear enough, and the property's description clearly points to what went wrong. Repeating / rephrasing the exception wouldn't have added much.

It throws an exception. I decided not to be defensive about this, since the exception thrown by Unity itself is clear enough, and the property's description clearly points to what went wrong. Repeating / rephrasing the exception wouldn't have added much.

StephenHodgson edited Mar 3, 2017 (most recent)

This comment has been minimized.

For some reason I am having a really hard time focusing on the text its making me go cross-eyed. It looks like the text is being placed 177.3 meters in front of you. I'm also experiencing issues with the outline fading out in the corners because of how thin the lines are and the way the display does that rainbow effect.

For some reason I am having a really hard time focusing on the text its making me go cross-eyed. It looks like the text is being placed 177.3 meters in front of you. I'm also experiencing issues with the outline fading out in the corners because of how thin the lines are and the way the display does that rainbow effect.

This comment has been minimized.

@vbandi Just loading that project in 5.6 introduced a bunch of changes that I wasn't expecting so it looks like I will need to install 5.5 before making that pull request. I'll try to get that done tomorrow.

@vbandi Just loading that project in 5.6 introduced a bunch of changes that I wasn't expecting so it looks like I will need to install 5.5 before making that pull request. I'll try to get that done tomorrow.

StephenHodgson edited Mar 6, 2017 (most recent)

This comment has been minimized.

Yeah, 5.6 has been in beta for a little while and is scheduled to be released on the 31st. Unfortunately I don't have enough storage to spare on my machine to install both 5.5 and 5.6 so I've just been running with the beta. What can I say, I like life on the bleeding edge!

Yeah, 5.6 has been in beta for a little while and is scheduled to be released on the 31st. Unfortunately I don't have enough storage to spare on my machine to install both 5.5 and 5.6 so I've just been running with the beta. What can I say, I like life on the bleeding edge!

This comment has been minimized.

@NeerajW If you don't agree with my argument below, I'll move this under Utilities\Tests\Scenes as requested.

Having an entire scene as a building block is new to the HoloToolkit, but I feel that putting it under Utilities/Scenes is the right thing to do.

I put it under Scenes because it is not a test scene for a prefab or a script, but is supposed to be used as a whole scene. The Utilities\Tests\Scenes would suggest that this is an example or test playground on how to use another part of the toolkit. But HeadsetAdjustment is a stand alone building block.

Developers are not forced to use it, they can select what scenes are in their project in the Build Settings dialog. It is not even included by default.

@NeerajW If you don't agree with my argument below, I'll move this under Utilities\Tests\Scenes as requested.

Having an entire scene as a building block is new to the HoloToolkit, but I feel that putting it under Utilities/Scenes is the right thing to do.

I put it under Scenes because it is not a test scene for a prefab or a script, but is supposed to be used as a whole scene. The Utilities\Tests\Scenes would suggest that this is an example or test playground on how to use another part of the toolkit. But HeadsetAdjustment is a stand alone building block.

Developers are not forced to use it, they can select what scenes are in their project in the Build Settings dialog. It is not even included by default.