This comment has been minimized.

Hello, thanks for this PR. I’m not at the computer right now. Can you
please apply the opposite strategy? To require sassc only when a .sass file
is detected.
Requiring sassc that way was clearly a mistake. I want to keep this gem
free from that runtime dep in the gemspec.
Thanks.

This comment has been minimized.

I'm disappointed that the implementation #102 is thought of as a mistake. I want to make this right 🙂

As @glaszig noted in his #102 comment, Tilt does attempt to load SassC, but falls back to Sass if that library is not available. With SassC listed only as a development dependency of this library, it seems likely that it will often not be available. With Sass being beyond end-of-life, what's the reason for not wanting SassC as a runtime dependency?

This comment has been minimized.

@landongrindheim The rationale behind not requiring sassc as a runtime dependency is that people can use hanami-assets without using Sass at all. It's not about Sass vs SassC, it's more like Sass vs Less or people who want to use hanami-assets for JS but not stylesheets.

I'm not sure this is a bug, I might be missing something though. Users will have to change gem 'sass' to gem 'sassc' in order for this to work (and run bundle install). Did you do that at @glaszig? I couldn't tell from your comment on #102 whether you made that change.

This comment has been minimized.

Users will have to change gem 'sass' to gem 'sassc' in order for this to work (and run bundle install). Did you do that at @glaszig? I couldn't tell from your comment on #102 whether you made that change.

sure i did that. after it blew up in my face. i naivly upgradet to 1.3.2 because it was a patch-level version bump and nothing indicated (to me, fwiw), that something else needs to be changed.

This comment has been minimized.

i naivly upgradet to 1.3.2 because it was a patch-level version bump and nothing indicated (to me, fwiw), that something else needs to be changed.

Sorry for not meeting your expectations. I was torn about switching from sass to sassc suddenly, in a patch level release. For a second I thought to release that change as 2.0.0, not to 1.3.2, but then I realized that this isn't an API change. An external dependency ceased to exist (sass) and a new one is replacing it (sassc). If we need to bump major release anytime SASS or any other compiling lib changes that will get potentially out of control.

So I feel good that we picked 1.3.2, it should've been not requiring sassc regardless of people using it or not.

This comment has been minimized.

i wanted but there‘s the dependencies method that needs the „engine“ directly and there‘s elegent way to get to that through tilt other than `instance_variable_get` and that‘s ugly, so.
what exactly does #dependencies do?

This is in response to a bug which was pointed out in
hanami#106. We added `require 'sassc'`,
which turned out to be a breaking change. If a user doesn't have `sassc`
listed in their Gemfile, they'll get load errors.
In order to resolve this, I'm opting to wrap both `SassC` and `Sass`,
with the idea that we can remove the reliance on `Sass` soon (the
sass-ruby gem is past end-of-life).

This comment has been minimized.

I opened #108 as an alternative approach. In that PR, I opted to wrap the gems, doing something along the lines of what Tilt is does. Totally fine with closing it since this PR was open first and may be the preferred approach 😄 Just let me know!

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.