Commit Message

This is a version of of_irq_to_resource() that propagates the precise
error code instead of returning 0 for all errors. It will be used in
subsequent patches to allow further propagation of error codes.
To avoid code duplication, implement of_irq_to_resource() as a wrapper
around the new __of_irq_to_resource().
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/of/irq.c | 33 +++++++++++++++++++++++++--------
1 file changed, 25 insertions(+), 8 deletions(-)

On Mon, Sep 16, 2013 at 11:29 PM, Rob Herring <robherring2@gmail.com> wrote:
> On 09/16/2013 03:32 AM, Thierry Reding wrote:>> This is a version of of_irq_to_resource() that propagates the precise>> error code instead of returning 0 for all errors. It will be used in>> subsequent patches to allow further propagation of error codes.>>>> To avoid code duplication, implement of_irq_to_resource() as a wrapper>> around the new __of_irq_to_resource().>> I think the callers in this case are manageable to update as well.> Several cases could simply use irq_of_parse_and_map instead as they just> pass in a NULL resource.
I second this comment.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Mon, Sep 23, 2013 at 09:20:37PM +0200, Linus Walleij wrote:
> On Mon, Sep 16, 2013 at 11:29 PM, Rob Herring <robherring2@gmail.com> wrote:> > On 09/16/2013 03:32 AM, Thierry Reding wrote:> >> This is a version of of_irq_to_resource() that propagates the precise> >> error code instead of returning 0 for all errors. It will be used in> >> subsequent patches to allow further propagation of error codes.> >>> >> To avoid code duplication, implement of_irq_to_resource() as a wrapper> >> around the new __of_irq_to_resource().> >> > I think the callers in this case are manageable to update as well.> > Several cases could simply use irq_of_parse_and_map instead as they just> > pass in a NULL resource.> > I second this comment.
That should be fixed in v2 of the series that I posted a few days ago.
Thierry