Comments

Media Controls: create popup menu element, base for text track/overflow lists.
This is introducing MediaControlPopupMenuElement as a base class. At
the moment, the class handles positioning of the popup and some basic
visibility. It's also cleaning up a bit of code around popup menus.
This new class will allow the introduction of an event handler to deal
with keyboard events on both popup menus.
Bug: 821131
Change-Id: I19ad4193b5ccbd6acd3c59c35701e32c91e634c6
Reviewed-on: https://chromium-review.googlesource.com/1005334
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549712}

[KeyboardLock] Updating Mojo service impl to return error codes

Comments

[KeyboardLock] Updating Mojo service impl to return error codes
The previous KeyboardLockService implementation always returned success
even when no KeyboardLock request was registered due to an error. This
CL adds errors for two known error conditions which are now communicated
back to javascript by rejecting the promise. The messages passed are
meant to help developers as they are building their website, they are not
something that can/should be used post-development (i.e. they represent
unrecoverable errors).
BUG=680809
Change-Id: I7748d0f0c7b8688b4e945e6aa349d75b2a9757ca
Reviewed-on: https://chromium-review.googlesource.com/1003216
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549716}

[KeyboardLock] Updating API to reject the first promise if lock is called twice

Comments

[KeyboardLock] Updating API to reject the first promise if lock is called twice
Per the W3C spec, when navigator.keyboard.lock() is called a second time (or
more), any previous, pending promises should be rejected. The old behavior
of the API was to reject the newest promise which is not correct.
As part of this cleanup, I am also using DomExceptions instead of raw strings
for the rejection. This allows us to clean up the test code (which fails if
a raw string is returned in the reject call).
BUG=680809
Change-Id: Ic4f2563a6ccc22a434f8e6079f1995d9e584f9aa
Reviewed-on: https://chromium-review.googlesource.com/1003472
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549719}

Media Controls: Do not update the time if we are hidden

Comments

Media Controls: Do not update the time if we are hidden
If the panel is hidden then we should not update the current time
unnecessarily.
BUG=821961,821414
Change-Id: I5c3fed448c52edfb14570d5e2e164c56e4747672
Reviewed-on: https://chromium-review.googlesource.com/1006068
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549720}