Jesse, they do - but I am not sure why. Problem is I don't fully
understand what is going on there... which is why I am hesitant to
just ignore it.

Advertising

> The tests pass on my machine if I would change <TargetPlatformVersion> to
10.0.15063.0 (I don't have the old target platform SDK installed with VS
2017 and don't intend to add it there)
Chris, where and how exactly does one install the "target platform SDK"?
What happens if you do not change the `TargetPlatformVersion` manually
but have only that one installed?
> It is though the AppVeyor tests that Jan
already discovered some fixes that were needed for VS 2017, if I am not
mistaken. @Jan can you explain this further or am I mistaken somehow?
VS2017 did not exist at the time of the last release (or at least
nobody cared) so CI didn't use it to test. This should have been added
earlier, but I only added it 3 weeks ago with
https://github.com/apache/cordova-windows/commit/f5f4b21ad2c030ff61550bc947dca196c570f0ad
- which then showed this bug. (If any of the other failures that were
then fixes also were caused only by VS2017 I can not say
unfortunately)
J
2018-02-09 17:24 GMT+01:00 Chris Brody <chris.br...@gmail.com>:
> P.S. I would not favor making a major version release before resolving the
> CI issue on AppVeyor somehow. It is though the AppVeyor tests that Jan
> already discovered some fixes that were needed for VS 2017, if I am not
> mistaken. @Jan can you explain this further or am I mistaken somehow?
>
> On Fri, Feb 9, 2018 at 11:17 AM, Chris Brody <chris.br...@gmail.com> wrote:
>
>> The tests pass on my machine if I would change <TargetPlatformVersion> to
>> 10.0.15063.0 (I don't have the old target platform SDK installed with VS
>> 2017 and don't intend to add it there)
>>
>> On Fri, Feb 9, 2018 at 11:12 AM, Jesse <purplecabb...@gmail.com> wrote:
>>
>>> Do the tests pass on your machines? If so, I think we should move forward
>>> with the 6.0.0 release, and write this off as a CI environment issue.
>>>
>>> On Feb 9, 2018, at 7:45 AM, Jan Piotrowski <piotrow...@gmail.com> wrote:
>>>
>>> >> I wonder if we should also consider CB-12499 to be breaking,
>>> considering
>>> >> that Default.rd.xml triggers the test failure on AppVeyor.
>>> >
>>> > No. "Breaking" (in context of semver) refers to changing existing
>>> > functionality to not work any more or work differently.
>>> > CB-12499 just seems "broken" right now.
>>> >
>>> > It introduces a new file and "link" to it in the Win10 project template:
>>> > https://github.com/apache/cordova-windows/pull/228/files And that file
>>> is
>>> > now causing issues with the test run with VS2017 on AppVeyor.
>>> >
>>> > We now just have to get the test working and pass or revert that change
>>> for
>>> > now because we can't get it to work properly.
>>> > (In https://issues.apache.org/jira/browse/CB-13834 I mentioned the 2
>>> people
>>> > involved in merging that functionality, maybe they can say more about it
>>> > over there).
>>> >
>>> >> All tests are enabled now right?
>>> >> Or am I mistaken?
>>> >
>>> > Yes.
>>> > No.
>>> >
>>> > -J
>>> >
>>> >
>>> > 2018-02-09 15:36 GMT+01:00 Chris Brody <chris.br...@gmail.com>:
>>> >
>>> >> I wonder if we should also consider CB-12499 to be breaking,
>>> considering
>>> >> that Default.rd.xml triggers the test failure on AppVeyor.
>>> >>
>>> >> All tests are enabled now right? Or am I mistaken?
>>> >>
>>> >> On Thu, Feb 8, 2018 at 12:49 PM, Jan Piotrowski <piotrow...@gmail.com>
>>> >> wrote:
>>> >>
>>> >>> All that change existing functionality a user could depend on.
>>> >>>
>>> >>> In this case:
>>> >>> https://issues.apache.org/jira/browse/CB-13237
>>> >>> Possibly also the ones disabling the tests (which happened before that
>>> >> one,
>>> >>> otherwise this would have been caught)
>>> >>>
>>> >>> J
>>> >>>
>>> >>> 2018-02-08 17:06 GMT+01:00 Chris Brody <chris.br...@gmail.com>:
>>> >>>
>>> >>>> Can someone explain exactly which changes in the master branch should
>>> >> be
>>> >>>> considered "breaking"?
>>> >>>>
>>> >>>
>>> >>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org