You harvest them when they are dry on the plant. If they are still green, they might not be mature yet. If you are collecting them to use in cooking, I would still wait for them to turn brownish; the ones in the spice jars don't look very green. I don't bother with collecting seeds because they self seed with wild abandon in my vegetable garden, along with the dill and Italian parsley....