I think removing the flush is fine. The file will get closed when the application finishes, so the only issue is that if the NM crashes badly more logs may be lost then before. I am +1. It a small change that reduces the load on the NN. I'll check it in.

Robert Joseph Evans
added a comment - 06/Nov/12 18:27 I think removing the flush is fine. The file will get closed when the application finishes, so the only issue is that if the NM crashes badly more logs may be lost then before. I am +1. It a small change that reduces the load on the NN. I'll check it in.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 06/Nov/12 18:43 -1 overall . Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552193/yarn-202.patch
against trunk revision .
+1 @author . The patch does not contain any @author tags.
-1 tests included . The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac . The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc . The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse . The patch built with eclipse:eclipse.
+1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit . The applied patch does not increase the total number of release audit warnings.
+1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
+1 contrib tests . The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-YARN-Build/134//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/134//console
This message is automatically generated.