It seems like $featured_index can also be of type string and false; however, parameter $priority of ElggMenuItem::setPriority() does only seem to accept integer, maybe add an additional type check?
( Ignorable by Annotation
)

If this is a false-positive, you can also ignore this issue in your code via the ignore-type annotation