tests updatelocks and updatelocksJDBC30.sql are not run anywhere; should get evaluated

Details

Description

I noticed the tests store/updatelocks.sql and store/updatelocksJDBC30.sql are not in use.
They should get evaluated for inclusion in the tests - they should either get included - and preferably converted to junit - or get deleted.

Activity

I started with just running the tests and updatelocksJDBC30.out only diffed from the master in that is now license header information in the output, so I updated the master with revision 741687.
However, updatelocks shows a number of different locking rows. I don't know whether there is a bug hiding here or no, and would appreciate someone who might know to take a look.
Attaching a patch that shows the new output.

Myrna van Lunteren
added a comment - 06/Feb/09 19:30 I started with just running the tests and updatelocksJDBC30.out only diffed from the master in that is now license header information in the output, so I updated the master with revision 741687.
However, updatelocks shows a number of different locking rows. I don't know whether there is a bug hiding here or no, and would appreciate someone who might know to take a look.
Attaching a patch that shows the new output.

checked in new master and added to the store nightly suite. Am resolving it, if someone wants to convert this test open another issue. Converting the test would not be too hard, just need to be able to queries on the lock
table. It actually will be much cleaner as a converted test as it uses "sub" scripts which really want to be program calls to a single routine after varying the setup. The problem is that calling the single routine
returns different expected results based on the setup.

Mike Matrigali
added a comment - 09/Jun/09 18:25 checked in new master and added to the store nightly suite. Am resolving it, if someone wants to convert this test open another issue. Converting the test would not be too hard, just need to be able to queries on the lock
table. It actually will be much cleaner as a converted test as it uses "sub" scripts which really want to be program calls to a single routine after varying the setup. The problem is that calling the single routine
returns different expected results based on the setup.