ABI field should be ignored when creating an AVD if not relevant

Details

Description

Currently it's not simple to create a matrix job which includes 2.x AVDs as well as 4.x AVDs, since the former don't require an ABI, but the latter do.

So if you enter the ABI "armeabi-v7a" in the job configuration, this will be used even when trying to generate the 2.x AVDs, which will fail. Conversely, if you don't enter an ABI, the 2.x AVDs will be generated correctly, but the 4.x ones will fail.

We should not pass the "--abi" flag to "android create avd" if the platform version doesn't support ABIs.

–
You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

I am getting NOT_BUILT with this since the 2.3.3 api has multiple abi targets and i believe its being ignored with the fix for this issue, running android list targets has this in it, and as you can see ABIs has multiple entries:

Stoyan Gaydarov
added a comment - 2013-04-26 18:50 I am getting NOT_BUILT with this since the 2.3.3 api has multiple abi targets and i believe its being ignored with the fix for this issue, running android list targets has this in it, and as you can see ABIs has multiple entries:
id: 15 or "android-10"
Name: Android 2.3.3
Type: Platform
API level: 10
Revision: 2
Skins: HVGA, QVGA, WQVGA400, WQVGA432, WVGA800 (default), WVGA854
ABIs : armeabi, x86
Because of this i get the following error:
There is more than one system image defined for platform 'android-10'.
Pick an image to use and set it in the 'Target ABI' config field.
Valid ABIs: armeabi, x86
Even though my matrix build actually has armeabi set as the target abi

Google now host the x86 ABI for android-10 rather than Intel,
in the process making it a proper system-image rather than an
add-on. This caused problems with determining if the configured
AVD required an ABI, so now we add some more special handling
for this case.

SCM/JIRA link daemon
added a comment - 2013-05-17 17:58 Code changed in jenkins
User: Christopher Orr
Path:
src/main/java/hudson/plugins/android_emulator/Constants.java
src/main/java/hudson/plugins/android_emulator/EmulatorConfig.java
src/main/java/hudson/plugins/android_emulator/SdkInstaller.java
http://jenkins-ci.org/commit/android-emulator-plugin/485d72b223982e91cc627c02d5ca943ee2eb5345
Log:
[FIXED JENKINS-14741] Allow for the x86 ABI for android-10.
Google now host the x86 ABI for android-10 rather than Intel,
in the process making it a proper system-image rather than an
add-on. This caused problems with determining if the configured
AVD required an ABI, so now we add some more special handling
for this case.