On Mon, 2003-06-30 at 01:17, Rusty Russell wrote:> Yeah, but I was trying to get you to do more work. And if the names> resulting are useless anyway, why apply the patch?

I noticed.

However, not printing empty names makes the trace a lot more useful. Just doing a symbolic trace on modules on x86, I see pretty much thecorrect call trace now.

But, I'll investigate and see if I can find a way of generically tellingif a particular symbol is useful or not.

> > Perhaps there should be a per-arch hook for purging the symbol tables of> > irrelevant symbols before we do kallsyms lookups in it?> > I think you can do it easily in module_finalize... or if we were> ambitious we'd extract only the function symbols rather than keeping> the whole strtab and symtab.

Apart from the dubious writing to a const * pointer, yes I can (it'swhat I'm doing now). There is some annoyance in that module_finalizeisn't told where the string or symbol tables are, so I have to find themagain.