lucene-dev mailing list archives

[jira] [Updated] (LUCENE-2548) Remove all interning of field names from flex API

Date

Mon, 20 Jun 2011 15:02:47 GMT

[ https://issues.apache.org/jira/browse/LUCENE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-2548:
---------------------------------------
Attachment: LUCENE-2548.patch
Initial patch.
Tests are passing, at least a few iterations (I'll beast it). There are still a few nocommits...
I used PMD and findbugs to find == and != on strings, but surprisingly there are cases that
these tools seem to miss. I also did various greps to try to find cases... but I'm sure I've
missed some!
> Remove all interning of field names from flex API
> -------------------------------------------------
>
> Key: LUCENE-2548
> URL: https://issues.apache.org/jira/browse/LUCENE-2548
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Michael McCandless
> Fix For: 4.0
>
> Attachments: LUCENE-2548.patch
>
>
> In previous versions of Lucene, interning of fields was important to minimize string
comparison cost when iterating TermEnums, to detect changes in field name. As we separated
field names from terms in flex, no query compares field names anymore, so the whole performance
problematic interning can be removed. I will start with doing this, but we need to carefully
review some places e.g. in preflex codec.
> Maybe before this issue we should remove the Term class completely. :-) Robert?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org