]]>
Do not call into formfiller code with a NULL PageView.Lei Zhang <thestig@chromium.org>Fri, 2 Oct 2015 21:01:37 +0000http://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=ac67d4765a8ac36cd00c9fc8b6f2b80a3e1cff72http://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=ac67d4765a8ac36cd00c9fc8b6f2b80a3e1cff72
Do not call into formfiller code with a NULL PageView.
Do not call into formfiller code with a NULL PageView.
BUG=537173
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1376093002 .

]]>
Tidy up CPDFDOC_Environment.Tom Sepez <tsepez@chromium.org>Thu, 16 Jul 2015 18:09:12 +0000http://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=fb07e2843dad0774d5842c2b08e7792164efc14ahttp://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=fb07e2843dad0774d5842c2b08e7792164efc14a
Tidy up CPDFDOC_Environment.
Tidy up CPDFDOC_Environment.
- untabify as encountered.
- Only put single-statement method in .h file, move more
complex methods to .cpp (counting an if without braces as
a single statement, killing braces as needed).
- Move invariant arguments to constructor and make
corresponding members const.
- Make all members private and add accessor methods.
- Make existing accessor methods const where possible.
- Kill meaningless asserts.
- Add helper functions in place of duplicate code.
- Rename GetCurrentDoc() to GetSDKDocument(), since the class
has two document members, one of CPDF_Document and one of
CPDFSDK_Document, making it clear which one you get.
- Simplify some logic with early returns.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1235393002 .

]]>
Cleanup: Get this rid of "this->" in fpdfsdk/Lei Zhang <thestig@chromium.org>Thu, 11 Jun 2015 20:03:09 +0000http://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=eda202769e5c79eba1d2fb5090f6e9cf176e2d4ahttp://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=eda202769e5c79eba1d2fb5090f6e9cf176e2d4a
Cleanup: Get this rid of "this->" in fpdfsdk/
Cleanup: Get this rid of "this->" in fpdfsdk/
Also remove commented out code and trailing whitespaces.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1179653005.

]]>
Use stdint.h types throughout PDFium.Tom Sepez <tsepez@chromium.org>Tue, 9 Jun 2015 18:30:25 +0000http://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=bb17868d736f698d5217c30d52c5bbfed62c5936http://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=bb17868d736f698d5217c30d52c5bbfed62c5936
Use stdint.h types throughout PDFium.
Use stdint.h types throughout PDFium.
It's redundant nowadays to provide our own equivalents, now
that this is done for us by the system header.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1177483002

]]>
Convert all line endings to LF.John Abd-El-Malek <jabdelmalek@google.com>Sat, 24 May 2014 00:28:10 +0000http://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=3f3b45cc74b0499912409f766a595945dbbfc4c5http://downloads.foxitsoftware.com/web/?p=pdfium.git;a=commitdiff;h=3f3b45cc74b0499912409f766a595945dbbfc4c5
Convert all line endings to LF.
Convert all line endings to LF.