Re: overflow bug SERIOUS

August 15, 2010, 09:23:55 PM

Once you have an update, you could download knightmb's block chain. You'll want one that's old enough that it ends before block 74000 so the most recent security lockin will check it. Can someone find the link for that?

Re: overflow bug SERIOUS

August 15, 2010, 09:40:19 PM

Patch is uploaded to SVN rev 132!

For now, recommended steps:1) Shut down.2) Download knightmb's blk files. (replace your blk0001.dat and blkindex.dat files)3) Upgrade.4) It should start out with less than 74000 blocks. Let it redownload the rest.

If you don't want to use knightmb's files, you could just delete your blk*.dat files, but it's going to be a lot of load on the network if everyone is downloading the whole block index at once.

Re: overflow bug SERIOUS

August 15, 2010, 10:58:08 PM

Don't update the block chain download. When you take someone's block chain download, you don't want it right up to the end. A somewhat old one is better so it can download and verify the most recent blocks.

tcatm's 4-way SSE2 SHA-256 is in the file sha256.cpp and already uploaded a few revs ago.

I just now uploaded rev 134 which is the makefile.unix that enables building with it on Linux. If you build rev 134 on Linux now you'll get the -4way switch.

If you have problems building because of it, then edit makefile.unix and:- remove -DFOURWAYSSE2- remove obj/sha256.o from the end of these lines:bitcoin: $(OBJS) obj/ui.o obj/uibase.o obj/sha256.obitcoind: $(OBJS:obj/%=obj/nogui/%) obj/sha256.o

Re: overflow bug SERIOUS

I think that you should add something about this: http://bitcointalk.org/index.php?topic=259.0There must be a label on the client that show a warning message if needed Now everyone have always to check the website, and I think that this is bad.

Agree, wanted to do that for a long time, haven't had time to do it.

For now, you could also subscribe to the bitcoin-list mailing list. It rarely gets used except for announcements like this and major new versions.

Re: overflow bug SERIOUS

Question about fallout: I had a transaction that I submitted after the bad block, using the bad block chain.

What is the status of that transaction?From what I can tell, my (updated) sending client wallet shows the deducted amount.

Will it get reincorporated into the fixed chain, and will the recipient be able to spend it?

Right, it will get reincorporated into the fixed chain. The transaction won't disappear, it'll still be visible on both sides, but the confirmation count will jump back to 0 and start counting up again.

It's only if you generated a block in the bad chain after block 74638 that the 50 BTC from that will disappear. Any blocks in the bad chain wouldn't have matured yet.

Re: overflow bug SERIOUS

Most people running clients are not reading this message thread. So... Silly questions:

1) How will this continue to affect version 3.8.1 (pre-catastrophe) clients with bad block chain?2) How will this affect clients that upgrade to 3.8.10 but don't remove their block chain files?

1) Once more than 50% of the node power is upgraded and the good chain overtakes the bad, the 0.3.10 nodes will make it hard for any bad transactions to get any confirmations. 2) If you didn't remove your blk*.dat files, you're not helping to contribute to that 50%, and you'll still show bad transactions until the good chain overtakes the bad chain.

Re: overflow bug SERIOUS

August 16, 2010, 02:16:10 AM

The bad chain is also slowed down as more nodes upgrade.

We've already generated 14 blocks since 74638. The builds of 0.3.10 were uploaded about 2 and 3 hours ago. Of the nodes I'm connected to, more than half are already 0.3.10. I would say we probably already have more power than the bad chain.

Re: overflow bug SERIOUS

August 16, 2010, 02:38:21 AM

On Windows, findstr /c:"version message" debug.log

It looks like the bad chain was on block 74678 recently. Can't wait to overtake it.

On the stats at http://nullvoid.org/bitcoin/statistix.php there's been 5 blocks per hour in the last 3 hours. We had a difficulty adjustment about a day ago that should have put it back to 6 blocks per hour.

Re: overflow bug SERIOUS

August 16, 2010, 10:54:55 PM

Un-upgraded nodes have the correct chain most of the time, but they are still trying to include the overflow transaction in every block, so they're continually trying to fork and generate invalid blocks. If an old version node is restarted, its transaction pool is emptied, so it may generate valid blocks for a while until the transaction gets broadcast again. 0.3.9 and lower nodes still must upgrade.

The SVN now has the code we needed to automatically reorg the block chain without having to delete the blk*.dat files manually. I knew I couldn't write that code fast and carefully enough yesterday, so I went with the quick manual option.