I have been trying out the changes to the inspection UI,and I am happy to see around 90% of the issues wereaddressed!I am going to resummarize the remaining issues, and alsoI have some new bugs/feature requests.

Votes

Share

I think all of the existing issues were addressed. It is really much nicer to use now compared to 5.1.

BUG: I don't like that my inspection profilers keep getting all the new

inspections added to them by default. This is an existing issue, butI don't think I mentioned it earlier.

I have one main profile I call "Recommended". I was looking at ittoday, and I see that I have all these new inspections which I don'tcare about that GWT (Google Web Toolkit) inspection, Struts Inspections,Plugin DevKit inspections, J2ME issues, Struts Assistant, UI FormProblems, etc.

I have another inspection I created in IDEA 4.5 (or maybe 5.0 EAP I forgot)called "None" which is supposed to have no inspections, and it has72 inspections enabled!

I am wondering if some of the slowness is attributable to having 72 new inspectionssilently added to my "Recommended" profile?

Can't you change it so if the inspection profile doesn't contain an entry foran inspection, that it always defaults to false?

*Useability: The filter text box doesn't respond to basic textediting keystrokes like CTRL+DELETE to wipe out word. It is slower to deleteeach character one at a time because there doesn't appear to be any delaybefore the tree is refilitered. There should be some minimal delay before thetree is refiltered like 300 ms.

Also, what does the Filter button to the right of the filter text box doanymore now that the filter is applied in realtime as you type?

BUG: I keep having this problem off/on where I am looking at an inspection item

in the results tree, I will click it to jump to it in the Editor, then in theEditor I will attempt to press ALT+ ENTER to access the quick fix, but the menuentries will be missing! If I then move my mouse over the line to get thetooltip to appear (sometimes have to do this a couple times), then usuallyhitting ALT+ENTER again will show the menu items. This has been an annoyingproblem and significantly reduced my pleasure. Anybody else seen this? This is stillhappening in 5561 for me. It is easier to get it to happen if you jump from theInspection Results, esp. if you don't mouse over the warning in the Editor firstto cause the warning tooltip to popup. Intermittant but frequent.

similar to when you do a search? Some of these inspection take hours to run, and it would be better if I could look at them sooner rather than later.

Feature - You don't have the option to suppress for statement, suppress

for class, etc. i.e. the same options that are accessible from the inspection's intention menu (ALT+ENTER). The Supress icon should popup a little popup menu showing the possible choices. Also, the text in the content pane that has the link "Suppress for method" could have the other choices there too.

Feature: For some inspections there is a need for them to have one or

more code pointers associated with them. For example, when it says variable is already defined in the scope, it would be nice if there was a way to jump to where the other variable is defined, because sometimes it isn't obvious in a large method. Another example, is the duplicate string literal.[AlexL,no jira #]

- Bug: If you press Suppress toolbar button, and the file is read-only, it pops up a dialog. If you cancel that dialog, the item is removed from the tree. It should be left as is. (There was a related Jira issue Inspection panel: Accept then cancel resolution => inspection result (Jonas Kvarnstrom) removed anyway http://www.jetbrains.net/jira/browse/IDEA-5631 )

Useability - I like the addition of a toggle "Filter Resolved Items" in

the toolbar. However, it doesn't work like I hoped it would.

- If you have the filter on, and then resolve some items, and then decide you want to see the resolved items, turning the filter off doesn't bring them back. The resolved items are only preserved if you have the filter off.

- The resolved items have the word ]]> appended to them. This is not very noticeable, and it many cases the text is truncated. I would rather have the item text Strike-out.

Even better, you should all the user to choose how the resolved items are displayed by adding a new style 'resolved items' in the Colors & Fonts settings dialog. You could also display it on the Errors settings dialog also.

Then, if I want Strike-out text, you got it. But if someone else wants the background color to be a different color, they could do that too.

- I would like to be able to hit DELETE to manually resolve an item, similar to how you can do with the Find Results. (Please see the example screenshot which shows how a search result item is changed to foreground gray with Strike-Out text after I manually cancelled it by pressing the DELETE key).

Useability: After I apply a quickfix, if it caused the line number to change, then

it causes the result item to change to INVALID, and you can no longer click on it.

It would be so much better if the original text was preserved and instead you added wavy red lines or something to indicate it was INVALID. (Again, the style could be customized in Colors&Fonts, call it "Invalid Code Pointer" or something. Even if it is INVALID, I should still be able to click on it and IDEA should make a best effort to jump the the file and line number. If the line number doesn't exist, jump to end of file. If the file doesn't exist anymore, popup an error message or do nothing. (See related "IDEA Find Usages and Find in Path should make best effort to jump to source for INVALID items"http://www.jetbrains.net/jira/browse/IDEADEV-2610)

Cosmetic: Why do you show the "(Read-only)". Shouldn't you should the

document icon with the lock decoration? I find all the "(Read-only" jarring to the eye, and inconsistent.

For many purposes, it might be ok to Remove the Package, and/or Class, and/ or Method grouping levels to create a flatter tree that is easier to navigate. I find I spend alot of time opening folders! (Related Jira Request IDEA-3832, Thomas Raugust)

+ Most of the new inspections added were too generic sounding, e.g. "Strutsinspection", and had very sparse documentation. Is there a reason why these can'tbe broken down into specific inspections? I really can't tell what manyof these new inspections do from the name or the documentation.Alot of work needs to be done for these to have the same quality as existing inspections.

- Faces Model Inspection. This is very generic. The description says 'This inspection checks for JSP problems.' Hopefully the description isgoing to be expanded before release. If possible, it would be better tobreak it down into multiple inspections so that user has more control overwhat is being checked.

- GWT Issues. This should be renamed to Google Web Toolkit (GWT) Issues.GWT is not well known, so I think it is better to show the fullname,because most people won't use this and it will be more obvious it can bedisabled. The GWT Issues is enabled by default.

+ I would be nice if the new inspections were hilighted in some way, orif there was some way to filter the inspections by release 4.0, 5.0,6.0+. This is helpful for somebody like me who has already waded throughall the inspections and selected the ones they want. Now, I would liketo try out the new inspections, but there are so many inspections itis hard to keep track of which are new and which are not.

Anything to help manage the massive inspection set is good, and here's one feature I would find helpful. Give each inspection a toggle that I can set to on I decide I like the inspection and its settings, whether on or off. So, I can work my way through them over time and in whatever order and finally know I'm done when all have the "this is the setting I want" toggle on. Also allow me to filter the inspection list by the toggle.

+ I would be nice if the new inspections werehilighted in some way, orif there was some way to filter the inspections byrelease 4.0, 5.0,6.0+. This is helpful for somebody like me who hasalready waded throughall the inspections and selected the ones they want.Now, I would liketo try out the new inspections, but there are so manyinspections itis hard to keep track of which are new and which arenot.

Maybe give inspections a way to tell you when (or version #) they were added and when (or version #) they were last updated?

newinspections added to them by default. This is an existing issue, butI don't think I mentioned it earlier.I have one main profile I call "Recommended". I was looking at ittoday, and I see that I have all these new inspections which I don'tcare about that GWT (Google Web Toolkit) inspection, StrutsInspections,Plugin DevKit inspections, J2ME issues, Struts Assistant, UI FormProblems, etc.I have another inspection I created in IDEA 4.5 (or maybe 5.0 EAP Iforgot)called "None" which is supposed to have no inspections, and it has72 inspections enabled!I am wondering if some of the slowness is attributable to having 72new inspections silently added to my "Recommended" profile?

Can't you change it so if the inspection profile doesn't contain anentry for an inspection, that it always defaults to false? [AlexL,nojira#]

When somebody writes a new inspection he (or she) should specify would it be enable by default or not. The default value for this property is false ;) I mean that plugin developers should use it accurately. I don't think that we should deny such possibility. May be just ask not to use it too often.

deleteeach character one at a time because there doesn't appear to be anydelaybefore the tree is refilitered. There should be some minimal delaybefore thetree is refiltered like 300 ms.Also, what does the Filter button to the right of the filter text boxdo anymore now that the filter is applied in realtime as you type?

inspection itemin the results tree, I will click it to jump to it in the Editor, thenin theEditor I will attempt to press ALT+ ENTER to access the quick fix, butthe menuentries will be missing! If I then move my mouse over the line to getthetooltip to appear (sometimes have to do this a couple times), thenusuallyhitting ALT+ENTER again will show the menu items. This has been anannoyingproblem and significantly reduced my pleasure. Anybody else seen this?This is stillhappening in 5561 for me. It is easier to get it to happen if you jumpfrom theInspection Results, esp. if you don't mouse over the warning in theEditor firstto cause the warning tooltip to popup. Intermittant but frequent.Please see attached files for an example.

Anna Kozlova wrote:>> * BUG: I don't like that my inspection profilers keep getting all the>> new>> inspections added to them by default. This is an existing issue, but>> I don't think I mentioned it earlier.

When somebody writes a new inspection he (or she) should specify wouldit be enable by default or not. The default value for this property isfalse ;) I mean that plugin developers should use it accurately. I don'tthink that we should deny such possibility. May be just ask not to useit too often.

This is not (only) a plugin-related issue. There were literally dozens of newinspections added in Demetra and even in 5.1 (that actually deserve to be on bydefault to be recognized by the user), but if I have an Inspection Profilecalled "JavaDoc only" that should tell me about JavaDoc problems, I want theprofile to be stable, no matter what fancy new inspections are added.

This hasn't caused me big headaches yet, but it's annoying anyway. It should bepossible to "lock" a profile against newly added inspections.

>>> * BUG: I don't like that my inspection profilers keep getting all>>> the>>> new>>> inspections added to them by default. This is an existing issue,>>> but>>> I don't think I mentioned it earlier.>> When somebody writes a new inspection he (or she) should specify>> would it be enable by default or not. The default value for this>> property is false ;) I mean that plugin developers should use it>> accurately. I don't think that we should deny such possibility. May>> be just ask not to use it too often.>>

This is not (only) a plugin-related issue. There were literally dozensof new inspections added in Demetra and even in 5.1 (that actuallydeserve to be on by default to be recognized by the user), but if Ihave an Inspection Profile called "JavaDoc only" that should tell meabout JavaDoc problems, I want the profile to be stable, no matterwhat fancy new inspections are added.

BUG: I don't like that my inspection profilers keep getting all the new

inspections added to them by default. This is an existing issue, butI don't think I mentioned it earlier.

I've also had some problems with this, although I mostly noticed it in the other direction: New inspections turn up now and then, and since they are turned off by default they are hard to find in the complete list of hundreds of old and new inspections. For example, I have a profile where I initially added ALL inspections and incrementally turned off those that turned out to be too intrusive or didn't fit my programming style, and now I don't know whether an inactive inspection is new or was explicitly turned off.

A couple of potential ideas (though neither idea is perfect):

1) Three different configuration states for inspections: On, off and undetermined. All new inspections would default to undetermined -- this would mean they aren't applied, but they are shown differently in the list so that you could easily find them, and now and then you can check your profiles to decide whether they should be on or off.

2) Sorting inspections by date of addition -- then you could more easily check the latest inspections to be added.

Anna> It is the problem with the entire highlighting :( Quickfixes are availableAnna> (roughly) after daemon stops analyzing ...

When this happens, there is no background daemon runnins as far as I can tell. I had the problem happen again today. I left the Editor alone for 1 minute, and then 5 minutes, and the problem still existed. The tooltip said "Missorted modifiers final static" but there was no quickfix in the intention menu.

I realize this might be post-Demetra, but this is really important as everyone gets Dual-Core and eventually Quad-Core workstations....

Ideally, Inspect Code should behave like Find in Path. The Inspection Results panel immediately appears and starts populating results as it finds them. And the status bar displays the progress of the operation. No modal progess dialogs.