Replace use of std container with WTF's equivalents in css_image_generator_value.cc

Comments

Replace use of std container with WTF's equivalents in css_image_generator_value.cc
Replace the use of std::map of std container with WTF::HashMap and
WTF::HashCountedSet in css_image_generator_value.cc, and add
HashTraits for FloatSize to use it as the HashMap key.
Bug: 952716
Change-Id: I0417570fc3cf375ef3ed9ea6759ad26b64b9d56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575315
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#653485}

Updating defaultValue in a non-dirty TEXTAREA should not move the caret to the end

Comments

Updating defaultValue in a non-dirty TEXTAREA should not move the caret to the end
According to the HTML standard, updating defaultValue should keep
selectionStart/End, and clamp them if the new value is shorter than them.
defaultValue setter doesn't have any explicit selection behavior [1], and
we should apply default selection adjustment algorithm in such case [2].
The new behavior matches to Edge, Firefox, and Safari.
Some test cases in selection-start-end-extra.html were not correct. This CL
fi
...skip...
g.org/multipage/form-elements.html#the-textarea-element:dom-textarea-defaultvalue-2
[2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#textFieldSelection:concept-textarea/input-relevant-value
Bug: 822639
Change-Id: I77db0934bb10774561e947f64b4cb3f88c293679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575317
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653487}

Reland: Use a per-frame task runner at mojom::SafeBrowsing binding

Comments

Reland: Use a per-frame task runner at mojom::SafeBrowsing binding
This is reland of https://chromium-review.googlesource.com/c/chromium/src/+/1536036
This was reverted once since ServiceWorkerTest.UpdateRefreshesServiceWorker
became flaky on Windows, but now this doesn't, though the reason is unclear.
This CL switches task runners at several places from per-thread to
per-frame. The purpose of this change is to make it possible to freeze
tasks for bfcache.
We found an actual case that JavaScript is
...skip...
rks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:media:soundcloud:2018
As this is a non-standard JavaScript API execution, we adopted
kInternalDefault as the task type.
Bug: 913912
Change-Id: Id03b1ac9f46e6c69adea8cd42c6af193dd83fa36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578144
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653490}

Changed files

chrome/renderer/url_loader_throttle_provider_impl.cc

chrome/renderer/url_loader_throttle_provider_impl.h

Replace use of std containers with WTF's equivalents in screen_orientation_controller_impl_test.cc

Update GrantObjectPermission to take url::Origin

Comments

Update GrantObjectPermission to take url::Origin
This change updates ChooserContextBase's GrantObjectPermission() method
to take url::Origins instead of GURLs. In the process the internal
GetWebsiteSetting() and SetWebsiteSetting() methods have also been
modified to take url::Origins.
This is part of a migration effort to remove GURL from the interface of
ChooserContextBase and its subclasses.
Bug: 951785
Change-Id: I88878374ca4c8c1d56cb6f05614fb76f70ac4f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579477
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653495}

Fix bug in LayoutTreeBuilder accessibility patch

Comments

Fix bug in LayoutTreeBuilder accessibility patch
This change changed the accessibility tree to be built
using LayoutTreeBuilder: crrev.com/c/1547617
This caused crbug.com/951503 - a crash in
blink::AXNodeObject::AddChildren, due to a node
being deleted while it was in the process of
iterating over its children.
I can reliably reproduce this crash by loading
https://www.komputerswiat.pl/gamezilla when
accessibility is enabled.
I discovered that the root cause was due to the
change in AXObjectCacheI
...skip...
objects that correspond to the
same Node.
The fix is easy - just check node->GetLayoutObject
and skip checking the node mapping if it's not the
same.
Bug: 951503, 835455
Tbr: nektar@chromium.org, aboxhall@chromium.org
Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580140
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653498}