Derek, is the post above meant for Jon or myself? And according to my watch, you should be in bed now

« Last Edit: Nov 22nd, 2011 at 2:22am by corvettec3 »

IP Logged

Derek Barnstorm

Support TeamYaBB Next TeamDevelopment TeamBeta Testers
Offline

Posts: 1,269
Location: United Kingdom

None

Re: PMs from Ex-MembersReply #62 - Nov 22nd, 2011 at 3:01am

It was meant for Ron really, but I guess you too if you did want to double check. I'd appreciate it if you guys could let me know if it fixes it anyhow.

Just to explain a little more what was going on - Some malicious users are obviously attempting to upload something through the email field:

Code

file_links[d:xr-dataseogyy@gmail.com.txt1l]

And it was being added to the ban list before it was being checked for being a valid email, so one of the characters was buggering up the settings. Adding it to the ban list after it has been checked to be valid is hopefully going to fix it.

The 'Auto-ban both IP Address and Email Address if either one matches?' option will ban the email address even if it isn't in the SFS database but the IP is, and visa versa - if that makes sense.

If it's only banned if it is in the database, then it would be already tested by SFS to be valid. It seemed to slip my mind that anything entered into the email field was going to be auto-added to the ban list with no checks.

I personally don't have that option enabled on my test/demo board - I only add them to the ban list if they do match emails in the database. But it's obviously up to you how strict you want to be.

Oh, I'm a night owl by the way.

« Last Edit: Nov 22nd, 2011 at 3:31am by Derek Barnstorm »

IP Logged

RonS2

Senior MemberLanguage TeamBeta Testers
Online

Posts: 582

YaBB 2.5.2

Re: PMs from Ex-MembersReply #63 - Nov 22nd, 2011 at 3:30am

I already overwrote the Settings.pl that had the problem. The backup I used was 2 days old, sorry.

Looks like I am now proficient in messing up perl. Before this I was only good at screwing up HTML.

He he! We all do it. Not so long ago I had two images - a small icon and a screenshot of an error message, both with the same name. I uploaded the wrong one and it took about an hour to realize it was an image on the screen and not an error with my code.

« Last Edit: Nov 22nd, 2011 at 2:11pm by Derek Barnstorm »

IP Logged

RonS2

Senior MemberLanguage TeamBeta Testers
Online

Posts: 582

YaBB 2.5.2

Re: PMs from Ex-MembersReply #71 - Nov 22nd, 2011 at 7:09pm

Just had the opportunity to splat an unsuspecting spammer with your most excellent bug swatter. Worked 100%

Looks like I am now proficient in messing up perl. Before this I was only good at screwing up HTML.

He he! We all do it. Not so long ago I had two images - a small icon and a screenshot of an error message, both with the same name. I uploaded the wrong one and it took about an hour to realize it was an image on the screen and not an error with my code.

What is worse is writing code, saving, looking for the difference you just made, not seeing it, though you KNOW it should be there. Deciding you aren't in the right IF/ELSE statement and working some other section.save that, etc etc etc. then an hour later (or less) realizing you were saving it to the wrong directory which you aren't hitting with your browser.