Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

Details

Telecommunication platforms in Germany must collect CDR start/stop times with an accuracy of +/- 500 ms.The attached patch is a WIP to achieve milliseconds precision with accounting. I have added new column acc.time_hires (decimal 13,3) because mysql doesn’t support milliseconds precision with time and date datatypes. Human-readable representation can be achieved by:select from_unixtime(time_hires) from acc;My TODO: prepare sql files, readme, enable milliseconds precision with accounting to log and radius if necessary.Not sure about the built-in cdr generation functionality as we are not using it (and we are still on 3.1.5).But right now I would like to collect some feedback as the ultimate goal is to get this integrated into upstream.So, I am willing to improve it. Any remarks and suggestions are welcome.

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

By the way, I noted the value range of timeval’s tv_usec field is architecture-dependent: On my Mac, it’s like [0,1000000) while on Linux I think it’s [0,1000). So when converting portions of timeval this should be accounted for.

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

Please disregard my very last comment completely; I was in an alternate universe when I wrote that.

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552

Revived from the mailing list – I see few issues and have some questions:

- the tm variable is declared set, but not used- tz is also not used, gettimeofday() can take NULL as second parameter and iirc, tz is obsolete- I wonder if gettimeofday() can actually fail and return code should be checked for error cases- the names of the new column, respectively ‘time_hires’ sounds a bit strange to me, does it have any special meaning the word ‘hires’?

Overall, wouldn’t be better to keep the seconds and microseconds (as returned in a timeval structure) in separate columns. That means keeping the time column as it is and adding a new column for microsecs. Then people can get the precision as they want, including only down to the miliseconds if that is what they need.

Strict Standards: call_user_func() expects parameter 1 to be a valid callback, non-static method dokuwiki_TextFormatter::render() should not be called statically in /var/www/sip-router.kamailio.org/flyspray/includes/class.tpl.php on line 552