cassandra-commits mailing list archives

[jira] [Comment Edited] (CASSANDRA-6936) Make all byte representations of types comparable by their unsigned byte representation only

Date

Wed, 04 Feb 2015 16:04:36 GMT

[ https://issues.apache.org/jira/browse/CASSANDRA-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305367#comment-14305367
]
Aleksey Yeschenko edited comment on CASSANDRA-6936 at 2/4/15 4:03 PM:
----------------------------------------------------------------------
Additionally, I wouldn't want to layer extra conversion logic on top of the already happening
CASSANDRA-8099. We will have bugs there (in back and forth conversion of mutations and read
commands). We are still catching bugs of this kind from CASSANDRA-3237. You don't want to
make things worse by having this on top, in a single release.
was (Author: iamaleksey):
Additionally, I wouldn't want to layer extra conversion logic on top of the already happening
CASSANDRA-8099. We will have bugs there (in back and forth convertion of mutations and read
commands). We are still catching bugs of this kind from CASSANDRA-3237. You don't want to
make things worth by having this on top, in a single release.
> Make all byte representations of types comparable by their unsigned byte representation
only
> --------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-6936
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6936
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Labels: performance
> Fix For: 3.0
>
>
> This could be a painful change, but is necessary for implementing a trie-based index,
and settling for less would be suboptimal; it also should make comparisons cheaper all-round,
and since comparison operations are pretty much the majority of C*'s business, this should
be easily felt (see CASSANDRA-6553 and CASSANDRA-6934 for an example of some minor changes
with major performance impacts). No copying/special casing/slicing should mean fewer opportunities
to introduce performance regressions as well.
> Since I have slated for 3.0 a lot of non-backwards-compatible sstable changes, hopefully
this shouldn't be too much more of a burden.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)