Details

Description

Found during code reading on HADOOP-6490, there seems to be an unnecessary call of normalizePath(...) being made in the constructor Path(Path, Path). Since initialize(...) normalizes its received path string already, its unnecessary to do it to the path parameter in the constructor's call of the same.

I believe that according to the Hadoop bylaws, all patches require a +1 from a committer before they can be committed. I've seen a few exceptions to that in practice, such as for trivial documentation fixes or for back-ports from other branches. In general it's safest to just find a committer who's willing to review it, though.

Aaron T. Myers
added a comment - 12/Oct/11 06:55 +1, the patch looks good to me.
I believe that according to the Hadoop bylaws, all patches require a +1 from a committer before they can be committed. I've seen a few exceptions to that in practice, such as for trivial documentation fixes or for back-ports from other branches. In general it's safest to just find a committer who's willing to review it, though.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 12/Oct/11 05:56 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498704/HADOOP-7736.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/288//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/288//console
This message is automatically generated.