On Thu, Jul 25, 2013 at 12:28 AM, <chaitanya.mgit@gmail.com> wrote:
>> Add Support TPC as per 802.11-2012> and TPE(VHT) IE's as per 802.11ac-draft-5.0.>> Signed-hostap: Srinivasan <srinivasanb@posedge.com>> Signed-hostap: Chaitanya T K <chaitanyatk@posedge.com>> ---> Fixed the signoffs.>> TPC Support from the RFC submitted by Srinivasan.> Clubbed these two as they belong to the same category.>> For TPE, for input of power constraints> currently only user support is added, regulatory support> can be added later.
Jouni,
Any update on the review?
Please send me the comments, if any.
Thanks.
Chaitanya T K.

> Please do not merge independent changes into a single patch even if they> are in similar category. It's much easier to review and manage shorter> patches that add each add a specific change. In addition, there were> quite a bit of whitespace damage in the changes. Please either fix your> MUA to not break the patch or as a less preferred backup, send the patch> as an attachment in addition to inline.>> I split the changes into three parts and cleaned them up to make it> easier to review them (doing that before for contributions would be> appreciated and likely to speed up the process of getting these into> hostap.git). The following commits have number of TODO/FIX comments> pointing out the changes that I think will be needed to make these work> properly.
Thanks a lot Jouni for the comments. Will handle the comments and send them
as a 3 individual patches.
> FIX: ieee80211h configuration parameter is not appropriate way of> deciding whether to add this to the Beacon/Probe Response frames since> it is used for other purposes (enabling DFS support). In addition,> hardcoding Local Power Constraint to 0 does not look good. Maybe add a> new configuration parameter local_pwr_constraint and add this element> only if that is set.
Accepted.
> FIX: ieee80211h is not appropriate parameter for selecting when spectrum> management is marked required. A new spectrum_mgmt_required> configuration parameter could be added to do this instead.
Accepted.
> TODO: Is use of 127 as the config-value-not-set appropritate? Would> sound better to use int values in configuration and a unique> value to indicate not set rather than re-use 127 which has a> special meaning in the standard.
Agree that 127 has a special meaning but that meaning says there is
no local power constraint, so we can safely use it to not to include the
IE.
> TODO: It is not appropriate to use ieee80211h config parameter as a> constraint for including this. Use vht_tpe_loc_20 parameter> present/not-present for this instead.
Accepted.
> Add Transmit Power Envelope element per IEEE 802.11ac/D6.0 if VHT is> enabled.
Sure, our patch was based on 5.0 will upgrade.

Hi All,
2013/9/1 Krishna Chaitanya <chaitanya.mgit@gmail.com>:
>> Please do not merge independent changes into a single patch even if they>> are in similar category. It's much easier to review and manage shorter>> patches that add each add a specific change. In addition, there were>> quite a bit of whitespace damage in the changes. Please either fix your>> MUA to not break the patch or as a less preferred backup, send the patch>> as an attachment in addition to inline.>>>> I split the changes into three parts and cleaned them up to make it>> easier to review them (doing that before for contributions would be>> appreciated and likely to speed up the process of getting these into>> hostap.git). The following commits have number of TODO/FIX comments>> pointing out the changes that I think will be needed to make these work>> properly.>> Thanks a lot Jouni for the comments. Will handle the comments and send them> as a 3 individual patches.>>> FIX: ieee80211h configuration parameter is not appropriate way of>> deciding whether to add this to the Beacon/Probe Response frames since>> it is used for other purposes (enabling DFS support). In addition,>> hardcoding Local Power Constraint to 0 does not look good. Maybe add a>> new configuration parameter local_pwr_constraint and add this element>> only if that is set.>>> Accepted.>>>> FIX: ieee80211h is not appropriate parameter for selecting when spectrum>> management is marked required. A new spectrum_mgmt_required>> configuration parameter could be added to do this instead.>> Accepted.>>>> TODO: Is use of 127 as the config-value-not-set appropritate? Would>> sound better to use int values in configuration and a unique>> value to indicate not set rather than re-use 127 which has a>> special meaning in the standard.>> Agree that 127 has a special meaning but that meaning says there is> no local power constraint, so we can safely use it to not to include the> IE.>>> TODO: It is not appropriate to use ieee80211h config parameter as a>> constraint for including this. Use vht_tpe_loc_20 parameter>> present/not-present for this instead.>> Accepted.>>> Add Transmit Power Envelope element per IEEE 802.11ac/D6.0 if VHT is>> enabled.>> Sure, our patch was based on 5.0 will upgrade.> _______________________________________________> HostAP mailing list> HostAP@lists.shmoo.com> http://lists.shmoo.com/mailman/listinfo/hostap
What is the current status of TPC implementation?
I am asking because I would like to continue that work or test that if
it is already done.
Thanks,
Marek

> What is the current status of TPC implementation?> I am asking because I would like to continue that work or test that if> it is already done.
I was busy with other things at hand, so couldn't spend time to
address the comments.
You can go ahead if you have time else will try to address them
myself. Either way its fine with me.