[03:13:29] @basvb : I was assuming that you were not going to make it late in the evening because of the festival in your city
[03:13:39] So I was not online
[03:14:03] Is the festival over?
[04:42:47] hi zhuyifei1999_
[04:46:42] Do you follow it as a strict rule to have <=79 chars per line?
[04:47:04] Or does it depend on the readability of that line?
[05:39:29] I usually follow it, but I don't require your project to be
[05:39:40] just don't exceed 120
[05:43:59] ok
[05:45:10] I keep on getting "socket.error: [Errno 98] Address already in use" when I rerun the flask app
[05:45:42] even after closing the browser and
[05:45:53] terminating the terminal
[05:49:16] did your start two instances?
[05:49:23] of flask?
[05:49:35] check process list
[05:49:59] closing the terminal might have made flask fork into the background
[05:50:08] (SIGHUP)
[05:50:17] ok
[05:50:49] Also I have set the same callback url for both the consumers, i.e., the toollabs one and the local m/c
[05:51:02] so after the Oauth login I am at the same url
[05:51:18] Is that the correct thing to do?
[05:53:33] https://tools.wmflabs.org/sibutest/oauth-callback?oauth_verifier=c94e0082ef27b34263614942d2617589&oauth_token=88f7d575ed8ccad35daa0b77650bb43d
[06:17:02] for testing use your local url
[06:17:16] or your browser will always redirect to tool labs
[06:17:37] and the tool labs tool will always find the tokens invalid
[07:08:31] Like http://127.0.0.1:5000/oauth-callback
[07:08:39] sure
[07:09:02] Ok
[09:26:39] hi, yes the festival is over, I'll be here every weekday at 20:00 or otherwise inform you
[09:42:40] ok @basvb
[12:06:43] infobliss: so when do you expect you can make the basic workflow with the upload working?
[13:54:58] zhuyifei1999_ : end of day today
[13:55:04] k
[15:07:27] hi zhuyifei1999_
[15:10:33] could you please see my upload method https://justpaste.it/19c71
[15:14:03] here is the logs : http://collabedit.com/yku79
[15:14:38] says: "badfilename: Target filename is invalid."
[15:17:04] a sec
[15:17:46] wiki_file_location = 'https://commons.wikimedia.org/wiki/File:' + filename
[15:17:56] we don't want full url here
[15:18:07] just "File:" + the filename
[15:18:36] oh
[15:18:47] without "File:" namespace should work as well, pywikibot.FilePage will sanitize it
[15:19:43] ok
[15:26:30] may be it worked
[15:26:35] that error is gone
[15:26:39] k
[15:26:45] I will come back after dinner
[17:29:19] infobliss_: any updates?
[17:33:01] was afk
[17:56:11] hi sorry
[17:56:20] went for a quick power nap
[17:56:28] k
[17:56:35] I think upload module is working
[17:56:36] but
[17:56:47] the proper link is not displayed
[17:56:55] i m investigating that now
[18:03:03] ok i got it
[18:03:11] it's because of a manual merge
[18:03:19] ...
[18:03:23] I had removed a return statement
[18:03:47] should be fine again now
[18:03:51] m testing
[18:04:31] cool
[18:04:33] working
[18:05:00] I am still very much bad in merging :(
[18:05:23] * zhuyifei1999_ hates merging
[18:05:37] a lot of redoing of the same task because of these silly mistakes
[18:06:37] well I will have to do this commit from the toollabs only
[18:06:50] then onwards I will pull that latest code into local machine
[18:06:52] why>
[18:06:55] and commit from there
[18:07:12] can't you push to github then pull from toollabs?
[18:07:52] I still find ^ better
[18:08:09] Yeah sure but the latest changes I made are directly from Toollabs
[18:08:20] ...
[18:08:30] further I will use local machine
[18:08:32] it has been set up
[18:08:37] can you stop making changes directly on tool labs?
[18:08:44] yes sure
[18:10:07] Do we have basvb here?
[18:10:49] btw, you may find https://phabricator.wikimedia.org/L3 very enlightening, especially the last paragraph
[18:11:13] Just this once! Sometimes you'll notice a little mistake in a file, and will be tempted to change it on the server itself. Despite good intentions. Do not edit local files on a server. Thanks
[18:11:56] Indeed
[18:12:15] I will not in the future.
[18:12:34] It is a lot of trouble without a good editor
[18:14:00] Do I have to "Agree and Sign Document" ?
[18:14:10] if you are doing some small tests I don't mind you doing it on a test tool, but going large changes, even commiting large chunks of code from them, clearly crossed the line
[18:14:12] no
[18:14:22] that's wmf production servers
[18:14:37] ok
[18:16:40] ..., clearly crossed the line <= except: if they are very minor projects and commiting from labs won't disrupt the workflow. (eg. only copy is on labs)
[18:17:58] ok I am very sorry
[18:20:01] * zhuyifei1999_ was just annoyed by how you keep encountering problems that would be avoided if you follow standard practice
[18:21:31] anyways, please make the things work and push it asap
[18:22:01] true, I didn't know how testing is possible from local machine until recently
[18:23:51] I will focus on showing multiple images in a grid now
[18:23:57] k
[18:24:17] [20:10] Do we have basvb here? -> here now
[18:24:26] and then adding checkboxes for each image in the grid
[18:24:29] hi basvb
[18:25:03] we have the OOP based design working now
[18:25:54] Good, then it's time to get back to some of the planned tasks:
[18:26:05] 1. provide some info on how to add a new glam (documentation)
[18:26:15] 2. for each glam there has to be a license check function
[18:26:22] which can be part of the class inheratance
[18:26:45] it's a must have for any upload, so good if it's a separate function
[18:27:04] ok task 1 will be done today
[18:27:31] 3. you want a function which can return the thumbnails per glam (or return false if it is not possible to do multiple upload/get thumbnails)
[18:27:52] maybe we also want 4. a function which given an url/identifier returns the json
[18:28:11] although that one does not have to be standard it's likely a stepping stone for 2 and 3
[18:28:49] zhuyifei1999_ said that task 4 is just a one line code
[18:29:09] so does not deserve to be a separate function
[18:29:21] you need: 1 regex to recognize id/url
[18:29:26] 2 call the json
[18:29:42] but if it's going to be used on multiple locations you need a function I think
[18:30:20] I think zhuyifei1999_ said that for just loading the json from the id the current multi-line code can be transferred into a 1 line
[18:30:36] yep
[18:30:40] but maybe he can give some input on these functions/what he said about the id to json
[18:31:36] btw 2nd evaluation is open now until friday
[18:31:45] so I'll do that tomorrow of the day after
[18:32:09] yeah due on Friday
[18:32:22] So I gave some thought on this
[18:32:34] going by the initial timeline
[18:33:20] July 29 to August 7: To give the option to search for images based on a searchstring across the selected GLAMs and upload the desired ones.
[18:33:46] And also I have some time allocated for documentation etc
[18:34:38] So that part I can finish now to save some time from next time
[18:35:04] *next month
[18:35:18] well there's also some things you didn't get around to from this month
[18:35:31] so we can swap those with some of the things from next month
[18:35:57] but I believe at the start I already discussed that testing and documentation should be a continues part of your work, not something left to the end
[18:35:57] Yeah I mean if I write the documentation etc now I won't have to give any time for them later
[18:36:32] Yeah
[18:36:46] Aug 22 - 28 : Create a page in the Wikimedia Commons on our tool where people can suggest new GLAMs for metadata-mapping and possible changes in metadata mapping for existing GLAMs. Announce the tool to the wikimedia community somewhere on Commons.
[18:37:01] yes
[18:37:07] We have a week here
[18:37:09] but for this month there is: "Designing a template for the metadata mappings."
[18:37:19] part of that is documenting how to use this template
[18:38:16] sure
[18:39:02] I am not very sure what to document here
[18:39:29] a step-by-step guide on how to add a new glam, what functions need to be filled with what (based on the template)
[18:39:38] I will write a how-to-add-a-new-glam doc
[18:39:55] yes, preferably wikitext, somewhere in your user-space
[18:40:28] but let's get some new funcitonalities finished as well
[18:40:59] yeah we have 3 days
[18:41:07] you learned a lot on the code restructuring and basic workflow for programming, but it's important to also go further than that
[18:41:14] well you have a whole month after that
[18:41:44] yeah for the next 3 days I will see how much of multiple upload can be finished
[18:41:50] the deadline for 3 days is nice and all but 90% of the work for that deadline should be ready, since 90% of the time has passed
[18:42:15] so we should focus on what can be done by the end of the project as well
[18:42:25] just make sure you put in the hours and ask questions when you get stuck
[18:42:56] I have troubled you both a lot ;)
[18:43:46] we're here to help and mentor you, don't be afraid to ask questions
[18:44:06] sure and thanks for the support
[18:45:07] Do you think "Create a page in the Wikimedia Commons on our tool where people can suggest new GLAMs" ha to be some other page than what I will make now?
[18:45:21] *has
[18:45:34] yes
[18:45:51] so on commons we will make 3 pages:
[18:45:57] 1. Commons:glam2commons
[18:46:07] with a description of the tool
[18:46:07] 2. suggest new glam
[18:46:13] 3. technical info on how to add a new glam
[18:46:27] maybe we make more pages: 4. what current glams are supported
[18:46:39] 2,3 and 4 are subpages
[18:46:54] Commons:Glam2commons/current GLAMs
[18:47:04] Commons:Glam2commons/suggested GLAMs
[18:47:14] Commons:Glam2commons/how to add a new GLAM
[18:47:22] or something similar
[18:47:40] ok
[18:48:16] "Commons:Glam2commons/how to add a new GLAM" will be made now as a subpage of my user page
[18:48:42] so we will change that later?
[18:48:51] yes we'll move it later
[18:49:02] ok
[18:49:42] I plan to make a few video tutorials on these topics as well
[18:49:51] like screen capture tutorials
[18:49:56] and upload to commons
[18:50:16] hmm, try to at least get everything discussed in text
[18:50:18] Is that fine?
[18:50:26] yeah of course
[18:50:35] it's good. But I think text + images is better for the broader audience
[18:50:55] sure
[18:51:04] those are going to be there
[18:51:07] * zhuyifei1999_ support text + image
[18:51:31] commons's video player isn't as good as youtube's
[18:51:59] you mean in terms of resolution etc?
[18:53:18] laoding/playing videos
[18:53:46] ok
[18:53:50] I mean seeking, pausing, resuming
[18:54:11] it often go idek-whats-going-on'
[18:54:51] If you are concerned about the size of the videos I can say that they won't be too big
[18:55:08] <10 minutes
[18:55:10] size isn't the issue
[18:55:22] it just doesn't seek well
[18:55:32] or pause or resume
[18:55:39] ok
[18:56:28] We may keep them in youtube as CC0 videos.
[18:56:41] and share links in commons
[18:57:27] well if you make videos preferably add them to commons (as well)
[18:57:32] you can transfer to commons. it doesn't hurt
[18:57:38] but make sure nothing is copyrighted (software)
[18:57:50] but I still prefer text + image
[18:58:07] it's easier to re-reread
[18:58:15] *re-read
[18:58:49] yeah the videos are extra help
[18:59:08] if someone is lazy to read :)
[18:59:39] you can write a tl;dr or "this page in a nutshell"
[19:00:45] ok
[19:03:31] one more thing
[19:03:49] are we changing our meeting time on Sundays?
[19:06:05] to what?
[19:07:03] basvb: I think you said 15:00 UTC recently
[19:07:21] no 15:00 amsterdam, that's what we were doing
[19:07:28] 13:00 UTC I think that is
[19:07:34] 18:30 New Delhi
[19:10:10] ok basvb
[19:10:18] my net was gone
[19:11:07] Is that all for today?
[19:23:27] yes, for me it is