dbus issueshttps://gitlab.freedesktop.org/dbus/dbus/issues2018-12-05T11:26:16Zhttps://gitlab.freedesktop.org/dbus/dbus/issues/241tests for OOM behaviour are skipped on Windows with CMake but not Autotools2018-12-05T11:26:16ZSimon McVittietests for OOM behaviour are skipped on Windows with CMake but not Autotools```
% git grep DBUS_WIN_FIXME
README.win:- the code wrapped with DBUS_WIN_FIXME should be inspected if it required for windows
bus/dispatch.c:#ifdef DBUS_WIN_FIXME
cmake/config.h.cmake:# define DBUS_WIN_FIXME 1
dbus/dbus-memory.c:#ifdef DBUS_WIN_FIXME
```
cmake/config.h.cmake is only used under CMake, not Autotools.
The practical result is that:
* The test for GetConnectionUnixProcessID is skipped when built for Windows with CMake, but not when built for Windows with Autotools. This is certainly wrong: GetConnectionUnixProcessID() is a cross-platform feature now, so we should fix that test so that it can pass on Windows (which I think !55 does) and enable it everywhere.
* The tests for what happens when malloc() returns NULL are skipped when built for Windows with CMake, but not when built for Windows with Autotools. We should decide whether libdbus on Windows aims to be robust against out-of-memory conditions.
* If it does, we should run these tests, even though they're slow (you can temporarily skip them for quicker testing with the `DBUS_TEST_MALLOC_FAILURES` environment variable).
* If it doesn't, we should probably make `dbus_malloc()` and friends abort on out-of-memory, like GLib's equivalents do, when running on Windows.WindowsCMakehttps://gitlab.freedesktop.org/dbus/dbus/issues/239test-bus fails when built for Windows with CMake2019-01-16T12:14:08ZSimon McVittietest-bus fails when built for Windows with CMakeOn !23, @rhabacker wrote:
```
2/20 Test #2: test-bus .........................***Failed 5.70 sec
```
This is apparently reproducible on Windows 7, on Windows 10, and when cross-compiling under Linux and running the tests with Wine.
test-bus is large and complicated so I'm not really surprised. !1 breaks it into smaller pieces: it would be interesting to see which of them fail.WindowsCMake1. Test failurehttps://gitlab.freedesktop.org/dbus/dbus/issues/220--enable-relocation support breaks assumptions made by mingw32-install-post.sh2018-11-15T13:29:45ZBugzilla Migration User--enable-relocation support breaks assumptions made by mingw32-install-post.sh## Submitted by Ralf Habacker `@rhabacker`
Assigned to **D-Bus Maintainers**
**[Link to original bug (#107662)](https://bugs.freedesktop.org/show_bug.cgi?id=107662)**
## Description
Created attachment 141245
fix-order-of-dbus-1.pc.patch
Cross building dbus from git master with autotools for windows fails because of two issues
1.cross pkg-config 0.28 is confused to not have prefix= in the first line of dbus-1.pc
2. relocation support in configure.ac does not recognize --exec_prefix expanded to ${prefix} and --libdir to ${prefix}/lib
For both issues a related patch has been appended.
~~**Patch 141245**~~, "fix-order-of-dbus-1.pc.patch":
[fix-order-of-dbus-1.pc.patch](/uploads/711e79dd42873d93b2ef29685083b6b4/fix-order-of-dbus-1.pc.patch)
Version: git mastermingw-w64WindowsCMakeAutotools2. Needs Information1. BugFrom Bugzillahttps://gitlab.freedesktop.org/dbus/dbus/issues/191sysdeps-win: _dbus_get_autolaunch_address prints to stdout/stderr2018-10-15T13:40:00ZBugzilla Migration Usersysdeps-win: _dbus_get_autolaunch_address prints to stdout/stderr## Submitted by Simon McVittie
Assigned to **D-Bus Maintainers**
**[Link to original bug (#103756)](https://bugs.freedesktop.org/show_bug.cgi?id=103756)**
## Description
The coding convention for the dbus library is to report errors through a DBusError (analogous to a GError or a C++ exception) so that they can be caught and handled by application code in whatever way is most appropriate for the application. In particular, this avoids corrupting stdout/stderr if the application is using them for something machine-readable.
However, the Windows implementation of _dbus_get_autolaunch_address() doesn't do that consistently:
if (!SearchPathA(dbus_module_path, daemon_name, NULL, sizeof(dbus_exe_path), dbus_exe_path, &lpFile))
{
dbus_set_error_const (error, DBUS_ERROR_FAILED, "could not find dbus-daemon executable");
retval = FALSE;
fprintf (stderr, "please add the path to %s to your PATH environment variable\n", daemon_name);
fprintf (stderr, "or start the daemon manually\n\n");
}
(This is after Bug #103601 - before that, it used printf to stdout, which was worse, because stdout is more likely to be used for machine-readable output.)
The warnings that are currently printed to stderr should probably move into the message part of the DBusError. It's OK for a DBusError to be reasonably long.
In library code, we should only emit warnings to stderr as a last resort when nothing else is possible (and if we do that, we should use _dbus_warn() instead of fprintf).
I'm not intending to fix this myself, since I don't develop on Windows and so can't meaningfully test this.
Version: git masterWindows1. BugFrom Bugzillahttps://gitlab.freedesktop.org/dbus/dbus/issues/187dbus-1.13 release for Windows2018-10-15T13:41:00ZBugzilla Migration Userdbus-1.13 release for Windows## Submitted by Ralf Habacker `@rhabacker`
Assigned to **D-Bus Maintainers**
**[Link to original bug (#103435)](https://bugs.freedesktop.org/show_bug.cgi?id=103435)**
## Description
This task is intended to track required task for the DBus 1.12 release on Windows.
Currently the following tasks comes into my mind or has been raised by others:
1. Specify minimal supported os version and compiler
2. complete open bugs (for example [bug 99751](https://bugs.freedesktop.org/show_bug.cgi?id=99751))
2. Update website
3. Make binary packages for Windows (packages are currently in preparation at https://build.opensuse.org/project/show/home:rhabacker:branches:windows:mingw:win32:unstable)
4. Find a download location for binary packages e.g. https://dbus.freedesktop.org/releases/win or something else if not possible [1]
5. ....
[1] obs would also be possible in theory by using the following search https://software.opensuse.org/package/mingw32-dbus-1-portable?search_term=mingw32-dbus-1-portable for portable packages or https://software.opensuse.org/package/mingw32-dbus-1-portable?search_term=mingw32-dbus-1-installer for exe installer or specifing a direct link to a package but is currently limited to having 7z files or exe installer inside a rpm container. A fix requires to add a new "raw" repository format to obs which would make it possible to place the native packages into a sub dir of https://download.opensuse.org. If this is not possible or will be too much work, or may be rejected by the obs maintainer a release script is required to unpack the native packages and prepare the release as it has been done for KMyMoney (see https://cgit.kde.org/kmymoney.git/tree/maintainer/release-windows-packages)
Version: git masterWindows2. RFCFrom Bugzillahttps://gitlab.freedesktop.org/dbus/dbus/issues/150W32: dbus does not support SSPI-based authentication mechanisms2018-10-15T13:51:14ZBugzilla Migration UserW32: dbus does not support SSPI-based authentication mechanisms## Submitted by LRN
Assigned to **D-Bus Maintainers**
**[Link to original bug (#96577)](https://bugs.freedesktop.org/show_bug.cgi?id=96577)**
## Description
As discussed on dbus@lists.freedesktop.org ML, dbus could use
an actual OS-supported authentication on Windows (EXTERNAL on Windows
is a hack, DBUS_COOKIE_SHA1 has obvious drawbacks).
### Depends on
* [Bug 99512](https://bugs.freedesktop.org/show_bug.cgi?id=99512)Patch needs converting to MRWindows1. FeatureFrom Bugzillahttps://gitlab.freedesktop.org/dbus/dbus/issues/149Memory leak when running test-(d)bus test on Windows2018-12-20T16:13:05ZBugzilla Migration UserMemory leak when running test-(d)bus test on Windows## Submitted by yfei
Assigned to **D-Bus Maintainers**
**[Link to original bug (#95191)](https://bugs.freedesktop.org/show_bug.cgi?id=95191)**
## Description
Created attachment 123326
Log from running "nmake check" on Win64 build using VS2013.
When running test-dbus spawn, I get memory leak errors. Full unit test output is attached. Test was run in Win10 x64, VS2013 compiler, "nmake check".
**Attachment 123326**, "Log from running "nmake check" on Win64 build using VS2013.":
[LastTest.log](/uploads/3a1add486baccbb67fbe4e2182a24610/LastTest.log)
Version: 1.10Minor issueWindows1. BugFrom BugzillaRalf HabackerRalf Habackerhttps://gitlab.freedesktop.org/dbus/dbus/issues/89Running dbus as windows service2018-10-15T14:25:34ZBugzilla Migration UserRunning dbus as windows service## Submitted by Ralf Habacker `@rhabacker`
Assigned to **D-Bus Maintainers**
**[Link to original bug (#68741)](https://bugs.freedesktop.org/show_bug.cgi?id=68741)**
## Description
Created attachment 84892
Add dbus service helper application
The append patches implements a basic implementation for running dbus as windows service, which has been requested.
**Patch 84892**, "Add dbus service helper application":
[0001-Add-windows-service-handler.patch](/uploads/5a0962c3d5e267fea527e3c2e3042106/0001-Add-windows-service-handler.patch)
Version: 1.5
### Depends on
* [Bug 35311](https://bugs.freedesktop.org/show_bug.cgi?id=35311)Patch needs converting to MR3. Out of scopeWindows1. FeatureFrom Bugzillahttps://gitlab.freedesktop.org/dbus/dbus/issues/88various thread-safety issues involving static variables2018-10-15T14:29:26ZBugzilla Migration Uservarious thread-safety issues involving static variables## Submitted by Simon McVittie
Assigned to **Simon McVittie**
**[Link to original bug (#68610)](https://bugs.freedesktop.org/show_bug.cgi?id=68610)**
## Description
Created attachment 84714
_dbus_get_tmpdir: be thread-safe
Sharing a static variable between threads is not safe in general,
and this function is used in the shared libdbus (for nonce files),
so it can't rely on being single-threaded.
---
This patch probably only applies to master. For dbus-1.6, we can have a simpler patch, because _DBUS_LOCK() can't fail.
~~**Patch 84714**~~, "_dbus_get_tmpdir: be thread-safe":
[0001-_dbus_get_tmpdir-be-thread-safe.patch](/uploads/2a204aa5854bb934dc5240f0370f43a6/0001-_dbus_get_tmpdir-be-thread-safe.patch)
Version: 1.5Patch needs converting to MRMulti-threadingWindows1. BugFrom Bugzilla