[00:02:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3092449 (10jmatazzoni)
[00:04:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2841120 (10jmatazzoni)
[00:12:43] Success....? :/ https://usercontent.irccloud-cdn.com/file/si8Tv6c1/rcfilters-wbreponame.png
[00:15:21] Fixed all the 'all' vs '' failures
[00:15:33] And found that the three .replace() failures are likely from passing undefined to mw.msg()
[00:23:04] The remaining crash failure is to do with subsets but I'm a bit confused, the code looks suspicious (defines a cross-group subset, which is illegal) but also wasn't touched by this commit
[00:29:59] Found it, it's because the change in subset structure wasn't represented in the tests
[00:30:21] I also fixed the subset tests to make sense (i.e. not cross group boundaries) (cc mooeypoo)
[00:35:19] Ha I just found the cause of the group2filter2 failure: it was testing the search function, and label and description are messages now, so that test case was finding nothing in the prefix search stage and falling back to non-prefix search
[00:38:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: For Conflict States, short-circuit the fruitless searches so as to save processing effort - https://phabricator.wikimedia.org/T160220#3092526 (10jmatazzoni)
[00:43:04] I've now fixed all original failures, but the highlight tests started failing after I fixed the crash there. Going to debug that now
[00:50:34] Got it, it's because cssClass needs to be set
[00:57:01] ...and qunit is green :)
[01:00:04] matt_flaschen: I got QUnit to pass locally and pushed to Gerrit, crossing fingers that it'll pass on Jenkins. I understand how to fix the npm failures, and the phpunit failure is my fault. How far along are you with fixing those things (plus phpcs)?
[01:01:20] RoanKattouw, I did the phpcs, didn't do the JS whitespace stuff since you were doing QUnit, I'll upload what I have.
[01:01:38] OK cool
[01:01:41] Also did the minor PHPUnit due to subset changes
[01:01:45] Be sure to stash + fetch + unstash etc
[01:01:49] Thanks
[01:01:55] I'll fix the JS whitespace
[01:03:51] RoanKattouw, oh, whoops, missed that you pushed to Gerrit. I'll fix.
[01:05:08] OK. I got eslint passing locally (within my IDE at least), but I'll hold off until you push a patchset that readds my qunit fixes
[01:08:15] RoanKattouw, done, sorry about that.
[01:10:09] And done
[01:10:16] Let's see if this pleases the CI gods
[01:11:06] RoanKattouw, subset is supposed to have 'group' for consistency. I can see why it doesn't fail, but it should match. I'll fix.
[01:11:14] Ah, I see, sure
[01:12:59] Hmm
[01:13:04] 01:11:50 >> Loading documentation messages failed: "Error: Unable to parse "/home/jenkins/workspace/mediawiki-core-npm-node-6-jessie/src/languages/i18n/qqq.json" file (Unexpected string in JSON at position 232937).".
[01:13:04] 01:11:50 Warning: Unable to parse "/home/jenkins/workspace/mediawiki-core-npm-node-6-jessie/src/languages/i18n/qqq.json" file (Unexpected string in JSON at position 232937). Use --force to continue.
[01:13:55] RoanKattouw, missing comma, fixed.
[01:14:26] Uploaded
[01:14:40] Alright, watching Zuul retest now
[01:15:21] jq is a good checker for that, it tells you the line (instead of the character position in the whole file... :))
[01:15:33] What's jq?
[01:17:33] RoanKattouw, https://stedolan.github.io/jq/ . It's very nice, like a syntax-aware sed or grep for JSON.
[01:18:00] You can do mapping and walk the tree, etc. Good for looking at MW API results too.
[01:18:17] And if you just pipe a JSON file into:
[01:18:18] jq .
[01:18:24] (note period), it will do a syntax check and pretty-print it.
[01:21:02] RoanKattouw, and updating the extensions was enough to fix QUnit.
[01:21:15] OK good
[01:22:20] Aaah, ONE phpcs failure, fixing
[01:23:58] RoanKattouw, it's also wrong, that's why it missed the grep. Let me if you don't mind.
[01:24:04] MIssed the replace I mean.
[01:24:25] Sorry I fixed and pushed it already, but go ahead and fix my fix if needed
[01:24:47] My fix being https://gerrit.wikimedia.org/r/#/c/337546/21..22/includes/specialpage/ChangesListSpecialPage.php
[01:34:09] RoanKattouw, yeah, fix uploaded. Double-checked the others too.
[01:34:13] It was doing the wrong order for that one.
[01:37:05] RoanKattouw, it passes though. :)
[01:37:38] Right :)
[01:40:39] RoanKattouw, okay, what's next? T159786 is only assigned to me since I created a subtask and didn't notice, but it seems like a good candidate. Open to others, though.
[01:40:40] T159786: Update filter logging for refactoring - https://phabricator.wikimedia.org/T159786
[01:41:03] matt_flaschen: How ready are we to merge this big MW core change?
[01:41:24] There's something in the comments and commit msg about a back-compat redirect, but I can't say I care too much about it
[01:42:23] RoanKattouw, people might complain. We can have both merged before the train, though. Forgot about that, should I pick that up (Stephane was working on it earlier)?
[01:42:58] Stephane worked on it but his patch is a bit different from what I expected. But sure, pick that up. Any other qualms about merging this patch?
[01:43:13] (Or thoughts about when it should be merged?)
[01:43:38] matt_flaschen: Also, please review https://gerrit.wikimedia.org/r/#/c/341732/
[01:43:59] RoanKattouw, no. It's feature-complete, no reason to hold off.
[01:44:04] Cool
[01:44:43] RoanKattouw, cool, I'll finish the redirect patch then review the ORES.
[01:44:58] 17:44:42 (CR) Catrope: [C: 2] Back-end of new RecentChanges page, refactoring [core] - https://gerrit.wikimedia.org/r/337546 (https://phabricator.wikimedia.org/T152754) (owner: Mattflaschen)
[01:45:08] Excellent
[01:45:11] Sweet
[01:45:15] I'll also upload my WIP Wikibase patch
[01:45:27] The problem with it is this: https://usercontent.irccloud-cdn.com/file/si8Tv6c1/rcfilters-wbreponame.png
[01:46:44] And we can't export preprocessed messages to the client because then {{PLURAL}} won't work :/
[01:48:44] RoanKattouw, I think it's pretty easy to fix: mw.jqueryMsg.setParserDefaults
[01:48:48] That might need to be recursive extend, though.
[01:48:49] Ha! Nice
[01:48:58] OK, well I'll upload the patch and comment that
[01:49:02] I used to work on jQueryMsg in the Before Times.
[01:49:15] But then I'll head out, it's Friday night and friends are dragging me to things
[01:49:23] haha yeah that's right, I'd forgotten
[01:49:48] RoanKattouw, cool, I'll fix that too.
[01:49:55] Have a good weekend.
[01:51:06] RoanKattouw, on Monday or whenever, can you add https://gerrit.wikimedia.org/r/#/c/341105/ and https://gerrit.wikimedia.org/r/#/c/341110/ to your review queue? They're not WMF-deployed, but it's a fix to a breaking change.
[01:51:10] matt_flaschen: Thanks. https://gerrit.wikimedia.org/r/342294 is the Wikidata patch
[01:51:16] (From my backend patch)
[01:51:41] Sure
[01:51:45] RoanKattouw, do you have Wikidata working BTW, or just enough to test this?
[01:51:49] It didn't use to work on Vagrant.
[01:51:50] s/Monday/Tuesday/ ! Don't forget Monday is a (fake) holiday
[01:51:56] And! Happy Purim
[01:52:06] Thanks. :)
[01:52:20] The sun hasn't quite set here yet, but it's been Purim for a couple hours for you already
[01:52:41] I got it working well enough to test
[01:52:51] vagrant enable-role wikidata; vagrant provision worked
[01:52:52] RoanKattouw, no, tomorrow, you double-corrected.
[01:53:07] Cool
[01:53:11] I mean it took my entire lunch break, but it worked well enough for the RC thing
[01:53:22] Wait really? Purim isn't on Sabbat?
[01:53:44] RoanKattouw, it starts immediately after Shabbat this year, no correlation in general.
[01:53:51] Oh, I see, OK
[01:54:55] I might poke at the jquerymsg thing later tonight too
[01:55:00] Anyway, good long weekend everyone
[01:55:13] I'll also send an email to Benoît later telling him a bunch of translatable messages just appeared
[01:55:56] Congrats all.
[01:56:23] Thanks, James_F
[03:33:33] Have a good weekend everyone.
[09:16:12] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New User Landing Page - Article Creation Workflow - https://phabricator.wikimedia.org/T156442#3093006 (10Kudpung) Why is this still being shunted around from one dev to another as if its a 'w e l l... i...
[10:15:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: `$wgAllowCategorizedRecentChanges = true` and using the "Limit to categories" input on Special:RecentChanges no longer works (PHP except... - https://phabricator.wikimedia.org/T160214#3092381
[11:28:38] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New User Landing Page - Article Creation Workflow - https://phabricator.wikimedia.org/T156442#3093067 (10Stevietheman) This proposal didn't make the top 10, thus it's not a core Foundation priority, but I thin...
[12:45:42] 06Collaboration-Team-Triage, 10Notifications: HTML email notifications caught by spam filters - https://phabricator.wikimedia.org/T54915#3093091 (10Liuxinyu970226)
[15:26:53] 06Collaboration-Team-Triage, 10Flow, 07I18n, 13Patch-For-Review, 07Technical-Debt: Flow provides custom i18n messages which duplicate core i18n messages - https://phabricator.wikimedia.org/T158526#3093193 (10SamanthaNguyen) 05Open>03declined Per comment by @Mattflaschen-WMF
[15:34:50] 06Collaboration-Team-Triage, 10Flow, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572#3093202 (10MarcoAurelio) Just FYI Globa...
[15:58:19] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New User Landing Page - Article Creation Workflow - https://phabricator.wikimedia.org/T156442#3093251 (10Kudpung) "The Top 10'? You mean that 'letter to Santa' of convenience gadgets? Forgive me for reminding...
[17:02:30] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Community-Wishlist-Survey-2016: New User Landing Page - Article Creation Workflow - https://phabricator.wikimedia.org/T156442#3093262 (10Stevietheman) Kudpung, I don't see how comments like yours are constructive, much less advance this alon...
[23:48:36] 06Collaboration-Team-Triage, 10Flow, 07Chinese-Sites: Make &action=purge useful on flow board descriptions - https://phabricator.wikimedia.org/T160265#3093506 (10Arthur2e5)