Activity

So this is an API change. It will break all existing implementations of GTRenderer, in particular afaik the patch does not care for the shapefile renderer.
I also see that the patch removes some c coding style bits with more java like ones (David B. used to code in java as it that was C in fact), but I'm unsure if all of them are actually equivalent. See this bit:

Maybe it is equivalent but after 10 hours of work I'm too tired to tell :-p
Allow me some more time to look into the patch. Maybe next time split it into two, code cleanups in one patch, api changes in the other.

Andrea Aime
added a comment - 05/May/11 12:51 PM So this is an API change. It will break all existing implementations of GTRenderer, in particular afaik the patch does not care for the shapefile renderer.
I also see that the patch removes some c coding style bits with more java like ones (David B. used to code in java as it that was C in fact), but I'm unsure if all of them are actually equivalent. See this bit:
{code}
// skip layers that do have only one fts
- if(layer.getStyle().getFeatureTypeStyles().length < 2)
+ if (!(layer instanceof FeatureLayer)) {
continue;
+ }
+ FeatureLayer featureLayer = (FeatureLayer) layer;
+
+ if (featureLayer.getStyle().featureTypeStyles().size() < 2) continue;
+
{code}
Maybe it is equivalent but after 10 hours of work I'm too tired to tell :-p
Allow me some more time to look into the patch. Maybe next time split it into two, code cleanups in one patch, api changes in the other.

Hi Jody, did you also prepare an equivalent patch for GeoServer?
To evaluate the updated set of classes for good the only realistic way is to switch something that uses them heavily, you have seen the amount of chaos the previous set of classes caused.
Btw, the patch you attached has a ton of commented out blocks and a number of unrelated changes that are probably due to encoding issues, those need cleaning up.

Andrea Aime
added a comment - 25/Jun/11 1:52 AM Hi Jody, did you also prepare an equivalent patch for GeoServer?
To evaluate the updated set of classes for good the only realistic way is to switch something that uses them heavily, you have seen the amount of chaos the previous set of classes caused.
Btw, the patch you attached has a ton of commented out blocks and a number of unrelated changes that are probably due to encoding issues, those need cleaning up.

This one fixes a mistake in the previous patches: if one sets a map context using setContext(), getContext() must return the same object, there is no guarantee it's goind go be a plain MapContext(), in the case of GEoServer it's a subclass with extra infos

Andrea Aime
added a comment - 02/Jul/11 6:06 AM This one fixes a mistake in the previous patches: if one sets a map context using setContext(), getContext() must return the same object, there is no guarantee it's goind go be a plain MapContext(), in the case of GEoServer it's a subclass with extra infos