Clojure JIRAhttp://dev.clojure.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+TRDR+AND+resolution+%3D+Unresolved+ORDER+BY+updated+DESC
An XML representation of a search requesten-us4.464925-07-2011RE: [TRDR-14] Feature Expressions
http://dev.clojure.org/jira/browse/TRDR-14?focusedCommentId=37521#comment-37521
Wed, 21 Jan 2015 16:34:24 -0600Alex Miller
<p>Attached new patch trdr-14-4.diff that uses an explicit options map with a :features key to a set of features. These changes match the latest changes in clj-1424, which are patterned after a similar implementation in the Clojure edn reader.</p>
<br/>
<br/>
<table>
<tr>
<td>Author:</td>
<td><a
href="http://dev.clojure.org/jira/secure/ViewProfile.jspa?name=alexmiller">Alex Miller</a>
(<a href="http://dev.clojure.org/jira/browse/TRDR-14">TRDR-14</a>)</td>
</tr>
</table>
http://dev.clojure.org/jira/browse/TRDR-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=37521\#worklog-37521RE: [TRDR-14] Feature Expressions
http://dev.clojure.org/jira/browse/TRDR-14?focusedCommentId=35266#comment-35266
Mon, 4 Aug 2014 12:56:57 -0500Alex Miller
<p>Updated patch to reflect clj and cljs as initial feature names.</p>
<br/>
<br/>
<table>
<tr>
<td>Author:</td>
<td><a
href="http://dev.clojure.org/jira/secure/ViewProfile.jspa?name=alexmiller">Alex Miller</a>
(<a href="http://dev.clojure.org/jira/browse/TRDR-14">TRDR-14</a>)</td>
</tr>
</table>
http://dev.clojure.org/jira/browse/TRDR-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=35266\#worklog-35266RE: [TRDR-14] Feature Expressions
http://dev.clojure.org/jira/browse/TRDR-14?focusedCommentId=34695#comment-34695
Mon, 19 May 2014 19:23:46 -0500Ghadi Shayban
<p>Yes thank you for not merging. This is WIP and just one approach for feature expressions. There seem to be at least two couple diverging approaches emerging from the various discussion (Brandon Bloom's idea of read-time splicing being the other.) I would definitely not merge until the community and Rich weighs in.</p>
<p>In any case having all Clojure platforms be ready for the change is probably essential. Also backwards compatibility of feature expr code to Clojure 1.6 and below is also not trivial.</p>
<p>1) &#42;suppress-read&#42; probably doesn't need to be exposed<br/>
2) &#42;suppress-read&#42; should probably imply &#42;read-eval&#42; false. You wouldn't want read-ctor to load any classes or call any code or constructors</p>
<br/>
<br/>
<table>
<tr>
<td>Author:</td>
<td><a
href="http://dev.clojure.org/jira/secure/ViewProfile.jspa?name=gshayban">Ghadi Shayban</a>
(<a href="http://dev.clojure.org/jira/browse/TRDR-14">TRDR-14</a>)</td>
</tr>
</table>
http://dev.clojure.org/jira/browse/TRDR-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=34695\#worklog-34695RE: [TRDR-14] Feature Expressions
http://dev.clojure.org/jira/browse/TRDR-14?focusedCommentId=34694#comment-34694
Mon, 19 May 2014 18:57:12 -0500Nicola Mometto
<p>I looked over the patch and it mostly looks good, a few comments:</p>
<ul>
<li>does &#42;suppress-read&#42; need to be exposed?</li>
<li>can you add a docstring for &#42;features&#42;?</li>
<li>should &#42;suppress-read&#42; affect read-eval?</li>
</ul>
<p>That said, has it been decided that this is how feature expressions will be implemented in 1.7?<br/>
If not, I'm going to wait to merge this in until a decision is taken, this is a major design point and I don't want to diverge from the official clojure take on this even for a single release: people might start using it, especially since t.r is now the default reader for cljs.</p>
<br/>
<br/>
<table>
<tr>
<td>Author:</td>
<td><a
href="http://dev.clojure.org/jira/secure/ViewProfile.jspa?name=bronsa">Nicola Mometto</a>
(<a href="http://dev.clojure.org/jira/browse/TRDR-14">TRDR-14</a>)</td>
</tr>
<tr>
<td>Edited by:</td>
<td><a href="http://dev.clojure.org/jira/secure/ViewProfile.jspa?name=bronsa">Nicola Mometto</a></td>
</tr>
</table>
http://dev.clojure.org/jira/browse/TRDR-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=34694\#worklog-34694