On Wed, 2008-07-16 at 15:15 +0200, Ingo Molnar wrote:> * Ingo Molnar <mingo@elte.hu> wrote:> > > > scsi_cmnd.h depends on symbols defined in blkdev.h. The fix is to > > > include blkdev.h as well.> > > > that wont work - a better replacement fix is the one below. The > > problem is that scsi.h is included even on !CONFIG_BLOCK and then the > > BLK_MAX_CDB symbol is meaningless.> > -v3 .. the new methods need to be under #ifdef CONFIG_BLOCK as well. > Note my patch is just a quick RFC, this can probably be done cleaner.

Erm, Ingo, if you'd just follow linux-next instead of your own tree,you'd see there's already a fix for this.

In file included from linux-next-20080708/include/scsi/scsi.h:12, from linux-next-20080708/fs/compat_ioctl.c:71:linux-next-20080708/include/scsi/scsi_cmnd.h:27:25: warning:"BLK_MAX_CDB" is not definedlinux-next-20080708/include/scsi/scsi_cmnd.h:28:3: error: #errorMAX_COMMAND_SIZE can not be bigger than BLK_MAX_CDBIn file included from linux-next-20080708/include/scsi/scsi.h:12, from linux-next-20080708/fs/compat_ioctl.c:71:linux-next-20080708/include/scsi/scsi_cmnd.h: In function'scsi_bidi_cmnd':linux-next-20080708/include/scsi/scsi_cmnd.h:182: error: implicitdeclaration of function 'blk_bidi_rq'linux-next-20080708/include/scsi/scsi_cmnd.h:183: error: dereferencingpointer to incomplete typelinux-next-20080708/include/scsi/scsi_cmnd.h: In function 'scsi_in':linux-next-20080708/include/scsi/scsi_cmnd.h:189: error: dereferencingpointer to incomplete type