Please note

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

This comment has been minimized.

Couple of reasons: the interface name is not presented in snmp - this needs to be reconstructed in code. I tried using yaml, and can get the information off the box, but can't create meaningful labels for the UI. Is there a way of using $pre_cache[] array data in yaml? If so, this might solve that problem.

Also, these devices don't have any of the usual IF-MIB contents. All these interface instances need to be reconstructed from several other entity tables in the coriant mib.

This comment has been minimized.

You can actually precache data in yaml file and use other fields to build descriptions. You can look at includes/definitions/discovery/vrp.yaml which precaches entPhysicalName to group each SFP rx and tx power, for instance.
It is clearly not as powerful as coding, so if needed, you are perfectly correct to code instead of Yaml.

This comment has been minimized.

i looked at vrp.yaml for some ideas, but it wasn't as flexible as needed. There was an additional complication because the network interface indexes were non numeric, which meant that this needed to be simulated in code.

If the yaml processing code is looked at in future, it would be great to see coded pre-cache data available in the yaml configs - if this happened, a good chunk of this code could be replaced by yaml.

otherwise, I've updated the test data and this is running clean. I also did a rename + logo change because Coriant got bought out by Infinera. i.e. no further substantial changes planned on this side for this pull request.

lockbot
locked as resolved and limited conversation to collaborators
May 3, 2019

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.