Sweet - I got 2.2 working in the ancient Grafpup 1.04 just by installing it and gxmessage and GTKdialog3 and copying over a new version of find (you have to copy it at every boot because of the way Puppy 1.x uses unionfs)
N.B. that when I mention bugs and stuff below they are not specific to Puppy 1 - I would not report them if they were. They all show up in 2.16.
--------------------------------------

Here's a modified version of Pfind that I've done

Changes:
I added a "Show location" function, to open the location of the selected file in ROX.

I made double-clicking on a file open it by default in whatever way it would be opened if you double-clicked on it in ROX. (You can still add custom MIME-types for Pfind).

I added an "Open as text" function for the selected file.

I added a "Send to Trash" function for the selected file

I fixed gui spelling errors in what was line 462 of Pfind (advansed), and macthed or macthing or something somewhere , and seperate in line 25 of pfind.txt

I modified line 4 of all the func_ files (and another line in func_run) so they handle files with spaces in the path correctly (please tell me if I'm misunderstanding something and shouldn't have done that).
------------------------------------

Further improvements I think could be made if anyone feels like it and can figure out how:

A "move file to..." feature would probably be fairly easy to do.

Ideally it might be good if the copy/link/rename dialogues could use the gtk dialogue that allows you to navigate directories - although in some ways I prefer the way it is done at the moment.

These improvements would probably have the most benefit to the end user:
How can we keep the Search Results window maximised when you click on a button to show only a certain type of file? Also, why (in JWM) when you first maximise it, does it maximise for a fraction of a second, then unmaximise, leaving a small gap at the top of the screen?

Can we do anything about the fact that when the file manager features are used (copy/link/delete), the results window goes back to showing all file types? (I'm wondering if they just need to be converted to the same format as the func_ files)

It would be good to have your previous search term stay in the search bar when you used advanced search, rather than

If you use advanced search and select an action other than show summary, it does not work correctly. Also the feature to find image files or music files etc does not seem to always work.

Once you have run a search, there is also a problem with instances of Pfind, Gtkdialog and gxmessage staying around after you close Pfind. If you kill some of them with kp before killing the Pfind instances, you get things happening again - new Pfind results windows popping up, music players opening to play lists - whatever you did before closing Pfind. So something clearly isn't exiting correctly. I read what Zigbert said about Gtkdialog above, but you also get instances of Pfind itself still there.

Minor Bugs:

If Pfind finds a large number of files (several thousand in Puppy 2.16, but several hundred in Grafpup 104 - that's how I noticed) then nothing shows up in the results pane. This does not appear consistent - sometimes it will show with more results than there are when it won't show other times. I guess maybe it is not actually the number of results, but something in the filenames or something.

I also have a strange situation where if I search for music files on one of my (FAT32) drives, it only shows me one file, but it plays all of them, except that Gxine complains that it can't play most of the mp3s in one particular folder. But it can normally play these files - very strange.

BTW the help states that it won't show results in file manager mode if some results have < or > in the path, but there must be another illegal character or something, as sometimes if you remove results with these, then it still won't show them in file manager mode.

BTW does anyone know what the deal is with the icons used in Pfind? Are they built in to gtkdialog3 or something? I can't find them. How can I get a copy of one?

disciple
Nice work. I will start working on a major upgrade, but now Pbackup has the attention.

- I'll look through the code, and incorporate (maybe all of) it. I'm very pleased with the use of Rox-MIME types. My todo-list is now shorter.
- The critical issue is about instances. I got a sort of solution. It still doesn't kill prosess, but it keeps Pfind stable even if older prosesses is running.
- The icons are all gtk-builtin.
- I will try to get rid of gxmessage, and only use gtk-dialog (and xdialog for calender).

I tweaked this a little more using disciple's modified package. I got rid of all of the instances of xdialog and changed them to gtkdialog. I also modified where the temp files go so pfind can be run on a multi-user system (a non-root user won't be able to delete the root owned files in /tmp/). When writing programs we should try to use $HOME as opposed to /root so these scripts can be easily ported to other distros. I put the pfindrc & pfindMIME files in the same directory as the rest of pfind and then they get copied to $HOME/.config/pfind/ (if they aren't already there) when pfind is ran. I'll post my modifications in a little while incase you want to incorporate them too.

Ok, here are my modifications. I also moved the pfind directory to /usr/local/apps/Utility/Pfind/ for the sake of grafpup. I tweaked the pfind script a little more to work right in Ubuntu. For some reason it chokes on the "echo -e whatever > /tmp/somefile". It will add the "-e" into the temp files. I just changed the "echo -e" to "echo" in every instance where it pipes into a temp file. It does the same thing with the "echo -e "\c"". Is there a reason to have the "c" at the begining of the temp file? The package I posted doesn't have the modifications to the echo lines.

Jason - since you're into making it work in Grafpup, do you know if it's possible to get the "act on list" button for image files to work with xnview? For some reason I can get it to show them all in xnview, but it doesn't like something about the links, and shows me a generic icon, instead of thumbnails.

Also, your version doesn't seem to work with gtksee, because the links are inside a hidden folder.---EDIT--- no - I just missed the option to view hidden files in GTKSEE.

OH NO - I just discovered that the #s in .pfindMIME aren't actually commenting things out - e.g. with the file as we had it, if I double-click on a jpg it opens in Gimp, but if I remove the

Code:

#jpeg=defaultpaint
#jpg=defaultpaint

lines, then it will open in xnview, like it does when I click on it in ROX. I thought it was working before, but maybe I only tried file types that weren't in .pfindMIME.

You cannot post new topics in this forumYou cannot reply to topics in this forumYou cannot edit your posts in this forumYou cannot delete your posts in this forumYou cannot vote in polls in this forumYou cannot attach files in this forumYou can download files in this forum