[00:01:13] Japan looks good so far, nothing in Zendesk, high success rate @ Adyen console
[00:01:33] Good times
[00:01:34] Thanks MBeat!
[00:06:12] (PS1) Awight: Kill any configured fraud checks before making recurring charges [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487)
[00:07:31] (Abandoned) Awight: Give the orphan gateway its own globals prefix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306277 (https://phabricator.wikimedia.org/T131275) (owner: Awight)
[00:27:38] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 7 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2578014 (awight) The new production...
[00:33:46] (PS2) Awight: Kill any configured fraud checks before making recurring charges [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487)
[00:37:52] headed out for the nite... bye!
[02:04:37] MBeat: delayed reaction "thanks!" Missed that message in the stream. The test has been over for 30 minutes; I'll send an email
[02:48:12] spatton: dude this is late for you
[02:48:50] HAPPY BIRTHDAY!
[02:49:09] I'd say the same but it's painfully obvious, Mr. 3am
[03:26:18] (Abandoned) Cdentinger: WIP smashpig paypal listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/305172 (owner: Cdentinger)
[10:36:34] Fundraising-Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2578568 (Aklapper) @Eileenmcnaughton, @DStrine: Can someone answer T141326#2498383 (and/or actually link an account on the Staff page)?
[11:11:18] Fundraising-Backlog: "Your transaction could not be accepted" errors when loading Japan form - https://phabricator.wikimedia.org/T143776#2578640 (Pcoombe)
[11:11:39] Fundraising-Backlog: "Your transaction could not be accepted" errors when loading Japan form - https://phabricator.wikimedia.org/T143776#2578653 (Pcoombe) p:Triage>High
[11:17:34] Fundraising-Backlog: "Your transaction could not be accepted" errors when loading Japan form - https://phabricator.wikimedia.org/T143776#2578676 (Pcoombe)
[12:03:48] Fundraising-Backlog, Hovercards, MediaWiki-extensions-CentralNotice, Reading-Web-Backlog: Measure impact of HoverCards on Central Notice interaction - https://phabricator.wikimedia.org/T131366#2578784 (ovasileva) Whoo, thank you, @Pcoombe! I agree - we should test on other wikipedias and compare,...
[12:48:22] (CR) Ejegg: [C: -1] "Definitely less disruptive than the orphan prefix change. You could get away with just the session velocity and custom filters, since cust" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487) (owner: Awight)
[12:49:49] (CR) Ejegg: "Ooh, and you'll need to implement runHooks under WmfFramework.drupal.php to get any fraud checking for the orphans! Then this patch could " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487) (owner: Awight)
[13:44:40] (PS7) Ejegg: WIP damaged message table UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305744 (https://phabricator.wikimedia.org/T142058)
[15:15:18] Fundraising-Backlog, WMF-NDA-Requests: Add Eileenmcnaughton to the NDA list #WMF-NDA - https://phabricator.wikimedia.org/T141326#2579157 (DStrine) @Aklapper It looks like you are using other accounts to verify a user's identity. I have seen on multiple occasions that OIT and basic on-baording did not s...
[15:30:10] (PS1) Ejegg: Reject isRequeue messages after expiry [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306450 (https://phabricator.wikimedia.org/T142028)
[16:06:23] AndyRussG: are you around?
[16:15:11] dstrine: yeah I'm here :)
[17:02:22] I guess tech talk is bumped by retro this morning?
[17:02:26] "morning"
[17:02:44] Oh, right, retro.
[17:02:59] or mebbe not?
[17:03:50] Hey ah, can anyone irc me the retro hangout link?
[17:04:56] Fr-tech ^
[17:05:57] awight: one sec
[18:03:31] (PS1) Ejegg: runHooks for drupal WmfFramework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306478 (https://phabricator.wikimedia.org/T141486)
[18:04:31] (CR) Ejegg: "took a stab at runHooks for drupal: Ie736128279b6" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487) (owner: Awight)
[18:37:33] ls
[18:37:36] derp
[18:37:48] hi fr-tech!
[18:38:01] hi ejegg!
[18:39:04] discovering anything terrifying while UML-ing out ecosystem AndyRussG ?
[18:40:58] ejegg: terrifying no.... interesting, yes :)
[18:41:15] Basically, that mid-level things need more names
[18:42:04] to facilitate the extraction and registry of knowledge in ur brainz!!!
[18:42:16] So the concepts of installed ap vs codebase
[18:43:27] Right... smashpig is certainly ambiguous there
[18:43:36] library + web app
[18:43:36] so we can distinguish "Smashpig" the codebase from the various places and ways Smashpig works as an application or as part of another app
[18:43:39] yeah
[18:43:57] I mostly think of it as a library
[18:44:08] Yeah! it mostly is, as far as I've seen sofar
[18:44:31] It might be healthy to do the ol', extract each independent module into its own repo
[18:44:34] Another thing is the concept of workflow. I'd like to see some explicit naming and description of the types of workflows
[18:44:37] so annoying though
[18:44:45] yea not always easy...
[18:44:58] Cool! Yeah workflows and data flows
[18:45:47] AndyRussG: have you been looking at any of the processor documentation?
[18:45:59] So yeah with workflows, while everyone familiar with the code knows what category of workflows each processor has, I think it isn't discussed explicitly as such much (I may be wrong) and those categories I don't think are in the code
[18:46:20] ejegg: I have the Adyen flow doc... I guess there's probably more, these are all partial and surely in many ways mistaken impressions!!!
[18:46:49] The other thing that I think needs some naming is the phases of the workflow
[18:47:11] It can be overwhelming - we only use a small bit of any processor's API
[18:47:13] The PSPs have some of their own documentation that touches on the workflows on their end
[18:47:35] ejegg: au u mean the documentation provided by the processors... Yeah not much, just a bit of PP!
[18:47:39] But it would be great to also show how our workflow interacts with that
[18:47:47] awight: yeah!
[18:48:03] do we have a set of links to that onwiki any place? I know there's a trove on the fileshare
[18:48:06] Ingenico provides state machines for various payment methods, not bad stuff
[18:48:22] ejegg: I only know of the filesrv
[18:48:25] Phases are like verticals or horizontals or whatever... If I understand correctly, each workflow has an initial data-collection-from-user phase
[18:48:45] Then there is the receiving follow-up info from the processor phase
[18:49:04] Then the putting all that info together phase
[18:49:09] :D
[18:49:18] Music to my eyes
[18:49:25] Dunno if the audit phase should be seen as separate, or as part of the last one... Don't understand it too well yet
[18:49:25] nice
[18:49:51] Having these general concepts would help us see how and why different workflow categories and specific processor workflows are different
[18:50:29] and I think would help at least me keep a map in my brain of what's working how, where and why :)
[18:50:53] This is thrilling but still, I'll always be nostalgic for K4's https://wikitech.wikimedia.org/wiki/Fundraising#/media/File:DonationPipeline_201302.png
[18:51:34] :)ML
[18:51:41] heh glad it sounds useful!! just some silly dishwashingthoughts
[18:52:05] Yeah K4's pic has shows the real flavour, which the formal diagrams will never get 8p
[18:52:27] Maybe we can ask a grafitti artist to spice it up
[18:52:46] K I'm guessing u have someone in mind ;p
[18:53:14] The listener workflows are all pretty similar, I guess
[18:53:30] Yeah! exactly :)
[18:54:08] So basically the UML diagrams can be multiple views on the processes, slicing 'em differently to show up different facets
[18:54:32] mmm. although the message-specific processing might be work their own submachines
[18:54:36] anyway that's the lofty goal I have in mind
[18:56:08] yeah there are some aspects shown up by a sequence/interaction diagram, and others I think activity diagrams, that don't put the actors so much in the foreground, will work best for
[18:56:20] wish I was further along!!!! apologies for taking so long with it....
[18:57:01] I'm putting links to processor doc pages on our mediawiki.org page
[18:59:03] AndyRussG: want to pair diagram with other techsen at any point?
[18:59:10] ejegg: cool beans, thx!!!
[18:59:39] awight: yes.... sooooon, yeah!! that'd be a big help
[18:59:54] I also have scrappy stabs I've taken at UMLling fundraising things which I should manifest
[19:00:07] * awight rummages through desk
[19:00:15] k, some links are here https://www.mediawiki.org/wiki/Fundraising_tech#Documents
[19:04:10] ejegg: nice!!!
[19:18:26] A little CR if there are takers: https://gerrit.wikimedia.org/r/#/c/306310/
[19:18:55] oops I see ejegg already read thru it
[19:19:52] ejegg: I don't think custom filters runs those others...
[19:20:02] check extension.json::Hooks
[19:20:26] Ah! runHooks, thank you
[19:20:38] * awight is linear
[19:21:52] awight: yeah, hooks running hooks :(
[19:22:58] oh, but IP Velocity does something on GatewayPostProcess
[19:26:40] (CR) Awight: [C: -1] "Oh wow, and we also have to duplicate the extension.json Hooks block, by assigning to a legacy $wgHooks global (already deprecated in Medi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306478 (https://phabricator.wikimedia.org/T141486) (owner: Ejegg)
[19:30:24] (CR) Ejegg: "k, i'll try that. looks like we aren't messing with the hooks in config." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306478 (https://phabricator.wikimedia.org/T141486) (owner: Ejegg)
[19:40:20] (CR) Awight: "Just realized that the patch would have to be reversed if we implemented hookRegister as we were discussing. In that case, the equivalent" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487) (owner: Awight)
[19:42:34] (CR) Ejegg: "Hmm, or if we've got direct switches like this, and don't actually change the hooks in config, we might as well just call the functions di" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306310 (https://phabricator.wikimedia.org/T141487) (owner: Awight)
[19:43:45] ejegg: Now that's a thought.
[19:44:16] yah, would make stepping through stack traces easier!
[19:44:29] hey all I'm going to be a few minutes late as it's Richard's birthday & the kids have cards to give him
[19:44:32] What would the configuration look like? We just add an Enable flag for each function?
[19:44:49] yep, we already have that though, right?
[19:44:50] eileen: fun! also, I think we're still 2 hours away from standup
[19:45:03] ejegg: I think some of the custom filters are exempt
[19:45:34] oh wait standup is still late today? (2pm pst?)
[19:45:52] Yea, I think we're on 2:03 standup for today.
[19:45:58] Early one starts tomorrow.
[19:46:05] cool cool
[19:52:45] omg, the dreaded > E: Archives directory /vagrant/cache/apt/partial is missing. - Acquire (2: No such file or directory)
[19:52:55] * awight stands very still
[19:53:41] disable vbguest autoupdate
[19:54:09] O_o
[19:54:17] Thank you, o oracle
[19:54:40] in ~/.vagrant.d/Vagrantfile put -- Vagrant.configure("2") do |config| \n config.vbguest.auto_update = false \n end
[19:54:44] * awight leaves another burning sage leaf
[19:54:53] its a really annoying problem
[19:55:14] maybe we should just rip that update plugin out all together
[19:55:26] +1 if it's just for apt.
[19:55:44] (PS2) Ejegg: runHooks and registerHooks for drupal WmfFramework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306478 (https://phabricator.wikimedia.org/T141486)
[19:55:45] Does the VM's native apt cache the same way as the vagrant thing?
[19:56:39] so the trick we are trying to accomplish there is sharing the downloaded debs across vm rebuilds (vagrant destroy; vagrant up)
[19:57:29] and it works except when the plugin we install to keep the VM's kernel extensions for talking to virtualbox fires on an already provisioned vm
[19:57:39] that is a noble goal
[19:57:40] then it all goes to shit
[19:57:44] * cwd glares at verizon jet pack
[19:57:45] Oh looks like we are on the later stand up time today anyway
[19:58:23] because the plugin purposefully runs before mounts and our puppet code has told apt that a directory will exist that doesn't
[20:15:03] oh sigh, I lost the nfs mount somehow. I hate when tools fall on the floor
[20:20:16] i prefer the non-nfs option which uses ihavenoideawhat
[20:31:22] (PS1) Ejegg: Remove unnecessary hooks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306519 (https://phabricator.wikimedia.org/T141486)
[20:32:21] fr-tech: what do you think of tearing out most of the hooks and just calling functions? ^^^
[20:32:42] ejegg: It looks great! Still reading though...
[20:33:04] heh, quick on the draw
[20:35:27] ejegg: Can I build something on that?
[20:35:41] sure, go for it!
[20:36:57] oh, let me fix a few more comments and var names
[20:37:01] awight: ^^
[20:37:02] k
[20:42:05] (PS2) Ejegg: Remove unnecessary hooks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306519 (https://phabricator.wikimedia.org/T141486)
[20:42:12] bd808: Looks like the .vagrant.d fix works, thanks again!
[20:44:29] ejegg: Ahh nvm about the follow-on patch, I'm blocked from trying this experiment by the lack of a shared config/
[20:44:36] arr
[20:45:13] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 3 others: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#2580474 (DStrine)
[20:46:25] well, there's that and the WmfFramework::registerHook patch https://gerrit.wikimedia.org/r/306478 for you to choose from to get the orphan thing running
[20:46:35] Fundraising-Backlog, Epic, Technical-Debt: [epic] Migrate fundraising extensions to the new format - https://phabricator.wikimedia.org/T95832#2580479 (awight) Open>Resolved a:awight
[20:47:20] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 4 others: Spike: Monitor deployment rolling back our "googleoff" tag - https://phabricator.wikimedia.org/T137761#2580482 (DStrine)
[20:49:34] ejegg: Thanks for taking the time to help!
[20:49:48] my pleasure!
[20:49:54] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, and 2 others: Donations message with empty body! - https://phabricator.wikimedia.org/T140515#2580491 (DStrine)
[20:50:09] for the longer-term fix, I'm trying to detail the use cases on https://etherpad.wikimedia.org/p/fr-tech-talk
[20:50:58] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 2 others: Handle refund mismatch more correctly - https://phabricator.wikimedia.org/T138542#2580492 (DStrine)
[20:51:25] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, and 2 others: CiviCRM dedupe causes runaway query - https://phabricator.wikimedia.org/T139964#2580493 (DStrine)
[20:52:06] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi reports: add filter for "is deceased" - https://phabricator.wikimedia.org/T140831#2580511 (DStrine)
[20:52:34] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface, Spike: Spike: Reconcile SmashPig and DonationInterface configuration - https://phabricator.wikimedia.org/T143831#2580512 (awight)
[20:52:36] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Disabled campaigns are causing messages to be rejected: '\'C15_Email1\' is not a valid o... - https://phabricator.wikimedia.org/T139969#2580524
[20:55:00] (CR) Eileen: [C: 2] "Yes - definitely! Good catch" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306239 (owner: Ejegg)
[20:55:36] thanks eileen !
[20:57:34] (CR) Awight: [C: 2] "Awesome! (and rapidly whipped up!)" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306519 (https://phabricator.wikimedia.org/T141486) (owner: Ejegg)
[20:57:49] brb
[21:00:26] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 3 others: Investigate Civi Load Time issue - https://phabricator.wikimedia.org/T138334#2580558 (Eileenmcnaughton) Shall we add a second ticket & close t...
[21:02:11] (Merged) jenkins-bot: Fix bug re-activating utm_campaign entries [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306239 (owner: Ejegg)
[21:02:13] (Merged) jenkins-bot: Remove unnecessary hooks [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306519 (https://phabricator.wikimedia.org/T141486) (owner: Ejegg)
[21:09:14] (Abandoned) Ejegg: runHooks and registerHooks for drupal WmfFramework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/306478 (https://phabricator.wikimedia.org/T141486) (owner: Ejegg)
[21:13:15] (CR) Ejegg: [C: 2] Minor cleanup using override() [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306166 (owner: Awight)
[21:14:02] (Merged) jenkins-bot: Minor cleanup using override() [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/306166 (owner: Awight)
[21:19:36] (PS6) Ejegg: Quit deleting from pending queue, stop saying limbo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301630 (https://phabricator.wikimedia.org/T133433)
[21:21:25] (CR) jenkins-bot: [V: -1] Quit deleting from pending queue, stop saying limbo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301630 (https://phabricator.wikimedia.org/T133433) (owner: Ejegg)
[21:25:25] (PS7) Ejegg: Quit deleting from pending queue, stop saying limbo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/301630 (https://phabricator.wikimedia.org/T133433)
[22:23:23] (CR) Eileen: [C: 2] FIXME [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/305580 (owner: Ejegg)
[22:47:30] Is the gerrit remote heck of slow for anyone else?
[22:48:02] I guess the really weird part is that the ssh URL works fine, but https is a snailfest
[22:48:34] (PS1) Awight: Let DI globals come from configuration files. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306575 (https://phabricator.wikimedia.org/T141487)
[22:49:16] Gonna wander to the taco truck...
[22:52:00] (CR) jenkins-bot: [V: -1] Let DI globals come from configuration files. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/306575 (https://phabricator.wikimedia.org/T141487) (owner: Awight)
[22:58:56] curses! Blocked in by various trucks
[23:02:57] rival food trucks?
[23:03:46] Hehe, that is the sort of tragedy that strikes around here
[23:04:00] but no, I apparently have art truck problems
[23:08:11] trying this another way...
[23:09:38] slashing NEA funding?
[23:18:55] ejegg: so as far as understanding adam's last patch there, i see that it removes a bunch of globals but don't understand what they are replaced with. config files in the imported modules?
[23:20:08] i think so...
[23:20:45] hehe well i'm glad it's not immediately obvious
[23:21:57] (CR) Eileen: [C: 1] "I followed most of this & it looked pretty good." (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/299938 (https://phabricator.wikimedia.org/T122641) (owner: Ejegg)
[23:22:11] cwd: Haha, I need to document that, huh.
[23:22:27] The $wg* config goes in settings.php for now... if that's not too horrible?
[23:22:42] doesn't bother me
[23:23:03] i really don't mind the globals that much to be honest
[23:23:24] it's what was available in php at the time mw was written
[23:23:47] but it seems like pretty much the same pattern you'd do with any config system, just using globals instead
[23:25:54] Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Decimal dates are breaking our queue consumer - https://phabricator.wikimedia.org/T140667#2580889 (awight) Still not fixed! ``` zgrep -c 'd...
[23:28:38] cwd: What I mean is like, https://gerrit.wikimedia.org/r/#/c/306564/2/puppet/modules/crm/templates/settings.DonationInterface.php.erb
[23:28:59] That gets pulled in from settings.php
[23:29:48] makes sense to me
[23:30:20] will they come from /etc/fundraising?
[23:31:06] Good point. In production, yeah that sounds best.
[23:31:37] seems like a good idea to pull stuff out of localsettings.php and put it there
[23:31:41] And techs have permissions to deploy using fcu+rb
[23:31:57] Yeah that was on my mind, too. I think there are 3 copies now?
[23:32:20] seems like it could all be deemed, application specific or global config
[23:33:20] move some into DI/SP/CRM
[23:33:26] the rest into /etc/fundraising?
[23:33:54] sounds perfect
[23:34:45] I guess we really do update like 2-4 copies of each global, though
[23:35:16] how's that?
[23:39:06] The way I'm doing it now, we're going to have a copy in vagrant/**/crm/**/settings.DonationInterface.php.erb, one for production payments and another for production CRM, then the defaults in extension.json
[23:39:59] The nasty part is that CRM can't take advantage of the default values in extension.json, so that's all weird manual sync fallout
[23:40:28] is this because they all have different values for the globals?
[23:40:48] or could the common ones be moved to /etc/fr?
[23:42:32] That's a good call. The SmashPig thing works really well, where we can read the defaults in code and override with /etc/fundraising with no duplication.
[23:43:09] yeah that seems cool
[23:43:19] and then the checked in defaults can be optimized for development
[23:44:00] I don't think we even have to abstract the configuration source in DonationInterface, we just hard switchover to __DIR__ . SmashPig.yaml and /etc/fundraising/SmashPig.yaml
[23:44:52] there will be a SmashPig.yaml in the DI directory?
[23:45:22] GatewayAdapter::getGlobal fits pretty well with SP views, because they also fall back to the shared config, and get() makes the prefix thing opaque
[23:45:27] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, and 3 others: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2580949 (DStri...
[23:46:02] Yeah... I don't really like that idea either. I think SP and DI should each manage exactly just the config that covers their own components.
[23:46:26] that would be my vote
[23:46:44] So then, maybe DI is calling SP\Configuration::loadConfigs(DI_BASE_CONFIG_FILE_NAME)
[23:46:45] would rather overload /etc/fundraising with stuff than have the crossed wires
[23:47:12] hmm, so DI will use SP for config?
[23:47:21] but it just loads up a bunch of globals?
[23:47:24] That lets us reuse the configuration style and code, but loads different files than SP
[23:48:09] No, I guess it doesn't load globals. Instead, we have getGlobal call into a SP $config object to get values
[23:48:19] ah interesting
[23:48:33] yeah that seems like a good compromise
[23:48:46] We could make it soft migrateable by falling back to $wg*
[23:49:16] having a function called getglobal that doesn't get a global sucks
[23:49:21] but as long as we finish the job some day
[23:50:01] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface, Spike: Spike: Reconcile SmashPig and DonationInterface configuration - https://phabricator.wikimedia.org/T143831#2580956 (awight)
[23:50:04] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising Sprint Pretending This Isn't Happening, and 7 others: Run the orphan rectifier job from CRM Jenkins - https://phabricator.wikimedia.org/T141487#2580955 (awight)
[23:50:22] cwd: nice one. Yeah I'll go ahead and fix that.
[23:50:51] i'm irrationally afraid of search and replace stuff like that
[23:51:00] IDEs probably make it safe and easy
[23:51:12] or at least give you the illusion
[23:51:21] gotta make a quick phone call...