> > Do some 32 bit processors need this? > > > > In 32 bit before the merge, we use to have code that did:> > > > #if defined(CONFIG_4xx) || defined(CONFIG_E500)> > #define cvt_fd without save/restore fpscr> > #else> > #define cvt_fd with save/restore fpscr> > #end if> > > > Kumar; does this ring any bells?> > I don't see anything in the various 440 docs I have at hand that would> hint at lfd/stfs adffecting FPSCR.
The way the ifdefs are, it's the other way around. 4xx procs don't need
to save/restore fpscr and others do.
Mikey

On Aug 22, 2010, at 7:23 PM, Michael Neuling wrote:
>> Neither lfs nor stfs touch the fpscr, so remove the restore/save of it>> around them.> > Do some 32 bit processors need this? > > In 32 bit before the merge, we use to have code that did:> > #if defined(CONFIG_4xx) || defined(CONFIG_E500)> #define cvt_fd without save/restore fpscr> #else> #define cvt_fd with save/restore fpscr> #end if> > Kumar; does this ring any bells?> > (The addition of this predates even bitkeeper)> > Mikey
Not really. However if the ifdef is as you say that seems wrong to me. We should be using CONFIG_PPC_FPU or !CONFIG_PPC_FPU. As both 4xx and E500 have variants w/FPUs.
- k

> >> Neither lfs nor stfs touch the fpscr, so remove the restore/save of => it> >> around them.> >=20> > Do some 32 bit processors need this?=20> >=20> > In 32 bit before the merge, we use to have code that did:> >=20> > #if defined(CONFIG_4xx) || defined(CONFIG_E500)> > #define cvt_fd without save/restore fpscr> > #else> > #define cvt_fd with save/restore fpscr> > #end if> >=20> > Kumar; does this ring any bells?> >=20> > (The addition of this predates even bitkeeper)> >=20> > Mikey> > Not really. However if the ifdef is as you say that seems wrong to> me. We should be using CONFIG_PPC_FPU or !CONFIG_PPC_FPU. As both> 4xx and E500 have variants w/FPUs.
It actually got changed to CONFIG_PPC_FPU, then dwg merged it with some
other versions that were around.
Mikey