The more things we put into the context menu, the more important I think it becomes to port the delegates to use a Krigami basiclistitem and make the items in the context menu show up on hover, with some of the more esoteric ones being in an overflow menu. We should probably also first extend it to support actions that show their text, so the connext/disconnect action has the most visual prominence.

Anyway, enough rambling, that would be material for another patch anyway, I just wanted to mention it.

The more things we put into the context menu, the more important I think it becomes to port the delegates to use a Krigami basiclistitem and make the items in the context menu show up on hover, with some of the more esoteric ones being in an overflow menu. We should probably also first extend it to support actions that show their text, so the connext/disconnect action has the most visual prominence.

One thing I noticed when trying this out is that when the full-screen window showing the QR code appears, plasma-nm's system tray popup doesn't close, and the QR code window is drawn underneath it. On my 16x9 screen, the system tray popup just barely doesn't overlap the QR code, but I bet it would on a 4:3 screen, or a screen in portrait orientation.

Also maybe the menu item could have the icon view-barcode. It's not idea but maybe it's better than nothing?

One thing I noticed when trying this out is that when the full-screen window showing the QR code appears, plasma-nm's system tray popup doesn't close, and the QR code window is drawn underneath it. On my 16x9 screen, the system tray popup just barely doesn't overlap the QR code, but I bet it would on a 4:3 screen, or a screen in portrait orientation.

Networks using WPA2-EAP or DynamicWEP don't have secrets stored as 802-11-wireless-security, these are under 802-1-x. Anyway, I think we should maybe filter these out, you will most likely won't be sharing them anyway. You can do that in the applet already, check predictableWirelessPassword property.

I actually thought that instead of all this logic, where you search for wireless device, AP and then to get the security type, you will pass those information from the applet, instead of the specificObject. Even ssid is exposed from the model so you can just pass ssid as an argument and security type as another one and almost all this code below can go away.