Child Tickets

Change History (20)

While about:tor is still proclaiming a secure search with Startpage the default search engine in non-en-US bundles is DuckDuckGo.

Tested torbrowser-install-3.6-beta-1_zh-CN.exe, and the default search engine is Starpage. However, when translating Tor on transifex, in source file 'Torbutton - about:tor homepage', I found strings like this:'Search securely with DuckDuckGo'.

Could we put a string into source on transifex only when it's translatable and the translation will actually be built into next release? It will save translators lots of time, and no chance to make mistakes.

How does DuckDuckGo get set as the URL bar search engine in non-English bundles? Is the search box also configured to use DuckDuckGo? Which should be fixed -- about:tor or the other places?

How does DuckDuckGo get set as the URL bar search engine in non-English bundles? Is the search box also configured to use DuckDuckGo? Which should be fixed -- about:tor or the other places?

It get set as the browser is not recognizing the translated default one and thus choosing the second one we define. The search box on about:tor is not affected and fixed should get the search box in the upper right corner.

Okay, this was a huge PITA but here come some patches. The idea behind them is to a) fix the problem and b) avoid translators shooting themselves in the foot by translating the search box search engine names. In order to do so I moved setting the default search engines out of Torbutton and put that into our default Tor Browser preference file using browser.search.order.extra.. This works as these prefs are consulted first when constructing the search engine order: see _buildSortedEngineList()​https://mxr.mozilla.org/mozilla-esr31/source/toolkit/components/search/nsSearchService.js#3671. The funny thing is, the default engine we want has to be set with browser.search.order.extra.3, the second one with browser.search.order.extra.1 and the third one, you guess it, with browser.search.order.extra.2. This problem does, even more surprisingly, not happen if one just wants to set 2 search engines on the top of the list. This seems to be a Mozilla bug to me which I still need to file.

The code to review is: bug_11236_v3 in my public tor-browser repo, bug_11236_v2 in my public torbutton repo and bug_11236 in my public tor-browser-bunlde-testsuite repo.

The test currently only checks whether we have Startpage as default search engine set. Testing for DuckDuckGo and Google being on second/third position was harder than I though and I deferred that to a ticket I have yet to file. Should be okay for the bug at hand I think.

Note: If we are concerned with the nightly/alpha channel then it would be good to coordinate the merge efforts with #14490 and adapt the code for tor-browser and the test accordingly. The torbutton changes are unaffected.

I fell back to my observation that no problems arise if we specify just two search engines to be on the top. Might be enough for the moment as fix: bug_11236_redux2 in my public tor-browser repo has it. It is working fine on my Windows, Mac and Linux test boxes.