On Fri, 2011-07-01 at 17:53 +0800, Dexuan Cui wrote:
> In the previous commit we enable largefile setting in> meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to> actually enable it.
I guess this would be a good case for using something like OE .dev's
DISTRO_PR. It would be a bit sad if we end up having to bump PRs all
over the place in oe-core whenever some random layer changes its
DISTRO_FEATURES or whatever.
Also, just on a stylistic issue, it's a bit confusing to talk about "the
previous commit" if the commit in question was to a different file and
in a different repo. If you want to refer to a specific commit it's
best to mention the actual hash and, if necessary, the repo where it can
be found.
p.

Phil Blundell wrote:
> On Fri, 2011-07-01 at 17:53 +0800, Dexuan Cui wrote:>> In the previous commit we enable largefile setting in>> meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to>> actually enable it.> > I guess this would be a good case for using something like OE .dev's> DISTRO_PR. It would be a bit sad if we end up having to bump PRs all> over the place in oe-core whenever some random layer changes its> DISTRO_FEATURES or whatever.
Thanks for the info!
I didn't know OE.dev's DISTRO_PR before. I'm going to look at that.
> Also, just on a stylistic issue, it's a bit confusing to talk about> "the previous commit" if the commit in question was to a different> file and in a different repo. If you want to refer to a specific> commit it's best to mention the actual hash and, if necessary, the> repo where it can be found.
Thanks for the suggestion!
I'll pay special attention to this and avoid confusion in future.
Thanks,
-- Dexuan