Change History (20)

Using this build, I was able to sign up for Twitter (entering twitter.com in URL bar) and use Twitter to add accounts.
I was able to tweet from the Tweet box.
I was able to confirm my account in another tab at Mailinator.com
I loaded the confirmation url for twitter.
I left my timeline alone for about ten minutes.
I followed thirty people from the suggestion box on the left side of the screen.
I opened seven different tweets in seven different tabs.
I clicked the tab for ​https://twitter.com/ergeekgoddess/status/302199410845184000
I then clicked the link that displays as ​http://bit.ly/GSrDlQ but is actually ​http://t.co/qqGxRTyJ
While that page started to load in the same tab, TBB quit unexpectedly. Vidalia did not close and only Firefox appeared to have crashed.

Ok, I lucked out and got ahold of a 64bit macbook with Xcode on it today. I ran several builds dropping various Firefox patches and eventually found the bug. It was actually in a helper API that affected *both* the image cache isolation patch and the DOM storage patch. I pushed a fix that stopped the twitter crashes for me to mikeperry/bug3944-intlfixes, head commit hash of that branch is now f0de0fda7b08f15f9fb99ad0831596c16f77d3f7.

Setting this as "needs review" for someone to try building with the patch and reproduce the lack of crashes. I definitely fixed a crash bug (it was a refcount issue that basically lead to a use-after-free), but who knows if there are still more. Though, I didn't experience any at least.

ioerror: To be honest, I was just directly building Firefox w/ patches and pointing it at an existing "known broken" TBB profile directory, because it was much quicker and easier to run through multiple builds with different patches directly using git that way. However, I think the instructions in ​https://gitweb.torproject.org/torbrowser.git/blob/master:/docs/buildmachine_setups/osx.txt are pretty close. In my case, I had to additionally build firefox with --disable-libjpeg-turbo though (TBB has mozconfig-osx* in build-scripts/config you can edit to add this), because I couldn't find an easy way to get libjpeg-turbo to build..

erinn: It would be useful if you could add a commit to that osx.tzt build machine file describing where you get libjpeg-turbo. Do you use macports for that, too?