> Yup, from what I've tested this works (and tcpdump sees broadcast> packets even for vlans not configured at the moment including vlan tag> - yipee!).>

Thanks Michael !

Here is the revised patch again then for stable team, via David Milleragreement.

[PATCH v2 2.6.36] vlan: Avoid hwaccel vlan packets when vid not used.

Normally hardware accelerated vlan packets are quickly dropped ifthere is no corresponding vlan device configured. The one exceptionis promiscuous mode, where we allow all of these packets through sothey can be picked up by tcpdump. However, this behavior causes acrash if we actually try to receive these packets. This fixes thatcrash by ignoring packets with vids not corresponding to a configureddevice in the vlan hwaccel routines and then dropping them before theyget to consumers in the network stack.

+ /* If we got this far with a hardware accelerated VLAN tag, it means+ * that we were put in promiscuous mode but nobody is interested in+ * this vid. Drop the packet now to prevent it from getting propagated+ * to other parts of the stack that won't know how to deal with packets+ * tagged in this manner.+ */+ if (unlikely(vlan_tx_tag_present(skb)))+ goto bypass;+ /* Handle special case of bridge or macvlan */ rx_handler = rcu_dereference(skb->dev->rx_handler); if (rx_handler) {@@ -2927,6 +2936,7 @@ } }