------- Comment From mahesh@linux.vnet.ibm.com 2010-09-22 07:10 EDT-------
(In reply to comment #4)
> Is this a request against the dump component or for a new package?
>
This feature is to enhance makedumpfile tool to support filtering/compressing of ELF kernel crash dumps on s390. We hope to have the zLinux filtering specific patch integrated upstream soon, so RHEL 6.1 will either need to pick up the newer makedumpfile with zLinux support or incorporate a port of it in their package.
Since makedumpfile is shipped as part of kexec-tools rpm, we'll have a challenge for s390 -- kexec is not supported on s390 and hence there is no corresponding kexec-tools package. We would either need to:
1. Have intelligent in the kexec-tools spec file to build only makedumpfile for s390
2. OR have a makedumpfile rpm separately for s390.
Redhat,
What is the preferred approach here?

------- Comment From mahesh@linux.vnet.ibm.com 2010-10-28 04:39 EDT-------
(In reply to comment #5)
> (In reply to comment #4)
> > Is this a request against the dump component or for a new package?
> >
>
> This feature is to enhance makedumpfile tool to support filtering/compressing
> of ELF kernel crash dumps on s390. We hope to have the zLinux filtering
> specific patch integrated upstream soon, so RHEL 6.1 will either need to pick
> up the newer makedumpfile with zLinux support or incorporate a port of it in
> their package.
>
> Since makedumpfile is shipped as part of kexec-tools rpm, we'll have a
> challenge for s390 -- kexec is not supported on s390 and hence there is no
> corresponding kexec-tools package. We would either need to:
> 1. Have intelligent in the kexec-tools spec file to build only makedumpfile for
> s390
> 2. OR have a makedumpfile rpm separately for s390.
>
>
> Redhat,
>
> What is the preferred approach here?
Hi Redhat,
We haven't received any response for the above qeury. Can you please let us know what is the preferred approach here?
Thanks,

IBM, would you mind to backport that patch to makedumpfile-1.3.5 which is the one we used in kexec-tools. Ideally, it would be very nice if you can make a patch against the latest kexec-tools srpm.
Thanks!

Created attachment 461533[details]
kexec-tools.spec.patch
------- Comment on attachment From mahesh@linux.vnet.ibm.com 2010-11-19 07:09 EDT-------
This patch enables kexec-tools package to deploy makedumpfile tool for s390x architecure. This patch cleanly applies on kexec-tools.spec file of kexec-tools-2.0.0-145.el6.s390x from RHEL6.0.
Redhat ships the makedumpfile tool through kexec-tools package and s390x does not use Kdump functionality, the kexec-tools package was never supported for s390x. Hence this patch enables kexec-tools rpm package to build and install only makedumpfile tool and related files on s390x architecture keeping the existing functionality (unpacking/building kexec-tools, kdump scripts and makedumpfile) intact for other architectures.
With this patch applied on kexec-tools.spec, we should be able to get makedumpfile tool land on s390x system.

IBM, thanks very much!
I fixed a couple of issues in the patch from you:
1) We moved makedumpfile to /usr/sbin in 2.0.0-151;
2) s390 patch should be put as Patch401 in spec file.
However, there is still one small issue that I can't fix, it is a compile error:
makedumpfile.c: In function 'is_kvaddr':
makedumpfile.c:1495: error: 'KVBASE' undeclared (first use in this function)
makedumpfile.c:1495: error: (Each undeclared identifier is reported only once
makedumpfile.c:1495: error: for each function it appears in.)
I got this on s390, it is fine on s390x. I think you missed to define KVBASE for s390? So, could you please provide an updated version of kexec-tools-2.0.0-makedumpfile-s390-port.patch?
Thanks again!

------- Comment From mahesh@linux.vnet.ibm.com 2010-11-22 11:20 EDT-------
(In reply to comment #14)
> Hmm, it seems you only make "makedumpfile" support s390x, then why we still
> define s390 in spec file? :)
Oops, my mistake. Yes, makedumpfile support is only for s390x and I should not have defined s390 in spec file. I will move s390 under ExcludeArch and post the new patch.
Thanks for your review.

Created attachment 462209[details]
Updated patch for spec file
IBM, never mind. I simply remove "s390" from all "ifarch" and "ifnarch", and put it back to ExcludeArch. Please review this patch.
Thanks!

This enhancement request was evaluated by the full Red Hat Enterprise Linux
team for inclusion in a Red Hat Enterprise Linux minor release. As a
result of this evaluation, Red Hat has tentatively approved inclusion of
this feature in the next Red Hat Enterprise Linux Update minor release.
While it is a goal to include this enhancement in the next minor release
of Red Hat Enterprise Linux, the enhancement is not yet committed for
inclusion in the next minor release pending the next phase of actual
code integration and successful Red Hat and partner testing.

Hello Red Hat,
in previous releases, without this feature, kexec-tools was not provided with RHEL on System z because System z had no use of it.
Now that we will have a port/supprot of makedumpfile on RHEL 6.1 on System z, will the kexec-tools package automaticaly be build and included for RHEL 6.1 on System z, or do we need a separate bugzilla to track the delivery of kexec-tools in RHEL on System z?
Thank you for your support!

------- Comment From mgrf@de.ibm.com 2011-02-02 09:38 EDT-------
for the record - I want to note that the s390 build of kexec tools will need to contain only the makedumpfile parts.
kexec or ancillary tools are currently not required for s390.
Would you agree to let IBM review the first build?

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.
http://rhn.redhat.com/errata/RHBA-2011-0736.html

Note

You need to
log in
before you can comment on or make changes to this bug.