This sets the key pointer in the mergeinfo hash to data from elt1.
But the key has less lifetime than the hash itself, so this isn't safe.
Instead, the keys should be allocated in the same pool the mergeinfo
hash was allocated in.

Before your commit, they keys were stored in 'pool' which was treated
as a result pool.

The temporary keys are also used elsewhere in this function in the same
unsafe way.

I would suggest to aprpstr_dup() keys into the mergeinfo hash's pool.
Received on 2011-09-28 18:16:56 CEST