*Re: [PATCH v2 0/2] Make NNTP Xrefs work better
2018-10-13 21:42 [PATCH v2 0/2] Make NNTP Xrefs work better Jonathan Corbet
2018-10-13 21:42 ` [PATCH 1/2] Put the NNTP server name into Xref lines Jonathan Corbet
2018-10-13 21:42 ` [PATCH 2/2] Add Xrefs to over/xover lines Jonathan Corbet
@ 2018-10-16 4:04 ` Eric Wong2 siblings, 0 replies; 7+ messages in thread
From: Eric Wong @ 2018-10-16 4:04 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: meta
Jonathan Corbet <corbet@lwn.net> wrote:
> I finally found some time to figure out why the Xref changes weren't having
> the desired effect for me; the result is the following two changes.
>
> As always, these patches are likely to reveal that I really haven't done
> any perl in decades and that I'm still kind of groping my way around the
> public-inbox source. Hopefully they aren't too bad...
No worries, Perl (or anything else) feels rusty to me after
only a few days/weeks away :x
> Version 2 makes the tests work and improves the setting of the server name.
Thanks! Applied and pushed to https://public-inbox.org/ as
commit fbfd63996ddfc9a23b8a1e0f8756e378f2e196ba
> Jonathan Corbet (2):
> Put the NNTP server name into Xref lines
> Add Xrefs to over/xover lines
I was concerned about exposing the NNTP server hostname for
people running Tor onions, but having "publicinbox.nntpserver"
already-configured on my mirror onions means no changes were
needed on my end. Other onion operators (if they exist) may
need to take notice.
I haven't deployed to news.public-inbox.org / ou63pmih66umazou.onion, yet;
but both nntp://hjrcffqmbrq6wope.onion/ and nntp://czquwvybam4bgbro.onion/
are running the new code.
^permalinkrawreply [flat|nested] 7+ messages in thread

*Re: [PATCH 1/2] Put the NNTP server name into Xref lines
2018-09-05 21:34 ` Eric Wong@ 2018-09-05 22:26 ` Jonathan Corbet0 siblings, 0 replies; 7+ messages in thread
From: Jonathan Corbet @ 2018-09-05 22:26 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
On Wed, 5 Sep 2018 21:34:10 +0000
Eric Wong <e@80x24.org> wrote:
> But it looks like some test cases need to be adjusted for these.
> (see below)
Hey, man, the feature works for me...what more do you want?!? :)
It didn't occur to me to run the tests, of course. I'll fix that up and
repost, but it may be a little before I get back to it; this allegedly
real-life thing is being a little intense at the moment...
Thanks,
jon
^permalinkrawreply [flat|nested] 7+ messages in thread