In 2009, McShane appeared in Kings, which was based on the biblical story of David. His portrayal of King Silas Benjamin, an analogue of King Saul, was highly praised, with one critic saying, "Whenever Kings seems to falter, McShane appears to put bite marks all over the scenery."[17]

McShane married and divorced Suzan Farmer in the 1960s. In 1977, he began a relationship with Sylvia Kristel after meeting her on the set of The Fifth Musketeer.[26] The affair ended his marriage to his second wife, model Ruth Post, who is the mother of his two children, Kate and Morgan.[2]