WordPress Trac: {5} Next Major Releasehttps://core.trac.wordpress.org/report/5
Trac Report - {{{
#!span class="create-new-ticket button button-large button-primary"
[https://wordpress.org/support/bb-login.php?redirect_to=https://core.trac.wordpress.org/newticket Create a new ticket]
}}}
* Active tickets slated for the next major release
* Sort by component, type, summary
* Accepted tickets have an '*' appended to their owner's nameen-usWordPress Trachttps://core.trac.wordpress.org/chrome/site/your_project_logo.pnghttps://core.trac.wordpress.org/report/5
Trac v1.0.1#24869: "All" in post list table is incorrectly selected in some filtered viewsMon, 29 Jul 2013 00:28:23 GMTThu, 15 Jan 2015 21:48:16 GMT<p>
When you are viewing the posts table and you have selected an author the all filter is incorrectly selected.
</p>
enejhttps://core.trac.wordpress.org/ticket/24869
https://core.trac.wordpress.org/ticket/24869Report#14530: "Cheatin', uh?" is not helpful feedback for users or developersWed, 04 Aug 2010 13:20:56 GMTWed, 11 Feb 2015 05:51:22 GMT<p>
I've sen this infamous error msg more times than I wanted, in my own site where I'm admin.
</p>
<p>
That happens with more frequency when adding a new comment, but some times also inside admin pages.
</p>
<p>
I understand it's generally capability and permission tests that fail, and that happens in pages that ppl without permission to access them shouldn't see links to them, therefore they probably tried direct access to somewhere they shouldn't be going.
</p>
<p>
But also it happens when session expires or due to some bug. In this cases, the user is effectively not doing anything wrong, it may even be WP fault, and when that's the case the message is rude, even offensive to more emotional ppl.
</p>
<p>
Even worse, it gives no hint on what went wrong, so that user can try to fix it.
</p>
<p>
Then I suggest these messages to be changed, to more meaningful and also polite messages. Real cheaters and hackers will already have any info a message may provide, so a better explanation of what went wrong won't help them succeed in their attempt to hack a site, and will help a lot the victims of these errors.
</p>
shidouhikarihttps://core.trac.wordpress.org/ticket/14530
https://core.trac.wordpress.org/ticket/14530Report#31482: "Quick Edit" in Comments table row action breaks on small screensFri, 27 Feb 2015 22:14:30 GMTTue, 03 Mar 2015 12:17:32 GMT<p>
The text in class-wp-comments-list-table.php for the "Quick Edit" row action does not contain a <tt>&amp;nbsp;</tt> which can result in a line break mid-link on smaller viewports.
</p>
<p>
The other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action, so this would bring consistency.
</p>
kraftbjhttps://core.trac.wordpress.org/ticket/31482
https://core.trac.wordpress.org/ticket/31482Report#20319: $page value not being defaulted to 1 in the absence of cpage query var in get_next_comments_link()/get_previous_comments_link()Thu, 29 Mar 2012 09:23:19 GMTWed, 18 Feb 2015 09:30:50 GMT<p>
get_next_comments_link() generates incorrect comment pagination links on the first page when used alongside a user-made call to wp_list_comments().
</p>
<p>
Currently, get_next_comments_link() doesn't take into account instances where there is no 'cpage' query var (which is the case when a user-made call to wp_list_comments() is performed). The intval() of the empty $page variable returns 0, and at this point should then be defaulted to 1 in order for the correct link to page 2 to be generated. Instead, it's left as 0, and the resulting link is self-referencing to page 1.
</p>
<p>
In wp-includes/link-template.php:
</p>
<pre class="wiki">function get_next_comments_link( $label = '', $max_page = 0 ) {
global $wp_query;
if ( !is_singular() || !get_option('page_comments') )
return;
$page = get_query_var('cpage'); //RETURNS EMPTY IN ABSENCE OF A cpage VALUE ON PAGE 1 OF A USER-MADE CALL TO wp_list_comments()
$nextpage = intval($page) + 1; //intval() RETURNS 0, 0+1=1, RESULTING IN THE "Newer Comments" LINK SELF-REFERENCING PAGE 1, INSTEAD OF POINTING TO PAGE 2
...
</pre><p>
Coincidentally, in paginate_comments_links() (wp-includes/link-template.php) this situation is handled correctly, and $page does get correctly defaulted to 1. The same conditional used in paginate_comments_links() can be applied to both get_next_comments_link() and get_previous_comments_link(). The code to properly account for it is:
</p>
<pre class="wiki">function get_next_comments_link( $label = '', $max_page = 0 ) {
global $wp_query;
if ( !is_singular() || !get_option('page_comments') )
return;
$page = get_query_var('cpage');
if ( !$page ) //******** ADDED
$page = 1; //******** ADDED
$nextpage = intval($page) + 1; //intval() RETURNS 0, 0+1=1, RESULTING IN THE "Newer Comments" LINK NOT POINTING TO PAGE 2
...
</pre><p>
The same addition should be made to get_previous_comments_link() as well, although it's obviously unnoticeable on the first page.
</p>
MomDadhttps://core.trac.wordpress.org/ticket/20319
https://core.trac.wordpress.org/ticket/20319Report#28502: 'User deleted' message needs contextWed, 11 Jun 2014 09:29:58 GMTSat, 14 Feb 2015 01:15:00 GMT<p>
I found that <tt>_n( 'User deleted.', '%s users deleted.', $delete_count )</tt>(<a class="ext-link" href="https://github.com/WordPress/WordPress/blob/master/wp-admin/users.php#L372"><span class="icon">​</span>wp-admin/users.php#L372</a>) and <tt>_e( 'User deleted.' )</tt>(<a class="ext-link" href="https://github.com/WordPress/WordPress/blob/master/wp-admin/network/users.php#L251"><span class="icon">​</span>wp-admin/network/users.php#L251</a>) is conflicted. This causes strange message box in some languages: <a style="padding:0; border:none" href="https://i.cloudup.com/mjVIoDU_Zu.png"><img src="https://i.cloudup.com/mjVIoDU_Zu.png" alt="https://i.cloudup.com/mjVIoDU_Zu.png" title="https://i.cloudup.com/mjVIoDU_Zu.png" /></a>
</p>
<p>
To fix this <tt>_e( 'User deleted.' )</tt> should be changed to <tt>_ex( 'User deleted.', 'network' )</tt>
</p>
extendwingshttps://core.trac.wordpress.org/ticket/28502
https://core.trac.wordpress.org/ticket/28502Report#30554: <img> sizes attribute is stripped when switching from text to visual tab in the editorSun, 30 Nov 2014 14:53:42 GMTSun, 22 Feb 2015 03:31:55 GMT<p>
Going to the "text" tab to add <tt>sizes</tt> attribute (manually) to the image, and then going to "visual" tab results in that attribute being stripped out.
</p>
<p>
Related to issue <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28993" title="defect (bug): &lt;img&gt; srcset attribute is stripped when switching from text to visual tab ... (closed: fixed)">#28993</a> "&lt;img&gt; <tt>srcset</tt> attribute is stripped when switching from text to visual tab in the editor (fixed)"
</p>
jhnedhttps://core.trac.wordpress.org/ticket/30554
https://core.trac.wordpress.org/ticket/30554Report#21870: @ error control operator hides fatal error on mysql_fetch_objectTue, 11 Sep 2012 14:59:36 GMTTue, 13 Jan 2015 04:37:58 GMT<p>
I ran a get_posts() query that took me a while to track down to the @ error control operator on the mysql_fetch_object call (see wp-db.php:1219 in trunk), therefore PHP was silently die'ing on me because of a memory limit error.
</p>
<p>
I'm curious as to what use cases there are for the error control operator to be used here. In my case, I want to see these errors and fix my code accordingly, or tailor my query to the memory constraints, or rethink my data relations in the database.
</p>
ericlewishttps://core.trac.wordpress.org/ticket/21870
https://core.trac.wordpress.org/ticket/21870Report#28699: \0 (backslash+zero) gets stripped from post content for users without "unfiltered_html"Mon, 30 Jun 2014 23:32:44 GMTTue, 13 Jan 2015 14:06:48 GMT<p>
Happens when saving posts from both the Visual and Text editors. Seems caused by kses.
</p>
azaozzhttps://core.trac.wordpress.org/ticket/28699
https://core.trac.wordpress.org/ticket/28699Report#21848: A single space in the image caption breaks alignmentSat, 08 Sep 2012 15:07:42 GMTFri, 27 Feb 2015 22:49:01 GMT<p>
If you add just a single space in the caption field of an image using the media uploader, it ignores any alignment settings.
</p>
<p>
The expected behaviour would mean that regardless of what is entered into the caption box, the image alignment should be honoured.
</p>
lufferhttps://core.trac.wordpress.org/ticket/21848
https://core.trac.wordpress.org/ticket/21848Report#16557: Ability to disable redirect_guess_404_permalink()Mon, 14 Feb 2011 12:37:02 GMTFri, 27 Feb 2015 17:30:57 GMT<p>
Can you make redirect_guess_404_permalink() pluggable or have its return value pass-through a filter so that developers can override it?
</p>
<p>
I know I can remove_filter('template_redirect', 'redirect_canonical') but redirect_canonical is too useful to be disabled. Only disabling URL guessing would be great.
</p>
<p>
Thanks a lot,
</p>
<p>
MK
</p>
msafihttps://core.trac.wordpress.org/ticket/16557
https://core.trac.wordpress.org/ticket/16557Report#24826: Add __construct function to the "WP_Comment_Query" ClassWed, 24 Jul 2013 09:47:37 GMTFri, 16 Jan 2015 04:48:24 GMT<p>
Add PHP5 construct function to the comments query class, just like we have constructor functions on <strong>WP_Query</strong> and <strong>WP_User_Query</strong> classes.
</p>
ramiyhttps://core.trac.wordpress.org/ticket/24826
https://core.trac.wordpress.org/ticket/24826Report#30666: Add a comment to RTL and minified files for new contributorsWed, 10 Dec 2014 23:12:08 GMTTue, 03 Mar 2015 01:37:37 GMT<p>
Can we add a small header to RTL and minified files explaining that they are autogenerated and should not be patched directly? This might reduce some confusion for new contributors.
</p>
SergeyBiryukovhttps://core.trac.wordpress.org/ticket/30666
https://core.trac.wordpress.org/ticket/30666Report#30421: Add ARIA attributes to globally permitted HTML attributes in ksesThu, 20 Nov 2014 17:17:14 GMTSun, 22 Feb 2015 14:12:19 GMT<p>
Core currently supports the role attribute as globally permitted. It would be helpful if ARIA attributes were permitted here. This would be helpful so that users without the unfiltered_html capability could use ARIA within their content.
</p>
<p>
I can do this with a plugin, but currently run into issues making TinyMCE not strip away the ARIA attributes when toggling between the text and visual mode.
</p>
jwenerdhttps://core.trac.wordpress.org/ticket/30421
https://core.trac.wordpress.org/ticket/30421Report#31433: Add docs for paginate_links $args argumentTue, 24 Feb 2015 13:09:39 GMTTue, 24 Feb 2015 18:57:48 GMT<p>
paginate_links has a lot of documentation in words as to what values are possible to send in the $args array but it's all natural text, there is no overview of arguments for a quick reference.
</p>
<p>
Compare <a class="ext-link" href="https://developer.wordpress.org/reference/functions/paginate_links/"><span class="icon">​</span>https://developer.wordpress.org/reference/functions/paginate_links/</a>
With <a class="ext-link" href="http://codex.wordpress.org/Function_Reference/paginate_links"><span class="icon">​</span>http://codex.wordpress.org/Function_Reference/paginate_links</a>
</p>
atimmerhttps://core.trac.wordpress.org/ticket/31433
https://core.trac.wordpress.org/ticket/31433Report#28636: Add functions for working with local dates and timesWed, 25 Jun 2014 18:53:31 GMTFri, 27 Feb 2015 17:41:42 GMT<p>
Since WordPress sets <tt>date_default_timezone_set( 'UTC' )</tt>, working with local dates and times can sometimes be a bit of a nuisance. I'd like to propose adding a couple of functions to replace at least <tt>date()</tt> and <tt>strtotime()</tt>. We can add replacements for others too, like <tt>mktime()</tt> if the interest is there.
</p>
<p>
I've put together two proposals for accomplishing this, one using <tt>date_default_timezone_set()</tt> to temporarily change the timezone, and another (far more complicated version) using <tt>DateTime</tt>/<tt>DateTimeZone</tt>. I think the former is preferable, unless anyone has any reasons, performance or otherwise, why resetting the default timezone might be a bad thing?
</p>
<p>
I'm not married to the function names I chose (<tt>wp_date()</tt> and <tt>wp_strtotime()</tt>), so if it would be preferable to name them e.g. <tt>wp_local_date()</tt> and <tt>wp_local_strtotime()</tt>, I'm open to it.
</p>
mboyneshttps://core.trac.wordpress.org/ticket/28636
https://core.trac.wordpress.org/ticket/28636Report#29126: Add Kickstarter oEmbed supportTue, 05 Aug 2014 23:07:51 GMTTue, 10 Feb 2015 23:29:04 GMT<p>
I've not reviewed their implementation yet, but Kickstarter has an oEmbed endpoint for embedding a project's video. I think it's a sound candidate for inclusion.
</p>
<p>
oEmbed docs: <a class="ext-link" href="https://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers"><span class="icon">​</span>https://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers</a>
</p>
<p>
Example oEmbed call: <a class="ext-link" href="https://www.kickstarter.com/services/oembed?url=https%3A%2F%2Fwww.kickstarter.com%2Fprojects%2F324283889%2Fpotato-salad"><span class="icon">​</span>https://www.kickstarter.com/services/oembed?url=https%3A%2F%2Fwww.kickstarter.com%2Fprojects%2F324283889%2Fpotato-salad</a>
</p>
johnbillionhttps://core.trac.wordpress.org/ticket/29126
https://core.trac.wordpress.org/ticket/29126Report#31450: Add landmark roles to WordPress admin areasWed, 25 Feb 2015 19:25:34 GMTSat, 28 Feb 2015 18:21:36 GMT<p>
Right now, the WordPress admin pages have ARIA landmark roles available for navigation only. This patch adds role="main" to the wpcontent container and role="contentinfo" to the wpfooter container.
</p>
joedolsonhttps://core.trac.wordpress.org/ticket/31450
https://core.trac.wordpress.org/ticket/31450Report#31121: Add leading zeros to 24 hour date formatsSun, 25 Jan 2015 11:51:02 GMTFri, 30 Jan 2015 00:17:21 GMT<p>
There are a lot of occurrences in core where we use <tt>G:i</tt> for a 24 hour time format. This leads to weird things like <tt>0:11</tt> and <tt>1:22:33</tt>. In general we should never use the <tt>G</tt> for displaying dates. <tt>g</tt> should be used for 12 hour time formats since it's a value between 1 and 12. Either it's <tt>H:i</tt> or <tt>g:i</tt>.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/31121
https://core.trac.wordpress.org/ticket/31121Report#30725: Add media modal - different select widthTue, 16 Dec 2014 11:10:12 GMTTue, 17 Feb 2015 14:13:35 GMT<p>
When clicking "Add media", images are loading in modal window.
But there is different width when loading spinner appears.
When everything loaded, select field shrinks back and it is distracting.
Also, localized string is longer than English original and it is not visible the whole text.
</p>
<p>
See attached screenshot.
</p>
pavelevaphttps://core.trac.wordpress.org/ticket/30725
https://core.trac.wordpress.org/ticket/30725Report#23988: Add post info on comment.php?action=editcommentMon, 08 Apr 2013 12:58:20 GMTWed, 04 Feb 2015 04:36:58 GMT<p>
When you get a comment notification, if you click on a link to mark as spam, etc, when you get to the edit comment screen, there's no indication of which post/page the comment was in response to, which can be a determining factor in deciding if a comment is valuable, off-topic, or spam.
</p>
<p>
We should add an "In response to" area that lists the post title, date/timestamp like on comment list screen. If it's in response to another comment that should show as well, but since we don't have that in comment screen functionality yet, at least adding the post info that we already have and show on the list would be a clue and a step in the right direction.
</p>
jenmylohttps://core.trac.wordpress.org/ticket/23988
https://core.trac.wordpress.org/ticket/23988Report#30755: Add Slack notifications to Travis CIWed, 17 Dec 2014 23:48:22 GMTMon, 23 Feb 2015 09:35:54 GMT<p>
Using <a class="ext-link" href="https://travis-ci.org/aaronjorbin/develop.wordpress"><span class="icon">​</span>https://travis-ci.org/aaronjorbin/develop.wordpress</a> for now.
</p>
<p>
The reformatting was the result of the <tt>travis</tt> CLI client, which was used to encrypt the credentials.
</p>
nacinhttps://core.trac.wordpress.org/ticket/30755
https://core.trac.wordpress.org/ticket/30755Report#31180: Add tumblr.com oEmbed supportFri, 30 Jan 2015 06:42:44 GMTMon, 09 Feb 2015 03:25:32 GMT<p>
Tumblr has recently added functionality for embedding posts on third party sites.
</p>
<p>
This patch adds <tt>https://www.tumblr.com/oembed/1.0</tt> as the oEmbed endpoint for URLs matching the <tt>http://*.tumblr.com/post/*</tt> format. This will account only for standard Tumblr blogs and does not account for those with customized domains - that support would require global oEmbed discovery to be enabled, and should not be part of the core Wordpress whitelist.
</p>
elliottcarlsonhttps://core.trac.wordpress.org/ticket/31180
https://core.trac.wordpress.org/ticket/31180Report#31470: Add user capability check to WordPress update nagThu, 26 Feb 2015 20:29:50 GMTFri, 27 Feb 2015 14:06:02 GMT<p>
The WordPress update nag has been in effect since the introduction of the WordPress admin update API as far as I can tell. In WordPress 2.3, with <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/4869" title="defect (bug): Core update notification is displayed for all user levels (closed: fixed)">#4869</a>, a check was added to differentiate between the language provided to users with <tt>manage_options</tt> and other logged-in users. In WordPress 3.0, the check was updated to utilize the new <tt>update_core</tt> permission.
</p>
<p>
Today, WordPress users should not be assumed to have any form of relationship with the site owner or anyone with update permissions. The nag currently shows for any logged in users, even those with <tt>read</tt> only permissions.
</p>
<p>
I don't think I should get update notifications on sites I'm only marginally attached to. Example A:
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/Uxjh2hLmKi.png"><img src="https://cldup.com/Uxjh2hLmKi.png" alt="https://cldup.com/Uxjh2hLmKi.png" title="https://cldup.com/Uxjh2hLmKi.png" /></a>
</p>
<p>
An example use case is eCommerce. Pretty much anyone making an order will get added as at least a subscriber level, and therefore if they find their way to the WordPress admin (perhaps to edit a profile), they'll get a WordPress update nag.
</p>
<p>
I'd propose that we limit the nag to users with at least some form of site management permissions.
</p>
<p>
I'd personally prefer that only editors and above get the nag: perhaps using the permission for <tt>publish_pages</tt>. Alternatively, we could limit to admins and those with permission to <tt>update_core</tt> and ditch the secondary language to notify an administrator. At an absolute minimum, I think we should limit it to <tt>edit_posts</tt>, or the contributor role.
</p>
krogsgardhttps://core.trac.wordpress.org/ticket/31470
https://core.trac.wordpress.org/ticket/31470Report#31306: add_query_arg changes numerical argumentsThu, 12 Feb 2015 10:44:29 GMTThu, 12 Feb 2015 17:59:46 GMT<p>
I noticed this when I used '1=1' as a default query value to prevent a ? being prepended. If an argument passed to add_query_arg is a number, it gets replaced with an incrementing value. It doesn't re-order arguments or parse non-decimal numbers.
I suspect this is being caused by array_merge on line 782 of wp-includes/functions.php
</p>
<div class="code"><pre><span class="x">var_dump( add_query_arg( array( 'foo' =&gt; 'bar' ), '1=1' ) );
// string '0=1&amp;foo=bar' (length=11)
var_dump( add_query_arg( array( 'a' =&gt; 'c' ), '1=1&amp;a=b&amp;10=10' ) );
// string '0=1&amp;a=c&amp;1=10' (length=12)
var_dump( add_query_arg( array( '19' =&gt; '19' ), '20=20' ) );
// string '0=20&amp;1=19' (length=9)
var_dump( add_query_arg( array( '3e1' =&gt; '3' ), '0x1=1&amp;a=b&amp;010=2' ) );
// string '0x1=1&amp;a=b&amp;010=2&amp;3e1=3' (length=21)
</span></pre></div>Lex_Robinsonhttps://core.trac.wordpress.org/ticket/31306
https://core.trac.wordpress.org/ticket/31306Report#30463: Adding second link to a text in Visual editor doesn't work within a tableSun, 23 Nov 2014 12:34:10 GMTSun, 22 Feb 2015 04:31:01 GMT<p>
The problem occurs when you follow these steps:
</p>
<ol><li>Create a new page.
</li><li>Copy the code below and paste it into Text editor:
<pre class="wiki">&lt;table&gt;
&lt;tbody&gt;
&lt;tr&gt;
&lt;td&gt;&lt;img src="some-image.jpg" alt="some-image" width="150" height="150" /&gt;&lt;/td&gt;
&lt;/tr&gt;
&lt;tr&gt;
&lt;td&gt;Lorem ipsum&lt;/td&gt;
&lt;/tr&gt;
&lt;/tbody&gt;
&lt;/table&gt;
</pre></li></ol><ol start="3"><li>Switch to Visual editor.
</li><li>Click the image and Insert/Edit link, then choose any page and press Add Link button.
</li><li>Select whole text below the image and Insert/Edit link, then choose any page and press Add Link button.
</li></ol><p>
Second link wasn't added, in console log you can find TinyMCE related JavaScript error.
</p>
<p>
You can put any text instead of the image and the bug still occurs. If you will try to add a link again, then it will work.
</p>
<p>
I'm using the latest version of WordPress, all plugins are deactivated, I've tested the bug with all default themes on two different operating systems (Windows 7 and Ubuntu 12 with the latest Firefox and Chrome).
</p>
<p>
In case of any problems with reproducing this bug <a class="ext-link" href="https://www.youtube.com/watch?v=elIS8GJlD-Q"><span class="icon">​</span>I've made also a video with all steps.</a>
</p>
Dumianhttps://core.trac.wordpress.org/ticket/30463
https://core.trac.wordpress.org/ticket/30463Report#30021: Admin bar font appears thin in Firefox when themes turn on font-smoothing in body elementFri, 17 Oct 2014 15:43:15 GMTTue, 13 Jan 2015 14:06:48 GMT<p>
Font bug in admin bar when theme turns on font smoothing in Firefox
</p>
<p>
<a style="padding:0; border:none" href="http://webplantmedia.com/wp-content/uploads/2014/10/Screen-Shot-2014-10-17-at-10.30.32-AM.png"><img src="http://webplantmedia.com/wp-content/uploads/2014/10/Screen-Shot-2014-10-17-at-10.30.32-AM.png" alt="http://webplantmedia.com/wp-content/uploads/2014/10/Screen-Shot-2014-10-17-at-10.30.32-AM.png" title="http://webplantmedia.com/wp-content/uploads/2014/10/Screen-Shot-2014-10-17-at-10.30.32-AM.png" /></a>
</p>
<p>
Looks good when in dashboard, or theme does not use font smoothing
</p>
<p>
<a style="padding:0; border:none" href="http://webplantmedia.com/wp-content/uploads/2014/10/Screen-Shot-2014-10-17-at-10.30.43-AM.png"><img src="http://webplantmedia.com/wp-content/uploads/2014/10/Screen-Shot-2014-10-17-at-10.30.43-AM.png" alt="http://webplantmedia.com/wp-content/uploads/2014/10/Screen-Shot-2014-10-17-at-10.30.43-AM.png" title="http://webplantmedia.com/wp-content/uploads/2014/10/Screen-Shot-2014-10-17-at-10.30.43-AM.png" /></a>
</p>
<p>
Propose solution to declare proper font smoothing in CSS when declaring font in admin elements.
</p>
<pre class="wiki">font: 400 13px/32px "Open Sans",sans-serif;
-webkit-font-smoothing: subpixel-antialiased;
-moz-osx-font-smoothing: auto;
</pre>cbaldelomarhttps://core.trac.wordpress.org/ticket/30021
https://core.trac.wordpress.org/ticket/30021Report#31322: Admin bar frontend search CSS fixesFri, 13 Feb 2015 19:03:21 GMTFri, 13 Feb 2015 19:29:50 GMT<p>
When the admin bar is displayed on the frontend, an additional search form appears on the right. The input field doesn't have an associated label (will open a separate ticket) but there are also some CSS glitches.
</p>
<ul><li>on focus: the blue lens is not shown in all browsers (appears just on hover)
</li><li>IE8: needs some love
</li></ul><p>
See screenshot before the patch:
modern browsers
IE8 search collapsed
IE8 search expanded
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/_SXVu_eybQ.png"><img src="https://cldup.com/_SXVu_eybQ.png" alt="https://cldup.com/_SXVu_eybQ.png" title="https://cldup.com/_SXVu_eybQ.png" /></a>
</p>
<p>
Screenshot after the patch:
modern browsers
IE8 search expanded
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/seRrHsBWNN.png"><img src="https://cldup.com/seRrHsBWNN.png" alt="https://cldup.com/seRrHsBWNN.png" title="https://cldup.com/seRrHsBWNN.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31322
https://core.trac.wordpress.org/ticket/31322Report#31345: Admin menu icon colors fixesMon, 16 Feb 2015 14:17:57 GMTTue, 17 Feb 2015 12:57:44 GMT<p>
After <a class="changeset" href="https://core.trac.wordpress.org/changeset/31422" title="Update the default admin color scheme for more unity and refinement.
This ...">r31422</a> IE 8 users will feel a bit blue :) See screenshot:
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/oAVakHF21e.png"><img src="https://cldup.com/oAVakHF21e.png" alt="https://cldup.com/oAVakHF21e.png" title="https://cldup.com/oAVakHF21e.png" /></a>
</p>
<p>
the icons color was: <tt>#999</tt> and changed in this
</p>
<pre class="wiki">#adminmenu div.wp-menu-image:before {
color: #00b9eb; &lt;-- light blue
color: rgba(240,245,250,0.6); &lt;-- rgba light grey
}
</pre><p>
and IE 8 doesn't support rgba so it will get the blue.
</p>
<p>
The proposed patch fixes also the icon color when tabbing (focus) the submenu items, this should pair the "focus" with the "hover" behavior. See before/after screenshot. Doesn't work in IE 8, just modern browsers.
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/EwZlqjPnVS.png"><img src="https://cldup.com/EwZlqjPnVS.png" alt="https://cldup.com/EwZlqjPnVS.png" title="https://cldup.com/EwZlqjPnVS.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31345
https://core.trac.wordpress.org/ticket/31345Report#30900: Admin menu is flickering when scrolling left or rightSun, 04 Jan 2015 16:00:29 GMTMon, 02 Mar 2015 04:35:01 GMT<p>
If you open WordPress' backend in the latest Safari version (8.0.2) on OS X you'll notice that the admin menu looks a bit buggy if you're trying to scroll left or right. So I started digging into the CSS code and found out that this is caused by some attributes on the <em>#adminmenuback</em>-element.
</p>
<p>
Currently, the element has the following attributes:
</p>
<pre class="wiki">#adminmenuback {
position: absolute;
top: 0;
bottom: 0;
z-index: -1;
}
</pre><p>
But If we would change the <strong>position</strong> to 'fixed' (like #adminmenuwrap already has it) and the <strong>z-index</strong> to '9980', the menu won't look buggy anymore if someone scrolls to the left or right. - I also tested the element's new behavior on mobile and in different browsers like Chrome, Opera and Firefox and everything looks fine.
</p>
<ul><li>Menu without fix: <a class="ext-link" href="http://quick.as/ov6bCaVg"><span class="icon">​</span>http://quick.as/ov6bCaVg</a>
</li><li>Menu with fix: <a class="ext-link" href="http://quick.as/VG1Qc6Qg"><span class="icon">​</span>http://quick.as/VG1Qc6Qg</a>
</li></ul><p>
Therefore this will be the new declaration for the named element:
</p>
<pre class="wiki">#adminmenuback {
position: fixed;
top: 0;
bottom: 0;
z-index: 9989;
}
</pre><p>
I would very much welcome it if someone could look after this problem. Thanks in advance!
</p>
mindrunhttps://core.trac.wordpress.org/ticket/30900
https://core.trac.wordpress.org/ticket/30900Report#31408: Alignment of labels and checkboxes is off on quick editSat, 21 Feb 2015 22:10:54 GMTSat, 21 Feb 2015 23:56:49 GMT<p>
Its a pretty small issue - but the alignment of labels on the quick edit screen is a bit wonky.
</p>
<p>
<a style="padding:0; border:none" href="https://dl.dropboxusercontent.com/s/9ma4qhh0t8c3uxv/2015-02-21%20at%2021.58%202x.png?dl=0"><img src="https://dl.dropboxusercontent.com/s/9ma4qhh0t8c3uxv/2015-02-21%20at%2021.58%202x.png?dl=0" alt="https://dl.dropboxusercontent.com/s/9ma4qhh0t8c3uxv/2015-02-21%20at%2021.58%202x.png" title="https://dl.dropboxusercontent.com/s/9ma4qhh0t8c3uxv/2015-02-21%20at%2021.58%202x.png" /></a>
</p>
<p>
I have a patch to fix this. Heres what it looks like after the patch.
</p>
<p>
<a style="padding:0; border:none" href="https://dl.dropboxusercontent.com/s/abpt0ld9euqv5pz/2015-02-21%20at%2022.07%202x.png?dl=0"><img src="https://dl.dropboxusercontent.com/s/abpt0ld9euqv5pz/2015-02-21%20at%2022.07%202x.png?dl=0" alt="https://dl.dropboxusercontent.com/s/abpt0ld9euqv5pz/2015-02-21%20at%2022.07%202x.png" title="https://dl.dropboxusercontent.com/s/abpt0ld9euqv5pz/2015-02-21%20at%2022.07%202x.png" /></a>
</p>
<p>
I've tested this on Chrome/Firefox and IE11 (and 8 up using emulator)
</p>
<p>
This has been an issue for a while - since the admin redesign.
</p>
mattheuhttps://core.trac.wordpress.org/ticket/31408
https://core.trac.wordpress.org/ticket/31408Report#24633: Allow admins to generate and send new passwords for usersMon, 24 Jun 2013 03:07:39 GMTMon, 02 Mar 2015 18:17:18 GMT<p>
For sites that have a lot of user accounts (such as community forums), it'd be really nice for admins to be able to manually generate a new password for user accounts and then automatically send that new password via email. The option to flag the user's account so they are encouraged to reset their password (exactly as they are when using an auto-generated password) would be excellent.
</p>
<p>
The <a class="ext-link" href="http://wordpress.org/plugins/simple-user-password-generator/"><span class="icon">​</span>Simple User Password Generator</a> plugin by 10up does this superbly. I'd propose it be implemented exactly like they have done.
</p>
<p>
Any reason not to do this?
</p>
mordaukhttps://core.trac.wordpress.org/ticket/24633
https://core.trac.wordpress.org/ticket/24633Report#31139: Allow editing of video embed parameters in the media modalMon, 26 Jan 2015 18:53:55 GMTFri, 27 Feb 2015 22:34:31 GMT<p>
Unsure if this is possible, but it would be pretty sweet if you could adjust available video embed parameters, such as height/width, straight from the media modal. It could fit pretty well on this screen: <a class="ext-link" href="https://cloudup.com/caoYOVuWM41"><span class="icon">​</span>https://cloudup.com/caoYOVuWM41</a>
</p>
melchoycehttps://core.trac.wordpress.org/ticket/31139
https://core.trac.wordpress.org/ticket/31139Report#31271: Allow is_page_template() to accept an array of templates to check.Mon, 09 Feb 2015 19:39:45 GMTMon, 02 Mar 2015 19:30:37 GMT<p>
Currently, <tt>is_page_template()</tt> takes an optional single template name to check. This would also allow for an array of strings to check.
</p>
<p>
Before:
</p>
<pre class="wiki">if ( is_page_template( 'page-one.php' ) || is_page_template( 'page-two.php' ) || is_page_template( 'page-four.php' ) ) {
throw_hhg( false );
}
</pre><p>
After:
</p>
<pre class="wiki">if ( is_page_template( array( 'page-one.php' , 'page-two.php', 'page-three.php' ) ) ) {
throw_hhg( true );
}
</pre><p>
Related: <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/15061" title="enhancement: Allow either array or string to be passed to locate_template (closed: fixed)">#15061</a>
</p>
morganesteshttps://core.trac.wordpress.org/ticket/31271
https://core.trac.wordpress.org/ticket/31271Report#30577: Allow plugins to bypass wp_options when saving transientsTue, 02 Dec 2014 20:25:32 GMTSat, 07 Feb 2015 14:28:21 GMT<p>
In <tt>set_transient()</tt>, the only way to prevent transients from using the wp_options table is by using a custom object-cache.php drop-in.
</p>
<p>
This isn't consistent with <tt>get_transient()</tt>, which does have a filter to short-circuit transient retrieval (pre_transient_*).
</p>
<p>
This patch allows plugins to bypass the options table when saving transients.
</p>
<p>
<strong>Full disclosure:</strong> I'm writing a plugin to store transients in a separate table, instead of cluttering wp_options. Reference: <a class="ext-link" href="https://github.com/mgibbs189/better-transients"><span class="icon">​</span>https://github.com/mgibbs189/better-transients</a>
</p>
mgibbs189https://core.trac.wordpress.org/ticket/30577
https://core.trac.wordpress.org/ticket/30577Report#31187: Allow swiping the admin menu open and closed on touch devicesFri, 30 Jan 2015 19:39:05 GMTWed, 25 Feb 2015 21:29:00 GMT<p>
<a class="ext-link" href="https://make.wordpress.org/flow/2014/10/17/opening-and-closing-the-admin-menu-on-touch-devices-nexus-5-ipad-air-iphone-5-4-1-alpha-20141016/"><span class="icon">​</span>https://make.wordpress.org/flow/2014/10/17/opening-and-closing-the-admin-menu-on-touch-devices-nexus-5-ipad-air-iphone-5-4-1-alpha-20141016/</a>
</p>
<p>
Other mobile web interfaces with a side menu allow swiping the menu open and closed. We too should accommodate swiping.
</p>
ryanhttps://core.trac.wordpress.org/ticket/31187
https://core.trac.wordpress.org/ticket/31187Report#9568: Allow users to log in using their email addressFri, 17 Apr 2009 17:11:28 GMTWed, 28 Jan 2015 17:37:04 GMT<p>
I've been looking into a few tickets and adding patches to things that were potentially problematic when implementing a membership plugin (<a class="closed ticket" href="https://core.trac.wordpress.org/ticket/1626" title="defect (bug): user_nicename should be unique (closed: fixed)">#1626</a>, <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/4170" title="defect (bug): author pages do an uncached user_nicename lookup (closed: fixed)">#4170</a>, <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/9563" title="defect (bug): unique email is not enforced (closed: fixed)">#9563</a>, <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/9564" title="feature request: When using emails as logins, emails and logins should be consistent. (closed: duplicate)">#9564</a>). The general idea being twofold: to avoid duplicate users at all costs -- because it's a bloody mess to merge users in a billing system.
</p>
<p>
I'm about to embark on a mid-sized patch that renders the WP username field optional. This is a natural next step from <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/9563" title="defect (bug): unique email is not enforced (closed: fixed)">#9563</a> and <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/9564" title="feature request: When using emails as logins, emails and logins should be consistent. (closed: duplicate)">#9564</a>.
</p>
<p>
Users could then be allowed to specify an email only, when registering. And they could use their email to login -- in addition to their username if they specified one.
</p>
Denis-de-Bernardyhttps://core.trac.wordpress.org/ticket/9568
https://core.trac.wordpress.org/ticket/9568Report#29558: Alt+Shift shortcuts override character inputSat, 06 Sep 2014 16:44:22 GMTSat, 31 Jan 2015 19:54:52 GMT<p>
I am using default wordpress editor for posts and I run into a issue when I want to write this char: " [ ".
I am from Croatia, and key combination for this is Alt Gr + F When I press that the editor goes full screen, what is really weird and I can't find a solution (I am forced to copy/paste that char from somewhere else).
</p>
Balkanahttps://core.trac.wordpress.org/ticket/29558
https://core.trac.wordpress.org/ticket/29558Report#29492: Attemp to keep both Text and Visual editors scroll position when switchingWed, 03 Sep 2014 18:10:46 GMTSun, 22 Feb 2015 16:35:51 GMT<p>
When using editor expand, it is nice to try to keep the scroll positions in case the user quickly switches to the Text editor to add something, then back to the Visual, then back to Text, etc.
</p>
azaozzhttps://core.trac.wordpress.org/ticket/29492
https://core.trac.wordpress.org/ticket/29492Report#31058: audio video previews JS errors in IE 8Mon, 19 Jan 2015 16:52:21 GMTFri, 13 Feb 2015 05:54:04 GMT<p>
Noticed a couple of JS errors when browsing prev/next in the attachment details modal using Internet Explorer 8: images are fine but as soon as you next (or previous) items is a video or audio, the preview is not rendered and the prev/next navigation fails.
</p>
<p>
It looks like the first error is caused by <a href="https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/media-audiovideo.js?rev=31016#L56">this line in media-audiovideo.js</a>
</p>
<pre class="wiki">t.media.remove();
</pre><p>
where <tt>t.media</tt> seems to me it's the DOM object and maybe it should be the <tt>t.$media</tt> jQuery object instead? See proposed patch.
</p>
<p>
About the second JS error, to be honest I gave up but seems it's from <tt>mediaelement-and-player.min.js</tt>.
</p>
<p>
See errors details below.
</p>
<pre class="wiki">Message: Object doesn't support this property or method
Line: 56
Char: 5
Code: 0
/wp-includes/js/media-audiovideo.js?ver=4.2-alpha-31007-src
Message: 'parentNode.tagName' is null or not an object
Line: 15
Char: 17054
Code: 0
/wp-includes/js/mediaelement/mediaelement-and-player.min.js?ver=2.16.2
</pre><p>
<a style="padding:0; border:none" href="https://cldup.com/5KiNOyCd7r.png"><img src="https://cldup.com/5KiNOyCd7r.png" alt="https://cldup.com/5KiNOyCd7r.png" title="https://cldup.com/5KiNOyCd7r.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31058
https://core.trac.wordpress.org/ticket/31058Report#30850: Audio/video previews for media controls in the CustomizerSun, 28 Dec 2014 00:06:17 GMTTue, 17 Feb 2015 15:41:21 GMT<p>
These were mostly in place but missing whatever's needed to trigger MediaElement.js, so they got pulled in <a class="changeset" href="https://core.trac.wordpress.org/changeset/30712" title="Customizer: Enhance Background Image/Upload controls.
* Adopt the Header ...">[30712]</a>. Turns out we just need to do something along the lines of <tt>control.container.find('audio,video').mediaelementplayer(_wpmejsSettings );</tt> after rendering it from the JS template.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/30850
https://core.trac.wordpress.org/ticket/30850Report#31463: Avoid reaching inside the object cache object in testsThu, 26 Feb 2015 04:28:55 GMTThu, 26 Feb 2015 12:17:58 GMT<p>
It'd be really fantastically great if <tt>WP_UnitTestCase::flush_cache</tt> could keep its hands off my internal properties. :)
</p>
<p>
Right now, <tt>flush_cache</tt> reaches into <tt>$wp_object_cache</tt> and messes with a bunch of internal properties:
</p>
<pre class="wiki">$wp_object_cache-&gt;group_ops = array();
$wp_object_cache-&gt;stats = array();
$wp_object_cache-&gt;memcache_debug = array();
$wp_object_cache-&gt;cache = array();
</pre><p>
If we could just not do that, that'd be greaaaat.
</p>
rmccuehttps://core.trac.wordpress.org/ticket/31463
https://core.trac.wordpress.org/ticket/31463Report#27638: Bad value navigation for attribute role on element ulWed, 02 Apr 2014 20:54:49 GMTFri, 16 Jan 2015 16:19:23 GMT<p>
In the WordPress administration dashboard the menu list contains the attribute "role" with the value of "navigation" and accordingly to HTML5 this is wrong.
</p>
<p>
Code: &lt;ul id="adminmenu" role="navigation"&gt;
Error: Bad value navigation for attribute role on element ul.
</p>
gigimuschihttps://core.trac.wordpress.org/ticket/27638
https://core.trac.wordpress.org/ticket/27638Report#29881: Better abstraction for WP_Posts_List_Table so it's easier to subclassTue, 07 Oct 2014 20:16:21 GMTSat, 07 Feb 2015 11:28:38 GMT<p>
Currently <tt>WP_Posts_List_Table</tt> is a bit of a complicated mess as all columns are in a big switch statement in the <tt>single_row()</tt> method. This annoying for a couple of reasons.
</p>
<ol><li>The code is a messy, huge method making it difficult to maintain and understand.
</li><li>Subclassing is a pain as you can't override a single column the way the magic method calling of <tt>column_$column_name</tt> should work.
</li><li>Subclasses don't automatically get the <tt>column_$column_name</tt> functionality as <tt>WP_Posts_List_Table</tt> (for whatever reason) closes out this functionality by overriding the <tt>single_row()</tt> method.
</li></ol><p>
I'm not a fan of changing things for the sake of it, but I think this is an important cleanup. <tt>WP_Comment_List_Table</tt> is pretty well implemented in comparison, but I imagine <tt>WP_Posts_List_Table</tt> is the most often subclassed due to the heavy use of custom post types.
</p>
<p>
Apologies if this has been discussed before and/or rejected. I tried to use search... which I seem to kind of fail at finding tickets.
</p>
<p>
I attached a preliminary path that is functional but needs a couple of edge cases cleaned up. It basically splits out all the columns into their own method which are automatically called from <tt>single_row_columns()</tt>.
</p>
joehoylehttps://core.trac.wordpress.org/ticket/29881
https://core.trac.wordpress.org/ticket/29881Report#28599: Better Visual Focus Indication in Admin MenuFri, 20 Jun 2014 06:22:58 GMTWed, 25 Feb 2015 22:54:39 GMT<p>
Breaking this issue away from <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28267" title="defect (bug): Unify focus styles across the admin (closed: fixed)">#28267</a> "Unify focus styles across the admin." The left navigation menu system now uses color changes to indicate visual focus. In the default scheme, when the main menu item is selected the background goes from dark gray to black and when a submenu item is selected the text goes dark blue, both hard to discern. Color alone cannot be the only indicator. For those who cannot perceive color changes, a secondary marker is required. For instance, in the situation where a blue glow is used to show focus on an input, there is the color and the shading in the glow: two elements. The solution should work in the eight available admin color schemes.
</p>
<p>
Some suggestions have been made including:
</p>
<ul><li>Helen reports that a blue glow does not look good
</li><li>White outline around menu item with white outline also around selected submenu item
</li><li>Reversing the colors coupled with another undefined indicator element
</li><li>Triangle to the left of main menu item and selected submenu item
</li><li>Underline under main menu item and selected submenu item (might be mistaken for links)
</li></ul>AccessibleJoehttps://core.trac.wordpress.org/ticket/28599
https://core.trac.wordpress.org/ticket/28599Report#31477: Build task is overwriting minified JS libraries with our uglified versionFri, 27 Feb 2015 17:22:21 GMTFri, 27 Feb 2015 23:01:54 GMTiseuldehttps://core.trac.wordpress.org/ticket/31477
https://core.trac.wordpress.org/ticket/31477Report#30859: Capability limit on custom taxonomy does not allow editors to previewMon, 29 Dec 2014 22:32:39 GMTSun, 22 Feb 2015 03:26:48 GMT<p>
This is a super-niche bug, but I believe my potential solution makes post.js more hardy.
</p>
<p>
I'm registering a custom taxonomy with capabilities to limit it in the following way:
</p>
<pre class="wiki"> 'capabilities' =&gt; array(
'manage_terms' =&gt; 'manage_options',
'edit_terms' =&gt; 'manage_options',
'delete_terms' =&gt; 'manage_options',
'assign_terms' =&gt; 'manage_options'
),
</pre><p>
This allows admins to manage the terms and all other users to view any terms that have been set.
</p>
<p>
The full register taxonomy:
</p>
<pre class="wiki">register_taxonomy( 'migrated_category', array( 'post' ), array(
'hierarchical' =&gt; false,
'public' =&gt; false,
'show_ui' =&gt; true,
'show_admin_column' =&gt; false,
'show_in_nav_menus' =&gt; true,
'show_tagcloud' =&gt; false,
'capabilities' =&gt; array(
'manage_terms' =&gt; 'manage_options',
'edit_terms' =&gt; 'manage_options',
'delete_terms' =&gt; 'manage_options',
'assign_terms' =&gt; 'manage_options'
),
'labels' =&gt; array(
'name' =&gt; 'Migrated Categories',
'singular_name' =&gt; 'Migrated Category',
'menu_name' =&gt; 'Migrated Categories',
),
) );
</pre><p>
As an editor, when you publish or save a new post, the terms for migrated categories are not set. This works fine except when attempting to preview this published or saved content. The following error is thrown in post.js
</p>
<pre class="wiki">line 30: Uncaught TypeError: Cannot read property 'replace' of undefined
</pre><p>
tagBox.flushTags() is not expecting both the existing tags and new tags to be undefined. There isn't a check here, so it errors out as tagBox.clean() gets called, expecting tags to be passed to it.
</p>
<p>
I'm attaching a patch that checks for typeof undefined on both tagBox.flushTags() and tagBox.clean(). It may be redundant since it seems like the flush and parse are the only things that call clean, but I'd rather be safe.
</p>
<p>
To note, removing capabilities from the taxonomy works as does having a term already set. Oddly enough, for admins in the same situation this is not a problem at all.
</p>
MikeNGarretthttps://core.trac.wordpress.org/ticket/30859
https://core.trac.wordpress.org/ticket/30859Report#31131: Check Box having two label, Should have single label as other screens.Sun, 25 Jan 2015 19:26:10 GMTFri, 27 Feb 2015 19:37:40 GMT<p>
Check Box of install page having two label on single field, Duplicate labels can lead to confused behavior for screen readers.
</p>
Ankit K Guptahttps://core.trac.wordpress.org/ticket/31131
https://core.trac.wordpress.org/ticket/31131Report#30979: Check for context menu before closing commentReplySun, 11 Jan 2015 14:40:41 GMTTue, 27 Jan 2015 19:09:55 GMT<p>
Login to WP-Admin, go to the comments section and "Quick edit" or "Reply" to a comment.
</p>
<p>
Bring up the context menu either with a right-click or the menu key, press ESC and the context menu and the comment box will close.
</p>
<p>
<a style="padding:0; border:none" href="https://i.imgur.com/xnhrZDr.png"><img src="https://i.imgur.com/xnhrZDr.png" alt="https://i.imgur.com/xnhrZDr.png" title="https://i.imgur.com/xnhrZDr.png" /></a>
</p>
<p>
I understand that this is the expected behaviour but this can be frustrating at times.
</p>
<p>
If you bring up the context menu while typing a long reply but decide not to autocorrect and press ESC to close the context menu everything you've typed so far is gone :(
</p>
<p>
The "Compose email" section of both Gmail and Outlook.com close themselves when ESC is pressed but don't if the context menu is open. So I thought WordPress should also have the same behaviour.
</p>
<p>
The patch checks for a right click or menu key press before doing <tt>commentReply.revert()</tt>.
</p>
jesinhttps://core.trac.wordpress.org/ticket/30979
https://core.trac.wordpress.org/ticket/30979Report#30613: Check the return value of wp_json_encode()Sat, 06 Dec 2014 10:08:13 GMTThu, 05 Feb 2015 21:25:42 GMT<p>
It's possible for <tt>wp_json_encode()</tt> to return <tt>false</tt>, same as <tt>json_encode()</tt>. Everywhere in core, this will cause either invalid JS to be produced, or invalid JSON to be returned to an ajax call.
</p>
<p>
We need to sanity check the return value, and switch <tt>false</tt> for an appropriate response.
</p>
<p>
This ticket is branched from discussion in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28786" title="defect (bug): wp_send_json silently fails on non UTF-8 strings (closed: fixed)">#28786</a>.
</p>
pentohttps://core.trac.wordpress.org/ticket/30613
https://core.trac.wordpress.org/ticket/30613Report#31267: Clean-up documentation for get_filesystem_method()Sun, 08 Feb 2015 21:27:17 GMTSat, 28 Feb 2015 13:49:21 GMTericlewishttps://core.trac.wordpress.org/ticket/31267
https://core.trac.wordpress.org/ticket/31267Report#31503: code flaw in function wp_clean_update_cacheMon, 02 Mar 2015 12:29:48 GMTMon, 02 Mar 2015 13:20:38 GMT<p>
I may be mistaken, but there seems to be a flaw in wp_clean_update_cache. here is teh existing code:
</p>
<pre class="wiki">/**
* Clear existing update caches for plugins, themes, and core.
*
* @since 4.1.0
*/
function wp_clean_update_cache() {
if ( function_exists( 'wp_clean_plugins_cache' ) ) {
wp_clean_plugins_cache();
} else {
delete_site_transient( 'update_plugins' );
}
wp_clean_plugins_cache();
wp_clean_themes_cache();
delete_site_transient( 'update_core' );
}
</pre><p>
If the function 'wp_clean_plugins_cache' exists, then it is called twice, once in the if...else and once outside the if...else.
If the function wp_clean_plugins_cache does not exist then delete_site_transient( 'update_plugins' ); will run (the else) but then you will get a fatal error 'call to an undefined function.
</p>
<p>
Since no one is getting the fatal error, then the else must never be running and why have two calls to teh same function?
</p>
juggledadhttps://core.trac.wordpress.org/ticket/31503
https://core.trac.wordpress.org/ticket/31503Report#29958: collapse menu keyboard accessibilityTue, 14 Oct 2014 18:11:27 GMTMon, 02 Mar 2015 00:41:56 GMT<p>
See also related <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29955" title="defect (bug): Section 508 issues found on WordPress 4.0 admin page. (closed: invalid)">#29955</a> point 1.
</p>
<p>
The "Collapse menu" item is not focusable and keyboard users can't collapse/expand the admin menu.
</p>
<p>
Some screen readers (tested with Firefox + NVDA) may announce it as "clickable" and you can activate it but it's still not focusable: you can't get to it using the Tab key, but only using the Arrow up and Arrow down keys.
Regardless, please consider that this issue is not just for screen reader users, they may found useless to collapse/expand the menu, but it's for all keyboard users: all the people who can't or don't want to use a pointing device. It would be nice to offer them a little improvement.
</p>
<p>
The best option here is to use a <tt>button</tt> element which <a class="ext-link" href="http://www.456bereastreet.com/archive/201302/making_elements_keyboard_focusable_and_clickable/"><span class="icon">​</span>natively supports mouse and keyboard interaction</a>
</p>
<p>
Quoting @joedolson at WordCamp Chicago 2014:
</p>
<blockquote class="citation">
<p>
"If it's supposed to act like a button, it should be a button."
</p>
</blockquote>
<p>
:) Buttons are mentioned also in the <a class="ext-link" href="https://make.wordpress.org/accessibility/draft-theme-review-accessibility-guidelines/"><span class="icon">​</span>accessibility guidelines for themes</a>
</p>
<ul><li>proposed patch also adds a hidden text "Expand menu" that is available just for screen readers when the menu is folded or auto-folded.
</li><li>about colors on hover and focus, tries to take into account the alternative color schemes which currently are a bit inconsistent, but this part is optional; which color should be used?
</li></ul><p>
In the screenshot below, see the current color on hover/focus in different color schemes: should use the submenu items color or its own color?
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/7zgMnvej9i.png"><img src="https://cldup.com/7zgMnvej9i.png" alt="https://cldup.com/7zgMnvej9i.png" title="https://cldup.com/7zgMnvej9i.png" /></a>
</p>
<p>
Needs testing, especially in IE9+.
Any thoughts welcome, especially from the accessibility team and mailing list.
</p>
aferciahttps://core.trac.wordpress.org/ticket/29958
https://core.trac.wordpress.org/ticket/29958Report#22383: Combine Domain and Path UIWed, 07 Nov 2012 22:30:08 GMTWed, 11 Feb 2015 22:06:40 GMT<p>
When editing a site in /network/site-info.php?id=123 you get two fields: one for the site's domain and another for the path.
</p>
<p>
It would make more sense from a UX perspective to have a single URL field, which would be intelligently parsed on save.
</p>
scribuhttps://core.trac.wordpress.org/ticket/22383
https://core.trac.wordpress.org/ticket/22383Report#29991: Comment action links are quite cramped on small screensThu, 16 Oct 2014 04:19:45 GMTMon, 02 Mar 2015 17:00:07 GMT<p>
On mobile devices, the comment action links are quite small and cramped - it's pretty easy to mis-tap.
</p>
pentohttps://core.trac.wordpress.org/ticket/29991
https://core.trac.wordpress.org/ticket/29991Report#31508: comment notification missing old line breakTue, 03 Mar 2015 05:11:33 GMTTue, 03 Mar 2015 10:39:05 GMT<p>
Before the last Wordpress update, when comment notification emails were sent, they were formatted like this:
</p>
<p>
Comment:
Text of comment here
</p>
<p>
Now they're formatted like this:
Comment: Text of comment here
</p>
<p>
In other words, it's missing the line break it used to have between these two lines. It now reads like each comment starts with the words "comment." It was much easier to scan the comment text before (when it started on a new line).
</p>
askamanagerhttps://core.trac.wordpress.org/ticket/31508
https://core.trac.wordpress.org/ticket/31508Report#16365: Comment transition for new commentsMon, 24 Jan 2011 21:07:46 GMTFri, 27 Feb 2015 21:30:10 GMT<p>
As far as I can tell wp_transitions_comment_status() does not get called for new 'comments' based on my testing and review of comment.php in wp-includes.
</p>
<p>
There is a similar transition for posts that gets called for new 'posts' including hooks like 'new_to_publish' and 'new_to_private'.
</p>
<p>
I feel that there should be a similar hook to this form comments so that plugins can hook into new comments differently from comments moved from one existing status to another (like comment_unapproved_to_approved'.
</p>
MattyRobhttps://core.trac.wordpress.org/ticket/16365
https://core.trac.wordpress.org/ticket/16365Report#28080: Commenting possible on custom post type after support for commenting removed from CPT.Wed, 30 Apr 2014 18:41:49 GMTThu, 19 Feb 2015 04:34:15 GMT<p>
I have found that if a custom post type is created with support for comments, and post in that CPT exist, when removing support for comments from the CPT, it is still possible to post comments on existing posts in the CPT. Since the CPT no longer supports comments, there are no discussion controls available in the post editor so discussion can not be manually disabled for the posts created before support for comments was removed from the CPT.
</p>
<p>
I am testing with trunk (4.0 alpha) and Twenty Fourteen.
</p>
Shelob9https://core.trac.wordpress.org/ticket/28080
https://core.trac.wordpress.org/ticket/28080Report#30589: Comments navigation template tagsWed, 03 Dec 2014 22:15:24 GMTWed, 11 Feb 2015 20:08:28 GMT<p>
We've introduced posts navigation template tags in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29808" title="enhancement: Post/paging navigation template tags (closed: fixed)">#29808</a>. Adding equivalent tags for comments would round off the API, giving theme authors tags that work similarly with both posts and comments, with similar output.
</p>
<p>
Unfortunately we missed the boat to have Twenty Fifteen take advantage of it, but that won't keep future themes from benefitting from the functions.
</p>
obenlandhttps://core.trac.wordpress.org/ticket/30589
https://core.trac.wordpress.org/ticket/30589Report#31168: Comments should be turned off on pages by defaultWed, 28 Jan 2015 21:44:35 GMTThu, 19 Feb 2015 04:34:00 GMT<p>
In the vast majority of use cases, you do not want comments turned on for pages. We should turn them off by default and save site builders everywhere some agony.
</p>
melchoycehttps://core.trac.wordpress.org/ticket/31168
https://core.trac.wordpress.org/ticket/31168Report#30949: Consider removing old DFW code form coreThu, 08 Jan 2015 12:20:33 GMTFri, 23 Jan 2015 17:31:34 GMT<p>
Last cycle we decided to try this in 4.2. A plugin could copy the necessary things from 4.1 and hopefully improve it.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/30949
https://core.trac.wordpress.org/ticket/30949Report#29992: Cramped tag action links on small screensThu, 16 Oct 2014 04:34:15 GMTMon, 02 Mar 2015 17:00:07 GMT<p>
The action links on taxonomy list tables are cramped on small screens.
</p>
<p>
We could fix this by hiding the Slug column on small screens.
</p>
pentohttps://core.trac.wordpress.org/ticket/29992
https://core.trac.wordpress.org/ticket/29992Report#30344: Curly Quotes Missing for Strange InputFri, 14 Nov 2014 18:17:34 GMTThu, 19 Feb 2015 21:27:57 GMT<p>
wptexturize() gives unexpected results if an Administrator uses a post body like this:
</p>
<pre class="wiki">&lt;&gt; "Hello world" &lt;&gt;
</pre><p>
This was caused by a small mistake in the new regexp.
</p>
miqrogroovehttps://core.trac.wordpress.org/ticket/30344
https://core.trac.wordpress.org/ticket/30344Report#15015: Customisable submit button for comment formSat, 02 Oct 2010 16:38:10 GMTMon, 02 Mar 2015 18:04:25 GMT<p>
Note: I'm setting this as a blocker because it is a blocker <strong>to me</strong>. Set it whatever you feel appropriate.
</p>
<p>
I badly needed to customise the submit button because I wanted to add a tabindex.
</p>
<p>
I could reimplement the whole form with my markup, but as I already worked my way through all the other fields, I did want to continue this way.
</p>
<p>
Sadly I discovered it's not possible. So, after discussing this in IRC, I decided to hack the core and propose the attached patch.
</p>
<p>
Basically now you can create a filter and output your markup, like this:
</p>
<pre class="wiki">function awesome_comment_form_submit_button($button) {
$button =
'&lt;input name="submit" type="submit" class="form-submit" tabindex="5" id="[args:id_submit]" value="[args:label_submit]" /&gt;' .
get_comment_id_fields();
return $button;
}
add_filter('comment_form_submit_button', 'awesome_comment_form_submit_button');
</pre><p>
and filter magic happens. Please notice that
</p>
<ol><li>you have to include [args:id_submit] and [args:label_submit] if you want the comment_form() parameters to work.
</li><li>you have to use the get_comment_id_fields() function.
</li></ol><p>
It may be better but it works for me. If anybody feels like making it better, be my guest.
</p>
morpheu5https://core.trac.wordpress.org/ticket/15015
https://core.trac.wordpress.org/ticket/15015Report#30713: Customizer control subclasses (custom controls) should have all parent control types as html classesMon, 15 Dec 2014 01:27:27 GMTMon, 09 Feb 2015 12:14:42 GMT<p>
See <a class="ext-link" href="https://wordpress.slack.com/archives/core/p1418599325001596"><span class="icon">​</span>https://wordpress.slack.com/archives/core/p1418599325001596</a>. This will let us simplify our css selectors, and make it easier to create custom controls without duplicating core css. Particularly notable with the core media controls, which are nested several levels deep ((potentially-in-the-future media) -&gt; upload -&gt; image -&gt; background-image/header-image).
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/30713
https://core.trac.wordpress.org/ticket/30713Report#31294: Customizer no longer gracefully handles session expirationWed, 11 Feb 2015 12:38:02 GMTWed, 11 Feb 2015 23:18:32 GMT<p>
Reported by ocean90:
</p>
<blockquote class="citation">
<p>
In <a class="changeset" href="https://core.trac.wordpress.org/changeset/31370" title="Customizer: Introduce an API to create WP_Customize_Settings for ...">r31370</a> you've changed <tt>doing_ajax()</tt> to return only true for <tt>defined( 'DOING_AJAX' ) &amp;&amp; DOING_AJAX</tt>, and not <tt>isset( $_POST['customized'] )</tt> anymore. This breaks the preview if you're logged out because you get a regular <tt>wp_die()</tt> with HTML instead of the <tt>0</tt>.
</p>
</blockquote>
<p>
<a class="ext-link" href="https://wordpress.slack.com/archives/core-customize/p1423601418000599"><span class="icon">​</span>https://wordpress.slack.com/archives/core-customize/p1423601418000599</a>
</p>
<p>
Issue introduced (at least partially) by changes introduced in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/30936" title="enhancement: Dynamically create WP_Customize_Settings for settings created on JS client (closed: fixed)">#30936</a>.
</p>
westonruterhttps://core.trac.wordpress.org/ticket/31294
https://core.trac.wordpress.org/ticket/31294Report#31202: Customizer preview iframe should have a titleSun, 01 Feb 2015 20:54:16 GMTMon, 02 Mar 2015 00:43:03 GMT<p>
Per <a class="ext-link" href="https://make.wordpress.org/accessibility/2015/01/31/theme-switcher-accessibility-test-result/"><span class="icon">​</span>https://make.wordpress.org/accessibility/2015/01/31/theme-switcher-accessibility-test-result/</a>. I think "Site preview" is appropriate.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/31202
https://core.trac.wordpress.org/ticket/31202Report#31501: Customizer Save race condition when attempting to publish too soon after updating widget form fields with multiple editsMon, 02 Mar 2015 09:23:27 GMTMon, 02 Mar 2015 09:53:39 GMT<p>
On a slow connection or if a widget update callback takes any amount of processing time complete, multiple edits to one or more form fields will have multiple simultaneous <tt>update_widget</tt> Ajax requests open at a time. The last one to return would have the winning instance data to supply for the widget form: a race condition. Before an update widget request is kicked off, any previous request should be aborted so that only the last user-submitted data is used in the form instance.
</p>
<p>
Additionally, when invoking the Customizer Save functionality, it needs to hold off on gathering up the {{customized}} data to POST to the server until the {{processing}} state is cleared-out; right now it is incorrectly obtaining the data to send before any widgets have finished processing to get their settings from the server over Ajax.
</p>
westonruterhttps://core.trac.wordpress.org/ticket/31501
https://core.trac.wordpress.org/ticket/31501Report#27355: Customizer: Add framework for partial preview refreshesTue, 11 Mar 2014 15:58:56 GMTTue, 27 Jan 2015 00:25:49 GMT<p>
In regards to the Widget Customizer merge in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/27112" title="task (blessed): Add widget management to the customizer (closed: fixed)">#27112</a>, we agreed to remove the partial preview refreshing of widgets (live previews via postMessage transport and re-rendering widgets via Ajax then doing DOM replacements). This live preview functionality for widgets was removed in favor of generalizing the functionality so that any customize control can add support for doing so. This partial preview refresh is key to keeping things DRY by eliminating the current requirement that all setting updates via postMessage transport re-implement all rendering logic in JavaScript for components that are normally written out in PHP—but even when the render logic is attempted to be written in JS, it will never be able to account for any filters added in PHP.
</p>
<p>
For instance, with such partial preview refreshes, the Navigation Menu control needn't do a full refresh of the preview: the menu's container could be targeted for a partial refresh, where the new menu gets rendered via an Ajax request and the response replaces the old menu.
</p>
<p>
Originally mentioned at <a href="https://core.trac.wordpress.org/ticket/27112#comment:10">https://core.trac.wordpress.org/ticket/27112#comment:10</a>
</p>
westonruterhttps://core.trac.wordpress.org/ticket/27355
https://core.trac.wordpress.org/ticket/27355Report#31289: Customizer: theme switcher navigation streamliningWed, 11 Feb 2015 01:16:10 GMTWed, 25 Feb 2015 22:31:23 GMT<p>
The upcoming <a class="ext-link" href="https://make.wordpress.org/core/2015/02/03/customizer-theme-switcher-update-22/"><span class="icon">​</span>customizer theme switcher</a> has the navigation that while works well in term of information hierarchy with a slide in the opposite direction, has the various navigation element a bit mixed in terms of navigation (arrows directions, headers).
</p>
<p>
This ticket aims to address these issues.
</p>
follettohttps://core.trac.wordpress.org/ticket/31289
https://core.trac.wordpress.org/ticket/31289Report#30766: Dashboard - At a glance metabox update button is misalignedThu, 18 Dec 2014 21:07:58 GMTSun, 22 Feb 2015 07:19:49 GMT<p>
See screenshot. Likely dates to 3.8.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/30766
https://core.trac.wordpress.org/ticket/30766Report#31388: Database Error During UpgradeThu, 19 Feb 2015 19:20:45 GMTThu, 19 Feb 2015 20:18:32 GMT<p>
I used the Beta Tester plugin to update a test site from 4.0 to 4.2-alpha-31473. I was greeted with an error after the database upgrade step:
</p>
<pre class="wiki">WordPress database error: [Can't DROP 'slug'; check that column/key exists]
ALTER TABLE wp_terms DROP INDEX slug, ADD INDEX slug(slug(191))
</pre>miqrogroovehttps://core.trac.wordpress.org/ticket/31388
https://core.trac.wordpress.org/ticket/31388Report#30864: Date format inconsistent across the adminTue, 30 Dec 2014 14:50:35 GMTSun, 18 Jan 2015 15:52:04 GMT<p>
See <a href="https://core.trac.wordpress.org/browser/tags/4.1/src/wp-includes/media.php#L2631">https://core.trac.wordpress.org/browser/tags/4.1/src/wp-includes/media.php#L2631</a>.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/30864
https://core.trac.wordpress.org/ticket/30864Report#16276: Default value for search field - (#11420 Easy within-site linking from new content)Mon, 17 Jan 2011 20:14:42 GMTMon, 09 Feb 2015 20:57:57 GMT<p>
The within-site linking available in the current release candidate looks like a great idea, but I'm wondering if it might make sense to pre-popular the search box area with the selected text that is highlighted.
</p>
<p>
Currently the search box (which is actually more of a filter box) is empty by default, but it seems to me that most of the time if you are linking to internal content, you will be linking to the material you are highlighting which will have a similar title.
</p>
jamie.richardhttps://core.trac.wordpress.org/ticket/16276
https://core.trac.wordpress.org/ticket/16276Report#30190: Denote Front and Posts Pages (in list view)Thu, 30 Oct 2014 00:17:06 GMTThu, 15 Jan 2015 22:28:35 GMT<p>
Right now, if you set custom pages for "front page" and "posts page" in settings, there are no markings on the page list view that denotes you these as special pages.
</p>
<p>
I've seen other systems add small text to the title to denote that it is currently set as "front page". I believe it would make for a better UX if WordPress did something similar.
</p>
ctalkingtonhttps://core.trac.wordpress.org/ticket/30190
https://core.trac.wordpress.org/ticket/30190Report#17817: do_action/apply_filters/etc. recursion on same filter kills underlying callThu, 16 Jun 2011 18:04:04 GMTWed, 25 Feb 2015 21:46:05 GMT<p>
Affects @wp-includes/plugin.php: do_action, do_action_ref_array, apply_filters, apply_filters_ref_array, _wp_call_all_hook
</p>
<p>
When calling a specific hook from a function that was called through that same hook, the remaining hooked functions from the first iteration will be discarded.<br />
This is due to the handling of the array of registered functions using internal array pointers instead of a more robust approach.
</p>
<p>
In my example, this problem arose when I tried to programmatically delete a menu in reaction to the removal of a category. I hooked into the delete_term action to do so, upon which another function hooked into delete_term would no longer fire.<br />
The obvious workaround is to adjust the priorities accordingly, but it shouldn't be necessary.
</p>
<p>
The current implementation as in apply_filters is:
</p>
<pre class="wiki">reset( $wp_filter[ $tag ] );
if ( empty($args) )
$args = func_get_args();
do {
foreach( (array) current($wp_filter[$tag]) as $the_ )
if ( !is_null($the_['function']) ){
$args[1] = $value;
$value = call_user_func_array($the_['function'], array_slice($args, 1, (int) $the_['accepted_args']));
}
} while ( next($wp_filter[$tag]) !== false );
</pre><p>
Using the following method instead, both iterations would develop properly:
</p>
<pre class="wiki">if ( empty($args) )
$args = func_get_args();
foreach ( $wp_filter[$tag] as $filters )
foreach( (array) $filters as $the_ )
if ( !is_null($the_['function']) ){
$args[1] = $value;
$value = call_user_func_array($the_['function'], array_slice($args, 1, (int) $the_['accepted_args']));
}
</pre>kernfelhttps://core.trac.wordpress.org/ticket/17817
https://core.trac.wordpress.org/ticket/17817Report#30883: Duplicate post_class() for different categoriesFri, 02 Jan 2015 00:24:10 GMTSat, 24 Jan 2015 01:48:30 GMT<ol><li>Create two categories, "Первая рубрика" and "Вторая рубрика". They will have the following slugs:
<pre class="wiki">%d0%b2%d1%82%d0%be%d1%80%d0%b0%d1%8f-%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0
%d0%bf%d0%b5%d1%80%d0%b2%d0%b0%d1%8f-%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0
</pre></li><li>Create a post in each category.
</li><li>Both posts will have a <tt>category--</tt> class.
</li></ol><p>
<tt>sanitize_html_class()</tt> uses a fallback value (term ID) if the resulting string is empty. It should do the same if the resulting string only contains hyphens.
</p>
SergeyBiryukovhttps://core.trac.wordpress.org/ticket/30883
https://core.trac.wordpress.org/ticket/30883Report#31326: Edit comment screen: misplaced-missing labelsFri, 13 Feb 2015 23:04:10 GMTMon, 02 Mar 2015 07:32:04 GMT<p>
In this form, neither "Name:&#34;, &#34;E-mail:&#34; or &#34;URL:" are labels.
</p>
<p>
The only label is the title "Author" associated with the "Name:" field. Pretty weird. See screenshot.
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/hw4IWGSouw.png"><img src="https://cldup.com/hw4IWGSouw.png" alt="https://cldup.com/hw4IWGSouw.png" title="https://cldup.com/hw4IWGSouw.png" /></a>
</p>
<p>
Once fixed, links can't be inside labels, it's pretty confusing. I'd propose to move them below the form fields. I'd say the proposed elements order makes sense when tabbing, e.g.:
E-mail &gt; {someone @ somewhere.org} -&gt; send email
</p>
<p>
The three form fields are now grouped in a <tt>&lt;fieldset&gt;</tt> and "Author" is the fieldset's <tt>&lt;legend&gt;</tt>. Added also a screen-reader-text'ed label for the comment's textarea. See screenshot:
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/_rL9uFi_31.png"><img src="https://cldup.com/_rL9uFi_31.png" alt="https://cldup.com/_rL9uFi_31.png" title="https://cldup.com/_rL9uFi_31.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31326
https://core.trac.wordpress.org/ticket/31326Report#31328: Emoji in a slug fails to displaySat, 14 Feb 2015 04:31:20 GMTTue, 03 Mar 2015 05:12:43 GMT<p>
When using emoji in a place that generates a slug (category name, post title, etc), if the emoji is saved to the database as HTML entities, it will fail to display in the UI.
</p>
<p>
Example: Save a draft/publish with post title is "WordPress {sparkling_heart emoji} Emoji".
URL/slug will be "wordpress-%f0%9f%92-emoji"
On post.php, the slug will not display: <a class="ext-link" href="https://cloudup.com/cASF4rxUNhF"><span class="icon">​</span>https://cloudup.com/cASF4rxUNhF</a>
</p>
<p>
Second example: Save a new category with the name being an emoji.
Slug is saved to the db in the HTML entity format ("%f0%9f%92").
On edit-terms.php, no slug will be displayed.
</p>
kraftbjhttps://core.trac.wordpress.org/ticket/31328
https://core.trac.wordpress.org/ticket/31328Report#22799: Erase Formatting Doesn't eraseThu, 06 Dec 2012 23:45:08 GMTFri, 16 Jan 2015 19:37:56 GMT<p>
In the Content area of a page under the visual test manager of a page if you highlight text click the bold button add italics and cross out. When I I highlight the text and then click the erase format button it only removes the italics and leaves the cross out.
</p>
<p>
On two other builds I have tested this problem with it turns the text red?
</p>
<p>
Have tested on two local installs. (one clean to test this issue) and one external install. All using Trunk all the same issue. See screenshot for visual reference.
</p>
<p>
<a class="ext-link" href="http://cl.ly/image/1Y1I1H2u471E"><span class="icon">​</span>http://cl.ly/image/1Y1I1H2u471E</a>
</p>
RDallhttps://core.trac.wordpress.org/ticket/22799
https://core.trac.wordpress.org/ticket/22799Report#31149: Error Object of class stdClass could not be converted to int in ms-functions.php on line 1788Tue, 27 Jan 2015 23:15:46 GMTFri, 30 Jan 2015 12:41:19 GMT<p>
Issue cause by <tt>$wpdb-&gt;get_row()</tt> return object to <tt>$local_id</tt> but was pass to global_terms to use as int. Fix by switching to <tt>$wpdb-&gt;get_var()</tt>:
</p>
<p>
Change from:
</p>
<pre class="wiki">$local_id = $wpdb-&gt;get_row( $wpdb-&gt;prepare( "SELECT term_id FROM $wpdb-&gt;terms WHERE term_id = %d", $global_id ) );
</pre><p>
To correction:
</p>
<pre class="wiki">$local_id = $wpdb-&gt;get_var( $wpdb-&gt;prepare( "SELECT term_id FROM $wpdb-&gt;terms WHERE term_id = %d", $global_id ) );
</pre>hauvonghttps://core.trac.wordpress.org/ticket/31149
https://core.trac.wordpress.org/ticket/31149Report#22768: EXIF/IPTC captions should populate caption/post_excerpt on upload, not description/post_contentThu, 06 Dec 2012 00:24:39 GMTWed, 25 Feb 2015 21:55:50 GMT<p>
It's been this way forever, but it is dumping data into the wrong field. Two schools of thought on this:
</p>
<ul><li>Plugins have used the description field, so we should not change this.
</li></ul><ul><li>Users continue to struggle with moving *captions* from the description field to the caption field, so we should change this.
</li></ul><p>
I am in the latter school of thought. A plugin can remain compatible by ensuring it checks either description or caption before falling back to the other.
</p>
nacinhttps://core.trac.wordpress.org/ticket/22768
https://core.trac.wordpress.org/ticket/22768Report#28185: Expose image attachment title and/or filename in the image details modalThu, 08 May 2014 23:46:33 GMTMon, 02 Mar 2015 18:37:30 GMT<p>
I ran into a case where I had a post with an image I wanted to set as the featured thumbnail. My Media library is very large and I didn't know the file name so I clicked the edit icon on the image to view the Image Details. Nowhere within the image details does it show either the image title, or file name. My suggestion would be to place it next to the words "Image Details", but i'm not married to the idea.
</p>
<p>
The search field in the media library looks for these attributes to filter the library list, it would be convenient if it were clearly labelled within the "Image Details" modal.
</p>
<p>
Additionally, once you do find the image in the media library, both the file name and image title are clearly visible.
</p>
<p>
I created an annotated video to clearly explain the issue:
<a class="ext-link" href="https://www.youtube.com/watch?v=lS55abTV7qc"><span class="icon">​</span>https://www.youtube.com/watch?v=lS55abTV7qc</a>
</p>
drrobotnikhttps://core.trac.wordpress.org/ticket/28185
https://core.trac.wordpress.org/ticket/28185Report#20774: Flagging a user with any role on a subsite as spam leads to flagging the site as spamTue, 29 May 2012 12:25:52 GMTMon, 23 Feb 2015 01:23:17 GMT<p>
Hi,
</p>
<p>
Since many weeks, many WangGuard users were contacting me because they say WangGuard were flagging the sub sites as spam.
</p>
<p>
Thats not a WangGuard bug, is a WordPress issue.
</p>
<p>
Steps:
</p>
<ul><li>Create a Subsite, you can add the Super Admin like site admin.
</li><li>Add a user like subscriber.
</li><li>Flag that user as spam in /network/users.php
</li></ul><p>
That site will be flagged as spam although the owner were the Super Admin.
</p>
<p>
I think WordPress has to look for the user rol and only flag the sub site as spam if the rol is Administrator.
</p>
<p>
This issue is in WP 3.3.1 and 3.4
</p>
j.contihttps://core.trac.wordpress.org/ticket/20774
https://core.trac.wordpress.org/ticket/20774Report#28820: Focus isn't clear when previewing an oEmbed from Add Media PanelThu, 10 Jul 2014 20:57:25 GMTFri, 27 Feb 2015 22:13:18 GMT<p>
Summary: After pasting an oEmbed URL into the "Insert from URL" portion of the Add Media Panel, tabbing away from the URL field does not provide a clear indication of focus.
</p>
<p>
Steps to reproduce:
</p>
<ol><li>Enter the post editor
</li><li>Open the Add Media Panel
</li><li>Go to the "Insert from URL" screen
</li><li>Paste an oEmbed (e.g. YouTube) URL into the URL field, and wait for the embed to appear
</li><li>Tab away from the URL field - the focus is unclear
</li></ol><p>
Further tabbing shows the focus was on the preview after tabbing away. I've replicated this using both YouTube and WordPress.tv embeds.
</p>
<p>
Attached is a screenshot showing the view after tabbing from the URL field.
</p>
philipjohnhttps://core.trac.wordpress.org/ticket/28820
https://core.trac.wordpress.org/ticket/28820Report#31203: Focus style for add-new-theme should match hover styleSun, 01 Feb 2015 21:06:30 GMTMon, 02 Feb 2015 16:08:45 GMT<p>
This also fixes the issue for the Customizer Theme Switcher plugin. See <a class="ext-link" href="https://make.wordpress.org/accessibility/2015/01/31/theme-switcher-accessibility-test-result/"><span class="icon">​</span>https://make.wordpress.org/accessibility/2015/01/31/theme-switcher-accessibility-test-result/</a>.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/31203
https://core.trac.wordpress.org/ticket/31203Report#30807: Font family titles in ArabicSun, 21 Dec 2014 11:57:49 GMTMon, 02 Mar 2015 18:49:50 GMT<p>
Titles should look differently from the rest of the text.
In Arabic, the font Arial (bold) is the most appropriate font for titles (H1, H2, H3, H4, H5, H6).
Is it possible to apply this rule to all the titles/headings?
</p>
rasheedhttps://core.trac.wordpress.org/ticket/30807
https://core.trac.wordpress.org/ticket/30807Report#30802: General settings menu isn't opened.Sun, 21 Dec 2014 04:34:51 GMTFri, 20 Feb 2015 02:15:18 GMT<p>
After upgrading to 4.1, I can't open General menu in Settings. When I click General menu, the server don't reply. The file of this menu is options-general.php. And below is the path of tracing a reason.
</p>
<p>
wp-admin/options-general.php
</p>
<ul><li>356 : wp_can_install_language_pack()
</li></ul><p>
wp-admin/include/translation-install.php
</p>
<ul><li>233 : fs_connect( array( WP_CONTENT_DIR, WP_LANG_DIR ) )
</li></ul><p>
wp-admin/include/class-wp-upgrader.php
</p>
<ul><li>193 : $wp_filesystem-&gt;find_folder($dir)
</li></ul><p>
wp-admin/include/class-wp-filesystem-base.php
</p>
<ul><li>273 : search_for_folder($folder)
</li><li>293 : trailingslashit($this-&gt;cwd()); ====&gt; $this-&gt;cwd() is defined to return false always at 525 line.
</li><li>1661 : untrailingslashit( $string ) . '/';
</li><li>1667 : rtrim( $string, '/<br />' ); ====&gt; $string isn't string. It is boolean value 'false'.
</li></ul><p>
I can't find where rtrim is defined. But it is clear rtrim must have a string variable as first input. In this case, rtrim gets boolean value 'false' as $string. This makes server blocked. If I remove this function(This means skipping this.), the general settings screen is shown properly. And I don't know why a boolean value is given as a first string variable.
</p>
<p>
Why rtrim gets a boolean value as a first string variable?
If it is a root reason, how do I fix this problem?
</p>
<p>
If you want to see the problem, visit here.
<a class="ext-link" href="http://칭기즈칸.한국/"><span class="icon">​</span>http://칭기즈칸.한국/</a>
And general settings path is below.
<a class="ext-link" href="http://칭기즈칸.한국/wp-admin/options-general.php"><span class="icon">​</span>http://칭기즈칸.한국/wp-admin/options-general.php</a>
</p>
hyoseophttps://core.trac.wordpress.org/ticket/30802
https://core.trac.wordpress.org/ticket/30802Report#29892: get_available_languages() can alternately too and not enough permissiveWed, 08 Oct 2014 15:03:45 GMTFri, 13 Feb 2015 16:30:44 GMT<p>
Since 4.0, it's possible to switch site languages from the language dropdown in options-general.php. This is a great feature.
</p>
<p>
But i think there can be cases when get_available_languages() is too permissive and others not enough.
</p>
<p>
1/ Too permissive
If for some reason, a theme or plugin language file is added at the root of <tt>WP_LANG_DIR</tt>, then the theme or plugin language file will be listed in the dropdown because it names does not start with 'continents-cities' or 'ms-' or 'admin-'. It can be confusing for the site admin.
</p>
<p>
2/ Not enough (might be an edge case)
<tt>get_available_languages()</tt> accepts a <tt>$dir</tt> param. So although it's not used in core, i guess plugins/themes can use this function to list language files of a given directory. In this case, if one of the file starts with 'continents-cities' or 'ms-' or 'admin-' then it won't be listed.
</p>
<p>
The attached patch is suggesting a way to be sure only site language files will be listed if the $dir param is null or == <tt>WP_LANG_DIR</tt> else to list all language files.
</p>
imathhttps://core.trac.wordpress.org/ticket/29892
https://core.trac.wordpress.org/ticket/29892Report#31469: get_avatar_data() Needs More ArgsThu, 26 Feb 2015 19:10:09 GMTSun, 01 Mar 2015 07:18:43 GMT<p>
The new get_avatar_data() and its filters are too limited because they do not provide any way to change the display dimensions, or to add extra attributes without using the old existing filters on the IMG element itself.
</p>
<p>
Previously mentioned at <a href="https://core.trac.wordpress.org/ticket/22329#comment:49">https://core.trac.wordpress.org/ticket/22329#comment:49</a>
</p>
miqrogroovehttps://core.trac.wordpress.org/ticket/31469
https://core.trac.wordpress.org/ticket/31469Report#30354: get_posts_by_author_sql doesn't also return prefixed where is asked toSat, 15 Nov 2014 22:39:54 GMTFri, 23 Jan 2015 17:55:05 GMT<p>
In get_posts_by_author_sql() if you set the full to false it doesn't return the post type element of the query
</p>
pbearnehttps://core.trac.wordpress.org/ticket/30354
https://core.trac.wordpress.org/ticket/30354Report#31351: get_the_post_thumbnail() needs a clearer explanation of the difference between 'post-thumbnail' and 'thumbnail'Mon, 16 Feb 2015 20:04:02 GMTMon, 02 Mar 2015 03:00:17 GMT<p>
Been discussing this with @drewapicture today.
</p>
<p>
I'd like to add a small comment to the inline docs for get_the_post_thumbnail() to make clear the difference between the image sizes <tt>thumbnail</tt> and <tt>post-thumbnail</tt>.
</p>
<p>
I'm also going to update the codex page on "Post Thumbnails" to clarify the difference there as it's quite confusing. The action to do that is not part of this ticket.
</p>
<p>
I'm a relative newbie to trac. I may need hand-holding. Be nice! :)
</p>
magicroundabouthttps://core.trac.wordpress.org/ticket/31351
https://core.trac.wordpress.org/ticket/31351Report#30380: get_transient doesn't check the return of get_optionTue, 18 Nov 2014 06:48:48 GMTWed, 18 Feb 2015 23:04:05 GMT<p>
When calling get_transient on a key that doesn't exist, notoptions[$key] is set so it won't do any further queries, but it doesn't go far enough. Since the get_option( $transient_timeout ) doesn't check the return well enough it will always cause 2 more queries. (SELECT autoload FROM wp_options ...)
</p>
<p>
If get_options( $transient_timeout ) is returning false, what is the point of trying to delete it.
</p>
jamesgolhttps://core.trac.wordpress.org/ticket/30380
https://core.trac.wordpress.org/ticket/30380Report#31242: Global Emoji SupportFri, 06 Feb 2015 02:38:26 GMTThu, 12 Feb 2015 14:44:23 GMT<p>
Once <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/21212" title="task (blessed): MySQL tables should use utf8mb4 character set (closed: fixed)">#21212</a> is complete, then WordPress will support storing emoji in the database.
</p>
<p>
The problem is, some browsers still don't support displaying emoji. We need to work around their lack of useful features.
</p>
<p>
Here's a plugin to get things rolling:
</p>
<p>
<a class="ext-link" href="https://github.com/pento/x1f4a9"><span class="icon">​</span>https://github.com/pento/x1f4a9</a>
</p>
pentohttps://core.trac.wordpress.org/ticket/31242
https://core.trac.wordpress.org/ticket/31242Report#31252: grid view in media library malfunctioning in Simplified Chinese installFri, 06 Feb 2015 21:22:33 GMTSat, 07 Feb 2015 05:59:46 GMT<p>
Media library grid breaks in Simplified Chinese install.
<a class="ext-link" href="https://wordpress.org/support/topic/the-grid-view-of-media-gallery-is-malfunctioning-in-simplified-chinese-install?replies=1"><span class="icon">​</span>https://wordpress.org/support/topic/the-grid-view-of-media-gallery-is-malfunctioning-in-simplified-chinese-install?replies=1</a>
</p>
kidsguidehttps://core.trac.wordpress.org/ticket/31252
https://core.trac.wordpress.org/ticket/31252Report#29792: Grunt: Add a precommit task to check for CSS syntax errorsMon, 29 Sep 2014 13:07:40 GMTFri, 27 Feb 2015 22:11:39 GMT<p>
We need to do a better job of catching sad syntax errors and problems in our CSS before commit - things like parse errors, empty rules, units on zero values, and possibly duplicate properties (when alone, not as a part of a group). There may also be a thing or two that we could enforce per our own standards, such as requiring a comment to follow any declaration with <tt>!important</tt>.
</p>
<p>
CSSLint seems to do most of these, provided we turn off the majority of its checks. Many of those checks (vendor prefixes, selector specificity, etc.) either are not relevant to our set up (due to Autoprefixer, for example) or are just not feasible given our current CSS and possibly not desirable for this project.
</p>
<p>
Interested to know if there are any other tools out there that perhaps fit the job better, and defining the parameters of what we would like to check.
</p>
helenhttps://core.trac.wordpress.org/ticket/29792
https://core.trac.wordpress.org/ticket/29792Report#31080: GUID should not always be escaped for url in feedsTue, 20 Jan 2015 21:08:52 GMTMon, 02 Mar 2015 20:33:09 GMT<p>
Hello,
On the /wp-includes/feed-rss2.php template, it validates the GUID as a url before outputting it (through the_guid() which calls esc_url()). So far so good because in Wordpress, GUID are urls by default.
</p>
<p>
However, it should not always be the case.
</p>
<p>
Example : a website migrating from another CMS to Wordpress. Some people are already subscribed to the feed in the other CMS and are reading it through some feed reader. The GUIDs in the other CMS are phrases with spaces. Then migrating the website, Wordpress will strip the spaces from the GUIDs, the feed readers will interpret those items as new items, the people will see duplicate items.
</p>
<p>
This bug might also be hidden in other feed templates.
</p>
CheeseDurgerhttps://core.trac.wordpress.org/ticket/31080
https://core.trac.wordpress.org/ticket/31080Report#29989: Hide Media Buttons on small screensThu, 16 Oct 2014 03:48:31 GMTMon, 02 Mar 2015 22:44:38 GMT<p>
On small screens, the media buttons above the post editor can take a up a lot of room, especially if plugins have added extra buttons.
</p>
<p>
It would be nice if they were hidden (perhaps in a dropdown) for small screens.
</p>
<p>
This would also be useful for the new distraction free writing mode.
</p>
pentohttps://core.trac.wordpress.org/ticket/29989
https://core.trac.wordpress.org/ticket/29989Report#29476: Hide the 'Title' field on the 'Insert from URL' tab until it's neededTue, 02 Sep 2014 20:27:59 GMTSun, 22 Feb 2015 03:11:57 GMT<p>
As helen mentioned in IRC, the 'Title' field on the 'Insert from URL' tab in the media manager should remain hidden until we've confirmed (via AJAX) that a URL can't be embedded.
</p>
<p>
Marking as 4.0. I'll let helen/nacin/MarkJaquith make the call.
</p>
johnbillionhttps://core.trac.wordpress.org/ticket/29476
https://core.trac.wordpress.org/ticket/29476Report#27115: HTTPS links to wordpress.orgWed, 12 Feb 2014 21:19:55 GMTFri, 13 Feb 2015 16:07:44 GMT<p>
It appears that wordpress.org now favours an SSL connection, although it is not currently enforced. <a class="ext-link" href="https://www.google.com/search?q=wordpress"><span class="icon">​</span>Googling for WordPress returns a link to https://wordpress.org</a> and once you're on the site, the HTTPS links persist.
</p>
<p>
We should convert all wordpress.org links in the dashboard to HTTPS links.
</p>
<p>
Any objections?
</p>
johnbillionhttps://core.trac.wordpress.org/ticket/27115
https://core.trac.wordpress.org/ticket/27115Report#28272: Image loses link after drag and dropThu, 15 May 2014 21:40:25 GMTFri, 27 Feb 2015 16:05:54 GMT<p>
To reproduce, insert an image with a link, drag it to another paragraph. The link is gone.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/28272
https://core.trac.wordpress.org/ticket/28272Report#31253: Images should be forced to fit inside the editorFri, 06 Feb 2015 21:54:30 GMTFri, 06 Feb 2015 23:24:03 GMT<p>
I think it would be best if images and captions have a <tt>max-width: 100%;</tt>.
</p>
<p>
This appeared to be a bit of a problem on iOS... Another bug, again.
Inside iframes, Safari on iOS doesn't obey <tt>max-width</tt> if a <tt>width</tt> is set on the element. It does work if a width attribute is used though. The only solution seems to be overwriting with <tt>width: auto;</tt>.
</p>
<p>
Related:
</p>
<p>
</p><div><dl class="wiki compact"><dt><a class="new" href="/ticket/24968" title="$content_width not constraining images in fullscreen editor">#24968</a></dt><dd>$content_width not constraining images in fullscreen editor</dd><dt><a class="closed" href="/ticket/30696" title="Inline media toolbar positioning">#30696</a></dt><dd>Inline media toolbar positioning</dd><dt><a class="new" href="/ticket/31250" title="Twenty Fifteen editor styles look weird on mobile">#31250</a></dt><dd>Twenty Fifteen editor styles look weird on mobile</dd></dl></div><p>
</p>
iseuldehttps://core.trac.wordpress.org/ticket/31253
https://core.trac.wordpress.org/ticket/31253Report#31467: Images should default to not linkingThu, 26 Feb 2015 18:54:56 GMTFri, 27 Feb 2015 02:23:43 GMT<p>
For the reasons discussed in this Slack conversation: <a class="ext-link" href="https://wordpress.slack.com/archives/core-flow/p1424973816000003"><span class="icon">​</span>https://wordpress.slack.com/archives/core-flow/p1424973816000003</a>
</p>
<blockquote class="citation">
<p>
In conversation with developers and users there is a general feeling of frustration about the default "link to" for images and image galleries being set to Attachment Page. Users generally don't understand what this is and few theme developers bother to build a template for it — @mor10
</p>
</blockquote>
<blockquote class="citation">
<p>
I would LOVE if the default link for images was none. That confuses my students every time. They add a picture and have no idea why it's linking to the Attachment page and what an attachment page even is. I think linking should take action, not unlinking — @liljimmi
</p>
</blockquote>
<blockquote class="citation">
<p>
same here. also there is an issue where i see people naming an image and a post the exact same slug and this shows the attachment page of the image instead of the post they were expecting. — @andrea_r
</p>
</blockquote>
<p>
I agree — changing the default to <em>not</em> link is the expected behavior for the vast majority of people. Let's turn off linking by default.
</p>
melchoycehttps://core.trac.wordpress.org/ticket/31467
https://core.trac.wordpress.org/ticket/31467Report#23285: Implement an AMD JavaScript loader in WordPressThu, 24 Jan 2013 14:28:47 GMTSat, 03 Jan 2015 05:55:25 GMT<p>
AMD = Asynchronous Module Definition
</p>
<p>
See comment: <a class="ext-link" href="http://core.trac.wordpress.org/ticket/22896#comment:29"><span class="icon">​</span>http://core.trac.wordpress.org/ticket/22896#comment:29</a>
</p>
<p>
I think this is a must for the future viability of WordPress and plugins written for it.
</p>
<p>
Multiple versions of JavaScript libraries are a fact of life and we have to deal with it somehow.
</p>
<p>
If WordPress provides the framework for the use of multiple versions of JavaScript libraries then a lot of the problems we see with WordPress now will be a thing of the past.
</p>
<p>
This represents a major re-think of the current WordPress JavaScript loading paradigm, but I think it is necessary and would be well worth it.
</p>
<p>
I'm not a terribly advanced developer, and there might be better solutions out there or others to come, but for now, I think this is the way to go.
</p>
<p>
Example:
</p>
<p>
<a class="ext-link" href="http://requirejs.org/docs/why.html"><span class="icon">​</span>http://requirejs.org/docs/why.html</a>
</p>
<p>
<a class="ext-link" href="http://requirejs.org/docs/whyamd.html"><span class="icon">​</span>http://requirejs.org/docs/whyamd.html</a>
</p>
<p>
<a class="ext-link" href="https://github.com/amdjs/amdjs-api/wiki/AMD"><span class="icon">​</span>https://github.com/amdjs/amdjs-api/wiki/AMD</a>
</p>
<p>
It does not have to be RequireJS, but it seems the most mature and popular of the implementations.
</p>
<p>
From the unminified jQuery source:
</p>
<pre class="wiki">// Expose jQuery as an AMD module, but only for AMD loaders that
// understand the issues with loading multiple versions of jQuery
// in a page that all might call define(). The loader will indicate
// they have special allowances for multiple jQuery versions by
// specifying define.amd.jQuery = true. Register as a named module,
// since jQuery can be concatenated with other files that may use define,
// but not use a proper concatenation script that understands anonymous
// AMD modules. A named AMD is safest and most robust way to register.
// Lowercase jquery is used because AMD module names are derived from
// file names, and jQuery is normally delivered in a lowercase file name.
// Do this after creating the global so that if an AMD module wants to call
// noConflict to hide this version of jQuery, it will work.
if ( typeof define === "function" &amp;&amp; define.amd &amp;&amp; define.amd.jQuery ) {
define( "jquery", [], function () { return jQuery; } );
}
</pre><p>
Note: <strong>multiple versions of jQuery</strong>
</p>
auniquenamehttps://core.trac.wordpress.org/ticket/23285
https://core.trac.wordpress.org/ticket/23285Report#28603: Improve "previously approved comment" test for logged-in usersFri, 20 Jun 2014 20:34:16 GMTSun, 01 Mar 2015 06:16:26 GMT<p>
In order to restrict spam, my site uses the following settings to restrict the ability to comment (from /wp-admin/options-discussion.php):
</p>
<p>
1: Other comment settings / Users must be registered and logged in to comment
2: Before a comment appears / Comment author must have a previously approved comment
</p>
<p>
This generally works as expected, however the second requirement appears to test the user's profile information rather than user ids. This means that whenever a user changes either their nickname or e-mail, their next comment is held for moderation.
</p>
<p>
In my view, a better implementation would allow comments from logged-in users with previously approved comments immediately after a change to whatever profile information is currently tested.
</p>
<p>
Apologies if this issue has been discussed before, I certainly couldn't find that discussion.
</p>
nevermoorhttps://core.trac.wordpress.org/ticket/28603
https://core.trac.wordpress.org/ticket/28603Report#28784: Improve the Customize experience on mobileTue, 08 Jul 2014 00:57:05 GMTWed, 11 Feb 2015 18:33:37 GMT<p>
The Customizer currently works on mobile, despite what you might think. Utilizing the "collapse" function, it's possible to change settings and switch back and forth between the controls and the preview window. But the experience doesn't work on every device (there are some scrolling issues), and could be much smoother and more intuitive.
</p>
<p>
The controls part of the Customizer is already mobile-optimized - at 300px wide, it works quite well on mobile and the only major issues are with things like the widget-adder that pop out of the main control panel. Similarly, the preview works down to tablet-sized devices with responsive themes, although it continues to be squeezed to unrealistic widths on smaller devices.
</p>
<p>
We should look at revamping the Customizer experience on smaller devices - anything smaller than about 620px wide can't realistically be used in the standard controls/preview mode. For this ticket, the goal is to make the cosmetic tweaks necessary to streamline the Customization experience on mobile, most likely by hiding the preview at a certain point and highlighting the ability to switch between the controls and the preview.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/28784
https://core.trac.wordpress.org/ticket/28784Report#30202: In multisite, the "storage space used" is incorrectly calculated for the main blog/site.Thu, 30 Oct 2014 21:45:16 GMTTue, 10 Feb 2015 21:50:16 GMT<p>
Recently identified an issue in a few multisite installs where the "space used" that displays on the dashboard of the main site is calculating everything in /wp-content/uploads/, including the subsite uploads in /wp-content/uploads/sites/. For instance, the main site has only 4MB in its Media Library, but the dashboard shows that it's exceeded the storage limit of 150MB and prevents users from uploading files. The additional storage used corresponds with the files uploaded to the network's subsites in /wp-content/uploads/sites/.
</p>
<p>
Notes:
</p>
<ul><li>This is not an issue on other multisite instances that are using the /blogs.dir/ path for uploads.
</li><li>Organize uploads by year/month is disabled on all instances.
</li></ul>rebekahickeyhttps://core.trac.wordpress.org/ticket/30202
https://core.trac.wordpress.org/ticket/30202Report#26601: Inappropriate content in headings on admin screensFri, 13 Dec 2013 11:57:56 GMTWed, 25 Feb 2015 19:29:47 GMT<p>
At the top of the themes.php page there is a second level heading which contains the following:
</p>
<ul><li>The text Themes
</li><li>The number of themes being shown
</li><li>The Add New link
</li><li>The Search installed themes input and label
</li></ul><p>
So on an example page a screen reader voices "Themes7 Add New Search Installed Themes".
</p>
<p>
The use of headings is good for accessibility as it gives screen reader users a way of finding what they are looking for on a page. But in this case there is too much within the heading.
</p>
<p>
Suggested solution: Keep the word Themes within the heading and move the other elements outside the <tt>&lt;h2&gt;...&lt;/h2&gt;</tt>
</p>
grahamarmfieldhttps://core.trac.wordpress.org/ticket/26601
https://core.trac.wordpress.org/ticket/26601Report#31344: Inconsistent terminology on menus panelMon, 16 Feb 2015 14:03:42 GMTFri, 20 Feb 2015 14:32:57 GMT<p>
If you add a link to a menu using the "Links" box, it shows up in the menu contents alongside as "Custom". So when I said to my client "just add a new Custom menu entry" they didn't know what I was talking about. Please can you change "Custom" to "Link", or something which uses the same word(s) in both places. Didn't this used to say "Custom Links"?
</p>
frankieandshadowhttps://core.trac.wordpress.org/ticket/31344
https://core.trac.wordpress.org/ticket/31344Report#30470: Introduce "delete_blog" capabilitySun, 23 Nov 2014 22:36:35 GMTMon, 23 Feb 2015 03:00:19 GMT<p>
Currently, any user with administrator privileges for one blog within a multisite network can delete this specific blog. While the creation of new blogs can be restricted to network admins in the network options, there is no such option for the deletion of blogs.
</p>
<p>
When I dug into the code of <tt>wp-admin/ms-delete-site.php</tt>, I stumbled upon the following comment in line 15:
</p>
<pre class="wiki">// @todo Create a delete blog cap.
if ( ! current_user_can( 'manage_options' ) )
wp_die(__( 'You do not have sufficient permissions to delete this site.'));
</pre><p>
I'd suggest to introduce such a capability. Then it would be possible to control who is able to delete a blog within the multisite network.
</p>
thomaswmhttps://core.trac.wordpress.org/ticket/30470
https://core.trac.wordpress.org/ticket/30470Report#29213: Introduce capability for access to nav-menus.phpThu, 14 Aug 2014 16:22:16 GMTFri, 06 Feb 2015 16:33:07 GMT<p>
Management of the nav menus currently requires <tt>edit_theme_options</tt> capability, a capability associated with administrators which grants the power to make many wide sweeping changes. There should be a discrete capability <tt>edit_nav_menus</tt> just for managing menus, one that is inherited for anyone who has <tt>edit_theme_options</tt> by default. This was done for Customizer access in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28605" title="enhancement: Introduce customize capability for accessing Customizer (closed: fixed)">#28605</a> with the introduction of a <tt>customize</tt> capability.
</p>
<p>
Originally brought up in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/14386" title="enhancement: 3.0 Nav Menus - Edit who has access. (closed: invalid)">#14386</a>.
For introducing a <tt>manage_widgets</tt> capability, see <a class="reviewing ticket" href="https://core.trac.wordpress.org/ticket/31020" title="enhancement: Introduce discrete capability for managing widgets (reviewing)">#31020</a>.
</p>
westonruterhttps://core.trac.wordpress.org/ticket/29213
https://core.trac.wordpress.org/ticket/29213Report#31020: Introduce discrete capability for managing widgetsThu, 15 Jan 2015 07:11:15 GMTWed, 25 Feb 2015 20:40:53 GMT<p>
As with management of nav menus (<a class="reviewing ticket" href="https://core.trac.wordpress.org/ticket/29213" title="enhancement: Introduce capability for access to nav-menus.php (reviewing)">#29213</a>), managing widgets currently requires <tt>edit_theme_options</tt> capability, a capability associated with administrators which grants the power to make many wide sweeping changes. There should be a discrete capability <tt>manage_widgets</tt> just for managing widgets, one that is inherited for anyone who has <tt>edit_theme_options</tt> by default. This was done for Customizer access in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28605" title="enhancement: Introduce customize capability for accessing Customizer (closed: fixed)">#28605</a> with the introduction of a <tt>customize</tt> capability.
</p>
<p>
Originally brought up in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/14386" title="enhancement: 3.0 Nav Menus - Edit who has access. (closed: invalid)">#14386</a>.
The same is proposed for menus in <a class="reviewing ticket" href="https://core.trac.wordpress.org/ticket/29213" title="enhancement: Introduce capability for access to nav-menus.php (reviewing)">#29213</a>.
</p>
westonruterhttps://core.trac.wordpress.org/ticket/31020
https://core.trac.wordpress.org/ticket/31020Report#27034: jQuery methods html('') vs empty()Thu, 06 Feb 2014 08:38:56 GMTWed, 21 Jan 2015 17:22:03 GMT<p>
I found that in a many places in WP uses <tt>.html('')</tt> instead of <tt>.empty()</tt>
</p>
<p>
There is a few advantages to use the second one:
</p>
<ol><li><tt>$.empty()</tt> works faster
</li><li><tt>$.html('')</tt> creates memory leak
</li><li><tt>$.empty()</tt> is more readable
</li></ol><p>
Confirmation of these words you can find on the internet (e.g. stackoverflow).
</p>
<p>
Thanks!
</p>
madeinuahttps://core.trac.wordpress.org/ticket/27034
https://core.trac.wordpress.org/ticket/27034Report#31427: jQuery UI autocomplete style brokenMon, 23 Feb 2015 19:50:28 GMTTue, 24 Feb 2015 15:05:08 GMT<p>
The update to jQuery UI 1.11.2 (<a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29833" title="enhancement: Update to jQuery UI 1.11.2 (closed: fixed)">#29833</a>) broke the style of the autocomplete. The <tt>.ui-state-focus</tt> background change isn't working and the area for each option is smaller than it used to be.
</p>
<p>
This is happening because the &lt;a&gt; tag inside &lt;li&gt; has been removed. It is necessary to update wp-admin/css/forms.css to reflect this change.
</p>
<p>
The attached patch fixes this problem. CSS is not my area of expertise so I might be missing something.
</p>
rodrigosprimohttps://core.trac.wordpress.org/ticket/31427
https://core.trac.wordpress.org/ticket/31427Report#30737: JS templates for Customizer Panels and SectionsWed, 17 Dec 2014 02:18:20 GMTMon, 09 Feb 2015 10:23:52 GMT<p>
Follow up to <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28907" title="defect (bug): media_handle_upload calls wp_read_image_metadata on video files, causing ... (closed: fixed)">#28907</a> and <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29572" title="enhancement: Customizer: add a framework for rendering controls from JS templates (closed: fixed)">#29572</a>. This is necessary for truly dynamic containers, which don't require any ajax and can be added using the new JS API.
</p>
<p>
This is required for Menu Customizer, which is currently working around the issue by supplying its own template for a generic section. I'd like to get this done <strong>early</strong> in 4.2.
</p>
<p>
Working on a patch that's very similar to <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29572" title="enhancement: Customizer: add a framework for rendering controls from JS templates (closed: fixed)">#29572</a>, but for sections and panels. It will be possible to override in subclasses, of course, like the existing render/render content methods.
</p>
<p>
If anyone's wondering why we would ever need dynamically-rendered <em>panels</em>, think things like in-page theme switching, where available options change inline based on the previewed theme.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/30737
https://core.trac.wordpress.org/ticket/30737Report#30966: Let's make word count better (master ticket)Fri, 09 Jan 2015 14:05:00 GMTMon, 02 Feb 2015 12:29:49 GMT<ol><li>Make the code readable (don't use short variable names such as <tt>tx</tt>, <tt>w</tt>, <tt>tc</tt>, <tt>t</tt>, <tt>wc</tt>, <tt>c</tt>, which have no meaning).
</li><li>Make the word count function more abstract so that it can be used elsewhere. So, it should only count the words in a given text, nothing else.
</li><li>Maybe move to <tt>wp-includes</tt>.
</li><li>The word count should update at the right times. At the moment it updates on <tt>enter</tt>, <tt>delete</tt> and <tt>backspace</tt>. It should at least be updated on <tt>space</tt> too. Consider things like cut and paste, and look at TinyMCE events that change the content.
</li><li>Exclude more patterns like known shortcodes and ellipsis (<a class="new ticket" href="https://core.trac.wordpress.org/ticket/27386" title="defect (bug): Editor: Word count should exclude shortcodes (new)">#27386</a>, <a class="new ticket" href="https://core.trac.wordpress.org/ticket/27391" title="defect (bug): Editor: Word count should exclude ellipsis (new)">#27391</a>).
</li><li>Add some good unit tests for all of this.
</li><li>Make sure it's as fast as it can be (e.g. don't needlessly manipulate the DOM).
</li></ol><p>
This could be a small improvement that makes people less annoyed with WordPress. :)
</p>
<p>
More inspiration, although not ideal either:
<a class="ext-link" href="https://github.com/tinymce/tinymce/blob/master/js/tinymce/plugins/wordcount/plugin.js"><span class="icon">​</span>https://github.com/tinymce/tinymce/blob/master/js/tinymce/plugins/wordcount/plugin.js</a>
</p>
<p>
Depends on:
</p>
<p>
</p><div><dl class="wiki compact"><dt><a class="new" href="/ticket/20738" title="Improve Javascript Word Counting for TinyMCE">#20738</a></dt><dd>Improve Javascript Word Counting for TinyMCE</dd><dt><a class="new" href="/ticket/26620" title="Word Count is one number short">#26620</a></dt><dd>Word Count is one number short</dd><dt><a class="new" href="/ticket/27386" title="Editor: Word count should exclude shortcodes">#27386</a></dt><dd>Editor: Word count should exclude shortcodes</dd><dt><a class="new" href="/ticket/27391" title="Editor: Word count should exclude ellipsis">#27391</a></dt><dd>Editor: Word count should exclude ellipsis</dd></dl></div><p>
</p>
iseuldehttps://core.trac.wordpress.org/ticket/30966
https://core.trac.wordpress.org/ticket/30966Report#31365: links in themes.php are not escapedTue, 17 Feb 2015 17:39:47 GMTWed, 18 Feb 2015 20:32:02 GMT<p>
The links are not escaped in themes.php related <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/30952" title="defect (bug): customize.php links in the admin menu are not ecaped (closed: fixed)">#30952</a>
</p>
MikeHansenMehttps://core.trac.wordpress.org/ticket/31365
https://core.trac.wordpress.org/ticket/31365Report#30028: Load Customizer preview iframe with natural URLFri, 17 Oct 2014 20:26:30 GMTSat, 24 Jan 2015 21:48:07 GMT<p>
Currently the Customizer preview is populated by doing an Ajax <tt>POST</tt> request to a the previewed URL and then the Ajax response is written to an <tt>iframe</tt> which has an <tt>about:blank</tt>. This works well to make sure that the change settings get passed along to the Customizer for the refresh, but there are some unintended side effects. For one, the <tt>location.href</tt> of the window in the Customizer preview reflects the location of the parent window, not the location of the URL being previewed. This breaks things like jQuery UI (<a class="new ticket" href="https://core.trac.wordpress.org/ticket/23225" title="defect (bug): Customizer is Incompatible with jQuery UI Tabs. (new)">#23225</a>) when it checks if links are in-page targets. Other aspects of the Customizer preview can be improved if the natural URL is loaded instead of using Ajax, namely the navigation within the preview can be much more robust without needing to implement hacks for catching clicks on link elements to route the URL change up to the Customizer; this will also fix <a class="new ticket" href="https://core.trac.wordpress.org/ticket/20714" title="enhancement: Theme customizer: Impossible to preview a search results page (new)">#20714</a>, allowing forms to be interacted with in the Customizer as expected.
</p>
<p>
To implement this (as discussed on <a href="https://core.trac.wordpress.org/ticket/23225#comment:21">#23225:22</a>) we'll need to introduce a new communications channel to push Customizer settings changes into the preview when a <tt>refresh</tt> transport is invoked. Instead of sending the settings with <tt>POST</tt> request to load the page, we'll need to send settings changes into a transient which the Customizer preview can read from when loading a page via a regular <tt>GET</tt> request. A side effect of this may be that we need to disallow a user from opening the Customizer in multiple windows, since the Customizer preview won't know which Customizer pane it is associated with.
</p>
<p>
Another gotcha here, perhaps another reason why <tt>document.write()</tt> was chosen for populating a blank iframe, is maintaining the scroll position when a refresh happens. Doing a <tt>location.reload()</tt> in the preview window may not have a seamless preservation of the scroll position. We may need to make sure the Customizer preview gets sent back with output buffering so that the entire document is sent all at once so that incremental rendering does not interfere with the prior scroll position.
</p>
<p>
Fixes <a class="new ticket" href="https://core.trac.wordpress.org/ticket/23225" title="defect (bug): Customizer is Incompatible with jQuery UI Tabs. (new)">#23225</a>
</p>
westonruterhttps://core.trac.wordpress.org/ticket/30028
https://core.trac.wordpress.org/ticket/30028Report#31196: Loading indicators for the Customizer previewSun, 01 Feb 2015 07:08:09 GMTSun, 22 Feb 2015 06:41:25 GMT<p>
Blank screen when the Customizer is first loaded looks broken, and nothing happening visually when following a link in the preview or when a change requires the refresh transport that takes a while looks odd. Let's make more liberal use of loading indicators and/or semi-transparent overlays.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/31196
https://core.trac.wordpress.org/ticket/31196Report#6820: Make it possible to manually detach/attach post imagesWed, 23 Apr 2008 01:24:09 GMTSun, 22 Feb 2015 03:06:36 GMT<p>
You should be able to change the parent of an attachment to attach it to a different post.
</p>
matthttps://core.trac.wordpress.org/ticket/6820
https://core.trac.wordpress.org/ticket/6820Report#31147: make sure $notoptions is an array before assigning array key valueTue, 27 Jan 2015 22:23:16 GMTFri, 30 Jan 2015 13:39:38 GMT<p>
In a multi sites worpress setup environment, there are times where get_options would cause illegal string offset warnings.
</p>
<p>
The issue is caused by $notoptions that can contain a string from get_get_cache call.
To avoid the potential warning errors, we should check to make sure $notoptions variable is an array before trying to assign array indexed value to it.
</p>
<p>
For reference: <a class="ext-link" href="https://github.com/Automattic/vip-quickstart/issues/216"><span class="icon">​</span>https://github.com/Automattic/vip-quickstart/issues/216</a>
</p>
hauvonghttps://core.trac.wordpress.org/ticket/31147
https://core.trac.wordpress.org/ticket/31147Report#31041: Make wpautop documentation more verboseSat, 17 Jan 2015 00:10:27 GMTSun, 15 Feb 2015 19:10:23 GMT<p>
To help myself understand what's going on in wpautop, I added some more verbose documentation. Others for whom regex is a second language may also benefit.
</p>
ericlewishttps://core.trac.wordpress.org/ticket/31041
https://core.trac.wordpress.org/ticket/31041Report#31464: MCE Views - Don't restrict importing of styles to AV views.Thu, 26 Feb 2015 14:30:52 GMTMon, 02 Mar 2015 17:32:49 GMT<p>
FIrstly - some great improvements to the MCE view code recently - see <a class="new ticket" href="https://core.trac.wordpress.org/ticket/31412" title="enhancement: TinyMCE views improvements (new)">#31412</a>.
</p>
<p>
I would like to register a custom view which is sometimes sandboxed in an iFrame. I would also like to have the styles imported from the editor.
</p>
<p>
However this is hardcoded to only do this for video, audio and playlists.
</p>
<p>
<tt>importStyles = this.type === 'video' || this.type === 'audio' || this.type === 'playlist';</tt>
</p>
<p>
I think this should be a property on the view object - set to false by default but true for the AV views. This would allow me to easily enable it for my views.
</p>
<p>
Patch incomming.
</p>
mattheuhttps://core.trac.wordpress.org/ticket/31464
https://core.trac.wordpress.org/ticket/31464Report#29993: Media action links are cramped on small screensThu, 16 Oct 2014 04:50:00 GMTMon, 02 Mar 2015 17:20:12 GMT<p>
In the Media Library list view, the action links are quite cramped on small screens.
</p>
pentohttps://core.trac.wordpress.org/ticket/29993
https://core.trac.wordpress.org/ticket/29993Report#30333: Media filtering behavior should be the same in list and grid mode displaysThu, 13 Nov 2014 15:34:24 GMTFri, 27 Feb 2015 23:22:29 GMT<p>
When the Media Library is displayed using the grid layout, selecting an entry in the filtering drop-down menu applies it right away. For example, selecting "Unattached" hides all medias that are attached to a post.
</p>
<p>
On the other side, when the list layout is used, selecting an entry in the filtering drop-down menu does nothing until I click on the "Filter" button. That makes me think the functionality was broken for about 10 minutes before I realize my mistake.
Moreover, the "Filter" button is replacing the "Bulk Select" button when list view is activated, so I did not noticed its presence.
</p>
<p>
I think there is a need to make this more homogeneous : triggering the form submission upon dropdown menu selection in javascript would be easy.
</p>
<p>
This is linked to <a class="new ticket" href="https://core.trac.wordpress.org/ticket/29744" title="defect (bug): Media Library: type dropdown in grid mode different form list mode + no ... (new)">#29744</a>
</p>
Fab1enhttps://core.trac.wordpress.org/ticket/30333
https://core.trac.wordpress.org/ticket/30333Report#30943: Media Library: Duplicate files are confusingly labeled the same on List modeWed, 07 Jan 2015 20:05:25 GMTFri, 27 Feb 2015 21:03:09 GMT<p>
On Grid mode, elements in your Media Library are labeled by their filename.
On List mode, elements are labeled by their title.
</p>
<p>
This is confusing if you have uploaded duplicate files.
</p>
<p>
Possible solutions could be:
</p>
<ul><li>Add the filename beneath the title the List view.
</li><li>Always use the filename on both modes.
</li><li>Append numbers to the end of the title, like it's done with the filename.
</li></ul><p>
See attached screenshots.
</p>
diegoehttps://core.trac.wordpress.org/ticket/30943
https://core.trac.wordpress.org/ticket/30943Report#30599: media views: improve keyboard accessibility avoiding confusing tab stopsThu, 04 Dec 2014 22:25:39 GMTSun, 01 Feb 2015 15:38:32 GMT<p>
When hiding parts of the UI it's very important to take into consideration side-effects on keyboard accessibility. For example, when media-menu is hidden, e.g. when editing images, it's just positioned out of view but links in the menu are still there and they are focusable. See screenshot.
</p>
<p>
When tabbing, keyboard users get a variable number of confusing tab stops that shouldn't be there.
</p>
<p>
Actually, it's also possible to activate one of the links in the menu (just tab into one of them and press Enter) and break the editing workflow.
Unless I'm missing something, the media menu should be hidden with <tt>display: none</tt> I'm guessing the out of view positioning is there just for historical reasons.
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/tfDzl1O6r0.png"><img src="https://cldup.com/tfDzl1O6r0.png" alt="https://cldup.com/tfDzl1O6r0.png" title="https://cldup.com/tfDzl1O6r0.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/30599
https://core.trac.wordpress.org/ticket/30599Report#24146: Menu items with blank labels are removed on savingSat, 20 Apr 2013 22:10:09 GMTFri, 13 Feb 2015 16:48:25 GMT<p>
Hello,
</p>
<p>
When edit an item of menu leaving the label in blank, the item is auto deleted.
There are two problems in that:
</p>
<ol><li> I could need an item with blank title to add some class with an background image
</li><li> When this item has subitems with two or more depth, all subitems are moved to first depth loosing submenus hierarchy. Moreover if i try to drag the subitems to make the hierarchy again, after save, all subitems come back to first depth. While i not change the depth of first item this issue occurs again.
</li></ol><p>
Best regards
</p>
rodrigo@…https://core.trac.wordpress.org/ticket/24146
https://core.trac.wordpress.org/ticket/24146Report#18132: Misleading message when deleting a user with no sitesFri, 15 Jul 2011 17:53:14 GMTWed, 25 Feb 2015 21:55:12 GMT<p>
In multisite, when deleting a user with no sites, the following message appears:
</p>
<blockquote>
<p>
Transfer or delete posts and links before deleting users.
</p>
</blockquote>
<p>
This is a confusing message because there are no posts or links to transfer/delete. The message should be changed to something else.
</p>
danielbachhuberhttps://core.trac.wordpress.org/ticket/18132
https://core.trac.wordpress.org/ticket/18132Report#30556: Modern widgets default wrapperSun, 30 Nov 2014 19:14:31 GMTWed, 25 Feb 2015 22:50:49 GMT<p>
Since 2.2.0, widgets are wrapped in <tt>&lt;li&gt;&lt;/li&gt;</tt> by default.
In my opinion, they should be wrapped in <tt>&lt;div&gt;&lt;/div&gt;</tt> even if, during the sidebar registration, theme developers should declare how to wrap the widgets in the sidebar.
</p>
<p>
Twentyten theme is the only default theme using this structure and it's declared in functions.php.
</p>
<p>
The patch contains this change.
</p>
LeoPeohttps://core.trac.wordpress.org/ticket/30556
https://core.trac.wordpress.org/ticket/30556Report#11226: Month name declension caseSun, 22 Nov 2009 13:13:43 GMTThu, 08 Jan 2015 17:13:54 GMT<p>
As I've reported previously, in order to fully translate WordPress into Polish (and probably many more languages), dates have to be declended. This was fixed in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/9396" title="enhancement: Month name declension (closed: fixed)">#9396</a>, however proper translation into Polish still cannot be accomplished.
</p>
<p>
You see, the "January 2009" is something else for
</p>
<pre class="wiki">"View posts published in January 2009"
</pre><p>
and just
</p>
<pre class="wiki">"January 2009"
</pre><p>
In the former case, it's a locative. In the latter, it's simply a genitive. What needs to be done in order to fix this is passing some kind of information to the date_i18n filter, informing it of the case.
</p>
<p>
I suggest passing the declension case information (whether it's genitive, locative or something else). That should do it. :)
</p>
waclawjacekhttps://core.trac.wordpress.org/ticket/11226
https://core.trac.wordpress.org/ticket/11226Report#30002: ms_not_installed returns 200Thu, 16 Oct 2014 10:37:16 GMTMon, 23 Feb 2015 00:39:34 GMT<p>
The ms_not_installed function returns apache state 200. It should return 500. Also there should been an action / filter to modify behaviour within this code.
</p>
spacedmonkeyhttps://core.trac.wordpress.org/ticket/30002
https://core.trac.wordpress.org/ticket/30002Report#22302: Multisite administration - default date formatMon, 29 Oct 2012 15:11:58 GMTMon, 23 Feb 2015 02:56:41 GMT<p>
1) There is default non-translatable format for dates in multisite administration:
</p>
<p>
Sites - All sites (columns Last Updated and Registered)
</p>
<p>
Users - All users (column Registered)
</p>
<p>
Please see attached patch, I used existing localization format.
</p>
<p>
2) Sites - All sites - Edit any site. There are also Registered and Last Updated values in default date format, but I am not sure how to solve this issue...
</p>
pavelevaphttps://core.trac.wordpress.org/ticket/22302
https://core.trac.wordpress.org/ticket/22302Report#31076: Multisite signup functions don't support SSLTue, 20 Jan 2015 16:21:57 GMTSun, 15 Feb 2015 22:44:24 GMT<p>
<a class="source" href="https://core.trac.wordpress.org/browser/tags/4.1/src/wp-signup.php#L612">confirm_blog_signup()</a><a class="trac-rawlink" href="https://core.trac.wordpress.org/export/HEAD/tags/4.1/src/wp-signup.php#L612" title="Download">​</a>, <a class="source" href="https://core.trac.wordpress.org/browser/tags/4.1/src/wp-signup.php#L361">confirm_another_blog_signup()</a><a class="trac-rawlink" href="https://core.trac.wordpress.org/export/HEAD/tags/4.1/src/wp-signup.php#L361" title="Download">​</a>, and <a class="source" href="https://core.trac.wordpress.org/browser/tags/4.1/src/wp-includes/ms-functions.php#L768">wpmu_signup_blog_notification()</a><a class="trac-rawlink" href="https://core.trac.wordpress.org/export/HEAD/tags/4.1/src/wp-includes/ms-functions.php#L768" title="Download">​</a> use hardcoded <tt>http://</tt> links.
</p>
SergeyBiryukovhttps://core.trac.wordpress.org/ticket/31076
https://core.trac.wordpress.org/ticket/31076Report#17376: Multisite Subfolders and bunk /wp-admin areasWed, 11 May 2011 15:07:38 GMTMon, 02 Mar 2015 18:31:51 GMT<p>
On a multisite installation with subfolders, navigating to:
</p>
<p>
www.mysite.com/i-dont-exist/wp-admin
</p>
<p>
loads a dashboard and maintains the i-dont-exist in the url. That part exists if i navigate to themes and/or plugin pages. However, I'm actually altering the base site.
This can be quite confusing if someone makes a typo in a sitename and they end up changing the base site (like happened to us) :(
</p>
MadtownLemshttps://core.trac.wordpress.org/ticket/17376
https://core.trac.wordpress.org/ticket/17376Report#15459: Need Better Page Hierarchy Display AlgorithmThu, 18 Nov 2010 00:33:16 GMTTue, 24 Feb 2015 20:07:27 GMT<p>
WordPress 3.0.1
</p>
<p>
File: /wp-admin/includes/post.php
</p>
<p>
Lines: 904-912
</p>
<p>
Code:
</p>
<pre class="wiki"> // Hierarchical types require special args.
if ( is_post_type_hierarchical( $post_type ) ) {
$query['orderby'] = 'menu_order title';
$query['order'] = 'asc';
$query['posts_per_page'] = -1;
$query['posts_per_archive_page'] = -1;
}
wp( $query );
</pre><p>
The code in the area mentioned above causes our site to use over 170mb of memory on each load of the Pages index. This really should be improved to accommodate sites that have large amounts of hierarchical data. Looks to me like it's pulling all the data for all the pages on the site. Perhaps a solution where unnecessary data is not included might be better here (such as content or excerpt).
</p>
truthmediahttps://core.trac.wordpress.org/ticket/15459
https://core.trac.wordpress.org/ticket/15459Report#29316: Need more filters for WP_Customize_SettingsFri, 22 Aug 2014 11:57:04 GMTFri, 23 Jan 2015 17:50:52 GMT<p>
There should have more filters to handle settings.
</p>
<p>
for example:
add
</p>
<pre class="wiki">apply_filters( 'customize_value', $this-&gt;defaults, $this);
</pre><p>
or
</p>
<pre class="wiki">apply_filters( 'customize_value_'.$this-&gt;type, $this-&gt;default, $this);
</pre><p>
before
</p>
<pre class="wiki">apply_filters( 'customize_value_' . $this-&gt;id_data[ 'base' ], $this-&gt;default );
</pre><p>
add
</p>
<pre class="wiki">do_action( 'customize_preview_setting', $this );
</pre><p>
before
</p>
<pre class="wiki">do_action( 'customize_preview_' . $this-&gt;id, $this );
</pre>dedepresshttps://core.trac.wordpress.org/ticket/29316
https://core.trac.wordpress.org/ticket/29316Report#13867: New filter for comment RSS feed's titleSat, 12 Jun 2010 21:53:07 GMTSun, 22 Feb 2015 11:33:23 GMT<p>
I'd like to be able to customize comments titles in RSS feed.
</p>
<p>
Currently it's hardcoded and has no way to be changed, so I added 2 new filters so that plugins can edit them.
</p>
<p>
I've tested and patch is working for me.
</p>
shidouhikarihttps://core.trac.wordpress.org/ticket/13867
https://core.trac.wordpress.org/ticket/13867Report#31500: New post type undefined delete post valueMon, 02 Mar 2015 09:14:55 GMTMon, 02 Mar 2015 14:06:25 GMT<p>
I have WP_DEBUG = TRUE on my localhost.
</p>
<p>
I registered new post type for my plugin. And then went to WP ADMIN -&gt; MENU -&gt; CARS. And in the list of 'cars' (no items added) I see this warning:
Notice: Undefined property: stdClass::$delete_posts in C:\Program Files (x86)\Zend\Apache2\htdocs\GitHub\*WEBSITE-NAME*\wp-admin\includes\class-wp-posts-list-table.php on line 209
</p>
ozzWANTEDhttps://core.trac.wordpress.org/ticket/31500
https://core.trac.wordpress.org/ticket/31500Report#31068: oEmbed Podbean player support podbean.com embed player URLsTue, 20 Jan 2015 08:33:54 GMTWed, 21 Jan 2015 08:11:15 GMT<p>
Attached patch provides the support for Podbean embed player in oEmbed endpoint URLs like [embed]<a class="ext-link" href="http://www.podbean.com/media/player/54bvw-531545/initByJs/1/auto/1?skin=10[/embed"><span class="icon">​</span>http://www.podbean.com/media/player/54bvw-531545/initByJs/1/auto/1?skin=10[/embed</a>] It would be nice if the core regex also handled Podbean oEmbed URLS
</p>
podbeanhttps://core.trac.wordpress.org/ticket/31068
https://core.trac.wordpress.org/ticket/31068Report#31214: oEmbed: Newlines within <pre> tags get removedMon, 02 Feb 2015 20:22:26 GMTWed, 11 Feb 2015 22:17:28 GMT<p>
An oEmbed's HTML content gets all <tt>\n</tt> newlines removed through
</p>
<blockquote>
<p>
add_filter( 'oembed_dataparse', array($this, '_strip_newlines'), 10, 3 );
</p>
</blockquote>
<p>
<tt>WP_oEmbed::strip_newlines()</tt> unfortunately removes every newline, even those within <tt>&lt;pre&gt;</tt> tags - but they are crucial there. My oEmbedded code pastes all only have a single line currently: <a class="ext-link" href="http://fotostore.cweiske.de/screenshots/2015-02-02%20wordpress%20oembed%20newlines.png"><span class="icon">​</span>http://fotostore.cweiske.de/screenshots/2015-02-02%20wordpress%20oembed%20newlines.png</a>
</p>
<p>
Please fix this method to not remove newlines within <tt>&lt;pre&gt;</tt> tags.
</p>
cweiskehttps://core.trac.wordpress.org/ticket/31214
https://core.trac.wordpress.org/ticket/31214Report#26646: On Appearance themes page ".themes" div is not covering floated elements.Mon, 16 Dec 2013 14:00:37 GMTMon, 19 Jan 2015 06:28:49 GMT<p>
On theme page, all theme's thumbnail wrapper div are floated left but the parent div (div.themes) do not cover any floated element;
Moreover div.themes is also having 100px bottom padding which is not taking any effect on the page.<br />
In <strong>/wp-admin/themes.php</strong> have a clearing element <tt> &lt;br class="clear" /&gt; </tt> inside the div.themes but when rendering is done by tmpl-theme template, the clearing element <tt> &lt;br class="clear" /&gt; </tt> is being inserted outside of the div.themes.<br />
<br />
Also the "add-new-theme" element is being add as last child element of div.themes but last element should be <tt> &lt;br class="clear" /&gt; </tt>
to clear every element, if not then div.add-new-theme will start from new line even though there is room available next to div.theme element.
</p>
5um17https://core.trac.wordpress.org/ticket/26646
https://core.trac.wordpress.org/ticket/26646Report#31144: Options general screen, accessibility improvementsTue, 27 Jan 2015 16:55:54 GMTMon, 23 Feb 2015 14:15:08 GMT<p>
Splitting this out from <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29955" title="defect (bug): Section 508 issues found on WordPress 4.0 admin page. (closed: invalid)">#29955</a> see points 2. and 3.
</p>
<p>
Basically, the date format and time format radio button labels don't get read out by JAWS. It reads out just "radio button checked". Should read the label text with the date/time example formats.
</p>
<p>
After some testing with IE 8 and JAWS 15, turned out <strong>when in "form mode"</strong>, JAWS doesn't read out the implicit label because there's a <tt>&lt;span&gt;</tt> wrapping the label text. So with this HTML:
</p>
<pre class="wiki">&lt;label&gt;&lt;input type="radio" name="test"&gt; &lt;span&gt;implicit label&lt;span&gt;&lt;/label&gt;
</pre><p>
the label text is just ignored. I guess it make sense: when there's an implicit label, IE 8 and JAWS 15 expect to find a text node and instead they find a <tt>&lt;span&gt;</tt>. <strong>Oddly, looks like this happens just for radio buttons.</strong>
Simple test case: <a class="ext-link" href="http://codepen.io/afercia/full/BydyKx/"><span class="icon">​</span>http://codepen.io/afercia/full/BydyKx/</a>
</p>
<p>
So, lesson learned: <strong>never use a span or other elements to wrap a radio button implicit label text</strong>.
</p>
<p>
In the proposed patch some more issues addressed:
</p>
<ul><li>removed spans wrapping implicit radio buttons label: they make JAWS ignore the label text
</li><li>updated the JavaScript part related to the ".example" text
</li><li>added 2 missing labels for custom formats text fields
</li><li>added "aria-describedby" for elements with a description paragraph
</li><li>added some screen-reader-text
</li><li>small CSS fixes including spinner position
</li></ul><p>
Outstanding accessibility issues:
</p>
<ul><li>moving the focus on the custom format fields makes screen readers skip important information
</li><li>try a better association between the "example" date and time (the ones changed by JavaScript on radio buttons click) and the input fields
</li><li>the link: "to be different from the directory" it's confusing when read out of context, I would propose to change the wording of that sentence and use something like "Learn how to give WordPress its own directory".
</li></ul><p>
Accessibility team testing and any thoughts welcome :)
</p>
aferciahttps://core.trac.wordpress.org/ticket/31144
https://core.trac.wordpress.org/ticket/31144Report#20943: Paragraphs get removed in table cells when Visual editor is refreshedWed, 13 Jun 2012 19:06:04 GMTWed, 04 Feb 2015 18:47:42 GMT<p>
As far as I know, this issue has been around since 3.1. It's not a bug in 3.0.4. I even stopped upgrading at 3.0.4 for any sites where I knew the client would need to edit tabular data. For security reasons, it's time to upgrade these and I'd REALLY like this issue to be fixed.
</p>
<p>
The problem happens when using paragraphs in a table cell. When I hit enter to create a new paragraph within a table cell, it looks fine. If I then hit Update/Publish, when the page refreshes, WordPress converts that paragraph break into a single line break. If I then click Update again, WordPress removes that linebreak entirely and the paragraphs are essentially merged.
</p>
<p>
I can also reproduce this behaviour without even clicking Update. If you just switch to HTML mode and then back to Visual mode, the same issue occurs.
</p>
JboyJWhttps://core.trac.wordpress.org/ticket/20943
https://core.trac.wordpress.org/ticket/20943Report#25666: Pass perpetrating $handle to enqueue_script's _doing_it_wrong() callTue, 22 Oct 2013 21:15:03 GMTSat, 03 Jan 2015 05:59:36 GMT<p>
So the debug message for enqueueing resources at the proper time is helpful, but finding out which one of a site's plugins or theme can be a tedious task. I suggest we pass the $handle that triggered the warning to the output, so we know exactly where to look (since it references back to wp-includes/functions.php).
</p>
bigdawggihttps://core.trac.wordpress.org/ticket/25666
https://core.trac.wordpress.org/ticket/25666Report#5305: permalinks broken when article name is numericThu, 01 Nov 2007 21:27:54 GMTFri, 27 Feb 2015 15:49:40 GMT<p>
if you create numeric-only post name, the generated slug is this number - this conflicts with article ID, so it returns different article or 404 page, never the article. It can be then solved by generating manual slug with some char in it, but i think it would be better to include some char in that case, e.g. underscore, like _123
</p>
<p>
Also if someone will try to solve this, it would be nice to solve other problem - if post slug is begining with the slug of the category, than the category page returns that post, not the category
</p>
thomaskhttps://core.trac.wordpress.org/ticket/5305
https://core.trac.wordpress.org/ticket/5305Report#31422: Permission errors should not return 500 server error.Mon, 23 Feb 2015 14:21:47 GMTMon, 23 Feb 2015 14:30:22 GMT<p>
In network-installs, permission denied errors send an 500 server error.
Should be 403.
</p>
<p>
This status code can be confusing when load balancers captures server errors to hide from users but nothing gets logged in error logs.
</p>
yo-l1982https://core.trac.wordpress.org/ticket/31422
https://core.trac.wordpress.org/ticket/31422Report#31104: Plugin activation includes plugin file in variable scope of activate_pluginFri, 23 Jan 2015 06:57:16 GMTFri, 23 Jan 2015 23:23:24 GMT<p>
When a plugin is activated, it is included in <tt>activate_plugin</tt>, with access to the variable scope of <tt>activate_plugin</tt>. This caused a problem with <tt>$plugin</tt> in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28102" title="defect (bug): is_string check in validate_file (closed: fixed)">#28102</a>, and was fixed in <a class="changeset" href="https://core.trac.wordpress.org/changeset/28644" title="Avoid stomping of the $plugin variable in activate_plugin().
fixes ...">[28644]</a>, but the other variables that are used in the function (<tt>$current</tt>, <tt>$silent</tt> and <tt>$network_wide</tt>) can still potentially cause problems.
</p>
<p>
Overriding <tt>$current</tt> and <tt>$network_wide</tt>, a plugin could potentially deactivate all active plugins on activation or activate itself network wide when activated per-site (or vice-versa).
</p>
<p>
It's not hard to imagine plugins using those var names in the main plugin file. To illustrate, here is an example of a broken plugin file:
</p>
<pre class="wiki">&lt;?php
/*
Plugin Name: Broken Plugin
Plugin URI: http://example.com
Description: This plugin breaks things when it is activated
Version: 0.1
Author: Your Name
Author URI: http://example.com
*/
// Is this a network install?
$network_wide = is_multisite(); // EFFECT: Will turn a per-site activation into a multisite activation
$defaults = array( "my-option" =&gt; 1 );
foreach( $defaults as $option =&gt; $current ) {
if ( !get_option( $option ) ) {
add_option( $option, $current );
}
} // EFFECT: $current is now '1'. This deactivates ALL active plugins.
</pre><p>
Though the occurrence will be rare, these side-effect can be hard to debug for a plugin developer. Instead of saving the variable in a shadow var like in <a class="changeset" href="https://core.trac.wordpress.org/changeset/28644" title="Avoid stomping of the $plugin variable in activate_plugin().
fixes ...">[28644]</a>, it can be easily and definitively fixed by calling the include from a separate function, so the variable scope of activate_plugin is simply out of reach. I have attached a patch. With the patch, the broken plugin above loses all side-effects.
</p>
Mike_Cowobohttps://core.trac.wordpress.org/ticket/31104
https://core.trac.wordpress.org/ticket/31104Report#31415: Plugin and theme editor focus trapSun, 22 Feb 2015 17:25:14 GMTMon, 02 Mar 2015 20:14:01 GMT<p>
Reported by Michelle DeYoung during last accessibility testers group testing session:
</p>
<p>
"I'm not sure what is causing the tab order to stop at the textarea element and not allow the user to tab to the next form element in IE and Chrome. I tried using 'ESC' then 'Tab' to see if that would allow me to exit the textarea, but that only worked in FF."
</p>
<p>
Reproduced in Chrome and IE 8:
</p>
<ul><li>go in plugin-editor.php
</li><li>click or tab inside the textarea
</li><li>type something
</li><li>click or tab outside the textarea (press Escape and then Tab)
</li><li>everything works OK
</li></ul><p>
Refresh and repeat the previous steps and once inside the textarea:
</p>
<ul><li>insert a tab character (press Tab)
</li><li>click or tab outside the textarea (press Escape and then Tab)
</li><li>the textarea is permanently focused
</li></ul><p>
Keyboard users will be trapped, there's no way to move outside of the textarea using only the keyboard.
</p>
<p>
In the attached patch, I'd propose to simple remove the "lastkey" related stuff, I guess it was meant for Opera 12 and maybe no more necessary unless I'm missing something. Added also a little fix for Opera 27.
</p>
aferciahttps://core.trac.wordpress.org/ticket/31415
https://core.trac.wordpress.org/ticket/31415Report#30773: Plugin information modal: banner repeats when scrollableFri, 19 Dec 2014 01:26:16 GMTSun, 01 Feb 2015 05:04:20 GMT<p>
For scrollable modals, the bottom of the header banner has 6 pixels repeating vertically.
</p>
<p>
When the plugin information modal has a scrollbar, the (inner) width of the modal decreases a bit. The title banner, sized 772x250, will then be resized (for example to 755x244 on Chrome on Windows). Result is that the banner is not high enough to fill the header area which has a fixed height, and will repeat at the bottom (see attached).
</p>
<p>
Suggested patch gives the banner <strong>background:cover</strong> so that the image will be evenly placed/sized in the header.
</p>
senffhttps://core.trac.wordpress.org/ticket/30773
https://core.trac.wordpress.org/ticket/30773Report#29539: Plugin viewer not displaying video tutorials.Fri, 05 Sep 2014 16:19:32 GMTMon, 02 Mar 2015 18:07:41 GMT<p>
In the WordPress 4.0 plugin page viewer, my video tutorials for my plugins are not displaying.
</p>
<p>
<a style="padding:0; border:none" href="http://www.redeemerdanceacademy.ca/wp-content/uploads/2014/09/Ticket.png"><img src="http://www.redeemerdanceacademy.ca/wp-content/uploads/2014/09/Ticket.png" alt="http://www.redeemerdanceacademy.ca/wp-content/uploads/2014/09/Ticket.png" title="http://www.redeemerdanceacademy.ca/wp-content/uploads/2014/09/Ticket.png" /></a>
</p>
kidsguidehttps://core.trac.wordpress.org/ticket/29539
https://core.trac.wordpress.org/ticket/29539Report#30991: Post type object capability 'delete_posts' is referenced in the posts list table but does not exist unless 'map_meta_cap' is set to true for post typeMon, 12 Jan 2015 15:31:48 GMTTue, 10 Feb 2015 05:43:03 GMT<p>
I'm getting the following error when viewing the main edit screen of a custom post type:
</p>
<p>
Undefined property: stdClass::$delete_posts at wp-admin/includes/class-wp-posts-list-table.php:209
</p>
<p>
When I looked up the line, the following code is run:
</p>
<pre class="wiki">if ( current_user_can( $post_type_obj-&gt;cap-&gt;delete_posts ) ) {
</pre><p>
The problem is that the capability, 'delete_posts', is only applied to a post type (via get_post_type_capabilities()) if the 'map_meta_cap' argument is set to true when you're registering the post type (via register_post_type()).
</p>
bamadesignerhttps://core.trac.wordpress.org/ticket/30991
https://core.trac.wordpress.org/ticket/30991Report#31458: Press This: Add Preview functionalityThu, 26 Feb 2015 01:54:54 GMTThu, 26 Feb 2015 08:57:08 GMT<p>
This was brought up earlier today and I think could make a good addition to the Action bar at the bottom.
</p>
<p>
Super quick mockup:
<a style="padding:0; border:none" href="https://cldup.com/Lkoi8KoWtC.png"><img src="https://cldup.com/Lkoi8KoWtC.png" alt="https://cldup.com/Lkoi8KoWtC.png" title="https://cldup.com/Lkoi8KoWtC.png" /></a>
</p>
<p>
We need to discuss what happens when clicked. I think there are two options. One is more pleasant (and probably trickier) than the other.
</p>
<ol class="upperalpha"><li>The preview opens in a new window. This is pretty standard behavior, but is super rough when you have multiple tabs open or are on mobile.
</li></ol><ol class="upperalpha" start="2"><li>The preview opens in a full screen iframe modal. The modal would have a "Close" or "Hide preview" button over it on the top right. This would enable quick edits and toggling of visibility without ever leaving the Press This window. Quick (ultra rough) mockup:
</li></ol><p>
<a style="padding:0; border:none" href="https://cldup.com/pS_JrR8OFv.png"><img src="https://cldup.com/pS_JrR8OFv.png" alt="https://cldup.com/pS_JrR8OFv.png" title="https://cldup.com/pS_JrR8OFv.png" /></a>
</p>
<p>
Thoughts?
</p>
Michael Arestadhttps://core.trac.wordpress.org/ticket/31458
https://core.trac.wordpress.org/ticket/31458Report#31457: Press This: Close sidebar when cursor clicks out of sidebar or tab focus leaves sidebarThu, 26 Feb 2015 01:43:13 GMTTue, 03 Mar 2015 17:04:50 GMT<p>
The sidebar should probably close when clicking out of it or when it no longer has focus. (note, the sidebar visibility is only toggle-able on smaller viewports)
</p>
Michael Arestadhttps://core.trac.wordpress.org/ticket/31457
https://core.trac.wordpress.org/ticket/31457Report#31472: Press This: Header improvementsFri, 27 Feb 2015 05:38:31 GMTMon, 02 Mar 2015 17:23:37 GMT<p>
In the revamped Press This header, the styling is meant to mimc the styling of the Toolbar. In <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/31234" title="task (blessed): Update wp-admin default colors (closed: fixed)">#31234</a>, the default color scheme was updated, so we should update it in Press This as well.
</p>
<p>
We should also link the site name in the header with the the admin index URL. This would be helpful for when you're leveraging Press This via the direct link and want a quick way to get back to your dashboard.
</p>
DrewAPicturehttps://core.trac.wordpress.org/ticket/31472
https://core.trac.wordpress.org/ticket/31472Report#31462: Press This: Match styling on tools.phpThu, 26 Feb 2015 03:55:31 GMTFri, 27 Feb 2015 19:45:42 GMT<p>
The Press This area of /wp-admin/tools.php doesn't match the styling of the Category converter text or generally other pages in /wp-admin/
</p>
<p>
Notice <a class="ext-link" href="https://cloudup.com/clOJ-s28VZa"><span class="icon">​</span>https://cloudup.com/clOJ-s28VZa</a> vs <a class="ext-link" href="https://cloudup.com/cyFFhCZIIwv"><span class="icon">​</span>https://cloudup.com/cyFFhCZIIwv</a>
(granted there is Jetpack material, but shows the styling used up to now on that page).
</p>
<p>
Time to overhaul tools.php visually or change up PT to match?
</p>
<p>
Main ticket: <a class="assigned ticket" href="https://core.trac.wordpress.org/ticket/31373" title="task (blessed): Revamp Press This (assigned)">#31373</a>
</p>
kraftbjhttps://core.trac.wordpress.org/ticket/31462
https://core.trac.wordpress.org/ticket/31462Report#31443: Press This: Mega checkboxes in IE and FirefoxTue, 24 Feb 2015 23:39:12 GMTWed, 25 Feb 2015 07:55:55 GMT<p>
<a style="padding:0; border:none" href="https://cldup.com/ywdsAkspps.png"><img src="https://cldup.com/ywdsAkspps.png" alt="https://cldup.com/ywdsAkspps.png" title="https://cldup.com/ywdsAkspps.png" /></a>
</p>
<p>
This is due to an attempt at focus styles on the categories list. The best thing to do would be to change the categories list markup to <tt>li</tt> elements.
</p>
<p>
Pros:
</p>
<ul><li>full style control
</li><li>A11y win (list tells how many items are in it)
</li><li>removal of super hacky CSS targeting browsers
</li></ul><p>
Working example: <a class="ext-link" href="http://test.cita.uiuc.edu/aria/checkbox/checkbox1.php"><span class="icon">​</span>http://test.cita.uiuc.edu/aria/checkbox/checkbox1.php</a>
</p>
Michael Arestadhttps://core.trac.wordpress.org/ticket/31443
https://core.trac.wordpress.org/ticket/31443Report#31444: Press This: The scan button is a bit big on IEWed, 25 Feb 2015 00:00:46 GMTSat, 28 Feb 2015 15:49:31 GMT<p>
<a style="padding:0; border:none" href="https://cldup.com/g49o9Gq91P.png"><img src="https://cldup.com/g49o9Gq91P.png" alt="https://cldup.com/g49o9Gq91P.png" title="https://cldup.com/g49o9Gq91P.png" /></a>
</p>
<p>
Shouldn't be too tricky to fix.
</p>
Michael Arestadhttps://core.trac.wordpress.org/ticket/31444
https://core.trac.wordpress.org/ticket/31444Report#30501: Prevent flushing rewrites during page loadTue, 25 Nov 2014 22:15:16 GMTWed, 14 Jan 2015 07:22:26 GMT<p>
Flushing rewrites during the pageload breaks a lot of plugins. They might not have registered their rewrite yet which would cause issues. I propose preventing the flushing from working and forcing it to be run on shutdown instead.
</p>
joostdevalkhttps://core.trac.wordpress.org/ticket/30501
https://core.trac.wordpress.org/ticket/30501Report#13651: Problem with plural form in comments_numberMon, 31 May 2010 07:55:14 GMTTue, 10 Feb 2015 08:39:58 GMT<p>
Hi, there is problem with comments_number in WordPress (and also Twentyten theme). There is possibility to use 0, 1 or more comments. But for Czech there are also two plural forms: 0 (žádný komentář), 1 (1 komentář), 2-4 (komentáře) and 5 and more (komentářů).
</p>
<p>
Function comments_number does not support it, also in Twentyten it is not possible...
</p>
pavelevaphttps://core.trac.wordpress.org/ticket/13651
https://core.trac.wordpress.org/ticket/13651Report#25060: Quick Edit Comments inline edit save breaks the alternating table row backgroundsFri, 16 Aug 2013 23:09:09 GMTWed, 14 Jan 2015 22:13:04 GMT<p>
Related: <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/24951" title="defect (bug): Quick edit always adds class &#34;alternate&#34; (closed: fixed)">#24951</a>
Related: <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/25059" title="defect (bug): Inline Edit Tags always adds class &#34;alternate&#34; (closed: fixed)">#25059</a>
</p>
<p>
When quick editing comments and saving the single_row method always uses the same classes "even thread-even". Additionally a css background color gets added to the table row inline.
</p>
<p>
This patch fixes the class issues. Still need a patch for the background color.
</p>
c3mdigitalhttps://core.trac.wordpress.org/ticket/25060
https://core.trac.wordpress.org/ticket/25060Report#20513: Refactor $wp_scripts init checking codeSun, 22 Apr 2012 15:15:36 GMTFri, 16 Jan 2015 05:37:07 GMT<p>
The functions in <a class="ext-link" href="http://core.trac.wordpress.org/browser/trunk/wp-includes/functions.wp-scripts.php"><span class="icon">​</span>functions.wp-scripts.php</a> seem to contain a lot of duplicate code in terms of checking and initializing the global <tt>$wp_scripts</tt> in each function.
</p>
<p>
Attached is rough first pass at creating a function to do this. I expect aspects of it could be done better.
</p>
<p>
I've included the first argument, to avoid relying on a global so that the function might be unit tested (pass something in, see what gets returned).
</p>
GaryJhttps://core.trac.wordpress.org/ticket/20513
https://core.trac.wordpress.org/ticket/20513Report#30614: Remove <code> tags from few more translatable stringSat, 06 Dec 2014 14:09:06 GMTSat, 14 Feb 2015 17:31:33 GMT<p>
See ticket <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/30612" title="defect (bug): Avoid using &lt;code&gt; HTML tags inside of translatable string (closed: fixed)">#30612</a>.
</p>
<p>
I found few more strings that use &lt;code&gt; tags inside of translatable string. This patch fixes the string.
</p>
<p>
Remove &lt;code&gt; tags from translatable string
</p>
ramiyhttps://core.trac.wordpress.org/ticket/30614
https://core.trac.wordpress.org/ticket/30614Report#23367: Remove message parameters from admin URl's in the browser address barSat, 02 Feb 2013 07:31:20 GMTMon, 02 Mar 2015 21:20:06 GMT<p>
Scenario: When a post is being published successfully "message=6" is appended to the URL. If I refresh the page while in that state I will get the "post published" message again, although nothing was done.
</p>
<p>
There is probably nothing functionally wrong with the way things work now but it can be esthetically more pleasant if that parameter was removed which in turn will eliminate the message problem.
</p>
<p>
This can be done on browsers that support the history API of HTML5. The following piece of code can be used after displaying the message or maybe it can be generalized to work in the admin footer.
</p>
<pre class="wiki">&lt;script type="text/javascript" charset="utf-8"&gt;
url = the canonical URL for the address
if (typeof history.replaceState === 'function') { // check html5 functionality support
data = {dummy:true};
history.replaceState(data,'',url);
}
&lt;/script&gt;
</pre>mark-khttps://core.trac.wordpress.org/ticket/23367
https://core.trac.wordpress.org/ticket/23367Report#18788: Remove redundant type attributes from script and style tagsTue, 27 Sep 2011 06:54:02 GMTFri, 06 Feb 2015 18:38:14 GMT<p>
Now that the admin is using the HTML5 doctype everywhere, the <tt>type="text/javascript"</tt> and <tt>type="text/css"</tt> attributes on script and style tags are unnecessary (if they weren't anyway), and I think they can be safely removed to trim a few hundred bytes from core. Should be a simple search and replace exercise.
</p>
solarissmokehttps://core.trac.wordpress.org/ticket/18788
https://core.trac.wordpress.org/ticket/18788Report#31255: Remove space from empty paragraphsSat, 07 Feb 2015 00:00:36 GMTTue, 10 Feb 2015 22:22:59 GMT<p>
I remember we fixed this in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28282" title="defect (bug): Remove &amp;nbsp; from an empty paragraphs inside the visual editor (closed: fixed)">#28282</a>, but this problem popped up again. Not sure where exactly <tt>&lt;p&gt;&lt;/p&gt;</tt> is replaced with <tt>&lt;p&gt;&amp;nbsp;&lt;/p&gt;</tt> again. Maybe just better to add a <tt>&lt;br&gt;</tt>.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/31255
https://core.trac.wordpress.org/ticket/31255Report#21976: Remove the "standard" fullscreen mode from the default configuration of TinyMCESun, 23 Sep 2012 18:07:56 GMTFri, 23 Jan 2015 17:31:34 GMT<p>
The "standard" TinyMCE fullscreen is incompatible with the DFW fullscreen. Currently we are loading both plugins and trying to give access to the standard fullscreen by shortcut only. This is left over from when DFW was working only for the Edit Post screen.
</p>
<p>
Best would be to remove the standard fullscreen completely. It can be added by a simple WordPress plugin for users that prefer it.
</p>
azaozzhttps://core.trac.wordpress.org/ticket/21976
https://core.trac.wordpress.org/ticket/21976Report#26553: Remove title attributes: comment-template.phpWed, 11 Dec 2013 21:05:58 GMTTue, 24 Feb 2015 15:44:01 GMT<p>
Related: <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/24766" title="defect (bug): Title attributes galore. They serve no useful purpose. (closed: fixed)">#24766</a>
</p>
<pre class="wiki">// comment-template.php
comments_popup_link()
comment_form()
</pre>joedolsonhttps://core.trac.wordpress.org/ticket/26553
https://core.trac.wordpress.org/ticket/26553Report#28687: Removing background image and/or reverting background color to default doesn't remove custom-background body class and remove theme modsMon, 30 Jun 2014 06:06:11 GMTTue, 24 Feb 2015 14:49:36 GMT<p>
Scenario:
</p>
<ul><li>Set custom background color, then revert do default or
</li><li>Set custom background image, then remove it
</li></ul><p>
Problem:
</p>
<ul><li>None of the theme mods are removed
</li><li>Because of this <tt>.custom-background</tt> is still being added
</li></ul><p>
This is what I have in theme_mods_twentyfourteen after setting background color and image, then removing them both:
</p>
<pre class="wiki">s:16:"background_color";s:6:"f5f5f5";
s:16:"background_image";s:0:"";
s:22:"background_image_thumb";s:0:"";
s:17:"background_repeat";s:6:"repeat";
s:21:"background_position_x";s:4:"left";
s:21:"background_attachment";s:6:"scroll";
</pre><p>
Sorry if this has been filed before. I checked for tickets that could relate to this, but no luck.
</p>
<p>
I'll work on a patch today, but it would be great if someone could say if there's a reason for this behaviour.
</p>
slobodanmanichttps://core.trac.wordpress.org/ticket/28687
https://core.trac.wordpress.org/ticket/28687Report#31245: Replace alloptions with a key cacheFri, 06 Feb 2015 05:39:47 GMTMon, 23 Feb 2015 10:49:30 GMT<p>
Let's talk about <tt>alloptions</tt>. <tt>alloptions</tt> is a particularly fragile piece of WordPress, since it's exceptionally vulnerable to accidental concurrency issues due to its design.
</p>
<p>
A primer on <tt>alloptions</tt>, for those who haven't dug into it: <tt>alloptions</tt> is a cache key that stores all the options marked with autoload, thereby reducing the number of external calls out to an object cache from hundreds down to 1. It does this by running <tt>SELECT * FROM wp_options WHERE autoload = 'yes'</tt>, then storing that array (map of <tt>option_name =&gt; option_value</tt>) under the <tt>alloptions</tt> cache key. (Non-autoloaded options are stored as individual cache items instead, with a key of <tt>option_name</tt> in the <tt>options</tt> group.)
</p>
<p>
When you add an option, you can pick the <tt>autoload</tt> flag. This flag is <tt>'yes'</tt> (<tt>true</tt>) <strong>by default</strong>, meaning most calls to <tt>add_option</tt> will set options to autoload. Additionally, if you add an option via <tt>update_option</tt>, there's no way to set this flag. These combined mean that the vast majority of options are stored in the <tt>alloptions</tt> cache.
</p>
<h2 id="Whyisthisanissue">Why is this an issue?</h2>
<p>
The <tt>alloptions</tt> cache is loaded very early in the WordPress request lifetime. From this moment until the end of a request, option reads are taken from this cache rather than the database.
</p>
<p>
In addition, every time an autoloaded option is updated or deleted, <tt>alloptions</tt> is similarly updated. However, this means that on <strong>any</strong> autoloaded option being updated, <strong>every</strong> autoloaded option has its value set to the value at load time.
</p>
<p>
This is a huge concurrency bug, as it's very easy to run into accidentally. As a proof of concept, try updating two different options in two different requests at the same time, and you'll see that whichever ran first will lose the changes. (See <a class="new ticket" href="https://core.trac.wordpress.org/ticket/25623" title="defect (bug): The design of update_option etc makes race conditions likely to happen (new)">#25623</a>)
</p>
<p>
(We're running into this issue a few times a week, due to certain plugins running an <tt>update_option</tt> on a high percentage of requests. These plugins are obviously being dumb in doing so, but they're revealing the core bug quite nicely.)
</p>
<h2 id="Howdowefixthis">How do we fix this?</h2>
<p>
The biggest issue is that <tt>alloptions</tt> is a single cache item containing every option. If we reduce this to one cache item per option, the concurrency problem is then reduced to individual options (and can be mitigated in the places it actually matters, typically in plugins). Rather than storing all the options, we can instead cache the keys that matter, then grab the values for all of those at once.
</p>
<p>
This means that we may still have minor concurrency issues when adding and removing options, however these happen much less often than updating existing ones. In addition, the cache would now only be used to decide which options to load at the start of the request, so worst case scenario, you end up with extra object cache <tt>get</tt> calls. This is much better than the current case, where a concurrency problem can return incorrect data.
</p>
<p>
This change would require adding a <tt>wp_cache_get_multi</tt> to take full advantage of the cache, however compatibility could be shimmed here with a loop and individual calls to <tt>wp_cache_get</tt>. This <strong>would</strong> cause worse performance for object caches that don't support multi-get (or haven't been updated), but at the benefit of no longer returning potentially bad data.
</p>
<p>
There's a few things that need to be done for this:
</p>
<ul><li>Add <tt>wp_cache_multi_get</tt>, and talk to object cache maintainers to update the popular ones to support it (Memcache, APC)
</li><li>Change <tt>wp_load_alloptions</tt> to pull from <tt>alloptionskeys</tt>, then run a multi-get on those
</li><li>Ensure <tt>alloptionskeys</tt> is a protected option name
</li><li>Store value caches per-key
</li></ul>rmccuehttps://core.trac.wordpress.org/ticket/31245
https://core.trac.wordpress.org/ticket/31245Report#31259: Replace array_shift() with current() where appropriateSat, 07 Feb 2015 19:13:58 GMTSat, 07 Feb 2015 19:14:58 GMT<p>
Background: <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/31182" title="defect (bug): array_shift in taxonomy.php very slow on large array (closed: fixed)">#31182</a>
</p>
<p>
<tt>array_shift()</tt> recalculates array indexes, and can be slow on large arrays. Most of the time, this is unnecessary, as we only use it to get the first element of the array, and the array is never used later.
</p>
SergeyBiryukovhttps://core.trac.wordpress.org/ticket/31259
https://core.trac.wordpress.org/ticket/31259Report#22329: Retina GravatarsWed, 31 Oct 2012 05:18:14 GMTFri, 20 Feb 2015 02:09:08 GMT<p>
Mentioned by Matt in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/21019" title="task (blessed): Retina All the Things (closed: fixed)">#21019</a>
</p>
<p>
Should be a simple matter of changing get_avatar() in pluggable.php so that the requested size is twice the display size.
</p>
miqrogroovehttps://core.trac.wordpress.org/ticket/22329
https://core.trac.wordpress.org/ticket/22329Report#21295: Retrospectively generate new images sizes if requestedTue, 17 Jul 2012 10:12:01 GMTFri, 13 Feb 2015 17:17:54 GMT<p>
At present the image variations are created at the moment the image is uploaded to the server. If a new image size is later added, or the default ones changed after an image is uploaded then the existing images are not adjusted.
</p>
<p>
Whilst there are plugins that provide - regenerate thumbnail functionality it might be neater if an image size is requested that doesn't exist that the system generates it at the time it is requested. This only need happen once per image as once it is created it doesn't need to be created again.
</p>
TwoThirdsWaterhttps://core.trac.wordpress.org/ticket/21295
https://core.trac.wordpress.org/ticket/21295Report#31373: Revamp Press ThisWed, 18 Feb 2015 23:19:15 GMTMon, 02 Mar 2015 06:32:06 GMT<p>
This will be used as the master tracking ticket for the <a class="ext-link" href="https://make.wordpress.org/core/tag/press-this/"><span class="icon">​</span>Press This Revamp</a> feature plugin, which has been approved for merge in the 4.2 release.
</p>
<ul><li>GitHub Repo: <a class="ext-link" href="https://github.com/MichaelArestad/Press-This"><span class="icon">​</span>https://github.com/MichaelArestad/Press-This</a>
</li><li>Plugin Page: <a class="ext-link" href="https://wordpress.org/plugins/press-this/"><span class="icon">​</span>https://wordpress.org/plugins/press-this/</a>
</li></ul>michael-arestadhttps://core.trac.wordpress.org/ticket/31373
https://core.trac.wordpress.org/ticket/31373Report#26675: Rewrite of get_media_embedded_in_content() function to produce expected results.Wed, 18 Dec 2013 22:14:28 GMTFri, 27 Feb 2015 16:11:01 GMT<p>
The get_media_embedded_in_content() function does not output the media in the array in the order it appears in the content (as it should). Rather, it loops through each tag and gets the media in the order of tag (if get_tag_regex() worked correctly, see <a class="ext-link" href="http://core.trac.wordpress.org/ticket/26674"><span class="icon">​</span>#26674</a>).
</p>
<p>
The attached patch adds a third parameter 'sortby' to declare how the results should sort. By default it sorts by 'type' and the remains as it is now. If a user declares the 'sortby' parameter as 'source', the results would appear in the order they are found in the content (which is what I expected).
</p>
<p>
Also preg_match() was changed to preg_match_all() to find all the media of a type (instead of just one).
</p>
<p>
Lastly, the regex used in the 'source' sort by is a modification of the get_tag_regex() to try subpatterns in alternation. An optional fix would be to add the named group in the get_tag_regex() function, but that is another patch.
</p>
<p>
Side note: I added 'img' to the option of allowed media types (because it is media). If anyone has a reason this should not be in there, I would like to know why. I did not find any complications while testing.
</p>
kopepasahhttps://core.trac.wordpress.org/ticket/26675
https://core.trac.wordpress.org/ticket/26675Report#31003: Row actions not revealed on focus in network usersTue, 13 Jan 2015 19:51:00 GMTWed, 14 Jan 2015 13:00:05 GMT<p>
Follow-up to <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/30980" title="defect (bug): Row actions not revealed on focus in categories and tags screens (closed: fixed)">#30980</a>
there's one more place where row-actions are not revealed on focus: on multisite installations
<tt>/wp-admin/network/users.php</tt> see <tt>td.column-blogs</tt>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31003
https://core.trac.wordpress.org/ticket/31003Report#22010: RSS Widget with hardcoded icon and styleWed, 26 Sep 2012 22:13:58 GMTTue, 20 Jan 2015 14:56:59 GMT<p>
Standard RSS Widget outputs hardcoded icon and oldschool inline style="border:0" e.g.
</p>
<pre class="wiki">&lt;img style="border:0" width="14" height="14" src="http://zdrojak.lamp.wikidi.net/wp-includes/images/rss.png" alt="RSS"&gt;
</pre><p>
this makes it hard to style (even more that the parent anchor has the same css class as following title, so you can't even hide it without some css3 only magic (:first)
</p>
<p>
IMO this part of WP_INC/default-widgets.php row 766-777
</p>
<pre class="wiki"> $icon = includes_url('images/rss.png');
if ( $title )
$title = "&lt;a class='rsswidget' href='$url' title='" . esc_attr__( 'Syndicate this content' ) ."'&gt;&lt;img style='border:0' width='14' height='14' src='$icon' alt='RSS' /&gt;&lt;/a&gt; &lt;a class='rsswidget' href='$link' title='$desc'&gt;$title&lt;/a&gt;";
</pre><p>
+ line 764
</p>
<p>
should be replaced by standard way e.g.
</p>
<pre class="wiki"> $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'RSS' ) : $instance['title'], $instance, $this-&gt;id_base );
</pre><p>
so when someone wants to output there an icon, he could simply with the widget_title filter
</p>
thomaskhttps://core.trac.wordpress.org/ticket/22010
https://core.trac.wordpress.org/ticket/22010Report#30799: Scrutinizer in 4.2Sat, 20 Dec 2014 20:13:59 GMTThu, 26 Feb 2015 05:53:32 GMT<p>
Continued efforts to improve static analysis of the codebase. Most commits will be minor changes that either remove dead code, improve comprehensibility of existing code, or clarify types specified by <tt>@param</tt> docs.
</p>
wonderboymusichttps://core.trac.wordpress.org/ticket/30799
https://core.trac.wordpress.org/ticket/30799Report#26600: Search installed themes input has no submit buttonFri, 13 Dec 2013 11:48:43 GMTTue, 24 Feb 2015 16:20:11 GMT<p>
This input field has no corresponding Search button. I can see that adding letters to the field refines the themes shown on the screen. However, when using a screen reader there is no audible feedback to tell the screen reader user that the display is being updated.
</p>
<p>
Provision of a submit button may help with this as users will be more likely to expect the results to be changed based on the characters they have entered.
</p>
<p>
Alternatively (or additionally) a solution using <tt>aria-live</tt> regions could be investigated to give screen readers feedback that the search results have changed. I notice that the number next to the word Themes updates as the search results change. This could be the basis for an <tt>aria-live</tt> solution, but more context would need to be provided.
</p>
grahamarmfieldhttps://core.trac.wordpress.org/ticket/26600
https://core.trac.wordpress.org/ticket/26600Report#26504: Semantic elements for non-link linksMon, 09 Dec 2013 14:29:18 GMTMon, 02 Mar 2015 23:31:11 GMT<p>
Using the <a class="ext-link" href="http://heydonworks.com/revenge_css_bookmarklet/"><span class="icon">​</span>revenge.css bookmarklet</a> on the dashboard gives a very <a class="ext-link" href="http://d.pr/i/yVYh"><span class="icon">​</span>clear indication</a> that some of the links on there are semantically incorrect - they should be buttons, even if they should look like links.
</p>
<p>
The Actual Buttons Are Actual section of this <a class="ext-link" href="http://coding.smashingmagazine.com/2013/08/20/semantic-css-with-intelligent-selectors/"><span class="icon">​</span>article</a> sums it up nicely why.
</p>
<p>
Unless the accessibility team have indicated otherwise, each of the 74+ occurrences (only counting PHP files, more in JS files) of links with <tt>href="#"</tt> should probably be a <tt>&lt;button&gt;</tt>, so that screen readers interpret it as a button that does something, rather than a link that takes you somewhere. It also reduces the number of links that can be pulled out of context.
</p>
<p>
Appearance isn't a problem either - taking the "See 3 more…" from the screenshot:
</p>
<pre class="wiki">// Original:
&lt;a href="#"&gt;See 3 more…&lt;/a&gt;
// New (might benefit from ARIA attribute):
&lt;button class="no-button"&gt;See 3 more…&lt;/button&gt;
// Basic CSS:
.no-button {
background: none;
border: none;
color: #0074a2;
}
.no-button:hover {
color: #2EA2C9;
cursor: pointer;
}
</pre>GaryJhttps://core.trac.wordpress.org/ticket/26504
https://core.trac.wordpress.org/ticket/26504Report#31251: Show username in wp_dropdown_users when deleting users, not display nameFri, 06 Feb 2015 19:54:20 GMTMon, 02 Mar 2015 18:20:29 GMT<p>
<tt>wp_dropdown_users</tt>, by default, shows the display name for a user.
</p>
<p>
The function is used in <tt>users.php</tt> to show a list of users, so that you can attribute posts to someone when deleting an existing user. It should show the username so that the exact list shows up. I just had a situation trying to delete a user where I had multiple "Tom"s show up as display names, with no idea which to delete.
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/RSlM9jG45g.png"><img src="https://cldup.com/RSlM9jG45g.png" alt="https://cldup.com/RSlM9jG45g.png" title="https://cldup.com/RSlM9jG45g.png" /></a>
</p>
<p>
We can easily use the <tt>show</tt> parameter where <tt>wp_dropdown_users</tt> is used in <tt>users.php</tt> to delete a user to make this actually usable when deleting users.
</p>
krogsgardhttps://core.trac.wordpress.org/ticket/31251
https://core.trac.wordpress.org/ticket/31251Report#31013: Similar strings and missing plural for users pageWed, 14 Jan 2015 17:09:04 GMTWed, 14 Jan 2015 17:12:20 GMT<ul><li>There are 3 similar strings, we can make only one. There is no need for other strings for Users, because there is only one string for Posts, Plugins, etc.
</li></ul><ul><li>We have plural for deleting users, there should be also plural for removing users.
</li></ul><p>
See attached patch.
</p>
pavelevaphttps://core.trac.wordpress.org/ticket/31013
https://core.trac.wordpress.org/ticket/31013Report#17864: Small bug when using "wp_delete_file" filterTue, 21 Jun 2011 20:40:36 GMTFri, 27 Feb 2015 16:51:44 GMT<p>
Hi,
</p>
<p>
I came acrossed this little annoying bugger, when I was playing around with upload filters.
</p>
<p>
When I added the "wp_delete_file", I kept getting this error:
</p>
<div class="code"><pre><span class="x">Notice: Undefined index: path in /volume1/web/dev/favola_dk/wp-includes/post.php on line 3757
</span></pre></div><p>
I then digged down in the line, where the error was occuring and I find this little bugger (the bold line is line 3757):
</p>
<div class="code"><pre><span class="x">// remove intermediate and backup images if there are any
foreach ( get_intermediate_image_sizes() as $size ) {
if ( $intermediate = image_get_intermediate_size($post_id, $size) ) {
$intermediate_file = apply_filters('wp_delete_file', $intermediate['path']);
@ unlink( path_join($uploadpath['basedir'], $intermediate_file) );
}
}
</span></pre></div><p>
I noticed when I var_dump() the $size, that "path" is not within the array at any time. And the funny thing is, if you go down the next block in the code you'll see this:
</p>
<div class="code"><pre><span class="x">if ( is_array($backup_sizes) ) {
foreach ( $backup_sizes as $size ) {
$del_file = path_join( dirname($meta['file']), $size['file'] );
$del_file = apply_filters('wp_delete_file', $del_file);
@ unlink( path_join($uploadpath['basedir'], $del_file) );
}
}
</span></pre></div><p>
Here it uses the index "file", which is the one I was expecting to recieve in the former block.
</p>
DuGi_dkhttps://core.trac.wordpress.org/ticket/17864
https://core.trac.wordpress.org/ticket/17864Report#29820: Smooth installation and updating of plugins and themesWed, 01 Oct 2014 21:04:28 GMTTue, 24 Feb 2015 04:33:59 GMT<p>
The "UI" for plugin installs and updates and the "UI" for theme updates (and combined updates) is about as friendly as the Linux boot sequence.
</p>
<p>
This is a tracking ticket for improving that whole experience, as a blessed effort for the WordPress 4.1 release.
</p>
<p>
@Pento has gotten started already: <a class="ext-link" href="https://github.com/pento/shiny-updates"><span class="icon">​</span>https://github.com/pento/shiny-updates</a> (functional, but with minimal UI changes). So as a next step, we need to think about the UX we want, and then what we need to do UI-wise and PHP-wise to make that happen.
</p>
<p>
Making the installation and updates happen inline is paramount. Right now it is a jarring and unfriendly experience.
</p>
markjaquithhttps://core.trac.wordpress.org/ticket/29820
https://core.trac.wordpress.org/ticket/29820Report#29897: Some focus styles are brokenThu, 09 Oct 2014 03:27:42 GMTWed, 04 Feb 2015 17:07:27 GMT<p>
See screenshots below.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/29897
https://core.trac.wordpress.org/ticket/29897Report#24879: Sourcemaps should be provided for use with minified javascript librariesMon, 29 Jul 2013 15:49:33 GMTFri, 27 Feb 2015 16:40:52 GMT<p>
Sourcemaps make it possible to debug minified files.
</p>
<p>
Supported in Chrome:
<a class="ext-link" href="https://developers.google.com/chrome-developer-tools/docs/javascript-debugging#source-maps"><span class="icon">​</span>https://developers.google.com/chrome-developer-tools/docs/javascript-debugging#source-maps</a>
</p>
<p>
Landing in Firefox in v23:
<a class="ext-link" href="https://wiki.mozilla.org/DevTools/Features/SourceMap"><span class="icon">​</span>https://wiki.mozilla.org/DevTools/Features/SourceMap</a>
</p>
<p>
When this feature is enabled, the Chrome console currently shows a 404 when the script specifies a sourcemap file and it isn't found.
</p>
jblzhttps://core.trac.wordpress.org/ticket/24879
https://core.trac.wordpress.org/ticket/24879Report#25698: Speed up slow Menus Panel for menus with many itemsFri, 25 Oct 2013 15:14:46 GMTFri, 27 Feb 2015 17:46:18 GMT<p>
<strong>Overview</strong>
</p>
<p>
When the <a href="https://core.trac.wordpress.org/ticket/14045">new accessibility enhancements</a> (<a class="ext-link" href="https://github.com/WordPress/WordPress/commit/9bd740f6165f26ee44f8bd19a3a8a565c640742b"><span class="icon">​</span>relevant commit</a>) were added to the Appearance &gt; Menus Panel in WordPress 3.6, it added a lot of extra javascript processing per menu item. For large menus (say, &gt; 50 menu items), this creates a bottleneck and slows down both the menu panel load time and the ability to manage the menu, resulting in a poor user experience - for a menu with 100 items, the lag is around 6 seconds in my tests (and in extreme cases, users have experienced browser crashing due to not being able to handle the javascript load). Basically, the processing time for these accessibility enhancements increases linearly with each new menu item, slowing things down considerably once there are many menu items in play.
</p>
<p>
<strong>Details &amp; Demonstration</strong>
</p>
<p>
I've written up a detailed article on the issue here: <a class="ext-link" href="http://sevenspark.com/wordpress/speeding-up-the-appearance-menus-screen-in-wordpress-3-6"><span class="icon">​</span>Speeding up the Appearance &gt; Menus Screen in WordPress 3.6 </a>
</p>
<p>
I've also created a screencast demonstrating the issue: <a class="ext-link" href="http://www.youtube.com/watch?v=P1wOPN5zJz"><span class="icon">​</span>Video</a> - which shows and times the lag, as well as demonstrates the performance improvement using my "lazy" solution.
</p>
<p>
(Please note I also tested in WordPress 3.7, and the same issue/solution applies.)
</p>
<p>
<strong>Issue Source Synopsis</strong>
</p>
<p>
After doing some troubleshooting, I believe that the issue occurs in wp-admin/js/nav-menu.js, in the function refreshAdvancedAccessibility(). The problem is that both on page load and any time a change is made, the entire set of menu items needs to be reprocessed, causing the page to become unresponsive for several seconds until the processing completes. (Please see linked article and video above for more detailed explanation)
</p>
<p>
<strong>Potential Solution (including available plugin)</strong>
</p>
<p>
I've outlined my solution in the article I linked to above. Instead of processing every menu item every time, this solution takes a "lazy" approach and only processes menu items when the item is about to be interacted with (triggered on hover, focus, or touch). This greatly reduces the processing load and allows the page to become immediately responsive, improving user experience. The lag when moving menu items is also eliminated. I am not an accessibility expert, but I believe triggering the processing on focus will ensure that the accessibility features are present for those interacting with the site without a pointer device.
</p>
<p>
I've also written and released a plugin - <a class="ext-link" href="http://wordpress.org/plugins/faster-appearance-menus/"><span class="icon">​</span>Faster Appearance - Menus</a> (also on <a class="ext-link" href="https://github.com/sevenspark/faster-appearance-menus"><span class="icon">​</span>github</a>) which implements this solution by replacing the default nav-menu.js with my modified version. The plugin was released about 2 months ago, and has received positive feedback from many users who were encountering slow Menus Panel speeds (as someone who writes plugins dealing with the creation and management of menus with many items, I've encountered this issue with a lot of customers). That being said, I'm sure it could be improved and needs more stringent testing and code review.
</p>
<p>
Thanks! This is my first ever submission to trac, so I do apologize if I have done anything wrong here.
</p>
sevensparkhttps://core.trac.wordpress.org/ticket/25698
https://core.trac.wordpress.org/ticket/25698Report#28510: Split javascript files in media into modulesThu, 12 Jun 2014 15:45:02 GMTSun, 22 Feb 2015 08:47:02 GMT<p>
<a class="ext-link" href="http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&amp;day=2014-06-11&amp;sort=asc#m868005"><span class="icon">​</span>Yesterday in dev chat</a>, ideas for splitting up distinct javascript modules in were discussed. As we move towards more and more javascript-heavy administrative interfaces, this will prove quite helpful in readability, and by extension maintainability. A 6000 line file made up of 50-some views is not easy to step into. A folder of well organized modules for one feature would be.
</p>
<p>
This will only affect the src/ directory in the develop repository, which will use our build process to concatenate into the build/ directory, so nothing will change for developers using the build/ directory or the core repo.
</p>
<p>
We'll start this effort with media, and end up with a standardized way of doing this going forward.
</p>
ericlewishttps://core.trac.wordpress.org/ticket/28510
https://core.trac.wordpress.org/ticket/28510Report#31167: SSH2/SFTP newline breaks path causes segfault and "Save Changes" missing in UIWed, 28 Jan 2015 21:25:20 GMTMon, 23 Feb 2015 17:26:32 GMT<p>
Trying to use the SSH2 update method on 4.1. Running on Red Hat Enterprise Linux 6.6 with php55 and httpd24 from SCL (software collections).
</p>
<p>
After installing the php55-php-pecl-ssh2 I was getting segfaults from php-fpm causing "Service Unavailable" messages when performing certain functions such as trying to remove a plugin (installing a plugin however worked).
I also noticed that I did not have the "Save Changes" submit button in Settings-&gt;General or anything underneath TimeZone. TimeZone was simply showing "UTC+0".
</p>
<p>
I worked through Red Hat support to rule out php-fpm as the cause and it appears that there is a newline being introduced in the pwd call in class-wp-filesystem-ssh2.php causing the issue.
It makes the path /var/www/sites/wca/ turn into /var/www/sites/wca\n/.
Part of the trace is below:
</p>
<pre class="wiki"> #0 __strlen_sse42 () at ../sysdeps/x86_64/multiarch/strlen-sse4.S:32
#1 0x000000000058d4bf in _estrdup (s=0x0) at /usr/src/debug/php-5.5.6/Zend/zend_alloc.c:2630
#2 0x00007fcb122aac76 in php_ssh2_fopen_wraper_parse_path (path=0x36ab5c8 "ssh2.sftp://Resource id #140/var/www/sites/wca\n/", type=&lt;value optimized out&gt;, context=0x0, psession=0x7fffe8cab9d0,
presource_id=0x7fffe8cab9dc, psftp=0x7fffe8cab9c8, psftp_rsrcid=0x7fffe8cab9d8) at /usr/src/debug/php55-php-pecl-ssh2-0.12/NTS/ssh2_fopen_wrappers.c:226
#3 0x00007fcb122ad626 in php_ssh2_sftp_urlstat (wrapper=&lt;value optimized out&gt;, url=&lt;value optimized out&gt;, flags=2, ssb=0x7fffe8cabad0, context=&lt;value optimized out&gt;)
at /usr/src/debug/php55-php-pecl-ssh2-0.12/NTS/ssh2_sftp.c:390
#4 0x000000000056a65f in _php_stream_stat_path (path=0x36ab5c8 "ssh2.sftp://Resource id #140/var/www/sites/wca\n/", flags=2, ssb=0x7fffe8cabad0, context=0x0)
at /usr/src/debug/php-5.5.6/main/streams/streams.c:1933
#5 0x0000000000507a82 in php_stat (filename=0x36ab5c8 "ssh2.sftp://Resource id #140/var/www/sites/wca\n/", filename_length=&lt;value optimized out&gt;, type=12, return_value=0x3a657f8)
at /usr/src/debug/php-5.5.6/ext/standard/filestat.c:906
</pre><p>
It appears that a simple fix might be to just rtrim the call to pwd in class-wp-filesystem-ssh2.php, at least that fixed the issues I am seeing (do not know if it introduces any).
</p>
<p>
I changed the following function (just line 187) from:
</p>
<pre class="wiki">186 public function cwd() {
187 $cwd = $this-&gt;run_command('pwd');
188 if ( $cwd )
189 $cwd = trailingslashit($cwd);
190 return $cwd;
191 }
</pre><p>
to
</p>
<pre class="wiki">186 public function cwd() {
187 $cwd = rtrim($this-&gt;run_command('pwd'));
188 if ( $cwd )
189 $cwd = trailingslashit($cwd);
190 return $cwd;
191 }
</pre><p>
After making that change it appears that the SSH2 functions work properly.
</p>
thajekkuhttps://core.trac.wordpress.org/ticket/31167
https://core.trac.wordpress.org/ticket/31167Report#30716: Strange date format in Publish box after changeMon, 15 Dec 2014 10:11:32 GMTSat, 17 Jan 2015 11:47:46 GMT<p>
I tried to change date from 13th to 14th December in Publish box and when clicking "OK" button, strange date format appeared (also space between icon and "Published on" string was shrinked)... See attached screenshot...
</p>
pavelevaphttps://core.trac.wordpress.org/ticket/30716
https://core.trac.wordpress.org/ticket/30716Report#29256: Strings ending with a number and quotation mark get wrong smart quotesMon, 18 Aug 2014 22:52:49 GMTTue, 13 Jan 2015 14:06:48 GMT<p>
When a string ends in a number followed by a single or double quote, such as <tt>"Lorem ipsum dolor sit amet 1234"</tt> or <tt>'Etiam eu egestas dui 1234'</tt> wptexturize incorrectly converts the trailing single or double quote into a single or double prime, respectively.
</p>
<p>
Related to <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/8775" title="defect (bug): Numbers in quotation marks get wrong smart quotes (closed: fixed)">#8775</a>, but the scope of that ticket seems to be limited to numbers inside of quotes, not a number preceded by other text (crudely described as<tt>\d+</tt> vs <tt>.*\d+</tt>).
</p>
<p>
This is still an issue in trunk on .org and on wordpress.com (Example: <a class="ext-link" href="http://coreygilmore.wordpress.com/2014/08/18/expendables-3-illegally-downloaded-5-million-times-but-still-isnt-top-hit-for-pirates/"><span class="icon">​</span>http://coreygilmore.wordpress.com/2014/08/18/expendables-3-illegally-downloaded-5-million-times-but-still-isnt-top-hit-for-pirates/</a>)
</p>
coreygilmorehttps://core.trac.wordpress.org/ticket/29256
https://core.trac.wordpress.org/ticket/29256Report#29906: Submenus can't be dismissed on mobile.Thu, 09 Oct 2014 15:24:37 GMTFri, 27 Feb 2015 15:58:55 GMT<p>
When the site-name submenu pane is active, it covers the viewport and there is no way to dismiss it. All tapping will lead to a screen in the admin.
</p>
<p>
First reported in: <a class="ext-link" href="https://make.wordpress.org/flow/2014/07/07/the-guises-of-bar-nexus-5-4-0-alpha-20140706/screenshot_2014-07-07-07-41-58/"><span class="icon">​</span>https://make.wordpress.org/flow/2014/07/07/the-guises-of-bar-nexus-5-4-0-alpha-20140706/screenshot_2014-07-07-07-41-58/</a>
</p>
obenlandhttps://core.trac.wordpress.org/ticket/29906
https://core.trac.wordpress.org/ticket/29906Report#31428: Switch_to_blog() no longer works in Customize using Multisite.Mon, 23 Feb 2015 20:09:07 GMTWed, 25 Feb 2015 16:47:57 GMT<p>
A change in /wp-includes/class-wp-customize-setting.php seems to have broken something.
</p>
<p>
Code that uses switch_to_blog() no longer gets run in customize view.
</p>
<p>
Had no problem in 4.1
</p>
csschrishttps://core.trac.wordpress.org/ticket/31428
https://core.trac.wordpress.org/ticket/31428Report#31485: Tags meta box: consider removing taghintSat, 28 Feb 2015 00:58:30 GMTTue, 03 Mar 2015 18:56:23 GMT<p>
Noticed today on Slack with @michaelarestad and @azaozz, looks like <tt>taghint</tt> was used in 3.0 (and maybe later, see screenshot) like a "fake placeholder" for the new tag input field but it doesn't work anymore (HTML is changed, always hidden with CSS) and maybe no more needed. Still takes some bytes of JavaScript and CSS though. Worth considering some cleaning?
See also Press This.
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/-ggqKEMxKV.png"><img src="https://cldup.com/-ggqKEMxKV.png" alt="https://cldup.com/-ggqKEMxKV.png" title="https://cldup.com/-ggqKEMxKV.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31485
https://core.trac.wordpress.org/ticket/31485Report#31241: Taxonomy error messages show success colorsThu, 05 Feb 2015 22:10:18 GMTWed, 11 Feb 2015 05:40:34 GMT<p>
When attempting to update a taxonomy fails the message is shown with a green update border instead of the red error border.
</p>
<p>
Steps to reproduce:
</p>
<ol><li>Create two tags
</li><li>Edit the second tag
</li><li>Attempt to change the slug of the second tag to be the same as the first
</li></ol><p>
After hitting update you will be take to the list of all tags and the message "Tag not updated." Will show with a green border.
</p>
ninnypantshttps://core.trac.wordpress.org/ticket/31241
https://core.trac.wordpress.org/ticket/31241Report#31262: Tests_DB_Charset failuresSun, 08 Feb 2015 05:14:14 GMTSat, 14 Feb 2015 03:12:23 GMT<p>
Background: <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/21212" title="task (blessed): MySQL tables should use utf8mb4 character set (closed: fixed)">#21212</a>
</p>
<p>
Seeing two failures in current trunk running <tt>phpunit --group wpdb</tt> on PHP 5.2.17, MySQL 5.0.51a:
</p>
<pre class="wiki">There were 2 failures:
1) Tests_DB_Charset::test_strip_invalid_text with data set #6 (array(array('hebrew', 'ùord÷ress', true)), array(array('hebrew', 'ùord÷ress', true)), 'hebrew')
hebrew
Failed asserting that Array (
0 =&gt; Array (
'charset' =&gt; 'hebrew'
'value' =&gt; '?ord?ress'
'db' =&gt; true
)
) is identical to Array (
0 =&gt; Array (
'charset' =&gt; 'hebrew'
'value' =&gt; 'ùord÷ress'
'db' =&gt; true
)
).
S:\home\wordpress\develop\tests\phpunit\tests\db\charset.php:129
S:\usr\local\php5\phpunit:46
2) Tests_DB_Charset::test_strip_invalid_text with data set #9 (array(array('latin1', 'ðŸŽ·'), array('ascii', 'Hello World'), array('utf8', 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'), array('utf8mb3', 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'), array('utf8mb4', 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'), array('koi8r', 'ýordòress', true), array('hebrew', 'ùord÷ress', true), array(false, 100), array('big5', 'a¦@b')), array(array('latin1', 'ðŸŽ·'), array('ascii', 'Hello World'), array('utf8', 'Hâ‚¬lloWorldÂ¢'), array('utf8mb3', 'Hâ‚¬lloWorldÂ¢'), array('utf8mb4', 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'), array('koi8r', 'ýordòress', true), array('hebrew', 'ùord÷ress', true), array(false, 100), array('big5', 'a¦@b')), 'multiple fields/charsets')
multiple fields/charsets
Failed asserting that Array (
0 =&gt; Array (
'charset' =&gt; 'latin1'
'value' =&gt; 'ðŸŽ·'
)
1 =&gt; Array (
'charset' =&gt; 'ascii'
'value' =&gt; 'Hello World'
)
2 =&gt; Array (
'charset' =&gt; 'utf8'
'value' =&gt; 'Hâ‚¬lloWorldÂ¢'
)
3 =&gt; Array (
'charset' =&gt; 'utf8mb3'
'value' =&gt; 'Hâ‚¬lloWorldÂ¢'
)
4 =&gt; Array (
'charset' =&gt; 'utf8mb4'
'value' =&gt; 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'
)
5 =&gt; Array (
'charset' =&gt; 'koi8r'
'value' =&gt; 'ýordòress'
'db' =&gt; true
)
6 =&gt; Array (
'charset' =&gt; 'hebrew'
'value' =&gt; '?ord?ress'
'db' =&gt; true
)
7 =&gt; Array (
'charset' =&gt; false
'value' =&gt; 100
)
8 =&gt; Array (
'charset' =&gt; 'big5'
'value' =&gt; 'a¦@b'
)
) is identical to Array (
0 =&gt; Array (
'charset' =&gt; 'latin1'
'value' =&gt; 'ðŸŽ·'
)
1 =&gt; Array (
'charset' =&gt; 'ascii'
'value' =&gt; 'Hello World'
)
2 =&gt; Array (
'charset' =&gt; 'utf8'
'value' =&gt; 'Hâ‚¬lloWorldÂ¢'
)
3 =&gt; Array (
'charset' =&gt; 'utf8mb3'
'value' =&gt; 'Hâ‚¬lloWorldÂ¢'
)
4 =&gt; Array (
'charset' =&gt; 'utf8mb4'
'value' =&gt; 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'
)
5 =&gt; Array (
'charset' =&gt; 'koi8r'
'value' =&gt; 'ýordòress'
'db' =&gt; true
)
6 =&gt; Array (
'charset' =&gt; 'hebrew'
'value' =&gt; 'ùord÷ress'
'db' =&gt; true
)
7 =&gt; Array (
'charset' =&gt; false
'value' =&gt; 100
)
8 =&gt; Array (
'charset' =&gt; 'big5'
'value' =&gt; 'a¦@b'
)
)
</pre>SergeyBiryukovhttps://core.trac.wordpress.org/ticket/31262
https://core.trac.wordpress.org/ticket/31262Report#24486: The 'commentsdiv' meta box isn't displayed when using custom post statusesMon, 03 Jun 2013 08:22:39 GMTSat, 24 Jan 2015 02:21:08 GMT<p>
The 'commentsdiv' meta box, which shows comments to a post in the admin post edit section (and also gives the ability to post additional comments straight from there) isn't displayed when the post is set to any non-publish or non-private post status, particularly any custom post status.
</p>
<p>
As far as I can tell, the problem arises from the fact that the said meta box is initialized in "wp-admin/edit-form-advanced.php", where the conditional expression for its initialization has the "publish" and "private" post statuses hardcoded in:
</p>
<pre class="wiki">if ( ('publish' == $post-&gt;post_status || 'private' == $post-&gt;post_status) &amp;&amp; post_type_supports($post_type, 'comments') )
add_meta_box('commentsdiv', __('Comments'), 'post_comment_meta_box', $post_type, 'normal', 'core');
</pre><p>
The existing code is disabling the initialization of the 'commentsdiv' meta box in any use case with custom post statuses, reducing their usefulness and flexibility.
</p>
<p>
In my opinion, the the simplest fix for this would be to remove the post status check as a condition for the 'commentsdiv' meta box initialization, leaving the "post_type_supports($post_type, 'comments')" as the only condition:
</p>
<pre class="wiki">if ( post_type_supports($post_type, 'comments') )
add_meta_box('commentsdiv', __('Comments'), 'post_comment_meta_box', $post_type, 'normal', 'core');
</pre>XyntaManhttps://core.trac.wordpress.org/ticket/24486
https://core.trac.wordpress.org/ticket/24486Report#31174: The get_terms() argument "fields" renders "get_terms_fields" & "terms_clauses" filter callbacks uselessThu, 29 Jan 2015 10:58:24 GMTSat, 21 Feb 2015 12:56:14 GMT<p>
The <tt>get_terms( $tax, [ args ] );</tt> function accepts an argument named <tt>fields</tt>. This allows to chose which columns should be fetched from either the <tt>wp_terms</tt> or <tt>wp_term_taxonomy</tt> table. Example:
</p>
<pre class="wiki">$terms = get_terms( 'example_tax', [ 'fields' =&gt; 'names', ] );
var_dump( $names );
/* Result:
array (size=1)
0 =&gt; string 'Code Review' (length=11)
*/
</pre><p>
In this case, the resulting query inside the function would be the following:
</p>
<pre class="wiki">SELECT t.term_id, tt.parent, tt.count, t.name
FROM wp_terms AS t
INNER JOIN wp_term_taxonomy AS tt
ON t.term_id = tt.term_id
WHERE tt.taxonomy IN ('project_type')
ORDER BY t.name ASC
</pre><p>
In fact, <tt>fields</tt> does not really any combination of fields, but allows to chose from a list:
</p>
<ul><li><tt>all</tt> : <tt>$selects = array( 't.*', 'tt.*' )</tt>
</li><li><tt>ids</tt> : <tt>$selects = array( 't.term_id', 'tt.parent', 'tt.count' )</tt>
</li><li><tt>id=&gt;parent</tt> : <tt>$selects = array( 't.term_id', 'tt.parent', 'tt.count' )</tt> (the same as above)
</li><li><tt>names</tt> : <tt>$selects = array( 't.term_id', 'tt.parent', 'tt.count', 't.name' )</tt>
</li><li><tt>count</tt> : <tt>$selects = array( 'COUNT(*)' )</tt>
</li><li><tt>id=&gt;name</tt> : <tt>$selects = array( 't.term_id', 't.name', 'tt.count' )</tt>
</li><li><tt>id=&gt;slug</tt> : <tt>$selects = array( 't.term_id', 't.slug', 'tt.count' )</tt>
</li></ul><p>
After this preselection ran, there are two filters available to alter the list:
</p>
<pre class="wiki">$fields = implode( ', ', apply_filters( 'get_terms_fields', $selects, $args, $taxonomies ) );
$pieces = array( 'fields', 'join', 'where', 'orderby', 'order', 'limits' );
</pre><p>
But no matter if you attached an filter to either of those or not: The result stays the same. This is due to the following filtering done in a final loop through all results:
</p>
<ul><li><tt>ids</tt> : <tt>$_terms[] = $term-&gt;term_id</tt>
</li><li><tt>id=&gt;parent</tt> : <tt>$_terms[$term-&gt;term_id] = $term-&gt;parent</tt>
</li><li><tt>names</tt> : <tt>$_terms[] = $term-&gt;name</tt>
</li><li><tt>id=&gt;name</tt> : <tt>$_terms[$term-&gt;term_id] = $term-&gt;name</tt>
</li><li><tt>id=&gt;slug</tt> : <tt>$_terms[$term-&gt;term_id] = $term-&gt;slug</tt>
</li></ul><p>
And that renders callbacks to both attached filters useless. The only cases where this does not happen are the argument values <tt>all</tt> and <tt>count</tt>.
</p>
<p>
I'm not sure if this should be called an "undocumented feature" or if this actually needs a patch. I'm in for later if there is support for changing this awkward behavior as this is not clear until one jumps and dumps in core.
</p>
<p>
Proposed fix: Only run the final filter-loop if ...
</p>
<pre class="wiki">if ( ! (
has_filter( 'get_terms_fields' ) or has_filter( 'terms_clauses' )
) )
// do final filtering
</pre>F J Kaiserhttps://core.trac.wordpress.org/ticket/31174
https://core.trac.wordpress.org/ticket/31174Report#31381: The theme details modal has scrolling and toolbar problems on iPhone 6 and 6+Thu, 19 Feb 2015 16:02:41 GMTMon, 02 Mar 2015 16:19:35 GMT<p>
Visit themes.php on an iPhone 6 or 6+. Tap a theme to bring up the details modal. Note that the modal's nav buttons are beneath the toolbar. Scrolling is very awkward, and the toolbar detaches from the top and follows your finger. This screen is very difficult to use.
</p>
ryanhttps://core.trac.wordpress.org/ticket/31381
https://core.trac.wordpress.org/ticket/31381Report#30619: The wpView toolbar is not accessible by keyboardSun, 07 Dec 2014 00:01:53 GMTMon, 02 Mar 2015 18:52:11 GMT<p>
The (new) image toolbar is fully accessible by keyboard (Alt+F8 to focus, then arrow keys to move to the next button, etc.). However the wpView toolbar is not build in the same way so it is still not accessible.
</p>
azaozzhttps://core.trac.wordpress.org/ticket/30619
https://core.trac.wordpress.org/ticket/30619Report#12120: Thumbnail image isn't created if the original is too smallWed, 03 Feb 2010 17:53:32 GMTFri, 30 Jan 2015 14:56:14 GMT<p>
It would be very useful to force the generation of a thumbnail images for uploaded files. With content being syndicated to feeds, e-readers, and mobile devices, the ability to have a working thumbnail is more important.
</p>
<p>
For example, if the original image has dimensions of 250x50, and the default thumbnail size in WP is 150x150, a thumbnail will not be generated because the 50 height is smaller than the 150 pixel minimum.
</p>
<p>
The fix would be to include an additional parameter to the image_resize_dimensions to allow the function the dimensions. A filter could be applied to allow the user to set which images should force the generation of a resized image (i.e. to exclude a medium and large image from being generated for a 250x50 image) by passing in the original width/height and max width/height.
</p>
<p>
in wp-includes/media.php
</p>
<p>
========
</p>
<pre class="wiki">function image_resize( $file, $max_w, $max_h, $crop = false, $suffix = null, $dest_path = null, $jpeg_quality = 90 ) {
...
$force = apply_filters('image_resize_dimensions_force', $orig_w, $orig_h, $max_w, $max_h);
$dims = image_resize_dimensions($orig_w, $orig_h, $max_w, $max_h, $crop, $force);
</pre><p>
========
</p>
<pre class="wiki">function image_resize_dimensions($orig_w, $orig_h, $dest_w, $dest_h, $crop = false, $force = false) {
...
// if the resulting image would be the same size or larger we don't want to resize it
if ( $new_w &gt;= $orig_w &amp;&amp; $new_h &gt;= $orig_h &amp;&amp; !$force )
return false;
</pre>atowhttps://core.trac.wordpress.org/ticket/12120
https://core.trac.wordpress.org/ticket/12120Report#31480: TinyMCE resize sandbox iFrame when images loadFri, 27 Feb 2015 20:49:52 GMTFri, 27 Feb 2015 21:00:06 GMT<p>
Possible bug - If an MCE View contains an image, and the view is sandboxed, the iFrame is not resized correctly to fit the image.
</p>
<p>
The reason for this is that the iFrame is resized using a MutationObserver. This is only triggered when a new element is inserted, or an attribute changes. But not when an image loads.
</p>
<p>
Fix - do resize on image load event. This could be done very simply like so:
</p>
<pre class="wiki">$( iframeDoc.body ).find('img').load( resize );
</pre><p>
However
</p>
<ul><li>This functionality would need to be duplicated inside the MutationObserver callback to handle any images that are added later.
</li><li>I noticed that we can't rely on the MutationObserver callback alone because this is set up AFTER the iframe is created and the content added.
</li></ul><p>
I think the solution here should be
</p>
<ol><li>In the mutation observer calback we should check for new image elements, and trigger <tt>resize</tt> when that image loads.
</li><li>Set the mutation observer BEFORE the content is added to the iFrame so this gets triggered by the main preview body content. To do this the MutationObserver needs to observe <tt>iframeDoc</tt> and not <tt>iframeDoc.body</tt>
</li></ol><p>
Any thoughts?
</p>
mattheuhttps://core.trac.wordpress.org/ticket/31480
https://core.trac.wordpress.org/ticket/31480Report#31170: TinyMCE view edit tooltip can conflict with TinyMCE tollbarWed, 28 Jan 2015 22:57:33 GMTWed, 25 Feb 2015 23:51:24 GMT<p>
See screenshot:
</p>
<p>
<a style="padding:0; border:none" href="https://dl.dropboxusercontent.com/s/sejq4amcfvq1cmk/2015-01-28%20at%202.50%20PM.png?dl=0"><img src="https://dl.dropboxusercontent.com/s/sejq4amcfvq1cmk/2015-01-28%20at%202.50%20PM.png?dl=0" alt="https://dl.dropboxusercontent.com/s/sejq4amcfvq1cmk/2015-01-28%20at%202.50%20PM.png" title="https://dl.dropboxusercontent.com/s/sejq4amcfvq1cmk/2015-01-28%20at%202.50%20PM.png" /></a>
</p>
<p>
This particular view was added with Shortcake, so it might be a problem there. I can reproduce somewhat consistently when I switch between HTML and Visual.
</p>
<p>
Previously: <a class="ext-link" href="https://github.com/fusioneng/Shortcake/issues/84"><span class="icon">​</span>https://github.com/fusioneng/Shortcake/issues/84</a>
</p>
danielbachhuberhttps://core.trac.wordpress.org/ticket/31170
https://core.trac.wordpress.org/ticket/31170Report#31412: TinyMCE views improvementsSun, 22 Feb 2015 09:44:31 GMTFri, 27 Feb 2015 22:28:59 GMT<p>
I'm going to use this ticket to propose some improvements to the mce views API, instead of adding this to <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29841" title="defect (bug): Don't replace non embeddable URLs with a loading placeholder (closed: fixed)">#29841</a>.
</p>
<ul><li>Give views the option to display a loader or not. See <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29841" title="defect (bug): Don't replace non embeddable URLs with a loading placeholder (closed: fixed)">#29841</a>. We can mark the paragraph and replace it later based on this option. To the user it will look as if nothing happened until there is a match. This is very useful for oEmbed.
</li><li>Remove the <tt>wrap</tt> and <tt>replace</tt> options from <tt>setContent</tt>.
</li><li>Better edit function. Now it's part of the instance, so no need to look at the node for the encoded text. You can call the function provided to refresh the view, no need to touch the DOM any more. You can see the edit functions of the core views are a lot simpler.
</li><li>The gallery and av views now reuse the same edit function.
</li><li>Simpler registration.
</li><li><tt>setContent</tt> will call <tt>setIframes</tt> itself if needed.
</li><li>Selecting another view will pause all players. We could also limit this to the same view type or a set of view types. This allows us to remove a lot of code.
</li><li>Better documentation (though it could be better still).
</li><li>Move the main API to the top of the file.
</li><li>Wrap the view registration in a separate IIFE. Ideally this should go in a separate file.
</li><li>The <tt>render</tt> method is easier to override.
</li><li>Better detection of already rendered views, so we don't unnecessarily refresh views.
</li><li>I added a proper <tt>setLoader</tt> method, just like <tt>setError</tt>.
</li><li>All options set in <tt>toView</tt> are now added as properties of the instance.
</li></ul><p>
I will do some more testing.
Suggestion are welcome.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/31412
https://core.trac.wordpress.org/ticket/31412Report#30968: Title box being partially cropped at the bottom for add/edit post screen on any non-public post type.Fri, 09 Jan 2015 16:00:17 GMTSun, 22 Feb 2015 04:21:44 GMT<p>
When creating or editing any post of a non-public post type, (e.g. when the permalink section below the title is not visible), the post title box gets partially cropped at the bottom. This results in two minor visual issues (i've attached screenshots):
</p>
<ol><li>When the title field is not focused, the border bottom is not visible - <tt>1.jpg</tt>.
</li><li>When the title field is focused, the border bottom and the bottom highlight (box shadow) is not visible - <tt>2.jpg</tt>.
</li></ol><p>
This issue occurs only in the trunk version, and not in <tt>4.1</tt>.
</p>
<p>
In order to replicate the issue, you can use the code from the <tt>Elaborate</tt> example of the <tt>register_post_type()</tt> function in the Codex: <a class="ext-link" href="http://codex.wordpress.org/Function_Reference/register_post_type#Example"><span class="icon">​</span>http://codex.wordpress.org/Function_Reference/register_post_type#Example</a> . You simply have to change the <tt>public</tt> to <tt>false</tt> to make the post type non-public.
</p>
tyxlahttps://core.trac.wordpress.org/ticket/30968
https://core.trac.wordpress.org/ticket/30968Report#22839: Toggle spinners by adding/removing a class instead of show()/hide()Sun, 09 Dec 2012 18:17:02 GMTFri, 13 Feb 2015 16:06:13 GMT<p>
I've noticed a bug with the spinner while updating a previous submission (<a class="accepted ticket" href="https://core.trac.wordpress.org/ticket/19159" title="enhancement: When Inactive Widgets list gets long it is hard to clear (accepted)">ticket:19159</a>). It worked in 3.4 when .ajax-feedback was used instead of .spinner.
</p>
<p>
Elements with class .spinner don't show up in any .sidebar-name (e.g. Main Sidebar, Inactive Widgets etc.) when an action is in progress (e.g. clearing inactive widgets).
</p>
cdoghttps://core.trac.wordpress.org/ticket/22839
https://core.trac.wordpress.org/ticket/22839Report#30596: Transparent background of .png not preserved when rotating pictureThu, 04 Dec 2014 16:15:14 GMTTue, 13 Jan 2015 14:29:13 GMT<p>
Rotating .png picture with transparent background does not preserve transparency. Resulting picture has partially black background.
</p>
frankpwhttps://core.trac.wordpress.org/ticket/30596
https://core.trac.wordpress.org/ticket/30596Report#31499: Trim non-breaking spaces from URLsMon, 02 Mar 2015 06:29:50 GMTMon, 02 Mar 2015 06:34:37 GMT<p>
If a link to a WordPress site has a non-breaking space on the end of it, WordPress will give a 404, instead of showing the page. Refreshing the page (allowing the browser to trim the space) causes the page to load correctly.
</p>
pentohttps://core.trac.wordpress.org/ticket/31499
https://core.trac.wordpress.org/ticket/31499Report#31250: Twenty Fifteen editor styles look weird on mobileFri, 06 Feb 2015 16:16:10 GMTSun, 01 Mar 2015 16:15:58 GMT<p>
It doesn't look at all like what the front-end looks like.
Text is padded too much to the right.
Images are not resized to fit which causes the iframe to expand (off screen). There's no way to scroll horizontally and the editor is completely useless.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/31250
https://core.trac.wordpress.org/ticket/31250Report#30891: Unchecked property overloading is detrimental to OOP.Sat, 03 Jan 2015 12:57:02 GMTMon, 12 Jan 2015 16:25:30 GMT<p>
Original Summary: Unchecked property overloading is detrimental to OOP.
</p>
<p>
<a class="ext-link" href="http://php.net/manual/en/language.oop5.overloading.php#language.oop5.overloading.members"><span class="icon">​</span>Property</a> and <a class="ext-link" href="http://php.net/manual/en/language.oop5.overloading.php#language.oop5.overloading.methods"><span class="icon">​</span>Method</a> overloading (allowed by magic methods __get, __set, __isset, __unset, and __call) have been thoroughly introduced into WP code for Backward Compatibility, maybe starting from Changeset/21512, but mostly since version 4.0.0.
</p>
<p>
The copy-&amp;-paste-d code I'm referring to is:
</p>
<div class="code"><pre><span class="x"> /**
* Make private properties readable for backwards compatibility.
*
* @since 4.0.0
* @access public
*
* @param string $name Property to get.
* @return mixed Property.
*/
public function __get( $name ) {
return $this-&gt;$name;
}
/**
* Make private properties settable for backwards compatibility.
*
* @since 4.0.0
* @access public
*
* @param string $name Property to set.
* @param mixed $value Property value.
* @return mixed Newly-set property.
*/
public function __set( $name, $value ) {
return $this-&gt;$name = $value;
}
/**
* Make private properties checkable for backwards compatibility.
*
* @since 4.0.0
* @access public
*
* @param string $name Property to check if set.
* @return bool Whether the property is set.
*/
public function __isset( $name ) {
return isset( $this-&gt;$name );
}
/**
* Make private properties un-settable for backwards compatibility.
*
* @since 4.0.0
* @access public
*
* @param string $name Property to unset.
*/
public function __unset( $name ) {
unset( $this-&gt;$name );
}
/**
* Make private/protected methods readable for backwards compatibility.
*
* @since 4.0.0
* @access public
*
* @param callable $name Method to call.
* @param array $arguments Arguments to pass when calling.
* @return mixed|bool Return value of the callback, false otherwise.
*/
public function __call( $name, $arguments ) {
return call_user_func_array( array( $this, $name ), $arguments );
}
</span></pre></div><p>
Unchecked overloading (i.e. lazy programming) is detrimental to OOP because it neutralizes all protections. No matter what, all properties and methods of classes with unchecked overloading are always public.
</p>
<p>
I mean, not only legacy properties and methods that existed before introducing unchecked overloading but also all others that <strong>were, are being and will be</strong> introduced afterward and really meant to be private or protected.
</p>
<p>
This is a very important issue, whose implications will be appreciated in the future. Currently, it all seems fine, but it's an illusion. As time goes by, on one side the WP core will continue to migrate to PHP5 (and its access rules) and on the other side theme and plugin hackers will continue to squeeze WP as much as possible. When core developers introduce protection for new properties and methods, they expect that protection to be taken into account by the ecosystem, and finally by theme and plugin developers, which are the ones those protections were thought for. BUT if WP theme plugin and core developers will always be able to access whatever they want as they please, then I wonder why PHP5 protections were introduced in the first place.
</p>
<p>
Here is a tedious but simple fix (i.e. checked overloading):
</p>
<div class="code"><pre><span class="x">if (! array_key_exists($name, $this-&gt;legacy_properties)) {
$trace = debug_backtrace();
trigger_error('Undefined property' ..., E_USER_NOTICE);
}
// rest of __get, __set, __isset, __unset code here
</span></pre></div><div class="code"><pre><span class="x">if (! array_key_exists($name, $this-&gt;legacy_methods)) {
$trace = debug_backtrace();
trigger_error('Call to undefined method' ..., E_USER_ERROR);
}
// rest of __call code here
</span></pre></div><p>
If this issue is not fixed ASAP, developers will find these "backdoors" and start to use them. Then it gets worse.
</p>
aercolinohttps://core.trac.wordpress.org/ticket/30891
https://core.trac.wordpress.org/ticket/30891Report#31432: Unit tests are sensitive to line endingsTue, 24 Feb 2015 11:05:07 GMTTue, 24 Feb 2015 14:59:37 GMT<p>
Currently, patching unit test files with <tt>grunt patch</tt> on Windows changes line endings.
</p>
<p>
This results in unexpected failures in some tests using the heredoc syntax (<tt>&lt;&lt;&lt;</tt>), see <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/31340" title="defect (bug): Use of the @subpackage tag in documentation (closed: invalid)">#31340</a>.
</p>
<p>
We should probably set <tt>svn:eol-style</tt> to native for test files, like we did for core, and do something like <tt>str_replace( "\r\n", "\n", ... )</tt> in the tests with heredoc.
</p>
SergeyBiryukovhttps://core.trac.wordpress.org/ticket/31432
https://core.trac.wordpress.org/ticket/31432Report#25244: Unminified versions of MediaElement.js and MediaElementPlayer not in coreFri, 06 Sep 2013 18:52:30 GMTFri, 30 Jan 2015 16:17:54 GMT<p>
Not sure how this fits into the new Grunt build process so I'll leave this to the big boys/girls.
</p>
ericlewishttps://core.trac.wordpress.org/ticket/25244
https://core.trac.wordpress.org/ticket/25244Report#31488: Update grunt-contrib-jshint to v0.11.0Sat, 28 Feb 2015 06:55:03 GMTSat, 28 Feb 2015 09:46:41 GMT<p>
Upstream changes:
</p>
<ul><li><a class="ext-link" href="https://github.com/gruntjs/grunt-contrib-jshint/compare/v0.10.0...v0.11.0"><span class="icon">​</span>https://github.com/gruntjs/grunt-contrib-jshint/compare/v0.10.0...v0.11.0</a>
</li></ul><p>
Patch includes adding <tt>JSON</tt> to <tt>globals</tt> ignore in <tt>.jshintrc</tt> which avoids the errors below.
</p>
<hr />
<p>
Updating to v0.11.0 results in the following Core errors during <tt>grunt jshint:core</tt>
</p>
<div class="code"><pre>
src/wp-admin/js/customize-controls.js
2348 | customized: JSON.stringify<span class="o">(</span> dirtyCustomized <span class="o">)</span>,
^ <span class="s1">'JSON'</span> is not defined.
src/wp-admin/js/customize-widgets.js
1025 | data +<span class="o">=</span> <span class="s1">'&amp;'</span> + <span class="nv">$.</span>param<span class="o">(</span> <span class="o">{</span> <span class="s1">'sanitized_widget_setting'</span>: JSON.stringify<span class="o">(</span> instanceOverride <span class="o">)</span> <span class="o">}</span> <span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
src/wp-admin/js/image-edit.js
114 | <span class="nb">history</span> <span class="o">=</span> JSON.parse<span class="o">(</span><span class="nb">history</span><span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
151 | <span class="k">return </span>JSON.stringify<span class="o">(</span>op<span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
274 | var <span class="nv">ret</span> <span class="o">=</span> JSON.parse<span class="o">(</span>r<span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
410 | <span class="k">$(</span><span class="s1">'#imgedit-selection-'</span> + postid<span class="k">)</span>.val<span class="o">(</span> JSON.stringify<span class="o">(</span>sel<span class="o">)</span> <span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
442 | <span class="nb">history</span> <span class="o">=</span> <span class="o">(</span> h !<span class="o">==</span> <span class="s1">''</span> <span class="o">)</span> ? JSON.parse<span class="o">(</span>h<span class="o">)</span> : <span class="o">[]</span>,
^ <span class="s1">'JSON'</span> is not defined.
456 | <span class="nb">history</span> <span class="o">=</span> <span class="o">(</span> elem.val<span class="o">()</span> !<span class="o">==</span> <span class="s1">''</span> <span class="o">)</span> ? JSON.parse<span class="o">(</span> elem.val<span class="o">()</span> <span class="o">)</span> : <span class="o">[]</span>,
^ <span class="s1">'JSON'</span> is not defined.
467 | elem.val<span class="o">(</span> JSON.stringify<span class="o">(</span><span class="nb">history</span><span class="o">)</span> <span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
500 | <span class="nv">sel</span> <span class="o">=</span> JSON.parse<span class="o">(</span>sel<span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
519 | <span class="nb">history</span> <span class="o">=</span> <span class="o">(</span> elem.val<span class="o">()</span> !<span class="o">==</span> <span class="s1">''</span> <span class="o">)</span> ? JSON.parse<span class="o">(</span> elem.val<span class="o">()</span> <span class="o">)</span> : <span class="o">[]</span>;
^ <span class="s1">'JSON'</span> is not defined.
src/wp-includes/js/autosave.js
124 | <span class="nv">stored_obj</span> <span class="o">=</span> JSON.parse<span class="o">(</span> stored_obj <span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
145 | sessionStorage.setItem<span class="o">(</span> key, JSON.stringify<span class="o">(</span> stored_obj <span class="o">)</span> <span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
src/wp-includes/js/customize-base.js
578 | <span class="nv">message</span> <span class="o">=</span> JSON.parse<span class="o">(</span> event.data <span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
603 | this.targetWindow<span class="o">()</span>.postMessage<span class="o">(</span> JSON.stringify<span class="o">(</span> message <span class="o">)</span>, this.origin<span class="o">()</span> <span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
src/wp-includes/js/plupload/wp-plupload.js
260 | <span class="nv">response</span> <span class="o">=</span> JSON.parse<span class="o">(</span> response.response <span class="o">)</span>;
^ <span class="s1">'JSON'</span> is not defined.
&gt;&gt; 16 errors in 78 files
Warning: Task <span class="s2">"jshint:core"</span> failed. Use --force to <span class="k">continue</span>.
</pre></div>netwebhttps://core.trac.wordpress.org/ticket/31488
https://core.trac.wordpress.org/ticket/31488Report#31343: Update grunt-sass to 0.18.0Mon, 16 Feb 2015 10:15:27 GMTFri, 27 Feb 2015 23:50:54 GMT<p>
Upstream changes:
</p>
<ul><li>grunt-sass: <a class="ext-link" href="https://github.com/sindresorhus/grunt-sass/compare/v0.16.0...v0.18.0"><span class="icon">​</span>https://github.com/sindresorhus/grunt-sass/compare/v0.16.0...v0.18.0</a>
</li><li>node-sass: <a class="ext-link" href="https://github.com/sass/node-sass/compare/v1.0.3...v2.0.0"><span class="icon">​</span>https://github.com/sass/node-sass/compare/v1.0.3...v2.0.0</a>
<ul><li>Node v2.0: Release notes: <a class="ext-link" href="https://github.com/sass/node-sass/releases/tag/v2.0.0"><span class="icon">​</span>https://github.com/sass/node-sass/releases/tag/v2.0.0</a>
</li><li>libsass v3.1: Release notes <a class="ext-link" href="https://github.com/sass/libsass/releases/tag/3.1.0"><span class="icon">​</span>https://github.com/sass/libsass/releases/tag/3.1.0</a>
</li><li>node.js v0.12 (stable) support (while keeping the v0.10 compatibility)
<ul><li>NodeJS v0.12 (stable) released 6th Feb 2015 <a class="ext-link" href="http://blog.nodejs.org/2015/02/06/node-v0-12-0-stable/"><span class="icon">​</span>http://blog.nodejs.org/2015/02/06/node-v0-12-0-stable/</a>
</li></ul></li></ul></li></ul><hr />
<p>
With the changes in <tt>_admin.scss</tt> in the included patch there is no difference to any file in <tt>/build</tt> folder after running <tt>grunt build</tt> or <tt>grunt precommit</tt>.
</p>
<p>
The addition of the leading zero is due to the upstream issue in <a class="ext-link" href="https://github.com/sass/libsass/issues/623"><span class="icon">​</span>libsass/issues/623</a>, this is fixed as part of libsass v3.1.
</p>
<p>
Without the changes all the <tt>colors.css</tt> files (MP6) result in changes for each e.g:
</p>
<div xmlns="http://www.w3.org/1999/xhtml" class="diff">
<ul class="entries">
<li class="entry">
<h2>
<a>build/wp-admin/css/colors/sunrise/colors.css</a>
</h2>
<table class="trac-diff inline" summary="Differences" cellspacing="0">
<colgroup><col class="lineno" /><col class="lineno" /><col class="content" /></colgroup>
<thead>
<tr>
<th title="File build/wp-admin/css/colors/sunrise/colors.css">
</th>
<th title="File build/wp-admin/css/colors/sunrise/colors.css">
</th>
<td><em> ul#adminmenu a.wp-has-current-submenu:after, ul#adminmenu &gt; li.current &gt; a.curre</em> </td>
</tr>
</thead>
<tbody class="unmod">
<tr>
<th>218</th><th>218</th><td class="l"><span></span> </td>
</tr><tr>
<th>219</th><th>219</th><td class="l"><span>#wpadminbar #adminbarsearch .adminbar-input::-webkit-input-placeholder {</span> </td>
</tr><tr>
<th>220</th><th>220</th><td class="l"><span>&nbsp; color: #fff;</span> </td>
</tr>
</tbody><tbody class="mod">
<tr class="first">
<th>221</th><th> </th><td class="l"><span>&nbsp; opacity: <del></del>.7; }</span> </td>
</tr>
<tr class="last">
<th> </th><th>221</th><td class="r"><span>&nbsp; opacity: <ins>0</ins>.7; }</span> </td>
</tr>
</tbody>
</table>
</li>
</ul>
</div>netwebhttps://core.trac.wordpress.org/ticket/31343
https://core.trac.wordpress.org/ticket/31343Report#31505: Update HoverIntent Library to latest version (v1.80)Mon, 02 Mar 2015 15:23:56 GMTTue, 03 Mar 2015 12:03:02 GMT<p>
WordPress 4.1 ships with HoverIntent <a class="changeset" href="https://core.trac.wordpress.org/changeset/7" title="Fixed whitespace error, cleaned some formatting. Improved grammer on error ...">r7</a> (released in 2013). Version 1.80 (released in 2014) fixes a number of bugs.
</p>
<p>
Info on latest version: <a class="ext-link" href="http://cherne.net/brian/resources/jquery.hoverIntent.html"><span class="icon">​</span>http://cherne.net/brian/resources/jquery.hoverIntent.html</a>
</p>
<p>
Minified script: <a class="ext-link" href="http://cherne.net/brian/resources/jquery.hoverIntent.minified.js"><span class="icon">​</span>http://cherne.net/brian/resources/jquery.hoverIntent.minified.js</a>
</p>
lovememorehttps://core.trac.wordpress.org/ticket/31505
https://core.trac.wordpress.org/ticket/31505Report#31489: Update NPM Grunt packages: compress, concat, copy, imagemin and uglifySat, 28 Feb 2015 09:04:54 GMTSat, 28 Feb 2015 22:10:35 GMT<ul><li><tt>grunt-contrib-compress</tt> v0.13.0:
<ul><li><a class="ext-link" href="https://github.com/gruntjs/grunt-contrib-compress/compare/v0.12.0...b17adac"><span class="icon">​</span>https://github.com/gruntjs/grunt-contrib-compress/compare/v0.12.0...b17adac</a>
</li></ul></li><li><tt>grunt-contrib-concat</tt> v0.5.1:
<ul><li><a class="ext-link" href="https://github.com/gruntjs/grunt-contrib-concat/compare/v0.5.0...v0.5.1"><span class="icon">​</span>https://github.com/gruntjs/grunt-contrib-concat/compare/v0.5.0...v0.5.1</a>
</li></ul></li><li><tt>grunt-contrib-copy</tt> v0.8.0:
<ul><li><a class="ext-link" href="https://github.com/gruntjs/grunt-contrib-copy/compare/v0.7.0...v0.8.0"><span class="icon">​</span>https://github.com/gruntjs/grunt-contrib-copy/compare/v0.7.0...v0.8.0</a>
</li></ul></li><li><tt>grunt-contrib-imagemin</tt> v0.9.3:
<ul><li><a class="ext-link" href="https://github.com/gruntjs/grunt-contrib-imagemin/compare/v0.9.1...v0.9.3"><span class="icon">​</span>https://github.com/gruntjs/grunt-contrib-imagemin/compare/v0.9.1...v0.9.3</a>
</li></ul></li><li><tt>grunt-contrib-uglify</tt> v~0.8.0:
<ul><li><a class="ext-link" href="https://github.com/gruntjs/grunt-contrib-uglify/compare/v0.6.0...v0.8.0"><span class="icon">​</span>https://github.com/gruntjs/grunt-contrib-uglify/compare/v0.6.0...v0.8.0</a>
</li></ul></li></ul><p>
Each of these packages updates results in no change to the <tt>/build</tt> folder via <tt>grunt build</tt> or <tt>/src</tt> folder via <tt>grunt precommit</tt>
</p>
netwebhttps://core.trac.wordpress.org/ticket/31489
https://core.trac.wordpress.org/ticket/31489Report#31424: Update star rating colorsMon, 23 Feb 2015 17:36:46 GMTWed, 25 Feb 2015 18:46:59 GMT<p>
Stars in core currently use color scheme highlight colors. This doesn't extend well to outside of core, leading to inconsistencies on WordPress.org. Let's unify all of the star rating colors by making them yellow. I proposed <tt>#e6b800</tt> for the WordPress.org website, but I know @hugobaeta is working on a style guide and might have a better option, so I'd like his input before going forward with this.
</p>
<p>
Initial star conversation here: <a class="ext-link" href="https://wordpress.slack.com/archives/meta/p1424556348001331"><span class="icon">​</span>https://wordpress.slack.com/archives/meta/p1424556348001331</a>
Follow-up here: <a class="ext-link" href="https://wordpress.slack.com/archives/meta/p1424711870001375"><span class="icon">​</span>https://wordpress.slack.com/archives/meta/p1424711870001375</a>
</p>
melchoycehttps://core.trac.wordpress.org/ticket/31424
https://core.trac.wordpress.org/ticket/31424Report#31459: Update WP-admin ButtonsThu, 26 Feb 2015 02:02:33 GMTMon, 02 Mar 2015 00:40:46 GMT<p>
Following the work done on ticket <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/31234" title="task (blessed): Update wp-admin default colors (closed: fixed)">#31234</a>, the buttons needed some updating as well to comply to the new default color scheme.
</p>
<p>
Used the opportunity to evolve the style of the buttons ever so slightly to match everything else better (removal of the 1px light inset box-shadow on the top, for example).
</p>
<p>
Here's a comparisson:
</p>
<p>
<a style="padding:0; border:none" href="http://cl.ly/image/2x351c0H3F1q/admin-buttons-old-new.png"><img src="http://cl.ly/image/2x351c0H3F1q/admin-buttons-old-new.png" alt="http://cl.ly/image/2x351c0H3F1q/admin-buttons-old-new.png" title="http://cl.ly/image/2x351c0H3F1q/admin-buttons-old-new.png" /></a>
</p>
hugobaetahttps://core.trac.wordpress.org/ticket/31459
https://core.trac.wordpress.org/ticket/31459Report#9777: Usability : add delete button to edit-tags.phpSat, 09 May 2009 22:56:39 GMTFri, 13 Feb 2015 17:10:59 GMT<p>
Add "delete" button to "edit category" menu so i can delete the category and not only edit it. this is a very useful feature that is missing in this menu.
</p>
<p>
<strong>LOCATION:</strong>
</p>
<p>
Admin -&gt; Posts -&gt; Categories -&gt; Edit Category
</p>
<p>
<strong>URL:</strong>
</p>
<p>
<a class="ext-link" href="http://www.site.org/wp-admin/categories.php?action=edit&amp;cat_ID=302"><span class="icon">​</span>http://www.site.org/wp-admin/categories.php?action=edit&amp;cat_ID=302</a>
</p>
ramiyhttps://core.trac.wordpress.org/ticket/9777
https://core.trac.wordpress.org/ticket/9777Report#31006: Use classes instead of setting and directly animating background colors in JSWed, 14 Jan 2015 05:32:10 GMTThu, 29 Jan 2015 12:28:47 GMT<p>
Directly setting hex values in JS doesn't tell us much about what the color is being used for, whereas setting a class name is much more semantic. Also, jQuery UI can animate color changes when using addClass/removeClass/toggleClass/switchClass - no need to use .animate() directly and do things like getting background colors of surrounding elements.
</p>
<p>
This is very tightly related to <a class="assigned ticket" href="https://core.trac.wordpress.org/ticket/25060" title="defect (bug): Quick Edit Comments inline edit save breaks the alternating table row ... (assigned)">#25060</a> and blocks it. I am working on it.
</p>
helenhttps://core.trac.wordpress.org/ticket/31006
https://core.trac.wordpress.org/ticket/31006Report#29804: Use HR instead of IMG as a placeholder for the more and nextpage tagsMon, 29 Sep 2014 20:23:14 GMTSun, 22 Feb 2015 16:25:56 GMT<p>
Read more here: <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28335" title="defect (bug): More tag can't be inserted if inside div (closed: wontfix)">#28335</a>.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/29804
https://core.trac.wordpress.org/ticket/29804Report#22895: user_can_admin_menu() is Type-Insensitive for Users who Can't Create PagesWed, 12 Dec 2012 18:32:53 GMTFri, 13 Feb 2015 17:04:30 GMT<p>
Utilization of the new separation edit_posts /create_posts capability separation reveals a flaw in admin menu privilege checking.
</p>
<p>
The issue occurs when:
</p>
<ol><li>For any post type other the "post", the user has $type-&gt;cap-&gt;edit_posts but not $type-&gt;cap-&gt;create_posts
</li></ol><ol start="2"><li>User also does not have a manage_terms capability for any associated taxonomies
</li></ol><p>
In that situation, access to "edit.php?post_type=whatever" fails unless the user has the "edit_posts" cap for the "post" type.
</p>
<p>
This occurs because:
</p>
<ol><li><strong>wp-admin/includes/menu.php</strong> removes solitary submenus that have the same destination as the parent
</li></ol><ol start="2"><li><strong>get_admin_page_parent()</strong> returns nullstring if there is no $submenu item
</li></ol><ol start="3"><li><strong>user_can_access_admin_page()</strong> performs a type-sensitive capability check only if get_admin_page_parent() returns an existing $submenu key.
</li></ol><p>
For now, my plugin workaround is to hook into 'admin_menu' and add a dummy submenu with nullstring caption.
</p>
kevinBhttps://core.trac.wordpress.org/ticket/22895
https://core.trac.wordpress.org/ticket/22895Report#31183: Users with "update_plugins" capability can not see update detailsFri, 30 Jan 2015 13:19:09 GMTWed, 18 Feb 2015 16:42:34 GMT<p>
Users with the "update_plugins" capability can see available updates for plugins, but see the message "You do not have sufficient permissions" when clicking on "View version x.y.z details", because that page requires the "install_plugins" capability. The details page (with changelog, etc) should also be available with only the "update_plugins" capability.
</p>
michel.weimerskirchhttps://core.trac.wordpress.org/ticket/31183
https://core.trac.wordpress.org/ticket/31183Report#30998: Widgets helper position incorrect after moving out of the sidebarTue, 13 Jan 2015 07:42:15 GMTFri, 27 Feb 2015 16:35:43 GMT<p>
How to replicate:
1) drag a widget to the sidebar in the widgets.php page without dropping on the sidebar
2) move the helper (widget clone) to somewhere else, moving out of the sidebar and you will see that the helper is in far from the mouse cursor.
</p>
<p>
Current version: 4.2-alpha-31007-src
The bug is present in the 4.1 version too.
</p>
<p>
Chrome 39.0.2171.95 m version, Windows 7 32bit.
</p>
<p>
I uploaded a video with my camera on youtube of the screen of my pc where I show the problem - <a class="ext-link" href="https://www.youtube.com/watch?v=WzKMaY0VhNg"><span class="icon">​</span>https://www.youtube.com/watch?v=WzKMaY0VhNg</a>
</p>
alexvorn2https://core.trac.wordpress.org/ticket/30998
https://core.trac.wordpress.org/ticket/30998Report#31484: Widgets in Customizer during theme preview fail to preview widgets with prior sidebars_widgets theme mod and fail to apply upon activationFri, 27 Feb 2015 23:02:11 GMTTue, 03 Mar 2015 12:13:41 GMT<p>
When testing the new Theme Switcher in the Customizer, I noticed when previewing another theme that the widget controls appearing in the Widgets panel were sometimes largely appearing as inactive (partially transparent) and the widgets appearing in the Customizer preview did not correspond to the widget controls I saw in the Widgets pane. In fact, the widgets in the Panel reflected the widgets that were actually from the previously-cached widgets configuration (via <tt>retrieve_widgets()</tt> and stored in the <tt>sidebars_widgets</tt> theme mod), but the widgets appearing in the Customizer preview corresponded to the widget configuration in the currently-active theme.
</p>
<p>
The problem was introduced in WordPress 4.1, specifically in <a class="changeset" href="https://core.trac.wordpress.org/changeset/29905" title="Customizer: Only POST dirty settings to preview to improve performance.
...">r29905</a> for <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29983" title="enhancement: Only POST dirty settings to Customizer preview to improve performance (closed: fixed)">#29983</a>, since we're no longer posting all of the settings from the Customizer pane to the preview for performance reasons: only the changed (dirty) settings get POSTed to the Preview when it is loaded.
</p>
<p>
Additionally, when attempting to activate the previous theme that had a cached widgets configuration in the <tt>sidebars_widgets</tt> theme mod, this prior configuration is not getting restored when activating the previously-active theme: the sidebar configuration from the current theme is overwriting the previous theme's configuration. I believe this is due to the <tt>old_sidebars_widgets_data</tt> not being marked as dirty, and so it is not being submitted when saving the settings.
</p>
<p>
Steps to reproduce:
</p>
<ol><li>Activate Twenty Fourteen via the Themes admin page
</li><li>Add multiple widgets to each sidebar via the Widgets admin page; let them have "2014" in their titles
</li><li>Activate Twenty Thirteen via the Themes admin page
</li><li>Add multiple widgets to each sidebar (Main Widget Area, Secondary Widget Area) via the Widgets admin page; let them have "2013" in their titles
</li><li>Try switching between Twenty Thirteen and Twenty Fourteen and note each theme's respective sidebar configurations.
</li><li>Switch back to Twenty Fourteen via the Themes admin page.
</li><li>Live-preview the Twenty Thirteen theme either via the Themes admin page, or via the new Customizer theme previewer
</li><li>Open the Widgets panel and note that the widgets listed are correctly those for Twenty Thirteen, but notice in the Preview that the widgets from Twenty Fourteen are unexpectedly showing.
</li><li>Press *Save &amp; Activate* when redirected to the frontend with the Twenty Thirteen theme active, notice that the Twenty Fourteen widgets are incorrectly shown.
</li></ol><p>
For previous issues related to widgets in the Customizer being lost during a theme switch, see <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/27897" title="defect (bug): Theme preview empties sidebar on active theme (closed: fixed)">#27897</a>.
</p>
westonruterhttps://core.trac.wordpress.org/ticket/31484
https://core.trac.wordpress.org/ticket/31484Report#30325: WP List Table: allow filtering view switcher modesWed, 12 Nov 2014 19:21:48 GMTSat, 31 Jan 2015 19:53:05 GMT<p>
I suggest the view mode switcher for post/media/site list views should be filterable, so it's possible to:
</p>
<ul><li>add additional, custom view modes (especially for custom post types)
</li><li>filter available view modes
</li><li>remove view modes completely (effectively removing the switcher from HTML)
</li></ul><p>
This would allow developers to customise the switcher for different custom post types. At the moment, this is impossible - and in some cases the switcher may make no sense or have no effect at all, if a specific mode isn't implemented.
</p>
ragulkahttps://core.trac.wordpress.org/ticket/30325
https://core.trac.wordpress.org/ticket/30325Report#31492: wp-admin/post.php > sendback URL generated through string concatenationSat, 28 Feb 2015 14:21:14 GMTMon, 02 Mar 2015 11:40:09 GMT<p>
This will result in invalid redirect URLs (containing two <tt>?</tt>) when <tt>admin_url</tt> filter is applied before.
Patch uses <tt>add_query_arg()</tt> rather than string concatenation.
</p>
podpiratehttps://core.trac.wordpress.org/ticket/31492
https://core.trac.wordpress.org/ticket/31492Report#30947: wp-includes files should not contain hooksThu, 08 Jan 2015 04:36:06 GMTMon, 19 Jan 2015 11:23:56 GMT<p>
It is general good practice to have 2 types of PHP files: those that declare symbols, and those that cause side effects (vars, functions calls, class invocations, includes, etc).
</p>
<p>
There are some random <tt>add_action()</tt> and <tt>add_filter()</tt> calls littered around some files in <tt>wp-includes/</tt>. These should be moved to <tt>wp-includes/default-filters.php</tt> with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even <tt>SHORTINIT</tt> - a lot of the hooks registered won't run anyways (that's already the case).
</p>
<p>
I made sure the hooks are in the same order - corresponding to the order their files load.
</p>
<p>
Almost all static analysis tools + <tt>hackificator</tt> (see Hack) complain about this. Also a requirement of PSR-2, which I know we don't care about, but doesn't hurt.
</p>
wonderboymusichttps://core.trac.wordpress.org/ticket/30947
https://core.trac.wordpress.org/ticket/30947Report#31236: wp_ajax_upload_attachment does not properly handle situation when post_id is setWed, 04 Feb 2015 23:13:47 GMTWed, 11 Feb 2015 06:23:54 GMT<p>
In the wp_ajax_upload_attachment function of wp_admin/includes/ajax_actions.php, it appears that the wrong capability is checked by the current_user_can function if post_id is set in the $_REQUEST object. At line 1845, this code exists:
</p>
<p>
if ( ! current_user_can( 'edit_post', $post_id ) )
</p>
<p>
As far as I can tell, edit_post is not a valid capability. I was building a custom post upload for my site that allowed certain users to add media. I had given them the edit_posts capability and they were still receiving the error message "You don't have permission to attach files to this post." Once I changed this line of code in wp-admin to:
</p>
<p>
if ( ! current_user_can( 'edit_posts', $post_id ) )
</p>
<p>
it worked as expected.
</p>
johncacprohttps://core.trac.wordpress.org/ticket/31236
https://core.trac.wordpress.org/ticket/31236Report#29215: WP_Customize_Media_ControlThu, 14 Aug 2014 18:24:42 GMTFri, 23 Jan 2015 17:53:16 GMT<p>
We'd like to refactor the existing <tt>WP_Customize_Upload_Control</tt>, <tt>WP_Customize_Image_Control</tt>, and <tt>WP_Customize_Background_Image_Control</tt> to leverage the media library (<a class="closed ticket" href="https://core.trac.wordpress.org/ticket/21483" title="task (blessed): Refactor Customizer Upload, Image, and Background Image controls to ... (closed: fixed)">#21483</a>). But the Customizer should also support inserting media (including things like Youtube videos) from a URL, for which "Upload" isn't the best term.
</p>
<p>
We should introduce a <tt>WP_Customize_Media_Control</tt> to serve as the base media-related control that all of the other media image/upload controls extend (or, if we can't be fully back-compat, we could create new controls that extend this one). It should allow developers to specify either a media type (ie, audio, video, image, document, etc; mapping to allowed filetypes and embed providers) or potentially specific filetypes (like <tt>WP_Customize_Upload_Control</tt> allows now).
</p>
<p>
Ultimately, the purpose of this control will be to bring the full power of the media manager into the Customizer.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/29215
https://core.trac.wordpress.org/ticket/29215Report#30815: WP_Filesystem_FTPext::exists() returns false if directory exists but is emptyMon, 22 Dec 2014 10:01:53 GMTThu, 15 Jan 2015 11:25:00 GMT<pre class="wiki">/**
* Check if a file or directory exists.
*
* @since 2.5.0
* @abstract
* @param string $file Path to file/directory.
* @return bool Whether $file exists or not.
*/
public function exists($file) {
$list = @ftp_nlist($this-&gt;link, $file);
return !empty($list); //empty list = no file, so invert.
}
</pre><p>
This method doesn't take in consideration that directory may exist but is empty.
</p>
<p>
The <tt>WP_Filesystem_FTPext::is_dir()</tt> method works correct (returns <tt>true</tt>). But the <tt>exists()</tt> method must be fixed, I think it's a major bug.
</p>
Unysonhttps://core.trac.wordpress.org/ticket/30815
https://core.trac.wordpress.org/ticket/30815Report#23931: wp_insert_comment should require comment_post_IDWed, 03 Apr 2013 18:41:58 GMTSun, 22 Feb 2015 04:35:15 GMT<p>
At this moment there is no check for example comment_post_ID. Not sure if there are more checks needed. Reason I asked are a few notices on the unit tests caused by WP_UnitTest_Factory_For_Comment. Those comments don't add a post ID what should change.
</p>
<p>
Currently, if a null comment_post_ID is passed, the comment isn't connected to a post. This can create confusion. Also Unit tests should run with WP_Debug on.
</p>
markoheijnenhttps://core.trac.wordpress.org/ticket/23931
https://core.trac.wordpress.org/ticket/23931Report#30266: wp_mail() can send emails with a blank 'From' addressThu, 06 Nov 2014 02:43:09 GMTTue, 24 Feb 2015 07:54:54 GMT<p>
If wp_mail() is used to send an email with a blank 'From' address set, it is not detected and replaced with the default wordpress@mydomainname...
</p>
<p>
Problem as I see it is in wp-includes/pluggable.php, where line 366 contains the test
</p>
<pre class="wiki"> if ( !isset( $from_email ) ) {
</pre><p>
The test using isset does not detect an empty string, allowing a blank 'from' address to be sent. Wouldn't it be better to test using empty?
</p>
<pre class="wiki"> if ( empty( $from_email ) ) {
</pre><p>
The same issue affects the 'from name' test on line 356.
</p>
drtonybhttps://core.trac.wordpress.org/ticket/30266
https://core.trac.wordpress.org/ticket/30266Report#14279: wp_new_comment ignores comment_date_gmt and comment_dateMon, 12 Jul 2010 14:07:06 GMTMon, 23 Feb 2015 19:05:09 GMT<p>
wp_new_comment takes in a $comment array, but then ignores the comment_date and comment_date_gmt passed into it, instead replacing them with the current time.
</p>
<p>
It should only set them if the data passed in is empty or not a date/time.
</p>
johneckmanhttps://core.trac.wordpress.org/ticket/14279
https://core.trac.wordpress.org/ticket/14279Report#14601: wp_new_comment method doesn't allow passed in values for IP and user-agentThu, 12 Aug 2010 14:20:21 GMTFri, 13 Feb 2015 16:07:19 GMT<p>
In a scenario where you have a client that receives comments from the internet and pre-processes those comments before feeding them into wordpress through xmlrpc the ip and user-agent of the commenting internet user gets lost because there is no way of passing those values into the wp_new_comment function.
</p>
<p>
<tt>$_SERVER['REMOTE_ADDR']</tt> and <tt>$_SERVER['HTTP_USER_AGENT']</tt> are hard-coded, which in the above mentioned scenario will always have the IP and user-agent from the client that feeds the comments into wp through xmlrpc.
</p>
<p>
The attached patch will used passed in values and only fall back to <tt>$_SERVER['REMOTE_ADDR']</tt> and <tt>$_SERVER['HTTP_USER_AGENT']</tt> if not passed in.
</p>
mrutzhttps://core.trac.wordpress.org/ticket/14601
https://core.trac.wordpress.org/ticket/14601Report#30307: wp_update_comment does not update user_id columnMon, 10 Nov 2014 23:40:48 GMTThu, 19 Feb 2015 18:40:35 GMT<p>
wp_update_comment() does not allow the update of the user_id column. This is caused from the $keys array on line 2233 of wp-includes/comment.php not containing the 'user_id' key before wp_array_slice_assoc() is ran on the following line. It's a very simple fix so I'll be posting a diff to this here momentarily.
</p>
<p>
Before the fix:
</p>
<pre class="wiki"> $keys = array( 'comment_content', 'comment_author', 'comment_author_email', 'comment_approved', 'comment_karma', 'comment_author_url', 'comment_date', 'comment_date_gmt', 'comment_parent' );
$data = wp_array_slice_assoc( $data, $keys );
$rval = $wpdb-&gt;update( $wpdb-&gt;comments, $data, compact( 'comment_ID' ) );
</pre><p>
After the fix:
</p>
<pre class="wiki"> $keys = array( 'comment_content', 'comment_author', 'comment_author_email', 'comment_approved', 'comment_karma', 'comment_author_url', 'comment_date', 'comment_date_gmt', 'comment_parent', 'user_id' );
$data = wp_array_slice_assoc( $data, $keys );
$rval = $wpdb-&gt;update( $wpdb-&gt;comments, $data, compact( 'comment_ID' ) );
</pre><p>
Attached is a diff for this that fixed trunk for me. Let me know if I missed something obvious or am not understanding some basic usage.
</p>
jphasehttps://core.trac.wordpress.org/ticket/30307
https://core.trac.wordpress.org/ticket/30307Report#30647: wp_update_user() allows using existing user_email, user_login, and user_nicenameWed, 10 Dec 2014 00:55:23 GMTFri, 27 Feb 2015 17:38:30 GMT<p>
When updating a user with <tt>wp_update_user()</tt> (which, in turn, uses <tt>wp_insert_user()</tt>), it's possible to set the <tt>user_email</tt> or <tt>user_nicename</tt> to those of an existing user. It's also possible to supply <tt>user_login</tt>, which gets silently discarded.
</p>
<p>
Each of these values need to be considered unique per user. If the values were supplied and not unique, I'd expect <tt>WP_Error</tt> to be returned.
</p>
<p>
Here's the relevant faulty logic:
</p>
<pre class="wiki">if ( ! $update &amp;&amp; username_exists( $user_login ) ) {
return new WP_Error( 'existing_user_login', __( 'Sorry, that username already exists!' ) );
}
</pre><pre class="wiki">if ( ! $update &amp;&amp; ! defined( 'WP_IMPORTING' ) &amp;&amp; email_exists( $user_email ) ) {
return new WP_Error( 'existing_user_email', __( 'Sorry, that email address is already used!' ) );
}
</pre><p>
Looks like this was introduced in <a class="changeset" href="https://core.trac.wordpress.org/changeset/12778" title="Add email and login dupe checking down into wp_insert_user(). Tidy up ...">r12778</a>.
</p>
<p>
Discovered in:
</p>
<ul><li><a class="ext-link" href="https://github.com/WP-API/WP-API/pull/705"><span class="icon">​</span>https://github.com/WP-API/WP-API/pull/705</a>
</li><li><a class="ext-link" href="https://github.com/WP-API/WP-API/pull/707"><span class="icon">​</span>https://github.com/WP-API/WP-API/pull/707</a>
</li></ul>danielbachhuberhttps://core.trac.wordpress.org/ticket/30647
https://core.trac.wordpress.org/ticket/30647Report#30945: WP_Upgrader: Incorrect plugin folder after updating from remote (non-WP) URLWed, 07 Jan 2015 23:52:26 GMTWed, 21 Jan 2015 14:52:08 GMT<p>
I have a plugin that fetches its updates via a remote URL - it's hosted on my own server, not WordPress.org. The plugin hooks into the <tt>site_transient_update_plugins</tt> filter to integrate with the native plugin update process.
</p>
<p>
The issue I've run into is that after performing an update, the plugin is in a new folder with an incorrect name. It happens under two conditions:
</p>
<p>
1) If the download URL is in the syntax <tt>http://example.com/updates/my-plugin.zip</tt>, then the plugin folder is renamed to <tt>my-plugin.tmp</tt> instead of <tt>my-plugin</tt>.
</p>
<p>
2) If the download URL is in the syntax <tt>http://example.com/updates/?action=download&amp;slug=my-plugin</tt> (the server interprets this and returns the zip file), then the plugin folder is renamed to <tt>actiondownloadslugmy-plugin</tt>, based on the query string.
</p>
<p>
I've been tracing the root cause of the issue in <tt>wp-admin/includes/class-wp-upgrader.php</tt>, and it's happening in <tt>WP_Upgrader::run()</tt>. The plugin is downloaded into a temporary folder via <tt>download_package()</tt>. It uses <tt>download_url($package)</tt> which calls <tt>wp_tempnam($url)</tt> to create the temporary folder name. Then it's unpacked, and by the time it gets to <tt>install_package()</tt> the destination directory is different from the original plugin folder. It seems that before <tt>install_package()</tt>, the plugin folder should be renamed from the temporary one to the correct one, based on the information available in $package.
</p>
<p>
I checked how a plugin hosted on WordPress.org is updated. The options passed to <tt>WP_Upgrader::run()</tt> are the same, with the download URL pointing to a zip file. I wonder where it's going wrong in my case.. Could it be that the zip file itself is the problem? I was having another issue there where if the zip contained a root folder with all the files, the update process would throw an error that the plugin was "empty".
</p>
<p>
It would be great if someone could help me figure this out..
</p>
miyarakirahttps://core.trac.wordpress.org/ticket/30945
https://core.trac.wordpress.org/ticket/30945Report#31513: Wrong description in DocBlock of function wp_insert_user()Tue, 03 Mar 2015 15:58:56 GMTTue, 03 Mar 2015 19:05:32 GMT<p>
Hey WP-Community,
</p>
<p>
I hope you all doing good.
</p>
<p>
I've found out that the variable name in the DocBlock of the <tt>wp_insert_user()</tt> in file <a href="https://core.trac.wordpress.org/browser/tags/4.1.1/src/wp-includes/user.php#L1689">/wp-includes/user.php (line 1689)</a> is wrong.
</p>
<p>
The parameter <tt>$date_registered</tt> should be renamed to <tt>$user_registered</tt>. I don't know really why this parameter is called <tt>$user_registered</tt> as the value gets saved into the database table cell named <tt>date_registered</tt>.
</p>
<p>
I've tested that
</p>
<pre class="wiki">wp_insert_user( array(
'date_registered' =&gt; '2010-12-05 10:00:01',
'user_pass' =&gt; 'test',
'user_login' =&gt; 'testperson',
) );
</pre><p>
will not work whereas
</p>
<pre class="wiki">wp_insert_user( array(
'user_registered' =&gt; '2010-12-05 10:00:01',
'user_pass' =&gt; 'test',
'user_login' =&gt; 'testperson',
) );
</pre><p>
will do the trick (writes the date into the database correctly). So <tt>user_registered</tt> is right (<a class="ext-link" href="http://codex.wordpress.org/Function_Reference/wp_insert_user#Notes"><span class="icon">​</span>as the documentation suggests</a>).
</p>
<p>
I know that this is just a small thing. However it's confusing if one constantly takes a look into the core code instead of the documentation.
</p>
<p>
Thanks
</p>
floriansimethhttps://core.trac.wordpress.org/ticket/31513
https://core.trac.wordpress.org/ticket/31513Report#24916: XML-RPC "wp_author_id" ignored when changing author to selfThu, 01 Aug 2013 20:40:00 GMTTue, 13 Jan 2015 14:06:48 GMT<p>
When using the MetaWeblog mw_editPost method to change the author of an existing post from another user to the logged in user, the wp_author_id" field is not read from the content_struct because of a logic error in mw_editPost().
</p>
<p>
The logic error is in this line:
</p>
<pre class="wiki">if ( isset($content_struct['wp_author_id']) &amp;&amp; ($user-&gt;ID != $content_struct['wp_author_id']) )
</pre><p>
Here it is assumed that if the supplied author ID is the same as the logged in user, then the supplied ID does not need to be read. However, this is not true when the post being edited is in fact not currently in the logged in user's authorship.
</p>
<p>
The attached patch fixes the problem and also clarifies the permissions test so that it will reject any effort to change the author ID either to another user's ID or from another user's ID, unless the logged in user has permission to editor others' posts.
</p>
redsweaterhttps://core.trac.wordpress.org/ticket/24916
https://core.trac.wordpress.org/ticket/24916Report