Description

Working on the "Mahara" assignment submission plugin, I need to be able to tell Mahara to unlock the submitted page on the Mahara side if an assignment is reopened. The mod/assign/submission plugin provides hooks for most actions you can take in the gradebook, but not for reopen aka "add_attempt".

Damyon Wiese
added a comment - 07/Apr/14 9:38 AM Is this ready for review (the status is still "Open") - the current patch looks fine to me for master only (haven't run unit tests on it though).
For stables - we backported MDL-39760 - but on reflection that caused some issues - there were some regressions introduced and some flow on effects for strict standards warnings reported by Davo.
It also creates a wonky API - because functions appear and then disappear as you increase the version number: (2.5.6 would have the function, 2.6.2 would not, 2.6.3 would).
+1 to submit the current master branch if there are no more changes pending.

Yep, no more changes needed. I just forgot to click the "Request peer review" button. It's been maybe 2 years since I submitted a Moodle patch, and some parts of the process seem to have changed since then, so please do let me know if I'm missing anything else.

It would be handy for users of our plugin if the additional function was backported into the 2.5 & 2.6 stable releases, but you do have a point about the problems caused by doing the same for MDL-39760.

Aaron Wells
added a comment - 07/Apr/14 10:24 AM Hi Damyon,
Yep, no more changes needed. I just forgot to click the "Request peer review" button. It's been maybe 2 years since I submitted a Moodle patch, and some parts of the process seem to have changed since then, so please do let me know if I'm missing anything else.
It would be handy for users of our plugin if the additional function was backported into the 2.5 & 2.6 stable releases, but you do have a point about the problems caused by doing the same for MDL-39760 .
Cheers,
Aaron

Michael de Raadt
added a comment - 09/Apr/14 11:58 AM Test result: Passed
Tested in master only.
Thanks for working on this, Aaron.
I think the testing instructions could have been more explicit. I knew what to test, but others might not have, and "works as expected" always depends on perspective.