Comments

On Wed, 2009-04-08 at 14:37 +0100, Alan Jenkins wrote:
> This unused feature was removed in 4dec9b807be757780ca3611a959ac22c28d292a7> > Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>> ---> > p.s. Is netdev really the right list for rfkill (as listed in MAINTAINERS)?> I have a feeling most development happens on linux-wireless.
You're right, and I'm rewriting rfkill and part of that is changing the
maintainer to myself and the list to linux-wireless.
I have no problems with this patch, but note that I'm rewriting that
entire file as well so it's not really necessary in the long run -- now
that -rc1 is out I can hopefully convert all in-tree rfkill stuff and
get the patch in.
johannes

Johannes Berg wrote:
> On Wed, 2009-04-08 at 14:37 +0100, Alan Jenkins wrote:> >> This unused feature was removed in 4dec9b807be757780ca3611a959ac22c28d292a7>>>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>>> --->>>> p.s. Is netdev really the right list for rfkill (as listed in MAINTAINERS)?>> I have a feeling most development happens on linux-wireless.>> >> You're right, and I'm rewriting rfkill and part of that is changing the> maintainer to myself and the list to linux-wireless.>
Good luck! I'll try to have a look at your patch, to see how (if) it
would affect the benighted eeepc-laptop.
> I have no problems with this patch, but note that I'm rewriting that> entire file as well so it's not really necessary in the long run -- now> that -rc1 is out I can hopefully convert all in-tree rfkill stuff and> get the patch in.>
Heh, ok.
Alan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Mon, 2009-04-13 at 20:00 +0100, Alan Jenkins wrote:
> I tried the latest patch (#19) from your website, it didn't work so well > :-).
I think I fixed that now, I allowed using set_sw_state before register
and that didn't go too well with the LED system w/o any checks.
johannes

diff --git a/Documentation/rfkill.txt b/Documentation/rfkill.txtindex 4d3ee31..357ef01 100644--- a/Documentation/rfkill.txt+++ b/Documentation/rfkill.txt@@ -47,10 +47,8 @@ know when they should enable or disable a wireless network device transmitter.
This is enabled by the CONFIG_RFKILL Kconfig option.
The rfkill class support makes sure userspace will be notified of all state
-changes on rfkill devices through uevents. It provides a notification chain-for interested parties in the kernel to also get notified of rfkill state-changes in other drivers. It creates several sysfs entries which can be used-by userspace. See section "Userspace support".+changes on rfkill devices through uevents. It creates several sysfs entries+which can be used by userspace. See section "Userspace support".
The rfkill-input module provides the kernel with the ability to implement a
basic response when the user presses a key or button (or toggles a switch)
@@ -156,9 +154,8 @@ rfkill class:
transmitter state;
* Keeps track of the wireless transmitter state (with help from
the driver);
- * Generates userspace notifications (uevents) and a call to a- notification chain (kernel) when there is a wireless transmitter- state change;+ * Generates userspace notifications (uevents) when there is a wireless+ transmitter state change;
* Connects a wireless communications driver with the common rfkill
control system, which, for example, allows actions such as
"switch all bluetooth devices offline" to be carried out by
@@ -206,18 +203,15 @@ Userspace input handlers (uevents) or kernel input handlers (rfkill-input):
restore the transmitters to their state before the EPO, or unblock
them all.
-Userspace uevent handler or kernel platform-specific drivers hooked to the-rfkill notifier chain:+Userspace uevent handler or kernel platform-specific drivers:- * Taps into the rfkill notifier chain or to KOBJ_CHANGE uevents,- in order to know when a device that is registered with the rfkill- class changes state;+ * Listens to KOBJ_CHANGE uevents or the platform in order to know when+ a device that is registered with the rfkill class changes state;
* Issues feedback notifications to the user;
* In the rare platforms where this is required, synthesizes an input
event to command all *OTHER* rfkill devices to also change their
statues when a specific rfkill device changes state.
-
===============================================================================
3: Kernel driver guidelines
@@ -269,8 +263,7 @@ SW_RFKILL_ALL, etc) when ALL of the folowing conditions are met:
When in doubt, do not issue input events. For drivers that should generate
input events in some platforms, but not in others (e.g. b43), the best solution
is to NEVER generate input events in the first place. That work should be
-deferred to a platform-specific kernel module (which will know when to generate-events through the rfkill notifier chain) or to userspace. This avoids the+deferred to a platform-specific kernel module or to userspace. This avoids the
usual maintenance problems with DMI whitelisting.