Comments

From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Thu, 9 Feb 2012 08:55:13 +0100
> From: Francesco Virlinzi <francesco.virlinzi@st.com>> > In case of we use an external Wake-Up IRQ line> (priv->wol_irq != dev->irq) we need to invoke the> request_irq.> > Signed-off-by: Francesco Virlinzi <francesco.virlinzi@st.com>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
You never free the IRQ in the driver close path, so it leaks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On 2/9/2012 8:02 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>> Date: Thu, 9 Feb 2012 08:55:13 +0100> >> From: Francesco Virlinzi <francesco.virlinzi@st.com>>>>> In case of we use an external Wake-Up IRQ line>> (priv->wol_irq != dev->irq) we need to invoke the>> request_irq.>>>> Signed-off-by: Francesco Virlinzi <francesco.virlinzi@st.com>>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>> > You never free the IRQ in the driver close path, so it leaks.
Yes you are right. I'm reviewing the patch and send it again.
Thx
peppe
> --> To unsubscribe from this list: send the line "unsubscribe netdev" in> the body of a message to majordomo@vger.kernel.org> More majordomo info at http://vger.kernel.org/majordomo-info.html>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html