On Thu, 29 Mar 2012 15:14:29 +1100, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:> On Thu, 2012-03-29 at 13:50 +1100, Michael Neuling wrote:> > Grant: why does powerpc_debugfs_root appear in generic code? This seems> > very bogus.> > Yes, Grant, you should move that to a different (generic) debugfs file,> the mapping information is valuable debug data for all architectures> that use the remapper, not just powerpc and it's not an ABI (no tool I> know of rely on the location of that debugfs file) so feel free to move> it around.

I could simply drop the powerpc_debugfs_root argument fromdebugfs_create_file() and replace it with NULL. As you say, this isnot an ABI and this will solve the problem.

On Wed, 28 Mar 2012 22:02:41 -0700, Linus Torvalds <torvalds@linux-foundation.org> wrote:> Grant - what's the plan about that CONFIG_VIRQ_DEBUG thing? In theory> something like it could be useful as a generic thing, but at least> right now it is clearly powerpc-specific (not just that the config> option only exists for powerpc: it has that whole> 'powerpc_debugfs_root' thing in it)?> > Stephen's patch very much looks like the right thing, but if there was> some plan to actually make this generic ...

The plan is to make it generic. I just ran out of time for thiscycle to generalize it. I moved all of irqdomain out of arch/powerpcwholesale, which included the debug bits, and then generalized it inplace. That was the safest way to transition without causingbreakage.

Moving it back into powerpc land is a step backwards. I've attached apatch that makes it generic instead. It has been tested on ARM.

I've pushed it out to the following branch:

git://git.secretlab.ca/git/linux-2.6 irqdomain/merge

---

[PATCH] irqdomain: Remove powerpc dependency from debugfs file

The debugfs code is really generic for all platforms. This patch removes thepowerpc-specific directory reference and makes it available to allarchitectures.