Activity

Over the last few days , I've completed this work. I'm sure there will be a few issues and certainly there are test failures when the full test run is executed with just the hdk. Hopefully we can fix up any issues in the next few days.

Mark Hindess
added a comment - 19/Jul/09 22:47 Over the last few days , I've completed this work. I'm sure there will be a few issues and certainly there are test failures when the full test run is executed with just the hdk. Hopefully we can fix up any issues in the next few days.

When I ran tests with security-resource.jar I saw about 30 tests failures. The first half was due to missed key-storage for some security algorithm the second one due to missed serialization data files. Access to serialization data may be easily fixed, but I don't know good solution to fix access problem for 'special' files. I considered two options here:

the test extract needed files from the archive through the some library function to the temporary location and then use it;

the resource files stored to separated directory in the HDK without compression.

Vladimir Ivanov
added a comment - 12/Oct/06 06:33 When I ran tests with security-resource.jar I saw about 30 tests failures. The first half was due to missed key-storage for some security algorithm the second one due to missed serialization data files. Access to serialization data may be easily fixed, but I don't know good solution to fix access problem for 'special' files. I considered two options here:
the test extract needed files from the archive through the some library function to the temporary location and then use it;
the resource files stored to separated directory in the HDK without compression.
At present time the second option was selected just because it is:
easy to implement;
tests are still simple and more reliable.

Mark Hindess
added a comment - 11/Oct/06 16:10 Thanks Vladimir.
I've applied the security patch in r462825.
I wonder if it might be tidier to put the resources in a jar as well? What do you think?
(I prefer to leave all attachments - the manage attachments view makes it clear which is the latest version so it's not too confusing.)

Vladimir Ivanov
added a comment - 09/Oct/06 09:31 variable '$
{hy.jdk}
' were defined early I just use it. But agreed, 'hdk' is more preferable here.
I'll prepare the patch with dot-separated names and with small letters in some minutes.

Also, previously most of the variables in the security build.xml used dots to separate the words in their names. Your patch introduces variables with both underscores and dashes. Is this intentional? (You've also introduced uppercase letters though I'm less confused about that.)

Mark Hindess
added a comment - 09/Oct/06 08:38 Vladimir,
A few questions about the updated patch. The line:
<property name="tests-HDK-dir" value="$
{hy.jdk}/build/test" />
should probably be ${hy.hdk} not ${hy.jdk}
?
Also, previously most of the variables in the security build.xml used dots to separate the words in their names. Your patch introduces variables with both underscores and dashes. Is this intentional? (You've also introduced uppercase letters though I'm less confused about that.)

tests are placed in 4 archives, resources are copied to the HDK dir while many tests refers to resources as a file on the disk (key storage, serialization data etc) and not for all of them data can be stored in the archive.
If it is OK - I'll prepare patches for other modules.

Vladimir Ivanov
added a comment - 06/Oct/06 13:53 tests are placed in 4 archives, resources are copied to the HDK dir while many tests refers to resources as a file on the disk (key storage, serialization data etc) and not for all of them data can be stored in the archive.
If it is OK - I'll prepare patches for other modules.

I've applied the accessibility patch in r453122. Please confirm it is okay.

Assuming you are planning to carry on with this process, if not let me know and I'll add it to my todo list, my preference would be to do one of the difficult modules next - one with four jars. Then it should be fairly easy to apply the "pattern" to the remaining modules. After that we should think about MANIFEST files but that can wait until we've got all modules working this way.

Mark Hindess
added a comment - 05/Oct/06 08:23 Thanks Vladimir.
I've applied the accessibility patch in r453122. Please confirm it is okay.
Assuming you are planning to carry on with this process, if not let me know and I'll add it to my todo list, my preference would be to do one of the difficult modules next - one with four jars. Then it should be fairly easy to apply the "pattern" to the remaining modules. After that we should think about MANIFEST files but that can wait until we've got all modules working this way.

According to discussion on the dev-list it should be separated jars (up to 4) for each module.
Could somebody review and integrate changes for accessibility module?
If it is OK I prepare the similar updates for each module.

Vladimir Ivanov
added a comment - 04/Oct/06 10:10 According to discussion on the dev-list it should be separated jars (up to 4) for each module.
Could somebody review and integrate changes for accessibility module?
If it is OK I prepare the similar updates for each module.