Comments

Hi, the BladeEngine 10g NIC driver (benet) has undergone a few rounds of review on this list.
Later, some more issues have been fixed as a part of the drivers/staging tree maintained by Greg KH.
It is being re-submitted for a final round of review.
The patches are against the torvalds git tree.
Thanks,
-Sathya
P.S: Pls ignore the "company confidential" warning at the end of the patch emails.
Signed-off-by: Sathya Perla <sathyap@serverengines.com>
---
drivers/net/benet/be_init.c | 1382 +++++++++++++++++++++++++++++++++++++++++++
drivers/net/benet/benet.h | 429 ++++++++++++++
2 files changed, 1811 insertions(+), 0 deletions(-)
create mode 100644 drivers/net/benet/be_init.c
create mode 100644 drivers/net/benet/benet.h

From: Sathya Perla <sathyap@serverengines.com>
Date: Tue, 09 Dec 2008 19:49:44 +0530
> + pnob = netdev->priv;
netdev->priv should never be accessed directly, use
netdev_priv() always
netdev->priv has even been removed in the net-next-2.6
tree so we don't want any new references sneaking into
the tree as this will cause build failures.
> + struct be_net_object *pnob = (struct be_net_object *)netdev->priv;
...
> + struct be_net_object *pnob = (struct be_net_object *)netdev->priv;
And when you convert these cases, remove the casts.
They are pointless since netdev_priv() (and netdev->priv) are void
pointers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html