Comments

Hi Jon,
On 21/12/12 15:45, Jon Diekema wrote:
> tokyocabinet: new package>> Signed-off-by: Jon Diekema<jon.diekema@gmail.com>
Your patch is still line-wrapped. Also, it has to be modified manually
in order to be processed with git-am, otherwise all the text below will
be included in the commit message. Please send your patch with
git send-email.
Also, it is useful for the review if you include in the message a
changelog of what you modified compared to your previous submission.
[snip]
> diff --git a/package/tokyocabinet/Config.in b/package/tokyocabinet/Config.in> new file mode 100644> index 0000000..66ff02e> --- /dev/null> +++ b/package/tokyocabinet/Config.in> @@ -0,0 +1,7 @@> +config BR2_PACKAGE_TOKYOCABINET> + bool "Tokyo Cabinet"> + help
The config attributes should be indented with 1 TAB.
> + A modern reimplementation of QDBM, also released under the LGPL> + by Mikio Hirabayashi in 2007.> +> + http://www.igvita.com/2009/02/13/tokyo-cabinet-beyond-key-value-store/
The help text should be indented with 1 TAB + 2 spaces.
[snip]
> diff --git a/package/tokyocabinet/tokyocabinet.mk> b/package/tokyocabinet/tokyocabinet.mk> new file mode 100644> index 0000000..a5fa21d> --- /dev/null> +++ b/package/tokyocabinet/tokyocabinet.mk> @@ -0,0 +1,42 @@> +#############################################################> +#> +# Tokyo Cabinet> +#> +#############################################################> +> +TOKYOCABINET_VERSION = 1.4.47> +TOKYOCABINET_SOURCE = tokyocabinet-$(TOKYOCABINET_VERSION).tar.gz> +TOKYOCABINET_SITE = http://httpsqs.googlecode.com/files> +TOKYOCABINET_INSTALL_STAGING = YES> +TOKYOCABINET_LICENSE = LGPLv2.1
LGPLv2.1+, actually.
> +TOKYOCABINET_LICENSE_FILES = COPYING
[snip]
I tried this with an internal toolchain with all features disabled, and
it barfed in tcucodec.c, which tries to print out the size and range of
wchar_t. Simplest solution is to make tokyocabinet depend on
BR2_USE_WCHAR, but perhaps better is a patch that removes the useless
wchar stuff from tcucodec.c...
Regards,
Arnout