Maciej Prochniak
added a comment - 14/Sep/16 12:29 https://github.com/mproch/flink/commit/ceef33d94058958f36275bfae81d00054e8cc231 - I think this should do the job, but have yet to find a place to write test...

I think org.apache.flink.runtime.client.JobClientActorTest in the java tests of flink-runtime might be a good place to start looking at.
Feel free to open a PR when you think you're ready, I can offer to help review

Tzu-Li (Gordon) Tai
added a comment - 14/Sep/16 12:42 I think org.apache.flink.runtime.client.JobClientActorTest in the java tests of flink-runtime might be a good place to start looking at.
Feel free to open a PR when you think you're ready, I can offer to help review

ASF GitHub Bot
added a comment - 14/Sep/16 21:26 GitHub user mproch opened a pull request:
https://github.com/apache/flink/pull/2498
FLINK-4619 - JobManager does not answer to client when restore from savepoint fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mproch/flink flink-4619
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2498.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2498
commit 79ed80af927ecededd06ba61d98879b189f064ea
Author: Maciek Próchniak <mpr@touk.pl>
Date: 2016-09-14T12:27:27Z
FLINK-4619 - JobManager does not answer to client when restore from savepoint fails

ASF GitHub Bot
added a comment - 15/Sep/16 17:57 Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2498
Good idea. Unfortunately, the changed broke some tests:
`SavepointITCase.testSubmitWithUnknownSavepointPath`
`RescalingITCase.testSavepointRescalingFailureWithNonPartitionedState`
You can see more in the Travis CI report.

Yes, it's a bit more tricky then I expected... These tests probably also need to be changed, because they relied on previous behaviour... What's more with the change some checks on FlinkMiniCluster start to be non-deterministic... I'll commit fixes when I'll fully understand how it works...

ASF GitHub Bot
added a comment - 15/Sep/16 18:04 Github user mproch commented on the issue:
https://github.com/apache/flink/pull/2498
Yes, it's a bit more tricky then I expected... These tests probably also need to be changed, because they relied on previous behaviour... What's more with the change some checks on FlinkMiniCluster start to be non-deterministic... I'll commit fixes when I'll fully understand how it works...