Owen O'Malley
added a comment - 17/May/11 23:08 Devaraj,
Can you please have the Thread catch IOExceptions and log them. Throwable should be caught, logged, and call System.exit.
I think you need to retry if the offer returns false rather than just dropping the cancel request.

I should ideally put a small sleep between the retries whenever 'offer' returns false. That would need InterruptedException to be handled. I ideally don't want to swallow the InterruptedException but if I don't it leads to a big cascading change in the method declarations in the call hierarchy of the token cancellation method... I am in two minds on whether to swallow/ignore the interrupted exception or propagate it all the way up and effect a major change in the method signatures...

Devaraj Das
added a comment - 18/May/11 01:08 I should ideally put a small sleep between the retries whenever 'offer' returns false. That would need InterruptedException to be handled. I ideally don't want to swallow the InterruptedException but if I don't it leads to a big cascading change in the method declarations in the call hierarchy of the token cancellation method... I am in two minds on whether to swallow/ignore the interrupted exception or propagate it all the way up and effect a major change in the method signatures...

Owen O'Malley
added a comment - 01/Jun/11 18:37 Looking good. A few more points:
Please have the cancelToken catch the InterruptedException and create a new RuntimeException that wraps it.
Please have the DelegationTokenCancelThread catch InterruptedException and exit gracefully.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

Hadoop QA
added a comment - 02/Jun/11 01:13 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481158/cancel-delegation-token-fix-trunk.patch
against trunk revision 1130147.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/330//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/330//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/330//console
This message is automatically generated.

Compared the number of findbugs warnings with the number of findbugs warnings for another recent hudson run. They are the same. Not sure why this patch is triggering false findbugs alarms. I intend to commit the patch soon..

Devaraj Das
added a comment - 03/Jun/11 21:38 Compared the number of findbugs warnings with the number of findbugs warnings for another recent hudson run. They are the same. Not sure why this patch is triggering false findbugs alarms. I intend to commit the patch soon..