Description

There is an invalid query in the ./lib/question.php file with a reference to an ambiguous column definition which appears twice in the select. Oracle will not accept this as a valid query and errors with :

Tim Hunt
added a comment - 16/Mar/10 6:59 PM That patch won't work. In SQL queries in Moodle, the first column is significant. It gets used to index the array that is returned.
I think the correct solution it to explicitly write out all the s.... columns (except for question) to avoid the duplication.
The patch looks find. The only comment I would make is that it is best to give it a file extension different from .php. I often use .patch.txt.

David Binney
added a comment - 16/Mar/10 8:58 PM Hey Tim, I made the specified changes but was just unsure of the replacement of the questionid for the quesiton but i am sure you will let me know if that is no good

Tim Hunt
added a comment - 16/Mar/10 11:51 PM Well, tabs for indent a bad (according to Development:Coding_style#Indentation). But apart from that it looks fine. I will try to commit it soon, but today is testing day before the weekly build.

Tim Hunt
added a comment - 06/Apr/10 7:13 PM Oops, I forgot all about this.
Attached is a cleaned up patch. I was about to commit this to CVS, when I remembered that it is testing day again.
Hopefully I will remember tomorrow.