Created attachment 631855[details]
screenshot of dialog
Would be nice to hook up this dialog with proper verbs to enforce the actions.
What about: [Later] [Send Now]
(I also hate that dialog keeps blocking me and want it to be a notification bar, but that is bug #763436)

Comment on attachment 632355[details][diff][review]
patch
This is definitely better. ui-r=me, based on that.
I think "Send now" then "Later" would be better still, since that follows the order in time of the two buttons.
And even better would be to just send the messages, and not interrupt the user. ;) (It looks like we could change the default value of "offline.send.unsent_messages" to achieve that…)
Thanks,
Blake.

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #7)
> And even better would be to just send the messages, and not interrupt the
> user. ;) (It looks like we could change the default value of
> "offline.send.unsent_messages" to achieve that…)
>
> Thanks,
> Blake.
indeed, Bug 511079 would be better

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #7)
> I think "Send now" then "Later" would be better still, since that follows
> the order in time of the two buttons.
I am not sure what you mean here. Should I change the order of the buttons? Or what?

I think the order also depends on platform, so you want the "Send now" be the first one (primary and default) and "Later" be the second. I think this will make Send on the left and Later on the right on Windows.

I also didn't see a better one. :(
The confirmEx comments also say that if you're replacing all the buttons with custom strings, you might be doing something wrong. Perhaps we should just leave them as they are. :P
And finally, I'm not sure I can explain why "[Send now] [Later]" is better than "[Later] [Send now]" better than I did above… If you agree that following the order in time is better, then surely it's better on all the platforms, no?

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #16)
> And finally, I'm not sure I can explain why "[Send now] [Later]" is better
> than "[Later] [Send now]" better than I did above… If you agree that
> following the order in time is better, then surely it's better on all the
> platforms, no?
But I can't order it in the same way on all platforms (as some platforms reverse the order automatically). Maybe by ifdef'ing the code by platform. Do we want that?

I don't think it's actually so much a question of when it time you'll do it. It's really more of "send now" vs "i don't wanna deal with this/stupid dialog go away/irrelevant text". So i'd just go for the platform order for defaults.