I've only played the first three gens, but I'd say my favourite was Pokemon Sapphire (adding further to the gen 3 love...). I have so many happy memories from that game, and I really loved having a secret base. I also liked HeartGold because I thought Ethan and Lyra were very cute. :>