If this is your first visit, be sure to
check out the FAQ by clicking the
link above. You may have to register
before you can post: click the register link above to proceed. To start viewing messages,
select the forum that you want to visit from the selection below.

tivowebplus-v2.1.b3-20120803

Here is an updated bundle. It includes patches from this thread since the previos bundle was released by John1980 (from post 1060 through 1126). Specifically it includes patches from 1070, 1077, 1078, 1091, 1094, 1114, 1124, and 1126. Those patches also supercede 1060, 1075, 1076, 1092, 1097, and 1107. I removed the get_space binaries and sources. I update the distribution name and checksums. Feel free to point out anything I missed and please post future patches against this distribution (unless there are any objections).

Here's a patch that fixes the "Error: your season pass priority list is corrupted, reorganizing them from the tivo UI may help" seen on the seasonpass menu. Looks like a bug was introduced when the OzTivo widget support was added a few years ago. I updated the previous post/distribution to include this fix as well.

Lock-ups

Did anyone ever have any luck with diagnosing the TWP runaway when interrupting a page display? The condition I mean is:
1) Display a nice long page - e.g. Now Playing or ToDo
2) *While it's loading* click on a link - e.g. a programme title (with a view to displaying the Showing screen)

Result = TWP now locks up and you're left "waiting for 192.168.1.200...". If you look on the Tivo, TWP is still running but is churning away just running up mill time (e.g. 85% CPU 21% MEM). Can't interrupt it, can't stop it - only way out is to reboot Tivo.

You're ok if you Ctrl & click to load on another browser tab - it seems to be only if you load into the same tab.

I tried various things:

I thought maybe it was because the channel was no longer available (once you abort/interrupt the page load) so "puts $chan" is blocking, but that doesn't seem to be it - all connections have the same channel id.

I tried making TWP only accept 1 request at a time - no effect.

I even tried making the http socket non-blocking but that caused issues elsewhere and didn't help anyway!

It doesn't seem to do it with all screens and I'm thinking it only happens if you interrupt TWP while it is doing some MFS work (e.g. it does it on NowPlaying, ToDo and SPs but not on Channel List). Quite why this should upset things I don't know - maybe "transaction" can't muti-thread?

As I say it's not an issue if you request things on different tabs - they are simply queued up and processed in sequence. It's only if you interrupt a page load (by clicking on a link, or pressing Esc) that TWP barfs.

This doesn't happen with tivoweb or TWP 1.3.1 so it's something in the way 2.1 is accessing the MFS? Maybe it's something to do with the way getrec() is using global vars? (that proc is serious spaghetti with not a comment nor usage note in sight!)

But then again, it also happens if you simply press Esc during the page load, which suggests it's a socket issue.

I have not seen this behavior and cannot reproduce it. I tried both title and eptitle during a NPL load. I also tried ESC. I tested with THD, IE8, and tivowebplus-v2.1.b3-20120803. What are you testing with?

IE8 displays for me as the list is building. Can you verify that the last bundle I posted also does it (not that I expect otherwise, but since I don't have your bundle/patches to test). It could very well be something S1/swversion specific. There are plenty of branches based on "version".

IIRC THD is based on TCL 8.2. I don't have access to an S1, so I'm not sure how much help I will be.

I assume by some of your patches and comments, you've already been through the ForeachMfsFile code. You mentioned that it works on TWP 1.3.1, does it also use ForeachMfsFile during those screens. Have you tried reverting to the stock mfslib.tcl version?

I just had another thought about your lockups. How are you starting TWP when you experience problems? I vaguely remember having issues when I was creating/debugging code for get_space_tcl. IIRC, it was only when I start TWP interactively from the CL.

It happens however I start it - either rc.sysinit.author, CL or any of TWP's "Restart" options.

p.s. there is a bug in the "tivoweb" start-up script which means if you start TWP using a relative dir (i.e. with "./TivoWebPlus/tivoweb &") then it will create spurious config files - this can be fixed as shown below - is that the issue you are referring to?

Excellent. I will add the patches to the distribution, but probably wait a few days before releasing it. There are a few more things I want to look at.

Oddly enough, I was finally able to reproduce your problem last night but was too tired to continue. I updated my distribution with a couple of other fixes and re-installed an it started happening. I wonder if I was inadverntly testing with John1980's bundle when I couldn't reproduce it. Maybe I should have had a fresh cup yesterday...

I think I must have done something similar - I was sure I had the same problem with John1980's bundle but, with hindsight, I couldn't have done! That's the problem with having 5 different versions of TWP sitting on the one TiVo I guess! Can never have too much tea...