Dear Linus Walleij,
In message <1311086967-21406-1-git-send-email-linus.walleij@linaro.org> you wrote:
> This deletes the integrator split_by_variant.sh script and> defines a number of unique board types for the core modules> that are meaningful to support for the Integrator AP/CP, i.e.> the ones that did not just say "unsupported core module" in> split_by_variant.sh. If more core modules need to be supported> they are easy to add.> > We delete all the old cruft in Makefile and MAKEALL that was> working around the old way of building boards. We create a> unique config file per board to satisfy the build system, but> they are just oneliners that include the existing> integratorap.h and integratorcp.h configs.> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>> ---> This patch goes on top of the previous git pull request and fix> the final request from Wolfgang to convert the Integrator boards> over to the new build system.
Thanks a lot. I have one question, though:
> include/configs/integratorap.h | 3 +> include/configs/integratorap_cm720t.h | 1 +> include/configs/integratorap_cm920t.h | 1 +> include/configs/integratorap_cm926ejs.h | 1 +> include/configs/integratorap_cm946es.h | 1 +> include/configs/integratorcp.h | 2 +> include/configs/integratorcp_cm1136.h | 1 +> include/configs/integratorcp_cm920t.h | 1 +> include/configs/integratorcp_cm926ejs.h | 1 +> include/configs/integratorcp_cm946es.h | 1 +
It appears that all the new board config files just include
integrator[ac]p.h, without any additional stuff. Would it not make
sense to omit these file alltogether then, and let the entries in
boards.cfg point to the generic files integratorap.h resp.
integratorcp.h instead?
Best regards,
Wolfgang Denk

On Tue, Jul 19, 2011 at 10:04 PM, Wolfgang Denk <wd@denx.de> wrote:
> [Me]>> include/configs/integratorap.h | 3 +>> include/configs/integratorap_cm720t.h | 1 +>> include/configs/integratorap_cm920t.h | 1 +>> include/configs/integratorap_cm926ejs.h | 1 +>> include/configs/integratorap_cm946es.h | 1 +>> include/configs/integratorcp.h | 2 +>> include/configs/integratorcp_cm1136.h | 1 +>> include/configs/integratorcp_cm920t.h | 1 +>> include/configs/integratorcp_cm926ejs.h | 1 +>> include/configs/integratorcp_cm946es.h | 1 +>> It appears that all the new board config files just include> integrator[ac]p.h, without any additional stuff.
Yes, that's how it works...
> Would it not make> sense to omit these file alltogether then, and let the entries in> boards.cfg point to the generic files integratorap.h resp.> integratorcp.h instead?
This row in the global Makefile is the reason:
sinclude $(obj).boards.depend
$(obj).boards.depend: boards.cfg
awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config;
$$(MAKE)" }' $< > $@
It requires one *_config per board variant.
The boards are just two variants, but the CPU column differs for all of
them, depending on what CPU Module (CM) you plug into the board.
So I define these different boards just to get the right value of CPU into
$(obj)/include/config.mk
I haven't quite figured out how that file is generated, but to avoid any
more configure options being passed in it seemed like the only way
forward without revamping the build system.
Hacking Makefile to support several boards using the same *_config
seems pretty daunting, but if this is what you want I can try.
Any hints?
Yours,
Linus Walleij

Dear Linus Walleij,
In message <CACRpkdYR5+bMBpdF0F5NmQZZGnRS3=NUYq1R_FCezoj2Fp2D5w@mail.gmail.com> you wrote:
>> > Would it not make> > sense to omit these file alltogether then, and let the entries in> > boards.cfg point to the generic files integratorap.h resp.> > integratorcp.h instead?> > This row in the global Makefile is the reason:> > sinclude $(obj).boards.depend> $(obj).boards.depend: boards.cfg> awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config;> $$(MAKE)" }' $< > $@> > It requires one *_config per board variant.
Right. But it does NOT require that each board has it's own file in
include/configs/<name>.h
> Any hints?
Well, for example, the following different boards and board
configurations all shar the same board config file
(include/configs/TQM823L.h) : TQM823L, TQM823L_LCD, TTTech and wtk
The same should be done for the integrator boards, too.
Best regards,
Wolfgang Denk

On Wed, Jul 20, 2011 at 2:16 PM, Wolfgang Denk <wd@denx.de> wrote:
> [Me]>> It requires one *_config per board variant.>> Right. But it does NOT require that each board has it's own file in> include/configs/<name>.h
Aha I see, the last column in boards.cfg points to the name of an
a config file, else it uses the board name, new patch in a few minutes.
Thanks,
Linus Walleij