On top of "[PATCH 5/5] timers: cleanup, kill __get_base()", seehttp://marc.theaimsgroup.com/?l=linux-kernel&m=111125359121372If the timer is currently running on another CPU, __mod_timer()spins with interrupts disabled and timer->lock held. I think itis better to spin_unlock_irqrestore(&timer->lock) in __mod_timer'sretry path.

This patch is unneccessary long. It is because it tries to cleanupthe code a bit. I do not like the fact that lock+test+unlock patternis duplicated in the code.

If you think that this patch uglifies the code or does not matchkernel's coding style - just say nack :)