Re: SRFI-14 and locale settings

From:

Ludovic Courtès

Subject:

Re: SRFI-14 and locale settings

Date:

Wed, 20 Sep 2006 15:21:16 +0200

User-agent:

Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Hi,
Kevin Ryde <address@hidden> writes:
> address@hidden (Ludovic Courtès) writes:
>>
>> +#ifdef HAVE_CONFIG_H
>> +# include <config.h>
>> +#endif
>
> No need to conditionalize that, just the #include is enough. And it
> normally should be the first thing in the file, if it isn't already.
I left the conditional since (i) all other files have it and (ii) it
makes sense from an Autoconf viewpoint. :-)
> Otherwise looks ok.
I committed the patch into HEAD, along with the following doc bits
(under ``Standard Character Sets''):
Currently, the contents of these character sets are recomputed upon a
successful @code{setlocale} call (@pxref{Locales}) in order to reflect
the characters available in the current locale's codeset. For
instance, @code{char-set:letter} contains 52 characters under an ASCII
locale (e.g., the default @code{C} locale) and 117 characters under an
ISO-8859-1 (``Latin-1'') locale.
I'll eventually merge it into the 1.8 branch if nobody disagrees.
Thanks,
Ludovic.