Activity

The Date Created field is not currently a LookupCriteriaInputField for the LookupSampleViewStackedResults view. Should it be added? If so, what is the behavior that should occur when it is. i.e., should the search be halted before being submitted similar to what happens for a required search field?

This is the current behavior when the BasicDatePatternConstraint is added to the Date Created input field (please also see attached screenshots):

If you enter a bad date and tab off of the field, the error constraint text will appear.

If you enter a bad date and hit search (either before or after tabbing off the field), an invalid date message is shown at the top of the screen but the date field is blanked out and the search results are still shown

Shannon Hess
added a comment - 12/May/14 12:24 PM The Date Created field is not currently a LookupCriteriaInputField for the LookupSampleViewStackedResults view. Should it be added? If so, what is the behavior that should occur when it is. i.e., should the search be halted before being submitted similar to what happens for a required search field?
This is the current behavior when the BasicDatePatternConstraint is added to the Date Created input field (please also see attached screenshots):
If you enter a bad date and tab off of the field, the error constraint text will appear.
If you enter a bad date and hit search (either before or after tabbing off the field), an invalid date message is shown at the top of the screen but the date field is blanked out and the search results are still shown

Yes to both: The Date Create field needs to be added. Client side validation should prevent submission if there is an error.

If you enter a bad date and hit search (either before or after tabbing off the field), an invalid date message is shown at the top of the screen but the date field is blanked out and the search results are still shown

This should not happen. Client side validation should prevent submission and server side validation should cause an error instead of blanking the date.

Claus Niesen
added a comment - 12/May/14 12:43 PM Yes to both: The Date Create field needs to be added. Client side validation should prevent submission if there is an error.
If you enter a bad date and hit search (either before or after tabbing off the field), an invalid date message is shown at the top of the screen but the date field is blanked out and the search results are still shown
This should not happen. Client side validation should prevent submission and server side validation should cause an error instead of blanking the date.

For validCharactersConstraints, both the client side validation and server side validation for lookup criteria fields have been fixed. For testing purposes to verify it worked for any type of validCharactersConstraint, I tested various types of constraints to the account name field such as interger only & CharsetPatternConstraint. (removed the constraint from the name before committing)

There was also a bug with the server side validation for required fields (message was "null is a required field." instead of "Travel account number is a required field.") That has also been fixed as part of this JIRA.

DemoLookUpStackedResultsAft.java has also been updated to verify the error messages

Shannon Hess
added a comment - 14/May/14 12:03 AM - edited For validCharactersConstraints, both the client side validation and server side validation for lookup criteria fields have been fixed. For testing purposes to verify it worked for any type of validCharactersConstraint, I tested various types of constraints to the account name field such as interger only & CharsetPatternConstraint. (removed the constraint from the name before committing)
There was also a bug with the server side validation for required fields (message was "null is a required field." instead of "Travel account number is a required field.") That has also been fixed as part of this JIRA.
DemoLookUpStackedResultsAft.java has also been updated to verify the error messages
Link to lookup on env14 - http://env14.rice.kuali.org/kr-krad/lookup?methodToCall=start&viewId=LookupSampleViewStackedResults