Change History (14)

I can't comment on the new tests, but the change in twisted.python.versions looks obviously fine.
Of course, you could have taken the opportunity to use a "with" statement (and perhaps made explicit the "r" argument to open(), but that's a personal preference) :-)

I can't comment on the new tests, but the change in twisted.python.versions looks obviously fine.
Of course, you could have taken the opportunity to use a "with" statement (and perhaps made explicit the "r" argument to open(), but that's a personal preference) :-)

This looks good to me. There's also some overlap with ticket #5627, but lets wait for this to get in and I'll take care of the other ticket. I guess a topfile should be added and tests run, but other than that +1 from me.