Activity

POSIX does have a way of conveying "failed to read any bytes, but we're not at EOF." It's called EINTR. We should return this errno code when Java returns 0 from a read (as opposed to -1, which means EOF in Java.)

Colin P. McCabe
added a comment - 06/Jul/12 18:53 POSIX does have a way of conveying "failed to read any bytes, but we're not at EOF." It's called EINTR. We should return this errno code when Java returns 0 from a read (as opposed to -1, which means EOF in Java.)

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

Hadoop QA
added a comment - 06/Jul/12 22:24 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535403/HDFS-470.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2751//console
This message is automatically generated.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

Hadoop QA
added a comment - 11/Jul/12 00:59 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535943/HDFS-470.002.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2780//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2780//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2780//console
This message is automatically generated.