From ant-dev-return-41197-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org Tue Jan 14 22:27:25 2003
Return-Path:
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 78794 invoked from network); 14 Jan 2003 22:27:24 -0000
Received: from exchange.sun.com (192.18.33.10)
by daedalus.apache.org with SMTP; 14 Jan 2003 22:27:24 -0000
Received: (qmail 21385 invoked by uid 97); 14 Jan 2003 22:28:46 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 21369 invoked by uid 97); 14 Jan 2003 22:28:46 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe:
List-Subscribe:
List-Help:
List-Post:
List-Id: "Ant Developers List"
Reply-To: "Ant Developers List"
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 21357 invoked by uid 98); 14 Jan 2003 22:28:45 -0000
X-Antivirus: nagoya (v4218 created Aug 14 2002)
Message-ID: <3E248F27.9040900@cortexebusiness.com.au>
Date: Wed, 15 Jan 2003 09:28:55 +1100
From: Conor MacNeill
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ant Developers List
Subject: Re: signjar task OutOfMemoryError
References: <20030114184511.13349.qmail@nagoya.betaversion.org> <3E24617D.5000209@wi.rr.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
Jim Garacci wrote:
> I did a little investigation into this, i.e. I did a cvs checkout of the
> source, and noticed that someone added a "maxmemory" attribute to
> SignJar on 12/23.
>
> I did not, however, find a bug entry for this.
Since you have a manager hat on, I guess that it is understandable that
you couldn't find it :-)
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=1284
If you look at the CVS commit log, it also mentions the bugzilla numbers
there.
> Not yet having
> contributed to an open source project, is it standard practice for the
> opensource community to just submit code fixes without recording
> bug/enhancement entries in bugzilla?
We do not require an entry in BugZilla to add or fix code in the Ant
codebase.
>
> Why was the attribute not named "memoryMaximumSize" as it was for
> javac for consistancy purposes?
> Why was a "memoryMinimumSize" attribute not added, again for
> consistancy?
It is consistent with the task.
> Why was the Java class attribute not made all lower case to match the
> rest of the source in the file?
>
The rest of the code is wrong :-) The coding conventions we use require
variables to be camelCase, not all lowercase. However, since these
variables are "protected" (which is really also a bad idea), I can not
correct this.
>
> Regardless, is there anyway to check on the status of this fix and its
> possible inclusion in 1.5.2 or 1.6?
Yes, refer to the BugZilla case above
Conor
--
To unsubscribe, e-mail:
For additional commands, e-mail: