It seems to make sense to move this menu_edit_menu_name_exists() as it's just use in a single place (the controller).
Sadly the breadbrumb test still fail, but I couldn't figure out yet why they actually fail.

Looking at this patch, I'm not sure why this needs a change notice for "menu module API changes". There are no **API functions** affected by this patch, which is shown clear by the fact that only the page callback related stuff (routing.yml, page callback file, controller) is affected.

I see the idea behind https://drupal.org/node/2119699, but to adapt that to all page controller patches, we would need to reopen several dozens of issues for change notices. We did not document one-on-one how other page callbacks were moved to classes either, that change notice only mentions one of them, although it appears it was intended to broadly cover the whole thing.

@Gábor Hojtsy, we don't need to reopen them -- just go down the list on the WSCCI meta, which I'm planning to ask some new contributors to work on in upcoming weeks. :) But if #71 is incorrect, and there are no menu module API changes, let's just add to the page callback list then and close this?

Ok, so we are not tracking that. That may be counter-productive if we want to get it done (we have a hard time getting done what we track). However, that is not related to *this* issue, so no need to discuss it here.

Added the page callback changes from this patch to https://drupal.org/node/2119699 and since there is no API change to document here otherwise AFAIS, closing.

Hm. I'm not really down with https://drupal.org/node/2119699 the way it is worded. We definitely do not want to waste anyone's time (let alone dozens of anyone's time) going through all of the WSCCI conversions and finding out what functions changed to what classes/methods, IMO. There is next to no reason that a module would ever call, say, menu_overview_page() directly. (And if there is, they can always look up the path in the routing file and figure out where it went.)

However, the title "Page callbacks converted to controllers" definitely deserves merit as a change notice; just the body should explain to module developers how to do this, using a D7 vs. D8 code example. This is indeed not a problem for this issue (or any other individual conversion issue) to solve, but is rather for #1971384: [META] Convert page callbacks to controllers.

There's already a massive change notice for the routing system. (https://drupal.org/node/1800686) Probably too massive. And then the docs are in progress, and more complete than any change notice should be. Add a link to the docs to the existing routing change notice and call it a day. Listing individual callback->controller renames is pointless.

To expect people to learn how to upgrade their modules from D7 to D8 just from change notices is a fool's errand. Change notices are simply not suited to the level of change we're talking about here.