Re: [Avf-fuse-dev] Read-combining patch

Just want to report that I've been using the fuse.01b.read-combining
patch for the last couple weeks while working on my encrypted filesystem
module. I have not had any problems, and I have been flogging FUSE
pretty well in order to test my filesystem.. I haven't examined the
code for correctness, but at least it seems to behave well.
regards,
Valient
On Mon, 2003-11-03 at 01:01, Miklos Szeredi wrote:
>
> Because, this is a non-trivial change and I would like to think about
> it and do some testing before adding it to CVS. If you'd like to do
> some testing on it, please go ahead! If your experiences are good,
> then that will increase the chances of this patch being included :)
>
> Miklos

Thread view

Hi,
I'm currently working on a Samba filesystem, to be released real soon, that
mounts the complete "network neighbourhood" (all workgroups and shares) on
one mountpoint.
I read on the list archive that Michael Grigoriev has posted a patch for
read-combining., reading 64kB blocks instead of 4kB.
Because his other patches were committed to the CVS, I was wondering why this
patch wasn't committed. This would help increasing the throughput of my
program enormously (libsmbclient likes 64kB blocks better than the 4kB that
are currently used)
Cheers,
Vincent

Hi!
> I'm currently working on a Samba filesystem, to be released real soon, that
> mounts the complete "network neighbourhood" (all workgroups and shares) on
> one mountpoint.
Cool project!
> I read on the list archive that Michael Grigoriev has posted a patch for
> read-combining., reading 64kB blocks instead of 4kB.
>
> Because his other patches were committed to the CVS, I was wondering
> why this patch wasn't committed. This would help increasing the
> throughput of my program enormously (libsmbclient likes 64kB blocks
> better than the 4kB that are currently used)
Because, this is a non-trivial change and I would like to think about
it and do some testing before adding it to CVS. If you'd like to do
some testing on it, please go ahead! If your experiences are good,
then that will increase the chances of this patch being included :)
Miklos

Just want to report that I've been using the fuse.01b.read-combining
patch for the last couple weeks while working on my encrypted filesystem
module. I have not had any problems, and I have been flogging FUSE
pretty well in order to test my filesystem.. I haven't examined the
code for correctness, but at least it seems to behave well.
regards,
Valient
On Mon, 2003-11-03 at 01:01, Miklos Szeredi wrote:
>
> Because, this is a non-trivial change and I would like to think about
> it and do some testing before adding it to CVS. If you'd like to do
> some testing on it, please go ahead! If your experiences are good,
> then that will increase the chances of this patch being included :)
>
> Miklos

> Just want to report that I've been using the fuse.01b.read-combining
> patch for the last couple weeks while working on my encrypted filesystem
> module. I have not had any problems, and I have been flogging FUSE
> pretty well in order to test my filesystem.. I haven't examined the
> code for correctness, but at least it seems to behave well.
Thanks! Together with Vincents report that's quite strog evidence
that the patch is OK. I'll apply it to CVS, and then think about it
afterwards. I don't think this is the final solution, since in some
cases it's good to be able to read in small chunks (e.g. ftp FS, slow
network connection, file examined with 'less').
Miklos