webware-discuss

I took a look at TaskKit:
I added Docs/ and Docs/TODO-TaskKit.text (install.py wouldn't run without
Docs/)
I added Tests/
- Moved the test in the main code of TaskManager.py to Tests/BasicTest.py
- I added Test.py in the same vain as UserKit/Tests/Test.py. It uses
MiscUtils.unittest. The tests should be based on assertions. I haven't put
anything real in there yet.
I broke TaskManager into separate files for each class, like we do for the
other components. I was amused to find there's not even a class named
TaskManager... :^)
WebKit's taskManager() returns a Scheduler(). Seems like the method should
be renamed scheduler() (or the class gets renamed to TaskManager).
Request:
We are in serious need of quality doc strings. Right now there are
practically no doc strings for anything.
Tom & Jay, since you have done the work on this Kit, could you please add
some ASAP?
-Chuck

Chuck Esterbrook wrote:
>
> I took a look at TaskKit:
>
> I added Docs/ and Docs/TODO-TaskKit.text (install.py wouldn't run without
> Docs/)
>
> I added Tests/
> - Moved the test in the main code of TaskManager.py to Tests/BasicTest.py
> - I added Test.py in the same vain as UserKit/Tests/Test.py. It uses
> MiscUtils.unittest. The tests should be based on assertions. I haven't put
> anything real in there yet.
>
> I broke TaskManager into separate files for each class, like we do for the
> other components. I was amused to find there's not even a class named
> TaskManager... :^)
right, when starting to think about that, I was sure it should
be named TaskManager, when implementing a first version, Scheduler
seemed
a more natural name.
What I planned was to use the Manager class (you mailed here, that you
are going to implement that interface) to derive a class TaskManager
from that, which has a property self._scheduler..
> WebKit's taskManager() returns a Scheduler(). Seems like the method should
> be renamed scheduler() (or the class gets renamed to TaskManager).
right now scheduler is indeed more appropriate, but later (with the
Manager classes) taskManager will be ok..
B.T.W. I havn't found any Manager.py yet..
> Request:
>
> We are in serious need of quality doc strings. Right now there are
> practically no doc strings for anything.
>
> Tom & Jay, since you have done the work on this Kit, could you please add
> some ASAP?
ok, as far as I can see, there are already docstrings you added since
this
mail, but I will complete the rest where necessary.
I like what you did with the code (the restructuring,...), although I
feel
a little shaky with the TaskManager code incorporated in Application.py,
but probably it is better to test it straight away at a mission critical
place
instead of waiting to see how it behaves at other places.
I will make my standard performance tests during the next week and see
it the wait problem (and unprecise timing) are still there.
Now it's also time to add some glue around TaskKit (with UserKit..)
and make some Admin Servlets for that. I'll look at that for next week.
I remember the 28. as some kind of deadline..
--
Tom Schwaller
http://www.linux-community.de