Conversation

All these tests failed on Windows because something likesftp://%HOSTIP:%SSHPORT%PWD/
expanded tosftp://127.0.0.1:1234c:/msys64/home/bla/curl/
and then curl complained about the port number ending with a letter.

Use the original POSIX path instead instead of the Windows path created
in checksystem to fix this.

All these tests failed on Windows because something like
sftp://%HOSTIP:%SSHPORT%PWD/
expanded to
sftp://127.0.0.1:1234c:/msys64/home/bla/curl
and then curl complained about the port number ending with a letter.
Use the original POSIX path instead instead of the Windows path created
in checksystem to fix this.
Closes

This comment has been minimized.

The Windows path version in %PWD is still required to pass to a native Windows curl in the general case, e.g. when using the FILE protocol or just local file names. The new one is only required for OpenSSH.

All these tests failed on Windows because something like
sftp://%HOSTIP:%SSHPORT%PWD/
expanded to
sftp://127.0.0.1:1234c:/msys64/home/bla/curl
and then curl complained about the port number ending with a letter.
Use the original POSIX path instead of the Windows path created in
checksystem to fix this.
Closescurl#2920

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.