ps - please update your editor settings to use spaces rather than tabs for indentation. I didn't fix this patch because it looks endemic to the loggraph contrib, but you might consider fixing this at some point.

Patrick Hunt
added a comment - 05/Jul/10 20:59 +1, thanks Ivan!
ps - please update your editor settings to use spaces rather than tabs for indentation. I didn't fix this patch because it looks endemic to the loggraph contrib, but you might consider fixing this at some point.

Hadoop QA
added a comment - 29/Jun/10 16:47 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448307/ZOOKEEPER-798.patch
against trunk revision 958096.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/console
This message is automatically generated.