su, 2010-02-14 kello 11:51 -0700, Charles R Harris kirjoitti:
[clip]
> There are more - grep -r ob_type numpy/* - how do you want to go about
> fixing these things?
self->ob_type is fine if `self` is a plain PyObject* and not a subclass
pointer.
The issue in changing all of them to Py_TYPE is that there's no Py_TYPE
on Python 2.4, and we define it locally only in core/src/private so it's
a bit icky to include npy_3kcompat.h outside that subtree.
Anyway, with suitable #ifndef's there should be no problem.
[clip]
> The py3k branch doesn't compile:
>> numpy/core/src/multiarray/buffer.h: At top level:
> numpy/core/src/multiarray/buffer.h:14: error: conflicting types for
> ‘_descriptor_from_pep3118_format’
> numpy/core/src/multiarray/common.c:220: note: previous implicit
> declaration of ‘_descriptor_from_pep3118_format’ was here
That was fixed in 48f8edfdc8fc24484b2c91d581e00b4024a341ac
Pauli