On Tue, 23 Sep 2008 15:30:53 -0700, "Ed Swierk" <eswierk at arastra.com>
wrote:
> On Wed, Sep 3, 2008 at 5:23 PM, Ed Swierk <eswierk at arastra.com> wrote:
>> Thanks for the feedback. I have addressed most of your comments;
>> please see the attached patch.
>>>> I will address your comment about the duplicate struct dimm_size
>> declaration separately. Would it make sense to put it in a file common
>> to all Intel northbridges, say, src/northbridge/intel/mem.h, and then
>> remove it from the various raminit.c's?
>>>> Signed-off-by: Ed Swierk <eswierk at arastra.com>
>> Pinged-by: Ed Swierk <eswierk at arastra.com>
>Wait, making a common file for this?
struct dimm_size {
unsigned long side1;
unsigned long side2;
};
Four four lines of code that seems a little silly to me? Can you resend you
patch, I don't think I got it.
--
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org