My biggest concern is integration with non-tycho maven plugins.
Currently, we have reasonably good story about all/most Tycho
dependencies being pushed back to MavenProject, and this is simply not
possible from a tycho mojo. We really need to hook into Maven dependency
resolution logic to do this right, but I am not even sure if maven
provides required extension points.
Second, I think it is important to discuss and agree how P2 metadata
gets generated and consumed through various build stages. This is
something I was saying for a long time and fundamental change to Tycho
dependency resolution seems like a good time for this.
--
Regards,
Igor
On 11-10-21 10:15 AM, Oberlies, Tobias wrote:

So calling MavenProject.setContextValue won't work if called from a
Mojo? This would in fact be a problem.
I don't mind discussing the idea, but I just also wanted to show
something. The first POC that I am working on is to execute the code
from TychoMavenLifecycleParticipant.afterProjectsRead from a Mojo
instead of the "after projects read" event. The new module order
mechanism needed for this already works pretty well, but there are
still a few integration tests failing. Do you want to see the state
right now, or would it be sufficient to wait until I have something
kind of working?
Note that all I'm doing is still very far away from being integrated
into master - from the first POC there are still a lot of steps
needed before the refactoring is reasonably free of regressions and
brings real benefits. So there will be a lot of time to discuss...
Regards Tobias

modules which need it." won't work because of the way maven
manages MavenProject instance between mojo executions. And I really
think major design changes like this should be discussed on
tycho-dev.
-- Regards, Igor