Hi,
>> Ok, I completely forgot about that. There is the downside that the way
>> it is currently written any implementation of update_area_complete will
>> be called always, and causes a little work in
>> handle_dev_update_async_helper.
Don't think this is a big issue. Due to lazy rendering this should
rarely happen unless explicitly requested from the guest or
qxl_render_update, in which case we'll have the overhead _anyway_.
> Can you contribute your opinion on this? Do you think it's better to:
> - add the new API spice_qxl_update_area_dirty_async
> - use update_area_complete always
> - set update_area_complete when it is required in qxl_render_update,
> and unset it in qxl_render_update_complete
> - something else
I think "use update_area_complete always" is the best option. We can
also hook up surface dirty tagging there (see yonits new
qxl_dirty_surfaces function), which would be a good thing from the
correctness point of view.
cheers,
Gerd