On Tue, 27 Nov 2007 14:55:22 +0000 "Richard W.M. Jones" wrote:
> Daniel Veillard wrote:
> > On Tue, Nov 27, 2007 at 01:19:48PM +0000, Richard W.M. Jones wrote:
> >> Morning Saori,
Hello Rich,
> >> You need to call the error function for each error condition, eg:
> >>
> >> if (mapstr == NULL) {
> >> xenXMError (domain ? domain->conn : NULL, VIR_ERR_NO_MEMORY,
> >> __FUNCTION__);
> >> return -1;
> >> }
> >>
> >> The inner loop is still quadratic even with snprintf because you're
> >> copying the string each time. I've changed it below to use a virBuffer
> >> instead.
> >>
> >> If you ./configure --enable-compile-warnings=error then any warnings
> >> will turn into errors. There was one warning in the patch you sent.
> >>
> >> Modified version of the patch is attached. **NOTE** I've only compiled
> >> it, because I don't have any suitable machine to test it on.
Oh, that's great. I like this patch !
> Saori:
>
> If you can check that the patch works for you, then we can commit it.
I checked the patch and confirmed that is working properly.
Many thanks to all for your help !
Regards,
Saori.