David Nolen
added a comment - 25/Oct/12 11:11 AM This looks great but could we copy over the related tests for simple unification and partial map unification? You can run these with script/test. Thanks.

I patched up one bug, noted the failing unification for partial-map (I will open a new ticket for it).

Also, prep is failing on some JS Object because of a with-meta call. See the tests for the cases where that happens. I couldn't figure it out, but I haven't hit this in my project code (I'm doing extremely simple unification and binding-map stuff).
I'll open up a new ticket for that as well.

===
edit: take version 3 - removed print statements I left in the test file

Paul deGrandis
added a comment - 25/Oct/12 12:39 PM - edited I promise to write tests from now on
I patched up one bug, noted the failing unification for partial-map (I will open a new ticket for it).
Also, prep is failing on some JS Object because of a with-meta call. See the tests for the cases where that happens. I couldn't figure it out, but I haven't hit this in my project code (I'm doing extremely simple unification and binding-map stuff).
I'll open up a new ticket for that as well.
===
edit: take version 3 - removed print statements I left in the test file