Posted on 18 Nov 2010, 7:47 by BarryKdownload_file size fixThe 'download_file' script checks first that the remote file exists, and obtains its size.

This worked for an http protocol site, however for an ftp site the file-size information is returned differently. I have modified download_file to correctly obtain the remote file size for an ftp URL.

Posted on 18 Nov 2010, 8:04 by 01mickothanksYes I just discovered that myself! (actually I knew it but they have changed it recently)
Now they list the whole directory and sizes, so I'm grepping the exact size with the exact file name, I guess you do similar.
Cheers
(and aren't some of those wget header files wild? .. turtle power? hehe!)

Posted on 18 Nov 2010, 8:09 by 01mickotypoforgot to mention the typo at line 50, 'abiwotd'

I put code in to detect download_file and if it's there it uses it, Otherwise the old wget (with some params) is run from rxvt -e
Cheers

Posted on 20 Nov 2010, 21:33 by 01mickowget woesHi Barry

One particular user is reporting failure with PPM and my sfs_grab script (which uses 'download_file') but success with quickpet, http://www.murga-linux.com/puppy/viewtopic.php?p=469115#469115It just dawned on me what it is... the "-4" option with wget. (ipv4 vs ipv6, if that makes sense)
aarf (I'm sure you remember him/her) was considerably vocal and helpful on this issue in quickpet development, but what perplexes me is aarf's lack of problems with PPM at the time, which was some months ago.
So.. for some it seems the '-4' option is needed, but I bet for others it may bork their download. Incidentally, in all of quickpet's testing, since the '-4' option was added to the wget call, there have been no problems reported, that doesn't mean they are not there!
Cheers

Posted on 4 Jan 2011, 9:57 by 01mickosfs issue, download_filejpeps reported an sfs issue downloading the devx for lupu using my sfs_grabber
http://www.murga-linux.com/puppy/viewtopic.php?p=483290#483290I narrowed it down to some code in download_file that needs 3X the space to allow for installation of the file.

Here's my proposal At line 93 I added a case for pupmodes 6 and 12 conditional upon the file being an sfs,