Vinod Kumar Vavilapalli
added a comment - 21/Dec/11 00:27 Gone through the patch again, nothing more to cleanup. Not possible to write new tests as we are simply replacing references to configuration with JobConf.
Existing tests should continue to validate this changed code.

Vinod Kumar Vavilapalli
added a comment - 22/Dec/11 20:11 Some of the javac warnings are bogus, they are related to JobConf deprecation and I already suppressed them. Addresses a couple of warnings which are valid.

Hadoop QA
added a comment - 22/Dec/11 20:57 +1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508430/MAPREDUCE-3567-20111222.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1497//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1497//console
This message is automatically generated.