On 2014/06/06 22:11:56, dcheng wrote:
> rslgtm if it doesn't break any builders and incremental build after applying
> FastMobileScrolling works. Sorry for the trouble.
Thanks, dcheng. To do the test, I manually *copied* all generated files under
core, modules, and platforms back to gen/blink. Then I applied the
FastMobileScrolling patch. The build went through fine. I am checking the commit
flag now.

On 2014/06/07 02:16:47, haraken wrote:
> > to avoid including potential staled files.
>
> Just help me understand: In what situation can this happen, specifically?
Hi, haraken, here's the full story.
1. Originally, all generated files are located under gen/blink. E.g.,
HTMLNames.h
and cpp files include it using
"#include "HTMLNames.h"
since gen/blink is in the include search path.
2. The CL that moves the generated files to their component's directory changed
the location.
E.g., HTMLNames.h is generated under gen/blink/core. The cpp file still uses
"#include "HTMLNames.h"
because gen/blink/core is added in the include search path.
But if you don't do a clean build after this CL, the gen/blink/HTMLNames.h still
exists in your output dir.
And gen/blink is also in the search path (for including v8 files).
If "gen/blink" is found first, the staled gen/blink/HTMLNames.h is used.
This will cause problem only if HTMLNames.h is regenerated with different
content.
Some people have reported the problem and it also happened to my own CL related
to fastmobilescrolling flag.
3. This CL changes the order of search paths, so gen/blink/core is found before
gen/blink and the staled files are ignore.
Thanks.

On 2014/06/07 15:22:59, c.shu wrote:
> On 2014/06/07 02:16:47, haraken wrote:
> > > to avoid including potential staled files.
> >
> > Just help me understand: In what situation can this happen, specifically?
>
> Hi, haraken, here's the full story.
> 1. Originally, all generated files are located under gen/blink. E.g.,
> HTMLNames.h
> and cpp files include it using
> "#include "HTMLNames.h"
> since gen/blink is in the include search path.
> 2. The CL that moves the generated files to their component's directory
changed
> the location.
> E.g., HTMLNames.h is generated under gen/blink/core. The cpp file still uses
> "#include "HTMLNames.h"
> because gen/blink/core is added in the include search path.
> But if you don't do a clean build after this CL, the gen/blink/HTMLNames.h
still
> exists in your output dir.
> And gen/blink is also in the search path (for including v8 files).
> If "gen/blink" is found first, the staled gen/blink/HTMLNames.h is used.
> This will cause problem only if HTMLNames.h is regenerated with different
> content.
> Some people have reported the problem and it also happened to my own CL
related
> to fastmobilescrolling flag.
> 3. This CL changes the order of search paths, so gen/blink/core is found
before
> gen/blink and the staled files are ignore.
> Thanks.
ah, got it; thanks for the clarification. LGTM.