From: Stefan Beller <sbeller@google.com>
To: Antonio Ospite <ao2@ao2.it>
Cc: git <git@vger.kernel.org>, Brandon Williams <bmwill@google.com>,
Daniel Graña <dangra@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Richard Hartmann <richih.mailinglist@gmail.com>
Subject: Re: [RFC PATCH v2 05/12] submodule: use the 'submodule--helper config' command
Date: Thu, 2 Aug 2018 11:59:09 -0700
Message-ID: <CAGZ79kbwK1Kf2Oov9W9+UBBJpiOfDgZjZakmGP3iqxPPAhAUPQ@mail.gmail.com> (raw)
In-Reply-To: <20180802134634.10300-6-ao2@ao2.it>
On Thu, Aug 2, 2018 at 6:47 AM Antonio Ospite <ao2@ao2.it> wrote:
>
> Use the 'submodule--helper config' command in git-submodules.sh to avoid
> referring explicitly to .gitmodules by the hardcoded file path.
ccol! This is the corner stone to the work of the previous patches. Nicely done!
> This makes it possible to access the submodules configuration in a more
> controlled way.
>
> Signed-off-by: Antonio Ospite <ao2@ao2.it>
> ---
>
> Note that there are other instances of "git config -f .gitmodules" in test
> files, but I am not touching those for now.
I just checked and this converts all of git-submodule.sh which would
have been my expectation as that is the real product.
The tests are fine to use "git config -f .gitmodules" as there we want to
setup a specific environment to be tested? So I would think even future
patches in this series will not touch test files for such a conversion
as in here.
Stefan