Results:

Failure content_browsertests on Intel GPU on Mac on Mac-10.14 Failure remoting_unittests on Intel GPU on Mac on Mac-10.14 Failure unit_tests on Intel GPU on Mac on Mac-10.14 Failure webkit_layout_tests on Intel GPU on Mac on Mac-10.14

Comments

[fuchsia] Make `pm serve` run silently.
"pm serve" runs reliably and no longer needs to run verbosely.
The remaining issues with amber-based deployments tend to be on the
device, not on the HTTP server.
This change prevents a lot of httpd log spam from being sent to the
console.
Bug: 895627
Change-Id: If5e63785c8d70568bd4b1b99a18f4c59acc2a48e
Reviewed-on: https://chromium-review.googlesource.com/c/1407255
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622272}

Comments

Use px values for browser controls height and offset in java
This patch converts most of the float values that were previously
storing integers into proper integers and updates the related logic.
The idea here is to remove all of the unnecessary float comparison
and rounding that previously plagued the code; especially since all
of the values are tracked in pixels anyway (rather than DP).
Bug: 882508
Change-Id: I664fb52e3636aa99ac4937c9e3c1b29a4866eee6
Reviewed-on: https://chromium-review.googlesource.com/c/1404391
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622266}

Comments

Update profiling.md with link to internal tools
I thought about linking to a shared doc that said these same things,
but this documentation seems to have everything I would want to say.
Change-Id: I027ac5e9f6e5a6925306e405ae36e0c1f6fcf938
Reviewed-on: https://chromium-review.googlesource.com/c/1407948
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622258}

Comments

Store and set stale frame content screenshot when the frame is evicted
This patch captures the web content surface as a texture and displays
it on the RenderWidgetHostView until a new compositor frame is submitted
by the viz client. This allows the browser to display stale content
instead of a white solid color during animations.
The decision to show stale content or a solid color is done by the
WebContentsDelegate associated with the RenderWidgetHostView and its
DelegatedFrameHost. For this patch, the default is to show a solid
color on frame eviction. In the case of a tabbed browser, the Browser
(which implements the WebContentsDelegate) chooses to show stale content
if the frame being evicted is from an active tab.
Bug: 897826
Change-Id: I3346f3dec79780d107d2c96b4382886690a69570
Component: RenderWidgetHostViewAura, DelegatedFrameHost, ui layer
Reviewed-on: https://chromium-review.googlesource.com/c/1369714
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622255}

Comments

[Cast MRP] Media commands, media status, and SET_VOLUME.
Forked from https://chromium-review.googlesource.com/c/chromium/src/+/1234371
This patch implements media commands sent from the SDK to the receiver,
as well as media status messages from the receiver to the SDK.
This patch also implements the SET_VOLUME message which sets the system
level volume and not considered part of media commands.
Bug: 809249
Change-Id: Ib6d0a8764ca16ec9f0c5748df16e2a7c3f972be0
Reviewed-on: https://chromium-review.googlesource.com/c/1372666
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622254}

Comments

[AppCache] ReportBadMessage rather than DCHECK for first_party_url_ check.
If first_party_url_ hasn't been initialized when SelectCache is called it
means the renderer is somehow trying to select a Cache for a main resource
that was never actually fetched. That is only possible if the renderer is
misbehaving, so return false to trigger a mojo::ReportBadMessage.
Bug: 917827
Change-Id: I9c02a6ea4ea328c736f24cf2b2666363192de03f
Reviewed-on: https://chromium-review.googlesource.com/c/1407910
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622250}

Comments

[Extensions] Reduce the pixel threshold for icon visibility.
In IsRenderedIconSufficientlyVisible(), we render an icon against the
background toolbar color and check the resulting pixel RGB values
against a threshold. The current threshold results in over 70% of
icons declared in manifests being considered not visible.
Bug: 805600
Change-Id: Ie45b2e523d152fddebffdedd28749a05684c7fe7
Reviewed-on: https://chromium-review.googlesource.com/c/1407908
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622248}

Comments

[Refactor] Split out directions from WebFocusType
Focus code only cares about how focus is being moved, not the direction.
Spatial navigation code used to reuse this enum to also communicate the
direction of navigation.
In https://crrev.com/d5d79fa304dd23c0216051af79b325d292b93dba we moved
the spatial navigation code out of FocusController. Rather than passing
a "dummy" directional value to the focus controller, this CL creates a
new enum for spatial navigation direction (used only by SpatNav code)
and replaces the focus enum's directional values with a single value for
SpatialNavigation.
Bug: 919158
Change-Id: If092c1464957722dec1cd44be1591d6f8c0a17c9
Reviewed-on: https://chromium-review.googlesource.com/c/1407497
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622247}

Comments

Reland "Allow dragging for NonClientArea (i.e. DraggableRegions)"
The non-client area in ProxyWindow is set through "DraggableRegions",
and this section is used for draggability of the window (see
https://cs.chromium.org/chromium/src/apps/ui/views/app_window_frame_view.cc?sq=package:chromium&g=0&l=196).
The same logic should be introduced on Mash, otherwise frameless
app window can't be dragged.
The previous CL (r622061) was reverted since this CL actually
makes any browser-windows unresizable -- this draggable-regions
check should be done only when the located event isn't on the
edge (i.e. keep the existing behavior as long as it returns
values other than HTCLIENT).
Bug: 920469
Test: ash_unittests
Change-Id: I9389e35ae8cb89b84df6517e932acaa5cb7ebaa7
Reviewed-on: https://chromium-review.googlesource.com/c/1407776
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622239}

Comments

Add logging to debug nullptr in TabWebContentsDelegateAndroid.addNewContents
Adds logging which verifies that the |delegate_| used by WebContentsImpl for
WebContentsCreated is the same used for AddNewContents. A failure will result
in a crash on Android.
Helps debug by providing the following info:
- If delegate is null at WebContentsCreated and non-null at AddNewContents,
there is a race between WebContentsCreated and delegate assignment.
- If delegate is non-null in both cases, but different, it means we're
updating the delegate between the two, which is also not safe.
- If no log messages are fired and we still crash, it means AddNewContents
was called twice.
Bug: 758186
Change-Id: I103cd77c148af25adb1c7002354bb3b853c913b5
Reviewed-on: https://chromium-review.googlesource.com/c/1407269
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622232}

[Fuchsia] Fix SocketPosix::IsConnected() pre-Connect() behaviour.

Comments

[Fuchsia] Fix SocketPosix::IsConnected() pre-Connect() behaviour.
SocketPosix::IsConnected() has a Fuchsia-specific implementation, to
work-around the lack of a working recvmsg(MSG_PEEK). This was
incorrectly returning |true| when a SocketPosix was not-yet-connected.
Fix the Fuchsia implementation to report |false| in this case, and
re-enable a TCPClientSocket test that depends on it.
Add a TCPClientSocket test for the behaviour of both the IsConnected()
and IsConnectedAndIdle() APIs.
Bug: 887587
Change-Id: I5b7ef9fa7f98364ee5612cf8d472a13ebbeab164
Reviewed-on: https://chromium-review.googlesource.com/c/1407505
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622231}

Comments

MobileSetupUI: Avoid calls to shill when getting cellular info
Instead of getting cellular network service and device properties
directly from shill, use the values cached in chromeos::NetworkState and
chromeos::DeviceState.
The only piece of information that was not currently cached in
NetworkState was payment portal post data (data that should be sent to
the payment portal with POST requests) - added
chromeos::NetworkState::payment_post_data()
Along the way fix usages of CallJavascriptUnsafe and remove some
unneeded includes.
BUG=778021
Change-Id: Ie848686cc8d82154b40e4d944d83f503aac2e363
Reviewed-on: https://chromium-review.googlesource.com/c/1406190
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622228}

Comments

Remove apps and themes from kHardcodedPartOfCorbAllowlist.
CORB doesn't impact:
- Chrome Apps (which are explicitly excluded by
DoContentScriptsDependOnRelaxedCorb function in
//extensions/browser/url_loader_factory_manager.cc)
- Chrome Hosted Apps and Chrome Themes (which are both unable to perform
cross-origin requests from content scripts)
Nevertheless, entries in the kHardcodedPartOfCorbAllowlist accidentally
included entries which corresponded to apps and/or themes. This is
somewhat expected given the design of RAPPOR data gathering pipeline
which (in an attempt to protect private of Chrome users) noisifies the
data and can return false positives (this is especially expected in
cases where the set of all expected values is now known - we know
extensions in the Chrome Web Store, but we can't account for extension
ids corresponding to extensions under development or not published
through the public store). See also:
- https://www.chromium.org/developers/design-documents/rappor
- (internal, Google-only) go/rappor101 which describes this
problem in the "3.2 Limitations" section.
Because of the above, we used Chrome Web Store metadata to classify
items on kHardcodedPartOfCorbAllowlist as either extension, app,
platform_app or theme and removed all non-extension items from the
allowlist.
Bug: 846346
Change-Id: I45fd9437f3dae9b57d6f5d1ae79f389b5a528bbc
Reviewed-on: https://chromium-review.googlesource.com/c/1407604
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622227}

Set the display mode from the CreateViewParams not from RenderWidget.

Comments

Set the display mode from the CreateViewParams not from RenderWidget.
We want to not use the RenderWidget before it's initialized, and we
want to move initialization to where there is a main frame already
(or part of making the main frame). So stop using the RenderWidget
to grab the display mode when setting it on the WebView, since we
have it in the CreateViewParams anyways.
R=avi@chromium.org
Change-Id: Ia9d5a1ecf9dc222a662bfc74de94764f50143ab3
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1407635
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622226}

Comments

Remapping Quic HTTP data stream into HTTP/3 format.
Previously data that passes through QuicSpdyStream is simply the raw body. In HTTP/3, data are contained in data frames. This CL implements data frames.
When the stream wants to write data, HttpEncoder will be used to produce a frame header that will be sent before the body.
On the other side when the stream receives new data from the sequencer, HttpDecoder will be used to strip the header and then the stream will store the actual body that will be available for applications to use.
Merge internal change: 226378053
Update QuicSpdyStream's constructor from PendingStream consistent with the original constructor. Version 99 only. Not protected.
Merge internal change: 226924343
Change-Id: Ieb516c83f5f8fa673928c5ad8be304f90ab24d63
Reviewed-on: https://chromium-review.googlesource.com/c/1399423
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622216}

Comments

[AF Sync] React to local changes in metadata sync bridge
This CL re-implements how the new metadata sync bridge reacts to local
changes. This CL reflects the new design for the data&metadata bridge
interaction.
The CL re-introduces a local cache that was recently removed because it
is needed (exactly) for reacting to local changes. I am sorry for the
back-and-forths.
The CL also updates the implementation of Get*Data to load the data from
the cache as this is needed by the unit-tests to be able to test both
writing to cache and writing to the DB.
Bug: 853688
Change-Id: I6de2da7b0126a05ffa13315c8376c43e9cbd5454
Reviewed-on: https://chromium-review.googlesource.com/c/1406711
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622197}

Comments

Don't use InvertColor() to try and guarantee contrast.
In particular, inverting a light color may give you an even lighter color, e.g.
#8070ff (contrast ratio against white 3.69) inverts to #7f8f00 (contrast ratio
against white 3.6). There's a function in color_utils called GetReadableColor()
that tries to lightness-invert the color, but that turns out not to work well
either, e.g. HSL 60,100%,36% (contrast ratio against white 2.12)
lightness-inverts to HSL 60,100%,64% (contrast ratio against white 1.06).
Instead use GetColorWithMinimumContrast(). This will reduce the ontrast of some
cases compared to current behavior, but it will also guarantee no cases are
below the minimum.
Bug: 659451
Change-Id: I09b5850e0ba3b76ca6e004c9320131ac175cbe43
Reviewed-on: https://chromium-review.googlesource.com/c/1406241
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622194}

Comments

[Extensions] Fix table appearance in activity log view
Change appearance of the activity log to be more inline with other webui
based tables. This CL also adds the functionality for activity log items
to be expanded and collapsed if an item is associated with one or more
urls.
A placeholder delete icon is also added for this CL. The functionality
for deleting specific activity log items will be implemented in a future
CL.
How to test changes:
1) Run chrome locally with the flag "enable-extension-activity-logging"
i.e. "out/Default/chrome --enable-extension-activity-logging"
2) navigate to chrome://extensions (install extensions if needed)
3) click on "Details" for an extension to see the details page.
4) click on "View Activity log" on the details page for that extension.
2b) Alternatively, the activity log can be found at:
chrome://extensions/?activity=<extension_id>
Design mock: https://screenshot.googleplex.com/WAtvuqifSDM.png
Screenshots:
Before: https://imgur.com/a/ZUIBtE9
After: https://imgur.com/a/5CCeQf9
With arrows showing alignment specs: https://imgur.com/a/DwPu51k
Old (Patchset 1) https://imgur.com/a/LzPGB5d
Bug: 908595
Change-Id: I7d5f8aa5f5050bee929cdc4489f80114d7576d75
Reviewed-on: https://chromium-review.googlesource.com/c/1381375
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622193}

Comments

Allow the installability check to respect --unsafely-treat-insecure-origin-as-secure.
InstallableManager uses SecurityStateTabHelper to check the security
status of a tab, and strictly verifies the status of the SSL
certificate. However, this means that any origins whitelisted using the
--unsafely-treat-insecure-origin-as-secure flag are still regarded as
insecure for the purposes of the check.
This CL allows InstallableManager to respect the flag by exposing
content::IsWhitelistedAsSecureOrigin in content/public. This allows the
strictness of the check to be maintained whilst allowing users of the
flag to have their sites considered as installable (e.g. testing sites
on local network IP addresses).
BUG=864391
Change-Id: Id801cc74524e760a1a502dd2a7de7b026cb86c33
Reviewed-on: https://chromium-review.googlesource.com/c/1401830
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622182}