[gstreamer-bugs] [Bug 506549] fbdevsink patch

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
------- Comment #3 from Sebastian Dröge 2007-12-31 10:08 UTC -------
Also you should add the acceptable ranges of bpp, depth, etc to the pad
template. And it might make sense to set the device field of the instance
struct in the init method already to the default value.
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.

Thread view

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
Summary: fbdevsink patch
Product: GStreamer
Version: HEAD CVS
Platform: Other
OS/Version: All
Status: UNCONFIRMED
Severity: enhancement
Priority: Normal
Component: gst-plugins-bad
AssignedTo: gstreamer-bugs@...
ReportedBy: sean@...
QAContact: gstreamer-bugs@...
GNOME version: Unversioned Enhancement
GNOME milestone: Unspecified
added support for linux framebuffer video sink
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
Sebastian Dröge changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |slomo@...
------- Comment #2 from Sebastian Dröge 2007-12-31 09:57 UTC -------
Generally looks good from a short look but why didn't you use GstVideoSink as
base class? Would probably save you some lines of code :)
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
------- Comment #3 from Sebastian Dröge 2007-12-31 10:08 UTC -------
Also you should add the acceptable ranges of bpp, depth, etc to the pad
template. And it might make sense to set the device field of the instance
struct in the init method already to the default value.
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
Wim Taymans changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wim.taymans@...
Attachment #101888|none |needs-work
Flag| |
------- Comment #4 from Wim Taymans 2007-12-31 13:40 UTC -------
- extend GstVideoSink, this will set the default video properties correctly,
like QoS and max-latency.
- use start()/stop() to open close the device. Make getcaps only return the
device specific info when it's opened.
- be as specific as you can in the caps of the template, I think you can add
some more properties.
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
Sean D'Epagnier changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101888|0 |1
is obsolete| |
------- Comment #5 from Sean D'Epagnier 2008-01-01 03:09 UTC -------
Created an attachment (id=101931)
--> (http://bugzilla.gnome.org/attachment.cgi?id=101931&action=view)
updated patch, use patch -p1
I think I am extending from GstVideoSink now, I am new to gclass stuff so it is
hard to tell. Some of the other drivers use GstVideoSink and GstBaseSink
similarly (ximagesink)
I am using start() and stop() for opening and closing now. I return FALSE if
there is an error with open, ioctl, or mmap. I am not sure if this is correct
handling or not, it seems to cause the pipeline to fail to pause.
I am more specific with the template of the caps now. I specify
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
------- Comment #6 from David Schleef 2008-01-06 22:04 UTC -------
Committed, with a few minor modifications. Moved to sys/, added <stdint.h>,
and changed a malloc/strcpy to g_strdup().
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
------- Comment #7 from David Schleef 2008-01-06 23:01 UTC -------
Some comments:
* Please move declarations to the top of blocks. It's the gstreamer style.
* Use the glib macros for endianness changing.
* Add a test for big endian, and a g_warning() asking the BE user to report
feedback on whether it works or not.
* Please add checks for failed opens and mmaps in gst_fbdevsink_stop()
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
http://bugzilla.gnome.org/show_bug.cgi?id=506549
GStreamer | gst-plugins-bad | Ver: HEAD CVS
Sebastian Dröge changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101931|none |committed
Flag| |
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
Target Milestone|HEAD |0.10.6
--
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.
You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=506549.