Comments

Adds support for using a OMAP dual-mode timer with PWM capability
as a Linux PWM device. The driver controls the timer by using the
dmtimer API.
Cc: Grant Erickson <marathon96@gmail.com>
Cc: NeilBrown <neilb@suse.de>
Not-Yet-Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
Hello,
First of all this is a RFC patch not to be merged in it's current state.
There are two problems with the driver now as I see.
* I don't think this hack will fly on mainline.
#include <../arch/arm/plat-omap/include/plat/dmtimer.h>
I use the above include path for testing now since the plat include doesn't
work with DT multiplatform build.
Joel Fernandes is working on moving the dmtimer driver into
drivers/clocksource so eventually this will be fixed.
* The drivers calls omap_dm_timer_set_source() to set the source. This should
decided in DT on the timer node itself. There is also work in this area by
Tero Kristo and Joel has said that this function will become a no-op when
this work is done.
So for now it be nice if people could look at the dmtimer API usage, the DT
bindings and the PWM part of the driver to see if that looks okay.
Joel: I have tested this driver on top of your last dmtimer cleanup patches
and it works nicely. It would be nice if you could take a look at the dmtimer
API usage. I think you might be the one who knows dmtimer best now.
A bit of history on this driver.
First version made by Grant Erickson for the old PWM API back in 2010. Later
NeilBrown converted the driver to the new PWM API and submitted [1] it to the
mail list back in 2012. The driver was then reviewed by Thierry Reding and Jon
Hunter. NeilBrown also later added DT support to the driver. I have since made
some fixes, removed platform data support and added DT documentation.
[1]: https://lkml.org/lkml/2012/12/12/51
regards
Joachim Eastwood
Documentation/devicetree/bindings/pwm/pwm-omap.txt | 15 ++
drivers/pwm/Kconfig | 9 +
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-omap.c | 273 +++++++++++++++++++++
4 files changed, 298 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pwm/pwm-omap.txt
create mode 100644 drivers/pwm/pwm-omap.c