Hi Simon,
> This code seems to be entirely othogonal, so remove the #ifdef and put> the condition in the Makefile instead.
I'm fully with you in respect of cleaning/refactoring the ext4 u-boot
code.
I will test this change when I only find some time ...

Hi Simon,
> > > This code seems to be entirely othogonal, so remove the #ifdef and> > put the condition in the Makefile instead.> > I'm fully with you in respect of cleaning/refactoring the ext4 u-boot> code.> > I will test this change when I only find some time ...>
Are you doing any work on ext4 code refactoring/rewritting at u-boot?

Hi Lukasz,
On Thu, Feb 7, 2013 at 3:35 AM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> Hi Simon,>>>>> > This code seems to be entirely othogonal, so remove the #ifdef and>> > put the condition in the Makefile instead.>>>> I'm fully with you in respect of cleaning/refactoring the ext4 u-boot>> code.>>>> I will test this change when I only find some time ...>>>> Are you doing any work on ext4 code refactoring/rewritting at u-boot?
No, just the fs layer, so that I could get sandbox to work. Plus I
split up the file a bit. But I have no other plans.
Regards,
Simon
>> --> Best regards,>> Lukasz Majewski>> Samsung R&D Poland (SRPOL) | Linux Platform Group

Hi Simon,
> Hi Lukasz,> > On Thu, Feb 7, 2013 at 3:35 AM, Lukasz Majewski> <l.majewski@samsung.com> wrote:> > Hi Simon,> >> >>> >> > This code seems to be entirely othogonal, so remove the #ifdef> >> > and put the condition in the Makefile instead.> >>> >> I'm fully with you in respect of cleaning/refactoring the ext4> >> u-boot code.> >>> >> I will test this change when I only find some time ...> >>> >> > Are you doing any work on ext4 code refactoring/rewritting at> > u-boot?> > No, just the fs layer, so that I could get sandbox to work. Plus I> split up the file a bit. But I have no other plans.>
Ok, thanks for info.
> Regards,> Simon> > >> > --> > Best regards,> >> > Lukasz Majewski> >> > Samsung R&D Poland (SRPOL) | Linux Platform Group