Hi Igor,
On 5/15/18 4:16 PM, Igor Ignatyev wrote:
>http://cr.openjdk.java.net/~iignatyev//8202946/webrev.00/index.html>> 1619 lines changed: 1619 ins; 0 del; 0 mod;
> Hi all,
>> could you please review this patch which open sources OOM tests from VM testbase? these tests test OutOfMemoryError throwing in different scenarios.
>> As usually w/ VM testbase code, these tests are old, they have been run in hotspot testing for a long period of time. Originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. In a long term, we are planning to rework them.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8202946> webrev: http://cr.openjdk.java.net/~iignatyev//8202946/webrev.00/index.html> testing: :vmTestbase_vm_oom test group
Webrev.00 looks good to me but have minor nits.
-------------------
test/hotspot/jtreg/TEST.groups
1164 # Test for OOME re-throwing after Java Heap exchausting
- Typo: exchausting -> exhausting
-------------------
test/hotspot/jtreg/vmTestbase/vm/oom/OOMTraceTest.java
68 protected boolean isAlwaysOOM() {
69 return expectOOM;
70 }
- (optional) It is returning the variable of "expectOOM" but the name is
"isAlwaysOOM" which makes me confused. If you prefer "isXXX" form of
name, how about "isExpectingOOM()" etc..? Or you can defer this
renaming, as you are planning to rework those tests.
I don't need a new webrev for these.
-------------------
Just random comment.
- It would be better to use small fixed Java Heap size to trigger OOME
for short test running time.
Thanks,
Sangheon
>> Thanks,
> -- Igor