Changes look good Alex. One thing though - the current docs also includes API documentation which is not generated by make. For that, we need to modify the pom.xml to bind javadoc:javadoc to the package phase with the output directory specifically set to target/docs/api.

Arvind Prabhakar
added a comment - 18/Oct/11 17:58 Changes look good Alex. One thing though - the current docs also includes API documentation which is not generated by make. For that, we need to modify the pom.xml to bind javadoc:javadoc to the package phase with the output directory specifically set to target/docs/api.

There is some regression from the previous patch. When I do mvn package -DskipTests, the javadocs do get generated in the right place but the rest of the documentation does not. I think you need to bind the make exec invocation to the package phase.

Arvind Prabhakar
added a comment - 19/Oct/11 23:32 There is some regression from the previous patch. When I do mvn package -DskipTests, the javadocs do get generated in the right place but the rest of the documentation does not. I think you need to bind the make exec invocation to the package phase.

I double checked to make sure both the api and the handbook were created. I then clicked around. We still aren't building the release notes in an automated fashion. Is that purposeful? Also notice I used a more compact notation for passing variables to make.

Alex Newman
added a comment - 20/Oct/11 02:20 I double checked to make sure both the api and the handbook were created. I then clicked around. We still aren't building the release notes in an automated fashion. Is that purposeful? Also notice I used a more compact notation for passing variables to make.