Commit Message

Hi,
Linux next tree(20090626) produced the following build error:
CC [M] drivers/mtd/maps/sbc8240.o
drivers/mtd/maps/sbc8240.c:31:1: warning: "DEBUG" redefined
In file included from drivers/mtd/maps/sbc8240.c:23:
include/linux/mtd/mtd.h:333:1: warning: this is the location of the previous definition
drivers/mtd/maps/sbc8240.c: In function 'init_sbc8240_mtd':
drivers/mtd/maps/sbc8240.c:172: warning: passing argument 1 of 'simple_map_init' from incompatible pointer type
drivers/mtd/maps/sbc8240.c:177: error: 'struct mtd_info' has no member named 'module'
make[3]: *** [drivers/mtd/maps/sbc8240.o] Error 1
make[2]: *** [drivers/mtd/maps] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2
I remember reporting this back in April, when it was suggested to remove
the code as it is no more used:
http://lkml.org/lkml/2009/4/21/476,
I tried to gather some more info about this driver from the link
mentioned in Kconfig:
http://www.windriver.com/products/sbc8240/,
without much success.
The original author of this driver code has no problem, as she has
expressed by the following mail:
>On Tue, 2009-06-30 at 09:37 -0700, carolyn.j.smith@tektronix.com wrote:>Hello Subrata,> > I am the original author of this file and have no objection to its removal> from the 2.6 kernel. I added it to the 2.4 kernel when I ported Linux to> the SBC8240 board many years ago. I haven't used the board in several years.> > Regards,> Carolyn>
Last time i did not address: linux-mtd@lists.infradead.org. If there are
no issues, can you please apply this patch to remove it ?
To: linux-mtd@lists.infradead.org,
Cc: David Woodhouse <dwmw2@infradead.org>,
Cc: Scott Wood <scottwood@freescale.com>,
Cc: Jim Cromie <jim.cromie@gmail.com>,
Cc: carolyn.j.smith@exgate.tek.com,
Cc: dwmw2@infradead.org,
Cc: Sachin P Sant <sachinp@linux.vnet.ibm.com>,
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Cc: Linuxppc-dev <Linuxppc-dev@ozlabs.org>,
Cc: linux-next <linux-next@vger.kernel.org>,
--
Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
Tested-on-PPC64-by: Subrata Modak <subrata@linux.vnet.ibm.com>
---
---
Regards--
Subrata

On Mon, 2009-07-06 at 07:47 +0530, Subrata Modak wrote:
> Hi,> > Is there somebody else whom i should also address to get an attention> for this patch ? I apolozise if i have not included someone. Kindly> connect to the concerned.
I'm putting your patch to l2-mtd-2.6.git.

On Fri, 2009-07-10 at 08:59 +0300, Artem Bityutskiy wrote:
> On Mon, 2009-07-06 at 07:47 +0530, Subrata Modak wrote:> > Hi,> > > > Is there somebody else whom i should also address to get an attention> > for this patch ? I apolozise if i have not included someone. Kindly> > connect to the concerned.> > I'm putting your patch to l2-mtd-2.6.git.
Thanks very much. Would i receive some automatic confirmation once it
make to Linus tree ?
Regards--
Subrata
>

Subrata Modak wrote:
> On Fri, 2009-07-10 at 08:59 +0300, Artem Bityutskiy wrote:>> On Mon, 2009-07-06 at 07:47 +0530, Subrata Modak wrote:>>> Hi,>>>>>> Is there somebody else whom i should also address to get an attention>>> for this patch ? I apolozise if i have not included someone. Kindly>>> connect to the concerned.>> I'm putting your patch to l2-mtd-2.6.git.> > Thanks very much. Would i receive some automatic confirmation once it> make to Linus tree ?
I do not think so. I'm not MTD maintainer and in l2-mtd-2.6.git
I just collect random patches, which the maintainer then usually
takes from my tree.

On Fri, 2009-07-10 at 09:18 +0300, Artem Bityutskiy wrote:
> Subrata Modak wrote:> > On Fri, 2009-07-10 at 08:59 +0300, Artem Bityutskiy wrote:> >> On Mon, 2009-07-06 at 07:47 +0530, Subrata Modak wrote:> >>> Hi,> >>>> >>> Is there somebody else whom i should also address to get an attention> >>> for this patch ? I apolozise if i have not included someone. Kindly> >>> connect to the concerned.> >> I'm putting your patch to l2-mtd-2.6.git.> > > > Thanks very much. Would i receive some automatic confirmation once it> > make to Linus tree ?> > I do not think so. I'm not MTD maintainer and in l2-mtd-2.6.git> I just collect random patches, which the maintainer then usually> takes from my tree.
Thanks. I just want this through before 2.6.31 stable is released, so
that the build fails does not occur on next trees based on that stable
one.
Regards--
Subrata
>

On Fri, 2009-07-10 at 12:42 +0530, Subrata Modak wrote:
> On Fri, 2009-07-10 at 09:18 +0300, Artem Bityutskiy wrote:> > Subrata Modak wrote:> > > On Fri, 2009-07-10 at 08:59 +0300, Artem Bityutskiy wrote:> > >> On Mon, 2009-07-06 at 07:47 +0530, Subrata Modak wrote:> > >>> Hi,> > >>>> > >>> Is there somebody else whom i should also address to get an attention> > >>> for this patch ? I apolozise if i have not included someone. Kindly> > >>> connect to the concerned.> > >> I'm putting your patch to l2-mtd-2.6.git.> > > > > > Thanks very much. Would i receive some automatic confirmation once it> > > make to Linus tree ?> > > > I do not think so. I'm not MTD maintainer and in l2-mtd-2.6.git> > I just collect random patches, which the maintainer then usually> > takes from my tree.> > Thanks. I just want this through before 2.6.31 stable is released, so> that the build fails does not occur on next trees based on that stable> one.
Then you should bug dwmw2.

On Fri, 2009-07-10 at 10:14 +0300, Artem Bityutskiy wrote:
> On Fri, 2009-07-10 at 12:42 +0530, Subrata Modak wrote:> > On Fri, 2009-07-10 at 09:18 +0300, Artem Bityutskiy wrote:> > > Subrata Modak wrote:> > > > On Fri, 2009-07-10 at 08:59 +0300, Artem Bityutskiy wrote:> > > >> On Mon, 2009-07-06 at 07:47 +0530, Subrata Modak wrote:> > > >>> Hi,> > > >>>> > > >>> Is there somebody else whom i should also address to get an attention> > > >>> for this patch ? I apolozise if i have not included someone. Kindly> > > >>> connect to the concerned.> > > >> I'm putting your patch to l2-mtd-2.6.git.> > > > > > > > Thanks very much. Would i receive some automatic confirmation once it> > > > make to Linus tree ?> > > > > > I do not think so. I'm not MTD maintainer and in l2-mtd-2.6.git> > > I just collect random patches, which the maintainer then usually> > > takes from my tree.> > > > Thanks. I just want this through before 2.6.31 stable is released, so> > that the build fails does not occur on next trees based on that stable> > one.> > Then you should bug dwmw2.
Hmmm. I see.
Hi dwmw2,
Is it possible to get this patch through and before 2.6.31 stable is
released ?
Regards--
Subrata
>

On Fri, 2009-07-10 at 14:17 +0530, Subrata Modak wrote:
> Is it possible to get this patch through and before 2.6.31 stable is> released ?
Hm, I was ignoring this until I was sure all the last-minute fixes for
2.6.31 were out of the way; I was planning to submit it for 2.6.32.
Do we really need to submit it for 2.6.31? It's not a regression, is it?
It's been like this for _ages_.

On Fri, 2009-07-10 at 09:53 +0100, David Woodhouse wrote:
> On Fri, 2009-07-10 at 14:17 +0530, Subrata Modak wrote:> > Is it possible to get this patch through and before 2.6.31 stable is> > released ?>
Hi David,
> Hm, I was ignoring this until I was sure all the last-minute fixes for> 2.6.31 were out of the way; I was planning to submit it for 2.6.32.> > Do we really need to submit it for 2.6.31? It's not a regression, is it?> It's been like this for _ages_.
True. But it gives annoying build fails on randconfig next trees. And
we(Sachin & myself) has been reporting it from March/April. If you feel
there is still room to be pushed to 2.6.31, then please do it. Else,
2.6.32 will be fine. Thanks for your support.
Regards--
Subrata
>