On Mon, Aug 15, 2005 at 11:55:31PM +0200, Jean Delvare wrote:> You should probably be using the --no-index option of quilt 0.42 (if you> are using quilt as I presumed), as I heard Linus doesn't like these> index lines in the patches he receives.

Yeah, I was thinking about that too, but I can't think of a reasonablereturn code to use. -1 for "don't probe"? Or <0 for "fatal error,don't touch this bus any more"? Anyway, client drivers will probablyonly use one of the two detection methods because if they need toimplement attach_adapter they can just call i2c_probe from there.

> Also, maybe we can put this new code in a separate function to be called> from both i2c_add_adapter and i2c_add_driver, so as to not duplicate> code? Or would this be too much overhead? It could be made inline then.> Again, just a random thought.

I didn't think anybody was porting client drivers any more, but ifyou're still updating that doc, I can too. :-) -Nathan-To unsubscribe from this list: send the line "unsubscribe linux-kernel" inthe body of a message to majordomo@vger.kernel.orgMore majordomo info at http://vger.kernel.org/majordomo-info.htmlPlease read the FAQ at http://www.tux.org/lkml/