this should probably be a component with some dynamic control of filtering

39

org.apache.maven.artifact.DependencyResolutionRequiredException

Line

it may be better for artifact.getFile() to throw it - perhaps it is a runtime exception?

27

org.apache.maven.artifact.repository.MavenArtifactRepository

Line

need to URL decode for spaces?

231

org.apache.maven.artifact.repository.metadata.RepositoryMetadata

Line

not happy about the store method - they use "this"

30

org.apache.maven.artifact.resolver.filter.ExcludesArtifactFilter

Line

I think this is equiv. to exclusion set filter in maven-core

31

org.apache.maven.project.DuplicateArtifactAttachmentException

Line

Make this a checked exception, and modify the API of MavenProjectHelper. Currently, this modification would create compatibility problems for existing plugins.

30

org.apache.maven.project.MavenProject

Line

I would like to get rid of this. jvz.

333

org.apache.maven.project.artifact.ActiveProjectArtifact

Line

I think this exposes a design flaw in that the immutable and mutable parts of an artifact are in one class and should be split. ie scope, file, etc depend on the context of use, whereas everything else is immutable.

take repo mans into account as one may be aggregating prefixes of many

638

collect at the root of the repository, read the one at the root, and fetch remote if something is missing or the user forces the issue

639

org.apache.maven.lifecycle.internal.DependencyContext

Line

From a concurrency perspective, this class is not good. The combination of mutable/immutable state is not nice

38

org.apache.maven.lifecycle.internal.GoalTask

Line

From a concurrecy perspective, this class is not good. The combination of mutable/immutable state is not nice

25

org.apache.maven.lifecycle.internal.MojoDescriptorCreator

Line

take repo mans into account as one may be aggregating prefixes of many

225

collect at the root of the repository, read the one at the root, and fetch remote if something is missing or the user forces the issue

226

org.apache.maven.lifecycle.internal.ProjectBuildList

Line

Optimize; or maybe just rewrite the whole way aggregating mojos are being run.

54

org.apache.maven.lifecycle.internal.TaskSegment

Line

Consider throwing UnsupprtedSomething on hashCode/equals

72

org.apache.maven.plugin.DefaultBuildPluginManager

Line

the antrun plugin has its own configurator, the only plugin that does. might need to think about how that works

34

remove the coreArtifactFilterManager

35

pluginDescriptor classRealm and artifacts are set as a side effect of this call, which is not nice.

173

org.apache.maven.plugin.PluginManagerTest

Line

These two tests display a lack of symmetry with respect to the input which is a free form string and the mojo descriptor which comes back. All the free form parsing needs to be done somewhere else, this is really the function of the CLI, and then the pre-processing of that output still needs to be fed into a hinting process which helps flesh out the full specification of the plugin. The plugin manager should only deal in concrete terms -- all version finding mumbo jumbo is a customization to base functionality the plugin manager provides.

104

turn an equivalent back on when the RR plugin is released.

114

this will be the basis of the customizable lifecycle execution so need to figure this out quickly.

139

org.apache.maven.plugin.PluginParameterExpressionEvaluator

Line

used by the Enforcer plugin

51

don't catch exception

187

don't catch exception

227

don't catch exception

259

don't catch exception

316

without #, this could just be an evaluate call...

371

Copied from the DefaultInterpolator. We likely want to resurrect the PathTranslator or at least a similar component for re-usage

415

org.apache.maven.plugin.PluginParameterExpressionEvaluatorTest

Line

Auto-generated method stub

441

org.apache.maven.plugin.internal.DefaultMavenPluginManager

Line

could the configuration be passed to lookup and the configurator known to plexus via the descriptor so that this method could entirely be handled by a plexus lookup?

493

org.apache.maven.project.MavenProject

Line

Find a way to use <relativePath/> here...it's tricky, because the moduleProject usually doesn't have a file associated with it yet.

261

This is suboptimal. Without a cache in the project builder, rebuilding the parent chain currently causes O(n^2) parser invocations for an inheritance hierarchy of depth n.

344

let the scope handler deal with this

513

classpath check doesn't belong here - that's the other method

531

let the scope handler deal with this

534

let the scope handler deal with this

558

this checking for file == null happens because the resolver has been confused about the root artifact or not. things like the stupid dummy artifact coming from surefire.

576

classpath check doesn't belong here - that's the other method

605

let the scope handler deal with this

653

classpath check doesn't belong here - that's the other method

670

let the scope handler deal with this

673

let the scope handler deal with this

697

let the scope handler deal with this

726

classpath check doesn't belong here - that's the other method

743

let the scope handler deal with this

746

let the scope handler deal with this

770

this should not be allowed to be null.

841

org.apache.maven.project.ProjectSorter

Line

!![jc; 28-jul-2005] check this; if we're using '-r' and there are aggregator tasks, this will result in weirdness.

235

org.apache.maven.project.artifact.MavenMetadataSource

Line

This prevents a cycle in the composition which shows us another problem we need to deal with.

96

Not even sure this is really required as the project will be cached in the builder, we'll see this is currently the biggest hotspot

180

shouldn't the versions be merged across relocations?

664

org.apache.maven.project.artifact.MavenMetadataSourceTest

Line

restore these if it makes sense

93

org.apache.maven.repository.TestRepositoryConnector

Line

Auto-generated method stub

111

org.apache.maven.repository.TestRepositorySystem

Line

Auto-generated method stub

172

Auto-generated method stub

292

org.apache.maven.settings.DefaultMavenSettingsBuilder

Line

This replacing shouldn't be necessary as user.home should be in the context of the container and thus the value would be interpolated by Plexus

129

org.apache.maven.toolchain.DefaultToolchainManager

Line

why is this using the context

90

org.apache.maven.toolchain.RequirementMatcherFactory

Line

error reporting

90

org.apache.maven.toolchain.ToolchainFactory

Line

keep around?? */

39

org.apache.maven.toolchain.java.DefaultJavaToolchainFactory

Line

possibly move at least parts to a utility method or abstract implementation.