Activity

Hugo, your patch doesn't apply cleanly to latest master due to some changed lines of context around it that are from before Nov 2011, which confuses me given that your patch was created recently. I could mechanically update it, but if you could take a look and create an updated patch yourself it would be safer.

Andy Fingerhut
added a comment - 09/Mar/12 9:22 AM Hugo, your patch doesn't apply cleanly to latest master due to some changed lines of context around it that are from before Nov 2011, which confuses me given that your patch was created recently. I could mechanically update it, but if you could take a look and create an updated patch yourself it would be safer.

I offer a new patch, 0003-CLJ-940-check-for-sequential.patch, as an alternative.
This patch also checks for the more specific clojure.lang.Sequential instead of IPersistentCollection (which includes sets and maps).
If I had my druthers, I'd check for IPersistentList, but I can't face the screaming that would result.
Neither patch provides file/line information in the error, but there isn't much affordance for that in core.clj right now.

Applies cleanly against d4170e65d001c8c2976f1bd7159484056b9a9d6d. This looks good to me. We should at some point talk more about the implications of checking IPersistenList, but I think there is enough value here to push it forward.

Aaron Bedra
added a comment - 21/Aug/12 10:57 AM Applies cleanly against d4170e65d001c8c2976f1bd7159484056b9a9d6d. This looks good to me. We should at some point talk more about the implications of checking IPersistenList, but I think there is enough value here to push it forward.