So the setup appears OK, I can see the files in /media/Media on the Pi, I can see RASPBERRYPI in my workgroup from my Windows7 box. But when I try to access it I get a logon failure. I also have a 2nd pi with Raspbmc installed and I also cannot access the smb share from there either.

Is there something else I need to do in Samba to get this working?

Edit:
I did some more work on this last night.
I added a new user to the raspberry, set a password, added a new user to samba, set the password and added the following lines.

And now I've managed to get an error like... "You do not have authorization to access this share". I'm thinking perhaps I'll work on my pi directly tonight instead of using putty and perhaps there is something I'll be able to see when using a text editor instead of vi.

@LordLoh. Thanks Loh, my ultimate goal here is to have an always on network share that my Raspbmc, Wii and Windows machines can access so I don't have to have my main computer on all the time.
–
Biff MaGriffNov 7 '12 at 19:18

Can you try this? Give the Username as RASPBERRYPI\pi(where pi is a user in raspberry pi) and password as the password of the user.PRobably you have already tried this but just in case :)
–
SteveIrwinNov 7 '12 at 19:27