Joerg Roedel wrote:>>> +static char *npt = "on";>>> +>>> +module_param(npt, charp, S_IRUGO);>>> >>> >> This would probably be better as an integer. Then we don't have to do nasty things like >> implicitly cast a literal to a char *.>> >> Hmm, I used int for that first but typing npt=off seemed more> userfriendly to me than npt=0. So I used char* for it.>

I expect this to be rarely used by users, so the simpler int is preferable (and also consistent with vmx's bypass_guest_pf and enable_vpid).

-- Any sufficiently difficult bug is indistinguishable from a feature.