On Mon, Nov 01, 2010 at 11:01:41PM +0100, Peter Stuge wrote:
> Ward Vandewege wrote:
> > See attached. Perhaps we should also print a post code if the SMBus
> > controller can't be found - suggestions for a value?
>> 0x5B ?
>>> > We can't print this early.
> >
> > This patch fixes a hang on
> >
> > supermicro/h8dme
> > supermicro/h8dmr
> > supermicro/h8dmr_fam10
> >
> > and possibly on other mcp55-based boards.
> >
> > Signed-off-by: Ward Vandewege <ward at gnu.org>
>> Acked-by: Peter Stuge <peter at stuge.se>
I don't object to the patch, and we should probably fix this in all
other southbridges, I think the same problem applies there.
But: the die() call itself also does a printk(), so that'll still hang
if the error path is chosen (at that point it probably doesn't matter
much, though, as we die anyway).
I also agree that die() should have a POST code, preferrably something
easy to remember. It already has a commented-out "//post_code(0xff);".
Not sure why it's disabled, but I think it should be something other
than 0xff, that's a bit too "special" for my taste.
We have "0xee: Not supposed to get here" as per documentation/POSTCODES,
so maybe we can use 0xdd ("d" as in die), if that's not already used elsewhere.
Uwe.
--
http://hermann-uwe.de | http://sigrok.orghttp://randomprojects.org | http://unmaintained-free-software.org