The clock is displaying one hour earlier than it should. OK changed it from menu but it is one hour back again (after computer turn off - so could be a battery fault).

I vaguely remember this happening a long time ago but need confimation from other users before can label as bug . . . ah yes the trick was to set the time zone but Puppy has been doing this (from the keyboard choice I guess)
Might be to do with UK summertime? Was OK in 2.16.

By the way all keyboards that I've used in New Zealand are US format, so it would help if rc.country (I think that's the name of the script) could have the "x" changed to "us" for country 60 New Zealand.
Thanks. That's an impressive effort doing everything in a single selection.

I'm reminded of Sir Humphrey Appleby in 'Yes Minister' telling the Minister that "that is a brave decision, Minister". It's very ambitious anyway, trying to put everything in one table, and there's going to be lots of tweaking required, plus some special cases.
Okay, I'll fix the keyboard for New Zealand.

These are all on an ext3 partition. The #2 save file was named that way because the #1 save file already existed. Looking at rc.shutdown, I thought that saving on an ext3 partition would result in an ext3 pup_save file. When booting #1 and #2 above, fsck is ran on both.

The #3 encrypted save file is mounted as ext2 by init (line #754) and no fsck is done. Maybe it's remounted later as ext3?

I'd like to see us go back to all ext3, especially with the clean shutdown problem, But that's another story.

That code about choosing the filename is, well, kinda tortured. Seems like the way to do it is to break it into pieces - directory, name, extension. Then go through figuring what each piece should be, and finally at the bottom, reassemble the pieces into the full name, adding that "bla" thing between name and extension.

If you want my opinion, you should simply lay out what the two choices (2fs vs 3fs) are, what the reasoning is behind them, and then let the user choose. At the bottom say, "if you aren't sure, pick 2fs".

I also noticed the variable "PCHOOSE" is never initialized to "no".

I have a couple more:

1) If xvesa is selected and I pick the default screen resolution (I think 640x480), then the windows, for example the browser with the welcome message, are too large for the screen. Maybe this is normal...

2) You replaced TkDiff with IIRC Xdiff. Bad move in my opinion. TkDiff is very intuitive, Xdiff such a mess that I finally gave up trying to get it to work. It may be that Xdiff actually is more capable, once you get to know it, but most people I think don't want to invest a lot of time in a program like that. They just want to find the differences in two files, right now. TkDiff was great for that; please don't dump it!

3) I went to create a lite encrypted pup_save when shutting down. In the final sanity check it says to hit ESC key if something is not right. I did that just to see what would happen, and it simply shut down without creating the pup_save. I thought it was going to go back and let me modify something.

4) Also I noticed there was no way to tell it what file type, 2fs or 3fs, you wanted for the pup_save. I think 2fs is the correct default but do we want to force people to use that? There is that utility kirk and I cooked up to change from one to the other, but that is an extra step that people have to know, and anyway it is not included in standard Puppy.

5) In the shutdown you use "x" to designate light encrypted files ("density") and "a" to designate heavy encrypted files. But in init you only look for "x" and assume anything else is heavy encrypted. There is a possibility that we may have loop-aes or dmcrypt in the future, which means more indicators. Right now, having no indicator after "crypt" is treated as heavy encryption. I'm not sure where I am going with this, but maybe there should be more documentation on this point; for example, in rc.shutdown just say that the indicator should be "a" or "x" and if the filename does not meet that specification it is not accepted. People should know what constraints there are in renaming pup_saves. I didn't know why the "a" appeared in the filename when I tried creating a new one.

I also have noticed that my normal HD install of 2.17RC1 on my laptop Dell CPX 450Mhz has the time resetting 1 hour too early upon every reboot. I like this OS. It makes this older equipment imminently more usable. i also have it on an 333Mhz w/128Mb RAM. I like it. Enough software to do what I do with a confuseser. Man- I wish I could fix that double-repeat problem, though! Good thing I am not a fast typist, any way. bettere stop rambling. thanks for the work on this, guys/gals.

Oh, one other point. Is it true that encrypted pupsaves never get automatically fsck'ed? I know that doing it every time was awful slow, but doing it never might be going too far in the other direction.

That code about choosing the filename is, well, kinda tortured. Seems like the way to do it is to break it into pieces - directory, name, extension. Then go through figuring what each piece should be, and finally at the bottom, reassemble the pieces into the full name, adding that "bla" thing between name and extension.

If you want my opinion, you should simply lay out what the two choices (2fs vs 3fs) are, what the reasoning is behind them, and then let the user choose. At the bottom say, "if you aren't sure, pick 2fs".

I also noticed the variable "PCHOOSE" is never initialized to "no".

I have a couple more:

1) If xvesa is selected and I pick the default screen resolution (I think 640x480), then the windows, for example the browser with the welcome message, are too large for the screen. Maybe this is normal...

2) You replaced TkDiff with IIRC Xdiff. Bad move in my opinion. TkDiff is very intuitive, Xdiff such a mess that I finally gave up trying to get it to work. It may be that Xdiff actually is more capable, once you get to know it, but most people I think don't want to invest a lot of time in a program like that. They just want to find the differences in two files, right now. TkDiff was great for that; please don't dump it!

3) I went to create a lite encrypted pup_save when shutting down. In the final sanity check it says to hit ESC key if something is not right. I did that just to see what would happen, and it simply shut down without creating the pup_save. I thought it was going to go back and let me modify something.

4) Also I noticed there was no way to tell it what file type, 2fs or 3fs, you wanted for the pup_save. I think 2fs is the correct default but do we want to force people to use that? There is that utility kirk and I cooked up to change from one to the other, but that is an extra step that people have to know, and anyway it is not included in standard Puppy.

5) In the shutdown you use "x" to designate light encrypted files ("density") and "a" to designate heavy encrypted files. But in init you only look for "x" and assume anything else is heavy encrypted. There is a possibility that we may have loop-aes or dmcrypt in the future, which means more indicators. Right now, having no indicator after "crypt" is treated as heavy encryption. I'm not sure where I am going with this, but maybe there should be more documentation on this point; for example, in rc.shutdown just say that the indicator should be "a" or "x" and if the filename does not meet that specification it is not accepted. People should know what constraints there are in renaming pup_saves. I didn't know why the "a" appeared in the filename when I tried creating a new one.

Oh, one other point. Is it true that encrypted pupsaves never get automatically fsck'ed? I know that doing it every time was awful slow, but doing it never might be going too far in the other direction.

I havn't saw any speed difference between encrypted and non-encrypted. Fsck takes a while if you have a lot of files in your pup_save. If it's fairly empty then it's real fast. Rebuild all of the kernel modules or do somthing else that puts thousands of files in your pup_save and reboot, you'll see. You'll spend more time with fsck than the rest of the boot process. That's why journaling was invented

You cannot post new topics in this forumYou cannot reply to topics in this forumYou cannot edit your posts in this forumYou cannot delete your posts in this forumYou cannot vote in polls in this forumYou cannot attach files in this forumYou can download files in this forum