Commit Message

Hello David Miller,
It has taken pretty long time to figure it out to submitting the patch in my environment.
Now I am almost sure I find a workaround solution to submit the patch in my environment.
Anyway I am sorry for making mistakes in submitting the patch and causes to waste your valuable time.
This patch fixes up as followings;
.Remove "#define DEBUG" and "#define MALLOC".
.Remove the compile warning messages from ks_inblk() and ks_outblk().
.add "return IRQ_NONE" when there is no hardware IRQ indication in ks_irq().
.remove mutex_lock/unlock from ks_net_open because they are redundancy.
I will appreciate if you send back any comments on my patch.
-------------------------------
-------------------------------
Regards,
David J. Choi
-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thu 9/17/2009 4:49 PM
To: Choi, David
Cc: greg@kroah.com; netdev@vger.kernel.org; Li, Charles; Choi@kroah.com; jgarzik@redhat.com; shemminger@vyatta.com
Subject: Re: [PATCH] ks8851_ml ethernet network driver
From: "Choi, David" <David.Choi@Micrel.Com>
Date: Thu, 17 Sep 2009 12:30:27 -0700
> --- linux-2.6.31-rc3/drivers/net/ks8851_mll.c.orig 2009-09-17> 10:18:56.000000000 -0700> +++ linux-2.6.31-rc3/drivers/net/ks8851_mll.c 2009-09-17> 10:09:37.000000000 -0700> @@ -21,8 +21,6 @@> * KS8851 16bit MLL chip from Micrel Inc.
I can't use this patch or even test it, as your email client
has corrupted it by, for example, breaking up long lines.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Comments

This is a patch against the driver, not the whole new driver.
We want the whole new driver, with your proper commit log message,
and proper signoffs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html