From: Michael Widenius
Date: June 27 2009 8:42am
Subject: Re: MySql coding style: Request for deprecation of UPPERCASE typedefs
List-Archive: http://lists.mysql.com/internals/37017
Message-Id: <19013.56173.132090.751622@narttu.askmonty.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hi!
>>>>> "Davi" == Davi Arnaut writes:
Davi> On 6/25/09 5:27 AM, Jonas Oreland wrote:
>>> This practice makes it impossible to do unit testing.
>>>
>>> 'include or declare what you use' is a very simple rule,
>>> and makes the code much more maintainable and testable.
>>
>> maybe mysql is not designed to be unit-tested, maintainable or testable.
>> that "MUCH faster compile time for compilers that support precompiled headers"
>> is really a more important goal.
>>
Davi> only if mysql supported by default precompiled headers with gcc..
Which wouldn't be hard to add (and someone should look at this).
However going the other way, we could never do it.
We did support and use precompiled headers on Windows when I did the
Windows builds. Don't know the current state, but it shouldn't be hard
to still do it.
Davi> only if mysql_priv modifications weren't very common...
Compared to other code changes, they are not very common.
Davi> oh.. if my ccache could speak about mysql_priv...
Yes, that is a problem, but ccache only helps local builds.
One of our main problem is the run time of a complete builds, as part
of pushbuild or buildbot and we have to get this faster. Here ccache
is of no notable help compared to what precompiled headers could
give/gives us.
Regards,
Monty