Activity

As to the code itself, I think the two findbugs warning are false positive. While it does not follow the JSR-166 strictly, its releasing/retaking lock action is safe in DfsClientShmManager$EndpointShmManager::allocSlot() method.

So I prefer the other solution for this issue. I will file a patch to move the findbugs filter rules from hadoop-hdfs to hadoop-hdfs-client module.

Mingliang Liu
added a comment - 27/Aug/15 01:36 As to the code itself, I think the two findbugs warning are false positive. While it does not follow the JSR-166 strictly, its releasing/retaking lock action is safe in DfsClientShmManager$EndpointShmManager::allocSlot() method.
So I prefer the other solution for this issue. I will file a patch to move the findbugs filter rules from hadoop-hdfs to hadoop-hdfs-client module.

Thank you for fixing the findbugs warning. Next time, can you please include what was done in the commit message and the JIRA name? "investigating" doesn't really describe what the commit does. Thanks.

Colin P. McCabe
added a comment - 15/Sep/15 20:42 Thank you for fixing the findbugs warning. Next time, can you please include what was done in the commit message and the JIRA name? "investigating" doesn't really describe what the commit does. Thanks.