commons-issues mailing list archives

[jira] [Commented] (DISCOVERY-15) implementing a commons-logging wrapper is an overkill

Date

Tue, 05 Apr 2011 13:10:05 GMT

[ https://issues.apache.org/jira/browse/DISCOVERY-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015907#comment-13015907
]
Simone Tripodi commented on DISCOVERY-15:
-----------------------------------------
Sure, Jochen, I realize that maybe the problem is not well explained.
Situation was that we had a {{org.apache.commons.discovery.log}} package where there was a
simple {{org.apache.commons.logging.Log}} implementation and related factory, and in discovery
classes there are a lot of methods like:
{code}
public static void setLog(org.apache.commons.logging.Log _log) {
log = _log;
}
{code}
So, just removing the {{org.apache.commons.discovery.log}} package, and using the commons-logging
in the traditional way, we removed the custom implementation (yes, remove classes) but maintained
the binary compatibility since setters have not be touched
> implementing a commons-logging wrapper is an overkill
> -----------------------------------------------------
>
> Key: DISCOVERY-15
> URL: https://issues.apache.org/jira/browse/DISCOVERY-15
> Project: Commons Discovery
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Fix For: 0.5
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> org.apache.commons.discovery.log is a commons-logging implementation wrapper, moreover
the 90% of classes that use a Log instance, have a static setter method.
> It should be enough just using commons-logging in the 'traditional' way :P
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira