Watchers (6)

This issue tracker is now in read-only archive mode and automatic ticket export has been disabled. Redmine users will need to create a new JIRA account to file tickets using https://tickets.puppetlabs.com. See the following page for information on filing tickets with JIRA:

There should actually be an exception there, I’m pretty sure. I know my intention was that this throw an exception, because I haven’t been all that careful to make sure naming collisions don’t cause problems, so I knew an exception was important.

Probably the right move, at this point, is to make the ASTSet in parser/parser_support.rb into a class, which can then do validation as nodes et al are added.

I think it shouldn’t be an exception. I know eventually, this is probably solved by an external node tool, but as it stands now, we often have classes that have the same name as nodes and I’d really hate to rename classes/modules to something else just to avoid that name collision. Isn’t there any other way to handle this such that a node is a node and can be the same name as a class? I know the direction that was discussed was to eventuall treat nodes as classes (or perhaps that’s what’s happening now), but this is somewhat limiting.

The problem here is that I’ve got a single @class_scope hash for the entire compile, and it stores both node and class scopes, with no typing (i.e., the node and class scopes aren’t separated in any way).

This looks pretty unnecessary, so it should be straightforward to just add a node_scope hash to go with the class_scope hash.