Hi Juan and Paulo,
Paulo -
I've quickly glanced into the commits. I think it is not a good (or even disallowed) thing to alter 7.2 API (unlike v7.3+).
The only commits to release branch now are the ones fixing some bugs or regression (hiding some symbols actively used by 3rd-party well-know projects could be considered as a regression). (The only reason for making such fixing should be making legacy code work as expected nothing more.)
I guess Hans is having the similar opinion of it.
So, part of your patch is definitely ok for master branch. But no code of it suitable for release branch for now.
Thank you for the quick response but please adjust it (being more close to the fix scenario I've outlined in my previous post).
Regards,
Ivan
Sun, 27 May 2012 21:06:06 +0200 Juan Jose Garcia-Ripoll <juanjose.garciaripoll at googlemail.com>:
> On Sun, May 27, 2012 at 8:44 PM, Paulo César Pereira de Andrade <
>paulo.cesar.pereira.de.andrade at gmail.com> wrote:
>> > I gone ahead and did the patches as listed above, and confirmed it
> > compiles
> > and works at least for a "(+ 1 1)" test in ecl, but did not address the
> > comment
> > Juan said about GC_init_explicit_typing as I do not have enough insight
> > about
> > what needs to be done.
>>> Thanks for acting so quickly, Paulo.The part with GC_init_explicit_typing()
> should probably be included in gc_types.h as
> GC_API GC_descr GC_CALL GC_init_explicit_typing(void);
> but Ivan may know better.
>> Juanjo
>> --
> Instituto de Física Fundamental, CSIC
> c/ Serrano, 113b, Madrid 28006 (Spain)
>http://juanjose.garciaripoll.googlepages.com