Hi,
On Sat, Feb 17, 2007 at 10:17:36PM +0100, Daniel Sieger wrote:
> Here's a proposed patch to introduce a new scheduler API in
> Yamamoto-san's idle lwp branch. It is a slightly modified/improved
> version of the patch I send a couple of weeks ago (see [1]).
[...]
> +#ifdef SCHED_4BSD
> if (schedhz == 0) {
> /* 16Hz is best */
> statscheddiv = i / 16;
> if (statscheddiv <= 0)
> panic("statscheddiv");
> }
> +#endif /* SCHED_4BSD */
I'm not sure if it is worth #ifdefing this just yet. I think it would make
more sense to have other schedulers provide a dummy routine that just
returns and does nothing.
+sched_rqinit()
Perhaps call it sched_init()?
+sched_setup()
This kicks off scheduling, right? So why not sched_start() or something?
Bikeshedding I know, sorry. :-)
Cheers,
Andrew