On Wed, May 03, 2006 at 10:40:19AM -0400, Jon Smirl wrote:> On 5/3/06, Al Viro <viro@ftp.linux.org.uk> wrote:> >On Wed, May 03, 2006 at 10:11:52AM -0400, Jon Smirl wrote:> >> Something seems to be wrong in selinux_get_task_sid. I am getting> >> thousands of these and can't boot the kernel.> >> >It's actually in security/selinux/hooks.c::selinux_disable() and gets> >triggered if you have selinux enabled and explicitly disable afterwards.> >Stephen Smalley had done a fix yesterday, basically adding> > selinux_enabled = 0;> >after> > selinux_disabled = 1;> >in there. selinux_get_task_sid() happens to step on that in visible way> >and nobody had caught that while this stuff was sitting in -mm ;-/> >> >The only question I have about that patch: what would happen if we do not> >have CONFIG_SECURITY_SELINUX_BOOTPARAM? In that case selinux_enabled is> >defined to 1, so...> > I have these config options set:> > CONFIG_SECURITY_SELINUX=y> CONFIG_SECURITY_SELINUX_BOOTPARAM=y> CONFIG_SECURITY_SELINUX_BOOTPARAM_VALUE=1> CONFIG_SECURITY_SELINUX_DISABLE=y> CONFIG_SECURITY_SELINUX_DEVELOP=y> CONFIG_SECURITY_SELINUX_AVC_STATS=y> CONFIG_SECURITY_SELINUX_CHECKREQPROT_VALUE=1> > SELinux needs to be built in or FC5 won't run.

Then add the assignment above (selinux_enabled = 0;) in selinux_disable()and see if that fixes your problem.-To unsubscribe from this list: send the line "unsubscribe linux-kernel" inthe body of a message to majordomo@vger.kernel.orgMore majordomo info at http://vger.kernel.org/majordomo-info.htmlPlease read the FAQ at http://www.tux.org/lkml/