On Fri, Apr 02, 2004 at 10:13:43PM +0200, Pavel Machek wrote:> Hi!> > > > An anonymous user page meets these requirements. A did say "anal", but> > > rw_swap_page_sync() is a general-purpose library function and we shouldn't> > > be making assumptions about the type of page which the caller happens to be> > > feeding us.> > > > that is a specialized backdoor to do I/O on _private_ pages, it's not a> > general-purpose library function for doing anonymous pages> > swapin/swapout, infact the only user is swap susped and we'd better> > forbid swap suspend to pass anonymous pages through that interface and> > be sure that nobody will ever attempt anything like that.> > > > that interface is useful only to reach the swap device, for doing I/O on> > private pages outside the VM, in the old days that was used to> > read/write the swap header (again on a private page), swap suspend is> > using it for similar reasons on _private_ pages.> > Ahha, so *here* is that discussion happening. I was only seeing it at> bugzilla, and could not make sense of it.

;)

btw, as far as I can tell I cannot see anymore VM issues with current CVSkernel, what I get now is:

I believe this is fine with you, I mean, you told me this is because theaic7xxx cannot restore, right?

the only VM pending bug right now (besides the mprotect feature request that Ialready implemented at 85%) is the compound bugreport from Christoph, but to methat sounds a kernel miscompilation, it makes no sense that PageCompound(p) ==0 and after a nanosecond p->flags & (1<<PG_compound) == 1, and no, it's notlikely a race condition, and nothing weird like that ever happened on x86 yet,and that's all common code (no arch details in the compound thing, infact itmust not even depend on MMU etc..).

> > If swsusp/pmdisk are only user of rw_swap_page_sync, perhaps it should> be moved to power/ directory?

it's ok to leave it in page_io.c since it's generating a fake-swapcacheentry, and there are writeback details etc.. that'd better stay in themm layer.-To unsubscribe from this list: send the line "unsubscribe linux-kernel" inthe body of a message to majordomo@vger.kernel.orgMore majordomo info at http://vger.kernel.org/majordomo-info.htmlPlease read the FAQ at http://www.tux.org/lkml/