[xine-devel] Lots of commits from patches of SuSE package...

Hi all,
I finally took some time to sort out patches from the xine package of
SuSE Linux, and pushed the ones upstream that I thought worthy for
inclusion. Here a short summary including some issues, as some of them
might be / are controversial:
xine-lib:
* src/xine-utils/cpu_accel.c:
Don't hardcode cache line size on PPC (Andreas Schwab).
* src/demuxers/demux_avi.c:
Security fix for http://www.xfocus.org/advisories/2006.
* src/demuxers/demux_avi.c:
Security fix for http://www.xfocus.org/advisories/200603/11.html, as far as
xine is affected (Unknown).
* src/libffmpeg/libavcodec/truemotion1.c,src/libffmpeg/libavutil/common.h,
src/libw32dll/wine/ext.c,src/post/goom/{filters.c,ifs.c,tentacle3d.c}:
Fixed gcc warnings (Adrian Schroeter).
* Issues: - One of the warning fixes was in in libffmpeg. I suggest not
tracking it, because it is only a warning issue.
- If anybody has commit rights to libffmpeg, it would be
nice, of course...
* src/xine-engine/input_cache.c:
Fixed unaligned access on IA64 (Andreas Schwab).
* src/libmpeg2/idct_altivec.c:
Fix undefined symbol [SUSE #173413] (Andreas Schwab).
* Issues: - This is in libmpeg2, I have to track it in
diff_to_ffmpeg_cvs.txt (doesn't compile on ppc otherwise)
- This wasn't an issue prior to gcc 4.0 (or 4.1?), because
only in newer gcc versions the variable is optimized away.
- If anybody has commit rights to libmpeg2, it would be
nice, of course...
xine-ui:
* src/xitk/oxine/mediamarks.c,src/xitk/oxine/oxine.c:
Fixed gcc warnings (Adrian Schroeter).
* src/common/utils.c,src/fb/osd.c,src/xitk/*.c,
src/xitk/xine-toolkit/{*.c,mrlbrowser.h}:
Fixed misuse of sprintf (Andreas Schwab + me).
* Issues: - The original patch (while being the 'right' solution)
changed localized strings, which had been misused to
include '%s' at the begining for concatenation with
sprintf (which is not supported but accidentially works).
The right fix would be to fix the locales, but I don't
have enough experience here. Currently the strings include
the '%s' and the argument is a "" right now.
src/xitk/actions.c:383,394,408
CU all
Matthias
--
Matthias Hopf <mhopf@...> __ __ __
Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@...
Phone +49-911-74053-715 __) |_| __) |__ labs http://www.mshopf.de

Thread view

Hi all,
I finally took some time to sort out patches from the xine package of
SuSE Linux, and pushed the ones upstream that I thought worthy for
inclusion. Here a short summary including some issues, as some of them
might be / are controversial:
xine-lib:
* src/xine-utils/cpu_accel.c:
Don't hardcode cache line size on PPC (Andreas Schwab).
* src/demuxers/demux_avi.c:
Security fix for http://www.xfocus.org/advisories/2006.
* src/demuxers/demux_avi.c:
Security fix for http://www.xfocus.org/advisories/200603/11.html, as far as
xine is affected (Unknown).
* src/libffmpeg/libavcodec/truemotion1.c,src/libffmpeg/libavutil/common.h,
src/libw32dll/wine/ext.c,src/post/goom/{filters.c,ifs.c,tentacle3d.c}:
Fixed gcc warnings (Adrian Schroeter).
* Issues: - One of the warning fixes was in in libffmpeg. I suggest not
tracking it, because it is only a warning issue.
- If anybody has commit rights to libffmpeg, it would be
nice, of course...
* src/xine-engine/input_cache.c:
Fixed unaligned access on IA64 (Andreas Schwab).
* src/libmpeg2/idct_altivec.c:
Fix undefined symbol [SUSE #173413] (Andreas Schwab).
* Issues: - This is in libmpeg2, I have to track it in
diff_to_ffmpeg_cvs.txt (doesn't compile on ppc otherwise)
- This wasn't an issue prior to gcc 4.0 (or 4.1?), because
only in newer gcc versions the variable is optimized away.
- If anybody has commit rights to libmpeg2, it would be
nice, of course...
xine-ui:
* src/xitk/oxine/mediamarks.c,src/xitk/oxine/oxine.c:
Fixed gcc warnings (Adrian Schroeter).
* src/common/utils.c,src/fb/osd.c,src/xitk/*.c,
src/xitk/xine-toolkit/{*.c,mrlbrowser.h}:
Fixed misuse of sprintf (Andreas Schwab + me).
* Issues: - The original patch (while being the 'right' solution)
changed localized strings, which had been misused to
include '%s' at the begining for concatenation with
sprintf (which is not supported but accidentially works).
The right fix would be to fix the locales, but I don't
have enough experience here. Currently the strings include
the '%s' and the argument is a "" right now.
src/xitk/actions.c:383,394,408
CU all
Matthias
--
Matthias Hopf <mhopf@...> __ __ __
Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@...
Phone +49-911-74053-715 __) |_| __) |__ labs http://www.mshopf.de