David S. Miller wrote:> On Fri, 10 Sep 2004 13:35:14 +0100> Brian Somers <brian.somers@sun.com> wrote:> > >>The problem seems to be that autoneg is disabled on the IBM switches.>>After disabling autoneg on the Sun shelf switches, I see the problem.>>This patch fixes things by reverting to sw autoneg which defaults to>>a 1000Mbps/full-duplex link but with no flow control when it fails>>(IBM should really have autoneg enabled!) - I'd appreciate it if>>someone could test this against an IBM blade.> > > Did you see the fix I posted the other day and have> already merged upstream?> > The real problem was the MAC_STATUS register checking in> tg3_timer() that we use to determine if we should call> the PHY code. Specifically, we were failing to test> MAC_STATUS_SIGNAL_DET being set, which when trying to> bring the link up means we should call tg3_setup_phy().

To be honest, when I saw your mail about that change, I was happyto down tools as the problem was clearly fixed. At that point Ialready had suspicions that the optimisations in this area mayhave issues.

But after a few more days, all the IBM blade folks were stillsaying they were having problems - and then Mike W gave me akick ;*P

I think the issue with the code up 'till now is that when HWautoneg fails, the driver just hangs about waiting for thehardware to do something - in my previous testing here, theswitch would eventually recover (my only way of breaking theswitch was to drop it to the monitor prompt or reload it),and at that point tg3 picks up the link status change andeverything's rosy.

> There are still some nagging problems with certain blades even> with my current code. Brian, if you want to help I'd really> appreciate it if you worked with current tg3 sources as I rewrote> the 5704 hw autoneg support from scratch since it was missing> a hw bug workaround and had other issues as well.> > Thanks.

Yes, I really ought to be running a current box, but for variousreasons I've been quite short of hardware for the past couple ofmonths. I now have a lab again, but it's not yet turned on, soI'm still scrounging hardware from people...