I'd prefer to avoid disabling it temporarily, to prevent further regressions.
I'm working on making it reasonably fast right now. Sorry for the trouble.
If you'd like to land this anyway, then maybe let's chat before. If the slowness
doesn't get fixed today, then it should be perfectly fine to land this.

jam

Sure, waiting till end of day to see if slowness is fixed seems reasonable. I ...

Sure, waiting till end of day to see if slowness is fixed seems reasonable.
I think the likelihood of regressions happening if it was reverted for a few
days will be low, and if they do happen, it shouldn't be huge changes that
occur. Since this only got turned on recently anyways, IMO it's not as if
we've been trained to depend on it for license issues.
On Thu, Sep 22, 2011 at 9:07 AM, <phajdan.jr@chromium.org> wrote:
> I'd prefer to avoid disabling it temporarily, to prevent further
> regressions.
> I'm working on making it reasonably fast right now. Sorry for the trouble.
>
> If you'd like to land this anyway, then maybe let's chat before. If the
> slowness
> doesn't get fixed today, then it should be perfectly fine to land this.
>
>
>
http://codereview.chromium.**org/7977043/<http://codereview.chromium.org/7977...
>

jam

btw I just looked through all the runs over the last few hours that had ...

btw I just looked through all the runs over the last few hours that had your
fix. They took anywhere from 3 minutes to 10 minutes (timeout).
I'll disable this for now. We can enable it once we figure out how to get it
to be fast and not flaky. I think some opportunities would be to only run it
for added files, and only run it on clobber builder. If the script itself
changes, then it can notice that and run against all files in the try run.
On Thu, Sep 22, 2011 at 9:21 AM, John Abd-El-Malek <jam@chromium.org> wrote:
> Sure, waiting till end of day to see if slowness is fixed seems reasonable.
>
> I think the likelihood of regressions happening if it was reverted for a
> few days will be low, and if they do happen, it shouldn't be huge changes
> that occur. Since this only got turned on recently anyways, IMO it's not as
> if we've been trained to depend on it for license issues.
>
>
> On Thu, Sep 22, 2011 at 9:07 AM, <phajdan.jr@chromium.org> wrote:
>
>> I'd prefer to avoid disabling it temporarily, to prevent further
>> regressions.
>> I'm working on making it reasonably fast right now. Sorry for the trouble.
>>
>> If you'd like to land this anyway, then maybe let's chat before. If the
>> slowness
>> doesn't get fixed today, then it should be perfectly fine to land this.
>>
>>
>>
http://codereview.chromium.**org/7977043/<http://codereview.chromium.org/7977...
>>
>
>