> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Thursday, June 23, 2016 6:50 PM
> To: dev at dpdk.org> Cc: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>
> Subject: [dpdk-dev] [PATCH] ip_pipeline: add Python script file for
> creating visual diagram of IP pipeline config file
>> This commit adds Python script for generating diagram of the application
> configuration file. This script requires graphviz package to be installed
> on the machine. The input config file is translated to an output file in
> DOT syntax, which is then used to create the image file using graphviz.
>> To run the script, following command is used;
>> ./diagram-generator.py -f <input configuration file>
>
Hi,
That is useful tool. The output looks very good.
> + if os.system("which dot"):
> + print dot_not_found_msg
The dot_not_found_msg variable isn't defined. It should be uppercase.
Also, it would be worth making the script Python 3 compliant since more
and more distros have that as the default.
John