Lars Hofhansl
added a comment - 06/Mar/12 07:37 Interesting. Seems reasonable
Out of personal interest: why 4? What is the default (on other distributions)? And why is CentOS special in this regard?
Also need an 0.94 patch (which hopefully is identical to trunk version)

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

Hadoop QA
added a comment - 06/Mar/12 08:06 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517201/HBASE-5529-trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -129 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 154 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1112//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1112//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1112//console
This message is automatically generated.

Gregory Chanan
added a comment - 06/Mar/12 18:49 The 0.94 patch would be identical to trunk. Do you want me to reattach with a 0.94 name?
Regarding your questions, see here: https://issues.apache.org/jira/browse/HADOOP-7154
That is a better explanation than I gave or the linked MR jira gives. I think that addresses all your questions, but let me know if you have more.

Lars Hofhansl
added a comment - 07/Mar/12 23:58 No need for a separately named 0.94 patch. Thanks for the link, makes perfect sense now.
+1 on patch.
Lastly, is this something we should add to hbase-env.sh?

Lars Hofhansl
added a comment - 08/Mar/12 05:00 If there're no concerns I'll commit tomorrow morning.
Again, if this is a problem during test runs, it will also be a problem when running HBase so we probably want to set this (at least as comment) in hbase-env.sh.

I don't think we need to add it to hbase-env.sh. The issue (at least what I've experienced) is with the mapreduce containers. So we need it in the surefire config when running unit tests, but when running the jobs normally, hadoop already has the configuration, because of HADOOP-7154.

If we run into these errors in another area of hbase, we can add it at that time.

Gregory Chanan
added a comment - 08/Mar/12 06:00 I don't think we need to add it to hbase-env.sh. The issue (at least what I've experienced) is with the mapreduce containers. So we need it in the surefire config when running unit tests, but when running the jobs normally, hadoop already has the configuration, because of HADOOP-7154 .
If we run into these errors in another area of hbase, we can add it at that time.