Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

From: "Daniel P. Berrange" <berrange redhat com>

To: Eric Blake <eblake redhat com>

Cc: libvir-list redhat com, Laine Stump <laine laine org>

Subject: Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

Date: Tue, 4 Jan 2011 16:01:02 +0000

On Thu, Dec 23, 2010 at 09:53:57AM -0700, Eric Blake wrote:
> On 12/23/2010 06:50 AM, Paweł Krześniak wrote:
> > On Wed, Dec 22, 2010 at 16:50, Laine Stump <laine laine org> wrote:
> >> I agree with Eric that this should be discussed with Dan Berrange and/or
> >> Daniel Veillard before comitting anything to the tree (definitely it needs
> >> doing in some manner, though).
> >
> > Another idea came to my mind:
> > Following logic behind <emulator> tag for domain definition, we could
> > introduce XML tag in network definition which would override default
> > location of dnsmasq (and radvd).
> >
> > For example:
> > <network>
> > <name>xxxnet</name>
> > <dnsmasq>/usr/local/bin/my-dnsmasq</dnsmasq>
> > <radvd>/usr/local/bin/my-radvd</radvd>
>
> Rather than tying the element name to our current choice of program, can
> we come up with something more generic?
>
> <network>
> <name>xxxnet</name>
> <ipv4routing>/usr/local/bin/my-dnsmasq</ipv4routing>
> <ipv6routing>/usr/local/bin/my-radvd</ipv6routing>
> </network>
>
> But the idea of allowing the XML to specify an override for the program
> to run seems like it might be worthwhile.
We don't want to directly expose the fact that we're running
a process for these services in the XML, because in the future
there's a good chance the way we run dnsmasq will change, such
that we don't run it per network, instead having one shared
instance.
Daniel