Stars ticket summary owner component _version priority severity milestone type _status workflow _created modified _description _reporter
1 44219 null post json object reference when retrieve a media item REST API 4.8.2 normal normal Awaiting Review defect (bug) new 2018-05-24T18:08:24Z 2018-05-24T18:08:24Z "hello, i have problem with my wp json api, and if i'm not wrong, maybe this is a bug in wp json api. So, when i try to retrieve a post item, the json object show that the post has featured media by id 7636.
{{{
{
// retrieved post item
""id"": 7634,
""date"": ""2018-04-16T09:56:54"",
""date_gmt"": ""2018-04-16T02:56:54"",
...
""author"": 79,
""featured_media"": 7636,
""comment_status"": ""open"",
""ping_status"": ""open"",
""sticky"": false,
""template"": """",
""format"": ""standard"",
""meta"": [],
....
}
}}}
full response here: https://himmahonline.id/wp-json/wp/v2/posts/7634
But, when i try to retrieve media with id 7636, the ""post"" json object is null. why this is happen? thanks before.
{{{
{
// retrieved media item
""id"": 7636,
""date"": ""2018-04-15T17:20:46"",
""date_gmt"": ""2018-04-15T10:20:46"",
...
""post"": null,
""source_url"": ""https://himmahonline.id/wp-content/uploads/2018/04/DSC_0384.jpg"",
...
}
}}}
full response here: https://himmahonline.id/wp-json/wp/v2/media/7636
" nurcholisart
44217 An error maybe related to some deprecated function. General normal normal Awaiting Review defect (bug) new 2018-05-24T16:46:47Z 2018-05-24T17:49:51Z " it looks like WordPress Core may still be using a deprecated function. See line 224 [here]https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-locale.php
The error in my apache error log
{{{
[Sun May 20 13:35:20.221828 2018] [proxy_fcgi:error] [pid 10537] [client 127.0.0.1:47010] AH01071: Got error 'PHP message: PHP Fatal error: Uncaught Error: Call to undefined function get_bloginfo() in /public_html/wp-includes/class-wp-locale.php:231\n
Stack trace:\n
#0 /public_html/wp-includes/class-wp-locale.php(112): WP_Locale->init()\n
#1 /public_html/wp-includes/load.php(927): WP_Locale->__construct()\n
#2 /public_html/wp-includes/wp-db.php(1569): wp_load_translations_early()\n
#3 /public_html/wp-content/plugins/w3-total-cache/DbCache_Wpdb.php(145): wpdb->db_connect(true)\n
#4 /public_html/wp-includes/wp-db.php(592): W3TC\\DbCache_Wpdb->db_connect()\n
#5 /public_html/wp-content/plugins/w3-total-cache/DbCache_Wpdb.php(252): wpdb->__construct('db', 'pass', 'user', 'localhost')\n
#6 /pu...\n
}}}
my server keeps generate this error until my server disk space was 0." pcnador
1 44215 Personal data exports - Empty values are included in the report Privacy 4.9.6 normal normal Awaiting Review defect (bug) new dev-feedback 2018-05-24T14:37:40Z 2018-05-24T16:14:28Z "Empty values should not be included in the report. Otherwise, the report will be cluttered with empty values.
Use the following code in `mu-plugins` to reproduce:
{{{
array( array(
'group_id' => 'group-1',
'group_label' => __( 'Orders', 'woocommerce-services' ),
'item_id' => 'item-1',
'data' => array(
array(
'name' => __( 'Exporter 1' ),
'value' => 1234,
),
array(
'name' => __( 'Exporter 2' ),
'value' => '',
),
array(
'name' => __( 'Exporter 3' ),
'value' => '0',
),
array(
'name' => __( 'Exporter 4' ),
'value' => 0,
),
),
) ),
'done' => true,
);
}
function register_exporter_1( $exporters ) {
$exporters['exporter_1'] = array(
'exporter_friendly_name' => __( 'Exporter 1' ),
'callback' => 'exporter_1',
);
return $exporters;
}
add_filter(
'wp_privacy_personal_data_exporters',
'register_exporter_1'
);
}}}
Results:
Before proposed patch:
[[Image(https://cloudup.com/iPJ8ocUnyiz)]]
After proposed patch:
[[Image(https://cloudup.com/i7MqWkMZjrj)]]" bor0
44214 Update wp-cli.yml path after 43309 General 4.9.6 normal normal Awaiting Review defect (bug) new has-patch 2018-05-24T14:35:21Z 2018-05-24T14:35:21Z Now that [43309] has landed, the {{{wp-cli.yml}}} file should be updated to point to the {{{build/}}} directory instead of the {{{src/}}} directory. JPry
44213 Tab order in Tools Administration 4.9.6 normal normal Awaiting Review enhancement new 2018-05-24T13:17:31Z 2018-05-24T13:17:31Z "Since 4.9.6, two new menu items are added in ""Tools"" when one logs in: ""Export Personal Data"" and ""Erase Personal Data"".
The position of these are lower than what is added by plugins and should be below ""Export""
.
Screenshot:
[[Image(https://i.imgur.com/6pzcmpV.png)]]
" superpoincare
44212 Add a new helper function for comma- or space-separated lists General normal normal Awaiting Review defect (bug) new has-patch 2018-05-24T10:26:34Z 2018-05-24T18:01:59Z "The functions `wp_parse_id_list()` and `wp_parse_slug_list()` both use `preg_split()` to convert strings to an array. Strings with leading or trailing spaces will result in an added empty value {{{''}}} or {{{0}}} returned by these functions.
Example
{{{
// leading space
$ids = wp_parse_id_list( ' 1,2,3' );
// result
array(
0 => 0
1 => 1
2 => 2
3 => 3
)
}}}
This is because the `PREG_SPLIT_NO_EMPTY` flag is not used with`preg_split()`. The same regex `'/[\s,]+/'` used by these functions is also used in other places in WordPress core (also without using the flag). That's why I propose a new helper function for comma- or space-separated lists (that uses the flag by default).
That function could then be used by `wp_parse_id_list()` and `wp_parse_slug_list()` and all other instances where this regex is used." keesiemeijer
44211 Add cookie domain to `userSettings` script localize General normal normal Awaiting Review feature request new has-patch 2018-05-24T08:30:04Z 2018-05-24T08:31:28Z I have cookie path and secure status but I need have `domain` param in array too. I think that this will helpful. sebastian.pisula
44210 Add filter for developers testing downloads from local servers HTTP API trunk normal normal Awaiting Review enhancement new dev-feedback 2018-05-24T02:25:59Z 2018-05-24T02:25:59Z "I can be the only one.
I have set up a local git server that runs on my LAN, 192.168.x.x
I use it to test plugin/theme updating. Within {{{wp-includes/http.php}}} {{{wp_http_validate_url()}}} we can already use the filter hook {{{http_request_host_is_external}}}, however, at the end of the function is a conditional test that will still fail and not return the {{{$url}}}. This is because {{{$same_host}}} is false if the dev environment and the local git server aren't on the same host/IP.
{{{
if ( $parsed_home && $same_host && isset( $parsed_home['port'] ) && $parsed_home['port'] === $port {
return $url;
}
}}}
My patch is a filter in a new conditional just after this penultimate conditional.
" afragen
44209 Admin Menu SVG Icon colour wrong in Default colour scheme Administration normal normal Awaiting Review defect (bug) new 2018-05-23T23:36:11Z 2018-05-23T23:36:11Z When using a SVG as an icon for an admin menu, the default color scheme shows the svg icons as a different colour (#82878c) than font icons (#a0a5aa). Other colour schemes seem to render svg icons correctly. Seems like it's related to /wp-includes/general-template.php line 3886 (WP 4.9.5), and possibly /wp-admin/includes/misc.php line 713. Changing 'base' => '#82878c' to 'base' => '#a0a5aa' fixes the issue for me. swift
44206 Missing short description and parameter comment in wp-admin/includes/ajax-actions.php General normal normal Awaiting Review defect (bug) new has-patch 2018-05-23T14:52:40Z 2018-05-23T14:52:40Z "Added function doc comment and parameter comment for `wp_ajax_delete_page`.
" abhijitrakas
44204 Privacy export codebase in 4.9.6 doesn't use WP Filesystem API Privacy 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-23T13:01:28Z 2018-05-23T13:36:02Z "The codebase added in WP 4.9.6 for privacy was written with low-level file APIs like fopen(), file_exists(), fwrite(), etc. rather than the WP Filesystem API. Quick to see in wp_privacy_generate_personal_data_export_file(). This restricts core parts of the privacy management functionality to only operate on hosts with direct access to the local filesystem.
It is recommended to instead use the WP Filesystem API so that more secure hosts are supported and a broader set of filesystems can be used, e.g. SSH, FTPext, FTPsocket, etc. https://codex.wordpress.org/Filesystem_API" diablodale
44203 Native fields for API key General normal normal Awaiting Review defect (bug) new 2018-05-23T11:51:52Z 2018-05-23T11:51:52Z "I think Captcha-protection is somehow ""must-have"" thing (I use on all my sites).
I'ts not arguable that most of users use Google ReCaptcha.
However, every new plugin we add, requires us to again and again enter (copy paste) the same key pairs in every individual plugin.
It could have been good, if there were fields in ""general options"" dashboard settings page (or somewhere), and plugins can access like this:
{{{
if ( !get_option(""google_recaptcha_secret_key""))
echo 'Please, enter ReCaptcha key pairs in settings page';
}}}
However, it can be done so, as WP clean installation, itself had hidden those fields, but the plugins (any of installed plugin) could make it force WP to show that field, like:
{{{
add_filter('admin_shown_fields', function($args){ $args[] = 'GOOGLE_RECAPTCHA'; return $args; } );
}}}
also, the concept can be extended and WP can have several ready FIELD PAIRS for other frequently-used APIs too, which can be activated using above filter, and can be obtained with `get_option`.
" tazotodua
2 44202 "Link to ""Privacy Policy"" automatically added to footer of any Twenty XXX theme" Bundled Theme 4.9.6 normal normal Awaiting Review enhancement new dev-feedback 2018-05-23T11:03:17Z 2018-05-24T14:08:27Z "Clients are confused about ""weird links appearing on each and every page"" and are ""scared about SEO ranking as the link does not have a nofollow"" ... quotes from client and their SEO consultant.
They already have own privacy policy links in footer via `do_action( 'twentyXXX_credits' );` or in custom menus via `wp_footer()`.
Expected Behaviour: No forced output of any links. Maybe a switch in the exact same place where the privacy policy page is set. Switch should be opt-in like ""add link to footer, some themes may show it"", not an opt-out.
A dev note for theme authors is mentioned in a [https://core.trac.wordpress.org/ticket/43715?replyto=36#comment:36 related ticket], can somebody provide a link to this dev note?
Besides that, the link does not show the real title of the privacy policy page, maybe related: #44192
Personal rant: You can't simply add breaking changes to frontend with a minor update from 4.9.5 to 4.9.6. WordPress is not a nanny, it is the users own responsibility to add links, when and where they like. Current behaviour is not ""democratize publishing"", it is ""dictate publishing""." Ov3rfly
44201 Ability to specify a URL as the privacy page Privacy 4.9.6 normal normal Awaiting Review feature request new 2018-05-23T09:24:58Z 2018-05-23T14:53:28Z "It's not uncommon for large companies and their subsidiaries to host their privacy policy at a central URL. This can also be the case on Multisite installations, where the privacy policy exists on the main site only.
In this case, it's not possible to specify an external URL as the privacy policy page." johnbillion
1 44199 Can't upgrade to WordPress 4.9.6 Upgrade/Install 4.9.6 normal critical Awaiting Review defect (bug) new reporter-feedback 2018-05-22T23:31:41Z 2018-05-23T23:01:42Z "Everything has been working just fine, updating wordpress has been a regular push a button and be done with it, up until the latest update.
My website refuses to upgrade to WordPress 4.9.6, each time I press the upgrade button, it says it's been upgraded but then it shows it is still 4.9.5
I tried it a thousand times now, even uploaded a fresh copy of wordpress 4.9.6 into the site and overwritten all files and it is still displaying WordPress 4.9.5 and the Upgrade wordpress notice is there.
It is driving me nuts, what is going on here?" Alex Vojacek
2 44198 "add ""Multisite support"" readme header to plugin directory" Plugins normal minor Awaiting Review enhancement new reporter-feedback 2018-05-22T21:51:08Z 2018-05-23T22:22:37Z "Building on the recent ""Requires PHP"" readme.txt header addition:
https://make.wordpress.org/plugins/2017/08/29/minimum-php-version-requirement/
Multisite support could also be specified, e.g.:
{{{
Multisite support: No [Yes]
}}}
" littlebizzy
1 44197 ZIP file containing a user’s personal data has user’s personal data in filename Privacy 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-22T19:16:41Z 2018-05-22T19:36:51Z "Example from wp-content/uploads/wp-personal-data-exports/
* wp-personal-data-file-info-at-example-com-1RwxnSYi7z...SZGjD6shoOc.zip
The email `info@example.com` can be clearly identified within the filename.
Hosting providers worldwide: Work literally day & night to provide anonymization of personal user data like IP address in access logs etc. for gdpr-compliance.
WordPress in a core privacy feature: HMB, let's put personal user data in a filename for personal user data.
Why this isn't a good idea in terms of gdpr and otherwise, incomplete list:
* While user email usually can be seen only in server database, now it can be seen in server filesystem
* During download the filename is stored in access logs of the server and ..
* .. in load balancer and firewall logs
* .. in proxy server logs
* .. in automated virus checking logs on proxy servers
* .. in automated virus checking logs on client
* .. in client browser history
* .. in client filesystem
* .. in client cloud backups
* ..
* After download has expired and user tries to re-download using the expired link ..
* .. the normal WordPress 404 page is triggered and the filename ends up ..
* .. in logs and/or storage of [https://wordpress.org/plugins/search/404/ 404 handling] plugins
* .. in trackers like Google Analytics or similar
* .. in referer logs of any third party content on 404 page
* .. in page url accessable to third party content on 404 page
* ..
Current Behaviour:
* wp-personal-data-file-[email]-[random].zip
Expected Behaviour:
* wp-personal-data-file-[hash of email]-[random].zip
Note: Would not suggest to use MD5 for hashing, otherwise many emails still could be revealed with minimal effort similar to [https://wordpressexpose.chrisgherbert.com/ Gravatar user emails]." Ov3rfly
44193 "Export Data request ""Action Confirmed"" email gets trimmed in gmail" Privacy normal normal Awaiting Review defect (bug) new 2018-05-22T17:14:04Z 2018-05-22T17:35:17Z While testing the Export Personal Data features, I noticed that the Action Confirmed email is getting trimmed after **User: username** by the gmail browser client. Screenshots coming. ianbelanger
1 44192 Title of Privacy Policy Page not used on login page Privacy 4.9.6 normal normal Awaiting Review defect (bug) new dev-feedback 2018-05-22T17:10:09Z 2018-05-22T19:47:32Z "1. Have a page with some title like ""Imprint and Privacy Policy""
2. Set as ""Privacy Policy Page""
Current Behaviour:
3. Link on login page does not use the page title.
Expected Behaviour:
3. Link on login page uses the page title." Ov3rfly
44191 is_email() function accepts non RFC822 General 4.7 normal normal Awaiting Review defect (bug) new 2018-05-22T15:59:25Z 2018-05-23T09:00:59Z "is_email() seems to declare non RFC822 compliant addresses as valid email address. The following email address came through a WooCommerce shop, the email address is altered.
faaanebencze.lujza.@umail.hu
due to the '.' at the end of the local part, the email address is not valid or RFC822, the logic shall be the follows
local-part = word *(""."" word)
still, the above mail address passes. (WooCommerce uses is_email() function to determine the email address validity.)" vonsch
1 44189 Missing Exif Data Media normal normal Awaiting Review defect (bug) new dev-feedback 2018-05-22T15:34:29Z 2018-05-22T15:41:21Z "Missing EXIF Data: the terminal exiftool provides the data as follow:
-HyperfocalDistance= excample: 1497.69 m
-LensID= excample: Sigma 150-600mm F5-6.3 DG OS HSM | S
- LensModel = worked in the past now is empty
you need examples? Many thx!" lriese
44188 Error in the deployed update GDPR Privacy 4.9.6 normal normal Awaiting Review defect (bug) new reporter-feedback 2018-05-22T15:33:50Z 2018-05-23T12:58:55Z "Hi, I want to bring to your attention that in your last update ""WordPress-4-9-6-privacy-and-maintenance-release"" Is a technical error.
This is not a bug!
According to the GDPR, we must anonymize IP adresses and can not track them any longer in Google Tag Manager or Google analytics. I am not aware if a consent will eliminate this or not. However, I would either change or remove this paragraph in the rolled out update.
Keep up the good work
Juergen Kuhlmann " justnailedit
1 44186 Possibles enhancements to 4.9.6 privacy tools Privacy 4.9.6 normal normal Awaiting Review enhancement new 2018-05-22T13:53:05Z 2018-05-23T13:37:48Z "-- User should start a request from frontend
User can create his own request starting from privacy page. Form are similar to the change password and login forms.
Maybe, in first time, wordpress do not provide directly the form, but let developer start a request from a form submission hooking to a specific hook or using a function provided by the core.
-- Automatic request processing
User could receive first email without admins starts or confirm the process as for change password request. For large websites is unthinkable they rely on the wordpress system to manage privacy requests if tasks of this kind has to be done by admins, they will go for other plugins to do that. We need to include an options to disable automatic request processing and let things as in 4.9.6.
-- Automatic send data
As for request processing, user could confirm the link on the second email and get directly the datas without admins work.
-- User should see their data on a webpage (Frontend Personal Data Profile Page?)
I guess the zip download has been long discussed.. but in my personal opinion is a real bad practice. We are talking about privacy and data protections and we should not stimulate the proliferation of pieces of personal datas spreading in internet and devices.
I’m thinking of a request started from a mobile device, the user can have his own datas and can delete it from your website. But this in some case this is not a real data erasure, but it is just a data transfer as, after the request, on his download folder of the mobile device it has a PDF containing a lot of personal informations like Addresses, Family Status, Accounts name, Phone numbers, etc…
People are not educated to take care of their personal datas..
Using a web page to show the personals data we could achieve more than one goal:
- we strength the overall privacy avoiding data proliferations
- people will remain on the website (marketers will love it)
- we could get granular erasure of datas
- user can update datas
-- Granular erasure of data
As 4.9.6 the request of deleting personal data is an all or nothing actions. People can request to delete all the data from the website and maybe delete his / her account.
People may want to delete just some part of the datas (maybe a second address, the family status, their phone number) but let other to be processed for their sake (they want to be in your interest based newsletter).
And again for the sake of the website admins, the relationship with the user will continue.
Example of an overall process.
- User start a data export request
- Website send an email to be confirmed
- User confirm the email
- Website send a second email with the link to see (and eventually download and erase) the personal datas
- On the Frontend Personal Data Profile Page the user delete an address, his marital status and update the phone number.
Every single step in the process could be automatic or manual depending on admins preferences.
" mnzhc
1 44183 BUG in get_the_archive_title() when get author Users 4.9.6 normal normal Awaiting Review defect (bug) new has-patch 2018-05-22T02:39:49Z 2018-05-22T14:32:35Z "On author archive page with no posts [https://wp-kama.com/filecode/wp-includes/general-template.php#L1465 get_the_archive_title()] don't display author name - it return empty string. Example: https://wp-kama.com/author/vladlu
It is because `get_the_author()` which need global var `$authordata`, but this var is empty if user dont have any posts...
{{{
} elseif ( is_author() ) {
/* translators: Author archive title. 1: Author name */
$title = sprintf( __( 'Author: %s' ), '' . get_the_author() . '' );
} elseif ( is_year() ) {
}}}
We need to think about the way to fix this. Maybe good solution is to set global $authordata for request with no posts in [https://wp-kama.com/filecode/wp-includes/class-wp.php#L558 WP::register_globals()]. Something like this:
{{{
if ( $wp_query->is_author() ){
if( isset( $wp_query->post ) )
$GLOBALS['authordata'] = get_userdata( $wp_query->post->post_author );
else
$GLOBALS['authordata'] = get_userdata( get_queried_object()->ID );
}
}}}
-
One more notice: it's better to use `esc_html()` for `get_the_author()` in `get_the_archive_title()`.
{{{
} elseif ( is_author() ) {
/* translators: Author archive title. 1: Author name */
$title = sprintf( __( 'Author: %s' ), '' . esc_html( get_the_author() ) . '' );
} elseif ( is_year() ) {
}}}
" Tkama
44182 No images in Media Library since the update to 4.9.6 Media 4.9.6 normal major Awaiting Review defect (bug) assigned reporter-feedback 2018-05-22T01:51:56Z 2018-05-22T14:02:27Z "Since the update today the images in my Media Library don't show the image just an X but they are working most everywhere else. I thought you might like to know in case someone else is having the same problem.
So basically if I go to the library to change, add or even upload a new picture just get the x and no picture.
Thanks" cheryl2017
2 44179 Use wp_update_comment instead of $wpdb->update $wpdb->comments when anonymizing comments Privacy trunk normal normal Awaiting Review enhancement new 2018-05-21T20:13:59Z 2018-05-21T20:13:59Z "During the course of the development on #43442 we switched from `wp_update_comment` to a direct `$wpdb->update( $wpdb->comments, $anonymized_comment, $args );`
Unfortunately, plugins that do things with comments when they change are more likely to hook wp_update_comment - so plugins like that are unaware when comments are anonymized
Let's switch back to wp_update_comment (as it was in earlier diffs on that ticket)
cc @azaozz" allendav
44177 Enhance wp_debug_backtrace_summary() with the optional ability to include arguments General normal normal Awaiting Review enhancement new has-patch 2018-05-21T14:38:52Z 2018-05-21T21:38:14Z "The attached patch for `wp_debug_backtrace_summary()`:
- Adds the optional ability to include arguments in the output
- Leaves the default behaviour as-is
- Removes an unnecessary check on whether the PHP version is at least a value which is still lower than the minimum one that WP supports" DavidAnderson
6 44176 Un-map Privacy Capabilities Privacy 4.9.6 normal normal Awaiting Review defect (bug) new dev-feedback 2018-05-21T14:31:43Z 2018-05-22T19:29:12Z "Three new capabilities were added in WordPress 4.9.6 to allow granular control over the new privacy features:
- `erase_others_personal_data`
- `export_others_personal_data `
- `manage_privacy_options `
If a site activates a role management plugin (such as [https://wordpress.org/plugins/members/ Members]), the capability is not listed under the Administrator role (which receives these capabilities by default), and is not available to be assigned to other roles. Adding this role as a custom capability does nothing because the capabilities are mapped to `manage_options` and `manage_network`.
A site could create a custom role specifically for someone to manage privacy requests that should not have access to other `manage_options` related functionality.
Related: #44079, ticket:44055#comment:5." desrosj
44174 wp_get_http_headers does not return status code or follow redirects HTTP API 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-21T13:13:02Z 2018-05-21T13:13:02Z "wp_get_http_headers performs an HTTP HEAD request and returns a simple success or failure code. This function is listed as part of the ""HTTP API"" on https://codex.wordpress.org/Function_Reference.
If the target resource issues a redirect, it is not followed, nor is the specific redirect code returned. It is possible to check for the Location header & follow the redirect manually. But wp_get_http_headers should, at least optionally, process redirects. It should also return the HTTP status code and message. One way to do this would be the Apache model - provide a Status pseudo-header in the response (e.g. 'Status' => '200 OK')
If a WordPress resource returns a 404 code, the result is 'success' with an HTML page suitable for humans - HEAD, of course, simply says content-type: text/html. This is indistinguishable from 200 for the page.
The underlying wp_safe_remote_head API seems to return the status, but it's not returned from wp_get_http_headers. Note that wp_safe_remote_head is not listed on the function reference page, so I assume is not intended for public use.
(If context matters, I'm using it to implement a shortcode in a plugin.)
I'm leaving this as a ""bug"" since failure to provide status prevents a caller from detecting errors and correctly processing a response." tlhackque
1 44172 TinyMCE style_formats broken for `a` tags Editor 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-21T10:59:16Z 2018-05-21T10:59:16Z "It seems that the link inserter breaks the TinyMCE style formats.
P-tag is working, the link-tag not.
{{{#!php
'Button',
'inline' => 'a',
'classes' => 'btn',
],
[
'title' => 'P',
'block' => 'p',
'classes' => 'largerp',
],
];
// Insert the array, JSON ENCODED, into 'style_formats'
$init_array['style_formats'] = json_encode( $style_formats );
return $init_array;
} );
}}}
" Horttcore
44169 New filter to short circuit WP_User_Query results Users normal normal Awaiting Review enhancement new needs-unit-tests 2018-05-21T01:52:16Z 2018-05-22T09:27:43Z "#41700 added the filter `posts_pre_query` to WP_Query. This filter lets you short circuit the WP_Query MySQL query to return your own results. We use this filter in ElasticPress to return results from Elasticsearch instead of MySQL.
This ticket (patch incoming) is to add a similar filter to WP_User_Query." tlovett1
44168 Add is_countable() check to wp-admin/includes/ajax-actions.php General trunk normal normal Awaiting Review defect (bug) new reporter-feedback 2018-05-20T21:16:30Z 2018-05-21T06:56:47Z "Update code with `is_countable()` wherever necessary in `wp-admin/includes/ajax-actions.php`
See #44123." thrijith
1 44165 Preview issue General 4.9.6 normal normal Awaiting Review defect (bug) new dev-feedback 2018-05-20T19:35:27Z 2018-05-21T08:57:57Z "Hopefully it's the theme and not the 4.9.6 update, but since updating all my posts in Learnpress have gone visible, whether preview or not.
This is triggering some weird behaviour in Learnpress, but thought I'd flag it up. I've had to password protect all my courses as they were all visible overnight to non-customers!" mccrow
1 44164 Getting a span code when switching from HTML to Visual editor Editor 4.9.6 normal major Awaiting Review defect (bug) new reporter-feedback 2018-05-20T18:56:17Z 2018-05-21T08:55:26Z "Hello.
After updating to WordPress 4.9.6 I am getting a span code in the editor and the tabs don't switch.
Here is code I'm getting:
{{{#!php
}}}
[[Image(https://i.imgur.com/nI7j5xJ.jpg)]]
It is a WordPress core error or maybe some theme or plugin incompatibility?
Thanks,
Rogério Moreira" rogeriomoreira
1 44163 wpdb->update() fails, showing no error message Database normal normal Awaiting Review defect (bug) new reporter-feedback 2018-05-20T18:54:05Z 2018-05-21T13:52:46Z "It's my second report about the incompletness of wpdb->update function.
1-2 years ago I've reported the scenario when it failed to update, but `last_error` was empty.
Now, another scenario, when it fails , but `last_error` is empty, is the following:
i.e. create a table with ""NOT NULL""
{{{#!php
query(""CREATE TABLE IF NOT EXISTS `example_table` (
`rowID` int(11) NOT NULL AUTO_INCREMENT,
`name` varchar(150) NOT NULL,
`id` varchar(150) NOT NULL,
`data` LONGTEXT NOT NULL DEFAULT '',
PRIMARY KEY (`rowID`),
UNIQUE KEY `rowID` (`rowID`)
) "". $wpdb->get_charset_collate() ."" AUTO_INCREMENT=1;""
);
}}}
then insert some empty value:
{{{
$wpdb->insert(""example_table"", array(""name"" => ""James"", ""id""=>""123"", ""data""=>""blabla"") );
}}}
then try to update
{{{
$wpdb->update(""example_table"", array(""name""=>""Jonathan""), array(""id""=>""133"") );
}}}
it doesnt update.
I have dumped `$this->dbh` (in wp-db.php 1887 line), and it shows affected lines: 0
`last_error` is empty. After spending much time, found that I was missing ""required"" parameter and added
{{{
$wpdb->update(""example_table"", array(""name""=>""Jonathan"", ""data""=>""new-blabla""), array(""id""=>""133"") );
}}}
(""NOT NULL"" requirement caused failure)
so, it's good, last_error contained some information, when affected lines are 0, or like such scenarios." tazotodua
44161 Expired session tokens need to be removed from database because GDPR Privacy 4.9.6 normal normal Awaiting Review enhancement new 2018-05-20T15:12:32Z 2018-05-20T15:12:32Z "WordPress stores the IP address (which is considered personal information) as part of its session tokens in the usermeta table. When the session expires, GDPR would seem to require the IP address to be removed from the database, as there is no longer a reason to keep it.
There should be some kind of garbage collection that removes expired session tokens on a daily basis." mechter
44159 feature request: otption for removing save my name in comments General 4.9.6 normal normal Awaiting Review feature request new 2018-05-20T04:14:29Z 2018-05-20T04:14:29Z "Hi,
As I see in wordpress 4.9.6, a new option has been added under comments fields that says: sava my name, email and etc…
Thant very nice. thank you so much
But I think it would be better if there was an option in wordpress settings to let website owners choose whether to select it or not to show on frontend.
Thank you very much" longman2020
2 44157 the comments/[id] endpoints should have the same permissions checks as the comments endpoint REST API trunk normal normal Awaiting Review defect (bug) new 2018-05-19T21:18:59Z 2018-05-19T21:18:59Z "I noticed this because custom comment types don't show up on the `comments` endpoint but it's possible to access them via their id in `comments/[comment_id]`.
`get_item_permissions_check` should do the same checks as `get_items_permissions_check` in `WP_REST_Comments_Controller`" tharsheblows
1 44156 REST API: Media uploads ignore CJK/emoji chars in filenames REST API 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-19T19:52:21Z 2018-05-19T19:52:21Z "When creating a new media item through the `media` endpoint, CJK and emoji characters in the payload file's name are not correctly set as the title of the resulting media file.
While explicitly supplying the CJK filename as a `title` argument works as expected, this is not necessary with non-CJK filenames.
The GUI uploader (media-new.php) handles CJK filenames correctly.
== Steps to reproduce:
1. POST a file with filename `日本語.mp3` to `/wp/v2/media`
Result: `title: {raw: """", rendered: """"}`
Expected result:`title: {raw: ""日本語"", rendered: ""日本語""}`" 0mirka00
44155 bugs found in 4.9.6 General 4.9.6 normal critical Awaiting Review defect (bug) new reporter-feedback 2018-05-19T19:44:24Z 2018-05-22T19:07:21Z "comments not working - in other words all the settings are the same as before this update but now readers cannot leave any comments on my blog posts. In addition the scrolling menu bar in backend for editing posts is not scrolling
" coleraine
44153 Plugin privacy polices and admin notification Privacy normal normal Awaiting Review enhancement new 2018-05-18T23:14:22Z 2018-05-18T23:23:49Z "If a plugin adds a privacy policy by hooking wp_add_privacy_policy_content(), the information shows up on example.com/wp-admin/tools.php?wp-privacy-policy-guide=1.
However, there's no link on the dashboard menu (esp settings->privacy) regarding that.
Settings->privacy does say ""Need help putting together your new Privacy Policy page? Check out our guide for recommendations on what content to include, along with policies suggested by your plugins and theme."" with a link in the text, but it's quite obscure.
How about a 2nd line: If any plugins or themes have available privacy policies, you'll find them [link]here[/link]. You can them use them on your own privacy policy page." sterndata
1 44152 "Comments ""up"" link does not cover custom post types and/or REST controllers" REST API trunk normal normal Awaiting Review defect (bug) new 2018-05-18T21:12:26Z 2018-05-18T21:55:58Z "Currently, `WP_REST_Comments_Controller` only covers built-in post types under the `/wp/v2/` namespace when making ""up"" links.
https://core.trac.wordpress.org/browser/trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php#L997
Note that `wp/v2` is hard-coded on the line above.
This causes issues if a comment falls under a custom post type with it's own REST controller falling under a different namespace." dsifford
3 44151 Personal data exports - lower priority exporters should place their data after the higher priority ones Privacy trunk normal normal Awaiting Review defect (bug) new has-patch 2018-05-18T16:55:40Z 2018-05-22T20:38:28Z "When two exporters are registered that export the data for the same group_id and the same item_id the data from the lower priority exporter is placed higher in the resulting file than the higher priority one.
For example, this code:
{{{#!php
function exporter_1( $email_address, $page = 1 ) {
return array(
'data' => array(
'group_id' => 'group-1',
'group_label' => __( 'Orders', 'woocommerce-services' ),
'item_id' => 'item-1',
'data' => array(
array(
'name' => __( 'Exporter 1' ),
'value' => 1234,
),
),
);,
'done' => true,
);
}
function exporter_2( $email_address, $page = 1 ) {
return array(
'data' => array(
'group_id' => 'group-1',
'group_label' => __( 'Orders', 'woocommerce-services' ),
'item_id' => 'item-1',
'data' => array(
array(
'name' => __( 'Exporter 2' ),
'value' => 4567,
),
),
);,
'done' => true,
);
}
add_filter( 'wp_privacy_personal_data_exporters', 'exporter_1', 5 );
add_filter( 'wp_privacy_personal_data_exporters', 'exporter_2', 10 );
}}}
should result in a file where 'Exporter 1' appears before 'Exporter 2' (see the priority attribute passed to the add_filter call), but this isn't the case.
CC @allendav @jeffstieler" robobot3000
44150 Consider adding a privacy policy confirmation checkbox to the register screen General 4.9.6 normal normal Awaiting Review enhancement new 2018-05-18T15:21:27Z 2018-05-18T15:21:27Z Consider adding a privacy policy confirmation checkbox just below the password field on the register screen in case there exists a privacy policy page. IMHO it is needed for a better GDPR compliance as upon registration they will need to be able to opt it in. summoner
1 44146 Design issue on Theme page General 4.9.6 normal normal Awaiting Review defect (bug) assigned 2018-05-18T12:28:00Z 2018-05-21T19:13:41Z "Theme section does not display properly on admin theme page. I installed WP 4.9.6.
[[Image(https://drive.google.com/file/d/1-sZZjOOkm4BE4A0dkfJya8rjm-XhR3zZ/view)]]" mitraval192
1 44145 Rework Privacy settings page to use the Settings API Privacy 4.9.6 normal normal Awaiting Review enhancement new 2018-05-18T12:23:18Z 2018-05-18T12:23:18Z Now that the Privacy page is under Settings, it should be reworked to utilize the Settings API. desrosj
2 44136 Privacy Pointer covers the thing it's pointing at Administration 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-17T21:25:30Z 2018-05-17T22:07:21Z "After upgrading to 4.9.6, a ""Personal Data and Privacy"" pointer appears to draw attention to the ""Tools"" menu, and the new submenu items.
Unfortunately, the pointer covers the Tools submenu that it's pointing at, which makes this pointer feel incomplete, unintentional, or broken.
Screenshot imminent." johnjamesjacoby
44135 Have Erasure button workflow follow Export button workflow replacing with static link Privacy trunk normal normal Awaiting Review enhancement new 2018-05-17T20:59:15Z 2018-05-17T20:59:15Z "Hello,
On the export workflow when you click the Email Data button it ends up going away replaced with a static ‘Email Sent’ message
On the removal workflow when you click the remove you get the inline alert but the buttons goes back to actionable state which makes you feel you should click it again. should it not instead go to a static text of ‘Data Removed’ to avoid repeatedly clicking.
Thanks" garrett-eclipse
1 44133 Should the Data Export indicate when we have no information on the user Privacy 4.9.6 normal normal Awaiting Review enhancement new has-patch 2018-05-17T20:45:33Z 2018-05-18T21:29:00Z "Hello,
If a data export is done for a non-existent user should we indicate in the .html file provided that we have no information on the subject? Currently the file is provided and just the initial table provided. If there's nothing else should a message be there to indicate that we currently have nothing stored on them?
Thanks" garrett-eclipse
1 44131 If draft page selected for Privacy Policy page should verbiage change from view to preview Privacy 4.9.6 normal normal Awaiting Review enhancement new 2018-05-17T20:33:56Z 2018-05-17T21:08:28Z "Hello,
Super minor, but should the verbiage on the Privacy Settings page switch from view to preview when the page you've selected for Privacy Policy page is in draft mode?
See screen for verbiage I'm speaking on, it's the 'Edit or view your privacy policy page content.'
Cheers" garrett-eclipse
1 44130 Mixed Case of Privacy Policy on Privacy Settings page Privacy 4.9.6 normal normal Awaiting Review defect (bug) new has-patch 2018-05-17T20:30:24Z 2018-05-23T19:46:13Z "Hello,
Super minor sorry didn't catch earlier, but seeing a mix of cases for Privacy Policy on the Privacy Settings. There's 'Privacy policy page', 'privacy policy page' and 'Privacy Policy page'. See attached screen.
Not sure what the rule of thumb is there or if this is introduced in en_CA as I'm on that locale.
Thanks" garrett-eclipse
3 44129 Setting Privacy Policy page as existing page gives misleading alert Privacy 4.9.6 normal normal Awaiting Review enhancement new 2018-05-17T20:23:59Z 2018-05-22T19:51:43Z "Hello,
We have an existing Privacy Policy so using the new tools on 4.9.6 we selected our existing page and clicked 'Use This Page' on the Privacy Settings page. On completion of this action the page reloads with the alert 'Privacy policy page updated successfully. Remember to update your menus!' which made my heart skip a beat thinking the pages content was updated in some way. To avoid this panic and people asking what's been updated on their page maybe this message can be modified to indicate what actually happens, 'Privacy Policy page set successfully. Remember to update your menus!'.
Thank you" garrett-eclipse
44127 editing an image can result in intermediate sized images left over after the image is deleted Media 4.9.5 normal normal Awaiting Review defect (bug) new 2018-05-17T19:51:02Z 2018-05-17T20:04:57Z "Steps to reproduce:
1. set thumbnail_size to `150x150`
1. upload a `300x300` image, e.g., `foo.jpg`
* will result in `/wp-content/uploads/foo-150x150.jpg` being generated
1. edit the image and scale to `200x200`
* will result in something like `/wp-content/uploads/foo-e1526583456941.jpg` being generated
* `/wp-content/uploads/foo-150x150.jpg` will still be present, since it is still a valid thumbnail for the scaled image
1. regenerate intermediate sized images (e.g., by calling [[https://developer.wordpress.org/reference/functions/wp_get_attachment_metadata/|wp_get_attachment_metadata()]] followed by [[https://developer.wordpress.org/reference/functions/wp_update_attachment_metadata/|wp_update_attachment_metadata()]], which the [[https://wordpress.org/plugins/regenerate-thumbnails/|Regenerate Thumbnails]] plugin does)
* will result in something like `/wp-content/uploads/foo-e1526583456941-150x150.jpg` being generated
1. ""Delete Permanently"" the image
Check `/wp-content/uploads` and you will see that `foo-150x150.jpg` is still there.
" pbiron
44121 Return of the Page Template Bug? Themes 4.9.5 normal critical Awaiting Review defect (bug) new 2018-05-17T13:24:19Z 2018-05-24T06:10:40Z "Problem is within WP 4.9.5 using Woocommerce 3.3.5 (latest), installed on 4/3/2018 as a new install from the server installer.
Woocommerce runs without a woocommerce.php script . Uploaded edited version of that script are not recognized.
The theme being used is a custom one which until today did not have this problem. Changes were made yesterday to the woocommerce.php script file. After uploading: the changes were confirmed and approved. Today, with one remaining issue to deal with, a modified version was uploaded. The site ignored that upload. The theme folder shows the date and time of upload to be today as 8:55am the previous identical upload was at 6:55 am.
The file is not recognized as even being there and a previous version, which literally was one refresh away from perfect (except the remaining pop up issue) is… showing the bad pop up in action and on other store pages that use the changes made for that script the missing new styles contained within changed a lot. Frustrating.
Woomcommerce database update was performed after a full site back up. Plugins that were not present before yesterday were disabled and removed. No change. WordPress itself was not updated as it is updated and a reload fo no reason is dumb.
All of a sudden this site acts like the 2017 ‘Tipton’ bug from WordPress ( https://wordpress.org/search/page+template+bug/?forums=1 ) that I was under the impression was long conquered.
And it never happened like this all through build and set up. In fact I have never seen this in 18 years.
So, laying the mess upon the alter: be there anyone who has already overcome this disaster? Any help would be greatly appreciated, the client is understandably concerned and I may be old but i’m not suffering from.. from.. yeah.. memory loss.
The site URL will be sent to anyone here requesting it just please give some form of contact other than public i do not desire to embarrass a fantastic product company and founder. This is posted in WordPress troubleshooting in hopes someone has already been here or can take an educated stab at what is going on." lkhlc
2 44119 WP API post status queries don't work with custom public post stati REST API 4.9.5 normal normal Awaiting Review enhancement new 2018-05-17T02:08:45Z 2018-05-17T02:08:45Z "The WP API only allows unpriv list requests to the posts controller for the `publish` status.
Shouldn't custom post stati with `'public' => true, 'private' => false` be query-able like so?
{{{
/wp-json/wp/v2/posts?status=unread
}}}
Currently, requests for posts with a custom post stati result in:
{{{
{""code"":""rest_invalid_param"",""message"":""Invalid parameter(s): status"",""data"":{""status"":400,""params"":{""status"":""Status is forbidden.""}}}
}}}
I've tested this behavior with the Codex provided custom post type example:
{{{
register_post_status( 'unread', array(
'label' => _x( 'Unread', 'post' ),
'public' => true,
'exclude_from_search' => false,
'show_in_admin_all_list' => true,
'show_in_admin_status_list' => true,
'label_count' => _n_noop( 'Unread (%s)', 'Unread (%s)' ),
) );
}}}
and tracked this back to `sanitize_posts_statuses` in `WP_REST_Posts_Controller` which assumes all post stati that differ from the default (publish) must be private and require `edit_posts`
https://github.com/WordPress/WordPress/blob/4.9.5/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L2279
" hurtige
44118 WordPress performs some unnecessary plugin update checks Plugins trunk normal normal Awaiting Review defect (bug) new 2018-05-17T01:50:49Z 2018-05-17T01:50:49Z "In the function `wp_update_plugins()`, it seems clear that the intent is not to check for updates if there has already been an update check recently (e.g., on the wp-admin/plugins.php page, ""recently"" means within the last hour). However, in some cases it will check for updates anyway because of subtle issues in the implementation.
The easiest way to reproduce the issue is to install the [https://wordpress.org/plugins/query-monitor/ Query Monitor] plugin (to view HTTP requests) and then perform the following steps:
1. Visit the admin section ""Updates"" page (wp-admin/update-core.php). Look at Query Monitor's ""HTTP API Calls"" - you should see a call to https://api.wordpress.org/plugins/update-check/1.1/ to check for plugin updates. (You might also see additional HTTP API calls for theme and core update checks.) Note: if you don't see the plugin update check, it's possible that there was already a check for updates in the last minute - update-core.php is supposed to check for updates no more than once per minute. Try waiting a minute and reloading the page.
2. Once you have seen the plugin update check being made, visit the ""Plugins"" page (wp-admin/plugins.php). Look at ""HTTP API Calls"" - you will see another plugin update check being made. This doesn't make much sense, because WordPress just checked for plugin updates on the update-core.php page.
3. Note that the additional update check in only occurs once. Try reloading the plugins.php page and look at ""HTTP API Calls"" again - this time there will be no plugin update check (which is the expected behavior, since WordPress just checked for plugin updates).
Looking at the code for `wp_update_plugins()`, it seems that the `update_plugins` transient is sometimes stored with a `checked` property, sometimes not. This doesn't make sense to me - when the `checked` property is not stored in the transient, the next call to `wp_update_plugins()` will always check for updates regardless of how recently the last update check occurred." siliconforks
44116 Trac Mentions link not working WordPress.org site trunk normal normal Awaiting Review defect (bug) new 2018-05-16T22:25:46Z 2018-05-16T22:53:57Z in page https://make.wordpress.org/core/handbook/best-practices/tools/ mojo2405
2 44114 GDPR - Provide upload mechanism for admins to supplement the data export generated by WordPress Privacy trunk normal normal Awaiting Review enhancement new 2018-05-16T16:52:41Z 2018-05-16T21:32:44Z "Hello,
I originally posted my idea on slack;
""And this is probably more for GDPR v2, but is there any plans on a tool on the export request for admins to manually supplement the export. Just thinking of maybe a json upload of non-core information the admin may have to provide the user for the request which would get merged into the .html file. Basically thinking of non-dev admins who won’t know how to code with the filters provided but need to add more to the export. Thanks""
I was hoping to assist the standard admin who may have data collected in places that aren't on-site or aren't integrated with the core tools it would be nice to provide them a method to supplement the core data before the export is sent to the user.
In my mind an xml or json upload which follows a standard format would be great way to add more information to the .html data file that gets zipped and sent to the requester. And maybe even a way to upload other files such as images to be bundled in the zip.
I understand there's filters and actions for this if you're a savvy admins, but often the basic admin doesn't have those skills or just wants to add a bit of information to that export.
Hope that made some sense ;)
Thanks" garrett-eclipse
1 44112 WP is changing page URL to avoid duplicate URL for non needed case Networks and Sites 4.9.5 normal normal Awaiting Review defect (bug) new 2018-05-16T15:55:54Z 2018-05-16T15:55:54Z "WP has URL slug validator after page/post saved, when WP recognize potential of duplicate URL slug between the main site pages and each of existing multisites URL, WP will update the post_name (page slug URL) and adding suffix number to the page URL.
In the following scenario this validation should not be made:
* Create New WP multi-site instance (sub-directory).
* Create new site called ‘blog’ and publish it.
* Move to root site.
* Create new page without parent page with name ‘blog’ and publish it.
* WP will change the page slug to ‘blog3’ (with number suffix) to avoid duplicate URL [OK]
* Create new page with parent page ‘simple-page’ called ‘blog’ and publish it.
* WP will change the site slug to ‘blog4’ [BUG]
In this case WP should leave the slug as is, because the result URL will be “simple-page/blog” and there is no URL conflict here.
**Possible Solution:**
update “avoid_blog_page_permalink_collision” function [wp-admin/includes/ms.php:640] to do not modify the “post_name” if “post_parent” exists." tubys
44111 Setting data to variable early. Administration trunk normal normal Awaiting Review enhancement new close 2018-05-16T15:11:30Z 2018-05-17T02:36:57Z I think setting data to variable early. rnaby
44107 wp_insert_user should return WP_Error if user_url's length is too long General normal normal Awaiting Review defect (bug) new 2018-05-16T10:36:43Z 2018-05-16T10:36:43Z "Just like the user_nicename checking
Consider the test below
{{{
public function test_wp_insert_user_should_reject_user_url_over_100_characters() {
$user_url = str_repeat( 'a', 101 );
$u = wp_insert_user(
array(
'user_login' => 'test',
'user_email' => 'test@example.com',
'user_pass' => 'password',
'user_url' => $user_url,
)
);
$this->assertWPError( $u );
}
}}}
This also apply to the function `wp_update_user`" tszming
44106 Embed code not being regenerated on link change in Insert/edit media dialog TinyMCE 4.9.5 normal normal Awaiting Review defect (bug) new 2018-05-16T10:28:35Z 2018-05-16T10:28:35Z When using the Insert/edit media dialog to embed videos, if a user puts a source link in for an unrecognized URL, it will generate a tag, if it is recognized (at least if it's youtube), it will generate an iframe. However, if the user changes the URL, for example puts an unrecognized link in then changes it to youtube, the youtube link then just gets placed in the src of the video tag instead of regenerating an iframe tag, and vice versa. brmoore252
44103 change the type attribute of #menu_order from 'text' to 'number' General 4.9.5 normal normal Awaiting Review feature request new 2018-05-16T01:36:09Z 2018-05-16T01:36:09Z "Currently, when focus shifts to the input box of menu_order in the situation that the IME is turned on, an extra operation such as inputting a numerical value after turning off the IME is necessary.
I would like to improve on this.
Now:
{{{
menu_order ); ?>"" />
}}}
Change:
{{{
menu_order ); ?>"" />
}}}
Also, please add a style to specify the width." tmatsuur
1 44101 GDPR Erasure Workflow - Make the Erasure Fulfilled notification admin triggered Privacy trunk normal normal Awaiting Review defect (bug) new 2018-05-15T22:59:46Z 2018-05-16T21:32:44Z "Hello,
This might be more for a GDPR v2, but from an admin perspective, I found it easy to overlook any manual actions the admin may need to do to properly complete an Erasure.
With the current workflow the requester confirms, and on admin clicking 'Erase Personal Data' the data WP knows about is removed and the user receives a Erasure Fulfilled notification. So is it expected the admin would remove any other non-WP core data before clicking that option?
I was thinking it might be nice to have that 'Erase Personal Data' conduct the erasure but hold off on the fulfilled email and have that manually triggered by the admin once they've removed any other data. Would be nice if this step prompted the admin to conduct any other erasure steps that their process might require.
Hoping that makes sense, I'm just feeling that currently there's no part in the process prompting the admin to do any other erasures that the core doesn't cover.
Thank you" garrett-eclipse
1 44100 GDPR Privacy Page setting allows for Draft Pages Privacy 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-15T22:37:41Z 2018-05-17T21:08:28Z "Hello,
Currently the Privacy Policy page select provides both published and draft pages. If a draft is selected it would be nice to indicate it's status to the user from this page. Was thinking possibly just by having (draft) appended to the select option for any pages in draft, or (private) for private pages to avoid users selecting non-published pages and overlooking.
For myself when I clicked 'Create New Page' it updated the setting pointing it to the new draft page which resulted in the Privacy Policy link no longer being present on the confirmation pages. Would be nice to either not allow drafts be selected or indicate they're draft so you're aware you have to finalize and publish.
Hope that makes sense,
Thanks" garrett-eclipse
1 44099 Add Request Type into Admin Email Subject for GDPR Privacy 4.9.6 normal normal Awaiting Review defect (bug) new has-patch 2018-05-15T22:30:32Z 2018-05-17T21:08:28Z "Hello,
Similar to #43968 the Admin notifications don't provide an indication in the subject for what action was confirmed, see screenshot.
Thanks" garrett-eclipse
44098 Widget classes when custom widget class is namespaced Widgets normal normal Awaiting Review defect (bug) new 2018-05-15T21:04:14Z 2018-05-15T21:04:14Z "Widgets output from a namespaced class have a class added to the {{{before_widget}}} argument in a way which is potentially confusing and messy to work with.
The {{{before_widget}}} value within the arguments array sent to the {{{widget()}}} method within {{{WP_Widget}}} looks something like this when using a namespaced custom widget class:
{{{
'
}}}
Given my understanding of WP's ""normal"" escaping of attributes, I would have expected {{{myplugin-My_Widget}}}, {{{mywidgetname myplugin-My_Widget}}} or maybe {{{mypluginMy_Widget}}}.
I believe that ''technically'' the two escape characters make the WP output the equivalent to the latter, but it's a bit messy and potentially confusing to folks looking to style the output, or find the {{{aside}}} using JS." rogerlos
1 44097 Introduce cookie consent & management to core Privacy normal major Awaiting Review enhancement new 2018-05-15T20:24:28Z 2018-05-24T16:07:17Z "Cookie consent is going to be one of the biggest hurdles for most sites. There are more than a dozen plugins attempting to do this in various ways, but I think that is inevitably going to be a nightmare.
Consider it from both site owner and plugin developer perspectives:
Site owner:
Plugin A support Cookie consent plugin 1
Plugin B support Cookie consent plugin 2
Do I install both cookie consents, or uninstall one of my needed plugins and maybe find a replacement that also uses consent plugin 1?
----
Plugin developer:
Do I really need to build and maintain long term support for dozens of 3rd party cookie consent plugins. There won't be time for anything else.
----
I propose this needs to be core functionality, a centralized point of registering cookies in a dynamic way under several predefined categories.
Any other way leads to major issues for the entire ecosystem.
There are several general categories:
Necessary
Preferences
Statistics
Marketing
Other could be a possible one as well.
Each plugin can then dynamically define cookie name, label & description for each cookie which could look something like this (adapted from #44010):
{{{#!php
'necessary',
'group' => __( 'Plugin Name' ), // Allows for logical grouping within each category
'label' => __( 'Cookie Label' ),
'reason' => __( 'Used for reason x, y & z' ),
];
return $cookies;
});
}}}
Alternatively, it could be done via a register_cookie_for_consent() function but I think a filter is most versatile.
----
Next would come a front end consent overlay on first visit, maybe a method of reopening this modal in the future to manage them again as well.
It should likely show each category and a way to enable disable by category as a whole or on per cookie basis to some extent as required by law.
----
Last part that needs to be there is a way to test if consent for a particular cookie has been granted or denied. This is paramount as plugins such as analytics need to check for consent prior to loading the analytics js which will track the user.
I don't pretend to have all this worked out but I will be happy to contribute as much time as needed to get something to this effect in place as it ultimately saves me and my users thousands of collective hours in fixing compatibility with many different consent plugins." danieliser
1 44094 Hook for WP_User data hydration to enable strong data security Users normal normal Awaiting Review enhancement new 2018-05-15T17:54:31Z 2018-05-23T22:05:04Z "Hi there! I'm one of the founders of Crypteron, a data-security platform for developers. I'm also active in the WordPress community, an organizer of the [San Diego Advanced WordPress Meetup](https://www.meetup.com/Advanced-WordPress), an admin of the [Advanced WordPress Facebook Group](https://www.facebook.com/groups/advancedwp) (with over 30,000 members) and a past speaker and organizer at WordCamp San Diego.
For the past 8 months I've been working on a free plugin called **EncryptWP** that brings military-grade data-security to WordPress. It automatically encrypts and decrypts sensitive user data such as names, email addresses and physical addresses and even supports secure, searchable encryption. It's been a labor of love and is available for beta testing at https://github.com/crypteron/encryptwp.
The reason I'm posting a ticket here is that I've had to resort to a non-ideal approach to automatic decryption of native (non-meta) user fields within WordPress. Ideally I would decrypt sensitive user data right after it's loaded from the database as it is hydrated into the `WP_User` object. Unfortunately, no hook is fired during this process. I strongly believe that one should be.
Instead, I decrypt native user fields using a combination of the filters: `edit_user_{{$field}}`, `{{user_{{$field}}`, `the_author`, and `wp_dropdown_users`.
This approach works but has some major downsides:
* The `edit_user_{{$field}}` and `user_{{$field}}` filters are only fired when `$user->filter` is truthy (See line 308 of `class-wp-user.php`). I do my best to ensure that this value is set, but plenty of plugins interact with `WP_User` objects without setting their `filter` property. This results in some plugins outputing encrypted text for fields such as `display_name`.
* The `edit_user_{{$field}}` and `user_{{$field}}` filters are fired in the `sanitize_user_field` method which, fundamentally, is not a logical place for this sort of operation.
* Some native WordPress code bypasses the `sanitize_user_field` method so I've had to add additional filters for `the_author` and `wp_dropdown_users` (using a RegEx!)
* Rather than decrypting all sensitive data once, I have to decrypt it every time it is fetched which is inefficient.
Despite all of this, EncryptWP works very well. I think the plugin can be a game-changer for WordPress, making HIPAA compliant WordPress sites possible not to mention the new world of GDPR compliance. We have an ambitious, technical road map for the plugin including extending it to handle user-defined meta keys, encrypting `wp_post` and `wp_options` data, key management, and more. But I'd really love to get it 100% compatible and performant with all plugins and, in order to do that, we really need a `WP_User` hydration filter.
Such a filter could benefit many other plugins as well and is guaranteed to be backward compatible with all other sites since it would not change existing behavior. I would envision that the filter could be added within the [WP_User->init](https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-user.php#L170) method:
{{{#!php
data = apply_filters('init_user_data', $data, $site_id);
$this->ID = (int) $data->ID;
$this->for_site( $site_id );
}
}}}
Please let me know your thoughts on adding this new filter. One line of code can make all the difference!
" yguez
3 44090 Reword plugin compatibility text to something more meaningful Plugins normal normal Awaiting Review enhancement new has-patch 2018-05-15T13:52:46Z 2018-05-15T15:12:10Z "Currently, when looking at the plugins update table on the `/wp-admin/update-core.php` page, it says whether the plugin is compatible with the version of WordPress you are running and the latest version (or just the latest if you're on it).
It states that it's 100% compatible. This seems to be left over from the old days when people could rate if a plugin worked on a certain version, but this doesn't apply anymore as it either does work, or it doesn't. You can't quantify it with a percentage because it's just not possible. It either works or doesn't.
I'd suggest the wording here is updated to reflect the current state of plugin compatibility by replacing the percentage with either a yes or no value.
It's my understanding that based on the meta data in the plugin readme, it'll either be 0% or 100%, so that's either a 0 (no) or 1 (yes). I've attached a screenshot of what I mean." danieltj
1 44089 Clear post password cookie when logging out Posts, Post Types normal normal Awaiting Review defect (bug) new has-patch 2018-05-15T11:28:02Z 2018-05-15T14:25:28Z "I think it is expected behaviour that when a user logs out of WordPress, they are also ""logged out"" of viewing password protected posts for which they've entered the password. This is not the case. The `wp-postpass_{hash}` cookie is not cleared when a user logs out.
Example scenario:
1. Log in to WordPress.
2. Publish a password protected post.
3. Navigate to the post permalink and enter the password to view the post.
4. Log out of WordPress.
The password protected post is still viewable at its permalink, despite the user having just logged out. It's correct that viewing a password protected post is not tied to a user session, but I think most users would expect that after logging out of their account they would no longer be able to see the contents of a password protected post that they just published.
Previously: #32567
Related: There is no way for any user -- logged in or not -- to ""log out"" of viewing a password protected post. I'm sure there's an existing ticket for this but I can't find it." johnbillion
44088 Merged two if into single Taxonomy trunk normal normal Awaiting Review enhancement new has-patch 2018-05-15T11:09:22Z 2018-05-15T11:09:22Z In `get_the_term_list` function there is no need to check with two if conditions. As at line `1246` of the same file inside `get_the_terms` function it is returning `false` when the `$terms` is empty then there is no need to check it again in `get_the_term_list` I think. rnaby
1 44087 Duplicate case in Entities.php External Libraries lowest normal Awaiting Review defect (bug) new 2018-05-15T05:04:20Z 2018-05-15T08:06:33Z "There is duplicate 'case' present for ""\x0B"" in 'entity()' function of 'SimplePie_Decode_HTML_Entities' class present at 'wp-includes/SimplePie/Decode/HTML/Entities.php'
Code Reference : https://github.com/WordPress/wordpress-develop/blob/e72d50370273c2741329e1a102ec90b35cf1b492/src/wp-includes/SimplePie/Decode/HTML/Entities.php#L172" akshayar
4 44083 Add action to wp_mkdir_p() when directory is created successfully Filesystem API 2.0.1 normal normal Awaiting Review enhancement new has-patch 2018-05-15T00:11:46Z 2018-05-23T19:46:19Z "It would be nice if the `wp_mkdir_p()` function contained a hook for plugins to interact with when a directory gets created.
The use-case I have currently is that Easy Digital Downloads (for example) creates `.htaccess` files and empty `index.php` files in its own `uploads/edd` directory, and each directory inside it, as one way of protecting those empty directories from being publicly browsable.
Because there is no action hook here, EDD uses a daily transient, which leaves new directories potentially open until the transient expires.
An action hook on directory creation would allow for EDD to create those files immediately." johnjamesjacoby
44082 settings_errors() wraps all notices in p and strong tags General normal normal Awaiting Review defect (bug) new 2018-05-14T19:06:59Z 2018-05-14T19:06:59Z "I noticed today that `settings_errors()` wraps every notice in a set of `

` and `` tags.
This is undesirable for a few reasons:
* Notices should be allowed to use their own formatting (they already are everywhere)
* Many/most core notices that do not use `settings_errors()` are not strong, or use `strong` for emphasizing specific parts of a notice
As a result, almost every plugin is forced to reinvent their own approach for putting out admin notices. Core even does this in a bespoke way in almost every other admin page, resulting in a bunch of duplication and fragmentation of approaches.
(A quick grep of `.php` files in `wp-admin` with `is-dismissible` in them shows 75.)
----
A few ideas:
* We could use `wpautop()` to wrap each notice to avoid duplicate `

` tags
* We could use KSES to only allow certain tags in a notice (not certain this is necessary)
* We could invent a new function for formatting admin area notices in places other than settings (which most plugins do already, so something they can use is preferable)
I can also imagine this issue being a smaller part of a larger `admin_notices` initiative, but figured I'd at least document this kvetch." johnjamesjacoby
1 44080 Unreachable dead code in ID3/module.audio-video.quicktime.php General 3.6 normal normal Awaiting Review defect (bug) new 2018-05-14T18:56:07Z 2018-05-14T19:16:57Z "There are two consecutive blocks for
case 'rmla' in QuicktimeParseAtom functions. The second will never be visited under any given condition.
{{{
case 'rmla': // Reference Movie Language Atom
$atom_structure['version'] = getid3_lib::BigEndian2Int(substr($atom_data, 0, 1));
$atom_structure['flags_raw'] = getid3_lib::BigEndian2Int(substr($atom_data, 1, 3)); // hardcoded: 0x0000
$atom_structure['language_id'] = getid3_lib::BigEndian2Int(substr($atom_data, 4, 2));
$atom_structure['language'] = $this->QuicktimeLanguageLookup($atom_structure['language_id']);
if (empty($info['comments']['language']) || (!in_array($atom_structure['language'], $info['comments']['language']))) {
$info['comments']['language'][] = $atom_structure['language'];
}
break;
case 'rmla': // Reference Movie Language Atom
$atom_structure['version'] = getid3_lib::BigEndian2Int(substr($atom_data, 0, 1));
$atom_structure['flags_raw'] = getid3_lib::BigEndian2Int(substr($atom_data, 1, 3)); // hardcoded: 0x0000
$atom_structure['track_id'] = getid3_lib::BigEndian2Int(substr($atom_data, 4, 2));
break;
}}}
Here is a pointer to the issue ->
https://github.com/WordPress/wordpress-develop/blob/e72d50370273c2741329e1a102ec90b35cf1b492/src/wp-includes/ID3/module.audio-video.quicktime.php#L690
" kikk
1 44078 Add an email pseudonymization function that preserves first letter and TLD Privacy normal normal Awaiting Review enhancement new 2018-05-14T18:16:11Z 2018-05-16T21:32:44Z "In addition to the existing behavior of wp_privacy_anonymize_data( 'email', $email_address) which returns deleted@site.invalid, it would be useful, e.g. for debug logging to have another type that would return pseudonymized email addresses that retain a little bit of the original address, e.g.
{{{#!php
my-mailbox@mailprovider.com.ca
}}}
could become something like
{{{#!php
m*********@****************.ca
}}}
Where the number of * corresponds to the letters removed, and only the first letter of the email address and the TLD are retained.
See also https://iapp.org/news/a/top-10-operational-impacts-of-the-gdpr-part-8-pseudonymization/" allendav
2 44077 Image editor not working after WP update 4.9.5 this week Post Thumbnails 4.9.5 normal major Awaiting Review defect (bug) new reporter-feedback 2018-05-14T17:36:37Z 2018-05-15T13:33:56Z "Hi:
I used to upload images to my wordpress site, then resize them to fit my columns of info. After this week's update:
1. I am unable to select & copy images; it must be done at the text level.
2. If you left click on an image, you automatically jump to the bottom of the open page.
3. If you try to use the image delete (""X"") or edit (pencil image), nothing happens.
I am using regular google browser, I see that some other users have inquired about this exact problem recently, but it appears unresolved.
Is there a way to make it function like before?
Thanks & we appreciate all you do.
Paul Chandler
www.pickguardplanet.com
" adrianchandler
44074 oEmbed with many

tags do not work Embeds trunk normal minor Awaiting Review defect (bug) new 2018-05-14T14:31:21Z 2018-05-14T14:31:21Z "If an oEmbed has more than ten {{{

}}} tags {{{WP_oEmbed::_strip_newlines}}} (called by {{{oembed_dataparse}}}} filter) returns a wrong result for it.
All {{{

}}} tags get temporarily replaced by a token, the newline stripping gets done and then the tokens {{{

}}} get replaced back to their HTML. The tokens unfortunately are just {{{__PRE__}}} plus a counter (e.g. {{{__PRE__0}}}, {{{__PRE__1}}}) Thus if there are more than ten {{{

}}} tags there will be tokens like {{{__PRE__10}}}. These obviously clash with previous tokens.
Granted, this is ''quite'' uncommon but nonetheless it should be fixed in my opinion." jagszent
44073 Add functionality to search plugin with double quoted keyword Plugins normal normal Awaiting Review feature request new 2018-05-14T14:22:42Z 2018-05-23T14:24:28Z "Is this possible to add a feature where plugins could be searched on `Add New Plugin` page either with:
- More than one keyword wrapped inside double quotes. Example: ""my plugin""
OR
- Add a filter like **Match Whole Phrase** (in existing filter dropdown)
In either case, it would be much easier to locate the desired plugin as the result will become more filtered and less items would appear on screen. This can avoid scrolling through ""relevant results""." subrataemfluence
44072 Plugin repository search error - cannot find plugin with Author's name Plugins trunk normal normal Awaiting Review defect (bug) new 2018-05-14T13:02:45Z 2018-05-14T14:56:01Z "If I search with Author option selected in plugin repository (/wp-admin/plugin-install.php), no plugin is found unless the author name is present in the Plugin name or may be somewhere in the description.
Example:
I searched with `Takayuki Miyoshi` as a Keyword and got a handful of result, but when I selected Author, it returned no result." subrataemfluence
44070 Avoid flickering of admin notices General normal normal Awaiting Review defect (bug) new 2018-05-14T10:16:22Z 2018-05-14T12:50:11Z "Here's an example:
- Save settings on the ''General Settings'' page ({{{wp-admin/options-general.php}}})
- Then the ""Saved settings"" admin notice displays first above the page header.
- Then it moves below it, causing flickering.
The admin notices are moved with Javascript in {{{wp-admin/js/common.js}}}
{{{
/*
* The `.below-h2` class is here just for backward compatibility with plugins
* that are (incorrectly) using it. Do not use. Use `.inline` instead. See #34570.
* If '.wp-header-end' is found, append the notices after it otherwise
* after the first h1 or h2 heading found within the main content.
*/
if ( ! $headerEnd.length ) {
$headerEnd = $( '.wrap h1, .wrap h2' ).first();
}
$( 'div.updated, div.error, div.notice' ).not( '.inline, .below-h2' ).insertAfter( $headerEnd );
}}}
See ticket #35047 and changeset [36134]. Also ticket #34570 and changeset [35516].
The same happens for notices on the other admin ''Settings'' screens, like:
- {{{wp-admin/options-writing.php}}}
- {{{wp-admin/options-reading.php}}}
- {{{wp-admin/options-discussion.php}}}
- {{{wp-admin/options-permalink.php}}}
- {{{wp-admin/profile.php}}}
- {{{wp-admin/user-edit.php?user_id=123}}}
- ... etc ...
We should avoid this flickering, e.g. hide it with CSS and display it with Javascript?
I guess we should also consider the case if Javascript is turned off?
Related #43978 [https://core.trac.wordpress.org/ticket/43978 Avoid flickering on the Tools / Export page]
" birgire
1 44068 Provide a way to check whether a user's data has been erased Privacy trunk normal normal Future Release enhancement new 2018-05-14T04:43:10Z 2018-05-16T21:32:44Z "There should be some way for plugins to check for completed personal data erasures, so they won't store any personal data afterwards for those users.
Consider the following scenario:
1. Plugin X saves user IP address when they sign in
2. User requests personal data erasure
3. Administrator completes the request and Plugin X deletes the user's IP by using the ""wp_privacy_personal_data_erasers"" hook
4. Administrator removes the request
5. The same user signs in again later. The plugin saves the user's IP address again since there is no way for the plugin to know that this user had requested a personal data erasure.
Right now, when you click on the ""Remove Request"" button, the request (post) is completely deleted from the database and there is no record of the erasure.
So, if the requests were not completely deleted from the database after clicking on the ""Remove Request"" button, but for example stored with a custom status such as ""completed-removed"", this would allow us check if a particular user has requested data erasure and therefore not store any personal data about this user anymore. Or alternatively there could be a flag stored in user meta upon erasure." dennis_f
2 44067 Refactor get_avatar and related functions to make Gravatar a Hook instead of a Default Comments normal normal Awaiting Review enhancement new 2018-05-14T03:24:43Z 2018-05-17T22:46:50Z "The design of get_avatar and related functions is a problem for a variety of reasons. It creates a dependency on gravatar even when a gravatar isn't being used.
However, gravatar is such a long-standing part of WordPress it would hurt more to remove it. So, the logical solution is a refactoring.
We've added filters are various levels. Gravatar should be hooked onto these filters, and if someone removes the hook, everything will return an anonymous image hosted as part of the plugin.
Identicon, wavatar, and monsterIDs were originally plugins for WordPress that were absorbed by Gravatar(https://blog.gravatar.com/2008/04/22/identicons-monsterids-and-wavatars-oh-my/). They generate anonymous icons from the provided email or hash. Mystery person can be stored locally, and maybe we can add a few options for this.
It would not change any functionality. It might pave the way for local avatars, waiting in #16020 for seven years.
Gravatars are implemented are problematic from a privacy standpoint, which has come out locally as a priority issue. As noted in an 8 year old ticket, #14682, it does share your information with gravatar.
5 Years Ago, in #23179, it waas suggested that gravatars should only be used for registered users.
So, we have people saying that this should be addressed. Local avatars continues to be a request, but this isn't that.
While I set out a bigger agenda here to host the default icons, the scope of this ticket would be that if you remove the gravatar hunting hook from WordPress, it would just return false, as the signature of the function already has as an option.
" dshanske
44066 Add a tool to test personal data without sending a mail to a user Privacy normal major Awaiting Review feature request new 2018-05-13T21:17:04Z 2018-05-16T21:32:44Z "Hello, just testing RC1 and the GDPR tools...
Yes, it looks great, but I found a catch which will make all the stuff very complicated. It seems that it is impossible to simply test what data a site has on a user. Because, in the Export Request, you state that
""An email will be sent to the user at this email address asking them to verify the request.""
But in real life, if a request is made, it is very useful (or even essential, I'd suggest) that an admin could to test the data and a simply see ""what we have here""...
But since the email is send, there is, I believe, no way to check it privately... Please, consider including this tool... If it is already there, I apologise for not getting it...
Best,
Jan" iprg
1 44060 Search by Keywords and filter based on ...for Plugin search Engine! Plugins 4.9.5 normal normal Awaiting Review feature request new 2018-05-12T22:25:41Z 2018-05-12T22:38:45Z "Hi,
On WordPress.org we found a lot of old plugins and we can't filter when we do a search by keywords
We must be able to search by keywords AND filter based on
a) Version compatibility. Example : tested with 4.9.5
b) How much active installations ?
c) Last update date, examples : three days, three months, three years
d) Popularity" Casimir11767
3 44058 Include security sniffs in PHPCS ruleset Security normal normal Future Release enhancement new 2018-05-12T16:14:39Z 2018-05-16T18:31:10Z "Currently, our custom ruleset includes the sniffs for prepared queries, but not for XSS or CSRF.
I couldn't find any previous discussions about why they're not included. The only thing I can think of is that there might be too many false positives?
In my experience, the XSS sniff works well. The CSRF one sometimes generates false positives, but I think it'd be better to include it, and then refine our code and/or the sniff to address those, than it would be to not use it at all, and take the risk of a vulnerability slipping through.
" iandunn
4 44043 Framework for logging/retrieving a users consent state Privacy trunk normal normal Awaiting Review enhancement new close 2018-05-11T09:33:28Z 2018-05-22T22:51:53Z When a users visits a website for the first time, the user should be able to opt in or out from cookies. There are a couple of WP plugins that provide such functionality. The most common cookie categories are; necessary, preference, statistics, marketing. Other plugins should be able to retrieve the users consent state through WP Core, which allows them to avoid putting unwanted cookies in the users browser, without having to explicitly support certain cookie consent plugins. cookiebot
2 44042 Hook for ‘delete_option’ behaviour required Options, Meta APIs 1.2 normal normal Future Release enhancement new dev-feedback 2018-05-11T07:45:45Z 2018-05-17T15:16:31Z "Hi, I posted this about one month ago in the wordpress support forum: [https://wordpress.org/support/topic/hook-for-delete_option-behaviour-required/]
I did not receive any answers there but referred to this forum, so I post it here again:\\
Hi, I would need to prevent and change the deletion of certain options by the WP core function ‘delete_option’.
There is a hook
{{{
do_action( 'delete_option', $option );
}}}
available here: [https://core.trac.wordpress.org/browser/tags/4.9.4/src/wp-includes/option.php#L532]\\
But this does neither provide a way to exit the delete_option function before the option is deleted nor to change the option name to be deleted. In fact this existing hook seems to be pretty useless.
Therefore I would need a filter in the first line of the delete_option core function like
{{{
$option = apply_filters( 'delete_option_name', $option );
}}}
.
Or change the line 535 from
{{{
$option = trim( $option );
}}}
to
{{{
$option = trim( apply_filters( 'delete_option_name', $option ));
}}}
Any chances to get this into core immediately?\\
Thx, Robert
" RobertoDonPedro
44039 attachment rewrite rule redirects to posts instead of showing 404 Rewrite Rules normal minor Awaiting Review defect (bug) new 2018-05-10T17:04:23Z 2018-05-10T19:33:26Z "Instead of showing 404 for an invalid attachment slug, you will be redirected to a valid post slug.
The blog is set to permalink structure `%postname%`
The attachment rule for this is `[^/]+/([^/]+)/?$`
And the rewrite is `index.php?attachment=$matches[1]`
Tested on a clean WordPress-installation running twentyseventeen if you visit /hello-world/sample-page/
you will be redirected to /sample-page.
Is this really how it should be?
" swedish boy
44037 Cannot hide plugin description on responsive view Administration trunk normal normal Awaiting Review defect (bug) new 2018-05-10T12:20:24Z 2018-05-11T11:48:27Z "Plugin description is not toggling by clicking `Screen Options > Description` on responsive view.
Steps for reproduction:
1. Go to Plugin page
2. Enter responsive view (Chrome: Shift+Ctrl+I, FireFox: Shift+Ctrl+M)
3. Pull down Screen Options dialog by clicking on `Screen Options` button at top right corner
4. Check / Uncheck Description checkbox
5. Description visibility never toggles.
In both desktop and responsive views the markup stays the same:
{{{

Plugin description here...

}}}
Tested in Chrome and FireFox\\
OS: Ubuntu 14.04\\
WordPress version: 5.0-alpha-43205
Screenshot attached." subrataemfluence
44036 Checkboxes appearing strangely in FireFox responsive view Administration normal normal Awaiting Review defect (bug) new 2018-05-10T11:52:31Z 2018-05-10T13:54:37Z "When I switch to mobile view in FireFox, the checkboxes are appearing strangely! Please see screenshot.
WordPress version: 5.0-alpha-43205
FireFox version: 59.0.2 (64-bit)
OS: Ubuntu 14.04
Steps to reproduce:
1. Go to /wp-admin/edit.php?post_type=page
2. Press Shift+Ctrl+M to bring up smaller view" subrataemfluence
44035 Admin flyout submenu does not open on mouseover when changing device width in browser Menus normal normal Awaiting Review defect (bug) new reporter-feedback 2018-05-10T11:40:03Z 2018-05-23T14:34:06Z "On Chrome (Version 66.0.3359.139 (Official Build) (64-bit)), if I switch to mobile view from desktop, refresh the page and then switch back to dekstop view, no flyout submenu is opening on mouseover.
For example, if I hover on `Posts` menu, the flyout menu is supposed to appear but it is only appearing when I click on it! Which also means the click event does not take me to the posts list page immediately. Once I click on `All Posts` link, everything gets back to normal.
OS: Ubuntu 14.04
Steps to reproduce:
1. Go to admin.
2. Press Shift+Ctrl+I to reduce viewport size.
3. Refresh the page.
4. Press Shift+Ctrl+I again to go back to desktop view.
5. Mouseover on Post or Pages or Appearance. Flyout menu will not appear.
6. Click on the menu item to bring up the Flyout menu." subrataemfluence
44034 Privacy: Introduce a function to count user requests by type Privacy trunk normal normal Awaiting Review enhancement new dev-feedback 2018-05-10T11:13:55Z 2018-05-16T21:32:44Z "The user request list tables use {{{WP_Privacy_Requests_Table::get_request_counts( $type )}}} to count user requests by type.
If export- and erase bubble counts will be added in #44000 and if e.g. plugins or core will add request stats to the dashboard ( e.g. ""At a glance"" or ""Activity"" metaboxes), then it makes sense to introduce a function like:
{{{
wp_count_user_requests( $type )
}}}
where type is either {{{'remove_personal_data'}}} and {{{'export_personal_data'}}}.
An alternative would be if {{{wp_count_post( $post_type = 'user_request' )}}} would support {{{$post_name}}} as well, for the request types.
" birgire
44033 Get Avatar Comment Types should be a Function Not Just a Filter Comments normal normal Awaiting Review enhancement new 2018-05-10T00:15:55Z 2018-05-24T13:32:34Z "Pretty much what it says.
I envision, is_avatar_comment_type, that takes WP_Comment, or a comment_ID and returns true or false.
Right now, if I want to use this filter in the code I use to bypass Gravatar, I have call the filter myself. I don't think it is a good idea to call filters multiple times if you can help it." dshanske
44032 Use random_bytes() for generating keys and salts Upgrade/Install normal trivial Awaiting Review enhancement new has-patch 2018-05-09T23:21:52Z 2018-05-12T09:06:46Z "While auditing WordPress for remote queries the servers make, I noticed the generation of salts in wp-admin.php is wasteful with an unnecessary loop inside a loop. If the system php supports random_int it also supports random_bytes.
Attached patch generates 64 byte (512 bit) salts without needed the 64 round loop inside the 8 round loop loop." alicewondermiscreations
3 44030 Remove unnecessary `This email has been sent to ###EMAIL###` from privacy emails. Privacy trunk low normal Future Release enhancement new has-patch 2018-05-09T21:44:05Z 2018-05-16T21:32:44Z "Several privacy related emails contain a string in the body saying, `This email has been sent to ###EMAIL###`. It appears that this was copied from the emails that get sent when an email address changes, without considering if it made sense in the new context.
I think that string is appropriate in the original use cases, because explicitly calling out the receiving address can help avoid confusion, since the address is changing.
The string is not used in any other emails in Core, though, except for some of the new privacy ones from 4.9.6. I think the string is unnecessary in the new context, and it's best to remove it.
The recipient address is already obvious enough from the `To` header, and removing unnecessary content will make the messages shorter, and maybe even avoid some suspicion from spam filters, which sometimes penalize seemingly innocent text, especially if it contains URLs or email addresses.
* wp_privacy_send_personal_data_export_email() - r43012 / #43546.
* wp_send_user_request() - r42791 / #43443." iandunn
2 44028 Conditional Statements are not meeting Yoda Conditions Coding Standards General normal normal Awaiting Review defect (bug) new has-patch 2018-05-09T20:29:58Z 2018-05-23T19:46:19Z "A lot of conditional statements are not meeting Yoda conditions coding standards. Variables are placed on the left side instead of right side.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-pclzip.php#L3636" seusmaniqbal
44027 """Enable full-height editor"" setting only saved on page refresh" Users trunk normal minor Awaiting Review defect (bug) new 2018-05-09T18:49:19Z 2018-05-09T18:49:19Z "Testing the ""Enable full-height editor and distraction-free functionality."" setting on my personal site as well as a customer's site:
* logged in: setting is enabled (Add New Post, Screen Options)
* disable and logout immediately (without changing anything or refreshing page)
* logged back in: still enabled
* disable, refresh page and then logout
* logged back in: now disabled
* enable and logout immediately
* logged back in: still disabled
* enable, refreshed page and logged out
* logged back in: now enabled
I also verified this using `wp user meta get 1 rug3dk50q_user-settings` while performing the same actions. Watching the Chrome network tab, it appears that clicking the checkbox for this setting is not triggering an admin-ajax call to update this user setting, whereas the Boxes and Layout screen options do trigger the call.
It does appear to correctly update the `wp-settings-1` cookie correctly when the setting is toggled.
" GunGeekATX
1 44025 Privacy: Pagination screen options for the requests list tables Privacy trunk normal normal Future Release enhancement new 2018-05-09T18:09:09Z 2018-05-16T21:32:44Z "It's handy to have the screen options for pagination.
We could add it with e.g.:
{{{
$args = array(
'label' => __( 'Requests per page' ),
'default' => 20,
'option' => $screen->id . '_requests_per_page'
);
add_screen_option( 'per_page', $args );
}}}
or with a shorter options like {{{export_requests_per_page}}} and {{{erase_requests_per_page}}}.
We then need to adjust the switch in {{{set_screen_options()}}} to handle these two new options.
I assume the admin pages:
{{{
wp-admin/tools.php?page=export_personal_data
wp-admin/tools.php?page=remove_personal_data
}}}
will get their own files in 5.0?
Else we would need to hook into the corresponding {{{""load-{$page_hook}""}}} action.
Then we can fetch the per page option with:
{{{
$posts_per_page = $this->get_items_per_page( $this->screen->id . '_requests_per_page' );
}}}
in the {{{WP_Privacy_Requests_Table::prepare_items()}}} method.
" birgire
44024 Unreachable destination file pointer closing in getid3.lib.php External Libraries normal major Awaiting Review defect (bug) new has-patch 2018-05-09T17:24:48Z 2018-05-09T23:59:23Z If for any reason, a file is opened for writing and the file pointer fails to seek to the offset, then the fclose($fp_dest) is unreachable. The destination file handle would remain open until the script execution is finished, which could lead to a corrupted file or other probable security issues. itowhid06
2 44022 Location information of admin users leaked Administration 4.8 normal normal Awaiting Review enhancement reopened 2018-05-09T15:01:52Z 2018-05-11T20:35:08Z "class-wp-community-events.php
That class and what it does really needs to be taken out of core and turned into a plugin. I don't care if it is a plugin that installed by default and even turned on by default, but it needs to be easy to turn off.
https://gist.github.com/AliceWonderMiscreations/b6acab93d03f73ba3b327aaebbf043e1
That turns it off, but that will get undone w/ the next WordPress because it is modifying a core file.
Please turn that feature into a plugin that can easily be turned off by non-technical admins.
Also the class uses unsalted md5 - wouldn't it be better to use one of the site specific salts in the wp-config.php to salt the key created with the md5?" alicewondermiscreations
44021 Dashboard menu disappears in Chrome beta General normal normal Awaiting Review defect (bug) new 2018-05-09T14:51:22Z 2018-05-09T14:51:22Z When using Chrome 67, scrolling down the page on any dashboard page, makes the links to the left invisible (still clickable). Yet another Chrome bug, and it's reported here, but if they fail to fix it could be an easy CSS fix. https://bugs.chromium.org/p/chromium/issues/detail?id=840521 programmin
44020 WordPress Installation Error Upgrade/Install normal normal Awaiting Review defect (bug) new has-patch 2018-05-09T12:44:45Z 2018-05-09T14:26:16Z "On all my new project I have this error message if I want to install WordPress:
Fatal error: Uncaught Error: Call to undefined function wp() ..... wp-blog-header.php on line 16
Please fix it. " Benjamin_Zekavica
1 44019 Class-wp-widget-categories.php causes js error in console. Widgets 2.8 normal normal Future Release defect (bug) new has-patch 2018-05-09T11:36:10Z 2018-05-11T18:04:02Z "The implementation of onCatChange() javascript function in class-wp-widget-categories.php causes problems in themes which use wrappers to style select boxes (drop down menus).
HTML dropdowns are very limited in terms of styling possibilities. It is quite common practice for the front-end designers to use javascript to add a custom wrapper around the select boxes for further styling.
For the sake of clarity, to create a style like this ([[Image(https://orionthemes.com/img/select-box.png)]]), one absolutely needs a custom wrapper.
In this case select box changes html structure:
{{{
}}}
becomes
{{{

}}}
If you do this in WordPress categories widget, an error is returned in console:
{{{
(index):830 Uncaught TypeError: dropdown.parentNode.submit is not a function
at HTMLSelectElement.onCatChange ((index):830)
}}}
Interestingly, if you do the same thing with the archive widget, everything works as it should.
To test this, you can add this jQuery to functions.js file in the theme:
{{{
$('.widget_categories select, .widget_archive select').wrap('

');
}}}
" arhit
44018 Adding a filter in paginate_links function General normal normal Awaiting Review enhancement new 2018-05-09T06:46:12Z 2018-05-09T06:46:12Z "Possible to add a filter at the end of **paginate_links** function similar to this: http://take.ms/eBEyB
It's beneficial for developers to change anything from links, HTML, ... in the final output.
In my case, I want to change the HTML class so I can easily make it Bootstrap pagination friendly." re.ardestani
1 44017 Add filter to display edit post link without 'edit_post' capability Posts, Post Types normal major Awaiting Review enhancement new reporter-feedback 2018-05-09T04:40:20Z 2018-05-10T02:57:28Z "WordPress has come a long way from just being a Blogging CMS. Now we can allow our end users to Post using different plugin without bringing the users in WP Admin. So, basically users don't need the 'edit_post' capability to be just able to create and edit posts using plugins.
Hence, this filter is needed so that plugins can allow any user to view the built in edit post link on front-end if needed." rafsuntaskin
14 44013 Add Basic Access and Deletion Front-end Request Forms as shortcodes/widgets/blocks Privacy normal normal Future Release feature request new 2018-05-09T02:58:13Z 2018-05-16T21:32:44Z "Per this Slack discussion:
https://wordpress.slack.com/archives/C9695RJBW/p1525394015000159
In order for the new GDPR features to truly work ""out of the box"" (per WordPress Philosophy standards), and to not force users to find their own options (""Decisions not Options"") it would be best if WordPress Core provided at least a simple name/email frontend form for users of a website to create their ""Right to Access"" and ""Right to be Forgotten"" requests that would populate the admin entries for those tools.
I understand how that might seem like form-plugin territory, but without it, these new tools are so limited as to not be useful.
Naturally, the output of these shortcodes/widgets/blocks can have filters so form plugins can hook into them to customize the forms further than the default, but the bare minimum would simply be one form for ""Right to Access"" and one form for ""Right to be Forgotten"" that simply has an email address field (no other fields are truly necessary since the confirmation emails would be sent automatically, and no action would happen until confirmed). " webdevmattcrom
1 44012 Store the agreed-to-privacy-policy date/timestamp to help prove GDPR compliance Privacy 4.9.5 normal normal Awaiting Review feature request new 2018-05-08T20:54:16Z 2018-05-19T02:37:06Z "Anytime a customer agrees to a privacy policy, should that be stored in some way? Perhaps the version of the privacy policy they agreed to, the date they agreed to it, and the user who agreed should be stored so that it could be used to prove that they agreed to any specific privacy policy, should a GDPR audit happen to anyone in the future.
If so, I'm not sure if it should be stored as user meta, or if it should be stored in a unique table so that the agreement of a guest commenter could also be stored. " johnstonphilip
44011 link to gmpg.org for XFN should now be https everywhere in core and core themes Security 4.9.5 normal normal Awaiting Review enhancement new has-patch 2018-05-08T20:44:11Z 2018-05-08T21:52:29Z "In order to push forward with https-everywhere, this will need correction.
https://gmpg.org/xfn/11 is now fully functional as https, and there is no reason to avoid working the change into the wordpress core, as well as in core themes.
my current blog has mostly single-occurance in header.php, but one stood out with over 36 occurrances within:
>$ ack -cl 'http://gmpg.org'
wp-content/themes/twentyeleven/header.php:1
wp-content/themes/twentyten/header.php:1
wp-content/themes/twentytwelve/header.php:1
wp-content/themes/tempera/header.php:1
wp-content/themes/twentyten-madhouse/header.php:1
wp-content/themes/twentyfourteen/header.php:1
wp-content/themes/twentythirteen/header.php:1
wp-content/themes/twentythirteen-madhouse/header.php:1
wp-content/plugins/siteorigin-panels/tpl/live-editor-preview.php:1
wp-admin/includes/meta-boxes.php:36
wp-admin/edit-link-form.php:1
wp-includes/theme-compat/header.php:1
This will help avoid mixed-content warnings from some reporting algorithms and services on the web, and since it now works, there is no reason not to do so.
" WebDragon
1 44010 GDPR: Add general filters for registering various privacy policy information (cookies) from plugins General normal normal Awaiting Review defect (bug) new 2018-05-08T19:04:24Z 2018-05-08T19:11:58Z "I didn't see it mentioned but during testing of integrating a real plugin, I found that it seems extremely complicated and out of order without some explicit filters for listing things like cookies.
To be clear when a plugin adds additional suggested text it appears below the core text in a completely separate box. This is so detached it means if you have 10+ plugins this is gonna be an all-day process for any user to go through generating a policy for their needs.
If I just append our plugin suggested text to the end and it has cookies, they will be separate from the other ""Cookies"" sections further up.
I think the smarter approache is to implement something to the effect that we could register our cookies, analytics etc, just like the exporters.
{{{#!php
__( 'Cookie Label' ),
'reason' => __( 'Used for reason x, y & z' ),
];
return $cookies;
});
}}}
Then it could automatically be output via a shortcode or block or whatever to a table of
| Cookie Name | Cookie Label - Cookie Description |
| wp_cookie_test | WP Test Cookie - Used to determine if cookies are available for use. |
The same would apply to several other sections. I think outputting those into a simple 2 column table would be easy to work with, clean output and easy enough for plugins & themes to integrate with.
You could do similar and register user meta info collected, or even specific analytics plugins could output label and info on how they use the data directly under the Analytics heading.
Monster Insights, for instance, might add
Google Analytics: Tracks visitor engagement with the site anonymously for use in marketing & improvement." danieliser
3 44006 Privacy Policy page should have suffix like other special pages Privacy trunk normal minor Awaiting Review enhancement new has-patch 2018-05-08T11:02:49Z 2018-05-17T20:41:09Z The Privacy Policy page (''when set in the Privacy page within `Tools > Privacy`'') doesn't have the special page suffix like the Home and Blog pages do. As this page has special options when officially set as ''The Privacy Policy Page'', it needs to have a suffix so people can pick it out easily from the list of pages. danieltj
2 44005 Privacy template file Privacy 4.9.6 normal normal Awaiting Review enhancement new 2018-05-08T10:51:15Z 2018-05-17T21:38:18Z "With the introduction of a privacy generator (not exactly what it is, but just roll with it), it would be beneficial to include something in the template hierarchy for this as well.
Looking at many large sites and services, their designs are often created to continue drawing focus to new things, leaving the privacy text as ""just another page"". These same sites have often opted to separate their privacy pages, giving them a simpler and non-intrusive design focusing solely on the text at hand.
This could be achieved with a page template, although creating a page template for a single purpose makes little sense, but given that we're creating tools around this in the first place it is a natural evolution to also provide a separate theme file for this kind of content." Clorith
2 44004 TwentySeventeen Theme - CSS issue when using rowspan in tables Bundled Theme 4.9.5 normal minor Awaiting Review defect (bug) new has-patch 2018-05-08T10:09:32Z 2018-05-08T17:54:28Z "I've spotted an issue with the TwentySeventeen theme. This definition in styles.css:
{{{
th:first-child,
td:first-child {
padding-left: 0;
}
}}}
causes problems when using tables containing rowspans. Specifically, this code:
{{{

Head 1

Head 2

Cell 1

Cell 2

Cell 3

Cell 4

}}}
produces a table where Head 2 and Cell 2 have padding-left: 0.4em, while Cell 3 and Cell 4 have padding-left: 0. This produces a table with misaligned cells in the same column.
" aussi
44002 fread(): Length parameter must be greater than 0 - Happens on all updates to core, plugins, themes. Upgrade/Install 4.9.5 normal normal Awaiting Review defect (bug) new 2018-05-08T06:32:16Z 2018-05-08T13:12:03Z "I'm getting this error in my log every time updates are run. It occurs regardless of whether any plugins or non-wordpress issued themes are active. I am using Sentry on my live site to catch pretty much all errors, and this consistently turns up every time anything updates.
As a test measure, I disabled app 3rd-party plugins and themes, and ran an update against an older version of the twentyfifteen theme as an isolated case. The issue still occurs in lieu of any other 3rd party modifications.
{{{
array(4) {
[""type""]=>
int(2)
[""message""]=>
string(48) ""fread(): Length parameter must be greater than 0""
[""file""]=>
string(66) ""/xxx/xxx/xxx/xxx/redacted.com/wp-admin/includes/class-pclzip.php""
[""line""]=>
int(4212)
}
}}}
This appears to be a core bug with the updater. The issue has been consistent since at least 4.9.0, probably earlier.
--------
This component needs to be using fstat to check the size prior to attempting to read. Something like this:
{{{
$f = fopen('file', 'r+');
$stat = fstat($f);
$size = $stat['size'];
if ( $size > 0 )
{
// The file is non-zero length and safe to read.
$contents = fread( $f );
// Carry on.
} else {
// Do not fread an empty file. Return, throw an exception, whatever's clever.
}
}}}
" mopsyd
2 44001 GDPR: oEmbed two click / local emoji scripts Privacy 4.9.5 normal major Awaiting Review enhancement new 2018-05-08T06:10:40Z 2018-05-16T21:32:44Z "Hi,
the first beta release 4.9.6 has a few optimziations due to the GDPR, but I think, WordPress is missing two very relevant features. With the latest beta release, WordPress would not be legal for use within the EU - except you´re using WordPress as private notepad!
1) oEmbed two click solution: similar to the shariff plugin, all embedded items via the core WordPress oEmbed function need a two click privacy. Only when the user first clicks on the embedded item, the scripts should be active and the user can view / listen to the embedded item.
2) The emoji script is loaded from Automaticc. There is no possibility to disable this behaviour or the best would be: load all scripts locally. This is one of the relevant of GDPR: you cannot tell your users or lawyers, why it is relevant for using your site, when specific scripts like emoji are loaded from a CDN. There is no need for a CDN.
It would be great, if you could still imagine to implement those both things, because they are rather important than a general privacy policy page, which the most users of WordPress had already created as a single page. And I think not all related core features needs an extra plugin, when it´s time to develop the core further. WordPress should go ahead and implement more features to the core than letting even more plugins used for a proper website.
Thanks and regards," yoursql719
3 44000 Add notification bubble to Tools menu for GDPR export/erase requests Privacy trunk normal normal Awaiting Review enhancement new has-patch 2018-05-08T00:15:10Z 2018-05-21T23:46:41Z "Currently, when a user has confirmed their GDPR export or erase request the site admin does not receive a notification or any visual indication that the request has been confirmed. Outside of visiting the Export/Erase pages they will have no way of knowing whether or not the request has been confirmed.
I'm suggesting a notification bubble (similar to when there are comments or plugin updates available) that will indicate the total number of export and erase requests that have been confirmed." scott.deluzio
43999 Add Telegram and Whatsapp support to Social Media Menu Themes trunk normal trivial Awaiting Review feature request new has-patch 2018-05-07T23:49:09Z 2018-05-07T23:49:09Z "I have at least two clients requesting links to Whatsapp and Telegram.
The icons I made are ""Ugly"", so it would be preferable to have a better SVG design for the icons.
thanks!" cpasqualini
1 43995 wp_dropdown_categories(array( 'pad_counts' => true ) ) doesn't correctly pad counts on post_types with custom stati Taxonomy trunk normal normal Awaiting Review defect (bug) new 2018-05-07T17:53:33Z 2018-05-08T21:51:44Z "Suppose I have the following situation:
* a custom post type (e.g., `member`)
* post type `member` has custom post stati (e.g., `subscribed` and `unsubscribed`)
* **ALL** posts of post type `member` have one of these custom stati (i.e., **NONE** have post_status `publish`).
* a hierarchical taxonomy (e.g., `membership-status`) is registered on post type `member`
* taxonomy `membership-status` looks like the following:
* Membership
* Current
* Expired
and that the term `Current` has been assigned to 10 posts, `Expired` has been assigned to 5 posts and that `Membership` has been assigned to **0** posts.
If I then call
{{{
#!php
$args = array(
'taxonomy' => 'membership-status',
'show_counts' => true,
'pad_counts' => true,
...
);
wp_dropdown_categories( $args );
}}}
I expect to get a dropdown that looks like:
* Membership (15)
* Current (10)
* Expired (5)
Instead, I get the following:
* Membership (0)
* Current (10)
* Expired (5)
which is, obviously, not correctly padding the count for `Membership`.
Related: #11847, #13176" pbiron
1 43993 GDPR - Provide indication to admin when user downloads export General trunk normal normal Awaiting Review enhancement new 2018-05-07T16:17:24Z 2018-05-07T16:18:04Z "Hello,
This was discussed on Slack here;
https://wordpress.slack.com/archives/C02RQBWTW/p1525518891000051
Basically along with the tickets which handled updating status to completed it would be nice to indicate when a user actually downloaded the export package. This would allow the admin to assess if they should resend the email.
" garrett-eclipse
3 43990 Use wp_delete_file instead of unlink Filesystem API low normal Future Release enhancement assigned has-patch 2018-05-07T14:35:43Z 2018-05-14T19:44:35Z Use `wp_delete` instead of `unlink` as much as possible throughout the codebase. macbookandrew
43988 Consolidate privacy options in dashboard menus Privacy 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-07T14:16:17Z 2018-05-17T21:08:28Z "We have export personal data under Tools, and the privacy notice under Settings.
Is there a case to be made for moving the privacy notice under a new menu subsection, Tools > Privacy, with that page containing a summary of each tool and a link to them?" idea15
2 43978 Avoid flickering on the Tools / Export page Export normal normal Awaiting Review defect (bug) new has-patch 2018-05-05T20:15:13Z 2018-05-10T17:03:11Z "The export filters are hidden by default on the Tools / Export page.
But it's only hidden with Javascript in {{{wp-admin/export.php}}}:
{{{
jQuery(document).ready(function($){
var form = $('#export-filters'),
filters = form.find('.export-filters');
filters.hide();
}}}
The filters can therefore be visible for a short time, before they are hidden.
Here the {{{filters.hide()}}} will add a {{{display:none;}}} inline styling to the corresponding filters.
We can avoid this flickering with CSS, something like:
{{{
#export-filters .export-filters {
display: none;
}
}}}
" birgire
1 43974 Both request processes should follow the same convention - GDPR Privacy 4.9.6 normal normal Awaiting Review defect (bug) new 2018-05-04T23:04:10Z 2018-05-17T21:08:28Z "Hello,
I noticed with the GDPR requests process that the export requests workflow only affects the Next Steps buttons, while the removal request instead injects an alert. Can the two processes be consistent?
Button Flow for Sending Email;
https://gyazo.com/241ea304afd342419b585697aa4ac9a3
Button Flow for Removing Data;
https://gyazo.com/3b72b3622b3e38b1c9868f8971eb6ee7
Was thinking the button should go away with 'Data Removed' or something.
But that being said I do like the alert as it does give more info if data was already removed but maybe not in the table and instead in the standard wp alert location. And maybe have an alert for the email send.
Thanks
" garrett-eclipse
43963 Add admin body class for multisite blog ID and network admin context Administration normal minor Awaiting Review enhancement new 2018-05-04T16:58:17Z 2018-05-04T16:58:17Z "In multisite, it'd be great to have an admin body class to safely scope CSS to specific blogs (i.e. `blog-2` or `network-admin`) available by default. I often filter `admin_body_class` to add these.
One situation where I often use this is conditional override of the text Site Title in the Admin Bar with a logo -- but only if the logo exists. PHP can certainly be used to check context before printing conditional CSS, but the body class adds a safe, client-side scope and clear approach for avoiding in-admin style collisions.
Example:
{{{
if ( ! empty( $logo ) ) {
?>
body.blog- li#wp-admin-bar-site-name > a.ab-item:first-of-type,
body.blog- #wpadminbar .ab-top-menu > li#wp-admin-bar-site-name.menupop:hover > .ab-item:first-of-type,
body.blog- #wpadminbar .ab-top-menu > li#wp-admin-bar-site-name.menupop.hover > .ab-item:first-of-type {
font-size: 0; // safely hide default text
background-image: url("""");
background-size: ;
background-position: center;
background-repeat: no-repeat;
min-width: 120px;
}
to post this here.
As per:
https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers
We would like to apply to be considered from oEmbed whitelisting on Wikipedia.
As per the different criteria you list there:
- be well-established, popular, and mainstream services
We have been around since 2012 and won a variety of awards for being the best API for video recording and playback.
- properly and fully implement the oEmbed specification,
We do and are being recognized as oEmbed provider by Tumblr, Embedly, Facebook, LinkedIn and Twitter.
- Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”
We have participated as sponsors in all major hackathons (including TC Disrupt) and have established our own yearly hackathon videohackday.com for the past four years now; we are the go to place for engineers and companies alike for all video recording and playback needs.
- Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?
We have around 4.5k followers on Twitter, much more than most other SaaS companies. The account is not verified because Twitter vertification has been stopped.
- Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)
Yes. See https://ziggeo.com/docs
- Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?
It should work with auto-discovery.
- Does the service make an effort to build relationships with developers, such as through robust APIs?
Our main business is an API.
- How old is the service?
6 years
- Does it have a well-established Wikipedia article? (Seriously.)
Yes.
- Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?
Yes. Ziggeo has an official plugin on WP.
Thank you for your consideration." oliverfriedmann
1 43959 Twenty Seventeen responsive width bug Bundled Theme normal normal Awaiting Review defect (bug) new 2018-05-04T12:36:33Z 2018-05-05T09:21:17Z "Hi,
Hope this is the right area to report. I recently installed WP on site FreeWoodworkingPlan.com We like the Twenty Seventeen theme as a layout. The width responsive ness is fine in desktop. But it is not on mobile device. In particular, the header title. I shouldn't have to abbreviate my title, I figured the code would adjust the text to fit the screen. Can you offer any assistance? Thanks.
Jim Barry" woodchuckcanuck
43958 Pingbacks Trackbacks and Data Export/Deletion/GDPR Privacy normal normal Awaiting Review enhancement new close 2018-05-04T12:04:19Z 2018-05-22T11:23:04Z "Being as there is all this talk about the ability to export or request deletion of data, we aren't factoring in the fact that these comments have no email address, only a URL.
In the successor to Pingbacks and Trackbacks, Webmention, the specification supports updating/deleting a webmention by sending a new one. https://www.w3.org/TR/webmention/#updating-existing-webmentions
Pingbacks and trackbacks have no such facility. While sending a ping is a clear indication of permission for a site to link to you(Otherwise why do it), there should be a way to hook into the new systems that supports this rather than building a separate one.
Looking for ideas on this one.
" dshanske
1 43957 check_password_reset_key could use get_user_by instead of direct query Login and Registration 4.9.5 normal normal Awaiting Review enhancement new 2018-05-04T09:58:07Z 2018-05-04T12:14:13Z "Hi
Just noticed, that {{{check_password_reset_key}}} is one of only a few functions making a direct query to the users table. Wouldn't it be more consistent to use the {{{get_user_by}}} function here. I came across this because I am replacing the
{{{get_user_by}}} function with my own. Not being able to hook into the user retrieval in {{{check_password_reset_key}}} forces me to take a rather hackish approach by using the 'query' filter.
I cannot see any advantages of making a direct query aside from bypassing the object cache. Maybe there is a security concern that I am not aware of?
" thomaslhotta
43950 JSDoc: wp-admin/js/language-chooser.js General normal normal Awaiting Review defect (bug) new has-patch 2018-05-03T14:06:02Z 2018-05-03T14:06:02Z "In our ongoing effort to improve JavaScript documentation, this patch adds descriptions and JSDoc formatting to the following file:
language-chooser.js
Please give props to:
- [https://profiles.wordpress.org/ireneyoast ireneyoast]
- [https://profiles.wordpress.org/manuelaugustin manuelaugustin]" manuelaugustin
1 43949 Need filter in get_metadata Plugins normal normal Awaiting Review enhancement new reporter-feedback 2018-05-03T13:19:13Z 2018-05-23T13:55:22Z "When accessing get_post_meta('ID_HERE')
Need to filter the output array.
Existing get_{$meta_type}_metadata filter works before fetching data.
The filter required before returning or Processing value of $meta_cache" fitehal
43948 JSDoc: wp-includes/js/zxcvbn-async.js General normal normal Awaiting Review defect (bug) new has-patch 2018-05-03T12:53:25Z 2018-05-03T12:53:25Z "In our ongoing effort to improve JavaScript documentation, this patch adds descriptions and JSDoc formatting to the following file:
zxcvbn-async.js
Please give props to:
- [https://profiles.wordpress.org/igorsch igorsch]
- [https://profiles.wordpress.org/LisanneKluitmans LisanneKluitmans]
" manuelaugustin
43946 Inconsistent encoding of comment_content Comments 4.9.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2018-05-03T10:50:13Z 2018-05-04T12:39:24Z "The contents of the comments.comment_content field in the WordPress database are stored inconsistently depending on whether the user creating the comment was logged in or not.
{{{
> select comment_ID, comment_content, comment_type from wp_comments where comment_ID > 7;
+------------+-----------------------------------------------------+--------------+
| comment_ID | comment_content | comment_type |
+------------+-----------------------------------------------------+--------------+
| 8 | This is a good & strong comment (comment, anon) | |
| 9 | This is a good & strong comment (comment, auth) | |
+------------+-----------------------------------------------------+--------------+
}}}
In the example above, comment 8 was left by an anonymous user, and comment 9 was left by an authenticated user. Notice how the comment_content field has been HTML-escaped for ID 8, but not for ID 9.
=== Steps to reproduce:
* Install a fresh copy of WordPress
* As the site administrator, navigate to the default ""hello-world"" post
* Leave a comment including characters that should be escaped when output to HTML, e.g. &
* Log out
* Navigate to the default ""hello-world"" post
* Leave a comment including characters that should be escaped when output to HTML, e.g. &
Compare the contents of the two comments in the wp_comments table.
" leewillis77
43938 Make it clear to administrators that not all plugins support privacy policy content, personal data export and erasure Privacy trunk normal normal Awaiting Review enhancement new 2018-05-02T19:16:18Z 2018-05-22T18:41:13Z "It is likely that there will be many plugins that will not implement the new privacy policy content hooks nor the personal data export and erasure hooks for some time (if ever).
It would be unfortunate for administrators to overlook privacy policy impacts from such plugins, or to assume that personal data export and erasure included personal data collected by such plugins.
As part of privacy policy content UX, as well as export and erasure UX, we should come up with a way to prompt administrators to take this into consideration." allendav
3 43936 Settings: Warn when open registration and new user default is privileged Users normal normal Awaiting Review defect (bug) new has-patch 2018-05-02T18:21:52Z 2018-05-07T09:46:13Z "Much like our Strong Passwords work, we can help inform site administrators when their actions may be sub-optimal.
WordPress allows a site owner to open registration AND set the default new user level to ""Administrator"". While this combination may make sense for some sites (on an intranet?), this is typically a really really bad idea.
We should provide some type of confirmation to ensure site administrators are intending to open their site up.
If registration is open and default level is Subscriber (`read` cap only), the current behavior is fine. If registration is open and other capabilities are included in the default role, we should have some type of checkbox or ""are you sure"" notice. ""By allowing open registration and a default role of {role}, anyone who can visit the site would have the ability to {have full control of your site|publish content|etc}.""
We saw this in the wild on a site in support today :)." kraftbj
5 43933 Make the Privacy Policy page intro text shorter and more friendly Privacy normal normal Future Release enhancement new has-patch 2018-05-02T17:47:48Z 2018-05-16T21:32:44Z "#43435 introduced the `Privacy Policy page` screen, which includes some intro text, intended to educate the user about their potential legal obligations, and some best practices for implementing and maintaining a privacy policy.
In the rush for the 4.9.6 string freeze, there wasn't enough time to fully discuss and iterate on the text, so I think it may be beneficial to continue the conversation.
Most recent discussion:
https://wordpress.slack.com/archives/C9695RJBW/p1525273783000517
https://wordpress.slack.com/archives/C9695RJBW/p1525274779000367
" iandunn
1 43930 Inaccurate width and height returned when using wp_get_attachment_image_src on the backend. Media 4.9.5 normal normal Awaiting Review defect (bug) new 2018-05-02T14:56:44Z 2018-05-08T18:30:23Z "I'm using wp_get_attachment_image_src on the backend to do image validation for a custom image selector meta box. When the image is large enough for the requested image size the source of the original image is returned but the dimensions are smaller.
This is my call:
{{{#!php
string(70) ""http://localhost:8888/wp-content/uploads/2018/05/image.jpg""
[1]=>
int(400)
[2]=>
int(400)
[3]=>
bool(false)
}
}}}
The actual image dimensions are 1200x1200.
The image_constrain_size_for_editor call in the image_downsize function seems to be where the problem lies. I can comment out that line and it works as expected." jwoolsch
2 43924 "Add ability to add page for ""Logged In User""" Posts, Post Types 4.9.5 normal normal Awaiting Review feature request new 2018-05-02T02:20:03Z 2018-05-02T02:21:15Z "Refer: https://codex.wordpress.org/Content_Visibility
It's too hard to keep exclude logged in pages from a main query like Search. All we can do is hard code a page name, and if we have many pages which required logged in to see, to keep them hidden from search results it must do it manually.
My suggestion:
1. Add a visibility status for ""Logged-in User"".
2. Keep to exclude their pages from default public search, and visible them only for logged users.
Another topic about this issue:
https://wordpress.stackexchange.com/questions/142811/exclude-pages-from-wordpress-search-result-page
https://wordpress.stackexchange.com/questions/34439/exclude-post-from-home-page-and-archives-but-still-public
https://www.johnparris.com/exclude-certain-pages-from-wordpress-search-results/
http://www.beginwp.com/exclude-certain-post-pages-from-wordpress-search-result/
" khoipro
4 43923 Add a step to the Data Removal/Erasure UX for deleting a user account Privacy normal normal Future Release enhancement new has-patch 2018-05-01T23:19:09Z 2018-05-21T20:29:26Z "In the ERASURE.md file over on #43602, it is mentioned that processing an erasure request does not actually remove the user's account, as that should be a separate step. However, this isn't mentioned anywhere in the UX, and may not match the expectations of some admins who are trying to fulfill a request to completely remove a user.
Perhaps the request could include a row action that initiates the process of deleting a user account? Or at least a blurb at the top explaining that account deletion is a separate step over on the Users table." coreymckrill
1 43921 Include community-events-location user meta value in Personal Data Export Privacy trunk normal normal Future Release enhancement assigned dev-feedback 2018-05-01T22:44:58Z 2018-05-16T21:32:44Z Any user who visits the Dashboard screen will have a row in the `usermeta` table with location information, which is used by the WordPress Events and News widget to show relevant WP community events. The location information may include an IP address, location description, and/or lat/lon coordinates. This seems like personally identifiable information that should be included in a Personal Data Export. coreymckrill
2 43916 Auto update translations when the respective plugin/theme is updated Upgrade/Install normal normal Awaiting Review feature request new dev-feedback 2018-05-01T13:41:41Z 2018-05-01T13:41:41Z "I find updating translations a bit of a pain because they only seem to appear (rightly so though) once you've updated a plugin or a theme. It'd be great if translations could be automatically updated after the respective plugin or theme has been updated removing the need to check if there are any translations waiting.
Most often I find myself updating a plugin and then committing the update into version control and it's not until the commit has gone through that I reload the page to see that I now have new translation strings waiting. They really should be bundled with the main update of the plugin/theme." danieltj
43912 Requests (new, pending, completed) should not be deletable. Privacy normal normal Awaiting Review enhancement new 2018-04-30T22:42:21Z 2018-05-16T21:32:44Z "After todays bug scrub - splitting this from #43481.
azaozz wrote ( https://core.trac.wordpress.org/ticket/43481#comment:46 ):
> Requests (new, pending, completed) should not be deletable. This is important for keeping audit log. The only exception may be be requests that haven't been confirmed by email, but then we can auto-delete them when the link in the email expires (and they become unusable).
There is a discussion following that comment on logging ( also there's a somewhat related ticket please see #43797 )" xkon
43907 JS WordPress Coding Standards — Add Space In The Method Call Comments trunk normal normal Awaiting Review enhancement new has-patch 2018-04-30T15:00:42Z 2018-04-30T15:00:42Z "According to JS WordPress standards, there should be a space right after the opening bracket and closing bracket of the function call. However, in the
{{{
wp-includes/js/comment-reply.js
}}}
there's no space at function call on line 161.
I am not sure if there's any other reason for being so. But all other function calls seem to follow that standard. Don't know if I am missing something? Would love to know thoughts on it.
Also, I have added the patch.
" saqibameen
3 43904 Media toolbar spacing inconsistent across views Media normal normal Awaiting Review defect (bug) new has-patch 2018-04-30T01:21:58Z 2018-05-23T19:46:19Z The media toolbar is present on both list and grid views. The padding on the dropdowns and buttons, though, is inconsistent. desrosj
43902 Small refactoring to prevent multiple chr() calls in MO class I18N trunk normal normal Awaiting Review enhancement new 2018-04-29T22:27:54Z 2018-05-05T22:01:52Z likemusic
1 43900 Add hint about blocked Javascript as possible error reason in script-loader.php Script Loader normal normal Awaiting Review defect (bug) new 2018-04-29T18:52:58Z 2018-05-02T09:41:14Z "When trying to do various things with a new site, I got the same error message over and over:
{{{Connection lost or the server is busy. Please try again later.}}}
I even reinstalled, but the error didn't go away. When I revisited the issue next day, finally realized what silly mistake i had made.
In order to help other people with same issue, we only need to change the string above in /wp-includes/script-loader.php (around row 840) into:
{{{Connection lost, the server is busy, or you may have blocked JavaScript. Please try again later.}}}
" tobifjellner
43899 Move the view mode switcher into screen options for multisite users and sites Networks and Sites 4.4 normal normal Awaiting Review defect (bug) new 2018-04-29T15:37:00Z 2018-04-29T22:05:59Z "In the Posts screen, WordPress used to have two links to ""switch mode"" from the normal list view to the ""excerpt"" view. In WordPress 4.4 these links were moved to the Screen Options panel, see [35357].
However, on multisite the ""Sites"" and ""Users"" screens still show the switch mode links at the top right of the main table. For consistency, and for the design / UI reasons explained in #22222, they should be moved to the Screen Options as well.
" afercia
1 43896 Several flex and grid CSS properties listed as Unknown property in Customizer Customize trunk normal normal Awaiting Review defect (bug) new has-patch 2018-04-29T01:11:57Z 2018-05-02T06:47:57Z "When I use the CSS editor in the Customizer it suggests element properties as I start typing them. One of the properties that it suggests is the justify-items property. When I save the settings in the Customizer I get a notice of ""Unknown property 'justify-items'.""
I've checked some of the other flexbox and grid properties, and there are several others that this is the case for, namely:
- justify-items
- grid-gap
- grid-column-gap
- grid-row-gap
- place-self
The properties still work in supported browsers, they just display an error in the Customizer. Some valid values for properties that are recognized also give errors, such as the values of start and end for several grid properties." davidjlaietta
43895 Organize privacy functions into logical files and classes Privacy normal normal Awaiting Review enhancement new 2018-04-28T20:15:02Z 2018-05-16T21:32:44Z "Many new functions and classes are being created in 4.9.6 for the privacy features, but they can only be added in existing files, because it's a point release (and they have to be in the next point release, because GDPR).
That results in a bit of a mess, since functions are tacked on to unrelated files, or files that already have thousands of lines of code. The codebase would be much more maintainable if we can migrate logical groups of functions to their own file, and move classes to their own files.
We may need to consider back-compat issues, like plugins including `wp-admin/includes/file.php` in order to call a function that resides there in `4.9.6`. Ideally this should be done in 5.0, to minimize the time where plugins will start to rely on functions being available in certain files." iandunn
1 43893 The maybe_create_table() function has two definitions Database low normal Awaiting Review defect (bug) new 2018-04-28T14:22:56Z 2018-05-02T12:12:28Z "The `maybe_create_table()` function has two definitions:
1. https://github.com/WordPress/wordpress-develop/blob/c71a898f784d8435c07bcf9ec9e30560dd3abe19/src/wp-admin/includes/upgrade.php#L2187-L2219
2. https://github.com/WordPress/wordpress-develop/blob/c71a898f784d8435c07bcf9ec9e30560dd3abe19/src/wp-admin/install-helper.php#L40-L70
The latter is contained within a `function_exists()` check, but this still means the function's behaviour can differ depending on which definition happens to load.
The function is not used at all in WordPress core. It (they?) should probably be deprecated." johnbillion
43890 Allow Admin to Skip e-mail confirmation for Export/Anonymization Privacy normal normal Awaiting Review enhancement new has-patch 2018-04-28T12:14:15Z 2018-05-16T21:32:44Z "We thought that it might be good to allow admins the option to avoid a user's e-mail confirmation.
We've talked a bit about it with @allendav and @mikejolley and 1 way was adding a drop down menu for the Admin to select if they want to skip it or not.
" xkon
43886 "Chrome autofills password over ""new password"" field when updating user." Users trunk normal normal Awaiting Review feature request new dev-feedback 2018-04-27T21:25:28Z 2018-04-27T21:26:05Z "Chrome, the wonderful browser that it is, is super helpful.
When editing a user (even your own), and attempting to update the password with a nice strong one, Chrome will (helpfully) insert *your* old password into the new password field, right when you click update. (You can tell, because the length of the password will change to your passwords length).
Incognito Mode fixes it, apparently, and uninstalling Chrome in favor of Firefox seems to work too.
From what I've been able to guess, it's because of Chrome's unique implementation of completely ignoring `autocomplete=""off""` https://bugs.chromium.org/p/chromium/issues/detail?id=370363#c7 and suggests `autocomplete=""new-password""` instead.
Alternatively, `` could possibly work. https://stackoverflow.com/questions/15738259/disabling-chrome-autofill
It does seem to make sense to disable autocomplete completely on the edit-user form, since it's not actually useful to fill in some random user's info with info from your browser...especially passwords...despite what Chrome seems to believe." WraithKenny
2 43885 WP_Role and WP_Roles::get_role() missing Display Name Role/Capability normal normal Awaiting Review enhancement new 2018-04-27T21:19:41Z 2018-04-27T21:19:41Z "Hello,
While working with roles I found it odd that you can add a Display Name for a role but the WP_Role class and the WP_Roles function get_role don't provide this information.
Please add $display_name as a public attribute of WP_Role so it's available on that object and would be returned in the get_role function.
Thank you
P.S. Currently to access this information you have to use the WP_Roles as follows;
{{{#!php
roles[$role]['name'];
}}}
" garrett-eclipse
43884 new is_front() function General normal normal Awaiting Review enhancement new 2018-04-27T20:24:39Z 2018-04-29T22:15:31Z "When we need to check if we doing something in front-end, we do it like this:
{{{
if( ! is_admin() ){}
}}}
But this not convenient and not so clear because of `!`. And maybe not full, because we don't check other admin functions like: is_blog_admin(), is_network_admin(), is_user_admin().
We have so many functions in WordPress, but haven't this simple but useful function, why?
Maybe its a good idea to add **is_front()** function in **/wp-includes/load.php** file?
{{{
function is_front(){
return ! is_admin();
}
}}}
" Tkama
3 43882 Introduce slug-specific hooks to manage plugin loading order Plugins normal normal Awaiting Review enhancement new 2018-04-27T16:48:35Z 2018-04-27T16:48:35Z "As already discussed in #41346, I'd like to propose a simple mechanism that can solve the loading order problems that inter-dependent plugins can have.
The main mechanism just adds an action that is named after the plugin that was just loaded. In this way, other plugins are able to initiate actions based on when another plugin was loaded.
A similar mechanism has been used in WP-CLI to solve the problems in the loading order of commands that rely on each other. You can read more about how commands can control their loading order here: https://make.wordpress.org/cli/2017/05/03/managing-command-dependencies/
Furthermore, this also allows for a small extension that can automatically resolve loading order, provided it knows about the dependency to look for. This is used in WP-CLI as well, where it is easy to deduce the parent command to look for, as described here: https://make.wordpress.org/cli/2017/05/31/command-dependencies-revisited/. For plugins, this could be solved by adding a simple plugin slug to the plugin header. I'll introduce a separate ticket to that regard.
I will upload a patch that adds the above-mentioned action, together with `pre_plugin_loaded` and `post_plugin_loaded` actions that give further control to plugins.
In case anyone wonders whether that might open the door to abuse and have plugins block loading of other plugins: that is already easily possible right now. A plugin can just remove whatever plugins it dislikes from the list of active plugins on activation hook." schlessera
1 43881 url_to_postid doesn't works with custom post type in PhpUnit Test General normal blocker Awaiting Review defect (bug) new 2018-04-27T14:10:38Z 2018-04-27T14:10:38Z "In the {{{functions.php}}} I have the following code:
{{{#!php
[
'name' => 'products',
'singular_name' => 'products',
'add_new' => 'Add New',
'add_new_item' => 'Add New Product',
'edit_item' => 'Edit Product',
'new_item' => 'New Product',
'all_items' => 'All Product',
'view_item' => 'View Product',
'search_items' => 'Search for Product',
'not_found' => 'No product found',
'not_found_in_trash' => 'No product found in the Trash',
'menu_name' => 'products',
'parent_item_colon' => '',
],
'description' => 'Product description',
'public' => true,
'rewrite' => ['slug' => 'products'],
'menu_position' => 5,
'supports' => ['title', 'editor', 'excerpt'],
'has_archive' => true,
'menu_icon' => 'dashicons-id-alt',
]
);
}
add_action('init', 'post_type_products');
}}}
Then I need to test it. And for this test I create the test record via factory class:
{{{#!php
'Test Post',
'post_content' => 'Test Post Content',
'post_excerpt' => 'Test Post excerpt',
'post_type' => 'products'
];
$this->factory->post->create($post_data);
}}}
The problem is when I got URL from following code:
{{{$url = get_permalink($this->factory->post->create($post_data));}}}
The function {{{url_to_postid}}} return {{{0}}}
{{{#!php
section of a HTML element toggles visibility of the details. Consequently, the element can only be trivialy edited in the visual editor. steve.clason
1 43851 Network admin allows updating one site to have the same domain and path as another site. Networks and Sites 4.9.5 normal normal Awaiting Review defect (bug) new 2018-04-24T20:15:47Z 2018-04-24T20:15:47Z "The network admin page for updating sites in multisite (site-info.php) allows setting the domain and path on one site to match the domain and path on another site. This creates a conflict: if multiple sites have the same domain or path (depending on subdomain install vs. subdirectory install), only one of them can actually be accessed.
I would propose the following addition on line 82 of site-info.php:
{{{#!php
domain || $blog_data['path'] !== $existing_details->path ) {
// A change to the domain or path was requested.
if ( get_sites( [
'domain' => $blog_data['domain'],
'path' => $blog_data['path'],
'site__not_in' => [ $id ], // Don't include the site we are changing.
'number' => 1, // It's enough to know if one or more exist.
] ) ) {
wp_die( __( 'Another site with that domain and path already exists.' ) );
}
}
}}}
I don't think this is the case, but if it only needs to be unique by network, this can be added to the query:
{{{
'network_id' => $existing_details->site_id,
}}}
If there is some reason to not make this change, then I would appreciate the addition of a filter either on line 82 of site-info.php or in the update_blog_details() function that would allow the above check to be added by me or other developers. In fact, would be useful in either case!
Thank you!
" giacocorsiglia
43848 "Function ""user_can_access_admin_page"" refactor." Administration trunk normal normal Awaiting Review enhancement new has-patch 2018-04-24T18:20:44Z 2018-04-24T18:20:44Z I think this `user_can_access_admin_page` function should looks more clean and better this way. Also added a description of the function. rnaby
43847 "Cleaned ""handle_featured_media"" method of ""WP_REST_Posts_Controller"" class." REST API trunk normal normal Awaiting Review enhancement new has-patch 2018-04-24T18:01:58Z 2018-04-24T18:01:58Z Cleaned `handle_featured_media` method of `WP_REST_Posts_Controller` class. I think this is more cleaner approach. rnaby
43842 get_children() function enhancement. Query trunk normal normal Awaiting Review enhancement new has-patch 2018-04-24T12:06:31Z 2018-04-24T12:06:31Z This `get_children` function can be rewritten this way. And I think this is cleaner and better. rnaby
2 43841 Add request confirmation and security logging for major user actions Administration normal normal Future Release enhancement new 2018-04-24T10:10:51Z 2018-04-24T11:15:16Z "This is a follow-up from #43443.
We can extend the methods and functionality added for privacy request to other ""major"" user actions:
- Lost password notifications.
- Changing email addresses.
- Deleting accounts.
This will form the base for a user security log screen where admins will be able to see notifications, verify requests, and keep track of other user activities." azaozz
1 43840 Allow configuration variables as :root properties Themes 4.9.5 normal major Awaiting Review defect (bug) new 2018-04-24T02:42:37Z 2018-04-24T02:42:37Z "When using theme-editor.php to edit CSS, Our code shows ""There is x error which must be fixed before you can update this file."" when using variables in :root
eg, the following code has an error with 'Expected RBRACE...'
:root {
--redpink: #f05562;
}
" kandb
43839 Video Player Mobile Media normal normal Awaiting Review defect (bug) new 2018-04-23T23:51:04Z 2018-04-24T01:23:28Z "I usually use the video player with autoplay on.
\\
But I noticed that on the mobile (I know the autoplay does not work on the mobile), the video player does not display the big play button in the middle of the player.
\\
And the only way to run a video is to press the play button from the control bar at the bottom of the player.
\\
Print screen:
\\
That's how it should look (So it was up to wp 4.8.3)[https://i.imgur.com/PkHjszD.jpg]
\\
That's what it looks like now [https://i.imgur.com/l8Zp94G.jpg]
\\
Does anyone know how to solve this issue?
Thank you!" studiosx
1 43836 Update or patch getID3 library Media trunk normal normal Awaiting Review defect (bug) new has-patch 2018-04-23T14:04:21Z 2018-04-23T15:11:33Z "The getID3 library is a little out of date now and currently has the following defect.
File names are sanitised in such a way that a double slash (or directory separator) eg. `//` is replaced by a single instance of that character.
For file stream wrappers this is broken because a path like `s3://example` is changed to `s3:/example`.
The latest version of the library doesn't have this issue (the offending line is commented out) but requires PHP 5.3.
We should patch the offending line or update the entire library." sanchothefat
2 43835 Add thumbnail to category (like to posts) Taxonomy normal normal Awaiting Review feature request new dev-feedback 2018-04-23T07:23:28Z 2018-04-24T07:06:33Z "Was it discusses ever, to integrate thumbnail support for categories too?
[https://wordpress.org/plugins/category-thumbnails/ This plugin] adds the feature to WP to add thumbnails (feature images) to categories and use functions:
{{{
has_category_thumbnail();
get_the_category_thumbnail();
....
}}}
However, it may be nice to have these features built-in." tazotodua
43833 Problem to customize anz theme in fresh installed wordpress Editor normal normal Awaiting Review defect (bug) assigned 2018-04-22T16:15:20Z 2018-04-22T16:15:20Z "Hello,
https://fancywatches.pl/wp-content/uploads/2018/04/wp-error.png
as you can see on photo, I am not able to customize any wordpress theme. I've tried to install wordpress few times with no luck. On the same server but in other directory I have my first wordpress site that works normally. I've found this code snippet on the internet:
define('CONCATENATE_SCRIPTS', false);
Thanks to that I am able to modify theme but when I""ve downloaded woocommerce I am not able to add description to product. Something doesnt work and I dont know where and how to find this bug.
Thank you in advance for ANY help
Peter from Poland
" piotrek1992
1 43831 parse_order method of WP_Query class. Query trunk normal normal Awaiting Review enhancement new has-patch 2018-04-22T16:00:40Z 2018-04-22T16:00:40Z the `parse_order` method of `WP_Query` class can be rewritten like this patch. rnaby
43830 "Being able to set a page as a homepage under the ""Page Attribute"" meta box" General trunk normal normal Awaiting Review enhancement new 2018-04-22T12:00:58Z 2018-04-23T11:34:06Z "Hi everyone,
As the file attached shows, the idea is to allow the user to set the page as a homepage from the admin panel of the page without going to the ""settings"" -> ""reading"" section.
Tank you.
Team from contributor day in Madrid" dssaez
1 43825 Style/script loading infrastructure: Etag header as a hash of script/style handles and their corresponding versions Script Loader trunk normal normal Awaiting Review enhancement new 2018-04-21T08:27:55Z 2018-04-21T08:27:55Z "We've been exploring on how to bundle styles and scripts together for different block types in Gutenberg (https://github.com/WordPress/gutenberg/pull/6087#issuecomment-382888928)
It looks like the inbuilt infrastructure for concatenating and bundling assets (load-styles.php and load-scripts.php) might be a good fit for bundling assets in Gutenberg.
However, it looks like we will run into an issue with this approach. load-styles.php and load-scripts.php use the current WordPress version as the value of the Etag header. So if a plugin/theme developer modifies some CSS / JS for their block type, the browser will not attempt to fetch the latest content since the value of the Etag header will remain the same (since the WordPress version will remain the same).
We can add some functionality in load-styles.php and load-scripts.php to support this:
**Specify the value of the Etag header as a hash of the script/style handles and their corresponding versions.**
So, if we get a request to load styles for paragraph and image block like this:
> /load-styles.php?load=core-paragraph-block,core-image-block
We can generate the Etag like this:
> etag = hash_function( 'core-paragraph-block-v1.1-core-image-block-v8.3')
and supply this value in the Etag header in the response to the browser.
This will make sure that the next time the plugin/theme developer changes the CSS / JS for a block type (meaning changes the version of the script/style handle), the hash function will automatically generate a new value for the Etag header and the browser will therefore fetch the latest style / script bundle.
**We can add this functionality in load-styles.php and load-scripts.php as an add-on to the current functionality (to preserve backward compatibility).**
Maybe, this new functionality can be triggered if a specific URL parameter is included in the request to load-styles.php / load-scripts.php. Maybe, something like: /load-styles.php?etag=content_hash.
Do you think we can go ahead with this approach? If yes, I can propose a patch for adding this functionality." kanishk.dudeja
1 43823 Posts can not be saved with /etc/ as part of the content Editor 4.9.5 normal normal Awaiting Review defect (bug) new close 2018-04-20T20:58:40Z 2018-04-20T21:56:17Z "I created a post using the latest version of WordPress with one line and the only content of the post.
The line is:
/etc/
I can not save this post as a draft. When saving, I get a blank white screen.
This was tested using Theme TwentyFifteen updated to the latest version.
I can save the post if there is a space between /etc and the last slash.
This has been tested with all plugins disabled with the same results.
" fgluck
1 43822 Add UX in the Network Admin for exporting/anonymizing/deleting personal data across the entire network Privacy normal normal Awaiting Review enhancement new 2018-04-20T20:12:18Z 2018-05-16T21:32:44Z "It's not practical for a super admin to hunt down personal data by going to the Dashboard of each site in the network. There should be one centralized place in the Network Admin to receive and process SARs.
This should look similar to the UX in #43546 and #43602, but the underlying functionality for managing the data across the entire network is being discussed in #43738." coreymckrill
1 43821 Add UX in the Network Admin for setting a network-wide privacy policy Privacy normal normal Awaiting Review enhancement new 2018-04-20T20:05:00Z 2018-05-16T21:32:44Z "Some multisite instances will need to set one privacy policy for the entire network, with controls on whether or not individual sites can modify/replace it. Other multisite instances may choose to leave the privacy policy entirely to individual sites.
The UI for setting a network-wide policy should probably be similar to #43435, so snippets from plugins can be included." coreymckrill
43818 Invalidate query caches less aggressively by using a `last_changed` key specific to metadata Options, Meta APIs normal normal Awaiting Review enhancement new needs-unit-tests 2018-04-20T08:13:55Z 2018-04-20T08:13:55Z "Currently, the meta implementations for posts, terms, comments and sites (in multisite) invalidate all respective query caches when any value is changed (via setting the `last_changed` key). This is a really aggressive method of cache invalidation and causes in query caches being too frequently invalidated, resulting in lots of unnecessary cache misses.
Most queries (or at least many queries) do not make use of meta queries, and those should stay unaffected by when a meta value changes. Therefore I suggest introducing a specific `meta_last_changed` cache key, and have the meta functions set that one instead of the generic `last_changed`. In the query classes, we can then check if a meta query is present, and only then make use of the `meta_last_changed` key - otherwise we can ignore it and use the regular `last_changed` key.
Regarding the initial implementation, we should think about whether we would wanna roll this out to all the above object types immediately, or whether we should rather start with an object type less popular for metadata (i.e. ''not'' posts). Related to this is #43813." flixos90
43816 Editing Image Can Lead to Mixed Metadata Media 4.9.5 normal normal Awaiting Review defect (bug) new 2018-04-20T00:04:30Z 2018-04-20T00:33:57Z "== Summary
If an image is uploaded at a size allowing the creation of a defined image size (ie, ""large"", ""twentyseventeen-featured-image"", etc.) and the image is then edited to a size which doesn't allow that defined size to be created, the non-supported size can still be placed and will display the original image.
== Steps to Reproduce
1. Upload an image which is slightly larger than a defined image size in a particular theme (for example, if using the WordPress default definition for ""large"" images, 1,024 pixels, upload an image 1,100 pixels wide)
1. Edit the image, and scale or crop it to be 1,000 pixels wide
1. Save edit
1. Within the post editor, ""add media"", select the ""large"" image size, and place within body of post
=== Expected Behavior
* //Developer//: The ""large"" image should not be able to be selected within the ""Place Media"" dialog
* //Regular user//: The ""large"" image placed should reflect the image edit
=== Result
The ""large"" size is selectable and the **original** image is placed within the page.
=== Other Effects
In this particular example, if the Media Library is in ""grid"" view, and our edited image is selected, the dialog which opens will display the incorrect original image, as the dialog preferentially uses the ""large"" image size.
== Source of Behavior
I believe the problem stems from line 880 of https://core.trac.wordpress.org/browser/tags/4.9.5/src/wp-admin/includes/image-edit.php :
{{{
$meta['sizes'] = array_merge( $meta['sizes'], $img->multi_resize( $_sizes ) );
}}}
* `$meta['sizes']` contains all of the sizes which were able to be created when the image was uploaded
* The return from `$img->multi_resize()` only has keys set for those sizes that can be created from the edited image
* Using `array_merge` keeps the original values not returned by `$img->multi_resize()`, despite the fact they are no longer valid for this edit
== Fix
I believe the fix may be as simple as simply returning the result of `$img->multi_resize()` without merging it into the existing `$meta['sizes']`, which are mainly used in this context to create the `_wp_attachment_backup_sizes` array.
{{{
$meta['sizes'] = $img->multi_resize( $_sizes );
}}}" rogerlos
43814 Checkbox label has a period in Add New User page. Text Changes 4.9.5 normal minor Awaiting Review defect (bug) new has-patch 2018-04-19T20:29:21Z 2018-04-19T20:29:21Z "In a previous ticket (#33780) @SergeyBiryukov fixed some checkbox which has period reported by @juhise\\
I found a checkbox on **Add New** user page where Checkbox for **Send User Notification** has a period.\\
**It is only one checkbox in WordPress that containing period.**
\\
thank you" pratikthink
1 43813 Meta API should set `last_changed` cache key internally General normal normal Awaiting Review enhancement new 2018-04-19T19:06:49Z 2018-04-20T14:18:09Z "See #40669, r41848, r41849.
Sorry, but I completely missed this work being done for the 4.9 release cycle.
I think the individual post/comment/term/user checks should be moved directly into the appropriate meta API function calls.
I can imagine 2 ways of doing this:
----
Add a `$cache_key` parameter to the following functions:
* `add_metadata()`
* `update_metadata()`
* `delete_metadata()`
When `$cache_key` is not empty, it will internally call:
`wp_cache_set( 'last_changed', microtime(), $cache_key );`
----
Infer the cache-key using `$meta_type` in the following function:
* `update_meta_cache()`
Then call:
`wp_cache_set( 'last_changed', microtime(), $meta_type . 's' );`
(We already use `$meta_type` to infer things like primary keys, so it's not great, but not new.
If we went this route, I believe we'd probably want to do a better job of priming meta-data caches the same way we prime primary object caches (users and posts specifically prime themselves on update, etc...)
cc @boonebgorges @spacedmonkey for consult & discussion" johnjamesjacoby
2 43812 Retrieving Blog/site description in multisite Networks and Sites trunk normal normal Awaiting Review enhancement new dev-feedback 2018-04-19T16:38:51Z 2018-05-18T17:54:18Z "Hello,
In a project on a Multisite I need on site 1 (for example) to retrieve description on site 2.
With
{{{
get_blog_details()
}}}
I'm able to retrieve some info (name, url...) but not the description
" sebastien@…
43811 Licence & Policy notice during installation xkon Privacy normal normal Awaiting Review enhancement assigned 2018-04-19T13:56:37Z 2018-05-16T21:32:44Z "This was a thought mentioned in #43492 originally but it deserves it's own ticket at the moment.
We all know about the lovely 5 minute installation process that WordPress provides. I feel like we can create a small placeholder during the installation process ( probably on the first page even ) to notify the users about GPL license and a text on Policy. Yes the license is included in a .txt, but people are more used when installing things to see a license / policy during the installation and then continue to the actual install.
I'm not personally thinking about a full blown page with a wall of text but rather a discreet placeholder to hold just the right the information needed like an excerpt from the GPL and a link refering to the full text for the ease of use etc as well as the connection between WordPress and wp.org during updates and such as stated on other tickets so we can be even more clear and upfront to any given user.
@melchoyce do you think you could check this as well so we can provide a mockup/patch to see how it feels and then we can go forth adding the texts needed here as well just in case this could make it to the release also ?" xkon
43810 Aphostrophe issue Formatting 4.9.5 normal normal Awaiting Review defect (bug) new 2018-04-19T13:31:05Z 2018-04-19T13:32:02Z "Take a look. Instead of to have normal aphostrohpe, we have open and close if is between tags
[[Image(https://i.imgur.com/c6QDmR5.png)]]
[[Image(https://i.imgur.com/1F1zfWj.png)]]" colomet
4 43809 Add personal data from posts to personal data export tz-media Privacy normal normal Future Release enhancement assigned has-patch 2018-04-19T12:35:02Z 2018-05-16T21:32:44Z Add personal data from posts to the personal data export infrastructure built in #43438 and #43546. TZ Media
1 43808 Photos do not keep rotation when uploaded from iPad Media trunk normal normal Awaiting Review defect (bug) new 2018-04-19T08:36:40Z 2018-04-19T08:36:40Z When I take photos on my iPad and then upload them to a wordpress site using my iPad, they don’t keep the rotation settings for the image and I then have to manually rotate the images to the correct rotation. timlings
1 43805 "Add ""in reply to"" in comment moderation email notification" Comments normal normal Awaiting Review enhancement new has-patch 2018-04-19T03:18:25Z 2018-04-19T13:43:27Z "The comment moderation notification email provides quick ways to moderate comments, which can save time and hassle.
Sadly, the ""in reply to"" information, which is available on the moderation page, is missing from these emails, so moderators lack some of the context of the comment.
As you can imagine, the meaning of a comment is vastly different when it relates to the post, as opposed to some stupid comment that someone made, and may make a difference to the moderation outcome.
Therefore, at least when reply threading is enabled, moderation emails should include the ""in reply to"" comment link and author name.
While we're at it, both the moderation page and email would benefit from the actual replied-to comment to be shown, in order to avoid the hassle of another page load to enable proper moderation.
This can be done in combination with #33627, where every change done on the moderation page is also reflected in the emails." galbaras
43804 Undefined offset: 0 in ../wp-includes/taxonomy.php on line 1903 Taxonomy trunk normal normal Awaiting Review defect (bug) new reporter-feedback 2018-04-19T00:39:50Z 2018-04-19T09:21:01Z "The issue is pretty trivial. When there are no terms assigned to a post, the condition on 1894 will return false and this immediately will cause PHP error because $taxonomies array does not have any records inside.
To reproduce the issue, simply call wp_get_object_terms function with post, page or custom post type that does not have a single hierarchical term assigned to." vasyltech
43802 Default timezone for new sites in WP multisite I18N 4.9.5 normal normal Awaiting Review feature request new 2018-04-18T19:38:19Z 2018-04-18T19:38:19Z "In WordPress Multisite, the super admin may set a default language for all newly created sites but not a default timezone. As a matter of fact, the timezone for new sites is taken from translation string ""0"" (context string ""default GMT offset or timezone string""). [https://github.com/WordPress/WordPress/blob/176a28905041fd79c439946a4ba290a87db5991f/wp-admin/includes/schema.php#L402 Relevant code]
Unfortunately, language is not location. It's entirely possible for a community using WordPress multisite to use a language while not being physically based in the usual timezone for said language. Furthermore, many language are spread all over the world.
For that reason I think it would be more correct to decouple default timezone from translation files and add a ""default timezone for new sites"" setting for multisite installations." moreauf
1 43801 Need better documentation to show importance of checking for args while using wp_schedule_event and wp_next_scheduled General normal normal Awaiting Review defect (bug) new 2018-04-18T15:47:51Z 2018-04-18T15:47:51Z "While the user notes https://developer.wordpress.org/reference/functions/wp_next_scheduled/#user-contributed-notes do relay the importance. I believe it is important that the documentation also be more clear about the issue.
When coded incorrectly something like
{{{
function schedule_my_event(){
if ( ! wp_next_scheduled( 'myevent' ) ) { // This will always be false
wp_schedule_event( time(), 'daily', 'myevent', array( false ) );
}
}
add_action('init','schedule_my_event');
}}}
It's potentially disastrous for a site. The cron value in the options would keep on increasing until the database could no longer withstand it.
So keeping that in mind I feel the documentation for both wp_next_scheduled and wp_schedule_event should highlight this point more." digamberpradhan
43798 Add multiple parent ids in get_term function General normal normal Awaiting Review enhancement new 2018-04-18T12:15:40Z 2018-04-18T12:15:40Z "Please let uns use get_term parent arg as an array with multiple ids:
{{{#!php
[164, 1411]
];
$child_regions = get_terms( 'region', $args );
}}}
" Chorstikus
11 43797 Logging for GDPR privacy/security xkon Privacy normal normal Awaiting Review enhancement assigned dev-feedback 2018-04-18T11:03:26Z 2018-05-23T15:19:42Z "After a little chat in #gdpr-compliance as some questions where raised https://ico.org.uk/for-organisations/guide-to-the-general-data-protection-regulation-gdpr/lawful-basis-for-processing/consent/ was presented.
It seems that we have to create a mechanism so plugins/themes can tap into and record any consents so the admins can keep a proper log of them for later use if needed.
I think it would be prefered if it's somewhere centralized again instead of each plugin keeping it's own log." xkon
43796 User Role with integer role name not showing in admin filter list Users 4.9 lowest normal Awaiting Review defect (bug) new reporter-feedback 2018-04-18T08:38:58Z 2018-04-19T07:26:25Z When we create a new user role using add_role function and role name is an integer then assign that role to users and that role will not display on top of User listing. aiyaz
43792 get_comment_excerpt filter should tell if the comment was shorted or not Comments trunk normal normal Awaiting Review enhancement new dev-feedback 2018-04-17T22:14:58Z 2018-04-18T00:01:39Z "The design I am currently working on has long comments shortened to 100 words, and a 'show more' / 'show less' link is added.
I only want to add the 'show more' text if the comment has been shortened. There is a filter before get_comment_excerpt() returns that I can use to add my link. However it does not pass along information about whether or not the comment was shortened.
As a workaround I can check if the comment ends in ""…"", but it would make sense to add a boolean value to the filter arguments to make this easier/cleaner." mattkeys
1 43791 Add the call to pingback_url to core instead of themes Pings/Trackbacks 4.9.5 normal normal Awaiting Review enhancement new dev-feedback 2018-04-17T20:03:24Z 2018-04-20T13:54:39Z "The `` section contains a lot of `` items that WordPress core generates.
Why should themes be responsible for outputting the `pingback_url()` ``?
The core code should remove this burden from the theme and ensure that it is handled every time and correctly. Currently, the theme needs code like this:
{{{
function mytheme_pingback_header() {
if ( is_singular() && pings_open() ) {
echo '';
}
}
add_action( 'wp_head', 'mytheme_pingback_header' );
}}}
and a lot of themes don't even have it, so then there are core options that don't work correctly. This logic belongs in core.
" joyously
4 43789 the_posts_pagination() outputs the slash at the first link Permalinks 4.9.5 normal normal Future Release defect (bug) new needs-unit-tests 2018-04-17T19:25:04Z 2018-04-19T01:17:37Z "Hello.
Permanent link settings: `http://wp-test.ru/%postname%` (without a slash on the end)
On the second and other pages of pagination, any category has a link to the first page with a slash on the end.
{{{
http://wp-test.ru/category/bez-rubriki/ (with a slash on the end, why?)
http://wp-test.ru/category/bez-rubriki/page/2
http://wp-test.ru/category/bez-rubriki/page/3 (current page)
.....
}}}
" campusboy1987
43787 sql error in wp_get_post_terms Taxonomy normal normal Awaiting Review defect (bug) new close 2018-04-17T11:07:58Z 2018-04-17T15:56:11Z "hi guys,
i create new plugin, and when i try to fetch all custom taxonomies of the post, i give an error :
my code:
{{{
[You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROM wp_terms AS t INNER JOIN wp_term_taxonomy AS tt ON t.term_id = tt.term_id ' at line 1]
SELECT FROM wp_terms AS t INNER JOIN wp_term_taxonomy AS tt ON t.term_id = tt.term_id INNER JOIN wp_term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tt.taxonomy IN ('olympic_games_tax') AND tr.object_id IN (15950) ORDER BY t.name ASC
}}}
{{{#!php
""slug""));
}}}
Have a nice day.
" d1sabled
43785 wptexturize fails to skip JavaScript if code contains < Formatting normal normal Awaiting Review defect (bug) new 2018-04-17T07:51:58Z 2018-04-17T07:51:58Z "As the [https://codex.wordpress.org/Function_Reference/wptexturize documentation] states: Text enclosed in the tags

, , ,
}}}
that will work like before, but stops breaking full-height layouts, for example
{{{
html{height: 100%}
body{min-height: 100%}
}}}" loranrendel
1 43243 Twenty Seventeen: Menu Items are overlapped Bundled Theme 4.9.4 normal normal Awaiting Review defect (bug) new 2018-02-07T09:01:50Z 2018-02-09T04:04:28Z "Menu Items are overlapped
Steps:
1. Installed WordPress 4.9.4
2. Imported file""themeunittestdata.wordpress.xml""
3. Activate Menu
3. Try to overlap and open inner menu items
Issue: Menu Items are overlapped and some part is not displayed.
" nilamacharya
43242 Do not propose users to skip a minor upgrade Upgrade/Install 4.9.3 normal normal Awaiting Review enhancement new has-patch 2018-02-07T07:50:22Z 2018-02-07T10:47:20Z "1) When having a non-US installation and a new version of WP gets proposed, the text is indicating 'You can skip upgrading if you want to keep your current translation'. I think it's a bad idea to tell people they can skip upgrading.
Most probably it would be better to indicate that there might be temporarily some translation issues if the translation files are not immediately available.
2) The button says 'Hide this update', the text says 'skip'. Probably better to harmonize (if these are linked, which I think they are)." casiepa
1 43241 Twenty Seventeen: Menu behaviour is not proper Bundled Theme 4.7 normal normal Awaiting Review defect (bug) new 2018-02-07T07:08:55Z 2018-05-24T12:05:04Z "Menu Items are sticky once user will click on it
Steps:
1. Installed WordPress 4.9.4
2. Imported file""themeunittestdata.wordpress.xml""
3. Activate Menu
Issue: Menu is shown sticky after clicking on it (where there is # link and third party links)
Expected Bahaviour: It should be disappear once user will click on it" nilamacharya
43232 User signups should be marked `active=0` after account is deleted Users 3.0 normal normal Awaiting Review defect (bug) new dev-feedback 2018-02-05T17:16:52Z 2018-05-10T23:43:45Z "On multisites with open registration, the flow works like this:
1. User registers as wp-signup.php, which puts an entry into `wp_signups` with `active=0`.
2. When the user clicks the link in the activation email, the `wp_users` entry is created, and the entry in `wp_signups` is marked `active=1`.
Later, if that user's account is deleted - ie the record is removed from the `wp_users` table - the record in `wp_signups` is left untouched. This causes problems if the user creates an account, deletes it, and then tries to register again using the same login or email address. https://core.trac.wordpress.org/browser/tags/4.9.2/src/wp-includes/ms-functions.php?marks=503-524#L499
The problem goes away after two days, after which registering with info that matches an existing signup causes the old signup to be deleted in favor of the new one.
That said, it feels like some confusion could be avoided - and the database kept somewhat more internally consistent - by setting `active=0` when an account is deleted. Does this seem reasonable to others?" boonebgorges
4 43228 register_theme_directory() needs to delete the `theme_roots` transient johnbillion Themes normal normal Future Release defect (bug) reopened 2018-02-05T11:40:43Z 2018-03-20T22:25:53Z "Calling `register_theme_directory( '/path/to/themes' )` adds an element to the global `$wp_theme_directories` array.
When WordPress attempts to load the active theme, it ultimately calls `get_theme_roots()` which first checks for a cached value in the `theme_roots` transient before looking at the `$wp_theme_directories` global. This transient does not get deleted when `register_theme_directory()` is called, therefore if `get_theme_roots()` gets called before `register_theme_directory()` then the theme directory registration will silently fail due to the use of a stale cache of registered theme directories.
`get_theme_roots()` is ultimately called by several theme-related functions, such as `wp_get_themes()` and `wp_get_theme()`, so it's reasonable to expect that `get_theme_roots()` might get called before `register_theme_directory()`.
`register_theme_directory()` should delete the `theme_roots` cache in order to avoid this problem.
This bug has manifested itself in the WP-CLI theme test scaffolding command, which calls `register_theme_directory()` on the `muplugins_loaded` hook, which means the `theme_roots` transient has already been populated with registered theme directories." johnbillion
1 43227 Media uploaded to post should remove underscores and hyphens from text inserted into title attribute Media normal normal Awaiting Review enhancement new 2018-02-05T11:04:43Z 2018-02-05T11:04:43Z "When adding a new image into a post my file name will typically be called something like:
descriptive-name-of-image.jpg
Once this image is uploaded wp will automatically set the title and will default to the name of the image ""descriptive-name-of-image"" if no title meta data is available in the image.
I think a better default action would be to replace the hyphens/underscores with spaces and possibly capitalising the first letter making the title ""Descriptive name of image""." mrmadhat
2 43225 feed_links and feed_links_extra should have filters Feeds trunk normal normal Awaiting Review enhancement new needs-docs 2018-02-04T20:34:25Z 2018-02-05T00:00:01Z There ought to be a way to modify the way feed links are displayed by the `feed_links` function. Currently there is, for instance, no way to change the separator from `»` to something else. topdownjimmy
1 43224 Extract `$utf8_pcre` from `wp_check_invalid_utf8()` into a separate function Formatting trunk normal normal Awaiting Review enhancement new 2018-02-03T23:59:24Z 2018-04-26T04:35:49Z "The `wp_check_invalid_utf8()` function checks to confirm support for the `/u` flag in regular expressions. The result of that check is cached in a static variable within that function. However, other areas of the codebase might want to run the same check, or maybe plugins would like to check also.
I'm considering a change in Gutenberg's PEG parser and that might serve as an example use case for the new `wp_can_utf8_pcre()` function I'm proposing in this ticket. Instead of running the same check all over again, having this check run once by a utility function would be nice.
See: https://github.com/WordPress/gutenberg/blob/daad3f21319ec9ec73fa1b907119a7464442bfac/lib/parser.php#L1818" jaswrks
1 43222 l10n merging and priority I18N 4.9.2 normal normal Awaiting Review defect (bug) new 2018-02-03T17:13:56Z 2018-02-07T10:00:24Z "Hi,
I'd like to better understand how the prioritization of .mo files should be working, as the behavior seems backwards.
Having a multi-language site, I'm getting wrong language strings under these circumstances:
1. I place plugin translations for select languages under
wp-content/languages/plugins/plugin-xx_YY.mo
2. I select a language other than default
3. WordPress seems to always load the site's default language .mo first
4. Then when language is switched by a multi-lang plugin, the code in l10n.php merging in the translations seems to prioritize the original entries over the 'new' ones:
https://core.trac.wordpress.org/browser/tags/4.9/src/wp-includes/l10n.php#L586
At 590: $mo->merge_with( $l10n[$domain] );
will override the newly loaded .mo entries (in selected language)
with the ones loaded before (site's original language).
And so I end up with a site that's mostly translated to the selected language with strings for the 'plugin' in site's original language no matter what I do.
Since merge_with() always overwrites the entries, shouldn't it be used as $orig->merge_with($new) rather than the current $new->merge_with($orig) in l10n.php?
Thanks,
hnhn" hnhn2
43215 Allow wp_kses to pass allowed CSS properties Security 4.9.2 normal normal Awaiting Review feature request new 2018-02-02T12:31:48Z 2018-02-02T12:31:48Z "`wp_kses` takes arguments for allowed HTML elements, HTML element attributes, and allowed protocols. It takes all of these directly via the function argument through a nicely formatted assoc array. On the side side, attribute values (i.e. ""display: block; visibility: hidden;"") are configured via a hook, which means they are changed globally for all future calls.
Here a sample how the system is behaving currently:
{{{#!php
array(),
'noscript' => array(),
'iframe' => array(
'src' => array(),
'width' => array(),
'height' => array(),
'style' => array(),
),
);
$allowed_output_protocol = array(
'https',
'javascript',
);
$google_tag_manager_noscript <<
ENDSTRING;
echo wp_kses( $google_tag_manager_noscript, $allowed_output_html, $allowed_output_protocol);
// Outputs as it should except for the style=""display:none;visibility:hidden"" portion
//
}}}
It seems that currently the only way to allow the ""style"" attribute from showing is to write a filter for ""safe_style_css"" to add in the ""display"" and ""visibility"" attributes, however this means that we are globally altering this behavior, which in other scenarios would allow unexpected HTML to appear (ie unsafe element properties). Even when removing the items immediately after executing the code will not work because the attribute may in the future be consider secure. This then causes an inconsistent execution.
For example, imagine that if we wanted to make sure the ""float"" attribute was allowed in the attribute value. Currently this value is allowed, so us adding it in won't change the array. However when we're then undoing our action (ie removing the ""float"" attribute from the list of allowed attributes, we are actually removing one that was set as ""safe"" by WordPress themselves. It is easy to imaging how this could escalate further, when plugins blanket whitelist element attributes, then remove them from the list, then meaning that no attributes are allowed.
Alternatively, in this same example if we removed our filter (with remove_filter) right after our wp_kses call, it would mean that our attribute whitelist would apply to all HTML attributes (display, visibility,...) and not only the one we would want to whitelist (style).
{{{#!php
array(),
'noscript' => array(),
'iframe' => array(
'src' => array(),
'width' => array(),
'height' => array(),
'style' => array(),
),
);
$allowed_output_protocol = array(
'https',
'javascript',
);
$google_tag_manager_noscript <<
ENDSTRING;
// Telling WordPress about safe CSS attributes...
add_filter( 'safe_style_css', 'my_safe_css_attributes' );
echo wp_kses( $google_tag_manager_noscript, $allowed_output_html, $allowed_output_protocol);
add_filter( 'safe_style_css', 'my_safe_css_remove_attributes' );
// Outputs as it should.
//
}}}
I initially expected the allowed_output_html to allow overriding allowed attribute values from the ""style"" element in the array, which I thought would have been a really neat way of overwriting the execution on a one-time basis.
{{{#!php
array(),
'noscript' => array(),
'iframe' => array(
'src' => array(),
'width' => array(),
'height' => array(),
'style' => array(
'display', 'visibility'
),
),
);
// ...
}}}
I think it would make sense to make the function accept this added level of depth as it allows very flexible configuration of what attributes are allowed without compromising attribute
" mclaurent
43211 Large number of widgets freezes the browser and makes widget admin unusable Widgets 4.8.3 normal normal Awaiting Review defect (bug) new 2018-02-02T01:06:37Z 2018-02-05T16:08:05Z "Having a large number of widgets can freeze the browser for minutes while loading, and crashes Firefox when viewing source. On a site with a little more than 500 widgets (mostly ''text'' widgets!) it can be completely unresponsive for some time loading wp-admin/widgets.php
Tested in Firefox and Chrome beta." programmin
43210 Introduce singular capabilities for managing individual options Role/Capability normal normal Awaiting Review enhancement new dev-feedback 2018-02-02T00:21:35Z 2018-04-19T21:52:52Z "We've always had `manage_options`, but it's currently impossible whether a user can manage a specific option. As part of related tickets dealing with more granular capabilities (see https://core.trac.wordpress.org/query?status=accepted&status=assigned&status=new&status=reopened&status=reviewing&keywords=~granular-capabilities&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=milestone&col=component&order=priority), I suggest adding a meta capability `manage_option`.
It should accept (or basically require) the option name as argument. By default it should fallback to the regular `manage_options`, but an `auth_callback` could be passed to `register_setting()` to tweak the permissions there (such an `auth_callback` is already known from `register_meta()`).
This would also be useful for the REST API so that it can use the more granular permissions." flixos90
43209 REST API should take settings errors into account Options, Meta APIs normal normal Awaiting Review enhancement new dev-feedback 2018-02-01T23:59:10Z 2018-02-01T23:59:10Z "The `WP_REST_Settings_Controller` should notify the client when updating a setting fails due to an invalid value provided per the setting's `sanitize_callback` (should actually be validation, see related #43208). Currently this goes completely unnoticed.
While `update_option()` doesn't return any information like that, it may be possible to use the information passed to `add_settings_error()` in case of a validity issue, and forward that to the client by returning a `WP_Error` with the message." flixos90
3 43208 Separate setting validation from sanitization Options, Meta APIs normal normal Awaiting Review enhancement new needs-unit-tests 2018-02-01T23:45:12Z 2018-04-03T11:32:21Z "As widely known, validation is different from sanitization. A value should first be validated and then be sanitized. Historically, WordPress has been mixing these two responsibilities in the `sanitize_option()` function, however it is easily possible to add an extra layer on top of that which maintains full backward-compatibility.
Newer parts of core, such as the Customizer and the REST API, have been dealing with this in a better way, keeping the two separate. We can achieve the same for options themselves too.
I suggest introducing a `validate_option_{$option}` filter that works somewhat similar like the `customize_validate_{$setting_id}` filter used in the Customizer. It passes an empty `WP_Error` object that can be added to. In addition to allow separate validation from sanitization, it also makes handling of validation easier, since it can then automatically set the value to the previous value and call `add_settings_error()`, passing any error messages set, which matches current core behavior." flixos90
1 43206 Angle brackets around URLs can confuse email clients Mail 4.9.2 normal normal Awaiting Review defect (bug) reopened 2018-02-01T19:20:43Z 2018-04-13T10:35:36Z "In #14140, angle brackets were added to plain text emails sent by WordPress due to some email clients not handling long URLs correctly.
However in some email clients, the trailing `>` is treated as part of the link, which also causes users to end up at the wrong URL.
As there is no standardised way to make a link clickable in a plain text document I think the best solution would be for WordPress to send all mail in both `text/plain` and `text/html`." tomdxw
43205 Allow filtering the list of characters to be replaced by wptexturize Formatting trunk normal normal Awaiting Review feature request new 2018-02-01T18:41:46Z 2018-02-01T18:41:46Z "I'd like to selectively disable the replacement of a subset of the characters replaced by wptexturize.
There are already filters to control which html tags & shortcodes are exempt from being texturized: `no_texturize_shortcodes` & `no_texturize_tags`.
I think a similar filter should exist to control which characters are texturized. This filter would take at least two parameters: `$dynamic_characters` & `$dynamic_replacements`.
I am interested in writing a patch if you'll consider it. Would this enhancement be acceptable?" cyclic
43202 Attachment Details: with cursor in URL box, left/right arrows switch between attachments Media 4.9.2 normal normal Awaiting Review defect (bug) new 2018-02-01T15:27:28Z 2018-02-01T15:27:28Z "This is related to issue #29725 (https://core.trac.wordpress.org/ticket/29725). The changes made to resolve #29725 work for text boxes that can be edited, but the URL box is read-only, and because of that, the fix has no effect.
On the Attachment Details screen, an attachment's URL is only shown in the URL box. But typically, most of the URL is not shown, since it's longer than the box size. To see the end of the URL, I can use the End key, but that leaves the middle of the URL, which for many URLs I can only see if I can move the cursor with the left/right arrow keys.
You could make the URL box completely inaccessible (disable the cursor completely), but then the box would be essentially useless as a source of information. That seems to leave only one remaining choice, which is to disable attachment navigation using the left/right arrow keys when the cursor is in the URL box." jrivett
43199 JSDoc: wp-admin/js/edit-comments.js Comments normal normal Awaiting Review defect (bug) new 2018-02-01T14:31:13Z 2018-02-02T09:41:03Z props to @Xyfi @thulshof @diedeexterkatedex @manuelaugustin manuelaugustin
43198 Error saving widgets with html code - ModSecurity active - in some host services Widgets 4.9.2 normal normal Awaiting Review defect (bug) new 2018-02-01T14:10:20Z 2018-02-01T14:10:20Z "Hello.
Problem: When I go into the administration panel at Apearance - Widgets, and want to add a text box to a sidebar, the box saves just plain text, not accepting it with html content. When the save button is pressed, nothing happens, the process having no end.
Answer from my host service:
""I'm asking you to modify your site with the ModSecurity module deactivated.
You can disable this module from the cPanel interface, the section called ""ModSecurity""
Recently, WordPress changed their platform without considering that the new site editing methods are not safe and easy to explode, resulting in many situations where it violates multiple ModSecurity rules.""
Maybe a similar problem is related here:
https://hameedullah.com/whitelisting-wordpress-admin-wp-admin-in-mod_security-to-avoid-404-on-post-save-or-post-preview.html" attosoftonline
2 43197 Nesting @media rule inside @supports rule fails CSS validation Customize 4.9.2 normal normal Awaiting Review defect (bug) new 2018-02-01T10:13:49Z 2018-02-23T22:04:59Z "The CSS editor in the Customize panel returns 2 syntax errors when trying to insert a `@media` rule inside a `@supports` rule. It does work fine the other way around.
See screenshot:
[[Image(https://i.imgur.com/81b01Bp.png)]]
Results are independent of specified properties & values.
This might impact performance, because it is faster to skip the entire content of a feature query if a browser does not support a certain feature, rather than having multiple media queries with `@supports` in each of them. Besides, it can be functionally different, as explained here: https://stackoverflow.com/a/42438244
Tested on Chrome 63 and Windows 7. " neoqueto
43196 wp-admin/upload.php media thumbnails are loaded in http despite all site runs https Media 4.9.2 normal normal Awaiting Review defect (bug) new 2018-02-01T09:52:14Z 2018-02-01T09:52:14Z "Hi,
I’m working on a site where wordpress address and site address are the same and starting by https://...
By now,this site is htaccess-password-protected and I’ve noticed media thumbnails don’t appear (but if I click the details, my images appear correctly).
I’ve looked into the generated code and I see img thumbnails are still http:// and not https:// as they should.
Same problem in grid as list view.
My thumbnails appear again if I try to connect to my site via http://, so I’m asked again for password and then I’m redirected to https:// (and I have to set password again). " synthview
43194 MySQL error when uploading my own theme Themes 4.9.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2018-02-01T09:21:45Z 2018-02-01T09:23:52Z "NOTE: I have the debug options ON
When I upload my own theme [Themes -> Add New -> Upload Theme] I get these mesages:
Installing Theme from uploaded file: example-1.2.3.zip
Unpacking the package…
Installing the theme…
Theme installed successfully.
Network Enable | Return to Themes page
Notice: wpdb::prepare was called incorrectly. Unsupported value type (array). Please see Debugging in WordPress for more information. (This message was added in version 4.8.2.) in /wp-includes/functions.php on line 4147
Warning: mysqli_real_escape_string() expects parameter 2 to be string, array given in /wp-includes/wp-db.php on line 1102
Notice: wpdb::prepare was called incorrectly. Unsupported value type (array). Please see Debugging in WordPress for more information. (This message was added in version 4.8.2.) in /wp-includes/functions.php on line 4147
Warning: mysqli_real_escape_string() expects parameter 2 to be string, array given in /wp-includes/wp-db.php on line 1102" JavierCasares
43189 Restoring page revision doesn't restore page template previously used Revisions 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-31T13:23:15Z 2018-01-31T15:09:27Z "I noticed this when one of the editors made a change in a page and also changed page template.
We reverted the change by restoring a previous revision, but this didn't restore the previous page template.
" bugnumber9
43183 wp-comments-post.php endpoint support for OPTIONS Comments 4.9.2 normal normal Awaiting Review enhancement new 2018-01-30T17:13:04Z 2018-01-30T17:13:04Z "Under some circumstance we may need cross-posting from one domain to another (without the wp-json API).
At least lets preflight requests flow normally
https://github.com/WordPress/WordPress/pull/338
" drzraf
3 43178 Rethinking what “captions” means for video Media trunk normal normal Future Release enhancement new reporter-feedback 2018-01-29T16:32:59Z 2018-03-18T23:12:29Z "'''Because different users will use the word ""caption"" in different ways, it would be helpful to look at reducing this term in WordPress media and clarifying all media terms as a whole.'''
Captions carry a meaning in the video industry that is closely related to subtitles. It's recommended that we change how we describe our images, videos, and other media used within WordPress.
''Note: For architectural reasons, the field data should be left alone, but we need a better label for the associated meta. I also talked about this a bit in #31177''
This proposal further explores the messy language in media attachments and focuses on clear description so that all users can understand them, including clarifying WordPress' use of video subtitles.
A proposal to revising these terms is below.
Images
1) Wherever images use {{{data-setting=""title""}}} - instead of ""Title"" the English label should read ""Media Title.""
2) Wherever images use {{{data-setting=""caption""}}} - instead of ""Caption"" the English label should read ""Image Caption."" Because the specific term ""photo captioning"" describes a widely-used industry term, it should be clarified here but not removed.
3) Wherever images use {{{data-setting=""description""}}} - instead of ""Description"" the English label should read ""Longer Description."" This is because theme developers do not output this data beyond attachment pages and having three ill-described content areas - alt, caption, description - is an anti-pattern to describe what these images.
Videos
1) Wherever images use {{{data-setting=""title""}}} - instead of ""Title"" the English label should read ""Media Title.""
2) Wherever video use {{{data-setting=""caption""}}} - instead of ""Caption"" the English label should read ""Media Description.""
3) Wherever images use {{{data-setting=""description""}}} - instead of ""Description"" the English label should read ""Longer Description."" This is because theme developers do not output this data beyond attachment pages and having three ill-described content areas - alt, caption, description - is an anti-pattern to describe these images.
By adjusting these terms and exposing utility of the meta values, this level of clarity will greatly enhance the ability for all users, especially those helping create content for both multi-lingual and Deaf audiences, to understand the meta values in managing media work without the need to read documentation.
Goals:
1. Because videos are reused on separate posts and all subtitled videos should contain this as a part of their output, create a meta value (or some other object type) that stores associated SRTs per language.
2. Allow for a better way for all videos that stores the associated SRTs to be associated with a language or as another kind of subtitle track - i.e. commentary, descriptive text, etc.
3. Allow videos uploaded at the same time with the same subtitle file name (or in a language structure) to be associated with each other. Assume the default core language for videos with no LANG code and associate the only subtitle as belonging to default core’s. (If there’s only one SRT with no lang suffix, it’s probably a caption.)
If we leave the existing labels as-is, new and old users will both continue to put the wrong information in because of the lack of context to each field. Whatever fix we decide on, this should also be further adjusted in each target language that WordPress core is released in." postphotos
1 43177 REST API allows empty comments containing only whitespace REST API trunk normal normal Future Release defect (bug) new needs-unit-tests 2018-01-29T16:28:06Z 2018-03-22T17:54:17Z "I can POST the following to the REST API endpoint for comments and it slides through so long as it's not an empty string. Just adding a single space results in an empty comment.
{{{
{
""post"": 1,
""content"": "" ""
}
}}}
I suggest `trim()` empty check. Or, a more robust alternative: https://gist.github.com/jaswrks/d662f4ba8b379e7602c8f80f7b1bb82e
" jaswrks
43176 Nav Menu Search - add filters for query args Menus trunk normal normal Awaiting Review enhancement new 2018-01-29T16:01:00Z 2018-03-19T15:20:33Z "On sites that have lots of content with similar names, it can be almost impossible to find the correct page using the search tab. One way to fix this is described in #38224 (changing the number of posts returned, or providing a filter so developers can change it).
Another option would be to check if the search query is_numeric(), and if so, search for a page with that ID. This could either be implemented in core directly, or appropriate filters could be provided so a plugin could implement this functionality." billerickson
10 43175 Discussion - Pseudonymisation Privacy normal normal Awaiting Review enhancement new 2018-01-29T12:56:17Z 2018-05-19T03:47:13Z "I'm opening up this ticket as an area of discussion to try and find out if there's anything needed or will be done in the future regarding 1 specific area of the GDPR. Specifically for `Pseudonymisation`. In my eyes the paragraph below seems to be in need of more attention than explaining to the user what data we are collecting on any given site.
As it is stated at the moment on
https://en.wikipedia.org/wiki/General_Data_Protection_Regulation#Pseudonymisation
Pseudonymisation
The GDPR refers to pseudonymisation as a process that transforms personal data in such a way that the resulting data cannot be attributed to a specific data subject without the use of additional information. An example of pseudonymisation is encryption, which renders the original data unintelligible and the process cannot be reversed without access to the correct decryption key. The GDPR requires that this additional information (such as the decryption key) be kept separately from the pseudonymised data. Pseudonymisation is recommended to reduce the risks to the concerned data subjects and also help controllers and processors to meet their data-protection obligations (Recital 28).
Although the GDPR encourages the use of pseudonymisation to ""reduce risks to the data subjects,"" (Recital 28) pseudonymised data is still considered personal data (Recital 26) and therefore remains covered by the GDPR.
After reading that we made some discussions with some law firms (specializing on internet matters) and the answers that we got where pretty much the same and are as follow:
The idea is to either have pretty much all the data encrypted ( for example phone numbers, addresses etc ) or have the website connecting into 2 databases instead of 1 that keeps the data. So you would require access to both databases to identify a person. For example DB 1 keeps the name and password, the 2nd keeps the address and phone. The idea is that if there's a breach it would require both databases to make a full match of a person else the data are incomplete etc.
--
Now since I'm not into law or anything, maybe there's somebody around with a more clear view into what's ( IF ) needed to be done. And if that's the case maybe it should become a matter of discussion since May isn't that far off.
I've seen Plugins and developers in general are already moving and altering things towards being GDPR compliant, but my question is based on if there's something that needs to be done within the core of WordPress itself so it can be 'shipped' GDPR ready ( if not already compliant ).
--
We could also try and gather somewhere all the information regarding WordPress / GDPR to see a more spherical view of the matter and what is changing / needs to be adjusted ( policies etc )." xkon
1 43173 Site Icon 512x512 doesn't work, other sizes do Media 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-29T04:46:43Z 2018-01-29T04:46:43Z "I've tried with multiple themes and no plugins to try and resolve a site icon issue.
The WordPress administration area says to upload a site icon that is at least 512 by 512 in width and height.
Uploading a site icon exactly this size doesn't appear to work. When choosing an image by clicking the ""select"" button, the image is un-selected in the media library and the ""select"" button is disabled. The next screen does not appear and nothing else happens.
I tried with different sizes, e.g. 300 x 300, and it worked." smeinfosec
1 43171 Image Title Not Carrying through on Insert Widgets 4.8 normal normal Awaiting Review defect (bug) new 2018-01-28T16:35:54Z 2018-01-29T18:34:31Z "If I go into a post, page, or widget and insert and image the image title does not come through on that original insert. This happens with either a new uploaded image or one from the gallery. I can set the alt-text, caption, title, and such, but when it is inserted the title is the only field not to come through. It is blank. I can then go in and edit the image and fix the title and it takes. If I am editing an image in the image widget, the same thing happens. And if it is an existing image widget that I am just changing the image in, it will actually leave the title from the previous image - not blank it out or use the newly specified title. I have verified this with new images, edited images, uploaded images, images from the media library, different image formats, etc... And verified on multiple sites, on different hosts, with any and or all plug-ins deactivated or activated. Oh, and different themes. Everything from complex magazine theme to standard WP TwentyTen theme and stuff in between. Can give access to sites where this happens. Actually, I have found no sites where it actually works correctly.
" carnellm
1 43170 Replace all usages of basename() with wp_basename() in order to support multibyte filenames Media 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-28T10:10:09Z 2018-01-29T19:16:52Z "We still use `basename()` in a lot of places even though it isn't multibyte compatible out of the box. See http://php.net/basename and https://bugs.php.net/bug.php?id=62119.
Example filename where it can fail: `麻美.jpg`
We should replace all uses of `basename()` with our own `wp_basename()`. This will probably need a lot of testing, so probably best to avoid one big patch and instead change calls in small chunks.
Related: #43138" Viper007Bond
1 43168 Customizer: Iris color picker handle above section title Customize 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-27T18:58:05Z 2018-01-27T18:58:05Z "When Iris color picker is opened, the handle displays bevor the section title – if section is visible during scroll-up.
Section title styles:
{{{
#customize-controls .customize-info.is-in-view,
#customize-controls .customize-section-title.is-in-view {
z-index: 9;
}
}}}
Handle styles:
{{{
.iris-picker .iris-square-handle {
z-index: 10;
}
}}}" crstnio
43166 4.9 broke uploaded images' paths on my network installation General 4.9 normal normal Awaiting Review defect (bug) new close 2018-01-27T18:05:07Z 2018-01-28T17:08:50Z "I run a network installation. I upgraded from 4.8.2 to 4.9 back in December but found out that images were broken on all of my network's sites.
My network's sites are as follows:
Site 1: https://www.mybrand.com/es/blog/
Site 2: https://www.mybrand.com/en/blog/
Site 3: https://www.mybrand.co.uk/en/blog/
Site 4: https://www.mybrand.it/it/blog/
etc.
4.9 converts a 4.8.2 working image URL on Site 1, such as:
https://www.mybrand.com/es/blog/wp-content/uploads/sites/1/2016/09/image.jpg
...into the following non-existent URL:
https://www.mybrand.com/es/blog/wp-content/uploads/2016/09/image.jpg
... thus resulting in a 404 response for the image load.
Since I had upgraded some plugins together with the Wordpress core, what I tried first was deactivating those, with no success. So I ended up downgrading the core back to 4.8.2, which fixed the bug.
Last week I again tried upgrading to 4.9.2, with the same result (the image bug is still there). This time I downgraded to 4.8.5, which works fine.
All sites use the Twenty Sixteen template.
My current install includes the following plugins at the network level:
* AddToAny Share Buttons Version 1.7.23
* All In One SEO Pack Version 2.4.4.1
* Autoptimize Version 2.3.2
* Broken Link Checker Version 1.11.5
* Custom Meta Widget Version 1.4.8
* Custom Permalinks Version 1.2.12
* Customize Login Image Version 3.3.1
* Disable REST API Version 1.4.2
* External Links Version 6.8.1
* Google Analytics for WordPress by MonsterInsights Version 6.2.7
* Google Captcha (reCAPTCHA) by BestWebSoft Version 1.33
* HREFLANG Tags Lite Version 1.5.6 | By DCGWS
* Jetpack by WordPress.com Version 5.7.1
* kk Star Ratings Version 2.6
* Simple 301 Redirects Version 1.07
* W3 Total Cache Version 0.9.6
* wBounce Version 1.8
* WordPress Importer Version 0.6.3
* WP Downgrade Version 1.1.4
* WP Login Flow Version 1.0.0
* WP Rollback Version 1.5
I actually installed WP Downgrade and WP Rollback after 4.9 broke my installation, to help downgrade to a working version.
All templates and plugins are up to date." pasqal
43164 Function Description : wp-includes/link-template.php General 4.1 normal normal Awaiting Review enhancement new 2018-01-26T20:49:22Z 2018-01-26T20:49:22Z There is no descrption for global vars mt8.biz
1 43163 Did you know? CSS notification needs a Dismiss button to close Editor 4.9 normal normal Awaiting Review feature request new has-patch 2018-01-26T17:09:30Z 2018-01-27T17:08:09Z "The CSS notification bar at the top of the Edit Themes editor needs a Dismiss button so that it can be closed.
The notification bar I'm referring to says:
'''
Did you know?
There’s no need to change your CSS here — you can edit and live preview CSS changes in the built-in CSS editor.'''
" pracko
1 43162 Deleting a site from a multisite network leaves orphaned database tables and files Networks and Sites 3.0 normal normal Awaiting Review enhancement new dev-feedback 2018-01-26T16:15:02Z 2018-01-26T19:12:10Z "Looking at the table structure of a typical multisite install, I see that tables for individual sites within the network are prefixed with wp_{siteid}_ tablename. When I delete a site from the from the network, all standard WP tables for that particular site ID are deleted; however, several plugin tables are not.
As well, looking at the uploads/sites directory, the directory for that site (represented by its ID) is also still there along with all its files (media and other uploads).
an earlier ticket:30673 suggested that this should be caught when uninstalling a plugin from the master site. But, I'd have to disagree. Most uninstall scripts use a type of {TABLEPREFIX} before its table names. This would delete the tables for every site in the network, wouldn't it? and that's not what the goal would be.
Aside from the plugin issue are the media files that are also orphaned. Media file uploads is part of core, and that's not something a plugin author could approach.
When deleting a site from the network, this is irrevocable. Wordpress even create an extra confirmation page upon delete saying so just to make sure. If that's the case, and this is by design, what's the point of keeping these extra files and tables if they are never going to be used again?
Shouldn't all site specific db tables and all files in the uploads directory be deleted when a site is deleted? Or, perhaps as an enhancement, on the Delete Site confirmation page, could we have two checkboxes: ""1) delete all tables associated with this site"" and ""2) delete all files associated with this site""
Currently I have a script setup to alert me as to when a site is deleted. I then open up a cli to manually delete the db tables for that install, and then its files from the uploads directory. This doesn't feel like the intended workflow to handle the orphaned elements of the site." bluep92877
2 43160 Reduce wp-admin/update-core.php load time by half Upgrade/Install 4.9.2 normal normal Awaiting Review enhancement new 2018-01-25T23:10:13Z 2018-04-18T20:39:35Z "I had this problem where loading this page was taking over a minute.
It turns out that this is caused by premium plugins that makes remote calls to validate license and/or verify the existence of update.
My whole journey is documented here:
https://wordpress.org/support/topic/displaying-wp-admin-update-core-php-takes-about-50-secs/
There is not much that can be done about that but this can be mitigated a lot when you realise that wp_update_plugins() calls set_site_transient() twice and this is where the expensive hook calls are made.
So here is my attempt to improve the situation:
{{{
$ diff wp-includes/option.php{.orig,}
1721a1722,1759
> * Set/update the value of a site transient without calling the sometimes expensive hooks.
> *
> * This is particularly for the special case of wp_update_plugins() where set_site_transient() was called twice
> * and the first time was only for setting up the last_checked update_plugins option.
> *
> * @since 4.9.2
> *
> * @see wp_update_plugins()
> *
> * @param string $transient Transient name. Expected to not be SQL-escaped. Must be
> * 167 characters or fewer in length.
> * @param mixed $value Transient value. Expected to not be SQL-escaped.
> * @param int $expiration Optional. Time until expiration in seconds. Default 0 (no expiration).
> * @return bool False if value was not set and true if value was set.
> */
> function set_site_transient_nohook( $transient, $value, $expiration = 0 ) {
>
> $expiration = (int) $expiration;
>
> if ( wp_using_ext_object_cache() ) {
> $result = wp_cache_set( $transient, $value, 'site-transient', $expiration );
> } else {
> $transient_timeout = '_site_transient_timeout_' . $transient;
> $option = '_site_transient_' . $transient;
> if ( false === get_site_option( $option ) ) {
> if ( $expiration )
> add_site_option( $transient_timeout, time() + $expiration );
> $result = add_site_option( $option, $value );
> } else {
> if ( $expiration )
> update_site_option( $transient_timeout, time() + $expiration );
> $result = update_site_option( $option, $value );
> }
> }
> return $result;
> }
>
> /**
1767,1781c1805
< if ( wp_using_ext_object_cache() ) {
< $result = wp_cache_set( $transient, $value, 'site-transient', $expiration );
< } else {
< $transient_timeout = '_site_transient_timeout_' . $transient;
< $option = '_site_transient_' . $transient;
< if ( false === get_site_option( $option ) ) {
< if ( $expiration )
< add_site_option( $transient_timeout, time() + $expiration );
< $result = add_site_option( $option, $value );
< } else {
< if ( $expiration )
< update_site_option( $transient_timeout, time() + $expiration );
< $result = update_site_option( $option, $value );
< }
< }
---
> $result = set_site_transient_nohook( $transient, $value, $expiration );
$ diff wp-includes/update.php{.orig,}
68c68
< set_site_transient( 'update_core', $current );
---
> set_site_transient_nohook( 'update_plugins', $current );
}}}
" lano1106
1 43159 Introduce helper function for XMLRPC checks Bootstrap/Load normal normal Awaiting Review enhancement new has-patch 2018-01-25T20:30:35Z 2018-01-26T17:40:12Z Similar to #25669, it would be nice if there was a helper function for checking if WordPress is doing a XML-RPC request. NathanAtmoz
43156 _walk_bookmarks(): please add the link id as HTML id attribute. Formatting 4.9.2 normal normal Awaiting Review enhancement new 2018-01-24T17:28:33Z 2018-01-24T17:28:33Z "Hi, would it be possible to add an HTML attribute that contains the WP link ID when outputting the a blogroll link with _walk_bookmarks() ?
It would be nice to be able to customize links with CSS.
I know it is possible to do it by hooking a function on 'wp_list_bookmarks', but... what a waste of time for nothing :)
Thanks" grosbouff
43155 Formatting bug with ampasands - WooCommerce Layered Nav Formatting 4.7.5 normal normal Awaiting Review defect (bug) new 2018-01-24T14:39:12Z 2018-01-24T14:39:12Z "I found a problem with the WooCommerce layered nav plugin caused by WordPress itself. When you have products shown filtered by an attribute (for example - red) and then click the number of products to show (such as 45) upon page load the ampasand (&) changes to the HTML entity instead.
I commented out a few lines on wp-includes/formatting (example - line 238 - $curl = preg_replace( '/&(?!#(?:\d+|x[a-f0-9]+);|[a-z1-4]{1,8};)/i', '&', $curl );) which now stops this happening.
Please have a look as I know this will be overwritten when WordPress is next updated.
Best Regards,
Jim." jimleeder
43153 Theme Preview doesn't work Themes 4.9.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2018-01-24T12:53:53Z 2018-01-26T07:34:06Z "Hi
in WordPress 4.9.2 when i go to Appearance-> Themes and want to add new theme from WordPress library. i'm click on Preview button to see details about any themes but it's blank page happen. i test it on 3 different WordPress site but it's happen again." CG-TEAM
43152 Image remains in page after deleting from Media Library Media 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-24T00:31:39Z 2018-01-24T00:31:39Z "Whilst editing your page, if you open the Media Library (using the Add Media button), and then delete an image that is currently added to the page, the image remains on the page after closing the pop-up window.
To Reproduce:
- Insert Image on Page
- Click Add Media button to display the Media Library popup Window
- Select the image that you previously inserted on the page and delete the image
- Close the media pop-up window
- Image that was deleted remains on page
Here's a gif to show an example - https://cl.ly/1I2r3q3H301J
I originally raised this as an [https://github.com/WordPress/gutenberg/issues/4610 issue with Gutenberg], but it was suggested to raise it here since it's also an issue with the classic editor." ahortin
1 43151 Media widgets shouldn't use a clickable div as an UI control Widgets 4.8 normal normal Future Release defect (bug) new 2018-01-23T23:12:26Z 2018-02-05T16:11:38Z "All the new media widgets (image, audio, video, gallery) display a media ""placeholder"":
[[Image(https://cldup.com/niQGhcAASo.png)]]
It has a double functionality:
- it displays an informative message, e.g. ""No image selected""
- it's clickable to open the media modal
However, this clickable placeholder is actually a clickable `

` element. Elements that are non-natively interactive shouldn't be used as UI controls. In the last years. WordPress has been progressively addressing this issue across the whole admin interface, [https://core.trac.wordpress.org/query?keywords=~semantic-buttons trying to use semantic and natively interactive elements] instead.
The introduction of clickable `

` elements in core is a regression compared to the best practices used in the last years. Additionally, it's an accessibility barrier, as these elements can only be used with a pointing device and there's no way to use them with other devices, e.g. with a keyboard.
The same issue was discussed at length for the similar ""placeholders"" in the customizer, see #34323. There was also a [https://wordpress.slack.com/archives/C02S78ZAL/p1462228081000246 discussion on Slack] with different opinions, which highlighted how such a pattern is controversial.
Regardless of all the feedback, suggestions, and expertise provided previously, these clickable `

` elements are now implemented in the media widgets. Worth noting they just duplicate the functionality of the ""Add media"" buttons placed below them.
They also introduce a new inconsistency in core: in the Customizer there are other ""placeholders"" that visually look the same but they're ''not'' clickable:
[[Image(https://cldup.com/Pfbgq2z4yW.png)]]
We've discussed again this pattern in a [https://wordpress.slack.com/archives/C02RP4X03/p1516038456000043 recent weckly accessibility meeting on Slack], and agreed on all the points previously discussed.
The root cause of the issue is this placeholder is visually designed to look like a clickable control. However, it's labeled just with an informative message. Since it's immediately followed by an ""Add media"" button that does the same thing, it's not clear why the placeholder should be clickable in the first place.
As pointed out in all the resources linked above, it should be either a real button (thus, the Add Media button would be redundant) or be just text, and look like just text.
" afercia
2 43149 WP-API JS Client not triggering change event when using setMeta/setMetas helpers General 4.9 normal normal Awaiting Review defect (bug) new 2018-01-23T16:49:55Z 2018-01-23T16:53:44Z "As briefly [https://wordpress.slack.com/archives/C5UNMSU4R/p1516717879000467 mentioned] on Slack earlier today the `model.setMeta()` helper method introduce in #41055 has a couple of weaknesses.
1/ The `meta` attribute is undefined when creating a new model, which makes sense, but causes `setMetas()` to silently fail at set new meta values; using `setMeta()` causes an error.
{{{#!javascript
var post = new wp.api.models.Post( { id : 1234 } );
post.setMetas( { foo : 'bar' } ); // post.attributes.meta remains undefined
post.setMeta( 'foo', 'bar' ); // TypeError: metas is undefined
}}}
2/ When the `meta` attribute is properly defined, some changes in meta values fail to trigger a change event. Provided that the above issue does not show:
{{{#!javascript
var post = new wp.api.models.Post( { id : 1234 } );
post.on( 'change:meta', console.log );
post.set( 'meta', { foo : 'bar' } ); // trigger change event
post.setMetas( { foo : 'BAR' } ); // Does not trigger change event
post.setMeta( 'foo', 'BAR' ); // Does not trigger change event
}}}
Values are correctly updated; the `change` event is just not triggered as it should.
The only way I found to make this work is to clone the `meta` attribute in `setMeta()`/`setMetas()`. As of now these methods simply retrieve the `meta` attribute using `get()` and then `_.extend()` to add/update properties, which doesn't seem enough to make Backbone consider it a change." caercam
3 43147 Introduce `esc_html_comment` and translation related functions Formatting trunk normal normal Awaiting Review enhancement new dev-feedback 2018-01-23T15:27:17Z 2018-01-25T17:53:06Z "Triggered by the following PR on Yoast SEO [https://github.com/Yoast/wordpress-seo/pull/8687 #8687] I saw the need for `esc_html_comment` functionality in WordPress.
This patch is based on the current API for formatting and escaping functions.
The implementation is based on the specifications found on the [https://www.w3.org/TR/html51/syntax.html#sec-comments HTML specifications page].
I've added unit tests to cover the situations that I could come up with." jipmoors
2 43145 Theme and Plugin Editor unable to edit PHP files for Active theme/plugin of Main Site in a Multisite system General 4.9.2 normal normal Awaiting Review defect (bug) new has-patch 2018-01-23T01:58:49Z 2018-05-18T18:25:15Z "Originally reported here: https://wordpress.org/support/topic/theme-editor-cannot-edit-php-files/
Was able to reproduce on my own multisite instance.
Editing any PHP file of the theme which is active on the ""main"" site of the multisite instance will result in a ""Something went wrong"" message.
Narrowed it down to the wp_remote_get calls (either the one to wp-admin/theme-editor.php or the one to home_url) timing out, in the $is_active section of the function wp_edit_theme_plugin_file().
This does not happen on any other theme, nor any other plugin as far as I can determine. Those edits go through fine, however you would expect them to, as other themes are not the ""active"" one, although I cannot account for why plugins would not register as ""active"" in this case. Perhaps network activated plugins are not detected as active here and thus do not trigger this code.
While the /wp-admin/theme-editor.php call does redirect to /wp-admin/network/theme-editor.php, I'm not sure of the underlying problem here. I think it may have something to do with the difference between the transients and the site_transient, but I'm been unable to narrow it down further. Reporting as a bug in case anybody else has better ideas.
" Otto42
43144 Add a language icon next to language selectors I18N 4.0 normal normal Awaiting Review enhancement new has-patch 2018-01-22T12:06:42Z 2018-03-07T15:10:12Z "The `Site Language` option on the General Settings screen can be hard to identify if the site is using a language that the user cannot understand. The `Language` option on the user's profile screen has a similar problem, although less so.
The problem is especially noticeable for users who are not familiar with the WordPress interface.
An icon should be placed next to the field name so that it's more easily identifiable as a language switcher for users who cannot understand the current language.
There is a [https://developer.wordpress.org/resource/dashicons/#translation translation icon in Dashicons] that can be used. There's also the [http://www.languageicon.org/ Language Icon] that could be an option if an icon specific to language selection is needed." johnbillion
43140 WordPress does not allow HTML tags in the Name field of Links (blogroll) General 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-21T18:07:04Z 2018-01-26T21:33:37Z "In WordPress 4.9.2, when creating a Link (i.e. the blogroll feature) it is not possible to wrap HTML tags around the text in the Name field: WordPress will simply display those HTML tags escaped on the website.
Being able to add HTML tags around the Name text is important because it allows specifying foreign-language names with the {{{}}} tag for the sake of accessibility (screenreaders etc.) and semantic markup. My blog, for example, is in English, but some of the blogs linked to in my blogroll have foreign-language titles.
WordPress already allows adding tags like {{{}}} in the Title field of new blog posts, presumably for precisely this purpose, so this feature should be made available to the Links editor as well." CRCulver
43138 Deleting intermediate image-sizes with non-ASCII file-names Media trunk normal normal Awaiting Review defect (bug) new 2018-01-21T15:44:35Z 2018-01-28T11:02:51Z "Deleting attachments intermediate image-sizes often fails in some cases where file-names are constructed with multibyte character path names.
The bug is caused when using the basename() function without setting UTF-8 locales first. It has been documented in: [https://bugs.php.net/bug.php?id=62119]
'''This patch fixes only A single instance of the described issue and should be examined more widely.'''" idofri
43132 Best integrations on the apps with WordPress.org Forum General normal normal Awaiting Review enhancement new 2018-01-19T17:31:43Z 2018-01-19T17:31:43Z Can be great if an user can open a ticket from the App, and, the App can send some diagnostic data too. matteospi
1 43131 Unable to add new users Users 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-19T14:53:08Z 2018-01-19T16:34:59Z "[[Image(Users list)]]For some reason, every time I attempt to add a user [[Image(New user)]], it removes all the users alphabetically below and inclusive of the new entry [[Image(User list post addition)]]. I cannot therefore update the extended profile or access any users under this entry. This has previously happened, so I removed the buddypress pluggin and reactivated it an this allowed me to update the entry and reinstated the missing users. Although when I have tried this work around this time, it is generating a 500 Internal Server Error.
Subsequently I have downloaded the ""Health Check"" plugin, as it has highlighted a couple of errors:
-The loopback request to your site failed, this may prevent WP_Cron from working, along with theme and plugin editors.Error encountered: (0) cURL error 28: Operation timed out after 10000 milliseconds with 0 bytes received
-Testing gears: The loopback requeshttps://core.trac.wordpress.org/newticket#t returned an unexpected status code, 500, this may affect tools such as WP_Cron, or theme and plugin editors.
I have also completed a troubleshoot, removing all the plugins. At this point I was able to add users. I think activated the gears plugin first, which then cause my site to crash out- error 500.
" initials1
43130 Add New Site: admin autocomplete search all users Administration 4.9.2 normal normal Awaiting Review enhancement new 2018-01-19T09:01:27Z 2018-01-19T09:01:27Z "When adding a new site on multisite Wordpress, the ""Admin Email"" field's autocomplete will find only users attached to the first ""site"". If the user is in Wordpress network user list but not in first site, it'll not be found." julienlusson
43127 Error with Mixed Content when using https General 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-18T23:02:45Z 2018-01-18T23:02:45Z "Hi all,
We run a microservices architecture, where we proxy inbound requests to internal services. The inbound requests are in HTTPS, but the request to the wordpress server is proxied via HTTP once inside our VPN. As a result, the service mis-identifies the protocol as https, and gives a mixed content error (we enforce all content is requested via https, so things like javascript and CSS were failing to load) and much of the site refuses to load. Would it be possible to add a parameter that would allow us to force HTTPS in all links, and disable https redirect on admin? I was able to do this with the following code edits, but need this merged in so that our solution is sustainable.
-Jeremy
=============================================
I added to wp-config.php:
define('FORCE_NO_SSL_ADMIN', TRUE);
define('FORCE_SCHEME', 'https');
In linkTemplate.php's method for set_url_scheme, I enabled the following control.
function set_url_scheme( $url, $scheme = null ) {
$orig_scheme = $scheme;
if (defined('FORCE_SCHEME') && FORCE_SCHEME) {
$scheme = FORCE_SCHEME;
} elseif ( ! $scheme ) {
...
In default-constants.php, we modify this so we don't get stuck in an infinite loop, as the https occurs through the proxy server
function wp_ssl_constants() {
if ( !defined( 'FORCE_SSL_ADMIN' ) ) {
if (defined('FORCE_NO_SSL_ADMIN') && FORCE_NO_SSL_ADMIN) {
define( 'FORCE_SSL_ADMIN', false );
} elseif ( 'https' === parse_url( get_option( 'siteurl' ), PHP_URL_SCHEME ) ) {
...
" jeremyschiff
43126 Lang File in wp-includes/js/mediaelement Upgrade/Install 4.9.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2018-01-18T19:18:43Z 2018-01-21T01:52:21Z "It appears that a Lang Folder is being added to the above resulting in a whole language list appearing. It is not contained in the downloaded 4.9.2 on WP Org but seems to occur when the site is automatically updated.
Does not appear to cause a problem just should not be there and is being reported by Wordfence and similar plugins that monitor core files
" adrianhead1
43124 Cannot read property 'action' of null General 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-18T07:31:00Z 2018-01-19T05:31:13Z In WP Backend there is a javascript error. subratamal
2 43122 customize.php fails to load with default changeset_uuid bpayton Customize 4.7 normal normal Awaiting Review defect (bug) assigned 2018-01-18T00:46:13Z 2018-01-22T18:17:53Z "I am seeing a rare condition where users are unable to load the Customizer with no specified changeset and see the message ""Cheatin, uh? This changeset cannot be further modified.""
In all cases, I am seeing two `customize_changeset` posts with the same GUID post name, one with draft status and the other with published status. When WP_Customize_Manager attempts to find a changeset to load by default, it finds the draft with the GUID, and when it attempts to load the post, it finds the published post with the same GUID and dies with the message mentioned above.
I read WP_Customizer and theorized how this could be happening but have no theory worth mentioning. Still, this seems like some kind of race condition." bpayton
1 43121 Custom HTML Widget Warning Tooltips Error Widgets 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-17T22:16:24Z 2018-01-19T14:26:14Z "I am using Custom HTML widgets in the current version of WordPress, and I have noticed an error in the display of warning tooltips within the current version of Firefox.
When I mouseover a warning icon in the Custom HTML widget, the resulting tooltip displays beneath the editor pane, making the warning text unreadable.
'''Warning Tooltip in Firefox:'''
[[Image(https://img.nettech.net/Temp/CustomHTMLWidget_WarningTooltip_Firefox.jpg)]]
The same warning tooltip appears correctly in the latest versions of Chrome and Edge.
'''Warning Tooltip in Chrome'''
[[Image(https://img.nettech.net/Temp/CustomHTMLWidget_WarningTooltip_Chrome_Edge.jpg)]]
I have not tested across themes, so for reference I am currently working within Front Page sidebars in a Genesis child theme. I have tested the same widget across Firefox, Chrome, and Edge, and only Firefox exhibits the described behavior." JosefNT
43120 HTML Tag Auto-Formatting in Custom HTML Widget Widgets 4.9 normal normal Awaiting Review enhancement new 2018-01-17T21:12:25Z 2018-01-18T01:28:52Z "As a developer using WordPress multisite to manage a stable of client websites, I have quickly become a big fan of the Custom HTML widget. The syntax highlighting combined with the removal of the auto-paragraph formatting of text widgets has provided a much friendlier interface for my daily work building and maintaining sites.
However, in addition to syntax highlighting, the latest update has also introduced another new behavior that is quickly becoming the bane of my coding workflow. Typing the closing angle-bracket at the end of any block-level HTML tag initiates an auto-formatting routine that completely derails my coding process.
For example, typing {{{

}}} or {{{

}}} automatically generates the closing {{{

}}} or {{{}}} tag after the cursor, respectively. This behavior mimics the automations of many popular IDEs, and it is a big time-saver if implemented well.
However, the current implementation in the Custom HTML widget takes the automation a step too far with block-level tags, also adding carriage returns and indentation to my code where I don't want either.
I understand that many coding best-practices prescribe this format to make code easier to read and maintain, which is true for coding in an adjustable-width IDE window or frame. But for the widget editor that's limited to a width of around 340 pixels (without accounting for padding), I prefer to organize my code into segments broken into logical blocks with whitespace between them and everything flush-left.
Currently, the contents of a typical Custom HTML widget in my environment look like this (line breaks added to approximate editor width):
{{{

Image 3 Title

Image 3 Caption

Image 4 Title

Image 4 Caption

[/su_column]
[/su_row]
[tabbyending]

}}}
Because I am using the Custom HTML widgets to build out large sections of pages within my sites, I end up having to scroll through lots of code within any single widget instance. Having a bunch of opening and closing tags on individual lines sprinkled with indents forcing extra text wraps is a pointless gesture that impairs quick-scanning and readability rather than improving it. This is especially true for sections involving deeply nested divs containing lengthy paragraph text and shortcodes.
Within the constraints of the editor, I would prefer the above code to appear in the below format (again, line breaks reflect real text-wrapping in the editor):
{{{

Image 3 Title

Image 3 Caption

Image 4 Title

Image 4 Caption

[/su_column]
[/su_row]
[tabbyending]

}}}
Because I prefer to keep my code flush left, the editor's auto-indentation for nested block-level tags keeps offsetting my closing tags and requires backspacing/deletion of both the indents and the carriage returns.
While I realize that many developers may prefer strict adherance to best-practices, I also expect those same developers ultimately prefer the ability to decide upon their own standards without having someone else assume what's best and impose those assumptions into their development environments.
I believe the best implementation of IDE features into the Custom HTML widget should involve the ability to adjust such formatting presets as they are introduced. This would allow end-users to apply such enhancements according to their individual preferences and prevent distractions from the introduction of unwelcomed ""improvements"".
Perhaps IDE preferences could be enabled through checkboxes below the editor pane for applying individual features:
- Syntax Highlighting
- Tag Completion
- Quotes Completion
- Auto-Indentation
and maybe even
- Line Numbers (to regain space in a constrained-width pane)
The editor would still perform analysis on each keystroke, but ""If Tag-Completion = false"" it could skip the tag completion subroutine, for instance.
My apologies for the verbosity of this ticket, but I wanted to fully illustrate my particular use-case.
As a frequent user of Custom HTML widgets, I am excited by the prospects of current and forthcoming enhancements, and I can't wait to see what improvements future updates bring." JosefNT
4 43119 Allow passing empty post ID to media_handle_sideload() Media 2.6 normal normal Awaiting Review defect (bug) new has-patch 2018-01-17T20:56:38Z 2018-03-15T18:47:45Z "I stumbled upon this via https://wordpress.stackexchange.com/questions/291344/why-does-media-handle-sideload-upload-to-last-months-folder.
Basically, the person was trying to run `media_handle_sideload( $file_array, $post_id = 0 )` to upload files. This works fine in so far as it calls `wp_insert_attachment()` which accepts a post ID of `0` (it's the default) so the attachment won't be associated with a specific post.
However, `media_handle_sideload()` doesn't fully support `$post_id = 0` (or `$post_id = null`, for that matter) because of the `if ( $post = get_post( $post_id ) ) { … }` condition since `get_post( 0 )` fetches the global post and overrides `$time`.
This means you cannot upload a media file and have `$time` set to today.
To reproduce:
1. Create a post with the date set to last month
1. Set this post as `$GLOBALS['post']`
1. Run `media_handle_sideload( $file_array, 0 )`
1. Notice that the upload folder will be the one from last month, not this month.
Proposed fix:
Change the condition from `if ( $post = get_post( $post_id ) ) { … }` to `if ( $post_id && $post = get_post( $post_id ) ) { … }`
Consequences:
The upload folder will point to the current month, not the date from the global post if using `$post_id = 0` or `$post_id = null`. Not a big deal IMHO." swissspidy
1 43117 Featured image -> Featured media Media normal normal Awaiting Review enhancement new 2018-01-17T20:27:49Z 2018-01-23T12:28:58Z "It would be great to use a video in the featured image section.
At the same time renaming featured image -> featured media.
" paaljoachim
1 43115 Improve plugin search results Plugins 4.9.2 normal normal Awaiting Review feature request new 2018-01-17T19:05:36Z 2018-01-17T19:05:36Z "Hi there,
I'm not sure if I post this at the right place, but being new to 'get involved' I find this to be the most direct place to share my thoughts. Maybe someone before me has suggested my request before, but I could not find existing tickets about it.
For a long time I do miss a good filtering and sorting option in the plugin repository, both on wordpress.org/plugins and in the admin plugin section. I would like to see a filter and sorting option for the following attributes:
- WP version compatiblility (tested up to ...)
- WP version required
- number of active installs -> if this is high, it must be a quite good plugin, otherwise not so many websites would use it
- in plugin repository since -> plugin can be fairly new and therefore not yet have a high number of active installs
- last updated -> to filter out plugins that are not regularly updated
- rating
I also would like to see that 'last updated' would be added to the info for a single plugin search result (where now only the number of active installs, developer and 'tested with' is displayed), so you can see right away if a plugin is well maintained or not.
I would also suggest that plugins which have not been updated or maintained at all for over a year will be marked; for example with a traffic light: orange for 'updated more than a year ago', red for 'updated more than two years ago' (and off course green for 'updated less than a year ago').
I think the least plugin writers can do is test their plugin for compatibility with each new WP version and update this information if the plugin still works fine. Maybe make this mandatory if you want your plugin to be included in the plugin reporitory?
I hope this will also encourage all plugin writers to maintain their plugins better. My goal is to separate the plugins of good quality and high developer dedication from the plugins that are less well maintained. And make this visible to users.
I'm looking forward to a response from the core developers community. Thanks!" prodefu
1 43114 FLV video - NetworkError: Exception ProgressEvent error Media 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-17T18:13:19Z 2018-01-20T22:22:27Z "Hello,
FLV doesn't work any more since last versions of Wordpress.
I have this error : NetworkError: Exception ProgressEvent error when I use this code in articles :
[video width=""640"" height=""480"" flv=""http://mydomaine.org/wp-content/uploads/2012/02/DSC_0011.flv""][/video]
and sometimes this error : ""Aucune vidéo dont le format ou le type MINE est géré n'a été trouvée""
Thank you for your help" Fred001
43113 Multiple custom item classes are returned as single string when using 'nav_menu_link_attributes' filter with Customizer preview Customize 4.9.2 normal normal Awaiting Review defect (bug) new 2018-01-17T17:38:26Z 2018-02-23T23:51:13Z "Normally the variable {{{$item->classes}}} used in a {{{nav_menu_link_attributes}}} filter function returns an array of all classes associated with an item, including custom classes defined in the menu settings. However, when using the Customizer to edit an item all custom classes will be returned as a single string. Only after the changes have been published and the page reloaded will it return the expected array.
I've attached a patch that fixes the problem but I am unsure what actually causes the bug." lrdn
1 43110 Warning: WordPress could not establish a secure connection to WordPress.org General 4.9.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2018-01-17T13:07:37Z 2018-01-24T15:05:27Z "Not sure if this is a core bug, but since the message has WordPress.org in it I thought it might have a relation with core. I have updated to 4.9.2 just today and occasionally, specially when the site is idle for some time, I am getting the following message:
''Warning: An unexpected error occurred. Something may be wrong with WordPress.org or this server’s configuration. If you continue to have problems, please try the support forums. (WordPress could not establish a secure connection to WordPress.org. Please contact your server administrator.) in /var/www/wp-projects/multibase/wp-includes/update.php on line 348''
However, if I refresh the page the message goes away and everything ""seems"" to be normal. I am on multisite setup and working at my localhost.
{{{#!php
support forums.' ),
__( 'https://wordpress.org/support/' )
) . ' ' . __( '(WordPress could not establish a secure connection to WordPress.org. Please contact your server administrator.)' ),
headers_sent() || WP_DEBUG ? E_USER_WARNING : E_USER_NOTICE
);
$raw_response = wp_remote_post( $http_url, $options );
}
}}}" subrataemfluence
2 43100 Unexpected results from wpautop General trunk normal normal Awaiting Review defect (bug) new 2018-01-16T19:01:25Z 2018-01-23T17:53:50Z "An empty paragraph will result in invalid HTML
To reproduce using default theme add `echo wpautop( '

' );` into a template file.
Expected result `

`
Actual result ``" pross
2 43098 Defining WP_UNINSTALL_PLUGIN also when the uninstall handler is registered via register_uninstall_hook() Administration trunk normal normal Awaiting Review defect (bug) new 2018-01-16T14:18:36Z 2018-02-27T21:58:34Z "At the moment, there's no way to ""know"" that the context execution is uninstallation until the uninstall hook is executed:
{{{
do_action( ""uninstall_{$file}"" );
}}}
I'd like to move the definition of `WP_UNINSTALL_PLUGIN` to be set for both uninstall handlers (the `uninstall.php` and the `register_uninstall_hook()` hook).
The fix is super simple, just moving `define('WP_UNINSTALL_PLUGIN', $file);` in `/wp-admin/includes/plugin.php` outside the `if` statement.
It's needed when a plugin need to execute some code prior to the `register_uninstall_hook()` execution that is later used within the callback.
I couldn't think of any intentional reason why it shouldn't be defined for both uninstallation methods." svovaf
6 43096 Reduce redundant calls to translate() I18N trunk normal normal Awaiting Review enhancement new 2018-01-16T04:22:09Z 2018-05-23T09:16:35Z "Profiling the default WordPress install I noticed translate functions where being called 1700+ times and many times with duplicate strings. This patch uses static vars in a few key places to avoid translating the same string multiple times. Gives about a 14% reduction in page response time and a very slight memory increase. See https://blackfire.io/profiles/compare/6b2513f0-de36-400d-9e39-2349644b3d57/graph
" superdav42
1 43095 Audit the usage of `aria-haspopup` in the admin menu Administration normal normal Awaiting Review defect (bug) new 2018-01-15T20:18:01Z 2018-02-19T16:13:29Z "In the admin menu (the one in the left sidebar, not the toolbar one) items that have a sub-menu have an `aria-haspopup` attribute. While the intent is good, I'm not sure this is a 100% appropriate usage. We've discussed this during today's accessibility team meeting and agreed it's worth investigating.
In the previous ARIA 1.0 recommendation it was clearly stated that `aria-haspopup` is meant to be used on controls that require user activation to reveal additional content. Then, in the new [https://www.w3.org/TR/wai-aria/#aria-haspopup ARIA 1.1] recommendation, the sentence ""This means that activation renders conditional content"" [https://www.w3.org/2016/04/28-aria-minutes.html#item03 was removed]. Regardless, this doesn't necessarily change things and the new values for `aria-haspopup` don't seem to suggest the current usage in WordPress is 100% correct.
What does ""user activation"" means?
The `aria-haspopup` makes perfectly sense when users of assistive technologies land on an interactive item and need to be informed that activating the item reveals additional content.
That's not the case with the admin menu. Both when tabbing or arrowing when using a screen reader, all the menu items including the sub-menu items get revealed without requiring any special user action.
In this case, the information provided by `aria-haspopup` seems pointless, if not confusing.
Only in the responsive view, the admin menu works differently and the top level items do require user activation to reveal the sub menus. Seems `aria-haspopup` should be used only in the responsive view.
We should further investigate this issue and test with assistive technologies, not only screen readers but also, for example, speech recognition software.
For reference, the major screen readers announce `aria-haspopup` this way, as of January 2018:
{{{
NVDA ""sub menu""
JAWS ""has pop-up""
VoiceOver ""Menu pop-up""
}}}
" afercia
43091 blank new-post.php Posts, Post Types 4.9.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2018-01-15T10:02:42Z 2018-01-17T05:51:57Z "After recent update we get this bug
If site language is different than english(in this case Danish), and the user have ""default site language"" as setting, and they click ""new post"" the new post page is blank
If change user language to english, then the user can create a new post" KunSoren
43085 Metabox UI rough box shadow when in closed mode Administration trunk normal normal Awaiting Review enhancement new 2018-01-14T10:30:23Z 2018-01-14T10:30:23Z "Please check the following two images and compare side by side. I've added a red mark for your convenience. The drop shadow or box shadow doesn't look neat and clean.
'''Before'''
[[Image(https://i.imgur.com/Af5eB2e.png)]]
'''After'''
[[Image(https://i.imgur.com/M1zoLfx.png)]]
Changing the following css I've gotten better result.
{{{
.postbox .hndle, .stuffbox .hndle {
border-bottom: 1px solid #eee;
user-select: none;
}
// Changing the above styles to this
.postbox:not(.closed) .hndle, .stuffbox:not(.closed) .hndle {
border-bottom: 1px solid #eee;
user-select: none;
}
}}}
Thanks
" obiplabon
43084 dashboard confuses published posts count with all posts Administration 2.7 normal normal Awaiting Review defect (bug) new 2018-01-13T23:22:05Z 2018-01-14T18:31:57Z "the following is a good first bug for new contributors, IMO!
because it's very easy to fix
https://core.trac.wordpress.org/tickets/good-first-bugs
in dashboard, in ""at a glance"" section there's a misleading link:
1. its hyper reference uri leads to list of '''all existing''' posts
/wp-admin/edit.php?post_type=post
there are currently 26 posts in my blog
2. its label is ""8 posts"" where 8 -- is the number of '''currently published''' posts
/wp-admin/edit.php?post_status=publish&post_type=post
there are currently 8 published posts in my blog
3. its icon is the pushpin. and the pushpin usually means '''sticky''' posts
/wp-admin/edit.php?post_type=post&show_sticky=1
there are currently 1 sticky post in my blog
thus, as you can see, this link confuses ""all posts (26)"" with ""published posts (8)"" AND with ""sticky posts (1)""
I know, Wordpress uses pushpin icon to indicate any post, so, maybe, I'm wrong about sticky posts.
But I'm definitely not mistaken in that you cannot label the link as ""8 posts"" and make it refer to the list of 26 posts -- it should be fixed.
Either label should be ""26 posts"" or it should go to list of published posts.
IMO, the latter choice (lead to published posts)." awardpress
1 43083 "adding ""Unlisted"" type for post visibility" Posts, Post Types normal normal Awaiting Review feature request new 2018-01-13T16:29:17Z 2018-03-02T01:27:19Z "I think there is a good reason that WP natively supported ""unlisted"" posts, in addition to PUBLIC, DRAFT and PRIVATE.
Why not WP add that feature?
btw, Private is not same as ""unlisted"".
" tazotodua
1 43081 Custom logo issue in Customizer Customize 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-13T00:05:30Z 2018-01-20T23:50:40Z "Hi,
Almost 2 years ago I've started a thread about an issue with the custom logo in customizer. Link: [https://wordpress.org/support/topic/custom-logo-issue-in-customizer/]
Until now it's not fixed.
In short, this doesn't behave as expected:
{{{

Site Title

Tagline

}}}
Once a custom logo is set, and removed again in the same session, Site Title and Tagline aren't displayed. You need to close and re-visit the customizer, to make Site Title and Tagline visible again.
It seems the custom logo stays active, after removing the logo (image) in the same session.
Guido
" Guido07111975
43080 Allow access to triggered WP_Error when using login_errors and login_messages filters General 4.9.1 normal normal Awaiting Review enhancement new 2018-01-12T21:39:59Z 2018-01-12T21:39:59Z "Hi,
There are currently 2 filters login_errors et login_messages but everything is string. As a consequence this is translated. I would be nice to add $wp_error (WP_Error) in these filters to make it even more customizable.
" jmlapam
1 43077 Misleading error when updating plugins Plugins 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-12T10:22:04Z 2018-01-12T22:28:30Z "Hi,
I am in /wp-admin/plugins.php
A plugin has a new update and I click ""Update now"". After a few seconds I get ""'''Update Failed: Could not copy file.'''""
However, when I refresh the page and I see that the plugin was updated.
After a few tests I realise that if there are Core Translation Updates and they fail(for example due to bad filesystem permissions), you will get the error mentioned above even though the plugin was successfully updated.
I would like to comment on two things:
a) The translations shouldn't get updated with any plugin update. I might NOT want to update the translations. By doing it in the background without asking me that's bad.
b) The error message shown is irrelevant to the plugin update and might cause confusion to some admins who might try to reinstall manually a plugin or do any other changes which might eventually end up breaking a site for nothing.
Thanks in advance for your time." SGURYGF
43076 current-menu-item for archive menu item on singular page Menus normal normal Awaiting Review defect (bug) new has-patch 2018-01-12T09:51:43Z 2018-01-12T09:53:04Z If I have CPT with archive and singular page and I add to menu url to archive and I go to singular page of CPT then should be add current-menu-item to menu item of archive sebastian.pisula
43074 Custom site identity Crop Image function does not work Customize 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-11T22:52:34Z 2018-01-12T07:18:30Z "Site Identity image.
After the image source is selected, crop image popup window arises.
Then the image is shown in a crop frame, but crop function does not work as crop frame does not react to mouse.
Wordpress 4.9.1
Firefox 57.0.4 64
Internet Explorer 11.192.16299.0" obermeister8080
1 43073 Undo leaves a big blank spot where content wp-view was Editor 4.9.1 normal normal Future Release defect (bug) new 2018-01-11T22:11:14Z 2018-01-17T05:19:28Z "1. Add a Wordpress audio playlist (or video playlist, or others)
2. Select and click ""x"" to remove.
3. Undo, ctrl+z.
Now there is a big blank spot... where is it?? It's there but transparent.
Tested in the Twenty Fifteen theme and another theme, so it's not the theme." programmin
1 43071 User without the ability to publish are unable to edit post status Administration normal normal Awaiting Review defect (bug) new 2018-01-11T21:46:21Z 2018-01-11T21:46:21Z "If a user is able to edit a post but unable to publish a post, they can change the post status from the `wp-admin/edit.php?post_type=post_type` page using the quick edit dropdown feature. However, if the user goes to the `wp-admin/post.php?post=ID&action=edit` page, they are unable to edit the post status.
User who are able to edit post_type should be able to do so from the post edit page." NathanAtmoz
43070 srcset attribute can be overridden but not prevented Media 4.4 normal normal Awaiting Review defect (bug) new 2018-01-11T19:07:48Z 2018-01-11T19:13:44Z In `wp_get_attachment_image()`, a `srcset` attribute can be passed to the fourth parameter to override the attribute's contents. There is no way to prevent this attribute from showing, though. An empty `srcset` attribute throws a validation error. desrosj
43069 Docs: improve documentation for register_meta() function Options, Meta APIs 4.9.1 normal normal Awaiting Review defect (bug) new has-patch 2018-01-11T16:23:29Z 2018-01-11T16:33:40Z "The documentation for the `register_meta()` function would benefit from additional clarity to help developers recognize that the `$object_type` parameter does not mean custom post type and the implications that registering the meta field applies to all objects of a type.
Within that method there are also missing default values and optional markers in the docblock as well as a backwards compatibility comment that could be more specific and useful in an inline comment.
https://developer.wordpress.org/reference/functions/register_meta/" terriann
43061 New MediaElement Player Issue General 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-10T19:23:49Z 2018-01-10T19:23:49Z "I'm having a CSS issue with the implementation of the upgraded MediaElement. I'm using the default styling and this what is rendered:
https://www.evernote.com/l/AAL0fZsZMR9MnbWuoXnV2OVATlXwABZXNrg
How do I resolve this?
" newventureswest
1 43060 register taxonomy should accept a label to affect the description under each field on the Add Tag form Taxonomy normal normal Awaiting Review enhancement new 2018-01-10T17:27:41Z 2018-01-11T00:19:08Z "Hi
When registering a custom taxonomy WordPress uses the default UI to allow content editors to manage terms in this taxonomy. The descriptions under the Tag name and Slug may in some cases not be adequate and/or require additionnal guidance. For instance when the names of tags should follow a certain convention or standard.
For instance for a Countries taxonomy we would wish to give the user information on what standard to follow (for instance ISO-3166-2).
I have attached images of what it currently looks like on the Add Tag page, and what it should look like in my opinion.
Since there are no hooks allowing to add extra information under the tag-name field on the edit-tags.php:393, I think the best place for this change would be at the time of register_taxonomy. I would suggest introducing new labels for a taxonomy which would overwrite the labels displayed under each field.
The implementation would then look something like this:
{{{#!php
__( 'Countries' ),
'labels' => array(
'name' => __( 'Countries' ),
'singular_name' => __( 'Countries' ),
'menu_name' => __( 'Countries' ),
'all_items' => __( 'All Countries' ),
'edit_item' => __( 'Edit Country' ),
'view_item' => __( 'View Country' ),
'update_item' => __( 'Update Country' ),
'add_new_item' => __( 'Add New Country' ),
'new_item_name' => __( 'New Country name' ),
// The below would be used on the edit-tags.php:393
'new_item_name_description' => __( 'This name should adhere to the ISO-3166-2 standard.' ),
'parent_item' => __( 'Parent Country' ),
'parent_item_colon' => __( 'Parent Country:' ),
'search_items' => __( 'Search Countries' ),
'popular_items' => __( 'Popular Countries' ),
'separate_items_with_commas' => __( 'Separate Countries with commas' ),
'add_or_remove_items' => __( 'Add or remove Countries' ),
'choose_from_most_used' => __( 'Choose from the most used Countries' ),
'not_found' => __( 'No Countries found' ),
),
'public' => true,
));
}}}
" mclaurent
2 43058 File search in theme & plugin editor window Plugins normal normal Awaiting Review feature request new has-patch 2018-01-10T13:39:58Z 2018-01-16T05:36:27Z "Now we have using Code mirror for updating theme/plugin files. We have also create a directory tree of theme & plugin files.
It is hard to search the file in the given directory tree. So, File search filed is useful to search particular file. This patch search `file name` & `file extensions` too." Mahesh901122
43052 Add an End action function to Color Picker External Libraries trunk normal normal Awaiting Review enhancement new 2018-01-09T08:10:03Z 2018-01-09T08:10:03Z "I need to call a function after color was selected using Color Picker...
https://make.wordpress.org/core/2012/11/30/new-color-picker-in-wp-3-5/
I want to trigger a change action that I am using into a widget after I change the color... https://core.trac.wordpress.org/ticket/42984 but the problem is I can't do this now, I can call functions when I change the color but I want '''after''' I changed, so it will be called only once.
" alexvorn2
43045 Trigger events equivalent to editor:image-edit and editor:image-update in media-image-widget.js Widgets normal normal Future Release enhancement new 2018-01-08T20:51:24Z 2018-02-23T22:37:00Z "The `wpeditimage` TinyMCE plugin has helpful `editor:image-edit` and `editor:image-update` events for hooking additional metadata onto the Image object. Here's an example:
{{{
wp.media.events.on('editor:image-edit',function(event){
event.metadata.pinterest_text = event.editor.$(event.image).attr('data-pin-description');
});
wp.media.events.on('editor:image-update',function(event){
event.editor.$(event.image).attr('data-pin-description', event.metadata.pinterest_text);
});
}}}
Although the new Image Widget reuses the `image-details` frame, it doesn't fire these equivalent events, making integration difficult. It would be helpful if the `ImageWidgetControl` implemented equivalent events." danielbachhuber
1 43043 WP Customizer checks current_user_can() too early Customize 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-08T18:56:14Z 2018-01-08T19:13:27Z "Hi all :)
On WordPress VIP, the only user role which may use Customizer is an Administrator. This is due to when the current_user_can() checks occur.
WP Customizer currently checks capabilities on the setup_theme action. https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-manager.php#L510
This means the only way to create a role/capabilities to manage Customizer settings is with one of the few hooks which run before setup_theme, i.e. muplugins_loaded or maybe plugins_loaded. However, if, like us, you're on WordPress VIP, the earliest hook to do anything is after_setup_theme, since any/all functionality must live in themes.
I would like to propose that any Customizer current_user_can() checks be moved to the after_setup_theme action. Of course this would benefit us, but more importantly, Customizer specifically allows 'theme_mod' settings (setting specific to the current theme), which infers that a theme_mod setting is registered by the theme. If a setting is registered by a theme, the theme should then also be able to determine who may view/edit that setting." jamesmehorter
43042 Ability to add Page Anchor along with changing Navigation Label in menu system (Live Preview mode) Menus 4.9.1 normal normal Awaiting Review enhancement new 2018-01-08T16:09:36Z 2018-01-08T16:09:36Z "Presently we can add a single page in the menu system and update navigation labels of each item. All of them actually point to the same page / URL.
However, it would be very useful if there is an option to add an anchor with the actual page URL along with the ability to change the navigation label. This would allow visitors to jump to a particular section of the same page but from different navigation labels.
For example, I have a page called ""About Us"". In this page I have two sections:
""Our Company"" and ""Customer Service"". In present situation I can easily add this page twice in the menu and use different labels for each, like '''Our Company''' and '''Customer Service'''. The new feature I am requesting will provide us the ability to add an anchor like `#company` and `#customer-service` with different navigation lables, which actually would get appended to the actual page URL `http://mysite.com/about-us`.
So that '''""Our Company""''' navigation label actually points to and navigates user to `http://mysite.com/about-us#company` whereas '''""Customer Service""''' link takes users to `http://mysite.com/about-us#customer-service` directly.
I think this would allow us to take more advantage of it." subrataemfluence
43039 Resize capability missing from Custom HTML widget Widgets 4.9.1 normal normal Future Release defect (bug) new reporter-feedback 2018-01-08T00:02:45Z 2018-01-08T18:19:03Z "I'm using WordPress 4.9.1 with the theme Prolio 2.6.1
I had fallen behind in updating and just updated to current versions.
I'm using Text widgets on my homepage, and the text widget editor used to allow both vertical and horizontal resizing by dragging the resize icon in the lower-right corner.
Now I can only resize Text widgets vertically!
I also started using the Custom HTML widget, as recommended.
But the Custom HTML widget is not showing a corner resize icon at all so I cannot resize it, and it is a small rectangular editing pane with a larger font than before, and very awkward to use (although it would be wonderful if I could enlarge it).
I used Firefox's Tools > Web Developer > Inspector to find the CSS for the editing window:

...

...
...

...

...

I find that I can change that last line to:

and that enables the bidirectional resize corner that I need!
But of course that only affects the running instance. I have no idea how to tweak the code so that change becomes the default.
Before I look into creating my own customized version of the Custom HTML editor, I'm wondering whether this very minor change could be incorporated into the next release of these tools, so I don't have to do that work myself, and so other people can benefit from it.
I don't actually know whether this is a request for the WP team or the Prolio team, so I'm starting with the WP team.
Thanks for your consideration,
-- Paul Tukey paul.tukey@gmail.com
" paultukey
3 43036 the_posts_pagination() - redirect URL for first page in category Posts, Post Types 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-06T20:51:56Z 2018-01-06T20:51:56Z "When you are on the second, third, etc. the page function `the_posts_pagination ()` outputs a link to the first page for the current category with a slash `/` at the end of the URL:
{{{
/category/category-1/
}}}
But when clicking on a link, a redirect to the page takes place without a slash `/` on the end:
{{{
/category/category-1
}}}
A link to the following pages from this category is displayed already without a slash on the end of the URL:
{{{
/category/category-1/page/2
}}}
Permalink at the same time on the site are configured to look like this:
{{{
/%postname%.html
}}}" webliberty
3 43033 User can not see updated Icon in editing Menu with live preview Menus 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-06T06:48:54Z 2018-02-05T14:06:38Z "Bug: User can not see updated Icon in editing Menu with live preview
Attachment for steps: https://www.screencast.com/t/jOBHlmVeUTdO
Steps:
1. Navigate to Appearance->Menus from left rail
2. Select ""Menu with Live preview""
3. Select Menu and click on 'Add Items""
4. Sect ""Pages"" and add some page, User can see that ""+"" icon is changed to Tickmark sign
5. User will remove it from menu,Now User can not see previous symbol again to add
Thanks" nilamacharya
2 43031 Menu text is shown updated in collapsed widget though user has cancelled editing text Menus 4.9.1 normal normal Awaiting Review defect (bug) new has-patch 2018-01-06T05:34:56Z 2018-01-08T15:56:58Z "Bug: Menu text is shown updated in collapsed widget though user has cancelled editing text
Steps:
Please check URL for steps: https://www.screencast.com/t/4vshm4i37G
1. Navigate to Appearance->Menus from left rail
2. Go to ""Edit Menu"" and add some menu in Menu structure at right side
3. Expand Menu tab
4. Edit Navigation Label for example from ""Home"" to ""Home test""
5. Select ""Cancel"" link , widgte is collapsed and updates text is display (which should not)
6. Again expand and check Naviogation lable is not updated inside which is proper
7. Try to edit text and now earlier updated text is removed.
" nilamacharya
1 43029 "Filter ""send_email_change_email"" is never called" Users 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-05T22:38:29Z 2018-01-05T22:38:29Z "The purpose of the ""send_email_change_email"" filter is to allow the optional suppression of the warning email sent when a user changes their email address.
However, that warning email is sent by function send_confirmation_on_profile_email() at user.php line 2623 - which gets called ''before'' the apply_filters for send_email_change_email is called by function wp_user_update() in user.php at line 1856.
So, by the time that (any) send_email_change_email filter could be called, the warning email has already been sent.
Further, function send_confirmation_on_profile_email() resets $_POST['email'] to the ''original'' email address, so function wp_user_update() is not even aware that the email address has been changed, and never calls the apply_filters for ""send_email_change_email""." flymike
3 43028 Remove numbers before month in dropdown, it makes user confused when drowdown is not opened Date/Time 3.3 normal normal Awaiting Review defect (bug) new has-patch 2018-01-05T12:01:10Z 2018-02-09T04:08:48Z "Bug: Remove numbers before month in dropdown, it makes user confused when drowdown is not opened
1. Navigate to Header from left Rail
2. Select ""Header Media""
3. Make anu changes
4. Select ""setting"" icon near ""publish"" button from top
5. Select ""Schedule"" radio button
6. Check Date Field
" nilamacharya
2 43025 wp_list_filter should filter all iterable objects General 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-04T23:09:38Z 2018-02-11T17:49:28Z "#16499 introduced an issue which requires that data sent to `wp_list_filter` is an array. What it really means is the data sent to `wp_list_filter` should be iterable _like_ an array. By permitting both arrays and objects that are Transverable we can allow for anything that decends from the `\ArrayObject` class.
While there is an `is_iterable` method we _could_ use, it's only availabile in PHP 7.1 so the attached is friendly to PHP v4.2 and above
" jarednova
3 43023 Make Core Image Handling More Extensible Media 4.9.1 normal normal Awaiting Review enhancement new 2018-01-04T21:35:41Z 2018-01-04T21:35:41Z "As we are beginning to see many new and promising formats such as WebP (#35725), APNG, and HEIF/HEVC (#42775), it is probably time to revisit all of the image-related code in the Core, providing filters and hooks so that plugins and themes can choose to support them.
Based on the work in #35725, it is clear there are a number of areas with insufficient extensibility, making it impossible for such work to be done by third-party code.
[[BR]]
'''WRAPPERS'''
`getimagesize()`: Due to various bugs and inconsistencies within PHP, direct calls to this function should be replaced with a wrapper function capable of providing filtered responses. #35725 includes this in its patch.
[[BR]]
'''FILTERS'''
Many functions include hard-coded datasets or conditions. By wrapping those in filters, third-party code can alter behavior accordingly.
* `wp_stream_image()`
* `wp_save_image_file()`
* `wp_generate_attachment_metadata()` - The extensions-by-type need to be filterable.
* `load_image_to_edit()` - The $mime_type switch needs a filterable default.
* getid3.lib.php `ImageTypesLookup()` - Types need to be filterable.
* class-phpmailer.php `_mime_types()` - Types need to be filterable.
* image classes `supports_mime_type()`
* class-wp-theme `get_screenshot()` - Filterable types.
* `gd_edit_image_support()` - Filterable responses for both conditions.
* `translate_smiley()` - Needs filterable types.
* `wp_get_image_mime()`
* `wp_attachment_is()` - Filterable extensions.
* `wp_mime_type_icon()` - Filterable test for image files.
[[BR]]
'''OTHER'''
There are additional areas that require more complicated solutions.
* `file_is_displayable_image()` - Relies on constants which may not be defined, even in cases where an image type is actually supported. Haha.
* wp-admin/includes/schema.php - $misc_exts needs to be filterable.
* class-wp-image-editor-gd `load()` - Needs a filter around the resource creation. `imagecreatefromstring()` does not work consistently depending on the GD version installed.
* class-wp-image-editor-gd `_save()` - Needs a filter to handle alternative MIME types.
* class-wp-image-editor-gd `stream()` - Needs some means of specifying alternative headers and callbacks.
* class-wp-image-editor-imagick `thumbnail_image()` - Needs some means of specifying options for different image types.
* class-wp-image-editor-imagick `stream()` - Needs a shortcut filter to allow for completely different handling. (This is a quirk of the PHP extension not always properly communicating with the system binary, leading to segfaults, etc.)
* class-wp-customize-media-control `to_json()` - Needs some method of altering the $type matching.
[[BR]]
'''ROADBLOCKS'''
Additional requirements, such as defining missing PHP constants, might not be possible by the time plugin or theme code is executed. However by the time official PHP support lands, we can probably consider adding such values to the `compat.php` file (without necessarily providing a full blessing for the filetype within the Core)." blobfolio
2 43019 Hook to validate post form data before save General normal normal Awaiting Review enhancement new has-patch 2018-01-04T13:23:07Z 2018-01-05T18:43:06Z "There doesn't seem to be a hook available to validate form data before a post is saved. In my case I'm considering using JavaScript to validate the post title, content and meta but would prefer to do this validation server side.
Can we add a hook?" henry.wright
43015 function get_previous_comments_link not working in front page Comments 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-03T11:44:16Z 2018-01-03T12:21:26Z "Hey,
function get_previous_comments_link generate wrong url in front page, but it's ok in typical page, it's because of the permalink, wordpress hasn't full permalink in front page." devlife
43013 Confirmation Email workaround Users 4.9.1 normal normal Awaiting Review enhancement new 2018-01-02T21:41:35Z 2018-01-02T21:41:35Z "This is a follow-up to #16470.
Not after support but have a question about this new addition on single-site installs. When I set new client websites up, I change the administrator email address (mine) to a non-administrator user (the client) so I don't want them having to click an email to confirm the email change. To workaround this I access wp_options via phpmyadmin and change the email address in there, but if I refresh the General Settings there is a message stating that there is a pending change TO the email address I have changed from, so I click to cancel (which leaves the new email address set).
Would just like confirmation that this method is OK for my own reasons and that no confirmation emails would be sent by doing this.
Thanks" adejones
2 43010 Attribute Name Escape Formatting normal normal Awaiting Review enhancement new has-patch 2018-01-02T17:03:09Z 2018-01-02T18:07:43Z "The HTML5 spec allows us to arbitrarily named attributes for tags, e.g. '''''data-my-arb-attr-name'''=""attr value""''. This allows for generated attribute names and thus, a need to escape to avoid potential security implications.
I have seen several occasions of developers using `esc_attr` to resolve this case, however this is far from correct - the requirements of the name of an attribute are very different to that of the value, the best example of this simply being whitespace.
The requirements of an attribute name can be found here: https://html.spec.whatwg.org/multipage/syntax.html#attributes-2
There is a need for an `esc_attr_name` function to avoid compromises in html.
I have provided a simple addition patch to wp-includes/formatting.php which should resolve this issue." joe_bopper
1 43009 Create Video/Audio Playlist hooks not working as expected Media 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-02T15:54:41Z 2018-04-12T18:06:08Z "WordPress now provides the following hooks:
https://developer.wordpress.org/reference/hooks/media_library_show_video_playlist/
https://developer.wordpress.org/reference/hooks/media_library_show_audio_playlist/
We can use these to hide the “Create Video Playlist” (and Audio) button in the media library.
These only seem to work on initial page load. The “Create Video Playlist” button still appears for me even though I'm using these filters.
To reproduce from a fresh install.
1. Set these lines in your theme functions.php
{{{#!php
add_filter( 'media_library_show_audio_playlist', function() { return false; });
add_filter( 'media_library_show_video_playlist', function() { return false; });
}}}
2. Go to wp-admin/post-new.php.
3. Click 'Add Media', notice that the playlist buttons are missing.
4. Upload a video file (I used .mov). Notice that the 'Create Video Playlist' button now appears.
This likely exists in versions earlier than 4.9.1, but this was the version I tested in." iforrest
3 43008 Switching post status from publish to draft still allows you to see it Posts, Post Types 4.9.1 normal normal Awaiting Review defect (bug) new 2018-01-02T14:18:46Z 2018-01-04T20:10:57Z "After some testing, I've found a bug regarding draft posts. I did originally think this is a security vulnerability however '''''it is not''''' because this only occurs if you're logged in and the person who saved the post as a draft.
If you have a post and save it as a draft, if you try and view that on the front-end you can see a preview, which the URL usually looks like this `http://wp.test/?p=100&preview=true` however if you try and view it using the real post URL such as `http://wp.test/test-page/` then you'll get a post not found error message.
''This is fine so far, however...''
If you publish the post and then any time afterwards change the post to a draft again, it's still accessible using the real post URL even though it's still a draft. When a post is set to a draft, in my opinion it should never be accessible through it's real URL. It should only be accessible through the 'not pretty' preview URL instead.
If you're not logged in, you won't be able to see draft posts regardless of when they were drafted, but even so, while logged in you shouldn't either. I've not dug into the code yet to see what's happening here but it doesn't seem like it's by design because it's hidden away from things like post lists and widgets etc." danieltj
43006 help wordpress-4.9.1 version General 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-31T22:35:03Z 2017-12-31T22:35:03Z Hi I have posted the latest version of WordPress-4.9.1 Filezilla but only comes across the theme Login button do not have anything please help the wordpress family good 198 years hasan09
1 43004 Keep shortcodes in the RSS summary feed General 4.9.1 normal normal Awaiting Review enhancement new 2017-12-31T11:25:13Z 2017-12-31T11:25:13Z "WordPress keeps/processes shortcodes for the full text feed, but removes them from the automatic excerpt in the summary feed.
If you use a page builder theme, everything is wrapped inside a shortcode, so the summary feed is always empty.
I think the RSS feed should always contain the actual text that is also displayed when you visit the article. So shortcode output should also be included." jpnl
1 43002 Can't order tag cloud by tag_cloud_sort filter Taxonomy trunk normal normal Awaiting Review defect (bug) new reporter-feedback 2017-12-30T07:44:48Z 2018-01-02T06:53:46Z I can't re-order tags by tag_cloud_sort filter, because the order is same with id order. yuetyeelo2855
1 43001 Page Slug and Attachment - Conflict Posts, Post Types trunk normal normal Awaiting Review defect (bug) new has-patch 2017-12-29T21:15:31Z 2017-12-29T21:26:28Z "I found problem. My attachment have post_name ""test"" and I want set for my new page post_name ""test"" and WordPress generate ""test-2"". I think that problem is with wp_unique_post_slug function in file: wp-includes/post.php:3950:
{{{
$check_sql = ""SELECT post_name FROM $wpdb->posts WHERE post_name = %s AND post_type IN ( %s, 'attachment' ) AND ID != %d AND post_parent = %d LIMIT 1"";
}}}
I attach fix" sebastian.pisula
1 42999 A Super Admin can have no caps on a /wp/v2/users/me?context=edit REST API request REST API trunk normal normal Awaiting Review defect (bug) new has-patch 2017-12-29T18:34:47Z 2018-01-10T21:15:30Z "Hi,
When testing Gutenberg, as it uses the REST API `/wp/v2/users/me?context=edit` request to get the current user capabilities I've noticed this request can return an empty object for the user's capabilities although the current user is a Super Administrator.
Steps to reproduce in a multisite config:
1. log as a super administrator.
2. create a new user from the network administration.
3. create a new site for this created user.
4. Request `/wp/v2/users/me?context=edit` on the newly created site.
I think even if a Super Admin has no role on a given site, as he can actually perform all the site's administrator actions, the site's `/wp/v2/users/me?context=edit` request should return the administrator's capabilities for this Super Admin.
I'm attaching a diff containing my suggestion to fix what i think is an issue + a unit test.
" imath
42995 Wordpress XML-RPC editComment return error 500 changing date_created_gmt XML-RPC 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-28T19:01:25Z 2017-12-30T22:01:26Z "Grettings,
This:
// Do some timestamp voodoo
if (!empty($content_struct['date_created_gmt'])) {
// We know this is supposed to be GMT, so we're going to slap that Z on there by force
$dateCreated = rtrim($content_struct['date_created_gmt']->getIso(), 'Z') . 'Z';
$comment_date = get_date_from_gmt(iso8601_to_datetime($dateCreated));
$comment_date_gmt = iso8601_to_datetime($dateCreated, 'GMT');
}
[Thu Dec 28 15:52:34.123148 2017] [php7:notice] [pid 5507] [client 127.0.0.1:39464] PHP Fatal error: Uncaught Error: Call to a member function getIso() on string in wp-includes/class-wp-xmlrpc-server.php:3533
" fpilee
42992 Menu Customizer - Inconsistent use of Tags and Format Menu Items Menus trunk normal normal Awaiting Review defect (bug) new close 2017-12-28T15:03:50Z 2018-01-04T06:57:17Z "When using the standard menu administration it does not display ""Tags"" and ""Format"" to add into menu items.
When using the menu controls in the customizer, it display ""Tags"" and ""Format"" options to appear as menu-items." monikarao
42990 Deprecate WP_UnitTestCase::_make_attachment Build/Test Tools trunk normal normal Awaiting Review enhancement new has-patch 2017-12-28T13:07:36Z 2017-12-28T13:10:46Z "In r35309, several ways of creating an attachment for an uploaded media file were consolidated into a single method, `WP_UnitTestCase::_make_attachment`.
As part of r34855, a new method, `create_upload_object`, was added to `WP_UnitTest_Factory_For_Attachment`. It contains all of the code from `_make_attachment`, but additionally it also handles the upload of the media file.
We should deprecate the `_make_attachment` helper method, and use the factory method instead. This reduces duplicate code, and makes the interface of `WP_UnitTestCase` cleaner." Frank Klein
3 42987 is_active_sidebar returns true on after plugin deactivation Widgets 2.8 normal normal Future Release defect (bug) new 2017-12-27T12:44:45Z 2018-01-26T21:12:12Z "Hi,
Steps to reproduce:
code:
{{{#!php
Sidebar is active, and it contains widget(s).
Sidebar doesn't contain any widget.
}}}
1. Add a widget plugin to the `custom-sidebar`
2. Disable the widget plugin
3. Reload the page
The page is still showing sidebar is active. and `wp_get_sidebars_widgets()` still contains the disabled plugin's widget info.
Is this something intended? Or is it a bug? " tpaksu
42982 media player issue in wordpress 4.9.x Media 4.9.1 normal major Awaiting Review defect (bug) new dev-feedback 2017-12-26T15:21:00Z 2017-12-27T11:09:01Z "after WordPress update, video/audio are not being displayed properly I am facing issues regarding media player height and width.
thanks in advance
'''Github issue Link'''
[https://github.com/mediaelement/mediaelement/issues/2469]" thrijith
42981 Sorting plugins and themes General 4.9.1 normal normal Awaiting Review feature request new 2017-12-26T09:09:56Z 2017-12-26T15:10:53Z "PLEASE - Sort themes and plugins into :
Premium
Fremium / Cripple ware
Free and fully functional
Not as described in the image (Pretty picture, preview looks nothing like it = Hours of work to make it look like the demo. I'd write a theme if I wanted the work)
Anything not updated in the last 12 months - ""Abandoned"" pile, not visible
Anything with ratings - Sort by rating - Under 3 - not visible
Not tested on latest WP version - not visible
Not tested on PhP 7 - not visible
Speed test rating - Google wants a 2 second load time for mobile. Let's have an apples for apples rating. 5 pages, 10 images, 1000 words and (say) Yoast, Wordfence, WooCommerce and 4 other common plugins.
I am sick to death of wasting hours on sifting this garbage - Make these 'Filters' and help everybody.
You tell us to update things for security reasons and some of us professionals do that.
Client sees a pretty picture then it turns into a nightmare for the above reasons and who has to fix it for free or spend hours looking for a replacement?
The login Username should not be the default Editor name. You've handed a hacker half the login.
Security - Set permissions to prevent malware spreading - in 2017, one client had malware uploaded to his site and it spread to all other sites and within site folders. WordPress should be containerised by default and SQL / Updates / changes should require 2 factor authentication to update anything (Just a 'secret password')
Yes, I know, experts can fix this. In reality, most people do not have the skills. I buy a tool and assume the manufacturer has designed it for Joe Public to use with inbuilt basic safety.
Last suggestion - A fork of WP for eCom with included carts, security etc. Google wants fast loading and WP struggles, so fork it to optimised versions :
Blogs
eCom
Membership
Versatile - Current version (as is)
and the revolutionary version - Offline. This is where the site is built offline and uploaded as a stripped down html5 flat file database version that is a speed demon static site. Lauyan.com looks promising.
Regards" grumblenz
1 42979 "Draw ""dismiss"" icon in upload errors in the error div, not after the action title" Upload trunk normal normal Future Release defect (bug) assigned 2017-12-25T15:58:42Z 2018-03-12T15:13:23Z "When an error occurs while uploading a file in the media manager, the icon to dismiss the error is (incorrectly, imho) floated near the title of the action and not with the actual error.
There is probably a larger underlying issue where the action text (e.g. ""Uploading"") is actually tied to the error (i.e. dismissing the error causes the action text to disappear) but is not visually drawn as part of the same dialog; but presumably in the case of multiple errors or when attempting to dismiss an error while another upload is underway, etc. the change suggested above should suffice.
In short, one merely seeing the error (see attached) by itself would be confused as to whether the would terminate the upload or dismiss the error, because of its layout and positioning." ComputerGuru
42978 Automatically clear file upload error messages Media trunk normal normal Awaiting Review defect (bug) new 2017-12-25T15:50:20Z 2017-12-25T15:50:20Z "When an error occurs on file upload in the media uploader while drafting a post, the error message persists after both a) another file is successfully uploaded, b) the media manager is closed and re-opened.
In both of these cases, it is my opinion that the user is best served by having the error message automatically dismissed, as
1. Its positioning is not typical of a ""historic/cumulative"" error log,
2. It may be assumed that by successfully uploading another file the error first encountered is no longer relevant, and
3. An indefinite amount of time may have passed since the error was first encountered and the media manager subsequently closed and the next time the media manager/upload div was re-opened such that the user may have completely forgotten about the error and may be confused to see a red error box and mistakenly think it is associated with some action he/she just took,
4. As a dialog, nothing about the media manager suggests that its state should persist after being closed and re-opened.
(see attachment as an example of an error)" ComputerGuru
1 42970 Add a 'rest_nonce_action' filter to the REST API REST API trunk normal normal Awaiting Review enhancement new has-patch 2017-12-23T23:22:11Z 2018-01-08T16:43:42Z "In the spirit of fully customizing the REST API, as I'm doing in my current application, some features (like the REST prefix) are customizable through filters, while the nonce name, or rather the rest nonce 'action', is not. 'wp_rest' is a bit generic and could easily have a 'rest_nonce_name' or 'rest_nonce_action' filter added in wp-includes/rest-api.php.
I believe in this regard that allowing alignment with user-defined namespaces and naming conventions would really further the extensibility of the WP REST API, especially in cases where pretty much every default (including default endpoints) are being disabled or overridden/overwritten. Thoughts?" enlightenedpie
2 42961 Rest API doesnt handle empty arrays in querystring correctly REST API 4.7 normal normal Awaiting Review defect (bug) new 2017-12-21T20:47:50Z 2018-03-22T23:47:49Z "Sending empty arrays to endpoints through Rest API is not handled correctly by WP core.
Ex.
Querystring:
mysite.com/wp-json/...?my_empty_array[]=&... get_page_permastruct() on line 356, with an if statement that tests for null $wp_rewrite. The rest of the code functions if that approach is taken.
if (!empty($wp_rewrite)) {
$link = $wp_rewrite->get_page_permastruct();
}
" wcwilson1950
1 42958 create callers for loop functions to accept post id General normal normal Awaiting Review defect (bug) new 2017-12-21T17:23:36Z 2017-12-21T17:23:36Z "I've always been surprised, why the loop functions (like `the_title`, `the_content`, `the_post_thumbnail` and etc) doesnt have ability to accept post-id as argument.
I think that the `get_.....` functions is not replacement in MANY MANY cases, whereas `the_...` functions automatically generate all the needed attributes and tags. using the `get_` function, it is hard to hardcode all those things manually.
I suggest to revise once again and why wont WP create callers, like i.e.
`_the_content($post_id, [other parameters as of now...])`
`_the_title($post_id, [other parameters as of now...])`
etc...
this will make the things much easier for developers. If you dont believe, see how hard it is to get the same result as `the_content` for specific post id (while outside of loop):
{{{
//save global variable
$target_post_id = 14;
$p=$GLOBALS['post'];
//change global variable temporarily, to deceive WP
$GLOBALS['post']=get_post($target_post_id);
//ONLY NOW call get_the_content
$content = get_the_content( $more_link_text='Read more', $strip_teaser=false );
$content = apply_filters( 'the_content', $content );
$content = str_replace( ']]>', ']]>', $content );
//restore the global variable
$GLOBALS['post']=$p;
echo $content;
}}}
this is real equivalent of `the_content` when you need to call outside of loop. Is it still arguable??
" tazotodua
42957 Usernames ending in a period generate invalid reset password links in certain email clients Users trunk normal normal Awaiting Review defect (bug) new has-patch 2017-12-21T16:51:13Z 2017-12-21T18:46:30Z "Password reset links contain the username appended to the end of the URL. If the user name ends in a period the email client has to decide if the period is part of the URL or part of the punctuation of the sentence. For example:
Gmail generates a clickable link that stops short of the final period. Outlook successfully links the entire URL." paulcline
1 42953 Created images have a larger filesize than the original Media normal normal Awaiting Review defect (bug) new 2017-12-21T12:34:42Z 2017-12-21T12:49:59Z "Images uploaded in the media library get resized to the defined sizes. However, if the image has been optimized beforehand the result can be that the generated images have a filesize larger than the originally uploaded image.
It can happen due to a very high `jpeg_quality` value for example..
This should not happen under any circumstances. Uploading optimized images is something a lot of people do for SEO purposes, and larger generated images affect that negatively.
Sometimes even if the image-size is smaller, the generated file's filesize is bigger.
One solution would be to save the image in a temp location and have its filesize checked against the original image. If the image is smaller than the original one then move to its final location. If not, then some other solution has to be found." aristath
42952 Add comments about JS removal of message query_arg Comments 4.9.1 normal normal Awaiting Review enhancement new 2017-12-21T01:20:25Z 2017-12-21T01:20:25Z "This is a follow-up to #23367.
Can someone '''please''' add some inline doc about how Javascript actually removes `&message=x` from the URL - Specifically in `/wp-admin/edit-form-advanced.php:186` (in WP 4.9.1).
As a plugin developer who looks up source code for solutions, I was wracking my brain around seeing `$_GET['message']` as the main argument for showing admin notices, but never seeing it in backend. Took unnecessarily long time to figure out it actually exists and is just hidden." davidsword
42949 wp_attachment_is() forces the page to get new instance of post Posts, Post Types trunk normal normal Awaiting Review enhancement new close 2017-12-20T17:29:31Z 2017-12-21T23:29:43Z In the wp_attachment_is function, the signature allows for the post to be passed in as either ID or object. However, if you pass and an instance of a post object in, the current code forces you to retrieve another copy of the post object. It should use the object passed in to prevent unnecessary database calls. bowlerman235
42947 REST API wrong total pages REST API 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-20T17:03:36Z 2018-03-22T18:09:19Z "When I require posts with the draft status the 'x-wp-total' and 'x-wp-totalpages' headers come with extra values ​​being that not all drafts are from the user making a request, so when I try to pick up the second page the answer comes empty.
[[Image(https://i.imgur.com/223sEE3.gif)]]" elvishp2006
42945 Not all error messages are capitalized Text Changes normal normal Awaiting Review defect (bug) new has-patch 2017-12-20T11:53:31Z 2017-12-20T11:54:18Z "Let's capitalize all of them.
I didn't touch ''class-pop3.php'' which has some more..; not sure if including ''ms-deprecated.php'' is needed here.
Related #42941" Presskopp
2 42941 "Improve options.php error ""options page not found""" Plugins 4.9.1 normal normal Awaiting Review enhancement new has-patch 2017-12-20T01:47:59Z 2017-12-23T15:39:01Z "The message generated by options.php when the options page is not in the whitelist is ""Error: options page not found"". This message is so generic that it provides the plug-in developer with no clue as to what needs to be addressed. A more useful message would be ""Error: options page X not found in whitelist.""" tdlewis77
1 42937 Success Message should display on insertion of new category in Taxonomy page Taxonomy 4.9.1 normal normal Awaiting Review enhancement new has-patch 2017-12-19T13:57:20Z 2018-04-22T17:21:24Z "When we add new category then apart from displaying a new category at the top, there should also display a success message like 'new category added successfully' same as we have in 'Add new post' Page.
[https://www.awesomescreenshot.com/image/3050291/30f92b69674d681274d708ec6d6e472b]
[https://www.awesomescreenshot.com/image/3050289/1e5164792645bf217b32b93d2f33e2bc]
" manishamakhija
42936 get_adjacent_post won't find any posts that are published in the same minute General 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-19T10:34:26Z 2017-12-19T10:34:26Z "`get_adjacent_post` won't find any posts that are posted in the same minute, even if they are technically posted before or after the other post.
This sounds silly but if you use a '''clone''' function to create multiple posts for a website, then you you can't navigate them using links created with `get_previous_post` or `get_next_post`." sheepysheep60
42933 Change from Class::method to static::method in WP_List_Table Database 4.9.1 normal normal Awaiting Review enhancement new 2017-12-19T06:39:22Z 2017-12-19T06:39:22Z "From this source code [https://core.trac.wordpress.org/browser/tags/4.9.1/src/wp-admin/includes/class-wp-list-table.php]
At the line 910.
Currently is:
{{{
$default = WP_List_Table::get_default_primary_column_name();
}}}
Change to:
{{{
$default = self::get_default_primary_column_name();
}}}
`self::` can forward static calls but `WP_List_Table::` cannot.
In case that WordPress needs to upgrade **requirement** to PHP 5.3+ it can change to `static::` call.
References:
[http://php.net/manual/en/language.oop5.late-static-bindings.php]
[https://stackoverflow.com/questions/4718808/php-can-static-replace-self]
[https://stackoverflow.com/questions/3481085/self-vs-classname-inside-static-classname-metods-in-php]
" okvee
42929 Indicate when a media file is selected as the video header Media normal normal Awaiting Review enhancement new 2017-12-18T03:50:24Z 2017-12-18T03:53:24Z "When a theme supports video headers and a video is chosen, it is not indicated as the current header media in the media library.
Site logos, favicons, and header images are already marked in the media library." desrosj
42925 register_setting backwards compatibility when function defined after registration General 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-17T15:49:28Z 2017-12-17T15:49:28Z "to make register_setting backward compatible this code is used:
{{{
if ( is_callable( $args ) ) {
$args = array(
'sanitize_callback' => $args,
);
}
}}}
so if you call register_setting with a function instead of args, and only then define that function is_callable returns false, and the function is never passed." ItayXD
42923 Add new Docs to WordPress upgrade/install classes Upgrade/Install normal normal Awaiting Review defect (bug) new 2017-12-17T11:45:02Z 2017-12-17T11:45:02Z @DrewAPicture please review the attached patch. ramiy
1 42922 Image Scaling using get_the_post_thumbnail issue in Wordpress General 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-17T08:22:37Z 2017-12-17T08:22:37Z "Issue URL - http://www.creativescripters.com/clients/testwp/uncategorized/image-resized/
I am using wordpress (self hosted) latest version, The problem is I am looking to get a thumbnail from the resized/scaled image, and when I do that wordpress returns the test-150x150.jpg i.e. Thumbnail from the original image and not the resized image which should have been test-e1513229707262-150x150.jpg
Step to reproduce the issue
1. Upload an image , Scale it (click edit on uploaded image and change width and click scale). Wordpress will rename the image and add an Suffix Id to the name so you can confirm the image have been scaled. for eg if you uploaded test.jpg after scaling image name will become test-randomstring.jpg
[![enter image description here][1]][1]
2. When I call get_the_post_thumbnail($post, 'full') I get the correct image The resized one i.e. test-randomstring.jpg
[![enter image description here][2]][2]
3. When I try to get a different size of the scaled image for eg I need thumbnail generated from the image size and I call function get_the_post_thumbnail($post, 'thumbnail') wordpress return the THUMBNAIL from actual image (the one I uploaded initially test.jpg and not the resized one test-randomstring.jpg)
Screenshot - https://i.imgur.com/sQKoZcF.png
[1]: https://i.stack.imgur.com/TTIaG.png
[2]: https://i.stack.imgur.com/T3vPE.png" rigids.php
1 42921 get_header('customheadername') is fetching the header.php even i have provided customheadername Themes 4.9.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-12-17T07:39:00Z 2017-12-20T13:44:46Z get_header() is not supporting the custom headername provided. so fetching default header.php mausamrai
4 42920 Add support for the picture element Media normal normal Awaiting Review enhancement new needs-unit-tests 2017-12-17T06:10:52Z 2018-01-18T19:42:43Z "The `` element is in the HTML standard and should be supported in WordPress (https://html.spec.whatwg.org/multipage/embedded-content.html#the-picture-element).
Similar to the `` and `` elements, the `` element can contain multiple `` child attributes, providing the browser with different formats for the same resource. Each source can have its own `srcset`, `media`, and `sizes` attributes, among others, to control which source is used under specific circumstances (such as screen width). After all `` tags are output, an `` tag is required as a fallback.
Adding support for the `` element can help in many areas. Here are a few:
- Allowing support for more modern image formats, such as SVG or WebP (https://core.trac.wordpress.org/timeline?from=2017-12-16T21%3A15%3A32Z&precision=second)
- Provides a way to solve the responsive image art direction problem (rough POC: https://github.com/desrosj/respect-art-direction).
Adding `` elements to core's output could be tricky for backwards compatibility. Themes are most likely targeting `` tags as direct children of other elements in CSS and JS. There are also a few oddities in CSS with styling the `` element.
== Proposed Solution ==
The solution I am proposing is to add `picture` to the `html5` array in registered theme support. This would allow us to encourage themes to add support and proper styling for the picture element when they are ready. When themes adopt this feature, future releases of WordPress (or plugins) could add `` elements to `` elements as more performant formats are supported. Sites would receive all of the benefits of the new enhancements without any updates needed from themes.
== Unsolved ==
Hardcoded images in post content and widgets would not be solved with this approach. They would continue as hardcoded `` tags. This may not be a bad thing but may require additional CSS rules in themes to handle correctly.
Browser support for the `` element is very good. According to https://caniuse.com/#feat=picture, the only modern browser lacking support is IE11.
== Other notes ==
Tackling this may also be dependant on #29807.
== Initial Patch ==
My initial incoming patch adds documentation for the `html5` `picture` support for themes and wraps the `get_image_tag()`/`wp_get_attachment_image()` `` output in a `` element." desrosj
5 42918 Replace intval(), strval(), ... function calls with type hints General trunk normal normal Awaiting Review enhancement new has-patch 2017-12-16T21:44:54Z 2017-12-17T17:38:10Z "PHP's `intval()`, `strval()`, `floatval()` and `boolval()` are from PHP 4 ages. PHP 5 and later has the type hinting pattern (e.g `(int) $var`) that is ~6x faster than their function-call counterpart.
There are over 250 such calls, and I'll upload a patch to replace them with type hints. The patch itself is large, but because `intval()` and `(int)` are identical in usage, I hope you can review it. The test suit passed (https://travis-ci.org/Ayesh/wordpress-develop/builds/317469175).
I have not changed anything in third party libraries (such as random_compat).
Thank you. " ayeshrajans
42916 Terms for taxonomy with show_in_quick_edit = false still load in inline data Administration 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-15T20:16:59Z 2017-12-15T20:16:59Z "The show_in_quick_edit property was introduced for taxonomies in 4.2 with changeset:
https://core.trac.wordpress.org/changeset/31307
This changeset removed the taxonomy from the inline edit form, but the terms for the taxonomy are still being populated in the data for each row via the `get_inline_data()` function, which only respects `$taxonomy->show_ui`.
One reason people may want to remove a taxonomy from quick edit is for performance reasons, when the number of terms fore each post are huge. However, the terms are still being loaded, and the page can take a huge performance hit.
For example, I have a custom post type where each one is assigned thousands of zip codes via a custom taxonomy. I set show_in_quick_edit to false on the taxonomy, but the post listing was still loading very slow. I looked at the source code, and saw thousands of zip codes being rendered in a hidden div on each row." jazbek
42915 Don't load admin dashboard widgets if they're not shown Administration trunk normal normal Awaiting Review enhancement new 2017-12-15T19:55:41Z 2017-12-15T23:46:30Z "I'm not sure how doable this is given that #23910 was closed, but some plugins load slow admin dashboard widgets that use HTTP API requests or else involve heavy db lookups and processing. (Yes, these plugins should be designed better.)
Since this is the admin dashboard and not some other component that is heavily modified and reconfigured such as the post page and since #23910 was closed, would it be possible to require a page reload when an admin component is enabled (so that the page can be re-requested while calling the widget routine) instead of preloading all widgets and then simply hiding the unshown dashboard elements?
Or perhaps #23910 could be revisited with consideration given to non-stock admin dashboard widgets that are not as ""no big deal"" as the ones that WP ships with out of the box." ComputerGuru
42913 Scroll widgets and widget containers independently in admin ui Widgets trunk normal normal Future Release enhancement new 2017-12-15T18:31:30Z 2018-05-03T19:50:32Z "A ""regular"" WordPress installation with a few plugins providing widgets can easily result in a situation where the height of the ""available widgets"" div on the left can be significantly larger than the height of the ""available widget containers"" div on the right, as a result of which one may need to scroll down significantly to reach the desired widget, then scroll back up _while dragging_ to place the widget in the desired container.
If the div on the right were to be configured with {{height: 1vh; overflow-y: scroll}} and then turned into fixed (?) position div, it would remain on-screen while the user scrolled through the list of available widgets, such that installing a new widget would only require scrolling to find the widget in question, and at no point would it be necessary to drag and scroll simultaneously (which, while frustrating, is easy enough on a desktop... but with a touchpad it becomes quite the challenge).
On further reflection, it might actually be easier and less hacky to assign both the left and right divs a height of 1vh (and perhaps throw in a {{min-height}}) and {{overflow-y: scroll}}, then there's no need for anything but the default positioning. Both containers would scroll independently, and no need to drag and scroll.
Attaching a video of the current experience." ComputerGuru
42912 JavaScript Error with Emoji Script Emoji normal normal Awaiting Review defect (bug) new 2017-12-15T15:31:08Z 2017-12-15T15:31:08Z "In rare cases, I get the following error after logging in, but can't force it to reproduce so I will wait sometimes a day or more until it happens again:
Failed to execute 'observe', parameter 1 is not of type 'Node' in this line:
https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/wp-emoji.js#L116
{{{#!php
.observe( document.body, {
}}}
" Presskopp
42911 A parameter is missing in wp-admin/menu.php comments Administration trunk normal normal Awaiting Review defect (bug) new has-patch 2017-12-15T15:23:47Z 2017-12-15T15:25:39Z "The parameter ""Page title"" is missing." ajoah
2 42910 Default Post Format doesn't apply on post created from Quick Draft Post Formats 4.9.1 normal normal Awaiting Review defect (bug) reopened has-patch 2017-12-15T09:09:31Z 2018-04-15T07:24:06Z "Default Post Format doesn't keep selected while submitting posts using Quick Draft option of dashboard.
'''Steps To Reproduce:'''
1. Login into the WordPress admin
2. Navigate to the Settings > Writing
3. Change the Default Post Format to any format
4. Clicked on ‘Save changes’ button
5. Now navigate to the Dashboard
6. Inside Quick Draft block Add post title and description and Clicked on ‘Save Draft’.
7. Now check the post format of added post.
Note: ''it is working after 2-3 attempt but when you again change the post format then it will not work as expected.''
'''Expected result:''' default post format should be applied on post created from ""Quick Draft"" option." aiyaz
42907 Meta Queries: support ordering by meta_value but still including items without that key Query trunk normal normal Awaiting Review enhancement new 2017-12-14T21:54:48Z 2017-12-15T22:37:58Z "Consider this scenario:
- You want to order a query's results by `meta_value` of a particular `meta_key`.
- Not all items have that key/value pair set.
- You want to still include those items in the results.
- You want them to be ordered as if the `meta_value` is `NULL` (or `0` if using `meta_value_num`).
There is currently no way to do this. (But it is a desired feature, see [https://wordpress.stackexchange.com/questions/28409/way-to-include-posts-both-with-without-certain-meta-key-in-args-for-wp-query 1] [https://wordpress.stackexchange.com/questions/102447/sort-on-meta-value-but-include-posts-that-dont-have-one?noredirect=1&lq=1 2] [https://stackoverflow.com/questions/17016770/wordpress-order-by-meta-value-if-it-exists-else-date 3].)
If you don't care about the items that don't have the meta key set being included, then you can use `compare` => `EXISTS`.
{{{#!php
'meta_value',
'meta_query' => array(
array(
'key' => 'test',
'compare' => 'EXISTS',
),
),
)
);
}}}
However, that won't work if we want to include results where the key/value pair doesn't exist.
A workaround is to do something like this:
{{{#!php
'meta_value',
'meta_query' => array(
'relation' => 'OR',
array(
'key' => 'test',
'compare' => 'EXISTS',
),
array(
'key' => 'test',
'compare' => 'NOT EXISTS',
),
),
)
);
}}}
This approach solves the problem of the items with no key/value pair not being included. However, it does not order those items in the results reliably. Instead of the `meta_value` being interpreted as `null` (which we might expect), the database will choose another `meta_value` entry for that item to order that item based on.
My proposal is to add a `NONE` option for `compare`, so that it would be possible to achieve the desired ordering with a query like this:
{{{#!php
'meta_value',
'meta_query' => array(
'relation' => 'OR',
array(
'key' => 'test',
'compare' => 'NONE',
),
),
)
);
}}}
This would result in a query that included a `LEFT JOIN` on the meta table for that `meta_key`, but did not include any conditions in the query. (This is basically a `NOT EXISTS` query but without the `ID = NULL` requirement, so that it is just a left join and not a left outer join.)
When using `meta_value_num` in particular though, ordering by `NULL` may not be desirable (those results will be after all other results); `0` may be preferred as the imputed value (consider a case when negative values are present). To make this possible, I suggest allowing the clause to also specify a `default` value, which will be used in the `ORDER BY` clause with `COALESCE`.
Initial patch forthcoming." jdgrimes
1 42902 CSS bug in mediaelement Media 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-14T16:59:32Z 2018-01-10T19:25:51Z "I have noticed a weird css bug in the css for the internal HTML5 player.
It seems that the margin is wrong, and the height is set to 100% for some reason.
See provided screenshot:
[[Image(https://i.imgur.com/uK3pznY.jpg)]]
This bug shows in both Firefox and Google Chrome." skoen
4 42900 Add gender field to user profile for use in translations I18N trunk normal normal Awaiting Review enhancement new has-patch 2017-12-14T13:14:27Z 2017-12-21T13:51:18Z "See #42725 for more background.
'''What this solves'''
To be able to properly translate numerous terms across the WP codebase, translators to some languages require knowledge of the gender of the user being referenced in the string.
Adding an optional field to the user profile will enable the extension of WP's translation functions to support gender variations (see #42725)
'''What's included'''
- A new user profile field, and a matching get_user_gender()
- Unit tests for get_user_gender()
'''Gender/Pronouns - How the field was named'''
The word ''gender'' has a lot of connotations - but it's used here in the grammatical sense - see [https://en.wikipedia.org/wiki/Grammatical_gender Grammatical Gender on Wikipedia].
When presented to the user, we ask what their preferred ''pronoun'' is, since that's probably the easiest way to relate to it. The wording around the field was inspired by Wikipedia's gender user profile field.
'''Screenshot'''
[[Image(https://cldup.com/LAj-feF0TI.png)]]
" yoavf
3 42897 Hard deprecate functions deprecated before WP 3.7.0 General normal normal Awaiting Review defect (bug) new needs-unit-tests 2017-12-13T21:11:36Z 2017-12-14T23:50:03Z "There are several of soft deprecated functions in `wp-includes/deprecated.php`.
It's safe to hard deprecate those listed as deprecated prior to the introduction of automatic updates in version 3.7.
Several tests will need to be removed, others will need to be modified to use the non-deprecated equivalent when using pre-3.7 deprecated functions to test functions deprecated in 3.7 or later.
The initial patch removes the functions but needs a refresh to modify the tests." peterwilsoncc
42895 Plugin Search Feature Autocomplete Not Usable General 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-13T18:53:47Z 2017-12-13T18:53:47Z When searching for a plugin using the add plugin tool and performing a search using the search box, the autocomplete drop list keeps flashing on and off too fast to click anything. This seems like it may be a result of the search dynamically updating as I'm typing, but this behaviour makes it impossible to use the autocomplete list which in a recent search contained the exact name of the plugin I was looking for, whereas the main search was not yet narrowed down enough to contain that plugin. When I would try to click the term to quickly get to that plugin, the list would disappear and not reappear until I'd start typing again, at which point, the screen would refresh, once again removing the autocomplete list. RadiantFreedom
42892 save_post_customtype not firing on quick edit General 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-13T13:37:31Z 2017-12-13T21:16:16Z "save_post_customtype not firing on quick edit submit.
Had to change to save_post and add check for post type in it..." dangerd512
5 42883 Use sargable queries for date-based lookups for posts Query 3.7 normal normal Future Release enhancement new dev-feedback 2017-12-12T16:17:14Z 2018-03-14T20:23:11Z "Related to #41054 but a very specific and actionable, high-impact instance is the fact that the WordPress lookup for permalinks involving dates is not sargable.
For a bog-standard permalink structure %year%/%slug%/, WP generates the following query:
{{{
SELECT wp_posts.*
FROM wp_posts
WHERE 1=1
AND ( YEAR( wp_posts.post_date ) = 2017 )
AND wp_posts.post_name = 'tahoma-vs-verdana'
AND wp_posts.post_type = 'post'
ORDER BY wp_posts.post_date DESC
}}}
This runs (as a cold query) in ~0.075 seconds on a dedicated (and overpowered) MariaDB 10 instance on a pretty small WordPress DB. While indexes exist for all the fields matched against in the query, the use of {{{AND ( YEAR( wp_posts.post_date ) = 2017 )}}} cannot be matched against the database because MySQL/MariaDB is not intelligent enough to optimize that constraint.
The ""same"" query adjusted to make the match against {{{post_date}}} sargable does the same in ~0.034 seconds (half the time):
{{{
SELECT wp_posts.*
FROM wp_posts
WHERE 1=1
AND wp_posts.post_date >= DATE(""2017-01-01"")
AND wp_posts.post_date < DATE(""2018-01-01"")
AND wp_posts.post_name = 'tahoma-vs-verdana'
AND wp_posts.post_type = 'post'
ORDER BY wp_posts.post_date DESC
}}}
The same would apply for permalinks that reference the month and day, of course." ComputerGuru
4 42879 Invent a “Recommended Tools” section Administration normal normal Awaiting Review defect (bug) new dev-feedback 2017-12-12T14:45:58Z 2017-12-13T08:22:52Z "We have recommended plugins and themes, and while most tools are just plugins in disguise, the importers have had the limelight for a bit too long.
There are a bunch of handy WordPress tools that deserve some attention, and a dedicated box/page/something under the Tools menu in WP Admin would help bring attention to them." johnjamesjacoby
2 42875 /var/www/html/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php on line 328 REST API 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-12T04:02:20Z 2017-12-12T06:16:12Z "Getting the error:
Undefined index: items in /var/www/html/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php on line 328
The context of that line is that the variable is determined to be an 'array', but then gets indexed by the string 'items', which is not in the apparently associative array of associative array (?).
Apparently, some people trigger this, and some don't." perrywagle
42874 mediaelement-and-player.min.js javascript errors on Add New Post Media 4.9.1 normal normal Awaiting Review defect (bug) reopened 2017-12-11T20:08:41Z 2018-03-25T13:42:30Z "I am getting javascript errors on the Add New Post page after upgrading to 4.9.1. I've seen other tickets with similar errors, but the solutions do not seem to help. I have disabled all plugins, set the theme to twenty-twelve, and the language is set to U.S. English. The errors are preventing being able to switch between text and visual editors.
{{{
mediaelement-and-player.min.js Failed to load resource: the server responded with a status of 404 (Not Found)
load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,moxiejs,plupload&ver=4.9.1:9 JQMIGRATE: Migrate is installed, version 1.4.1
mediaelement-and-player.min.js Failed to load resource: the server responded with a status of 404 (Not Found)
mediaelement-migrate.min.js:1 Uncaught ReferenceError: mejs is not defined
at mediaelement-migrate.min.js:1
at mediaelement-migrate.min.js:1
load-scripts.php?c=1&load[]=hoverIntent,common,admin-bar,heartbeat,autosave,suggest,wp-ajax-response,jquery-color,wp-lists,jquery-ui-core,jquery-ui-widget,j&load[]=query-ui-mouse,jquery-ui-sortable,postbox,jquery-ui-position,jquery-ui-menu,wp-a11y,jquery-ui-autocomplete,tags-suggest,tags-box&load[]=,underscore,word-count,post,editor-expand,thickbox,shortcode,backbone,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaeleme&load[]=nt,wp-api-request,media-views,media-editor,media-audiovideo,mce-view,imgareaselect,image-edit,svg-painter,wp-auth-check,editor,q&load[]=uicktags,wplink,media-upload,wp-embed&ver=4.9.1:449 Uncaught TypeError: b(...).not(...).filter(...).mediaelementplayer is not a function
at HTMLDocument.a (load-scripts.php?c=1&load[]=hoverIntent,common,admin-bar,heartbeat,autosave,suggest,wp-ajax-response,jquery-color,wp-lists,jquery-ui-core,jquery-ui-widget,j&load[]=query-ui-mouse,jquery-ui-sortable,postbox,jquery-ui-position,jquery-ui-menu,wp-a11y,jquery-ui-autocomplete,tags-suggest,tags-box&load[]=,underscore,word-count,post,editor-expand,thickbox,shortcode,backbone,wp-util,wp-backbone,media-models,wp-plupload,wp-mediaeleme&load[]=nt,wp-api-request,media-views,media-editor,media-audiovideo,mce-view,imgareaselect,image-edit,svg-painter,wp-auth-check,editor,q&load[]=uicktags,wplink,media-upload,wp-embed&ver=4.9.1:449)
at i (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,moxiejs,plupload&ver=4.9.1:2)
at Object.fireWith [as resolveWith] (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,moxiejs,plupload&ver=4.9.1:2)
at Function.ready (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,moxiejs,plupload&ver=4.9.1:2)
at HTMLDocument.K (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,moxiejs,plupload&ver=4.9.1:2)
}}}
Any help you can provide is appreciated." bluesaphyer
42873 Customize: Allow themes to be installed when SFTP credentials required Customize 4.9 normal normal Future Release defect (bug) new has-patch 2017-12-11T19:07:31Z 2018-01-15T18:46:31Z "Split out from #42184.
Next steps:
- Revert [41997]
- Use [https://core.trac.wordpress.org/attachment/ticket/42184/42184.2.diff 42184.2.diff]
- Fix the two known bugs: incorrect labels after cancelling the modal, and fix broken buttons after cancelling the modal
Note that with [https://core.trac.wordpress.org/attachment/ticket/42184/42184.2.diff 42184.2.diff], SFTP appears to work as expected. The only issues are with canceling the modal, which happens much more in testing than in practice. [41997] seems like an overreaction to the minor bugs that we need to track down with that, which may seem worse than they are because they are more apparent in a testing workflow than in real usage. Either way, the fixes for that should not be particularly difficult. I'm not planning on working on this issue further, so someone else can take it on." celloexpressions
42872 Customize: Improve display of theme tag filters on mobile Customize 4.9 normal normal Future Release defect (bug) new 2017-12-11T19:04:32Z 2017-12-11T19:04:32Z "Split out from #42212.
The filter bar disappears on screens shorter than a magic number (or narrower than a different, also magic number), unless you scroll all the way up to the top (quite difficult with one-column infinite scroll of themes). I don't happen to use this feature on any devices that would be affected by this problem, but the experience is quite subpar for those users currently. I'm guessing there might be some issues with CSS caching in the above screenshots, or, those that worked on the previous changes in this ticket may have a better idea of why certain browsers don't like something here. Probably worth exploring before 4.9 release if anyone is able to do that, though." celloexpressions
1 42855 Add ability to filter header, sidebar, searchform, footer and template_part file paths Themes normal normal Awaiting Review enhancement new has-patch 2017-12-09T21:47:03Z 2018-02-28T22:20:08Z "I've seen several tickets that appear related but are either dead or include bigger changes compared to what I'm proposing (the most relevant being #21062).
My proposal (including patch):
1. Introduce `get_template_part_hierarchy( $slug, $name = null );`.
1. Update `get_header()`, `get_sidebar()`, `get_search_form()`, `get_footer()` and `get_template_part()` to use the new function.
1. Add a `template_part_{$slug}_template_hierarchy` filter to the new function so all 5 general template functions' results are filterable.
What these changes achieve:
1. Provide a way to filter the location of header.php, sidebar.php, searchform.php, footer.php and any file loaded by `get_template_part()`
1. Reduce code duplication (all metioned functions had the same $slug + $name logic to create a $templates array)
Also, @MikeSchinkel has mentioned a few benefits and arguments for why such a filter is beneficial:
https://core.trac.wordpress.org/ticket/21062#comment:19" atanasangelovdev
1 42851 Problem with video height since 4.9 Media 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-09T12:02:55Z 2018-01-02T23:19:13Z "I have a video on a page and after updating to WP 4.9.1 the following element gets a height of 0px:

The result is that the video area shows just the controls and nothing more (see attached screenshot on the left) .
I can fix this with workarounds via CSS like styling mejs-container and mejs-mediaelement (see attached screenshot on the rigth) but that's a hassle for the responsive versions.
Anyone elese facing these problems?
(P.S.: I'm not an expert AND a German, so forgive me for dumb questions and bad writing …)
" vhcrossmedia
2 42849 Custom HTML Widget: Allow user to be able to bypass lint errors to save Widgets 4.9 normal normal Future Release feature request new 2017-12-09T00:41:41Z 2018-03-14T21:11:53Z "In the custom HTML widget I have some div ids that are the same, and for some reason I can't save the edited widget after updating to 4.9. I would like an ignore button to be able to save the content inside a widget, especially the custom HTML widget. I don't want WordPress' brand new HTML checker feature to override code that is working completely fine.
Would it be possible to do that, or make it so that you can at least checkmark something to be able to save the widget.
The error it is bugging me about is this:
{{{

}}}
Because I have two or more widgets using the same formatting it actually wants me to change them, and in that case break the formatting just to please itself. I have made websites for over 20 years, I don't need a WordPress feature «for dummies» to tell me how to write my HTML code.
" skoen
42848 Twenty Seventeen: Pre-sized Header Media not used Bundled Theme 4.8.3 normal normal Awaiting Review defect (bug) new 2017-12-09T00:13:00Z 2017-12-13T21:12:05Z "Theme: Twenty Seventeen
Version: current
The theme customizer has an option to add Header Media and recommends dimensions of 2000 x 1200 pixels. When images are uploaded, WordPress automatically creates a size 2000 x 1200 pixel.
The bug
When adding a new header image in the customizer, sizing of the original is still required, i.e. it does not automatically choose the pre-sized 2000 x 1200 image.
Steps to replicate:
1. Upload an image. Login to your FTP space and you will see a file sized to 2000 x 1200.
2. Go into customizer, Header Media, Add new image, select the one you just uploaded. Note that it will require you to size it to 2000 x 1200." madriverweb
1 42847 Twenty Seventeen: Social Menu creates code bloat Bundled Theme 4.8.3 normal normal Awaiting Review defect (bug) new 2017-12-09T00:02:46Z 2017-12-11T04:18:40Z "Theme: Twenty Seventeen
Version: current
The theme has an option to make a social menu.
The Bug
When using the social menu, 150+ lines of code (svg defs) are rendered in source code just above the closing body tag. This code is bloated with all the icons not selected, i.e. about 146 lines not needed when only two icons used.
Steps to replicate:
Add one or more custom links (Facebook) to social menu. Then look at rendered source code." madriverweb
1 42839 wp_remote_post should support multipart uploads HTTP API trunk normal normal Awaiting Review feature request new 2017-12-08T13:49:32Z 2018-01-03T00:34:17Z Currently `wp_remote_post` doesn't support multipart uploads (file uploads). Because of this many plugin authors need to workaround this by implementing their own way to upload files remotely. calin
42838 Manipulating uploads and images can break when using stream wrappers General trunk normal normal Awaiting Review defect (bug) new 2017-12-08T12:30:05Z 2017-12-08T12:30:05Z "When using PHP stream wrappers for storing uploads into object storages (like S3 or Google Cloud Storage) some things break because in this context a directory merely a path which ends in a '/'.
PHP's builtin `dirname` always returns the path without the trailing slash. On regular filesystems this is not a problem since `a` and `a/` are equivalent, but in the context of object storages this pose some issues.
I'm attaching a patch which always add a trailing slash when the code expects to work with directories." calin
2 42835 " for paged static front-page is wrong" joostdevalk Canonical trunk normal normal Awaiting Review defect (bug) assigned 2017-12-08T08:44:03Z 2017-12-08T09:37:54Z "Hello,
I have a website with custom paging on my static front-page. I use {{{page}}} slug to handle paging, because without the slug I get 404 error, but I noticed that there is no slug present in {{{}}} URL generated by WordPress.
For example: Page at {{{http://example.com/page/2/}}} has {{{}}}, but as said above, {{{http://example.com/2/}}} serves a 404 page." chesio
42834 Doc mismatch between developer. and codex., codex appears to be more correct Themes trunk normal normal Awaiting Review defect (bug) new 2017-12-08T02:35:57Z 2017-12-08T07:35:19Z "I’m looking at some code that uses the switch_theme hook. The docs are quite different between the (current)[https://developer.wordpress.org/reference/hooks/switch_theme/] docs and the old (codex)[https://codex.wordpress.org/Plugin_API/Action_Reference/switch_theme].
Specifically, the old version specified that switch_theme is best used for things that should happen when a theme is *deactivated*, and actions related to the new theme should be on after_switch_theme. The new docs don’t make the distinction, but the code hasn’t changed since like 4.5. I'm wonder whether developer.wordpress.org has the most correct info?" kluny
2 42833 Wordpress forces non-ssl login in described circumstance even though FORCE_SSL_ADMIN is set in wp-config Administration 4.9.1 normal normal Awaiting Review defect (bug) new 2017-12-07T19:32:39Z 2017-12-07T19:32:39Z "Wordpress provides an http login page in this circumstance:
1. Put the following in wp-config.php: define('FORCE_SSL_ADMIN', true);
2. Log into your Wordpress site via wp-login.php with an admin login.
3. Click Visit Site (home icon) at the top of the page.
4. Open a new brower tab.
5. Log into your Wordpress site in the new tab via wp-login.php.
6. Go back to previous tab.
7. Click on Edit Page.
It then displays the login box with http instead of https. (Ideally it would not require a new login at all, but instead would use the session from the new tab.)" geomouchet
42830 Automatic List coding error TinyMCE 4.9.1 normal normal Future Release defect (bug) new 2017-12-07T14:48:55Z 2018-01-16T13:31:42Z "With TinyMCE Advanced Version 4.6.7 occurs an error in coding while switching between visual and text editor
Step 1) writing in visual editor and assigning listing to boh lines:
{{{
* topic 1
* topic 2
}}}
Step 2) results in corrct coding in text editor
{{{

topic 1

topic 2

}}}
Step 3) insrting a break and a space in the visual editor after “topic 1”
{{{
* topic 1
* topic 2
}}}
Step 4) and switching to the text editor gives also a correct code, even so the “ ” is deleted:
{{{

topic 1

topic 2

}}}
Step 5) but switching afterwards back to the visual code results in a weard coding and the text editor has following to show:
{{{

topic 1

topic 2

}}}
These works always like this with the mentioned steps above.
" Wordaspect
1 42829 Debugging image uploads with wp_generate_attachment_metadata Media 4.9.1 normal normal Awaiting Review enhancement new 2017-12-07T14:24:22Z 2017-12-07T14:24:22Z "Because of the if statement declared in image.php on line 181 ([https://core.trac.wordpress.org/browser/tags/4.9/src/wp-admin/includes/image.php#L181]) it seems impossible to retrieve the error message, what is supplied by the wp_upload_bits() function.
Please return this message or implement a new function what verifies what the error messages are trying to inform the user about." Fleuv
1 42826 Change get_oembed_response_data to apply filters to title Embeds normal normal Awaiting Review enhancement new 2017-12-07T12:42:11Z 2017-12-07T12:45:08Z "The function get_oembed_response_data in wp-includes/embed.php outputs the title using
{{{
$post->post_title
}}}
This is a problem when the title includes special tags. For example, the very popular plugin qTranslateX (https://fi.wordpress.org/plugins/qtranslate-x/) does this to manage multilingual content. In this case, the function should use this to output the title:
{{{
apply_filters('the_title',$post->post_title)
}}}
The oembed content overrides the og tags. This is a problem for example when sharing a link to LinkedIn.
So here would be the new get_oembed_response_data function:
{{{
function get_oembed_response_data( $post, $width ) {
$post = get_post( $post );
$width = absint( $width );
if ( ! $post ) {
return false;
}
if ( 'publish' !== get_post_status( $post ) ) {
return false;
}
/**
* Filters the allowed minimum and maximum widths for the oEmbed response.
*
* @since 4.4.0
*
* @param array $min_max_width {
* Minimum and maximum widths for the oEmbed response.
*
* @type int $min Minimum width. Default 200.
* @type int $max Maximum width. Default 600.
* }
*/
$min_max_width = apply_filters( 'oembed_min_max_width', array(
'min' => 200,
'max' => 600
) );
$width = min( max( $min_max_width['min'], $width ), $min_max_width['max'] );
$height = max( ceil( $width / 16 * 9 ), 200 );
$data = array(
'version' => '1.0',
'provider_name' => get_bloginfo( 'name' ),
'provider_url' => get_home_url(),
'author_name' => get_bloginfo( 'name' ),
'author_url' => get_home_url(),
'title' => apply_filters('the_title',$post->post_title),
'type' => 'link',
);
$author = get_userdata( $post->post_author );
if ( $author ) {
$data['author_name'] = $author->display_name;
$data['author_url'] = get_author_posts_url( $author->ID );
}
/**
* Filters the oEmbed response data.
*
* @since 4.4.0
*
* @param array $data The response data.
* @param WP_Post $post The post object.
* @param int $width The requested width.
* @param int $height The calculated height.
*/
return apply_filters( 'oembed_response_data', $data, $post, $width, $height );
}
}}}
" mheikkila
1 42825 [embed] shortcode - oembed_cache not being updated when $cached_recently is false Embeds trunk normal normal Awaiting Review defect (bug) new 2017-12-07T12:32:01Z 2017-12-07T18:19:54Z "For my plugin ( oik ) I developed a Shortcode help facility that shows examples of my shortcodes, syntax etc. It also shows examples of the WordPress core shortcodes.
For [embed] it uses a YouTube URL
[embed width=""480"" src=https://www.youtube.com/watch?v=nH228-XQ-A8]
During PHPUnit testing in multiple environments I found I was getting different results. In one environment the content of oembed_cache was
{{{
}}}
In other environments I was getting a different result.
{{{
}}}
Note: The shortcode expansion is being performed in wp-admin with no global post.
Trace analysis of the `shortcode` method in shortcodes/class-wp-embed.php indicates
that the `$cached_post_id` is being set by `find_oembed_post_id`, which means that `$cache` is set to the content. But the post_modified_gmt of the first example is 25th November; so `$cached_recently` is false.
Since `$this->usecache` is initially set to true then the `$cached_recently` logic is ignored and the route taken is to apply the first 'embed_oembed_html' filter then return.
The subsequent updating doesn't kick in.
== Partial fix ==
It doesn't look at all logical but setting `$this->usecache=false` before the return of `$oembed_post_id` in `find_oembed_post_id` partially resolves the problem.
However, since there's no further checking of `$cached_recently`, this happens every single time. Obviously, more work is needed to update out of date cached items.
This is a follow on to #34115" bobbingwide
42822 CodeMirror: HTML attributes values hints not fully operable with a keyboard Widgets 4.9 normal normal Future Release defect (bug) new 2017-12-07T09:38:16Z 2017-12-18T16:04:25Z "To reproduce, add an HTML widget either in the Widgets screen or in the Customizer:
- start typing a HTML tag, for example ""New menu to actually upload any files. The error happened in all Wordpress versions I tested (since 4.8.3).[[BR]][[BR]]
'''Proposed solution''': I can see a number of different solutions for this problem. The best one would be to only call info() on the UploadStatus belonging to the opened media dialogue. However, the info() calls are performed via a single event trigger ([https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/media-views.js?rev=40359#L8289]) that all info() methods subscribe to in the UploadStatus.initialize() function (relevant for this bug is the `""add""` trigger), and this trigger cannot distinguish its subscribers. Therefore I propose to instead call ready() at the end of the initialize() function. This way, ready() is only called once more than before per media dialogue and page load, and we can be certain that info() is only called on UploadStatuses that are ready()." carlobeltrame
42792 Custom Post Editor for Automotive Editor 4.9.1 normal normal Awaiting Review feature request new 2017-12-04T06:41:20Z 2017-12-04T06:41:20Z "Any suggestion to create custom post editor for automotive? We are delivering automotive news and franchise website [https://murahmotor.com] and recently we are looking a way to customize our post editor.
Many thanks before for the suggestion." murahmotor
1 42791 wp_add_dashboard_widget() should accept location and priority parameters davidjlaietta Administration normal normal Awaiting Review enhancement assigned has-patch 2017-12-03T21:57:20Z 2018-02-25T19:04:02Z The `wp_add_dashboard_widget()` function should accept `$location` and `$priority` parameters to bring the function inline with `add_meta_box()`, which it ultimately calls. johnbillion
5 42790 Permit basic authentication to the REST API over SSL REST API trunk normal normal Awaiting Review feature request new 2017-12-03T21:53:38Z 2017-12-07T01:27:19Z "The only REST API authentication scheme currently supported in core is cookie/nonce authentication. This is sufficient for front-end usage within wp-admin, themes, and plugins, but prohibits full consumption of the REST API from external applications, particularly the WordPress mobile apps.
After discussion with the WordPress mobile app team, we propose adding core support for REST API authentication via basic auth for SSL-enabled environments.
These mobile apps currently use basic authentication to connect via the XML-RPC API. The XML-RPC API is disabled in some hosting environments, but discussion with the hosting team suggests this is usually to avoid amplification attacks via pingbacks rather than anything related to basic authentication itself. Using this scheme only over secured connections mitigates the primary security criticism of basic authentication. As an example, the Github API (among many others) supports basic authentication: https://developer.github.com/v3/auth/ without any clear drawbacks. These APIs also preference basic auth because it is substantially simpler to use than OAuth schemes, even with a central broker.
From the perspective of a mobile app developer, preventing REST API access via that same authentication scheme on the grounds that we are simultaneously pursuing alternatives unfairly disenfranchises the mobile app team and blocks significant potential code improvements." kadamwhite
42786 get_settings_errors() inline docs return should reflect the array in detail General trunk normal normal Awaiting Review defect (bug) new has-patch 2017-12-03T20:14:48Z 2017-12-20T15:40:33Z "The return array should be explained in better detail in the inline docs, both for the purpose of clarity for developers, and for DevHub purposes.
Here's the line in the code:
https://core.trac.wordpress.org/browser/tags/4.9/src/wp-admin/includes/template.php#L1440
Suggested return array:
{{{
@return array {
* @type string $setting The setting that is throwing an error.
* @type string $code Code of the error.
* @type string $message Message of the error.
* @type string $type Type of error.
* }
}}}
I have a patch, but would like clarity on whether this is accurate first. " webdevmattcrom
13 42785 Change default of `show_in_rest` in register_post_type and register_taxonomy pento REST API normal normal Future Release enhancement assigned needs-unit-tests 2017-12-03T19:34:14Z 2018-05-17T03:47:46Z "Right now `show_in_rest` is defaulted to `false` in `register_post_type` and `register_taxonomy`. To improve usefulness of the REST API I think the time has come to include default publicly readable data into the REST APi.
This helps with https://github.com/WordPress/gutenberg/issues/1342#issuecomment-319920850 for Gutenberg too.
I propose we default `show_in_rest` to `true` in the following scenarios:
- Object types registered with `public => true` (only).
- Object types registered with `publicly_queryable => true`.
I have other future ideas for further cases (including authenticated-only cases) but I think this is a good start.
" joehoyle
42783 set_query_var should have a helpful inline doc description General trunk normal normal Awaiting Review defect (bug) new has-patch 2017-12-03T19:15:20Z 2017-12-13T16:04:11Z "set_query_var() does not have any description to help developers understand the purpose and/or context of this function. Adding inline docs will also help ensure the DevHub is accurate.
See here: https://core.trac.wordpress.org/browser/tags/4.9/src/wp-includes/query.php#L73
Suggested Description:
""set_query_var is a wrapper function to the global $wp_query that uses the method set.""" webdevmattcrom
42780 Code Editor: Linter (HTMLHint) should show error if checkbox doesn't have associated General 4.9 normal normal Future Release enhancement new 2017-12-03T17:32:45Z 2018-01-09T02:00:10Z "The Custom HTML Linter should show an error if an checkbox field does not have an associated label element. This would be a good improvement for accessibility.
To reproduce:
1. Create a custom HTML widget
2. Enter the following code:
{{{
Checkbox Label
}}}
3. No warning/error appears. " shooper
1 42773 Plugin/Theme editor does not return sufficient information when loopback request fails Plugins 4.9 normal normal Awaiting Review enhancement new 2017-12-01T23:46:46Z 2017-12-01T23:46:46Z "The sandbox feature of the theme/plugin editor in 4.9 is a step in the right direction. Unfortunately there are many situations where the loopback request fails and there is no indication back to the user why that happened. The cURL/WP_Error response is just tossed away and a generic message is sent. Will attach a patch that at least returns the error message back to the user.
Additional improvements could be made, but I don't have the time to implement them:
Have a loopback test run before the file is saved to at least be sure that is available (save the result in a transient with a 60 sec ttl)
If that loopback fails, pop up a notice that the sandboxing feature is unavailable but have a checkbox to allow the user to force the edit to save.
" jamesgol
42770 Custom HTML Widgets & Google Tracking Widgets 4.9.1 normal normal Awaiting Review defect (bug) reopened reporter-feedback 2017-12-01T16:39:41Z 2017-12-07T06:41:30Z "Cannot save valid HTML code in the Custom HTML Widget if it contains Google outbound tracking links. It generates the ""There are XX errors which must be fixed before you can save.""" MacLeroy
42768 the_archive_title clutter General 4.9.1 normal normal Awaiting Review enhancement new 2017-12-01T12:37:09Z 2017-12-11T10:58:41Z "This function (and its get_ counterpart) is adding the ""Archives:"" prefix to the archive title. While the reason for this is understandable, not every site is a news/blog site, and many of us wishes to remove this (as it is clutter for some presentation sites, where we use standard WordPress behavior and custom post types for listing things).
This function is very useful, as it works with any kind of archives. However, the clutter isn't.
It's OK to leave the feature in by default. The only thing that is needed, to add a parameter which we can use to turn it off (using false).
For example:
{{{
the_archive_title($before = '', $after = '', $use_title_prefix = true);
}}}
" beerwin
2 42766 Issue in update password From admin side and login ith same password adamsilverstein Administration trunk normal normal Awaiting Review defect (bug) assigned has-patch 2017-12-01T11:25:05Z 2018-01-18T08:06:53Z "Issue details:
-> login to admin area:
-> go to user tab
-> Click on your admin user
-> Go to password field click on generate password
-> Remove generated password
-> keep that password box empty or fill it with any number of space.
-> Click on update profile.
-> You will get a success message that your profile was successfully updated.
-> logout
-> But try using that same password or previous password you can't login.
" ronakganatra
7 42765 Add the filter to the taxonomy metabox when editing a post Taxonomy 4.9.1 normal normal Awaiting Review enhancement new 2017-12-01T10:41:15Z 2017-12-01T13:00:18Z "The filter (`default_term_id`) is needed to set a default term in the custom taxonomy for custom post type.
File: '''/wp-admin/includes/meta-boxes.php''', Line: 542
{{{

-all"" class=""tabs-panel"">
""; // Allows for an empty term set to be sent. 0 is an invalid Term ID and will be ignored by empty() checks.
?>

}}}
" mihdan
1 42763 class-wp-list-table unnecessarily disables first and last pagination buttons General 4.9.1 normal normal Awaiting Review enhancement new has-patch 2017-11-30T22:04:28Z 2017-12-01T08:00:22Z "protected function pagination($which) in class-wp-list-table.php unnecessarily disables the << pagination button if you are on page 2 and disabled the >> pagination button if you are on the next to last page. That seems a bit pedantic and completely unnecessary.
If I am on page 2 of a multi-page list, I should be able to click either << or < to get back to the first page. If I am on the next to last page, I should be able to click either > or >> to get to the last page. It does not make sense to disable buttons that should logically work in these two conditions.
The following code starting at line 743 of class-wp-list-table.php...
{{{#!php
post_type}_query filter wrong place REST API 4.9.1 normal normal Awaiting Review enhancement new 2017-11-30T18:39:41Z 2017-11-30T18:39:41Z "Taxonomies are added after {{{rest_{$this->post_type}_query}}} filter takes place, making impossible to alter the query completely.
It would be better to apply filter right before {{{new WP_Query()}}} in class-wp-rest-posts-controller.php:290.
" Krstarica
42761 Undefined offset: -1 in wp-includes/post-template.php Posts, Post Types 4.9.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-30T18:37:34Z 2017-12-01T09:34:00Z "Hello,
I am getting this notice:
Notice: Undefined offset: -1 in /var/www/vhosts/domain/httpdocs/web/wp-includes/post-template.php on line 287
The logic that checks for index presence is faulty:
{{{#!php
count( $pages ) ) // if the requested page doesn't exist
$page = count( $pages ); // give them the highest numbered page that DOES exist
}}}
If `$page` is 0 or 1 and `$pages` is an empty array, you end up checking an out of bounds array and trigger this notice.
Maybe a more complete fix would be:
{{{#!php
count( $pages ) ) // if the requested page doesn't exist
$page = count( $pages ); // give them the highest numbered page that DOES exist
$content = isset($pages[$page - 1]) ? $pages[$page - 1] : '';
}}}
Ow whatever you think it will avoid this.
Thanks.
" twisted1919
1 42760 Trying to access an attachment directly by URL not working adamsilverstein Media 4.9.1 normal normal Awaiting Review defect (bug) reviewing 2017-11-30T13:41:32Z 2017-11-30T14:04:56Z "For example the URL https://example.com/wp-admin/upload.php?item=14
If there are more than 40 attachments, trying to access any attachment page after that 40th entry, will result in a JS error:
{{{
Uncaught TypeError: Cannot read property 'set' of undefined
}}}
Trying to open any attachment page via URL before and including 40, will work as expected.
A quick look, and it appears that, the problem comes from media-grid JS.
{{{
item = library.findWhere( { id: parseInt( query, 10 ) } );
}}}
The line above will return `undefined`, resulting in the attachment page not showing.
I'm attaching a screenshot with a log of the `library` variable from the media-grid JS file (line 521).
[[Image(https://i.imgur.com/euFKa0p.png)]]" ppetrov2c
2 42759 post not posting with featured image on mobile with wordpress 4.9.1 General 4.9.1 normal normal Awaiting Review defect (bug) new 2017-11-30T13:31:02Z 2017-11-30T13:31:02Z Hi! There’s a bug in WordPress after the update on 4.9.1: Posts on Facebook are not showing the featured image when being posted from iOS mobile, it only works on the computer version. When can we expect a bugfix? bluewhite
42757 Php notice when clicking View details on a plugin from the Plugins list view (edge case) Plugins normal normal Awaiting Review defect (bug) new 2017-11-30T11:51:04Z 2017-11-30T11:51:04Z "Hi,
I've just updated to 4.9.1. A warning now appears when clicking on ""View details"" on the plugin list page.
The issue comes from `get_installed_plugins`.
This function gets data from the transient `update_plugins`. In this data there's a list of stdClass objects. One of these objects doesn't have a slug.
`get_installed_plugins` doesn't test for the use-case where a slug doesn't exist.
The plugin without a slug in my case is WooCommerce Helper (woothemes-updater version 1.7.2).
I didn't manage to replicate this on a new install. After some testing I notice that this issue will only happen on existing installs because the faulty object won't be included when generating the transient in 4.9.1. This transient doesn't expire.
The fix in this case is to delete the existing `_site_transient_update_plugins` from the options table so it can be re-generated without the faulty object.
Should we add a test for the slug in `get_installed_plugins` for that use-case?
" mathieuhays
42754 Problems vid media search Media 4.9 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-30T08:39:52Z 2017-12-18T02:28:22Z "Hello!
I have tried to search for images by the name image, but no results are found. Im working at a web agency and I have tried the same thing at some customers websites that dont have the newest update and it is not a problem. I have both tried to search for the whole image name and parts of it, and still no results. There are only 50-70 images in the library.
/ Katarina
" katwag
1 42751 Can we please enqueue media-views independently ? Media 4.9 normal normal Awaiting Review defect (bug) new 2017-11-29T22:14:11Z 2017-11-29T22:14:11Z "Many of theme developers are styling mediaelement to their preference and this is a first step when they do so;
{{{
/*
* use theme mediaelement CSS
*/
wp_deregister_style('mediaelement');
wp_deregister_style('wp-mediaelement');
}}}
that disables the default CSS and lets us use our own. Issue with this is that
buttons, imgareaselect and media-views CSS files depend on these and if anyone is using a frontend page builder or anything that needs media library in frontend, these 3 CSS files are not present.
My first tought was
{{{
/*
* since we have deregistered medialement style
* make sure media dependencies are loaded
* in case of frontend editros
*/
if( is_user_logged_in() ){
wp_enqueue_style( 'buttons' );
wp_enqueue_style( 'imgareaselect' );
wp_enqueue_style( 'media-views' ) ;
}
}}}
but to my surprise media-views which is a key CSS file for media library is not loading since it is a dependent.
I know that I can do the direct enque but since we have a handle we should be able to use it independently from other styles.
While we are at it, why are we loading mediaelement CSS files at the bottom of body
http://prntscr.com/hh0808 ?
CSS files should always be in head. " Themezly
42750 Javascript breaks in some backend pages General 4.9 normal normal Awaiting Review defect (bug) new close 2017-11-29T21:01:28Z 2017-12-14T19:30:52Z "As discussed in ticket #42574, there seems to be at least one further reason why javascript stops working on some backend pages other than the already identified and corrected about the language codes.
Please refer to entry #24 in said ticket #42574 where the problem is described by some other user. According to this description javascript stops working when jquery is loaded twice. I don't know javascript at all and I can't identify where jquery is loaded from but I checked the source for different pages on my backend with consistent results: every time a backend page doesn't work well (like sreen options or help menus not being deployed, post tags not being assignable and other malfunctions), I see jquery being loaded twice in the page source. Every time a backend page shows no problems, there's only one load of jquery in the page source. The correlation seems clear.
I enclose source excerpts from two different pages, Post Editor and Image Editor where the double loading of jquery is shown. I think it's the very same source for both cases.
In pages that work well there's only this jquery loading:
{{{
}}}
Hope you can help and thanks in advance." viajarapie
42748 wpautop adds an extra

\n"";
}}}
This is very similar to #39377.
Note: I added the newlines to the input to make the difference more obvious.
- div before span gives p
- span before div gives /p
== Workaround ==
For my affected plugin I've written a PHPUnit test case that will fail when wpautop's behaviour no longer produces the unexpected results.
And I'm changing my code to avoid mixing spans and divs.
" bobbingwide
1 42747 i18n: Add specific text domain processing to `makepot` tools I18N trunk normal normal Awaiting Review enhancement new has-patch 2017-11-29T14:38:16Z 2018-02-21T14:55:24Z "In the {{{tools/i18n/}}} directory of the core repo is a great set of tools. As a plugin developer, two of the most useful tools are the {{{makepot.php}}} and {{{add-textdomain.php}}} files.
As an enhancement, it would be nice if the {{{makepot.php}}} file was able to operate on a specific text domain. This obviously wouldn't be necessary for Core, but for plugins and themes it could be quite useful. In particular, it would be great to have in the following cases:
* When including default WordPress strings in conjunction with custom strings.
* When including 3rd-party bundled libraries, such as CMB2.
* When trying to put together a single translation file that spans multiple plugins and even a theme in a single site (this is certainly an edge case, but I have worked with clients who have this need)
I have a working patch that allows passing a textdomain and processing that domain only.
I opened this ticket as the result of a [https://wordpress.slack.com/archives/C04KRK0KA/p1507040646000668 discussion in Slack]." JPry
42743 Disable wp_options autoload for inactive widgets Widgets trunk normal normal Awaiting Review defect (bug) new 2017-11-29T04:25:59Z 2017-11-29T04:55:07Z "Options/settings for all widgets are saved in wp_options with autoload=yes, but autoload is enabled for the wp_options even for deactivated widgets.
On sites with many widgets installed (but not even activated), the size of data transferred from the DB to the PHP host on each and every page request can add significant overhead and introduce noticeable slowdowns.
I can't see a reason why autoload can't be disabled on deactivation of a widget, preloaded on navigation to the widget settings page, and then re-enabled when said widget is activated." ComputerGuru
42735 Add missing periods to some error messages Text Changes normal normal Awaiting Review enhancement new has-patch 2017-11-28T17:39:59Z 2017-11-28T17:41:07Z All those 'Invalid xyz'-like messages do end with a period, but not all :) Presskopp
1 42732 Problem with usage of WP_Term_Query inside WP_Tax_Query Query 4.9 normal normal Awaiting Review defect (bug) new 2017-11-28T15:15:21Z 2017-11-28T15:15:21Z "This problem started on WP 4.9 because of #37038.
In WPML plugin, we filter the tax queries in order to convert the term IDs to their translations in the current language (if any).
In WP 4.8.3, `WP_Tax_Query::transform_query` was making direct calls to the DB.
In WP 4.9, `WP_Tax_Query::transform_query` is using `WP_Term_Query` to fetch the terms of the meta query.
The problem is that we have filters on `WP_Term_Query` (on `get_terms_args`) which applies to this.
This is usually not a problem, except for a post query with tax queries and `suppress_filters` set to `true`.
Here's an example:
{{{
$args = array(
'post_type' => 'post',
'suppress_filters' => true,
'tax_query' => array(
array(
'taxonomy' => 'category',
'field' => 'term_id',
'terms' => [ 3, 4 ] // 3 is the English category and 4 is the translation in French
),
)
);
$wp_query = new WP_Query( $args );
}}}
'''What is expected (and actual behavior in 4.8.3):''' This query should return all the posts attached to the category 3 or 4, whatever the current language.
'''What we have now:''' The query returns the posts attached to 3 OR the posts attached to 4 (depending on the current language).
So we need a way to flag that `WP_Term_Query` is used inside `WP_Query` (via `WP_Tax_Query`) and `suppress_filters` is set to `true`." strategio
24 42725 Allow gender specific translations I18N trunk normal normal Awaiting Review enhancement new dev-feedback 2017-11-28T07:50:52Z 2018-01-23T18:15:30Z "For years, the WordPress translators community has needed to resort to '''painful compromises''' for languages with grammatical gender, where women are often discriminated by default.
From strings like `Lead Developer` to simply `Author` or `Editor`, some languages will always refer to these as males, regardless of the user self-identification.
While modern English grammar is exceptionally capable of being gender neutral, many other languages do not share this trait. Forcing all languages to adopt a gender-neutral grammar, even when they're not capable of it, diminishes the appeal of WordPress to non-English speaking users, especially women - because in almost all languages, pseudo gender-neutral grammar just uses the male form.
This ticket is a tracking ticket for the various tasks needed to allow for gender-specific translations
'''How gender specific translations will work with gettext'''
- We will modify some of the existing translations functions (in a backward compatible way) to accept an optional user gender value.
- When this happens, the POT generation tools will create 3 different strings, differentiated by a specific context.
- On output, the correct translation will be loaded based on the value of the gender property
'''What needs to be done'''
- Introduce a user profile field to store users' gender and a `get_user_gender()` function. See #42900
- Add unit tests to current translation functions
- Add an optional `options` parameter to `__()`, `_x()`, `_n()`, `_nx()` that will be used to pass the gender to the translation functions
- Update documentation
- Update GlotPress to group translations.
----
'''Notes:'''
- This ticket originally included proof-of-concept patches. It has since been rewritten to reference other tickets to tackle the various tasks.
- The details of the implementation were discussed during contributor day at WCUS 2017. Big thanks to @gregross, @johnbillion, @nullbyte for making this happen, and thanks to @nacin for his input.
- Major props to @glueckpress for being a driving force in creating this with his [https://wordpress.tv/2017/06/27/caspar-hubinger-big-little-shame-a-tale-of-empowered-user-experience-through-localisation/ WC Europe 2017 talk].
" yoavf
2 42723 Tag Cloud CSS needed for HTML minification Bundled Theme 4.9 normal normal Awaiting Review enhancement new has-patch 2017-11-28T05:41:29Z 2017-11-29T13:30:32Z "The new tag cloud code in Wordpress 4.9 works great except for one issue which can be improved.
Because it uses
{{{
display: inline-block
}}}
for li elements, it needs whitespace after each ending closing li tag.
Else HTML minifiers will remove the spacing. It's hard for minifiers to do the job as this is a more general issue.
An illustration is here: https://codepen.io/anon/pen/pdOPdr
What happens is that after HTML minification, tags appear very close to each other. Undesired.
The best way to tackle it would be to improve the CSS. Here's a suggestion
{{{
.tagcloud ul li:after, .widget-area .widget.widget_tag_cloud li:after {
content: '\00A0';
white-space: pre;
}
}}}
" superpoincare
42718 Video shortcode needs muted attribute for Autoplay to work with Safari 11.0.1+ Shortcodes 3.6 normal normal Awaiting Review defect (bug) new has-patch 2017-11-27T21:31:45Z 2017-11-28T02:36:03Z "Safari 11.0.1 disables autoplay on everything that isn't muted by default. Link here:
https://techcrunch.com/2017/06/05/auto-play-block/
Chrome will disable it starting next year:
https://arstechnica.com/tech-policy/2017/09/google-chrome-block-auto-play-video/
For this reason, if we're including the autoplay attribute in the video shortcode, we should add a muted attribute to make it a useable shortcode.
Other than a code change, we should also update the docs about the shortcode here:
https://codex.wordpress.org/Video_Shortcode
How to test this now:
Get on Safari 11.0.1 (or greater)
Create a post with a video shortcode and an autoplay tag.
Go to the front end version and see that it won't play.
" deeptiboddapati
42714 Unit tests: Move remaining classes out of includes/utils.php into their own file Build/Test Tools normal normal Awaiting Review defect (bug) new has-patch 2017-11-27T15:15:00Z 2017-12-09T01:47:28Z "The `includes/utils.php` file includes four classes:
- `MockAction`
- `testXMLParser`
- `MockClass`
- `wpdb_exposed_methods_for_testing`
The patch moves these classes into their own files, as this makes the code more transparent, and easier to add documentation.
The files are now loaded during bootstrap. Moving classes out of files can lead to issues, as seen in #37523.
Rather than continue loading these files always in `includes/utils.php`, one way to get around this is to check for these classes being loaded at the top `utils.php`. If not, they can be loaded, and an error message can be triggered, so that developers can update their code.
This backwards compatibility layer could then be removed after having it there for one major release.
" Frank Klein
42712 Enhance wp revisions to keep with expiration date for the revisions Revisions normal normal Awaiting Review feature request new 2017-11-27T13:16:26Z 2017-11-28T00:39:31Z "https://codex.wordpress.org/Revisions
Now, the options of the revisions are:
true (default), -1: store every revision
false, 0: do not store any revisions (except the one autosave per post)
(int) > 0: store that many revisions (+1 autosave) per post. Old revisions are automatically deleted.
What about to have expiration by time also, not just with number. In that way, in big multisite installations, old revisions could desappear after X months. Decreasing the size of the database.
Normally, if a post have not modifications after 1 year, is because not longer are necesary. Anyway, it would be a choice of the superadministrator of the installation.
thanks" colomet
1 42711 Support for symlinked themes in the themes folder Themes normal normal Awaiting Review enhancement new 2017-11-27T12:38:34Z 2017-11-27T12:38:34Z "Symlinking themes to the theme directory does not work.
This feature is more important than ever, since developers usually use various build tools.
The repository – almost everytime – looks something like this:
{{{
.
├── build
├── src
├── package.json
└── readme.md
}}}
The build folder contains the generated theme. Currently it is necessary to use a script to copy the build files to the Wordpress theme folder, after a successful build.
It would be much easier to symlink the build folder to the WP themes directory. This way you keep your repository and the WordPress themes folder clean." Afterlame
42703 WP_Query: Swap parsing date into own method Database trunk normal normal Awaiting Review enhancement new 2017-11-26T17:32:44Z 2017-11-26T17:32:44Z "The WP_Query::get_posts also parses the date query.
This is modular enough to swap it to its own method at last.
A proof of concept has been made and all tests are still green.
Some details and todos:
- see https://github.com/ScreamingDev/wordpress-develop-1/commit/6bb681e8caf4df8ba4811690ee19f12ad1755371
- Check if the whole logic can be shifted to WP_Date_Query::get_sql
Hint: The long run is about enabling WordPress to support multiple tables (per ""post-type""). To achieve this some enhancements to the current wpdb and WP_Query class are needed. This issues covers a small bit of it by refurbishing the source." screamingdev
42702 "Most common issue inside post edit - ""Links Live search""." Permalinks 4.9 normal normal Awaiting Review feature request new 2017-11-26T09:59:46Z 2017-11-26T09:59:46Z "'''Most common issue in WP Back End Search''':
My original parmalink is not matching with Search URL and for that way i have trouble in interlinking of blog articles to 1 post to another one because of wrong category URL.
I have set Primary category (Messaging).
But in Search you will see wrong category (Linux).
For more details please view below 2 attach files carefully…
https://drive.google.com/file/d/1XoDVa_zMygIWs8bFfgaSag4-iou7BCl3/view?usp=sharing
https://drive.google.com/file/d/1u5ZlOXAA_5q30qo-HLnO8Qtz75tJkj3Q/view?usp=sharing
For more details:
This above issue is in 2-fold i will try to explane you below…
Our website permalinks are configured like so: /%category%/%postname%/
The first issue is that although a '''primary category is set for all of my posts''', when using the WordPress Link button, WordPress does not always insert the link using the primary category in the URL. I read that other people were having a similar issue where the categories where being inserted in alphabetical order. This does not seem to be the case for me as for the most part the permalink is working correctly, but not accross every post.
The second issue is that the post is not redirecting to the url which contains the primary category eg.
example.com/secondary/test-post
is not being redirected to the correct permalink as shown below
example.com/primary/test-post
Instead, the post is visable on both URL’s.
And for that way we have trouble in interlinking of blog articles to one post to another one because of wrong category URL
But if any fix in functions.php can help to resolved above issue and for that we need your help.
Your help would be appreciated.
Thank you." Softfully
2 42696 Autosave Notification not dismissible Autosave 4.2 normal normal Awaiting Review defect (bug) new dev-feedback 2017-11-25T10:11:17Z 2017-12-06T07:02:10Z "If I make changes to a Post/Page and then decide I don't want to keep those changes, I'll simpy click away from the edit page.
The next time I decide to edit the page, I'm prompted with a notification advising ""There is an autosave of this post that is more recent than the version below. View the autosave""
https://cl.ly/082A3B0u3J1u
The only option I'm given is to view the autosaved version. This notificaiton should be dismissible. I shouldn't have to view the autosaved version when I already know that I don't want it. I also shouldn't have to resave the page, just to get rid of the notification.
I would like to see a Dismiss icon/link so that we can dismiss the notification for good. When developing a theme or plugin, we're required to make all notifications dismissible. There's no reason why core notifcations shouldn't follow the same rules and also be dismissible." ahortin
3 42695 Text Widget: hard-coded width/height attributes are stripped from iframes Widgets 4.9 normal normal Future Release defect (bug) new dev-feedback 2017-11-25T04:30:54Z 2018-05-02T15:01:49Z "hi when i update my WordPress 4.9 my exiting iframe size in text widget not working.please find my [http://dubaicarmelschool.com/] and iframe code below:
" dubaicarmelschool
1 42692 Unused static variable $column_headers General trunk normal normal Awaiting Review defect (bug) new close 2017-11-24T18:56:49Z 2017-11-24T20:07:21Z "=== Context
We're working on a custom `WP_List_Table` class. For a project, we have setup a custom admin page and attach it to a custom post type.
Basically we call the `add_submenu_page` and set its parent slug to `edit.php?post_type=custom_post_slug`.
Our custom list table class is called `CurrencyListTable` and just displays a list of currencies coming from a custom database table. For this table, we have defined 2 custom columns. We correctly extend the `get_columns()` method and return an array with those 2 columns.
=== Expected result
On our page display fallback, we instantiate our custom table class and call its `prepare_item()`, `search_box()` and `display()` methods in order to render our list table.
We expect to see the usual list table with the table header and footer, the rows containing 20 items as our `$per_page` definition, the search box and the table pagination.
=== Result
Everything is displayed on screen except the header, footer and rows of the table. The search box, pagination and total number of items is correctly displayed.
=== Solution
We have digged into the WordPress source code and stop our attention on the `get_column_headers()` function defined into the `wp-admin/includes/screen.php` file line 19.
When we remove the `static` definition for the `$columns_header` variable on line 23, our custom table renders correctly.
Perhaps a core developer could provide more information on why this variable is set as static.
We can see that the `get_column_headers()` function is called several times when rendering a list table and that we might want to re-use the set variable. But we don't understand why the first initialization is incorrect and set our column headers as an empty array.
When removing the `static` definition, everything works as expected. We have tested this with another custom set of people data where we have 114589 rows and haven't noticed any slow performance (we still show 20 rows per page).
Core list tables also work as expected for posts, pages, plugins, users, ...
Personnaly I think we can remove the `static` keyword as the `WP_List_Table` class `get_column_info()` method is storing the list of columns for a table instance into its ""private"" property `$_column_headers`. But I would like more insights from core developers before diggin into a patch.
" jlambe
42690 Custom HTML Widget? Widgets 4.9 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-24T15:17:07Z 2017-11-25T22:10:10Z "Your Custome HTML Widget no longer accepts HTML
Cannot enter amazon banners, adsense banners or any other html coded banners" bollox
42688 Option to make get_template_part return instead of require Themes 4.9 normal normal Awaiting Review feature request new close 2017-11-24T10:02:08Z 2017-11-29T23:08:41Z "Having the ability to have a template returned instead of required would be extremely helpful for building shortcodes using get_template_part to load reusable sections of code in the theme. Current work-arounds include output buffering and using locate_template, both of which have their own downsides.
{{{
#!php
and

elements.
You can reproduce this error by:
- opening a new post
- adding `

` in the text editor *
- press the ‘publish’ button
- switch back to the visual editor
- add a link via the ‘insert’ link button (for example: www.google.com)
- switch to the text editor and notice that the result is not a link element but just: `

`
This error didn’t happen in WordPress 4.8.2, but it does in WordPress 4.9.
*please note that from here on, everything in your editor is placed within div elements automatically. For example, just pressing the ‘enter’ button leads to new `

` elements in your text editor" michellefoolen
42671 REST - getting all taxonomy terms with one GET request causes division by zero warning. REST API 4.9 normal normal Awaiting Review enhancement new 2017-11-23T12:18:31Z 2017-11-23T12:18:31Z "
Querying taxonomy terms from REST API one can affect the returned items number by using per_page REST argument, like so:
wp-json/wp/v2/customtaxonomy?per_page={number}
Minimum value for this argument is 1, which is annoying in the taxonomy terms context. One have to use a filter to change per_page minimum value to 0 to be able to get all terms at once.
The per_page argument for taxonomy terms route is set in WP_REST_Terms_Controller parent WP_REST_Controller, see get_collection_params() method.
Here is an filter example to allow per_page value 0:
{{{#!php
(www.site.com/:166)
at Function.each (jquery.js:2)
at a.fn.init.each (jquery.js:2)
at HTMLDocument. (www.site.com/:163)
at i (jquery.js:2)
at Object.fireWith [as resolveWith] (jquery.js:2)
at Function.ready (jquery.js:2)
at HTMLDocument.K (jquery.js:2)
I tried to downgrade to wordpress 4.8.3
all problems resolved
" animedate
2 42663 Imagick support for stream wrappers Media trunk normal normal Awaiting Review enhancement new dev-feedback 2017-11-22T13:57:17Z 2018-03-01T21:20:21Z "The current implementation of imagick backend doesn't support stream wrappers. In order to support them `readImageFile` and `writeImageFile` methods must be used instead of `readImage` and `writeImage`. The methods were added in ImageMagick module 2.3.0.
This patch uses stream wrapper compatible functions if they are available." calin
42661 html5 comments form validation doesn't work General 3.6 normal normal Awaiting Review enhancement new 2017-11-22T11:44:23Z 2017-11-22T15:06:09Z "The default html5 validation doesn't work in the forms build by /wp-includes/comment-template.php
in the function comment_form( $args = array(), $post_id = null )
in the line 2298 of comment-template.php the sentence to create novalidate atribute has the values reversed and because of this it isn't going to validate in html5 forms :
{{{#!php
"" method=""post"" id="""" class="""">
}}}
This sentence shouldn't be? :
{{{#!php
"" method=""post"" id="""" class="""">
}}}
¿Or are you delegating this kind of validations to any other source code? in such case what sense have print or not this attribute here?
I attach the file with the correction from a previous versión but the bug, if it is a bug is in 4.9 source code too.
Thanks for reading and thanks for wordpress ;-)
Best regards
" Wordpreso
1 42659 Cropped logo image not display when use customize section in (4.9-RC2) Gallery 4.9 normal normal Awaiting Review defect (bug) new 2017-11-22T06:26:35Z 2017-11-22T06:26:35Z Customize section logo images gallery not display cropped logo. ravipatel
42654 Color Palette on Theme Options General 4.9 normal normal Awaiting Review defect (bug) new 2017-11-21T19:26:54Z 2017-11-23T04:48:05Z "Hi, guys!
So I'v seen that the color palette menu has changed on the last Wordpress Update. Now it doesn't show the box to write down the color code and be more accurate. I've tried with two different themes (Garage and 15Zine) and it shows the same color menu, without the box to write color codes. Do you know if there is a way to get that box back?
Best,
R." raulfpm
1 42649 Remove extra space after Dashboard & Comment admin menu Menus 4.9 normal normal Awaiting Review defect (bug) new 2017-11-21T08:44:57Z 2017-11-21T13:35:12Z I just seen dashboard and comment admin menu. it is showing extra space after both menu Hardik Amipara
42642 Displayin page WP 4.9 General 4.9 normal normal Awaiting Review defect (bug) new 2017-11-20T15:10:06Z 2017-11-20T15:27:45Z "I prefer to display my pages on one column rather than on two, as default checked in WP.
It works fine with twentyseventeen theme and WP 4.8.3.
But it does not any longer works with WP 4.9.
So, I undergraded to 4.8.3 but what a work and waste of time.
Any idea about this bug solving ?
Jacques" jibe64320
42637 Wrong button text for plugin installation failed! Plugins trunk normal normal Awaiting Review defect (bug) new 2017-11-20T07:42:07Z 2017-11-20T07:42:07Z "Button text should be `Installation Failed!` instead of `Update Failed!` if plugin installation failed.
Check below gif:
Latest version: http://bsf.io/yola3
After applied patch: http://bsf.io/rblas" Mahesh901122
42633 Suggestion to provide Better Page and Image Management Media 4.9 normal normal Awaiting Review feature request new 2017-11-20T03:41:59Z 2017-11-20T05:24:14Z "**** This is not bug report but a suggestion ****
Not at all sure if this is the right place for this however, I've been using wordpress for about 12 months now and believe it lacks somewhat in the management of pages and media. I believe that it would help tremendously helpful if we could:
(1) organize pages into groups or folders as it can be overwhelming with the current long list of pages when we are working on large sites with a lot of pages, and
(2) similarly, organize media into folders so for example, we could keep site media separate from post media.
Thanks for listening" sixlinksrule
1 42631 Widget visibility settings not preserved Widgets 4.9 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-19T23:32:06Z 2017-11-20T23:13:48Z "Changes to widget visibility settings that are neither all off or all on are erratically changed upon close/save of the visibility pop-up. I've tried to save specific page display settings for widgets on two different browsers (FireFox and Chrome) and both produce the same result:
If a widget is to display only on pages A, B, C, and D; what is stored is randomly, A, C, E, F, G, and L. Or maybe A, B, C, G M, N, and P. Who knows. If all pages are off, they'll stay off. If all pages are on, they stay on.
In the same vein, paging through the lists screws up items selected items on each page too. All de-selected items will be re-selected when you go to another page.
" Blackhawke
1 42624 "Documentation says ""available_permalink_structure_tags"" filter is since 4.8" General 4.9 normal normal Awaiting Review defect (bug) new 2017-11-19T08:49:57Z 2017-11-19T08:49:57Z `@since` declaration is incorrect. The filter was actually introduced in 4.9. tiagohillebrandt
1 42619 WordPress tries to access /home/.bzr but to no avail Upgrade/Install 4.9 normal normal Awaiting Review defect (bug) new 2017-11-18T14:35:29Z 2018-01-24T04:58:46Z "Hi,
I'm getting the following error in my logs. I'm aware that I have open_basedir enabled, but I don't think WordPress should try to read files outside its installation directory. If I'm mistaken, I'm sorry and I'll be glad to receive any explanation as to why.
This bug doesn't generate any visible error or message other than this log, so I would definitely consider it ""low severity"". The log file was generated by a plugin of mine, but as you can see, the error doesn't occur in my own files. It's located in a core file.
Here's what I get in my log file:
{{{
[14:35:04]
******************
PHP SHUTDOWN ERROR
Type: 2
Message: is_dir(): open_basedir restriction in effect. File(/home/.bzr) is not within the allowed path(s): (/home/httpd/vhosts/[hidden]/:/tmp/)
File: /home/httpd/vhosts/[hidden]/subdomains/[hidden]/wp-admin/includes/class-wp-automatic-updater.php:98
******************
}}}
Best regards" meyegui
1 42618 wp.mce.views API not using registered shortcode functions TinyMCE normal normal Awaiting Review defect (bug) reopened 2017-11-18T10:09:02Z 2018-03-05T14:08:23Z "This is a follow-up to #21812.
Hi @all!
Not sure if this is the right place to post, but could not find a better one. Just a few words why I am posting here: I write a plugin that extends the default/ core gallery shortcode (by remove/add_shortcode ('gallery')).
So one of the ""problems"" with the whole 'wp.mce.views' API is, that it completly ignores/ bypass any shortcode functions (registered with WP). So to say it establishes its own shortcode functions, which imho cannot be useful. As a user I would expect, that every view represents the correct output of any shortcode in the content, which is currently not the case.
Unfortunately I am not the Javascript Guru to correct these ""inappropriate"" behaviour. So I am hoping that people with the needed knowledge will find a proper solution for this, espacially @koopersmith who seems to have invented this ""system"".
Beside this hope I would be glad if anyone could give me some advice/ hint, how to circumvent this problem and make views use of the proper shortcode function.
Many thanks in advance!" netsurfer2705
3 42612 Single post navigation bugs when adding posts in Starter Content westonruter Customize 4.7 normal normal Future Release defect (bug) reviewing has-patch 2017-11-17T23:13:45Z 2018-04-20T18:23:36Z "To reproduce the issue:
- Inside a fresh install of Twentyseventeen, open the functions.php file. Line 132, modify the $starter_content posts array to add 2 posts:
{{{#!php
array(
'home',
'about' => array(
'thumbnail' => '{{image-sandwich}}',
),
'contact' => array(
'thumbnail' => '{{image-espresso}}',
),
'blog' => array(
'thumbnail' => '{{image-coffee}}',
),
'homepage-section' => array(
'thumbnail' => '{{image-espresso}}',
),
'the-new-office' => array(
'post_type' => 'post',
'post_title' => 'The new office',
'thumbnail' => '{{image-espresso}}',
'post_content' => 'Maecenas tristique lobortis sem sit amet consectetur. Nullam pharetra ex ex, a aliquet ligula pellentesque a. Aenean et justo volutpat, malesuada purus a, sagittis eros.',
),
'join-the-team' => array(
'post_type' => 'post',
'post_title' => 'Join the team',
'thumbnail' => '{{image-coffee}}',
'post_content' => 'Maecenas tristique lobortis sem sit amet consectetur. Nullam pharetra ex ex, a aliquet ligula pellentesque a. Aenean et justo volutpat, malesuada purus a, sagittis eros.',
),
),
}}}
- Open the Customizer to load the starter content and click on the Publish button.
- Visit the first post titled ""The new office"". The single navigation indicates ""Hello World"" as the previous post while it should be ""Join the team"".
I think the bug comes from the fact that the 2 posts have the same exact date. Is there a way to specify the post date when configuring the starter content?" bduclos
1 42610 Admin created account password reset process not reverse proxy friendly Login and Registration 4.9 normal normal Awaiting Review defect (bug) new 2017-11-17T21:08:41Z 2017-11-17T21:08:41Z "WordPress newbie, so feel free to point me to a better resolution. Couldn't find anything quite like this.
Have WP running mostly correctly behind a reverse proxy. So no one ever directly touches blog..com (the WP site), instead they access it through www..com/blog
If I create user accounts in the admin, it sends initial password reset links to the new accounts, which have a format like www..com/blog/wp-login.php?action=rp&key=&login=
In wp-login.php, I see the case that catches the rp action, and it does something with the key and user parameters, then strips them off and redirects again to wp-login as follows:
{{{#!php
wp_safe_redirect( remove_query_arg( array( 'key', 'login' ) ) );
}}}
I'm unclear on why this line doesn't incorporate site_url as do several other places in nearby code. The user ends up getting a redirect to /wp-login.php. That is, from the '''user's perspective''' (not seeing the reverse proxy activity), it looks like:
www..com/blog/wp-login.php?action=rp&key=&login=
redirects to
www..com/wp-login.php?action=rp
which is a 404
From the '''WP server's''' perspective, it told
blog..com/wp-login.php?action=rp&key=&login=
to redirect to
/wp-login.php?action=rp
which would have been fine if there were no reverse proxy involved.
This is not the desired behavior in my case, and I would think it would be safe to redirect to
/wp-login.php?
I can work around it in the main site's rewrite rules by forcing /wp-login to /blog/wp-login, but that seems as if it shouldn't be necessary.
Thanks for your consideration." normjhansen
42599 Design changes in Tools Categories and Tags Converter box and Tools Import box Import 4.9 normal normal Awaiting Review defect (bug) new has-patch 2017-11-17T10:27:46Z 2017-11-28T07:21:58Z "Some Design changes in Categories and Tags Converter box and Import box
Go to wp-admin
1. Tools > Available Tools
2. Tools > Import" Shital Patel
42595 Navigation Menu Issue General 4.9 normal normal Awaiting Review defect (bug) new 2017-11-17T07:17:11Z 2017-11-17T07:17:11Z "Hello Team,
I have notice Main Menu Navigation issue when we are at Manged Themes Location.
How can be reproduce this issue
Step 1> Apperence > Themes
2> Click on Theme Details Button.
And now without closing POP Dialog try to enter into Main Menu Navigation. Which not allow to used choose menu content. Its actully block menu visiblity and its functionalty to access.
I have attach screen shot for reference
" codexdemon
42592 Broken footer width on theme Twenty Fifteen when looking at individual post Bundled Theme 4.9 normal normal Awaiting Review defect (bug) new close 2017-11-17T01:30:28Z 2017-11-17T11:03:36Z "I'm using the default theme Twenty Fifteen and I noticed that since I upgraded to Wordpress version 4.9 the footer of each individual post is not contain within the width of the rest of the page, you can see this on any of the blog post of my blog https://blog.listalegal.com/
I attached a screenshot." listalegal
2 42587 Added Css Classes field to wp-link in editor. Editor trunk normal normal Awaiting Review enhancement new 2017-11-16T17:26:31Z 2017-11-16T17:26:31Z "Good day to WP Core developers!
Currently the only way to add css class to a link in wysiwyg is to switch editor to textual mode and add class attribute by hand.
So I've decided to add this field to wp-link editor dialog. It's helpfull when you use link as a button and you definitely don't want to style all content links as buttons, so you are able to edit class link attribute in wp-link editing dialog which is much user friendly.
" mikhailroot
42572 Can't delete custom taxonomy tags from a post Taxonomy 4.9 normal normal Awaiting Review defect (bug) new 2017-11-16T07:17:40Z 2017-11-16T07:17:40Z "Symptoms are the same as #39388: I can add terms in my custom taxonomy to a post, but I can't remove them. I'm not using any of the filters mentioned in that ticket. Based on logging all SQL queries on saving a post, it looks like removing a category triggers a query like:
{{{
DELETE FROM wp_term_relationships WHERE object_id = 1470 AND term_taxonomy_id IN ('7')
}}}
No DELETE query at all is running when I try to remove the custom taxonomy, so it's not a malformed query. Same problem whether I'm using the classic editor, the quick editor, or Gutenberg.
As a further wrinkle, in the classic editor, my terms don't even show up in the checkboxes in the sidebar (all of them are unchecked), though they do show up on the front end, in the quick editor, and in Gutenberg.
This didn't always happen, but I don't recall the version it started with. Disabling all plugins doesn't fix it, neither does clearing out my functions.php entirely, and neither does changing 'hierarchical' to false.
My arguments for registering the taxonomy are as follows:
{{{
$args = [
'labels' => [ /* a bunch of strings */ ],
'public' => true,
'hierarchical' => true,
'show_in_rest' => true,
'rewrite' => ['hierarchical' => true],
'query_var' => 'idea'
];
}}}" thrica
1 42569 Not able to edit files from Theme Editor option. Editor 4.9 normal normal Awaiting Review defect (bug) new 2017-11-16T06:05:29Z 2017-11-16T06:05:29Z "I'm using Window 10 and localhost server, When I tried to update file from Editor then I got the error '''Sorry, that file cannot be edited.'''.
Screenshot: [https://i.imgur.com/lBRhl9d.png]
After debuging I got that [https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/functions.php#L4258 validate_file()] function returning 2 that means the $file contains ':' after the first character.
" dineshc
1 42568 Media Uploader Button Label General 4.9 normal normal Awaiting Review enhancement new 2017-11-16T06:03:35Z 2017-11-16T06:03:35Z I was wondering if the '''Media Uploader''' in the new '''Text Widget''' has a button with label '''Insert Into Widget''' instead of '''Insert Into Post''' as shown here: http://prntscr.com/hb38jv . It would be more meaningful I guess :) saurav.rox
1 42566 When I use wp_nav_menu I get a huge update_meta_cache query regardless of theme Menus 4.8.3 normal normal Awaiting Review defect (bug) reopened 2017-11-15T23:53:36Z 2018-03-05T13:57:29Z "Hi there,
I've got a wordpress site that's been up and running for a couple of years now. I always keep core+plugins up to date, and although I use a custom theme, I'm pretty happy with how it's working.
Recently however it started to crash regularly - and the server guys notified me that it was mysql that was causing it. So I installed Query Monitor and took a look - there was a massive query which looked like this:
{{{
SELECT post_id, meta_key, meta_value
FROM ajs_postmeta
WHERE post_id IN (11178,9677,9060,7417,7354, )
ORDER BY meta_id ASC
}}}
This was returning 20,000 rows each time the page was loading. This obviously overloaded the server during peak times and it needed rebooting.
This is the code that was causing the problem (I know this because I replaced it and the offending query disappeared)
{{{#!php
'header-menu',
'container' => 'nav',
'container_class' => 'nav-menu-holder nav-menu-landing nav-new',
'menu_class' => 'nav-menu',
'walker' => new themeslug_walker_nav_menu));
}}}
So I replaced wp_nav_menu with static HTML and the query size reduced as it was no longer calling wp_nav_menu. I thought it might have been something I'd done in my theme - so I removed the custom walker, which didn't have any effect, and played about with some settings. I tried using the recommendation here: [https://hitchhackerguide.com/2011/11/01/reducing-postmeta-queries-with-update_meta_cache]/ but that had no effect.
So the next step was to try a different menu. So I deleted my menu (which had 70/80 items in it) and added 5 new items to a new menu. That then gave the following query:
{{{
SELECT post_id, meta_key, meta_value
FROM ajs_postmeta
WHERE post_id IN (11178,9677,9060,7417,7354)
ORDER BY meta_id ASC
}}}
which is the same query as above but without the lots of additional ids - as this menu only had 5 items. This returned around 450 rows - so it's not hard to see that a menu with 70/80 items would get up to 20,000.
The last thing I tried was to change to the default theme and disable all plugins (bar Query Monitor) and tried again. I associated my test menu (with the 5 items) with the 2017 theme top menu and checked query monitor - it still showed this query:
{{{
SELECT post_id, meta_key, meta_value
FROM ajs_postmeta
WHERE post_id IN (11178,9677,9060,7417,7354)
ORDER BY meta_id ASC
}}}
with the same number of rows.
So my question is this - is this something that is a problem in core wordpress, seeing as this update_meta_cache() method seems to be creating massive queries if you have a larger than average menu - even 15/20 items would create a fairly large result set each time.
I've been googling like crazy as I really want to get this sorted - but I can't seem to find a solution, and I'm wondering if it's something in the latest release. There's no difference between browser or OS that I can see - its just something wrong (I think) with the update_meta_cache method as it relates to the wp_nav_menu function.
Anyway, happy for you to take a look at my config etc - let me know what you need. Best email to get me on is andy@weboptimize.co.uk or you can call my UK mobile on 07791-107755
Thanks
Andy" andyseaton83
2 42560 mp4 files do not play in Safari Media 3.0 normal normal Awaiting Review defect (bug) reopened 2017-11-15T18:54:34Z 2017-11-20T23:55:37Z "When a user uploads an mp4 file, it will not play in Safari.
We have determined that this is not an issue with our Apache server (seems to happen to some folks that they have disabled range request headers) as the same file uploaded elsewhere on our server but externally from the wordpress site loads fine.
It seems that perhaps the video is attempting to load in byte ranges but that Wordpress is returning a 200 response instead of a 206, but that is just a hunch." cg923
42559 Twenty fifteen theme fails on IE 11.0.48 OK on 11.0.47 Bundled Theme normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-15T18:02:09Z 2017-11-15T23:15:01Z See my simple site at https://petergreenweb.wordpress.com/ - on every page, the menu works fine with Chrome on Win 7 and Android, and with IE 11.0.47 on Win 7, but fails to render or function in IE 11.0.48 on Win 7 (admittedly on a different PC). petergreen5678
1 42557 Wrong Behaviour on get_site_url for multiple sites with different protocol Networks and Sites 4.9 normal normal Awaiting Review defect (bug) new 2017-11-15T14:41:28Z 2017-12-21T23:18:17Z "Hi guys,
i think i found something that imho isn't working at all as expected.
Let's go with some explaination:
* I have a multisite network which has 4 sites
* 1 site, the main one, is under HTTPS protocol, the rest are under normal HTTP
* I've made a unique theme, customized for all 4 sites
* '''I don't want to pass the scheme to get_site_url()''' , this should be created dinamically
In theme footer, i'm calling the function {{{ get_site_url() }}} for pointing each site to other ones.
Something really bad happens here:
* The first site (the https:// one) show all the links with https on top, and it's totally wrong as the remaining sites are all under http
* Instead, the remaining sites show all the link with http on top, included the first https one
So, after inspecting a while, it seems you're doing something i cannot really explain...
* function get_site_url (link-template.php, row 3063) get the siteurl option from database using get_option('siteurl') and then you call set_url_scheme
* function set_url_scheme will be blocked from first condition check {{{ if(! $scheme) }}}, so we're going to is_ssl()
* and here we are with something misunderstood... function is_ssl() checks if $_SERVER[ 'HTTPS' ] global var is set and return true or false for the current server configuration, not bothering of other sites configuration (!?!?!?!?!?)
* so when i interrogate a HTTPS site, all links will be ssl, when i interrogate a HTTP site, all links won't have ahead that protocol.
I don't think this is an optimal way to check this thing honestly...
Could we discuss about it?" matteowebsolution
1 42550 Make wp_upload_dir respect URL scheme General normal normal Awaiting Review enhancement new 2017-11-14T20:33:54Z 2017-11-15T23:14:00Z '''wp_upload_dir()''' should respect the request scheme, consistent with '''get_site_url()'''. This would be helpful for plugins which put their generated content in the uploads directory. Senning
1 42546 WP_Query not handling 'LIKE' correctly. Query 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-14T16:27:03Z 2018-03-14T09:30:49Z "I am doing custom PHP to retrieve listings (as a CPT) from the database for a Realty Company website I'm working on and one of the criteria is searching on the city from a search field on a form. The problem is the generated SQL has some sort of guid in it instead of the expected percent character normally used with LIKE. Here is the generated SQL from WP_Query:
{{{
SELECT SQL_CALC_FOUND_ROWS wp_posts.* FROM wp_posts INNER JOIN wp_postmeta ON ( wp_posts.ID = wp_postmeta.post_id ) INNER JOIN wp_postmeta AS mt1 ON ( wp_posts.ID = mt1.post_id ) WHERE 1=1 AND ( ( wp_postmeta.meta_key = 'city' AND wp_postmeta.meta_value LIKE '{f270e6c7d3b231242ceefa28fdd47243cac2100fe4fe8c9df633ec6f3cc2f583}fairfield{f270e6c7d3b231242ceefa28fdd47243cac2100fe4fe8c9df633ec6f3cc2f583}' ) AND ( mt1.meta_key = 'beds' AND mt1.meta_value >= '0' ) ) AND wp_posts.post_type = 'listings' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'future' OR wp_posts.post_status = 'draft' OR wp_posts.post_status = 'pending' OR wp_posts.post_status = 'private') GROUP BY wp_posts.ID ORDER BY wp_posts.post_date DESC LIMIT 0, 10
}}}
As you can see the generated code for searching the ""city"" field is:
{{{
wp_postmeta.meta_value LIKE '{f270e6c7d3b231242ceefa28fdd47243cac2100fe4fe8c9df633ec6f3cc2f583}fairfield{f270e6c7d3b231242ceefa28fdd47243cac2100fe4fe8c9df633ec6f3cc2f583}'
}}}
The ""expected"" code should look like this:
{{{
wp_postmeta.meta_value LIKE '%fairfield%'
}}}
The form is found here: https://millersells.com/search-2/
After making selections and clicking the Search button it calls itself with url parameters and you get one of these errors:
""Fatal error: Maximum execution time of 60 seconds exceeded in /home/extremx1/public_html/millersells2017b/wp-includes/query.php on line 0""
OR
""Fatal error: Maximum execution time of 60 seconds exceeded in /home/extremx1/public_html/millersells2017b/wp-includes/class-wp-query.php on line 3090""
(Example URL with parameters: https://millersells.com/search-2/?cf_id=37&loc=fairfield&type=SingleFamilyHome&beds=3&baths=2&min_price=0&max_price=0)
I am using this PHP code to create the query (for now I'm just working with 2 of the search fields):
{{{
array( 'listings' ),
'meta_query' => array(
array(
'key' => 'city',
'value' => $location,
'type' => 'CHAR',
'compare' => 'LIKE',
),
array(
'key' => 'beds',
'value' => $bedrooms,
'compare' => '>='
)
)
);
$the_query = new WP_Query( $args );
?>
}}}
To see the generated SQL I added this code at line 2752 in wp_includes/class-wp-query.php: echo $this->request;
Also to aid in debugging I would suggest you add a ""generated_sql"" parameter to the query object that we can echo to see what the actual generated SQL looks like. EX: {{{echo $the_query->generated_sql;}}}
Thanks!
Tim :o]
PS: Your welcome to contact me at tberneman@gmail.com" tberneman
2 42544 Background Image Cover on iOS not correctly displayed Customize 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-14T14:48:42Z 2017-11-16T14:05:38Z "Steps to reproduce:
Define a background image
Set background preset to: fill (css: background-size cover; background-attachement: fixed; )
Test a site with ""long"" content (at least several screen heights) on an iOS device (needs to be real device, not Chrome preview)
You will now see a distorted background image, if the content is long enough (archive page of blog with show full content enabled for example), you will barely see the image, as the pixels will be huge.
Reason: iOS uses the body height and not just the viewport height to calculate the size for the cover image.
Possible solution: Add a div with 100vw, 100vh, instead of using body. Not sure if ::after or ::before would work as well.
Tested with: Storefront on iPhone and iPad (both iOS 11)" apermo
5 42542 Simplify mysql_to_rfc3339() and document RFC3339 incompatibility Date/Time 4.4 normal normal Awaiting Review enhancement new has-patch 2017-11-14T13:27:15Z 2017-11-15T23:12:52Z "Erasing time zone with regular expression is redundant, since date can be just formatted in respective format.
Documentation needs correction since output is absolutely not compatible with RFC3339, only the more lax ISO8601 upstream from it." Rarst
1 42541 Wordpress HTTP Error When Publishing New Article General 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-14T12:02:21Z 2017-11-14T12:02:21Z "Well I have wordpress multi-site, one is on sub-domain.example.com and the other is on example.com/sub-folder.
It's been going quite good! But suddenly I faced this problem today! The sub-domain wordpress is fine. But when today I was trying to publish an article on the sub-folder, it said HTTP Error and didn't publish the article neither did it save it as draft. To check whether the problem is on my server or wordpress, I quickly went to the sub-domain wordpress and tried to publish another article over there, but it didn't cause any problem. My Wordpress Memory limits are 96MB on both sites and max limit is 256M on both sites.
What I must mention is when this error is given, the other wordpress site is also unavailable for a few seconds. And then both sites are back up and working.
Also Note that I can edit previous articles and update them without any error. This problem is only happening in new article publishing time.
The problems I was facing previously but didn't take any action because I thought the work is going on so let's not bother about it is, on the sub-folder site (current site which has current problem) used to show 500 Internal Server Error whenever I published new article, the site stayed down for a couple of minutes and then when it is up and running, the new article was published! So when I saw that I found my articles published, I didn't bother to do anything about it. But now I have no other choice but to fix it." iskybird
42536 Smoothen Plugin Updates Plugins normal normal Awaiting Review enhancement new 2017-11-14T02:55:30Z 2017-11-15T23:11:51Z "When about to select plugins to be updated, there's the button 'Update Plugins' (2 times). Having selected nothing I can click on it and it will take a few seconds making requests ending up in an error message.
I propose to either:
1. Inactivate the button(s) whenever selected plugins count is 0
2. Change the button to ""Update all plugins"", making it ""auto-select"" all possible one's OR
Add a new button to do so (eventually combined with 1.)
3. Something like that" Presskopp
1 42534 get_post_time is adding or dropping a day on the front end. Date/Time 4.9 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-13T15:33:20Z 2017-11-13T19:46:48Z "
Hello,
I found this bug when using (get_post_time), i have two examples 1. the normal way of pulling post through a theme and 2. pulling post through the rest api.
the issue is as followed:
1. if on post archive or home, the first item will have either (and this part changes) a +1 or -1 to the day the post was submitted, but only the first post
2. if i pull the post through the REST API, it does it to all post.
I have not tried every format, but the one i tried was this get_post_time(‘F d, Y’, true);
Please advice if i need to provide any additional details!" keyinora
2 42533 New pages scheduled via Customizer viewable as admin, 404 as visitor Customize 4.9 normal normal Future Release defect (bug) new 2017-11-13T15:12:36Z 2018-05-20T19:50:12Z "'''I'm not 100% if this is a bug, but here's the issue I am seeing:'''
If I add a new page via the Customizer and schedule the changes for 5 minutes in the future:
* As an admin viewing the '''Share Preview Link''', I can view the new page.
* As a visitor viewing the '''Share Preview Link''', I get a 404 when trying to access the new page.
----
I posted a Google Doc with steps to reproduce and screenshots here:
https://docs.google.com/document/d/1tiTjWjlUnVGNDaUZjFWmyg1BFRz6nF7tCTO-jjaXXUs/edit?usp=sharing
'''If the document is unreachable, here are the steps from the doc:'''
1. Install a new WordPress site via Softaculous
1. Install WordPress Beta Tester plugin and upgrade to latest WordPress versions:
1. Access the Customizer
1. Menus > Top Menu > Add Items > ''Add New Page'' '''New Page 1''' > Add
1. Schedule the changes for the future, like 1 hour in the future.
1. Copy the Share Preview Link, you’ll need it in step 10.
1. Click the Share Preview Link
1. Click the link in the menu for '''New Page 1'''. You’re currently logged in as an admin, and you can see it.
1. Logout of WordPress.
1. As a visitor, access the '''Share Preview Link''' (the link you copied in step 6).
1. Click '''New Page 1''' in the menu. You’ll get a 404.
This 404 I believe is a bug. If I’ve been working on ''New Page 1'' and I want a client to preview my draft, I would expect them to be able to see it without logging in.
" bwmarkle
1 42532 Custom post type : redirection bug after publish when cap edit_published_cpt is not set Role/Capability trunk normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-13T12:49:29Z 2017-11-16T07:09:49Z "For a custom post type (movie for example), if user have capability `publish_movies` but not `edit_published_movies`, when he publishes a new movie, he is redirected to `http://example.com/edit.php` instead of
`http://example.com/edit.php?post_type=movie`
I make a gif to illustrate this :
[[Image(https://media.giphy.com/media/xT0xeo4c4WIOKd4qFW/giphy.gif)]]
----
User role capabilities :
* edit_movies
* edit_others_movies
* publish_movies
* read
Custom post type settings :
{{{
$labels = array(
""name"" => __( ""Movies"", ""twentyseventeen"" ),
""singular_name"" => __( ""Movie"", ""twentyseventeen"" ),
);
$args = array(
""label"" => __( ""Movies"", ""twentyseventeen"" ),
""labels"" => $labels,
""description"" => """",
""public"" => true,
""publicly_queryable"" => true,
""show_ui"" => true,
""show_in_rest"" => false,
""rest_base"" => """",
""has_archive"" => false,
""show_in_menu"" => true,
""exclude_from_search"" => false,
""capability_type"" => ""movie"",
""map_meta_cap"" => true,
""hierarchical"" => false,
""rewrite"" => array( ""slug"" => ""movie"", ""with_front"" => true ),
""query_var"" => true,
""supports"" => array( ""title"", ""editor"", ""thumbnail"" ),
);
register_post_type( ""movie"", $args );
}}}
" ajoah
42527 "Admin menus: PHP warning ""open_basedir restriction..."" when `_wp_menu_output` is called" Administration 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-13T10:13:25Z 2017-11-14T09:51:03Z "When plugins create certain kinds of administration menus, PHP warnings can occur when those menus are rendered. Although it's the plugin that generates the menu, it's the WordPress core code that is responsible for the warnings.
There may be related situations under which PHP warnings may occur during administration menu rendering, but the ones I've observed are, in summary:
* When the PHP setting `open_basedir` is used.
* When PHP is running under a Windows operating system.
* When a plugin generates an administration menu featuring an external URL.
Possible related issues are...
* ticket:25048 -- file_exists check in menu-header.php causes issue with backend menu on an IIS server
* ticket:0132 -- PHP Warning at menu-header.php line 118
=== Steps to Reproduce
1. Preparation:
(a) Make a website testing area running under a Windows operating system. I tested with Windows 7.
(b) Have a web server installed. I tested with Apache 2.2.
(c) Have MySQL installed and prepare necessary user accounts and databases. I used MySQL 5.6.
(d) Have PHP installed and configured so that the `open_basedir` setting is ''not'' used (the test plugin will do that). I tested with PHP 7.1.5. Ensure PHP error logging is enabled.
2. Install WordPress 4.8.3.
3. Create a directory `wp-content/mu-plugins`.
4. Put the file `test.admin.menu.php` (attached) into that directory.
5. Log into WordPress as administrator.
6. Go to the dashboard.
7. Check that the ""NaNoWriMo"" menu appears.
8. Click the ""Info"" sub-menu under ""NaNoWriMo"".
=== Expected Behaviour
The ""National Novel Writing Month"" information page should appear in the dashboard. Below the info, there should be only one error message displayed as ""test error, please ignore"".
=== Actual Behaviour
In addition, there is an ""open_basedir"" error message displayed. This message may also appear in the PHP error log.
The above happens when PHP runs under Windows. Under Linux, the behaviour is as expected, with no extra warning messages.
=== Impact
The administrative menus are created correctly and behave as expected, however, there are PHP warning messages generated when those menus are rendered by `wp_menu_output()` in `wp-admin/menu-header.php`.
The problem may seem relatively benign, but it could lead to bloated logs. It may also indicate more serious underlying issues.
=== Analysis
The issue occurs when an administration menu (or sub-menu) with an external URL is created. The WordPress core attempts to make a file system path out of this URL, then checks for its existence. For example:
`{DOCUMENT_ROOT}/wp-content/plugins/https:/nanowrimo.org`
While this kind of operation may not be inherently dangerous, and does not seem to cause warnings unless the `open_basedir` PHP setting is used, concatenating URLs to file system paths is not an algorithmically correct thing to do." darkskipper
1 42522 Terms are uselessly counted when saving a post Taxonomy 3.3 normal normal Awaiting Review defect (bug) new has-patch 2017-11-12T17:37:07Z 2017-11-13T08:50:10Z This occurs even when terms have not been modified and when the post status has not changed. This is due to `_update_term_count_on_transition_post_status` not checking if the post status has been modified. Chouby
42521 create WP_DROPDOWN function Administration low normal Awaiting Review feature request new close 2017-11-12T17:25:42Z 2017-11-13T01:40:30Z "there are bunch of dropdown functions,
like wp_categories_dropdown(), wp-pages-dropdowns, users and etc (i dont remember even).
It was good, there was common `wp_dropdown` function, which will accept $type as argument (or in array):
{{{
wp_dropdown(array('type'=>'pages', ..... ))
or
wp_dropdown(array('type'=>'categories', ..... ))
or
wp_dropdown(array('type'=>'users', ..... ))
or so on
}}}
" tazotodua
2 42520 "A Dot at the end of message ""WordPress successfully updated"" is missing" Upgrade/Install 4.9 normal normal Awaiting Review enhancement new has-patch 2017-11-12T16:10:18Z 2017-11-12T17:23:27Z "The Original String ""WordPress successfully updated"" is missing a dot at the end of the sentence. See:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-automatic-updater.php?marks=349#L349
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/update-core.php?marks=1258#L1258
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/update-core.php?marks=510#L510
We have a dot at the end of each message which informs about a successful update. Here are simular text strings, that all have a dot at the end:
https://translate.wordpress.org/projects/wp/dev/admin/de/default?filters%5Bterm%5D=wurde+erfolgreich+aktu&filters%5Buser_login%5D=&filters%5Bstatus%5D=current&filter=Filter&sort%5Bby%5D=references&sort%5Bhow%5D=desc
" transl8or
1 42519 Links in AutoUpdate-Mail contain horizontal ellipsis, which causes broken links Upgrade/Install normal minor Awaiting Review defect (bug) new close 2017-11-12T15:20:00Z 2017-11-17T12:39:15Z "The two textstrings, that appear in an email ...
""Downloading update from %s…""
+
""Downloading translation from %s…""
contain a horizontal ellipsis at the end which is not excluded from the link (href).
This does create broken links in the email that informs users about the update or upgrade of their WordPress and translations.
Links to the strings:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-language-pack-upgrader.php?marks=116#L116
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-core-upgrader.php?marks=33#L33
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-plugin-upgrader.php?marks=50#L50
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-theme-upgrader.php?marks=49#L49
I add a screenshot of a german mail where you can see the broken links.
(I've currently deleted the horizontonal ellipsis in the two strings of the german translations, but thats not a solution for all the other translated languages out there.)
" transl8or
42517 get_file_data() doesn't support the single-line variant of post template headers General 4.9 normal normal Awaiting Review defect (bug) new needs-unit-tests 2017-11-12T13:05:45Z 2017-11-13T17:24:40Z "get_file_data() is the common function used to retrieve information stored in a file's header comment. The function works fine for Plugin files and Theme style.css files, but is currently not used by the functions enumerating post templates, despite their header format being a clear subset of the same grammar.
The issue comes from the fact that post templates have traditionally supported single-line header comments, of the form:
{{{#!php
}}}
or even
{{{#!php
# Template Name: Full-Width ?>
}}}
Addressing this inconsistency will allow post templates to use the same file-handling function that other theme/plugin files use, and will significantly reducing the amount of potential data parsed by WP_Theme::get_post_templates() see issue [https://core.trac.wordpress.org/ticket/42513 #42513]" gschoppe
42513 WP_Theme::get_post_templates() is extremely inefficient for large themes Themes 4.8.3 normal normal Awaiting Review defect (bug) new needs-unit-tests 2017-11-11T14:07:01Z 2017-11-12T13:13:42Z "WP_Theme::get_post_templates() uses file_get_contents() to read the complete contents of each theme php file in the root of a theme into memory, twice, and processes the result with a custom Regular Expression.
As a result, significantly more data than necessary is processed when loading large themes.
In addition, because the standard get_file_data() function is not called (as it is with all other header comments), the ""extra_{$context}_headers"" filter is never called, which is inconsistent behavior with other file_header related operations, such as the WP_Theme constructor." gschoppe
1 42512 Domain with special character redirect loop on homepage Canonical 4.5 normal normal Awaiting Review defect (bug) new 2017-11-11T11:31:53Z 2018-03-14T01:39:00Z "Hi,
i am experiencing a problem with wordpress starting with 4.5 i think.
Since this commit [1] i always get redirect loops on the home page. this issue seemed to be fixed, and i can confirm this on various wordpress instances.
But one instance has a '''domain with a special character''' (""ö"" - german Umlaut), and the problem persists there.
Also i am not the only user who can confirm this issue [2].
Currently i have to reset the line [3] to the old value after every update since it gets overwritten. This is not a solution, only a very bad workaround.
Of course i already have tried to disable all plugins, themes etc. which could cause the issue. I can say, that the problem is not caused by the hoster since i have many wordpress instances running on the same hoster and no other does have this problem (and no other have a special character in the domain)
Regards
[1] https://github.com/WordPress/WordPress/commit/84a3b4407f9e03311aa591004f3bec0639f3ba3f?diff=unified
[2] https://wordpress.org/support/topic/45-causes-infinite-redirect-on-static-front-page/page/2/#post-8156893
[3] https://github.com/WordPress/WordPress/commit/84a3b4407f9e03311aa591004f3bec0639f3ba3f?diff=unified#diff-dc3247fd3fa65f15e6fc5ce8c6fa2d42L175" stefan-niedermann
2 42511 register_activation_hook with MultiSite General normal normal Awaiting Review feature request new 2017-11-11T10:54:23Z 2017-11-11T10:54:23Z "I think, it will be good, if any parameter/method will be added with that function, like:
{{{
register_activation_hook(__file__ ,'myFunc', $FORCE_MULTISITE_BLOGS = true);
}}}
where the third parameter will indicate, if the activation happens in Network (multisite) dashboard, then the plugin should be activated for each sub-blog.
There is one problem:
{{{
define('variable_XYZ', home_url() );
function myFunc(){
update_option('smth', variable_XYZ );
}
}}}
so, if just ""myFunc"" will be executed in the loop for each sub-blog, then there will be problems... So, I think, whole plugin should be ""sandboxed"" (i dont know what termin should be used) and whole plugin activation should happen for each sub-site, and not just ""myFunc""." tazotodua
2 42509 Document expected parameters passed to callback functions General normal minor Future Release enhancement new has-patch 2017-11-10T22:31:46Z 2017-11-10T22:36:46Z "Around eighty function parameters in WordPress accept a callback function (documented with the `callable` type), but none of these parameters document the expected parameters that get passed to the callback function.
phpDocumentor doesn't have a syntax for this. It's currently [https://github.com/phpDocumentor/phpDocumentor2/issues/1712 being discussed] but isn't a high priority.
I think it's safe to say that the following syntax is the most sensible and the most similar to the existing associative array parameter notation:
{{{#!php
/**
* @param callable $callback {
* The callback function description.
*
* @type string $one A string.
* @type int $two An integer.
* @return string A nicely formatted string.
* }
*/
function foo( $callback ) {
echo call_user_func( $callback, 'one', 2 );
}
}}}
The `@return` notation for the callback could also be specified, but we'd need to check whether it interferes with the docs parser and fix it if so.
Let's start with a couple of instances and once we're happy with the syntax, go from there." johnbillion
2 42500 Enable Revisions when there is 1 Revisions 3.6 normal normal Awaiting Review defect (bug) new 2017-11-10T07:55:21Z 2018-03-09T23:54:00Z "Hello,
I was trying to get revisions to appear for a post and found that it requires 2 revisions to operate due to the conditional;
{{{
if ( count( $revisions ) > 1 ) {
}}}
https://github.com/WordPress/WordPress/blob/a72be13ec0b57a2831d75540fd1892d1bd121f3b/wp-admin/edit-form-advanced.php#L234
Can this be amended to be > 0 or event just `if ( count( $revisions ) ) {`
Thanks" garrett-eclipse
42496 Add CSSTidy in WP General normal normal Awaiting Review feature request new 2017-11-09T21:14:17Z 2017-11-09T21:14:17Z "On [https://codex.wordpress.org/Function_Reference/wp_add_inline_style | Add Inline CSS] page, there is said, that best thing to filter inline css is to use CSS-Tidy.
Why not WP automatically include the sanitization for wp_add_inline_style?
I think, it could be useful, yeah?
" tazotodua
1 42487 Avoid redundant crops for all Customizer media controls. Media normal normal Awaiting Review enhancement new needs-unit-tests 2017-11-09T17:09:17Z 2017-11-09T17:09:17Z "In WordPress 4.9, we made use of context metadata to keep from producing redundant crops in the media library for custom headers (see #21819). We should extend this behavior to all other media controls in the Customizer (e.g., custom logos, site icon, etc.).
There are a few parts to the implementation to keep in mind:
1. We should only create one cropped attachment per context for a given site/theme option. So for instance, if a custom logo has already been cropped from an attachment for the theme being customized, we should replace that attachment instead of creating a new one. However, we ''should'' create a new attachment if the crop was created for a different theme (this may not apply to site-level settings).
2. The context of an attachment should be included in the JSON model returned by `wp_prepare_attachment_for_js()` and used to filter contextual crops out of the main media attachment library. However, it would be great if those were ''not'' filtered when you've opened the media library from the context which those attachments are created/selected." joemcgill
42484 WP ajax call fail when executing long time 'ERR_SPDY_PROTOCOL_ERROR'. Media 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-09T12:18:18Z 2017-11-09T12:38:47Z "Hello,
I have one ajax script that is uploading 25MB video on server and convert on server. This core process doing by only WordPress ajax file. This process is run successfully but after uploading and conversion ajax automatically fail and give me this error ""ERR_SPDY_PROTOCOL_ERROR"". This error i am facing from last update(4.8.3). so i think there is issue regarding ajax call in WordPress 4.8.3 version.
I am WordPress Developer with 6+ years of experience and i have found this bug. Please review this bug.
There is attach one image related to error.
[[Image(http://webidroid.com/WP_ajax_err.png)]]
" gaurangsondagar
2 42481 Test cookie secure flag prevents non-secure login Login and Registration 4.9 low normal Awaiting Review defect (bug) new 2017-11-09T01:30:29Z 2017-11-28T00:20:03Z "Once a user has accessed the login form over https (possible without a valid ssl license, ignoring the browser warning) the WordPress TEST_COOKIE will have the secure flag set https://core.trac.wordpress.org/browser/trunk/src/wp-login.php#L433
When that user goes back to login over http, this will no longer be possible. The test cookie will be ignored by the browser because of the secure flag.
Without the test cookie, all login attempts will be redirected back to the login form with a warning about cookies not being set by the browser. Most users will not know why this happens and will no longer be able to log in.
The user will have to go back to https, open the developer toolbar, delete the cookie and then back to http. Only then the test cookie will be set again, this time without the secure flag.
A work-around to prevent users from being locked out like this, is to make the test cookie name ""http/s aware"" with something like this in wp-config.php:
{{{
$secure = ( isset($_SERVER['HTTPS']) && 'on' == $_SERVER['HTTPS'] ) ? '_sec' : '';
define( 'TEST_COOKIE', 'wordpress' . $secure . '_test_cookie' );
}}}
(using wordpress_sec for secure cookie similar to the auth cookie)
But... the real question is:
'''Why does the test cookie need the secure flag at all?'''
There is no sensitive information passed and it's only there to (as the name suggests) test for cookie unaware or blocking browsers. At least as far as I can tell, there would be no possible problem with simply removing this cookies secure flag. This will not affect any sensitive login/session cookies secure flags.
Or am I mistaken? Are there use cases where the browser can be set to accept cookies over https while blocking them over http?
" RavanH
1 42478 Add_permastruct ignores EP_NONE and other args if %post_id% is present in struct Rewrite Rules 4.9 normal normal Awaiting Review defect (bug) new 2017-11-08T22:15:20Z 2017-11-08T22:15:20Z "Additional rewrite rules are made if the %post_id% is in a struct passed to add_permastruct. This happens because generate_rewrite_rules (called in to process the permastructs) assumes anything with %post_id% in its struct is a post and should have attachments, talkbacks, comments, etc. I suspect it's holdover from when %post_id% and p= only referred to posts and post_ids from the wp_posts table at large.
I have a simple enough solution.
Add another default rewrite_tag that generates the 'p=' query but doesn't trigger the additional rewrites.
i.e. add_rewrite_tag( '%p%', '([0-9]+)', 'p=' );" Underscorefunk
42477 Cannot save theme customizer changes if nonce_life value is filtered in the active theme Customize 4.8.3 normal normal Awaiting Review defect (bug) new close 2017-11-08T21:59:47Z 2017-11-10T01:31:47Z "Summary:
If the `nonce_life` filter is used in the active theme to change the nonce lifetime from its default 86400 (e.g., to 3600), then changes made in the Theme Customizer cannot be saved.
Details:
WordPress 4.8 introduced some changes to the theme customizer, including this security-related commit that clears submitted post data if the nonce check fails:
https://github.com/WordPress/WordPress/commit/3d10fef22d788f29aed745b0f5ff6f6baea69af3#diff-681a4f686cf806e75ff8cd4c6d2fe5b7
This introduces an unintended side effect in a certain context:
* Since this code is hooked into `setup_theme`, it fires before the theme is loaded.
* If a theme developer hooks into the `nonce_life` filter that can be used to adjust the lifespan of nonces, it will cause the nonce check above to fail (since the nonce ticks will not match).
https://developer.wordpress.org/reference/hooks/nonce_life/
https://github.com/WordPress/WordPress/blob/master/wp-includes/pluggable.php#L1999
This specific context happens in the theme customizer, when trying to //Save & Publish// changes. Interestingly, changesets can still be saved as an auto-draft on window blur (clicking outside of the browser window). I believe this is because changeset data is in `$_POST['customize_changeset_data']`, while the same data is in `$_POST['customized']` when the //Save & Publish// button is clicked.
I think the best solution here may be to remove the `nonce_life` filter, but I don't know how widely it's used. Another possibility may be moving the nonce check out of `WP_Customize_Manager::setup_theme()`, but I don't have a good idea at the moment for where it should go." figureone
1 42474 bulk_edit_posts should honor the show_in_quick_edit property of taxonomies Quick/Bulk Edit 4.2 normal normal Awaiting Review defect (bug) new has-patch 2017-11-08T20:20:08Z 2017-11-08T20:22:58Z "When bulk editing posts, several database queries are related to taxonomies for which `show_in_quick_edit` is set to false. Since the terms are not modified, these queries uselessly harm the performance.
This is because `bulk_edit_posts` does not check this property when building arguments to pass to `wp_update_post`." Chouby
1 42473 Categories List on Post page Errors General 4.9 normal normal Awaiting Review defect (bug) new 2017-11-08T19:45:27Z 2017-11-08T19:45:27Z Installed WordPress 4.9-RC2-42125 running Outreach Pro theme. Elected to edit a post and found Custom Categories List not displaying at all. See error in attached text file. I'm not a pro but maintain a business site and am testing 4.9 on local wamp server 3.0.6 development site before official release. Same error when creating new Post. Categories are critical to the posts for this site. mrm2016
1 42470 add_image_size: incorrect relative scaling Media 4.8.3 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-08T16:53:00Z 2017-12-18T03:21:56Z "Wordpress seems to mess up relative image scaling with add_image_size.
The code of my child theme reads:
{{{
}}}
With the '9999' based on [https://developer.wordpress.org/reference/functions/add_image_size/#other-notes]
Upon entering a landscape image w2500 x h1250 the image is resized to w525 x h263, taking the longest side of the image as height, instead of the actual height (in this case 1250px). Portrait images are (of course) resized according to their height (which is their longest side).
" the_Alien_01
42469 WP_Query found_posts inconsistent data type. Query normal normal Awaiting Review defect (bug) new dev-feedback 2017-11-08T16:34:21Z 2017-11-12T14:26:53Z PressLabs
1 42468 Iron out the usage of 'homepage', 'home page', 'front page' Text Changes normal normal Awaiting Review defect (bug) new 2017-11-08T14:41:43Z 2018-04-15T16:37:01Z "As discussed in #41828, I think we need clarification of the usage of 'Homepage' vs. 'Home Page' or 'Front Page'.
In german we used to differ the homepage from a 'start page', see screenshot.
Can I assume it' all the same, like the french do?
Quoting @fxbenard:
We made the choice to always translate it the same way in FR, no more consistency issues" Presskopp
1 42466 HTTP status code is wrong on setup error General normal normal Awaiting Review defect (bug) new dev-feedback 2017-11-08T07:10:44Z 2017-11-30T03:46:19Z Since setup error and http status are not matched, it is necessary to correct it. linyows
2 42459 "Comments metabox doesn't load all the comments when clicking ""Show more comments"" link" Comments 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-07T18:04:17Z 2018-01-02T12:25:59Z "Recently, I found an issue related to the Comments meta-box on a post edit screen. To reproduce the bug, go to the article with a certain number of comments. Suppose there are 25 comments. Then go to the post edit screen, enable the comments and scroll down to view all the comments(you will see 10). Then click the link ""Show more comments"" at the bottom of the section. You will see the second part of the comments (10 again), and the link ""Show more comments"" will disappear. You may notice that you can't load the remaining comments(5).
Why this happened? My short investigation below.
I found that on my opinion there is a mismatch in amount of loaded comments between the ''commentBox'' object(`/wp-admin/js/post.js`) and comments meta-box init script(`/wp-admin/includes/meta-boxes.php`).
First have a look at `/wp-admin/includes/meta-boxes.php:741`
{{{#!php
}}}
As you can see there are 10 comments set to be loaded.
Then go to `/wp-admin/js/post.js:42-45`
{{{#!js
if ( ! num )
num = 20;
this.st += num;
}}}
As you can see there is default `num` value set to 20. Important: then commentBox.st was increased by a `num` value.
But now have a look at ""Show more comments"" link onclick attribute.
{{{#!php
Show more comments
}}}
As you can see `commentsBox.load(26)` call will update `commentBox.st` but then `commentBox.get(26, 20)` will be called (because `num = 20`). But to fit the init script(`meta-boxes.php`) it should be `commentBox.get(26, 10)`.
My solution here is to set default `num` value to 10. So I guess `/wp-admin/js/post.js:42` should looks like this:
{{{#!js
if ( ! num )
num = 10;
}}}
Let me know if I missed something and we can't accept new default `num` value.
I have tested it on my local end. It works well after I changed `num` default value to 10." rku4er
1 42455 WordPress Class methods and Single Responsibility (recent posts widgets) Plugins 4.9 normal normal Awaiting Review enhancement new 2017-11-07T13:24:34Z 2017-11-07T13:24:34Z "WordPress uses PHP Classes a lot and this is great for extending and improving. The problem is, many class methods does a lot of things at once and this doesn't help extending at all.
For instance, I'm trying to extend the Recent Posts Widget (`WP_Widget_Recent_Posts`).
The plugin has it's internal settings and logic, query posts and apply filters.
I want to change it's render method, but just that. Don't want to mess with the plugin logic.
The problem is, the render method (`widget` method) does a lot of things instead of focusing only on rendering. This forces me to copy every logical actions and reproduce them on my extending class.
This could be solved by just splitting the plugin logic and rendering in separated functions (an function to get the posts and filters, separated from the `widget` function).
This would improve a lot the WordPress extending by plugins and themes. If we apply the single responsibility principle on WordPress classes and functions, plugins wouldn't need to have much more code.
Another point: this enhancement wouldn't impact old plugins/themes if the functions signatures keep the same." viewup
42451 Fix WordPress UTC Time not correct issue Date/Time 4.8.3 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-07T00:44:20Z 2018-03-12T14:07:10Z "in wp-includes/functions.php, look for
{{{
case 'timestamp':
return ( $gmt ) ? time() : time() + ( get_option( 'gmt_offset' ) * HOUR_IN_SECONDS );
}}}
change to
{{{
case 'timestamp':
//return ( $gmt ) ? time() : time() + ( get_option( 'gmt_offset' ) * HOUR_IN_SECONDS );
return ( $gmt ) ? strtotime(gmdate('Y-m-d H:i:s')) : strtotime(gmdate('Y-m-d H:i:s')) + ( get_option( 'gmt_offset' ) * 3600 );
}}}
This issue because of php timestamp function." taojing10
3 42448 Add 'upgrader_pre_unpack' hook Upgrade/Install normal normal Awaiting Review enhancement new has-patch 2017-11-06T21:38:50Z 2017-11-19T15:53:27Z The `WP_Upgrader` class provides several hooks that can be used to modify the upgrader process. There is an `'upgrader_pre_download'` hook, for example. But there is no hook that fires after download but before the package is unpacked. It would be nice to add such a hook, which for example could be used to verify a package's signature, or override the unpacking code entirely. jdgrimes
42446 "Bulk edits don't update ""last edited by..."" which user" Administration 4.9 normal normal Awaiting Review defect (bug) new 2017-11-06T19:35:38Z 2017-11-06T19:35:38Z "On a multi-author site, I made some bulk edits to some posts' categories. These posts were previously created and last updated by other users.
In the editor for the individual posts, it now says ""Last updated by [previous user] on [date and time I made the changes]"", which is incorrect. It looks like the bulk editor doesn't update which user last edited a post, though it does update the last modified time.
I would expect it to say ""Last updated by [my username]..."" - which is what it does if I quick edit an individual post, or change the categories on the full post edit page.
I've found the same behaviour on two different sites, and both on standard pages and categories, and on a custom post type and custom taxonomy." calebwoodbridge
1 42444 Quotes in post title are not searched correctly when on mobile Administration normal normal Awaiting Review defect (bug) new 2017-11-06T16:56:43Z 2017-11-06T16:56:43Z "Reported in https://github.com/woocommerce/woocommerce/issues/17564 but affects all post types.
To reproduce the issue:
1. Create a post with a quote in the title e.g. ""Hello World Y'all"" using desktop browser.
2. Search for ""Y'all"" in desktop browser. Results found.
3. Search for ""Y'all"" on mobile (I used xcode simulator to simulate iPhone). No results.
Looks like some kind of weird encoding bug." mikejolley
3 42441 Disable autoload for large options Options, Meta APIs normal normal Awaiting Review defect (bug) new 2017-11-06T02:20:50Z 2017-11-06T02:20:50Z "A frequent issue I encounter with WordPress sites is extreme slowdown due to a huge option that is being autoloaded. Sometimes this is some sort of cache option that a careless plugin has let be autoloaded, and has grown to tens of megabytes.
Having an option this large be autoloaded not only slows downs the options loading query (when that option may not be required on every load), but on sites with object caching, it causes a lot of wear and tear on the alloptions cache. Combine a large option with a frequently updated option and you have a recipe for a very sluggish site.
We should consider preventing options from being autoloaded if they grow to a certain size. Off the top of my head, 100kb sounds like a reasonable upper bounds. We could monitor option settings/updates and peek at the size of the option going in. If it's above a certain (filterable) bounds, we can force autoload to be off." markjaquith
42440 Uncaught TypeError: $(...).wpColorPicker is not a function Script Loader 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-05T23:30:56Z 2017-11-06T00:56:47Z "I can't edit my page using Page Builder because the next Error
{{{
gdlr-admin-panel-html.js?ver=f63693efb5b9a5e10ac3abbd57323a6b:192 Uncaught TypeError: $(...).wpColorPicker is not a function
at HTMLDocument. (gdlr-admin-panel-html.js?ver=f63693efb5b9a5e10ac3abbd57323a6b:192)
at i (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,plupload&ver=f63693efb5b9a5e10ac3abbd57323a6b:2)
at Object.fireWith [as resolveWith] (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,plupload&ver=f63693efb5b9a5e10ac3abbd57323a6b:2)
at Function.ready (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,plupload&ver=f63693efb5b9a5e10ac3abbd57323a6b:2)
at HTMLDocument.K (load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils,plupload&ver=f63693efb5b9a5e10ac3abbd57323a6b:2)
}}}
Can you help please?" shamstarek
4 42437 Thumbnails can overwrite other uploads if filename matches Upload 4.8.3 normal normal Future Release defect (bug) new 2017-11-05T00:40:36Z 2018-05-17T10:31:36Z "Imagine you're browsing some WordPress site and you find an image ~~you want to steal~~ you like and want to upload to your own site. Not knowing any better, you download and save a thumbnail, `image-1024x768.png`. Later on you upload a different image called `image.png` to your site. Assuming you haven't changed thumbnail sizes, the large thumbnail of the second image will overwrite the original first image.
I've attached two images that you can use to test. Notice that `image-1024x768.png` will become the red image instead of staying green.
One possible solution to this is to add a flag to the thumbnail generation function that toggles overwriting existing files. It should default to overwriting for backwards compatibility but not overwrite on initial upload. If not overwriting, then `-2` could be added somewhere in the filename. The filename doesn't need to be predictable because it's stored in the metadata." Viper007Bond
42432 Upload image without cropping Media normal normal Awaiting Review feature request new 2017-11-03T19:29:16Z 2017-11-03T19:29:16Z "Sometimes we know exactly that uploaded image don't need to be cropped.
Maybe checkbox - ""upload without cropping""." web2033
42429 Incorrect access level on $message property in class getid3_exception General 4.8.3 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-11-03T10:18:59Z 2017-11-03T22:05:34Z "In the file: wp-includes/ID3/getip3.php
on line: 1795
{{{
class getid3_exception extends Exception
{
public $message;
}
}}}
Should be
{{{
class getid3_exception extends Exception
{
protected $message;
}
}}}
" yrpwayne
42428 wp-emoji pops up privacy hanger in Firefox with privacy.resistFingerprinting turned on Emoji 4.1.2 normal normal Future Release defect (bug) new 2017-11-03T09:56:10Z 2018-03-02T01:42:43Z "This isn’t really a bug, but worth reporting anyway.
wp-emoji uses a technique that’s often used by trackers for fingerprinting clients: reading canvas pixel data. For them, differences in OS and graphics drivers can lead to subtle differences when text is rendered to a canvas. This means that when they hash data read out of the canvas with text on they have another datapoint to identify a client.
To work around this, Firefox has recently uplifted a technique from TOR Browser. If you visit a site that tries to do this it’ll pop open a hanger asking for the user’s permission. You can test this by downloading a copy of Firefox Nightly, going to about:config and setting privacy.resistFingerprinting to true. Which brings us on to WordPress…
Unfortunately the default wp-emoji package also uses this technnique, which triggers a browser warning on a large number of sites I visit on a daily basis. While I doubt that Wordpress is using this for user tracking, it means that sites that are being nefarious get lost in the Wordpress noise. This is a shame, but also I would imagine that it would be hard for Firefox to turn this on by default given the number of sites out there using Wordpress.
What I’d like to suggest is that:
1) wp-emoji is reviewed to see whether this technique is necessary for its functionlity. Can it be updated to use some other technique?
2) wp-emoji is considered for removal by default. According to the docs wp-emoji ‘will convert the often greyscale Emoji characters to colored image files.‘ Is this really a problem with the current set of browsers?
" robinwhittleton
1 42423 redirect_guess_404_permalink passes array of post types with single placeholder Canonical 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-02T20:02:01Z 2017-11-02T20:02:01Z "I am not familiar enough with WordPress to know if this is an issue or intended.
redirect_guess_404_permalink has a block that looks like:
wp-includes/canonical.php:594
{{{#!php
// if any of post_type, year, monthnum, or day are set, use them to refine the query
if ( get_query_var('post_type') )
$where .= $wpdb->prepare("" AND post_type = %s"", get_query_var('post_type'));
else
$where .= "" AND post_type IN ('"" . implode( ""', '"", get_post_types( array( 'public' => true ) ) ) . ""')"";
}}}
This works in the case that post_type is a single value, but if it has been changed to an array of values then this looks to trigger the warning:
wp-includes/wp-db.php:1353
{{{#!php
_doing_it_wrong( 'wpdb::prepare', __( 'The query only expected one placeholder, but an array of multiple placeholders was sent.' ), '4.9.0' );
}}}" augustuswm
1 42422 'unique' index not removed from the 'slug' column of the 'wp_terms' table Taxonomy 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-02T19:07:15Z 2017-11-11T18:10:02Z "This is a follow-up to #22023.
It appears that on one of my older installations of wordpress the unique index was never removed from the 'slug' column of the 'wp_terms' table. The latest update 4.8.3 must have stirred something up with wp cron, conflicting with the unique status of the column. This has caused thousands of the following errors to be logged which in turn caused our server to 503 due to hitting the PHP FcgidMaxProcessesPerClass limit.
Note: this installation has had regular updates since being installed years ago.
{{{
stderr:
WordPress database error Duplicate entry 'category-slug' for key 'slug' for
query INSERT INTO `wp_terms` (`name`, `slug`, `term_group`) VALUES ('Category Name', 'category-slug', 0) made by do_action_ref_array, WP_Hook->do_action,
WP_Hook->apply_filters, _wp_batch_split_terms, _split_shared_term
}}}" joellisenby
2 42421 "Move ""Filter by"" strings into labels arrays of registrations" nicolalaserra Administration normal normal Awaiting Review enhancement assigned dev-feedback 2017-11-02T17:47:44Z 2018-02-08T15:39:08Z "WordPress admin includes a few ""Filter by"" strings. They are largely used in screen-reader text.
* ""Filter by category"" is used 2 times
* ""Filter by type"" is used 1 time in media
* ""Filter by comment type"" is used 1 time in comments
* ""Filter by date"" is used once as a generic List Table string
The first 3 could be included as part of the post type and taxonomy labels. The last 1 is in the `months_dropdown()` method in the base list table class, and I guess could go either way.
The benefit of adding these to the labels arrays is these strings can be re-used in other places, not repeated, and custom post types and taxonomies won't need to hard-code their strings in with their mark-up, and can instead register them with the other labels." johnjamesjacoby
42419 Text widget accepts invalid media URL General 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-02T12:37:02Z 2017-11-12T12:13:58Z "
I am noticed that text widget accepts invalid URL.
Steps to Repro:-
1) Select text widget from the “Appearance–>Widgets”
2) Click on “Add Media” button.
3) Click on “insert from URL”.
4) Add a invalid URL like “jnwfjkewwwnnwfkjfkjewkjfnkje”.
5) Click on “insert into post” button.
6) Click on “Done”
" nirmalcm
42417 Ability to reset site in Network Networks and Sites normal normal Awaiting Review feature request new 2017-11-02T08:29:22Z 2017-11-02T08:29:22Z "Edit | Dashboard | Deactivate | Archive | Spam | Delete | Visit | '''Reset'''
Add ""Reset"" link that will delete all data and will restore a site to an initial state." web2033
42412 Calling get_current_user_id() and setting $current_user gives unexpected behaviour General 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-02T01:19:30Z 2017-11-02T01:19:30Z "Steps to reproduce, paste this code in functions.php
{{{#!php
';
echo '$current_user global? ';
echo array_key_exists('current_user', $GLOBALS)?""true"":""false"";
echo get_current_user_id() . '';
echo '$current_user global? ';
echo array_key_exists('current_user', $GLOBALS)?""true"":""false"";
echo get_current_user_id() . '';
echo get_current_user_id() . '';
echo '----echo $current_user after 1 call----';
$current_user = get_current_user_id();
echo $current_user . '';
echo $current_user . '';
echo $current_user . '';
echo '----echo $current_user, 1 call each time----';
$current_user = get_current_user_id();
echo $current_user . '';
$current_user = get_current_user_id();
echo $current_user . '';
$current_user = get_current_user_id();
echo $current_user . '';
$current_user = get_current_user_id();
echo $current_user . '';
$current_user = get_current_user_id();
echo $current_user . '';
echo '----echo $current_user, $current_user = 5 before each call----';
$current_user = 5;
$current_user = get_current_user_id();
echo $current_user . '';
$current_user = 5;
$current_user = get_current_user_id();
echo $current_user . '';
$current_user = 5;
$current_user = get_current_user_id();
echo $current_user . '';
$current_user = 5;
$current_user = get_current_user_id();
echo $current_user . '';
$current_user = 5;
$current_user = get_current_user_id();
echo $current_user . '';
echo '----echo $current_user, $current_user = 5 NO call----';
$current_user = 5;
echo $current_user . '';
$current_user = 5;
echo $current_user . '';
$current_user = 5;
echo $current_user . '';
$current_user = 5;
echo $current_user . '';
$current_user = 5;
echo $current_user . '';
echo '----echo $cu, 1 call each time---';
$cu = get_current_user_id();
echo $cu . '';
$cu = get_current_user_id();
echo $cu . '';
$cu = get_current_user_id();
echo $cu . '';
$cu = get_current_user_id();
echo $cu . '';
echo '----echo $current_user_1, 1 call each time----';
$current_user_1 = get_current_user_id();
echo $current_user_1 . '';
$current_user_1 = get_current_user_id();
echo $current_user_1 . '';
$current_user_1 = get_current_user_id();
echo $current_user_1 . '';
$current_user_1 = get_current_user_id();
echo $current_user_1 . '';
echo '----echo $current_user->ID ----';
$current_user = wp_get_current_user();
echo $current_user->ID . '';
$current_user = wp_get_current_user();
echo $current_user->ID . '';
$current_user = wp_get_current_user();
echo $current_user->ID . '';
$current_user = wp_get_current_user();
echo $current_user->ID . '';
echo '----echo $current_user_obj->ID ----';
$current_user_obj = wp_get_current_user();
echo $current_user_obj->ID . '';
$current_user_obj = wp_get_current_user();
echo $current_user_obj->ID . '';
$current_user_obj = wp_get_current_user();
echo $current_user_obj->ID . '';
$current_user_obj = wp_get_current_user();
echo $current_user_obj->ID . '';
}
}}}
That outputs:
{{{
----echo get_current_user_id()----
$current_user global? false
1
$current_user global? true
1
1
----echo $current_user after 1 call----
1
1
1
----echo $current_user, 1 call each time----
0
1
0
1
0
----echo $current_user, $current_user = 5 before each call----
0
0
0
0
0
----echo $current_user, $current_user = 5 NO call----
5
5
5
5
5
----echo $cu, 1 call each time---
0
0
0
0
----echo $current_user_1, 1 call each time----
0
0
0
0
----echo $current_user->ID ----
0
0
0
0
----echo $current_user_obj->ID ----
0
0
0
0
}}}
Issue in _wp_get_current_user() ?
Using php 7.0" gertmeeusen
42410 wpautop() breaks HTML (missing start tag p) Formatting 4.7 normal normal Awaiting Review defect (bug) new 2017-11-01T23:31:19Z 2017-11-01T23:31:19Z "Steps to reproduce:
1. Create new page with the following content:
{{{

Text

}}}
2. Preview post and inspect HTML output
Expected result:
{{{

Text

}}}
Actual result:
{{{

Text

}}}
" mar1in
42407 no notification for new comments Mail 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-01T22:30:51Z 2017-11-01T22:30:51Z "I installed a new wordpress-Instance on a webhoster-package.
I setup the wordpress Version 4.8.3.
I write an Article as admin or as an editor. The Article is saved correcly but when some writes a comment i don't get an E-Mail to moderate the comment/as info for new comment." amarradi
1 42405 Introduce singular capabilities for enabling individual themes on Multisite Role/Capability normal normal Future Release enhancement new needs-unit-tests 2017-11-01T22:14:24Z 2017-11-01T22:14:24Z "Related: #39083
The ability to enable or disable individual themes for a site from the Network Admin -> Sites -> Edit -> Themes screen should be controlled by singular capabilities.
* `enable_theme`
* `disable_theme`" johnbillion
1 42404 Introduce singular capabilities for managing individual plugins Role/Capability normal normal Future Release enhancement new needs-unit-tests 2017-11-01T22:11:24Z 2018-04-18T20:37:39Z "In #38652, singular capabilities were added for activating and deactivating individual plugins.
The same should be added for other management actions for plugins:
* `edit_plugin` (ability to adit plugin via the Plugin Editor)
* `delete_plugin` (ability to outright delete the plugin)
* `update_plugin` (ability to update a plugin)
Network activation and deactivation will be handled in #42403" johnbillion
42403 Introduce singular capabilities for network activating plugins Role/Capability normal normal Future Release enhancement new needs-unit-tests 2017-11-01T22:08:36Z 2017-11-01T22:08:36Z "In #38652, singular capabilities were added for activating and deactivating individual plugins.
The same should be added for:
* `network_activate_plugin`
* `network_deactivate_plugin`
" johnbillion
42398 WP_Query with parameter post id 'p'=0 is not considered as a single post request Query 4.7 normal normal Awaiting Review defect (bug) new close 2017-11-01T17:54:27Z 2018-03-26T19:57:07Z "Hi there,
I'm trying to run a 'dummy' main WP query requesting only the post ID = 0 for performance purpose (all my requests are performed using AJAX with secondary extended WP queries)
However WP_Query does not detect a single post request adding SQL clauses like 'LIMIT'
In the class-wp-query.php file, the PHP test to set single post is
{{{#!php
is_single = true;
}}}
that of course fails with 'p' = 0
Is that an expected behavior ?
I'm using the following code
{{{#!php
set('p', 0);
}
}}}
Thanks in advance,
" solo14000
1 42393 Enqueue CDN Script With Dependency General 4.8.1 normal normal Awaiting Review defect (bug) new close 2017-11-01T07:09:00Z 2017-11-01T12:03:04Z "If I try and enqueue a CDN script with a dependecy the page returns a 503 error.
{{{#!php
.......
}}}
One plugin, which tries to overwrite other meta tags, has to use the undesired approach:
get_ob_contents() --->then preg-replace the matched meta tags and etc...
you know 90% of WP sites HAS TO USE META TAGS, ESPECIALLY FOR FACEBOOK, TWITTER, G+ share tags and some other.
Cant WordPress create a new API to standartize the process, for example, in the Core, there was:
{{{
add_action('wp_head', 'add_meta_tags_in_head');
function add_meta_tags_in_head(){
//let people have ability to disable auto-generation of tags
if(defined(""DISABLE_ADDING_OG_META_TAGS_AUTOMATICALLY""){
$title = get_the_title(); //or whatever
echo '';
$description= get_the_title(); //or whatever
echo '';
.... and same for Twitter, G+ and some other ESSENTIAL, EVERY-DAY tags, to be available for filtering
}
}
}}}
" tazotodua
42366 Missing global parameter in function comment Toolbar 4.9 normal minor Awaiting Review enhancement reopened has-patch 2017-10-28T13:33:07Z 2017-10-28T15:37:36Z "Hello,
There is 3rd global parameter missing in function inline comment wp_admin_bar_edit_menu() in admin-bar.php
[[Image(https://ibb.co/bVpao6)]]" janak007
2 42361 get_term returns NULL before filters Taxonomy 4.7 normal minor Awaiting Review enhancement new reporter-feedback 2017-10-27T19:10:55Z 2017-11-21T02:50:00Z "So, this might be a super specific issue, but we utilize a plugin called CPT-onomies [https://wordpress.org/plugins/cpt-onomies/], which modifies CPTs to be also utilized as taxonomies, which means it manipulates the system in a few ways, but, for the most part it's been working great!
Ever since the taxonomy changes that came about somewhere between 4.5 - 4.7, error log files have been sort of exploding due to object term caches being full of NULL values. I believe I've come up with a fix to that solution outside of core, but I have come across an issue with the function `get_term`.
This chunk of code is run around lines 746-750:
{{{
if ( is_wp_error( $_term ) ) {
return $_term;
} elseif ( ! $_term ) {
return null;
}
}}}
before any filters are run on $_term, mainly, on line 761:
{{{
$_term = apply_filters( 'get_term', $_term, $taxonomy );
}}}
I know I might be a bit out of my depth, but is there a reason that NULL is returned if the `$_term` is false before the filters are run?
I understand the return if a WP_Error is encountered, but if there is a different pairing that is needed outside the what the core interprets as a Term/Taxonomy relationship, could that if false/return null be run after the filters?
Thanks for bearing with me through this!" socki03
42358 Twenty Seventeen: Social Links menu items in footer get hidden when used as child Bundled Theme 4.9 normal normal Awaiting Review defect (bug) new dev-feedback 2017-10-27T13:44:04Z 2017-10-27T14:15:50Z "Inside customizer if I reorder Social Menu Items as Children while they are on footer, child items are not visible any more and no way to access them! But they come up as dropdown sub menu item(s) when placed in Top menu. Screenshot attached.
I think when Footer menu is checked menu option to create a parent-child kind of ordering should not be available. However, if both options (Header and Footer) are checked, parent-child ordering needs to be there, but it should only in header menu only and leaving all footer menu items visible." subrataemfluence
1 42356 No Media in Grid View & No Upload possible Media 4.8.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-10-27T12:42:29Z 2017-11-09T19:11:31Z "'''Problem Description:'''
Grid View in Media Library Show only one empty thumbnail & upload does not work
in my network console I see that the admin-ajax.php is endless running
In the List view I'm able to see all files & when I search für media files I see also the correct result
'''What I tried to solve the Problem:'''
- increase memory limit
- check wordpress debug mode
- check php errorlog files
- set reverse uploads dir permissions to 775 & file permissions to 644
- deactivate all plugins
- change custome template to a wordpress default one
- set upload path & upload url path in den database
- check if a further bugfix is really fixed in my version (https://core.trac.wordpress.org/changeset/30259)
But I have no more idea now :-/" smark87
2 42355 "Missing plural forms in ""unexpected output"" string" I18N normal normal Awaiting Review defect (bug) new 2017-10-27T11:34:03Z 2017-10-27T11:34:03Z "This message can be displayed when activating a plugin:
> `The plugin generated %d characters of unexpected output during activation. If you notice “headers already sent” messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.`
For proper i18n, the first sentence should use `_n()`." SergeyBiryukov
42354 Changing Add New theme link in wp-admin/themes.php Customize 4.9 normal normal Future Release enhancement new 2017-10-27T10:36:41Z 2017-10-30T18:26:59Z "In 4.9, we can install theme with live previewing in customize. so it will better WordPress user land on /wp-admin/customize.php?autofocus[panel]=themes&autofocus[section]=wporg_themes to install new theme, when they click on 'Add New' button on wp-admin/themes.php
Or when WordPress user click on wp-admin/themes.php under Appearance because WordPrss user can perform same actions in customize related to wp-admin/themes.php.
Right now, there is two pages / parts in core to do same task. 1. under customize, 2. under wp-admin/themes.php" rinkuyadav999
42353 Header video does not load below 900px after resized and refreshed. Themes 4.8.2 normal normal Awaiting Review defect (bug) new 2017-10-27T08:39:51Z 2017-10-27T08:39:51Z "Header Media video does not load on screen size less than 900px after resized and refreshed. Instead Header Media Image is loaded.
Tested on Twenty Seventeen theme and WordPress version 4.8.2.
Steps:
Set the video URL in the customizer's Header Media.
Resize the screen and refreshed below 900px.
The video does not load instead header image is shown.
" sachyya sachet
6 42352 Support use of native MySQLi prepared queries Database normal normal Future Release enhancement new early 2017-10-27T04:15:52Z 2017-12-12T06:48:33Z "When we added `$wpdb->prepare()` back in WordPress 2.3, we were forced to roll our own MySQL Prepared queries as the MySQL extension didn't support it.
While the MySQL extension still doesn't, the majority of WordPress sites are likely using the newer MySQLi engine (by default, enabled for PHP 5.5+ which accounts for 70~80% of sites). That makes now a good time to start investigating the potential implementation and usage of native prepared queries in the future.
Attached is a first-draft of implementing native prepared queries into WPDB, it has no fallbacks for MySQL at present, but it would be possible to force support in for it using a ""simple"" SQL parser.
Unfortunately I expect that this draft is incompatible with many DB drop-ins, which is okay, this is only a draft and proof-of-concept.
I'll attach some examples of how this first draft could be used in a comment below." dd32
42349 Things get deleted when editing anchor text on lins Editor normal normal Awaiting Review defect (bug) new reporter-feedback 2017-10-26T19:49:45Z 2018-01-13T14:49:44Z "So if I set a link, and then want to change that blue text from the text editor (as opposed to clicking the pencil button and editing the whole thing on the link editor pop up), I set the cursor on the anchor word that I want to change and type backspace and suddenly the whole paragraph and previous image is deleted. The same thing happens when using Delete.
Not only is this not useful and annoying but it's retarded. I get the fact that maybe you have to click on the pencil icon to edit the whole URL and anchor text, but why does the whole paragraph and surrounding objects have to disappear? " anormal
3 42347 month/year Issue in Media section Media 4.8.3 normal normal Future Release defect (bug) new 2017-10-26T14:36:45Z 2017-11-09T20:01:25Z "Recently i have installed latest WordPress and found some issues in '''Media''' section.
At the time of adding the new media file in '''""Grid View""''', after completing the process of media file uploading the '''month/year''' of respected uploaded media file should be automatically added into '''""All Dates""''' dropdown menu.
Same issue after completed the process of deleting the media file in '''""Grid View""''' the '''month/year''' of the respected deleted media file should be automatically removed from the '''""All Dates""''' dropdown.
These both things are not working.
[[Image(http://i.imgur.com/LP4EE7C.jpg)]]
Also i have checked in '''""List View""''' and i have seen the '''month/year''' of respected uploaded media. Please check below screenshot.
[[Image(http://i.imgur.com/tuKYfSQ.jpg)]]" harshbarach
42340 Spurious Insertion of

” because HTML has semantics as well as syntax; not all vertical spacing represents distinction amongst paragraphs. The replacements break my mark-up more generally, resulting in defective presentation.
The software should never behave in such an entitled manner without permission from the user. " oeconomist
2 42338 Blank page on plugin-install.php Plugins 4.8.2 normal normal defect (bug) reopened 2017-10-25T18:33:47Z 2018-05-21T05:28:55Z "I'm running into an issue on /wp-admin/plugin-install.php where the page is just blank.
After some investigating it would appear the issue is related to the plugin icon being an svg.
When I use inspector to replace the svg with a png or jpg instead the page properly loads everything. But put a png in there and everything goes blank. Noticed the svg was being loaded by the popular Jetpack plugin and so my install plugins page is blank.
See code line 537 of the file /wp-admin/includes/class-wp-plugin-install-list-table.php for where the image is output.
I'm guessing the reason for the issue is that svg don't have a normal calculated height/width and so the container is just expanding way outside of the image container itself. Maybe try wrapping the img tag in a div and setting the width and height on that container as well to keep the image from bleeding outside if it is an svg.
" theyrobburnfield
42336 Language suggestion when no plugins installed Text Changes lowest normal Awaiting Review enhancement new dev-feedback 2017-10-25T16:52:37Z 2017-10-25T17:22:38Z "When there are no plugins in `wp-content/plugins` the following text is presented to the user:
> You do not appear to have any plugins available at this time.
This seems like the wordiest possible way to say:
> No plugins are currently available." johnjamesjacoby
42335 NULL get_queried_object on /feed URL Query 4.9 normal normal Awaiting Review defect (bug) new has-patch 2017-10-25T16:23:02Z 2017-10-27T03:18:09Z "I have been trying to track down numerous PHP notices littering my log files. I have traced it to when someone fetches a /feed version of a page/post. When this happens the various conditionals such as is_singular(), is_single(), is_page(), etc call
{{{
$post_obj = $this->get_queried_object();
}}}
which returns NULL. Then the WP routines try to reference the post_type which throws a notice such as:
PHP Notice: Trying to get property of non-object in /opt/www/wp-includes/class-wp-query.php on line 3895
Woocommerce for example uses template_redirect and checks is_page() or is_singular() which throws a bunch of notices.
WP_Query does have an is_feed variable that is set...perhaps it could use that as a check before it tries to access a null object." krbvroc1
42334 Enter/Escape keys don't have an affect in the locked content modal Editor normal normal Awaiting Review enhancement new 2017-10-25T14:48:56Z 2017-10-25T14:48:56Z "When a post is locked due to being edited by another user, the Enter and Escape keys don't have any effect on the modal window which pops up.
I think the Enter key should trigger the `Take over` button, as it's the primary action, and Escape should trigger the `All Posts` button, as it's the action most similar to cancelling your intention.
[[Image(https://i.imgur.com/R2ahCSJ.png)]]" johnbillion
1 42331 Improve setting up header images in Customizer Customize 3.9 normal normal Future Release enhancement new 2017-10-25T11:47:08Z 2018-01-15T19:05:10Z "I think the process of setting up header images in Customizer can be more streamlined.
When only 1 image is there (uploaded or suggested), why do we offer the 'randomize' option? If you click the button, it gets the 'selected' class, the preview greys out, but nothing has been changed (how could it having only 1 image) -
1) Shouldn't this button rather be only there if we have more then 1 image?
2) Small glich
Scenario:
Current header image is not set
We have 1 uploaded image
Set it to 'Randomizing uploaded headers'
then delete the image (clicking 'X')
Publish
It's still set to 'randomize headers' instead of 'no image selected'
I think it should switch to 'No image set' in the moment the image is deleted
There was a lot of activity in #21785 I'm unable to sum this all up" Presskopp
1 42328 directory listing, missing index.html Rewrite Rules 4.8.2 normal normal Awaiting Review defect (bug) new 2017-10-24T22:17:00Z 2017-10-24T22:21:09Z "On hostings where missing ""Options -Indexes"" (Apache) index.php file with ""Silence is golden."" could be an option or as discussed in #4759 as it will work also on NGINX.
While by default it's not a security issue, however, may lead to a discovery of private/non-for-public files.
Directories:
/wp-includes/
/wp-content/uploads/
/wp-content/languages/ (I know it's not by default here)
possible related: #17619
" rolandinsh
1 42326 Allow for user deletion in multisite Users 3.0 normal normal Awaiting Review enhancement new needs-unit-tests 2017-10-24T18:30:56Z 2017-10-24T21:19:24Z When multisite is enabled, it is impossible to completely delete user a user. A user is only removed from a site. However, if a user is has no sites on the network, then it should be safe to remove them. spacedmonkey
2 42324 Extending the use of the Text widget by adding heading drop down and alignment icons. Widgets normal normal Awaiting Review enhancement new 2017-10-24T15:21:35Z 2017-10-30T07:14:50Z "When the text widget was created it left out adding media (which has now been added for 4.9) but it does still not include adding a heading or alignment by clicking a button.
To make the text widget even more useful it would be nice to also include:
- Heading
- Alignment
These are typical features from TinyMCE that would improve the text widget.
" paaljoachim
42323 Posts vs CPT user permissions issue Posts, Post Types 4.9 normal normal Awaiting Review defect (bug) assigned needs-unit-tests 2017-10-24T14:51:56Z 2017-10-24T15:10:29Z "We have the following use case:
1. User does not have access to create new ""Posts""
2. User does have access to create new Product Submissions (CPT post type)
With these prerequisites, when the user clicks on ""New Product Submission"" from the list view (or the edit view), they get the No access message.
This happens because in core we check for `edit.php` no_priv instead of `edit.php?post_type=product_submission`." bor0
1 42309 Add page-numbers CSS class to wp_link_pages generated links Themes 4.9 normal normal Awaiting Review feature request new 2017-10-23T01:28:38Z 2018-04-17T20:28:50Z "While creating my own theme, I were annoyed by the differences between the functions wp_link_pages() and the_posts_pagination().
To simplify the styling of the pagination, I would like to suggest some changes to ensure some unification as stated below.
----
For example, equal styling currently works if you use the functions as follows:
{{{#!php
// pagination on singular pages
wp_link_pages (array (
'before' => '',
'after' => '',
'link_before' => '',
'link_after' => '',
));
//pagination on Posts page
the_posts_pagination ();
}}}
Resulting HTML markup
{{{
123

}}}
when it should be like
{{{
}}}
In order to achieve this we can add an additional parameter `html_wrapper_element` in `wp_list_categories` function and pass a value `dorpdown` in the argument like:
{{{#!php
'movies_taxonomy',
'walker' => new Walker_CategoryDropdown(),
'hide_empty' => false,
'html_wrapper_element' => 'dropdown'
);
wp_list_categories($args);
?>
}}}
and in `wp_list_categories` we add this before the $html gets returned from the function.
{{{#!php
' . $html . '';
}
if ( $r['echo'] ) {
echo $html;
} else {
return $html;
}
}}}
" subrataemfluence
41880 Improve comment in functions description for class http file Editor normal normal Awaiting Review defect (bug) new has-patch 2017-09-14T10:17:39Z 2017-09-14T10:20:54Z add static keyword and improve comment in functions descriptions. adnan.limdi
41878 No way to change the order of fields for taxonomy meta Taxonomy 4.8.1 normal normal Awaiting Review enhancement new 2017-09-13T22:27:26Z 2017-09-13T22:27:26Z There is currently no way to position any fields inserted with {$taxonomy}_add_form_fields or {$taxonomy}_edit_form_fields. Any fields added always appear after the description field with no way to insert them anywhere else in the form. ralphonz
1 41877 Caddy server support Permalinks 4.8.1 normal normal Awaiting Review enhancement new has-patch 2017-09-13T21:29:56Z 2017-09-17T11:55:30Z Caddy behaves mostly as nginx. But unknown `$_SERVER['SERVER_SOFTWARE']` caused default permalinks options to include `index.php`. This patch replicates global `$is_nginx` variable to Caddy's context. viliamkopecky
41875 Wordpress has some fundamental flaws in its structure General normal normal Awaiting Review enhancement new reporter-feedback 2017-09-13T20:38:35Z 2017-09-13T21:53:01Z "In way I am happy that Wordpress works. Of sorts. It is a versatile piece of software. It is amazing how many things you can create with it.
But the process of making anything more complex work in Wordpress is excrutiatingly painful.
The concept of plugins is wonderful. But currently the plugins have full access to the browser. They need to run inside Wordpress. Wordpress would need to provide the environment for as much code as possible. It's the only chance of minimizing js and and css conflicts.
Currently everybody can submit a plugin and the only hope of making all components work together is hoping that progammers are sticking to at least some conventions. Bottomline: it is down to luck.
I'd love to get involved. But to be quite honest, I have tried making some contributions with another browser based software before. It didn't go anywhere. My general impression of the age of browser based software: the only thing that matters is implementing features. The more the better.
Minimizing pain on getting things to run together is an art. But it doesn't seem to rank very highly on the list of priorities.
I'd love to get involved. But these are not cosmetic changes. So I don't know where to start and if there's a chance of anything changing on that level in the first place.
So. There it is.
Thanks for listening,
Peter
" peterhsbi
1 41874 Code Editor: Extend CSS linter to check for safecss-forbidden properties General normal normal Future Release enhancement new 2017-09-13T18:18:06Z 2017-09-29T16:16:52Z "While there is a custom HTMLHint rule which checks for Kses violations, this does not extend to CSSLint and `safecss_filter_attr()`. It would be a nice enhancement to get illegal style properties flagged as lint errors as well.
Originally https://github.com/WordPress/better-code-editing/issues/60:
> The `safecss_filter_attr()` function is used by KSES to filter HTML `style` attributes, removing any properties that are illegal. This should be applied to CSS and `style` attributes in HTML, so that any illegal properties are flagged as such.
>
> It seems that HTMLHint is not currently applying CSSLint to `style` attributes, but if it did, then a `kses` rule added to CSSLint could then apply to both HTML and CSS.
This is for the code editor introduced in [41376] for #12423." westonruter
4 41873 Code Editor: Add PHP linter General normal normal Future Release enhancement new 2017-09-13T18:15:18Z 2017-10-03T20:31:50Z "There is no PHP linter yet when editing PHP in the code editor (powered by CodeMirror, from [41376] for #12423). This would be a good enhancement, PHP syntax errors are the most critical thing to catch prior to saving in order to prevent whitescreening a site. Currently there are linters only for HTML, JS, CSS, and JSON.
See https://github.com/WordPress/better-code-editing/issues/48#issuecomment-327963921:
> Props to @rheinardkorf for finding http://glayzzle.com/php-parser/#demo !!
>
> On GitHub: https://github.com/glayzzle/php-parser
>
> I had previously stumbled across the https://github.com/glayzzle/php-linter project but it is empty. I didn't see the other project.
>
> This holds great promise. The only icing on the cake here would be if the parser could be told which PHP version to use, but we could get a list of language features that are added after PHP 5.2 and mark them as errors when the version of PHP on the server is not new enough. Amazing.
See more background on the original GitHub issue: https://github.com/WordPress/better-code-editing/issues/48" westonruter
1 41869 Documentations was not proper. Editor normal normal Awaiting Review defect (bug) new has-patch 2017-09-13T14:28:27Z 2017-09-14T07:39:48Z Add static keyword and add functions Descriptions. adnan.limdi
1 41867 wp_list_categories throws SQL error if list is empty Taxonomy 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-09-13T08:05:49Z 2017-09-15T13:12:27Z "If via the args, we exclude the only category available in the list, then the SQL query will end up wrongly formated (empty : IN() statement).
See full query here :
{{{
SELECT object_id, term_taxonomy_id FROM wp_term_relationships INNER JOIN wp_posts ON object_id = ID WHERE term_taxonomy_id IN () AND post_type IN
('post') AND post_status = 'publish';
}}}
Sample php code :
{{{#!php
'category',
'child_of' => $queried_object->category_parent,
'depth' => 1,
'exclude' => $queried_object->cat_ID,
'echo' => 0,
'hierarchical' => true,
'hide_empty' => false,
'show_count' => 1,
'title_li' => '');
echo wp_list_categories($args);
}}}
The solution would be to check if there are other categories to be displayed and if not, then just return the empty result." firebird75
41862 """Attach to Existing Content"" popup search box pulling up records that don't match search query" Query 4.8.1 normal normal Awaiting Review defect (bug) new close 2017-09-12T14:02:39Z 2017-11-20T20:28:57Z "I am not very sure whether this is really a bug in WordPress core but today I encountered it accidentally.
I was Attach-ing an image from media library to an existing post. I typed in a search query ('''10 thing''') in the search box and hit submit. Multiple records came up, while I was expecting only one which has the phrase in its title and content body. None of the other posts which appear along with, is associated with the search phrase. I checked title, body, and meta values for this post.
But when I searched with '''10 things''' (added an ""s""), I got the desired result, i.e. only a single post.
I have no third party plugin installed in my system. It is a clean install and everything is up to date." subrataemfluence
1 41857 Walker_PageDropdown doesn't set correct selected value when using value_field Posts, Post Types 4.8.1 normal normal Awaiting Review defect (bug) new 2017-09-11T17:16:16Z 2017-09-13T17:17:15Z "If the ''value_field'' is different from ID, the selected value was not set.
Function Walker_PageDropdown::start_el
{{{
if ( $page->ID == $args['selected'] )
$output .= ' selected=""selected""';
}}}
See also #32330
" it4life
1 41855 copy_dir fails in coping some files in nested dirs Filesystem API 4.8.1 normal normal Awaiting Review defect (bug) new 2017-09-11T12:12:46Z 2017-09-11T12:12:46Z "Tricky, subtle bug!
Let's suppose we do have a folder structure like this:
/folder1/folder2/
/folder1/folder2/file1.txt
/folder1/folder2/subfolder1/
/folder1/folder2/subfolder1/file2.txt
/folder3/
and that we want to move or copy the entire ''folder2'' to ''folder3'' so that the final structure is like this:
/folder1/folder2/
/folder1/folder2/file1.txt
/folder1/folder2/subfolder1/
/folder1/folder2/subfolder1/file1.txt
/folder3/folder2/
/folder3/folder2/file1.txt
/folder3/folder2/subfolder1/
/folder3/folder2/subfolder1/file1.txt
IMPORTANT: Please note that initially the path /folder3/folder2 doesn't exist.
The problem arise based on the order used internally by copy_dir to retieve the ''source'' elements.
Let's see it in detail.
command:
{{{
copy_dir('/folder1/folder2', '/folder3/folder2')
}}}
Result:
First iteration: /folder3/folder2 is created with mkdir.
Second iteration (if copy_dir retrieves first /folder1/folder2/file1.txt): copy(/folder1/folder2/file1.txt, /folder3/folder2/file1.txt) fails because /folder3/folder2 doesn't exist!
Second iteration (if copydir retrieves first /folder1/folder2): /folder3/folder2 is created. Now, by the next iteration, copy(/folder1/folder2/file1.txt, /folder3/folder2/file1.txt) will not fail.
I've discover this bug almost accidentally using the following (buggy) code:
{{{#!php
isDir()) {
mkdir($dest.DIRECTORY_SEPARATOR.$iterator->getSubPathName(), 0777, true);
} else {
copy($file, $dest.DIRECTORY_SEPARATOR.$iterator->getSubPathName());
}
}
} else {
copy($source, $dest);
}
}
}}}
I need a copy_dir (or copy_recursive) function for copying my custom plugin's data (a complex nested structure of file/folders) to wordpress' upload dir. The above code used to fail, apparently randomly, the copy of only some files.
Then I've tried to use wordpress' copy_dir function only to discover, with disappointment, that it used to fail exactly the same way.
The solution, at least for my (buggy) code, is to create the ''destination'' folder before any copy command, like this is:
{{{#!php
isDir()) {
mkdir($dest.DIRECTORY_SEPARATOR.$iterator->getSubPathName(), 0777, true);
} else {
copy($file, $dest.DIRECTORY_SEPARATOR.$iterator->getSubPathName());
}
}
} else {
copy($source, $dest);
}
}
}}}
" caraffande
41854 Allow filters to be added for the Media Library in Grid Mode & Insert Media Media 4.8.1 normal normal Awaiting Review enhancement new 2017-09-11T08:02:45Z 2017-09-17T14:41:55Z "Hello,
I would like to suggest the action '''restrict_manage_posts''' and '''pre_get_posts''' to be used by the Media Library in Grid Mode. It would also be great to have this available in Insert Media or when picking a Featured Image. That will allow many developers to add useful filters and avoid users to look desperately for their images/photos :) Many users have been asking this and most of them believed it was a bug (List Mode and Grid mode look very similar so the absence of filters for the Grid Mode is actually not logical).
Thanks a lot :)" TigrouMeow
41846 Avoid PHP notice in get_comment_reply_link() for null comment Comments 2.7 normal normal Awaiting Review defect (bug) new has-patch 2017-09-10T10:37:09Z 2017-09-10T23:22:23Z "
When I was working on tests for {{{get_comment_reply_link()}}} I got a PHP notice:
{{{
Notice Trying to get property of non-object ...
}}}
with inputs like:
{{{
get_comment_reply_link( array( 'depth' => 1, 'max_depth' => 2 ) );
}}}
when there's no current global comment available and the input comment is null.
That's because of this part:
{{{
$comment = get_comment( $comment );
if ( empty( $post ) ) {
$post = $comment->comment_post_ID;
}
}}}
where there's no validation for {{{$comment}}}.
" birgire
1 41843 Provide more flexibility to the `get_{$adjacent}_post_where` hook Themes 4.9 normal normal Awaiting Review enhancement new 2017-09-09T15:33:07Z 2017-09-09T16:05:49Z "I'm working on getting the previous/next post for a Custom Post Type based on a certain postmeta value, and the `get_{$adjacent}_post_where` seems the appropriate hook for this. However, it currently receives the whole WHERE clause as a parameter. IMO it would be ideal to be able to override just the `WHERE p.post_date $op %s AND p.post_type = %s` part and keep the other (useful ones) intact.
This could potentially be solved in a non-breaking way by sending `$where` as it stands ''before'' concatenation with `WHERE p.post_date $op %s AND p.post_type = %s`, so that authors can neatly plugin a postmeta condition." danburzo
2 41839 "Add ""Update available"" option to ""Plugins"" on the admin menu" Menus 4.9 normal normal Awaiting Review enhancement new dev-feedback 2017-09-09T08:29:23Z 2018-01-12T17:17:49Z "I update plugins on my site several times a week. I add a new plugin maybe once or twice a year.
I generally perform the update from the list of plugins rather than going directly to updates, as might appear in the admin toolbar.
From the perspective of usability and efficiency, it would be much more useful to have the options ""Updates available"" under the ""Plugin"" entry in the admin menu, than ""Add new"". So I am suggesting that this option be added to the main admin menu, visible when and if such updates are available.
I am not suggesting that ""Add new"" be removed." Josiah S. Carberry
1 41837 WP_User_Query can generate negative offset in the LIMIT clause Users 4.4 normal normal Awaiting Review defect (bug) new has-patch 2017-09-08T18:08:30Z 2017-09-08T18:51:27Z "The {{{paged}}} argument in {{{WP_User_Query}}} was introduced in #34531
There's a problem with the {{{paged}}} as 0 case.
There's a similar ticket for {{{WP_Comment_Query}}}: #41826
'''Example:
'''
When {{{paged}}} is 0 and number is 2, {{{WP_User_Query}}} generates the LIMIT clause:
{{{
LIMIT -2, 2
}}}
instead of
{{{
LIMIT 0, 2
}}}
According to the MySQL documentation, the offset in the LIMIT clause shouldn't be negative:
https://dev.mysql.com/doc/refman/5.7/en/select.html
I think we should handle it in the same way as in {{{WP_Query}}}, where the 0 case is the same as 1." birgire
41833 Excerpt disappear in excerpt mode post list, after quick edit Quick/Bulk Edit 4.8.1 normal normal Awaiting Review defect (bug) new 2017-09-08T08:46:42Z 2017-09-09T21:42:41Z I am listing post in excerpt mode. I press quick edit and edit or not some post. Update and the excerpt disappears. Reload and the excerpt is there again satnapar
41827 add sanitize_html_class in whole class while there is no spacing. General normal normal Awaiting Review defect (bug) new has-patch 2017-09-07T12:20:10Z 2017-09-07T22:54:36Z umangvaghela123
41826 WP_Comment_Query can generate negative offset in LIMIT clause Comments 4.9 normal normal Awaiting Review defect (bug) new has-patch 2017-09-07T11:40:49Z 2017-09-08T19:03:35Z "The {{{paged}}} argument in {{{WP_Comment_Query}}} was introduced in #38268
There's a problem with the {{{paged}}} as 0 case.
'''Example:'''
When the {{{paged}}} is 0 and {{{number}}} is 2, {{{WP_Comment_Query}}} generates the LIMIT clause:
{{{ LIMIT -2, 2 }}}
instead of
{{{ LIMIT 0, 2 }}}
According to the MySQL documentation, the offset in the LIMIT clause shouldn't be negative:
https://dev.mysql.com/doc/refman/5.7/en/select.html
I think we should handle it in the same way as in {{{WP_Query}}}, where the 0 case is treated as the default, that is 1.
" birgire
41822 Twenty Twelve: Submenus not working on touch screen devices Bundled Theme 4.8.1 normal normal Awaiting Review defect (bug) new 2017-09-07T08:16:52Z 2017-09-08T01:53:17Z "Appears identical to #24767
When tapping on a menu item with a submenu, the submenu briefly appears but then the browser loads the link at the top menu item. Site should be viewed in Landscape orientation for the regular menu to be visible.
Confirmed on ​http://wp-themes.com/twentytwelve/ in Chrome 60 on Android 7.1.2 (Nexus 5X)
The user who reported it suspects it might be related to https://www.chromestatus.com/feature/5093566007214080
From http://en.forums.wordpress.com/topic/submenu-links-broken-on-touch-devices-chrome-56" kokkieh
1 41821 REST API: Add support for threaded comments REST API 4.7 normal normal Future Release enhancement new 2017-09-07T06:39:29Z 2017-09-07T06:39:29Z "(I don't think we have a tracking ticket for this already.)
We should add support for threading comments, particularly in ""flat"" mode. Flat mode would allow threading in frontend code relatively easily.
The only issue with this is that it will overflow `per_page`. We intentionally treat this as an indicator and occasionally have less items already (if they're filtered inside the `get_items()` loop, e.g.), so I don't think this is a huge issue. In addition, threaded mode should be opt-in in any case.
Previously: https://github.com/WP-API/WP-API/issues/1612" rmccue
41819 Support the paged argument in WP_Site_Query and WP_Network_Query spacedmonkey Query 4.6 normal normal Future Release enhancement assigned dev-feedback 2017-09-06T18:21:04Z 2017-11-01T17:47:07Z "The {{{WP_Site_Query}}} and {{{WP_Network_Query}}} both support the {{{offset}}} and {{{number}}} arguments.
It would be handy to be able to use the {{{paged}}} argument, to make the pagination easier.
" birgire
1 41818 Add widget-title to default widget for consistency Widgets 4.9 lowest minor Awaiting Review defect (bug) new close 2017-09-06T17:48:32Z 2017-09-06T18:19:47Z `widgettitle` appears only in 3 places within core. Everywhere else it is `widget-title`. This patch makes everything consistent. wpsmith
2 41816 attachment_url_to_postid() should find post_id for URLs of intermediate size images Media 4.9 normal normal Awaiting Review defect (bug) new dev-feedback 2017-09-06T15:40:45Z 2017-09-06T17:11:30Z "[[https://developer.wordpress.org/reference/functions/attachment_url_to_postid/|attachment_url_to_postid()]] fails to find the post ID when given a URL of an intermediate sized image.
For example,
{{{
$url_of_full_sized_image = 'http://example.com/wp-content/uploads/test.jpg';
$attachment_id = attachment_url_to_postid( $url_of_full_sized_image );
// $attachment_id now equals 3
$url_of_intermediate_sized_image = 'http://example.com/wp-content/uploads/test-150x150.jpg';
$attachment_id = attachment_url_to_postid( $url_of_intermediate_sized_image );
// $attachment_id now equals 0 but should equal 3, the same as for the full-sized image
}}}
This should be fixed." pbiron
1 41813 get_terms is hiding taxonomies that are not empty Taxonomy 4.8.1 normal normal Awaiting Review defect (bug) new 2017-09-06T13:14:20Z 2017-09-11T13:55:11Z "I have created a custom taxonomy for media type contents which has three terms in it. All terms have at least one image (media) associated to it. When I use the following code:
{{{#!php
'media_content_category',
'hide_empty' => true
));
foreach($terms as $term) {
echo $term->name . '';
}
}}}
it only displays one taxonomy when there should be all of them as no taxonomy is ""empty"".
'''NB: All plugins are deactivated during test.'''" subrataemfluence
2 41804 Combine and Relocate Editor Menu Link Editor normal normal Awaiting Review enhancement new 2017-09-05T16:21:07Z 2017-09-14T13:21:15Z "While discussing #31779, I recommended the following:
1. Move the Editor into the Tools menu, or into Tools > Available Tools. It fits better there anyway: it's not a visual editor for the Appearance, as other things are in the Appearance menu), but the other problem with Plugins > Editor is it's right beside one of the most clicked buttons in the UI (Add New). It's too easy to discover. You could also move the warning messages suggested above into a box on Available Tools. Instead of a warning, it becomes the context for launching the Editor. Plus, what else is going on in that page anyway. :)
1. To do the above, combine the Theme and Plugin editors into one. Separate the edit dropdown with headings for Theme and Plugins.
@melchoyce recommended splitting this out into a separate ticket (ticket:31779#comment:54)." cliffseal
1 41802 add wp_attachment_is_audio() and wp_attachment_is_video() Media 4.9 normal normal Awaiting Review enhancement new has-patch 2017-09-05T14:57:43Z 2017-09-05T15:01:37Z "Core already has [[https://developer.wordpress.org/reference/functions/wp_attachment_is_image/|wp_attachment_is_image()]].
For consistency and convenience, core should also have `wp_attachment_is_audio()` and `wp_attachment_is_video()`." pbiron
41801 add wp_get_image_extensions() and wp_image_extensions filter Media 4.9 normal normal Awaiting Review enhancement new has-patch 2017-09-05T14:33:32Z 2017-09-05T14:36:31Z "Core already has [[https://developer.wordpress.org/reference/functions/wp_get_audio_extensions/|wp_get_audio_extensions()]] and [[https://developer.wordpress.org/reference/functions/wp_get_video_extensions/|wp_get_video_extensions()]] (which are used in [[https://developer.wordpress.org/reference/functions/wp_attachment_is/|wp_attachment_is()]]).
For consistency and convenience, core should also have `wp_get_image_extensions()` and `wp_image_extensions` filter." pbiron
3 41800 Ability to collapse multi-level menus in the Menu editor Menus 4.9 normal normal Awaiting Review enhancement new 2017-09-05T14:04:37Z 2017-09-07T15:59:19Z "When creating large menu structures in the Appearance > Menu editor, it can be very overwhelming when there's a number of top-level items with child items... almost becoming an eyesore and confusingly difficult to navigate.
Could we work to make any menu item within the editor have the ability to be collapsed? Along with the default state upon loading the editor to have them collapsed, with an icon to expand it." atomicjack
41797 max_num_pages for WP_User_Query Query normal normal Awaiting Review enhancement new has-patch 2017-09-04T22:19:56Z 2017-09-05T08:13:21Z "The {{{WP_User_Query}}} class supports pagination but doesn't have the public {{{max_num_pages}}} property, like most of the other query classes do.
This can be useful when using e.g. {{{paginate_links()}}} and also for better consistency.
" birgire
1 41792 Suggested Enhancement to WordPress' Handling of Authors and Author URL's Themes normal normal Awaiting Review enhancement new dev-feedback 2017-09-04T11:36:02Z 2017-09-06T07:59:42Z "Hi, everyone, my first post here, but I have some concerns.
*WordPress' Handling of Authors*
I feel it's not the right UX when, say on a single author blog, the url ""blog.com/author"" goes to 404.
I'd like for WordPress to programmatically direct/redirect a blog.com/author to the archive of this single author if single author. I mean, say I, Kabolobari, am an author on a single author blog and the url to my posts is blog.com/author/kabolobari. So, WordPress automatically creates that based on my name choice.
Now, since WordPress can also tell a multi-author blog once there's more than one author, I'd like if WordPress then automatically builds the url for such as blog.com/authors/kabolobar, Kabolobari being one author on this blog.
Then if a user/browser were to backspace the url, of course, their intention would be to see all authors at blog.com/authors, right? Thus, WordPress shouldn't send them to a 404. WordPress should intelligently default that to a list of all the authors on the multi-author blog.
Is my explanation clear?
Then, WordPress can, as with other archives, leave a way for admins or theme developers to customize how they'd like this `authors.php`, as an example, template to be.
To summarize,
Single Author Blogs = blog.com/author/single-author
Then, blog.com/author = This Single Author and a list of their posts
Multi Author Blogs = blog.com/authors/multi-author
Then, blog.com/authors = These authors list and a list of their posts
Then leave all of these to be customizable by theme devs.
I'm having a hard time hacking my way around this because of this feature which I see is unavailable. If I'm wrong and there's actually a straightforward way about this, kindly direct me.
*As an Example*
Kindly, study the website kincommunity.com. Because what I’m building is very similar to that. Now, you should notice that when you hit Creators on the navigation at this site, Kin Community’s developers chose a custom post type route to display their Creators.
Thus, Creators takes you to kincommunity.com/our-community/. Then a single creator is at kincommunity.com/creators/rosanna-pansino/, for example. But when you try kincommunity.com/creators/, as a user you expect to see a list of all creators, right? But you get a 404.
I figure if WordPress allowed for a native way to flex around this, so that say you added a role of Creator (coding it yourself or with a plugin such as Members by Justin Tadblock) and you give this new role about same level of cap as Author.
Then one wouldn’t need to use CPT for this purpose and then the logic as I’ve explained above would take hold automatically with allowance for customization to look like the theme’s overall feel.
Could we examine these concerns? Thanks." kbooshco
41791 Unicode + add_permastruct breaks rewrite rules Rewrite Rules 4.9 normal normal Awaiting Review defect (bug) new needs-unit-tests 2017-09-04T11:15:57Z 2017-09-15T13:14:58Z "This was reported here https://github.com/woocommerce/woocommerce/issues/16673
To recreate the issue, create a taxonomy with a cyrillic name such as Сертификат. View the taxonomy archive. You'll see no results; it will go to the homepage rather than an archive.
In WooCommerce you can recreate this by creating an attribute (Product > Attributes) with a cyrillic name, and enabling the 'archive', assigning a term from this taxonomy to a product, and trying to view products by that term.
I managed to trace it back to the `add_permastruct`. The `struct` is added with unicode % encoded characters. When the rewrite rules are processed, it thinks these are placeholders so the `matches` variables do not align. See this screenshot for clarity:
https://www.dropbox.com/s/5vztnfm6895488a/query%20is%20wrong.png?dl=0
Notice all the $matches? Compare to a working taxonomy:
https://www.dropbox.com/s/24zyr5v7taw7b60/correct.png?dl=0
This can be fixed by using `urldecode` when adding the permastruct. I don't know if this has side effects but it worked in testing.
Patch to follow.
" mikejolley
41788 PHP Fatal error: Call to a member function has_cap() on a non-object in wp-includes/comment.php Comments 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-09-03T22:16:34Z 2017-09-04T11:54:19Z "{{{#!php
if ( ! empty( $commentdata['user_id'] ) ) {
$user = get_userdata( $commentdata['user_id'] );
$post_author = $wpdb->get_var( $wpdb->prepare(
""SELECT post_author FROM $wpdb->posts WHERE ID = %d LIMIT 1"",
$commentdata['comment_post_ID']
) );
}
if ( isset( $user ) && ( $commentdata['user_id'] == $post_author || $user->has_cap( 'moderate_comments' ) ) ) {
}}}
If get_userdata() returns false, this code can lead to a fatal error." kirbyde
1 41783 allow loading wp-config.php (values) without DB bootstrap Bootstrap/Load 4.8.1 normal normal Awaiting Review enhancement new 2017-09-02T17:43:40Z 2017-09-02T17:43:40Z "Directly related issue: [https://github.com/wp-cli/extension-command/issues/26 wp-cli plugin download command]
''wp-config.php'' is a fundamental and unique source of information about the WP instance. It contains information about database, but some others about languages/paths/...
In some case we may want to provide preprovisionned WP instance but also about the to-be-instanciated installation: filesystem/plugin/themes/... to be provided in the filesystem *before* WP got installed).
This may be the case when a team share a common WP filesystem image / Docker image / ...
External tool (ex `wp-cli`) may benefit from loading not only the WP-core helpers (like, eg, `plugins_api()`), but also to know about some constants inside ''wp-config.php'' although DB is not yet available.
An issue is that currently, loading ''wp-config.php'' forcefully attempt a DB connexion. This happens via the unconditional call to `wp_set_wpdb_vars()` inside ''wp-settings.php''
We rather should provide a mechanism to optionally disable such a behaviour.
There already exist a '''SHORTINIT''' define. Could we introduce another one that may allow to load `wp-config.php` in a database-less environment?
Indirectly related: [https://core.trac.wordpress.org/ticket/41710 WP_* configuration constants from the environment]
" drzraf
1 41782 Using date_query with 'before' in WP_Query returns wrong timezone Date/Time 4.8.1 normal normal Awaiting Review defect (bug) new 2017-09-02T13:42:46Z 2017-09-03T16:53:01Z "Hi,
When using the date_query for WP_Query, to retrieve posts before a given date, it appears the date is used as gmdate - which creates an unwanted gap.
Example:
My site's timezone settings is UTC+3
I do a query with {{{'date_query' => array('before' => '2017-01-01 10:00:00')}}} then I get results from prior to 2017-01-01 07:00:00.
Looking at wp-includes/date.php, I can see you already suspected this may be an issue:
{{{
if ( ! is_array( $datetime ) ) {
// @todo Timezone issues here possibly
return gmdate( 'Y-m-d H:i:s', strtotime( $datetime, $now ) );
}
}}}
So, yes... there are timezone issues there for sure :D
I tried various ways to sort this out, with no luck. Both our server and wordpress options are correctly set up. So it's just these kind of queries -- and revisions suffer similarly -- from a distortion of the actual date to return.
Thank you,
Bira" Biranit
1 41781 do not forcefully phpunit delete fixtures data Build/Test Tools 4.8.1 normal normal Awaiting Review enhancement new 2017-09-02T02:06:22Z 2017-09-02T02:06:22Z "When phpunit runs, there are at least three places where test-data are removed (see below).
Fixture deletion is good in its principle. But it's also sometimes painful, especially when one is in the process of developing tests and need to run the testsuite many times.
WP (re)installation + shared XML fixture loading could easily be '''very''' slow (especially given XML importer slowness).
If your plugin's testsuite does not even contains destructive operations (or controlled destructions) then all that time spent in testsuite (re)installation is very frustrating. (In my case it's 1 minutes 50 versus 2 seconds)
It would be good if developers could control whether or not fixtures are deleted & database cleaned, when phpunit starts/finishes.
Places that need change:
* [https://github.com/WordPress/wordpress-develop/blob/ce8a915/tests/phpunit/includes/bootstrap.php#L68 system( WP_PHP_BINARY ... install.php)]
* [https://github.com/WordPress/wordpress-develop/blob/ce8a915/tests/phpunit/includes/bootstrap.php#L101 _delete_all_posts()]
There is also: [https://github.com/WordPress/wordpress-develop/blob/ce8a91/tests/phpunit/includes/testcase.php#L83 _delete_all_data() inside tearDownAfterClass()] but this one can be easily overriden.
Could a couple of filter/action/define/whatever could be made so that data cleanup, being the default, could be disabled if developer wants to?
thx" drzraf
41779 TinyMCE plugins included with WordPress aren't loaded when using wp_enqueue_editor(); Editor 4.8.1 normal normal Awaiting Review defect (bug) new close 2017-09-01T18:09:11Z 2017-09-03T09:01:33Z "Using the WP_Editor API as described on the following page does not load any of the WordPress specific TinyMCE plugins like it's supposed to do in the back-end.
[https://make.wordpress.org/core/2017/05/20/editor-api-changes-in-4-8/]
This seems like an oversight to me." Swennet
41778 Archive page for user roles Role/Capability 4.8.1 normal normal Awaiting Review feature request new 2017-09-01T17:22:55Z 2017-09-02T21:23:07Z "If possible, implement userroles in the author archive page or create a seperate user archive for it. Along with an option to modify the base/slug.
For example, subscribers should have their own archive page. While subscribers don't hold any rights inside wordpress, in themes such as an ecommerce website or membership website, these subscriber roles are quite important as they are considered as 'customers'.
" mireillesan
41776 wp_list_category array element 'exclude' better be called 'exclude_id' Taxonomy 4.8.1 normal normal Awaiting Review enhancement new 2017-09-01T14:30:12Z 2017-09-01T14:31:21Z "Could the default array element `exclude` of `wp_list_category` function be renamed as `exclude_id`?
I think only `exclude` is not that self explanatory and ""what to exclude"" could easily be a reasonable question for a developer to ask!
Instead `exclude_id` is easily understandable, even `exclude_ids` could be used as well because we can pass an array to it.
Please give it a thought.
Source file: wp-includes/category-template.php
Line no: 508" subrataemfluence
1 41775 REST API: Add filter to allow creation of custom comment type REST API normal normal Awaiting Review enhancement new 2017-09-01T11:31:09Z 2017-09-01T11:31:09Z "When trying to create a comment using the REST API that has a different comment type I get the following error.
''Cannot create a comment with that type.''
Looks like it is coming from this code.
{{{#!php
// Do not allow comments to be created with a non-default type.
if ( ! empty( $request['type'] ) && 'comment' !== $request['type'] ) {
return new WP_Error( 'rest_invalid_comment_type', __( 'Cannot create a comment with that type.' ), array( 'status' => 400 ) );
}
}}}
Looks like this was added to fix defect #38820
Would it be possible to change this check to use a filter that will allow some comment types? Something like this
{{{#!php
if ( ! empty( $request['type'] ) && false === in_array($request['type'], apply_filters( 'rest_allow_comment_types', array('comment'), $request ) ) {
return new WP_Error( 'rest_invalid_comment_type', __( 'Cannot create a comment with that type.' ), array( 'status' => 400 ) );
}
}}}
We could then use the same filter in the update_item call as well I've attached a diff with a first draft idea" langan
1 41774 REST-API: Media endpoint (POST): Unable to upload files REST API 4.8.1 normal normal Awaiting Review defect (bug) new dev-feedback 2017-09-01T07:55:08Z 2017-09-05T06:53:01Z "I have found a possible bug in the file ""'''wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php'''"", which prevents me from uploading media files via the ""media"" REST endpoint. Every time I try to upload a file, I get the following response:
{{{
{
""code"": ""rest_upload_unknown_error"",
""message"": ""File is empty. Please upload something more substantial. This error could also be caused by uploads being disabled in your php.ini or by post_max_size being defined as smaller than upload_max_filesize in php.ini."",
""data"": {""status"": 500}
}
}}}
The problem seems to be in line 719:
{{{#!php
$file = wp_handle_upload( $files['file'], $overrides );
}}}
After some debugging, I have found out that the array in the $files variable does not have the format that seems to be expected. After changing the line to the following code, the file upload works for me without problems:
{{{#!php
$file = reset( $files );
$file = wp_handle_upload( $file, $overrides );
}}}
" tiger42
2 41773 Page Templates // Post Type Templates | Any Post Type? Posts, Post Types 4.7 normal normal Awaiting Review enhancement new reporter-feedback 2017-09-01T00:39:03Z 2017-09-01T19:29:27Z "If I add a template like this:
{{{#!php
` element which already had a working, canonical `url` parameter in its querystring.
An example URL is:
{{{https://twitter.com/i/web/status/898599373956722688}}}
If you try to fetch oEmbed data for that URL by just adding it as a `url` querystring parameter on the standard Twitter oEmbed provider URL, it will return an error.
But view source on that page, and you'll see:
{{{}}}
Note that the path of this URL is `.../{username}/status/{id}`, whereas the original URL was `.../i/web/status/{id}`.
I've worked out a small patch and method for getting WordPress to use oEmbed discovery to extract and use the canonical URL.
When using `wp_oembed_add_provider()`, if you leave the provider URL falsey, then `WP_oEmbed::get_provider()` will use discovery to find it (assuming that you haven't forced `discovery = false` in `$args`). Then my patch will pull the `url` arg from there and use that, instead of the original URL that was passed in to the embed handling.
Later, when the JSON response is being handled, the code will still be able to see whether this is a whitelisted URL pattern, and bypass/perform security filtering such as `kses()` (see `wp_filter_oembed_result()`).
" dougal
2 41745 Uncaught Error in get_query_var when $wp_query is null Query 4.8.1 normal normal Awaiting Review defect (bug) new has-patch 2017-08-28T16:24:01Z 2017-09-05T23:40:55Z When `get_query_var()` is called without the global $wp_query being set an Uncaught Exception is thrown. kbjohnson90
2 41740 "Add comment count to ""replies"" link in post responses" REST API normal normal Awaiting Review enhancement new 2017-08-28T02:42:10Z 2017-08-28T02:42:10Z "Right now, you can preload comments using embedding with the linked ""replies"" resource. This is great, but there's no way to know whether you should try loading more. Fetching the resource directly would give you the total in the `X-WP-Total` header, but you lose this when embedding.
While this is generically a problem with the loss of headers from embedded resources, I don't think we really need a generic solution. Even when not embedding, a comment count is useful for archive display of a list of posts.
We should add the comment count (using `wp_count_comments`) to the ""replies"" link:
{{{
{
""replies"": [
{
""href"": "".../wp/v2/comments?post=42"",
""embeddable"": true,
""count"": 12,
}
]
}
}}}" rmccue
1 41739 "Support a ""source"" attribute in post types, taxonomies, and post statuses" Posts, Post Types 3.0 normal normal Awaiting Review enhancement new 2017-08-28T02:07:31Z 2017-08-28T02:27:55Z "When registering custom post types, taxonomies, or post statuses, it would be nice to have a way to tell the system what plugin was responsible for those registrations.
Use Case:
In bbPress, there are 3 post types, 1 taxonomy, and 4 post statuses. There are several places where an ""any bbPress post type"" or ""any bbPress post status"" comparison is necessary, but it's somewhat annoying and repetitive to need to write:
{{{
array( bbp_get_forum_post_type(), bbp_get_topic_post_type(), bbp_get_reply_post_type() )
}}}
I'd prefer to write:
{{{
get_post_types( array( 'source' => 'bbpress' ) )
}}}
Tangentially, this could replace the otherwise vague `internal` property, with:
{{{
'source' => 'wordpress'
}}}
I'm not confident that `source` is the best descriptor, or if `domain` or `namespace` or something else might be more appropriate (without being too vague to be useful.)" johnjamesjacoby
41737 Possibly redundant template files in the hierarchy Themes normal normal Awaiting Review enhancement new close 2017-08-27T20:41:17Z 2017-10-03T14:06:42Z "Hi,
As I'm building https://forklor.github.io/wp-template-hierarchy/ (still a work in progress) and sifting through the source code, it looks like the following template files in the hierarchy may be redundant:
1. `${subtype}.php` for attachments — is there a need for a template for a subtype without its associated `${mime_type}`? Is there a use-case am I missing where a subtype may be associated with different mime types?
2. `attachment.php` can be caught in `single-attachment.php`.
For the sake of simplifying WP's API surface, I am proposing deprecating these templates in a future version.
And as a related question (let me know if I should open a separate issue), to preserve symmetry with other post types and and pages, should a Custom Post Template set for an attachment not get priority before the other attachment templates?
(Please let me know if I misunderstood anything!)" danburzo
1 41736 validate_file function will always return error for file paths in windows dev environments Plugins 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-08-27T18:50:51Z 2017-08-30T16:30:16Z "In Windows dev environments such as WAMP or XAMPP a file path always contains a colon after a drive letter, so all plugins making conditional checks with `validate_file()` would fail.
" lechdulian
41735 Include titles for JSON Schema properties REST API 4.7 normal normal Awaiting Review enhancement new has-patch 2017-08-27T00:38:41Z 2017-12-03T21:03:30Z JSON Schema supports a `title` property that can hold a user-readable label for the property. This would be incredibly helpful in building generated documentation and user interfaces. TimothyBlynJacobs
41733 manual Post excerpt being ignored Themes 4.8.1 normal normal Awaiting Review defect (bug) new close 2017-08-26T22:53:05Z 2017-08-26T23:20:47Z "wordpress 4.8.1 fresh install.
no plugins activated, using 2017 theme although excerpt does not show even when the theme is changed.
created 1 post with a manual excerpt and also edited the default Hello World post and added a manual excerpt. Excerpts do not show on the home page, instead, the full post is shown.
I've been on this for days, I thought it was an issue with the theme then the plugins however even with a fresh WP install I can now confirm it is an issue with WP.
Server Software.
Nginx
PHP 7.1 fpm
maria db InnoDB
" maltonge
1 41732 Potential Core Issue Editor 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-08-26T01:56:27Z 2017-10-18T21:35:33Z "I posted [https://wordpress.org/support/topic/wordpress-core-issue/ this] a couple of weeks ago and I haven't heard anything so I assume its not in the ideal place.
I asked one of the developers of the products I initially thought the issue was associated with (and who have also recreated/tested this issue without their products present) for a suggestion and they recommended posting a ticket here.
I've been battling to narrow this problem down for a long time now. Over a year ago I discovered an issue which as it turns out impacts the editor view in visual mode. Sorry I don't recall the version this started happening in. I assume it was around 4.0
Initially I thought it was either the GeneratePress theme or Yoast SEO plugin however their support/developers have helped me to recreate the issue without their products installed.
I'm not sure why but at this stage the issue occurs using WordPress and twenty-sixteen theme when various types of content are present in visual mode but not when using the twenty seventeen theme to my knowledge.
After a load of time and testing the common denominator in all the tests is WordPress itself.
I attached an image below which shows the area in the code which fluctuates. It may help cut through some of the info and get to the problem.
There are a number of other attachments found within the associated thread above.
[https://1drv.ms/f/s!AjEGKOtzUwy1gclEHoZZ9-DCW52S4Q]
Thanks" doubledworks
1 41731 Make it Easier to Locate Restored Comments Comments 4.8.1 normal normal Awaiting Review enhancement new 2017-08-25T19:30:34Z 2017-08-25T19:58:06Z "When a comment is in the trash, WordPress does not allow you to edit its details without restoring it first. After restoring the comment, it disappears from the Trash and the user is then required to locate it either by memorizing the post it's on or searching for it in the backend. It doesn't show up on the approved comments page because of its original published date.
I suggest that if a single comment is restored, it takes users to the post it's on. Even better would be taking the user straight to where the comment is in the Discussions meta box. However, since users can hide this meta box via the screen options, I'm unsure how to account for that.
Perhaps redirecting users to the post where the comment is displayed is enough?" jeffr0
41727 Draft page loses its hierarchy on save when other pages are drafts in hierarchy Posts, Post Types 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-08-25T13:12:54Z 2017-08-30T14:26:31Z "How to reproduce:
1. Create a set of pages with a status publish
2. Set hierarchy to pages
3. Change the status to of the aforementioned set to draft
4. Open draft for editing.
5. Save as draft.
6. Now you have lost the hierarchy.
I think you should retain the hierarchy, because it is quite common use case to build something as drafts before publishing them or taking pages to drafts if they are in need for editing and the user wants them out before edits are done. Tickets possibly related #15541 and #12890.
" stode
2 41725 User Search Box disappears if searched with 0 (zero) Users 4.8.1 normal normal Awaiting Review defect (bug) new has-patch 2017-08-25T11:44:12Z 2017-08-25T12:07:15Z "If I search users with ""0"" in search box, the '''search box disappears''' after the search is performed and there is no way of doing another search without reloading user list or going back!
If I enter any other value like 999999, -200, xyz etc. no user is fetched, which is fine. But the search box remains visible. It only disappears for `0`.
Line nos. 347 and 348 in /wp-admin/includes/class-wp-list-table.php has this:
{{{#!php
has_items() )
return;
...
}
}}}
If I understand correctly, according to [https://developer.wordpress.org/reference/classes/wp_list_table/search_box/] and [https://developer.wordpress.org/reference/classes/wp_list_table/has_items/], (`&& !$this->has_items()`) looks whether the table has items to display or not, where the first link is responsible for rendering the search_box.
So when I enter such a value for which there will no record fetched, should not render the search box after search is performed, but as I said, it is happening only for `0`
Commenting out the above if block prevents search box from disappearing. The search box should remain visible irrespective of values entered into it." subrataemfluence
41720 Give a path where VCS data can be stored General normal normal Awaiting Review enhancement new close 2017-08-24T06:25:51Z 2017-09-04T20:08:14Z "As a developer
I want to put data in my VCS
so that any developer can access this files.
- Currently wp-content/uploads is something no one wants in his VCS.
- Storing everything in wp-content is a complete mess.
- We could allow a messy folder in something like ""wp-content/data"".
If this becomes a preset in WordPress
and rule of thumb, then I am sure that most installs will become cleaner
and easier to maintain.
What plugins currently do is a complete mess. As a develop I don't want to enter the wp-content directory
and find a list of storage dir for each single plugin.
I just like to see:
- plugins/
- themes/
- languages/
- the theme compat thingy/
- data/
- uploads/
- index.php
This is already enough." screamingdev
1 41719 Malformed User Search results Users 4.8 normal normal Awaiting Review defect (bug) new 2017-08-23T22:16:58Z 2017-08-23T22:16:58Z "There is a logic bug with the User Search WP_User_Query. (Users > All Users > ""Search Users"" (in top-right corner)).
The SQL that is generated looks something like this:
{{{
SELECT SQL_CALC_FOUND_ROWS wp_users.ID
FROM wp_users
INNER JOIN wp_usermeta
ON ( wp_users.ID = wp_usermeta.user_id )
WHERE (
1=1 AND
(
user_login LIKE '%Search Term%' OR
user_url LIKE '%Search Term%' OR
user_email LIKE '%Search Term%' OR
user_nicename LIKE '%Search Term%' OR
display_name LIKE '%Search Term%'
)
)
ORDER BY user_login ASC LIMIT 0, 20;
}}}
However, such a query is not guaranteed to return unique user IDs. It just so ""happens"" to work right now. The more correct query adds the DISTINCT keyword:
{{{
SELECT SQL_CALC_FOUND_ROWS DISTINCT wp_users.ID
...
}}}
Modifying the query in certain situations results in duplicate user IDs being returned. One example, of many such modifications that could be made, can be seen in the Better User Search plugin on line https://github.com/wp-plugins/better-user-search/blob/master/better-user-search.php#L200.
As is, this is currently breaking pagination and sometimes displaying redundant users as you flip through the pages. (See attached screenshot. My pagination is set to 20, and I have 100 matching users on my system).
[[Image()]]" navepilif
1 41714 "wp_list_pages() - horrible performance due to eventual ""SELECT *""" Posts, Post Types 4.9 normal normal Awaiting Review defect (bug) new 2017-08-23T16:15:00Z 2017-08-25T13:41:23Z "I'm investigating awful performance (MySQL slow queries logged constantly) a site which uses a plugin to display a page list.
The plugin calls wp_list_pages(). wp_list_pages() in turn calls get_posts(). And get_posts() ends up making the slow query:
{{{
SELECT * FROM wp_posts WHERE (post_type = ‘page’ AND post_status = ‘publish’) ORDER BY wp_posts.post_date ASC;
}}}
So, all the post_content fields (along with everything else) are being requested, just for the purposes of constructing a page list. (The site has ~ 1200 pages - and the above call returns 34MB from the MySQL server).
It looks like either get_posts() needs some more flexibility so that it has an option to return only specified fields." DavidAnderson
1 41713 Some PHP Warning in /wp-includes/functions.php General 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-08-23T16:12:32Z 2017-08-24T09:54:33Z "I have updated our theme and when I check my error log. I found this error related to WordPress core file.
{{{
PHP Warning: strstr() expects parameter 1 to be string, object given in /public_html/wp-includes/functions.php on line 785
PHP Warning: stripos() expects parameter 1 to be string, object given in public_html/wp-includes/functions.php on line 790
PHP Warning: stripos() expects parameter 1 to be string, object given in public_html/wp-includes/functions.php on line 793
PHP Warning: strpos() expects parameter 1 to be string, object given in public_html/wp-includes/functions.php on line 800
PHP Warning: explode() expects parameter 2 to be string, object given in public_html/wp-includes/functions.php on line 801
}}}
" xpeed
41712 canonical infinite redirect bug General normal normal Awaiting Review defect (bug) new 2017-08-23T15:27:56Z 2017-08-23T15:27:56Z "I had an infinite redirection problem caused by ""redirect_canonical"" (wp-includes\canonical.php)
I have a query string parameter ex: ""http://mysite.com/mypage/?q=test%2C+test"" and it was redirected infinitly to itself because of:
{{{#!php
parents' many of the filters are bypassed. There should be a filter that all return types run through. spacedmonkey
1 41696 Content-Disposition header is blocked by CORS REST API 4.7 low minor Awaiting Review defect (bug) new has-patch 2017-08-22T01:51:03Z 2018-03-09T08:54:50Z "The media upload endpoint in the REST API accepts files in two formats: form data (`multipart/form-data`) and direct upload (`image/png` e.g.). When uploading in direct format, the desired filename is passed in the `Content-Disposition` header (e.g. `Content-Disposition: atttachment; filename=""file.jpg""`).
When sending requests across a cross-site boundary, browser preflight requests only allow a certain subset of headers to be sent. We whitelist `Authorization` and `Content-Type` in addition to the regular headers, but neither `Content-Disposition` nor `Content-MD5` are permitted by default or explicitly.
This means that a simple `fetch` using a File/Blob object (e.g. from an `` or HTML5 drag-and-drop) for the body will fail:
{{{
const url = `http://example.com/wp-json/wp/v2/media`;
const opts = {
method: 'POST',
headers: {
'Content-Disposition': 'attachment; filename=""test.txt""',
}
body: new Blob( [ 'test data' ] ),
};
fetch( url, opts ).then( resp => console.log( resp ) );
}}}
However, this is allowed by packing the data into a FormData object instead:
{{{
const url = `http://example.com/wp-json/wp/v2/media`;
const opts = {
method: 'POST',
};
opts.body = new FormData();
const file = new Blob( [ 'test data' ] );
file.name = 'test.txt';
opts.body.append( 'file', file );
fetch( url, opts ).then( resp => console.log( resp ) );
}}}
We should fix this inconsistency to allow for the simpler request format." rmccue
41690 Fix missing assignment of page templates on theme switch Themes normal normal Future Release enhancement new 2017-08-21T17:32:54Z 2017-08-21T20:14:56Z "Following up on #39692 and #39693, let's see if we can also save page template mapping when someone switches themes.
For example:
- Variations on ""homepage"" or ""front page""
- Variations on ""fullwidth""" melchoyce
1 41688 Wrong term pagination when altering the term query in custom taxonomy terms list Administration normal normal Awaiting Review defect (bug) new 2017-08-21T17:16:09Z 2017-08-21T17:16:09Z "WP outputs the wrong term pagination if we alter the term query in custom taxonomy terms list with for example the `list_terms_exclusions` filter hook.
In the screenshot below, we should have only 3 items in the pagination, but as you can see we get 21 items instead.
[[Image(https://i.imgur.com/pFUCG8P.png)]]
I believe the problem comes from this line:
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-terms-list-table.php#L125
{{{#!php
'total_items' => wp_count_terms( $this->screen->taxonomy, compact( 'search' ) ),
}}}
Shouldn't the pagination be defined based on the term query's **result** instead?
For more details about this issue, see:
https://wordpress.stackexchange.com/questions/277088/filter-taxonomy-admin-pagination/277590#277590
" opportus
41687 wp_update_link() doesn't allow updating of link_owner Administration 4.9 normal normal Awaiting Review defect (bug) new has-patch 2017-08-21T17:13:20Z 2017-08-21T17:17:50Z "The title says it all.
Example:
{{{
$link_id = wp_insert_link( array(
'link_name' => 'foo',
'link_url' => 'http://example.com',
'link_owner' => 1,
) );
// $link_id has link_url == http://example.com and link_owner == 1
wp_update_link( array(
'link_id' => $link_id,
'link_url' => 'http://example.org',
'link_owner' => 2,
) );
// $link_id now has link_url == 'http://example.org, but still has link_owner == 1 :-(
}}}" pbiron
1 41685 Save database version in site meta (Multisite) Networks and Sites 3.0 normal normal Awaiting Review enhancement new needs-unit-tests 2017-08-21T11:00:31Z 2018-03-06T17:45:46Z "Currently there is there a table in multisite called blog_versions. All this table stores is the database version as number and the date updated. With plans to add site meta in #37923 this new table should be used. This has a number of benefits, including functions to CRUD these values in the database. Once this data is in the blogmeta, table, the blog_versions table can be removed all together. If require a SQL view can be used blog_versions from data stored in blogmeta.
" spacedmonkey
2 41683 Add Widget REST API endpoint REST API 4.7 normal normal Awaiting Review defect (bug) new needs-unit-tests 2017-08-21T10:38:31Z 2017-12-03T21:05:33Z "There needs to be a REST endpoint to interacts with widgets. Current users can use the options api to interact with the data, but this is extremely limited. I would recommend that we look to WP CLI for pointer on how the api is laid out. Docs can be found here - https://developer.wordpress.org/cli/commands/widget/ .
One of the likely issues with if the is a view, how the html for a widget is rendered. " spacedmonkey
3 41680 Added rewrite tags using add_rewrite_tag() not working on static front-page Rewrite Rules 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-20T19:46:58Z 2017-08-20T19:46:58Z "Hello everyone,
the following ticket is a little bit similar to the issue described here: #25143
== Introduction ==
I am working on a plugin which provides a shortcode. This shortcode generates some content/output on a page where it is placed on. The shown output depends on optional URL-parameters. For example those two URLs result in different outputs:
- my-site.com/my-page
- my-site.com/my-page?'''foo'''=''bar''
In preparation for pretty URLs I have to register a new rewrite-tag '''foo''':
{{{#!php
add_rewrite_tag('%foo%', '([^/]*)');
}}}
This allows me (in combination with the corresponding rewrite rules) to use pretty URLs like this:
- my-site.com/my-page/'''foo'''/''bar''
As expected you can access the assigned value ''bar'' of '''foo''' with the following code:
{{{#!php
$value_of_foo = get_query_var('foo'); // returns: bar
}}}
== Problem ==
This all works fine as long as the page which includes the shortcode is not set as the sites static front-page. In this case your URLs will usually look like that:
- my-site.com (the content of the static page is shown)
- my-site.com/?'''foo'''=''bar'' (from here it is broken)
So, whats happening? Instead of generating and showing the content based on the URL parameter, the second URL loads the front-page but instead of showing the content of the static page, it acts like the blog page and shows the list of the latest posts.
The problem is that {{{is_home}}} is improperly set to {{{true}}} because we now have a custom query-var in our URL which basically makes the content of a ''static'' page not ''static'' anymore. But this fact shouldnt let WordPress showing the list of the latest posts-page instead. This problem makes it impossible for users to place and show the content of a shortcode - which is based on (prettyfied) URL-parameters - on their static front-page.
At the moment I am using the following code as a workaround but I think this is not an optimal long-term solution for this problem:
{{{#!php
function fix_query_vars_on_front_page($query) {
// Dont do this workaround when we are in the administration area or when we are not inside the main query.
if (is_admin() || !$query->is_main_query()) {
return;
}
// Cache the actual query vars first.
$queryVarCache = $query->query;
// Only continue when our query vars are not already empty.
if (!empty($queryVarCache)) {
// Remove our query vars from the cache when they are set.
if (isset($queryVarCache['foo'])) {
unset($queryVarCache['view']);
}
// When our cache is empty, we are on a front-page (is_home() or is_front_page()). Ensure that the following filtering only happens on a static front page.
if (empty($queryVarCache) && get_option('show_on_front') === 'page') {
// Get the ID of the front page and add it to the query vars.
$query->query['page_id'] = get_option('page_on_front');
// Reparse the query.
$query->parse_query($query->query);
}
}
}
add_action('pre_get_posts', 'fix_query_vars_on_front_page');
}}}
Maybe some way to add custom rewrite tags without adding them as a query var would be a possible solution for this. Of course there would be a need to add a function to access them, for example {{{get_rewrite_var('foo')}}} instead of {{{get_query_var('foo')}}}.
I am looking forward that WordPress will make this possible in a future version. :-)" Asgaros
3 41679 get_the_terms does not return expected results Taxonomy 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-08-20T17:15:19Z 2017-10-24T15:28:41Z "Wordpress fails to report the (custom) categories a post is in.
{{{
$terms = get_the_terms( $post->ID, 'project_category' );
}}}
returns no results.
{{{
$terms = wp_get_object_terms( $post->ID, 'project_category' );
}}}
does, which I believe to be correct.
I have traced the problem back to:
class-wp-term-query.php.
The caching code that calls this relies on object_ids (all_with_object_id) to come back, but the object_ids are eaten by:
{{{
if ( 'all' === $_fields || 'all_with_object_id' === $_fields) {
$terms = array_map( 'get_term', $terms );
}
}}}
commenting out the {{{'all_with_object_id' === $_fields}}} part yields correct results. But I am not sure that is the correct fix. presumably having a WP_Term object come back in this case had some intention?
" rslotb
1 41678 Make sure all field returns use filters in WP Query Query 1.5 normal normal Awaiting Review enhancement new needs-unit-tests 2017-08-20T13:01:32Z 2017-08-20T14:47:59Z Currently if fields is set to either `id` or `id=>parent`, it doesn't run through all the filters as these return early. spacedmonkey
3 41675 Add filter to bypass display/query for Media Months filter in media modal joemcgill Media normal normal Awaiting Review enhancement reviewing 2017-08-19T18:27:26Z 2017-09-15T14:40:59Z "I am investigating slow running queries to try and cut down the page load time for edit pages in the admin.
The media months dropdown filter runs a somewhat expensive query for what it is.
On our production database, it adds about 500 ms of query execution time to the page load.
There doesn't seem to be a way to be able to disable this drop down.
The query that is run populates the field.
But when there are a mass quantity of media, this is not an optimal method of search.
There should be an option/filter to disable the display and query for this." CrazyJaco
1 41674 More granular capabilities for restoring and permanently deleting trashed posts Posts, Post Types normal normal Awaiting Review enhancement new needs-unit-tests 2017-08-19T16:00:27Z 2017-08-19T16:00:27Z "Currently the user capability required for restoring a trashed post or permanently deleting a trashed post is `delete_post`, which maps to `delete_posts`. There should be a separate capability for each of these actions.
Suggestion:
* `restore_trashed_post` which maps to `restore_trashed_posts` which maps to `delete_posts`.
* `delete_trashed_post` which maps to `delete_trashed_posts` which maps to `delete_posts`.
Emptying the trash should use the `delete_trashed_posts` capability.
This allows for more granular control over which users can or cannot restore or permanently delete posts." johnbillion
3 41673 Abstract update capability logic into a meta capability Users 4.9 normal normal Awaiting Review enhancement new needs-unit-tests 2017-08-19T12:50:14Z 2017-08-19T12:50:14Z "From [comment:4:ticket:41538]
There are three places in core now which use logic to determine whether a user has any one of the `update_*` capabilities. This should be abstracted into a meta capability such as `manage_updates`." johnbillion
4 41672 REST create user: existing_user_login is returned before existing_user_email shooper Users 4.7 normal normal Awaiting Review enhancement assigned dev-feedback 2017-08-19T01:37:10Z 2018-02-08T16:26:19Z "When I post to `/wp-json/wp/v2/users` to create a user:
{{{
{
""email"": ""brianhenryie@gmail.com"",
""username"": ""brianhenryie"",
""password"": ""password""
}
}}}
and a user with that username and email address exists, the response is:
{{{
{
""code"": ""existing_user_login"",
""message"": ""Sorry, that username already exists!"",
""data"": null
}
}}}
whereas a more useful response would be the existing_user_email response:
{{{
{
""code"": ""existing_user_email"",
""message"": ""Sorry, that email address is already used!"",
""data"": null
}
}}}
which is learned once the original POST is updated with a new username.
i.e. existing_user_email tells a user if they already have an account. This information could be used to attempt to log in." bbrian
41663 Hooks for the back to login link in the footer of wp-login.php Login and Registration 4.8.1 normal normal Awaiting Review feature request new 2017-08-17T18:58:25Z 2017-08-17T18:58:25Z "In the following pull request: [https://github.com/WordPress/WordPress/pull/306/files] I introduced 3 new filters to the login footer area. With these filters you can customize the back to login link to your needs.
" Fleuv
1 41661 Using proxy & HTTP 1.1 leads to full URL in REQUEST_URI variable in Apache General 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-08-17T15:29:38Z 2017-08-17T17:08:53Z "When using a proxy the browser send a full URL in var REQUEST_URI
$_SERVER['REQUEST_URI'];
i.e.:
With proxy: it returns http://mydomain.com/requestedurl
No Proxy: it returns /requestedurl
Solution:
check the variable to see if it is full path and transform it:
{{{#!php
, this)"" class=""imgedit-fliph button"" title="""">
}}}
" dj_angola
41633 Textbox and buttons are not aligned properly Formatting normal normal Awaiting Review defect (bug) new 2017-08-14T17:37:12Z 2017-08-14T17:37:12Z "Hi,
Steps to reproduce the issue -
1. Please check this URL - https://wordpress.org/ideas/
2. Open any link - topic
3. Check in RHS where it allows the logged in user to add a tag.
4. Here these components are not aligned properly.
" krupajnanda
41631 Same Term Not Added Taxonomy 4.8 normal normal Awaiting Review defect (bug) new dev-feedback 2017-08-13T20:24:40Z 2017-09-21T11:42:48Z "Using latest version of WordPress, default theme, all plugins disabled. Problem first appeared in version 4.8 and continues with 4.8.1.
To recreate the issue:
1. Create regular post (“Posts”)
2. Add a new term to the Categories meta box
3. Save the term (it will appear on top of the list with a check mark next to it)
4. Add the same term again. Nothing happens and the term is not added
Version 4.7.5 and below would activate the term and put to the top of list. This was helpful when adding a string of terms and some of them were already in the database. " vaprak
41628 Permalink category and tag and taxonomy Taxonomy 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-08-13T15:59:50Z 2017-08-13T17:00:36Z Hi i found bug in permalink in any taxonomy and category open first post of category and no open category shm379
41627 Additional parameter for multisite activation Plugins 4.8.1 normal normal Awaiting Review feature request new 2017-08-13T13:42:15Z 2017-08-13T18:00:53Z "It could be good, if there was something additional parameter, which made
'register_activation_hook' function to be executed per individual sub-sites, while activating it from Network dashboard.
that is good, because i.e. in activation hook, we want sometimes to create tables, add options ( and etc) per each sub-site." tazotodua
1 41616 REST API: Expose old slugs REST API 4.8.1 normal normal Future Release enhancement new needs-unit-tests 2017-08-12T05:32:45Z 2017-08-22T07:24:30Z "Expose the old slugs for all posts including custom post types in the REST API.
For example, when building a React-powered app using the WordPress REST API the old slugs are required so that users can be automatically redirected if they clicked on an old link.
To expose the old slugs I created a small plugin (see below):
{{{#!php
true, 'show_in_nav_menus' => true ) ) ;
$args = array(
'get_callback' => 'get_old_slugs_for_api',
'schema' => null
);
foreach ($post_types as $type) {
register_rest_field( $type, 'old_slugs', $args );
}
}
function get_old_slugs_for_api( $object ) {
//get the id of the post object array
$post_id = $object['id'];
//return the post meta
return get_post_meta( $post_id, '_wp_old_slug' );
}
}}}
" crosescu
41615 Small clean-up in cache.php Cache API 4.9 normal normal Awaiting Review defect (bug) new 2017-08-11T15:49:20Z 2017-08-11T15:49:20Z "Following the current minimum requirement of PHP version 5.2.4 or greater (cf. https://codex.wordpress.org/Template:Server_requirements) and the absence of a PHP4 constructor, I think we can safely remove some obsolete code in ''cache.php''.
Patch is attached." neoxx
1 41613 "Media Modal: Consider redesigning ""Link to"" pattern" Media normal normal Future Release enhancement new 2017-08-11T15:32:36Z 2017-12-18T16:44:46Z From both experience and usability testing, it seems that “Link to” as a dropdown in the Media Modal isn’t a great interaction pattern. Could we explore some other options that might be more clear or intuitive? melchoyce
1 41611 "Customizer: Make ""Add a Widget"" button easier to find" Customize normal normal Future Release enhancement new 2017-08-11T15:22:17Z 2017-10-06T17:03:59Z "While testing out the image widget, I found that many of the folks I was testing with struggled to find the ""Add a Widget"" button.
We should consider different ways of making the ""add a widget"" button easier to find, including moving placement, changing to primary, or increasing size (this is my “gut” pick)." melchoyce
1 41608 Post files using cURL HTTP API 4.6 normal normal Awaiting Review defect (bug) new 2017-08-11T06:58:35Z 2017-08-11T09:23:40Z "It's impossible to post files by http using cURL via the WordPress API.
If you look at the code in the ''setup_handle'' method in ''Requests_Transport_cURL'' class found in the ''/wp-includes/Requests/Transport/cURL.php'' file, you'll see that the POST data is always converted to a string using the PHP ''http_build_query'' function. However, according to the PHP manual at [http://www.php.net/manual/en/function.curl-setopt.php], the value passed to CURLOPT_POSTFIELDS must be an array if files are passed to this option.
" codealfa
1 41607 Cannot scroll down in Firefox 54 and WordPress 4.8.1 using Shift + PageDown Editor 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-11T04:02:23Z 2017-08-11T04:02:23Z "Tried to demonstrate you the problem in this video:
https://youtu.be/Us4DqA71Tr4
If you need more information, let me know, please!" orschiro
1 41605 REST API: Fixed schema for the Page post type is incorrect Posts, Post Types normal normal Awaiting Review defect (bug) new dev-feedback 2017-08-10T17:19:43Z 2017-12-03T21:25:07Z "The fixed schema for the `page` post type incorrectly states that it supports the `excerpt` field. It does not.
Ref: https://github.com/WordPress/wordpress-develop/blob/d570de32ca3a5f623bf26d70dfc55141c339073d/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L1801-L1831
In addition, I'm not sure why the schemas for the Post, Page, and Attachment post types are hard-coded instead of relying on post type support." johnbillion
2 41604 REST API: Attempting to create or update a non-existent setting doesn't return an error response Options, Meta APIs normal normal Awaiting Review defect (bug) new 2017-08-10T16:35:44Z 2017-08-10T16:37:07Z "Attempting to create a new setting via a POST request to `/wp/v2/settings` returns a 200 response, despite the request having been invalid. The same goes for attempting to update a non-existent setting with a PUT request.
I would have expected maybe a 400 from such requests.
The internal logic in `WP_REST_Settings_Controller` routes the request through the `update_item()` method, treats it as a setting update, and silently ignores the problem.
" johnbillion
1 41601 wp_update_user creates an error Users 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-10T11:16:39Z 2017-08-11T11:05:41Z "See my code below. When I use wp_upadte_user within the hook ""after_setup_theme"", it throws an error:
{{{
[Thu Aug 10 13:08:45.503396 2017] [proxy_fcgi:error] [pid 9452] [client 10.130.52.246:56561] AH01071: Got error 'PHP message: WordPress-Datenbank-Fehler You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE user_id = 6 AND blog_id = 1' at line 1 f\xc3\xbcr Abfrage '''SELECT COUNT(id) FROM WHERE user_id = 6 AND blog_id = 1''' von require('wp-blog-header.php'), require_once('wp-load.php'), require_once('wp-config.php'), require_once('wp-settings.php'), do_action('after_setup_theme'), WP_Hook->do_action, WP_Hook->apply_filters, ad_sso_login, wp_update_user, wp_insert_user, do_action('profile_update'), WP_Hook->do_action, WP_Hook->apply_filters, bp_blogs_add_user_to_blog, bp_blogs_record_blog, BP_Blogs_Blog->save, BP_Blogs_Blog->exists\nPHP message: WordPress-Datenbank-Fehler You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '( user_id, blog_id ) VALUES ( 6, 1 )' at line 1 f\xc3\xbcr Abfrage INSERT INTO ( user_id, blog_id ) VALUES ( 6, 1 ) von require('wp-blog-header.php'), require_once('wp-load.php'), require_once('wp-config.php'), require_once('wp-settings.php'), do_action('after_setup_theme'), WP_Hook->do_action, WP_Hook->apply_filters, ad_sso_login, wp_update_user, wp_insert_user, do_action('profile_update'), WP_Hook->do_action, WP_Hook->apply_filters, bp_blogs_add_user_to_blog, bp_blogs_record_blog, BP_Blogs_Blog->save\n', referer: http://intranetdev.rehau.org/
}}}
The sql functions being executed by this functions are missing the database table name.
Here is the code I am using inside the functions.php from my plugin:
{{{#!php
$user_id, 'user_url' => $website ) );
if ( is_wp_error( $user_id ) ) {
echo ""There was an error, probably that user doesn't exist."";
} else {
echo ""Success!"";
}
}
}}}
" iamklaus
1 41599 wordpress migration is so landhy General 4.8.1 normal normal Awaiting Review feature request new dev-feedback 2017-08-10T01:46:24Z 2017-08-11T04:07:31Z "Wordpress have a not any inbuilt tool to migrate my new project from our local server to direct move on client server and all update move on client server without ftp or cpanel to upload files.
Ex : like git repository update all source from source tree.
" ketanumretiya030
41597 Language pack download requires too broad file system permissions Upgrade/Install 4.9 normal normal Awaiting Review enhancement new 2017-08-09T17:27:54Z 2017-08-11T06:28:34Z "Language packs are installed into `wp-content/languages` directory. The problem is, even if the directory exists, and WordPress is allowed to create files there, it is still required to:
* for WordPress to have permissions in the `wp-content` directory. This is because `$upgrader->fs_connect()` is called with an array of two directories – `WP_CONTENT_DIR` and `WP_LANG_DIR`, and `fs_connect()` only checks the permissions to the first one.
* for WordPress to have the exact file owner for the `wp-content` directory. Cause - `wp_can_install_language_pack()` calls `fs_connect()` wihout `$allow_relaxed_file_ownership`
I think languages, downloaded from a known source, should not require such a draconian measures. Instead, WordPress should successfully download and install languages if it can write to `wp-content/languages` directory (and not require ownership permissions for either `wp-content` or `wp-content/languages`." kpumuk
2 41594 Edit tag form limited to 800px width Taxonomy 4.8.1 normal normal Awaiting Review defect (bug) new has-patch 2017-08-09T15:27:23Z 2017-09-03T09:47:50Z "In taxonomy edit page the form width is limited to 800px by css. Many space was lost on large screens.
The bug seam come from wp-admin/css/edit.css at line 1095 and appear since WP 4.8.1 (work correctly on previous version)
[[Image()]]" fabienlege
3 41593 Document every function parameter that expects slashed data General normal normal Future Release task (blessed) new 2017-08-09T15:09:35Z 2017-11-08T21:23:48Z "There are several inline comments in core which state `// expected_slashed`, indicating that a variable's value is expected to contain slashed data.
This information should be documented in the corresponding function's parameter documentation, and any ""parent"" functions that call those functions.
It's more than likely that there are other places in core which expect slashed data which are not documented with `// expected_slashed`. These need to be identified (comments welcome)." johnbillion
1 41586 Page Attributes > Parent list doesn't fit screen Editor 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-08T16:34:59Z 2017-08-08T20:11:33Z "Tested on Firefox 54 on Ubuntu MATE and WordPress 4.8.1.
See this animation: http://i.imgur.com/7q8T7s7.gif" orschiro
41583 Menus Administration screen, menu items are always loaded even when not needed Menus 4.8.1 normal normal Awaiting Review enhancement new dev-feedback 2017-08-07T22:04:44Z 2017-10-10T01:39:18Z On the Menus Administration screen menu items are always loaded. For performance, menu items should only be loaded when editing an existing menu and not on the locations tabs or when adding a new menu item. I've attached a patch that fixes this. webgeekconsulting
4 41581 Cleared Comments stuck in moderation Comments 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-07T18:32:40Z 2017-11-14T18:47:57Z "I am the third person to report this issue, since it was first reported in June on the [https://en.forums.wordpress.com/topic/comments-stuck-in-moderation-queue-even-though-akismet-cleared-this-comment?replies=44 Dot Com Forum]. A Staff Member responded to the ticket, at the time, and stated that they would be filing a Bug Report, but we have not heard back.
A third user reported the issue on the [https://wordpress.org/support/topic/comments-held-in-moderation-even-after-previously-approved-comment/#post-9388458 Dot Org Forum] 2 months and 2 weeks ago.
Not all cleared users are getting their comments bumped into moderation. This is the case for all three of us. The only plugin the other dot org user and I have in common is the Akismet plugin and I disabled that to confirm that it didn't fix the problem.
Please advise." fb2ts
3 41580 Review the usage of the `::-moz-focus-inner` CSS fix for the buttons extra padding in Firefox viktorfroberg Administration normal normal Awaiting Review enhancement assigned has-patch 2017-08-07T14:55:54Z 2018-02-11T17:30:03Z "For a number of years, Firefox used to set some extra padding on the buttons (or inputs of type button/submit/reset). To address this, WordPress uses a known fix targeting the proprietary Firefox pseudo element `::-moz-focus-inner`.
Seems something has changed recently and starting with Firefox 53, FF doesn't apply the extra padding any longer. I ''think'' the relevant Bugzilla ticket Firefox 53 release notes, though.
Testing a bit on Windows, in the screenshot below:
- on the left, Firefox 48: buttons without and with the CSS fix: there's a clear size difference
- on the right: Firefox 54: buttons without and with the CSS fix: no size difference
[[Image(https://cldup.com/7AkzV22mi3.png)]]
Codepen available here: https://codepen.io/afercia/full/Gvrzwz/
Seems these rules used across the admin stylesheets could be simplified a bit. The only part that needs to stay is `border-width: 0;` or, maybe better, `border: 0;` which is necessary on Windows to remove the dotted line on :focus:
[[Image(https://cldup.com/aynypgSW6Y.png)]]
This could be also a good opportunity for some clean-up. For example, seems to me in `press-this.css` there are two identical rules. " afercia
41578 Assure that $_SERVER['PATH_INFO'] is available Bootstrap/Load 4.8.1 normal normal Awaiting Review enhancement new 2017-08-07T00:27:14Z 2017-08-10T06:19:40Z "I use the [http://www.fefe.de/gatling/ gatling] web server on one of my servers (low ressorce consumption). gatling will not set the PATH_INFO environment variable if no path info is available which causes the home page of WP to enter an endless redirect loop.
I managed to fix this by setting {{{$_SERVER['PATH_INFO']}}} to the empty string in an unhandled condition in wp-includes/load.php.
" glehner
1 41577 Fix Notice fixing Canonical 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-07T00:09:12Z 2018-04-17T17:29:52Z "The file wp-includes/canonical.php produces Notices for undefined indexes when a requested uri has no path or query.
The attached patch sets the indexes to empty strings.
#6977 (which was not used) had a different approach. The currently used ""Notice fixing"" approach does not fix up $original which is used afterwards.
" glehner
41575 Add global action to get_template_part Themes 4.9 normal normal Awaiting Review enhancement new 2017-08-06T21:56:45Z 2017-08-07T15:41:25Z "I would like to see
{{{#!php
do_action( ""get_template_part"", $slug, $name );
}}}
in get_template_part. Right now there is no means to track or do any action on every template call. A feature I want to implement in a plugin relies on this to function how I want. As of now I can only get the primary template." pcfreak30
41574 Add filter: wp_get_attachment_link_attributes Media normal normal Awaiting Review enhancement new has-patch 2017-08-06T17:26:28Z 2017-08-06T17:59:53Z Similar to wp_get_attachment_image_attributes, it would be nice to be able to filter the link attributes when getting the attachment link. NathanAtmoz
41573 Editor and Quick Edit display the slug of a page selected as static front page Posts, Post Types 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-06T16:52:02Z 2017-08-06T17:22:26Z "Dear Happy Engineers of WP!
I'm writing about a possible WP BUG after consulting the issue with 'AThemes Support' that tells me there is this possibility... The issue is about a SLUG that can not be cancelled in a ""Homepage"" (it has been a normal page before choosing it as Static Frontpage...)
But please, in order to don't repeat the conversation of the issue, I beg you to read it in the following link where is more clear...
https://wordpress.org/support/topic/slug-homepage-static-page-seo-front-page-wp/
Thank you a lot!
" cekar
2 41570 Multisite Global Media Settings Media normal normal Awaiting Review enhancement new 2017-08-05T17:51:57Z 2017-08-07T04:04:32Z "In the WP Multisite Network Admin, we have the following menu options to control the network:
Dashboard
Sites
Users
Themes
Plugins
Settings
My suggestion is to add to this list, a ""Media"" menu that creates global images for all sites. Anything loaded into this global Media menu is instantly available to all sub-sites." ina2n
41566 Function Description : /wp-signup.php Login and Registration 3.0 normal normal Future Release defect (bug) new has-patch 2017-08-04T19:49:00Z 2017-10-12T04:28:46Z There is no descrption for global vars mt8.biz
41564 Search for hyphenated post templates for post types with underscores Posts, Post Types normal normal Awaiting Review feature request new dev-feedback 2017-08-04T17:16:29Z 2017-08-13T15:54:10Z "Custom post type names adhere to the rules within sanitize_key() (lowercase alphanumeric characters, dashes, and underscores).
This means registering a post type `some_post_type` is perfectly fine. The archive and single templates would be be `archive-some_post_type.php` and `single-some_post_type.php`.
These file names do not adhere to the core standard for file names.
Files should be named descriptively using lowercase letters. Hyphens should separate words.
Searching for `archive-some-post-type.php` in addition to `archive_some_post_type.php` would allow this standard to be followed better." desrosj
41563 Multisite 4.8.1 - Menu not showing on frontend and customizer Menus 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-08-04T15:34:16Z 2017-09-18T17:27:28Z "In a multisite 4.8.1, if you create a new site, and then create a menu, it doesn't show up on the frontend and in the customizer.
Testscript:
- Wordpress 4.8.1 multisite (network)
- Create a new site (subdomain)
- Theme: 2017
- Go to Appearance menu -> create menu with 3 items, location: top menu
- Save menu
-> Frontend: no menu
-> Customizer: menu, without the items
You can then add menu items in the customizer, and they show up in the preview. If you save the menu in the customizer, and close the customizer:
-> No changes in Appearance menu
-> No menu on frontend
We tested this on 3 different installs. All caching disabled." thordar
41560 WP_Filesystem_FTPext class documentation updates Filesystem API normal normal Awaiting Review enhancement new 2017-08-04T05:21:33Z 2017-08-04T10:47:04Z the function in parameter $time and $atime is define but documentation in Not define upadalavipul
3 41559 Permalink Settings Permalinks 2.5 normal normal Awaiting Review enhancement new 2017-08-04T03:29:10Z 2017-08-05T06:52:08Z "'''Improving the appearance of Permalink Settings'''
" Luan Ramos
41558 create a (reusable) wp_default_admin_scripts Themes 2.6 normal normal Awaiting Review enhancement new 2017-08-03T23:53:48Z 2017-08-07T01:26:31Z "I had to create an admin-like form in the frontend, for guests submitting content.
I needed to provide {{{meta/post-box}}}, {{{autocompletion}}} and needed {{{media-views}}}, {{{wp-color-picker}}}, ...
I thought {{{wp_enqueue_script()}}} would do the trick... until I discovered the {{{ if(is_admin()) }}} inside {{{wp_default_scripts()}}}. I had no other choice than copy/pasting ~210 WP LoC in my own PHP files
Is there a really good reason for reserving all that cool client-side stuff to admin dashboard only?
plugin/themes developers may want to load and use it for good and having all that libs already registered by core is useful.
I suggest:
1. moving all the admin-oriented script into {{{wp_default_admin_scripts()}}} which should be reusable (even if non-admin), and run it if (is_admin).
2. moving all the {{{localize()}}} corresponding to these admin scripts into another {{{wp_default_admin_scripts_settings()}}} function somehow wrapped by {{{if(! is_admin())}}}
3. Document how to correctly bootstrap the dashboard in the frontend and a couple of common gotchas of these scripts (like that ajax-dashboard-pingback feature forcefully pulled as JS-dependencies and which can't be stopped, ...)
" drzraf
4 41554 REST API: Use `wp.apiRequest` helper to build URLs for media embed requests REST API normal normal Awaiting Review enhancement new has-patch 2017-08-03T17:41:04Z 2018-04-08T11:05:37Z "Follow-up to #40919.
Let's explore getting rid of the `oEmbedProxyUrl` [https://github.com/WordPress/wordpress-develop/blob/1c28b4a/src/wp-includes/media.php#L3449 property] used to pass a REST API URL down to `wp-admin` code that calls out to this endpoint ([https://github.com/WordPress/wordpress-develop/blob/1c28b4a/src/wp-includes/js/media/views/embed/link.js#L56 example]). We can use the helper library introduced in #40919 instead:
{{{#!js
wp.apiRequest( {
namespace: 'oembed/1.0',
path: '/proxy',
// ...
} );
}}}
This helper will allow us to eliminate all `rest_url` calls passed to client code through script localization. This will eventually lead to a lot of duplication, but it seems like it should be very clear from the requesting code which API endpoint is being called." jnylen0
1 41553 UTC time is affected by changing WP time zone setting Date/Time 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-03T17:11:41Z 2018-03-12T14:26:04Z "hi
when adjusting timezone to my timezone, which is Tallinn, then i get different results.
the most interesting issue is that UTC time itself is changing if i choose some different timezone. this should not be happening as utc is universal.
i'll attach couple of pictures.
i have discussed the issue with hosting company and they say that time should be correct.
version is WordPress 4.8.1 with Twenty Sixteen theme.
the time is not the issue but the problem arises when used with Revived Ajax Event Calendar. all the times in database are correct but when in calendar view, then times differ by what is the difference in WP settings. " ester17
1 41551 Officially support use of null for text domain name parameter to l10n functions I18N 4.9 normal normal Awaiting Review enhancement new 2017-08-03T16:45:53Z 2017-08-04T06:58:13Z "I am working on some code which shares library files between plugins / themes. A plugin or theme that needs to use some particular logic is able to ''require'' a library then assuming it's been loaded successfully, make use of the logic. Multiple plugins may deliver a library file but only one instance of a library file is loaded. Common logic implements version and dependency checking and therefore prevents run time fatal errors due to functions or classes being redefined.
The solution works fine, but it poses some challenges with regards to localisation of any strings that are used in the shared library files.
Having investigated a number of potential options I have concluded that a viable solution can be implemented by using some ""Just Translate It"" logic that is text domain agnostic.
The simplest implementation depends on the use of a `null` value for the `$domain` parameter to functions such as `__()`.
This TRAC requests that WordPress core officially sanctions this use of null.
I have developed some unit tests that demonstrate that the current code works fine.
I don't think it's necessary to change any of the docblocks in l10n.php
If required I will furnish more documentation that explains the ""Just Translate It"" approach." bobbingwide
1 41549 REST API: Use `wp.apiRequest` helper in `wp.api` Backbone client adamsilverstein REST API normal normal Future Release enhancement assigned needs-unit-tests 2017-08-03T14:50:13Z 2018-02-01T22:26:54Z "Follow-up to #40919. The `wp-api.js` Backbone client should use `wp.apiRequest` to do its API calls. This may be accomplished through overriding `Backbone.ajax` or through a change in the `wp-api.js` code.
This will allow client-side code to override or modify all WP REST API calls in a single, centralized place.
cc @adamsilverstein for your thoughts on the best way to achieve this." jnylen0
1 41546 WP Query order by meta_clause not working correctly for decimal values Query 4.2 normal normal Awaiting Review defect (bug) new 2017-08-03T13:06:36Z 2017-08-05T07:13:01Z "Short description: When using the WP 4.2 improvements for meta queries (as described here: https://make.wordpress.org/core/2015/03/30/query-improvements-in-wp-4-2-orderby-and-meta_query/) and trying to order the query by a decimal custom field, wordpress orders as if these fields are all integer and incorrectly handles all decimal values such as 1.5, 1.6 and 1.7 (all of these are seen as 1).
In detail:
{{{
WP_QUERY_ARGS Array
(
[ignore_sticky_posts] => 1
[post_status] => publish
[offset] => 0
[post_type] => Array
(
[0] => post
)
[orderby] => Array
(
[cf_clause_1] => DESC
[ID] => ASC
)
[meta_query] => Array
(
[cf_clause_1] => Array
(
[key] => my_decimal_custom_field
[type] => DECIMAL
[compare] => EXISTS
)
)
[posts_per_page] => 10
[nopaging] =>
)
}}}
5 Test posts:
Post 1 - my_decimal_custom_field = 1
Post 2 - my_decimal_custom_field = 2
Post 3 - my_decimal_custom_field = 2.2
Post 4 - my_decimal_custom_field = 2.6
Post 5 - my_decimal_custom_field = 3
Using the query above results in the order:
1,3,4,2,5
When it should be 1,2,3,4,5.
Trying out different order types as described in the WP Codex does not help." LordSpackolatius
2 41545 Allow cmd/ctrl-enter to submit comment forms lindstromer Comments normal minor Awaiting Review enhancement assigned has-patch 2017-08-03T13:05:11Z 2018-02-08T15:49:52Z It's become fairly common for comment/reply forms on the web to be submitted with cmd/ctrl-enter. Some quick examples include Twitter and GitHub, neither of which tells you as far as I've seen but rather just lets you discover it works. I think it'd be a nice enhancement for comment forms in both the admin and front end to submit this way. In particular, it would make managing and responding to comments a little smoother. helen
1 41544 $id_or_email parameter in get_avatar filter needs to be more concrete Users normal normal Awaiting Review enhancement new dev-feedback 2017-08-03T10:16:03Z 2017-10-14T14:06:35Z "In the {{{get_avatar}}} and {{{pre_get_avatar}}} filters there is a parameter {{{$id_or_email}}} which documented as:
> The Gravatar to retrieve. Accepts a user_id, gravatar md5 hash, user email, WP_User object, WP_Post object, or WP_Comment object.
There might be anything, but how to get user from it?
So, in filter callback function, developer have to check all of these types to determine the actual user identifier.
Like here https://core.trac.wordpress.org/browser/tags/4.8.1/src/wp-includes/link-template.php?rev=41211#L3923-L3965
Would be much more better to have more concrete value type in {{{$id_or_email}}} parameter (for example user ID) passed to {{{get_avatar}}} and {{{pre_get_avatar}}} filters. Really.
" dikiy_forester
41539 Dates not localized in admin-ajax when logged in I18N 4.7.4 normal normal Awaiting Review defect (bug) new close 2017-08-02T20:19:51Z 2017-08-03T15:31:47Z "I have a localized theme set to Spanish language. Everything works fine.
I change my user profile language to English.
Now, when logged in, the method called by admin-ajax returns the dates in English, not Spanish. Everything else remains in Spanish.
When not logged in, or when my user profile language is set to Spanish, the method called by admin-ajax returns the dates in Spanish, as expected.
I'm assuming that admin-ajax is defaulting to the user language instead of the theme language. This is a problem if you are trying to develop themes in languages other than your own.
It is also a problem because there is no obvious way to fix this. I've tried many ways to localize the dates manually in the method called by admin-ajax, but nothing works. I've even added a load_textdomain() call before the dates, but that doesn't localize them either.
" philjms
4 41535 Prevent or warn about offline status before submitting a form Administration normal normal Awaiting Review feature request new dev-feedback 2017-08-02T15:09:27Z 2018-04-18T20:35:09Z "For browsers that support it, the `navigator.online` property reliably indicates that the browser is offline (the inverse isn't true, but it doesn't matter).
Prior to submission of a form in the admin area (for example the post editing screen form), WordPress should check the value of `navigator.online` and present a prompt to the user stating that they appear to be offline. They can close the prompt or, optionally, ignore it and continue with the form submission.
This functionality would help prevent data loss when a user submits a form while they don't have an internet connection." johnbillion
41534 Styles added with `add_editor_style` are not added to custom `wp.mce` views on initial load Editor 4.8 normal normal Awaiting Review defect (bug) new dev-feedback 2017-08-02T14:54:54Z 2017-08-02T15:08:16Z "We have a custom wp.mce view built to render a shortcode that broke since the recent upgrade of TinyMCE in r40583.
Since this change, the view is rendered without its required stylesheets the first time the Visual editor loads. switching to the text view then back to visual correctly loads the stylesheets into the iframes.
I tracked down what is supposed to happen: in `wp-includes/js/mce-view.js` the function `setIframes` iterates thru all of the view iframes embedded in the editor and copies the stylesheets from the editor into the view iframes. In this way, the stylesheet added to the editor with `add_editor_style` are added to the iframes so they have the styles they need to render.
Since the TinyMCE update, the stylesheets are not yet present in the editor when this runs the first time. In my testing wrapping the `setIframes` callback in a `setTimeout(,0)` call was enough to resolve the issue although the root issue may be in where this call is triggered." adamsilverstein
2 41531 problem with wpautop Formatting 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-08-02T09:51:45Z 2017-09-03T12:46:17Z "Hi,
I think there is a problem with the function wpautop
It produce extra closing

in my content, But no need to them at all
Here is the HTML which I add in the editor:
{{{

}}}
" parsmizban
41527 Correct indentation in header.php file of Twenty Sixteen theme Bundled Theme 4.9 normal normal Awaiting Review defect (bug) new has-patch 2017-08-02T05:11:38Z 2017-08-02T05:14:00Z There is a excess space in line 56, column 37 truongwp
41522 wp_set_password() doesn't trigger a changed password notification Users normal normal Awaiting Review defect (bug) new dev-feedback 2017-08-01T20:30:59Z 2017-08-02T13:53:31Z "If {{{wp_update_user()}}} is used to update a user's password, a notification is sent to the user telling them their password has changed.
However, the same doesn't happen if {{{wp_set_password()}}} is used to update a user's password." henry.wright
7 41520 Disable deprecated functions Bootstrap/Load normal normal Awaiting Review enhancement new dev-feedback 2017-08-01T20:16:06Z 2017-12-14T23:49:59Z In bootstrap process, deprecated.php, pluggable-deprecated.php and ms-deprecated.php are includes. These files include all the deprecated functions in core. This is done for compatibility reasons, however there are many setups that do not requires these functions as they are not using any of these functions. These files inline over 4500 lines of code ( 3881 + 208 + 518 ). There should be an option to disable them. spacedmonkey
41518 The full-path body class is missing a hyphen. Posts, Post Types 4.9 normal normal Awaiting Review defect (bug) new close 2017-08-01T16:38:39Z 2017-08-04T16:39:42Z "In a case where page templates (eg ""full-width.php"") are in a folder called ""templates"" - a body class is created called ""page-template-templatesfull-width-php"". This is because post-template.php line 611 sanitizes the file path without replacing ""/"" with a hyphen like it does for template name parts on line 609.
I suggest replacing 611 with
{{{
$classes[] = ""{$post_type}-template-"" . sanitize_html_class( str_replace( array( '.', '/' ), '-', $template_slug ) );
}}}
" isaaclubow
41517 Preview Changes results in Schedule button instead of Update fresh install 4.8 with Twenty Seventeen Theme General 4.8 normal minor Awaiting Review defect (bug) new 2017-08-01T16:26:40Z 2017-08-01T16:27:43Z "Fresh install of 4.8 using Twenty Seventeen Theme with no active plugins. Editing an already published page and clicking Preview Changes activates the ""Schedule"" button instead of ""Update.""
This is only a minor irritation, since clicking ""Schedule"" immediately changes the button back to ""Update,"" but each click does produce a new revision, and even the ""schedule"" option actually performs the ""Update"" action.
Before ""Preview Changes"" Button clicked:

After ""Preview Changes"" Button clicked :

JQMIGRATE: Migrate is installed, version 1.4.1
Using Chrome (incognito mode) Version 59.0.3071.115 (Official Build) (64-bit) on Windows 7 Professional. (Clearing Cache did not change the result)
Tested on PHP 5.6.31, PHP 7.0.21 and 7.1.7
Tried a second clean installation on a test subdomain and DID reproduce the same result. However, upgrading an existing site to 4.8 did NOT reproduce the symptoms." eclath
41516 PNG Image Saturation Loss on Resize Media 4.8 normal normal Awaiting Review defect (bug) new 2017-08-01T16:08:23Z 2017-08-04T04:16:39Z "I work with PNG images made with grey colors. And the colors change because of wordpres, not the original image, but all the new sizes.
By default make the colors much darker but sometimes, also is weird:
[[Image(http://i.imgur.com/L3Sk1Rg.png)]]
Left and right are the same image. Some times handle even different for the same K=70 color.
( I export with Adobe illustrator to sRGB )" colomet
1 41514 Registration links disappear after requesting a password reset link Login and Registration normal normal Future Release defect (bug) new has-patch 2017-08-01T15:15:22Z 2017-10-08T21:29:17Z After requesting a password reset link at example.com/wp-login.php?action=lostpassword, the registration links (that were under the Log In button) disappear. See the attached screenshot(s) for visuals. henry.wright
1 41511 Attachment page URL not created correctly for image uploaded directly to library before being added to post Editor 4.8 normal normal Awaiting Review defect (bug) new 2017-08-01T10:11:55Z 2018-03-22T20:36:13Z "=== To replicate: ===
1. Visit Media ->Add New and upload a media file
2. Visit Posts ->Add New
3. Click Add Media
3. Select the media file previously uploaded and set Link To setting to Attachment Page
4. Publish the post
5. View post and click on image
=== What I expected: ===
To be taken to the attachment page for the image
=== What happened instead: ===
I got a Page not found error. Additionally the URL is formed as `http://SITE_URL/FILE_SLUG/` which is not the correct format for media attachment pages.
I went back to the editor, clicked the image and clicked the edit icon. The Link To setting now shows that I have a Custom URL set instead of Attachment Page.
Updating the setting to attachment page again changes the URL to `http://SITE_URL/YEAR/MONTH/POST_SLUG/FILE_SLUG/`
If I now update the post, I can click the image to view the attachment page.
=== Context: ===
Reported via the [http://en.forums.wordpress.com/topic/problems-with-images-and-attachment-page-custom-url-settings WordPress.com support forums], but I've confirmed it on a non-WordPress.com site as well." kokkieh
41504 Document global variables in dropdown_categories() and dropdown_link_categories() Taxonomy low normal Awaiting Review defect (bug) new has-patch 2017-08-01T07:00:10Z 2017-08-01T12:56:51Z In dropdown_categories() and dropdown_link_categories() function define global $post_ID and $link_id respectivly but it is not mentioned in comment. umangvaghela123
41502 _wp_expand_nav_menu_post_data() corrupts multiple select (array value) Menus 4.9 normal normal Awaiting Review defect (bug) new has-patch 2017-08-01T04:01:03Z 2017-12-13T23:29:49Z "Hi guys.
Elliot here - ACF developer.
I've recently added custom fields to the WP menu and WP menu item forms.
In doing so, i have discovered that the `_wp_expand_nav_menu_post_data()` function (called in wp-admin/nav-menus.php on line 56) is corrupting some array $_POST values.
The issue is caused with inputs using a name like so:
`my_field[]`
`my_field[]`
Please note that there is no issue when a key is defined like so:
`my_field[0]`
`my_field[1]`
There are many cases where a developer would not define the 'keys' of an 'array type' input name. Think of a multiple select element. The element accepts only one name attribute and it must be defined like so `my_field[]`.
- Also, checkbox / radio fields are commonly rendered using the same naming style.
Is it possible to request some extra logic within the `_wp_expand_nav_menu_post_data()` function that allows for this?
I suspect the issue is caused on line 1125 of the 'wp-admin/includes/nav-menu.php' file where the $_POST value is modified:
`$new_post_data[ $array_bits[ $i ] ] = wp_slash( $post_input_data->value );`
Thanks
Elliot" elliotcondon
3 41500 Custom TinyMCE style formats not working for Text Widget azaozz Widgets 4.8 normal normal Awaiting Review defect (bug) assigned 2017-07-31T21:47:19Z 2017-09-05T20:25:14Z "This is a follow-up to #35243.
I'm not sure what the source of the error is, but custom TinyMCE style formats do not work with the new Text Widget.
The `mce_buttons`, `mce_buttons_2`, etc. filters all happen before the `tiny_mce_before_init` filter, however, buttons are added differently for the new Text Widget. I'm not sure how, bu the only documentation provided to interact with the Text Widget I could find is here, and it is done through JS rather than WP filters.
https://make.wordpress.org/core/2017/05/23/addition-of-tinymce-to-the-text-widget/
I'm a little bit familiar with extending TinyMCE. Since `styleselect` is a baked-in button for accessing style formats, you can change the code to add it in, like this:
{{{#!js
jQuery( document ).on( 'tinymce-editor-setup', function( event, editor ) {
editor.settings.toolbar1 += ',styleselect';
});
}}}
However, as the ticket title mentions, custom style formats added in with the `mce_button` filters do not seem to affect Text Widget's visual editor's `styleselect` choices. Only the defaults show.
Also, doing it this way adds the buttons to ALL TinyMCE instances. I can probably just check for a class in the DOM, but it feels really inappropriate to add a button this way when there are already pre-existing filters for modifying the buttons. The fact that this editor instance affects both Text Widget and the main Visual Editor for posts is confusing. It implies they're the same instance, but you can't modify them in the same way.
I've looked forever and tried to figure out how the Text Widget editor is instantiated with the stripped down toolbar. If anyone wants to point me in the right direction, I'd love to tackle this bug (assuming this isn't intentional).
If you'd like to test out this problem for yourself, you can use this test code below. You will see ""Formats"" being added to the Text Widget via JS, but it affects all instances. The `mce_buttons` will only add it for the posts' TinyMCE instance. Style formats are presented differently depending on which editor you're using. The custom ones don't get added to the Text Widget.
{{{#!php
'Swag',
'inline' => 'span',
'classes' => 'swag',
'wrapper' => true,
),
);
$formats['style_formats'] = json_encode( $style_formats );
return $formats;
}
add_filter( 'tiny_mce_before_init', 'my_tinymce_formats' );
function my_mce_buttons( $buttons ) {
array_unshift( $buttons, 'styleselect' );
return $buttons;
}
add_filter( 'mce_buttons', 'my_mce_buttons' );
// for demonstration purposes, not how I'd actually implement! :P
function my_text_widget_buttons() {
ob_start();
?>
[1]
Using a file not saved to OneDrive doesn't exhibit this problem.
" repwolfe
1 41474 Feature Request: Download Media button from Attachment Details Page Media 4.8 normal normal Awaiting Review enhancement new 2017-07-28T14:30:15Z 2017-07-28T14:30:15Z "Hello,
Sorry if this has been posted but would love a simple ""Download Media"" button or link from the media Attachment Details lightbox popup. This this is super simple yet would be helpful if you are trying to simply grab a photo that is in your WP media library.
[[Image(https://swinterroth.com/wp-content/uploads/2017/07/Screen-Shot-2017-07-28-at-9.26.45-AM-squashed.png)]]" countrymusicchicago
41471 Page dropdown walker must check selected against value field General 4.9 normal normal Awaiting Review defect (bug) new 2017-07-28T03:36:18Z 2017-07-28T03:36:18Z `Walker_PageDropdown` only checks `selected` with the page `ID` and ignores `value_field` option. geminorum
41469 test_charset_switched_to_utf8() is not tested on Travis CI Database 4.7.1 normal normal Awaiting Review defect (bug) new 2017-07-28T00:26:11Z 2017-07-28T02:09:13Z "The `Tests_DB::test_charset_switched_to_utf8()` test (introduced in #37982) is skipped on Travis, because the test gets skipped when the environment's database driver supports utf8mb4. This makes the test useless.
What sort of environment does not support utf8mb4? Presumably an older MySQL version.
We should look into adding a build to Travis with a specific environment that allows this test to run.
Related: #30462" johnbillion
41468 "Provide contextual info about what ""attached"" and ""detached"" means regarding media objects" Media normal normal Awaiting Review defect (bug) new 2017-07-27T22:10:56Z 2017-07-30T14:25:03Z "From user testing:
""I have no idea what it means when it says an image is 'Attached' to a post. Does it mean the image is in the post? Does it mean if I 'Detach' the image from the post it will go away from the post? I'm worried a client might 'Detach' an image from a post to remove it, or 'Attach' an image to add it. What is this for? How can an image be 'Unattached' to the post it is displayed in anyway?""" mor10
41466 Allow cropping of images from inside the content editor Media 4.9 normal normal Awaiting Review enhancement new 2017-07-27T21:59:16Z 2017-07-27T21:59:16Z "In user testing, several people have requested the ability to crop images in the editor context after they have been placed. The expectation seems to be that this should be possible, and the abstraction of having to go to the edit media panel to do this results in the user having to crop the image multiple times to ""get it right"".
This suggestion has several significant sticking points:
1. The idea of cropping images to ""fit"" within the context of content makes no sense when considering RWD.
2. Users who crop images also expect to be able to uncrop them later or in other contexts when the image is reused.
3. Hard cropping images by changing the file is becoming a somewhat archaic practice thanks to CSS masking and cropping.
Possible solutions:
1. Provide tools for theme developers to provide display sizes and shapes for images in the editor through CSS and take full advantage of RICG image scaling (related to #35094).
2. Allow ""soft"" cropping through CSS (introduces complications with RWD, but better than hard cropping).
3. Disallow cropping at all." mor10
41465 Drag-and-drop image placement is confusing Media 4.9 normal normal Awaiting Review defect (bug) new 2017-07-27T21:52:14Z 2017-07-27T21:52:14Z "When a user drags-and-drops an image onto the editor, the image placement is not obvious and the experience leaves users confused:
- At the start of the process, the text caret is somewhere in the text.
- on drag-and-drop, the add media panel appears abstracting the user from the task of placing the image in the correct context in the text.
- When the add image panel is exited by clicking ""Add Image"", the image appears where the cursor was originally placed.
The introduction of the abstraction layer of the Add Image panel causes the user to shift focus enough that the final location of the image placed in the text seems arbitrary.
Possible solutions:
1. Allow the user to drag the image onto the canvas and place it in context by visualizing a placeholder container before the modal is opened. The modal should only open after placeholder placement is made so the user knows where they placed the image before dealing with metadata.
2. If the sequence of events must start with the add media modal, allow the user to place the image within context after clicking Add image: Rather than the image being placed at the current caret position, show a placeholder with an interactive outline the user can drag around and position before the actual image is placed.
Image placement via drag-and-drop is an issue that shows up often in user testing. It is poorly understood and leads users to feel like WordPress is either acting at random or worse making decisions on their behalf." mor10
1 41463 Improve REST API tests that don't perform any assertions johnbillion* REST API 4.7 normal normal Future Release enhancement accepted needs-unit-tests 2017-07-27T18:02:35Z 2017-08-10T17:31:07Z "There are a bunch of REST API tests that don't perform any assertions. This creates noise in the test results as they get marked as risky tests.
These tests are present because their test class extends the abstract `WP_Test_REST_Controller_Testcase` class, which requires several methods to be implemented which don't make sense for all REST API routes.
These tests can be improved so they do actually perform assertions related to their behaviour." johnbillion
41462 Promote media details admin page to full post page Media 4.9 normal normal Awaiting Review enhancement new 2017-07-27T17:43:26Z 2017-07-27T17:43:26Z "Currently when editing media metadata, you either get the modern library modal with the image on the left and various fields on the right. When you click ""Edit more details"" you get a blast from the past with an old-school version of WordPress admin where everything looks uninspired and, for new users, broken.
Based on user feedback it turns out some site owners use the Attachment Page feature to provide contextual info, commenting, etc for media items. One example was a teacher who uploaded student images to a gallery, then had each image link to the attachment page where further information and images were provided in the ""description"" field (so the post content) and parents could leave comments.
Since media items in reality are full fledged posts with their own post content, the media details admin view should be upgraded to a full post page with proper WYSIWYG editing for the Description field, custom fields, and ability to control things like commenting.
This would also be an ideal place to visualize in what posts a media item is in use across the site." mor10
1 41461 Sort out missing attachment.php template somehow Themes normal normal Awaiting Review enhancement new close 2017-07-27T17:35:51Z 2017-10-08T18:43:17Z "When a visitor goes to an attachment page (typically linked from a gallery) and the theme does not have an attachment template, they get a random and most often broken user experience. This is largely due to theme developers not creating an attachment.php template (and starter themes like Underscores not providing one), but it is perceived by visitors and site owners as an error.
There must be some way of gracefully capturing requests for attachment pages when the theme has no support for them so the info is displayed in a non-broken format." mor10
3 41459 Introduce a REST API endpoint for networks / network options REST API normal normal Future Release task (blessed) new needs-unit-tests 2017-07-27T16:55:56Z 2017-10-30T20:14:31Z "Similar to sites in #40365, there should be a networks endpoint as part of the REST API.
Through recent multisite discussions, we have come to the conclusion that, while multi-network should never be part of core, there should be basic and unopinionated APIs present that can be used by whoever wants to implement it.
A basic networks API in these terms implies that it's a simple CRUD API for the `wp_site` database table. #29411 will introduce the internal core functions that this endpoint will be able to use.
The endpoint should be able to do the following:
* List networks: `GET wp/v2/networks/`
* Retrieve a network: `GET wp/v2/networks/`
* Create a network: `POST wp/v2/networks/`
* Update a network: `PUT wp/v2/networks/`
* Delete a network: `DELETE wp/v2/networks/`
Once the changes in #25344 is in place, a network meta endpoint should be created as well. For now this will be part of this ticket too.
Note that this ticket is an early one and will lay around for a while. The other non-network-related roadmap items have a higher priority." flixos90
41458 Class gets stripped out when inserting a link in author biography box Formatting 3.5 normal normal Awaiting Review enhancement new 2017-07-27T16:44:55Z 2017-07-30T16:11:39Z "Class gets stripped out when inserting a link in author biography box
For example My link
becomes
My link" neodjandre
41456 Rename $buttons to $mce_buttons in 'mce_buttons' filter DocBlock Editor normal normal Awaiting Review defect (bug) new 2017-07-27T14:09:24Z 2017-08-05T15:21:39Z the function in parameter $mce_buttons define but documentation parameter define in $buttons upadalavipul
41451 Use pretty permalinks by default in the test suite Build/Test Tools normal normal Awaiting Review enhancement new needs-unit-tests 2017-07-26T21:16:09Z 2017-12-28T18:46:55Z "There are 118 instances of `$this->set_permalink_structure( ... )` in the test suite. The majority of these calls are present simply to enable pretty permalinks, regardless of the permastructure for posts.
Pretty permalinks should be enabled by default for the test suite. Let's try it and see if anything breaks." johnbillion
41448 Contributors shouldn't be able to change the date of their drafts Posts, Post Types 2.7 low normal Future Release defect (bug) new needs-unit-tests 2017-07-26T12:33:48Z 2017-08-04T13:24:10Z "(I'm guessing that) contributors shouldn't be able to change a post's publication date—that's why the ''Publish'' box doesn't include the date when logged in as a contributor in the first place. However, if a contributor quick edits a post in the ''All Posts'' screen, they'll be able to change the post's date.
We should remove the date field from the ''Quick Edit'' form. Or, alternatively, we should allow contributors to edit this date while they're editing a post. Either way, both screens should be consistent." davilera
2 41446 The PHP notice displayed after the overwriting global $posts by a new empty query. Query 4.8 normal normal Awaiting Review defect (bug) new 2017-07-26T07:57:45Z 2017-07-26T12:42:21Z "'''Tested in WordPress 4.8, twentyseventeen theme with default configuration (just installed).'''
After the overwriting a global variable {{{$posts}}} by a new {{{get_posts()}}} query (which return an empty array (no posts)) there is a PHP notice displayed:
{{{
Notice: Undefined offset: 0 in /.../wp-includes/class-wp-query.php on line 3162
}}}
The overwriting is not a best choice, but some themes and plugins do it, so we should solve this problem.
The problem is in {{{WP_Query}}} class in {{{rewind_posts()}}} method in {{{wp-includes/class-wp-query.php}}} file.
'''The original method:'''
{{{#!php
current_post = -1;
if ( $this->post_count > 0 ) {
$this->post = $this->posts[0];
}
}
}}}
'''The problem:''' the global query has at least one posts, but a new query has not. So the {{{$this->post_count}}} property is always positive, but the {{{$this->posts[0]}}} is not exists. In this step, the PHP notice is displayed.
'''An example of solution:'''
{{{#!php
current_post = -1;
if ( $this->post_count > 0 && isset( $this->posts[0] ) ) {
$this->post = $this->posts[0];
}
}
}}}
Right now the method checks that the query has posts and the first post is set and is not null." danielpietrasik
11 41445 post_parent can prevent media from embedding correctly REST API 4.9.4 normal normal Awaiting Review defect (bug) new dev-feedback 2017-07-26T06:29:28Z 2018-02-15T14:06:30Z "If media is uploaded for a post, then used as a featured image on another post, and the original parent is not accessible via the REST API (e.g. because it's in the trash, not published etc), then it cannot be embedded on the post that ''is'' accessible.
To reproduce
* make a new post with a featured image
* trash the post
* make a new post, using the first image as the featured image
* request the second post over the rest API with media embedding enabled
The media will not be embedded, instead a forbidden result will be embedded error
{{{#!json
{
""wp:featuredmedia"":[
{
""code"":""rest_forbidden"",
""message"":""You don't have permission to do this."",
""data"":{
""status"":403
}
}
]
}
}}}
See https://github.com/WP-API/WP-API/issues/2596 for the original issue. Also related is https://core.trac.wordpress.org/ticket/30691.
" loboyle
1 41443 Update /wp-admin/network/site-new.php to use wpmu_validate_blog_signup() Networks and Sites 4.8 normal normal Awaiting Review enhancement new 2017-07-25T21:29:37Z 2017-09-27T06:04:28Z Is there a good reason that /wp-admin/network/site-new.php uses it's own hard-coded blogname validation rules? Shouldn't it just call wpmu_validate_blog_signup() for DRY as well as a consistent / universal application of filters across all new site names? It seems crazy to have two different sets of validation for the same thing. And as multisite plugin developers we see network admins confused by the different behavior of site-new.php and sites created through plugins which use wpmu_validate_blog_signup(). neversettle
4 41442 Show nearby events in dashboard events widget in a per country basis Administration 4.8 normal normal Awaiting Review enhancement new 2017-07-25T18:51:10Z 2018-04-25T12:52:15Z "Hi!
I've noticed that the new events dashboard widget don't show all WordCamps in a country basis. It shows only that ones nearby in kilometres, 400 kms as seen in code (https://meta.trac.wordpress.org/browser/sites/trunk/api.wordpress.org/public_html/events/1.0/index.php?rev=5559&marks=707,708#L703).
That way, i.e., for an Spanish WordPress user from Madrid (in the geographical center of the Country) it going to be impossible to know about WordCamps in Chiclana (Cádiz) or others far away from that 400 kms standard, and totally impossible for anybody to know about a WordCamp in Las Palmas (Canary Islands), and impossible for anyone that lives in Canary Islands to know about continent WordCamps.
It could be possible to extend/change the range to a country basis (best) or more kilometres?" fernandot
1 41441 Deleting a theme from a single site's Themes screen should not be allowed Themes normal normal Awaiting Review defect (bug) new 2017-07-25T18:42:40Z 2017-07-25T18:42:40Z "With Multisite enabled, it's not possible to delete a plugin from the Plugins screen in individual sites' dashboards. The `Delete` link is removed.
The same should be true for themes. Currently, a `Delete` button is shown when a super admin views the Themes screen on an individual site." johnbillion
1 41439 A super admin cannot remove themselves from a site Users 3.0 normal normal Awaiting Review defect (bug) new 2017-07-25T17:52:24Z 2017-09-20T12:58:56Z A super admin cannot remove themselves from a site, either from the `Users` listing screen in the site's dashboard or from the `Users` tab when editing the site. There's no reason to prevent this from being possible. johnbillion
41434 $wpdb need to be mentioned for documentation General normal normal Awaiting Review defect (bug) new 2017-07-25T12:32:58Z 2017-07-25T12:32:58Z tejas5989
1 41432 Allow ircs protocol handler in default allowed whitelist for hyperlinks General normal normal Awaiting Review feature request new 2017-07-25T11:41:29Z 2017-07-25T11:41:29Z "Would it not be an idea to allow for protocol `ircs://` in default allowed whitelist of protocols in WP ?
Today only `irc://` is allowed.
But not the secure handler `ircs://` ..." arealnobrainer
41431 Need autocomplete attributes in wp_login_form() for security purpose General normal normal Awaiting Review defect (bug) new 2017-07-25T09:28:56Z 2017-07-25T09:31:23Z For security purpose need autocomplete attribute. tejas5989
41430 "TinyMCE: ""highlight"" the image caption DL when the image is selected" TinyMCE normal normal Future Release enhancement new 2017-07-25T08:16:03Z 2017-09-27T16:24:32Z Follow up from #41408. When an image with a caption is selected, or the caption field is focused, it would be good to indicate that the image is part of a larger object. azaozz
1 41428 Editor: long URLs are not broken in notifications Editor 4.8 normal normal Future Release defect (bug) new close 2017-07-24T21:55:25Z 2018-01-22T13:05:18Z "I have Google Fonts blocked in `/etc/hosts` and I get this notification when I edit a post, which is fine, except by the fact that it overflows:
[[Image(https://cldup.com/t7l1Z2fRi