Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.

--- a/widget/nsBaseFilePicker.cpp+++ b/widget/nsBaseFilePicker.cpp@@ -69,17 +69,17 @@ class AsyncShowFilePicker : public mozil public: AsyncShowFilePicker(nsIFilePicker *aFilePicker, nsIFilePickerShownCallback *aCallback) : mFilePicker(aFilePicker), mCallback(aCallback) { }- NS_IMETHOD Run()+ NS_IMETHOD Run() override { NS_ASSERTION(NS_IsMainThread(), "AsyncShowFilePicker should be on the main thread!"); // It's possible that some widget implementations require GUI operations // to be on the main thread, so that's why we're not dispatching to another // thread and calling back to the main after it's done. int16_t result = nsIFilePicker::returnCancel;

--- a/xpcom/threads/TaskDispatcher.h+++ b/xpcom/threads/TaskDispatcher.h@@ -169,17 +169,17 @@ private: AbstractThread::DispatchFailureHandling mFailureHandling; }; class TaskGroupRunnable : public Runnable { public: explicit TaskGroupRunnable(UniquePtr<PerThreadTaskGroup>&& aTasks) : mTasks(Move(aTasks)) {}- NS_IMETHODIMP Run()+ NS_IMETHOD Run() override { // State change tasks get run all together before any code is run, so // that all state changes are made in an atomic unit. for (size_t i = 0; i < mTasks->mStateChangeTasks.Length(); ++i) { mTasks->mStateChangeTasks[i]->Run(); } // Once the state changes have completed, drain any direct tasks