On Thursday, 19 October 2017 20:57:40 CEST Andrew Bartlett wrote:
> On Thu, 2017-10-19 at 11:28 -0700, Jeremy Allison via samba-technical
>> wrote:
> > On Thu, Oct 19, 2017 at 05:37:41PM +0200, Andreas Schneider via samba-
technical wrote:
> > > Hi,
> > >
> > > the attached patch fixes building Samba with MIT Kerberos. The pointer
> > > for
> > > model_ops is uninitialized.
> > >
> > > error: ‘model_ops’ may be used uninitialized in this function
> > > [-Werror=maybe- uninitialized]
> > >
> > > We have in the README.Coding that pointers should be *ALWAYS*
> > > initialized!!
> > >
> > >
> > > Please review and push if OK.
> >
> > RB+. Obvious goodness. We should move towards
> > enabling compiler switches that force *all* auto
> > variables to be initialized.
>> -1
>> Sorry, I think this is wrong. Sadly there are no automated tests for
> the MIT build as part of autobuild, and unless I'm reading the code
> wrong, this will just make the use of the kpasswd server fail in the
> MIT case as that pointer needs to be filled (as it is elsewhere) in
> instead of being set to NULL.
So it needs to be:
const struct model_ops *model_ops = process_model_startup("single");
>> We need the MIT KDC to be a full part of autobuild, with an appropriate
> git tag tracked in Samba and built as part of our build process.
Well, install a newer libkrb5 on autobuild and we can do that.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.org asn at cryptomilk.org