On Sat, 2012-03-24 at 16:02 +0500, Mike Sinkovsky wrote:> Based on original driver from chip manufacturer, but nearly full rewite.> Tested and used in production with Blackfin BF531 embedded processor.

Hi Mike.

Just a trivial comment. Instead of: if (netif_<test>(priv)) netdev_<level>(ndev, ...)you can use netif_<level>(priv, <test>, ndev, ,...)