> On Jan 15, 2020, at 1:09 AM, Yang Shi <yang.shi@linux.alibaba.com> wrote:> > The VM_BUG_ON() is already used by queue_pages_test_walk(), it sounds> better to dump more debug information by using VM_BUG_ON_VMA() to help> debugging.
What’s the problem this is trying to resolve? Was there an existing bug would trigger this?

On 1/27/20 10:17 AM, Qian Cai wrote:
>>> On Jan 15, 2020, at 1:09 AM, Yang Shi <yang.shi@linux.alibaba.com> wrote:>>>> The VM_BUG_ON() is already used by queue_pages_test_walk(), it sounds>> better to dump more debug information by using VM_BUG_ON_VMA() to help>> debugging.> What’s the problem this is trying to resolve? Was there an existing bug would trigger this?
Dumping more information to help debugging. I don't run into related bug
personally.

> On Jan 27, 2020, at 2:57 PM, Yang Shi <yang.shi@linux.alibaba.com> wrote:> > Dumping more information to help debugging. I don't run into related bug personally.
This is a relatively weak justification for merging. If we are keeping accepting those mindless debugging patches, the workload will be unbearable for all.

On Mon, 27 Jan 2020 15:23:08 -0500 Qian Cai <cai@lca.pw> wrote:
> > > > On Jan 27, 2020, at 2:57 PM, Yang Shi <yang.shi@linux.alibaba.com> wrote:> > > > Dumping more information to help debugging. I don't run into related bug personally.> > This is a relatively weak justification for merging. If we are keeping accepting those mindless debugging patches, the workload will be unbearable for all.
I think it's OK. If this ever triggers the kernel is dead, so the
volume of output isn't a problem. And if it triggers, the more info
the better.

> On Feb 14, 2020, at 12:26 AM, Andrew Morton <akpm@linux-foundation.org> wrote:> > I think it's OK. If this ever triggers the kernel is dead, so the> volume of output isn't a problem. And if it triggers, the more info> the better.
Well, I could think of millions of ways to just add more info for those theoretical assertion places where we will eventually be running out of review bandwidth if people start to “abuse” it. Anyway, if maintainers are willing to take risks on that path, I’ll not complain.