Kihwal Lee
added a comment - 26/Feb/14 15:35 The patch fixes 4 findbugs warnings.
Three were for ignoring return value of File.delete(). Moved them into a conditional statement and added logging.
Fourth was for not closing a FileWriter instance in some cases. This was originally ignored since it is non-critical and during shutdown. A finally block has been added to close it at all times.
The fifth warning is not something introduced by recent changes. There already is an entry in the exception list for this. So I am not fixing this.
<Match>
<Class name="org.apache.hadoop.hdfs.DFSClient$DFSOutputStream$DataStreamer$ResponseProcessor" />
<Method name="run" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>

Hi, Kihwal. This patch looks good. Minor nit: the finally block for closing the FileWriter could be simplified to a one-liner using IOUtils#cleanup or IOUtils#closeStream. +1 after that's addressed. Thanks!