Created attachment 301768[details]
Screenshot with different users in 1280x1024
1. Shouldn't it be "waves" instead of "wave"?
http://fedoraproject.org/wiki/Artwork/F9Themes/Waves
2. For infinity and flyinghigh we've used the prefix "fedora":
fedoraflyinghigh-kdm-theme and fedorainfinity-kdm-theme
So I would suggest "fedorawaves-kdm-theme" as name.
3. Please have a look at the screenshot. It'll need some work:
- hostname is bigger than the box
- font color needs some changes for not selected users

Sebastian, what color scheme are you using? The author says you should use
ObsidianBlue.
For the "hostname is bigger than the box" problem, we should just make the box
wider, there's plenty of room.
I'll do the review when I get back home.
The name should be waves-kdm-theme or fedorawaves-kdm-theme. I'm not sure
about the "fedora" part because the theme doesn't actually contain a Fedora
logo, but on the other hand it makes it clear where the theme is coming from.

(In reply to comment #3)
> Sebastian, what color scheme are you using? The author says you should use
> ObsidianBlue.
Oxygen (the default in current kdmrc). Where do I get ObsidianBlue?
kdebase-workspace only contains ObsidianCoast ATM.
> The name should be waves-kdm-theme or fedorawaves-kdm-theme. I'm not sure
> about the "fedora" part because the theme doesn't actually contain a Fedora
> logo, but on the other hand it makes it clear where the theme is coming
from.
AFAIR also fedorainfinity-kdm-theme and fedoraflyinghigh-kdm-theme didn't
contain a Fedora logo. So I would prefer fedorawaves-kdm-theme as %name
(and /usr/share/kde4/apps/kdm/themes/FedoraWaves as directory).

1. Shouldn't it be "waves" instead of "wave"?
>http://fedoraproject.org/wiki/Artwork/F9Themes/Waves
it's typo, it should be waves.
>2. For infinity and flyinghigh we've used the prefix "fedora":
>fedoraflyinghigh-kdm-theme and fedorainfinity-kdm-theme
i will rename it to fedorawaves-kdm-theme.
>3. Please have a look at the screenshot. It'll need some work:
> - hostname is bigger than the box
it's knowned issue. I already talked with Pavel, he will fix it properly today
evening. Temporary i will make the box wider.
> - font color needs some changes for not selected users
ObsidianCoast works fine for me.

Created attachment 301783[details]
Screenshot with ColorScheme=ObsidianCoast in 1280x1024
(In reply to comment #6)
> ObsidianCoast must be what I meant, that was from memory and I just didn't
> remember it correctly.
Ok. :)
ObsidianCoast looks better then.