Hello Peter,
>>>>> Peter Åstrand wrote:
> The patch below, submitted as a part of revision 2584, causes a major
> bug: Very often, updates are not correctly sent to the client.
>> - server->checkUpdate();
>> + static int counter = 1;
>> + if (--counter > 0) {
>> + server->checkVideoUpdate();
>> + } else {
>> + counter = rfb::Server::videoPriority;
>> + server->checkUpdate();
>> + }
Oops, I see, there is a problem indeed. However, I will not be able to
fix it in the nearest days. Would it be ok to fix it in early February?
--
With Best Wishes,
Constantin

On Mon, 26 Jan 2009, Constantin Kaplinsky wrote:
Hi,
> Oops, I see, there is a problem indeed. However, I will not be able to
> fix it in the nearest days. Would it be ok to fix it in early February?
No problems at all; we have simply disabled this code block (except
server->checkUpdate, of course) in the version we ship.
Best regards,
---
Peter Åstrand ThinLinc Chief Developer
Cendio AB http://www.cendio.com
Wallenbergs gata 4
583 30 Linköping Phone: +46-13-21 46 00

The patch below, submitted as a part of revision 2584, causes a major bug:
Very often, updates are not correctly sent to the client. An easy way of
triggering this is to execute xterm within Xvnc and then run:
"usleep 300000; uname"
In many cases, the uname and/or the new prompt will not reach the client,
unless you move the mouse or cause any other update.
I'm not sure what's the proper way of fixing this though; I'm not familiar
with the "video" mechanisms.
Best regards,
Peter
> Restored the functionality of the VideoPriority parameter. This time, it
> should work correctly even over slow networks, when update requests go less
> frequently than polling cycles. This version does not give any special
> meaning to the value 0, it is equivalent to 1.
> --- trunk/common/rfb/VNCSConnectionST.cxx 2008-06-12 13:18:10 UTC (rev 2583)
> +++ trunk/common/rfb/VNCSConnectionST.cxx 2008-06-13 18:07:53 UTC (rev 2584)
> @@ -541,7 +541,13 @@
>
> updates.enable_copyrect(cp.useCopyRect);
>
> - server->checkUpdate();
> + static int counter = 1;
> + if (--counter > 0) {
> + server->checkVideoUpdate();
> + } else {
> + counter = rfb::Server::videoPriority;
> + server->checkUpdate();
> + }
>
> // Get the lists of updates. Prior to exporting the data to the `ui' object,
> // getUpdateInfo() will normalize the `updates' object such way that its
---
Peter Åstrand ThinLinc Chief Developer
Cendio AB http://www.cendio.com
Wallenbergs gata 4
583 30 Linköping Phone: +46-13-21 46 00

Community

Help

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

CountryState

JavaScript is required for this form.

I agree to receive quotes, newsletters and other information from sourceforge.net and its partners regarding IT services and products. I understand that I can withdraw my consent at any time. Please refer to our Privacy Policy or Contact Us for more details