Comments

Remove MediaRouterAction
The new CastToolbarButton in the toolbar's trusted area is now enabled by
default, so this CL removes the old Media Router toolbar action that was
replaced by it.
MediaRouterActionController is still used by the new icon, and will be
renamed in a separate patch.
Bug: 919185
Change-Id: I95842e657379f823bd483d0a3da00015f76d8255
Reviewed-on: https://chromium-review.googlesource.com/c/1395419
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634839}

Comments

Y and UV planes release mechanism fix
The Y and UV planes weren't getting released properly because the local
variables used in base::RetainBlock() are snapshots of their current
values and do not get updated by subsequent code. In this case,
y_surface and uv_surface would always be at their original value of
EGL_NO_SURFACE and eglReleaseTexImage/eglDestroySurface would never get
called. Using pointers to these values solves the issue, since the
pointers do not get modified by subsequent code and the values can be
checked properly by dereferencing the pointers.
Bug: chromium:932986chromium:929088
Change-Id: Id0b9fcc79af733b645eaf8fed12d905dd40e9fbc
Reviewed-on: https://chromium-review.googlesource.com/c/1483690
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634837}

Comments

Fix emoji drawing coordinate in vertical text
Due to issues we have with retrieving correct font metrics on Mac OS,
due to [1, 2] when computing the vertical origin for Emoji Color Emoji
we receive an incorrect vertical origin with a 0 y-value, which leads to
an emoji glyph being placed too high.
Fallback to retrieving the slightly inflated SkFont.getBounds when
SkPath + getBounds() returns an empty rectangle, as it does for Apple
Color Emoji.
Added emoji-vertical-origin-visual.html test as part of own tests, but
in the style of a WPT test. As far as I can tell, we cannot yet run
pixel tests as part of WPT but I do not see a way to verify our
rendering as a ref test.
[1] https://bugs.chromium.org/p/skia/issues/detail?id=8779
[2] https://bugs.chromium.org/p/skia/issues/detail?id=5328
Test: fast/text/emoji-vertical-origin-visual.html
Bug: 933264
Change-Id: I3487bf832b857764fb638a3f2df5803137d3fd66
Reviewed-on: https://chromium-review.googlesource.com/c/1480463
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634836}