Using the browse.dat file I will attach to this bug report, with the workgroup changed to the current one in smb.conf, 3.5.0rc2 returns a bad browselist to smbclient.
To reproduce, set up the browse.dat as explained, then do:
smbclient -L 127.0.0.1 -U% -p139
The returned list has missing elements.
There are two problems:
1). The server is off-by-one in the end of buffer space test.
2). The server returns 0 in the totaldata (smb_vwv1) and totalparams (smb_vwv0) fields in the second and subsequent SMBtrans replies.
This occurred in the recent SMBtrans rewrite and also affects 3.4.x. and 3.3.x.
Jeremy.

Created attachment 5309[details]
git-am patch. Applies to 3.5.0 and 3.4.6.
Missed this one - it's also needed. Fixes a valgrind error in libsmb/clirap.c when reading a fully returned browselist.
Jeremy.