On Tue, 20 Aug 2019, Mihailo Stojanovic wrote:
> Hello everyone,> > As suggested by Joseph here [1], this bumps the highest valid ABIVERSION> value to ABSOLUTE ABI, which was overlooked in [2].> > New testcase loads the symbol from the GOT with the "lb" instruction> so that the EI_ABIVERSION header field of the shared object is set> to ABSOLUTE (it doesn't actually check the value of the symbol), and> makes sure that the main executable is executed without "ABI version> invalid" error.
Could you give details of how this was tested - did you test for all three
ABIs? (That's information that generally belongs in the proposed commit
message.)
> +CFLAGS-tst-undefined-weak.c: -O0
That's not how you set CFLAGS for a target. So presumably you don't need
-O0 at all?
> +#ifdef _ABIO32
I think the convention is to do
#include <sgidefs.h>
#if _MIPS_SIM == _ABIO32
rather than #ifdef on _ABI* macros.