Comments

Fix some instances where vxlan fdb 'used' field is not updated after the entry
is used.
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
---
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

From: Sridhar Samudrala <sri@us.ibm.com>
Date: Thu, 16 May 2013 10:05:43 -0700
> Fix some instances where vxlan fdb 'used' field is not updated after the entry > is used.> > Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Please just put the ->used update into vxlan_find_mac().
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Thu, 2013-05-16 at 15:00 -0700, David Miller wrote:
> From: Sridhar Samudrala <sri@us.ibm.com>> Date: Thu, 16 May 2013 10:05:43 -0700> > > Fix some instances where vxlan fdb 'used' field is not updated after the entry > > is used.> > > > Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>> > Please just put the ->used update into vxlan_find_mac().
I thought of doing it that way, but i found that there is a call
to vxlan_find_mac() in vxlan_fdb_create() where the fdb entry
gets updated, but it not really used.
Also in other cases, the fdb entry may not be used even if
vxlan_find_mac() returns an entry because of other conditions.
I guess it depends on how we define the 'used' field.
Thanks
Sridhar
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

From: Sridhar Samudrala <sri@us.ibm.com>
Date: Thu, 16 May 2013 15:22:44 -0700
> On Thu, 2013-05-16 at 15:00 -0700, David Miller wrote:>> From: Sridhar Samudrala <sri@us.ibm.com>>> Date: Thu, 16 May 2013 10:05:43 -0700>> >> > Fix some instances where vxlan fdb 'used' field is not updated after the entry >> > is used.>> > >> > Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>>> >> Please just put the ->used update into vxlan_find_mac().> > I thought of doing it that way, but i found that there is a call> to vxlan_find_mac() in vxlan_fdb_create() where the fdb entry> gets updated, but it not really used.> > Also in other cases, the fdb entry may not be used even if> vxlan_find_mac() returns an entry because of other conditions.> > I guess it depends on how we define the 'used' field.
Make a new __vxlan_find_mac() or similar that doesn't update
->used, and invoke it from vxlan_fdb_create().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html