patch look good except that there are un-used imports in DFSClientAspects.

Some suggestions:
Currently, both ActionContainer.run(..) and Action.run(..) throw IOException. However, some implementation like VerificationAction may not throw IOException. My suggestion is to add a generic type to Action and ActionContainer as shown below.

Kan Zhang
added a comment - 24/Aug/09 22:31 attaching a new patch, which removes the unnecessary imports. Otherwise, it's identical to the first patch. Thanks for your suggestion. Will address it when I add more test cases.

I think this fix should be applied to branch-20 as well. It's a fairly minor change, and although we wouldn't be able to use the new FI tests, I think it's a pretty straightforward error in the existing logic (I independently found this bug in branch 20 last night, fixed in same way, then found this JIRA).

Todd Lipcon
added a comment - 02/Apr/10 17:34 I think this fix should be applied to branch-20 as well. It's a fairly minor change, and although we wouldn't be able to use the new FI tests, I think it's a pretty straightforward error in the existing logic (I independently found this bug in branch 20 last night, fixed in same way, then found this JIRA).