This comment has been minimized.

This comment has been minimized.

edited

If I have understood the api-compatibility-test correctly, it will fail at any change on the API, except when it is told to update the goldens. Following the instructions in its README, I ran the command locally and that should allow only the next api-compatibility-test to succeed with API changes, by creating a temporary text file in the same folder. My question is, is the CI aware of this?

Also note that I added is_closed to Queue_Base goldens myself. It was not updated automatically. Any thoughts?

This comment has been minimized.

I think The problem is still related to syncing.
I checked out your branch, and the test is failing the same way for me.
I think what you needed to do was, first fetch and merge all changes from tensorflow/tensorflow:master. You did this. But you needed to rerun api compatibility test and update goldens again. I can confirm that, when I run api compatibility test on your branch, I see this failure:

This comment has been minimized.

It is certainly possible.
Api compatibility test runs on Linux and python 2 only, as different versions of dependencies can trigger failures in the api object names. Is it possible you are on a macbook, or using python3?

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.