(In reply to Bobby Holley (:bholley) from comment #2)
> Can we inline this, or drop the inline in ProxyXrayTraits, so that the two
> are consistent?
This involved moving more code around, so I didn't do it.
> +template <typename Base, typename Traits>
> +XrayWrapper<Base, Traits>::XrayWrapper(unsigned flags)
> + : Base(flags | WrapperFactory::IS_XRAY_WRAPPER_FLAG)
> +{
> +}
> +
> +template <typename Base, typename Traits>
> +XrayWrapper<Base, Traits>::~XrayWrapper()
> +{
> +}
>
> Can we just inline these?
I ended up not doing this, because it means more includes in the header.
> The XrayProxy we use in PXOW should inherit
> js::CrossCompartmentSecurityWrapper. Looks like that was already broken
> though...
Followup it is.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1faf67b119e6