This comment has been minimized.

edited

Author
Member

I am thinking we could additionally remove any dependencies with the same version qualifier as the dependency in Kibana. Thoughts? I still need to see how much additional overhead we are looking at currently.

💚 Build Succeeded

This comment has been minimized.

@tylersmalley so just for our own clarification's sake in APM ... the imports that used 'x-pack/plugins/etc' paths only worked because x-pack was packaged as a node module? That little "trick" only worked for us in .ts(x) files so I always assumed it was TS compiler magic, even though I could never quite track down how it worked...

Sidenote: would love to consider some way of aliasing imports from Kibana's root to avoid relative imports that go 3+ levels, much easier to read:from 'kibana/x-pack/plugins/apm/typings/Transaction'
thanfrom '../../../../../../../../../../typings/Transaction'

💚 Build Succeeded

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.