Comments

From: Petko Manolov <petkan@nucleusys.com>
(For inclusion in 3.10, diff against latest net-next.)
Pegasus driver used single callback for sync and async control URBs.
Special flags were employed to distinguish between both, but due to flawed
logic (as Sarah Sharp spotted) it didn't always work. As a result of this
change [get|set]_registers() are now much simpler. Async write is also
leaner and does not use single, statically allocated memory for
usb_ctrlrequest, which is another potential race when asynchronously
submitting URBs.
The socket buffer pool for the receive path is now gone. It's existence
didn't make much difference (performance-wise) and the code is better off
without the spinlocks protecting it.
Largely duplicated code in routines reading and writing MII registers is
now packed in __mii_op().
Adding URL for the public pegasus git repository.
Signed-off-by: Petko Manolov <petkan@nucleusys.com>
---
Project website and public git repository moved to Github.
Some more formatting. Sigh, somebody ought to keep checkpatch.pl and
Lindent in sync. The former seems a bit off.
MAINTAINERS | 10 +-
drivers/net/usb/pegasus.c | 575 ++++++++++-------------------------
drivers/net/usb/pegasus.h | 10 +-
3 files changed, 169 insertions(+), 426 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

From: Petko Manolov <petkan@nucleusys.com>
Date: Fri, 19 Apr 2013 11:21:49 +0300 (EEST)
> From: Petko Manolov <petkan@nucleusys.com>> > (For inclusion in 3.10, diff against latest net-next.)> > Pegasus driver used single callback for sync and async control URBs. > Special flags were employed to distinguish between both, but due to flawed > logic (as Sarah Sharp spotted) it didn't always work. As a result of this > change [get|set]_registers() are now much simpler. Async write is also > leaner and does not use single, statically allocated memory for > usb_ctrlrequest, which is another potential race when asynchronously > submitting URBs.> > The socket buffer pool for the receive path is now gone. It's existence > didn't make much difference (performance-wise) and the code is better off > without the spinlocks protecting it.> > Largely duplicated code in routines reading and writing MII registers is > now packed in __mii_op().> > Adding URL for the public pegasus git repository.> > Signed-off-by: Petko Manolov <petkan@nucleusys.com>
Three completely unrelated changes combined into one patch, split this
up properly into three distinct changes, and resubmit them as a series
with a "[PATCH 0/N]" initial posting.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html