On Monday 15 March 2004 12:40 pm, Matt Zimmerman wrote:
> On Sat, Mar 13, 2004 at 08:43:58PM -0500, Andrew Mahone wrote:
> > I can't seem to reproduce the crash myself, but the ydestwidth and
> > uvdestwidth values are extremely suspicious - they are supposed to be
> > offsets from the buffer start to the first line to blend, and should
> > never, ever have negative values. I tried the i and o keys in both
> > livetv and a recorded program, with both blueosd and defaultosd themes,
> > but I'm not able to reproduce this crash.
>> A good way to ensure that is to declare them unsigned. This also has the
> pleasant side effect of producing warnings for expressions which become
> suspicious when dealing with unsigned values.
But, the values are supposed to be negative here (an OSD object moving off the
top/left of the screen) -- the old code handled this properly, just was an
oversight in the new blending code.
Isaac