https://bugzilla.redhat.com/show_bug.cgi?id=1244315
Florian "der-flo" Lehner <dev(a)der-flo.net&gt; changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dev(a)der-flo.net
--- Comment #1 from Florian "der-flo" Lehner <dev(a)der-flo.net&gt; ---
Hi Colin!
The %changelog is missing in the .spec.
Cheers,
Florian
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1244315
--- Comment #2 from Colin Walters <walters(a)redhat.com&gt; ---
Hi Florian,
I usually add the %changelog after it's added to Fedora. It's a source of
merge conflicts, so I delay as long as possible.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1244315
--- Comment #3 from Florian "der-flo" Lehner <dev(a)der-flo.net&gt; ---
Hi Colin,
providing something general like "initial packaging" should be fine for
%changelog and doesn't produce that much merge conflicts.
The versioning is confusing. In the spec-file it is 2015.1 and in the github
repository v2015.2.
I see and can reproduce how to get Source0. But if would be great, if you
could reference the source to a unique commit -
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL...
Cheers,
Florian
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1244315
Igor Gnatenko <i.gnatenko.brain(a)gmail.com&gt; changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |i.gnatenko.brain(a)gmail.com
Assignee|nobody(a)fedoraproject.org |i.gnatenko.brain(a)gmail.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1244315
--- Comment #4 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com&gt; ---
Spec URL;
https://raw.githubusercontent.com/cgwalters/rpmdistro-gitoverlay/master/r...
Where is SRPM Url? it's required for review.
Any way some notes.
-> BuildRequires: git
git-core please
-> Requires: yum-plugin-priorities
why yum? is it really required?
-> Source0: %{name}-%{version}.tar.xz
why not %{url}/archive/%{shortcommit}.tar.gz#/%{name}-%{shortcommit}.tar.gz?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1244315
--- Comment #5 from Colin Walters <walters(a)redhat.com&gt; ---
OK, I'll update soon to the new git guidelines.
(Ironically rpmdistro-gitoverlay is intended to fix all that...)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1244315
Paul W. Frields <pfrields(a)redhat.com&gt; changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|ignatenko(a)redhat.com |i.gnatenko.brain(a)gmail.com
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component