On Mon, Oct 16, 2017 at 11:10:06AM +0900, Anthony Kim wrote:> The HiDeep touchscreen device is a capacitive multi-touch controller> mainly for multi-touch supported devices use. It use I2C interface for> communication to IC and provide axis X, Y, Z locations for ten finger> touch through input event interface to userspace.> > It support the Crimson and the Lime two type IC. They are different> the number of channel supported and FW size. But the working protocol> is same.

I was looking at the patch and I have a few concerns. The device seemsto speak big-endian when being programmed, so I think it would makesense to have dwz_info and the firmware as bin-endian data as well, toavoid unnecessary conversions.

You need to tell touchscreen_parse_properties what axes to expect beforecalling it.

I tried addressing all the comments above (and some more), below is theincremental patch that should apply on top of the patch I am replyingto. I am also attaching full source of hideep.c in case you have troubleapplying this patch. Please give it a try and let me know if it stillworks. If there are any additional changes needed, please do it in topof this patch and when it is time to merge I'll squash it all together.

module_i2c_driver(hideep_driver);/* * Copyright (C) 2012-2017 Hideep, Inc. * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 * as published by the Free Software Foudation. */