id summary reporter owner description type status priority component severity resolution keywords cc release
9087 Fixes and enhancements for this plugin Dennis McRitchie astei "This plugin would not build under Trac 12.1 out of the box. It also did not correctly identify internal/external links on an https website. I made the following changes, and have included a patch for them against r8182 (latest version):
1) Fixed imports to allow the plugin to build, given the new directory name and structure.
2) The inserted code had some problems:
a) Since ${base_url} always evaluates to an http-prefixed URL, even when the website is using https, all links evaluated as external. Fixed by removing the http prefix before comparisons.
b) Fixed subdomain support to be consistent with Google's latest documentation.
c) Ignored source browser views of files with trackable extensions since this would double-count them.
3) Changed the installed plugin name to be the new name (GoogleAnalyticsIntegration) and upped the version to 0.3 .
4) Fixed the CSS file to properly display the admin page.
5) Changed the trac.ini section name from google.analytics to googleanalyticsintegration to avoid possible future conflicts with other google-related plugins.
6) Improved some of the descriptions and documentation; notably, changed UID to 'Web Property ID"" to be consistent with current Google usage. Also updated the code snippet in which to find it.
7) Moved AdSense policy violation disclaimer from admin page to LICENSE file, since this plugin does not directly involve AdSense.
8) Removed the financial contribution section from the admin page since this was an unfinished and unbuildable plugin.
Let me know if you have any questions, or want me to commit these changes.
Dennis
" defect new normal GoogleAnalyticsIntegration normal 0.12