On Sat, Jun 13, 2009 at 09:45:46PM +0100, Patrice Bensoussan wrote:
>> On 30 May 2009, at 00:14, Aurelien Jacobs wrote:
>>> On Fri, May 29, 2009 at 05:01:11PM -0400, Justin Ruggles wrote:
>>> Aurelien Jacobs wrote:
>>>> On Fri, May 29, 2009 at 12:19:48AM -0400, Justin Ruggles wrote:
>>>>> Ramiro Polla wrote:
>>>>>> Hi,
>>>>>>>>>>>> On Thu, May 28, 2009 at 10:11 PM, Justin Ruggles
>>>>>> <justin.ruggles at gmail.com> wrote:
>>>>>>> Ramiro Polla wrote:
>>>>>>>> On Thu, May 28, 2009 at 7:18 PM, Patrice Bensoussan
>>>>>>>> <patrice.bensoussan at free.fr> wrote:
>>>>>>>>> Hello,
>>>>>>>>>>>>>>>>>> It seems that the Artist and Track Number info is lost
>>>>>>>>> when converting from
>>>>>>>>> flac to mp3. Sample file uploaded in
>>>>>>>>> /MPlayer/incoming/MissingTagsWhenConvertingFLAC
>>>>>>>>>>>>>>>>>> ffmpeg -i TrackAndArtistMissingAferConversionToMP3.flac -
>>>>>>>>> map_meta_data 0:0
>>>>>>>>> file.mp3
>>>>>>>>>>>>>>>>>> (same issue when converting to m4a). I tried to have a
>>>>>>>>> quick look at the
>>>>>>>>> code, but couldn't find out what the problem is... if
>>>>>>>>> anyone can help and
>>>>>>>>> have some time...
>>>>>>>> I have this patch in my tree that for some reason hasn't
>>>>>>>> ever been
>>>>>>>> submitted. Could you test and see if it still works?
>>>>>>> Thanks. I didn't know that was required. Is that documented
>>>>>>> somewhere?
>>>>>> I have no idea. I just found them on a bunch of files I wanted
>>>>>> to convert...
>>>>>>>>>>>>> Also, wouldn't the ogg demuxer need to use the same mapping?
>>>>>>> If so, it
>>>>>>> could be put in oggparsevorbis.c/oggdec.h and used in both
>>>>>>> demuxers.
>>>>>> It looks like so, but I don't really want to work on this patch (I
>>>>>> guess that's why I hadn't submitted it), so whoever applies it can
>>>>>> decide where it fits best.
>>>>> Well, seeing as how I maintain the FLAC demuxer, I'll pick it
>>>>> up. Here
>>>>> is a modified version of Ramiro's patch.
>>>>>>>> metadata_conv should also be set for ogg and flac muxers.
>>>> Except that, patch is OK.
>>>>>> We don't have a vorbiscomment writer. Should the metadata_conv
>>> stuff be
>>> added to the muxers anyway?
>>>> Hum... Then it's not really useful in muxers right now. On the other
>> hand,
>> it won't do any harm, and it may incite someone (you ? ;-) to
>> implement
>> the vorbiscomment writer...
>> So, do whatever you prefer. It's not important right now...
>> Hi Aurel, have you had any chance to look at this? is there any more
> changes required before it gets committed?
I've already approved the patch. Justin can commit it whenever he want.
Aurel