FS#6010 - Rockbox crash due to context menu recursion

I can’t really say what happens, but i can show you how to get to it.

1. Go To “Browse Plugins” Menu2. Access the context menu of any plugin (Playlist, Playlist Catalogue, rename, delete, …) [edited for clarity –RaeNye]3. Press menu (or whatever button takes you to the main menu)4. Go back to step 1 and repeat.5. if you do it right, rockbox freezes and playback stops

Aha, got it on the H300 sim - thanks Rani.I’m not familiar with the menu code, but it looks like this recurses through the following routines:(…)(#33 0x0040559b in main_menu () at main_menu.c:433)#34 0×00408276 in onplay (file=0x369fb8c “/.rockbox/rocks/alpine_cdc.rock”,

#37 0×00405309 in plugin_browse () at main_menu.c:286#38 0×00405915 in menu_run (m=0) at menu.c:183#39 0x0040559b in main_menu () at main_menu.c:433This results in a stack overflow.

I would guess the problem lies in onplay.c, lines 994-995. Somehow this should be returning a special value to result rather than continuing inwards. Someone who knows this code will need to take over though!