Activity

As far as I can see, the question code is doing the right thing. question_make_export_url in questionlib.php is calling moodle_url::make_file_url, but then pluginfile.php fails to handle that URL correctly.

Tim Hunt
added a comment - 13/Sep/12 12:34 AM I don't believe the cause is the same as MDL-33116 .
As far as I can see, the question code is doing the right thing. question_make_export_url in questionlib.php is calling moodle_url::make_file_url, but then pluginfile.php fails to handle that URL correctly.
Therefore, re-assigning to the File API component.

Maybe the documentation is wrong, but the phpdocs for moodle_url::out() say
"If you use the returned URL in HTML code, you want the escaped ampersands. If you use the returned URL in HTTP headers, you want $escaped=false."

Tim Hunt
added a comment - 29/Nov/12 11:42 PM Brian, thank you for working that out! I guess the PHPdoc comment does not address the case of "if you are passing the URL to JavaScript ..." at all.
Are you familiar with the process to prepare a patch for integration, or shall I do it?
omer, Until Brian did the clever detective work to determine that is all that it would take, we did not know that. Comments like yours do not help get the bug fixed.