Status

()

For bugs in Firefox Desktop, the Mozilla Foundation's web browser. For Firefox user interface issues in menus, bookmarks, location bar, and preferences. Many Firefox bugs will either be filed here or in the Core product. Bugs for developer tools (F12) should be filed in the DevTools product. (more info)

Gavin -- that's a really good suggestion. We're planning to launch this for a
single day sometime in the next couple weeks. If we do consider implementing
this beyond our one-day test (e.g., something longer-term or permanent), a
mozilla.com hosted page will definitely be among our top requirements.

Created attachment 367966[details]
screenshot
I wasn't able to come up with decent text for a Yes / No / Cancel messagebox and instead went with a Yes / No messagebox with the text "Would you like to tell us why you are canceling this installation?"
This doesn't give the user the option of canceling the cancel like they normally can which I think is acceptable since the instruction to the user is more clear and concise this way.

Note: this will enable the survey when aborting the installer whenever the installer locale is en-US and there is a distribution.ini with a '[Global]' section with an 'about' section entry that has the string Funnelcake (case insensitive) within the full string.

Comment on attachment 368103[details][diff][review]
patch rev1
Noticed one little comment typeo - "; Cacnel = don't exit."
I was also going to suggest using icon question rather than icon exclamation for the question dialog, but I guess ms depreciated that, so I guess exclamation is the right thing to do.

(In reply to comment #19)
> (From update of attachment 368103[details][diff][review])
> Noticed one little comment typeo - "; Cacnel = don't exit."
Fixed
> I was also going to suggest using icon question rather than icon exclamation
> for the question dialog, but I guess ms depreciated that, so I guess
> exclamation is the right thing to do.
It is also the default for these messageboxes in nsis

Comment on attachment 368181[details][diff][review]
mozilla-1.9.1 patch - (checked in)
1.9.0.8 is done. Definitely wouldn't take a fix like this until after it's in 1.9.1, but even then it's hard to argue this is in scope with our branch security updates. Have the localization issues been cleared w/Axel or SethB?

(In reply to comment #27)
> (From update of attachment 368181[details][diff][review])
> 1.9.0.8 is done. Definitely wouldn't take a fix like this until after it's in
> 1.9.1, but even then it's hard to argue this is in scope with our branch
> security updates. Have the localization issues been cleared w/Axel or SethB?
The string is hardcoded and only used with en-US (comment #18 has the conditions) and Funnelcake is en-US only as well.

Comment on attachment 368181[details][diff][review]
mozilla-1.9.1 patch - (checked in)
I didn't think we wanted to do this permanently without a slightly better UI? Am I missing some context, here? Is Kampyle always going to be running?

(In reply to comment #29)
> (From update of attachment 368181[details][diff][review])
> I didn't think we wanted to do this permanently without a slightly better UI?
> Am I missing some context, here?
I personally don't think having three choices as follows is better for the funnelcake builds
a) fill out survey and exit
b) don't fill out survey and exit
c) don't exit
As it stands it is
a) fill out survey and exit
b) don't fill out survey and exit
Also, the process can be restarted.
I'll spend some more time investigating the options available via NSIS to provide non-standard Windows UI for this. I considered displaying the finish page with this info after displaying the standard "are you sure" dialog which would then allow the user to fill out the survey though that would add steps. Another option would be to create a non-standard messagebox which would likely require creating an NSIS plugin since the source code was lost for the only existing one I have found.
> Is Kampyle always going to be running?
It is automatically enabled under the following scenario
(In reply to comment #18)
> Note: this will enable the survey when aborting the installer whenever the
> installer locale is en-US and there is a distribution.ini with a '[Global]'
> section with an 'about' section entry that has the string Funnelcake (case
> insensitive) within the full string.
This allows the funnelcake repackaging to enable it without additional work performed by anyone.

Comment on attachment 368177[details][diff][review]
patch for CVS 1.9.0.x
Drivers, this has landed on both trunk and mozilla-1.9.1. I'd like to get it for 1.9.0.9 to lessen the amount of work needed for funnelcake releases.

Comment on attachment 368177[details][diff][review]
patch for CVS 1.9.0.x
> Function preWelcome
>+ StrCpy $PageName "Welcome"
Are these strings an internal state marker, or are they displayed? If displayed what keeps them from showing up in localized installers? Are the modified functions _only_ used by the survey process?

(In reply to comment #36)
> (From update of attachment 368177[details][diff][review])
> > Function preWelcome
> >+ StrCpy $PageName "Welcome"
>
> Are these strings an internal state marker, or are they displayed? If displayed
> what keeps them from showing up in localized installers? Are the modified
> functions _only_ used by the survey process?
They are state markers and are not displayed.
The CustomAbort function is used for all locales when aborting.
When aborting with a funnelcake build that is en-US per
(In reply to comment #18)
> Note: this will enable the survey when aborting the installer whenever the
> installer locale is en-US and there is a distribution.ini with a '[Global]'
> section with an 'about' section entry that has the string Funnelcake (case
> insensitive) within the full string.
the other new functions will be used.
When any of these conditions aren't met the CustomAbort function is still used and it duplicates the existing behavior where the MOZ_MUI_TEXT_ABORTWARNING string is used to give the user the option to not abort the installer.

The best that can be done without a funnelcake build is to:
1. extract an installer using 7-Zip http://www.7-zip.org/
2. inside the extracted directory create a new directory named distribution inside the nonlocalized directory.
3. create a new file named distribution.ini inside the new distribution directory.
4. add the following to the distribution.ini file
[Global]
about=Funnelcake Test
5. launch the setup.exe in the root of the directory of the originally extracted installer.