594252016-05-03 21:01:20 +0000Display error in help page if the help file cannot be opened2016-05-04 20:05:48 +0000111UnclassifiedJMeterMain2.13AllAllRESOLVEDFIXEDP2normal---1sebbissuesp.mouawad0oldest_to_newest1907100sebb2016-05-03 21:01:20 +0000At present if the source file for the help page cannot be opened, JMeter displays a blank page and a separate dialog box with the error. On my system the box does not get focus and may be hidden, so it's not clear what has happened.
Either the dialog should be forced to the front, or the error could be displayed on the page instead of the help text190727133824felix.schumacher2016-05-04 19:31:31 +0000Created attachment 33824
Display errror message in Help pane
As proposed by sebb, the error message is displayed inside the help pane and the modal dialog is removed.
Should this be added before 3.0?1907292sebb2016-05-04 19:44:15 +0000I would say yes.
I don't think there is any risk in doing so.1907303p.mouawad2016-05-04 19:47:19 +0000Ok for addition also1907334felix.schumacher2016-05-04 20:05:48 +0000Date: Wed May 4 20:03:03 2016
New Revision: 1742328
URL: http://svn.apache.org/viewvc?rev=1742328&view=rev
Log:
Display error about missing help page inside the help pane
Bugzilla Id: 59425
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Help.java
jmeter/trunk/xdocs/changes.xml338242016-05-04 19:31:31 +00002016-05-04 19:31:31 +0000Display errror message in Help pane0001-Display-error-message-in-Help-pane.patchtext/plain1593felix.schumacherRnJvbSAyOGFlZGZmOTQwODlhMDY0NWI3YTA4YjdkZTYyMWRlYjE2MjFjMTE0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWxpeCBTY2h1bWFjaGVyIDxmZWxpeC5zY2h1bWFjaGVyQGlu
dGVybmV0YWxsZWUuZGU+CkRhdGU6IFdlZCwgNCBNYXkgMjAxNiAyMToyOToxOCArMDIwMApTdWJq
ZWN0OiBbUEFUQ0hdIERpc3BsYXkgZXJyb3IgbWVzc2FnZSBpbiBIZWxwIHBhbmUuCgotLS0KIHNy
Yy9jb3JlL29yZy9hcGFjaGUvam1ldGVyL2d1aS9hY3Rpb24vSGVscC5qYXZhIHwgMTIgKysrKysr
KysrKystCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoK
ZGlmZiAtLWdpdCBhL3NyYy9jb3JlL29yZy9hcGFjaGUvam1ldGVyL2d1aS9hY3Rpb24vSGVscC5q
YXZhIGIvc3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL2FjdGlvbi9IZWxwLmphdmEKaW5k
ZXggYjRiYjNiYy4uNzA2YWU0YiAxMDA2NDQKLS0tIGEvc3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0
ZXIvZ3VpL2FjdGlvbi9IZWxwLmphdmEKKysrIGIvc3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIv
Z3VpL2FjdGlvbi9IZWxwLmphdmEKQEAgLTk5LDcgKzk5LDE3IEBAIHB1YmxpYyBjbGFzcyBIZWxw
IGltcGxlbWVudHMgQ29tbWFuZCB7CiAgICAgICAgICAgICBoZWxwRG9jLnNldFBhZ2UodXJsLnRv
U3RyaW5nKCkpOyAvLyBOLkIuIHRoaXMgb25seSByZWxvYWRzIGlmIG5lY2Vzc2FyeSAoaWdub3Jl
cyB0aGUgcmVmZXJlbmNlKQogICAgICAgICB9IGNhdGNoIChJT0V4Y2VwdGlvbiBpb2UpIHsKICAg
ICAgICAgICAgIGxvZy5lcnJvcihpb2UudG9TdHJpbmcoKSk7Ci0gICAgICAgICAgICBKTWV0ZXJV
dGlscy5yZXBvcnRFcnJvclRvVXNlcigiUHJvYmxlbSBsb2FkaW5nIGEgaGVscCBwYWdlIC0gc2Vl
IGxvZyBmb3IgZGV0YWlscyIpOworICAgICAgICAgICAgaGVscERvYy5zZXRUZXh0KCI8aHRtbD48
aGVhZD48dGl0bGU+UHJvYmxlbSBsb2FkaW5nIGhlbHAgcGFnZTwvdGl0bGU+IgorICAgICAgICAg
ICAgICAgICAgICArICI8c3R5bGU+PCEtLSIKKyAgICAgICAgICAgICAgICAgICAgKyAiLm5vdGUg
eyBiYWNrZ3JvdW5kLWNvbG9yOiAjZmZlZWVlOyBib3JkZXI6IDFweCBzb2xpZCBicm93bjsgfSIK
KyAgICAgICAgICAgICAgICAgICAgKyAiZGl2IHsgcGFkZGluZzogMTA7IG1hcmdpbjogMTA7IH0i
CisgICAgICAgICAgICAgICAgICAgICsgIi0tPjwvc3R5bGU+PC9oZWFkPiIKKyAgICAgICAgICAg
ICAgICAgICAgKyAiPGJvZHk+PGRpdiBjbGFzcz0nbm90ZSc+IgorICAgICAgICAgICAgICAgICAg
ICArICI8aDE+UHJvYmxlbSBsb2FkaW5nIGhlbHAgcGFnZTwvaDE+IgorICAgICAgICAgICAgICAg
ICAgICArICI8ZGl2PkNhbid0IGxvYWQgdXJsOiAmcXVvdDs8ZW0+IgorICAgICAgICAgICAgICAg
ICAgICArIHVybC50b1N0cmluZygpICsgIjwvZW0+JnF1b3Q7PC9kaXY+IgorICAgICAgICAgICAg
ICAgICAgICArICI8ZGl2PlNlZSBsb2cgZm9yIG1vcmUgaW5mbzwvZGl2PiIKKyAgICAgICAgICAg
ICAgICAgICAgKyAiPC9ib2R5PiIpOwogICAgICAgICB9CiAgICAgfQogCi0tIAoyLjcuNAoK