Re: UPDATE: xschem 2.8.1 -> 2.8.2

Hi!

I also noticed the move of the examples and pcb, The examples are
mainly for documentation
and aren't supposed to be used as starting point. Also the pcb has
same fate. pcb directory
isn't needed any more for tEDAx export. Those are provided as
reference and will be redone
or removed when library system is further developed. So they shouldn't
be cluttering system library.

The manpage is generated at the end of configure. Configure's --prefix
is expanded when xschem.1.in
is converted to xschem.1 manpage. See scconfig/hooks.c

ma 4. helmik. 2019 klo 21.43 Klemens Nanni ([hidden email]) kirjoitti:
>
> Your diff does not apply.
>
> Examples are now installed into the wrong location, can you fix that?
>
> xschem.1 now has hardcoded paths in it, they need the same replacing
> as before, so instead of removing the patch and SUBST_CMD, simply update
> the patch.

Re: UPDATE: xschem 2.8.1 -> 2.8.2

On Wed, Feb 06, 2019 at 09:00:41PM +0200, Hannu Vuolasaho wrote:
> I also noticed the move of the examples and pcb, The examples are
> mainly for documentation
> and aren't supposed to be used as starting point. Also the pcb has
> same fate. pcb directory
> isn't needed any more for tEDAx export. Those are provided as
> reference and will be redone
> or removed when library system is further developed. So they shouldn't
> be cluttering system library.
Nonetheless there is a clear seperation between documentation and
example (configuration). All ports install them into the appropiate
locations and I see no reason here to make an exception for xschem.

> The manpage is generated at the end of configure. Configure's --prefix
> is expanded when xschem.1.in
> is converted to xschem.1 manpage. See scconfig/hooks.c
>
> scconfig uses @/local/xschem/prefix@ for it's prefix configuration variable.
Oh, right; it already did that when I looked at your port before
importing it - forgot it by now, sorry.

Re: UPDATE: xschem 2.8.1 -> 2.8.2

to 7. helmik. 2019 klo 0.30 Klemens Nanni ([hidden email]) kirjoitti:
>> On Wed, Feb 06, 2019 at 09:00:41PM +0200, Hannu Vuolasaho wrote:
> > I also noticed the move of the examples and pcb,
> > So they shouldn't
> > be cluttering system library.
> Nonetheless there is a clear seperation between documentation and
> example (configuration). All ports install them into the appropiate
> locations and I see no reason here to make an exception for xschem.

You are quite correct. After re-reading porter's guide, I also think that
examples belong to examples directory.

Re: UPDATE: xschem 2.8.1 -> 2.8.2

On Fri, Feb 08, 2019 at 12:27:04AM +0200, Hannu Vuolasaho wrote:

> to 7. helmik. 2019 klo 0.30 Klemens Nanni ([hidden email]) kirjoitti:
> >> On Wed, Feb 06, 2019 at 09:00:41PM +0200, Hannu Vuolasaho wrote:
> > > I also noticed the move of the examples and pcb,
> > > So they shouldn't
> > > be cluttering system library.
> > Nonetheless there is a clear seperation between documentation and
> > example (configuration). All ports install them into the appropiate
> > locations and I see no reason here to make an exception for xschem.
>
> You are quite correct. After re-reading porter's guide, I also think that
> examples belong to examples directory.
>
> Below diff which patches them to examples.

Here's a diff that actually applies and simply passes EXAMPLESDIR
through FAKE_FLAGS instead of patching the Makefile.