Devtools: a11y fixes for Service Worker view

Comments

Devtools: a11y fixes for Service Worker view
Accessibility testing revealed the following issues within the tool:
1. missing name for focusable controls
2. some of the links and buttons are not keyboard accessible
This change adds:
1. aria-label to the input field
2. tab stop to those links and buttons mentioned above
3. better described placeholder message for the filter input and focus indicator
4. mark role as h1 and h2 for report tiltle and section header
5. test coverage
see the gif: https://imgur.com/a/ycK3n70
Change-Id: I83c61c5b8abe91179451f1e7a07bde550011b9c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559704
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#653080}

Remove CancelAll() function at menu_controller.h

Comments

Remove CancelAll() function at menu_controller.h
it was used for OneShotTimer.
but it can replace with base::BindOnce using Cancel().
and other places which is just call it also can replace
with Cancel().
Bug: 940736
Change-Id: I4c0bf87a347640048ef81c1386a13a5f0349caf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573315
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653081}

Don't replay window state change sent from Android

Comments

Don't replay window state change sent from Android
When Android sends a window state change to a shell surface whose
widget hasn't been created, the widget is created first and the
window state change is applied later, which ends up requesting
a window state change back to Android. This happens when a window
enters PIP via minimize and a new task is created in a minimized
stack.
state just after it entered PIP.
Bug: b/130125505
Test: Confirmed a PIP window of VLC didn't go back to minimized
Change-Id: I5159ceaa8cf81a7d6f2c042fd5bdfdd71ae07647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573433
Reviewed-by: Mitsuru Oshima (Slow 4/22-26) <oshima@chromium.org>
Commit-Queue: Kazuki Takise <takise@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653083}