[00:22:54] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446)
[00:22:55] (03PS19) 10Parent5446: Added Uri class and Uri Query classes. [core] - 10https://gerrit.wikimedia.org/r/22167
[00:22:56] (03CR) 10jenkins-bot: [V: 04-1] Added Uri class and Uri Query classes. [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446)
[00:23:30] (03PS9) 10Parent5446: Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418
[00:24:02] (03PS10) 10Parent5446: Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418
[00:24:31] (03CR) 10jenkins-bot: [V: 04-1] Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418 (owner: 10Parent5446)
[00:25:06] (03CR) 10jenkins-bot: [V: 04-1] Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418 (owner: 10Parent5446)
[00:28:07] (03PS20) 10Parent5446: Added Uri class and Uri Query classes. [core] - 10https://gerrit.wikimedia.org/r/22167
[00:29:09] (03CR) 10jenkins-bot: [V: 04-1] Added Uri class and Uri Query classes. [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446)
[00:32:17] (03CR) 10Parent5446: ">.10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446)
[00:34:21] (03PS21) 10Parent5446: Added Uri class and Uri Query classes. [core] - 10https://gerrit.wikimedia.org/r/22167
[00:35:38] (03PS1) 10Matmarex: mediawiki.action.edit.preview: Assorted fixes [core] - 10https://gerrit.wikimedia.org/r/76457
[00:37:39] (03PS11) 10Parent5446: Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418
[00:40:14] (03PS2) 10Matmarex: mediawiki.action.edit.preview: Assorted fixes [core] - 10https://gerrit.wikimedia.org/r/76457
[00:47:55] (03PS1) 10Parent5446: Changed logged out tokens to use session if already there [core] - 10https://gerrit.wikimedia.org/r/76458
[00:48:24] (03CR) 10Parent5446: "@Daniel - See the change dependent on this change for the implementation of tokens for anonymous users with sessions." [core] - 10https://gerrit.wikimedia.org/r/65418 (owner: 10Parent5446)
[00:50:55] legoktm: \o/
[00:51:07] :D
[00:55:17] (03PS3) 10Legoktm: Parse the input list using a parser function [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76333
[00:56:40] Elsie: I updated it a bit. We do lose some duplication checking though… ^
[00:56:48] Why's that?
[00:58:45] Hm. Well we never really had it for global deliveries to begin with. I'll need to add an extra function to do it locally though
[00:59:16] There were two de-duping mechanisms.
[00:59:21] Well, three.
[00:59:23] SELECT DISTINCT.
[00:59:28] A Python set().
[00:59:30] And the key check.
[01:00:02] er, which one was the key check again?
[01:00:31]
[01:00:39] (03PS1) 10Shirayuki: Replace "themselves" by "oneself" [core] - 10https://gerrit.wikimedia.org/r/76459
[01:00:42] Oh, right. Well we're not really supporting that....
[01:02:39] Right.
[01:02:45] I'm just saying that de-duping is important.
[01:03:41] Yeah, I'll work it back in
[01:11:04] (03PS1) 10TTO: Format protection_expiry timestamp in ISO format for API prop=flagged [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460
[01:47:14] Does "This, that and the other" use IRC?
[01:47:17] Elsie do you know?
[01:47:38] Krenair: I don't think so.
[01:47:41] (03PS2) 10Alex Monk: Format protection_expiry timestamp in ISO format for API prop=flagged [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO)
[01:47:42] I don't know for sure.
[01:50:49] (03PS4) 10Parent5446: Fix double-parsing of account creation messages. [core] - 10https://gerrit.wikimedia.org/r/47821
[01:52:26] (03PS5) 10Parent5446: Fix double-parsing of account creation messages. [core] - 10https://gerrit.wikimedia.org/r/47821
[02:23:41] Krenair: He's on rarely
[02:23:51] [07:23:44 PM] -NickServ- Last seen : Jul 28 10:11:41 2013 (16 hours, 12 minutes, 2 seconds ago)
[02:43:11] (03CR) 10KartikMistry: "URL seems 404. Can you add correct URL to download or appropriate note in case of it is not available?" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76349 (owner: 10Ebrahim)
[02:54:21] legoktm: Hi.
[02:55:09] grrrit-wm seems to be dead.
[02:55:20] (03CR) 10MZMcBride: "(12 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76333 (owner: 10Legoktm)
[02:55:20] Oh, there it goes.
[02:56:41] (03CR) 10MZMcBride: "Thank you!" [core] - 10https://gerrit.wikimedia.org/r/76222 (owner: 10Ori.livneh)
[02:57:02] Elsie: how slow was that?
[02:58:36] Two minutes.
[02:58:45] For the (12 comments) CR.
[02:58:56] The "thank you!" CR came through quickly.
[03:04:42] (03CR) 10KartikMistry: "LGTM!" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76236 (owner: 10Santhosh)
[03:06:57] YuviPanda: Does grrrit-wm have any call/response?
[03:06:59] Like...
[03:07:02] * Elsie hits grrrit-wm.
[03:07:05] nope
[03:07:07] i should add some
[03:07:09] at some point
[03:07:13] Just something silly, yeah.
[03:07:17] reasonably trivial
[03:07:21] you can add them too! :)
[03:07:21] A hug response or something.
[03:07:36] well, responding with "Working..." would be appropriate, I think :)
[03:07:42] Hah!
[03:08:16] :D
[03:08:25] Elsie: want to try adding that? :)
[03:08:33] Which repo is it again?
[03:08:48] I have a working Gerrit account now, allegedly.
[03:09:11] Elsie: labs/tools/grrrit
[03:09:21] Elsie: you can also send a pull request to it on github, if you want.
[03:10:30] (03CR) 10Parent5446: [C: 031] "Haven't tested, but looks good to me." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75106 (owner: 10Rjain)
[03:15:53] (03PS1) 10Mollywhite: Bug 50762: Add variables to show/hide items in the navbar. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/76463
[03:26:24] (03CR) 10Parent5446: "(1 comment)" [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/75645 (owner: 10Rjain)
[03:28:44] (03PS3) 10Santhosh: Add Nazli font for Persian Script [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76349 (owner: 10Ebrahim)
[03:31:19] (03CR) 10Santhosh: [C: 04-1] "compressed the font more using sfntly." [extensions/cldr] - 10https://gerrit.wikimedia.org/r/45499 (owner: 10Kaldari)
[03:36:43] (03CR) 10Santhosh: [C: 04-1] "compressed the font more using sfntly." [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/76349 (owner: 10Ebrahim)
[03:37:27] (03CR) 10Santhosh: "Sorry about previous comment, wrong browser tab :)" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/45499 (owner: 10Kaldari)
[03:41:40] (03PS7) 10Yuvipanda: Clean-up UploadWizardDetails [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/75595 (owner: 10Rillke)
[03:42:30] (03CR) 10Legoktm: "(7 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76333 (owner: 10Legoktm)
[03:43:03] Elsie: ^
[03:48:28] (03CR) 10MZMcBride: "(4 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/76333 (owner: 10Legoktm)
[03:57:20] [23:57] ... James_F|Away!~James@wikimedia/JamesF
[03:57:20] [23:57] ... ircname "James
[03:57:25] I wonder if that's my client or his.
[03:58:06] as James always says, "it's
[03:58:45] So apparently over 400 German Wikipedians voted to reverse VE's deployment.
[04:02:23] Aaron|home: Hey, small job queue question for you. Is there a way I can get a count of how many jobs that are of the "MassMessageJob" class are queued?
[04:02:59] hey ori-l. did you see hashar's messages about EventLogging?
[04:03:03] they... don't fully make sense to me :)
[04:03:10] no. where?
[04:03:19] interestingly, on labs-l
[04:03:33] legoktm: no way from API, it's possible with CLI access (showJobs.php --group)
[04:03:38] oh
[04:03:39] actually no
[04:03:42] oh, i'm not on that list. i'll look.
[04:04:06] Aaron|home: This is for a special page so that will work. I'll take a look at how that script works, thanks
[04:04:08] ori-l: err, sorry
[04:04:11] ori-l: that was wikitech
[04:04:17] ori-l: 'bot dispatcher' thread
[04:04:32] ori-l: http://lists.wikimedia.org/pipermail/wikitech-l/2013-July/070864.html
[04:04:44] he also mentioned using EventLogging to... relay Gerrit messages to me before :)
[04:06:11] what's confusing about that?
[04:06:37] ori-l: using EventLogging to relay RecentChanges messages?
[04:06:37] to labs?
[04:07:12] I guess we can use the same concepts (0mq, etc), but I guess EL by itself can't do it?
[04:07:14] I think hashar is being a bit generous with praise for EventLogging; the aspects of it that are desirable and applicable to this problem are mostly attributable to ZeroMQ
[04:07:35] well, it can
[04:07:50] yeah, but then it will no longer be EventLogging, but something bigger
[04:07:54] you have:
[04:08:31] a) a wrapper around wfDebugLog that encodes objects to JSON and validates them for conformity with a spec (the latter part is only useful if we expect to need some flexibility / adaptability)
[04:09:24] so an interface for emitting JSON via UDP from MediaWiki
[04:09:45] "massmessageJob: 2 queued; 0 claimed (0 active, 0 abandoned)" :D
[04:09:46] EL also uses UDP? I thought it was 0mq from the apaches...
[04:09:48] Elsie: ^
[04:10:04] and then a set of puppet classes that are well-documented and easy to deploy for provisioning a UDP listener that transforms the stream to a ZeroMQ publisher
[04:10:21] legoktm: :D
[04:10:40] and then a puppetized plug-in architecture for adding subscribers to that stream
[04:10:43] Okay, let's say I want to upload a new patchset for a particular Gerrit changeset.
[04:10:46] How do I do that?
[04:11:11] Elsie: First get it via git review -d ####
[04:11:22] Then you make your changes, git commit --amend
[04:11:24] git review -R
[04:11:28] Do I need to clone the repo first?
[04:11:36] Yes
[04:11:41] Okay, let me do that first.
[04:11:48] ori-l: hmm, true. It'll be easier to extract that out than do something from scratch
[04:11:53] I think the primary benefit of using EventLogging stuff is not in any sort of wowee-zoee feature but rather the fact that I bashed my head against all sorts of MediaWiki / Wikimedia production environment idiosyncracies and found workable solutions for them
[04:12:01] hehe :)
[04:12:10] true!
[04:12:10] legoktm: I'll likely need a bit of hand-holding, if you're available for the next few minutes. :-)
[04:12:11] or had people smarter than me find workable solutions for them :)
[04:12:11] sure :P
[04:12:28] ori-l: I think this was confusing to me because... I think petr had put it on labs-l, since this is a toollabs specific thing that is going to consume the IRC feeds and rebroadcast them as redis after some filtering.
[04:13:04] it now makes sense to me, since it was on wikitech-l. Initially I Thought it was labs-l
[04:13:07] so nevermind.
[04:13:30] mzmcbride@gonzo:grrrit$ git clone gerrit:operations/mediawiki-config.git
[04:13:33] ori-l: btw, I don't think that IRC RC Feeds thing will be replaced anytime soon, though :( Nobody cares, mostly.
[04:13:33] I'm running that now.
[04:13:40] I have gerrit: as an SSH alias or something.
[04:13:54] Yeah, ori-l's tip about that was awesome :D
[04:14:11] I did it in .ssh/config, not .gitconfig.
[04:14:12] I think.
[04:14:16] I just set a port and some other shit.
[04:14:20] Oh, neat.
[04:14:25] I read it in the docs.
[04:14:30] I didn't pounce on petr with EventLogging stuff for exactly that reason; it's a project that needs someone who is passionate about it so if he wants to reinvent the wheel and experiment with some interesting pieces of software in the process he should go ahead.
[04:14:33] Okay, cloned.
[04:14:43] Now I want to...
[04:14:59] wowee-zowee
[04:15:06] I think the W is required.
[04:15:10] there's nothing more fatal to a young developer's enthusiasm than to be told that the project they want to embark on is mostly done and "only" requires some work adapting old code.
[04:16:09] ori-l: :)
[04:16:23] legoktm: So I tried "git review -d 76199".
[04:16:25] It blew up.
[04:16:44] Do I need to provide a hash instead?
[04:16:44] Elsie: What did it say?
[04:16:49] No, that should work.
[04:17:05] Sec, I'll paste.
[04:17:11] It went a bit ape-shit.
[04:17:39] https://dpaste.de/GsXRd/raw/
[04:17:56] Oh
[04:18:01] YuviPanda: the recently-rewritten eventlogging module in the puppet repo is fairly well documented and does a reasonably good job at explaining how the different components could be composed to facilitate different data flows, if you (or petr) are curious. I'd be happy to help if so, but I'll also endorse some amount of wheel-reinvention..
[04:18:01] Elsie: Try running git review -s first
[04:18:11] That command should be a one time run per repo.
[04:18:19] Similar error.
[04:18:23] bbl
[04:18:48] Hmmm
[04:19:13] https://dpaste.de/qUwxr/raw/
[04:19:27] * Elsie googles.
[04:19:43] Elsie: What does "git remote show gerrit" result in?
[04:20:15] It should error
[04:20:20] $ git remote show gerrit
[04:20:20] fatal: 'gerrit' does not appear to be a git repository
[04:20:20] fatal: Could not read from remote repository.
[04:21:03] Try...
[04:21:23] git remote add gerrit ssh://mzmcbride@gerrit.wikimedia.org:29418/operations/mediawiki-config.git
[04:22:11] Okay, new error.
[04:22:40] pastebin please
[04:22:41] https://dpaste.de/KAyut/raw/
[04:22:53] I think it's using the wrong private key.
[04:23:08] Well. There's your answer :P
[04:23:08] How do I specify a key?
[04:23:25] I'm not sure, that's a git thing
[04:23:39] http://stackoverflow.com/questions/4565700/specify-private-ssh-key-to-use-when-executing-shell-command-with-or-without-ruby
[04:24:36] ori-l: :D ty, will do at some point
[04:25:27] legoktm: Hmmm, not really helpful.
[04:25:45] Yeah, not really.
[04:26:41] Never mind, got it.
[04:26:47] I had to adjust my .ssh/config.
[04:27:10] I had...
[04:27:12] Host gerrit
[04:27:15] I needed...
[04:27:16] Host gerrit gerrit.wikimedia.org
[04:27:28] Then I have Hostname gerrit.wikimedia.org \n Port ...
[04:27:30] Okay.
[04:27:52] $ git review -d 76199
[04:27:52] Downloading refs/changes/99/76199/1 from gerrit
[04:27:52] Switched to branch "review/jforrester/bug/49998"
[04:27:55] :D
[04:28:47] So all I need to now is update the file, git commit --amend, and then git review something?
[04:29:18] yup! git review -R
[04:29:25] Let's see.
[04:29:33] Is -R short for --no-rebase ?
[04:30:08] Not sure. Lemme check
[04:30:23] Does git review have docs?
[04:30:40] `man git` is useless for this third-party shit.
[04:30:42] > The -R is important here. It tells git-review to not rebase your change against master, which clutters diffs between patch set 1 and 2.
[04:31:08] https://www.mediawiki.org/wiki/Git/Tutorial and the See also have links to docs
[04:31:12] has*
[04:31:12] So... yes.
[04:31:25] Yeah
[04:36:06] I think I need --all.
[04:36:55] Okay, fingers crossed.
[04:37:09] And it failed horribly.
[04:37:45] Heh.
[04:37:58] E-mail address inconsistency.
[04:38:12] I'm wondering what e-mail address I actually want to use.
[04:38:16] Does it matter?
[04:38:31] If you use the same email as you have in github its easier to link those commits
[04:38:39] No outing.
[04:38:48] Also that email will be saved FOREVER. So maybe.
[04:38:53] FOREVER.
[04:38:57] I use g@ for GitHub.
[04:39:07] g for git, g for gerrit!
[04:39:10] Though w@ for Wikipedia.
[04:39:20] So much internal conflict.
[04:39:26] m for MediaWiki.
[04:39:30] Anyway, whatever. Life is short.
[04:39:41] It's done.
[04:39:53] (PS2) MZMcBride: Enable anonymous use of VisualEditor on es/fr/he/it/pl/ru/sv [operations/mediawiki-config] - https://gerrit.wikimedia.org/r/76199 (owner: Jforrester)
[04:40:54] All right.
[04:42:15] Congrats :P
[04:42:48] Okay, so if I want to submit a new changeset.
[04:43:00] Do I need to un--d myself?
[04:43:14] I'm currently on branch review/jforrester/bug/49998.
[04:43:22] Should I switch back to the master branch?
[04:43:27] Or should I just stay in this branch?
[04:43:41] Is this a brand new change?
[04:43:51] Hmmmm.
[04:44:15] Yes, I guess so.
[04:44:18] I'm reverting https://gerrit.wikimedia.org/r/#/c/75543/4/wmf-config/InitialiseSettings.php,unified
[04:44:24] Partially.
[04:45:00] Well there is a git revert command thing. But that is for full commits, not really partial ones.
[04:45:06] Okay.
[04:45:09] git checkout master
[04:45:10] How do you name branches?
[04:45:12] I did that.
[04:45:14] Then I ran git pull.
[04:45:17] git checkout -b topicname
[04:45:18] Now I'm about to name the branch.
[04:45:26] I mean how do _you_ name branches?
[04:45:29] checkout switches branches, -b is to create a new branch
[04:45:36]