Comments

Sparse warned about several functions that were unnecessarily global.
After making them static, discovered that several functions were actually never used.
Compile tested only.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Fri, 2013-02-22 at 10:01 -0800, Stephen Hemminger wrote:
> Sparse warned about several functions that were unnecessarily global.> After making them static, discovered that several functions were actually never used.> > Compile tested only.> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>>
Hi Stephen,
Thanks for this patch. The "dead code" part is actually a missing call
in case of PHY FW upgrade for the 84833 PHY - without it, a server
reboot is required for the new PHY FW to take affect - but this reboot
saving enhancement should wait until net-next is open, so I'm acking
this patch and we will add the code back with the proper call once the
net-next is open again.
Acked-by: Eilon Greenstein <eilong@broadcomo.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Sun, 24 Feb 2013 22:25:20 +0200
> On Fri, 2013-02-22 at 10:01 -0800, Stephen Hemminger wrote:>> Sparse warned about several functions that were unnecessarily global.>> After making them static, discovered that several functions were actually never used.>> >> Compile tested only.>> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>>> > > Hi Stephen,> > Thanks for this patch. The "dead code" part is actually a missing call> in case of PHY FW upgrade for the 84833 PHY - without it, a server> reboot is required for the new PHY FW to take affect - but this reboot> saving enhancement should wait until net-next is open, so I'm acking> this patch and we will add the code back with the proper call once the> net-next is open again.> > Acked-by: Eilon Greenstein <eilong@broadcomo.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html