In Options > Main:
The "Use Bookmark" button under Startup leaves some confusion as to which bookmark it uses. Putting an Ellipsis (i.e., three dots) in front of it will let the user know that clicking it actually opens a dialog box where you can select a bookmark of your choice for the Home Page.

Thanks Javi!
* Can you make a single patch against mozilla-central that makes the change with the ellipsis character?
* We need to update the entity name, since nearly every localization needs to also be updated to add the ellipsis. Any suggestions? chooseBookmark.label, maybe?
* Re Firefox 2: There are no more changes on that branch.

(In reply to comment #5)
> Thanks Javi!
>
> * Can you make a single patch against mozilla-central that makes the change
> with the ellipsis character?
Sorry for the bugmail. First patch used the 3 dots. Then I realized that … should be used, but in my cloned repository I was testing the Mercurial Queues, so the following patch wasn't good as it doesn't contains the patch to the code in the mozilla-central repository. (note to myself: don't use mq in local repository).
Yeah, I am going to create a new one with the change of the ellipsis using the code from the repository.
>
> * We need to update the entity name, since nearly every localization needs
> to also be updated to add the ellipsis. Any suggestions?
> chooseBookmark.label, maybe?
This entity name is good to me. I chose this bug because the change needed was obvious. However, I am beggining to develop in this project, so I am still learning how it works.
>
> * Re Firefox 2: There are no more changes on that branch.
Oks.

(In reply to Dietrich Ayala (:dietrich) from comment #10)
> Comment on attachment 551002[details][diff][review]
> Patch for bug 378577 (ellipsis and id name change)
>
> Review of attachment 551002[details][diff][review]:
> -----------------------------------------------------------------
>
> don't change the access key, since it's value didn't change. i think that'd
> just confuse localizers. however, everything else looks fine. with that
> change, this patch should be good to go!
I didn't change the access key but its name. Following the link cited in Comment 6, I updated every place where the new entity name appears. Maybe I am wrong, but, although the value doesn't change ("B"), not changing this entity name from useBookmark.accesskey to chooseBookmark.accesskey is not coherent.

Comment on attachment 558780[details][diff][review]
Patch for bug 378577 (ellipsis and id name change) v1.1
Review of attachment 558780[details][diff][review]:
-----------------------------------------------------------------
r=me. regarding the incoherency in the naming scheme: yeah, i agree it's not ideal. i'm weighing coherency of two strings that only us few developers will ever look at, vs the hundreds (thousands?) of people who are doing translations across 90+ locales.
thanks for the patch, and your patience to make this change :)

(In reply to Dietrich Ayala (:dietrich) from comment #10)
> don't change the access key, since it's value didn't change. i think that'd
> just confuse localizers.
Actually, I think the opposite is true - there are tools that associate labels and accesskeys based on the string names (and common suffixes like ".label" and ".accesskey"), so keeping the two in sync would be best. Localizers are used to dealing with accesskey/label churn.

Comment on attachment 551002[details][diff][review]
Patch for bug 378577 (ellipsis and id name change)
Please omit the ID change - addons may have come to rely on it, and there's no reason it needs to match the entity name used for the label/accesskey.
r=me with that change omitted.

(In reply to Gavin Sharp from comment #17)
>
> Please omit the ID change - addons may have come to rely on it, and there's
> no reason it needs to match the entity name used for the label/accesskey.
So, is it needed a new patch (which will made last reviewed one obsolete) that adds the ellipsis to the string _only_? I should not take into count the guidelines that instructed the coder to change entity name, then. Just to be sure of this before posting a new one.

(In reply to Javi Rueda from comment #18)
> (In reply to Gavin Sharp from comment #17)
> >
> > Please omit the ID change - addons may have come to rely on it, and there's
> > no reason it needs to match the entity name used for the label/accesskey.
>
> So, is it needed a new patch (which will made last reviewed one obsolete)
> that adds the ellipsis to the string _only_? I should not take into count
> the guidelines that instructed the coder to change entity name, then. Just
> to be sure of this before posting a new one.
Sorry. I am auto-responding to myself. I should keep the entity changes from last patch and omit changes in the XUL file.

Created attachment 559313[details][diff][review]
Patch for bug 378577 1.2.1
This patch changes the entity names, keeping in sync both string and access-key and modifies main.xul file as it should use new entity name. Also adds an unicode ellipsis char to the button text.
As my comment 19 wasn't good enough in describing the changes, I prefer to ask again for a review to Gavin. Sorry about that, because you give already a + to the old patch.