On Wed, 2005-02-02 at 16:09, Mark Phippard wrote:
> "Brian W. Fitzpatrick" <fitz@collab.net> wrote on 02/02/2005 05:05:53 PM:
>
> > On Wed, 2005-02-02 at 16:00, Mark Phippard wrote:
> > > "Brian W. Fitzpatrick" <fitz@collab.net> wrote on 02/02/2005 04:53:37
> PM:
> > >
> > > [snip]
> > >
> > > > Propset:
> > > > - Setting the svn:needs-lock property sets the file to read-only
> > > > (It also canonicalizes the value to '*')
> > >
> > > Before setting the file to read-only, shouldn't it check to see if it
> is
> > > locally modified?
> >
> > Hmm. I'm not sure about that--if the prop is set, and the user has
> > local mods, isn't it safe to assume that the user is doing it
> > intentionally?
>
> Sure, but if I am editing the file, as indicated by the local mods,
> doesn't it stand to reason that I would not want the file to be made
> read-only until I commit? In your scenario, are you assuming that after
> running svn propset, I would have to run svn lock to make the file
> read-write before I commit?

Well, you *did* just set a property named "needs-lock" on the file. I
would assume that that means that the file needs to be locked before
committing, wouldn't you? :-)

Kidding aside, I think that flipping the file to read-only right away
really is the right thing to do here.