Johnstone played mainly for Rangers during his career. He also had a spell at Chelsea and a brief stint in management with Partick Thistle. He mainly played as a striker but could also perform in central defence, and in midfield. Uniquely, he was selected to play in defence, midfield, and attack for Scotland.