Jason Rust wrote:
> // coments are not technically allowed (just accomodated in gcc).
Correct. We try to stick with C89 in the project, but there are a few
extensions from C99 that are so widely available even in pre-99 tools that
after some debate and a study of the actually used compilation environments,
we allow them. The two that come to mind are C++ style single line comments
and snprintf.
> Bad vim settings :) The attached file also fixes that issue.
Groovy. I'll review and commit soon.
Thanx.
RJL
--
Support GPSBabel by helping to improve it or fund those that that have
done so. Visit:
http://sourceforge.net/donate/index.php?group_id=58972

On Thursday 10 March 2005 04:35 pm, Robert Lipe wrote:
> Jason Rust wrote:
> > Ok, I've managed to wade through my first bit of C since high school!
>
> It looks like you did fine. :-)
Great. I did find after consulting with one of my "C" friends that // coments
are not technically allowed (just accomodated in gcc). So, I've attached a
new version of lowranceusr.c with /* */ comments.
> I'll tweak the indenting (you used 4 spaces sometimes and tabs others) and
> see if I can beef up the test case and commit it in the next few days.
Bad vim settings :) The attached file also fixes that issue.
Cheers,
-Jason

Jason Rust wrote:
> Ok, I've managed to wade through my first bit of C since high school!
It looks like you did fine. :-)
(See, there really isn't rocket science to most of these formats once
you get a description of the format.)
> Let me know if there's anything else I need to do to get it committed to the
> code base.
From a quick review, it looks like you nailed it on the first shot.
I'll tweak the indenting (you used 4 spaces sometimes and tabs others) and
see if I can beef up the test case and commit it in the next few days.
Thanx.
--
Support GPSBabel by helping to improve it or fund those that that have
done so. Visit:
http://sourceforge.net/donate/index.php?group_id=58972

I'm (finally) back from my trip and climbing from an avalance of email.
Ron Parker wrote:
> This means that I could probably put back the README entry and the help
> output for the google input type, but I'm going to hold off on that to
> see what the rest of you have to say about it.
I don't think I have any problem with that plan.
RJL

GPS Dr wrote:
>
> Ok, I'm new at developing with Visual Studio, but was still able to get
> through
> adding the new "existing" source files to the project. But am hitting the
> brick
> wall when it comes to <usb.h>.
>
> Where Can I find this beast?
I think you've crossed the streams. There are two USB OS "layers" used
in GPSBabel: gpsusbin.c for windows and gpslibusb.c for pretty much
everything else. You don't say where you're finding an include of <usb.h>
but I have a feeling it's in a file you shouldn't even be compiling
in VS.
RJL