This component tracks
* Modifying or removing existing builds, tests and other jobs
* Adding support for new types of jobs, builds or tests (e.g. opt, pgo, debug, ASAN or code coverage builds; b2g device builds, new test suites; special builds like spidermonkey or valgrind)
* Scheduler changes: what jobs get run and when

+++ This bug was initially created as a clone of Bug #996388 +++
More Android 4.0 Debug tests can now be run on trunk trees:
- crashtests
- all plain reftests, R1 ... R8
- all robocop, rc1 ... rc5
(mochitest-gl, xpcshell and cppunit tests are still not green / not ready for trunk)

Created attachment 8458048[details][diff][review]bug1030753.patch
We don't need to limit by single test suites anymore so we can get rid of a lot of code. Limiting to 31 doesn't apply to branches that Android 4.0 tests run on anymore so we can remove the loop and make the tests specified the default, and then enable all for testing on cedar.

gbrown: I didn't have time to work on this patch for a few weeks because I was working on the AWS for 2.3 bug. In any case, the way I wrote this patch this morning is that I enabled the new test suites for all branches since this the old debug loop refers to 31 and all branches that run Android 4.0 tests are now 31 or higher. But should the new tests only be enabled on trunk? Thought I would ask since this bug is three weeks old.

Hey Kim,
I'm really sorry, I haven't managed to do this review today. I can try to look at it on Monday, or if it is urgent, I won't be offended if you throw it to Callek.
Thanks for your patience!
Pete

Comment on attachment 8458253[details][diff][review]bug1030753-2.patch
Review of attachment 8458253[details][diff][review]:
-----------------------------------------------------------------
Hi Kim,
I exploded the config before and after applying your patch, and the following questions are based on this diff of results of before vs after.
1) I notice we have no changes for date, elm, fig, holly - but this looks correct to me - from the rest of the config they do not look like the other trunk branches, so I guess they are not trunk branches?
2) The following trees appear to have no changes:
a) mozilla-aurora
b) mozilla-release
c) mozilla-central
d) mozilla-beta
e) cedar
Should these also now include crashtest and plain-reftest-{1..8} for platforms : android : panda_android : debug_unittest_suites?
3) mozilla-b2g28_v1_3 : platforms : android : panda_android : debug_unittest_suites appears to have the following now removed after this patch:
a) robocop-{1..5}
b) crashtest
c) mochitest-gl
d) xpcshell
e) cppunit
4) mozilla-b2g30_v1_4 : platforms : android : panda_android : debug_unittest_suites appears to have the following now removed after this patch:
a) robocop-{1..5}
b) crashtest
c) mochitest-gl
d) plain-reftest-{1..8}
e) xpcshell
f) cppunit
I'm happy with the changes for the other trees (ash, b2g-inbound, cypress, fx-team, graphics, gum, jamun, larch, maple, mozilla-inbound, oak, try) that now include plain-reftest-{1..8} and crashtest under platforms : android : panda_android : debug_unittest_suites.
I'll leave at r? until you've had a chance to answer, as I'm not quite sure if they are expected or not.
Thanks!
Pete
::: mozilla-tests/mobile_config.py
@@ +746,5 @@
> if suite[0].startswith('robocop'):
> continue
> ANDROID_PLAIN_UNITTEST_DICT['opt_unittest_suites'].append(suite)
>
> +# bug 982799 limit the debug tests run on trunk branches
This comment appears to be about a different (closed) bug - did you mean to include it in this patch?

Hi Kim,
Just to be explicit; 3) and 4) above were not written as a question, but I should have written them as questions. In other words, were you expecting these changes to mozilla-b2g28_v1_3 : platforms : android : panda_android : debug_unittest_suites and mozilla-b2g30_v1_4 : platforms : android : panda_android : debug_unittest_suites ? I wondered if this was pollution from bug 982799 or was intended for this patch.
Thanks,
Pete

1) Right they are project branches
2) Correct, riding the trains means that the tests will be first be enabled on mozilla-inbound and then the tests will be enabled on aurora, beta and release branches as the new version of gecko is merged into these branches.
3) and 4) There aren't any Android 4.0 Panda tests ever invoked on mozilla-b2g28_v1_3 or mozilla-b2g30_v1_4 because the build they run against isn't created on these branches. These builders should actually be removed since they aren't used, I'll open a separate bug for this.
The comment refers to the old bug where I initially enabled debug tests, this bug just enables more tests.

(In reply to Kim Moir [:kmoir] from comment #14)
> 2) Correct, riding the trains means that the tests will be first be enabled
> on mozilla-inbound and then the tests will be enabled on aurora, beta and
> release branches as the new version of gecko is merged into these branches.
But what about:
>> 2) The following trees appear to have no changes:
>> c) mozilla-central
That seems odd.

1) gbrown is testing all changes on cedar, thus all tests are enabled on this branch
2) Yes, this looks good.
3) I reran test-masters.sh on my master (after fixing some merge conflicts) and it ran green for me