Perhaps we disagree on the value of consistency.I believe it's a small but measurable effect and itcan reduce overall ongoing defect rates.

Is it DoublePlus_important_? No, definitely not.

To me using pr_<level> is a bit like using constor marking sections devinitconst.

It hardly matters, but it's good form and it canfree up some working memory in ram limited systems.

> but if there is some > functionality that would be possible with pr_info(...) that would not be > possible with printk(KERN_INFO, ...), there may be more reason to change.

Right now, it's just macros over printk so it's prettytrivial. I do intend to convert pr_<level> macros tofunctions eventually to reduce code size ~.5% overall.That reduction does depend on quantity of CONFIG_<FOO>options enabled of course. Enable everything, I thinkit's ~.01%. I haven't done it in quite awhile thoughso that's a guess.

It matters a tiny bit more for flash or ram limitedsystems.

Some driver optimizations like the rtlwifi reductionin -next commit 481b9606ec might have more of animpact though for those systems.