Issues

We do not recommend that you setup new ChiliProject instances and
we urge all existing users to migrate their data to a maintained
system, e.g. Redmine. We will
provide a migration script later. In the meantime, you can use the
instructions by
Christian Daehn.

History

This is definitely one of those things that is subjective to pull in or not. I am always against the "fixing whitespace at end of line" commits since it screws up git blame (unless of course you use -w flag. But when I do a fresh clone of a repo, I expect to be at a clean state.

I don't know. This will make merging changes from Redmine difficult if not impossible for some files (they use mixed line endings).

This is a bad excuse for allowing bad style. In our code style guide, UNIX line endings are mandatory. I'd rather try to contribute the patch back to Redmine. My even Ack pukes on one file somewhere on an UTF-8 error (where I don't know really where), so we should really try to improve ChiliProject's code style.

What if we fix it on unstable and leave master as it is for now? Master has a higher risk of merge errors for me.

I'd say we can pull that for 2.0.0, I'd volunteer to take care of it if everyone agrees on that target.

On a related topic: have we agreed on a style best practice? For example: should empty lines be completely empty or indented to the same level as the surrounding code? Hashes currently look { :like => this } or {:like => that}, sometimes they're {:even => askew }, what's best practice here? And so on.

I added a rake task (code:fix_line_endings) that will go through all of the code and convert them to UNIX line endings using the utility "fromdos" (05a4c4616f). Then I ran the conversion on our code (a85b6780d2) and merged the results into unstable.