Having the totara elementlibrary installed helps as it has a page which excercises the tab render in a variety of ways.
If not then visit anything with tabs, Wiki, Lesson, Quiz editing, Glossary.
Check
a) the HTML produced is in line with that documented by Bootstrap:
http://twitter.github.io/bootstrap/components.html#navs
b) the visual appearance is consistent with above, and doesn't clash with surroundings in Moodle Bootstrapbase theme
c) tabs with a second level should render as one row above the other
d) the tabs should collapse into what Bootstrap calls stackable tabs at screen widths less than 480px

David Scotson
added a comment - 02/May/13 3:04 PM I copied in the docs from the parent class.
I'm happy for this to go to integration if you're okay with it. I don't have the button to do it myself.
cheers,
dave

Damyon Wiese
added a comment - 08/May/13 5:29 AM I just checked and David M says this change wont break the behat tests because:
a) we are just looking for the links in the tabs and
b) we are not running the behat tests under bootstrap/clean atm.

Damyon Wiese
added a comment - 08/May/13 5:46 AM Thanks David,
This needs some work though - it is incorrectly escaping url parameters for the tabs which breaks the links. To reproduce the error - just add a feedback module and click on "Show responses".

One thing I noticed was that in the bootstrap examples the href is set to "#" for active links. I don't think this really matters though and I imagine the anchor tag is only placed around active text for CSS purposes. So,looks good to me. Thanks for your contribution. Passing.

Mark Nelson
added a comment - 09/May/13 7:07 AM One thing I noticed was that in the bootstrap examples the href is set to "#" for active links. I don't think this really matters though and I imagine the anchor tag is only placed around active text for CSS purposes. So,looks good to me. Thanks for your contribution. Passing.