From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Brandon Williams <bmwill@google.com>,
Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH v2 00/24] object_id part 10
Date: Thu, 12 Oct 2017 08:46:11 +0000
Message-ID: <20171012084610.slrweolcgwnfgvu6@genre.crustytoothpaste.net> (raw)
In-Reply-To: <9e44abcf-abcb-4868-d1cd-2326ea8df3ed@alum.mit.edu>
[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]
On Wed, Oct 11, 2017 at 12:05:50PM +0200, Michael Haggerty wrote:
> On 10/09/2017 03:11 AM, brian m. carlson wrote:
> > This is the tenth in a series of patches to convert from unsigned char
> > [20] to struct object_id. This series mostly involves changes to the
> > refs code. After these changes, there are almost no references to
> > unsigned char in the main refs code.
> >
> > The series has not been rebased on master since the last submission, but
> > I can do so if that's more convenient.
> >
> > This series is available from the following URL:
> > https://github.com/bk2204/git.git object-id-part10
>
> I read through the whole series medium-thoroughly and left a few
> comments, but overall it looks very good and clear. Thanks so much for
> working on this!
Thanks for pointing out the places where I forgot to update the
docstrings. I'll plan another reroll with those changes and the other
issues mentioned about the accidental deletion.
In the course of that, I'll rebase on top of master so that Junio can
avoid as much conflict resolution as possible.
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]