Comments

On 06/04/2012 08:24 PM, Jason Merrill wrote:
> On 06/04/2012 01:52 PM, Paolo Carlini wrote:>> Ok, this would be simple to do. The only issue I can see, is that in C++>> -Wenum-compare has a name, thus can be easily disabled but it's ON by>> default.> The warning is already on by default, so that wouldn't be a change; > this just creates a way for users to turn it off until we deal with > the unhelpful case.
Ok. The below passes the testsuite on x86_64-linux. Ok for mainline and
4.7.1?
Thanks,
Paolo.
/////////////////////
2012-06-04 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/53524
* doc/invoke.texi (Wenum-compare): Update documentation.
/cp
2012-06-04 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/53524
* call.c (build_conditional_expr_1): Use OPT_Wenum_compare
to control enumeral mismatch in conditional expression too.
/testsuite
2012-06-04 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/53524
* g++.dg/warn/Wenum-compare-no-2: New.

On 06/04/2012 02:50 PM, Paolo Carlini wrote:
> Ok. The below passes the testsuite on x86_64-linux. Ok for mainline and> 4.7.1?
OK. But let's leave the bug open until we fix the warning not to
complain about this testcase even with -Wenum-compare on.
Jason

On 06/04/2012 09:16 PM, Jason Merrill wrote:
> On 06/04/2012 02:50 PM, Paolo Carlini wrote:>> Ok. The below passes the testsuite on x86_64-linux. Ok for mainline and>> 4.7.1?>> OK. But let's leave the bug open until we fix the warning not to > complain about this testcase even with -Wenum-compare on.
Sure.
Paolo.