-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

Hadoop QA
added a comment - 26/Oct/11 17:35 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12500895/HADOOP-7772-topology-javadocs.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed the unit tests build
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/321//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/321//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/321//console
This message is automatically generated.

no tests as there are no changes to the code. I verified it as well as I could running mvn javadoc:jar which created a JAR file containing some (but not all) of the javadocs. I don't understand maven enough to know why it was incomplete, but the files that were there looked OK

Steve Loughran
added a comment - 26/Oct/11 17:44 no tests as there are no changes to the code. I verified it as well as I could running mvn javadoc:jar which created a JAR file containing some (but not all) of the javadocs. I don't understand maven enough to know why it was incomplete, but the files that were there looked OK