Haiku: Ticket #6834: add spinner widget [PATCH]https://dev.haiku-os.org/ticket/6834
<p>
A spinner widget would be very useful for Haiku.
</p>
<p>
Libwalter includes a spinner <a class="ext-link" href="http://dev.osdrawer.net/projects/libwalter"><span class="icon">​</span>http://dev.osdrawer.net/projects/libwalter</a>
</p>
en-usHaikuhttps://dev.haiku-os.org/chrome/site/logo.pnghttps://dev.haiku-os.org/ticket/6834
Trac 1.2.2DisrealiFri, 30 Sep 2011 19:20:21 GMTowner, component, summary changed; keywords sethttps://dev.haiku-os.org/ticket/6834#comment:1
https://dev.haiku-os.org/ticket/6834#comment:1
<ul>
<li><strong>owner</strong>
changed from <em>nobody</em> to <em>axeld</em>
</li>
<li><strong>keywords</strong>
<em>spinner</em> added
</li>
<li><strong>component</strong>
changed from <em>- General</em> to <em>Kits/Interface Kit</em>
</li>
<li><strong>summary</strong>
changed from <em>add spinner widget</em> to <em>add spinner widget [PATCH]</em>
</li>
</ul>
<p>
Attaching a patch that literally copies the Spinner.cpp and Spinner.h files from LibWalter to the, hopefully, appropriate locations in the Haiku src tree.
</p>
<p>
*Please review.* I don't know if there are any jam file adjustments that need to be done.
</p>
<p>
It would be really useful to replace the sliders in the VirtualMemory pref and DriveSetup with spinners.
</p>
TicketDisrealiFri, 30 Sep 2011 20:23:03 GMTattachment sethttps://dev.haiku-os.org/ticket/6834
https://dev.haiku-os.org/ticket/6834
<ul>
<li><strong>attachment</strong>
set to <em>add_spinner.diff</em>
</li>
</ul>
TicketDisrealiFri, 30 Sep 2011 20:23:04 GMTpatch changedhttps://dev.haiku-os.org/ticket/6834#comment:2
https://dev.haiku-os.org/ticket/6834#comment:2
<ul>
<li><strong>patch</strong>
set
</li>
</ul>
TicketDisrealiFri, 30 Sep 2011 20:34:01 GMThttps://dev.haiku-os.org/ticket/6834#comment:3
https://dev.haiku-os.org/ticket/6834#comment:3
<p>
I deduced the jamfile adjustment needed, and created an updated patch. I did a fresh build (jam -qa @alpha-raw) and there was no error given about adding the spinner files.
</p>
<p>
*PLEASE REVIEW* I can only assume that the code works as intended.
</p>
TicketDisrealiFri, 30 Sep 2011 20:34:41 GMTattachment sethttps://dev.haiku-os.org/ticket/6834
https://dev.haiku-os.org/ticket/6834
<ul>
<li><strong>attachment</strong>
set to <em>add_spinner_02.diff</em>
</li>
</ul>
TicketDisrealiFri, 28 Oct 2011 00:56:42 GMThttps://dev.haiku-os.org/ticket/6834#comment:4
https://dev.haiku-os.org/ticket/6834#comment:4
<p>
Here is another patch that could benefit from dev review at the upcoming BG.
</p>
<p>
I do not know if the code actually does what is supposed to, as I mention before, I just copied it from libWalter.
</p>
TicketleavengoodFri, 10 Aug 2012 05:50:00 GMThttps://dev.haiku-os.org/ticket/6834#comment:5
https://dev.haiku-os.org/ticket/6834#comment:5
<p>
I agree this could be useful but if anything this should start in the shared kit or otherwise somewhere private.
</p>
<p>
Generally we need to be careful about adding new classes like this to the Interface Kit, since it may need some API tweaking (and in this case definitely some object padding) before it can be deemed worthy of being public and therefore supported by Haiku for who knows how long.
</p>
<p>
If we can find a good use for this class in a few places in Haiku, I could see it getting added faster (though like I said, probably not to the Interface Kit first.)
</p>
<p>
Also please mark old patches obsolete when you update them.
</p>
TicketDisrealiFri, 10 Aug 2012 17:58:18 GMTblocking sethttps://dev.haiku-os.org/ticket/6834#comment:6
https://dev.haiku-os.org/ticket/6834#comment:6
<ul>
<li><strong>blocking</strong>
set to <em>8056, 8057</em>
</li>
</ul>
<p>
Replying to <a class="ticket" href="https://dev.haiku-os.org/ticket/6834#comment:5" title="Comment 5">leavengood</a>:
</p>
<blockquote class="citation">
<p>
If we can find a good use for this class in a few places in Haiku, I could see it getting added faster (though like I said, probably not to the Interface Kit first.)
</p>
</blockquote>
<p>
Tickets <a class="assigned ticket" href="https://dev.haiku-os.org/ticket/8056" title="#8056: enhancement: [VirtualMemory] replace slider with spinner (assigned)">#8056</a> and <a class="new ticket" href="https://dev.haiku-os.org/ticket/8057" title="#8057: enhancement: [DriveSetup] replace slider with spinner (new)">#8057</a> were created for that reason.
</p>
<blockquote class="citation">
<p>
Also please mark old patches obsolete when you update them.
</p>
</blockquote>
<p>
Sorry, I've not been successful in obsoleting anything on trac.
</p>
TicketleavengoodFri, 10 Aug 2012 18:46:40 GMThttps://dev.haiku-os.org/ticket/6834#comment:7
https://dev.haiku-os.org/ticket/6834#comment:7
<p>
Replying to <a class="ticket" href="https://dev.haiku-os.org/ticket/6834#comment:6" title="Comment 6">Disreali</a>:
</p>
<blockquote class="citation">
<p>
Tickets <a class="assigned ticket" href="https://dev.haiku-os.org/ticket/8056" title="#8056: enhancement: [VirtualMemory] replace slider with spinner (assigned)">#8056</a> and <a class="new ticket" href="https://dev.haiku-os.org/ticket/8057" title="#8057: enhancement: [DriveSetup] replace slider with spinner (new)">#8057</a> were created for that reason.
</p>
</blockquote>
<p>
OK great, those are indeed good cases for using the spinner. I'll add this ticket and those to my personal TODO list for sometime in the next few months. I won't take ownership since I may not get to it for a while, and maybe someone else can do it in the meantime.
</p>
<blockquote class="citation">
<p>
Sorry, I've not been successful in obsoleting anything on trac.
</p>
</blockquote>
<p>
OK, I guess only users with certain permissions (maybe just admins, I'm not sure) can mark obsolete patches. Though it is weird you cannot mark something you uploaded as obsolete.
</p>
TicketnielxFri, 10 Aug 2012 20:07:59 GMThttps://dev.haiku-os.org/ticket/6834#comment:8
https://dev.haiku-os.org/ticket/6834#comment:8
<p>
Replying to <a class="ticket" href="https://dev.haiku-os.org/ticket/6834#comment:7" title="Comment 7">leavengood</a>:
</p>
<blockquote class="citation">
<p>
Replying to <a class="ticket" href="https://dev.haiku-os.org/ticket/6834#comment:6" title="Comment 6">Disreali</a>:
</p>
<blockquote class="citation">
<p>
Tickets <a class="assigned ticket" href="https://dev.haiku-os.org/ticket/8056" title="#8056: enhancement: [VirtualMemory] replace slider with spinner (assigned)">#8056</a> and <a class="new ticket" href="https://dev.haiku-os.org/ticket/8057" title="#8057: enhancement: [DriveSetup] replace slider with spinner (new)">#8057</a> were created for that reason.
</p>
</blockquote>
<p>
OK great, those are indeed good cases for using the spinner. I'll add this ticket and those to my personal TODO list for sometime in the next few months. I won't take ownership since I may not get to it for a while, and maybe someone else can do it in the meantime.
</p>
<blockquote class="citation">
<p>
Sorry, I've not been successful in obsoleting anything on trac.
</p>
</blockquote>
<p>
OK, I guess only users with certain permissions (maybe just admins, I'm not sure) can mark obsolete patches. Though it is weird you cannot mark something you uploaded as obsolete.
</p>
</blockquote>
<p>
Please file a bug for that! I will have to look at that because it is not right.
</p>
TicketleavengoodFri, 10 Aug 2012 20:17:19 GMThttps://dev.haiku-os.org/ticket/6834#comment:9
https://dev.haiku-os.org/ticket/6834#comment:9
<p>
Replying to <a class="ticket" href="https://dev.haiku-os.org/ticket/6834#comment:8" title="Comment 8">nielx</a>:
</p>
<blockquote class="citation">
<p>
Please file a bug for that! I will have to look at that because it is not right.
</p>
</blockquote>
<p>
Done: <a class="closed ticket" href="https://dev.haiku-os.org/ticket/8869" title="#8869: bug: Users cannot mark their own attachments as obsolete (closed: invalid)">#8869</a>.
</p>
TicketpulkomandyFri, 07 Nov 2014 09:50:45 GMTmilestone changedhttps://dev.haiku-os.org/ticket/6834#comment:10
https://dev.haiku-os.org/ticket/6834#comment:10
<ul>
<li><strong>milestone</strong>
changed from <em>R1</em> to <em>Unscheduled</em>
</li>
</ul>
TicketrichienyhusSun, 03 May 2015 13:32:12 GMThttps://dev.haiku-os.org/ticket/6834#comment:11
https://dev.haiku-os.org/ticket/6834#comment:11
<p>
Further spinner code:
<a class="ext-link" href="https://github.com/jscipione/haiku/tree/spinner"><span class="icon">​</span>https://github.com/jscipione/haiku/tree/spinner</a>
<a class="ext-link" href="https://github.com/jscipione/haiku/blob/spinner/src/kits/interface/Spinner.cpp"><span class="icon">​</span>https://github.com/jscipione/haiku/blob/spinner/src/kits/interface/Spinner.cpp</a>
<a class="ext-link" href="https://github.com/jscipione/haiku/blob/spinner/headers/private/interface/Spinner.h"><span class="icon">​</span>https://github.com/jscipione/haiku/blob/spinner/headers/private/interface/Spinner.h</a>
</p>
TicketpulkomandyMon, 26 Oct 2015 07:24:17 GMTstatus, owner changedhttps://dev.haiku-os.org/ticket/6834#comment:12
https://dev.haiku-os.org/ticket/6834#comment:12
<ul>
<li><strong>status</strong>
changed from <em>new</em> to <em>assigned</em>
</li>
<li><strong>owner</strong>
changed from <em>axeld</em> to <em>jscipione</em>
</li>
</ul>
<p>
I think we have one now?
</p>
TicketjscipioneTue, 27 Oct 2015 18:19:15 GMTstatus changed; resolution sethttps://dev.haiku-os.org/ticket/6834#comment:13
https://dev.haiku-os.org/ticket/6834#comment:13
<ul>
<li><strong>status</strong>
changed from <em>assigned</em> to <em>closed</em>
</li>
<li><strong>resolution</strong>
set to <em>fixed</em>
</li>
</ul>
<p>
Yes we can close this one now.
</p>
<p>
Spinner widget added in <a class="changeset" href="http://cgit.haiku-os.org/haiku/commit/?id=hrev49568" title="Haiku Revision 49568">hrev49568</a>
</p>
Ticket