Jump to:

There is just one minor problem related to the "Compose appropriate user message" section that has been present in all the recent versions including 6x-1.2

In the section,

// Create new user account, administrator approval required.

the current message:

$message = t('Thank you for applying for an account. Your account is currently pending approval by the site administrator.<br />') . $message;

uses the earlier $message and this is not appropriate for the situation as it says the password and instructions HAVE been sent, when in fact they WILL be sent.

To correct this we have been changing the message as follows:

$message = t('Thank you for applying for an account. Your account is currently pending approval by the site administrator.<br> Once it has been approved, you will receive an e-mail containing information about how to log in, set your password, and other details.');

This is obviously a quick fix and it would be more ideal if this section could be factored better.

Comments

i'm afraid i'm a bit confused by this report. do you have your site set up so that users must have admin approval for new registrations? if so, what is the exact user message displaying to the user after they register?

Yes, the site requires admin approval for new registrations. Unfortunately, we do not have a default version of LoginToboggan installed but the resulting text displayed to the user as I recall is:

"Thank you for applying for an account. Your account is currently pending approval by the site administrator. Your password and further instructions have been sent to your e-mail address."

The ending of this is misleading as users might think it has right now been sent to their email address when in fact it is pending. The last sentence is defined as the immediately preceding $message.

To provide the user more clarity the message starts the same but the last sentence is:

"Once it has been approved, you will receive an e-mail containing information about how to log in, set your password, and other details."

On reading the code it appears as if an attempt is being made to keep the size of text strings small and reuse them whenever possible. This is a good idea but may be difficult to achieve.

The module is handing a number of cases very well including possibly interfacing with the request new password so the text displayed is sometimes reflecting an immediate action correctly.

I am not familiar with php and wondered if it supports Case Statements as alternatives to nested "if-else-then" conditionals? I did not want to risk altering the module code and just changed the text string.

Not to forget, this is a very good module; I wouldn't want to be without it and would rate it as essential. Thanks very much,

k, i see what you're saying now, and i agree. i've changed that line of code to:

$message = t('Thank you for applying for an account. Your account is currently pending approval by the site administrator.<br />Once it has been approved, you will receive an e-mail containing further instructions.');

i left the instructions a bit vague to allow admins to put whatever they want in the approved message.

committed to 6.x-1.x and 6.x-2.x. this won't make it into an official release for a bit, so use the dev snapshot if you really want it now.

With logintobbogan you are able to redirect the user to a node, but it still display the message "thank you for applying..".
And, despite it has been translate in the translation interface in french, it does not do it.

I see that the message is in the .module file, and not in a .tpl. No checkboxes to disable it ?