Status

()

The Bugzilla bug-tracking system.Note: This is not the place to request configuration, permission, or account changes to this installation of Bugzilla (bugzilla.mozilla.org). File such changes under the appropriate component in the bugzilla.mozilla.org product.

You go to https://bugzilla.mozilla.org/userprefs.cgi (to see the preferences in this installation of Bugzilla), you could take a look at the HTML source code of that page, and you could search for the strings in your checkout of the Bugzilla codebase to see where to change the code.

Hello,
I have tried install bugzilla on ubuntu 12.04 for the past 2 days but I wasn't able to.
I would like to give this bug back. I feel like I need to learn more about webserver and mysql.
Thank you,
Sushrut

(In reply to Rishab Kalra from comment #21)
> Hi, I would really like to work on this bug.
The bug is currently already assigned to walexi4great@gmail.com, which is actively working on this issue. So you either need to contact him or her to take the issue over or choose another bug to work on.
(In reply to David Lawrence [:dkl] from comment #20)
> You need to put the <label> tags around the text label itself instead of
> being an empty element.
Note that <label> tags are used to allow clicking the label to focus the form field it references.
Also, as far as I saw your patch only covers a part of the form fields and also some, which don't need a label like buttons.
To be clear on this, here's a list of pages I (as the reporter of this bug) expect to have labels for their input fields, checkboxes and drop down lists:
https://bugzilla.mozilla.org/userprefs.cgi?tab=settings
=> All drop downs under "General Preferences"
https://bugzilla.mozilla.org/userprefs.cgi?tab=email
=> "Add users to my watch list (comma separated list):" labelling <input id="new_watchedusers">
"Add bugs:" labelling <input id="add_ignored_bugs">
https://bugzilla.mozilla.org/userprefs.cgi?tab=account
=> All input fields
https://bugzilla.mozilla.org/userprefs.cgi?tab=bugmail_filter
=> All input fields and drop downs under "Bugmail Filtering"
https://bugzilla.mozilla.org/userprefs.cgi?tab=component_watch
=> "Product:" labelling <select id="product">
"Component:" and "Select the component(s) to add to your watch list:" labelling <select id="component">
"Or watch components starting with:" labelling <input id="add_starting">
https://bugzilla.mozilla.org/userprefs.cgi?tab=request_nagging
=> "Add users to my watch list (comma separated list):" labelling <input id="add_watching">
Because I do not have all privileges on Bugzilla, there may be other pages and fields I do not see. So the list above might not be complete.
Furthermore the patch contains file mode changes, which should probably not happen.
Sebastian

(In reply to Sebastian Zartner [:sebo] from comment #22)
> (In reply to Rishab Kalra from comment #21)
> > Hi, I would really like to work on this bug.
>
> The bug is currently already assigned to walexi4great@gmail.com, which is
> actively working on this issue.
walexi4great, are you still working on this?
Sebastian

(In reply to Mukhtar Ali from comment #27)
> can u assign this bug to me? I would like to contribute. Also if u can
> provide some info/links to get me started on this.
Yes you may work on this bug and complete the previous work if desired. Let me know if you need any assistance.
dkl

(In reply to David Lawrence [:dkl] from comment #28)
> (In reply to Mukhtar Ali from comment #27)
> > can u assign this bug to me? I would like to contribute. Also if u can
> > provide some info/links to get me started on this.
>
> Yes you may work on this bug and complete the previous work if desired. Let
> me know if you need any assistance.
>
> dkl
Thanks David . If u have some links on how to get started that would be helpful. I m new on this but definately want to contribute.

(In reply to Mukhtar Ali from comment #31)
> this current issue is for version 4.5.4 .
> Now current bugzilla release available is 5.0.1 .
> So can I take the latest available release and code base ?
Development must be done based on master, i.e. 5.1. This code is not available as a tarball. You must use git to download it:
http://git.mozilla.org/?p=bugzilla/bugzilla.git

(In reply to Mukhtar Ali from comment #31)
> this current issue is for version 4.5.4 .
I just filed it under 4.5.4, because there was no better version to select when I created the report. I now changed it to 'unspecified', because this enhancement request doesn't relate to a specific version of Bugzilla.
Sebastian

THanks Seabastian for the clarification.
I now have installed Git and Active Perl on my system.
I also downloaded the git master code base using "git clone https://git.mozilla.org/bugzilla/bugzilla"
Besides that do i need any thing else for the build ?

My bugzilla setup doesn't have the following Preference TABS :
1. Request Nagging ,
2. BugMail Filter and
3. Component Watch.
I need to make changes to these as well. Can u help if I m missing some configuration ?

Mukhtar: I suggest you come on IRC to ask your question, or use the support mailing-list for installation and configuration questions. Every comment posted in this bug triggers tens of emails sent to various developers and users. The discussion in this bug should stay focused on development as much as possible. :)
https://www.bugzilla.org/support

(In reply to Mukhtar Ali from comment #41)
> I have finished my development on this issue. Let me know the next steps.
You will need to generate a patch of your work based on your git checkout.
https://wiki.mozilla.org/Bugzilla:Patches
Then attach the patch to this bug setting the review flag to ? asking for a review of the patch. If the reviewer finds issues with the patch, they will set the review flag to - and you will need to revise and attach again.
dkl

Comment on attachment 8695103[details][diff][review]
patch.diff
The patch introduces lots of unneeded whitespace between apostrophes and brackets, or in front of brackets, plus duplicated whitespace between parameters. The patch also includes typos: "new_passowrd1".
- [% setting_descs.$name OR name FILTER html %]
+ <label for="[% name FILTER html %]" >
+ [% setting_descs.$name OR name FILTER html %]
+ </label>
Could you explain how you chose the for parameter for the <label> here, please?

(In reply to Andre Klapper from comment #44)
> Comment on attachment 8695103[details][diff][review]
> patch.diff
>
> The patch introduces lots of unneeded whitespace between apostrophes and
> brackets, or in front of brackets, plus duplicated whitespace between
I can remove the extra whitespace if that is an issue.
> parameters. The patch also includes typos: "new_passowrd1".
This is not typo. This is what the input field name is. ( i.e. While changing password , user has to enter new password (new_password1) and then user has to reconfirm the password @ _new_password2 )
>
> - [% setting_descs.$name OR name FILTER html %]
> + <label for="[% name FILTER html %]" >
> + [% setting_descs.$name OR name FILTER html %]
> + </label>
> Could you explain how you chose the for parameter for the <label> here,
> please?
the drop down field name is "<select name="[% name FILTER html %]" id="[% name FILTER html %]" ".
And it same for both the IF and ELSE input fields

(I don't understand why you set a needinfo request against dkl in your last comment.)(In reply to Mukhtar Ali from comment #45)
> I can remove the extra whitespace if that is an issue.
Yes please. The code style should be the same as the surrounding code.
> This is not typo.
Yes it clearly is. Please read carefully.

Comment on attachment 8695300[details][diff][review]
patch4.diff
>+++ b/template/en/default/account/prefs/account.html.tmpl>+ <label for="new_login_name">
> [% IF Param('emailsuffix') %]
> New login:
> [% ELSE %]
> New email address:
> [% END %]
>+ </label>
The indentation should be fixed.
>+++ b/template/en/default/account/prefs/apikey.html.tmpl>+ <label for="new_description">Generate a new API key with optional description</label>
This line is a bit too long (should not exceed 80 characters, ideally). I suggest that this label points to the checkbox instead of the text field. Or even better, split this text into two labels: "Generate a new API key" and "optional description".
>+++ b/template/en/default/account/prefs/email.html.tmpl>+ <p><label for="watched_by_you">You are watching everyone in the following list:</label></p>
>+<p id="new_watched_by_you"><label for="new_watchedusers">Add users to my watch list (comma separated list):</label>
Both lines are too long and should be split.
>- Add [% terms.bugs %]:<br>
>+ Add <label for="add_ignored_bugs">[% terms.bugs %]:</label><br>
I think <br> should go away, for consistency with the User Watching section.
>+++ b/template/en/default/account/prefs/settings.html.tmpl>+ <label for="[% name FILTER html %]">
>+ [% setting_descs.$name OR name FILTER html %]
>+ </label>
In templates, the indentation is 2 whitespaces, not 3.
All these comments can be fixed on checkin, so no need to upload a new one.
Thanks for your patch, Mukhtar! :) r=LpSolit

(In reply to Sebastian Zartner [:sebo] from comment #54)
> Shouldn't these changes already be available at
> https://landfill.bugzilla.org/bugzilla-tip/? Or is that page only updated
> manually?
They should be there automatically but unfortunately our automation has some problems due to switching to git. I've brought it up to date now.

(In reply to Teemu Mannermaa (:wicked) from comment #55)
> (In reply to Sebastian Zartner [:sebo] from comment #54)
> > Shouldn't these changes already be available at
> > https://landfill.bugzilla.org/bugzilla-tip/? Or is that page only updated
> > manually?
>
> They should be there automatically but unfortunately our automation has some
> problems due to switching to git. I've brought it up to date now.
Thank you! Now I could check it and it looks all very good to me.
Unfortunately some tabs mentioned in comment 22 are not available there. Are they BMO specific or are they just not enabled on Landfill?
Sebastian

(In reply to Sebastian Zartner [:sebo] from comment #56)
> Unfortunately some tabs mentioned in comment 22 are not available there. Are
> they BMO specific or are they just not enabled on Landfill?
Currently at least component watching, bugmail filter and request nagging are BMO only extensions.