ASF GitHub Bot
added a comment - 01/Apr/15 06:09 GitHub user RamVenkatesh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/22
ZEPPELIN-19 Failures from disabled interpreters not reported
Handle all exceptions from NotebookServer runParagraph and update Note
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RamVenkatesh/incubator-zeppelin ZEPPELIN-19
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
commit 4576183b29efa1e6af6ed1eec389cfd459e4917a
Author: Ram Venkatesh <rvenkatesh@hortonworks.com>
Date: 2015-04-01T06:07:32Z
ZEPPELIN-19 Failures from disabled interpreters not reported
Handle all exceptions from NotebookServer runParagraph and update Note

@felixcheung one question - I see that the paragraph has the error message but it is not displayed on the web UI until the note is refreshed. Do you have any suggestions on how to fix this refresh issue?

ASF GitHub Bot
added a comment - 01/Apr/15 17:40 Github user RamVenkatesh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/22#issuecomment-88569684
@felixcheung one question - I see that the paragraph has the error message but it is not displayed on the web UI until the note is refreshed. Do you have any suggestions on how to fix this refresh issue?

ASF GitHub Bot
added a comment - 02/Apr/15 05:50 Github user RamVenkatesh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/22#issuecomment-88750225
@felixcheung thank you. I have updated the patch to set the status to ERROR. This triggers a broadcast and the Note status is now correctly displayed on the web ui.

NotebookServer.java[runParagraph]:431) - Exception from run
java.lang.NullPointerException
at com.nflabs.zeppelin.notebook.NoteInterpreterLoader.get(NoteInterpreterLoader.java:70)
at com.nflabs.zeppelin.notebook.Note.run(Note.java:234)
at com.nflabs.zeppelin.socket.NotebookServer.runParagraph(NotebookServer.java:428)
at com.nflabs.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:96)
at org.java_websocket.server.WebSocketServer.onWebsocketMessage(WebSocketServer.java:469)
at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:368)
at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:157)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.run(WebSocketServer.java:657)
```

I have made the following changes:
1. for NPEs getMessage() is null, hence no error is shown on the GUI. I have fixed this in InterpreterUtils.getMostRelevantMessage
2. added a test for this specific case to throw an InterpreterException instead of NPE

ASF GitHub Bot
added a comment - 03/Apr/15 02:35 Github user RamVenkatesh commented on a diff in the pull request:
https://github.com/apache/incubator-zeppelin/pull/22#discussion_r27712863
— Diff: zeppelin-zengine/src/main/java/com/nflabs/zeppelin/notebook/Note.java —
@@ -231,6 +232,9 @@ public void run(String paragraphId) {
p.setNoteReplLoader(replLoader);
p.setListener(jobListenerFactory.getParagraphJobListener(this));
Interpreter intp = replLoader.get(p.getRequiredReplName());
+ if (intp == null) {
— End diff –
@Leemoonsoo thank you for the review.
I have made the following changes:
1. for NPEs getMessage() is null, hence no error is shown on the GUI. I have fixed this in InterpreterUtils.getMostRelevantMessage
2. added a test for this specific case to throw an InterpreterException instead of NPE