what are the best professions for a tank?
which profession offers spirit besides jc,bs and tailor(suitable for healers)?

Dunno fully, I have Blacksmithing because of my tanking, giving me 2 extra sockets. (Some might then say JC next to it, or Enchanting for the stam on rings)

And when it comes to spirit, are we talking armor or bonuses? JC has their spirit gems, BS just have sockets again, Tailor has leg and cloak enchant and Engineering has a 600 spirit cogwheel for the trinket.

Stuff can be fixed, just get enough glue or duct tape!Roses are red, mana is blue. Suramar Guards, Will always find you!

Well, as I wrote, that is mostly. BS doesn't offer spirit though, it offers you sockets to put spirit or intellect in. Engineering offers you a trinket to put 3x 600 of a secondary stat (only one of a kind - Among them you have 600 haste/Crit/Sprit/Mastery). Enchanting gives your intellect on rings. Jewelcrafting offer you the chance of maker 3 stronger versions of the current mainstat gems.

Stuff can be fixed, just get enough glue or duct tape!Roses are red, mana is blue. Suramar Guards, Will always find you!