> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port> device. It has a built-in programmable execution engine that can be programmed> to operate as almost any serial bus (I2C, SPI, EasyScale, and others).> > This patch adds a driver for this controller device. The driver does not> expose a user-land interface. Protocol drivers built on top of this layer are> expected to remain in-kernel.> >> ...>> +struct ti_ssp_dev_data {> + const char *dev_name;> + unsigned long iosel; /* see note below */> + unsigned long config;> + const void *pdata;> + int pdata_sz;

I suppose this really should have type size_t. Also a better name is"pdata_size" - we prefer to avoid this random omission of vowels fromkernel identifiers. Just spell it out; it makes it easier to remember.

These could be implemented as C funtions. That's superior because ofthe typechecking. At present dev2ssp() will happily compile and failat runtime if passed anystructure which has a 'const struct device*parent'.