Spec URL: http://bogado.net/rpm/cwiid.spec
SRPM URL: http://bogado.net/rpm/cwiid-0.6.00-1bog.src.rpm
Description: This package has a library and some tools that allows communication with a wiimote using a bluetooth connection. The package creates four different rpm files:
- cwiid : base library.
- cwiid-devel : development files.
- cwiid-python2 : python bindings.
- cwiid-wmgui : test program with a gtk gui.
- cwiid-wminput : Program that allows user to control mouse/keyboard with the wiimote (this package is affected by the bug #401951 '"/dev/input/uinput" without user rights (0600 root root)').

I started to do a pre-review but the package wouldn't build as is.
You need to start by adding python-devel >= 2.4 to the BuildRequires
Doing that produces the following error:
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/lib64/python2.5/site-packages/cwiid-0.6.00-py2.5.egg-info
Take care of those 2 things and I'll do another pre-review.

Also, you need something under changelog and your package is not rpmlint clean:
cwiid.src: E: description-line-too-long Cwiid is a library that enables your
application to communicate with a wiimote using a bluetooth connection.
cwiid.src: E: no-changelogname-tag

Yes it is my first try at packaging something for fedora, so please go easy on
me (hehee). ':-) Should I create an account?
The main problem I have with your direction is that the file you said
'/usr/lib64/python2.5/site-packages/cwiid-0.6.00-py2.5.egg-info' is not
installed in my version(*). If add this file the rpm fails to build in my
machine. What I did was to change the line that specify
"%{python_sitelib}/cwiid.so" to "
%{python_sitelib}/*" since this file is on that same dir this may cover both
build environments.
Also I am checking the rpmlint errors, I hope I can upload a new version soon,
thanks.
(*)I am building it with the fedora 8, should I be building it with a rawride
version? I usually prefer to use the stable version, but I guess it should no be
hard to make a building VM to do this.

The reason I ask is that we have specific procedures for new packagers. Please
look over the documentation at
http://fedoraproject.org/wiki/PackageMaintainers/Join.
You're well on your way, but be aware that you will need a sponsor so please do
provide that extra information which is requested.

There I fixed almost every rpmlint problem and tried to fix the problem that
appeared in josh.kayse@gtri.gatech.edu compilation.
But there are still some problems left in rpmlint, but I don't know how to solve
them :
cwiid.x86_64: W: incoherent-version-in-changelog 0.6.00-2 0.6.00-2bog
I use a different distribution tag to make my rpms, so I can find them easily
among the installed packages. I don't want to write the name of the distribution
in the change log because it will cause the same problem when compiled for other
distributions.
cwiid-devel.x86_64: W: no-documentation
cwiid-python2.x86_64: W: no-documentation
All the documentation went to the right places, those two packages simply do not
have any real documentation.
The spec file was overwritten, but the corresponding src.rpm is now :
http://bogado.net/rpm/cwiid-0.6.00-2bog.src.rpm

Now koji/CVS/etc seems under construction so I cannot
check binary rpms rebuilt from your srpm, however
for 0.6.00-3:
* SourceURL:
- I recommend to use %{name} and %{version}. With this
you won't have to change Source0 URL when version is
upgraded.
* BuildRequires
- Rebuild fails because "BuildRequires: desktop-file-utils"
is missing.
* License tag for -wminput subpackage
- License tag "GPLv2" is okay, however would you write some
comments in the spec file to explain why this subpackage
has the license tag?
* Compiler flags
- Fedora specific compiler flags are not yet correctly honored.
* Directory ownership issue/Duplicate files
- There are many warnings like:
-------------------------------------------------------------
warning: File listed twice: /etc/cwiid/wminput
warning: File listed twice: /etc/cwiid/wminput/acc_ptr
warning: File listed twice: /etc/cwiid/wminput/acc_ptr
warning: File listed twice: /etc/cwiid/wminput/buttons
warning: File listed twice: /etc/cwiid/wminput/buttons
.....................
--------------------------------------------------------------
! If you write the %files entry
--------------------------------------------------------------
%files
%{_libdir}/cwiid
--------------------------------------------------------------
this contains the directory %_libdir/cwiid and all files/
directories/etc under the directory, while
--------------------------------------------------------------
%files
%dir %{_libdir}/cwiid
--------------------------------------------------------------
contains the directory %_libdir/cwiid only.
* Desktop file
- wmgui desktop file has Icon entry, however no icons seem to
be installed?
Well, as this is NEEDSPONSOR ticket:
-------------------------------------------------------------
NOTE: Before being sponsored:
This package will be accepted with another few work.
But before I accept this package, someone (I am a candidate)
must sponsor you.
Once you are sponsored, you have the right to review other
submitters' review requests and approve the packages formally.
For this reason, the person who want to be sponsored (like you)
are required to "show that you have an understanding
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
(at the time you are not sponsored, you cannot do
a formal review)
When you have submitted a new review request or have pre-reviewed other
person's review request, please write the bug number on this bug report
so that I can check your comments or review request.
Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")
Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelineshttp://fedoraproject.org/wiki/Packaging/Guidelineshttp://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

I made all the chages and I do have another package wating for review, and I
even made some changes on it for myself based on the points you posted here. It
is a 3d game using SDL, it does have a questionable item in it, there is a
non-free (freely distributed for non-comercial uses) font, I removed it from the
final package but since the sources used must be the same as the upstream the
font file gets to be distributed with the source rpm, not sure if this is a problem.
The bug number for the review is #443238.

Okay.
- This package is now clean
- Your another review request seems good to some extent (some
fix seems needed although)
---------------------------------------------------------------------
This package (cwiid) is APPROVED by me
---------------------------------------------------------------------
Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account".
At a point a mail should be sent to sponsor members which notifies
that you need a sponsor. At the stage, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.
If you want to import this package into Fedora 7/8, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).
If you have questions, please ask me.

I have a question, the package has a binary file '/usr/bin/lswm' in the main
package, since it is a library package yum install both .i386 and .x86_64. It
does happen seamless, I tested in my computer. But the files in the i386 package
and the x86_64 are different, so how does this work.
I am thinking in renaming cwiid-wmgui to cwiid-utils and include this wmls in it
to solve this "problem".

My reasoning was that both wmgui and lswm are optional tools to debug
connections and find out bluetooth ids for your wiimotes, so they are optional.
So in my idea we would have :
cwiid - libraries.
cwiid-devel - development package.
cwiid-phyton2 - python binding.
cwiid-utils - lswm and wmgui, both utilities to debug connections.
cwiid-wminput - simulate mouse and inputs with the wiimote, an end user would
probably want this package.

As this package (cwiid) is already in F-8 testing so changing rpm
name like cwiid-wmgui -> cwiid-utils needs proper handing (adding
Provides/Obsoletes) and unless it is avoidable it should not be done.
My way (comment 30) is more safer way.

Other option would be create another package cwiid-lswm with only this file. But
I thought that this would bloat the cwiid namespace.
I think that this util 'lswm' is mostly a test thingy that is useless 90%-99% of
the time. Having a package for it alone is an overkill. I get it that renaming
is a hard option right now, and I regret have not seeing this before. So if we
let out the renaming option I have basically two options :
your idea on #30 :
cwiid - only packages /usr/bin/lswm or maybe even nothing on it. this packagfe
requires cwiid-libs.
cwiid-libs - runtime library stuff
cwiid-devel - development stuff
cwiid-lswm - /usr/bin/lswm in the case it is not packaged in the cwiid package.
or :
cwiid - runtime library stuff (as it is now, but without the lswm util)
cwiid-* - not changed
cwiid-lswm - new package with /usr/bin/lswm.
I tend to think that #2 is more to the point, even though it has more packages.