… hand)
------------------------------------------------------------------------
r1310731 | jleroux | 2012-04-07 13:01:49 +0200 (sam., 07 avr. 2012) | 18 lines
A patch from Tom Burns for "SFA Postal Address Broken" https://issues.apache.org/jira/browse/OFBIZ-4786
SFA does not store countryGeoId or stateProvinceGeoId in PostalAddress entity when creating a new account causing postal address display to break in SFA and Party Manager profile screens.
Demo data for "sfa100" does not have values for countryGeoId or stateProvinceGeoId
Values countryGeoId or stateProvinceGeoId are needed to display party profile.
To reproduce:
1. In Party Manager search for Party Id "sfa100"
Open "sfa100" from search results
See error message under "General Correspondence Address"
2. Similar in SFA Account Lookup
3. A New Account created in SFA will produce the same error.
Adding address to an existing account works. For example the demo accounts created by other components.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1310733 13f79535-47bb-0310-9956-ffa450edef68

------------------------------------------------------------------------
r1309715 | jleroux | 2012-04-05 11:27:24 +0200 (jeu., 05 avr. 2012) | 5 lines
A patch from Paul Foxworthy https://issues.apache.org/jira/browse/OFBIZ-4784 "storeIncomingEmail assumes variable is not null when it might be"
In storeIncomingEmail in CommunicationEventServices.java, the code to assemble the aboutThisEmail debugging message assumes addressesFrom and addressesTo are not null. But the methods that return values for those variables might return null if they encounter an exception.
Removes also uses of UtilValidate.isEmpty, which should only be used for collections and sequences (see OFBIZ-4427).
------------------------------------------------------------------------
?\026
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1309718 13f79535-47bb-0310-9956-ffa450edef68

------------------------------------------------------------------------
r1308063 | jleroux | 2012-04-01 12:35:09 +0200 (dim., 01 avr. 2012) | 13 lines
A patch from Sebastian Leitner https://issues.apache.org/jira/browse/OFBIZ-4766 "PriceRule applies action to wrong priceType"
If you create a PriceRule and add an action of type "PRICE_POD" (Percent of default price) I read this as:
"take the default price and give an amount of x% to that"
These rules are applied within the service "calculateProductPrice" (specifically in PriceServices.calcPriceResultFromRules). It calculates the amount of discount using the default price (as specified by the action of the rule). But then it adds this discount to the listPrice instead of the defaultPrice.
An example:
listPrice = 100,
defaultPrice = 10,
rule says you give 10% of defaultPrice,
modifyAmount = -1 (this is the correct discount amount)
result would be 100-1 = 99.
------------------------------------------------------------------------
?\026
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1308066 13f79535-47bb-0310-9956-ffa450edef68

….apache.org/jira/browse/OFBIZ-4762) A patch from Sebastian Leitner: The services "runSubscriptionAutoReorders" runs every midnight by default. It checks for expired subscriptions and places a new order to extend them. It fills up a cart from the previous order and places the order.
It also sets the orderId of the old order at the cart, which is used during creation of the new order. According to this, no new order can be placed because of duplicate-entry exceptions from the database.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1306729 13f79535-47bb-0310-9956-ffa450edef68

Bug fix. Setting up transaction-timeout="7200" for updateOrderItems service. This problem comes into picture when you have large number of items in an order. For example: Suppose you have more then 100 _different_ items in the cart, each has large quantity and now you wanted to update any of the item quantity then you will observe transaction timeout issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1305739 13f79535-47bb-0310-9956-ffa450edef68

…as not giving build fail error when I build the source code last time. Fixing the build fail error.
Old log message:
Bug fix back ported from trunk r1300463. For more details please refer discussion done on developer mailing list with subject line "svn commit: r1300463 [1/3] - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/finaccount/ applications/accounting/src/org/ofbiz/accounting/invoice/ applications/accounting/src/org/ofbiz/accounting/payment/ applications/accountin"
Log Message from trunk:
On production systems you can't suppress Debug.log( message by the use of debug.properties file. It is always good to use Debug.* statements that are having log level setup in debug.properties file. The real problem comes with Debug.log( statement when you are printing any list or map object that contains so many records(or data) in it. Here I am changing all the occurrence of Debug.log( with Debug.logInfo(, Debug.logError( or Debug.logWarning( so that we can have better control of Debug.* statements on production system. :-)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1302279 13f79535-47bb-0310-9956-ffa450edef68

…r discussion done on developer mailing list with subject line 'svn commit: r1300463 [1/3] - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/finaccount/ applications/accounting/src/org/ofbiz/accounting/invoice/ applications/accounting/src/org/ofbiz/accounting/payment/ applications/accountin' Log Message from trunk:On production systems you can't suppress Debug.log( message by the use of debug.properties file. It is always good to use Debug.* statements that are having log level setup in debug.properties file. The real problem comes with Debug.log( statement when you are printing any list or map object that contains so many records(or data) in it. Here I am changing all the occurrence of Debug.log( with Debug.logInfo(, Debug.logError( or Debug.logWarning( so that we can have better control of Debug.* statements on production system. :-)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1301889 13f79535-47bb-0310-9956-ffa450edef68

===
Removed the Webslinger component and all the framework dependencies on it; the reasons for this
* no active committer was maintaining the webslinger component
* the component was experimental and not really used by OFBiz
* the component was really big (lot of jars etc...) and we are trying to slim down the OFBiz framework and keep only the essential/useful features
* this fixes a security issue reported to the OFBiz PMC
The only Webslinger feature used by the OFBiz framework was the "service debug mode" (enabled by default with the property servicedispatcher.servicedebugmode): I have considered to keep it but it was impossible because it relied on Webslinger legacy code (in the org.webslinger.invoker.* package) that was never contributed as a source file to the OFBiz project; I have tried to review the source file from an external Webslinger repo but I couldn't find them; the only site about Webslinger I could find is this:
http://www.webslinger.org/Downloads
but the svn resources mentioned there are broken. The fact that the OFBiz frameework was dependent (for a feature useful only in development mode) on an external project that doesn't publish its source code (at least in an easy to find location) convinced me that it was better to clean up the dependency completely; on the bright side OFBiz should now use less memory.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1301887 13f79535-47bb-0310-9956-ffa450edef68

------------------------------------------------------------------------
r1293376 | jleroux | 2012-02-24 19:36:04 +0100 (ven., 24 févr. 2012) | 7 lines
A patch from Uwe Allner "Download link for digital products on order history page contains file name, preventing correct resolve of the request" https://issues.apache.org/jira/browse/OFBIZ-4711
I created a product with product type "Finished/Digital Good", and added product content of type "Digital download", providing a file (i.e. some.pdf).
The download link in the order history of the ecommerce application after purchasing the product is rendered as
"/ecommerce/control/downloadDigitalProduct/some.pdf?dataResourceId=10060".
The file name in this URL prevents resolving the correct service (method), and instead just a "404 Not found" is generated.
The link "/ecommerce/control/downloadDigitalProduct?dataResourceId=10060" works as expected.
------------------------------------------------------------------------
?\026
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1293378 13f79535-47bb-0310-9956-ffa450edef68

===
OFBIZ-4710 Applied modified patch from Deepak Dixit to fix the following issues:
* if the user attempts to receive a cancelled order then receive inventory page showing a stack trace
* in the first step of the receiving screen, the autocompletor for lookup purchase order displaying duplicated order ids
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release10.04@1292361 13f79535-47bb-0310-9956-ffa450edef68