db-derby-dev mailing list archives

[jira] Commented: (DERBY-375) Specification of incomplete server properties on command line causes NPE with NetworkServerControl when starting the server.

Date

Wed, 19 Oct 2005 18:47:45 GMT

[ http://issues.apache.org/jira/browse/DERBY-375?page=comments#action_12332498 ]
A B commented on DERBY-375:
---------------------------
The patch for this has been committed and I verified that the example shown in this description
now works against the trunk, as do the new test cases in derbynet/testProperties. Should
this fix be ported to 10.1? The Fix version is only specified as 10.2.0.0, so if that's correct,
I'll go ahead and resolve/close this issue...
> Specification of incomplete server properties on command line causes NPE with NetworkServerControl
when starting the server.
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-375
> URL: http://issues.apache.org/jira/browse/DERBY-375
> Project: Derby
> Type: Bug
> Components: Network Server
> Versions: 10.2.0.0, 10.1.1.0
> Environment: Running Derby Network Server and using command line API to start the server.
> Reporter: A B
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-375.diff, derby-375.status, derbyall_report.txt
>
> When using the command line to start the Network Server, there a couple of cases where
if a property is specified on the command line but no value is given (ex. "-Dderby.drda.maxThreads"
instead of "-Dderby.drda.maxThreads=3"), a Null Pointer Exception will result, when the correct
behavior should be to use some kind of default.
> For example:
> > java -Dderby.drda.maxThreads org.apache.derby.drda.NetworkServerControl start -p
1528
> java.lang.NullPointerException
> at org.apache.derby.impl.drda.NetworkServerControlImpl.localizeMessage(NetworkServerControlImpl.java)
> at org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessageWork(NetworkServerControlImpl.java)
> at org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessage(NetworkServerControlImpl.java)
> at org.apache.derby.impl.drda.NetworkServerControlImpl.getIntPropVal(NetworkServerControlImpl.java)
> at org.apache.derby.impl.drda.NetworkServerControlImpl.getPropertyInfo(NetworkServerControlImpl.java)
> at org.apache.derby.impl.drda.NetworkServerControlImpl.<init>(NetworkServerControlImpl.java)
> at org.apache.derby.drda.NetworkServerControl.main(NetworkServerControl.java)
> Note that even though we see this NPE, it appears that the server still starts up, although
the startup may not be complete (subsequent attempts to connect might lead to errors like
"Invalid reply from network server: Insufficient data.").
> For other properties, this will just result in the default value being used, which is
the correct behavior. For example:
> > java -Dderby.drda.host org.apache.derby.drda.NetworkServerControl start -p 1528
> Server is ready to accept connections on port 1528.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira