The only (potential) regression is that we did not apply previous changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global watchers are CCs so we can use their prefs to for instance ignore CC-only mails."

On Tue, Dec 4, 2012 at 2:44 PM, Andre Klapper <aklapper [at] wikimedia> wrote: > The only (potential) regression is that we did not apply previous > changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global > watchers are CCs so we can use their prefs to for instance ignore > CC-only mails." >

Is there a reason for this? We had this hack in place to keep BZ from spamming IRC/wikibugs-l when only the CC list changes...

On Tue, 2012-12-04 at 14:53 -0500, Chad wrote: > On Tue, Dec 4, 2012 at 2:44 PM, Andre Klapper <aklapper [at] wikimedia> wrote: > > The only (potential) regression is that we did not apply previous > > changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global > > watchers are CCs so we can use their prefs to for instance ignore > > CC-only mails." > > > > Is there a reason for this? We had this hack in place to keep BZ > from spamming IRC/wikibugs-l when only the CC list changes...

The diff didn't apply cleanly, IIRC. We could probably give it a try again in the next days.

> On Tue, Dec 4, 2012 at 2:44 PM, Andre Klapper <aklapper [at] wikimedia> > wrote: > > bugzilla.wikimedia.org is operational again and is now running the > > latest stable version (4.2.4, before was 4.0.9). > > > > There's been some idle grumbling (myself included) that the new > default of HTML e-mails is kind of yucky and people preferred the > plaintext. Do others have thoughts? Should we turn the default > back?

I like that I can finally see what changed. I couldn't see that on my iOS mail apps. Now I can. So I like that part.

I'd like to see the order of the fields optimized, but that's nothing critical.

> On Tue, Dec 4, 2012 at 2:44 PM, Andre Klapper <aklapper [at] wikimedia> > wrote: > > bugzilla.wikimedia.org is operational again and is now running the > > latest stable version (4.2.4, before was 4.0.9). > > > > There's been some idle grumbling (myself included) that the new > default of HTML e-mails is kind of yucky and people preferred the > plaintext. Do others have thoughts? Should we turn the default > back? >

I say leave it, let's join the 21st century with links in our emails. :)

> There's been some idle grumbling (myself included) that the new > default of HTML e-mails is kind of yucky and people preferred the > plaintext. Do others have thoughts? Should we turn the default > back? >

On 12/04/2012 11:44 AM, Andre Klapper wrote: > bugzilla.wikimedia.org is operational again and is now running the > latest stable version (4.2.4, before was 4.0.9). > > Big thanks to Daniel Zahn from the ops team for upgrading! > All fame belongs to him!

Much appreciation to Andre and to Daniel for their many hours of work on this, and on their previous security upgrade of Bugzilla.

I want to emphasize a few of the improvements that I especially love, from those release notes: * Displaying a bug with many dependencies is now much faster. * After you edit a bug, the URL is automatically changed to show_bug.cgi instead of process_bug.cgi or the like. * User autocompletion is faster (like when you add a cc). * Most changes made by BZ admins are now logged to the database, in the audit_log table. * We can disable older components, versions and milestones.

And we get more customizability to generally improve the look, feel, and workflow of Bugzilla. So, thanks for pushing this, Daniel and Andre!

Le 05/12/12 20:53, Chad a écrit : > There's been some idle grumbling (myself included) that the new > default of HTML e-mails is kind of yucky and people preferred the > plaintext. Do others have thoughts? Should we turn the default > back?

I would leave HTML mails to be the default. I hate them myself but given them a try for a few days see how my brain adapt :-]

As other said, one can revert back to plain text in its user preferences.

This is long overdue and kudos to all involved. I'm already noticing the more useful side effects such as the url change, performance and the better formatted emails

On Wed, Dec 5, 2012 at 12:56 PM, Sumana Harihareswara <sumanah [at] wikimedia> wrote: > On 12/04/2012 11:44 AM, Andre Klapper wrote: >> bugzilla.wikimedia.org is operational again and is now running the >> latest stable version (4.2.4, before was 4.0.9). >> >> Big thanks to Daniel Zahn from the ops team for upgrading! >> All fame belongs to him! > > Much appreciation to Andre and to Daniel for their many hours of work on > this, and on their previous security upgrade of Bugzilla. > >> I've done some quick testing, and to my surprise stuff like "Weekly bug >> summary" did not break. >> However, if you see new issues and problems please file a ticket: >> http://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikimedia&component=Bugzilla>> >> The only (potential) regression is that we did not apply previous >> changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global >> watchers are CCs so we can use their prefs to for instance ignore >> CC-only mails." >> >> New features and improvements of this Bugzilla version: >> http://www.bugzilla.org/releases/4.2.4/release-notes.html#v42_feat>> >> Happy bug reporting! >> >> andre > > I want to emphasize a few of the improvements that I especially love, > from those release notes: > * Displaying a bug with many dependencies is now much faster. > * After you edit a bug, the URL is automatically changed to show_bug.cgi > instead of process_bug.cgi or the like. > * User autocompletion is faster (like when you add a cc). > * Most changes made by BZ admins are now logged to the database, in the > audit_log table. > * We can disable older components, versions and milestones. > > And we get more customizability to generally improve the look, feel, and > workflow of Bugzilla. So, thanks for pushing this, Daniel and Andre! > > -- > Sumana Harihareswara > Engineering Community Manager > Wikimedia Foundation > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l [at] lists > https://lists.wikimedia.org/mailman/listinfo/wikitech-l

On Wed, Dec 5, 2012 at 10:45 PM, Jon Robson <jdlrobson [at] gmail> wrote: > This is long overdue and kudos to all involved. > I'm already noticing the more useful side effects such as the url > change, performance and the better formatted emails > > On Wed, Dec 5, 2012 at 12:56 PM, Sumana Harihareswara > <sumanah [at] wikimedia> wrote: >> On 12/04/2012 11:44 AM, Andre Klapper wrote: >>> bugzilla.wikimedia.org is operational again and is now running the >>> latest stable version (4.2.4, before was 4.0.9). >>> >>> Big thanks to Daniel Zahn from the ops team for upgrading! >>> All fame belongs to him! >> >> Much appreciation to Andre and to Daniel for their many hours of work on >> this, and on their previous security upgrade of Bugzilla. >> >>> I've done some quick testing, and to my surprise stuff like "Weekly bug >>> summary" did not break. >>> However, if you see new issues and problems please file a ticket: >>> http://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikimedia&component=Bugzilla>>> >>> The only (potential) regression is that we did not apply previous >>> changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global >>> watchers are CCs so we can use their prefs to for instance ignore >>> CC-only mails." >>> >>> New features and improvements of this Bugzilla version: >>> http://www.bugzilla.org/releases/4.2.4/release-notes.html#v42_feat>>> >>> Happy bug reporting! >>> >>> andre >> >> I want to emphasize a few of the improvements that I especially love, >> from those release notes: >> * Displaying a bug with many dependencies is now much faster. >> * After you edit a bug, the URL is automatically changed to show_bug.cgi >> instead of process_bug.cgi or the like. >> * User autocompletion is faster (like when you add a cc). >> * Most changes made by BZ admins are now logged to the database, in the >> audit_log table. >> * We can disable older components, versions and milestones. >> >> And we get more customizability to generally improve the look, feel, and >> workflow of Bugzilla. So, thanks for pushing this, Daniel and Andre! Hello,

I didn't see this thread before. Thank you Daniel for the update.

After several days, I can confirm that eases the daily use.

Small functionalities like "Take" instead to set himself as assignee.

About the HTML mails, I like them, it's easier to scan what changed than the previous format.

On Wed, 2012-12-05 at 00:29 +0100, Andre Klapper wrote: > On Tue, 2012-12-04 at 14:53 -0500, Chad wrote: > > On Tue, Dec 4, 2012 at 2:44 PM, Andre Klapper <aklapper [at] wikimedia> wrote: > > > The only (potential) regression is that we did not apply previous > > > changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global > > > watchers are CCs so we can use their prefs to for instance ignore > > > CC-only mails." > > > > Is there a reason for this? We had this hack in place to keep BZ > > from spamming IRC/wikibugs-l when only the CC list changes... So the aim of the patch was to completely omit bugmail in case of CC list only changes, in order to make IRC + wikibugs-l@ less noisy?

1) I assume this silently broke "The CC field changes" settings on https://bugzilla.wikimedia.org/userprefs.cgi?tab=email for everybody in the past. "Assume" because my time machine back to 4.0.9 is broken. 2) wikibugs-l@ is also set as "globalwatchers" ("who should receive a copy of every notification mail Bugzilla sends"). After the Bugzilla upgrade wikibugs-l@ *finally* works reliably for me and seems to send ALL bugmail. Before I didn't receive bugmail anymore after wikibugs-l@ got removed as assignee of a report && when wikibugs-l@ was not listed either as default CC of the corresponding component (test example: bug 42226).

These might be related [or not] to dropping the hack.

In any case, I'd like to challenge reapplying this patch, because:

1) Don't set wikibugs-l@ as globalwatchers if you don't want it to receive all bugmail about all changes. 2) If you want a certain account to not receive email in case of changing X in Bugzilla, edit the accounts's "when to send mail" settings in Bugzilla to not to send bugmail in case of only changing X. Obviously this interferes with 1) currently.

On Sat, Dec 8, 2012 at 12:29 AM, Andre Klapper <aklapper [at] wikimedia> wrote: > So the aim of the patch was to completely omit bugmail in case of CC > list only changes, in order to make IRC + wikibugs-l@ less noisy? > > ... > > In any case, I'd like to challenge reapplying this patch, because: > > 1) Don't set wikibugs-l@ as globalwatchers if you don't want it to > receive all bugmail about all changes. > 2) If you want a certain account to not receive email in case of > changing X in Bugzilla, edit the accounts's "when to send mail" settings > in Bugzilla to not to send bugmail in case of only changing X. > Obviously this interferes with 1) currently.

Wikibugs-l is for technical people that follow it for the bug information, not for "Joe Blogs [added/removed] himself from CC" and CCing doesn't provide any information that is needed for that list, That is why its hacked out. Wikibugs not receiving it is a bonus since it just reads the wikibugs email list and spits it out.

Global watcher is the best option for what we want, Because it always covers the bugs and the only other option really is rely on wikibugs-l being added to the cc list which wasn't a reliable method at all (was used before GW was enabled/present).

Can you propose a better option for this than defaulting the cc'er as wikibugs?

I doub't there are that that many people that want the wikibugs-l list to receive a copy of every single change (Eg: cc changes) to the bug, But that is probably a discussion for another thread.

On Fri, Dec 7, 2012 at 9:29 AM, Andre Klapper <aklapper [at] wikimedia> wrote: > On Wed, 2012-12-05 at 00:29 +0100, Andre Klapper wrote: >> On Tue, 2012-12-04 at 14:53 -0500, Chad wrote: >> > On Tue, Dec 4, 2012 at 2:44 PM, Andre Klapper <aklapper [at] wikimedia> wrote: >> > > The only (potential) regression is that we did not apply previous >> > > changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global >> > > watchers are CCs so we can use their prefs to for instance ignore >> > > CC-only mails." >> > >> > Is there a reason for this? We had this hack in place to keep BZ >> > from spamming IRC/wikibugs-l when only the CC list changes... > > So the aim of the patch was to completely omit bugmail in case of CC > list only changes, in order to make IRC + wikibugs-l@ less noisy? > > 1) I assume this silently broke "The CC field changes" settings on > https://bugzilla.wikimedia.org/userprefs.cgi?tab=email for everybody in > the past. "Assume" because my time machine back to 4.0.9 is broken. > 2) wikibugs-l@ is also set as "globalwatchers" ("who should receive a > copy of every notification mail Bugzilla sends"). > After the Bugzilla upgrade wikibugs-l@ *finally* works reliably for me > and seems to send ALL bugmail. > Before I didn't receive bugmail anymore after wikibugs-l@ got removed as > assignee of a report && when wikibugs-l@ was not listed either as > default CC of the corresponding component (test example: bug 42226). >

I don't know how your preferences were configured, but our hack has worked as expected for years. The logic only happens to @watchers[0], and all it does is set the default CC param for the global watch user. No actual user preferences should be changed.

On Fri, Dec 7, 2012 at 2:50 PM, K. Peachey <p858snake [at] gmail> wrote: > On Sat, Dec 8, 2012 at 12:29 AM, Andre Klapper <aklapper [at] wikimedia> wrote: >> So the aim of the patch was to completely omit bugmail in case of CC >> list only changes, in order to make IRC + wikibugs-l@ less noisy? >> >> ... >> >> In any case, I'd like to challenge reapplying this patch, because: >> >> 1) Don't set wikibugs-l@ as globalwatchers if you don't want it to >> receive all bugmail about all changes. >> 2) If you want a certain account to not receive email in case of >> changing X in Bugzilla, edit the accounts's "when to send mail" settings >> in Bugzilla to not to send bugmail in case of only changing X. >> Obviously this interferes with 1) currently. > > Wikibugs-l is for technical people that follow it for the bug > information, not for "Joe Blogs [added/removed] himself from CC" and > CCing doesn't provide any information that is needed for that list, > That is why its hacked out. Wikibugs not receiving it is a bonus since > it just reads the wikibugs email list and spits it out. > > Global watcher is the best option for what we want, Because it always > covers the bugs and the only other option really is rely on wikibugs-l > being added to the cc list which wasn't a reliable method at all (was > used before GW was enabled/present). > > Can you propose a better option for this than defaulting the cc'er as wikibugs? > > I doub't there are that that many people that want the wikibugs-l list > to receive a copy of every single change (Eg: cc changes) to the bug, > But that is probably a discussion for another thread. >

This. We've had this working for years as-is, and I don't see any consensus to change it (as long as it's continuing to work as expected).

On Sat, 2012-12-08 at 05:50 +1000, K. Peachey wrote: > Can you propose a better option for this than defaulting the cc'er as > wikibugs? > > I doub't there are that that many people that want the wikibugs-l list > to receive a copy of every single change (Eg: cc changes) to the bug, > But that is probably a discussion for another thread.

There are two people watching wikibugs-l@: Quim Gil and I. So I'll likely set up an account like "all-bugmail [at] wikimedia" and set it as "globalwatcher" tomorrow. Then Quim and I can subscribe to it to drown in bugmail, and you can use wikitech-l@ as usual.

> On Sat, 2012-12-08 at 05:50 +1000, K. Peachey wrote: >> Can you propose a better option for this than defaulting the cc'er as >> wikibugs? >> >> I doub't there are that that many people that want the wikibugs-l list >> to receive a copy of every single change (Eg: cc changes) to the bug, >> But that is probably a discussion for another thread. > > There are two people watching wikibugs-l@: Quim Gil and I. > So I'll likely set up an account like "all-bugmail [at] wikimedia" and > set it as "globalwatcher" tomorrow. Then Quim and I can subscribe to it > to drown in bugmail, and you can use wikitech-l@ as usual. >

I am also subscribed to wikibugs-l, and I believe Roan is as well (or was anyway).

I agree with Chad, it should continue to work as expected. From a globalwatcher point of view, whatever change is made to a bug, it must not affect the fact that the globalwatcher address (wikibugs-l in this case) is notified. The default CC status of "Nobody <wikibugs-l [at] lists>" is afaik just for legacy reasons and as placeholder. wikibugs-l as Bugzilla account isn't actually used afaik. In the Bugzilla configuration, wikibugs-l is configured as globalwatcher.

The proposal Andre makes here sounds confusing, How is that different from the current situation? What problem is it supposed to address?

On Tue, 2012-12-11 at 19:30 +0100, Krinkle wrote: > The proposal Andre makes here sounds confusing, How is that different > from the current situation? What problem is it supposed to address?

Re-reading what the hack is supposed to do I realize that making another Bugzilla user a globalwatcher won't change anything.

As I've mentioned before I didn't receive bugmail anymore for a report after wikibugs-l@ had been removed as assignee of a report && when wikibugs-l@ was not listed as default CC of the component either. It works since the upgrade, and I cannot prove if it was related to the hack, but I guess I can quickly find out after reapplying it.

So anybody with shell access who's passionate about getting this back, please feel free to reapply the attached patch 1) on the Bugzilla server and 2) to drop it into Gerrit's wikimedia/bugzilla/modifications/bugzilla-4.2/Bugzilla/BugMail.pm so Gerrit and Bugzilla are in sync (Bugzilla isn't hooked up with Puppet or Gerrit and you don't want to make things messier, do you?). ;)

It isn't, but that doesn't matter here. Other Bugzilla instances also use such virtual accounts, even with non-working email addresses. They are only created so you can add such accounts to your "User Watching" list. Then Bugzilla will make you receive the bugmail that such accounts would theoretically receive. That's all. No email is "physically" sent to such virtual accounts. That is contrary to wikibugs-l@ which seems to be an existing and working email address.

> [..] virtual accounts, even with non-working email addresses. They > are only created so you can add such accounts to your "User Watching" > list. >

That is an interesting technique, but that isn't what we're doing here afaik. Because if someone wants those mails, they can simply subscribe to the list. And moreover, subscribing to the list is semantically more correct since then you receive all activity though the globalwatchers setting, as opposed to only the activity on bugs the "Nobody" account is CCed on (which is often removed from bugs when someone assigns a bug or otherwise ends up removing it for some reason).