On 8/27/10, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> in testcase range-for4.C you have some typos s/dependant/dependent.
Actually, according to http://www.tfd.com/dependant it is correct,
although since this word is not used in GCC it is better changed.
> Also, I don't think you really want to use printf, most likely you> simply want asserts.
Agreed. I used printf because was easier to debug, but now assert
makes much more sense.
Rodrigo.

Hi,
> Actually, according to http://www.tfd.com/dependant it is correct,> although since this word is not used in GCC it is better changed.
To be clear, is not used in the C++ Standards, as a term of art, just in case somebody thinks we are talking about a GCC quirk.
Paolo

Hello, again.
Re-checking the patch, in gcc/cp/dump.c (cp_dump_tree):
Where it says:
+ dump_child ("init", RANGE_FOR_DECL (t));
Should be instead:
+ dump_child ("decl", RANGE_FOR_DECL (t));
Should I re-do the patch and send it again with these changes? Or is
it preferable to wait until more reviewing is done?
There isn't a hurry because my copyright assignment is still in progress...
--
Rodrigo.