I did retain the full text of the license in the file COPYING as is the GNU custom, but symlinked it from LICENSE per the LLNS instructions. Same with NOTICE -> NOTICE.LLNS, since it seemed good to designate it as part of the lab boilerplate like we did in the past with DISCLAIMER.LLNS.

In the past we had left off the copyright notice on non-installed header files and tests. I went ahead and added headers to those files per our discussion.

In python land, I did not find any copyright notices and didn't add any, as a bit of googling around had me wondering what standard practice was, e.g. this stack overflow question. Any thoughts?

@trws, I was already 3/4 of the way through editing headers by hand when I received your script, and as it wasn't self contained (is rgthis?) I just went ahead and finished it by hand. Thanks again for pushing through the re-release under this license, and for the first attempt at updating files in flux-core.

This comment has been minimized.

edited

LGTM!

I think the pylint errors were from having two consecutive docstrings/long strings (since some of the modules have a docstring that describe the module), but I think I actually like the # comments better.

(is rg this?)

Yep!

EDIT: I looked at the __license__ = "LGPL" example on StackOverflow. Looks like that specific dunder is an epydoc-ism. Also looks like most of the python community just uses __version__. So I'm fine if we don't add the __license__ dunder. I'll open an issue about the __version__ though.

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.