On Thu, Jun 17, 2010 at 4:54 PM, Geoff Norton <gnorton at novell.com> wrote:
> Comments?
Why is it necessary to have mono_ wrappers for arch-neutral Mach
functions, like mach_port_deallocate()?
It would be nice to have at least the larger Mach-centric parts in a
separate file sgen-mach.c, or sgen-os-mach.c. The whole
thread_handshake() function should go there. I'm taking every
opportunity to split the huge sgen-gc.c file into more managable
chunks.
Have you tried to provoke the restarting logic, to check whether it
actually works? I remember a case where for some reason it didn't
work, resulting in a very hard to reproduce bug.
I can't say much about the Mach-centric parts of the patch, but you're
the authority there, anyway. The SGen parts, apart from my comments,
look good to me.
Mark