> My gut feel is the device_suspend calls are the right direction> as it allows us to remove code from the drivers and possible> kill device_shutdown completely. > > But this close to 2.6.13 I'm not certain what the correct solution> is. With this we have had issues with both ide and the e1000.> But those are among the few drivers that do anything in either> device_shutdown() or the reboot_notifier...> Looking at it more closely the code is confusing because> FREEZE and SUSPEND are actually the same message, and in> addition to what shutdown does they place the device in

Not in -mm; I was finally able to fix that one.

> My gut feel is that device_suspend(PMSG_FREEZE) should be> removed from kernel_restart until is a different message> from PMSG_SUSPEND at which point it should be equivalent> to device_shutdown and we can remove that case.

PMSG_FREEZE != PMSG_SUSPEND in current -mm, but I'm not sure if we canpush that to 2.6.13... Pavel-- teflon -- maybe it is a trademark, but it should not be.-To unsubscribe from this list: send the line "unsubscribe linux-kernel" inthe body of a message to majordomo@vger.kernel.orgMore majordomo info at http://vger.kernel.org/majordomo-info.htmlPlease read the FAQ at http://www.tux.org/lkml/