Comments

Since the ONFI 2.1, the onfi spec adds the Extended Parameter Page
to store the ECC info.
The onfi spec tells us that if the nand chip's recommended ECC codeword
size is not 512 bytes, then the @ecc_bits is 0xff. The host _SHOULD_ then
read the Extended ECC information that is part of the extended parameter
page to retrieve the ECC requirements for this device.
This patch implement the reading of the Extended Parameter Page, and parses
the sections for ECC type, and get the ECC info from the ECC section.
Tested this patch with Micron MT29F64G08CBABAWP.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
drivers/mtd/nand/nand_base.c | 77 ++++++++++++++++++++++++++++++++++++++++++
1 files changed, 77 insertions(+), 0 deletions(-)

> Since the ONFI 2.1, the onfi spec adds the Extended Parameter Page> to store the ECC info.> > The onfi spec tells us that if the nand chip's recommended ECC codeword> size is not 512 bytes, then the @ecc_bits is 0xff. The host _SHOULD_> then> read the Extended ECC information that is part of the extended> parameter> page to retrieve the ECC requirements for this device.> > This patch implement the reading of the Extended Parameter Page, and> parses> the sections for ECC type, and get the ECC info from the ECC section.> > Tested this patch with Micron MT29F64G08CBABAWP.> > Signed-off-by: Huang Shijie <b32955@freescale.com>
Acked-by: Pekon Gupta <pekon@ti.com>
Thanks..
with regards, pekon

于 2013年05月03日 07:39, Brian Norris 写道:
> only run the extended parameter page function after that point.
sorry, I prefer to run the extended parameter page function here just
following the case
"p-> ecc_bits != 0xff". IMHO, the two cases should be put together as
the onfi spec tells, rather be split out
far away. The extended parameter page function is just the case
"p->ecc_bits == 0xff".
If we put the nand_flash_detect_ext_param_page() after the point we
reassign the chip->cmdfunc,
It's a little discrete in logic which makes the code not compact enough.
btw: Could you check you email client? I failed several times for the
HTML issue.
thanks
Huang Shijie