Comments

PeopleHandler: Also SetSyncRequested when confirming Sync
Typically SyncRequested is already set at this point, but if a dashboard
reset happened while the settings page was open, then it was cleared in
the meantime. (That's a more likely situation than it might seem,
because the Sync dashboard is linked from the settings page.)
If we don't SetSyncRequested in this case, then Sync won't actually
become active again, even though the user just pressed "Confirm". It
would only become active once they open the settings again.
This is only relevant for situations where sign-out isn't possible, i.e.
on ChromeOS or for managed (enterprise) users on desktop, since
otherwise a dashboard reset also signs out the user.
Bug: 936886
Change-Id: I196c3471176b3a958ad7e6b60751e558dd5dd740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530765
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642108}

Changed files

chrome/browser/ui/webui/settings/people_handler.cc

chrome/browser/ui/webui/settings/people_handler.h

chrome/browser/ui/webui/settings/people_handler_unittest.cc

[Tab Groups] Do not call RemoveFromGroup before adding tabs to groups.

Comments

[Tab Groups] Do not call RemoveFromGroup before adding tabs to groups.
To support crrev.com/c/1476146, this patch removes calls to
RemoveFromGroup from AddToNewGroup and AddToExistingGroup. This will
allow the eventual TabStripModelChange::Delta to contain both the old
group and the new group by giving MoveTabsIntoGroup enough context to
populate those fields.
Also moves MoveTabsIntoGroup, UngroupTab, and SetTabsPinned to be in
the same order as in the header file.
Bug: 905491
Change-Id: I87afbcd7710cb3245ae06631c00e7d835f30435c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526741
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642107}