Hi,
Thanks for the patch, it looks ok, but it can't be committed because it
does not add the mandatory ChangeLog entries. Can't you provide a new
patch with those entries?
Thanks,
Lluis.
El dom, 25-12-2005 a las 00:30 +0100, "Andrés G. Aragoneses" escribió:
> (This is my third attempt to send this email to the list. I suppose my
> previous attempts didn't arrive or are review-pending because their size
> was greater than 100K. I am now compressing the attached patch.)
>> Hello. I have made a patch that I am attaching to this message.
>> C.J. Collier wrote:
> >> 1) The file POTFILES.in contains the entry
> >> "../Core/src/MonoDevelop.Core/MonoDevelop.Core/GettextCatalog.cs",
> >> which is incorrect because the real name of the file is
> >> "GettextCatalog.cs.in".
> >>
> > Sounds to me like the .cs file is the one being translated, and the
> > .in is the file used to generate the .cs file. You may know more
> > about this than me, but the configure script parses .in files and
> > re-writes them without their .in suffix.
> >
> > If you believe that the .in file should be translated and not the .cs
> > file, please make a patch and submit it.
>> This change is in my patch.
>>> >
> >> 2) I think there is a typo in the following string: #:
> >> ../Extras/MonoQuery/MonoQuery/Gui/SqlQueryView.cs:222 #:
> >> ../Extras/MonoQuery/MonoQuery/Gui/SqlQueryView.cs:259 #:
> >> ../Extras/MonoQuery/MonoQuery/Gui/SqlQueryView.cs:469 msgid
> >> "Execuing sql query on" msgstr ""
> >>
> >> Shouldn't it be "Executing" instead of "Execuing"?
> >>
> > Correct. Please make this change part of your patch.
>> This change is in my patch.
>>> >> And I have some doubts about the localization:
> >>
> >> 1) Is a "combine" the same thing as a "solution"? If yes, why we
> >> don't use only one of the two words?
> >>
> > Hmm... I think "Combine" is the Visual Studio.Net name for Solution.
> > Yes, we should only use one. Please make this change in your patch
> > and present the question again when you submit it. If nobody
> > comments, it means we agree with you and that your patch should be
> > submitted.
>> And this change is in my patch.
>> Finally, the last part of my patch is the update of the Spanish
> translation. Ok to commit? If yes, please commit.
>> Regards,
>> Andrés [ knocte ]
>> _______________________________________________
> Monodevelop-list mailing list
>Monodevelop-list at lists.ximian.com>http://lists.ximian.com/mailman/listinfo/monodevelop-list