Comment on attachment 116024[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=116024&action=review>> Source/WebCore/css/CSSStyleApplyProperty.cpp:580
>> + void (CSSStyleSelector::*mapNinePieceImage)(CSSPropertyID, CSSValue*, NinePieceImage&)>
>
> This doesn't need to be a template argument, we can just call mapNinePieceImage() directly.
The reason is that mapNinePieceImage is private, and I both don't want to make it public, and don't want to make all the ApplyProperty* classes friends (because they too have no externally visible interfaces). Passing in the pointer seemed like the best solution here.
>> Source/WebCore/css/CSSStyleApplyProperty.cpp:587
>> + image.setMaskDefaults();
>
> This check should be "if (borderImageType == Mask)" for readability.
Will do.