Comments

Use per-frame task runners at WebView Plugin
This CL switches task runners at several places from per-thread to
per-frame. The purpose of this change is to make it possible to freeze
tasks for bfcache.
We found actual cases that JavaScript is executed:
browser_tests --gtest_filter=PluginPowerSaverBrowserTest.RunAllFlashInAllowMode
Bug: 870606
Change-Id: If5dfe70184fd568ae42dec3c00229121660452b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529894
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642074}

Comments

Add check for RenderWidgetHostDelegate before making a call
This patch adds a check for |delegate_| before a function invocation to
avoid crashes. When the WebContentsImpl is destroyed it triggers the
loading of tabs. It may happen that a tab for which the WebContentsimpl
has already been destroyed is loaded. This leads to a new surface being
embedded. FrameEvictor is also activated to release frames to relieve
memory pressure. In doing so, it may attempt to release frame associated
with the WebContentsImpl that is already destroyed thus leading to a
crash.
Bug: 931827
Change-Id: Ic9905f8249b8cd72501e3b5ff94ab135a93aae62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529198
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642073}

Comments

Remove ios/web/public/block_types.h
This header has a single typedef of a block which is
mostly used in deprecated files. Typedef itself does not
make code more readable, because the type name does not
convey any information about block return type and arguments.
Per Style Guide the code should be optimized for reader, not
for writer: http://go/objc-style#optimize-for-the-reader-not-the-writer
Bug: 942244
Change-Id: I9fcd09a2a990e32450f98ec55455508bf919a72b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527208
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642071}