[MR-279] Lot of local files left on NM after the app finish.

Details

Description

This ticket is about app-only files which should be cleaned after app-finish.

I see these undeleted after app-finish:
/tmp/nm-local-dir/0/nmPrivate/application_1305091029545_0001/*
/tmp/nm-local-dir/0/nmPrivate/container_1305019205843_0001_000002/*
/tmp/nm-local-dir/0/usercache/nobody/appcache/application_1305091029545_0001/*

Siddharth Seth
added a comment - 05/Oct/11 11:47 Changes
Gets rid of a bunch of left over files (either directly or by creating them under an app/container dir)
Gets rid of the random directory component instead of the localized file only.
Not directly related to the Jira, but some changes to the Application statemachine for ignorable transitions, and tests for Application.

Hadoop QA
added a comment - 05/Oct/11 12:13 +1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12497778/MR2751.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/947//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/947//console
This message is automatically generated.

Vinod Kumar Vavilapalli
added a comment - 07/Oct/11 07:33 Patch mostly looks good. Minor comments:
I see a bunch of other transitions missing in Application. Let's do all of that separately, the ignored transitions in the patch also may not really be ignored. Let's drop those changes.
TestApplication.WrappedApplication.finishContainer() can be renamed to containerFinished()
Also verified that all files are getting deleted properly now on my single-node secure setup.

Hadoop QA
added a comment - 07/Oct/11 16:13 +1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498165/MR2751_v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/965//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/965//console
This message is automatically generated.