The change in the order of canvas and base in FW $THEME->parents messed up the login block

Details

Compare the old and the new look of the login block with the attached images.
Take care because all has to work even changing theme blockcolumnwidth and blockpadding.
Cases are really a lot (# of blockcolumnwidth * # of blockpadding * # of browser) but the procedure I used in function formal_white_set_blockpadding of lib.php is linear (in mathematical sense: power of variable is never greater than 1) so I tested only the two extreme cases in FF and chrome and I totally trust all cases are correct.
Even icons and texts alignment needs to be tested. I worked on "Main menu", "Navigation block" and "Login block".

Compare the old and the new look of the login block with the attached images.
Take care because all has to work even changing theme blockcolumnwidth and blockpadding.
Cases are really a lot (# of blockcolumnwidth * # of blockpadding * # of browser) but the procedure I used in function formal_white_set_blockpadding of lib.php is linear (in mathematical sense: power of variable is never greater than 1) so I tested only the two extreme cases in FF and chrome and I totally trust all cases are correct.
Even icons and texts alignment needs to be tested. I worked on "Main menu", "Navigation block" and "Login block".

Activity

Developing the fix for this issue I found two more aspect needing attention.
1. .block_login #login_username, .block_login #login_password width depends from some static value.
I unified the definition of this static values in improve theme maintainability.
2. I found that horizontal alignment among icon and texts in "navigation block", "main menu block" and "login block" was not respected. I tried to fix it as I am showing in the last two attached pictures

Daniele Cordella
added a comment - 22/Apr/12 5:19 PM Developing the fix for this issue I found two more aspect needing attention.
1. .block_login #login_username, .block_login #login_password width depends from some static value.
I unified the definition of this static values in improve theme maintainability.
2. I found that horizontal alignment among icon and texts in "navigation block", "main menu block" and "login block" was not respected. I tried to fix it as I am showing in the last two attached pictures

Eloy Lafuente (stronk7)
added a comment - 25/Apr/12 8:20 AM I've tried IE7, Safari, Firefox and Chrome and both the login block and the icon and text alignments look ok.
Only the username and password boxes are 2-3 points out from text alignment, but it seems to be the same in your images.
So passing, thanks!

Eloy Lafuente (stronk7)
added a comment - 27/Apr/12 11:13 PM This has been near becoming rejected, because it's not the best code you are able to produce.
But, luckily, at the end, it has landed and has been spread to all repos out there.
Many thanks and, don't forget it, keep improving your skills, you can!
Closing, ciao