On Tue, Jun 21, 2005 at 09:56:43PM +0200, Andi Kleen wrote:> On Tue, Jun 21, 2005 at 11:44:55AM -0700, Hans Reiser wrote:> > vs and zam, please comment on what we get from our profiler and spinlock> > debugger that the standard tools don't supply. I am sure you have a> > reason, but now is the time to articulate it.> > > > We would like to keep the disabled code in there until we have a chance> > to prove (or fail to prove) that cycle detection can be resolved> > effectively, and then with a solution in hand argue its merits.> > How about the review of your code base? Has reiser4 ever been> fully reviewed by people outside your group?

I don't think so. Everyone used the previous criteria of the brokencore changes, broken filesystem semantics and it's own useless abtractionlayer (*) as an excuse not to look deeply at this huge mess yet.

(*) which isn't gone yet. and I need to look again if the core changesare okay yet. And the broken sematics should go completely aswell, ifyou want to reintroduce them it needs to happen at the VFS level anyway.