On Fri, Jan 18, 2013 at 08:40:47PM +0000, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging> to drivers/net/ethernet/agere.> > All the existing issues noted for this driver have been resolved, apart> from one performance issue where some fragmented packets suffer from> frame receive errors. As I've only tested the code on one piece of> hardware to date, it would be useful to get feedback on this issue from> any other users of the device (my device has been stepped on several times> now, and is known to need a few wiggles before starting up correctly).> > Signed-off-by: Mark Einon <mark.einon@gmail.com>
No objection from me for this. It's up to the network driver
maintainers if this is ok or not.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On 19 January 2013 11:03, Dan Carpenter <dan.carpenter@oracle.com> wrote:
<snip>
>> et131x_get_regs() has endian bugs calling et131x_mii_read().>
</snip>
Hi Dan,
Could you be a bit more descriptive about the issues you think there
are with these calls?
cheers,
Mark
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Mon, Jan 21, 2013 at 11:44:55PM +0000, Mark Einon wrote:
> On 19 January 2013 11:03, Dan Carpenter <dan.carpenter@oracle.com> wrote:> <snip>> >> > et131x_get_regs() has endian bugs calling et131x_mii_read().> >> </snip>> > Hi Dan,> > Could you be a bit more descriptive about the issues you think there> are with these calls?>
Sorry, that was sloppy on my part. Here's what I meant:
et131x_mii_read(adapter, MII_BMCR, (u16 *)&regs_buff[num++]);
That puts the number in the 2 high bits which works for little
endian systems but not for big endian. It should be something like:
u16 tmp;
et131x_mii_read(adapter, MII_BMCR, &tmp);
regs_buff[num++] = tmp;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html