This commits adds support for readableHighWaterMark and
writableHighWaterMark in Duplex stream, so that they can be set without
accessing the internal state.
Fixes: #14555
PR-URL: #14636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

This comment has been minimized.

This comment has been minimized.

In my opinion it is best to allow it also for Readable/Writable without checking for Duplex, because this is an inherited behavior that behaves different on the base class vs the child class, and this is more confusing than helping. Not sure if this will be agreed by any developer reading the docs though. I wonder what you guys think.

This commits adds support for readableHighWaterMark and
writableHighWaterMark in Duplex stream, so that they can be set without
accessing the internal state.
Fixes: #14555
PR-URL: #14636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

This commits adds support for readableHighWaterMark and
writableHighWaterMark in Duplex stream, so that they can be set without
accessing the internal state.
Fixes: nodejs#14555
PR-URL: nodejs#14636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes
* **Inspector**
* `require()` is available in the inspector console now.
[#8837](#8837)
* **N-API**
* New APIs for creating number values have been introduced.
[#14573](#14573)
* **Stream**
* For `Duplex` streams, the high water mark option can now be set
independently for readable the readable and the writable side.
[#14636](#14636)
* **Util**
* `util.format` now supports the `%o` and `%O` specifiers for printing
objects.
[#14558](#14558)

Notable changes
* **Inspector**
* `require()` is available in the inspector console now.
[#8837](#8837)
* **N-API**
* New APIs for creating number values have been introduced.
[#14573](#14573)
* **Stream**
* For `Duplex` streams, the high water mark option can now be set
independently for the readable and the writable side.
[#14636](#14636)
* **Util**
* `util.format` now supports the `%o` and `%O` specifiers for printing
objects.
[#14558](#14558)
PR-URL: #14811

Notable changes
* **HTTP2**
* Experimental support for the built-in `http2` has been added via the
`--expose-http2` flag.
[#14239](#14239)
* **Inspector**
* `require()` is available in the inspector console now.
[#8837](#8837)
* Multiple contexts, as created by the `vm` module, are supported now.
[#14465](#14465)
* **N-API**
* New APIs for creating number values have been introduced.
[#14573](#14573)
* **Stream**
* For `Duplex` streams, the high water mark option can now be set
independently for the readable and the writable side.
[#14636](#14636)
* **Util**
* `util.format` now supports the `%o` and `%O` specifiers for printing
objects.
[#14558](#14558)
PR-URL: #14811

Notable changes
* **HTTP2**
* Experimental support for the built-in `http2` has been added via the
`--expose-http2` flag.
[#14239](#14239)
* **Inspector**
* `require()` is available in the inspector console now.
[#8837](#8837)
* Multiple contexts, as created by the `vm` module, are supported now.
[#14465](#14465)
* **N-API**
* New APIs for creating number values have been introduced.
[#14573](#14573)
* **Stream**
* For `Duplex` streams, the high water mark option can now be set
independently for the readable and the writable side.
[#14636](#14636)
* **Util**
* `util.format` now supports the `%o` and `%O` specifiers for printing
objects.
[#14558](#14558)
PR-URL: #14811

Notable changes
* **HTTP2**
* Experimental support for the built-in `http2` has been added via the
`--expose-http2` flag.
[#14239](nodejs/node#14239)
* **Inspector**
* `require()` is available in the inspector console now.
[#8837](nodejs/node#8837)
* Multiple contexts, as created by the `vm` module, are supported now.
[#14465](nodejs/node#14465)
* **N-API**
* New APIs for creating number values have been introduced.
[#14573](nodejs/node#14573)
* **Stream**
* For `Duplex` streams, the high water mark option can now be set
independently for the readable and the writable side.
[#14636](nodejs/node#14636)
* **Util**
* `util.format` now supports the `%o` and `%O` specifiers for printing
objects.
[#14558](nodejs/node#14558)
PR-URL: nodejs/node#14811

Notable changes
* **HTTP2**
* Experimental support for the built-in `http2` has been added via the
`--expose-http2` flag.
[nodejs#14239](nodejs#14239)
* **Inspector**
* `require()` is available in the inspector console now.
[nodejs#8837](nodejs#8837)
* Multiple contexts, as created by the `vm` module, are supported now.
[nodejs#14465](nodejs#14465)
* **N-API**
* New APIs for creating number values have been introduced.
[nodejs#14573](nodejs#14573)
* **Stream**
* For `Duplex` streams, the high water mark option can now be set
independently for the readable and the writable side.
[nodejs#14636](nodejs#14636)
* **Util**
* `util.format` now supports the `%o` and `%O` specifiers for printing
objects.
[nodejs#14558](nodejs#14558)
This applies parts of 1fe0741 that are
relevant to N-API.
PR-URL: nodejs#14811

Notable changes
* **HTTP2**
* Experimental support for the built-in `http2` has been added via the
`--expose-http2` flag.
[nodejs#14239](nodejs#14239)
* **Inspector**
* `require()` is available in the inspector console now.
[nodejs#8837](nodejs#8837)
* Multiple contexts, as created by the `vm` module, are supported now.
[nodejs#14465](nodejs#14465)
* **N-API**
* New APIs for creating number values have been introduced.
[nodejs#14573](nodejs#14573)
* **Stream**
* For `Duplex` streams, the high water mark option can now be set
independently for the readable and the writable side.
[nodejs#14636](nodejs#14636)
* **Util**
* `util.format` now supports the `%o` and `%O` specifiers for printing
objects.
[nodejs#14558](nodejs#14558)
This applies parts of 1fe0741 that are
relevant to N-API.
PR-URL: nodejs#14811

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.