-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

-1 hadoop1.0. The patch failed to compile against the hadoop 1.0 profile.

Hadoop QA
added a comment - 15/Aug/13 07:38 -1 overall . Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12598159/9232.txt
against trunk revision .
+1 @author . The patch does not contain any @author tags.
-1 tests included . The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 hadoop1.0 . The patch failed to compile against the hadoop 1.0 profile.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6758//console
This message is automatically generated.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Committed to 0.95 and trunk. This is enough to make javadoc and findbugs green again (the findbugs complaints are often noise but frequently enough, the complaint has some legitimacy – worth reviewing what is outstanding I'd say)

stack
added a comment - 15/Aug/13 16:00 Committed to 0.95 and trunk. This is enough to make javadoc and findbugs green again (the findbugs complaints are often noise but frequently enough, the complaint has some legitimacy – worth reviewing what is outstanding I'd say)