From dev-return-21012-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Thu Feb 23 06:32:13 2012
Return-Path:
X-Original-To: apmail-couchdb-dev-archive@www.apache.org
Delivered-To: apmail-couchdb-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
by minotaur.apache.org (Postfix) with SMTP id 2B4ED9D7A
for ; Thu, 23 Feb 2012 06:32:13 +0000 (UTC)
Received: (qmail 69533 invoked by uid 500); 23 Feb 2012 06:32:12 -0000
Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org
Received: (qmail 69479 invoked by uid 500); 23 Feb 2012 06:32:12 -0000
Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
List-Help:
List-Unsubscribe:
List-Post:
List-Id:
Reply-To: dev@couchdb.apache.org
Delivered-To: mailing list dev@couchdb.apache.org
Received: (qmail 69406 invoked by uid 99); 23 Feb 2012 06:32:10 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2012 06:32:10 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2012 06:32:09 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
by hel.zones.apache.org (Postfix) with ESMTP id 531D7336182
for ; Thu, 23 Feb 2012 06:31:49 +0000 (UTC)
Date: Thu, 23 Feb 2012 06:31:49 +0000 (UTC)
From: "Jason Smith (Commented) (JIRA)"
To: dev@couchdb.apache.org
Message-ID: <150729701.8589.1329978709341.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <1802917239.5090.1329933349086.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (COUCHDB-1416) the requested_path that is passed
to a show is wrong on a vhost with a path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
[ https://issues.apache.org/jira/browse/COUCHDB-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214371#comment-13214371 ]
Jason Smith commented on COUCHDB-1416:
--------------------------------------
Thanks, Ryan.
Hopefully this is a dupe of COUCHDB-981. Caolan?
Firstly, yours would be the first test in the entire JavaScript suite to use vhosts. I do not know if vhosts were avoided all this time by design or accident. I made a small change to your hostname guesser (window.location.host) and it works for me.
Next, this bugfix has a problem. CouchDB has an object, httpd{} which contains a Mochiweb object. Mochiweb is an upstream dependency. I thought this fix would happen by adding a a #httpd.requested_path however all the vhost/rewrite code works exclusively with mochiweb.
So the question is how to remember state through all possible processing of a MochiReq.
> the requested_path that is passed to a show is wrong on a vhost with a path
> ----------------------------------------------------------------------------
>
> Key: COUCHDB-1416
> URL: https://issues.apache.org/jira/browse/COUCHDB-1416
> Project: CouchDB
> Issue Type: Bug
> Components: HTTP Interface
> Affects Versions: 1.2
> Reporter: Ryan Ramage
> Priority: Minor
>
> In a show or list, it is impossible to construct a full url that an end user could use to re-request the resource, given the various combinations of vhosts and rewrites.
> The major one is if the vhost contains a path component, this path information is not passed to the show at all.
> I have created three tests that highlight the condition, currently failing for one test, with the two passing to prevent regressions.
> The commit can be found here:
> https://github.com/ryanramage/couchdb/commit/e9417480e2ce160f359d9508dcec3d4e56045a60
> I have talked this over with JasonSmith and bennoitc on #couchdb and they asked me to write the tests and raise the jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira