Test failure org.apache.hadoop.mapred.TestKillSubProcesses.testJobKillFailAndSucceed is due to MAPREDUCE-408
-1 release audit. is because of jdiff files.
-1 contrib tests. Is known issue (MAPREDUCE-699)

Could you see if you can have the mapred.FileSplit class extend mapreduce.FileSplit so that you could refactor NLineInputFormat implementation to avoid code duplication.

The changes to TextInputFormat and SequenceFileInputFormat to check for compression can possibly be reverted. I feel the old code is both more readable and faster – they avoid method calls if the compression is not turned on.

Jothi Padmanabhan
added a comment - 31/Jul/09 08:24 Looks good. A few comments
Could you see if you can have the mapred.FileSplit class extend mapreduce.FileSplit so that you could refactor NLineInputFormat implementation to avoid code duplication.
The changes to TextInputFormat and SequenceFileInputFormat to check for compression can possibly be reverted. I feel the old code is both more readable and faster – they avoid method calls if the compression is not turned on.