Andrew Wang
added a comment - 10/Jul/12 19:13 That logging is split across two classes, changed both to DEBUG. Tested by adding the following lines to log4j.properties, seeing them at debug on namenode startup:
log4j.logger.org.apache.hadoop.hdfs.server.blockmanagement=DEBUG
log4j.logger.org.apache.hadoop.hdfs.util=DEBUG

This looks good, just one nit: Please wrap all LOG.debug performing lines under an {{if (LOG.isDebugEnabled()) { }}} check, to stay consistent with the rest of the code base (it is for a performance reason, check out HADOOP-6884 if you want to have some historical reading).

Harsh J
added a comment - 10/Jul/12 19:19 Thanks Andrew!
This looks good, just one nit: Please wrap all LOG.debug performing lines under an {{if (LOG.isDebugEnabled()) { }}} check, to stay consistent with the rest of the code base (it is for a performance reason, check out HADOOP-6884 if you want to have some historical reading).

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

Hadoop QA
added a comment - 10/Jul/12 22:54 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535914/hdfs-3613-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2777//console
This message is automatically generated.