In general, also see [[Development Resources#Users: Contributing To A Project]].

=== Using Gerrit ===

=== Using Gerrit ===

Line 51:

Line 64:

Attach the patch(es) to the bug/enhancement in Bugzilla. The patch should be in the format produced by <tt>git format-patch</tt>, so that it is suitable for <tt>git am</tt>.

Attach the patch(es) to the bug/enhancement in Bugzilla. The patch should be in the format produced by <tt>git format-patch</tt>, so that it is suitable for <tt>git am</tt>.

−

−

=== Legal Paperwork ===

−

−

With the contribution, you will have to include answers to the following questions (e.g. as comment in Gerrit or Bugzilla):

−

−

# Did you author 100% of the content you are contributing?

−

# Who owns the copyright of the contributed content? (This is typically your employer.)

−

# Is the contributed code licensed under the EPL? (You should answer this question by putting a [http://www.eclipse.org/legal/copyrightandlicensenotice.php copyright and license header] into every new java file.)

−

# Do you have the right to contribute the content to Eclipse? (You need to confirm this with the copyright owner.)

−

−

With these questions answered, we will be able to accept small patches (<250 LoC) immediately. For larger patches, we will also have to create a contribution questionnaire for review by the Eclipse IP team, but this usually doesn't require additional actions from you.

−

−

In general, also see [[Development Resources#Users: Contributing To A Project]].

Revision as of 07:33, 14 October 2013

Contents

Starting a Contribution

Before starting to develop an enhancement or fix for Tycho, it is important that you get in touch with the project. We track ideas for enhancements and bug reports in the Eclipse Bugzilla, so this is a good place to present your ideas for a patch and to make sure it's going in the right direction.

If you want to do an enhancement but don't know where to start, you can also just ask on tycho-dev@eclipse.org.

Developing Patches for Tycho

The technical basics (how to get the sources, how to import and build, etc.) are described here: Developing Tycho .

Unless the patch is really trivial, make sure you include at least one test case that reproduces the bug or proves that the enhancement works.

Note that if you don't provide any tests, we will not take the contribution.

Writing Tests

Tycho has two types of tests: unit tests (locally in each module) and a global integration test suite in module tycho-its.

Unit tests are preferred if possible because they are in general much faster and better targeted at the functionality under test.
Integration tests generally invoke a forked maven build on a sample project (stored under projects/) and then do some assertions on the build output.

Commit Granularity

Make small commits, yet self-contained commits. This makes them easy to review.

Do not mix concerns in commits: have a commit do a single thing. This makes them reviewable 'in isolation'. This is particularly important if you need to do refactorings to the existing code: Refactorings tend to lead to large diffs which are difficult to review. Therefore make sure to have separate commits for refactorings and for functional changes.

Contributing the Patch

Legal Paperwork

Before your contribution can be accepted by the project, you need to create and
electronically sign the Eclipse Foundation Contributor License Agreement (CLA) and sign
off on the Eclipse Foundation Certificate of Origin.