Re: Problem with GUI

From:

Nicola Pero

Subject:

Re: Problem with GUI

Date:

Tue, 23 Nov 2010 11:18:42 +0100 (CET)

> So, what can we do to make this disruptive behaviour stop ? It's
> exasperating.
Having briefly looked at David's latest changes, it's worse than just missing
ChangeLog entries:
* FSF/LGPL copyright headers are missing in new files. I even wonder if the
copyright was
assigned to the FSF or not, and obviously if the files are LGPL like the rest
(this is critically
important)
* the indentation follows a different standard (which means that Richard will
have to waste
time reindenting the new file to be the same as everything else)
* the headers lack the usual #include guards that allow them to work no matter
if #import or
#include is used (if we decide we don't want the #include guards, we should
remove them everywhere,
not just in one file, and it's a separate change that needs a separate
discussion)
Do we need a "code review" step where every change is reviewed by Richard
before being applied
to gnustep-base ? He can make sure that our coding standards are followed.
But it seems a bit of
an annoyance for our normal, regular contributors who do follow the coding
standards.
Thanks