tgnit: as for value_t, I'm much more familiar with the regression tests than the unit test.... why are you asking if you should try that in particular? I'm generally fine with you adding any tests you find useful.

tgnit: (re putting value.cc tests under math tests) Yeah, I'm not completely sure about the unit test structure. johnw is definitely the one to ask. If he's not around, I'd suggest submitting it that way in the PR and note that you weren't sure, and he'll tell you if it belongs somewhere else.

tgnit: It seems that at least 10 have been accepted upstream, but I'd really prefer if you could get all 35 you write accepted upstream -- particularly figuring out why your equity test fails for everyone else but you.