Prior to this patch, TBA was showing all onion services as SSL/TLS
encrypted connections(lock icon).
This patch fixes the issue adding several new Onion icons to indicate
all the various permutations of the Onions services hosted HTTP or HTTPS
pages.

I feel like "onion_active" doesn't describe the state well. Can we call it onion_lock (or something similar)? When I see IconType.ONION_ACTIVATE in the code, I don't immediately remember what that means. I think IconType.ONION_LOCK be a little better. And maybe the icons that don't contain locks shouldn't have "lock" in their name? Thoughts?

I feel like "onion_active" doesn't describe the state well. Can we call it onion_lock (or something similar)? When I see IconType.ONION_ACTIVATE in the code, I don't immediately remember what that means. I think IconType.ONION_LOCK be a little better. And maybe the icons that don't contain locks shouldn't have "lock" in their name? Thoughts?

antonela: I felt the onion icon (not the one for extended validation nor the one showing insecure content) was too big. Compared to the desktop, where the icon stays the same size-wise compared to the lock icon, the onion icon seems to get bigger on mobile. Could we fix that or do you want to leave it as-is?

antonela: I felt the onion icon (not the one for extended validation nor the one showing insecure content) was too big. Compared to the desktop, where the icon stays the same size-wise compared to the lock icon, the onion icon seems to get bigger on mobile. Could we fix that or do you want to leave it as-is?

I just tested the .apk and yes is big. The size should be the same size we have at the lock icon (24px). If we can fix it, would be awesome.

antonela: I felt the onion icon (not the one for extended validation nor the one showing insecure content) was too big. Compared to the desktop, where the icon stays the same size-wise compared to the lock icon, the onion icon seems to get bigger on mobile. Could we fix that or do you want to leave it as-is?

I just tested the .apk and yes is big. The size should be the same size we have at the lock icon (24px). If we can fix it, would be awesome.

Igt0 let me know if you need any asset.

I see the SVG used in #23247 is 16x16 (by default?), but the PNG used here is showing as 36x36.

FWIW: I found a fun bug while testing (thinking first it is related to this patch) where the security state is vanishing while a download is happening if one clicks on the lock icon. But that's actually a Fennec issue which is tracked in ​https://bugzilla.mozilla.org/show_bug.cgi?id=1511003.