Hi Markus,
On Fri, 2011-04-22 at 19:29 +0200, Markus Mohrhard wrote:
> Hello Kohei,
>> yes you're right. This part was copied from another method and I
> didn't notice it. But I don't think that you must check for
> ScDocShell, because the whole class is build without any check for it.
Agreed. The chances of pDocShell being NULL there are next to nothing,
so it's probably fine not checking its value. I wouldn't either.
> Should I send a reworked patch?
Nah. Don't bother. ;-) It's not that big deal anyway.
Thanks.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>