You don't use ls in a script (don't parse ls), so that function will only be used by you in an interactive shell. Nothing to watch out for. Aside from adding double quotes around "$@", that's the best way to do it.