Details

This change removes old and increasingly useless JAVA_HOME autodetection that looks for Java 6 runtimes in various locations. Ensure that JAVA_HOME is correctly set in the environment before launching HBase daemons.

Description

Allen Wittenauer mentioned on Twitter that the old JAVA_HOME autodetection script we have in hbase-config.sh is very unlikely to do the right thing now. Rip it out.

Esteban Gutierrez
added a comment - 17/Jul/14 05:49 What about using the same script from Bigtop? https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

Hadoop QA
added a comment - 17/Jul/14 06:22 -1 overall . Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12656230/HBASE-11534.patch
against trunk revision .
ATTACHMENT ID: 12656230
+1 @author . The patch does not contain any @author tags.
-1 tests included . The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch . The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10105//console
This message is automatically generated.

FWIW, I'm a big fan of "Let the installer figure this out." i.e., this is one place where having a distribution (bigtop or otherwise) is ideal because they can get away with taking a lot of time to configure and tune the system as a one-time operation. Taking the hit every time is...excessive.

Allen Wittenauer
added a comment - 17/Jul/14 14:54 FWIW, I'm a big fan of "Let the installer figure this out." i.e., this is one place where having a distribution (bigtop or otherwise) is ideal because they can get away with taking a lot of time to configure and tune the system as a one-time operation. Taking the hit every time is...excessive.
Anyway, kudos for fixing this.

+1 Lars Hofhansl and I'd say we should have it only for 0.99 and trunk. I think is too late for this change in 0.98.x and 0.96.x. Also we need to make sure that the release notes consider this as an major change that might break some environments if JAVA_HOME is not defined.

Esteban Gutierrez
added a comment - 18/Jul/14 17:14 +1 Lars Hofhansl and I'd say we should have it only for 0.99 and trunk. I think is too late for this change in 0.98.x and 0.96.x. Also we need to make sure that the release notes consider this as an major change that might break some environments if JAVA_HOME is not defined.