GnomeWorks TradeSkill Frame

427 - Queue doesn't update when crafting materials are collected from the bank

Potential bug fix for:
The Queue window does not update correctly when crafting materials are collected from the bank.

Example:
In the main window click QUEUE to craft an item that has materials in the bank.
Minor Glyph of Porcupine is selected and QUEUE is clicked.
The Queue window shows there are 10 Stranglekelp in the bank.
Go to then bank, talk to the teller and open the bank bags.
Click on the Queue window Reagent line "bank" -or- reagent line "Stranglekelp" and the materials are collected from the bank into your inventory bags.
The Reagent window will incorrectly show
Vendor
3 Midnight Ink
Missing
3 Ink of Dreams.

The workaround was to clear the queue then requeue the Glyph with the materials in inventory. It would progress to the next step of milling the herbs.

*** Here is a potential fix that needs verified: ***

Queue.lua line 318
Comment out "Return 0"
from
if not reagentsChanged then
AddItemsToShoppingList(player, entry)
Return 0
end
to
if not reagentsChanged then
AddItemsToShoppingList(player, entry)
-- Return 0
end

Now when materials are collected from the bank the Queue window correctly updates to
[Process Mill Stranglekelp x 2]

- What is the nature of the defect?+ Potential bug fix for:
The Queue window does not update correctly when crafting materials are collected from the bank.
+ Example:- What (if anything) triggers the defect? (happens when loading, when activating the mod, when clicking a particular button, etc)- Collecting materials from the bank does not update the Queue window to progress to the next step in the crafting process.-
In the main window click QUEUE to craft an item that has materials in the bank.
- Example: QUEUE Minor Glyph of Porcupine. Queue window shows there are 10 Stranglekelp in the bank.+ Minor Glyph of Porcupine is selected and QUEUE is clicked.+ The Queue window shows there are 10 Stranglekelp in the bank.
Go to then bank, talk to the teller and open the bank bags.
Click on the Queue window Reagent line "bank" -or- reagent line "Stranglekelp" and the materials are collected from the bank into your inventory bags.
- The Reagent window now incorrectly shows+ The Reagent window will incorrectly show
Vendor
3 Midnight Ink
Missing
3 Ink of Dreams.
The workaround was to clear the queue then requeue the Glyph with the materials in inventory. It would progress to the next step of milling the herbs.
- *** Potential fix that needs verified: ***+ *** Here is a potential fix that needs verified: ***
Queue.lua line 318
Comment out "Return 0"

*** Potential fix that needs verified: ***
Queue.lua line 318
- Remove or Comment out "Return 0"+ Comment out "Return 0"
from
if not reagentsChanged then
AddItemsToShoppingList(player, entry)
----------------------------------------
to
if not reagentsChanged then
AddItemsToShoppingList(player, entry)
+ -- Return 0
end
Now when materials are collected from the bank the Queue window correctly updates to

i've tried to make the queue not recalculate too frequently, but still present up to date information. it could be that it doesn't recalculate properly after collecting the bank items. possible tests would be to do other manipulations to the queue adding items, adjust counts, selecting different sources. see if any of those result in proper recalculation.