hbase-issues mailing list archives

[jira] [Commented] (HBASE-6323) [replication] most of the source metrics are wrong when there's multiple slaves

Date

Tue, 03 Jul 2012 22:14:34 GMT

[ https://issues.apache.org/jira/browse/HBASE-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406107#comment-13406107
]
Elliott Clark commented on HBASE-6323:
--------------------------------------
bq.I'm not sure what's the right way to fix this since we can't have dynamic metrics
We can. They are just annoying to make. But I think something like what we have with regions
is probably the right thing. A dynamic set for every source and a rollup.
> [replication] most of the source metrics are wrong when there's multiple slaves
> -------------------------------------------------------------------------------
>
> Key: HBASE-6323
> URL: https://issues.apache.org/jira/browse/HBASE-6323
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Elliott Clark
> Fix For: 0.96.0, 0.94.2
>
>
> Most of the metrics in replication were written with 1 slave in mind but with multiple
slaves the issue really shows. Most of the metrics are set directly:
> {code}
> public void enqueueLog(Path log) {
> this.queue.put(log);
> this.metrics.sizeOfLogQueue.set(queue.size());
> }
> {code}
> So {{sizeOfLogQueue}} is always showing the size of the queue that updated the metric
last.
> I'm not sure what's the right way to fix this since we can't have dynamic metrics. Merging
them would work here but it wouldn't work so well with {{ageOfLastShippedOp}} since the age
can be different and it definitely cannot be summed.
> Assigning to Elliott since he seems to dig metrics these days.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira