On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> Also, when sending an update, it is customary to add v2 to the subject so> people can see which version is the latest one. You can do that by calling> git send-email -v2 # Since git 1.8.x> or> git send-email --subject-prefix='PATCH v2'>
It seems, that the above should be applied to git format-patch, not
git send-email?

On 26/10/13 09:33, Wojciech Zabolotny wrote:
> On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:>>> Also, when sending an update, it is customary to add v2 to the subject so>> people can see which version is the latest one. You can do that by calling>> git send-email -v2 # Since git 1.8.x>> or>> git send-email --subject-prefix='PATCH v2'>>>> It seems, that the above should be applied to git format-patch, not> git send-email?
You're right, but git send-email takes (almost) all of the options of
git format-patch if you let it generate patches directly (e.g. with 'git
send-email -1). Normally I don't bother with generating the patches
separately and just mail them immediately - and I assumed that the rest
of the world does the same :-).
Regards,
Arnout

Hi Arnout,
On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:
> On 26/10/13 09:33, Wojciech Zabolotny wrote:> >On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:> >> Also, when sending an update, it is customary to add v2 to the subject > >> so> >>people can see which version is the latest one. You can do that by calling> >>git send-email -v2 # Since git 1.8.x> >>or> >>git send-email --subject-prefix='PATCH v2'> >> >It seems, that the above should be applied to git format-patch, not> >git send-email?> > You're right, but git send-email takes (almost) all of the options> of git format-patch if you let it generate patches directly (e.g.> with 'git send-email -1). Normally I don't bother with generating> the patches separately and just mail them immediately - and I> assumed that the rest of the world does the same :-).
How do you add patch version changelog then?
baruch

On 28/10/13 09:10, Baruch Siach wrote:
> Hi Arnout,>> On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:>> On 26/10/13 09:33, Wojciech Zabolotny wrote:>>> On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:>>>> Also, when sending an update, it is customary to add v2 to the subject>>>> so>>>> people can see which version is the latest one. You can do that by calling>>>> git send-email -v2 # Since git 1.8.x>>>> or>>>> git send-email --subject-prefix='PATCH v2'>>>>>> It seems, that the above should be applied to git format-patch, not>>> git send-email?>>>> You're right, but git send-email takes (almost) all of the options>> of git format-patch if you let it generate patches directly (e.g.>> with 'git send-email -1). Normally I don't bother with generating>> the patches separately and just mail them immediately - and I>> assumed that the rest of the world does the same :-).>> How do you add patch version changelog then?
Manually with git commit --amend.
There is no way AFAIK to ensure consistency between the patch changelog
and the -v option you pass to send-email/format-patch. There are a few
tools like topgit and guilt that are supposed to make it easier to manage
a patch with changelog, but I found them difficult to use.
Regards,
Arnout

Hi Arnout,
On Mon, Oct 28, 2013 at 09:24:59AM +0100, Arnout Vandecappelle wrote:
> On 28/10/13 09:10, Baruch Siach wrote:> >On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:> >>On 26/10/13 09:33, Wojciech Zabolotny wrote:> >>>On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:> >>>> Also, when sending an update, it is customary to add v2 to the subject> >>>> so> >>>>people can see which version is the latest one. You can do that by calling> >>>>git send-email -v2 # Since git 1.8.x> >>>>or> >>>>git send-email --subject-prefix='PATCH v2'> >>>> >>>It seems, that the above should be applied to git format-patch, not> >>>git send-email?> >>> >> You're right, but git send-email takes (almost) all of the options> >>of git format-patch if you let it generate patches directly (e.g.> >>with 'git send-email -1). Normally I don't bother with generating> >>the patches separately and just mail them immediately - and I> >>assumed that the rest of the world does the same :-).>> >How do you add patch version changelog then?> > Manually with git commit --amend.
But with 'commit --amend' you can only edit the log message itself, not the
part below the '---' separator where patches changelog usually go.
baruch
> There is no way AFAIK to ensure consistency between the patch> changelog and the -v option you pass to send-email/format-patch.> There are a few tools like topgit and guilt that are supposed to> make it easier to manage a patch with changelog, but I found them> difficult to use.

On 28/10/13 09:40, Baruch Siach wrote:
> Hi Arnout,>> On Mon, Oct 28, 2013 at 09:24:59AM +0100, Arnout Vandecappelle wrote:>> On 28/10/13 09:10, Baruch Siach wrote:>>> On Mon, Oct 28, 2013 at 08:12:21AM +0100, Arnout Vandecappelle wrote:>>>> On 26/10/13 09:33, Wojciech Zabolotny wrote:>>>>> On Sat, Oct 26, 2013 at 1:41 AM, Arnout Vandecappelle <arnout@mind.be> wrote:>>>>>> Also, when sending an update, it is customary to add v2 to the subject>>>>>> so>>>>>> people can see which version is the latest one. You can do that by calling>>>>>> git send-email -v2 # Since git 1.8.x>>>>>> or>>>>>> git send-email --subject-prefix='PATCH v2'>>>>>>>>>> It seems, that the above should be applied to git format-patch, not>>>>> git send-email?>>>>>>>> You're right, but git send-email takes (almost) all of the options>>>> of git format-patch if you let it generate patches directly (e.g.>>>> with 'git send-email -1). Normally I don't bother with generating>>>> the patches separately and just mail them immediately - and I>>>> assumed that the rest of the world does the same :-).>>>>> How do you add patch version changelog then?>>>> Manually with git commit --amend.>> But with 'commit --amend' you can only edit the log message itself, not the> part below the '---' separator where patches changelog usually go.
Sure you can. The --- separator is only interpreted by git-am (well,
actually the plumbing tool that is called by git-am). So you can update
the things below the --- separator while doing git commit --amend or git
rebase -i.
Regards,
Arnout