On Fri, Mar 4, 2011 at 8:37 PM, Ralf Gommers <ralf.gommers@googlemail.com>wrote:
> On Fri, Mar 4, 2011 at 5:00 PM, Christoph Gohlke <cgohlke@uci.edu> wrote:
> >
> >
> > On 3/3/2011 10:54 PM, Ralf Gommers wrote:
> >> Before the first beta can be released I think #1748 should be fixed.
> >> Before the first RC the Solaris segfaults should be investigated, and
> >> documentation for the new iterator (Python docstrings and C API docs)
> >> and datetime should be written.
> >>
> >> Also, some testing on 64-bit Windows would be great, that usually
> >> turns up new issues so the sooner the better.
> >>
> >> Ralf
> >
> > Hi Ralf,
> >
> > the numpy master branch on github can not be compiled with Visual Studio.
> A
> > patch is attached. I'll test the builds tomorrow.
>> That looks fine to me, but I'll leave it to someone more familiar with
> that code to commit it.
>> I'm also wondering whether the printf debug code should not be removed
> completely. Either way, using variadic macros is not a good idea I
> think, since that's a C99 feature which seems to not be supported well
> by non-gcc compilers.
>
If the approach to fixing it in the patch works, I'd like to keep the debug
prints in. They don't affect run time, and can be useful to figure out where
something is first deviating from the expected behavior when dealing with
subtle bugs.
-Mark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/numpy-discussion/attachments/20110305/e1cd10c0/attachment-0001.html