Owen O'Malley
added a comment - 22/Apr/10 22:48 Two comments:
1. Don't bother with useSasl and just use useWrap. useWrap implies useSasl.
2. I don't think you correctly handle the case of pings when useWrap is true.

Devaraj Das
added a comment - 23/Apr/10 01:40 In response to Owen's comment (2), the case of pings when useWrap is true is handled within processUnwrappedData (since the Pings are also wrapped and sent from the client)

Devaraj Das
added a comment - 04/Jun/10 20:20 Some nits:
1) The configuration hadoop.rpc.protection is missing from core-default.xml
2) The if statements
if (dataLength == Client.PING_CALL_ID) {
if(!useWrap) {
can be combined into a single statement.