As the developers of Open Journal Systems, Open Conference Systems, Open Harvester Systems, and Open Monograph Press, the PKP team are experts in helping journal managers and conference organizers make the most of their online publishing projects. PKP Publishing Services offers support for:

As a customer of PKP Publishing Services, you will not only receive direct, personalized support from the PKP Development Team, but will be contributing to the ongoing development of the PKP applications. All funds raised by PKP Publishing Services go directly toward enhancing our free, open source software. For more information, please contact us.

Hi all, I'm quite new to OJS and a newbie on this forum, so don't shoot me right away . The problem I'm having is with the PDF embedding in the 2.3.3-1 release. It doesn't work (well not without some changes). Having some experience with developing, I tried to find out the problem and I think I found it, but couldn't resolve it properly yet. Maybe some of you can help out?

The problem is to be found in /templates/article/article.tpl from line 19-39.

What I've already found out, is that the problem probably is to probably to be found in a syntax error after line 22. Because after some fiddling with the syntax I found out that the following syntax, where I filled in the variables $pdfUrl and $noPluginText and removed all literal-tags after the closing of the object-tag on line 22, actually works:

Happy to have you on board and contributing to the project! Could you give us a bit more detail on what the problem is exactly -- that is, are you experiencing a display problem, and if so in which browser(s)? I did some of the cross-browser testing of the new display, and managed to catch some (but probably not all) display bugs; if you could give us more detail on what the problem is, we can help work towards a solution.

Yes, please let us know what the exact problem with Safari you were seeing was. I'm not sure why your changes would have fixed any issues.. those variables should be filled out (and the literal tags removed) before they hit the browser. The side effect of your change is that the 'noPluginText' variable won't be translated (if you're using more than one locale on your site), and the PDF embedder will only be able to show one PDF (!). Are you sure you have PDF plugins installed for Firefox and IE?

Thanks for your replies, and sorry that I'm answering them rather late (was kind of busy with some other stuff).Well, I've tweaked the code a little more and now it works on every browser (with it's PDF plugin correctly installed, that is ). But let's start at the beginning: The problem was that, even with a PDF plugin correctly installed, when choosing to view a PDF it immediately showed the $noPluginText-message instead of a browser-embedded PDF. Whereas in other websites using PDFObject, embedding worked perfectly.After some trial and error I found out that the problem should be in the script embedding the PDF (found in /templates/article/article.tpl from line 19-39). The tweak I made earlier was indeed wrong and kept showing the same PDF, but at least the embedding worked. Adding the '{/literal}{$pdfUrl}{literal}' back at line 31 and using my own localization (we mainly use Dutch) on line 28, every now works as it should.What is changed from the original code then? Well, at this moment I only left out the literal-calling of $noPluginText at line 28. This is the actual result:

As far as I can think the problem lies in the calling or definition of $noPluginText?BTW: is it correct that in the aforementioned script, before the closing of the object-tag, you first call the, apparently non-defined, $noPluginKey instead of the defined $noPluginText?

Are you saying that the article is embedded only when you change line 28 from $("#articlePdf").html('{/literal}{$noPluginText}{literal}'); to $("#articlePdf").html('{$noPluginText}');? I think it should probably work either way, but it should definitely work with the {literal} tags there. Would you be able to try again, with the fix from the bug report above in place (i.e. change that call to 'noPluginKey' to 'noPluginText')?

Embedding: I know it doesn't make any sense, but the only way I get the embedding to work is to avoid the call to $noPluginText. Either by maintaining the typo (on line 22) or by filling in my own locale-version (on line 28). I just can't make any sense out of it.