Comments

patman shouts when it couldn't find a $(HOME)/.config/patman file.
Handle it in a sane way by creating a new one for the user.
It looks for a user.name and user.email in the global .gitconfig
file, waits for the user input if it can't find those.
Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
---
tools/patman/gitutil.py | 18 ++++++++++++++++++
tools/patman/settings.py | 34 +++++++++++++++++++++++++++++++---
2 files changed, 49 insertions(+), 3 deletions(-)

Dear Vikram & Simon,
In message <4F9ACBD1.1080003@gmail.com> you wrote:
> > patman shouts when it couldn't find a $(HOME)/.config/patman file.> Handle it in a sane way by creating a new one for the user.> It looks for a user.name and user.email in the global .gitconfig> file, waits for the user input if it can't find those.
I have a more general question here: Why is the config file in
$(HOME)/.config/patman (instead for example $(HOME)/.patman) ?
My understanding is that $(HOME)/.config/ is defined by the XDG Base
Directory Specification - but patman has nothign to do with the X11
desktop - or has it?
Best regards,
Wolfgang Denk

Hello Wolfgang,
On 4/30/2012 2:14 PM, Wolfgang Denk wrote:
> Dear Vikram& Simon,>> In message<4F9ACBD1.1080003@gmail.com> you wrote:>>>> patman shouts when it couldn't find a $(HOME)/.config/patman file.>> Handle it in a sane way by creating a new one for the user.>> It looks for a user.name and user.email in the global .gitconfig>> file, waits for the user input if it can't find those.>> I have a more general question here: Why is the config file in> $(HOME)/.config/patman (instead for example $(HOME)/.patman) ?>> My understanding is that $(HOME)/.config/ is defined by the XDG Base> Directory Specification - but patman has nothign to do with the X11> desktop - or has it?
Your argument is right. But Simon is the right person for answering this
as he is the one who pushed patman.
Regards,
Vikram

Hi Wolfgang, Vikram,
On Mon, Apr 30, 2012 at 6:37 AM, Vikram Narayanan <vikram186@gmail.com>wrote:
> Hello Wolfgang,>> On 4/30/2012 2:14 PM, Wolfgang Denk wrote:>>> Dear Vikram& Simon,>>>>>> In message<4F9ACBD1.1080003@**gmail.com <4F9ACBD1.1080003@gmail.com>>>> you wrote:>>>>>>>> patman shouts when it couldn't find a $(HOME)/.config/patman file.>>> Handle it in a sane way by creating a new one for the user.>>> It looks for a user.name and user.email in the global .gitconfig>>> file, waits for the user input if it can't find those.>>>>>>> I have a more general question here: Why is the config file in>> $(HOME)/.config/patman (instead for example $(HOME)/.patman) ?>>>> My understanding is that $(HOME)/.config/ is defined by the XDG Base>> Directory Specification - but patman has nothign to do with the X11>> desktop - or has it?>>>> Your argument is right. But Simon is the right person for answering this> as he is the one who pushed patman.>
I agree also, it was an attempt to reduce clutter in home but I agree that
.patman is more correct.
Vikram, let me check your series again and then would you mind inserting a
patch to change this at the start of your series?
> Regards,> Vikram>
Regards,
Simon

On 4/30/2012 11:07 PM, Simon Glass wrote:
> Hi Vikram,>> On Fri, Apr 27, 2012 at 9:39 AM, Vikram Narayanan <vikram186@gmail.com> <mailto:vikram186@gmail.com>> wrote:>>> patman shouts when it couldn't find a $(HOME)/.config/patman file.> Handle it in a sane way by creating a new one for the user.> It looks for a user.name <http://user.name> and user.email in the> global .gitconfig> file, waits for the user input if it can't find those.>> Signed-off-by: Vikram Narayanan <vikram186@gmail.com> <mailto:vikram186@gmail.com>>> Cc: Simon Glass <sjg@chromium.org <mailto:sjg@chromium.org>>>>> Acked-by: Simon Glass <sjg@chromium.org <mailto:sjg@chromium.org>>>> In terms of changing the config file to ~/.patman, this could actually> be a subsequent patch if you like. But there are a few nits below if you> re-issue.>
I feel that can be dealt in a separate patch which follows this. For the
few nits, I'll send a v3 _only_ for this patch and not for the whole
series as the other two are ACK'ed and one is decided not to be ACK'ed.
Thanks,
Vikram