Details

Description

Currently the user need to make sure that a direct source is not shared between threads and each time someone calls getDirectSource we create a new source which has a reasonable overhead. We can certainly reduce the overhead (maybe different issue) but it should be easier for the user to get a direct source and handle it. More than that is should be consistent with getSource / loadSource.

Robert Muir
added a comment - 05/Nov/12 13:40 I haven't looked in detail (will try to do a real review later) but I think something like this is really needed.
Its currently absurd: we make it easy as pie to load up enormous data structures in RAM but nearly impossible to use stuff from disk.
It should be the other way around.
We can certainly reduce the overhead (maybe different issue)
We should do this too!

here is a new patch makeing the loadSource & loadDirectSource protected. This is really confusing if you have two ways to get a Source instance and you need to take care of if it is cached or not. This really should not have been public at all.

Simon Willnauer
added a comment - 06/Nov/12 13:18 here is a new patch makeing the loadSource & loadDirectSource protected. This is really confusing if you have two ways to get a Source instance and you need to take care of if it is cached or not. This really should not have been public at all.
I will commit this soon