Fix MASTER_SITES:n usage so that the ":n" postfix is added
to *all* elements of MASTER_SITE_LOCAL, not just the final
one. To observe the difference, run the following command
while inside the port's dir before and after applying the
patch:
% make -V MASTER_SITES

TMTOWTDI. Your solution looks fine to me, and I don't really care which
approach is taken (the ":n" usage is perfectly clear to me), as long as
the problem is fixed. The maintainer shall decide.
--
Sahil Tandon <sahil@FreeBSD.org>

Sahil Tandon <sahil@FreeBSD.org> writes:
> TMTOWTDI. Your solution looks fine to me, and I don't really care which
> approach is taken (the ":n" usage is perfectly clear to me), as long as
> the problem is fixed. The maintainer shall decide.
What I meant is it's less confusing than having unused[*] qemu/:release
in MASTER_SITE_SUBDIR. And since it's unused your patch is just a no-op.
[*] `make -V MASTER_SITES' wouldn't show it

"Anonymous", thanks for your clarification.
On Sun, 2010-10-24 at 11:41:23 +0400, Anonymous wrote:
> What I meant is it's less confusing than having unused[*] qemu/:release
> in MASTER_SITE_SUBDIR. And since it's unused your patch is just a no-op.
I do not share your confusion with the original patch, which pertains to
the propagation of the ":snapshot" suffix to all elements of
MASTER_SITE_LOCAL; furthermore, `make -V MASTER_SITES' before and after
application of the patch *would* show difference.
> [*] `make -V MASTER_SITES' wouldn't show it
My patch has nothing to do with ":release" so yes, it would not show
what you are talking about, but - again - that is not the issue I was
addressing. I'm simply trying to bring attention to the fact that the
":snapshot" postfix was not being properly affixed to all sites. Just
because the snapshot MASTER_SITEs are not being used (since DISTFILES
only corresponds with ":release" archives) is not relevant to me. If you
review the history of this Makefile, you'll see this situation is a
result of a previous commit by the maintainer (from r1.104 -> 1.105)
that switched from using snapshot -> release DISTFILE, but explicitly
retained the snapshot-related MASTER_SITE entries.
Finally, now that the issue has been brough to nox's attention, he's
well-equipped to handle it how he wants. Perhaps he will decide to just
remove all mention of ":snapshot"! :)
--
Sahil Tandon <sahil@FreeBSD.org>