Force deletetion of ChromeStorageImpl on the main thread.

Comments

Force deletetion of ChromeStorageImpl on the main thread.
With https://chromium-review.googlesource.com/997892, a task posted
via base::PostTaskWithTraitsAndReplyWithResult() can be deleted on the
sequence on which it was supposed to run if it can't run because of its
shutdown behavior.
The constructor of AddressNormalizerImpl uses
base::PostTaskWithTraitsAndReplyWithResult() to post a task to which
a ChromeStorageImpl is bound. If the task runs before shutdown, the
ChromeStorageImpl is returned to
...skip...
en ~ChromeStorageImpl tries to remove itself
from the observer list of its WriteablePrefStore.
To fix this race, this CL uses base::OnTaskRunnerDeleter() to
ensure that the deletion of ChromeStorageImpl occurs on the right
sequence.
Bug: 829122
Change-Id: I75ba8eab4a884b0f1ac5e571eaaab18f63599d6b
Reviewed-on: https://chromium-review.googlesource.com/1005915
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549682}

DevTools: set highlighter type on binding change

Comments

DevTools: set highlighter type on binding change
This gets the highlighter type from the network UISourceCode, if it
exists. For overrides files with no extension, they will stay colorful
as long as they are bound.
Change-Id: I5f1ff41f54eabb7a7f1abf1aa27b19629529fbfd
Reviewed-on: https://chromium-review.googlesource.com/1003875
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549683}

Don't render custom icon in incognito on Windows

Comments

Don't render custom icon in incognito on Windows
Prevents popup favicon and Developer Tools window Icon from being
rendered on top of the incognito badge. Drawing the icon next to the
incognito badge was also tested but looked weird (like double icons).
The favicon / Developer Tools icon is still the icon used in the
Windows window switcher and not the incognito badge.
Bug: chromium:829724
Change-Id: Ie850cec31d51e808ad718ba96e32eac6b0942158
Reviewed-on: https://chromium-review.googlesource.com/1003378
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549686}

Replaced casting with ObjCCastStrict<> to avoid crashes.

Comments

Replaced casting with ObjCCastStrict<> to avoid crashes.
ObjCCastStrict<> returns nil if the object being casted is not of the
expected type. This offers a saner behavior when for whatever reasons
object is not of the expected type.
This is a workaround to avoid a growing crash in iOS 11.3 when an
object of UIView type is casted to one of CardView type. A later call
to -closeButtonFrame results in an exception (crash).
Bug: 393230
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6a3f2b66c4ab6a8f268743e1ce8c902ccffaaa05
Reviewed-on: https://chromium-review.googlesource.com/1005562
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549688}