Comments

The New Hotness of fq_codel wants bql support, but my WAN link is on my
Old And Busted tulip card, which lacks it.
It's just a few lines, but the important thing is knowing where to
put them, and I've sort of guessed. In particular, it seems like the
netdev_sent_queue call could be almost anywhere in tulip_start_xmit and
I'm not sure if there are reasons to prefer any particular position.
(You may have my S-o-b on copyright grounds, but I'd like to test it
some more before declaring this patch ready to be merged.)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Fri, 2013-07-12 at 09:20 -0400, George Spelvin wrote:
> The New Hotness of fq_codel wants bql support, but my WAN link is on my> Old And Busted tulip card, which lacks it.> > It's just a few lines, but the important thing is knowing where to> put them, and I've sort of guessed. In particular, it seems like the> netdev_sent_queue call could be almost anywhere in tulip_start_xmit and> I'm not sure if there are reasons to prefer any particular position.> > (You may have my S-o-b on copyright grounds, but I'd like to test it> some more before declaring this patch ready to be merged.)
Seems fine to me.
You might wait before David Miller re-opens net-next for new
submissions, a bit after linux-3.11-rc1 is released, before
sending an official patch.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html