On Fri, 6 Jun 2008, Alexey Dobriyan wrote:> On Thu, Jun 05, 2008 at 12:25:06PM +0200, Armin Schindler wrote:>> On Sat, 31 May 2008, Alexey Dobriyan wrote:>>> 1. creating proc entry and not saving pointer to PDE and checking it>>> is not going to work.>>>> I don't know where you found this. I have look even in older versions, but>> the pointer divas_proc_entry is set by proc_create(). The patch to>> divasproc.c is wrong, it exists from the beginning of the driver.>> (2.6.25.4 doesn't contain the bug you describe).>> Check mainline kernel, namely, 2.6.26-rc5.

Ah, okay. So someone removed the pointer between 2.6.25 and 2.6.26 then.In that case your patch is correct of course.