Hi Frederick,
On 5.12.2012, at 16.42, Hirsch Frederick (Nokia-CIC/Boston) wrote:
> Thanks, in general it looks to me personally like this revision clears up a number of issues and is a step in a very good direction. Thanks to those who have been persistently suggesting changes, and thanks for making an unofficial draft and diff, that makes it clear.
Thanks for your thorough review!
> I have a couple of suggestions:
>
> (1) Introduction
>
> change "This enables unified capture and upload from the device capture device without requiring a user to save a file and then upload it in separate steps."
>
> to
>
> "This enables simplified capture using device capture device supporting a variety of scenarios."
Changed.
> change
>
> " The capture attribute enables content authors to indicate the media to be captured and uploaded. Conformant user agents provide their users a more seamless access to the above-mentioned media capture capabilities of the hosting device."
>
> to
>
> "The capture boolean attribute allows authors to directly request use of the device capture mechanism."
Changed.
> (2) 5.1 has the statement
>
> "When the capture attribute is specified, the user agent should invoke a file picker of the specific capture control type."
>
> Is "invoke a device capture mechanism directly for the specific accept type" clearer?
The term 'capture control type' is defined in the Terminology section as follows:
[[
In this specification, the term capture control type refers to a specialized type of a file picker
control that is optimized, for the user, for directly capturing media of a MIME type specified by the accept attribute.
]]
Does it clarify this?
> (3) Also in 5.1, I don't think precedence is relevant any more - perhaps change
>
> "The HTMLInputElement interface's accept attribute takes precedence over the capture attribute. That is, if the accept attribute's value is set to a MIME type that has no associated capture control type, the user agent must act as if there was no capture attribute."
>
> to
>
> "If the device has no device capture mechanism corresponding to the accept attribute then the user agent must act as if no capture boolean attribute were present, that is as if it were false."
I changed this to:
[[
If the accept attribute's value is set to a MIME type that has no associated capture control type, the user agent must act as if there was no capture attribute.
]]
The text refers to the term 'capture control type' defined in the Terminology section. Does this sound ok now?
> (4) Is the Note in 5.1 still needed? Perhaps not.
I dropped this note.
> (5) where are the accept and capture attributes in example 5, 6,7? Not sure how this invokes the built-in camera, for example. Examples probably should be media capture not file specific?
I clarified the example by making 1-3 complete, and added comments to 5 and 6.
Here's the diff:
http://dev.w3.org/cvsweb/2009/dap/camera/unofficial.html.diff?r1=1.3;r2=1.4;f=h
As agreed on the call, I merged in changes introduced on unofficial branch, so you can now look at the Editor's Draft for the latest:
http://dev.w3.org/2009/dap/camera/
I also set the unofficial version to redirect to the Editor's Draft.
Let me know if further changes are needed. Thanks!
Tracker, this should complete my ACTION-600
-Anssi