From dev-return-16064-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org Sun May 08 04:23:03 2005
Return-Path:
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 56521 invoked from network); 8 May 2005 04:23:03 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
by minotaur.apache.org with SMTP; 8 May 2005 04:23:03 -0000
Received: (qmail 43507 invoked by uid 500); 8 May 2005 04:26:01 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 43302 invoked by uid 500); 8 May 2005 04:25:59 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help:
list-unsubscribe:
List-Post:
Reply-To: dev@forrest.apache.org
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 43284 invoked by uid 99); 8 May 2005 04:25:59 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Received: from www2.kc.aoindustries.com (HELO www2.kc.aoindustries.com) (65.77.211.84)
by apache.org (qpsmtpd/0.28) with ESMTP; Sat, 07 May 2005 21:25:59 -0700
Received: from www2.kc.aoindustries.com (www2.kc.aoindustries.com [65.77.211.84])
by www2.kc.aoindustries.com (8.12.9-20030917/8.12.9) with ESMTP id j484MwV8009986
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
for ; Sat, 7 May 2005 23:22:58 -0500
Received: from localhost (localhost [[UNIX: localhost]])
by www2.kc.aoindustries.com (8.12.9-20030917/8.12.9/Submit) id j484Mvpb009936
for dev@forrest.apache.org; Sat, 7 May 2005 23:22:57 -0500
X-Authentication-Warning: www2.kc.aoindustries.com: indexgeo set sender to crossley@apache.org using -f
Date: Sun, 8 May 2005 14:22:50 +1000
From: David Crossley
To: dev@forrest.apache.org
Subject: Re: SVN Inconsitent Line Endings
Message-ID: <20050508042250.GC6215@igg.indexgeo.com.au>
References: <41D826A1.8050805@apache.org> <41D8710B.4050607@apache.org> <20050505070812.GA2596@igg.indexgeo.com.au> <427B8641.7020705@apache.org> <20050507033250.GF4535@igg.indexgeo.com.au> <427CC57A.7040202@apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <427CC57A.7040202@apache.org>
User-Agent: Mutt/1.4i
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N
Ross Gardler wrote:
> David Crossley wrote:
> >Ross Gardler wrote:
> >>David Crossley wrote:
> >>
> >>>I presume that this does not happen when you do 'forrest' to
> >>>build the plugin's docs, rather than doing 'ant docs'.
> >>
> >>I had also assumed that, however it turns our to be incorrect.
> >>
> >>In fact doing "forrest site" on any site, including site-author, results
> >>in the same error.
> >>
> >>I can only assume that it has not raised it's head before because I have
> >>not been the first person to commit generated sites to SVN with the eol
> >>settings set to "native".
> >
> >Sorry, i can't parse that. Too many "nots". :-)
> >
> >All text files should have line-endings appropriate for the local system
> >OS and should always be 'svn propset svn:eol-style native'.
>
> Sorry, I'll try again, but I'll try by asking a couple of questions
> rather than stating what I think the problem might be.
I am finally beginning to understand what your issues are.
I thought you just had a problem with mixed line-endings,
but it sounds a bigger problem and perhaps separate issues.
> Has anyone built a site using Forrest on Windows and then been the first
> to commit it to SVN?
>
> Do we know for sure that the Ant SVN tasks pick up the SVN config info?
I just reviewed our SVN forrest/site/0.7/docs/plugins/
and found that there are files with *.rss and *.pod
which are missing the 'svn:eol-style native'. So perhaps
your ~/.subversion/config is out-of-date.
http://www.apache.org/dev/version-control.html
http://www.apache.org/dev/svn-eol-style.txt
To test if the Ant task gets the new config,
try 'svn rm' one of the plugins and re-add it.
Those *.rss and *.pod are also not handled by the workaround
below. However, they don't need to be, because there are no
mixed line-endings in those (no xml comments either).
> >>Given the above observation that the XSL generated comments ahve
> >>different line endings to other XSL generated files I can only assume it
> >>is something to do with the XSLT parser.
> >
> >What happens when you do a simple test with Xalan on the commandline.
>
> Not sure, I'll do that soon.
>
> >>For now I have put a workaround in place in the buildfile (uses an ant
> >>task to fix the line endings). I'll also place an issue on the issue
> >>tracker to remind us of this.
> >
> >I saw that. However i couldn't understand why it was converting
> >them to UNIX line-endings regardless of which OS the user is on.
> >Do we need to detect the OS?
>
> I converted to UNIX more out of habit than design. But it works for me
> and I'm on Windows so I'm happy.
My comment was more an SVN-based one:
"eol-style native" means native to the user's OS.
> >I have not heard of this problem before. At Cocoon and Incubator,
> >people on various operating systems generate the website and commit
> >the result to SVN, with no problems.
>
> Yes, but they don't do what we are doing with docs generated by Forrest
> and then imported into SVN by ant tasks.
Now i understand the issue a bit more. Sorry, i must have
missed something earlier in the thread.
I don't know if this is related, but thanks Google and mail-archive.com:
"line endings" "xsl:comment" ...
http://issues.apache.org/jira/browse/XALANJ-656
" introduces inappropriate line-end characters processing comments".
--David