On 27.05.2009 21:35, Nabs Kahn wrote:
>> Well, it will. But so will your producer thread and eventually the main
>> thread since it joins on the producer. The producer thread brings you
>> only advantages if you need to do other things in the main thread. But
>> since you don't in the code you presented you can as well do the queue
>> filling in the main thread.
>
> I see, that makes sense.
>
>
>> Btw, I just notice one thing: you don't chomp the lines read from the
>> file. So your URL's will still contain the trailing line feed.
>
> I am actually chomping them inside the screenScraper method.
I wouldn't do that. Preparation of the input should be done outside of
your scraping method. You put too much knowledge about the environment
into the method.
Cheers
robert
--
remember.guy do |as, often| as.you_can - without end
http://blog.rubybestpractices.com/