[{"url":"https://api.github.com/repos/openshift/release/issues/comments/540619694","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-540619694","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":540619694,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MDYxOTY5NA==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-10T14:40:31Z","updated_at":"2019-10-10T14:40:31Z","author_association":"MEMBER","body":"@smarterclayton @jwforres Can I please get some feedback on this PR?"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/541090767","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-541090767","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":541090767,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MTA5MDc2Nw==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-11T14:35:27Z","updated_at":"2019-10-11T14:35:27Z","author_association":"MEMBER","body":"I just added `s390x` for `4.2` because we'll be needing that for the `4.2.Z` releases. \r\n\r\n@smarterclayton SO, about the `amd64` stuff: I'd like to keep that in there. And if you don't object then I'll add it for `4.2` as well."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/542257232","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-542257232","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":542257232,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MjI1NzIzMg==","user":{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2019-10-15T15:01:29Z","updated_at":"2019-10-15T15:01:29Z","author_association":"MEMBER","body":"Changing the names of the streams breaks existing integrations that use images out of there, so it's not safe to just move. And we definitely don't want two."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/542271855","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-542271855","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":542271855,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MjI3MTg1NQ==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-15T15:31:48Z","updated_at":"2019-10-15T15:31:48Z","author_association":"MEMBER","body":"Alright, I'll update this to reflect this discussion. The default unlabeled image streams will implicitly be `amd64`."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/542275219","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-542275219","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":542275219,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MjI3NTIxOQ==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-15T15:38:32Z","updated_at":"2019-10-15T15:38:32Z","author_association":"MEMBER","body":"@smarterclayton I removed the `amd64` specific stream. Now this is just net-new additions. `ppc` for 4.2 and 4.3, and `s390x` for 4.3"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545470545","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545470545","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545470545,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ3MDU0NQ==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:27:00Z","updated_at":"2019-10-23T14:27:00Z","author_association":"MEMBER","body":"@smarterclayton how do you feel about merging this now?"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545472471","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545472471","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545472471,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ3MjQ3MQ==","user":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:31:14Z","updated_at":"2019-10-23T14:31:14Z","author_association":"MEMBER","body":"@tbielawa i'm seeing PPC for 4.2 here instead of s390x for 4.2, that seems backwards"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545476941","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545476941","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545476941,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ3Njk0MQ==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:40:50Z","updated_at":"2019-10-23T14:40:50Z","author_association":"MEMBER","body":"> @tbielawa i'm seeing PPC for 4.2 here instead of s390x for 4.2, that seems backwards\r\n\r\nDerp. Good catch."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545478935","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545478935","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545478935,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ3ODkzNQ==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:45:03Z","updated_at":"2019-10-23T14:45:03Z","author_association":"MEMBER","body":"> @tbielawa i'm seeing PPC for 4.2 here instead of s390x for 4.2, that seems backwards\r\n\r\nOK. I think that should be fixed now."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545483164","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545483164","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545483164,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ4MzE2NA==","user":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:53:52Z","updated_at":"2019-10-23T14:53:52Z","author_association":"MEMBER","body":"/lgtm"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545483773","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545483773","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545483773,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ4Mzc3Mw==","user":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:55:10Z","updated_at":"2019-10-23T14:55:10Z","author_association":"MEMBER","body":"/hold"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545484645","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545484645","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545484645,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ4NDY0NQ==","user":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:57:00Z","updated_at":"2019-10-23T14:57:00Z","author_association":"MEMBER","body":"You actually need to add the RBAC or these will fail to get automatically created. I'll find the PR where I did this recently..."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545485464","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545485464","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545485464,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ4NTQ2NA==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:58:34Z","updated_at":"2019-10-23T14:58:34Z","author_association":"MEMBER","body":"Yeah, I added ppc64le to 4.2 in that RBAC change:\r\nhttps://github.com/openshift/release/pull/5442/files\r\nI'll make a new request to include s390x for 4.2"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545485624","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545485624","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545485624,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ4NTYyNA==","user":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T14:58:54Z","updated_at":"2019-10-23T14:58:54Z","author_association":"MEMBER","body":"you need something similar to the part of the diff highlighted here:\r\nhttps://github.com/openshift/release/pull/5132/files#diff-b67911656ef5d18c4ae36cb6741b7965R162-R164"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/545495371","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-545495371","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":545495371,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTQ5NTM3MQ==","user":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T15:18:52Z","updated_at":"2019-10-23T15:18:52Z","author_association":"MEMBER","body":"/lgtm cancel\r\nsince there is more needed in this PR"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/546003847","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-546003847","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":546003847,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjAwMzg0Nw==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-24T16:43:10Z","updated_at":"2019-10-24T16:51:40Z","author_association":"MEMBER","body":"**edit** Sorry, I tagged Steve directly originally. Editing to refer to DPTP @openshift/openshift-team-developer-productivity-test-platform \r\n\r\nI saw this in `ci-operator/infra/openshift/release-controller/README.md` and I feel like it applies to this situation, but I am not exactly sure how it applies or what to do about it.\r\n\r\n```If the repo is incompatible with any of the RPMs in the default repos (like the OpenStack project), a new type of `ocp-4.Y-NAME.repo` has to be created (similar to `ocp-4.2-openstack.repo`) that points to the correct mirrors. Then the images that want to use that as a base have to inject the correct RPM repo ```\r\n\r\nFor example, I am adding `s390x` repos for 4.3, should I be adding a new `service` in `ci-operator/infra/openshift/release-controller/rpms-ocp-4.3.yaml` with the new matching `secretName` I added to the `Makefile`?\r\n\r\n```\r\n# Makefile\r\n+ oc create secret generic base-4-3-repos-s390x \\\r\n+ --from-file=cluster/test-deploy/gcp/ops-mirror.pem \\\r\n+ --from-file=ci-operator/infra/openshift/release-controller/repos/ocp-4.3-s390x.repo \\\r\n+ -o yaml --dry-run | oc apply -n ocp -f -\r\n```\r\n\r\nSecret name = `base-4-3-repos-s390x` so changes to `ci-operator/infra/openshift/release-controller/rpms-ocp-4.3.yaml` would be a new `service` like this (I tacked `-s390x` on the end of every unique identifer)?\r\n\r\n```yaml\r\n- apiVersion: v1\r\n kind: Service\r\n metadata:\r\n name: base-4-3-s390x\r\n namespace: ocp\r\n spec:\r\n selector:\r\n app: base-4-3-s390x\r\n ports:\r\n - port: 80\r\n targetPort: 8080\r\n type: ClusterIP\r\n- apiVersion: apps/v1\r\n kind: Deployment\r\n metadata:\r\n name: base-4-3-s390x\r\n namespace: ocp\r\n labels:\r\n app: base-4-3-s390x\r\n annotations:\r\n image.openshift.io/triggers: '[{\"from\":{\"kind\":\"ImageStreamTag\",\"name\":\"content-mirror:latest\",\"namespace\":\"ci\"},\"fieldPath\":\"spec.template.spec.containers[?(@.name==\\\"mirror\\\")].image\"}]'\r\n spec:\r\n replicas: 2\r\n selector:\r\n matchLabels:\r\n app: base-4-3-s390x\r\n template:\r\n metadata:\r\n labels:\r\n app: base-4-3-s390x\r\n spec:\r\n volumes:\r\n - name: repos\r\n secret:\r\n secretName: base-4-3-repos-s390x\r\n - name: cache\r\n emptyDir: {}\r\n - name: run\r\n emptyDir: {}\r\n containers:\r\n - name: mirror\r\n ports:\r\n - name: http\r\n containerPort: 8080\r\n volumeMounts:\r\n - name: repos\r\n mountPath: /tmp/repos\r\n readOnly: true\r\n - name: cache\r\n mountPath: /tmp/cache\r\n image: \" \"\r\n workingDir: /tmp/repos\r\n command:\r\n - content-mirror\r\n - --path=/tmp/config\r\n - --max-size=5g\r\n - --timeout=30m\r\n - /tmp/repos\r\n```\r\n\r\nLikewise for `ppc64le`?"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/546006731","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-546006731","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":546006731,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjAwNjczMQ==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-24T16:50:40Z","updated_at":"2019-10-24T16:52:28Z","author_association":"MEMBER","body":"Another followup, @openshift/openshift-team-developer-productivity-test-platform , as I am not including any `verify` jobs in the new `ci-operator/infra/openshift/release-controller/releases/release-ocp-4.*-*.json` definitions, must I include periodics at this time? ex: `ci-operator/jobs/openshift/release/openshift-release-release-4.3-periodics.yaml`\r\n\r\nI noticed there is a `promote machine-os-content` (`rhcos` bits) item in there which references an `ocp-dev-preview` nightly client. As we don't have `s390x` or `ppc64le` clients extracted yet, I don't think it's possible to include that job yet.\r\n\r\nreference `ci-operator/jobs/openshift/release/openshift-release-release-4.3-periodics.yaml`:\r\n\r\n```yaml\r\nperiodics:\r\n- agent: kubernetes\r\n decorate: true\r\n interval: 15m\r\n labels:\r\n ci.openshift.io/release-type: informing\r\n job-release: \"4.3\"\r\n name: release-promote-openshift-machine-os-content-e2e-aws-4.3\r\n spec:\r\n containers:\r\n - command:\r\n - /bin/bash\r\n - -c\r\n - |\r\n #!/bin/bash\r\n set -euo pipefail\r\n\r\n # prow doesn't allow init containers or a second container\r\n export PATH=$PATH:/tmp/bin\r\n mkdir /tmp/bin\r\n curl https://mirror.openshift.com/pub/openshift-v4/clients/ocp-dev-preview/4.2.0-0.nightly-2019-09-11-114314/openshift-client-linux-4.2.0-0.nightly-2019-09-11-114314.tar.gz | tar xvz>\r\n chmod ug+x /tmp/bin/oc\r\n\r\n```"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/546298617","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-546298617","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":546298617,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjI5ODYxNw==","user":{"login":"petr-muller","id":712614,"node_id":"MDQ6VXNlcjcxMjYxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/712614?v=4","gravatar_id":"","url":"https://api.github.com/users/petr-muller","html_url":"https://github.com/petr-muller","followers_url":"https://api.github.com/users/petr-muller/followers","following_url":"https://api.github.com/users/petr-muller/following{/other_user}","gists_url":"https://api.github.com/users/petr-muller/gists{/gist_id}","starred_url":"https://api.github.com/users/petr-muller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petr-muller/subscriptions","organizations_url":"https://api.github.com/users/petr-muller/orgs","repos_url":"https://api.github.com/users/petr-muller/repos","events_url":"https://api.github.com/users/petr-muller/events{/privacy}","received_events_url":"https://api.github.com/users/petr-muller/received_events","type":"User","site_admin":false},"created_at":"2019-10-25T10:27:32Z","updated_at":"2019-10-25T10:27:32Z","author_association":"MEMBER","body":"@tbielawa DPTP is not that familiar with release-controller - @bradmwilliams is probably the best contact here. From what I know, what you describe in your first comment is correct, that's how I saw people add e.g. openstack repos. I'm not able to advise with the second comment unfortunately."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/546389460","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-546389460","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":546389460,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjM4OTQ2MA==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-25T15:00:00Z","updated_at":"2019-10-25T15:00:00Z","author_association":"MEMBER","body":"> @tbielawa DPTP is not that familiar with release-controller - @bradmwilliams is probably the best contact here. From what I know, what you describe in your first comment is correct, that's how I saw people add e.g. openstack repos. I'm not able to advise with the second comment unfortunately.\r\n\r\nThanks for the advice. I'll go ahead and update that repo business. "},{"url":"https://api.github.com/repos/openshift/release/issues/comments/546409111","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-546409111","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":546409111,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjQwOTExMQ==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-25T15:52:06Z","updated_at":"2019-10-25T15:52:06Z","author_association":"MEMBER","body":"> > @tbielawa DPTP is not that familiar with release-controller - @bradmwilliams is probably the best contact here. From what I know, what you describe in your first comment is correct, that's how I saw people add e.g. openstack repos. I'm not able to advise with the second comment unfortunately.\r\n> \r\n> Thanks for the advice. I'll go ahead and update that repo business.\r\n\r\nI've added the proxy pods for all the new arches, including the not-yet-started 4.2-s390x ones (just to save us some work in the future)."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/546438412","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-546438412","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":546438412,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjQzODQxMg==","user":{"login":"bradmwilliams","id":43015045,"node_id":"MDQ6VXNlcjQzMDE1MDQ1","avatar_url":"https://avatars3.githubusercontent.com/u/43015045?v=4","gravatar_id":"","url":"https://api.github.com/users/bradmwilliams","html_url":"https://github.com/bradmwilliams","followers_url":"https://api.github.com/users/bradmwilliams/followers","following_url":"https://api.github.com/users/bradmwilliams/following{/other_user}","gists_url":"https://api.github.com/users/bradmwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/bradmwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradmwilliams/subscriptions","organizations_url":"https://api.github.com/users/bradmwilliams/orgs","repos_url":"https://api.github.com/users/bradmwilliams/repos","events_url":"https://api.github.com/users/bradmwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/bradmwilliams/received_events","type":"User","site_admin":false},"created_at":"2019-10-25T17:18:56Z","updated_at":"2019-10-25T17:18:56Z","author_association":"CONTRIBUTOR","body":"> Another followup, @openshift/openshift-team-developer-productivity-test-platform , as I am not including any `verify` jobs in the new `ci-operator/infra/openshift/release-controller/releases/release-ocp-4.*-*.json` definitions, must I include periodics at this time? ex: `ci-operator/jobs/openshift/release/openshift-release-release-4.3-periodics.yaml`\r\n\r\n@tbielawa You are not required to add any `periodic` job definitions at this time. Without any release verification jobs, the release will automatically get `accepted` and `published` according to your release configuration."},{"url":"https://api.github.com/repos/openshift/release/issues/comments/546439368","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-546439368","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":546439368,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjQzOTM2OA==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-25T17:21:56Z","updated_at":"2019-10-25T17:21:56Z","author_association":"MEMBER","body":"> > Another followup, @openshift/openshift-team-developer-productivity-test-platform , as I am not including any `verify` jobs in the new `ci-operator/infra/openshift/release-controller/releases/release-ocp-4.*-*.json` definitions, must I include periodics at this time? ex: `ci-operator/jobs/openshift/release/openshift-release-release-4.3-periodics.yaml`\r\n> \r\n> @tbielawa You are not required to add any `periodic` job definitions at this time. Without any release verification jobs, the release will automatically get `accepted` and `published` according to your release configuration.\r\n\r\nWeee! Excellent. I think this is ready for another round of review then, @jwforres and @smarterclayton etc. Tag in whomever has the best eyes for this please :smile_cat: "},{"url":"https://api.github.com/repos/openshift/release/issues/comments/547906546","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-547906546","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":547906546,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzkwNjU0Ng==","user":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T13:37:10Z","updated_at":"2019-10-30T13:37:10Z","author_association":"MEMBER","body":"i don't think the rpm stuff is necessary yet, but we did have a goal of eventually having CI builds of Z, I don't think hurts to leave it here, just wont get used for a bit"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/547908233","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-547908233","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":547908233,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzkwODIzMw==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T13:40:50Z","updated_at":"2019-10-30T13:40:50Z","author_association":"MEMBER","body":"> i don't think the rpm stuff is necessary yet, but we did have a goal of eventually having CI builds of Z, I don't think hurts to leave it here, just wont get used for a bit\r\n\r\nSounds good to me. I have pushed all the requested changes"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/547911946","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-547911946","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":547911946,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzkxMTk0Ng==","user":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T13:48:22Z","updated_at":"2019-10-30T13:48:22Z","author_association":"MEMBER","body":"/lgtm"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/547918543","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-547918543","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":547918543,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzkxODU0Mw==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T14:01:27Z","updated_at":"2019-10-30T14:01:27Z","author_association":"MEMBER","body":"/assign @droslean "},{"url":"https://api.github.com/repos/openshift/release/issues/comments/547918754","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-547918754","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":547918754,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzkxODc1NA==","user":{"login":"tbielawa","id":33121,"node_id":"MDQ6VXNlcjMzMTIx","avatar_url":"https://avatars3.githubusercontent.com/u/33121?v=4","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T14:01:54Z","updated_at":"2019-10-30T14:01:54Z","author_association":"MEMBER","body":"Or @'ing anybody else in @openshift/openshift-team-developer-productivity-test-platform who can approve and merginate this"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/547921561","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-547921561","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":547921561,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzkyMTU2MQ==","user":{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T14:07:34Z","updated_at":"2019-10-30T14:07:34Z","author_association":"MEMBER","body":"/approve\r\n/hold cancel"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/547921752","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-547921752","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":547921752,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzkyMTc1Mg==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T14:07:56Z","updated_at":"2019-10-30T14:07:56Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *jwforres*, *smarterclayton*, *tbielawa*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=openshift%2Frelease).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/openshift/release/blob/master/OWNERS)~~ [smarterclayton]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n\n"},{"url":"https://api.github.com/repos/openshift/release/issues/comments/547933512","html_url":"https://github.com/openshift/release/pull/5374#issuecomment-547933512","issue_url":"https://api.github.com/repos/openshift/release/issues/5374","id":547933512,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzkzMzUxMg==","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T14:30:48Z","updated_at":"2019-10-30T14:30:48Z","author_association":"MEMBER","body":"No bot comment about these changes being applied?"}]