On Mon, Sep 29, 2008 at 06:42:20AM -0700, Arjan van de Ven wrote:...> > This patch changes that behavior of the device driver so it uses> > uncacheable instead of cacheable mappings. This is the only thing> > I'm uncertain about for this patch.> > ioremap() also is uncachable today.

I expect it needs to use ioremap_cache() instead of ioremap().One line patch below fixes that. Build-tested on x86 only.

Signed-off-by: Grant Grundler <grundler@parisc-linux.org>

> > And I have a second issue less important issue.> > What is the result of ioremap_pcibar(pci, 1) when BAR0 is a 64-bit> > bar? Given the name, I expect to call "ioremap_pcibar(pci,2)" to get> > the desired result. Maybe just document how to handle this correctly> > in Documentation/pci.txt would be sufficient.> > we should detect this and DTRT inside the implementation, not in the> drivers.