> > > +#if defined(__nosave_begin)> > this won't work right, __nosave_begin isn't a preprocessor thing so it> will be ignored when you uncomment it. You probably can use #if 0> instead and a comment near __nosave_begin to turn it to 1 when enabling> the suspend code.

Oh sh*t, this is what one gets for fixing things up for a demo aftera long night... Will bite my lower rear portion after the nap.

> > > What is your opinion of this approach?> > except for the above two nitpicks, the patch is correct and needed for> safe suspend IMHO. 2.6 seems to miss this thing too, why not add it to> 2.6 first?

Swsusp won't be in 2.4 anyway, if Nigel accepts the patch, it will become part of his next releases for 2.4 and 2.6.

Anyway, I'll fix the patch up for 2.6, test it and post the patch in a few days.