Patrick Hunt
added a comment - 02/Sep/11 20:42 This patch addresses a new check added to javac in version 7. This is the default in java 6 (default source to target) so should be a relatively low risk change.
With this patch applied I can compile and run all tests successfully using java7.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 02/Sep/11 21:17 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492796/ZOOKEEPER-1171.patch
against trunk revision 1164632.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/491//console
This message is automatically generated.

No, the toplevel build.xml is the only file in which we specify an explicit target. As a result the other builds should build fine - although I didn't test that as my main goal here is to get the trunk build working on jdk7 and setup a jenkins job.

Patrick Hunt
added a comment - 13/Sep/11 19:34 No, the toplevel build.xml is the only file in which we specify an explicit target. As a result the other builds should build fine - although I didn't test that as my main goal here is to get the trunk build working on jdk7 and setup a jenkins job.
I think this should just go in as-is.