On Fri, 2011-10-07 at 16:34 -0700, Jeremy Allison wrote:
> On Wed, Sep 28, 2011 at 04:57:48PM +0200, Volker Lendecke wrote:
> > On Wed, Sep 28, 2011 at 10:46:34AM -0400, simo wrote:
> > > On Wed, 2011-09-28 at 16:42 +0200, Volker Lendecke wrote:
> > > > On Wed, Sep 28, 2011 at 10:40:09AM -0400, simo wrote:
> > > > > Make test does involve samr operations, in fact I discovered a few bugs
> > > > > through make test during development.
> > > >
> > > > Yes, I am aware that make test does involve samr operations.
> > > >
> > > > > I do not have a PDC with LDAP handy at the moment, but the LDAP side has
> > > > > seen minimal change and all quite obvious so I think the tests we see in
> > > > > make test may be enough to cover that part.
> > > >
> > > > If you are really, really certain that you did not break the
> > > > LDAP side of things then this might be okay. I still feel
> > > > very uneasy, but this might be just me.
> > >
> > > I will see if I can find time to do an actual smoke gun test on it.
> > > Would that be enough ?
> >
> > Sure. Set up an LDAP PDC with editposix and play back and
> > forth either usrmgr if it's still available or do some
> > groups operations with net rpc. That would be fine for me.
>> Ping. I don't want to lose this patch. Getting rid
> of all fixed size strings is a long-term goal of mine
> for Samba....
>> Simo, did you get this test done ?
Andreas is looking into that.
Simo.
--
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>