Status

()

For bugs in Firefox Desktop, the Mozilla Foundation's web browser. For Firefox user interface issues in menus, bookmarks, location bar, and preferences. Many Firefox bugs will either be filed here or in the Core product. Bugs for developer tools (F12) should be filed in the DevTools product. (more info)

For issues relating to the site identity block in the location bar, site information panel (also known as "Control Center"), and prompts from sites that require additional permissions (such as geolocation, camera, and microphone).

This had a lot more edge cases to cover than I'd expected at first. This is a first attempt at solving all of them. I haven't added tests yet, I'll push more commits later, I wanted to get this out first to be able to collect some feedback and see if we have to make any fundamental changes.
Paolo, do you have time to take a look at this? If not let me know and I'll ask someone else :)
(I know I still owe you two reviews which I'm going to get at shortly)
Thanks!

During some initial testing I noticed that step 3 of the UI Tour still refers to the button as "Disable protection for this site". I guess this string is set by the "mozilla.org" site, and it should either be made version-dependent or the button text should be removed from it. Is there a bug on file for this?

(In reply to :Paolo Amadini from comment #17)
> During some initial testing I noticed that step 3 of the UI Tour still
> refers to the button as "Disable protection for this site". I guess this
> string is set by the "mozilla.org" site, and it should either be made
> version-dependent or the button text should be removed from it. Is there a
> bug on file for this?
Thanks for noticing this, filed bug 1466235!

(In reply to :Paolo Amadini from comment #19)
> Comment on attachment 8982340[details]
> Bug 1462470 - Part 6 - Add tests for the updated tracking protection UI in
> the identity popup.
>
> https://reviewboard.mozilla.org/r/248290/#review255068
>
> ::: browser/base/content/test/trackingUI/browser_trackingUI_state.js:145
> (Diff revision 1)
> > + // We can't use BENIGN_PAGE here because, in mochitest,
> > + // the third party URI check done for subresources unfortunately
> > + // does not work. example.com does not load any subresources.
> > + await promiseTabLoadEvent(tab, "http://example.com/");
>
> I don't understand the issue entirely, but is this something that will
> eventually be fixed? If so, you could reference a bug number here.
So while sitting on a beach and pondering this issue I had the realization that this does not only occur in mochitests (when debugging a mochitest I had previously assumed that this is happening because topWinURI is null here: https://searchfox.org/mozilla-central/source/netwerk/base/nsChannelClassifier.cpp#347), but rather that this is a symptom of a bug in my implementation. I noticed that "trackers blocked" notifications were sent for any page with subresources, even if it did not contain trackers. The reason is that I had put the NotifyTrackingProtectionDisabled in the wrong place. Correcting that makes this test work with BENIGN_PAGE and works great in my manual testing, too, which I think means success!
Going back to my last day of vacation now, with one less problem to keep my mind busy about.

Comment on attachment 8980241[details]Bug 1462470 - Part 1 - Notify frontend of loaded tracking content in annotation-only mode.
Ehsan, since I moved this code to a different place, can you give it another quick sanity check? Thanks!

Comment on attachment 8980241[details]Bug 1462470 - Part 1 - Notify frontend of loaded tracking content in annotation-only mode.
LGTM. I couldn't figure out how to r+ this in MozReview, so marking this in Bugzilla instead, hope this is Doing The Right Thing...

Release Note Request (optional, but appreciated)
[Why is this notable]: We now tell the user that there are trackers on the site even if Tracking Protection is off (and some other minor improvements to the TP UI).
[Affects Firefox for Android]: No
[Suggested wording]: Even with Tracking Protection off, you can now use the site identity popup to find out whether the current page contains trackers.
[Links (documentation, blog post, etc)]: Nothing yet, but this is part of the larger anti-tracking work so stay tuned.