Comments

This is a resubmission.
The _nopm version usb functions were added to access register in suspend and resume functions.
Serveral variables allocted dynamically were removed and replaced by stack variables.
ax88179_get_eeprom were modified from asix_get_eeprom in asix_common.
This patch adds a driver for ASIX's AX88179 family of USB 3.0/2.0
to gigabit ethernet adapters. It's based on the AX88xxx driver but
the usb commands used to access registers for AX88179 are completely different.
This driver had been verified on x86 system with AX88179/AX88178A and
Sitcomm LN-032 USB dongles.
Signed-off-by: Freddy Xin <freddy@asix.com.tw>
---
drivers/net/usb/Kconfig | 18 +
drivers/net/usb/Makefile | 1 +
drivers/net/usb/ax88179_178a.c | 1424 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 1443 insertions(+)
create mode 100644 drivers/net/usb/ax88179_178a.c

From: Freddy Xin <freddy@asix.com.tw>
Date: Thu, 17 Jan 2013 17:32:54 +0800
> +struct ax88179_rx_pkt_header {> +> + u8 l4_csum_err:1,
Get rid of such extraneous empty lines. They do not add clarity,
rather they just take up space.
> + ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR |> + USB_RECIP_DEVICE, value, index, data, size);
This is not indented properly. When a function call takes up
multiple lines, the text on the second and subsequent lines must
be left justified to the first column after the openning parenthesis
of the function call, like this:
function(arg1, arg2,
arg3, arg4);
You must use the appropriate combination of TAB and space characters
to achieve this. If you are trying to only use TAB characters, you
are doing it wrong.
This code has a lot of other similar coding style errors, please
put some effort into fixing them up before you consider resubmitting
this driver.
All of the coding style errors are probably why nobody reviewed your
driver the first time around, there's already enough properly styled
submissions to review.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Fri, 18 Jan 2013, David Miller wrote:
> > + ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR |> > + USB_RECIP_DEVICE, value, index, data, size);> > This is not indented properly. When a function call takes up> multiple lines, the text on the second and subsequent lines must> be left justified to the first column after the openning parenthesis> of the function call, like this:> > function(arg1, arg2,> arg3, arg4);> > You must use the appropriate combination of TAB and space characters> to achieve this. If you are trying to only use TAB characters, you> are doing it wrong.
Documentation/CodingStyle doesn't mention this. Does the networking
stack have its own special requirements, not listed in CodingStyle?
Alan Stern
P.S: The standard I have tried to follow for USB code is to indent
continuation lines by two tab stops more than the first line,
regardless of whether the break occurs inside a function call. I have
seen other people consistently indent continuation lines by 1/2 tab
stop (i.e., four spaces) beyond the first line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html