General tests
The following tests apply to MOODLE_23_STABLE and to master:
Navigate to Settings -> Site administration -> Appearance -> Media
Ensure that the YouTube and Vimeo options are ticked
Navigate to a course page
Turn editing on
Edit a section
Set the section Summary to:
<p><a href="http://www.youtube.com/v/1akyXgddyAY">Example YouTube</a></p>
<p><a href="http://vimeo.com/1234567">Example Vimeo</a></p>
<p><a href="http://www.youtube.com/playlist?list=PL9B6AC5E479B1B992">Example Playlist</a></p>
Save changes
Confirm that the Top video (YouTube) is displayed
Confirm that the Middle video (Vimeo) is displayed
Confirm that the Bottom video (YouTube Playlist) is displayed
View the source and confirm that each video is pointed at the correct (https) URL
Open the 'Activity Chooser'
Confirm that none of the videos sit in front of the activity chooser
MOODLE_23_STABLE
The following instructions are in addition to the tests above. Moodle 2.3 still has the XML Strict Headers setting which slightly changes the way that some videos are displayed:
Navigate to Site administration -> Development -> Debugging
Turn "XML strict headers" to on
View the course page again
Confirm that the Top video (YouTube) is displayed
Confirm that it is not in an iframe
Confirm that the Middle video (Vimeo) is displayed
Confirm that the Bottom video (YouTube Playlist) is displayed
Open the 'Activity Chooser'
Confirm that none of the videos sit in front of the activity chooser

Andrew: if you are interested in this patch, I was thinking we could change the youtube embeding to always use https. But I have not had time to look into if doing that gives IE 'mixed https' warnings and doesn't solve the problem. It seems like an integratable solution irrespective of linked issue.

Dan Poltawski
added a comment - 17/Jul/12 8:52 PM Andrew: if you are interested in this patch, I was thinking we could change the youtube embeding to always use https. But I have not had time to look into if doing that gives IE 'mixed https' warnings and doesn't solve the problem. It seems like an integratable solution irrespective of linked issue.

Following discussion in the developer chat, I'm going to convert both youtube and vimeo to be always https.
At present, it's not possible to reliably determine the current URL in a filter because the global $PAGE object shouldn't be accessed from a filter.

Andrew Nicols
added a comment - 23/Jul/12 6:12 PM Following discussion in the developer chat, I'm going to convert both youtube and vimeo to be always https.
At present, it's not possible to reliably determine the current URL in a filter because the global $PAGE object shouldn't be accessed from a filter.

I've also replaced the YouTube playlist embedding with the iframe version as embed support for youtube playlists seems to be non-existent and I can't get the existing code to work under any circumstances.

I've also taken the opportunity to add a missing <span> around the iframe for youtube videos.

Andrew Nicols
added a comment - 23/Jul/12 9:50 PM I've replaced all Vimeo and YouTube links with their SSL equivalents.
I've also replaced the YouTube playlist embedding with the iframe version as embed support for youtube playlists seems to be non-existent and I can't get the existing code to work under any circumstances.
I've also taken the opportunity to add a missing <span> around the iframe for youtube videos.

Dan Poltawski
added a comment - 26/Jul/12 1:09 PM Thanks for taking this Andrew.
Some comments:
Please could you put a brief mention of why we are forcing https in the commit message. I'm sure there will be some https haters, so worth putting the rationale in.
The xml strict headers stuff is removed in master, so you'll need to correct the patch for that
It'll be easier for us to integrate this if you state the range of browsers you've tested this change on.
cheers,
dan

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

Aparup Banerjee
added a comment - 27/Jul/12 1:47 AM The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao

If possible could you please produce branches for the stable versions you'd like this to be backported to.
Looks to me like it would be well worth backporting, but I see there are conflicts when backporting.

Sam Hemelryk
added a comment - 31/Jul/12 8:20 AM Hi Andrew,
If possible could you please produce branches for the stable versions you'd like this to be backported to.
Looks to me like it would be well worth backporting, but I see there are conflicts when backporting.
Cheers
Sam

Andrew Nicols
added a comment - 31/Jul/12 4:35 PM Hi Sam,
Apologies for that - the original change did cherry-pick cleanly into 2.3, but the xmlstrict change last week broke that and I forgot to create an appropriate branch.
This will revert back to the object embedding method rather than iframes if xmlstrictheaders is set for YouTube Videos only.

The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P
Apologies for the inconvenience, this will be integrated next week. Thanks for your collaboration & ciao

Dan Poltawski
added a comment - 02/Aug/12 3:06 PM The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.
This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P
Apologies for the inconvenience, this will be integrated next week. Thanks for your collaboration & ciao