Issues for all projectshttps://www.drupal.org/project/issues?text=&projects=&status=Open&priorities=All&categories=All
enForm element datetime fail at Datetime class validationhttps://www.drupal.org/node/2544400
<p>When I created a form element</p>
<div class="codeblock"><code>$dateDefault = new DrupalDateTime($date);<br /> $form['entry']['date'] = array(<br /> '#type' =&gt; 'datetime',<br /> '#date_date_element' =&gt; 'date',<br /> '#date_time_element' =&gt; 'time',<br /> '#required' =&gt; TRUE,<br /> '#default_value' =&gt; $dateDefault,<br /> '#weight' =&gt; 100,<br /> );</code></div>
<p>This error appear</p>
<p>Fatal error: Cannot use object of type Drupal\Core\Datetime\DrupalDateTime as array in .../core/lib/Drupal/Core/Datetime/Element/Datetime.php on line 345</p>
<p>but the real problem is in this code line<br />
$form_state-&gt;setValueForElement($element, $date);<br />
line 357</p>
Sun, 02 Aug 2015 22:21:26 +0000vachohttps://www.drupal.org/node/2544400Port to drupal 8https://www.drupal.org/node/2544184
<p>I open this issue because I think drupal 8 has the same generic permission for menus.<br />
Is there any plans to port this?</p>
Sun, 02 Aug 2015 11:13:40 +0000rodrigoaguilerahttps://www.drupal.org/node/2544184Translate RFC 5424 log levels to appropriate hook_requirements() values.https://www.drupal.org/node/2544398
Sun, 02 Aug 2015 22:13:25 +0000twistorhttps://www.drupal.org/node/2544398KernelTestBaseNG™https://www.drupal.org/node/2304461
<h2>Mission</h2>
<ol><li>Run all functional integration tests via PHPUnit.</li>
<li>Convert <code>KernelTestBase</code> into a PHPUnit test base class.</li>
<li>Add a second Kernel <em>test suite</em>, separate from the Unit test suite.</li>
</ol><h2>Why</h2>
<ul><li>Drupal should not be in the business of developing a testing framework.</li>
</ul><ol><li>It will be possible that ~60% of Drupal's total test coverage is "rebased" onto PHPUnit, running entirely in memory.</li>
<li>Many kernel tests <em>should</em> be refactored into pure unit tests. Now they already operate in PHPUnit. Major milestone.</li>
<li>2 of 3 test suites can be executed sans any Drupal [QA] infrastructure. → <a href="https://travis-ci.org/sun/drupal" rel="nofollow">Proof.</a></li>
<li>PHPUnit is much more strict regarding unintended errors than Simpletest. It prevents more bugs and thus improves software quality. Also, it cleanly isolates tests (if necessary).</li>
</ol><h2>How</h2>
<ol><li>
<ul><li>Step 1: Add KernelTestBase itself as well as some basic integration test and fixing of related problems</li>
<li>Step 2: Convert the existing tests, which will fix various bits of code in multiple places and improve Drupal itself, see <span class="project-issue-issue-link project-issue-status-info project-issue-status-1"><a href="/node/2456477" title="Status: Active">#2456477: [meta] Convert existing \Drupal\simpletest\KernelTestBase tests to KernelTestBaseNG</a></span></li>
</ul><p>After 4 weeks of <em>permanent</em> work on porting KernelTestBase + <a href="https://github.com/sebastianbergmann/phpunit/issues?q=author%3Asun" rel="nofollow">fixing PHPUnit upstream</a>, mission accomplished:</p>
<pre>
OK (904 tests, 10081 assertions)
Time: 14.04 minutes, Memory: 269.25Mb
</pre><p>
This work revealed many bogus tests in HEAD + fixes <em>most</em> remaining SQLite Database driver issues. (See <em>Child issues</em>.)
</p></li>
<li>
<p>Discuss whether to restructure PHPUnit test directories for discovery purposes:</p>
<pre>
Test "type" Location
-------------- -------------------------------
Unit ./tests/src/Unit/*Test.php
Kernel ./tests/src/Kernel/*Test.php
</pre><p>
→ <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2260121" title="Status: Closed (fixed), Assigned to: sun">#2260121: PHPUnit Tests namespace of modules is ambiguous with regular runtime namespace (+ Simpletest tests)</a></span></p>
<p>Based on that decision,</p>
<ol type="A"><li>Either move all kernel test files + adjust their namespace and use statements</li>
<li>Or adjust the use statements only.</li>
</ol></li>
<li>
<p>Rebase, squash, and merge the final branch into Drupal core.
</p></li>
</ol><h2>Technical overview</h2>
<ol><li>Drop-in replacement for <code>Drupal\simpletest\KernelTestBase</code>.</li>
<li>Operates entirely in memory; no artifacts. (vfsStream, <code>sqlite::memory:</code>)</li>
<li>Highly optimized for performance.</li>
<li>Leverages latest &amp; greatest features of Drupal's dependencies. (PHPUnit, vfsStream, Psr\Log)</li>
<li>Forward-compatible with PHPUnit 4.3.</li>
</ol><h3>API additions/changes</h3>
<ol><li>New: <code>Drupal\Tests\KernelTestBase</code></li>
<li>New BC layer: <code>Drupal\Tests\AssertLegacyTrait</code> — to be removed before 8.0.0.</li>
</ol><p><code>Drupal\simpletest\KernelTestBase</code> remains unchanged — to be removed before 8.0.0.</p>
<h4>Upgrading</h4>
<ol><li>Use the new base class:
<div class="codeblock"><code class="diff">-use Drupal\simpletest\KernelTestBase;<br />+use Drupal\Tests\KernelTestBase;</code></div>
</li>
<li>Ensure that all custom class properties are properly declared (and not overloaded).</li>
<li>Run the test with <code>--verbose</code> (enabled by default) and check the test output, especially for deprecated warnings.</li>
</ol><p>In 99% of all cases, step (1) is sufficient.</p>
<h3>Dependencies</h3>
<ol><li>Fix virtual filesystem: <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2313989" title="Status: Closed (fixed), Assigned to: sun">#2313989: Update vfsStream to 1.3.0</a></span></li>
<li>Fix test class property overloading: <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2306539" title="Status: Closed (fixed), Assigned to: sun">#2306539: FieldUnitTestBase::createFieldWithInstance() pollutes test class with arbitrary properties</a></span></li>
<li>Fix bogus tests: <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2314123" title="Status: Closed (fixed), Assigned to: sun">#2314123: Fix various tests</a></span></li>
<li>Fix bogus ScriptTest: <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2261477" title="Status: Closed (fixed), Assigned to: sun">#2261477: Remove broken Drupal\system\Tests\ScriptTest</a></span></li>
<li>Fix bogus theme calls + error reporting: <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2301245" title="Status: Closed (fixed), Assigned to: sun">#2301245: Entity system invokes non-existing theme hooks: "Theme hook $entity_type_id not found."</a></span></li>
<li>Fix bogus Entity Query Aggregate test: <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2315269" title="Status: Closed (fixed)">#2315269: Entity/Query/Sql/QueryAggregate: PDOException: General error: GROUP BY clause is required before HAVING</a></span></li>
</ol><h3>Related issues</h3>
<table><tr><td valign="top">Change namespace for PHPUnit tests</td>
<td><span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2260121" title="Status: Closed (fixed), Assigned to: sun">#2260121: PHPUnit Tests namespace of modules is ambiguous with regular runtime namespace (+ Simpletest tests)</a></span></td>
</tr><tr><td valign="top">Service Container self-reference breaks PHP GC</td>
<td><a href="https://github.com/symfony/symfony/pull/11422" rel="nofollow">symfony/symfony#11422</a> (merged)</td>
</tr><tr><td valign="top">Fail upon unexpected severe log messages</td>
<td><span class="project-issue-issue-link project-issue-status-info project-issue-status-13"><a href="/node/652394" title="Status: Needs work, Assigned to: sun">#652394: Aggressive watchdog message assertion</a></span> (now built-in)</td>
</tr><tr><td valign="top">Use TestDiscovery in bootstrap.php</td>
<td><span class="project-issue-issue-link project-issue-status-info project-issue-status-8"><a href="/node/2301873" title="Status: Needs review, Assigned to: sun">#2301873: Use TestDiscovery to register test namespaces for running PHPUnit</a></span></td>
</tr><tr><td valign="top">Fix file discovery in phpunit.xml.dist<br />
.</td>
<td><span class="project-issue-issue-link project-issue-status-info project-issue-status-18"><a href="/node/2203747" title="Status: Closed (cannot reproduce)">#2203747: Current PHPUnit configuration scans into contrib vendor dirs</a></span><br /><span class="project-issue-issue-link project-issue-status-info project-issue-status-8"><a href="/node/2287925" title="Status: Needs review">#2287925: Profiles and themes can't contain PHPUnit tests</a></span>
</td>
</tr><tr><td valign="top">Views uses CONCAT_WS() but not supported</td>
<td><span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2427311" title="Status: Closed (fixed)">#2427311: SQLite does not natively support CONCAT_WS()</a></span></td>
</tr><tr><td valign="top"><del>Port @requires to Simpletest</del></td>
<td><del><span class="project-issue-issue-link project-issue-status-info project-issue-status-1"><a href="/node/1273478" title="Status: Active">#1273478: Fully implement @requires and mark tests with unmet requirements as 'skipped'</a></span></del></td>
</tr><tr><td valign="top">Improve test @group annotations<br />
.<br />
.</td>
<td><span class="project-issue-issue-link project-issue-status-info project-issue-status-1"><a href="/node/2297541" title="Status: Active">#2297541: [policy, no patch] Secondary/additional test @group names</a></span><br /><span class="project-issue-issue-link project-issue-status-info project-issue-status-1"><a href="/node/2296615" title="Status: Active, Assigned to: sun">#2296615: Change Simpletest test listing UI to support multiple @groups per test class</a></span><br /><span class="project-issue-issue-link project-issue-status-info project-issue-status-13"><a href="/node/2301481" title="Status: Needs work">#2301481: Remove duplicate test groups</a></span>
</td>
</tr><tr><td valign="top">Migrate Web tests to Mink + Guzzle</td>
<td><span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2232861" title="Status: Closed (fixed)">#2232861: Create BrowserTestBase for web-testing on top of Mink</a></span></td>
</tr><tr><td valign="top"></td>
<td></td>
</tr></table><hr /><p>Full (rebased/polished) history: <a href="https://github.com/sun/drupal/pull/2" rel="nofollow">sun/drupal#2</a> + <a href="https://github.com/sun/drupal/pull/1" rel="nofollow">sun/drupal#1</a></p>
<h4 id="beta-evaluation">Beta phase evaluation</h4>
<!--Uncomment the relevant rows for the issue. --><table><caption>Reference: <a href="https://www.drupal.org/core/beta-changes">https://www.drupal.org/core/beta-changes</a></caption>
<tbody><tr><th><a href="https://www.drupal.org/core/issue-category" rel="nofollow">Issue category</a></th>
<td>Task, because it enables an entire better world of testing</td>
</tr><tr><th><a href="https://www.drupal.org/core/issue-priority" rel="nofollow">Issue priority</a></th>
<td>Major because it improves the DX, removes fragility and is part of the general testing API overhaul </td>
</tr><tr><th><a href="https://www.drupal.org/core/beta-changes#unfrozen" rel="nofollow">Unfrozen changes</a></th>
<td>Unfrozen because it only changes tests.</td>
</tr><!--<tr><th><a href="https://www.drupal.org/core/beta-changes#prioritized">Prioritized changes</a></th><td>The main goal of this issue is usability/accessibility/security/performance/removing code already deprecated for 8.0.0/Migrate. (Which? Specify.)</td></tr>--><!--<tr><th><a href="https://www.drupal.org/core/beta-changes#disruption">Disruption</a></th> <td>Disruptive for core/contributed and custom modules/themes because it will require a BC break/deprecation/data model changes/an upgrade path/internal refactoring/widespread changes... (Which? Specify.)</td></tr>--></tbody></table>Wed, 16 Jul 2014 18:36:01 +0000sunhttps://www.drupal.org/node/2304461XHTML is not a thing anymore, remove &lt;!--//--&gt;&lt;![CDATA[//&gt;&lt;!-- //--&gt;&lt;!]]&gt; for escaping inline JS/CSShttps://www.drupal.org/node/2120113
<p>Like the title says. </p>
<p>I'm not seeing where it'd actually be used for escaping the JS. Serving XHTML as application/xml never took off because (thanks to?) IE.</p>
Fri, 25 Oct 2013 03:55:04 +0000nod_https://www.drupal.org/node/2120113Use phpspec/prophecy for mockshttps://www.drupal.org/node/2538794
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>@dawehner pointed out that PHPUnit now ships with phpspec/prophecy, a mocking framework.<br />
I wanted to try it out, figured page_manager would be a good candidate.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Use phpspec/prophecy for mocks</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<p>Decide if this is actually an improvement<br />
Figure out how to replace getMockBuilder calls</p>
<h3 id="summary-ui-changes">User interface changes</h3>
<p>N/A</p>
<h3 id="summary-api-changes">API changes</h3>
<p>N/A</p>
<h3 id="summary-data-model-changes">Data model changes</h3>
<p>N/A</p>
Thu, 23 Jul 2015 21:24:07 +0000tim.plunketthttps://www.drupal.org/node/2538794MBP breaks on postgresql databasehttps://www.drupal.org/node/2544394
<p>Hello,</p>
<p>MBP installed on drupal running postgreqs 9.3.<br />
Building folders tree produces nothing.<br />
Looking at the browser view produces silent errors on postgreql logs:</p>
<p>2015-08-02 23:51:18 CEST ERROR: column reference "fid" is ambiguous at character 617<br />
2015-08-02 23:51:18 CEST STATEMENT: SELECT COUNT(*) AS expression<br />
FROM<br />
(SELECT file_managed.fid AS fid, file_managed.timestamp AS file_managed_timestamp, 1 AS expression<br />
FROM<br />
file_managed file_managed<br />
LEFT JOIN file_usage file_usage ON file_managed.fid = file_usage.fid<br />
LEFT JOIN field_data_field_folder field_data_field_folder ON file_managed.fid = field_data_field_folder.entity_id AND (field_data_field_folder.entity_type = 'file' AND field_data_field_folder.deleted = '0')<br />
WHERE (( (file_managed.status IN ('0', '1')) )AND( (field_data_field_folder.field_folder_tid IS NULL ) OR (field_data_field_folder.field_folder_tid IN ('40')) ))<br />
GROUP BY fid, file_managed_timestamp) subquery...</p>
<p>Was this module tested againt pg database ?</p>
<p>Thx</p>
Sun, 02 Aug 2015 21:56:28 +0000oturpinhttps://www.drupal.org/node/2544394Views token cleanup: internally some tokens have curly-brackets, other do nothttps://www.drupal.org/node/2544392
<p>Followup from: <span class="project-issue-issue-link project-issue-status-info project-issue-status-1"><a href="/node/2492839" title="Status: Active">#2492839: Follow-up: Convert Views' %n and !n replacement tokens to Twig syntax</a></span>. Internally some Views tokens (such as row tokens) are passed with the curly-brackets. Others (such as argument tokens) are not. This needs to be cleaned up.</p>
<p>This issue is postponed on <span class="project-issue-issue-link project-issue-status-info project-issue-status-1"><a href="/node/2492839" title="Status: Active">#2492839: Follow-up: Convert Views' %n and !n replacement tokens to Twig syntax</a></span>.</p>
Sun, 02 Aug 2015 21:56:07 +0000mikekerhttps://www.drupal.org/node/2544392Remove \Drupal\Core\Render\Element\HtmlTaghttps://www.drupal.org/node/2544318
<p>As part of <span class="project-issue-issue-link project-issue-status-info project-issue-status-8"><a href="/node/2296101" title="Status: Needs review">#2296101: Remove SafeMarkup::set() use in \Drupal\Core\Render\Element\HtmlTag::preRenderHtmlTag()</a></span>, we identified the potential improvement of removing <code>#type =&gt; 'html_tag'</code> (including dawherner in <a href="https://www.drupal.org/node/2296101#comment-9305541" rel="nofollow">#4</a> and catch in <a href="https://www.drupal.org/node/2296101#comment-9914219" rel="nofollow">#7</a>. </p>
<p>From <a href="https://www.drupal.org/node/2296101#comment-10178050" rel="nofollow">#38</a>:</p>
<blockquote><p>[T]he non-test uses [of <code>#type =&gt; 'html_tag'</code>] in core can be grouped into 2 categories: elements such as , , and , and simple combinations where SafeMarkup::format could be used instead.</p>
<p>_drupal_add_html_head() is listed as deprecated (<span class="project-issue-issue-link project-issue-status-info project-issue-status-13"><a href="/node/2477223" title="Status: Needs work">#2477223: Remove _drupal_add_html_head, drupal_get_html_head and _drupal_add_html_head_link from common.inc and usage</a></span>), so we may need to postpone on that. In the meantime, we could work on the 6 places where non-head-type tags are using this #type? (One of those places is FilterCaption.php, which has its own use of SafeMarkup).</p></blockquote>
Sun, 02 Aug 2015 17:09:15 +0000akalatahttps://www.drupal.org/node/2544318Add more test coverage for node/file verbose fields.https://www.drupal.org/node/2542852
<p>Follow-up to <span class="project-issue-issue-link project-issue-status-info project-issue-status-2"><a href="/node/2525432" title="Status: Fixed">#2525432: Separate text fields per verbose extra field</a></span></p>
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>Creating sensors for nodes and files needs a better test coverage with every field and check if the output is correct.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Add test for all available fields of node and file.</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<h3 id="summary-ui-changes">User interface changes</h3>
<h3 id="summary-api-changes">API changes</h3>
<h3 id="summary-data-model-changes">Data model changes</h3>
Thu, 30 Jul 2015 14:15:31 +0000giancarlosotelohttps://www.drupal.org/node/2542852[D7] Wunderlisthttps://www.drupal.org/node/2526480
<p>With this module you can access your Wunderlist account and:<br />
- view your tasks<br />
- @toDo: update your tasks<br />
- @toDo: delete your tasks<br />
- @toDo: add default view</p>
<p>Sandbox page: <a href="https://www.drupal.org/sandbox/falc0/2442747" rel="nofollow">https://www.drupal.org/sandbox/falc0/2442747</a></p>
<p>git clone --branch 7.x-1.x <a href="http://git.drupal.org/sandbox/falc0/2442747.git">http://git.drupal.org/sandbox/falc0/2442747.git</a> wunderlist<br />
cd wunderlist</p>
Sun, 05 Jul 2015 21:07:58 +0000falc0https://www.drupal.org/node/2526480Verify stability with existing jobs when deleting a translatorhttps://www.drupal.org/node/2538360
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>From the code it is unclear if things break fatal, or if TMGMT still works fine if we have jobs / items assigned to a translator... and then delete the translator.</p>
<p>All cases, from new jobs, submitted, needs review and closed need to be tested.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>If it breaks, fix.<br />
I guess a test should cover these cases.</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<h3 id="summary-ui-changes">User interface changes</h3>
<h3 id="summary-api-changes">API changes</h3>
<h3 id="summary-data-model-changes">Data model changes</h3>
Thu, 23 Jul 2015 10:57:59 +0000miro_dietikerhttps://www.drupal.org/node/2538360Add all the DefaultTableMapping public methods to TableMappingInterfacehttps://www.drupal.org/node/2542282
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>Following plublic methods have are not defined on any interface:</p>
<div class="codeblock"><code>DefaultTableMapping::setFieldNames<br />DefaultTableMapping::setExtraColumns<br />DefaultTableMapping::allowsSharedTableStorage<br />DefaultTableMapping::requiresDedicatedTableStorage<br />DefaultTableMapping::getDedicatedTableNames<br />DefaultTableMapping::getDedicatedDataTableName<br />DefaultTableMapping::getDedicatedRevisionTableName</code></div>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Either add all the DefaultTableMapping public methods to TableMappingInterface or introduce new interface</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<p>Finalize the aporch and write a patch</p>
<h3 id="summary-ui-changes">User interface changes</h3>
<p>None</p>
<h3 id="summary-api-changes">API changes</h3>
<p>None</p>
<h3 id="summary-data-model-changes">Data model changes</h3>
<p>None</p>
<h4 id="beta-evaluation">Beta phase evaluation</h4>
<!--Uncomment the relevant rows for the issue. --><table><caption>Reference: <a href="https://www.drupal.org/core/beta-changes">https://www.drupal.org/core/beta-changes</a></caption>
<tbody><tr><th><a href="https://www.drupal.org/core/issue-category" rel="nofollow">Issue category</a></th>
<td>Task because simple adds method to interface</td>
</tr><tr><th><a href="https://www.drupal.org/core/issue-priority" rel="nofollow">Issue priority</a></th>
<td>Normal because nothing is broken </td>
</tr><!--<tr><th><a href="https://www.drupal.org/core/beta-changes#unfrozen">Unfrozen changes</a></th> <td>Unfrozen because it only changes CSS/markup/strings/documentation/tests. (Which? Specify.)</td></tr>--><!--<tr><th><a href="https://www.drupal.org/core/beta-changes#prioritized">Prioritized changes</a></th><td>The main goal of this issue is usability/accessibility/security/performance/removing code already deprecated for 8.0.0/Migrate. (Which? Specify.)</td></tr>--><tr><th><a href="https://www.drupal.org/core/beta-changes#disruption" rel="nofollow">Disruption</a></th>
<td>Non Disruptive for core/contributed and custom modules/themes </td>
</tr></tbody></table>Wed, 29 Jul 2015 17:37:57 +0000jibranhttps://www.drupal.org/node/2542282test issue for _drupal_log_error, DefaultExceptionSubscriber::onHtml, Error::renderExceptionSafehttps://www.drupal.org/node/2544380
<p>Test issue, trying to find proof of test coverage, and dont want to post patches on the main issue and confuse things there.</p>
Sun, 02 Aug 2015 21:13:06 +0000YesCThttps://www.drupal.org/node/2544380Fix shortcut action link styling in bartikhttps://www.drupal.org/node/2544390
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>Enable <code>shortcut.module_link</code> setting for bartik to show shortcut action link.</p>
<div class="codeblock">
<pre><code><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br /></span><span style="color: #007700">\</span><span style="color: #0000BB">Drupal</span><span style="color: #007700">::</span><span style="color: #0000BB">configFactory</span><span style="color: #007700">()-&gt;</span><span style="color: #0000BB">getEditable</span><span style="color: #007700">(</span><span style="color: #DD0000">'bartik.settings'</span><span style="color: #007700">)-&gt;</span><span style="color: #0000BB">set</span><span style="color: #007700">(</span><span style="color: #DD0000">'third_party_settings.shortcut.module_link'</span><span style="color: #007700">, </span><span style="color: #0000BB">TRUE</span><span style="color: #007700">)-&gt;</span><span style="color: #0000BB">save</span><span style="color: #007700">(</span><span style="color: #0000BB">TRUE</span><span style="color: #007700">);<br /></span><span style="color: #0000BB">?&gt;</span></span></code></pre></div>
<p><img src="/files/issues/screenshot-d8.dev%202015-08-03%2002-37-01.png" alt="" /><img src="/files/issues/Screenshot%20from%202015-08-03%2002%3A37%3A13.png" alt="" /><br /></p><h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Fixed the styling</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<p>Review.<br />
Commit.</p>
<h3 id="summary-ui-changes">User interface changes</h3>
<h4>Before</h4>
<p><img src="/files/issues/screenshot-d8.dev%202015-08-03%2002-37-01.png" alt="" /><img src="/files/issues/Screenshot%20from%202015-08-03%2002%3A37%3A13.png" alt="" /><br /></p><h4>After</h4>
<p><img src="/files/issues/screenshot-d8.dev%202015-08-03%2002-32-33.png" alt="" /><img src="/files/issues/Screenshot%20from%202015-08-03%2002%3A32%3A45.png" alt="" /><br /></p><h3 id="summary-api-changes">API changes</h3>
<p>None</p>
<h3 id="summary-data-model-changes">Data model changes</h3>
<p>None</p>
Sun, 02 Aug 2015 21:44:00 +0000jibranhttps://www.drupal.org/node/2544390When transactions fail, no details are recordedhttps://www.drupal.org/node/2461897
<p>I have the 7.x-1.x-dev module installed. I have our Merchant ID, Merchant key, and Sage Payment Solutions server defined the same as they were on a functional Drupal 6 version of the same store. This is a site where I've upgraded from Drupal 6 to Drupal 7.</p>
<p>Ubercart works fine with sending information to PayPal with that payment option selected. But when the Credit Card payment option is selected, it isn't working. Everything works fine on the checkout page. Then everything is fine on the Review Order page. But then when I hit Submit Order, the site redirects me to the checkout page with no indication of success or error with the order. The order shows in Ubercart's View Orders page as being "In Checkout". So the order is not completing with Sage Payment Solutions.</p>
<p>Please advise on what to do to get this working. As is, we are forced to eliminate the credit card payment option and only use PayPal.</p>
Sun, 29 Mar 2015 21:58:34 +0000wildlifehttps://www.drupal.org/node/2461897Avoid fatal error when flagged entity is missing in flag_user_account_removal()https://www.drupal.org/node/2501575
<p>There isn't really a good solution but we can't unflag if the entity is gone, maybe just delete them, didn't look closely, just had to fix the fatal error.</p>
<p>This is actually quite likely to happen right now because flag_entity_delete() is not implemented. But if when it will be, I think making sure that this doesn't fail hard is important.</p>
Sat, 06 Jun 2015 11:17:41 +0000Berdirhttps://www.drupal.org/node/2501575Fatal error when clicking &#039;in progress&#039; without a translatorhttps://www.drupal.org/node/2504639
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>When an item is in the progress of being translated, there is an 'in progress' link on /admin/tmgmt/items/17?destination=node/6/translations which leads to a fatal error when you click on it.<br /><code>( ! ) Fatal error: Call to a member function getPluginId() on a non-object in /usr/local/var/www/d8/www/modules/tmgmt/src/Form/JobItemForm.php on line 430</code></p>
<p>Steps to reproduce: </p>
<ul><li>make sure there iis no translator available for translating</li>
<li>request translation for a node </li>
<li>go back</li>
<li>click on "In progress"</li>
</ul><h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Fix the issue, provide patch, review it and then commit it.</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<p>All of them.</p>
<h3 id="summary-ui-changes">User interface changes</h3>
<p>'<br />
None</p>
<h3 id="summary-api-changes">API changes</h3>
<p>None</p>
Thu, 11 Jun 2015 15:42:34 +0000LKS90https://www.drupal.org/node/2504639AJAX error when switching between Content and Locale dropdownhttps://www.drupal.org/node/2540696
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>When switching between Content and Locale in the /admin/tmgmt/sources/content/node you get an ajax error.</p>
<div class="codeblock"><code>Uncaught AjaxError: <br />An AJAX HTTP error occurred.<br />HTTP Result Code: 500<br />Debugging information follows.<br />Path: /admin/tmgmt/sources/content/node?ajax_form=1<br />StatusText: Internal Server Error<br />ResponseText: {"message":"A fatal error occurred: SQLSTATE[42S22]: Column not found: 1054 Unknown column \u0027e.ajax_form\u0027 in \u0027where clause\u0027: SELECT e.nid AS nid\nFROM \n{node} e\nINNER JOIN {node_field_data} data_table ON data_table.nid = e.nid AND data_table.default_langcode = 1\nWHERE (e.type IN (:db_condition_placeholder_0)) AND (e.ajax_form IN (:db_condition_placeholder_1)) AND (e._wrapper_format IN (:db_condition_placeholder_2)) AND (data_table.langcode IN (:db_condition_placeholder_3, :db_condition_placeholder_4, :db_condition_placeholder_5)) \nORDER BY nid DESC\nLIMIT 20 OFFSET 0; Array\n(\n [:db_condition_placeholder_0] =\u003E translatable_node\n [:db_condition_placeholder_1] =\u003E 1\n [:db_condition_placeholder_2] =\u003E drupal_ajax\n [:db_condition_placeholder_3] =\u003E en\n [:db_condition_placeholder_4] =\u003E de\n [:db_condition_placeholder_5] =\u003E fr\n)\n"}</code></div>
<p>Steps to Recreate:</p>
<p>1.- visit /admin/tmgmt/sources/content/node.<br />
2.- Select from the dropdown Locale.<br />
3.- Wait until the ajax form loads and gives the error.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Check the ajax form post and see any errors for locale.</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<h3 id="summary-ui-changes">User interface changes</h3>
<p><img src="/files/issues/Screen%20Shot%202015-07-27%20at%2017.54.32.png" alt="Error Demo" /><br /></p><h3 id="summary-api-changes">API changes</h3>
<h3 id="summary-data-model-changes">Data model changes</h3>
<h3 id="summary-original-report">Original report by [username]</h3>
Mon, 27 Jul 2015 15:58:46 +0000juanse254https://www.drupal.org/node/2540696Add Placeholder Optionhttps://www.drupal.org/node/2543840
<p>There are times when we want a large form to be smaller, one good technique is to change the Labels by Placeholder inside the field. The most recent version of the Webforms, have components that includes this option "Placeholder". It would be good if we had this option for this incredible autocomplete component.</p>
Sat, 01 Aug 2015 04:40:41 +0000cristian100https://www.drupal.org/node/2543840[meta] Convert hook_element_info() to RenderElement and FormElement pluginshttps://www.drupal.org/node/2311393
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>Follow-up to <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2305839" title="Status: Closed (fixed)">#2305839: Convert hook_element_info() to annotated classes</a></span><br />
Will likely be broken down per-module.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<h3 id="summary-ui-changes">User interface changes</h3>
<h3 id="summary-api-changes">API changes</h3>
Mon, 28 Jul 2014 21:27:26 +0000tim.plunketthttps://www.drupal.org/node/2311393Update doRequest method to Guzzle 6https://www.drupal.org/node/2539228
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>Guzzle has been upgraded to version 6.0.2 and that changed how requests have to be done. The google translator is currently broken and doesn't work at all. This issue tries to fix this by starting to update to Guzzle 6.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Fix the request generation in doRequest()</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<p>Review Patch, discuss some more issues which need fixing, commit patch.</p>
<h3 id="summary-ui-changes">User interface changes</h3>
<p>None</p>
<h3 id="summary-api-changes">API changes</h3>
<p>None</p>
<h3 id="summary-data-model-changes">Data model changes</h3>
<p>None</p>
Fri, 24 Jul 2015 14:13:12 +0000LKS90https://www.drupal.org/node/2539228Update requests to be guzzle 6 compatiblehttps://www.drupal.org/node/2540652
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>Same change was necessary for google and microsoft translators: Guzzle has been updated to 6.0.2 and requests are now immutable and in general a little different.<br />
Update all requests so we can sucessfully query gengo again.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>See <span class="project-issue-issue-link project-issue-status-info project-issue-status-8"><a href="/node/2539228" title="Status: Needs review">#2539228: Update doRequest method to Guzzle 6</a></span> or <span class="project-issue-issue-link project-issue-status-info project-issue-status-8"><a href="/node/2537790" title="Status: Needs review">#2537790: Update all requests to Guzzle 6 compatible variant.</a></span> or <a href="http://guzzle.readthedocs.org/en/latest/quickstart.html#making-a-request" rel="nofollow">Guzzle documentation</a>. MAybe it's not really necessary either, I just assume the request are not correct and need updating.</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<p>Find broken request, fix them, provide patch, review and commit.</p>
<h3 id="summary-ui-changes">User interface changes</h3>
<p>None</p>
<h3 id="summary-api-changes">API changes</h3>
<p>None</p>
<h3 id="summary-data-model-changes">Data model changes</h3>
<p>None</p>
Mon, 27 Jul 2015 15:22:44 +0000LKS90https://www.drupal.org/node/2540652Captcha not showing only for a few usershttps://www.drupal.org/node/2544384
<p>I can't tell if this is a Captcha issue, or Recaptcha. It concerns the "I'm not a robot" and/or the image captcha showing, or in this case NOT showing, on the forum topic form.</p>
<p>Out of several hundred registered users, all of whom have the same roles, neither the "robot" checkbox nor the image captcha are showing on the forum topic form *only* for three users. Yet when they try to save the forum node, they get the message "The answer you entered for the CAPTCHA was not correct."</p>
<p>As far as I can tell, there's nothing special about those three users. I got one of them to clear the caches in his browser (Safari on iPhone 5S), but that didn't help. That user was accessing from China - the other two are from Australia and Germany. I only mention that because the one in China finally used a VPN to access from a Korean IP, and then he was able to post just fine - that is, he saw the Captcha field and responded correctly to it.</p>
<p>If you need additional information, I'll be happy to provide it if I can.</p>
Sun, 02 Aug 2015 21:29:46 +0000ExTexanhttps://www.drupal.org/node/2544384Sticky Edit Actions CSS conflicthttps://www.drupal.org/node/2320313
<p>This theme doesn't work well with sticky_edit_actions (see the related issue I created over there).</p>
<p>I don't know if Shiny or Sticky Edit Actions should be patched.. here's the CSS I add to sticky-edit-actions.css to make it work :</p>
<div class="codeblock"><code>/* Fix Shiny administration theme */<br />.form-actions #edit-submit, .form-actions #edit-save { padding: 6px 30px !important; }<br />#edit-actions input.form-submit { margin-bottom: 16px !important; }<br />#edit-actions { background: none repeat scroll 0% 0% #FFF !important; padding: 11px 0px 0px !important; }</code></div>
Wed, 13 Aug 2014 02:54:21 +0000PascalAnimateurhttps://www.drupal.org/node/2320313Add/edit node form settings are misleadinghttps://www.drupal.org/node/2537898
<p>The protected node configuration available on the node edit page is confusing for the following reasons:</p>
<ol><li>When the content type is set to "Always protected", the help text on the node edit form still indicates that a checkbox is available when it actually isn't.</li>
<li>The "Show Title" checkbox only matters when the default description text is used. It has no effect when a custom description text is set. </li>
</ol>Wed, 22 Jul 2015 16:35:37 +0000digitgopherhttps://www.drupal.org/node/2537898Remove SafeMarkup::set() use in \Drupal\Core\Render\Element\HtmlTag::preRenderHtmlTag()https://www.drupal.org/node/2296101
<p>Follow-up to: <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/1825952" title="Status: Closed (fixed)">#1825952: Turn on twig autoescape by default</a></span></p>
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>In <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/1825952" title="Status: Closed (fixed)">#1825952: Turn on twig autoescape by default</a></span>, <a href="https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21Element%21HtmlTag.php/function/HtmlTag%3A%3ApreRenderHtmlTag/8" rel="nofollow">\Drupal\Core\Render\Element\HtmlTag::preRenderHtmlTag()</a> assembles HTML markup based on input and it is subsequently marked as safe. However, there is no guarantee that the rendered markup is actually safe.</p>
<p>This is not a security regression because the same is true in HEAD; <code>HtmlTag::preRenderHtmlTag()</code> will render whatever the caller tells it to, so it's the caller's responsibility to sanitize the input. However, this is one of the only places that we are marking as safe markup strings that are not explicitly known to be safe.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<li><del>Remove the call by refactoring the code.</del> Refactor the code so we can be more explicit with what is being sanitized and what we must assume will be safe.</li>
<li>Thoroughly document where the string is coming from and why it is safe, and why SafeMarkup::set() is required. This class may be removed completely in a follow-up task (<span class="project-issue-issue-link project-issue-status-info project-issue-status-4"><a href="/node/2544318" title="Status: Postponed">#2544318: Remove \Drupal\Core\Render\Element\HtmlTag</a></span>).</li>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<ol><li><del>Evaluate whether the string can be refactored to one of the formats outlined in this change record: <a href="https://www.drupal.org/node/2311123">https://www.drupal.org/node/2311123</a></del> COMPLETED</li>
<li>Identify whether there is existing automated test coverage for the sanitization of the string. If there is, list the test in the issue summary. If there isn't, add an automated test for it.</li>
<li>If the string cannot be refactored, the SafeMarkup::set() usage needs to be thoroughly audited and documented. NEEDS REVIEW</li>
</ol><h3 id="summary-manual-testing">Manual testing steps</h3>
<p>Do these steps both with HEAD and with the patch applied:</p>
<ol><li>Install Drupal 8.</li>
<li>Log into Drupal.</li>
<li>Review the HTML of the <code>&lt;script&gt;</code> code block at the bottom of any page. This code block has inline javascript beginning with "var drupalSettings =".</li>
<li>Compare the output above in HEAD and with the patch applied. Confirm that the HTML is identical.</li>
</ol><h3 id="summary-ui-changes">User interface changes</h3>
<p>NA</p>
<h3 id="summary-api-changes">API changes</h3>
<p>NA</p>
Tue, 01 Jul 2014 20:58:33 +0000xjmhttps://www.drupal.org/node/2296101Remove SafeMarkup::set in NodeSearch::prepareResults()https://www.drupal.org/node/2501757
<p><code>Add to commit credit: bohemier</code></p>
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>NodeSearch::prepareResults() calls SafeMarkup::set() which is meant to be for internal use only.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<ul><li>Remove the call by refactoring the code. </li>
<li><del>If refactoring is not possible, thoroughly document where the string is coming from and why it is safe, and why SafeMarkup::set() is required.</del></li>
</ul><h3 id="summary-remaining-tasks">Remaining tasks</h3>
<ol><li><del>Evaluate whether the string can be refactored to one of the formats outlined in this change record: <a href="https://www.drupal.org/node/2311123">https://www.drupal.org/node/2311123</a></del></li>
<li>Identify whether there is existing automated test coverage for the sanitization of the string. If there is, list the test in the issue summary. If there isn't, add an automated test for it.</li>
<li><del>If the string cannot be refactored, the SafeMarkup::set() usage needs to be thoroughly audited and documented.</del></li>
</ol><h3 id="summary-manual-testing">Manual testing steps (for XSS and double escaping)</h3>
<p>Do these steps both with HEAD and with the patch applied:</p>
<ol><li>Clean install of Drupal 8.</li>
<li>Under "Manage" in the administration menu, select "Content", then "Add content" of type "Article". In the body field add the following: <code>Textbefore &lt;script&gt;alert('XSS Body');&lt;/script&gt; textafter</code>
</li>
<li>Under the newly created Article node/1, add comment: <code>Textbefore &lt;script&gt;alert('XSS Comment');&lt;/script&gt; textafter</code>
</li>
<li>Under "Configure" in the administration menu, select "Cron", then select "Run cron" so the search indexer runs (search module is enabled in standard install profile)</li>
<li>From your site homepage search for "textafter"
</li>
</ol><p> Compare the output above in HEAD and with the patch applied. Confirm that there is no double-escaping.</p>
<h3 id="summary-ui-changes">User interface changes</h3>
<p>N/A</p>
<h3 id="summary-api-changes">API changes</h3>
<p>N/A</p>
Sat, 06 Jun 2015 20:31:02 +0000cwellshttps://www.drupal.org/node/2501757Specify a start date for the licensehttps://www.drupal.org/node/2349475
<p>Hello</p>
<p>Do you think it would be able to specify a start date for a license.</p>
<p>I.e. a date when the license start to gets active (and is inactive before hand).<br />
Can I just change the license-&gt;granted value or should I use some custom field in my license?</p>
<p>Any comment/advice welcome</p>
<p>Many Many thanks for your help<br />
All best</p>
<p>Thomas</p>
Fri, 03 Oct 2014 09:54:00 +0000thoomyorkehttps://www.drupal.org/node/2349475First pager link not point to first page but to the same pagehttps://www.drupal.org/node/2544382
<p>This bug appear on Bartic theme.</p>
Sun, 02 Aug 2015 21:17:00 +0000Codenatorhttps://www.drupal.org/node/2544382Remove SafeMarkup::set and Recheck and Mark Safe the Output of Unicode::truncate() in DbLoghttps://www.drupal.org/node/2399261
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>The patch in <span class="project-issue-issue-link project-issue-status-info project-issue-status-7"><a href="/node/2273923" title="Status: Closed (fixed)">#2273923: Remove html =&gt; TRUE option from l() and link generator.</a></span> adds the following code:<br /><code>$log_text = SafeMarkup::set(Unicode::truncate(Xss::filter($message, array()), 56, TRUE, TRUE));</code></p>
<p>As pointed out in comment #2, the assumption that this is safe because truncating a safe string results in a safe string is not true as truncating a string may lead to a malformed HTML entity.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Several approaches for a resolution have been proposed. To summarize these:</p>
<ul><li>In #3 and #5, a parameter was added to Xss::filter() to indicate whether SafeMarkup should be called before returning the truncated string.
<p>We're not taking this approach because, as stated in #6, adding a parameter to Xss::filter() is out of scope of this issue.</p></li>
<li>The next approach (#9, #14, #20, #23, #24, #32) was to add a method to the SafeMarkup class instead of adding a parameter to Xss::filter().
<p>We're not taking this approach because, as stated in #33, it mixes sanitization with SafeMarkup.</p></li>
<li>Then a completely new approach (#35, #36, #38, #42, #43, #51, #54, #56, #61) was proposed which would add a method to the Xss class.
<p>We're not taking this approach because, from #62, truncation has nothing to do with Xss filtering and we shouldn't go over the strings twice.</p></li>
<li>A minimal patch was provided in #69 which removes does not preserve any HTML tags in the truncated output.
<p>Comments #71 and #72 indicate that <strong>this approach is appropriate for this issue</strong> as it simply removes SafeMarkup::set().</p></li>
</ul>Sun, 28 Dec 2014 20:43:28 +0000effulgentsiahttps://www.drupal.org/node/2399261Sticky table headers alignment wronghttps://www.drupal.org/node/2042501
<p>The alignment of the sticky table headers is out. I think it may be a difference in the width calculation due to shiny applying <code>box-sizing: border-box</code>.</p>
Mon, 15 Jul 2013 18:38:08 +0000andrewbelcherhttps://www.drupal.org/node/2042501Error when trying to add new billing typehttps://www.drupal.org/node/2544378
<p>Hello,</p>
<p>Finally get the module installed, when I try to add a new billing type the following two errors occur:</p>
<p>The occurs immediately following the entity-&gt;save() operation in commerce_license_billing_cycle_type_ui.inc:<br /><code>Recoverable fatal error: Argument 2 passed to SelectQuery::fields() must be of the type array, null given, called in /vhosts/wvw.com/original/drupal/includes/entity.inc on line 317 and defined in fields() (line 1301 of /vhosts/wvw.com/original/drupal/includes/database/select.inc). =&gt;</code></p>
<p><code>PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'entity_id' cannot be null: INSERT INTO {field_data_pce_period} (entity_type, entity_id, revision_id, bundle, delta, language, pce_period_value) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6); Array ( [:db_insert_placeholder_0] =&gt; cl_billing_cycle_type [:db_insert_placeholder_1] =&gt; [:db_insert_placeholder_2] =&gt; [:db_insert_placeholder_3] =&gt; periodic [:db_insert_placeholder_4] =&gt; 0 [:db_insert_placeholder_5] =&gt; und [:db_insert_placeholder_6] =&gt; day ) in field_sql_storage_field_storage_write() (line 514 of /vhosts/wvw.com/original/drupal/modules/field/modules/field_sql_</code></p>
<p>Any thoughts?</p>
Sun, 02 Aug 2015 21:11:46 +0000rjdjohnstonhttps://www.drupal.org/node/2544378Make compatible with recommended version of dependencyhttps://www.drupal.org/node/2385777
<p>Changed nothing and tried to enable devel_themer with drush and now I get: </p>
<blockquote><p>Module devel_themer cannot be enabled because it depends on simplehtmldom (1.x) but 2.1 is available</p></blockquote>
<p>The library is there, the lastest version 1.5 and has always worked before. No idea what this means. How to enable it? I need to module urgently.</p>
Tue, 02 Dec 2014 16:44:05 +0000ñullhttps://www.drupal.org/node/2385777Duplicate recordshttps://www.drupal.org/node/2544138
<p>Hi - I suspect this might be a bit of a newbie question, but I don't think it's been asked before.</p>
<p>When I import a XML feed as nodes, it creates the correct number of pages, but they are all identical - same title, same body, everything! No errors are generated and it's obviously reading the XML source.</p>
<p>If I run the import a second time a new set of nodes is imported. So in a feed of 50 nodes, these two imports result in 100 identical nodes.</p>
<p>The same thing happens whether I use a feed I generated myself (<a href="http://xmlout8qgqug4vzd.devcloud.acquia-sites.com/xml-export">http://xmlout8qgqug4vzd.devcloud.acquia-sites.com/xml-export</a>) or the CD catalog example on the W3C website (<a href="http://www.w3schools.com/xml/cd_catalog.xml">http://www.w3schools.com/xml/cd_catalog.xml</a>), so this must be caused by the way I've configured the import.</p>
<p>I've exported my feed import config from the module - if someone has a chance to look at it, I'd be very grateful to find out how I've misconfigured it.</p>
<p>Many thanks in advance.</p>
Sun, 02 Aug 2015 08:26:24 +0000Martin Reedhttps://www.drupal.org/node/2544138Using string argument returns Invalid argument supplied for foreach() in rb_misc_list_variant_context_entities()https://www.drupal.org/node/1468068
<p>Warning: Invalid argument supplied for foreach() in rb_misc_list_variant_context_entities() (line 135 of /Applications/XAMPP/xamppfiles/htdocs/anyjobportal/sites/all/modules/contrib/rb/rb_misc.module).</p>
<p>I created a page in page manager with the path node/%node/status/%update<br />
and set the context of the 2nd argument (3rd position) to String</p>
<p>I then see this message in rules, and in page manager.</p>
Sun, 04 Mar 2012 21:39:42 +0000bjalfordhttps://www.drupal.org/node/1468068Document or remove SafeMarkup::set in twig_render_template() and ThemeManager and FieldPluginBase:advancedRenderhttps://www.drupal.org/node/2501931
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>twig_engine::twig_render_template calls SafeMarkup::set() which is meant to be for internal use only.</p>
<p>Starting with <a href="#comment-10174782" rel="nofollow">#56</a> this issue also addresses <span class="project-issue-issue-link project-issue-status-info project-issue-status-3"><a href="/node/2505679" title="Status: Closed (duplicate)">#2505679: Remove SafeMarkup::set in FieldPluginBase::advancedRender()</a></span> where the problem/motivation was:<br />
FieldPluginBase:advancedRender calls SafeMarkup::set() which is meant to be for internal use only.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<ul><li>(done) Remove the call by refactoring the code. </li>
<li>(SafeString::create() has been documented) If refactoring is not possible, thoroughly document where the string is coming from and why it is safe, and why SafeMarkup::set() is required.</li>
<li>(done) <em>Have ThemeManager return a SafeString object.</em></li>
</ul><h3 id="summary-remaining-tasks">Remaining tasks</h3>
<ol><li>(done) Evaluate whether the string can be refactored to one of the formats outlined in this change record: <a href="https://www.drupal.org/node/2311123">https://www.drupal.org/node/2311123</a></li>
<li>(done. changes were made in ThemeTest.php) Identify whether there is existing automated test coverage for the sanitization of the string. If there is, list the test in the issue summary. If there isn't, add an automated test for it.</li>
<li>(done) If the string cannot be refactored, the SafeMarkup::set() usage needs to be thoroughly audited and documented.</li>
</ol><h3 id="summary-ui-changes">User interface changes</h3>
<p>N/A</p>
<h3 id="summary-api-changes">API changes</h3>
<p>N/A</p>
Sun, 07 Jun 2015 13:26:12 +0000peezyhttps://www.drupal.org/node/2501931#edit-actions #edit-delete float right overlaps with l10n_clienthttps://www.drupal.org/node/2362771
<p>There's an overlap problem with floating the delete button on the right when using l10n_client.. (see attachted screenshot).</p>
<p>Here's a patch to remove the offending float: right in shiny.css</p>
Fri, 24 Oct 2014 02:53:06 +0000PascalAnimateurhttps://www.drupal.org/node/2362771Convert SMS Gateways into D8 Pluginshttps://www.drupal.org/node/2292319
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>Currently gateways are implemented as separate modules with all the code implemented in the foo.module file and callbacks defined in the foo_gateway_info() function. We want to change this approach and implement gateways as D8 Plugins. There are several good reasons to do this:</p>
<ol><li>There is a lot of boiler-plate code and repetition which would be eliminated by implementing gateways as objects, making it easier to write gateways. DX++</li>
<li>Gateway module code is only needed when sending sms via that gateway, but currently is loaded at every page load and kept in memory causing memory bloat. As objects, all that code is lazy-loaded only when needed.</li>
<li>A common interface can be enforced to ensure required methods are implemented.</li>
<li>More than one gateway can be implemented by a single module - less module overhead.</li>
<li>One single gateway plugin can be used to implement multiple gateways.</li>
</ol><p>All the above are the reasons for D8 in the first place and right now is the best practice architecturally.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<ol><li>Implement a gateway plugin manager in sms module that uses AnotatedDiscovery to find sms gateway plugins</li>
<li>Implement a base class for gateway plugins that contains all the basic functionality of sms gateways</li>
<li>Retain the current hook_gateway_info based gateways for backward compatibility and convert them to gateway objects</li>
</ol><h3 id="summary-remaining-tasks">Remaining tasks</h3>
<p>Patch<br />
Reviews / Testing<br />
Commit</p>
<h3 id="summary-ui-changes">User interface changes</h3>
<ol><li>The SMS Default gateway selection page now has checkboxes for enabling / disabling each gateway. Selecting a disabled gateway as default in the UI automatically enables it. But the default gateway cannot be disabled.</li>
<li>Configurable gateways have to be created as they don't exist by default. Non-configurable gateways exist by default once the plugin exists.</li>
</ol><h3 id="summary-api-changes">API changes</h3>
<ol><li>Added a <code>GatewayManagerInterface</code> to represent services that manage sms gateways.</li>
<li>Added a <code>GatewayManager</code> class implementing <code>GatewayManagerInterface</code> and the corresponding <code>plugin.manager.sms_gateway</code> service.</li>
<li>Added the <code>SmsGateway</code> plugin annotation type for annotating gateway plugins.</li>
<li>Added a <code>GatewayInterface</code> to represent SMS Gateways and implemented a <code>GatewayBase</code> base class.</li>
<li>Moved the log gateway to a <code>LogGateway</code> plugin class.</li>
<li>Added a <code>SmsMessageProviderInterface</code> to represent sms messaging providers.</li>
<li>Added a default <code>SmsMessageProviderInterface</code> implementation called <code>DefaultSmsProvider</code> and the corresponding <code>sms_provider.default</code> service, which does basically what the <code>sms_send()</code>, <code>sms_incoming()</code>, <code>sms_receipt()</code>, etc. used to do. More complex implementations of SMS messaging including multiple-gateway routing and load-balancing systems can subclass this default implementation.</li>
<li>Added a <code>DeliveryReportController</code> for receiving and handling delivery reports.</li>
<li>Added a <code>SmsMessageResultInterface</code> to represent the report / result that is returned by sms gateways for sms send requests. A default implementation <code>SmsMessageResult</code> is also added.</li>
</ol>Wed, 25 Jun 2014 09:33:16 +0000almaudohhttps://www.drupal.org/node/2292319Glitch with chosen modulehttps://www.drupal.org/node/2339653
<p>Some weird sprite stuff going on. Please see screenshot.</p>
<p><img src="/files/issues/chosen-shiny-glitch1.png" alt="Chosen glitch" /></p>
Tue, 16 Sep 2014 20:59:08 +0000MrPaulDriverhttps://www.drupal.org/node/2339653Won&#039;t load when &#039;theme_debug&#039; variable is set to truehttps://www.drupal.org/node/2544376
<p>When you have your theme debug variable enabled, the load more button fires, but doesn't load new content. I suspect this is the same issue, or related to, the white space, where the js object has more than one child because of the theme debug comments in the markup.</p>
Sun, 02 Aug 2015 20:55:31 +0000drewbolleshttps://www.drupal.org/node/2544376Promote Al Dia News to Featuredhttps://www.drupal.org/node/2384073
<p>Case study url: <a href="https://www.drupal.org/node/2384067">https://www.drupal.org/node/2384067</a></p>
<p>We're really proud of this site, and hope that you will consider it for inclusion as a featured case study. It's a great example of a responsive, bi-lingual, headless Drupal setup running AngularJS on the front end with a feature-packed editorial workflow on the back-end.</p>
Sat, 29 Nov 2014 05:05:25 +0000jimkellerhttps://www.drupal.org/node/2384073GeoJSON doesn&#039;t work with opened popuphttps://www.drupal.org/node/2544374
<p>I noticed that if you have an opened popup, then you don't reload the markers on map moving/zooming. Which is not ideal at all. I would like to be able to move around (at least at the same zoom level) and keep the popup opened, what would be the best way of doing that?</p>
<p>It is currently not working because you are precisely preventing the reload of the layer in case a popup is opened in leaflet.bbox.js</p>
<div class="codeblock"><code>if (!map._popup) {<br /> // Rebuild the bounded GeoJSON layers.<br /> $.each(Drupal.settings.leafletBBox, function(layer_key, layer_info) {<br /> if (typeof layer_info.url !== 'undefined') {<br /> Drupal.leafletBBox.makeGeoJSONLayer(map, layer_info, layer_key);<br /> }<br />});<br />}</code></div>
<p>I tried a hackish solution by saving the popup identifier (id + type of the source) and its content.</p>
<div class="codeblock"><code> moveEnd: function(e) {<br /> var map = Drupal.leafletBBox.map;<br /> var popup = null;<br /> if (map._popup) {<br /> popup = {'type' : map._popup._source.feature.properties.type, 'id': map._popup._source.feature.properties.geocluster_ids, 'content': map._popup.getContent()};<br /> };
<p> // Rebuild the bounded GeoJSON layers.<br /> $.each(Drupal.settings.leafletBBox, function(layer_key, layer_info) {<br /> if (typeof layer_info.url !== 'undefined') {<br /> Drupal.leafletBBox.makeGeoJSONLayer(map, layer_info, layer_key, popup);<br /> }<br /> });<br /> <br /> }</p></code></div>
<p>Then, I try to identify the same marker if it exists, and if it does, reopen the popup:</p>
<div class="codeblock"><code>// Make a new GeoJSON layer.<br /> $.getJSON(url, function(data) {<br /> var geojsonLayer = new L.GeoJSON(data, Drupal.leafletBBox.geoJSONOptions);
<p> //try to reopen the popup if possible<br /> if (popup)<br /> {<br /> var markers = geojsonLayer._layers;<br /> for (var key in markers) {<br /> if (markers[key].feature.properties.type == popup['type'] &amp;&amp; markers[key].feature.properties.geocluster_ids == popup['id']) {<br /> markers[key].bindPopup(popup['content']);<br /> markers[key].openPopup();<br /> }<br /> }</p>
<p> }</p>
<p> Drupal.leafletBBox.markerGroup[layer_key].clearLayers();<br /> Drupal.leafletBBox.markerGroup[layer_key].addLayer(geojsonLayer);</p></code></div>
<p>It's almost working, but I have some flashing effect on the popup when I am dragging the map around, and I suspect this is because I am removing my layer building the layer without the popup, and only then opening it</p>
<p>What would be the best way of achieving the expected result?<br />
I am currently thinking of browsing through the list of features received via geojson and comparing it with what is currently displayed. Then I will add the features that only exist in the geojson received, and delete the current map features that are not existing in the geojson received.</p>
<p>Any ideas or suggestions?</p>
Sun, 02 Aug 2015 20:49:24 +0000vdshhttps://www.drupal.org/node/2544374Refactor use of SafeMarkup::set in \Drupal\Core\Render\Element\HtmlTag::preRenderConditionalComments()https://www.drupal.org/node/2544262
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>\Drupal\Core\Render\Element\HtmlTag::preRenderConditionalComments() calls SafeMarkup::set() which is meant to be for internal use only.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<ul><li>Remove the call by refactoring the code.</li>
</ul><h3 id="summary-remaining-tasks">Remaining tasks</h3>
<ol><li><del>Evaluate whether the string can be refactored to one of the formats outlined in this change record: <a href="https://www.drupal.org/node/2311123">https://www.drupal.org/node/2311123</a></del>COMPLETED - 4 SafeMarkup::set() converted to SafeMarkup::format()</li>
<li><del>Identify whether there is existing automated test coverage for the sanitization of the string. If there is, list the test in the issue summary. If there isn't, add an automated test for it.</del>Test <code>testPreRenderConditionalComments</code> exists in <code>HtmlTagTest</code></li>
<li><del>If the string cannot be refactored, the SafeMarkup::set() usage needs to be thoroughly audited and documented.</del></li>
</ol><h3 id="summary-manual-testing">Manual testing steps</h3>
<p>Do these steps both with HEAD and with the patch applied:</p>
<ol><li>Install Drupal 8.</li>
<li>Review the HTML of the page in the <code>&lt;head&gt;</code> area, between the <code>&lt;link&gt;</code> and <code>&lt;script&gt;</code> blocks. Look for the conditional comment that begins with <code>&lt;!--[if lte IE 8]&gt;</code>.</li>
<li>Compare the output above in HEAD and with the patch applied. Confirm that the HTML is identical.</li>
</ol><h3 id="summary-ui-changes">User interface changes</h3>
<p>N/A</p>
<h3 id="summary-api-changes">API changes</h3>
<p>N/A</p>
Sun, 02 Aug 2015 14:37:44 +0000akalatahttps://www.drupal.org/node/2544262Delete translation (ET) is styled as normal buttonhttps://www.drupal.org/node/2382657
<p>Shiny moves buttons to delete content to right side (<a href="http://take.ms/vHfv3">http://take.ms/vHfv3</a>) but button to delete translations (entity_translation module) looks like default button (<a href="http://take.ms/BsXh8">http://take.ms/BsXh8</a>).</p>
Wed, 26 Nov 2014 16:24:44 +0000rafal.endenhttps://www.drupal.org/node/2382657Remove SafeMarkup::set in _drupal_log_error, DefaultExceptionSubscriber::onHtml, Error::renderExceptionSafehttps://www.drupal.org/node/2501319
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>_drupal_log_error() calls SafeMarkup::set() which is meant to be for internal use only.</p>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<ul><li>Remove the call by refactoring the code. </li>
<li><del>If refactoring is not possible, thoroughly document where the string is coming from and why it is safe, and why SafeMarkup::set() is required.</del></li>
</ul><h3 id="summary-remaining-tasks">Remaining tasks</h3>
<ol><li><del>Evaluate whether the string can be refactored to one of the formats outlined in this change record: <a href="https://www.drupal.org/node/2311123">https://www.drupal.org/node/2311123</a></del></li>
<li>Identify whether there is existing automated test coverage for the sanitization of the string. If there is, list the test in the issue summary. If there isn't, add an automated test for it.</li>
<li><del>If the string cannot be refactored, the SafeMarkup::set() usage needs to be thoroughly audited and documented.</del></li>
<li>(done) security review asked for in <a href="#comment-10021445" rel="nofollow">#22</a> was done in <a href="#comment-10024329" rel="nofollow">#24</a> by @pfrenssen</li>
</ol><h3 id="summary-manual-testing">Manual testing steps (for XSS and double escaping)</h3>
<p>Do these steps both with HEAD and with the patch applied:</p>
<ol><li>Clean install of Drupal 8.</li>
<li></li>
<li></li>
<li>Compare the output above in HEAD and with the patch applied. Confirm that there is no double-escaping.</li>
<li>If there is any user or calling code input in the string, submit alert('XSS'); and ensure that it is sanitized.</li>
</ol><h3 id="summary-ui-changes">User interface changes</h3>
<p>N/A</p>
<h3 id="summary-api-changes">API changes</h3>
<p>N/A</p>
Fri, 05 Jun 2015 19:02:34 +0000cwellshttps://www.drupal.org/node/2501319Popup loophttps://www.drupal.org/node/2281069
<p>Hi!</p>
<p>When I enter on a site without 'www.' prefix the popup is display in a loop. I can click 'I agree.' button and even if there is no option 'show tank you message' checked it is shown. I can click 'close' button in 'thank you' message, but then it is displayed again and appears in a 'popup loop'.</p>
<p>As a workaround I uncomment this lines from .htaccess:</p>
<div class="codeblock"><code># To redirect all users to access the site WITH the 'www.' prefix,<br /># (http://example.com/... will be redirected to http://www.example.com/...)<br /># uncomment the following:<br />RewriteCond %{HTTP_HOST} .<br />RewriteCond %{HTTP_HOST} !^www\. [NC]<br />RewriteRule ^ http%{ENV:protossl}://www.%{HTTP_HOST}%{REQUEST_URI} [L,R=301]</code></div>
<p>I don't know if it is a bug or it works as designed, I post it here because It can be helpfull for ppl.</p>
<p>Tested on 7.x-1.x-dev (31.05.2014).</p>
Fri, 06 Jun 2014 09:24:32 +0000miczbothttps://www.drupal.org/node/2281069Title always in default language in panelshttps://www.drupal.org/node/2505311
<p>Follow up issue to <a href="https://www.drupal.org/node/1269076:">https://www.drupal.org/node/1269076:</a></p>
<div class="codeblock"><code>+++ b/title.module<br />@@ -642,17 +726,19 @@ function title_tokens_alter(array &amp;$replacements, array $context) {<br />- $langcode = NULL;<br />- if (isset($options['language'])) {<br />- $langcode = $options['language']-&gt;language;<br />- }<br />+ // Since Title tokens are mostly used in storage contexts we default to<br />+ // the current working language, that is the entity language. Modules<br />+ // using Title tokens in display contexts need to specify the current<br />+ // display language.<br />+ $langcode = isset($options['language']) ? $options['language']-&gt;language : entity_language($entity_type, $entity);</code></div>
<p><a href="https://www.drupal.org/commitlog/commit/394/3b41790833f3d231707a97557c050bea0431c257" rel="nofollow">Commit</a> caused another problem. If you render title using panels everywhere - it is always in default language.<br />
Title is rendered in my panels with ctools_set_page_token()</p>
Fri, 12 Jun 2015 17:07:02 +0000a.milkovskyhttps://www.drupal.org/node/2505311String data, right truncated: 1406 Data too long for column &#039;link_path&#039; https://www.drupal.org/node/2544372
<p>I am getting this when I am trying to add a very long Views url shortcut. I also noticed Views litters the url with unused filter values, but that could be a separate issue.<br /><code>PDOException: SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'link_path' at row 1: INSERT INTO {menu_links} (menu_name, plid, link_path, hidden, external, has_children, expanded, weight, module, link_title, options, customized, updated) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10, :db_insert_placeholder_11, :db_insert_placeholder_12); Array ( [:db_insert_placeholder_0] =&gt; shortcut-set-1 [:db_insert_placeholder_1] =&gt; 0 [:db_insert_placeholder_2] =&gt; admin/items?field_device_name_value_op=contains&amp;field_device_name_value=&amp;field_controller_target_id_op=in&amp;field_controller_target_id[0]=1905&amp;field_controller_target_id[1]=1906&amp;field_controller_target_id[2]=1904&amp;field_controller_target_id[3]=1903&amp;field_controller_target_id[4]=2199&amp;field_shapeways_id_value_op=empty&amp;field_shapeways_id_value[value]=&amp;field_shapeways_id_value[min]=&amp;field_shapeways_id_value[max]=&amp;field_longer_edge_value_op=%3E&amp;field_longer_edge_value[value]=0&amp;field_longer_edge_value[min]=&amp;field_longer_edge_value[max]=&amp;field_sell_on_amazon_value_op=or&amp;field_sell_on_amazon_value=All&amp;field_printable_value_op=or&amp;field_printable_value=All&amp;field_default_pic_ok_value_op=or&amp;field_default_pic_ok_value=All&amp;field_photo_count_value_op=%3E&amp;field_photo_count_value[value]=&amp;field_photo_count_value[min]=&amp;field_photo_count_value[max]=&amp;field_longer_edge_value_1_op=%3D&amp;field_longer_edge_value_1[value]=&amp;field_longer_edge_value_1[min]=&amp;field_longer_edge_value_1[max]=&amp;field_brand_tid=All&amp;changed_op=%3D&amp;changed[value]=&amp;changed[min]=&amp;changed[max]=&amp;field_md5_match_value_op=or&amp;field_md5_match_value=All&amp;field_md5checksum_value_op=%3D&amp;field_md5checksum_value=&amp;field_year_released_value[value]=2014 [:db_insert_placeholder_3] =&gt; 0 [:db_insert_placeholder_4] =&gt; 0 [:db_insert_placeholder_5] =&gt; 0 [:db_insert_placeholder_6] =&gt; 0 [:db_insert_placeholder_7] =&gt; -46 [:db_insert_placeholder_8] =&gt; menu [:db_insert_placeholder_9] =&gt; Administration [:db_insert_placeholder_10] =&gt; a:0:{} [:db_insert_placeholder_11] =&gt; 0 [:db_insert_placeholder_12] =&gt; 0 ) in menu_link_save() (line 3166 of public_html/includes/menu.inc).</code></p>
Sun, 02 Aug 2015 20:33:25 +0000giorgio79https://www.drupal.org/node/2544372Start time parameter ignoredhttps://www.drupal.org/node/2432933
<p>It seems like the video start time ( eg <a href="https://www.youtube.com/watch?v=QSCbpcpjJl4&amp;t=1m20s">https://www.youtube.com/watch?v=QSCbpcpjJl4&amp;t=1m20s</a> ) is ignored when used in the field. Not sure if it's a bug or whether it is not supported yet. Ideas?</p>
<h4>Also, from <span class="project-issue-issue-link project-issue-status-info project-issue-status-1"><a href="/node/2540142" title="Status: Active">#2540142: Optional Start-Time Parameter Field</a></span>:</h4>
<blockquote><p>
It would be a tiny nice - and in opinion in some cases extremely useful - feature to (optionally) be able to enter a start time of the video, like YouTube allows also for embedded videos.</p>
<p>Is there any chance you could implement this feature in the (near) future? :)
</p></blockquote>
Mon, 23 Feb 2015 20:22:08 +0000Vacilandohttps://www.drupal.org/node/2432933