Security

(public)

User Story

Many times when using Netscape, I exit from the application, only to realise I
was still halfway thru downloading (save to disk) a file. This is extremely
infuriating. It would be wonderful if Mozilla warned the user 'You are still
downloading files, do you really want to quit ?' before exiting. Apologies if
this is a dup.

That's a cool idea. Right now, Mozilla keeps the download alive if you close the
last window but quits the download if you choose quit from the file menu in a
Mozilla window. It really should ask for permission to quit the download since
they're probably not meant to be cancelled

> Matthew: proper UI/wording?
If you want to truly delight people:
+------------------------------------------------------+
|::::::::::::::::::::::::::::::::::::::::::::::::::::::|
+------------------------------------------------------+
| . If you quit now, 3 files which are being | \ large
| /!\ downloaded will not download completely. Are | } system
| """ you sure you want to quit? | / font
| |
| Downloading will finish in about 17 minutes. | } small system font
| |
| ( Cancel ) (( Quit Anyway )) |
+------------------------------------------------------+
Show this alert *before* any windows are closed -- if the user is resigned to
spending another 17 minutes online, she may wish to continue browsing or
whatever in her existing windows. And use separate strings on Windows, with
`exit' in the place of `quit'.
> Should download windows just not be closed upon quitting?
Yes -- but that requires making the browser and the download manager separate
executables. Otherwise you're not telling the truth about what `Quit'/`Exit'
means, and not telling the truth is marginally worse than putting up an extra
alert.
See also bug 65121 (though that bug doesn't apply to Mac OS, so it wouldn't
make this bug obsolete).

spam: over to File Handling. i have not changed the assigned developer [or the
other fields for that matter], so if anyone realizes that a bug should have a
more appropriate owner, go ahead and change it. :)

I happened to think about this again recently while working on something related.
Here's an idea: if we just add a function named tryToClose to the download
progress <window> (and in the download manager window?), then this will be
called at File->Quit time. There, we can put up a dialog like the one mpt
suggests and cancel the quit if the user says to.
This might be complicated by download manager interactions (no progress dialogs,
download manager not open) but otherwise might provide a means to a simple fix.
I won't get to it soon since I have [adt2] and [adt1] stuff.

Mass moving nsbeta1+/adt3 bugs assigned to Navigator team engineers out to
target milestone 1.0.1. Please confine your attentions to driving down our list
of TM 1.0 bugs for beta. Better to help, debug, or test one of them than fix
one of these.

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt. If you have any
questions about this, please email adt@netscape.com. You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt. If you have any
questions about this, please email adt@netscape.com. You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

This needs to be fixed quickly especially since the download manager is the
default. With the progress dialog, one can see them before quitting. But now,
the downloads are hidden and the download manager can be discarded at will. So
how does one know he can "safely" quit? First, he has to go in "Tools | Download
Manager" (no shortcut). Then he can go in "File | Quit". That's not what I would
call "user friendly"!!!!
I understand that there is still some important work to do for the final release
but for this, people are going to complain (actually, we already do :p) and even
more now that the download are not readily visible in the taskbar (or equivalent)
Because of bug 142310, I couldn't try but what will happen if one close the
download manager window then close the last navigator window?

While I agree with the suggestion in comment #11 (I would have made a similar
one myself if it wasn't there), I must add that the confirmation dialog should
appear at all times, even if there are no downloads in progress.
A possible exception (but not really necessary), it is not required if _ONLY
ONE_ mozilla window is displayed.

re comment #34: no - confirmation should only be asked for if there is the
danger of data loss. This bug is about a confirmation when downloads
are going on. Your suggestion does not belong in this bug, but
bug 39057 (verified wontfix).

About Comment #35, I'm sure we've all have downloaded files from low-bandwidth
servers that are very hard to restart downloads from. It's arguably a form of
data loss when data on your HD is rendered useless, as a partial doanload is. At
least let users choose whether to have the warning.

Why don't downloads fork to a helper app? Is it too much to maintain a bunch
of lightweight, one-function download windows?
As for downloads that don't have their own windows, I suggest WONTFIX because
people generally want network activity to halt when they close its associated
window.

Let me suggest one possible solution: as long as mozturbo is running, downloads
should continue downloading. This is similar to Kazaa where downloads continue
as long as application is alive in the launch bar (bottom right in Windows).

Ok, I suppose I need some clarification here.
I've read through the bug and it sounds like all that is necessary is that we
are able to query whether there there are one or more downloads currently in
progress. If there are, then present something to the effect of the dialog
proposed in comment 11. Is that right?
So why, then, is this dependent on bug 36776 (Show download progress in window
icon)? That bug is caught up in colors and behaviors of icons. All we really
need to know is, "are there any downloads in progress? Yes or no?"
Is there a neccesity to create a means to do this in a seperate bug?
Might I suggest that if there is a desire do deal with this problem in a more
complex way other than a simple warning dialog that a seperate bug be filed or
this bug will likely take another 3 years to be resolved.

I was to report as a bug, that when I restart Mozilla,
the download manager have cancelled my download,
rather than continue downloading where it was. Which
is what I expect it to do. But somehow, it seems way
much more complex than can be implemented for now.
I almost what to go see the code and see what should
be done for doing this. Afterall, this is supported
both by FTP and HTTP (1.1?) for quite a long time.

Well, actually, I guess it is best to simply pause all downloading files
before quiting Mozilla. That way, one have full bandwith when he restart
Mozilla, and still can resume download (which is impossible now because
they are cancelled).
Comment #11 is still usefull for dowloading files which are not restartable,
because the server don't support it. But for now, nothing shows that Mozilla
try to know a download is restartable. So for now, what seems to make sense
is just to pause all files before quitting.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030815
Isn't this bug moot at this point, as Mozilla now exhibits the default behavior
of Netscape 4.x where downloads will continue to run and will complete
successfully even after the last browser window is closed (or until the user
cancels the download)?

I agree. This is a cryin' shame. What is getting in the way of development? It
seems to me that the TryToClose () routine is a fine solution. The UI is also
already sketched out. Is there some big ugly problem in the code? Could we just
mark it as blocking a release to get some attention? This thing has been moved
to future releases a ton of times.

for anyone that wants/needs this they should migrate to firefox...
from ben:
exit the app, we prompt first and ask if you want to cancel (#) downloads.
once we get cross session resume this won't be necessary.
unless jan varga or someone has cycles to to this in the full suite it's
unlikely to appear there... guess we should mark this works for me in firefox,
or won't fix in seamonkey unless we can get someone to step up.

for anyone that wants/needs this they should migrate to firefox...
from ben:
exit the app, we prompt first and ask if you want to cancel (#) downloads.
once we get cross session resume this won't be necessary.
unless jan varga or someone has cycles to to this in the full suite it's
unlikely to appear there... guess we should mark this works for me in firefox,
or won't fix in seamonkey unless we can get someone to step up.

please do not abuse bugzilla as a firefox promotion forum. There are many people
who have reasons why to prefer the suite and want it fixed it the suite. If
somebody comes up with a patch it will get fixed - there is not reason to
WONTFIX this.

I totally agree with Johann Petrak. This bug seems important enough to be
considered in the suite as well! 38 votes are here to confirm our opinion!!!
If you do not want to fix such a bug in the suite, then stop releasing Mozilla
Suite, things would be clearer and effort concentrated on one product!
I sincerly hoped this bug to be fixed in 1.7... :-(

the intent was not to promote firefox. the intent was just to a clearity about
where solutions to this problem can be found. if someone comes up with a good
patch for this to apply to the suite we would definitely take it.

(In reply to comment #77)
> This bug has been resolved (at least in Mozilla). It now prompts before
> exiting. Shouldn't someone close this thread?
The prompting is great, but it would be really nice to have the following options:
<current prompt text>
[Yes - Shutdown everything] [No - Show Download Manager, Close Browser] [Cancel - Leave Browser Open]
Thanks for considering this.

(In reply to comment #82)
> Before I close this, which patch FIXED this in SeaMonkey? Or should I
> just WFM it as having been FIXED elsewhere?
I didn't know it was fixed in SeaMonkey, I was just saying that someone should do what you have just done (change the Product to Mozilla Application Suite) :-)

As far as I can see this is not fixed on SeaMonkey trunk though that will probably change when we switch to toolkit's download manager (as I think that has this protection built in) - Callek will need to advise on it.

Firefox is not doing this any more, presumably because the current download manager implementation can resume downloads after restarting.
Also because of the same, I don't think we need to do this for SeaMonkey with this implementation, so marking WONTFIX.

Is it not the case, that the resume feature can only work with servers that support to resume a download? Also, even if a download can be resumed, a user might not be aware that it is still going on and a warning would be extremely useful.
Firefox warns and nags in all kinds of situations (e.g. when more than one tab is being closed by default) that are much less useful, it is hard to understand why it should not warn in this case.

The assumption that all webservers are able to support resume is invalid. Many downloads rely on the existence of sessions (wiped on FF exit), or are served by application servers that don't support HTTP ranges.

(In reply to Worcester12345 from comment #91)
> Cleaning out old emails. Was this actually ever fixed in "Seamonkey"?
The current behaviour (with SeaMonkey 2.49.2) is that SeaMonkey does not warn the user when quitting while a download is active. However, upon restarting it will silently attempt to resume the download. So I would consider this issue to be still not fixed -- it would be better if SeaMonkey produced a confirmation dialog if the user attempts to quit while a download is in progress. It would also be helpful if the user were notified about any attempts to resume downloads (successful or otherwise) once the program is restarted.

You need to log in
before you can comment on or make changes to this bug.