I am trying to use tiller since we are converting from chef environment, and I thought that I can just copy the erb templates and roles from chef into tiller with minimal changes. However, if defaults is not an option, that would make it a much harder effort.

This comment has been minimized.

edited

I could make this a configurable option, e.g. in common.yaml, include a deep_merge: true setting. Would that suit your needs ? For me, I can see that this behaviour (deep merging hashes) would be useful, but as it's not currently the default behaviour, we can look at making it the default in later (0.10.x) releases if it seems sensible.

This comment has been minimized.

I'm not keen on making it the default behaviour just now. However, it seems like it could be a sensible default ("principle of least surprise") but having just released a breaking 0.9.x, I'd like to let things settle a little before another major release. Then we can always review all these settings and decide what should be defaulted.

I also think adding stuff per- hash also complicates things, and I'm really not keen on increasing the cognitive overhead further. But as a solution to @pgleyzer 's issue, I have committed a proof-of-concept here : https://github.com/markround/tiller/tree/feature/deep_merge. This simply changes the data merging behaviour if you set deep_merge: true in common.yaml.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/38#issuecomment-240377378, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADfmzB5qPa-Zo87ToGzZxd9IcbnwD7x2ks5qgua9gaJpZM4Jkj4n.