--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

On Thu, Oct 16, 2008 at 12:57:06PM +0200, Andreas Herrmann wrote:[color=blue]
> The problem should be solved with commits:
>
> x86: SB600: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC
>
> IMHO it does not make sense to check within a dmi-quirk
> whether an early-quirk was applied. Boot sequence is as follows:
>
> acpi_boot_table_init() (it applies dmi-quirks)
> ...
> early_quirks() (detect bogus IRQ0 override)
> ...
> acpi_boot_init() (setup IO APIC)
>
> Thus with current code we will always get following warnings for
> Laptops that have this dmi_ignore_irq0_timer_override dmi quirk:
>
> WARNING: at arch/x86/kernel/acpi/boot.c:1410
> dmi_ignore_irq0_timer_override+0x30/0x60()
> ati_ixp4x0 quirk not complete.
>
> ... just because the early-quirk (ati_ixp4x0) was not yet executed.
>[/color]

Hi Ingo,

How are chances that this patch will go into tip-tree?
I'd like to see this fix in 2.6.28.

Thanks,

Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
[color=blue]
> The problem should be solved with commits:
>
> x86: SB600: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC
>
> IMHO it does not make sense to check within a dmi-quirk
> whether an early-quirk was applied. Boot sequence is as follows:
>
> acpi_boot_table_init() (it applies dmi-quirks)
> ...
> early_quirks() (detect bogus IRQ0 override)
> ...
> acpi_boot_init() (setup IO APIC)
>
> Thus with current code we will always get following warnings for
> Laptops that have this dmi_ignore_irq0_timer_override dmi quirk:
>
> WARNING: at arch/x86/kernel/acpi/boot.c:1410
> dmi_ignore_irq0_timer_override+0x30/0x60()
> ati_ixp4x0 quirk not complete.
>
> ... just because the early-quirk (ati_ixp4x0) was not yet executed.[/color]

could we move the DMI check to after the early quicks stage? It would be
nice to have this double check, for at least one kernel cycle.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

On Wed, Oct 22, 2008 at 12:02:54PM +0200, Ingo Molnar wrote:[color=blue]
>
> * Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
>[color=green]
> > The problem should be solved with commits:
> >
> > x86: SB600: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> > x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> >
> > IMHO it does not make sense to check within a dmi-quirk
> > whether an early-quirk was applied. Boot sequence is as follows:
> >
> > acpi_boot_table_init() (it applies dmi-quirks)
> > ...
> > early_quirks() (detect bogus IRQ0 override)
> > ...
> > acpi_boot_init() (setup IO APIC)
> >
> > Thus with current code we will always get following warnings for
> > Laptops that have this dmi_ignore_irq0_timer_override dmi quirk:
> >
> > WARNING: at arch/x86/kernel/acpi/boot.c:1410
> > dmi_ignore_irq0_timer_override+0x30/0x60()
> > ati_ixp4x0 quirk not complete.
> >
> > ... just because the early-quirk (ati_ixp4x0) was not yet executed.[/color]
>
> could we move the DMI check to after the early quicks stage? It would be
> nice to have this double check, for at least one kernel cycle.[/color]

Ok, I'll have a look at that.

Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

Problems with bogus IRQ0 override of those laptops should be fixed
with commits

x86: SB600: skip IRQ0 override if it is not routed to INT2 of IOAPIC
x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC

that introduce early-quirks based on chipset configuration.

For further information, see
[url]http://bugzilla.kernel.org/show_bug.cgi?id=11516[/url]

Instead of removing the related dmi-quirks completely we'd like to
keep them for (at least) one kernel version -- to double-check whether
the early-quirks really took effect. But the dmi-quirks need to be
called after early-quirks are executed. With this patch calling
sequence for dmi-quirks is changed as follows:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]

* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
[color=blue]
> Problems with bogus IRQ0 override of those laptops should be fixed
> with commits
>
> x86: SB600: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC
>
> that introduce early-quirks based on chipset configuration.
>
> For further information, see
> [url]http://bugzilla.kernel.org/show_bug.cgi?id=11516[/url]
>
> Instead of removing the related dmi-quirks completely we'd like to
> keep them for (at least) one kernel version -- to double-check whether
> the early-quirks really took effect. But the dmi-quirks need to be
> called after early-quirks are executed. With this patch calling
> sequence for dmi-quirks is changed as follows:
>
> acpi_boot_table_init() (dmi-quirks)
> ...
> early_quirks() (detect bogus IRQ0 override)
> ...
> acpi_boot_init() (late dmi-quirks and setup IO APIC)
>
> Note: Plan is to remove the "late dmi-quirks" with next kernel version.
>
> Cc: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>[/color]

applied to tip/x86/urgent, thanks Andreas!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]