From: Zardosht Kasheff
Date: July 24 2010 1:45am
Subject: Re: [feedback/review request] Re: index creation and concurrent reads
List-Archive: http://lists.mysql.com/internals/37994
Message-Id:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary=00504501718064ec5f048c184f20
--00504501718064ec5f048c184f20
Content-Type: text/plain; charset=ISO-8859-1
Hello all,
After some investigation, I think the attached patch solves the issue.
I am interested in hearing feedback on the patch.
Thanks
-Zardosht
>> Hello all,
>>
>> About a year and a half ago, I filed the following bug:
>> http://bugs.mysql.com/bug.php?id=42230
>>
>> In short, for storage engines that implement handler::add_index,
>> queries cannot be run on a table while an index is being created. This
>> affects the innodb plugin.
>>
>> A comment at the bottom of the bug states that there is a "one line
>> fix". Does anyone have any ideas as to what that one line fix may be?
>> This bug seems important because storage engines that do NOT implement
>> handler::add_index do not have this problem.
>>
>> Thanks
>> -Zardosht
>>
>
--00504501718064ec5f048c184f20
Content-Type: text/plain; charset=US-ASCII; name="55528.txt"
Content-Disposition: attachment; filename="55528.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gbzst4931
SW5kZXg6IHNxbF90YWJsZS5jYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzcWxfdGFibGUuY2MJKHJldmlzaW9u
IDIxMTU1KQorKysgc3FsX3RhYmxlLmNjCSh3b3JraW5nIGNvcHkpCkBAIC01OTczLDYgKzU5NzMs
OSBAQAogCiAgIHN3aXRjaCAoa2V5c19vbm9mZikgewogICBjYXNlIEVOQUJMRToKKyAgICBWT0lE
KHB0aHJlYWRfbXV0ZXhfbG9jaygmTE9DS19vcGVuKSk7CisgICAgd2FpdF93aGlsZV90YWJsZV9p
c191c2VkKHRoZCwgdGFibGUsIEhBX0VYVFJBX0ZPUkNFX1JFT1BFTik7CisgICAgVk9JRChwdGhy
ZWFkX211dGV4X3VubG9jaygmTE9DS19vcGVuKSk7CiAgICAgZXJyb3I9IHRhYmxlLT5maWxlLT5o
YV9lbmFibGVfaW5kZXhlcyhIQV9LRVlfU1dJVENIX05PTlVOSVFfU0FWRSk7CiAgICAgYnJlYWs7
CiAgIGNhc2UgTEVBVkVfQVNfSVM6CkBAIC01OTgwLDYgKzU5ODMsOSBAQAogICAgICAgYnJlYWs7
CiAgICAgLyogZmFsbC10aHJvdWdoOiBkaXNhYmxlZCBpbmRleGVzICovCiAgIGNhc2UgRElTQUJM
RToKKyAgICBWT0lEKHB0aHJlYWRfbXV0ZXhfbG9jaygmTE9DS19vcGVuKSk7CisgICAgd2FpdF93
aGlsZV90YWJsZV9pc191c2VkKHRoZCwgdGFibGUsIEhBX0VYVFJBX0ZPUkNFX1JFT1BFTik7Cisg
ICAgVk9JRChwdGhyZWFkX211dGV4X3VubG9jaygmTE9DS19vcGVuKSk7CiAgICAgZXJyb3I9IHRh
YmxlLT5maWxlLT5oYV9kaXNhYmxlX2luZGV4ZXMoSEFfS0VZX1NXSVRDSF9OT05VTklRX1NBVkUp
OwogICB9CiAKQEAgLTcyMzEsOSArNzIzNyw2IEBACiAgIH0KICAgZWxzZQogICB7Ci0gICAgVk9J
RChwdGhyZWFkX211dGV4X2xvY2soJkxPQ0tfb3BlbikpOwotICAgIHdhaXRfd2hpbGVfdGFibGVf
aXNfdXNlZCh0aGQsIHRhYmxlLCBIQV9FWFRSQV9GT1JDRV9SRU9QRU4pOwotICAgIFZPSUQocHRo
cmVhZF9tdXRleF91bmxvY2soJkxPQ0tfb3BlbikpOwogICAgIHRoZF9wcm9jX2luZm8odGhkLCAi
bWFuYWdlIGtleXMiKTsKICAgICBhbHRlcl90YWJsZV9tYW5hZ2Vfa2V5cyh0YWJsZSwgdGFibGUt
PmZpbGUtPmluZGV4ZXNfYXJlX2Rpc2FibGVkKCksCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgYWx0ZXJfaW5mby0+a2V5c19vbm9mZik7Cg==
--00504501718064ec5f048c184f20--