<br><br><div class="gmail_quote">On Fri, Mar 12, 2010 at 7:08 PM, Joseph Smith <span dir="ltr"><<a href="mailto:joe@settoplinux.org">joe@settoplinux.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On 03/12/2010 06:07 PM, ron minnich wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Fri, Mar 12, 2010 at 2:55 PM, Keith Hui<<a href="mailto:buurin@gmail.com" target="_blank">buurin@gmail.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
If we go through all the Kconfigs for all 440BX boards and identify all that<br>
have 4 slots, and enter this setting for all of them, done before my 440BX<br>
ram init code is ready. ;-) There is a reason for expert mode, no?<br>
</blockquote>
<br>
I think this goes beyond expert mode. It seems to me it is a setting<br>
that can render the machine unbootable if configured incorrectly. Even<br>
for experts, I don't think it should be visible in Kconfig.<br>
<br>
</blockquote></div></div>
has anyone even tested this yet???<br>
<br>
>> slot4_detect = (spd_read_byte((DIMM_SPD_BASE + 3), SPD_MEMORY_TYPE);<br>
>><br>
>> if (slot4_detect != 0xff) {<br>
>><br>
>> /* We have 4 slots */<br>
>> ----Set bit 4 in SDRAMPWR----<br>
>> #define DIMM_SOCKETS 4<br>
>> } else {<br>
>><br>
>> /* We have 3 slots */<br>
>> ----Set bit 4 in SDRAMPWR----<br>
>> #define DIMM_SOCKETS 3<br>
>> }<br>
>><br><font color="#888888">
<br></font></blockquote><div>You put a #define inside a actual code branch? I highly doubt if that would work AT ALL. :-)<br><br>And this code will fail on any 4-DIMM boards without a stick installed in slot 3.<br><br>There is a possibility that a board would have 3 DIMM slots, yet only wired for GCKE. I doubt any manufacturer would actually do that, but still a possibility. Dumping the BX configuration space with factory BIOS installed still provides the most authoritative answer.<br>
<br>We currently have support for about 15 440BX mainboards. If someone can go through them and get the correct SDRAMPWR setting for all of them that we don't already know - especially those with 3 DIMM slots, I'll code this setting for all of them and get it out of sight.<br>
<br>Thanks<br>Keith<br></div></div><br>