Hey Guys here Is my code I am having communicating with a LoRa CLick2 device …I confirmed it communicates by hooking an Arduino to it …But the particl doesn’t seem to want to send the commands please have a look at the code and let me know whats up…

This is not how you write binary literals in C/C++. This might work on Arduino, but the correct syntax would be 0b1100111.

If it worked that way it would also be very obscure to have a variable char B1100111; that had the name of a binary literal.
That’s also the reason why you don’t get a build error when using LTCADDR because it just inserts the variable name in the respective calls, but the content of that variable is not the binary address you expect to pass to the functions.

But in that case you may want to cut unrelated distractions from the code - having unaddressed issues present will just diverge attention from what you really want answered.
Also having one part of a project potentially not work correctly makes debugging other issues more difficult.

One rule of thumb for debugging hard to locate issues is to isolate the one particular one and focus on that one and only one at a time.

Also the symptom description isn’t very revealing

jade7272:

But the particl doesn’t seem to want to send the commands

Also how have you wired the device?
Is the 3.3V TX signal accepted by the device?
Can you check the signal output (e.g. with Logic Analyzer or oscilloscope)?

BTW, there is one other distraction. We see this in your code

jade7272:

// This #include statement was automatically added by the Particle IDE.

Post your forum Tips and Tricks here!
Do you have some simple but useful tip that will save users time, or make their forum use much more rich with features? Post them here! Tips and Tricks should be short and to the point. Also, please don’t post questions here regarding anything other than the tips and tricks posted. I will organize and link to each relevant tip from this first post as the thread builds. If you have a way to improve a tip or trick, please make a suggestion. Thanks!
Plea…

that you are transmitting commands from which you are expecting to immediately (within just a few microseconds) receive a response.

this expectation of semi-synchronous serial communication would not be typical. Usually it would take a (relatively) very long time for a response, from the point of view of your 120Mhz photon or electron.

I’d try to first (as suggested above by the esteemed @ScruffR) further isolate your Serial1 communication and test to see just how long the LoRa module takes to respond to a command.

Side note:

void read_data_from_LoRa_Mod()

functions that take no parameters and return no values also make for a tough debug.

try to get a response asynchronously from one command (not tested of course):