Or uses of it could be replaced by textwrap and twisted.python.text could be deprecated and eventually removed.

Sounds good. Let's port it (which was quite simple) and file new tickets to replace usage and deprecate it. I'd like to see it's supported on py3 until it's removed in x releases. Current coverage is 93%.

The following doesn't emit a deprecation warning, but probably should.

#!/python
from twisted.python.text import stringyString

I think twisted.protocols.telnet is a better example. Note, this will involve suppressing the warning from the toplevel import, and perhaps more work to test the deprecation. (This probably also means the tests don't need to be touched)

There are some twistedchecker errors.

Is there a good reason to port the module? (I haven't looked at these changes, except to note that we don't have full test coverage)

There don't appear to be tests for the copied functions. (And the one in lore should probably be private.)

The core topfile should be a .removal.

The lack of test coverage for almost all of the changes makes me sad. (Most of the changed code isn't exercised, let alone tested)

Changed the deprecation to mimic the telnet deprecation (added in r14536) and importing it in different ways displays the DeprecationWarning, only I'm not sure how to test/suppress this, any pointers are welcome.

OK, it may be because I'm tired, or because the review queue is very long, but I think this ticket is improper. A 1500 lines diff is not a reasonable thing to do, in particular in this case. Please open at least 4 other tickets to handle changes per subprojects. Sorry for the delay in responding on this.

OK, it may be because I'm tired, or because the review queue is very long, but I think this ticket is improper. A 1500 lines diff is not a reasonable thing to do, in particular in this case. Please open at least 4 other tickets to handle changes per subprojects. Sorry for the delay in responding on this.

Thanks for the review. I opened 4 additional tickets (see updated ticket description for ticket nrs) for the subprojects. I'll leave this ticket open as the main ticket that will actually deprecate the module and replace it's usage in core, once these other tickets have been resolved.