On Tue, Feb 21, 2006 at 09:59:51PM +0100, Andi Kleen wrote:> On Tuesday 21 February 2006 21:56, Greg KH wrote:> > > I don't think you can add fields here, after the driver_data field. It> > might mess up userspace tools a lot, as you are changing a userspace> > api.> > User space should look at the ASCII files (modules.*), not the binary> As long as the code to generate these files still works it should be ok.

Does it? Shouldn't the tools export this information too, if it reallyshould belong in the pci_id structure?

So, is _every_ pci driver going to have to be modified to support thisnew field if they are supposed to work on this kind of hardware? If so,that doesn't sound like a good idea. Any way we can just set the bit inthe pci arch specific code for the devices instead?

> > Do you _really_ need to pass this information back from userspace to the> > driver in this manner?> > Well driver_data wouldn't be needed then either. Obviously it's for more> than just userspace.

For some drivers, they need that driver_data field to be set. Justwanting to make sure that this also is needed.