If this is your first visit, be sure to
check out the FAQ by clicking the
link above. You may have to register
before you can post: click the register link above to proceed. To start viewing messages,
select the forum that you want to visit from the selection below.

VenRob as Proper Dev

Given how helpful Rob has been, that he has become familiar-enough with the source, git, and the tools to work on ZC to the extent of adding new features without aid, and his willingness to do builds, I'd like to elevate him to full dev status.

He seems to have gotten the rules on doing merges in his head, and is now being more careful, so I think that won't be an issue--although I won't be giving him ownership on the repo, just merge access.

What are your thoughts here?

(Given that jman is pseudo-retired, if he doesn't respond, that's fine.)

I'm pretty sure that ultimately, it's my call here, but I want to gather your thoughts on this, before I do anything.

“The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating.” –Thomas Jefferson“It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning.” –Henry Ford“Man will ultimately be governed by God or by tyrants.” –Benjamin Franklin

This post contains the official Gleeok™ seal of approval. Look for these and other posts in an area near you.

Correct me if I'm wrong, but that looks like overflow to me. ...or did I just get (un)lucky with my timing?

No overflow? That's an InitD function. The value was being divided and multiplied when it should not have been, and the ffc index wasn't properly offset. Both my fault, and I sent him a text file with the patch, that he committed while my laptop was in surgery.

Both InitD and MiscD are always a raw values, and I forgot that here, when I wrote 300 ZScript commands all at once. All refinfo registers are also always raw.

Off-topic, but my plans this week are to finish uop bitmaps, fix script drawing stuff--cset2 related-- and to ffix some other critical bugs. I'm going to start on npc script stuff soon, as well. I need to get bitmap->Blit(dest,args) and some basic draw commands in for bitmaps, so that I can test if bitmap->Create(h,w) works as I intend.

I finally got that in there in the most straightforward manner possible.

Anyway, he's doing a good job, seems dedicated, and his outpit is constructive.

“The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating.” –Thomas Jefferson“It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning.” –Henry Ford“Man will ultimately be governed by God or by tyrants.” –Benjamin Franklin

This post contains the official Gleeok™ seal of approval. Look for these and other posts in an area near you.

“The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating.” –Thomas Jefferson“It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning.” –Henry Ford“Man will ultimately be governed by God or by tyrants.” –Benjamin Franklin

This post contains the official Gleeok™ seal of approval. Look for these and other posts in an area near you.

Back on topic, I was really only looking at his code for safety and bugs, which is basically the main prerequisite for write access.

Good point, and fixed. Anyway, this was my oversight. Rob has been helping me test, and prove some of the new stuff, and informing me of any issues. He applied the patch at my instruction, and I forgot to include the same BC as with the other related instructions. (These two are special, as they're commands, not variables.)

“The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating.” –Thomas Jefferson“It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning.” –Henry Ford“Man will ultimately be governed by God or by tyrants.” –Benjamin Franklin

This post contains the official Gleeok™ seal of approval. Look for these and other posts in an area near you.