Re: Fwd: sed porting trouble

From:

Paolo Bonzini

Subject:

Re: Fwd: sed porting trouble

Date:

Sat, 2 Oct 2010 10:44:51 +0200

On Sat, Oct 2, 2010 at 02:53, Paul Eggert <address@hidden> wrote:
> So, how about something like the following patch? It will fix the
> immediate problem anyway. (And my goodness, what a terrible misfeature
> "#pragma COLUMN" is! would you all mind if I give it as an example of a
> terrible design in my programming languages class?)
It's not per se horrible, the problems I see with it are that:
1) it does not warn, it silently eats code in all cases; it should
warn or error if the pragma was inherited via #include.
2) it, or the #include inheriting at least, cannot be disabled from
the command line (even -Wcolumns=32767 wouldn't be a fix).
But yes, if I were still teaching a programming languages class I'd
definitely sneak it in a lecture. :)
Can we add a syntax-check for *.h, just to be on the safe side, maybe?
Paolo