Amazing that is well worth framing. I am creating a blog after my father passed away I found a diary that he hid of his fathers that he obviously wanted me to find, but could not talk about to me directly

My Gramp was on the last military ship that was sank at the end of the Second World War, the diary includes news cuttings, photographs that he took (pictures of ship sinking he took from the life boat!) and letters as well as paperwork notes he took about his time at sea.

I'd be tempted to donate them either to the regimental museum (from the newspaper cutting, Charles was in the West Yorkshire Regiment - the regimental museum is at Bankfield Hall in Halifax), or even to the Imperial War Museum. They may not end up on display, but at least they would be stored and conserved properly, and you would have access to them at any time.

On a serious note: that's absolutely amazing. What a find. We had something similar. When my great uncle passed away, we found all his flight manuals from when he flew in the Royal Flying Corp in 1918.

Stuff like this is priceless. We have a letter that my Grandfather sent to his brother a few days before the war ended, full of stuff along the lines of "we've got them on the run now" and "we'll all be home again soon". Was returned undelivered as he was killed in the last few days of fighting. Really sad.

Another story - my wife is German, her Grandfather had his arm blown off in the street fighting in Berlin at the end of WW2. He was captured by the Russians and was being marched back to Russia (with not much chance of survival to be honest) but a couple of others escaped and selflessly pretty much dragged him along with them. By the time he got back home his own Mother didn't recognise him. We've got it pretty good these days, eh?

One thing that always strikes me regarding people of that era is the beauty and emotion they put into their writing. I've no idea what the general standard of literacy was - either way, women AND men seemed so much more capable of expressing themselves through words. Letters, stories, poems ... whatever it was they chose, they could write with so much warmth and feeling.

The senior Noteeths have a collection of letters & diaries from my grandfather & great-grandfather, including the latter's account of Gallipoli, where he was serving with the Royal Engineers. My favourite diary entry is one that reads, simply:

"Under heavy fire all day. Made jam."

The saddest item is probably a letter from my late great-uncle, brimming with excitement about coming home and getting married. Not long after the letter was written, he was killed during the Battle of Keren (East African Campaign). He was 27.

My G G Uncle Jim was unlucky to be on what was officially cannon fodder(ancient coal fired tub with a max 10 knots).
He was on HMS Aboukir when it was the first ship of WW1 to be sunk by a U boat. He managed to swim to another cruiser in the trio of ships in the patrol, but that too was sunk soon after. He managed to jump off that one and swam to the last boat. Yep, that got hit too and was sunk. I think he was saved by a Dutch trawler. This all happened in a hour. How the 'F' he felt after all that I didn't get to find out and he didn't get time to think about it as the next day he was out on another ship!

My G G Uncle Charlie was awarded a DCM too (RFC). The Victoria Cross for NCO's. We don't have his medal in the family. If the OP has his Uncle Charlie's then that is indeed a family treasure.

Very humbling when you realise how they lived and died in the trenches ..
Matey and i had a week to kill in northern France before a bike race so decided to have a wander around the ww1 battlefields. We really didnt know what to expect but gradually realised what tremendous hardships and sacrifices were made. The huge cemetry at Tyn cott was heartbreaking but the most poigniant was when we saw a remote cemetry in the distance and decided to pull over and pay our respects. A short climb up a small hill took us to to a British cemetry atop a ridge with around 50 graves, all killed on the same day. Along the ridge, were similar small burial grounds, for as far as the eye could see - all a few hundred yards apart. There we were, modern waterproofs, freezing cold, thinking we had it rough and blubbing like schoolkids.

If the OP has his Uncle Charlie's then that is indeed a family treasure.

I do indeed, and all his campaign medals.
Also, found an envelope filled with several letters from the public expressing admiration for his courage in diving off Blackpool Pier, 1937, into a stormy sea to rescue a Spaniel being repeatedly washed onto the stanchions of the pier. Alongside this are clippings of him being presented with an Animal Welfare medal, the medal, and a letter from the Chief Constable with a citation for bravery which resulted in his medal.

Oh, and VCs are for all any any rank and always have been.
edit; I was lucky enough to march with (and push one in his wheelchair) a bunch of David sterlings "originals" one remberance Sunday and had a few pints with some after. Humbling indeed.