No, that's not a correct fix. See the abovementioned change
for an example about how to get the anchor.
The hanchor group is for an optional, explicitely given id,
which, most of the time, will not be given.

Removal of trailing whitespace: I've not included that in the above patches, since it is easier for a committer to run a simple editor command, than review a patch doing the same (but it would be nice to have this done).

Introduction of coding: utf-8 statement: I've dropped that, since it was only there to support the addition of a weird angled quote character in an added comment, which looked like a typo anyway.

Placing of an assignment to args into an else: clause: I've removed this change, since it results in args being a different datatype (string vs. list) depending on whether args are provided, which doesn't seem right.

Oops! There's an error in various places throughout cboos' macro.py and my derivatives:

out.write(system_message(MESSAGE), None)

is supposed to be:

out.write(system_message(MESSAGE, None))

The error is present in the first of two uses of system_message in macro.py. In tweaks.patch, I accidentally spread the error to the second use too. In linewrap.patch, there's one change which isn't a pure line-wrap: the accidental spreading is undone again.

Rather than re-attaching fixed versions of tweaks.patch and linewrap.patch, please just correct the placement of the parentheses as described above, in tweaks.patch and linewrap.patch, before applying them - thanks!

Add Comment

This ticket has been modified since you started editing. You should review the
other modifications which have been appended above,
and any conflicts shown in the preview below.
You can nevertheless proceed and submit your changes if you wish so.