John sinclair married Joan Johnstone in 1824 in Edinburgh. Their daugher Margaret married Alexander Miller in 1853. Joan was the daughter of Ellizabth Carmichael and Thomas Johnstone. Margaret and Alexander migrated to Australia in 1885.