Created attachment 8563645[details]
Screenshot
Description:
When language is set to Arabic, the text on the tiles in the music app that appears in Arabic (e.g. "Unknown Artist", "Unknown Album", etc.) is not right aligned.
Repro Steps:
1) Update a Flame to 20150212010213
2) Set language to Arabic
3) Have a song with an unknown/blank artist and/or album title
4) Launch Music app
Actual:
Translated text on tiles in music app are not right aligned when language is set to Arabic.
Expected:
All translated text in music app is right aligned when language is set to Arabic.
Environmental Variables:
Device: Flame 3.0 Master
Build ID: 20150212010213
Gaia: d5a71cedb37dd45f439f672489db3994b349ac43
Gecko: 3094601af679
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Repro frequency: 3/3, 100%
See attached: screenshot

Comment on attachment 8565376[details][review]
[gaia] anefzaoui:bug-1132666 > mozilla-b2g:master
This looks sane, I guess. I'm not really a good person to ask about RTL issues. Is it normal for Latin text to be left-aligned in the same UI as Arabic text is right-aligned, or should we pick an alignment based on the user's locale?

Comment on attachment 8565376[details][review]
[gaia] anefzaoui:bug-1132666 > mozilla-b2g:master
Hey Stephany,
Sorry to add even more load to your work but could you please give quick insight on this or assign someone to do ?
Thanks :)

no no, the bug is still very valid - if you look at the original screenshot and STR, everything was left aligned. The patch fixes the alignment of items translated to Arabic (e.g. "unknown album") but Latin characters (e.g. Crystal Method) are still left-aligned when the should also be right aligned (Steph's comment)

(In reply to Tiffanie Shakespeare from comment #12)
> no no, the bug is still very valid ... but Latin characters (e.g.
> Crystal Method) are still left-aligned when they should also be right aligned
> (Steph's comment)
Right, you can see the inconsistency if you go into the now playing screen. There you will find that the Latin chars are right-aligned as expected.
Jim, Ahmed is no longer working on bugs for 2.2. Are you available to take over on this one to fix the alignment?

I can look at this.
Tif: Just to be clear, *all* the artist/album info - no matter the language of each item - should be left-aligned when the UI's locale is LTR, and right-aligned when the UI's locale is RTL, correct?

Yes, we want to consistently align the text. So everything should be right-aligned, including Latin strings, when the locale is a RTL language.
In looking at the patch, the Arabic was being right-aligned, but the English was not.
Thanks Jim!

Comment on attachment 8575060[details][review]
[gaia] jimporter:music-rtl-tiles > mozilla-b2g:master
Tif: Just wanted to make sure this looks right for you. Unfortunately, I don't have any MP3s with Arabic metadata to test...

Hey Jim I'm having issues testing the patch. Arabic disappears from the language list when I install your patch :-/
I also found another bug while trying to get this working - when English is truncated it's truncated on the left (e.g. ...stal Method) I don't know if you want to file a new bug for this or tackle in this one since it's related to switching the alignment to the right.

(In reply to Tiffanie Shakespeare from comment #23)
> Hey Jim I'm having issues testing the patch. Arabic disappears from the
> language list when I install your patch :-/
Can you use Mirrored English instead? That should be available in debug builds.
> I also found another bug while trying to get this working - when English is
> truncated it's truncated on the left (e.g. ...stal Method) I don't know if
> you want to file a new bug for this or tackle in this one since it's related
> to switching the alignment to the right.
That's probably a different bug; I'd guess it's related to bug 1140154.

Mirrored English works and looks like the bug is solved.
I checked out the patch in bug 1140154 and it doesn't seem to fix the truncation issue. So IDK if you want that patch to update with a fix or update it here.
Thanks Jim!

Hey Jim - can you send my a zip file of the music app with the patch? I want to see if I can get Arabic working with the changes you made.
Also, who can we check with to nail down where the weird truncation issue is occurring? This definitely needs to be fixed.
Thanks!

I have no idea how to generate a zip file for a given app. It *should* work if you just check out my branch and run
APP=music make install-gaia
from the terminal. That would only update the music app, and not the rest of the system.

Hi Tiffanie,
For Arabic language will only exist via building gaia with the patch, we tried this method, but something is wrong with en-US language package.
Instead, if we build the image with the patch, the Arabic language does not exist. Can we verify this issue in English via building the image with the patch?

Sorry Lancy I'm not quite following and re-reading my question I apologize for not being more clear. :-/
At one point (see comment 15) artists in Arabic or the translated word "unknown" was getting right-aligned but artists in English (e.g. Daft Punk) were being left-aligned.
In the screenshot you posted in comment 38, I only see Arabic and some other language or characters - I'm not sure what it is.
I wanted to double check that an artist in English was still being right-aligned. Thanks :)

(In reply to Tiffanie Shakespeare from comment #41)
> Sorry Lancy I'm not quite following and re-reading my question I apologize
> for not being more clear. :-/
>
> At one point (see comment 15) artists in Arabic or the translated word
> "unknown" was getting right-aligned but artists in English (e.g. Daft Punk)
> were being left-aligned.
>
> In the screenshot you posted in comment 38, I only see Arabic and some other
> language or characters - I'm not sure what it is.
>
> I wanted to double check that an artist in English was still being
> right-aligned. Thanks :)
Hi Tiffanie,
Sorry for the late reply, could you please review the attachment in comment 44? Translated text is left-aligned in English, and this issue has been fixed in latest Flame 3.0 build.