Importing shapefile with spaces in attributes fails for postgis

Details

Description

On import into Postgis the importer runs both the feature type and all of the features from the shapefile through a converter before it sends it down to the postgis datastore. The feature type conversion leaves attribute names with spaces in tact, however the feature conversion does not and it converts them to the XML safe version (ie replacing the space with an underscore).

As far as I know it was decided that in general all names should be made XML safe so that we can use the types with WFS / GML output.