Xiaoyu Yao
added a comment - 09/Nov/15 21:53 cc: Allen Wittenauer who may have an answer to this. It looks like a Infra issue unrelated to this change.
I will commit it later today if I have not heard any additional comments by EOD today.

Mingliang Liu
added a comment - 09/Nov/15 21:39 Thanks for the review, Xiaoyu Yao . I validated locally too and found the findbugs issue was gone with this patch.
Though there is findbugs warnings in the pre-patch findbugs warnings, the comment table says:
The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings.
It should be fine?

Xiaoyu Yao
added a comment - 09/Nov/15 19:48 Patch v002 LGTM. +1. I validated locally that it fixed the two findbugs issue on IS2_INCONSISTENT_SYNC.
Not sure why Jenkins still reported the same issue with the latest patch.
https://builds.apache.org/job/PreCommit-HDFS-Build/13201/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html

Per offline discussion withHaohui Mai and Li Lu, the volatile is considered premature optimization. The v1 patch simply use the synchronized block for accessors. The main observation is that synchronized read is not in critical path.

Mingliang Liu
added a comment - 25/Oct/15 04:20 Per offline discussion with Haohui Mai and Li Lu , the volatile is considered premature optimization. The v1 patch simply use the synchronized block for accessors. The main observation is that synchronized read is not in critical path.