Commit Message

Hi again,
Am 28.03.19 um 22:01 schrieb Ulf Zibis:
> As you can see from the benchmark log included in the> vf_fillbd_benchmark_9.patch I have attained a performance gain up to 45 %.> It is remarkable, that in several cases the processing of 16-bit planes> is often faster as of 8-bit planes of same image dimension.>> Regards,>> -Ulf
I again could enhance the performance up to 20 %.
Patch 11: Correction of version from 28.03.19 22:01 CET. Fixed compiler
warning.
Patch 12: Moved multiplication with linesize out of for loop for
performance; side effect: reduces footprint again.
-Ulf

Comments

2019-04-02 22:26 GMT+02:00, Ulf Zibis <Ulf.Zibis@cosoco.de>:
> Hi again,>> Am 28.03.19 um 22:01 schrieb Ulf Zibis:>> As you can see from the benchmark log included in the>> vf_fillbd_benchmark_9.patch I have attained a performance gain up to 45>> %.>> It is remarkable, that in several cases the processing of 16-bit planes>> is often faster as of 8-bit planes of same image dimension.>>>> Regards,>>>> -Ulf>> I again could enhance the performance up to 20 %.>> Patch 11: Correction of version from 28.03.19 22:01 CET. Fixed compiler> warning.> Patch 12: Moved multiplication with linesize out of for loop for> performance; side effect: reduces footprint again.
Does not apply / patches to change patches are not ok.
Carl Eugen

Am 02.04.19 um 23:33 schrieb Carl Eugen Hoyos:
>> I again could enhance the performance up to 20 %.>>>> Patch 11: Correction of version from 28.03.19 22:01 CET. Fixed compiler>> warning.>> Patch 12: Moved multiplication with linesize out of for loop for>> performance; side effect: reduces footprint again.> Does not apply / patches to change patches are not ok.
Sorry, I do not have the original commit anymore, because I have amended
the change to it. So I can't provide a revert patch on base of the
original patch 11. So please throw away the old one and use the new
patch 11.
-Ulf

2019-04-03 0:25 GMT+02:00, Ulf Zibis <Ulf.Zibis@cosoco.de>:
> So please throw away the old one and use the new> patch 11.
That patch does not apply:
The patch wants to remove "enum" from line 27, but that
is an include in current FFmpeg.
Carl Eugen

2019-04-03 11:13 GMT+02:00, Ulf Zibis <Ulf.Zibis@cosoco.de>:
> vf_fillborders_1.patch
As explained, this patch is not ok, therefore the patchset
as-is can not be applied.
There are two possibilities:
Either you rebase your remaining patchset and wait for a
review from Paul.
Or only send the patch that improves the filter performance.
Carl Eugen

Am 03.04.19 um 14:25 schrieb Carl Eugen Hoyos:
>> vf_fillborders_1.patch> As explained, this patch is not ok,
I would say "determined".
> There are two possibilities:> Either you rebase your remaining patchset and wait for a> review from Paul.
In consideration of his in my judgement impolite 1-line comments it
seems unlikely to me that rebasing would be worth the effort.
> Patches are big mess.> You showed very little skills.> You obviously lack git skills.
Even your question from 28.03.19, 23:22 CET is still open.
> Or only send the patch that improves the filter performance.
I'll consider that when I'm complete with my investigation with tuning.
I also could provide a final patch to rework the remaining indentations
which is much less work.
-Ulf

On 4/3/19, Ulf Zibis <Ulf.Zibis@cosoco.de> wrote:
>> Am 03.04.19 um 14:25 schrieb Carl Eugen Hoyos:>>> vf_fillborders_1.patch>> As explained, this patch is not ok,> I would say "determined".>>> There are two possibilities:>> Either you rebase your remaining patchset and wait for a>> review from Paul.>> In consideration of his in my judgement impolite 1-line comments it> seems unlikely to me that rebasing would be worth the effort.>>> Patches are big mess.>> You showed very little skills.>> You obviously lack git skills.> Even your question from 28.03.19, 23:22 CET is still open.>>> Or only send the patch that improves the filter performance.>> I'll consider that when I'm complete with my investigation with tuning.> I also could provide a final patch to rework the remaining indentations> which is much less work.
Do not reindent code, it is waste of my and yours time.

Ulf Zibis (12019-04-03):
> In consideration of his in my judgement impolite 1-line comments it> seems unlikely to me that rebasing would be worth the effort.
You are right, these comments are completely unacceptable.
But that does not mean you should not strive to improve your patches.
Regards,