On 1/2/2018 2:02 PM, Bjorn Helgaas wrote:> I read that as suggesting that we should enable DPC support in Linux> if and only if we also enable AER. But I don't see anything in DPC> that looks like that. Should there be something there? Should DPC be> restructured so it's enabled and handled inside the AER driver instead> of being a separate driver?

I think Keith posted a patch to do this. If firmware first is enabled, DPCinit is skipped after his patch.

Oza was able to plumb the DPC handling into error recovery callbacks ofthe portdrv since the portdrv layer already provides this facilities suchas reset_link and resume.

The way DPC and AER works is almost identical from AER portdrv perspective.

I really like his plumbing. Putting DPC code into AER makes it moreconvoluted in my opinion.

-- Sinan KayaQualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.