Hi Li-Bing,
On Wed, Dec 01, 2010 at 03:29:27PM +0800, Libing Song wrote:
...skip...
> > What if simple_parser is not available?
> > Did you try to remove mypluglib.so and run this test?
> The test sources have_simple_parser.inc, so the whole test will be
> skipped if mypluglib.so is not available.
Right. AFAIR simple parser is not available on all PB2 platforms,
I hope that's acceptable.
Since have_* scripts affect the whole test file, probably it is
a good idea to move it's inclusion to the top of the test file.
At least I would be very surprised if my test is skipped, but there
is no appropriate requirement listed at the top of the test file.
...skip...
> > Also, being non-replication guy, I'm a bit confused: you set unsafe
> > warning flag, but you don't really mark statement unsafe? If it is
> > done implicitely, could you point me to that code?
> binlog_query() calls issue_unsafe_warnings(). issue_unsafe_warnings()
> checks this flag and then generates different unsafe warnings.
Right, it generates different unsafe warnings. But I don't see how it
marks statement unsafe.
...skip...
Regards,
Sergey
--
Sergey Vojtovich <svoj@stripped>
MySQL AB, Software Engineer
Izhevsk, Russia, www.mysql.com

Content reproduced on this site is the property of the respective copyright holders. It is not reviewed in advance by Oracle and does not necessarily represent the opinion of Oracle or any other party.