On Sep 23 2007 10:39, Vegard Nossum wrote:>On 9/23/07, Joe Perches <joe@perches.com> wrote:>> On Sat, 2007-09-22 at 21:27 +0200, Vegard Nossum wrote:>> > #define kprint(fmt, ...)>>>> Good ideas. Perhaps a prefix of klog or kp_ instead?>> Given the number of 80 column zealots, character naming length matters.>>I don't know. Compare the following two lines:>>printk(KERN_INFO "Message.\n");>kprint_info("Message.");>>By dropping the lengthy macro (it's not like it's going to change>while we're running anyway, so why not make it a part of the function>name?) and the final newline, we actually end up with a net decrease>in line length.>>I thought it would be nice to have something that looks familiar,>since that would ease an eventual transition. klog is a valid>alternative, but isn't kp a bit cryptic?

I'd rather fix up code to reduce its indent rather thantrying microoptimizations at the function name level!-To unsubscribe from this list: send the line "unsubscribe linux-kernel" inthe body of a message to majordomo@vger.kernel.orgMore majordomo info at http://vger.kernel.org/majordomo-info.htmlPlease read the FAQ at http://www.tux.org/lkml/