Comments

David, All,
On Tuesday 18 September 2012 04:16:54 David Holsgrove wrote:
> # HG changeset patch> # User David Holsgrove <david.holsgrove@xilinx.com>> # Date 1347933988 -36000> # Node ID 79a03dc829edb6188436a2c7cc33ead9e27827c4> # Parent 2858a24a584642e263a920b4214c815c172ed547> config/arch+scripts/build/arch: Add Microblaze architecture support
Usually, we just specify the component familly, the component name, and
the action being done. As microblaze is still experimental (at least in
CT-NG!), saying so in the commmit log would be good.
In this case, a subject like the following would
be more obvious:
arch/microblaze: add new architecture
> Add Microblaze architecture support (depends on EXPERIMENTAL)> > Signed-off-by: "David Holsgrove" <david.holsgrove@xilinx.com>> > diff -r 2858a24a5846 -r 79a03dc829ed config/arch/microblaze.in> --- /dev/null Thu Jan 01 00:00:00 1970 +0000> +++ b/config/arch/microblaze.in Tue Sep 18 12:06:28 2012 +1000> @@ -0,0 +1,12 @@> +# MicroBlaze specific config options> +> +## depends on EXPERIMENTAL> +##> +## select ARCH_SUPPORT_ARCH> +## select ARCH_FLOAT_SW> +## select ARCH_SUPPORTS_BOTH_ENDIAN> +## select ARCH_DEFAULT_BE> +## select ARCH_DEFAULT_HAS_MMU
What archs usually do is:
- if the MMU is always available (eg. x86):
select ARCH_USE_MMU
- if the MMU is either available or missing (eg. arm):
select ARCH_SUPPORTS_BOTH_MMU
select ARCH_DEFAULT_HAS_MMU (only if the MMU is 'default')
- if the arch never has an MMU (eg. blackfin), select nothing
AFAICS, microblaze is like ARM: use of the MMU is configurable.
Also, please add to the help entry that upstream projects are not all
up to full support for microblaze, and that support is being added.
If there are out-of-tree public patches and/or alternate repositories,
you may also want to point to them in the help entry, so that interested
parties can use them until support is upstream.
Othwerwise, looks good!
Regards,
Yann E. MORIN.