On Wed, Jul 25, 2007 at 12:07 PM, Jeff Dike wrote:
> Looks reasonable (and useful). Do you want me to drop it in my tree
> and forward it to mainline?
Yes please, that would be great.
> If so, I'll need a changelog and a Signed-off-by:.
Here they are. I hope changelog is clear enought. Please tell me if you
want a properly formatted e-mail to submit to mainline.
Added vde network backend in uml to introduce native Virtual Distributed
Ethernet support (using libvdeplug).
Signed-Off-By: Luca Bigliardi <shammash@...>
> Some comments -
> style violations :
> there are some cases of return(x) which should be
> return x
> if( blah ){ should be if(blah) {
> if(foo) return bar - the return should be on the next
> line
> the indentation of multi-line function calls is whacked
>
> I would leave out the likely()s. Unless you can show a
> noticable performance difference, they only clutter the code.
> printks should have severity specified (in userspace code,
> they are available as UM_KERN_*)
> um_kmalloc is gone - use kmalloc with UM_GFP_KERNEL
Thank you. I'm attaching a new patch with some corrections tested on a
2.6.23-rc1-git1. I especially hope indentation of multi-line function
calls is getting better (I'm trusting vim's "gq", please tell me how's
going).
> I realize that you probably copied many of the above problems from the
> existing code. All I can say is that I'm gradually fixing them, and
> I'd rather not add new instances.
Yes, in fact i was getting "deeply inspired" :) by some existing parts
without paying enought attention to syntax.
luca
--
Beware of programmers who carry screwdrivers.
-- Leonard Brandwein
http://shammash.homelinux.org/ - http://www.artha.org/ - http://www.yue.it/