Hi,
On 28.02.2007 12:47, Stefan Reinauer wrote:
> * Lu, Yinghai <yinghai.lu at amd.com> [070205 18:09]:
>> USB DEBUG port support.
>> I committed this now, but I am unwilling to let this printk_ram stuff go
> in like that. We do not want yet another set of printk functions that
> have to be used with ifdefs spread in dozens of files. Can you please
> hook this up cleanly and against the CURRENT svn?
>> There's also smaller stuff that seems or seems not to be missing, like
> randomly commented in and out functions in yh_rest_of_patch.patch.
>> I will not go into further trouble of merging these changes now. If
> anyone feels this is needed, please help.
>> I made a new, somewhat cleaned up version of yh_rest_of_patch.patch
> But it is far from ready to go in.
The current printk stuff is a mess. Yinghai at least tried to clean
this up, but his tree diverged and so we have an even bigger mess.
Look at current svn and see the horror:
./src/arch/ppc/include/printk.h is a subset of
./src/include/console/console.h is a subset of
./src/arch/i386/lib/console.c
Duplicated code everywhere.
Suggestion: Look at the diff between LB-svn/src/arch/i386/lib/console.c
and LB-yhlu/src/arch/i386/lib/console_printk.c and see that moving code
between files helps readability. I can prepare a patch without functional
changes if anyone agrees.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/