[PATCH] Consolidate object search in DSO in _dl_find_dso_for_object

[PATCH] Consolidate object search in DSO in _dl_find_dso_for_object

Hi,

As Carlos, suggested, here's a patch to consolidate the object search
loop in various places in current code into a separate function.
There are only 3 places where this consolidation is needed (4 with
__cxa_thread_atexit_impl); the other two have a completely different
logic.

On 02/15/2013 06:43 AM, Siddhesh Poyarekar wrote:
> Hi,
>
> As Carlos, suggested, here's a patch to consolidate the object search
> loop in various places in current code into a separate function.
> There are only 3 places where this consolidation is needed (4 with
> __cxa_thread_atexit_impl); the other two have a completely different
> logic.

On Fri, Feb 15, 2013 at 01:33:20PM -0500, Carlos O'Donell wrote:
>
> While Andreas says the list should be alphabetical it doesn't look like it is :-)
>
> I guess it would be a distinct patch to sort the list first?
>
> How deep does the rabbit hole go?

Actually now that I think of it, the Versions files don't need to be
sorted; it is the abilist files that *must* be sorted.

> On Fri, Feb 15, 2013 at 01:33:20PM -0500, Carlos O'Donell wrote:
>>
>> While Andreas says the list should be alphabetical it doesn't look like it is :-)
>>
>> I guess it would be a distinct patch to sort the list first?
>>
>> How deep does the rabbit hole go?
>
> Actually now that I think of it, the Versions files don't need to be
> sorted; it is the abilist files that *must* be sorted.

On Mon, Feb 18, 2013 at 7:34 AM, Siddhesh Poyarekar <[hidden email]> wrote:
> +/* Search link maps in all namespaces for the DSO that containes the object at
> + address ADDR. Returns the pointer to the link map of the matching DSO, or
> + NULL if a match is not found. */