Jerry -
On Mon, Aug 24, 2009 at 12:32 PM, Jerry James<james(a)xemacs.org> wrote:
> On Wed, Jul 15, 2009 at 9:16 AM, Vin Shelton<acs(a)alumni.princeton.edu> wrote:
>> malloc takes a size_t. Here are the sizes of the respective types:
>>
>> sizeof(int) = 4
>> sizeof(long) = 4
>> sizeof(size_t) = 4
>
> Sorry to take so long with this. My 2 week vacation put me so far
> behind at work that it's taken me awhile to get around to all the bug
> reports that piled up for me while I was gone. It's a good thing I
> was able to relax for 2 weeks first! (NB: I had 4 children with me on
> vacation, which should tell you something about how much relaxing I
> got to do.)
>
> We need to deal with two issues. First is the missing (U)INT_64_BIT
> definition. Thanks for the pointer, Aidan. From looking at that, as
> well as a few other remarks about __int64 located with Google, it
> appears that this issue affects 32-bit Windows platforms exclusively.
> I think we can probably get away with just checking for __WIN32__,
> rather than piling on check after check for particular compilers on
> that platform.
>
> Second is the warning. Since we already check that the results of the
> image size calculation fit into a size_t, the only real problem here
> is that I forgot to cast to a size_t in one place.
>
> So I think this patch fixes both issues. Can somebody try it and tell
> me yea or nay?
Thanks for investigating. I tried your latest patch and found that I
had to change __WIN32__ to WIN32_NATIVE (in src/lisp.h) or else I got:
src\xemacs-21.5-test-2009-08-24\src\glyphs-eimage.c(412): error
C2065: 'UINT_64_BIT' : undeclared identifier
src\xemacs-21.5-test-2009-08-24\src\glyphs-eimage.c(412): error
C2146: syntax error : missing ';' before identifier 'pixels_sq'
....
- Vin
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

Ar an ceathrú lá is fiche de mí Lúnasa, scríobh Jerry James:
> We need to deal with two issues. First is the missing (U)INT_64_BIT
> definition. Thanks for the pointer, Aidan. From looking at that, as
> well as a few other remarks about __int64 located with Google, it
> appears that this issue affects 32-bit Windows platforms exclusively.
> I think we can probably get away with just checking for __WIN32__,
> rather than piling on check after check for particular compilers on
> that platform.
__WIN32__ isn’t defined on my particular native compiler (Visual C++ 2005
Express Edition, with Microsoft Platform SDK for Windows Server 2003 SP1). I
can use WIN32_ANY, from our include files, instead, and compilation goes
ahead successfully.
> Second is the warning. Since we already check that the results of the
> image size calculation fit into a size_t, the only real problem here
> is that I forgot to cast to a size_t in one place.
>
> So I think this patch fixes both issues. Can somebody try it and tell
> me yea or nay?
Yea on the first bit; I haven’t gone to the trouble of creating a corrupt
TIFF image that would trigger the second, please post one if you have it
around.
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghe, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches