Errors after WP-BP Update. Kindly help

Just Updated to WP 3.5 and BP 1.6.2 and get the following error on my album page, urgent help requested.

Warning: Missing argument 2 for wpdb::prepare(), called in /home/content/xx/xxxxxxx/html/wp-content/plugins/bp-album/includes/bpa.classes.php on line 322 and defined in /home/content/xx/xxxxxxx/html/wp-includes/wp-db.php on line 990

Warning: Missing argument 2 for wpdb::prepare(), called in /home/content/xx/xxxxxxx/html/wp-content/plugins/bp-album/includes/bpa.classes.php on line 310 and defined in /home/content/xx/xxxxxxx/html/wp-includes/wp-db.php on line 990

Warning: Missing argument 2 for wpdb::prepare(), called in /home/content/xx/xxxxxxx/html/wp-content/plugins/bp-album/includes/bpa.classes.php on line 322 and defined in /home/content/xx/xxxxxxx/html/wp-includes/wp-db.php on line 990

Warning: Missing argument 2 for wpdb::prepare(), called in /home/content/xx/xxxxxxx/html/wp-content/plugins/bp-album/includes/bpa.classes.php on line 310 and defined in /home/content/xx/xxxxxxx/html/wp-includes/wp-db.php on line 990

Warning: Missing argument 2 for wpdb::prepare(), called in /home/content/xx/xxxxxxx/html/wp-content/plugins/bp-album/includes/bpa.classes.php on line 322 and defined in /home/content/xx/xxxxxxx/html/wp-includes/wp-db.php on line 990

Warning: Missing argument 2 for wpdb::prepare(), called in /home/content/xx/xxxxxxx/html/wp-content/plugins/bp-album/includes/bpa.classes.php on line 310 and defined in /home/content/xx/xxxxxxx/html/wp-includes/wp-db.php on line 990

The BP-Media team just wants to say “Thanks for that, WordPress” </sarcasm>

They DELIBERATELY BROKE a function in the WordPress database class to remind some inexperienced developers about a potential SQL-injection flaw …potentially taking-out tens of thousands of plugins in the process.

BP-Album doesn’t have that SQL-injection flaw, but we ran several SQL statements through the prepare() method in the wpdb class for consistency, tripping their logic bomb.

It’s stupidity like this that delays plugins like BP-Media from being released.

Since we CAN’T TRUST the WordPress team, we have to code around them. For example, as of today, BP-Media no longer uses WordPress’ database class. We created our own fork of it to prevent this sort of stupidity from ever happening again.

@foxly isn’t this the second time you ranted on this subject today why not just fork WP altogether then you wouldn’t have the problem? Is this really the reason plugins like bp media get delayed from being released? You have been developing this plugin without a major release for over two years now.

We’ve already forked significant parts of WordPress, and it’s our eventual goal to have BP-Media able to operate without WordPress installed on the server at all (although still be able to interact with it if it is).

As for progress on BP-Media, we’ve started releasing blocks of code as individual plugins as they get completed:

Discovered this conversation just now. I’m from the team that develops buddypress media mentioned by @rickkumar.

Now, I’m not getting into the comparison game. Our plugin is not thoroughly tested, till now. We decided to get our hands dirty, early, so we could use user feedback and community involvement, faster.

Now that our plugin’s vision is getting aligned with real users, we are in the process of restructuring. Ours is much smaller in size and doesn’t boast of a host of features or an amazing ui. But, it is out there, available and being improved upon continuously, with live user feedback.

Now as for the error, the WordPress explanation cited by @modemlooper, is fairly simple and straightforward. When there is no filtering needed, a function like wpdp_prepare must fail. So WordPress is just putting things right. It broke our code, but we spent a little time doing find and replace for the function and corrected it.

@foxly can’t really disagree with your emotion. Often been tempted to go that way, decrease the dependency on WordPress. However, for the sake of lightness and tight functionality, and because that helps us debug the cores, WordPress and BuddyPress, themselves, we’ve stuck to using default wp functionality for as much as possible.

1. Our vision for the plugin is pretty much in contrast to yours, won’t work nice.
2. We bake our own bread, we eat our own dog food! What we write is closely tied with what we need, too.
3. If we compete instead, both the teams will be forced to outdo each other. That equals to two very good plugins, two options for users, two alternative ways of doing similar things. That’ll work out well for all of us, including users, I believe.

That being said, we are a commercial organisation (rtCamp Solutions Pvt Ltd) and such community projects satisfy our vested interests:

* of giving back to the community that helps us earn our bread (and butter ;)),
* interaction with the community,
* developing our skills and knowledge.

I don’t think, we can give that up, easily. Best of luck for your plugin, though!

Cheers!

Viewing 15 replies - 1 through 15 (of 15 total)

The topic ‘Errors after WP-BP Update. Kindly help’ is closed to new replies.