Activity

Updated patch that increases OK_FINDBUGS_WARNINGS to 1 after upgrading build machine findbugs to 1.3.9 (will file a new issue to get that back to zero). Also added the findbugs version in the jira comment message.

Nigel Daley
added a comment - 18/Nov/10 19:13 Updated patch that increases OK_FINDBUGS_WARNINGS to 1 after upgrading build machine findbugs to 1.3.9 (will file a new issue to get that back to zero). Also added the findbugs version in the jira comment message.

Konstantin Boudnik
added a comment - 19/Nov/10 01:23 Two things:
property file is missing for HDFS and MR (and it is expected to be in '..' relative to test-patch.sh location)
test-patch.sh isn't any more an external imported from common (which seems to be a good thing and will allow to use this feature on git without any additional hassle).

I'll fix this tonight. I needed to find out what the current number for these on trunk are. This is what I'm seeing:
HDFS Findbugs warnings on trunk: 0
HDFS Javadoc warnings on trunk: 0
HDFS Release Audit warnings on trunk: 98 (seriously?!?)

Nigel Daley
added a comment - 19/Nov/10 04:14 I'll fix this tonight. I needed to find out what the current number for these on trunk are. This is what I'm seeing:
HDFS Findbugs warnings on trunk: 0
HDFS Javadoc warnings on trunk: 0
HDFS Release Audit warnings on trunk: 98 (seriously?!?)
Other's agree with these numbers?

Eli Collins
added a comment - 19/Nov/10 04:30 Other's agree with these numbers?
Seems accurate. I looked at the rat warnings a while back, iirc they didn't seem problematic, but we should get these to zero in case real issues are hiding.