Konstantin Shvachko
added a comment - 03/Jun/10 19:24 Sounds like a good idea. One nit. It would be nice to use import static, like this
import static org.apache.hadoop.hdfs.server.common.Util.now;
Then direct calls to now() in FDNamesystem and DataNode will remain unchanged. In other places it will just say now .

Konstantin just beat me to the static import suggestion. I've added you to the HDFS contributors so you should be able to use submit patch to trigger Hudson's automated test patch; this also lets reviewers know the patch ready for review. Thanks for the contributions.

Jakob Homan
added a comment - 03/Jun/10 19:30 Konstantin just beat me to the static import suggestion. I've added you to the HDFS contributors so you should be able to use submit patch to trigger Hudson's automated test patch; this also lets reviewers know the patch ready for review. Thanks for the contributions.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 04/Jun/10 07:24 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12446323/HDFS-1185-2.patch
against trunk revision 951178.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/394/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/394/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/394/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/394/console
This message is automatically generated.