David Reiss
added a comment - 04/Sep/08 23:55 http://wiki.apache.org/thrift/NamingVote
Looks like I won . If you post a patch that implements this behavior, I'll commit it since It'll be a while before I can rename everything.

This patch makes the set of possible languages as first param to "namespace" constrained to the short names of the code generators. This means that if someone passes "ruby", you'll get a compiler error.

Bryan Duxbury
added a comment - 25/Apr/10 06:25 This patch makes the set of possible languages as first param to "namespace" constrained to the short names of the code generators. This means that if someone passes "ruby", you'll get a compiler error.

1/ Drop the printf.
2/ We already have a map of all of the generator names.
3/ Smalltalk support two different types of namespace declarations. I think it is something like "smalltalk.prefix" and "smalltalk.package".

David Reiss
added a comment - 26/Apr/10 21:10 1/ Drop the printf.
2/ We already have a map of all of the generator names.
3/ Smalltalk support two different types of namespace declarations. I think it is something like "smalltalk.prefix" and "smalltalk.package".

Could you help me figure out how to get access to the generator names in t_program? I glanced at this briefly before recalling the utter pain that was making the compiler treat enum/constant values correctly a while back. Would really love a compiler written in Java in situations like this.

Bryan Duxbury
added a comment - 26/Apr/10 22:01 Could you help me figure out how to get access to the generator names in t_program? I glanced at this briefly before recalling the utter pain that was making the compiler treat enum/constant values correctly a while back. Would really love a compiler written in Java in situations like this.

I just downloaded the latest thrift, and I can't even compile thrift with make because it can't find t_generator_registry.h
ERROR:
In file included from thrifty.yy:35:
./src/parse/t_program.h:41:43: error: generate/t_generator_registry.h: No such file or directory

Jordan
added a comment - 04/Aug/10 05:39 I just downloaded the latest thrift, and I can't even compile thrift with make because it can't find t_generator_registry.h
ERROR:
In file included from thrifty.yy:35:
./src/parse/t_program.h:41:43: error: generate/t_generator_registry.h: No such file or directory