From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
Brandon Williams <bmwill@google.com>,
Git Mailing List <git@vger.kernel.org>,
Antonio Ospite <ao2@ao2.it>
Subject: Re: [PATCH] grep: handle corrupt index files early
Date: Fri, 18 May 2018 07:57:59 +0900
Message-ID: <xmqq36yp6gaw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAGZ79kbvjoTq5079Ks+h2HNb+D99RELYPcJk2=pvZf9-Y8dToQ@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
> On Wed, May 16, 2018 at 6:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Duy Nguyen <pclouds@gmail.com> writes:
>>
>>> With a majority of call sites dying like this though, I wonder if we
>>> should just add repo_read_index_or_die() with die() inside. Then the
>>> next person won't likely accidentally forget _()
>>
>> Yuck.
>>
>> That sounds like inviting a major code churn. I tend to agree that
>> it would be a good clean-up for longer term maintenance, but I am
>> not sure if I can honestly say I'd look forward to such a clean-up
>> at this point in the cycle when there are tons of large-ish topics
>> in flight X-<.
>
> ok, consider the series
> https://public-inbox.org/git/20180516222118.233868-1-sbeller@google.com/
> retracted for this cycle; I will keep it around and resend it at some future
> date, hopefully.
Thanks. I didn't realize you've _already_ done that.