Commit Message

During my recent work on the bytcht-es8316 UCM profile I realized that the
bytcr-rt5651 devices with a single speaker use a differential setup just
like the es8316 does. The tell-tale here is the speaker going quiet when
playing the exact same sound on both channels when things are configured
for stereo speakers.
I've run some tests and the rt5651 does have a special mono balanced out
mode for its line-out but using this results in the same sound (and the
same loudness / volume of the sound) as our current solution, so adding
support for this to the kernel buys us nothing.
This commit makes no changes, it just documents my findings in a big
comment for future reference.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
src/conf/ucm/codecs/rt5651/MonoSpeaker.conf | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)

Comments

On Tue, 01 Jan 2019 12:32:46 +0100,
Hans de Goede wrote:
> > During my recent work on the bytcht-es8316 UCM profile I realized that the> bytcr-rt5651 devices with a single speaker use a differential setup just> like the es8316 does. The tell-tale here is the speaker going quiet when> playing the exact same sound on both channels when things are configured> for stereo speakers.> > I've run some tests and the rt5651 does have a special mono balanced out> mode for its line-out but using this results in the same sound (and the> same loudness / volume of the sound) as our current solution, so adding> support for this to the kernel buys us nothing.> > This commit makes no changes, it just documents my findings in a big> comment for future reference.> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thanks.
Takashi

Patch

diff --git a/src/conf/ucm/codecs/rt5651/MonoSpeaker.conf b/src/conf/ucm/codecs/rt5651/MonoSpeaker.confindex 0c3492fb..f4181d10 100644--- a/src/conf/ucm/codecs/rt5651/MonoSpeaker.conf+++ b/src/conf/ucm/codecs/rt5651/MonoSpeaker.conf@@ -9,7 +9,21 @@ SectionDevice."MonoSpeaker" {
EnableSequence [
cdev "hw:bytcrrt5651"
- # Map left and right input on left+ # On most (all?) devices with a single / mono speaker an+ # amplifier with a differential input connected between LOUT+ # right and left is used. We deal with this by silencing the+ # right output and mixing left + right to the left output.+ #+ # An alternative approach for devices using the differential+ # setup would be to set bit 15 of register 5 in the codec,+ # which turns the stereo unbalanced line out into a mono+ # balanced line out.+ #+ # This possibility was discovered after we already shipped the+ # current solution and the current solution has the advantage+ # of also working on devices which only use LOUT left in+ # unbalanced mode. The net result is the same for devices using+ # the differential setup, so we just stick with what we have.
cset "name='Stereo DAC MIXR DAC R1 Switch' off"
cset "name='Stereo DAC MIXL DAC R1 Switch' on"