Details

Description

I've been doing some "final" performance testing of 2.3RC1 and
uncovered a fairly serious bug that adds a large fixed CPU cost when
documents have any term vector enabled fields.

The bug does not affect correctness, just performance.

Basically, for every document, we were calling Arrays.fill(0) on a
large (32 KB) byte array when in fact we only needed to zero a small
part of it. This only happens if term vectors are turned on, and is
especially devastating for small documents.

Michael Busch
added a comment - 10/Jan/08 17:48
The fix is very low risk. All tests pass.
Yes, all contrib & core tests pass for me too. And after reading the
patch I agree that it looks good and is low risk.
Michael, I think we should spin 2.3 RC2 to include this fix? Sorry to
only find it so late in the game
OK, why don't you commit this today. Meanwhile I'll look into the
small issues Hoss pointed out and then build RC2 end of today.
Oh, and no need to be sorry! This is what the code freeze period is
for - finding and fixing problems!

Michael McCandless
added a comment - 10/Jan/08 18:09
OK, why don't you commit this today. Meanwhile I'll look into the
small issues Hoss pointed out and then build RC2 end of today.
OK, will do, thanks!