[distro] gac410 pushed 1 new commit to master: http://git.io/vt9b5
distro/master abdeb2e George Clark: Item13139: Die if installing incompatible extensions...
http://foswiki.org/Tasks/Item13139 [ Item13139: Backwards compatibility issues with Foswiki 1.2 default extensions ]
Hi, a lot of my pages are using the font-awesome graphics, so need %JQREQUIRE{"fontawesome" warn="off"}%
in the topic. Is there somewhere higher level I can put this, so that I don't need it in every topic?
I think you can make it a default plugin in bin/configure
Check out {JQueryPlugin}{DefaultPlugins}
In Extensions / JQueryPlugin tab
Great, thanks. I'll have a look. Also wondering about something else. I have a web I don't want people to see yet, but my other webs use some includes from it. What's the best way to set that up?
You can deny view on the web, and then individually allow view on the topics
Yeah, sounds much easier than denying view on each topic. There's a lot of them. Thanks!
RiskReward: Regarding the JQREQUIRE. If it's just group of topics, you can also put the JQREQUIRE in a view template for those topics.
@gac410: yep, nice idea. But I'm trying to keep things very simple for my users. Is there a performance issue with enabling it via configure?
nno I don't think so. it ends up on every page, but I don't think that's an issue.
Hi, is there a way to universally deny view on a web, or do I need to list each group in the wiki?
if you Allow NobodyGroup, that's the same as denying everybody
Foswiki 1.2 will add an * wildcard, so you could deny *, but allow Nobody works too.
I've denied view on the web (allow nobody), and allowed it on a topic in the web, but still get an "Access Denied"
hm That should work fine. Did you get the syntax of the allow right?
* Set ALLOWTOPICVIEW = SomeUser,SomeGroup
Actually, I used the NatEditPlugin. It has a permissions page. Doesn't seem to have recorded anything in the topic. I'll try manually adding the setting.
Ah NatEditPlugin puts it in the topic meta.
Take a look at YourTopic?raw=all
Should be a META preference
That should work as well.
OK, so NatEditPlugin didn't change it. I then tried to be clever and manually added: DENYTOPICVIEW = %USERSWEB%.NobodyGroup, thinking it would do the opposite. Doesn't seem to.
Deny NOBODY should be equivalent of ALLOW all.
Could it be that the deny on web view is overriding the allow on the topic?
No, Topics override web settings
See Foswiki:System/AccessControl#How_Foswiki_evaluates_ALLOW_47DENY_settings
http://foswiki.org/System/AccessControl#How_Foswiki_evaluates_ALLOW_47DENY_settings [ AccessControl ]
OK. But error message says: Access check on QMS.ApprovalForm failed. Action "VIEW": access not allowed on web.
So that says that the ALLOW on the topic was not matched.
That link I posted. It runs steps 1 - 7 in order, stopping at the first BOLD match.
Have removed the DENYTOPICVIEW, and replaced with ALLOWTOPICVIEW, and it seems to work.
hm Maybe I got the DENY Nobody part wrong.
yeah looks like i had it wrong. ALLOW implies everyone else denied. but DENY doesn't imply everyone else allowed.
Yeah, just rechecked, and seems like DENY trick doesn't work at topic level.
This changes in Foswiki 2.0
http://trunk.foswiki.org/System/AccessControl#How_Foswiki_evaluates_ALLOW_47DENY_settings
Looks like I'll have to upgrade!
(we renamed Foswiki 1.2 to Foswiki 2.0 ... decided it was big enough to warrant a "major" designation.
I like it better too!
I built the Release Candidate today. I hope... that we can build the release in a few days.
I think it might capture more attention if it's a 2.0 release.
yeah. The Store change, and the move to UNICODE internally really are a big change.
Hey, not all my users are members of groups. How do I ALLOWTOPICVIEW for all of them without having to enter all of their names?
Hm... That was the reason for the ALLOW * addition.
okay that comes to If DENYTOPIC is set to empty ( i.e. Set DENYTOPIC = )
So instead of Deny NOBODY, you need to set it, but empty.
That goes away in 2.0
(I don't know how NatEditPlugin does that. though)
Thanks, I'll give that a try now.
and, it works, thanks!
[distro] cdot pushed 1 new commit to master: http://git.io/vt7RD
distro/master ce81eb7 Crawford Currie: Item13100: yes, it was double-encoding, and a couple of other minor buglettes too
http://foswiki.org/Tasks/Item13100 [ Item13100: bulk_copy.pl needs thorough review & testing for 1.2 ]
Hey CDot - good morning. I see the bulk_copy was broken. That probably needs a new RC do you think?
I checked in a bunch of doc issues jomo found
not broken exactly, more.... completely f***ed
one little decode_utf8 in the wrong place :-(
:(
y, we can't release what was there.
Ive got a small patch on Item13491 I'll check in. Installer crashes if extensino has no plugins
http://foswiki.org/Tasks/Item13491 [ Item13491: Configure extension installer can crash if no plugins in the extension. ]
not sure if it's ideal, but it seemed to fix the issue.
there are two "Utf8" testcases in TestCases web. I'm going to remove them, because (annoyingly) they risk breaking tests
:( They were really helpful
they can still be pulled for testing
okay
we probably ought to make a quick check for any non-ascii in the release.
UTF-8 data/System/ReleaseNotes02x00.txt
UTF-8 data/System/JQueryInnerFade.txt
UTF-8 data/System/CountryList.txt
[distro] gac410 pushed 1 new commit to master: http://git.io/vt5mm
distro/master e4475ca George Clark: Item9693: UTF8 characters found in system topics
http://foswiki.org/Tasks/Item9693 [ Item9693: Documentation updates for Foswiki 1.2.0 ]
[distro] FoswikiBot pushed 1 new commit to master: http://git.io/vt5m5
distro/master 31cc35f CH yang: Item13252: Translations updated using Weblate (Traditional Chinese)...
http://foswiki.org/Tasks/Item13252 [ Item13252: Translation work for Foswiki 2.0 ]
[distro] cdot pushed 1 new commit to master: http://git.io/vt5On
distro/master ec29f49 Crawford Currie: Item13492: remove the testcases developed for the Unicode move. They are not need longe-term now we have moved everything to unicode, but may still be useful so have been attached to Foswiki:Development/CharacterSetTestCases instead.
http://foswiki.org/Tasks/Item13492 [ Item13492: Remove character set encoding topics from TestCases ] http://foswiki.org/Development/CharacterSetTestCases [ CharacterSetTestCases ]
[distro] gac410 pushed 1 new commit to master: http://git.io/vt5s0
distro/master 165f59a George Clark: Item13491: Installer fails to complete if no plugins
http://foswiki.org/Tasks/Item13491 [ Item13491: Configure extension installer can crash if no plugins in the extension. ]
Anyone else see any issues? otherwise I'll build RC2 and that's the one we'll announce.
hi gac410... I'm so sorry but have not a lot of free time these last days, so I haven't make any test more than the last week-end.
no problem. I understand, and thanks for all you've done so far. Free time comes & goes :)
oh... to my point of view.. I don't spent enough time, regarding what foswiki bring to me.
hum just one thing minor
what the name of the template used after having upload a doc ?
I think there is a sentence to suppress who speak about utf8 attachment
Not sure GuilainC
make a test on trunk
I will see, and probably found minor other miss utf8 render character
As long as it's not a translated string. ... That I can't change quickly anyway
is a translated string :(
but first let me find it !
:)
CDot, MichaelDaum ... Should I build RC2 ? anyone else with anything at all pending?
gac410, go for it :)
[distro] gac410 pushed 1 new commit to master: http://git.io/vt5EA
distro/master 9c482d9 George Clark: Item9693: Update release notes
http://foswiki.org/Tasks/Item9693 [ Item9693: Documentation updates for Foswiki 1.2.0 ]
oh get a crash on trunk... simple attach topic
attach image (sorry)
http://pastebin.com/2x7fw027
try to go forward
You hit it when it was updating
try it again
when you see a commit in the IRC logs, Trunk will auto-update at the next quarter-hour. Takes 1-2 minuts
gac410: well, I've done everything I have been asked to do, so.....
Okay ... just checking. Build just finished. Now to test it, and start the uploads, etc.
might be worth grepping the release package for 1.2(.0)
I did that last night and updated a bunch but maybe missed some.
i saw that
damn. Found another one. FormattedSearch :P
[distro] gac410 pushed 1 new commit to master: http://git.io/vt5Kw
distro/master bf030b9 George Clark: Item9693: A few more missed 1.2 references
Okay ... NOW I'm building 2.0 RC2
gac410: am I too late to catch another one?
http://trunk.foswiki.org/Sandbox/AttachmentTestTopicGuilainC
some minor problem
(very minor IMHO)
do you want I make a task ?
CDot: no go head. I've built, but not checked in yet, so go for it
[distro] cdot pushed 1 new commit to master: http://git.io/vt5yA
distro/master fe0b87d Crawford Currie: Item9693: 1.2 -> 2.0
GuilainC: I'm not following all of the issues in your example. String delete is easy,
But the quotes?
CDot: can you look at GuilainC issue. I think it's cosmetic but not sure. It shows some filenames with the apostrophe in the name and others without
We do need to sanitize out apostrophe, so that could be concerning if it is actually making it into the attachment name.
deleting is easy, but first are you agree is not needed anymore ?
is perhaps the same in 1.1.9 not tested...
I don't understand what the problem is :-(
don't worry CDot is not the first time, where someone tell me that...
Blow up the graphics, an look at the attachment names. Some have apostrophe's and some dont have apostrophes
this simple the name of the attachment in the upper and the bottom is not the same
I understand the pointless string, that's easy enough, but the rest of it..... :-/
there is an apostrophe difference
It's in french so I'm having trouble underestanding it.
I've submitted an attachment with apostrophe
capture d'écran = screenshot :)
did you see CDot ?
I can make an paint annotation if need be
Is the original topic with the attachments in the sandbox?
cdot only this image is usefull http://trunk.foswiki.org/pub/Sandbox/AttachmentTestTopicGuilainC/ExplanationImage3.png
(for you)
you are saying the upload process transposes UTF8 characters when renaming the upload, right?
yes gac410, is the original topic in the sandbox, and screenshot are coming from trunk
yes
submitted "filename ütf8 with apostrophe'.png"
er. No. ??? d'ecran vs decran
transform into "filename ütf8 with apostrophe.png"
so apostrophe disapear (during the renaming, perhaps not the utf8 treatment)
but, when you manage this file (manage = click on "manage link"
you have the original name with apostrophe at the top
and at the bottom the "real" saved name in foswiki
the two differ
CDot. Look at http://trunk.foswiki.org/bin/attach/Sandbox/AttachmentTestTopicGuilainC?filename=Capture_d%C3%A0cran_-_20062015_-_17_29_25.png;revInfo=1
AFAICT all the sanitizeAttachmentName thing does is to $fileName =~ s/$Foswiki::cfg{NameFilter}//g;
Select a new local file to update attachment ... shows one name More actions for Capture_dàcran ... shows a different name
One appears filtered, the other not.
$Foswiki::cfg{NameFilter} = '[\\s\\*?~^\\$@%`"\'&;|<>\\[\\]\\x00-\\x1f]';
Okay. I checked the server, the filename on disk is correctly filtered.
"correctly"? Hmmm.
Well the apostrophe is removed.
But manage the attachment still shows it:
Select a new local file to update attachment Capture_d'écran_-_20062015_-_17_29_25.png (GuilainCabannes)
d'é
*note
maybe a console thing, but the name is corrupted when I ls the directory though.
... 4114 Jul 1 12:58 Capture_d??cran_-_20062015_-_17_29_25.png
At least there is no apostrophe.
Looking at the META:
ahhhhhh
%META:FILEATTACHMENT{name="Capture_dàcran_-_20062015_-_17_29_25.png" attachment="Capture_décran_-_20062015_-_17_29_25.png... movedto="Sandbox.AttachmentTestTopicGuilainC.Capture_dàcran_-_20062015_-_17_29_25.png",,, movefrom="Sandbox.AttachmentTestTopicGuilainC.Capture_décran_-_20062015_-_17_29_25.png" path="Capture_d'écran_-_20062015_-_17_29_25.png" size="4114" user="GuilainCabannes" version="1"}%
so name, movefrom moveto are sanitized, attachment and path are not
path *cannot* be sanitised, it's the source path IIRC
agreed
it's not passed in the call to $topicObject->attach(
y I don't remember coming across that one.
$attrs = {
name => $opts{name},
attachment => $opts{name},
so it's synonymous with "name"
Hm So why are they different
ah.... is there a plugin involved?
trunk.foswiki.org I doubt it
Unless NatEdit ?
nah
wait a minute, they are NOT different I need glasses
no, they are the same, but why do we store both?
And the attach template must be showing the path then
---+++ META:FILEATTACHMENT in System.MetaData doesn't document 'attachment'
the {attachment} field doesn't seem to be used anywhere in core
Maybe one of MichaelDaums plugins needs it ???
no idea
gac410, ghosts ey?
CDot regarding "International (8-bit) characters are removed ... What if site is running with Store Encoding Iso-8859-1
Otherwise that's easy enough to delete
y, that would break it
can't store arbitrary unicode on a iso-8859-1 store encoding
but.... from the code, they are *not* removed
Okay. So that one probably ought to be in the release notes. If you chose to use iso store, dragons lurk if users attach 8-bit filenames
I've removed that warning about 8-bit, and rerun xgettext.
Foswiki::Meta::attach() adds name and attachment attrs to META::FILEATTACHMENT
http://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Meta
and yes they are identical
Any reason both are needed that you know of?
the {attachment} field is a kipper
"name" changes when an attachment is renamed, "attachment" stays as it was on the initial upload
MichaelDaum: wish that were so. The are both identictal/
so in principal you could write an "undo rename attachment"
CDot, see change properties. only "name" is updated
I'm adding to release notes on the Store encoding: Note that the name filters no longer filter international characters, so migration to utf-8 is strongly recommended.
trust me, the "attachment" field is ignored
we still have movedfrom/movedto
%META:FILEATTACHMENT{name="foo.png" attachment="webtide_logo.png" attr="" comment="" date="1435759761" moveby="micha" movedto="Sandbox.AttachmentTest.foo.png" movedwhen="1435759893" movefrom="Sandbox.AttachmentTest.webtide_logo.png" path="webtide_logo.png" size="21113" user="micha" version="1"}%
"path" is the only place the original name is kept
Regardless, I don't think this one should change on eve of the release ... just in case
oh and yes "path"...
mpf
stripping off "attachment" from Foswiki::Meta::attach() would be a one-line delete change
are we totally 100% absolutely positively sure it doesn't have any side effects :D
gac410, we are definitely unsure wtf "attachment" is
my $filePath = $args->{path} || $fileName;
$tmpl =~ s/%FILEPATH%/$filePath/g;
is what is doing it
gac410, so ignore us
gac410: I can't find any uses of it, but at this stage, the only thing I'll do is add a SMELL
skunk ;)
Okay good decision :) And you also explained why the quote is still visible. So good. I'll commit the string changes and start another build.
so my vote is it "move along, nothing to see here"
paint it pink and add an other-peoples-problem field around it
gosh, it' hot
32C today :-)
19C and raining :(
[distro] gac410 pushed 1 new commit to master: http://git.io/vtdqT
distro/master c8a1126 George Clark: Item9693: Remove a misleading string...
http://foswiki.org/Tasks/Item9693 [ Item9693: Documentation updates for Foswiki 1.2.0 ]
Any more .... Going ... going .... GONE
CDot, what is stream="IO::File=GLOB(0x3cb4e60)" tmpFilename="/usr/tmp/CGItemp47077 for in FILEATTACHMENT
gasp... and presses enter
MichaelDaum: it's an attribute that should have been removed before the META:FILEATTACHMENT was written, but wasn't
probably got lost in all the knitting
SMELL
yup
okay. Release built, install / sanity looks good.
[distro] gac410 pushed 1 new commit to master: http://git.io/vtdn5
distro/master dd241c5 George Clark: Item000: Build Foswiki-2.0.0-RC2
http://foswiki.org/Tasks/Item000 [ Item000 ]
[distro] gac410 tagged FoswikiRelease02x00x00_RC2 at 0a16d96: http://git.io/vtdcU
And uploading to SourceForge
MichaelDaum: hmmm: something leaked. Code says:
delete $attrs->{stream};
delete $attrs->{tmpFilename};
$this->putKeyed( 'FILEATTACHMENT', $attrs );
so 'stream' should never make it to META:FILEATTACHMENT
Foswiki 1.2.0 is now Foswiki 2.0.0 - Download RC2: http://foswiki.org/Download/FoswikiRelease02x00x00RC2 Channel logs at http://irclogs.foswiki.org/bin/irclogger_log/foswiki
[ #foswiki 2015-07-01,Wed ]
aww... crap Release notes still have title of RC1 ... I'm not rebuilding to fix something that minor.
MichaelDaum: Should we do an email about RC2, considering that if we are lucky, we'll release 2.0 on Saturday?
Or maybe just a short one to the discuss list?
how about: have a blog posting first, set it into draft mode so that we can edit collaboratively, then create the email from it.
okay
MichaelDaum: Saved first draft
MichaelDaum: Saved 2nd draft ... over to you
"to be compatible with Foswiki 2.0" ... right?
You can delete and 51 bugfixes since Beta 1 that's not right, and I have not counted commits
ok
done
Looks good Michael
I'll c/p and send it to foswiki-discuss. I think we can skip foswiki-announce
ah send it 2 both
twice
;)
okay. and I just edited a couple of typos. ut-8 and unicode
Any more edits ... otherwise sending now. ...
And... SENT
sounds good
guys here's the link: social networks please http://blog.foswiki.org/foswiki-2-0-release-candidate-is-available/
Anyone with twitter access?
congratz gac410 - RC2 :)
Howdy jomo, just in time for the RC2 party ...
just one super-mini-bug ;)
well congratz to the whole team, including you. We'd be nowhere without the testers.
naaaaawwww ;)
:D
la-la-la-la fingers in ears ... what bug ... la-la-la-
nothing.... fix in 2.0.1 :)
If it's docs / typo, we can fix between RC2 and release.
Otherwise, please open a task
the SERVERINFO macro prints scrabled path_info if it is used in a topic wide-char name - nobody will use it anyway :) :)
ah. .. okay
we need open a bottle of something....
well don't celebrate too hard - ... Lets pop corks after 2.0 is out.
CDot, extreme sprint to unicode, and gac410 marathon on fixing many-many things and make a pressure to the release ;) - imho the team CAN celebrate... :)
so, what features will be in 2.1? :D :D :D
some dev/decision_maker and like - could rewrite the releaseplan ;)
Once we get 2.0 out, we should probably have a release meeting to organize. A lot of committed features have lost their developers.
i'm pretty optimistic now - much much more as few months ago...
Before we jump on 2.1, we really need some extension love.
i still not understand how the extenstion policy works in the FW - imho, here isnt any policy.. ;(
what do you mean by extension policy?
rules. ;) e.g. defined: how teh verision numbers should lool, how the "last update" date must be in excatly defined field, how the plugins defined incompatible plugins, how the configure solves the incompatibility... and so on.. rules. defined. no democracy. (read: anarchy). :) - example: the AutoTemplatePlugin detects the it is in a conflict with AutoViewPlugin (or simething such) - but the configure hasn't any method to solve this - the user
must read something to do this... and so on... etc... uff (long line).
not good theme for the today - today we shouldn't work :)
what macro renders an "SecondLife" scene in the Foswiki ? :D
jomo try
%SECONDLIFE%
sometimes... that works :)
I'm not aware of any easter eggs in fw
exactly, thats a problem ;)
omg ! %BEER% doesn't work ! you right, do you open a task for that ?
jomo, get a first life first: http://uploads.meiobit.com/firstlife.jpg
firstlife.jpg - nice - this is only 3rd at me... the second is WordOfWarcraft :)
GuilainC: add to WebPrefs Set BEER = http://beeroverip.org :) :)
great workaround jomo !
and beer is so cheap in slovakia
and very nice too
yes, we like beer :)
seriously, I think more an emoticon, that I can use when "develop" wiki app... like an todo (I've take a beer, so I've stop here...)
Only automate creating tasks if you automate fixing them too, please!
gac410: :D
and the F.O will be switched to 2.0 only after the release?
I was going to do the RC, but TBH I'm running out of steam.
I'd like to convert to plainfile as well ... so that extension uploads don't die in rcs timeouts.
But that makes it even a bigger effort.
yes, unofrtunately isn't possible to do it step-by-step - e.g. one web RCS, second PF..
wc -l /var/db/ip_blacklist - 25291 ;)
after 2.0 release, could I suggest to rework Development.ReleasePlan ?
and if you are agree, could i suggest to submit to vote the different enhancement and functionality ?
GuilainC_away: Given that nobody's paid, this all really depends upon developer interest and desire to "scratch an itch".
The best thing beyond meeting and deciding what we'd like to prioritize is to find developers to work on those priorities.