[patch] [cla] Tree: dnd cause the browser crash

Description

Test case :/dijit/tests/tree/test_Tree_Programmatic.html

Defect 1:
If I drag and drop the items a little quickly, the browser will be crashed,the browser will no response ,and then will output the errors(IE is stackoverflow,ff is too much recursion),then many avatars can not be hidden,and some items disappeared.

Defect 2:
If the tree is too width or height ,there will be a scroll bar. I drag the scroll bar by accident .The avatar pointed item is the last selected item ,and the avatar will exist all the time.

I can't acess those "one.7z" and "two.7z" files you uploaded, are those screenshots? You should upload them in a standard format: PNG, GIF, JPEG, TIFF, etc.

Judging from your description (of "defect #1") you aren't getting a browser crash but just a javascript exception. It sounds like #7971/#10587 but I can't reproduce those tickets or this one. You might also just be seeing #6346 or #9475.

I don't understand what your "defect #2" is about. I can't get a vertical scrollbar on test_Tree_programmatic regardless of browser window size... there is just the browser's scrollbar itself.

I can't acess those "one.7z" and "two.7z" files you uploaded, are those screenshots? You should upload them in a standard format: PNG, GIF, JPEG, TIFF, etc.

Judging from your description (of "defect #1") you aren't getting a browser crash but just a javascript exception. It sounds like #7971/#10587 but I can't reproduce those tickets or this one. You might also just be seeing #6346 or #9475.

I don't understand what your "defect #2" is about. I can't get a vertical scrollbar on test_Tree_programmatic regardless of browser window size... there is just the browser's scrollbar itself.

Cool, thanks for the test case. Dropping an item onto itself definitely won't work but the copy-rather-than-cut problem is a bug. Actually there's also a problem with the test case itself, since users of ForestStoreModel are required to implement onLeaveRoot and onAddToRoot.

I've got a patch for this which I'll attach here, and checkin for 1.6, after some more testing.