Re: [Liferea-devel] [patch] autofoo update

Am Montag, den 19.06.2006, 19:24 +0200 schrieb Rémi Cardona:
> Lars Lindner wrote:
> > On 6/19/06, Rémi Cardona <remi2402@...> wrote:
> >> Lars Lindner wrote:
> >>> Thanks for the explanation. I removed it from source control.
> >>> I'll put up a new test tarball on SF.
> >> I think you forgot to add po/LINGUAS to subversion.
> >
> > As always. In 9 out of 10 cases I forget to add in a new file...
> > I'll fix this in some hours. Is there a simple SVN command to
> > list all files with their source control status?
The file is in SVN now.
> "svn status", or "svn st" will tell you what files were added, modified,
> or even just created but not under source control. Beware though that
> svn hides some files such as .o, backup~ and a bunch of others.
Ah... like "cleartool lsp"...
> I'd recommend reading the SVN Book.
> http://svnbook.red-bean.com/en/1.2/index.html It's the best reference on
> the subject. You can directly go to the parts you want to know about,
> it's really well written.
Thanks for the hint.
Lars

Thread view

Hi all,
Here is a patch with the modifications I had to do to clean some of the=20
building issues I had.
I had to remove some files from the POTFILES.in since they are not built=20
by any Makefile.am, but it's easy to add them back once the Makefiles=20
are updated.
In the end, to build liferea, I had to do the following:
$ autoreconf -i
$ intltoolize
$ ./configure && make && make install
"make dist" works and creates a buildable tarball, but "make distcheck"=20
(which runs a "make uninstall") fails because of the way the css files=20
are added to /usr/share.
I'm not sure if it's worth bothering with this, since most distros don't=20
rely on "make uninstall" anyway, and it didn't work before :)
Cheers,
R=E9mi

Am Sonntag, den 18.06.2006, 12:57 +0200 schrieb Rémi Cardona:
> Hi all,
>
> Here is a patch with the modifications I had to do to clean some of the
> building issues I had.
>
> I had to remove some files from the POTFILES.in since they are not built
> by any Makefile.am, but it's easy to add them back once the Makefiles
> are updated.
Removing them is ok.
> In the end, to build liferea, I had to do the following:
>
> $ autoreconf -i
> $ intltoolize
> $ ./configure && make && make install
>
> "make dist" works and creates a buildable tarball, but "make distcheck"
> (which runs a "make uninstall") fails because of the way the css files
> are added to /usr/share.
>
> I'm not sure if it's worth bothering with this, since most distros don't
> rely on "make uninstall" anyway, and it didn't work before :)
I don't think this is important. It is the last step in the
build/distcheck process and isn't that important.
I applied your patcht to SVN trunk. Worked properly.
The only thing I do not really understand is po/Makefile.in.in.
When should it be created? By intltoolize right when calling it
after autoreconf or by configure? Should it be under source control
(SVN) or should it be generated dynamically.
Lars

Am Montag, den 19.06.2006, 00:15 +0200 schrieb Rémi Cardona:
> Lars Lindner wrote:
> >
> > I applied your patcht to SVN trunk. Worked properly.
> >
> > The only thing I do not really understand is po/Makefile.in.in.
> > When should it be created? By intltoolize right when calling it
> > after autoreconf or by configure? Should it be under source control
> > (SVN) or should it be generated dynamically.
>
> It's symlinked from /usr/share/intltool/Makefile.in.in when you call
> intltoolize, so there's no need to put it under version control.
>
> People building from svn will just have to run intltoolize after running
> autoreconf -i.
>
> People using the tarballs won't notice anything different since "make
> dist" pulls Makefile.in.in and includes it in the tarball.
Thanks for the explanation. I removed it from source control.
I'll put up a new test tarball on SF.
Lars

On 6/19/06, R=E9mi Cardona <remi2402@...> wrote:
> Lars Lindner wrote:
> > Thanks for the explanation. I removed it from source control.
> > I'll put up a new test tarball on SF.
>
> I think you forgot to add po/LINGUAS to subversion.
As always. In 9 out of 10 cases I forget to add in a new file...
I'll fix this in some hours. Is there a simple SVN command to
list all files with their source control status?
In ClearCase one does a simple "cleartool ls" and one gets
a one file per line view with the view version for each file, or no
version at all for view private files. So I can easily determine
which files are not under source control.
The same for SVN would be great.
> I freaked out when I checked out a clean copy and none of the locales
> would install properly. For a minute there, I thought I gave you a non
> working patch :)
Not your fault. Patch was 100% ok.

Lars Lindner wrote:
>
> I applied your patcht to SVN trunk. Worked properly.
>=20
> The only thing I do not really understand is po/Makefile.in.in.
> When should it be created? By intltoolize right when calling it
> after autoreconf or by configure? Should it be under source control
> (SVN) or should it be generated dynamically.
It's symlinked from /usr/share/intltool/Makefile.in.in when you call=20
intltoolize, so there's no need to put it under version control.
People building from svn will just have to run intltoolize after running=20
autoreconf -i.
People using the tarballs won't notice anything different since "make=20
dist" pulls Makefile.in.in and includes it in the tarball.
Cheers,
R=E9mi

Lars Lindner wrote:
> Thanks for the explanation. I removed it from source control.
> I'll put up a new test tarball on SF.
I think you forgot to add po/LINGUAS to subversion.
I freaked out when I checked out a clean copy and none of the locales=20
would install properly. For a minute there, I thought I gave you a non=20
working patch :)
Cheers,
R=E9mi

Lars Lindner wrote:
> On 6/19/06, R=E9mi Cardona <remi2402@...> wrote:
>> Lars Lindner wrote:
>>> Thanks for the explanation. I removed it from source control.
>>> I'll put up a new test tarball on SF.
>> I think you forgot to add po/LINGUAS to subversion.
>=20
> As always. In 9 out of 10 cases I forget to add in a new file...
> I'll fix this in some hours. Is there a simple SVN command to
> list all files with their source control status?
"svn status", or "svn st" will tell you what files were added, modified,=20
or even just created but not under source control. Beware though that=20
svn hides some files such as .o, backup~ and a bunch of others.
I'd recommend reading the SVN Book.=20
http://svnbook.red-bean.com/en/1.2/index.html It's the best reference on=20
the subject. You can directly go to the parts you want to know about,=20
it's really well written.
R=E9mi

Am Montag, den 19.06.2006, 19:24 +0200 schrieb Rémi Cardona:
> Lars Lindner wrote:
> > On 6/19/06, Rémi Cardona <remi2402@...> wrote:
> >> Lars Lindner wrote:
> >>> Thanks for the explanation. I removed it from source control.
> >>> I'll put up a new test tarball on SF.
> >> I think you forgot to add po/LINGUAS to subversion.
> >
> > As always. In 9 out of 10 cases I forget to add in a new file...
> > I'll fix this in some hours. Is there a simple SVN command to
> > list all files with their source control status?
The file is in SVN now.
> "svn status", or "svn st" will tell you what files were added, modified,
> or even just created but not under source control. Beware though that
> svn hides some files such as .o, backup~ and a bunch of others.
Ah... like "cleartool lsp"...
> I'd recommend reading the SVN Book.
> http://svnbook.red-bean.com/en/1.2/index.html It's the best reference on
> the subject. You can directly go to the parts you want to know about,
> it's really well written.
Thanks for the hint.
Lars