[ https://issues.apache.org/jira/browse/DERBY-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480708
]
V.Narayanan commented on DERBY-2443:
------------------------------------
Thank you for looking at the patch!!
>Can't you just remove the if-else block and do the assert, which seems to be common for
all cases?
The existing code does it that way and I did not disturb it. I just changed the SQLState.
However I agree to this and shall make this change in my follow-up patch.
>There are also some long lines in client/am/ResultSet.
I shall fix these formatting issues in a follow-up patch.
> Implement ResultSet updateClob/updateBlob methods on the NetworkClient
> -----------------------------------------------------------------------
>
> Key: DERBY-2443
> URL: https://issues.apache.org/jira/browse/DERBY-2443
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Environment: All
> Reporter: V.Narayanan
> Assigned To: V.Narayanan
> Attachments: ResultSetNotImplMethods_v1.diff, ResultSetNotImplMethods_v1.stat
>
>
> Implement the following ResultSet methods on the Network Client
> updateBlob(int columnIndex, Blob x)
> updateBlob(String columnName, Blob x)
> updateClob(int columnIndex, Clob x)
> updateClob(String columnName, Clob x)
> updateBlob(int columnIndex, InputStream x, long length)
> updateBlob(String columnName, InputStream x, long length)
> updateClob(int columnIndex, Reader x, long length)
> updateClob(String columnName, Reader x, long length)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.