<richlv> if statement indentation seems to be still broken, it's spacing is broken as well (after all, that line was modified...) and sql statement still has excess spaces between arguments. there might be other things not listed here.

<Sasha> An update_template_dependencies_for_host() function is not used anywhere; a commented code should be removed
<Slava>RESOLVED r 24896

richlv
added a comment - 2012 Jan 17 14:40 - edited (1) changes in rev 24828 violate coding style guidelines
<Slava>RESOLVED
<richlv> if statement indentation seems to be still broken, it's spacing is broken as well (after all, that line was modified...) and sql statement still has excess spaces between arguments. there might be other things not listed here.
<Sasha> An update_template_dependencies_for_host() function is not used anywhere; a commented code should be removed
<Slava>RESOLVED r 24896
<pavels> More coding style fixes in r25011, please review.
<Sasha> CLOSED

Pavels Jelisejevs
added a comment - 2012 Feb 09 10:17 - edited Alexander has written a spec on how templated trigger dependencies should be handled. It's available here http://zabbix.org/wiki/Docs/specs/ZBX-4333
<zalex> I guess we have ZBXNEXT-1072 to discuss this awesome work. I'll add few thoughts there.

The fix for the trunk is available in /branches/dev/ZBX-4333-trunk. I've done some code refactoring and fixed several bugs connected to trigger dependencies. I think the code will be a little simpler now.

Pavels Jelisejevs
added a comment - 2012 Feb 14 10:56 The fix for the trunk is available in /branches/dev/ ZBX-4333 -trunk. I've done some code refactoring and fixed several bugs connected to trigger dependencies. I think the code will be a little simpler now.
RESOLVED.

<pavels> Indeed, we need to create the triggers first, and only then can we validate the dependencies and rollback, if something is not right. To fix this, we would need to completely rewrite the code.

Oleksiy Zagorskyi
added a comment - 2012 Mar 08 01:34 - edited Pavels, just interesting, why here is so many work for trunk although we have resolved and closed ZBX-4056 ?
Additional improvements?
<pavels> More like additional bug fixes. Even after ZBX-4056 a lot of problems with trigger dependencies remained.
<zalex> Thanks. CLOSED