Conversation

edited

Allow proxy_ssl to be checked for pending data even when connssl does
not yet have an SSL handle.

This change is for posterity. Currently there doesn't seem to be a code
path that will cause a pending data check when proxyssl could have
pending data and the connssl handle doesn't yet exist *.

Recall that an https proxy connection starts out in connssl but if the
destination is also https then the proxy SSL backend data is moved from
connssl to proxyssl, which means connssl handle is temporarily empty
until an SSL handle for the destination can be created.

- Allow proxy_ssl to be checked for pending data even when connssl does
not yet have an SSL handle.
This change is for posterity. Currently there doesn't seem to be a code
path that will cause a pending data check when proxyssl could have
pending data and the connssl handle doesn't yet exist *.
* Recall that an https proxy connection starts out in connssl but if the
destination is also https then the proxy SSL backend data is moved from
connssl to proxyssl, which means connssl handle is temporarily empty
until an SSL handle for the destination can be created.
Ref: f4a6238#commitcomment-24396542
Closes #xxxx

lockbot
locked as resolved and limited conversation to collaborators
May 14, 2018

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.