pidgin-devel

Hello,
Enclosed patch adds support for sending and receiving images in IMs in
SILC protocol. Images can be sent with or without text message and
multiple images can be sent at the same time. Note that, after applying
this patch the SILC Toolkit 1.0.1 must be installed in the system in order
to be able to compile.
The patch also adds support for the infrastructure to add later other
multimedia features in SILC, such as voice and video chats.
Note also, that the previous patch I sent (cipher selection) is included
in this patch.
Pekka
________________________________________________________________________
Pekka Riikonen priikone at silcnet.org
Secure Internet Live Conferencing (SILC) http://silcnet.org/

On Mon, 21 Nov 2005 13:46:36 +0100 (CET), Pekka Riikonen wrote
> Hello,
>
> Enclosed patch adds support for sending and receiving images in IMs
> in SILC protocol. Images can be sent with or without text message
> and multiple images can be sent at the same time. Note that, after
> applying this patch the SILC Toolkit 1.0.1 must be installed in the
> system in order to be able to compile.
>
> The patch also adds support for the infrastructure to add later
> other multimedia features in SILC, such as voice and video chats.
>
> Note also, that the previous patch I sent (cipher selection) is
> included in this patch.
Can you please submit this to the sourceforge patch tracker?
http://sourceforge.net/tracker/?func=add&group_id=235&atid=300235
Thanks!
-Mark

Mark Doliner spake unto us the following wisdom:
> On Mon, 21 Nov 2005 13:46:36 +0100 (CET), Pekka Riikonen wrote
> > Enclosed patch adds support for sending and receiving images in IMs=20
> > in SILC protocol. Images can be sent with or without text message=20
> > and multiple images can be sent at the same time. Note that, after=20
> > applying this patch the SILC Toolkit 1.0.1 must be installed in the=20
> > system in order to be able to compile.
>=20
> Can you please submit this to the sourceforge patch tracker?
No need to do that, this patch is already being processed (by Stu this
time, not me). Anything that keeps me from having to mess with source-
forge's trackers is bonus, anyway, so I vote for continuing mailing list
submissions.
Ethan
--=20
The laws that forbid the carrying of arms are laws [that have no remedy
for evils]. They disarm only those who are neither inclined nor
determined to commit crimes.
-- Cesare Beccaria, "On Crimes and Punishments", 1764

On Mon, 2005-11-21 at 13:46 +0100, Pekka Riikonen wrote:
> Enclosed patch adds support for sending and receiving images in IMs in
> SILC protocol. Images can be sent with or without text message and
> multiple images can be sent at the same time. Note that, after applying
> this patch the SILC Toolkit 1.0.1 must be installed in the system in order
> to be able to compile.
I was going to apply this after reworking it and our configure.ac to
continue to work with older versions of the SILC Toolkit (without image
support), but I'm concerned about the following:
1) As you mentioned earlier on this list, there is no way to tell if the
img tag was actually text entered by the user or a genuine image tag.
One possible resolution to this would be for the Gaim core to always
send html to the prpls, even those that do not set the
GAIM_CONNECTION_HTML flag, then the "text only" prpls could scan for img
tags before gaim_unescape_html'ing the message themselves. I'm not sure
if this is what we want to do though. What do others think?
2) There is no feedback if the recipient of a message with images is
unable to display the message, and not even the text gets through.
3) A message consisting of <text1><img><text2> is displayed on the
receiving side as 3 separate received messages, would it be possible to
re-combine them?
Anyway, my updated patch that works with SILC Toolkit < 1.0.1 (without
images) and >= 1.0.1 (with images) is attached.
Regards,
Stu.

On Thu, 24 Nov 2005, Stu Tomlinson wrote:
: I was going to apply this after reworking it and our configure.ac to
: continue to work with older versions of the SILC Toolkit (without image
: support), but I'm concerned about the following:
:
: 2) There is no feedback if the recipient of a message with images is
: unable to display the message, and not even the text gets through.
:
Not all SILC clients support MIME messages. It would be implementation
issue to send for example NOTICE | AUTOREPLY | NOREPLY flagged message
back with an error message (lib/silccore/silcmessage.h has the flags).
: 3) A message consisting of <text1><img><text2> is displayed on the
: receiving side as 3 separate received messages, would it be possible to
: re-combine them?
:
For me personally this is not an issue. In the recursive multipart
decoding the end buffer (the final message to be sent to Gaim) could be
delivered with the recursion and displayed once all multiparts has been
processed, to get what you want.
Pekka
________________________________________________________________________
Pekka Riikonen priikone at silcnet.org
Secure Internet Live Conferencing (SILC) http://silcnet.org/

: 1) As you mentioned earlier on this list, there is no way to tell if the
: img tag was actually text entered by the user or a genuine image tag.
:
: One possible resolution to this would be for the Gaim core to always
: send html to the prpls, even those that do not set the
: GAIM_CONNECTION_HTML flag, then the "text only" prpls could scan for img
: tags before gaim_unescape_html'ing the message themselves. I'm not sure
: if this is what we want to do though. What do others think?
:
Some generic solution would be nice, but in case of SILC the
GAIM_CONNECTION_HTML flag could perhaps be set to get rid of the problem.
However, I still would like to see the IM_IMAGE flag delivered correctly
to the prpl, so that there would not have to be message parsing if we know
there isn't images.
Pekka
________________________________________________________________________
Pekka Riikonen priikone at silcnet.org
Secure Internet Live Conferencing (SILC) http://silcnet.org/

On Thu, 2005-11-24 at 15:36 +0100, Pekka Riikonen wrote:
> : 1) As you mentioned earlier on this list, there is no way to tell if the
> : img tag was actually text entered by the user or a genuine image tag.
> :
> : One possible resolution to this would be for the Gaim core to always
> : send html to the prpls, even those that do not set the
> : GAIM_CONNECTION_HTML flag, then the "text only" prpls could scan for img
> : tags before gaim_unescape_html'ing the message themselves. I'm not sure
> : if this is what we want to do though. What do others think?
> :
> Some generic solution would be nice, but in case of SILC the
> GAIM_CONNECTION_HTML flag could perhaps be set to get rid of the problem.
I don't think setting GAIM_CONNECTION_HTML for SILC would be a good
idea, as the UI would then give the impression that message formatting
was supported.
I went ahead and made the change I suggested above, to always send html
from the core, and let prpls do what they want with it.
> However, I still would like to see the IM_IMAGE flag delivered correctly
> to the prpl, so that there would not have to be message parsing if we know
> there isn't images.
I did this too, along with removing GaimConvImFlags and
GaimConvChatFlags (we use GaimMessageFlags instead now). We're a bit
closer to image support in chats too.
I've now applied this patch, with my modifications to work with older
SILC Toolkits.
Thanks for the patch!
Regards,
Stu.