On 03/03/2011 01:01 AM, Keith Hui wrote:
>> Option C with GPLv2+ licensing.
>> A few quick things:
>> SUPERIO_FINTEK_F81865F_HAS_EARLY_SERIAL seems long-winded for a name.
>> I prefer to define CONFIG_SUPERIO_HAS_EARLY_SERIAL (or even just
> CONFIG_HAS_EARLY_SERIAL) within the superio Kconfig and not in
> mainboard Kconfig. This I think would be a per-superio setting. While
> we're at it, have we seen a board with 2+ superios?
>The idea was that, if a board has more than one superio, we would have
to select which of those carries the early serial. Let's say board
PETER40S has two superios: an KEITH875H and an ALEX666G. Both have early
serial capability, but you have to specify which of those will be used
for serial purpose.
So you have:
select SUPERIO_KEITH875H
select SUPERIO_ALEX666G
select SUPERIO_ALEX666G_HAS_EARLY_SERIAL
> Having said that though, isn't early serial support sort of mandatory anyway?
>The point is not to specify if a superio has early serial. It is to
specify which of the different superio's early serial will get compiled
in, and used.
Alex