Description

Very Bare-Bones: Invoicing emails have everything they need to, but they lack a certain je ne sais quoi.

Merchants CC'd: Currently, merchant accounts get CC'd on invoice emails. This makes some degree of sense, practically, and is consistent with other Phabricator applications, but feels a bit weird. Dropping them from non-approval emails or sending them a separate "merchant" version of the email might make more sense.

Subject: They generate with a subject like [Phortune] [New Invoice] Order X: Phabricator Instance which is, again, technically OK but not really great.

From: They should come "From" the merchant as an address display label. The currently come "From" the default address.

We can make these look different from other transactional email (but still general to Phortune) with a moderate amount of time, work, and ongoing maintenance cost.

We can make these look unique to Phacility at substantial cost.

Personally, I think this is worth less than an hour of time to sand some of the edges off. I'd probably address these things if they didn't end up being too hard:

Fix the "From" name to the merchant name, which will give us a cheap, general way for them to say "Phacility".

Drop "phortune" or use the merchant name.

Only CC the merchant on approval-required emails.

Do a quick pass on smoothing out the copy a little bit.

I think this is pretty near the bottom of the list of importance, but the mails are so rough around the edges right now that they could be kind of confusing (specifically, it may not be clear enough that they're coming from Phacility).

An instance needs their own address (and some other information) on the invoice for tax purposes:

Company Name
Some Road
Whatever Whatever
Secret British ID Code: XYZ

Presumably we can add this as account-level configuration and then just print whatever they write on invoices. This feels vaguely flimsy (in the vein of "impressum") but I could imagine other use cases for it (e.g., just put some note to your Accounts Payable department there), particularly in conjunction with T8389.

Add some kind of text field to PhortuneAccount, probably billingAddress I guess. We could try to call this freeformNoteToSelfWhichShowsUpOnInvoices or something to hint that you could put a note to your AP department here or a tax number or whatever, but users will probably figure that out 90% of the time and we can say "oh, just add it to the bottom of your billing address" the other 10% easily enough.

In Phortune account detail > Edit Account, add a field for it under "Name" and "Members" (this isn't EditEngine yet, unfortunately).

Figure out some way to put it on the cart page I guess.

Getting it into the email is desirable but probably nontrivial.

You could also do the same for PhortuneMerchant to let us put our address opposite their address. Also no EditEngine yet but I don't think it's a big deal to do these old-school-style since the total amount of wasted effort is fairly small (~20 lines in each Controller).

Followup from the same instance as above (T7607#198199) with the same request (put their contact details on the invoice). All of the prior changes put our contact details on the invoice but printable invoices are currently hard-coded to always be billed "To" the real name of the paying user.