From dev-return-130121-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org Mon Apr 1 18:47:19 2013
Return-Path:
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
by minotaur.apache.org (Postfix) with SMTP id 0CF03F702
for ; Mon, 1 Apr 2013 18:47:19 +0000 (UTC)
Received: (qmail 53927 invoked by uid 500); 1 Apr 2013 18:47:17 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 53857 invoked by uid 500); 1 Apr 2013 18:47:17 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help:
List-Unsubscribe:
List-Post:
List-Id:
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 53785 invoked by uid 99); 1 Apr 2013 18:47:17 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Apr 2013 18:47:17 +0000
Date: Mon, 1 Apr 2013 18:47:17 +0000 (UTC)
From: "Shawn Heisey (JIRA)"
To: dev@lucene.apache.org
Message-ID:
In-Reply-To:
References:
Subject: [jira] [Commented] (LUCENE-4742) Rename SpatialPrefixTree's "Node"
back to "Cell"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
[ https://issues.apache.org/jira/browse/LUCENE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619038#comment-13619038 ]
Shawn Heisey commented on LUCENE-4742:
--------------------------------------
bq. I'm not sure what is amiss in your local environment.
Sorry for the false alarm. I'm not sure what went wrong either. I did completely redo the checkout and 'ant eclipse' followed by a clean/refresh, but it didn't recover properly until I completely removed the project from eclipse, deleted the checkout, and did it all again.
Unfortunately I had deleted everything before I thought to check the filesystem for the .java file rather than the eclipse project view, so I have no way of knowing whether it was the checkout or eclipse that was screwed up.
> Rename SpatialPrefixTree's "Node" back to "Cell"
> ------------------------------------------------
>
> Key: LUCENE-4742
> URL: https://issues.apache.org/jira/browse/LUCENE-4742
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Trivial
> Fix For: 4.3
>
> Attachments: LUCENE-4742_Rename_spatial_Node_back_to_Cell.patch
>
>
> SpatialPrefixTree makes "Node"s which are basically a rectangular spatial region that is more colloquially referred to as a "Cell". It was named "Cell" in the first place and for whatever reason, Ryan and/or Chris renamed it as part of extracting it to a top level class from an inner class. Most comments and variable names still use the "cell" terminology. I'm working on an algorithm that keeps track of a tree of "nodes" and it has gotten confusing which kind of node I'm referring to, as each Node has one cell.
> In maybe a week or so if there isn't discussion to the contrary, I'm going to commit a rename it back to "Cell". And... while we're on this naming subject, perhaps "SpatialPrefixTree" could be named "SpatialGrid" ? FWIW the variables referring to it are always "grid".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org