Comment on attachment 229051[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=229051&action=review
It looks there is no critical issue on EFL side. However, this patch modify cario graphics back-end. I think folks of cairo graphics need to take a look this patch.
> Source/WebCore/ChangeLog:11
> + This patch adds a new API for pixel dump AcceleratedCompositingContext::extractImageData()
This description is a little unclear for me. Although I'm not sure whether I understand this description, I modify this description a little.
"This patch adds new member functions to AcceleratedCompositingContext for supporting pixel dump. One of new functions is "AcceleratedCompositingContext::extractImageData()", which replaces deprecated function calls. Besides the extractImageData() is invoked by ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview."

(In reply to comment #10)
> (From update of attachment 229051[details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229051&action=review
>
> It looks there is no critical issue on EFL side. However, this patch modify cario graphics back-end. I think folks of cairo graphics need to take a look this patch.
This patch doesn't modify cairo backend side, just adds a util function, flipVertically(cairo_surface_t*).
> > Source/WebCore/ChangeLog:11
> > + This patch adds a new API for pixel dump AcceleratedCompositingContext::extractImageData()
>
> This description is a little unclear for me. Although I'm not sure whether I understand this description, I modify this description a little.
>
> "This patch adds new member functions to AcceleratedCompositingContext for supporting pixel dump. One of new functions is "AcceleratedCompositingContext::extractImageData()", which replaces deprecated function calls. Besides the extractImageData() is invoked by ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview."
Thanks!

Comment on attachment 229254[details]
rebase patch
View in context: https://bugs.webkit.org/attachment.cgi?id=229254&action=review
Looks okay with a few small changes.
>> Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:262
>> +void flipVertically(cairo_surface_t* surface)
>
> I think Martin can review this function.
Probably should be called flipImageSurfaceVertically.
> Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:265
> + ASSERT(!size.isEmpty());
You probably want to ASSERT the that this is also an image surface.