Comments

[LevelDBScopes] Improving testing & factory classes
There isn't a great way to 'shut down' a leveldb instance if it is being
used on multiple threads, and there isn't a great way to supply a mock
database.
This patch adds both of those things.
Bug: 862456
Change-Id: I84ed0d1ef2ca77a2058945bebc6e03dadcb9fd92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521436
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642017}

Comments

SocketPools: group_name to GroupId conversion part 1.
Introduce ClientSocketPool::GroupId class, to replace string
group_names.
This CL does not make ClientSocketPool take GroupIds as an argument,
instead it uses an implicit GroupId to string conversion, and updates
some tests and ClientSocketPoolManager to pass in GroupIds to APIs that
take in string group_names.
Updating consumers first because conversion from GroupId to std::string
is simpler than the other way around. The implicit conversion operator
will be removed in a followup CL in which the SocketPools themselves are
updated to take GroupIds, after all consumers have been converted.
Bug: 533571
Change-Id: I013a23ae9211ac3d038f41abd13d0de42a229611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524977
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642012}

Comments

Background tracing: Refactored active scenario into separate class
Cleaned up the BackgroundTracingManager and prepared it for Perfetto
support by moving all of the state related to an ongoing tracing
scenario into a separate class.
Also removed an unused feature to enable/disable Blink features in
a background tracing config.
TBR=nasko@chromium.org
Change-Id: I1f218b1eb4dd93f89d4be4f2651bbf921259b0e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525471
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642007}