Hey, thanks for picking this up, it was on my list of things to look at...
Some preliminary comments on the spec file:
This looks wrong, only devel packages should require devel packages:
Requires: gtk2-devel
These will almost certainly be pulled in automatically be library dependencies,
so no need to list them explicitly:
Requires: glib2
Requires: libxml2
Requires: GConf2
The devel package must require pkgconfig, since it contains a pc file.
The description is misleading, since the devel package should _not_ contain
static libraries. It should contain the unversioned symlinks (.so) for shared
libraries.
Running autogen.sh should only be necessary when building from a checkout. Even
if this package is based on a git snapshot right now, the tarball should be
produced by 'make dist' and the autogen.sh call should be unnecessary. If it
were necessary for some reason, then you are missing the necessary BuildRequires
for automake, autoconf, etc
missing from the file list:
%dir %{_datadir}/geoclue-providers
%dir %{_includedir}/geoclue

As expected, trying to build your srpm in mock fails with
which: no libtoolize in
(/usr/lib/ccache:/usr/local/sbin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/root/bin:/builddir/bin)
libtoolize not found. Please install it.
due to the missing BuildRequires for the autogen.sh call

No problems. Been looking for some packages to maintain for a while to get
involved :)
geoclue has just done another release so the autogen.sh stuff can disappear, but
there's a missing file from the tar ball as far as I can tell so I'll upload a
new version once I can get it to build.
For the static libraries do I just rm them from the build?

with static libraries, do you mean .la files ? those are actually libtool
archives, and yes, rm is the right treatment for them. Actual static libaries
are .a files, but you are configuring with --disable-static, so those should not
be produced in the first place. I they are, then again rm is the easiest solution.

After adding
BuildRequires: gtk2-devel
BuildRequires: NetworkManager-devel
I was able to build this in mock, so we are getting somewhere. rpmlint has some
complaints:
geoclue.i386: E: zero-length /usr/share/doc/geoclue-0.11.1/ChangeLog
geoclue.i386: E: library-without-ldconfig-postin /usr/lib/libgeoclue.so.0.0.0
geoclue.i386: E: library-without-ldconfig-postun /usr/lib/libgeoclue.so.0.0.0
geoclue.i386: E: zero-length /usr/share/doc/geoclue-0.11.1/NEWS
geoclue.i386: E: description-line-too-long Geoclue is a modular geoinformation
service built on top of the D-Bus messaging system. The goal of the Geoclue
project is to make creating location-aware applications as simple as possible.
geoclue.i386: W: non-standard-group System
geoclue.i386: W: invalid-license LGPL
all of these are easy fixes, thankfully.

Yeah, looks fine now, basically. For rpm groups, I would just pick something like
Development/Libraries, since the demo is about showing how to use the geoclue
libraries.
I'll do a formal review sometime this weekend.

No, not having much luck on that front, also been very busy with other things
too. I'm not 100% on the best way to get sponsorship, although have been looking
at reviews for other packages but haven't posted any updates to them as yet. Any
other pointers for sponsorship?