On Fri, Jun 10, 2011 at 12:46 PM, Sangbeom Kim <sbkim73 at samsung.com> wrote:
> On Thu, Jun 9, 2011 at 4:04 PM, Jassi Brar wrote:
>> NAK.
>> It will break the most common user - SMDK6410, as s3c6410 doesn't have any
>> I2S internal DMA.
>> Please try to test the changes before submitting. I know it's boring,
>> but it's even more important :)
>>>> Thanks
>> I only focused on S5PV210 and S5PV310.
> I didn't consider s3c and s5p series.
> In the next version, I will delete it.
Though if then everything works fine with system and internal DMA,
maybe it is better to assign platform_name string at runtime from some
module parameter, and leaving the default to normal system DMA ?
> But I had found some problem and want to share.
> Like this patch, If different platform driver is used for each channel,
> 1st channel is overwritten by platform driver of 2nd channel.
> Have you ever experienced before like this problem?
IIRC, I successfully tested using system DMA with primary and iDMA
with secondary channel. Only the sec chan would keep playing when
the system went to suspend. Though tt was long time ago and I don't remember
which Samsung kernel version.