>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Dear Peter Korsgaard,
Thomas> On Sun, 06 Oct 2013 20:44:30 +0200, Peter Korsgaard wrote:
Thomas> diff --git a/package/libcap-ng/Config.in b/package/libcap-ng/Config.in
Thomas> index d1663cd..b799dc9 100644
Thomas> --- a/package/libcap-ng/Config.in
Thomas> +++ b/package/libcap-ng/Config.in
Thomas> @@ -1,5 +1,7 @@
Thomas> config BR2_PACKAGE_LIBCAP_NG
Thomas> bool "libcap-ng"
Thomas> + # tls support, needed by libcap-ng, not available on avr32
Thomas> + depends on !BR2_avr32
>> >> Shouldn't it then depend on BR2_GCC_ENABLE_TLS (and the avr32 toolchain >> not select it)?
Thomas> It wouldn't work with external toolchains, which is the reason why I
Thomas> excluded the AVR32 architecture rather than using a BR2_GCC_ENABLE_TLS
Thomas> condition.
Ok, but from your comment I believe it should also depend on
BR2_GCC_ENABLE_TLS (E.G. it would break on other archs if you disable
TLS support)?
If we start having other packages needing TLS, then we should perhaps
provide the option for external toolchains as well, similar to how we do
for the other toolchain settings.

Dear Peter Korsgaard,
On Sun, 06 Oct 2013 23:42:54 +0200, Peter Korsgaard wrote:
> Thomas> It wouldn't work with external toolchains, which is the reason why I> Thomas> excluded the AVR32 architecture rather than using a BR2_GCC_ENABLE_TLS> Thomas> condition.> > Ok, but from your comment I believe it should also depend on> BR2_GCC_ENABLE_TLS (E.G. it would break on other archs if you disable> TLS support)?
If we make the package depend on BR2_GCC_ENABLE_TLS, then it would no
longer be visible for any external toolchain.
> If we start having other packages needing TLS, then we should perhaps> provide the option for external toolchains as well, similar to how we do> for the other toolchain settings.
I'm always a bit reluctant to add more and more toolchain options,
since they are a pain to maintain, and do not necessarily reflect real
use cases. Is it really an useful use-case to support non-TLS
toolchains on architectures where TLS support is available?
Best regards,
Thomas