On 2013/10/23 06:42:08, hanwen-google wrote:
> this is a break out of 14494058. Once the rekeying is handled at a lower
layer,
> we don't have kexResult in client.go/server.go, so we should get it from
> transport.sessionID
Thanks for splitting this out.
This CL needs a better title, how about
"go.crypto/ssh: {Server,Client}Conn, do not pass sessionID to authenticate"
+agl, I'd like you to review this please.

Changed to " in {Server,Client}Conn, read session ID from
transport layer." (I try to avoid saying what we don't do in descriptions.)
On Wed, Oct 23, 2013 at 9:00 AM, <dave@cheney.net> wrote:
> On 2013/10/23 06:42:08, hanwen-google wrote:
>>
>> this is a break out of 14494058. Once the rekeying is handled at a
>
> lower layer,
>>
>> we don't have kexResult in client.go/server.go, so we should get it
>
> from
>>
>> transport.sessionID
>
>
> Thanks for splitting this out.
>
> This CL needs a better title, how about
>
> "go.crypto/ssh: {Server,Client}Conn, do not pass sessionID to
> authenticate"
>
> +agl, I'd like you to review this please.
>
> https://codereview.appspot.com/15870044/
--
Han-Wen Nienhuys
Google Munich
hanwen@google.com