Unfortunately, this is not a 5min fix. I had a look at it and the problem is that the ListItems are not aware of their background color (in this case defined by the Popover). Somehow we need to make it aware that is inside something with an "overlay" color (in the LabelVisual) so that it uses the foregroundText color belonging to the popover.

A quick fix was committed, but the real issue is that the same text color for list items does not work on the background (dark) and popover (white background) at the same time. I think a good solution would be that for dark themes, the popovers should also have a dark background. This is something for design to look at.

Design comment - I don't think we want the popovers to change between light/dark depending on what app is being used - they should be white by default, and the text inside them should be dark by default so that you can read it.

Can you not override the white listitem text colour with dark grey by default when using (white) popovers?

[ tpeeters ]
* Quick fix, completely untested. Might mess up apps with list items
that do not use popovers. Have a look to see if you can use this
code and it doesn't break anything. (LP: #1205094)
* Clean toolbar code by removing deprecated properties and updating
tests.