Linus Walleij wrote at Thursday, December 01, 2011 3:55 AM:> This is a split-off from the earlier patch set which adds generic> pin configuration for the pin controllers that want it. Since> we may have a system with mixed generic and custom pin controllers,> we pass a boolean in the pin controller ops vtable to indicate> if it is generic.

This enum conflates both "parameter" and "value" into a single enum space.The patch introduces to_config_packed() and friends specifically to packboth param and value into a single unsigned long, but then defines the"param" to encompass "value" as well. That seems inconsistent. Instead,shouldn't you have something more like: