If this is your first visit, be sure to
check out the FAQ by clicking the
link above. You may have to register
before you can post: click the register link above to proceed. To start viewing messages,
select the forum that you want to visit from the selection below.

And a bunch of dialogs that I didn't even know we had. "Untinker item", "Wand-Zap Item", "Monster Level" - all of which I just use the CLI for. Ditto for "Rest in Chateau", "Rest in House", and "Sleep in Sofa". Not that I use anything but the Chateau, these days.

"Loot the Hermit" and "Visit the Trapper" are both subsumed by Coinmasters. Why do they still exist?

- Those that open a Frame of the sort that you can put into a tab (most of them)
- Those that open a Frame that displays a response to a KoL request (Council)
- Those that open the Relay Browser with a request (Relay Browser, Read Kmail. Radio KoL)

Which are the frames you can put in tabs? KoLCionstants.FRAME_NAMES lists them:

As noted, Relay Browser and Read Mail and Radio KoL go to the Relay Browser.

Everything else opens a Frame. All of those frames - except Council - can be set up as a tab. Council would make no sense for that, since it visits the Council and tells you what they say right now; there is no interaction, and it does not update.

I suggest:

Every frame that can be in a tab or opened at startup should have an icon to be used on the toolbar, should you choose to place it there.

Relay Browser requests - Relay Browser, Read Mail, Radio KoL (does it still exist? It seems so - but we should use radio-kol.com, rather than a raw IP address) - should have icons and also be in the Menu.

RequestFrames - things that show the current result of a KoL request, like Council Frame - should have icons and also be in the Menu.

CouncilFrame shows a visit to council.php
DescriptionFrame is how we show desc_xxx.php
ProfileFrame shows a user profile from chat, clan manager, ...

RequestSynchFrame is used if you have "showAllRequests" set to true. It lets you watch, round by round, as you automate. I remember wanting that many years ago - and hola did it - but I have long since lost interest. I wouldn't mind simplifying our code and trashing it.

So, for configuring the toolbar:

It could/should work in combination with how you configure tabs.

Provide a palette of icons, each associated with a frame, with a Relay Browser link, or with a request frame (currently only Council)

You can drag a button to your set of Tabs - if it is a standalone Frame
You can drag a button of any sort to the toolbar.
If a button is in the Tabs, it doesn't need to be on the Toolbar (right?)

You can reorder Tabs to suit your fancy.
You can reorder the Toolbar to suit your fancy.

Restart KoLmafia to see your new tabs and toolbar buttons.

Short of a configurable toolbar:

We could move some buttons to the menu: Radio KoL, Read Mail, Council
We could add some default toolbar buttons: Modifier Maximizer, Sweet Synthesis
We could suppress adding a toolbar button if you have the corresponding Frame in a tab, although that might be controversial: you can press a button to switch tabs, currently, and perhaps people depend on that. We could make that UI decision configurable.

I use the button for free rests on the Daily Deeds for "Rest in Chateau", "Rest in House", and "Sleep in Sofa". Not that I use anything but the Chateau, these days.

"Loot the Hermit" and "Visit the Trapper" are both subsumed by Coinmasters. Why do they still exist?

Originally Posted by Veracity

I have no idea! It's clear the UI needs a small overhaul.

"Mini-Browser" -> "RequestFrame"

Is this still useful? KoL itself is so dependent on Javascript that this is a very deficient version of the Browser experience

Originally Posted by Veracity

I say it should be killed. There was a time when I found it useful. That time is long gone.

"Relay Server" -> "LocalRelayServer"

This is not really a "Frame". It is a directive to start the Relay Browser on startup. Does it work?

It works very well. It doesn't actually start the relay browser, but it does start the relay server so that my browser can open the relay. Without this I need to use the button on the toolbar first. For me it removes some awkwardness from the process.

I suggest:(common-sense obvious stuff follows)

So, for configuring the toolbar:(more good stuff)

Definitely! You're actually suggesting a bit more than I hoped.

Short of a configurable toolbar:

We could move some buttons to the menu: Radio KoL, Read Mail, Council
We could add some default toolbar buttons: Modifier Maximizer, Sweet Synthesis
We could suppress adding a toolbar button if you have the corresponding Frame in a tab, although that might be controversial: you can press a button to switch tabs, currently, and perhaps people depend on that. We could make that UI decision configurable.

That is the best minimalistic approach. I'd recommend changing the tooboar buttons you suggest first.

I'm not sure about toolbar button suppression myself, but that is something to discuss only if toolbar customization isn't created.

I do remember times in the past when I had enough tabs open on start that they exceeded the allowed width. The options to get to unshown tabs were to repeatedly click the tiny scroll button that is provided or more simply to use the menus (or a toolbar button) to quickly change to an unshown tab. I've since constrained my tabs to only those that will appear on the screen without scrolling or clicking, but I could see the case for allowing a button push or menu selection to switch tabs in that situation. Mafia has so many great features, they can amount to a lot of tabs.

I guess another option would be to make the actual "tabs" smaller so they would all fit if many were used.

One thing I use the mini-browser for is that it easily provides the exact link you need for any particular use of visit_url(). It even already has the password hash replaced with "pwd" for you. I doubt that's a reason to keep it around though. Sometimes the actual link needed is obscured from the relay browser since the address never changes from "game.php" and things like choice buttons aren't even links that you can use "copy address" with.

Yeah, I've heard people say they use it for that. I just get the URLs out of DEBUG logs, which is pretty cumbersome, but doesn't require you to actually click on the link.

A smaller and more succinct log would be "debug trace on" which makes a TRACE log, rather than a full DEBUG log; just the request & response URLs, without the full response text and header fields and such.