-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

Hadoop QA
added a comment - 23/Mar/12 15:55 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519646/MAPREDUCE-3540.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2090//console
This message is automatically generated.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

Hadoop QA
added a comment - 23/Mar/12 17:35 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519665/MAPREDUCE-3540.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2092//console
This message is automatically generated.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 23/Mar/12 18:59 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519673/MAPREDUCE-3540.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2093//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2093//console
This message is automatically generated.

Mostafa Elhemali
added a comment - 25/Mar/12 22:55 There is a version there but it outputs the CR/LF. Note that this is a copy-paste of the same workaround in hadoop-common-project/hadoop-common/dev-support/saveVersion.sh

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 01/Oct/12 21:44 -1 overall . Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12547267/MAPREDUCE-3540-121001.patch
against trunk revision .
+1 @author . The patch does not contain any @author tags.
-1 tests included . The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac . The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc . The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse . The patch built with eclipse:eclipse.
+1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit . The applied patch does not increase the total number of release audit warnings.
+1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
+1 contrib tests . The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2898//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2898//console
This message is automatically generated.

Thanks Trevor for updating the patch. I still needed to trim newlines from whoami in my environment for build to work so including an updated patch with that fix intact (and unnecessary whitespace changes removed).

Mostafa Elhemali
added a comment - 23/Nov/12 19:30 Thanks Trevor for updating the patch. I still needed to trim newlines from whoami in my environment for build to work so including an updated patch with that fix intact (and unnecessary whitespace changes removed).

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 23/Nov/12 19:44 -1 overall . Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554748/MAPREDUCE-3540.Nov12.patch
against trunk revision .
+1 @author . The patch does not contain any @author tags.
-1 tests included . The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac . The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc . The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse . The patch built with eclipse:eclipse.
+1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit . The applied patch does not increase the total number of release audit warnings.
+1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
+1 contrib tests . The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3063//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3063//console
This message is automatically generated.

Trevor Robinson
added a comment - 23/Nov/12 22:44 Yes, if you use the Windows whoami , it has a newline at the end. A workaround is to put the Cygwin bin directory before Windows\System32 in your PATH , but it's helpful to include that in this fix.

Hi Anoop, you no longer need to run from Cygwin shell to be able to compile and run Hadoop on Windows (this is post HADOOP-8562 merge). Check BUILDING.txt for instructions on how to compile natively on Windows.

Ivan Mitic
added a comment - 28/May/13 18:08 Hi Anoop, you no longer need to run from Cygwin shell to be able to compile and run Hadoop on Windows (this is post HADOOP-8562 merge). Check BUILDING.txt for instructions on how to compile natively on Windows.