On Thu, Oct 22, 2009 at 04:43:38AM -0700, Leonidas . wrote:> > Yep.> > For example we do that in the function graph tracer. Because we store return> > addresses of functions in the "current" task structure. Even if the task> > is interrupted, it still makes sense to use current because we want> > to know the flow of execution as a linear thing per cpu, the interrupt> > is part of that flow> >> > I hope that helps.> >> > Can you give pointers to the source code of this project?

Yep, it's in kernel/trace/trace_functions_graph.c (with a littlepart in arch/*/kernel/ftrace.c and arch/*/kernel/entry*.S)and also parts in kernel/trace/ftrace.c

We do that from the former file in ftrace_push_return_trace()and ftrace_pop_return_trace()

We deref current from whatever context, this part of the code doesn't careabout interrupt or process context, and this code can be called fromevery contexts, since it is tracing 99% of the kernel function calls.

We do care about the context in which the trace has been taken while displayingthese traces to the user, later, just to inform the user, but this is already post-processing at this stage, even though it's done from the kernel.

Anyway, the point is that it's safe to deref current from an irq handler.

But whether it makes sense to do that. It depends on what you want to do.