Can you undo the whitespace change from geliboot.c? Phabricator doesn't seem to have a good option to hide white space changes and it detracts from reviewing the (security sensitive) functional change.

Can you undo the whitespace change from geliboot.c? Phabricator doesn't seem to have a good option to hide white space changes and it detracts from reviewing the (security sensitive) functional change.

Bad Pharbricator ;/
For the purpose of review I revert the style changes in the geli_attach function.
Insted of changing whole style I left extra brackets where SLIST_FOREACH_SAFE was.
I hope this make it more readable.

I know the review passed correctly but I had some issue with this patch.
I think by default we should present the most secure version of the system.
So by default I would disable the stars during the boot and I changed the flag to allow to show stars.

I know that this functionality is already in the release but I feel much bather doing it that way.