I've added my initial take on the "unsaved changes indicator" to Soda Theme.

When a file is edited, the close button dynamically changes to a circle icon to show unsaved changes (or for users with close buttons disabled, the circle will simply appear).

One thing that arose from this implementation is that it makes the existing text based label dot redundant, and I'd really like to disable it via the theme.

Is there option or setting for themes to be able to disable the default text based dot that renders at the end of a tab labels name?

It would be nice to be able to turn this off to avoid the double dot effect (see below), and it would have the added benefit (for themes that don't need it), of not causing tab widths to be pushed out due to the text dot rendering.

Here's some details on that request, and a look at the unsaved changes indicator of Soda Light:

I do like the look of this approach but it seems to suffer from the same issue as the original dot method. When I have too many tabs open, I cannot see your dirty indicator. At least with the orange glow, I could always see it. Though I do like the look, functionality is always very important to me.

Is there a way to force the close icons to always be shown that I am just not aware of? If not, it would be nice if you could implement a dirty indicator that doesn't disappear when a lot of tabs are open.

facelessuser wrote:When I have too many tabs open, I cannot see your dirty indicator.

Yeah, that is something that would be nice to find a way to fix.

There seems to be some logic in place (that may be configurable by a theme, or perhaps is hard coded in the app), that auto-hides the close button at a calculated minimum width. If anyone knows how to adjust this, let me know and I'll try some adjustments to keep it there at much smaller sizes.

At the moment on a 1280 wide resolution with an average sized sidebar, it'll fit about 21 tabs with a visible indicator, regardless of the length of the tab label file names. With wider resolutions, or no sidebar showing that number increases, but yeah, I end up with lots of files open too and would like to resolve that.

Jon, are there any parameters that can set what the trigger width is for auto-hiding the close button?

fkirkholt wrote:Changing the close button for dirty files should also be done for Open files in the side bar

Completely agree. I would also like to see this.

At the moment, based on my interpretation of how Jon has implemented the "dirty" state trigger, it appears to be a property of the tab_control, rather than something more abstract, like the file itself.

When determining whether or not to trigger the dirty file icon in place of the close button, the theme does more or less the following check: "For this close button, if the parent tab element's dirty attribute is true, display the dirty file icon"