Thanks for the patch!On 08/08/18 at 04:03pm, Mike Galbraith wrote:> When booting with efi=noruntime, we call efi_runtime_map_copy() while> loading the kdump kernel, and trip over a NULL efi.memmap.map. Avoid> that and a useless allocation when the only mapping we can use (1:1)> is not available.

At first glance, efi_get_runtime_map_size should return 0 in casenoruntime.

Also since we are here, would you mind to restructure the bzImage64_loadfunction, and try to move all efi related code to setup_efi_state()?

Currently bzImage64_load prepares the efi_map_offset, efi_map_sz, and efi_setup_data_offset and then pass it to setup_boot_parameters andsetup_efi_state. It should be better to move those efi_* variables tosetup_efi_state().