Hi,
How about it just sorts it all of the time given that the order that svn returns the files really
does not have any meaning.
Thanks
Jason
--- David Sitsky <sits@...> wrote:
> Hi Vlad,
>
> > I'm creating topics directly from Subversion. One problem I've noticed
> > immediately
> > is that file list in a topic is not sorted by filename. Instead, files
> > are listed in some
> > semi-sorted order defined by Subversion. I couldn't find any
> > configuration options
> > that would trigger file sorting. Did I miss something?
>
> The order the files are presented is the same as that in the text
> uploaded into Codestriker, or the order obtained from the SCM, in your
> case, Subversion. So no, you didn't miss anything.
>
> > Patching the code to sort by filename was rather trivial: in
> > lib\Codestriker\FileParser\Parser.pm,
> > insert just before the first return:
> >
> > # Sort the diff chunks by filename, then old linenumber
> > @diffs = sort { $a->{filename} cmp $b->{filename} ||
> > $a->{old_linenumber} <=> $b->{old_linenumber} } @diffs;
> >
> > Would it make sense to make this a configurable feature?
>
> I can imagine this could be useful for large reviews. Rather than
> making this a configurable feature (codestriker.conf is also quite large
> and complex), it might be useful to have a link instead on the view
> topic page above the list of files, for example:
>
> Download topic text | ... | Tab width ... | Sort by filename
>
> Clicking on the sort by filename link will set a CGI parameter, which
> will then execute code similar to what you have, but this would be in
> ViewTopic.pm over the list of delta objects. That way, a reviewer can
> choose at runtime which way they'd prefer to see the list of files
> presented.
>
> What do you think?
>
> Cheers,
> David
>
>
>
> -------------------------------------------------------
> All the advantages of Linux Managed Hosting--Without the Cost and Risk!
> Fully trained technicians. The highest number of Red Hat certifications in
> the hosting industry. Fanatical Support. Click to learn more
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com

Hi Vlad,
> I'm creating topics directly from Subversion. One problem I've noticed
> immediately
> is that file list in a topic is not sorted by filename. Instead, files
> are listed in some
> semi-sorted order defined by Subversion. I couldn't find any
> configuration options
> that would trigger file sorting. Did I miss something?
The order the files are presented is the same as that in the text
uploaded into Codestriker, or the order obtained from the SCM, in your
case, Subversion. So no, you didn't miss anything.
> Patching the code to sort by filename was rather trivial: in
> lib\Codestriker\FileParser\Parser.pm,
> insert just before the first return:
>
> # Sort the diff chunks by filename, then old linenumber
> @diffs = sort { $a->{filename} cmp $b->{filename} ||
> $a->{old_linenumber} <=> $b->{old_linenumber} } @diffs;
>
> Would it make sense to make this a configurable feature?
I can imagine this could be useful for large reviews. Rather than
making this a configurable feature (codestriker.conf is also quite large
and complex), it might be useful to have a link instead on the view
topic page above the list of files, for example:
Download topic text | ... | Tab width ... | Sort by filename
Clicking on the sort by filename link will set a CGI parameter, which
will then execute code similar to what you have, but this would be in
ViewTopic.pm over the list of delta objects. That way, a reviewer can
choose at runtime which way they'd prefer to see the list of files
presented.
What do you think?
Cheers,
David

Just installed Codestriker 1.9.1 (FreeBSD 6.1, Apache 2.2, MySQL 4.1.14,
Subversion 1.1, worked right out the box) - great tool!
=20
I'm creating topics directly from Subversion. One problem I've noticed
immediately
is that file list in a topic is not sorted by filename. Instead, files
are listed in some
semi-sorted order defined by Subversion. I couldn't find any
configuration options
that would trigger file sorting. Did I miss something?
Patching the code to sort by filename was rather trivial: in
lib\Codestriker\FileParser\Parser.pm,
insert just before the first return:
# Sort the diff chunks by filename, then old linenumber
@diffs =3D sort { $a->{filename} cmp $b->{filename} ||
$a->{old_linenumber} <=3D> $b->{old_linenumber} } @diffs;
=20
Would it make sense to make this a configurable feature?
-- Vlad

Community

Help

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

I agree to receive quotes, newsletters and other information from sourceforge.net and its partners regarding IT services and products. I understand that I can withdraw my consent at any time. Please refer to our Privacy Policy or Contact Us for more details