Clojure JIRAhttp://dev.clojure.org/jira
This file is an XML representation of an issueen-us4.464925-07-2011[CLJS-696] remove arguments usage from defrecord constructorhttp://dev.clojure.org/jira/browse/CLJS-696
ClojureScript<p>There is no need for the arguments usage in the defrecord constructor and it's a perf hit for construction. We should always construct defrecords by passing in the extra three arguments: __extmap, __meta, and hash automatically.</p>CLJS-696remove arguments usage from defrecord constructorDefectMajorClosedCompletedDavid NolenDavid NolenSat, 23 Nov 2013 09:39:22 -0600Tue, 16 Dec 2014 12:20:40 -0600Tue, 16 Dec 2014 12:20:37 -060001<p>The constructor now has __extmap, __meta, and __hash in all the places it's constructor is called, the positional factory, map factory, and direct constructor invocation. This is the first time going deep into the ClojureScript compiler so there may be some clean up to do or other places a records constructor is called that I didn't take care of.</p><p>Excellent work! Thanks! <a href="https://github.com/clojure/clojurescript/commit/491dd1bb6ba446407298d6fb93dd6cbd578d3b76">https://github.com/clojure/clojurescript/commit/491dd1bb6ba446407298d6fb93dd6cbd578d3b76</a></p>Global RankPatchCode