Comments

[cc] Pausing Keyframes now correctly handles delay and multiple pauses
Existing pause time application in cc::KeyframeModel is incorrect.
To convert the client pause time to monotonic time, we used to add the
|time_offset_| (1) but not add |total_pause_duration_| (2). The new logic now
excludes (1) and adds (2). This ensures pause time and monotonic time
have the same base clock.
The original conversion was incorrect because:
a. Pause time should have the same base clock as monotonic time since we compute
total_paused_duration_ as difference between the two.
b. Blink provides its animation's current time as pause offset which maps to
the concept of local time in cc. So to convert it to monotonic time we don't
need to include time_offset_.
Without this correction animations with start-delay or multiple pause/unpause
cycles would lead to incorrect pause time calculation. I suspect these issues
flew under the radar mainly because pausing is only ever used for simple test
cases not involving either of these conditions.
Bug: 840364
TEST: cc/animation/keyframe_model_unittest.cc
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id52ca7a3f3d63899864b7153470c7ef64c582d29
Reviewed-on: https://chromium-review.googlesource.com/c/1045126
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619437}

Changed files

cc/animation/keyframe_model.cc

cc/animation/keyframe_model_unittest.cc

Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource

Comments

Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource
This CL is strictly a refactor that switches the Ads PLMO to count frame
data using ResourceDataUseUpdate instead of OnLoadedResource. This will
allow us to include incomplete resources and header bytes in future
per-frame metrics. This will not change behavior of existing histograms
at all.
Bug: 878393
Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251
Reviewed-on: https://chromium-review.googlesource.com/c/1372428
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619436}

Comments

Android: Replace desugar with d8 and r8 for debug
For release builds, desugar.jar still runs first, before d8 or r8, so
nothing is changing for them as by the time d8 or r8 runs, the code has
already been desugared.
When r8 is enabled, it can desugar all targets that enable proguard, and
d8 can desugar all targets that do not enable proguard.
This can only be turned on once r8 replaces proguard since proguard does
not understand java 8 code that has not been desugared already.
Bug: 906803, 913679, 916733
Change-Id: I3fcc5a20b38e7fdc78cdeed1533583675d58346b
Reviewed-on: https://chromium-review.googlesource.com/c/1384945
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619434}