Hello all
Attached is the reworked patch.
I left the _names as is, but if you insist, I'll change them.
Thanks,
Boris
Sureshkumar T wrote:
>>I'll try to keep the code as close as possible to the guidelines.
>>>>>>Thanks.
>>>>>DbParameterBase.Parent : used by DbParameterCollectionBase to track
>>collection ownership on parameters (for example it should be impossible
>>to add the same parameter to two different collections simultaneously).
>>I choose to implement this through internal property rather that
>>internal variable.
>>>>>>Ok.
>>>>>Private variables naming : since code guide lines do no define this
>>well, I did the changes for the following reasons :
>>_paramValue -> _value and _name -> _parameterName : keep private member
>>name close to property name, so the code will be more readable.
>>>>>>Ok, Understandable. But, name for a parameter is always parameter's
>name. anyway, if you feel it is necessary, change them.
>>>>>adding _ to parameter names : to enable easy recognize of an errors like :
>>>>int myProperty;
>>>>public int MyProperty
>>{
>> get { return MyProperty; }
>>}
>>>>>>here, anyway, we use CamelCase for properties and first-letter-small for
>private members. we could have got the error by seeing M in return
>statements.
>>Please feel free to post the reworked patch.
>>Thanks,
>suresh.
>>
--
Boris Kirzner
Mainsoft Corporation
http://www.mainsoft.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: System.Data.Common.diff
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050526/62b00e77/attachment.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: System.Data.ProviderBase.diff
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050526/62b00e77/attachment-0001.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: System.Data.diff
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050526/62b00e77/attachment-0002.pl