> Here is my second attempt at the serial driver patch for the
> PMC-Sierra MSP71xx device.

> There are three different fixes:
> 1. Fix for THRE errata
> - I verified the UART_BUG_TXEN fix does not help with this erratum.
> - I left our current fix in until I get our platform booting on
> 2.6.20-rc4 to try the mm tree "8250-uart-backup-timer.patch".
> Feel free to ignore for now.

> 2. Fix for Busy Detect on LCR write
> - Moved to new UPIO_DWAPB iotype. Because the new type is a memory
> mapped device and there are several tests for UPIO_MEM, this involved
> updating serial_core.c and 8250_early.c in addition to 8250.c.
> - I tried implementing this totally in serial_in as suggested, but
> it can't be done because of bit overlap between UART_IIR_NO_INT and
> UART_IIR_BUSY. Also there is no way to set the interrupt "handled = 1"
> from serial_in.

currently support other cases). So, serial_pot() doesn't need
save_offset. :-)

Our regshift is definitely 2 on this SoC and we don't have any problems with
console output before the serial driver opens. So assuming it's using
8250_early.c for initial console output I can only conclude that it works

It comes into action only if you specify console=uart,... kernel option
for the eraly console support. The "plain" 8250 console driver is containded
within 8250.c itself.

because UART_TX is offset 0 and the port was left configured from our
ROM monitor.

Well, this part of the patch can't be considered complete then (how LSR
polling is going to work?), so should either be removed or the proper regshift
support added.