Status

()

For bugs in Firefox Desktop, the Mozilla Foundation's web browser. For Firefox user interface issues in menus, bookmarks, location bar, and preferences. Many Firefox bugs will either be filed here or in the Core product. Bugs for developer tools (F12) should be filed in the DevTools product. (more info)

Created attachment 9009822[details]Bug 1491999: Quote command line for multiple components. r?mhowell
The macro expansion of ExecAndWaitForInputIdle consumes the quotes
around the macro argument. The argument has an extra layer of quotes
around the executable name, which keeps it together even if it has
spaces, but we need yet another layer around the whole command line or
else each component of the command line appears as another argument to
StrCpy.
Standard practice is to quote args in the macro definition, I overlooked
this in the initial implementation.

(In reply to Adam Gashlin [:agashlin] from comment #1)
> Standard practice is to quote args in the macro definition, I overlooked
> this in the initial implementation.
To be fair to Adam, I'll point out I also overlooked this in the initial review.

[Tracking Requested - why for this release]:
A regression with launching firefox after an install has been discovered in our release product. We probably want this in a point release as a ride along. Note this is only for "refresh" installs, so it's limited in scope. We're tracking down some telemetry on this now.

Here's the stats for whether installs requested refresh for the last few weeks:
https://sql.telemetry.mozilla.org/queries/59036
It looks like around 12% of all stub installer pings. These installs aren't broken, but Firefox won't start automatically after the installer runs and refresh won't be performed.

Comment on attachment 9009822[details]Bug 1491999: Quote command line for multiple components. r?mhowell
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1451366
[User impact if declined]: Users eligible for refresh (see bug 1369255) will not start running Firefox automatically after install, they will have to run it manually.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes, the fix is working in
https://archive.mozilla.org/pub/firefox/nightly/2018/09/2018-09-19-12-38-06-mozilla-central/Firefox%20Installer.en-US.exe
[Needs manual test from QE? If yes, steps to reproduce]: Yes.
1. Install Firefox
2. Uninstall
3. Install from an affected stub installer, allow the install to proceed with refresh
After the install the affected installer will not start Firefox.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: The error and fix are straightforward, this is a return to the old behavior.
[String changes made/needed]: None

I also can confirm that 64.0a1 (2018-09-19) is verified fixed. Now Firefox is successfully launched after the stub installation (reproduced the initial issue using the 64.0a1 (2018-09-17) stub build and Windows 10 x64). Based on comment 10, too, I will mark Firefox 64 accordingly.
I will finish the verification process as soon as the latest beta and release stub builds will be available.