-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. There were no new javadoc warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 05/Feb/15 20:57 -1 overall . Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12654156/HADOOP-10623.v04.patch
against trunk revision 276485e.
+1 @author . The patch does not contain any @author tags.
-1 tests included . The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac . The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc . There were no new javadoc warning messages.
+1 eclipse:eclipse . The patch built with eclipse:eclipse.
+1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings.
+1 release audit . The applied patch does not increase the total number of release audit warnings.
-1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5607//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5607//console
This message is automatically generated.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. There were no new javadoc warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 05/Jul/14 01:55 -1 overall . Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12654156/HADOOP-10623.v04.patch
against trunk revision .
+1 @author . The patch does not contain any @author tags.
-1 tests included . The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac . The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc . There were no new javadoc warning messages.
+1 eclipse:eclipse . The patch built with eclipse:eclipse.
+1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit . The applied patch does not increase the total number of release audit warnings.
+1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests . The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4216//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4216//console
This message is automatically generated.

Haohui Mai
added a comment - 01/Jul/14 16:15 Thanks for the explanation. This should be a useful feature.
Note that there is a GetConf tool in hdfs – do you think that it might be cleaner if you can integrate this patch with it?

I think we really ought to have a yarn diagnostics operation, with this being a sub-operation. That way, this could be just one of the operations supported, some diagnostics --configuration ...

this implies use of the org.apache.commons.cli.Options code to parse the options -this scales better than doing it all by hand.

isolating parsing from the printing makes this testable

Configuration.addResource() gets into trouble if the resource isn't there. it should be checked and reported as missing first (maybe a failure for the listed, or just a --failifmissing option to even bail out if, say yarn-site.xml isn't on the CP.

Steve Loughran
added a comment - 01/Jul/14 10:01 This will be useful as a way of diagnosing problems
I think we really ought to have a yarn diagnostics operation, with this being a sub-operation. That way, this could be just one of the operations supported, some diagnostics --configuration ...
this implies use of the org.apache.commons.cli.Options code to parse the options -this scales better than doing it all by hand.
isolating parsing from the printing makes this testable
Configuration.addResource() gets into trouble if the resource isn't there. it should be checked and reported as missing first (maybe a failure for the listed, or just a --failifmissing option to even bail out if, say yarn-site.xml isn't on the CP.

Gera Shegalov
added a comment - 27/Jun/14 20:37 Haohui Mai , The purpose of this tool is complimentary to the displaying the conf of a running service.
It can load conf from classpath, local path or FileSystem (e.g., job conf from the staging area)
it allows to you to review separately *-default.xml and overlaid with *-site.xml and application/job conf
obviously there is the deficiency of not being able to see the hardcoded constants, somewhat compensated by -defval.
We intend to use it to validate config for sanity before rolling out to cluster, and to debug failed jobs easier from the command line especially when the AM failed before completing history.

This feature shows the configuration from the classpath instead of the configuration used in run-time. Given the fact that you can get the runtime configuration from the URL {{http://service/conf}, I wonder, is it better to just load the run-time configuration instead?

Haohui Mai
added a comment - 27/Jun/14 17:23 This feature shows the configuration from the classpath instead of the configuration used in run-time. Given the fact that you can get the runtime configuration from the URL {{ http://service/conf }, I wonder, is it better to just load the run-time configuration instead?

Tsuyoshi Ozawa
added a comment - 27/Jun/14 14:27 I just glanced over the patch. This feature looks interesting and useful for Hadoop operators to confirm current configurations. +1 to this feature. Should we add tests and document of this tools?

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. There were no new javadoc warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 27/May/14 08:11 -1 overall . Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12646849/HADOOP-10623.v03.patch
against trunk revision .
+1 @author . The patch does not contain any @author tags.
-1 tests included . The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac . The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc . There were no new javadoc warning messages.
+1 eclipse:eclipse . The patch built with eclipse:eclipse.
+1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit . The applied patch does not increase the total number of release audit warnings.
+1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests . The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3973//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3973//console
This message is automatically generated.