On Wed, Jun 04, 2008 at 09:24:37PM +0200, ??ric Piel wrote:> Hello,> We haven't received any review for this driver since last week's post by> Yan :-( That's why I'm adding explicitly as receivers of this email all> the people who have reviewed the first two previous takes. Apologies for> the possible multiple receptions.> > It would be _really really kind_ if some of you could take some time and> comment (or simply ACK ;-) ) this code. It adds support for hardware> which can be found in mostly every HP Compaq laptop less than three> years old. It's quite worthy.>

I would recommend converting the input piece to input_polled_deviceinstead of managing the polling thread by yourselves.