On 05/14/2013 11:08 AM, Joe Perches wrote:
> On Mon, 2013-05-13 at 14:04 -0700, Nithin Nayak Sujir wrote:>> On the 5718, 5719 and 5720 serdes devices, powering down function 0>> results in all the other ports being powered down. Add code to skip>> function 0 power down.>> Hi Nithin. 5718? I'm confused a bit by the commit message.>>> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c> []>> +static bool tg3_phy_power_bug(struct tg3 *tp)>> +{>> + switch (tg3_asic_rev(tp)) {>> + case ASIC_REV_5700:>> + case ASIC_REV_5704:>> + return true;>> + case ASIC_REV_5780:>> + if (tp->phy_flags & TG3_PHYFLG_MII_SERDES)>> + return true;>> + return false;>> + case ASIC_REV_5717:>> + if (!tp->pci_fn)>> + return true;>> + return false;>> + case ASIC_REV_5719:>> + case ASIC_REV_5720:>> + if ((tp->phy_flags & TG3_PHYFLG_PHY_SERDES) &&>> + !tp->pci_fn)>> + return true;>> + return false;>> + }>> +>> Where is the 5718 in this?> What is the 5718?> There is no #define for it.>
The 5718 is another device in the same family as the 5719 and 5720. There is no
case or define for the ASIC_REV because it has the same asic revision as the 5719.
However, it is a separate device and you can find it in the pci table and in the
code as TG3PCI_DEVICE_TIGON3_5718.
>>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html