On Thu, Feb 11, 2010 at 03:20:00PM -0800, Eric W. Biederman wrote:>>If we exclude directories and symlinks from the set of sysfs>dirents where we need active references we are left with>sysfs attributes (binary or not).>>- Tweak sysfs_deactivate to only do something on attributes>- Move lockdep initialization into sysfs_file_add_mode to> limit it to just attributes.

Why?

If I read your patch correctly, s_active will be uselessfor non-attributes sysfs entries? For sysfs dir, maybe,since it can only be removed by sysfs_remove_dir(),but not sure about sysfs symlinks...