| | Can't understand this patch. First of all, it looks wrong. Looks like| we never set .si_pid != 0 when the signal is set by sys_kill() ?| | But more importantly, unless I missed something, this patch is unnecessary| complication.| | We call masquerade_si_pid() only when from_ancestor_ns == T, this is correct.| But this means that (!is_si_special(info) && SI_FROMUSER(info)) == T, why| do we re-check in masquerade_si_pid() ?| | And why can't we just do| | default:| copy_siginfo(&q->info, info);| if (from_ancestor_ns)| info->si_pid = 0;

and go with this.

| | ? Why should we check SI_USER and change sys_kill() ?| | see also the comment for the next 7/7 patch.| | Oleg.