On Wednesday 09 January 2008, Christian Perrier wrote:
> Quoting Frans Pop (elendil@planet.nl):
> > I have done some first testing with the new script and committed some
> > changes. Please check them (preferably before the next l10n-sync run
> > :-).
>
> I won't have time for this. So if you have some doubts, better
> de-activate the l10n-sync runs....
Nah, we'll just let things crash [1] ;-)
> > For example, I have doubts that an existing translation would in all
> > cases survive a change in the sublevel of a string.
> > The solution could be to:
> > 1) merge all sublevel PO files into a temporary master PO file
>
> That's already done in the script, IIRC.
Yes, but only after the updates have already been done.
> > 2) update that against the grand master POT file
> > 3) merge that against the sublevel POT files to split it
>
> That seems an interesting idea, yes.
OK. Attached a "proof of concept" patch that roughly implements this. It's
missing some debug logging support and some other minor details, but I've
tested with it and it should work.
For now I'm mostly interested in discussion of the issues I mention in the
comments in the big new section (which basically replaces the old section
that follows it).
The main problems I see ATM (but these exist in your code too) is:
- keeping correct PO-Revision-Date headers
- attributing updates done in sublevels to the correct translator in
changelogs
The way I have tested this is:
cd packages/po
svn revert -R
for i in 3 4 5; do mkdir sublevel$i; done
rm sublevel*/*.po
cp *.po sublevel1/
And then, for the first run only, comment out the "if" statement as
indicated in the comment in the new section (only the if and fi statements,
not the code between them). This will magically create PO files for all
translations for all levels.
> > General question. Should the ATOMIC_COMMITS option maybe just be
> > dropped? I'm not sure why you'd want to use it and dropping it would
> > significantly improve the readability of the code.
>
> So, I agree that it can be dropped, yes.
Done and committed.
Cheers,
FJP
[1] Translates to: I don't expect problems, but will check the commits.