> BKL use isn't right or wrong -- it isn't a case of creating a deadlock> or a race. I'm picking a relatively random function from "grep -r> lock_kernel * | grep /usb/". I'll show what I think isn't optimal> about it.

Perhaps, we could agree that the BKL is used wrongly if itwon't fulfill its presumed function, or fulfills another functionthan the obvious without a comment stating that, or fulfillsa non obvious function without any comment ?

The first case is IMHO the worst, because, although BKLcan't hurt technically, it obscures locking.