Change History (14)

It looks like many of the demos are missing:
dojo.require("dijit._Widget");

And some also need to remove the comments around:
{% load dojox.dtl.contrib.dijit %}
It looks like the load was commented out with this comment, but maybe that is no longer the case?
Note, the load tag here is superfluous, since _DomTemplate has a dojo.require for it.

I will try to create a patch tomorrow, there is still 3 failing after the above changes, which I need to work on demo_Templated.html, and demo_Table.html and demo_Data.html

While working on the dtl/demos I found the following problems with the dtl code.
dojox.dtl._base.js - was missing define for "dojo/_base/Deferred", and had to change xhr.xhrGet() to xhr.get()
dojox.dtl._DomTemplated.js - had to change cache.cache() to cache().
dojox.dtl._Templated.js - had to define dijit/_TemplatedMixin instead of dijit/_Templated, and had to add a function to the call to attachTempalteNodes.
dojox.dtl.contrib.dom.js - change from domStyle.style() to domStyle.set().

And I made the following updates to the demos:
dojox/dtl/demos/demo_Data.html - was missing a dojo.require for dijit._Widget.
dojox/dtl/demos/demo_Table.html - was missing a dojo.require for dijit._Widget.
dojox/dtl/demos/demo_Templated.html - was missing a dojo.require for dijit._Widget.

dojox/dtl/demos/templates/blog_base.html, blog_list.html and blog_page.html - had to remove the <!-- --> from around this line:
{% load dojox.dtl.contrib.dom %}
But I am not sure why this was necessary, it worked in 1.6 with the <!-- --> around it...

Thanks for committing my patch and for making the other updates to dtl.

I found one problem with the updates to dtl/_base which are causing a few test failures for things which were working ok with just my patch.
The change you made in the get: function(key, otherwise)
You changed:

if(typeof this[key] != "undefined"){

return n(this[key]);

}

To this:

if(this[key] != undefined){

return n(this[key]);

}

The problem is happening when this[key] is null, and the typeof this[key] is an object, the old test would pass (and return n(this[key])) , but your test is failing and going on to the return otherwise;
So you can either change back to the typeof or change to also allow null.
Thanks,
Ed