xine-devel

Hi,
Attached is a patch to xine-lib cvs that adds an smb input plugin based on
libsmbclient.
It is actually a no-brainer as libsmbclient does all the work, but it does the
job well (for me). Video playback is much smoother and more reliable than
when I try to use the vfs plugin.
I hope this helps anyone.
Frank van Viegen

On Sun, 2004-09-19 at 16:56 +0200, Frank van Viegen wrote:
> Hi,
>
> Attached is a patch to xine-lib cvs that adds an smb input plugin based on
> libsmbclient.
>
> It is actually a no-brainer as libsmbclient does all the work, but it does the
> job well (for me). Video playback is much smoother and more reliable than
> when I try to use the vfs plugin.
I agree that the gnome-vfs plugin is slow in its current form, however I
have a patch to make it use the network buffer control which helps a
great deal, as well as the fact that this plugin supports authentication
callbacks.
I also have plans to make it the default for HTTP now that the main
issue (following redirects) is fixed in gnome-vfs.
Hopefully, I should be able to commit all this soon.
Cheers
---
Bastien Nocera <hadess@...>

Hi,
On Mon, 20 Sep 2004 14:51:06 +0100, Bastien Nocera <hadess@...> wrote:
> great deal, as well as the fact that this plugin supports authentication
> callbacks.
Do i missed anything from previous authentication callback thread or
we really have not yet a final decision about this?
IMHO we must add this mechanism before 1.0, preferably now in rc7.
If we still have not decided about the callback's parameters, my vote
is for somewhat using the gnome's vfs api as base. They most likely
support more protocols for vfs than we do and have probably discussed
which parameters are needed.
comments? patches? objections?
regards,
Miguel

Hi Bastien,
On Mon, 20 Sep 2004 14:51:06 +0100, Bastien Nocera <hadess@...> wrote:
> I agree that the gnome-vfs plugin is slow in its current form, however I
> have a patch to make it use the network buffer control which helps a
> great deal, as well as the fact that this plugin supports authentication
> callbacks.
Does it prevent us from adding the libsmbclient support? I mean, do
you think the gnome-vfs totally supercedes the need for a simpler smb
plugin?
At first sight, I would risk to say we should have both. in case one
has no gnome installed but libsmbclient the later would be used.
perhaps with a lower priority or something.
Miguel

On Thu, 2004-09-23 at 17:20 -0300, Miguel Freitas wrote:
> Hi Bastien,
>
> On Mon, 20 Sep 2004 14:51:06 +0100, Bastien Nocera <hadess@...> wrote:
> > I agree that the gnome-vfs plugin is slow in its current form, however I
> > have a patch to make it use the network buffer control which helps a
> > great deal, as well as the fact that this plugin supports authentication
> > callbacks.
>
> Does it prevent us from adding the libsmbclient support? I mean, do
> you think the gnome-vfs totally supercedes the need for a simpler smb
> plugin?
No, absolutely not. I was just explaining why the gnome-vfs plugin
existed, and why it was better than a stand-alone one, not saying that
the stand-alone one wasn't of use, at any time ;)
> At first sight, I would risk to say we should have both. in case one
> has no gnome installed but libsmbclient the later would be used.
> perhaps with a lower priority or something.
Fine by me.
---
Bastien Nocera <hadess@...>

Hi,
On Mon, 20 Sep 2004 14:51:06 +0100, Bastien Nocera <hadess@...> wrote:
> great deal, as well as the fact that this plugin supports authentication
> callbacks.
Do i missed anything from previous authentication callback thread or
we really have not yet a final decision about this?
IMHO we must add this mechanism before 1.0, preferably now in rc7.
If we still have not decided about the callback's parameters, my vote
is for somewhat using the gnome's vfs api as base. They most likely
support more protocols for vfs than we do and have probably discussed
which parameters are needed.
comments? patches? objections?
regards,
Miguel

On Thu, 2004-09-23 at 17:40 -0300, Miguel Freitas wrote:
> Hi,
>
> On Mon, 20 Sep 2004 14:51:06 +0100, Bastien Nocera <hadess@...> wrote:
> > great deal, as well as the fact that this plugin supports authentication
> > callbacks.
>
> Do i missed anything from previous authentication callback thread or
> we really have not yet a final decision about this?
Daniel and Thibaut worked on that. I think that, just like the works on
tags, it was just a short way from being committed.
> IMHO we must add this mechanism before 1.0, preferably now in rc7.
>
> If we still have not decided about the callback's parameters, my vote
> is for somewhat using the gnome's vfs api as base. They most likely
> support more protocols for vfs than we do and have probably discussed
> which parameters are needed.
>
> comments? patches? objections?
I thought that Daniel's patch was good. I would need to see how I could
integrate it before saying anything for, or against it.
---
Bastien Nocera <hadess@...>