I don't think this is really a relevant change : As for me (and I guess at least for the author of this theme, @agnoster, if he did this choice ?), i don't really care about the return value. And also, it seems your changes are bugged, I have an error command not found : prompt_contextx

No problem. It is like me, as i like in the composer plugin to alter some commands here and there. About that, you make me think i should put this in my .zshrc instead of directly editing the plugin... :)

An earlier version of this theme did indeed have the exit code - I decided in the end against it in the interest of simplicity. I tried to make sure the theme shows no more information than I really need, and 99% of the time I don't need the exit code - I just want to know if a command succeeded or not.

The git status follows a similar principle: many themes show detailed information about whether there are new files, or modifications, or unmerged, etc. etc. Ultimately, conveying too much information can be just as bad as not conveying enough, because it's harder for the user to automatically perceive what they need to know.

I'd like to see the return of the ✘ instead of the error code. It's much, much more aesthetically appealing and, given that I rarely if ever need to know the error code, there's no need for it to clutter the command line.

I could write the code change myself & submit the pull request if y'all like; otherwise, I may fork the agnoster theme & start working on my own. Let me know what y'all think.

@jfmercer The sad thing is, I hate the numeric status code. What am I supposed to do, fork it and call it "agnoster's agnoster theme"? Or maybe "agnoster-classic"?

@robbyrussell While I believe very strongly that everyone should have the right to adapt and change my theme however they see fit, it hurts me a little that I put so much work into getting it just so, and now I can't even use my own theme from OMZ. In future, I'd suggest that if people want to modify a theme, they create a new theme forked from the original.

Would you be open to a PR reverting these changes? I totally understand that, since it's a community project you have every right to let people contribute however you see fit, but it would mean a lot to me if I could use my theme straight from OMZ without cringing ;-)

@fuadsaud Thanks, I can totally see why you'd want the code, it may be that for certain workflows it's more relevant (say, developing CLI tools). I'd like to perhaps re-introduce this as an option, but I don't really want the theme to suffer from optionitis. I tried to make my theme fairly easy to hack so that people could fork it and make their own powerline-style prompts, so I could well imagine building a theme that looks similar, but shows numeric status code, more detailed git information, maybe even some more relevant stuff in the RPROMPT. But I want the agnoster theme to remain focused on brevity and clarity — even if the length and rambling nature of my comments here might suggest I should take some of my own medicine!

I have submitted a pull request, #1510, to revert the numeric code to the X instead.