Twelve years after it opened in London, Punchdrunk’s take on Macbeth is still packing them in in New York – with a bar and restaurant attached. Has success tarnished the magic – or does it still seduce?