Re: [PATCH 0/6] [KBUILD] configuration system improvements

Randy Dunlap <randy.dunlap <at> oracle.com>
2009-03-02 03:42:49 GMT

Cheng Renquan wrote:
> This group of patches improve the usability of kernel configuration system,
> mainly,
>
> 1. add symbol's value shown accompanied in config item's help message;
> 2. move the real plumbing functions code from mconf.c to menu.c, make them
> be able to be shared with other configuration methods;
> 3. add "symbol's value shown" support for gconfig/xconfig/config;
>
> 0001--KBUILD-add-symbol-value-to-help-find-the-real-depe.patch
> 0002--KBUILD-add-menu_get_ext_help-function-to-display-m.patch
> 0003--KBUILD-menuconfig-improvements.patch
> 0004--KBUILD-make-use-of-menu_get_ext_help-in-gconfig.patch
> 0005--KBUILD-make-use-of-menu_get_ext_help-in-qconfig.patch
> 0006--KBUILD-make-use-of-menu_get_ext_help-in-make-conf.patch
>
> I found gconfig still lack of "search by symbol" support, and that would be
> in another patch.
>
> Request for comments, thanks.
Hi,
I still like this idea a lot. However, with "make gconfig" I am
seeing a segfault when I click on "Firmware Drivers" in the main menu.
I only see this with these patches applied.
Other than that, they look good to me.
Here's the gconfig info:

Re: [PATCH 0/6] [KBUILD] configuration system improvements

Cheng Renquan <crquan <at> gmail.com>
2009-03-03 04:09:35 GMT

On Mon, Mar 2, 2009 at 11:42 AM, Randy Dunlap <randy.dunlap <at> oracle.com> wrote:
> Cheng Renquan wrote:
>> This group of patches improve the usability of kernel configuration system,
>> mainly,
>>
>> 1. add symbol's value shown accompanied in config item's help message;
>> 2. move the real plumbing functions code from mconf.c to menu.c, make them
>> be able to be shared with other configuration methods;
>> 3. add "symbol's value shown" support for gconfig/xconfig/config;
>>
>> 0001--KBUILD-add-symbol-value-to-help-find-the-real-depe.patch
>> 0002--KBUILD-add-menu_get_ext_help-function-to-display-m.patch
>> 0003--KBUILD-menuconfig-improvements.patch
>> 0004--KBUILD-make-use-of-menu_get_ext_help-in-gconfig.patch
>> 0005--KBUILD-make-use-of-menu_get_ext_help-in-qconfig.patch
>> 0006--KBUILD-make-use-of-menu_get_ext_help-in-make-conf.patch
>>
>> I found gconfig still lack of "search by symbol" support, and that would be
>> in another patch.
>>
>> Request for comments, thanks.
>
> Hi,
>
> I still like this idea a lot. However, with "make gconfig" I am
> seeing a segfault when I click on "Firmware Drivers" in the main menu.
> I only see this with these patches applied.
>
> Other than that, they look good to me.
>

Re: [PATCH 0/6] [KBUILD] configuration system improvements

Randy Dunlap <randy.dunlap <at> oracle.com>
2009-03-03 18:24:20 GMT

Cheng Renquan wrote:
> On Mon, Mar 2, 2009 at 11:42 AM, Randy Dunlap <randy.dunlap <at> oracle.com> wrote:
>> Cheng Renquan wrote:
>>> This group of patches improve the usability of kernel configuration system,
>>> mainly,
>>>
>>> 1. add symbol's value shown accompanied in config item's help message;
>>> 2. move the real plumbing functions code from mconf.c to menu.c, make them
>>> be able to be shared with other configuration methods;
>>> 3. add "symbol's value shown" support for gconfig/xconfig/config;
>>>
>>> 0001--KBUILD-add-symbol-value-to-help-find-the-real-depe.patch
>>> 0002--KBUILD-add-menu_get_ext_help-function-to-display-m.patch
>>> 0003--KBUILD-menuconfig-improvements.patch
>>> 0004--KBUILD-make-use-of-menu_get_ext_help-in-gconfig.patch
>>> 0005--KBUILD-make-use-of-menu_get_ext_help-in-qconfig.patch
>>> 0006--KBUILD-make-use-of-menu_get_ext_help-in-make-conf.patch
>>>
>>> I found gconfig still lack of "search by symbol" support, and that would be
>>> in another patch.
>>>
>>> Request for comments, thanks.
>> Hi,
>>
>> I still like this idea a lot. However, with "make gconfig" I am
>> seeing a segfault when I click on "Firmware Drivers" in the main menu.
>> I only see this with these patches applied.
>>
>> Other than that, they look good to me.
>>

Re: [PATCH 0/6] [KBUILD] configuration system improvements

Randy Dunlap <randy.dunlap <at> oracle.com>
2009-03-03 19:55:27 GMT

Randy Dunlap wrote:
> Cheng Renquan wrote:
>> On Mon, Mar 2, 2009 at 11:42 AM, Randy Dunlap <randy.dunlap <at> oracle.com> wrote:
>>> Cheng Renquan wrote:
>>>> This group of patches improve the usability of kernel configuration system,
>>>> mainly,
>>>>
>>>> 1. add symbol's value shown accompanied in config item's help message;
>>>> 2. move the real plumbing functions code from mconf.c to menu.c, make them
>>>> be able to be shared with other configuration methods;
>>>> 3. add "symbol's value shown" support for gconfig/xconfig/config;
>>>>
>>>> 0001--KBUILD-add-symbol-value-to-help-find-the-real-depe.patch
>>>> 0002--KBUILD-add-menu_get_ext_help-function-to-display-m.patch
>>>> 0003--KBUILD-menuconfig-improvements.patch
>>>> 0004--KBUILD-make-use-of-menu_get_ext_help-in-gconfig.patch
>>>> 0005--KBUILD-make-use-of-menu_get_ext_help-in-qconfig.patch
>>>> 0006--KBUILD-make-use-of-menu_get_ext_help-in-make-conf.patch
>>>>
>>>> I found gconfig still lack of "search by symbol" support, and that would be
>>>> in another patch.
>>>>
>>>> Request for comments, thanks.
>>> Hi,
>>>
>>> I still like this idea a lot. However, with "make gconfig" I am
>>> seeing a segfault when I click on "Firmware Drivers" in the main menu.
>>> I only see this with these patches applied.
>>>
>>> Other than that, they look good to me.

Re: [PATCH 0/6] [KBUILD] configuration system improvements

Cheng Renquan <crquan <at> gmail.com>
2009-03-04 06:50:21 GMT

On Wed, Mar 4, 2009 at 3:55 AM, Randy Dunlap <randy.dunlap <at> oracle.com> wrote:
>> This is on OpenSUSE 10.3 on x86_64.
>>
>> glibc-2.6.1-18
>> gtk2-2.12.0-5
>>
>> I don't know that I have any other gtk+ programs.
>>
>>> I have developed these patches on default Fedora 10 i686, it runs
>>> well, and today I have tested it under a latest Gentoo x86_64 desktop,
>>> all seems run well here.
>>
>> Here's a backtrace from gdb. gconfig was built without -d, however.
Your glibc and gtk version not old, the building environment seems
good, but here I don't have a OpenSUSE 10.3 x86_64, really no idea on
how to resolve that problem, maybe I have chance to install a OpenSUSE
10.3 x86_64 these days, the I will try that,
Today I tested these patches on another pristine debian-5.0 (lenny)
x86_64 system, it also performed well.
On systems I tested (glibc 2.6,2.7,2.8, gtk-2.12 or gtk-2.14), it may
report warnings from gtkitemfactory.h and ununsed variables from
images.c, but doesn't matter, after "scripts/kconfig/gconf
arch/x86/Kconfig" run, the gtk gconfig window will display, with
symbol's value quoted well,
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function
declaration isn’t a prototype

On Thu, Feb 19, 2009 at 11:45:31PM -0800, Josh Hunt wrote:
> Updated patch with Sam's fixes as per this discussion:
> http://lkml.org/lkml/2009/2/15/18
>
> Running 'make rpm' fails when CONFIG_LOCALVERSION_AUTO=y and using a kernel
> source tree under SCM. This is due to KERNELRELEASE being different when the
> initial make is run and when make is run from rpmbuild.
...
Hand applied - your patches continue to be wordwrapped.
Please see if you can fix this next time.
Thanks,
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix mkspec to cleanup RPM_BUILD_ROOT

Sam Ravnborg <sam <at> ravnborg.org>
2009-03-07 12:59:21 GMT

On Sun, Feb 22, 2009 at 10:54:55AM -0800, Josh Hunt wrote:
> The contents of the %clean section in mkspec is currently commented
> out leaving RPM_BUILD_ROOT and its contents on the build machine.
> This patch removes it once the rpm build process is complete.
>
> Signed-off-by: Josh Hunt <josh <at> scalex86.org>
Applied,
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html