Em Wed, Feb 09, 2011 at 05:06:18AM +0100, Mike Galbraith escreveu:> On Wed, 2011-02-09 at 00:43 +0000, tip-bot for Arnaldo Carvalho de Melo wrote> > Gitweb: http://git.kernel.org/tip/d5e3d747007fdb541e57ed72e020ff0b94db3470> > Author: Arnaldo Carvalho de Melo <acme@redhat.com>> > > > perf annotate: Fix annotate context lines regression> > > > The live annotation done in 'perf top' needs to limit the context before> > lines that aren't filtered out by the min percent filter, if we don't do> > that, the screen in a tty often is not enough for showing what is> > interesting: lines with hits and a few source code lines before it.> > Looks to me like this went from regress a bit while waiting for tui> thing to progress a bit immediately :)

:-) Can you please apply the two patches and give 'perf top --tui' liveannotation a shot? Just press enter or -> (right key) on a symbol youwant to annotate.

I'm still polishing it a bit, want to avoid trying the notes->lock oneach time record_precise_ip is called, for that I need to share thecurrent symbol being annotated (sym_filter_entry) with the annotatebrowser, the timer should not always run, etc, but just so that I canget some feedback on how it is shaping up, please try it and report yourimpressions :-)

Also when enter is pressed and one is monitoring multiple events, apopup menu with the event names should be presented, etc.