commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separateenum for the fip_mode that shall be used during initialisation handlinguntil it is passed to fcoe_ctrl_link_up to set the initial fip_state. Thatchange was incomplete and gcc quietly converted in various places betweenthe fip_mode and the fip_state enum values with implicit enum conversions,which fortunately cannot cause any issues in the actual code's execution.

clang however warns about these implicit enum conversions in the scsidrivers. This commit consolidates the use of the two enums, guided byclang's enum-conversion warnings.

This commit now completes the use of the fip_mode: It expects and usesfip_mode in {bnx2fc,fcoe}_interface_create and fcoe_ctlr_init, and it callsfcoe_ctrl_set_set() with the correct values in fcoe_ctlr_link_up(). Italso breaks the association between FIP_MODE_AUTO and FIP_ST_AUTO toindicate these two enums are distinct.