Donald Trump’s choice for ambassador to Israel, David Friedman, has helped raise millions of dollars for a prominent West Bank settlement, a connection that could complicate the president-elect’s promised effort to revive Israeli-Palestinian peace talks.

Mr. Friedman and his family have longstanding connections to the settlement, Beit El, a large and politically active settlement that has benefited from extensive support from the...