Activity

Is this the same issue as CLJ-806? If so, it might be nice to close one with a comment that it is a duplicate of the other. Given CLJ-806 has no patch, and this one does, perhaps preferable to close CLJ-806?

Andy Fingerhut
added a comment - 16/Feb/12 11:36 AM Is this the same issue as CLJ-806? If so, it might be nice to close one with a comment that it is a duplicate of the other. Given CLJ-806 has no patch, and this one does, perhaps preferable to close CLJ-806?

Tassilo Horn
added a comment - 16/Feb/12 11:46 AM John, you are right. I didn't find it searching for "test are" earlier today; now I do.
I did as you've suggested: closed CLJ-806 in favour of this one.

I've tested this patch by hand, and it seems to work fine, and the code looks correct. I have tried several ways to add a unit test to verify this fix, but haven't found the right way to do it, if there is one.

Andy Fingerhut
added a comment - 17/Feb/12 2:27 AM I've tested this patch by hand, and it seems to work fine, and the code looks correct. I have tried several ways to add a unit test to verify this fix, but haven't found the right way to do it, if there is one.

This patch obsoletes the former on (I'm gonna delete the old one). It includes:

an extended fix that catches also the zero-arg given case

a fix for a testcase in test/clojure/test_clojure/java_interop.clj which only passed because of the bug this issue is all about

a currently #_-disabled test case for testing `are'. It is disabled, because it fails when run with "ant test". However, it works just fine when run inside some REPL. I presume that's because ant runs inside its own JVM instance and thus makes catching exceptions from macroexpand/eval forms impossible?!?

Tassilo Horn
added a comment - 17/Feb/12 4:10 AM This patch obsoletes the former on (I'm gonna delete the old one). It includes:

an extended fix that catches also the zero-arg given case

a fix for a testcase in test/clojure/test_clojure/java_interop.clj which only passed because of the bug this issue is all about

a currently #_-disabled test case for testing `are'. It is disabled, because it fails when run with "ant test". However, it works just fine when run inside some REPL. I presume that's because ant runs inside its own JVM instance and thus makes catching exceptions from macroexpand/eval forms impossible?!?