On Sun, 2009-01-18 at 08:34 +0100, Oleg Nesterov wrote:> parse_options(&pgid) sets pgid = task_pgrp_nr() which uses the global> namespace. This is wrong, we use this pgid to find "struct pid" in the> current's namespace. Change parse_options() to use task_pgrp_vnr().> > Also do s/task_pgrp_nr/task_pgrp_vnr/ in the debugging printks.> checkpatch.pl complains about "line over 80 characters", but it should> blame the cuurent code, not the patch.

This changelog entry doesn't really have anything that I can use to workout if this change might introduce regressions.

It would be helpful to me if you could include:1) A brief statement about what your trying to achieve and why.2) The reason why task_pgrp_nr() has changed to task_pgrp_vnr() sinceyou made the change (that is someone working on pid namespaces) totask_pgrp_nr().3) Why you believe this change won't introduce a regression.