It shouldn't. Only redefining window.console somehow would do it. Or setting window.console, if you've made the property non-configurable yourself -- which would happen if you froze the global object, which it seems plausible you might have done.

(In reply to Jeff Walden [:Waldo] (busy, try to prefer other reviewers if possible) from comment #4)
> It shouldn't. Only redefining window.console somehow would do it. Or
> setting window.console, if you've made the property non-configurable
> yourself -- which would happen if you froze the global object, which it
> seems plausible you might have done.
I don't thin we intent do redefine non-configurable properties and if we do that's a bug in our code I'll try to digg into this to find out why / where this happens.

I looked into stack traces of the failures:
File "resource://anonid0-annotator-at-jetpack/api-utils/lib/timer.js", line 28, in notify
callback.apply(null, args);
File "resource://anonid0-annotator-at-jetpack/test-harness/lib/run-tests.js", line 59, in
onDone: onDone});
File "resource://anonid0-annotator-at-jetpack/test-harness/lib/harness.js", line 311, in runTests
console: new TestRunnerConsole(new ptc.PlainTextConsole(print), options)
File "resource://anonid0-annotator-at-jetpack/test-harness/lib/loader.js", line 12, in
globals = override(override({}, require('api-utils/globals')), globals || {});
File "resource://anonid0-annotator-at-jetpack/api-utils/lib/loader.js", line 85, in override
return defineProperties(target, getOwnPropertyDescriptors(properties));
TypeError: can't redefine non-configurable property 'console'
And it looks like SDK code is not up to date. For example:
File "resource://anonid0-annotator-at-jetpack/api-utils/lib/loader.js", line 85, in override
return defineProperties(target, getOwnPropertyDescriptors(properties));
No longer exists, https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/loader.js#L85 pointed out by KWierso, is not actually not an override function :)
Also `defineProperties(target, ...` is no longer used either.
Can we re-run those tests with up to date SDK ?

This issue which has been automagically fixed by some changeset in 1.9 branch means that 1.8.1 isn't able to run tests with nightly (and aurora ?).
$ cfx test
...
TypeError: can't redefine non-configurable property 'console'
...
I got pinged by various people about this error and thought that something was wrong with their addon... Wouldn't it be worth having a 1.8.2 to fix this (and the panel issue) ?

Created attachment 645345[details]
Pull request 508
This bug was marked as resolved fixed as it has been fixed by new loader changeset landed in 1.9 branch.
But it will need some fix for release/1.8 branch.
Here is one.

Note

You need to
log in
before you can comment on or make changes to this bug.