[{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289201927","html_url":"https://github.com/openark/orchestrator/issues/20#issuecomment-289201927","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/20","id":289201927,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTIwMTkyNw==","user":{"login":"sjmudd","id":116250,"node_id":"MDQ6VXNlcjExNjI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/116250?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmudd","html_url":"https://github.com/sjmudd","followers_url":"https://api.github.com/users/sjmudd/followers","following_url":"https://api.github.com/users/sjmudd/following{/other_user}","gists_url":"https://api.github.com/users/sjmudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmudd/subscriptions","organizations_url":"https://api.github.com/users/sjmudd/orgs","repos_url":"https://api.github.com/users/sjmudd/repos","events_url":"https://api.github.com/users/sjmudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjmudd/received_events","type":"User","site_admin":false},"created_at":"2017-03-25T10:01:12Z","updated_at":"2017-03-25T10:01:12Z","author_association":"COLLABORATOR","body":"I think this issue can be closed now. Several PRs I've provided have added discovery metrics via API calls so this is now resolved. Closing."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289258546","html_url":"https://github.com/openark/orchestrator/issues/118#issuecomment-289258546","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/118","id":289258546,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTI1ODU0Ng==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-26T04:55:03Z","updated_at":"2017-03-26T04:55:03Z","author_association":"COLLABORATOR","body":"> For instance, if the backend mysql is unavailable can Orchestrator still do failovers based on some cached state? Can it failover it's own backend (hence dogfood)?\r\n\r\nIt cannot. You have three options available:\r\n\r\n- running a circular master-master setup, with your own failover/routing mechanism. We do that. Generally master-master is undesired and to be avoided. `orchestrator` guarantees no conflict of writes on a master-master setup and is safe to use. We use [haproxy checks](http://githubengineering.com/context-aware-mysql-pools-via-haproxy/) to route `orchestrator` mysql traffic to the active/available master.\r\n- running Galera/xtradb cluster/InnoDB cluster\r\n- wait; we're working on raft consensus for `orchestrator`, where nodes would be independent of each other yet collaborating, each with their own backend store. This would be either `mysql` or `sqlite`."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289264675","html_url":"https://github.com/openark/orchestrator/issues/78#issuecomment-289264675","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/78","id":289264675,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTI2NDY3NQ==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-26T07:51:26Z","updated_at":"2017-03-26T07:51:56Z","author_association":"COLLABORATOR","body":"@ecortestws I'm happy if you can share the logs. If they contain sensitive data, can you please share them with me via email? My address is shlomi-noach@-youknowhichcompany-.com"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289295245","html_url":"https://github.com/openark/orchestrator/issues/118#issuecomment-289295245","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/118","id":289295245,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTI5NTI0NQ==","user":{"login":"sjmudd","id":116250,"node_id":"MDQ6VXNlcjExNjI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/116250?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmudd","html_url":"https://github.com/sjmudd","followers_url":"https://api.github.com/users/sjmudd/followers","following_url":"https://api.github.com/users/sjmudd/following{/other_user}","gists_url":"https://api.github.com/users/sjmudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmudd/subscriptions","organizations_url":"https://api.github.com/users/sjmudd/orgs","repos_url":"https://api.github.com/users/sjmudd/repos","events_url":"https://api.github.com/users/sjmudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjmudd/received_events","type":"User","site_admin":false},"created_at":"2017-03-26T16:31:54Z","updated_at":"2017-03-26T16:31:54Z","author_association":"COLLABORATOR","body":"I have an orchestrator backend with slaves and have tested \"scheduled\" failover to a slave. This is usually to achieve MySQL upgrades or change the backend due to hardware issues etc. This type of failover works fine though it's not quite what you're asking about. Do *not* expect orchestrator to be able recover from its own backend failure.\r\n\r\nHowever, if you can arrange, on orchestrator backend failure, for the following to be true orchestrator will recover and that is probably all you care about:\r\n* all connections to the old master are killed\r\n* the new \"master\" is writeable (obviously)\r\n* the name that orchestrator uses to talk to its backend (vip name) does not change but points to the new host\r\n* the data that was in the old host is present in the new one\r\n\r\nUnder these conditions orchestrator will detect the backend failure but will recover from it to no ill effect.\r\n\r\nThe main reason that orchestrator is unable to recover itself is that currently a lot of state it may use for recovery is stored in the database with no \"caching layer\" running on the active node. That is not available at the moment the orchestrator backend fails.\r\n\r\nI personally, for performance reasons, would like to see the state being managed by the active node but that requires a very significant amount of code change to achieve that. Given the complexity of all the situations that orchestrator can handle such a change if it were ever to happen needs to be made with a considerable amount of care."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289320083","html_url":"https://github.com/openark/orchestrator/issues/117#issuecomment-289320083","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/117","id":289320083,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTMyMDA4Mw==","user":{"login":"sjmudd","id":116250,"node_id":"MDQ6VXNlcjExNjI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/116250?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmudd","html_url":"https://github.com/sjmudd","followers_url":"https://api.github.com/users/sjmudd/followers","following_url":"https://api.github.com/users/sjmudd/following{/other_user}","gists_url":"https://api.github.com/users/sjmudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmudd/subscriptions","organizations_url":"https://api.github.com/users/sjmudd/orgs","repos_url":"https://api.github.com/users/sjmudd/repos","events_url":"https://api.github.com/users/sjmudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjmudd/received_events","type":"User","site_admin":false},"created_at":"2017-03-26T22:04:41Z","updated_at":"2017-03-26T22:04:41Z","author_association":"COLLABORATOR","body":"I do notice that dropping privileges seems hard in go so maybe this can't be done yet or easily? See: https://github.com/golang/go/issues/1435"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289363834","html_url":"https://github.com/openark/orchestrator/issues/120#issuecomment-289363834","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/120","id":289363834,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTM2MzgzNA==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-27T06:21:57Z","updated_at":"2017-03-27T06:21:57Z","author_association":"COLLABORATOR","body":"I agree that we can have better well formed auditing for failovers. I'm happy to write to a specialized recovery-audit-table. Does that make sense? "},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289364847","html_url":"https://github.com/openark/orchestrator/issues/117#issuecomment-289364847","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/117","id":289364847,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTM2NDg0Nw==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-27T06:28:53Z","updated_at":"2017-03-27T06:28:53Z","author_association":"COLLABORATOR","body":"Perhaps just run via `start-stop-daemon`? It's a pretty nice wrapper.\r\n\r\n```\r\nUsage: start-stop-daemon [

...] \r\n\r\nCommands:\r\n -S|--start -- ... start a program and pass to it\r\n -K|--stop stop a program\r\n -T|--status get the program status\r\n -H|--help print help information\r\n -V|--version print version\r\n\r\nMatching options (at least one is required):\r\n --pid pid to check\r\n --ppid parent pid to check\r\n -p|--pidfile pid file to check\r\n -x|--exec program to start/check if it is running\r\n -n|--name process name to check\r\n -u|--user process owner to check\r\n\r\nOptions:\r\n -g|--group run process as this group\r\n -c|--chuid \r\n change to this user/group before starting\r\n process\r\n -s|--signal signal to send (default TERM)\r\n -a|--startas program to start (default is )\r\n -r|--chroot chroot to before starting\r\n -d|--chdir change to (default is /)\r\n -N|--nicelevel add incr to the process' nice level\r\n -P|--procsched \r\n use with for the kernel\r\n process scheduler (default prio is 0)\r\n -I|--iosched use with to set the IO\r\n scheduler (default prio is 4)\r\n -k|--umask change the umask to before starting\r\n -b|--background force the process to detach\r\n -C|--no-close do not close any file descriptor\r\n -m|--make-pidfile create the pidfile before starting\r\n |--remove-pidfile delete the pidfile after stopping\r\n -R|--retry check whether processes die, and retry\r\n -t|--test test mode, don't do anything\r\n -o|--oknodo exit status 0 (not 1) if nothing done\r\n -q|--quiet be more quiet\r\n -v|--verbose be more verbose\r\n\r\nRetry is |//... where is one of\r\n -|[-] send that signal\r\n wait that many seconds\r\n forever repeat remainder forever\r\nor may be just , meaning //KILL/\r\n...\r\n```"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289364982","html_url":"https://github.com/openark/orchestrator/issues/117#issuecomment-289364982","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/117","id":289364982,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTM2NDk4Mg==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-27T06:29:43Z","updated_at":"2017-03-27T06:29:43Z","author_association":"COLLABORATOR","body":"(I don't know that it solves opening port `80`). If you're behind reverse proxy you don't relaly need to run `orchestrator` on port `80` anyhow"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289441529","html_url":"https://github.com/openark/orchestrator/issues/118#issuecomment-289441529","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/118","id":289441529,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTQ0MTUyOQ==","user":{"login":"bbeaudreault","id":116591,"node_id":"MDQ6VXNlcjExNjU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/116591?v=4","gravatar_id":"","url":"https://api.github.com/users/bbeaudreault","html_url":"https://github.com/bbeaudreault","followers_url":"https://api.github.com/users/bbeaudreault/followers","following_url":"https://api.github.com/users/bbeaudreault/following{/other_user}","gists_url":"https://api.github.com/users/bbeaudreault/gists{/gist_id}","starred_url":"https://api.github.com/users/bbeaudreault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbeaudreault/subscriptions","organizations_url":"https://api.github.com/users/bbeaudreault/orgs","repos_url":"https://api.github.com/users/bbeaudreault/repos","events_url":"https://api.github.com/users/bbeaudreault/events{/privacy}","received_events_url":"https://api.github.com/users/bbeaudreault/received_events","type":"User","site_admin":false},"created_at":"2017-03-27T12:41:32Z","updated_at":"2017-03-27T12:41:32Z","author_association":"NONE","body":"Thanks guys"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289686422","html_url":"https://github.com/openark/orchestrator/issues/78#issuecomment-289686422","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/78","id":289686422,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTY4NjQyMg==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T07:27:30Z","updated_at":"2017-03-28T07:27:30Z","author_association":"COLLABORATOR","body":"OK I'm able to reproduce this.\r\n\r\nThe reason this happens: the `auto_position` is not set by default, and `orchestrator` uses that to recognize GTID replication. I'm looking into improving this."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289715902","html_url":"https://github.com/openark/orchestrator/issues/88#issuecomment-289715902","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/88","id":289715902,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTcxNTkwMg==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T09:34:10Z","updated_at":"2017-03-28T09:34:10Z","author_association":"COLLABORATOR","body":"#104 has been merged."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289723107","html_url":"https://github.com/openark/orchestrator/issues/78#issuecomment-289723107","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/78","id":289723107,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTcyMzEwNw==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T10:03:58Z","updated_at":"2017-03-28T10:03:58Z","author_association":"COLLABORATOR","body":"@ecortestws can you please confirm https://github.com/github/orchestrator/releases/tag/v2.1.1-BETA works for you?\r\n\r\nMake sure that the replicas are on `auto_position=1`, as this is a requirement for a GTID-based recovery.\r\n\r\n\r\n"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289723474","html_url":"https://github.com/openark/orchestrator/issues/83#issuecomment-289723474","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/83","id":289723474,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTcyMzQ3NA==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T10:05:43Z","updated_at":"2017-03-28T10:05:43Z","author_association":"COLLABORATOR","body":"@adkhare @sougou https://github.com/github/orchestrator/releases/tag/v2.1.1-BETA should solve your case, you would need to set:\r\n```\r\n \"FailMasterPromotionIfSQLThreadNotUpToDate\": true,\r\n```\r\n\r\nin `orchestrator`'s config file.\r\n\r\nAre you able to and are interested in testing this?"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289750569","html_url":"https://github.com/openark/orchestrator/issues/78#issuecomment-289750569","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/78","id":289750569,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTc1MDU2OQ==","user":{"login":"ecortestws","id":22430960,"node_id":"MDQ6VXNlcjIyNDMwOTYw","avatar_url":"https://avatars3.githubusercontent.com/u/22430960?v=4","gravatar_id":"","url":"https://api.github.com/users/ecortestws","html_url":"https://github.com/ecortestws","followers_url":"https://api.github.com/users/ecortestws/followers","following_url":"https://api.github.com/users/ecortestws/following{/other_user}","gists_url":"https://api.github.com/users/ecortestws/gists{/gist_id}","starred_url":"https://api.github.com/users/ecortestws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecortestws/subscriptions","organizations_url":"https://api.github.com/users/ecortestws/orgs","repos_url":"https://api.github.com/users/ecortestws/repos","events_url":"https://api.github.com/users/ecortestws/events{/privacy}","received_events_url":"https://api.github.com/users/ecortestws/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T12:14:51Z","updated_at":"2017-03-28T12:14:51Z","author_association":"NONE","body":"@shlomi-noach it worked, but the replication was not started in the demoted master. Is it a expected behavior? The credentials were in place, and after execute \"START SLAVE\" in the old master it started syncing with the new master. "},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289981760","html_url":"https://github.com/openark/orchestrator/issues/78#issuecomment-289981760","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/78","id":289981760,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTk4MTc2MA==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T04:52:40Z","updated_at":"2017-03-29T04:52:40Z","author_association":"COLLABORATOR","body":"@ecortestws This is expected behavior. I see advantages and reasons for both starting and not starting replication automatically; \"not starting\" is on the safer side."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/289986103","html_url":"https://github.com/openark/orchestrator/issues/116#issuecomment-289986103","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/116","id":289986103,"node_id":"MDEyOklzc3VlQ29tbWVudDI4OTk4NjEwMw==","user":{"login":"samveen","id":1241434,"node_id":"MDQ6VXNlcjEyNDE0MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1241434?v=4","gravatar_id":"","url":"https://api.github.com/users/samveen","html_url":"https://github.com/samveen","followers_url":"https://api.github.com/users/samveen/followers","following_url":"https://api.github.com/users/samveen/following{/other_user}","gists_url":"https://api.github.com/users/samveen/gists{/gist_id}","starred_url":"https://api.github.com/users/samveen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samveen/subscriptions","organizations_url":"https://api.github.com/users/samveen/orgs","repos_url":"https://api.github.com/users/samveen/repos","events_url":"https://api.github.com/users/samveen/events{/privacy}","received_events_url":"https://api.github.com/users/samveen/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T05:25:22Z","updated_at":"2017-03-29T05:31:50Z","author_association":"CONTRIBUTOR","body":"I dont see anything between `v2.0.2`..`v2.1.0` that would break building:\r\n```\r\n[samveen@development orchestrator]$ git diff v2.0.2..v2.1.0 build.sh \r\ndiff --git a/build.sh b/build.sh\r\nindex a4703dc..b8141d7 100755\r\n--- a/build.sh\r\n+++ b/build.sh\r\n@@ -33,6 +33,7 @@ usage() {\r\n function precheck() {\r\n local target\r\n local ok=0 # return err. so shell exit code\r\n+ target=\"$1\"\r\n \r\n if [[ \"$target\" == \"linux\" ]]; then\r\n if [[ ! -x \"$( which fpm )\" ]]; then\r\n@@ -135,7 +136,7 @@ function build() {\r\n prefix=\"$4\"\r\n ldflags=\"-X main.AppVersion=${RELEASE_VERSION} -X main.GitCommit=${GIT_COMMIT}\"\r\n echo \"Building via $(go version)\"\r\n- gobuild=\"go build ${opt_race} -ldflags \\\"$ldflags\\\" -o $builddir/orchestrator${prefix}/orchestrator/orchestrator go/cmd/orchestrator/main.go\"\r\n+ gobuild=\"go build -i ${opt_race} -ldflags \\\"$ldflags\\\" -o $builddir/orchestrator${prefix}/orchestrator/orchestrator go/cmd/orchestrator/main.go\"\r\n \r\n case $os in\r\n 'linux')\r\n```\r\n\r\nThat said, the `Please install fpm ...` and `rpmbuild...` messages are actully precheck messages. Looks like the prechecks ignore the `buildonly` option. Good catch 👍 . I'll submit a MR for this.\r\n "},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290086572","html_url":"https://github.com/openark/orchestrator/issues/101#issuecomment-290086572","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/101","id":290086572,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDA4NjU3Mg==","user":{"login":"sturem","id":9708316,"node_id":"MDQ6VXNlcjk3MDgzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9708316?v=4","gravatar_id":"","url":"https://api.github.com/users/sturem","html_url":"https://github.com/sturem","followers_url":"https://api.github.com/users/sturem/followers","following_url":"https://api.github.com/users/sturem/following{/other_user}","gists_url":"https://api.github.com/users/sturem/gists{/gist_id}","starred_url":"https://api.github.com/users/sturem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sturem/subscriptions","organizations_url":"https://api.github.com/users/sturem/orgs","repos_url":"https://api.github.com/users/sturem/repos","events_url":"https://api.github.com/users/sturem/events{/privacy}","received_events_url":"https://api.github.com/users/sturem/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T13:17:39Z","updated_at":"2017-03-29T13:17:39Z","author_association":"NONE","body":"Or even provide both, say, as orchestrator_init.bash and orchestrator_unit.bash; then install either, based on o/s version or systemd presence-or-absence?"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290094690","html_url":"https://github.com/openark/orchestrator/pull/95#issuecomment-290094690","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/95","id":290094690,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDA5NDY5MA==","user":{"login":"orkestrov","id":20597053,"node_id":"MDQ6VXNlcjIwNTk3MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/20597053?v=4","gravatar_id":"","url":"https://api.github.com/users/orkestrov","html_url":"https://github.com/orkestrov","followers_url":"https://api.github.com/users/orkestrov/followers","following_url":"https://api.github.com/users/orkestrov/following{/other_user}","gists_url":"https://api.github.com/users/orkestrov/gists{/gist_id}","starred_url":"https://api.github.com/users/orkestrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orkestrov/subscriptions","organizations_url":"https://api.github.com/users/orkestrov/orgs","repos_url":"https://api.github.com/users/orkestrov/repos","events_url":"https://api.github.com/users/orkestrov/events{/privacy}","received_events_url":"https://api.github.com/users/orkestrov/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T13:46:20Z","updated_at":"2017-03-29T13:46:20Z","author_association":"NONE","body":"I pushed a couple of config tests and also following @sjmudd's advice made sure that orchestrator does not die on SIGHUP when config is erroneous."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290127730","html_url":"https://github.com/openark/orchestrator/issues/120#issuecomment-290127730","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/120","id":290127730,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDEyNzczMA==","user":{"login":"sjmudd","id":116250,"node_id":"MDQ6VXNlcjExNjI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/116250?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmudd","html_url":"https://github.com/sjmudd","followers_url":"https://api.github.com/users/sjmudd/followers","following_url":"https://api.github.com/users/sjmudd/following{/other_user}","gists_url":"https://api.github.com/users/sjmudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmudd/subscriptions","organizations_url":"https://api.github.com/users/sjmudd/orgs","repos_url":"https://api.github.com/users/sjmudd/repos","events_url":"https://api.github.com/users/sjmudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjmudd/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T15:30:56Z","updated_at":"2017-03-29T15:30:56Z","author_association":"COLLABORATOR","body":"To be honest I've not checked exactly how much information is currently stored, and a more complete recovery audit table probably makes sense. I guess we need to look and figure out the details of exactly what it makes sense to add and then figure out how and where to do that."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290306722","html_url":"https://github.com/openark/orchestrator/issues/101#issuecomment-290306722","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/101","id":290306722,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDMwNjcyMg==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T05:31:57Z","updated_at":"2017-03-30T05:31:57Z","author_association":"COLLABORATOR","body":"> Or even provide both, say, as orchestrator_init.bash and orchestrator_unit.bash\r\n\r\nI like this suggestion!"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290309981","html_url":"https://github.com/openark/orchestrator/pull/124#issuecomment-290309981","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/124","id":290309981,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDMwOTk4MQ==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T05:56:33Z","updated_at":"2017-03-30T05:56:33Z","author_association":"COLLABORATOR","body":"Very interesting!\r\n\r\nCan you please explain the flow? What happens when and how, and what tests could run on this?"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290331340","html_url":"https://github.com/openark/orchestrator/pull/124#issuecomment-290331340","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/124","id":290331340,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDMzMTM0MA==","user":{"login":"sjmudd","id":116250,"node_id":"MDQ6VXNlcjExNjI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/116250?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmudd","html_url":"https://github.com/sjmudd","followers_url":"https://api.github.com/users/sjmudd/followers","following_url":"https://api.github.com/users/sjmudd/following{/other_user}","gists_url":"https://api.github.com/users/sjmudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmudd/subscriptions","organizations_url":"https://api.github.com/users/sjmudd/orgs","repos_url":"https://api.github.com/users/sjmudd/repos","events_url":"https://api.github.com/users/sjmudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjmudd/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T07:53:04Z","updated_at":"2017-03-30T07:53:32Z","author_association":"COLLABORATOR","body":"Sure for now I'll I'm doing is a wrapper around your own `integration_test.sh` script.\r\n\r\n```\r\n[smudd@myhost ~/src/orchestrator/src/github.com/github/orchestrator]$ export GOPATH=~/src/orchestrator\r\n[smudd@myhost ~/src/orchestrator/src/github.com/github/orchestrator]$ tests/docker/scripts/integration_test.sh\r\n/Users/smudd/src/orchestrator/src/github.com/github/orchestrator/tests/docker/scripts/../root\r\nStarting up docker mysql image needed for testing...\r\nThu 30 Mar 2017 09:50:04 CEST mad8 mysql[10696]: Create network test_network...\r\n0534dcaaf9e8a20c2a54aa2feaf02b0a764dee8039912dc5cabe69434b51c02c\r\nThu 30 Mar 2017 09:50:04 CEST mad8 mysql[10696]: Creating required directory layouts under /Users/smudd/src/orchestrator/src/github.com/github/orchestrator/tests/docker/scripts/../root...\r\nThu 30 Mar 2017 09:50:04 CEST mad8 mysql[10696]: Ensuring directory for mysql exists...\r\nThu 30 Mar 2017 09:50:05 CEST mad8 mysql[10696]: Starting up containers...\r\nThu 30 Mar 2017 09:50:05 CEST mad8 mysql[10696]: Start up mysql...\r\nThu 30 Mar 2017 09:50:05 CEST mad8 mysql[10696]: mysql: Starting container (image: mysql:5.7)\r\n192d50cfcd9ca02fa6dcb59b4fa8e46f82e709647fb71e5d0ef19b0c8aa5b360\r\nThu 30 Mar 2017 09:50:06 CEST mad8 mysql[10696]: Waiting for containers to initialise...\r\nThu 30 Mar 2017 09:50:06 CEST mad8 mysql[10696]: mysql: Waiting for MySQL to come up...\r\nThu 30 Mar 2017 09:50:28 CEST mad8 mysql[10696]: mysql is up\r\nThu 30 Mar 2017 09:50:28 CEST mad8 mysql[10696]: Add replication users to containers...\r\nThu 30 Mar 2017 09:50:28 CEST mad8 mysql[10696]: mysql: Add test user\r\nmysql: [Warning] Using a password on the command line interface can be insecure.\r\nThu 30 Mar 2017 09:50:28 CEST mad8 mysql[10696]: Setup of mysql complete\r\nRunning integration tests using docker mysql image...\r\nUsing defaults file: tests/docker/scripts/dot_my_cnf\r\nBuilding\r\n### testing via mysql\r\n- generate_config_file OK\r\n- check_db OK\r\nDeploying db\r\n..- deploy_internal_db result: 1\r\n- deploy_internal_db OK\r\n- done testing via mysql\r\nStopping docker mysql image needed for testing...\r\nThu 30 Mar 2017 09:50:35 CEST mad8 mysql[10824]: Stopping and removing containers (mysql)...\r\nThu 30 Mar 2017 09:50:35 CEST mad8 mysql[10824]: - stopping mysql\r\nmysql\r\nThu 30 Mar 2017 09:50:38 CEST mad8 mysql[10824]: - removing mysql\r\nmysql\r\nThu 30 Mar 2017 09:50:38 CEST mad8 mysql[10824]: - removing network\r\ntest_network\r\nThu 30 Mar 2017 09:50:38 CEST mad8 mysql[10824]: Finished\r\n[smudd@myhost ~/src/orchestrator/src/github.com/github/orchestrator]$\r\n```\r\n\r\nSo this doesn't do anything smart yet except avoid the need for anyone to actually \"install mysql\" when testing orchestrator. If they have docker it will get pulled in and run when needed."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290333716","html_url":"https://github.com/openark/orchestrator/pull/125#issuecomment-290333716","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/125","id":290333716,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDMzMzcxNg==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T08:03:55Z","updated_at":"2017-03-30T08:04:01Z","author_association":"COLLABORATOR","body":"Same applies for `end-maintenance`"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290344530","html_url":"https://github.com/openark/orchestrator/pull/124#issuecomment-290344530","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/124","id":290344530,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDM0NDUzMA==","user":{"login":"sjmudd","id":116250,"node_id":"MDQ6VXNlcjExNjI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/116250?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmudd","html_url":"https://github.com/sjmudd","followers_url":"https://api.github.com/users/sjmudd/followers","following_url":"https://api.github.com/users/sjmudd/following{/other_user}","gists_url":"https://api.github.com/users/sjmudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmudd/subscriptions","organizations_url":"https://api.github.com/users/sjmudd/orgs","repos_url":"https://api.github.com/users/sjmudd/repos","events_url":"https://api.github.com/users/sjmudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjmudd/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T08:48:21Z","updated_at":"2017-03-30T08:48:21Z","author_association":"COLLABORATOR","body":"Also note: the size of the current docker images are not too bad and much of what's contained is shared.\r\n\r\n```\r\n$ docker images\r\nREPOSITORY TAG IMAGE ID CREATED SIZE\r\nmysql 8.0 9f21237828fe 8 days ago 433 MB\r\nmysql 5.6 68399df75c59 8 days ago 329 MB\r\nmysql 5.7 5faba1a71ec4 8 days ago 407 MB\r\n```"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290373943","html_url":"https://github.com/openark/orchestrator/pull/124#issuecomment-290373943","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/124","id":290373943,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDM3Mzk0Mw==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T10:42:09Z","updated_at":"2017-03-30T10:42:09Z","author_association":"COLLABORATOR","body":"Thank you for working on this!"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290606697","html_url":"https://github.com/openark/orchestrator/issues/101#issuecomment-290606697","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/101","id":290606697,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDYwNjY5Nw==","user":{"login":"samveen","id":1241434,"node_id":"MDQ6VXNlcjEyNDE0MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1241434?v=4","gravatar_id":"","url":"https://api.github.com/users/samveen","html_url":"https://github.com/samveen","followers_url":"https://api.github.com/users/samveen/followers","following_url":"https://api.github.com/users/samveen/following{/other_user}","gists_url":"https://api.github.com/users/samveen/gists{/gist_id}","starred_url":"https://api.github.com/users/samveen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samveen/subscriptions","organizations_url":"https://api.github.com/users/samveen/orgs","repos_url":"https://api.github.com/users/samveen/repos","events_url":"https://api.github.com/users/samveen/events{/privacy}","received_events_url":"https://api.github.com/users/samveen/received_events","type":"User","site_admin":false},"created_at":"2017-03-31T03:31:49Z","updated_at":"2017-03-31T03:31:49Z","author_association":"CONTRIBUTOR","body":"That's needs to be a build time decision, IMHO."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290830671","html_url":"https://github.com/openark/orchestrator/issues/127#issuecomment-290830671","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/127","id":290830671,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDgzMDY3MQ==","user":{"login":"sjmudd","id":116250,"node_id":"MDQ6VXNlcjExNjI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/116250?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmudd","html_url":"https://github.com/sjmudd","followers_url":"https://api.github.com/users/sjmudd/followers","following_url":"https://api.github.com/users/sjmudd/following{/other_user}","gists_url":"https://api.github.com/users/sjmudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmudd/subscriptions","organizations_url":"https://api.github.com/users/sjmudd/orgs","repos_url":"https://api.github.com/users/sjmudd/repos","events_url":"https://api.github.com/users/sjmudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjmudd/received_events","type":"User","site_admin":false},"created_at":"2017-03-31T21:09:40Z","updated_at":"2017-03-31T21:09:40Z","author_association":"COLLABORATOR","body":"The other option is to assume that all connections using orchestrator must use TLS. This requires more work as all servers need to be configured appropriately and this may be hard or not possible. Also using TLS everywhere may affect performance as the connection time is likely to be longer than a straight connection. On a high volume orchestrator monitoring a large amount of servers this extra overhead may be significant. I have not checked this and should do but in most cases would prefer the fastest option of monitoring the MySQL servers I am using."},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290966434","html_url":"https://github.com/openark/orchestrator/pull/128#issuecomment-290966434","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/128","id":290966434,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDk2NjQzNA==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-04-02T05:49:33Z","updated_at":"2017-04-02T05:49:33Z","author_association":"COLLABORATOR","body":"cc @sjmudd \r\n"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290967330","html_url":"https://github.com/openark/orchestrator/pull/128#issuecomment-290967330","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/128","id":290967330,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDk2NzMzMA==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-04-02T06:16:23Z","updated_at":"2017-04-02T06:16:23Z","author_association":"COLLABORATOR","body":"Also adding badges: https://github.com/github/orchestrator/blob/travisci/README.md"},{"url":"https://api.github.com/repos/openark/orchestrator/issues/comments/290967934","html_url":"https://github.com/openark/orchestrator/issues/126#issuecomment-290967934","issue_url":"https://api.github.com/repos/openark/orchestrator/issues/126","id":290967934,"node_id":"MDEyOklzc3VlQ29tbWVudDI5MDk2NzkzNA==","user":{"login":"shlomi-noach","id":2607934,"node_id":"MDQ6VXNlcjI2MDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2607934?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":false},"created_at":"2017-04-02T06:35:09Z","updated_at":"2017-04-02T06:35:09Z","author_association":"COLLABORATOR","body":"Thank you. Seems like `golang` is not very helpful in identifying the line within an anonymous function."}]