Comments

On Wed, 2012-09-26 at 19:37 -0700, Brian Norris wrote:
> Use pr_info() and pr_err() while defining pr_fmt(). This saves a few> characters, joins a few lines, and makes the code a little more readable> (and grep-able).> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Not sure about this - there is a patch-set from Vikram Narayanan
<vikram186@gmail.com> (Subject: [RFC PATCH 0/8] mtd_tests: Remove
duplicate code and cleanups) which does this for all tests. I hoped he
can re-send newer version.
Also, this patch-set should probably merge all the split format strings
at the same time.

On 10/10/2012 8:10 PM, Artem Bityutskiy wrote:
> On Wed, 2012-09-26 at 19:37 -0700, Brian Norris wrote:>> Use pr_info() and pr_err() while defining pr_fmt(). This saves a few>> characters, joins a few lines, and makes the code a little more readable>> (and grep-able).>>>> Signed-off-by: Brian Norris<computersforpeace@gmail.com>>> Not sure about this - there is a patch-set from Vikram Narayanan> <vikram186@gmail.com> (Subject: [RFC PATCH 0/8] mtd_tests: Remove> duplicate code and cleanups) which does this for all tests. I hoped he> can re-send newer version.
Yeah. I'll send a newer version which will change the printk to pr_* for
all the tests. I can take Brian's patch as well and send the whole
series, if he is ok with it.
Regards,
Vikram

On Wed, Oct 10, 2012 at 8:47 AM, Vikram Narayanan <vikram186@gmail.com> wrote:
> On 10/10/2012 8:10 PM, Artem Bityutskiy wrote:>>>> On Wed, 2012-09-26 at 19:37 -0700, Brian Norris wrote:>>>>>> Use pr_info() and pr_err() while defining pr_fmt(). This saves a few>>> characters, joins a few lines, and makes the code a little more readable>>> (and grep-able).>>>>>> Signed-off-by: Brian Norris<computersforpeace@gmail.com>>>>>>> Not sure about this - there is a patch-set from Vikram Narayanan>> <vikram186@gmail.com> (Subject: [RFC PATCH 0/8] mtd_tests: Remove>> duplicate code and cleanups) which does this for all tests. I hoped he>> can re-send newer version.
I made the patch a while ago when playing around with the test for the
first time but never bothered to send it out until recently. It was
independent of the fact that Vikram did a (later) patch series for
this.
> Yeah. I'll send a newer version which will change the printk to pr_* for all> the tests. I can take Brian's patch as well and send the whole series, if he> is ok with it.
Sure, take it in your series and modify as you want (that's what the
"Signed-off-by" and GPL thing is all about). Or just rewrite it, if
your own search-and-replace is better :)
Regards,
Brian