On Mon, Apr 25, 2011 at 09:31:03AM -0700, Linus Torvalds wrote:> 2011/4/25 Bruno Prémont <bonbons@linux-vserver.org>:> >> > kmemleak reports 86681 new leaks between shortly after boot and -2 state.> > (and 2348 additional ones between -2 and -4).> > I wouldn't necessarily trust kmemleak with the whole RCU-freeing> thing. In your slubinfo reports, the kmemleak data itself also tends> to overwhelm everything else - none of it looks unreasonable per se.> > That said, you clearly have a *lot* of filp entries. I wouldn't> consider it unreasonable, though, because depending on load those may> well be fine. Perhaps you really do have some application(s) that hold> thousands of files open. The default file limit is 1024 (I think), but> you can raise it, and some programs do end up opening tens of> thousands of files for filesystem scanning purposes.> > That said, I would suggest simply trying a saner kernel configuration,> and seeing if that makes a difference:> > > Yes, it's uni-processor system, so SMP=n.> > TINY_RCU=y, PREEMPT_VOLUNTARY=y (whole /proc/config.gz attached keeping> > compression)> > I'm not at all certain that TINY_RCU is appropriate for> general-purpose loads. I'd call it more of a "embedded low-performance> option".> > The _real_ RCU implementation ("tree rcu") forces quiescent states> every few jiffies and has logic to handle "I've got tons of RCU> events, I really need to start handling them now". All of which I> think tiny-rcu lacks.> > So right now I suspect that you have a situation where you just have a> simple load that just ends up never triggering any RCU cleanup, and> the tiny-rcu thing just keeps on gathering events and delays freeing> stuff almost arbitrarily long.> > So try CONFIG_PREEMPT and CONFIG_TREE_PREEMPT_RCU to see if the> behavior goes away. That would confirm the "it's just tinyrcu being> too dang stupid" hypothesis.

CONFIG_TINY_RCU is a bit more stupid than CONFIG_TREE_RCU, and dittofor both PREEMPT versions. CONFIG_TREE_RCU will throttle RCU callbackinvocation. It defaults to invoking no more than 10 at a time, untilthe number of outstanding callbacks on a given CPU exceeds 10,000,at which point it goes into emergency mode and just processes all theremaining callbacks.

In contrast, the TINY versions always process all the remainingcallbacks. There are two reasons for the difference:

1. The fact that TINY has but one CPU speeds up the grace periods (particularly for synchronize_rcu() in CONFIG_TINY_RCU, which is essentially a no-op), so that callbacks should be invoked in a more timely manner.

2. There is only one CPU for TINY, so the scenarios where one CPU keeps another CPU totally busy invoking RCU callbacks cannot happen.

3. TINY is supposed to be TINY, so I figured I should add RCU callback-throttling smarts when and if they proved to be needed. (It is not clear to me that this problem means that more smarts are needed, but if they are, I will of course add them.)

It is quite possible that some adjustments are needed in the defaultsfor CONFIG_TREE_RCU and CONFIG_TREE_PREEMPT_RCU due to the heavierload from the tree-walking changes.