SX410 IS porting thread

Correction for 'Zebra'.With the old DEF for "recreview_hold", with zebra was shown and some garbage in the lower and upper part of the display.The same problem is likely also present on sx400is.

Thanks, checked in as trunk 4703.

Just to be clear, I don't think recreview_hold can affect the correctness of the zebra display, only when it is shown or not. I would expect the viewport/bitmap changes were what affected the zebra?

Also, the patch changed camera_jpeg_count_str to use the address directly rather than using the one defined with the same address in stubs_entry.S. I changed this back. In general, the top level lib.c should not refer to canon variable addresses directly, because they might vary between firmware versions. Hardware addresses (like raw and viewport) should be fine since as far as we know they are the same for every firmware version of a given model.

Just to be clear, I don't think recreview_hold can affect the correctness of the zebra display, only when it is shown or not. I would expect the viewport/bitmap changes were what affected the zebra?

If I turn on the camera with the pictures on the SD card, with the old 'recreview_hold', with zebra indicator is shown and some garbage. If the camera is on without pictures on the SD card garbage is not shown, to the first image.Also if I delete most recently taken picture, with the next half-press, zebra is shown without garbage.This is why I doubted on the problem with 'recreview_hold'With the new 'recreview_hold' garbage was never shown.

Just to be clear, I don't think recreview_hold can affect the correctness of the zebra display, only when it is shown or not. I would expect the viewport/bitmap changes were what affected the zebra?

If I turn on the camera with the pictures on the SD card, with the old 'recreview_hold', with zebra indicator is shown and some garbage. If the camera is on without pictures on the SD card garbage is not shown, to the first image.Also if I delete most recently taken picture, with the next half-press, zebra is shown without garbage.This is why I doubted on the problem with 'recreview_hold'With the new 'recreview_hold' garbage was never shown.

The recreview_hold variable should only be one when the camera in post-shoot review, controlled by the "Review" setting in the Canon menu. It should not be 1 in playback mode.

The "Show OSD in review" CHDK setting should control whether the CHDK OSD is shown in this review.

An incorrect address for recreview_hold could cause the zebra to be shown when it wouldn't otherwise be (e.g. if it were 1 in playback, perhaps) and might cause a corrupt zebra to show if there were other problems, but really shouldn't be able to have any other effect on the content of the zebra.

If you want to check that recreview_hold behaves correctly, you can display it in the DEBUG_PRINT_TO_LCD ifdef section in core/main.c. This will draw regardless of whether the normal OSD would be shown.

@blackholeIf you still have the camera and have time, can you test the patch below? I think it's correct, but I'd like to hear confirmation.Since startup files are affected, please test that the sx410 build still boots correctly, and also that an ixus160 binary built from the same source blinks an LED rather than silently crashing.

@blackholeIf you still have the camera and have time, can you test the patch below? I think it's correct, but I'd like to hear confirmation.Since startup files are affected, please test that the sx410 build still boots correctly, and also that an ixus160 binary built from the same source blinks an LED rather than silently crashing.