* Konstantin Sobolev <konstantin.sobolev at gmail.com> [2009-04-03 17:00:36-0400]
> Hello,
>> Could somebody review my attempt to write a layout and tell if it's
> worth including in contrib?
Sure, it seems to be useful.
There are several wishes to your code:
1. All non-trivial top-level functions should be documented (such as
swap, forwardToFocused etc.)
2. If you use some function from a different module (like
'differentiate' from Combo) you shouldn't copy-paste its code;
instead prepare a separate patch which adds that function to export
list and explain where you use that function in the patch
description. Later that function may be also moved to some module in
the Util section.
Again, those functions (differentiate and broadcastPrivate from
Combo) are not documented there. Could you please write documentation
for them if you use them?
3. You shouldn't advise to import XMonad.Util.WindowProperties; instead
you should re-export needed things (or even the whole module) from
your module. See XMonad.Layout.IM for example.
Sorry for a late response and thanks for your work!
--
Roman I. Cheplyaka (aka Feuerbach @ IRC)
http://ro-che.info/docs/xmonad.hs