Description

The description for "Enable conditional access" currently says:
"When enabled, this lets you set conditions (based on date, grade, or completion) that control whether an activity can be accessed."

This suggests that conditional access is available for activities but not necessarily for resources. I would suggest to change the text and mention resources as well. I don't think we have a noun that would cover both "activity" and "resource", so the text could simply be:
"When enabled, this lets you set conditions (based on date, grade, or completion) that control whether an activity/resource can be accessed."

I agree with Tomasz that language string could be improved by mentioning resources, though I'd suggest the following wording as slightly easier to understand:

When enabled, this lets you set conditions (based on date, grade, or completion) that control whether an activity or resource can be accessed.

I don't know why the issue was labeled as 'patch' or set as major priority. As it's an en language pack improvement, I'm setting the component as 'Language' and will move it to MDL-29160 together with other language pack improvements.

Helen Foster
added a comment - 22/Feb/12 10:59 PM Hi Dan,
I agree with Tomasz that language string could be improved by mentioning resources, though I'd suggest the following wording as slightly easier to understand:
When enabled, this lets you set conditions (based on date, grade, or completion) that control whether an activity or resource can be accessed.
I don't know why the issue was labeled as 'patch' or set as major priority. As it's an en language pack improvement, I'm setting the component as 'Language' and will move it to MDL-29160 together with other language pack improvements.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

Dan Poltawski
added a comment - 19/Apr/12 9:57 PM The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao

Eloy Lafuente (stronk7)
added a comment - 27/Apr/12 11:13 PM This has been near becoming rejected, because it's not the best code you are able to produce.
But, luckily, at the end, it has landed and has been spread to all repos out there.
Many thanks and, don't forget it, keep improving your skills, you can!
Closing, ciao