http://codereview.chromium.org/20334/diff/1/5
File chrome/browser/cocoa/sad_tab_view.h (right):
http://codereview.chromium.org/20334/diff/1/5#newcode18
Line 18: - (id)initWithFrame:(NSRect)frame;
On 2009/02/12 22:50:34, Avi wrote:
> On 2009/02/12 22:40:21, pink wrote:
> > inherited, no need to include in public API.
>
> True, but it's the designated initializer.
i guess, though you don't say that in a comment. If it's obvious because it's an
NSView subclass, then omitting it would still be obvious.
http://codereview.chromium.org/20334/diff/1/4
File chrome/browser/cocoa/sad_tab_view.mm (right):
http://codereview.chromium.org/20334/diff/1/4#newcode29
Line 29: // Layout
On 2009/02/12 22:50:34, Avi wrote:
> On 2009/02/12 22:40:21, pink wrote:
> > can we not just load this view from the nib?
>
> We want a nib for this view? I ported the Windows view code as it was simple
> enough, and would match.
I just figured it'd be easier (less code), but maybe we should be nib adverse
for l10n reasons?
http://codereview.chromium.org/20334/diff/1/7
File chrome/chrome.xcodeproj/project.pbxproj (right):
http://codereview.chromium.org/20334/diff/1/7#newcode2391
Line 2391: 824FC14E0F44C56A000299E5 /* sadtab.png */ = {isa = PBXFileReference;
lastKnownFileType = image.png; name = sadtab.png; path = theme/sadtab.png;
sourceTree = "<group>"; };
On 2009/02/12 22:50:34, Avi wrote:
> On 2009/02/12 22:40:21, pink wrote:
> > maybe file a bug that we want a PDF for this?
>
> I thought the idea was that it was an ugly bitmap, like the Sad Mac. That's a
> design issue. Who designed this page?
ugly or not, it should still probably scale gracefully. maybe the png is
sufficient, i dunno.

brettw

http://codereview.chromium.org/20334/diff/1/2 File chrome/browser/tab_contents/web_contents_view_mac.mm (right): http://codereview.chromium.org/20334/diff/1/2#newcode22 Line 22: NotificationService::current()->AddObserver( Can you use the NotificationRegistrar object instead? ...

On 2009/02/13 21:38:12, brettw wrote:
> Note for the future: it would be better to call this ScopedCFTypeRef to match
> Google style. scoped_ptr is from Boost so we keep the name.
OK; out of scope for this review.