This would be good to check before submitting a patch, to ensure the code formatting is consistent and valid

davsclaus:~/workspace/camel/camel-core$ mvn compile -Psourcecheck[INFO] Scanning for projects...[INFO][INFO] ------------------------------------------------------------------------[INFO] Building Camel :: Core 2.13-SNAPSHOT[INFO] ------------------------------------------------------------------------[INFO][INFO] — maven-bundle-plugin:2.3.7:cleanVersions (versions) @ camel-core —[INFO][INFO] — maven-checkstyle-plugin:2.9.1:checkstyle (validate) @ camel-core —[INFO] Starting audit...
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:23: Wrong order for 'java.io.File' import.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:20: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:57: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:42:68: ')' is preceded with whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:20: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:57: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:50:72: ')' is preceded with whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:20: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:57: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:59:72: ')' is preceded with whitespace.
Audit done.

Claus Ibsen
added a comment - 12/Sep/13 08:24 - edited There were a couple of checkstyle issues which I will fix
You can read about how to build with CS
http://camel.apache.org/building.html
This would be good to check before submitting a patch, to ensure the code formatting is consistent and valid
davsclaus:~/workspace/camel/camel-core$ mvn compile -Psourcecheck
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Camel :: Core 2.13-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] — maven-bundle-plugin:2.3.7:cleanVersions (versions) @ camel-core —
[INFO]
[INFO] — maven-checkstyle-plugin:2.9.1:checkstyle (validate) @ camel-core —
[INFO] Starting audit...
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:23: Wrong order for 'java.io.File' import.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:20: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:57: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:42:68: ')' is preceded with whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:20: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:57: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:50:72: ')' is preceded with whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:20: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:57: ',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:59:72: ')' is preceded with whitespace.
Audit done.

James Carman
added a comment - 12/Sep/13 11:51 Thanks for the tip, Claus. I was having an awful time with the full build on my machine. I'll try to work through those issues and get started on more patches. Glad I could help out!