Comment on attachment 56151[details]
Periodically try to reset a lost IDirect3DDevice9 until we succeed
> - resetDevice();
> + resetDevice(ChangedWindowSize);
Is it worth asserting that this call returns true?
r+

(In reply to comment #3)
> (From update of attachment 56151[details])
> > - resetDevice();
> > + resetDevice(ChangedWindowSize);
>
> Is it worth asserting that this call returns true?
No. Resetting might fail at this point (e.g., if the device became lost sometime since the last time we rendered), so we can't assert that it doesn't. But we don't need to worry here whether it failed or not; if it did fail, we'll try to reset again before we next render. I'll add a comment about this.
Thanks for the review!