Created attachment 618053[details][diff][review]
patch v1: only enable the runtime for Firefox
1. configure.in enables the runtime for Windows and Mac by defining MOZ_WEBAPP_RUNTIME for those target OSes;
case "${target}" in
*darwin*)
ACCESSIBILITY=
MOZ_WEBAPP_RUNTIME=1
;;
*)
ACCESSIBILITY=1
;;
esac
case "$target_os" in
mingw*)
NS_ENABLE_TSF=1
AC_DEFINE(NS_ENABLE_TSF)
MOZ_WEBAPP_RUNTIME=1
;;
esac
2. only Firefox builds webapprt/ (via its browser/build.mk);
ifdef MOZ_WEBAPP_RUNTIME
tier_app_dirs += webapprt
endif
3. toolkit/mozapps/installer/packager.mk tries to package the runtime if MOZ_WEBAPP_RUNTIME is defined, regardless of what was built;
4. `make package` fails for XULRunner because webapprt/ wasn't built.
The solution seems obvious: only enable the runtime for Firefox. We could test for MOZ_BUILD_APP=browser in configure.in, but project-specific defines are what confvars.sh is for. Here's a patch. Tryserver run:
https://tbpl.mozilla.org/?tree=Try&noignore=1&rev=cd8a979582d2
Dave: the changes are in configure.in and browser/confvars.sh. Are you ok to review this, or should I get a Build Config peer like bsmedberg to review it?