hadoop-yarn-issues mailing list archives

[jira] [Commented] (YARN-252) Unmanaged AMs should not have to set the ContainerLaunchContext

Date

Wed, 05 Dec 2012 23:15:58 GMT

[ https://issues.apache.org/jira/browse/YARN-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510887#comment-13510887
]
Bikas Saha commented on YARN-252:
---------------------------------
I think it would be good to add the assert in the other places too. e.g. to catch a bug when
context is set for the app but not in the attempt because of some new code bug.
The other thing I am not sure I understand is the ACL's bit. What are the use cases for these
ACL's. If they are needed to be sent by the client to the RM then dont we need the submission
context to pass the ACL's? From what I see the client passes ACL's to the RM via the app submission
context, so that the RM can pass it onto the attempt during attempt registration. Now say
we are going to use unamanged AM for debugging. Ideally, the AM should have the same code
path for receiving ACL's in managed and unmanaged mode, right? And that currently is getting
ACL's from the registerAM response. If we remove the context completely then how do we pass
ACL's around in the unmanaged case? If this is correct then perhaps instead of removing context
from the launcher we might want to improve it to accept ACL's and add it to the context. In
general I am thinking of having 1 client allow users to launch apps, in managed or unmanaged
mode. I may be missing something. So you might have to educate me here :P
bq. and in fact requiring that one be set is very confusing for YARN application writers.
I am not clear why application writers would need to do this. Application writers need to
think about setting context for containers and not AM's themselves, dont they?
> Unmanaged AMs should not have to set the ContainerLaunchContext
> ---------------------------------------------------------------
>
> Key: YARN-252
> URL: https://issues.apache.org/jira/browse/YARN-252
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications
> Affects Versions: 2.0.2-alpha
> Reporter: Tom White
> Assignee: Tom White
> Attachments: YARN-252.patch, YARN-252.patch
>
>
> Not calling ApplicationSubmissionContext#setAMContainerSpec causes a NPE, even though
the container is not used (since the AM doesn't run in a managed YARN container).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira