Details

Description

While it is simple to construct an erlang thrift client that uses a framed transport, there is no simple option to do the same with an erlang thrift server.
I'm attaching a patch that adds this functionality.

Ben Taitelbaum
added a comment - 04/Sep/09 20:15 I thought I had configured emacs to replace tabs with whitespace when saving, but I'll take another look.
I see your point about true/false as opposed to true/_ – it's better to get a badmatch error than to match on, say, '1' (although that won't happen when I add the is_boolean guard).
I'll make these changes and upload a new patch.

Todd Lipcon
added a comment - 04/Sep/09 19:58 Small style nits:
Still seems to be a tab introduced in the record definition
I'd like to see an is_boolean guard for the parse_options clause
Similarly, instead of "case Framed of true -> ...; _ -> ... end" use "false" for the second clause
Aside from that, looks good, assuming you've done some tests and it works (I've never tested a framed server in Erlang). Thanks, Ben!