Comments

From: Gustavo Padovan <padovan@profusion.mobi>
Date: Sat, 3 Mar 2012 13:46:55 -0300
> This is something we can't do.
Then I cannot pull from you.
I gave you guys a one-off free pass last time around when I took
you stuff in via John's last wireless pull request.
That was your opportunity to start doing things correct yet not
be inconveniences that one time.
But if I just keep pulling from you, that sends absolutely the
message. I am serious and you must start making your code fit
my requirements for suitability.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

From: Gustavo Padovan <padovan@profusion.mobi>
Date: Sat, 3 Mar 2012 13:46:55 -0300
> Changing only the new code will put the Bluetooth subsystem in a> inconsistent coding style with different styles through the> subsystem.
Which btw would be perfectly fine, this is how we gradually fix
coding style in other areas of the tree too. So don't use crap
like this as an excuse for not doing the right thing.
Requiring a big "fix all the coding style" patch before starting to do
things properly in small increments first is completely bogus.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Sat, 2012-03-03 at 14:47 -0500, David Miller wrote:
> From: Gustavo Padovan <padovan@profusion.mobi>> Date: Sat, 3 Mar 2012 13:46:55 -0300> > > Changing only the new code will put the Bluetooth subsystem in a> > inconsistent coding style with different styles through the> > subsystem.> > Which btw would be perfectly fine, this is how we gradually fix> coding style in other areas of the tree too. So don't use crap> like this as an excuse for not doing the right thing.> > Requiring a big "fix all the coding style" patch before starting to do> things properly in small increments first is completely bogus.
Style conformity is important to people for lots of
different reasons.
It's your choice but I personally think you should
give the bluetooth folk a chance to change their style
in a single largish whitespace commit immediately post
3.4 akin to the recent isdn one you just pulled.
If the bluetooth folk want help, I do have scripts
that would do a pretty decent job and make all
the git blame -w changes transparent.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

From: Joe Perches <joe@perches.com>
Date: Sat, 03 Mar 2012 12:04:20 -0800
> It's your choice but I personally think you should> give the bluetooth folk a chance to change their style> in a single largish whitespace commit immediately post> 3.4 akin to the recent isdn one you just pulled.
They didn't just continue to use existing coding style, they also
screwed up things that were done correctly.
The struct member tabbing thing is just one example.
I already gave them a free one-time pull even though I disagreed with
what was in their tree. I'm not going to continually review new code
that isn't styled properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html