2165812012-08-09 10:54:00 +0000Widget should implement Lookup.Provider2012-12-09 06:17:23 +0000111UnclassifiedplatformGraph7.1.2AllAllRESOLVEDFIXEDAPI, API_REVIEW_FASTP4normal7.31bcallebautjhavlinapireviewsissuesENHANCEMENT0oldest_to_newest11824730bcallebaut2012-08-09 10:54:23 +0000The Widget class has a getLookup() method but not implements Lookup.Provider.
This should be added even if the lookup is not used anywhere.
Related discussion can be found at bug 209609
A uses I see for lookup is the same kind of uses as for a Node.
1) With a constructor where you can pass the lookup, you can for example provide actions, border, layout.
2) An action can use the layout to find out if a given functionality is supported by the widget (rotating it,...)
Only thing to be changed in Widget.java is
public class Widget implements Accessible {
by
public class Widget implements Accessible, Lookup.Provider {
I can supply a patch if needed.11868561123721jhavlin2012-08-30 09:01:47 +0000Created attachment 123721
Proposed Patch
Patch with change suggested by bcallebaut. Thank you!11868592jhavlin2012-08-30 09:04:12 +0000Please review. Thanks.12177633bcallebaut2012-11-26 14:33:19 +0000(In reply to comment #2)
> Please review. Thanks.
For me it is fine12182104jhavlin2012-11-27 15:30:17 +0000If there are no objections, I'll integrate on Thursday.12191505jhavlin2012-11-29 16:18:08 +0000Integrated as http://hg.netbeans.org/core-main/rev/8607c24263cb12199276quality2012-12-02 03:05:52 +0000Integrated into 'main-golden', will be available in build *201212020001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/8607c24263cb
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #216581: Widget should implement Lookup.Provider12223917businesswifi2012-12-09 06:17:23 +0000SPAM - Removed by Administrator1237212012-08-30 09:01:00 +00002012-08-30 09:01:47 +0000Proposed Patchvisual_widget_lookup_provider.difftext/plain2388jhavlinIyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBQYXJlbnQgZGY5NGM5YmJmZGM2MzFmZDAwOTIyZDMyMjBl
OTQ3YTIwMTI2NmJiNAojMjE2NTgxOiBXaWRnZXQgc2hvdWxkIGltcGxlbWVudCBMb29rdXAuUHJv
dmlkZXIKCmRpZmYgLS1naXQgYS9hcGkudmlzdWFsL2FwaWNoYW5nZXMueG1sIGIvYXBpLnZpc3Vh
bC9hcGljaGFuZ2VzLnhtbAotLS0gYS9hcGkudmlzdWFsL2FwaWNoYW5nZXMueG1sCisrKyBiL2Fw
aS52aXN1YWwvYXBpY2hhbmdlcy54bWwKQEAgLTc1Nyw2ICs3NTcsMjEgQEAKICAgICAgICAgICAg
IDxjbGFzcyBwYWNrYWdlPSJvcmcubmV0YmVhbnMuYXBpLnZpc3VhbC5ncmFwaC5sYXlvdXQiIG5h
bWU9IkdyYXBoTGF5b3V0U3VwcG9ydCIgbGluaz0ieWVzIi8+CiAgICAgICAgICAgICA8aXNzdWUg
bnVtYmVyPSIxNzg3MDUiLz4KICAgICAgICAgPC9jaGFuZ2U+CisgICAgICAgIDxjaGFuZ2U+Cisg
ICAgICAgICAgICA8YXBpIG5hbWU9ImdlbmVyYWwiLz4KKyAgICAgICAgICAgIDxzdW1tYXJ5Pldp
ZGdldCBJbXBsZW1lbnRzIExvb2t1cC5Qcm92aWRlcjwvc3VtbWFyeT4KKyAgICAgICAgICAgIDx2
ZXJzaW9uIG1ham9yPSIyIiBtaW5vcj0iMzQiLz4KKyAgICAgICAgICAgIDxkYXRlIGRheT0iMzAi
IG1vbnRoPSI4IiB5ZWFyPSIyMDEyIi8+CisgICAgICAgICAgICA8YXV0aG9yIGxvZ2luPSJqaGF2
bGluIi8+CisgICAgICAgICAgICA8Y29tcGF0aWJpbGl0eSBhZGRpdGlvbj0ieWVzIi8+CisgICAg
ICAgICAgICA8ZGVzY3JpcHRpb24+CisgICAgICAgICAgICAgICAgQ2xhc3MgPGNvZGU+V2lkZ2V0
PC9jb2RlPiBpbXBsZW1lbnRzIGludGVyZmFjZQorICAgICAgICAgICAgICAgIDxjb2RlPkxvb2t1
cC5Qcm92aWRlcjwvY29kZT4uIEl0IGFscmVhZHkgY29udGFpbnMgbWV0aG9kCisgICAgICAgICAg
ICAgICAgPGNvZGU+Z2V0TG9va3VwKCk8L2NvZGU+LgorICAgICAgICAgICAgPC9kZXNjcmlwdGlv
bj4KKyAgICAgICAgICAgIDxjbGFzcyBwYWNrYWdlPSJvcmcubmV0YmVhbnMuYXBpLnZpc3VhbC53
aWRnZXQiIG5hbWU9IldpZGdldCIvPgorICAgICAgICAgICAgPGlzc3VlIG51bWJlcj0iMjE2NTgx
Ii8+CisgICAgICAgIDwvY2hhbmdlPgogICAgIDwvY2hhbmdlcz4KIAogICAgIDxodG1sY29udGVu
dHM+CmRpZmYgLS1naXQgYS9hcGkudmlzdWFsL21hbmlmZXN0Lm1mIGIvYXBpLnZpc3VhbC9tYW5p
ZmVzdC5tZgotLS0gYS9hcGkudmlzdWFsL21hbmlmZXN0Lm1mCisrKyBiL2FwaS52aXN1YWwvbWFu
aWZlc3QubWYKQEAgLTEsNiArMSw2IEBACiBNYW5pZmVzdC1WZXJzaW9uOiAxLjAKIE9wZW5JREUt
TW9kdWxlOiBvcmcubmV0YmVhbnMuYXBpLnZpc3VhbAogT3BlbklERS1Nb2R1bGUtTG9jYWxpemlu
Zy1CdW5kbGU6IG9yZy9uZXRiZWFucy9tb2R1bGVzL3Zpc3VhbC9yZXNvdXJjZXMvQnVuZGxlLnBy
b3BlcnRpZXMKLU9wZW5JREUtTW9kdWxlLVNwZWNpZmljYXRpb24tVmVyc2lvbjogMi4zMworT3Bl
bklERS1Nb2R1bGUtU3BlY2lmaWNhdGlvbi1WZXJzaW9uOiAyLjM0CiBBdXRvVXBkYXRlLUVzc2Vu
dGlhbC1Nb2R1bGU6IHRydWUKIApkaWZmIC0tZ2l0IGEvYXBpLnZpc3VhbC9zcmMvb3JnL25ldGJl
YW5zL2FwaS92aXN1YWwvd2lkZ2V0L1dpZGdldC5qYXZhIGIvYXBpLnZpc3VhbC9zcmMvb3JnL25l
dGJlYW5zL2FwaS92aXN1YWwvd2lkZ2V0L1dpZGdldC5qYXZhCi0tLSBhL2FwaS52aXN1YWwvc3Jj
L29yZy9uZXRiZWFucy9hcGkvdmlzdWFsL3dpZGdldC9XaWRnZXQuamF2YQorKysgYi9hcGkudmlz
dWFsL3NyYy9vcmcvbmV0YmVhbnMvYXBpL3Zpc3VhbC93aWRnZXQvV2lkZ2V0LmphdmEKQEAgLTkz
LDcgKzkzLDcgQEAKICAqIEBhdXRob3IgRGF2aWQgS2FzcGFyCiAgKi8KIC8vIFRPRE8gLSBTaG91
bGQgV2lkZ2V0IGJlIGFuIGFic3RyYWN0IGNsYXNzPwotcHVibGljIGNsYXNzIFdpZGdldCBpbXBs
ZW1lbnRzIEFjY2Vzc2libGUgeworcHVibGljIGNsYXNzIFdpZGdldCBpbXBsZW1lbnRzIEFjY2Vz
c2libGUsIExvb2t1cC5Qcm92aWRlciB7CiAKICAgICBzdGF0aWMgZmluYWwgU3RyaW5nIE1FU1NB
R0VfTlVMTF9CT1VORFMgPSAiU2NlbmUudmFsaWRhdGUgd2FzIG5vdCBjYWxsZWQgYWZ0ZXIgbGFz
dCBjaGFuZ2UuIFdpZGdldCBpcyBub3QgdmFsaWRhdGVkLiBTZWUgZmlyc3QgUS9BIGF0IGh0dHA6
Ly9ncmFwaC5uZXRiZWFucy5vcmcvZmFxLmh0bWwgcGFnZS4iOwogCkBAIC00OTMsNiArNDkzLDcg
QEAKICAgICAgKiBSZXR1cm5zIGEgbG9va3VwIG9mIHRoZSB3aWRnZXQuCiAgICAgICogQHJldHVy
biB0aGUgbG9va3VwCiAgICAgICovCisgICAgQE92ZXJyaWRlCiAgICAgcHVibGljIExvb2t1cCBn
ZXRMb29rdXAgKCkgewogICAgICAgICByZXR1cm4gTG9va3VwLkVNUFRZOwogICAgIH0K