-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

Hadoop QA
added a comment - 14/Oct/11 19:17 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499071/mr-3187.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 20 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1019//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1019//console
This message is automatically generated.

There's a couple more threads in the NM - ContainerMonitorImpl, NodeStatusUpdaterImpl and also the AsyncDispatcher. Does it make sense to change the log4j unit test configuration to include thread names ?
Would definitely like to see this go in.

Siddharth Seth
added a comment - 14/Oct/11 20:30 There's a couple more threads in the NM - ContainerMonitorImpl, NodeStatusUpdaterImpl and also the AsyncDispatcher. Does it make sense to change the log4j unit test configuration to include thread names ?
Would definitely like to see this go in.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

Hadoop QA
added a comment - 14/Oct/11 21:14 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499093/mr-3187.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 20 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1025//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1025//console
This message is automatically generated.

Hadoop QA
added a comment - 15/Oct/11 03:34 +1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499119/mr3187_increment.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1031//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1031//console
This message is automatically generated.