*[PATCH 0/3] Making the search indexes optional@ 2018-07-17 23:27 ebiederm
2018-07-17 23:30 ` [PATCH 1/3] SearchIdx.pm: Make indexing search positions optional Eric W. Biederman
` (3 more replies)0 siblings, 4 replies; 17+ messages in thread
From: ebiederm @ 2018-07-17 23:27 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
Here is the code to make the Xapian search indexes optional.
The first patch makes the term position database optional.
The second patch makes anything in Xapian optional.
Finally the last patch adds a config option.
At the end of the day it all looks simple and straight forward so I feel
good about the code. At the very least it looks like a good starting
point.
What this code does not do is make the Xapian code modules optional. As
that is more involved, and there is not much reward for that. With a
little cleverness in moving around code that is probably possible in a
follow change.
Eric W. Biederman (3):
SearchIdx.pm: Make indexing search positions optional
SearchIdx: Add the mechanism for making all Xapian indexing optional
SearchIdx: Allow the amount of indexing be configured
lib/PublicInbox/Config.pm | 2 +-
lib/PublicInbox/SearchIdx.pm | 255 +++++++++++++++++++++++--------------------
2 files changed, 137 insertions(+), 120 deletions(-)
^permalinkrawreply [flat|nested] 17+ messages in thread

*Re: [PATCH 0/3] Making the search indexes optional
2018-07-17 23:27 [PATCH 0/3] Making the search indexes optional ebiederm
` (2 preceding siblings ...)
2018-07-17 23:30 ` [PATCH 3/3] SearchIdx: Allow the amount of indexing be configured Eric W. Biederman
@ 2018-07-18 10:17 ` Eric Wong3 siblings, 0 replies; 17+ messages in thread
From: Eric Wong @ 2018-07-18 10:17 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: meta
"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> Here is the code to make the Xapian search indexes optional.
>
> The first patch makes the term position database optional.
> The second patch makes anything in Xapian optional.
> Finally the last patch adds a config option.
>
> At the end of the day it all looks simple and straight forward so I feel
> good about the code. At the very least it looks like a good starting
> point.
Thanks for your work on this. I have a few minor comments in
a separate message. I expect you'll have tests and maybe
an option for public-inbox-index eventually?
> What this code does not do is make the Xapian code modules optional. As
> that is more involved, and there is not much reward for that. With a
> little cleverness in moving around code that is probably possible in a
> follow change.
Not required; but it could be nice-to-have for portability and
ease-of-installation (probably for older distros and
non-GNU/Linux platforms).
Off the top of my head, there's also some places in NNTP.pm
where it needlessly uses Search.pm wrappers instead of using
Over.pm interfaces directly.
^permalinkrawreply [flat|nested] 17+ messages in thread