Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs

From:

Guillem Jover

Subject:

Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs

Date:

Tue, 30 Aug 2011 02:43:03 +0200

User-agent:

Mutt/1.5.21 (2010-09-15)

On Sat, 2011-08-27 at 00:53:41 +0200, Samuel Thibault wrote:
> Guillem Jover, le Thu 25 Aug 2011 15:22:38 +0200, a écrit :
> > * linux/dev/kernel/sched.c (cdrom_sleep): Move to ...
> > * linux/src/drivers/block/ide-cd.c: ... here, replace [!MACH]
> > definition, and remove conditionals.
>
> I disagree.
>
> > void
> > -cdrom_sleep (int t)
> > -{
> > - int xxx;
> > -
> > - assert_wait ((event_t) &xxx, TRUE);
> > - thread_set_timeout (t);
> > - schedule ();
> > -}
>
> This is really mach-specific glue code, so it should remain there or in
> glue/
If the original file has to be modified anyway to disable the function
I don't see the point in arbitrarily moving the function somewhere
else, more so when it forces the function to be global when it should
be static. I agree that if a whole file needs writting from scratch
then the code belongs in glue/ in any file that makes sense.
I'm following up with a revised version of the patch, which makes it
easier to track modifications to the original. If you still do not
agree then I guess it would make sense to update ‘linux/dev/README’.
regards,
guillem