Conversation

In order to get the accounts_quickbooks and associated quickbooks package working, I had to get access to this realmId parameter that comes back in the oauth request. This seemed like simple and safe way to do it (and the oauth2 code already has access to the query parameter).

This comment has been minimized.

@estark37 (Slava suggested I forward to you) - is this something you could take a look at? I'm pretty sure I need this code change to make the integration with quickbooks work, but maybe there's something I'm missing. Here's the rest of the quickbooks integration, if that helps.

This comment has been minimized.

Hey @andylash, sorry for the slow response! This looks reasonable to me, but could we stick it in an options object instead? i.e. make the second argument { query: query }, instead of just query. That way we won't have to keep sticking arguments on the end if we end up needing to pass more information. Thanks!

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.