> 3.3-stable review patch. If anyone has any objections, please let me know.[...]> commit dc75ce9d929aabeb0843a6b1a4ab320e58ba1597 upstream.>> This patch (as1542) changes the criterion ehci-hcd uses to tell when> it needs to resume the controller's root hub. A resume is needed when> a port status change is detected, obviously, but only if the root hub> is currently suspended.

Here's a blind backport to 3.0-stable (for next week, perhaps) thataccounts for the lack of v3.2-rc1~183^2~179^2~19 ("USB: EHCI: removeusages of hcd->state", 2011-08-18).

This patch (as1542) changes the criterion ehci-hcd uses to tell whenit needs to resume the controller's root hub. A resume is needed whena port status change is detected, obviously, but only if the root hubis currently suspended.

Right now the driver tests whether the root hub is running, and thatis not the correct test. In particular, if the controller has diedthen the root hub should not be restarted. In addition, some buggyhardware occasionally requires the root hub to be running andsending out SOF packets even while it is nominally supposed to besuspended.

In the end, the test needs to be changed. Rather than checking whetherthe root hub is currently running, the driver will now check whetherthe root hub is currently suspended. This will yield the correctbehavior in all cases.