bug#3863: 23.1.50; possible save-match-data in copyright.el

From:

Kevin Ryde

Subject:

bug#3863: 23.1.50; possible save-match-data in copyright.el

Date:

Thu, 16 Jul 2009 10:05:39 +1000

User-agent:

Gnus/5.110011 (No Gnus v0.11) Emacs/22.3 (gnu/linux)

In recent copyright.el I noticed copyright-update using the match data
after a y-or-n-p query. Is that a good idea?
When running it in emacs 22 I seemed to sometimes get the match data
clobbered by y-or-n-p. I never tracked down the circumstances, but
wondered if copyright.el shouldn't rely on what an input func like
y-or-n-p could do, per diff below.
In GNU Emacs 23.1.50.1 (i586-pc-linux-gnu, GTK+ Version 2.16.4)
of 2009-07-12 on blah.blah
configured using `configure 'CFLAGS=-O -g' '--prefix=/down/emacs/b/inst'
'--with-x-toolkit=gtk''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_AU
value of $XMODIFIERS: nil
locale-coding-system: iso-latin-1-unix
default-enable-multibyte-characters: t
2009-07-16 Kevin Ryde <address@hidden>
* emacs-lisp/copyright.el (copyright-update): save-match-data across
y-or-n-p, for safety.