WordPress Trac: {6} Next Major Release, Workflow Orientedhttps://core.trac.wordpress.org/report/6
Trac Report - {{{
#!span class="create-new-ticket button button-large button-primary"
[https://wordpress.org/support/bb-login.php?redirect_to=https://core.trac.wordpress.org/newticket Create a new ticket]
}}}
* Active tickets slated for the next major release, workflow oriented
* Sort by component, type, summary
* Accepted tickets have an '*' appended to their owner's nameen-usWordPress Trachttps://core.trac.wordpress.org/chrome/site/your_project_logo.pnghttps://core.trac.wordpress.org/report/6
Trac v1.0.1#31721: "Add new" button bugdaniluk4000Sat, 21 Mar 2015 13:05:36 GMTWed, 25 Mar 2015 00:10:38 GMT<p>
I noticed a bug when using the new Theme Switcher in the Customizer. For large texts, such as the Russians, the button moves to the next line and looks disgusting.
</p>
daniluk4000https://core.trac.wordpress.org/ticket/31721
https://core.trac.wordpress.org/ticket/31721Report#24869: "All" in post list table is incorrectly selected in some filtered viewsenejMon, 29 Jul 2013 00:28:23 GMTWed, 25 Mar 2015 06:38:52 GMT<p>
When you are viewing the posts table and you have selected an author the all filter is incorrectly selected.
</p>
enejhttps://core.trac.wordpress.org/ticket/24869
https://core.trac.wordpress.org/ticket/24869Report#21848: A single space in the image caption breaks alignmentlufferSat, 08 Sep 2012 15:07:42 GMTFri, 27 Mar 2015 17:32:42 GMT<p>
If you add just a single space in the caption field of an image using the media uploader, it ignores any alignment settings.
</p>
<p>
The expected behaviour would mean that regardless of what is entered into the caption box, the image alignment should be honoured.
</p>
lufferhttps://core.trac.wordpress.org/ticket/21848
https://core.trac.wordpress.org/ticket/21848Report#31450: Add landmark roles to WordPress admin areasjoedolsonWed, 25 Feb 2015 19:25:34 GMTMon, 30 Mar 2015 15:51:03 GMT<p>
Right now, the WordPress admin pages have ARIA landmark roles available for navigation only. This patch adds role="main" to the wpcontent container and role="contentinfo" to the wpfooter container.
</p>
joedolsonhttps://core.trac.wordpress.org/ticket/31450
https://core.trac.wordpress.org/ticket/31450Report#30725: Add media modal - different select widthpavelevapTue, 16 Dec 2014 11:10:12 GMTThu, 05 Mar 2015 03:49:12 GMT<p>
When clicking "Add media", images are loading in modal window.
But there is different width when loading spinner appears.
When everything loaded, select field shrinks back and it is distracting.
Also, localized string is longer than English original and it is not visible the whole text.
</p>
<p>
See attached screenshot.
</p>
pavelevaphttps://core.trac.wordpress.org/ticket/30725
https://core.trac.wordpress.org/ticket/30725Report#31306: add_query_arg changes numerical argumentsLex_RobinsonThu, 12 Feb 2015 10:44:29 GMTThu, 19 Mar 2015 19:45:50 GMT<p>
I noticed this when I used '1=1' as a default query value to prevent a ? being prepended. If an argument passed to add_query_arg is a number, it gets replaced with an incrementing value. It doesn't re-order arguments or parse non-decimal numbers.
I suspect this is being caused by array_merge on line 782 of wp-includes/functions.php
</p>
<div class="code"><pre><span class="x">var_dump( add_query_arg( array( 'foo' =&gt; 'bar' ), '1=1' ) );
// string '0=1&amp;foo=bar' (length=11)
var_dump( add_query_arg( array( 'a' =&gt; 'c' ), '1=1&amp;a=b&amp;10=10' ) );
// string '0=1&amp;a=c&amp;1=10' (length=12)
var_dump( add_query_arg( array( '19' =&gt; '19' ), '20=20' ) );
// string '0=20&amp;1=19' (length=9)
var_dump( add_query_arg( array( '3e1' =&gt; '3' ), '0x1=1&amp;a=b&amp;010=2' ) );
// string '0x1=1&amp;a=b&amp;010=2&amp;3e1=3' (length=21)
</span></pre></div>Lex_Robinsonhttps://core.trac.wordpress.org/ticket/31306
https://core.trac.wordpress.org/ticket/31306Report#31322: Admin bar frontend search CSS fixesaferciaFri, 13 Feb 2015 19:03:21 GMTSat, 21 Mar 2015 11:17:56 GMT<p>
When the admin bar is displayed on the frontend, an additional search form appears on the right. The input field doesn't have an associated label (will open a separate ticket) but there are also some CSS glitches.
</p>
<ul><li>on focus: the blue lens is not shown in all browsers (appears just on hover)
</li><li>IE8: needs some love
</li></ul><p>
See screenshot before the patch:
modern browsers
IE8 search collapsed
IE8 search expanded
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/_SXVu_eybQ.png"><img src="https://cldup.com/_SXVu_eybQ.png" alt="https://cldup.com/_SXVu_eybQ.png" title="https://cldup.com/_SXVu_eybQ.png" /></a>
</p>
<p>
Screenshot after the patch:
modern browsers
IE8 search expanded
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/seRrHsBWNN.png"><img src="https://cldup.com/seRrHsBWNN.png" alt="https://cldup.com/seRrHsBWNN.png" title="https://cldup.com/seRrHsBWNN.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31322
https://core.trac.wordpress.org/ticket/31322Report#31345: Admin menu icon colors fixesaferciaMon, 16 Feb 2015 14:17:57 GMTSun, 29 Mar 2015 23:14:10 GMT<p>
After <a class="changeset" href="https://core.trac.wordpress.org/changeset/31422" title="Update the default admin color scheme for more unity and refinement.
This ...">r31422</a> IE 8 users will feel a bit blue :) See screenshot:
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/oAVakHF21e.png"><img src="https://cldup.com/oAVakHF21e.png" alt="https://cldup.com/oAVakHF21e.png" title="https://cldup.com/oAVakHF21e.png" /></a>
</p>
<p>
the icons color was: <tt>#999</tt> and changed in this
</p>
<pre class="wiki">#adminmenu div.wp-menu-image:before {
color: #00b9eb; &lt;-- light blue
color: rgba(240,245,250,0.6); &lt;-- rgba light grey
}
</pre><p>
and IE 8 doesn't support rgba so it will get the blue.
</p>
<p>
The proposed patch fixes also the icon color when tabbing (focus) the submenu items, this should pair the "focus" with the "hover" behavior. See before/after screenshot. Doesn't work in IE 8, just modern browsers.
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/EwZlqjPnVS.png"><img src="https://cldup.com/EwZlqjPnVS.png" alt="https://cldup.com/EwZlqjPnVS.png" title="https://cldup.com/EwZlqjPnVS.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31345
https://core.trac.wordpress.org/ticket/31345Report#30900: Admin menu is flickering when scrolling left or rightmindrunSun, 04 Jan 2015 16:00:29 GMTThu, 26 Mar 2015 01:33:58 GMT<p>
If you open WordPress' backend in the latest Safari version (8.0.2) on OS X you'll notice that the admin menu looks a bit buggy if you're trying to scroll left or right. So I started digging into the CSS code and found out that this is caused by some attributes on the <em>#adminmenuback</em>-element.
</p>
<p>
Currently, the element has the following attributes:
</p>
<pre class="wiki">#adminmenuback {
position: absolute;
top: 0;
bottom: 0;
z-index: -1;
}
</pre><p>
But If we would change the <strong>position</strong> to 'fixed' (like #adminmenuwrap already has it) and the <strong>z-index</strong> to '9980', the menu won't look buggy anymore if someone scrolls to the left or right. - I also tested the element's new behavior on mobile and in different browsers like Chrome, Opera and Firefox and everything looks fine.
</p>
<ul><li>Menu without fix: <a class="ext-link" href="http://quick.as/ov6bCaVg"><span class="icon">​</span>http://quick.as/ov6bCaVg</a>
</li><li>Menu with fix: <a class="ext-link" href="http://quick.as/VG1Qc6Qg"><span class="icon">​</span>http://quick.as/VG1Qc6Qg</a>
</li></ul><p>
Therefore this will be the new declaration for the named element:
</p>
<pre class="wiki">#adminmenuback {
position: fixed;
top: 0;
bottom: 0;
z-index: 9989;
}
</pre><p>
I would very much welcome it if someone could look after this problem. Thanks in advance!
</p>
mindrunhttps://core.trac.wordpress.org/ticket/30900
https://core.trac.wordpress.org/ticket/30900Report#29558: Alt+Shift shortcuts override character inputBalkanaSat, 06 Sep 2014 16:44:22 GMTMon, 30 Mar 2015 21:36:57 GMT<p>
I am using default wordpress editor for posts and I run into a issue when I want to write this char: " [ ".
I am from Croatia, and key combination for this is Alt Gr + F When I press that the editor goes full screen, what is really weird and I can't find a solution (I am forced to copy/paste that char from somewhere else).
</p>
Balkanahttps://core.trac.wordpress.org/ticket/29558
https://core.trac.wordpress.org/ticket/29558Report#31770: Better feedback after bulk updating plugins via shiny updatesjohnbillionWed, 25 Mar 2015 22:16:10 GMTSat, 28 Mar 2015 20:21:44 GMT<p>
Currently the UI feedback after bulk updating a bunch of plugins on the Plugins screen is sub-optimal. If all the plugins you're updating are below the fold, there's no UI feedback at all. Even if they're not, there's no visual confirmation near the button you've just clicked.
</p>
<p>
We should consider adding a confirmation message the same as the one you get without shiny updates. And scroll the user to the top of the screen post-update.
</p>
johnbillionhttps://core.trac.wordpress.org/ticket/31770
https://core.trac.wordpress.org/ticket/31770Report#31477: Build task is overwriting minified JS libraries with our uglified versioniseuldeFri, 27 Feb 2015 17:22:21 GMTThu, 26 Mar 2015 03:39:57 GMTiseuldehttps://core.trac.wordpress.org/ticket/31477
https://core.trac.wordpress.org/ticket/31477Report#26183: Calling quicktags *after* initial setup results in an empty toolbarPeterRKnightSat, 23 Nov 2013 22:32:44 GMTFri, 13 Mar 2015 09:16:06 GMT<p>
Quicktags.js has a limitation in that if you call quicktags on a textarea after it has been previously been initialized it fails to attach buttons.
</p>
<p>
To reproduce this bug, go to a post editing page and bring up the console and attempt to call quicktags on a textarea, like:
</p>
<pre class="wiki">quicktags({id:"metavalue", buttons: "strong,link,em"});
</pre><p>
The expected result is a quicktags toolbar with buttons, instead you get an empty toolbar. This is because of the following lines:
</p>
<pre class="wiki">if ( !qt.instances[0] ) {
qt.instances[0] = qt.instances[id];
_domReady( function(){ qt._buttonsInit(); } );
}
</pre><p>
Because qt.instances<a class="missing changeset" title="No changeset 0 in the repository">[0]</a> has been set, it fails to continue on to rendering the buttons on a new textarea.
</p>
<p>
This strikes me as a bug, or at least an unnecessary limitation. I stumbled against this when trying to add a quicktag enabled textarea dynamically.
</p>
PeterRKnighthttps://core.trac.wordpress.org/ticket/26183
https://core.trac.wordpress.org/ticket/26183Report#31651: Change Twemoji CDN to W.orgpentoMon, 16 Mar 2015 01:56:13 GMTTue, 31 Mar 2015 04:32:52 GMT<p>
This task is currently pending changes to the W.org CDN, it needs to be completed before 4.2.
</p>
pentohttps://core.trac.wordpress.org/ticket/31651
https://core.trac.wordpress.org/ticket/31651Report#29958: collapse menu keyboard accessibilityaferciaTue, 14 Oct 2014 18:11:27 GMTWed, 25 Mar 2015 19:35:28 GMT<p>
See also related <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29955" title="defect (bug): Section 508 issues found on WordPress 4.0 admin page. (closed: invalid)">#29955</a> point 1.
</p>
<p>
The "Collapse menu" item is not focusable and keyboard users can't collapse/expand the admin menu.
</p>
<p>
Some screen readers (tested with Firefox + NVDA) may announce it as "clickable" and you can activate it but it's still not focusable: you can't get to it using the Tab key, but only using the Arrow up and Arrow down keys.
Regardless, please consider that this issue is not just for screen reader users, they may found useless to collapse/expand the menu, but it's for all keyboard users: all the people who can't or don't want to use a pointing device. It would be nice to offer them a little improvement.
</p>
<p>
The best option here is to use a <tt>button</tt> element which <a class="ext-link" href="http://www.456bereastreet.com/archive/201302/making_elements_keyboard_focusable_and_clickable/"><span class="icon">​</span>natively supports mouse and keyboard interaction</a>
</p>
<p>
Quoting @joedolson at WordCamp Chicago 2014:
</p>
<blockquote class="citation">
<p>
"If it's supposed to act like a button, it should be a button."
</p>
</blockquote>
<p>
:) Buttons are mentioned also in the <a class="ext-link" href="https://make.wordpress.org/accessibility/draft-theme-review-accessibility-guidelines/"><span class="icon">​</span>accessibility guidelines for themes</a>
</p>
<ul><li>proposed patch also adds a hidden text "Expand menu" that is available just for screen readers when the menu is folded or auto-folded.
</li><li>about colors on hover and focus, tries to take into account the alternative color schemes which currently are a bit inconsistent, but this part is optional; which color should be used?
</li></ul><p>
In the screenshot below, see the current color on hover/focus in different color schemes: should use the submenu items color or its own color?
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/7zgMnvej9i.png"><img src="https://cldup.com/7zgMnvej9i.png" alt="https://cldup.com/7zgMnvej9i.png" title="https://cldup.com/7zgMnvej9i.png" /></a>
</p>
<p>
Needs testing, especially in IE9+.
Any thoughts welcome, especially from the accessibility team and mailing list.
</p>
aferciahttps://core.trac.wordpress.org/ticket/29958
https://core.trac.wordpress.org/ticket/29958Report#30344: Curly Quotes Missing for Strange InputmiqrogrooveFri, 14 Nov 2014 18:17:34 GMTSat, 28 Mar 2015 00:58:01 GMT<p>
wptexturize() gives unexpected results if an Administrator uses a post body like this:
</p>
<pre class="wiki">&lt;&gt; "Hello world" &lt;&gt;
</pre><p>
This was caused by a small mistake in the new regexp.
</p>
miqrogroovehttps://core.trac.wordpress.org/ticket/30344
https://core.trac.wordpress.org/ticket/30344Report#31294: Customizer no longer gracefully handles session expirationwestonruterWed, 11 Feb 2015 12:38:02 GMTMon, 30 Mar 2015 19:35:44 GMT<p>
Reported by ocean90:
</p>
<blockquote class="citation">
<p>
In <a class="changeset" href="https://core.trac.wordpress.org/changeset/31370" title="Customizer: Introduce an API to create WP_Customize_Settings for ...">r31370</a> you've changed <tt>doing_ajax()</tt> to return only true for <tt>defined( 'DOING_AJAX' ) &amp;&amp; DOING_AJAX</tt>, and not <tt>isset( $_POST['customized'] )</tt> anymore. This breaks the preview if you're logged out because you get a regular <tt>wp_die()</tt> with HTML instead of the <tt>0</tt>.
</p>
</blockquote>
<p>
<a class="ext-link" href="https://wordpress.slack.com/archives/core-customize/p1423601418000599"><span class="icon">​</span>https://wordpress.slack.com/archives/core-customize/p1423601418000599</a>
</p>
<p>
Issue introduced (at least partially) by changes introduced in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/30936" title="enhancement: Dynamically create WP_Customize_Settings for settings created on JS client (closed: fixed)">#30936</a>.
</p>
westonruterhttps://core.trac.wordpress.org/ticket/31294
https://core.trac.wordpress.org/ticket/31294Report#31791: Customizer Theme Switcher: Switch the details/live preview buttonscelloexpressionsFri, 27 Mar 2015 18:31:20 GMTMon, 30 Mar 2015 21:09:50 GMT<p>
Based on usability testing and feedback from almost everyone that's provided it. Let's get this in.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/31791
https://core.trac.wordpress.org/ticket/31791Report#31289: Customizer: theme switcher navigation streamliningfollettoWed, 11 Feb 2015 01:16:10 GMTSun, 29 Mar 2015 01:07:07 GMT<p>
The upcoming <a class="ext-link" href="https://make.wordpress.org/core/2015/02/03/customizer-theme-switcher-update-22/"><span class="icon">​</span>customizer theme switcher</a> has the navigation that while works well in term of information hierarchy with a slide in the opposite direction, has the various navigation element a bit mixed in terms of navigation (arrows directions, headers).
</p>
<p>
This ticket aims to address these issues.
</p>
follettohttps://core.trac.wordpress.org/ticket/31289
https://core.trac.wordpress.org/ticket/31289Report#31742: Customizer: use attachment ID to show current headersirbrilligMon, 23 Mar 2015 18:19:55 GMTFri, 27 Mar 2015 14:09:04 GMT<p>
<tt>api.HeaderTool.ChoiceView</tt> sets the current header image model (<tt>api.HeaderTool.currentHeader</tt>) by comparing the current image URL (<tt>api.get().header_image</tt>) to the model URL for each recently updated header image. This relies on the URLs being identical, which may not be the case if, for example, the value of <tt>api.get().header_image</tt> uses <tt>https</tt> and the value of the model's URL uses <tt>http</tt> (which is the case on WordPress.com).
</p>
<p>
I think it would be better to use the attachment ID to find the current header image. The attached patch modifies the check in <tt>api.HeaderTool.ChoiceView</tt> to compare the current image attachment ID (<tt>api.get().header_image_data.attachment_id</tt>) with the model attachment ID. Because sometimes the current header may not have an ID (eg: if it is set to <tt>random-uploaded-image</tt>), this also falls back to comparing the <tt>choice</tt> attribute.
</p>
sirbrillighttps://core.trac.wordpress.org/ticket/31742
https://core.trac.wordpress.org/ticket/31742Report#31388: Database Error During UpgrademiqrogrooveThu, 19 Feb 2015 19:20:45 GMTFri, 27 Mar 2015 16:41:10 GMT<p>
I used the Beta Tester plugin to update a test site from 4.0 to 4.2-alpha-31473. I was greeted with an error after the database upgrade step:
</p>
<pre class="wiki">WordPress database error: [Can't DROP 'slug'; check that column/key exists]
ALTER TABLE wp_terms DROP INDEX slug, ADD INDEX slug(slug(191))
</pre>miqrogroovehttps://core.trac.wordpress.org/ticket/31388
https://core.trac.wordpress.org/ticket/31388Report#31233: Dismissable admin noticesryanWed, 04 Feb 2015 18:28:57 GMTTue, 31 Mar 2015 08:28:35 GMT<p>
Let's make admin notices dismissable.
</p>
<p>
<a class="ext-link" href="https://make.wordpress.org/flow/2015/01/29/focus-and-admin-notices-macnchrome/"><span class="icon">​</span>https://make.wordpress.org/flow/2015/01/29/focus-and-admin-notices-macnchrome/</a>
</p>
<blockquote class="citation">
<p>
Admin notices result in empty space near the top of the screen when Focus is activated. Some notices, such as the upgrade network notice, do not fade away when Focused. Focus must reserve space for the notices so that they can be winked back in when unfocused. I’ve long wanted dismissable admin notices. Accommodating Focus seems like a good motivation to finally make notices dismissable. After saving a draft, being stuck with a padded header while Focused is annoying. Being able to click to dismiss notices would workaround this (rewriting the url to get rid of the message query arg would also be nice) .
</p>
</blockquote>
ryanhttps://core.trac.wordpress.org/ticket/31233
https://core.trac.wordpress.org/ticket/31233Report#30883: Duplicate post_class() for different categoriesSergeyBiryukovFri, 02 Jan 2015 00:24:10 GMTWed, 25 Mar 2015 19:15:38 GMT<ol><li>Create two categories, "Первая рубрика" and "Вторая рубрика". They will have the following slugs:
<pre class="wiki">%d0%b2%d1%82%d0%be%d1%80%d0%b0%d1%8f-%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0
%d0%bf%d0%b5%d1%80%d0%b2%d0%b0%d1%8f-%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0
</pre></li><li>Create a post in each category.
</li><li>Both posts will have a <tt>category--</tt> class.
</li></ol><p>
<tt>sanitize_html_class()</tt> uses a fallback value (term ID) if the resulting string is empty. It should do the same if the resulting string only contains hyphens.
</p>
SergeyBiryukovhttps://core.trac.wordpress.org/ticket/30883
https://core.trac.wordpress.org/ticket/30883Report#31798: Editor: switch undo and redo in RTLyoavfSun, 29 Mar 2015 11:35:54 GMTSun, 29 Mar 2015 18:40:29 GMT<p>
The undo and redo icons in RTL should we switched.
</p>
<p>
LTR:
<a class="ext-link" href="https://cloudup.com/cHOxlUfHbAp"><span class="icon">​</span>https://cloudup.com/cHOxlUfHbAp</a>
</p>
<p>
Current RTL:
<a class="ext-link" href="https://cloudup.com/cizBcGBMkCa"><span class="icon">​</span>https://cloudup.com/cizBcGBMkCa</a>
</p>
<p>
Proper RTL:
<a class="ext-link" href="https://cloudup.com/cSCyiF_HxMA"><span class="icon">​</span>https://cloudup.com/cSCyiF_HxMA</a>
</p>
yoavfhttps://core.trac.wordpress.org/ticket/31798
https://core.trac.wordpress.org/ticket/31798Report#31771: Emoji rendering in Windows XPaferciaThu, 26 Mar 2015 00:24:56 GMTTue, 31 Mar 2015 18:24:43 GMT<p>
See attached screenshots, tested on 4.2-beta2-31866
</p>
<p>
Latest Chrome:
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/FmCDwtW5Yk.png"><img src="https://cldup.com/FmCDwtW5Yk.png" alt="https://cldup.com/FmCDwtW5Yk.png" title="https://cldup.com/FmCDwtW5Yk.png" /></a>
</p>
<p>
Latest Fireox:
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/hq8PJWzZdl.png"><img src="https://cldup.com/hq8PJWzZdl.png" alt="https://cldup.com/hq8PJWzZdl.png" title="https://cldup.com/hq8PJWzZdl.png" /></a>
</p>
<p>
Tested also in IE 8, behaves as Chrome but sooo slow when displaying the editor even with a very short post.
</p>
aferciahttps://core.trac.wordpress.org/ticket/31771
https://core.trac.wordpress.org/ticket/31771Report#31149: Error Object of class stdClass could not be converted to int in ms-functions.php on line 1788hauvongTue, 27 Jan 2015 23:15:46 GMTMon, 23 Mar 2015 18:08:55 GMT<p>
Issue cause by <tt>$wpdb-&gt;get_row()</tt> return object to <tt>$local_id</tt> but was pass to global_terms to use as int. Fix by switching to <tt>$wpdb-&gt;get_var()</tt>:
</p>
<p>
Change from:
</p>
<pre class="wiki">$local_id = $wpdb-&gt;get_row( $wpdb-&gt;prepare( "SELECT term_id FROM $wpdb-&gt;terms WHERE term_id = %d", $global_id ) );
</pre><p>
To correction:
</p>
<pre class="wiki">$local_id = $wpdb-&gt;get_var( $wpdb-&gt;prepare( "SELECT term_id FROM $wpdb-&gt;terms WHERE term_id = %d", $global_id ) );
</pre>hauvonghttps://core.trac.wordpress.org/ticket/31149
https://core.trac.wordpress.org/ticket/31149Report#28820: Focus isn't clear when previewing an oEmbed from Add Media PanelphilipjohnThu, 10 Jul 2014 20:57:25 GMTWed, 25 Mar 2015 23:18:50 GMT<p>
Summary: After pasting an oEmbed URL into the "Insert from URL" portion of the Add Media Panel, tabbing away from the URL field does not provide a clear indication of focus.
</p>
<p>
Steps to reproduce:
</p>
<ol><li>Enter the post editor
</li><li>Open the Add Media Panel
</li><li>Go to the "Insert from URL" screen
</li><li>Paste an oEmbed (e.g. YouTube) URL into the URL field, and wait for the embed to appear
</li><li>Tab away from the URL field - the focus is unclear
</li></ol><p>
Further tabbing shows the focus was on the preview after tabbing away. I've replicated this using both YouTube and WordPress.tv embeds.
</p>
<p>
Attached is a screenshot showing the view after tabbing from the URL field.
</p>
philipjohnhttps://core.trac.wordpress.org/ticket/28820
https://core.trac.wordpress.org/ticket/28820Report#31203: Focus style for add-new-theme should match hover stylecelloexpressionsSun, 01 Feb 2015 21:06:30 GMTSat, 21 Mar 2015 12:25:59 GMT<p>
This also fixes the issue for the Customizer Theme Switcher plugin. See <a class="ext-link" href="https://make.wordpress.org/accessibility/2015/01/31/theme-switcher-accessibility-test-result/"><span class="icon">​</span>https://make.wordpress.org/accessibility/2015/01/31/theme-switcher-accessibility-test-result/</a>.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/31203
https://core.trac.wordpress.org/ticket/31203Report#30380: get_transient doesn't check the return of get_optionjamesgolTue, 18 Nov 2014 06:48:48 GMTSat, 28 Mar 2015 01:02:35 GMT<p>
When calling get_transient on a key that doesn't exist, notoptions[$key] is set so it won't do any further queries, but it doesn't go far enough. Since the get_option( $transient_timeout ) doesn't check the return well enough it will always cause 2 more queries. (SELECT autoload FROM wp_options ...)
</p>
<p>
If get_options( $transient_timeout ) is returning false, what is the point of trying to delete it.
</p>
jamesgolhttps://core.trac.wordpress.org/ticket/30380
https://core.trac.wordpress.org/ticket/30380Report#27115: HTTPS links to wordpress.orgjohnbillionWed, 12 Feb 2014 21:19:55 GMTMon, 23 Mar 2015 12:04:39 GMT<p>
It appears that wordpress.org now favours an SSL connection, although it is not currently enforced. <a class="ext-link" href="https://www.google.com/search?q=wordpress"><span class="icon">​</span>Googling for WordPress returns a link to https://wordpress.org</a> and once you're on the site, the HTTPS links persist.
</p>
<p>
We should convert all wordpress.org links in the dashboard to HTTPS links.
</p>
<p>
Any objections?
</p>
johnbillionhttps://core.trac.wordpress.org/ticket/27115
https://core.trac.wordpress.org/ticket/27115Report#31776: I18n optimizations for 4.2obenlandThu, 26 Mar 2015 18:56:07 GMTFri, 27 Mar 2015 23:19:26 GMT<p>
Ticket to collect optimization suggestions for new strings in 4.2.
</p>
obenlandhttps://core.trac.wordpress.org/ticket/31776
https://core.trac.wordpress.org/ticket/31776Report#28272: Image loses link after drag and drop or copy/pasteiseuldeThu, 15 May 2014 21:40:25 GMTFri, 20 Mar 2015 00:20:16 GMT<p>
To reproduce, insert an image with a link, drag it to another paragraph. The link is gone.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/28272
https://core.trac.wordpress.org/ticket/28272Report#31253: Images should be forced to fit inside the editoriseuldeFri, 06 Feb 2015 21:54:30 GMTTue, 24 Mar 2015 12:31:21 GMT<p>
I think it would be best if images and captions have a <tt>max-width: 100%;</tt>.
</p>
<p>
This appeared to be a bit of a problem on iOS... Another bug, again.
Inside iframes, Safari on iOS doesn't obey <tt>max-width</tt> if a <tt>width</tt> is set on the element. It does work if a width attribute is used though. The only solution seems to be overwriting with <tt>width: auto;</tt>.
</p>
<p>
Related:
</p>
<p>
</p><div><dl class="wiki compact"><dt><a class="new" href="/ticket/24968" title="$content_width not constraining images in fullscreen editor">#24968</a></dt><dd>$content_width not constraining images in fullscreen editor</dd><dt><a class="closed" href="/ticket/30696" title="Inline media toolbar positioning">#30696</a></dt><dd>Inline media toolbar positioning</dd><dt><a class="reopened" href="/ticket/31250" title="Twenty Fifteen editor styles look weird on mobile">#31250</a></dt><dd>Twenty Fifteen editor styles look weird on mobile</dd></dl></div><p>
</p>
iseuldehttps://core.trac.wordpress.org/ticket/31253
https://core.trac.wordpress.org/ticket/31253Report#28784: Improve the Customize experience on mobilecelloexpressionsTue, 08 Jul 2014 00:57:05 GMTSun, 29 Mar 2015 12:22:34 GMT<p>
The Customizer currently works on mobile, despite what you might think. Utilizing the "collapse" function, it's possible to change settings and switch back and forth between the controls and the preview window. But the experience doesn't work on every device (there are some scrolling issues), and could be much smoother and more intuitive.
</p>
<p>
The controls part of the Customizer is already mobile-optimized - at 300px wide, it works quite well on mobile and the only major issues are with things like the widget-adder that pop out of the main control panel. Similarly, the preview works down to tablet-sized devices with responsive themes, although it continues to be squeezed to unrealistic widths on smaller devices.
</p>
<p>
We should look at revamping the Customizer experience on smaller devices - anything smaller than about 620px wide can't realistically be used in the standard controls/preview mode. For this ticket, the goal is to make the cosmetic tweaks necessary to streamline the Customization experience on mobile, most likely by hiding the preview at a certain point and highlighting the ability to switch between the controls and the preview.
</p>
celloexpressionshttps://core.trac.wordpress.org/ticket/28784
https://core.trac.wordpress.org/ticket/28784Report#26601: Inappropriate content in headings on admin screensgrahamarmfieldFri, 13 Dec 2013 11:57:56 GMTMon, 30 Mar 2015 19:13:42 GMT<p>
At the top of the themes.php page there is a second level heading which contains the following:
</p>
<ul><li>The text Themes
</li><li>The number of themes being shown
</li><li>The Add New link
</li><li>The Search installed themes input and label
</li></ul><p>
So on an example page a screen reader voices "Themes7 Add New Search Installed Themes".
</p>
<p>
The use of headings is good for accessibility as it gives screen reader users a way of finding what they are looking for on a page. But in this case there is too much within the heading.
</p>
<p>
Suggested solution: Keep the word Themes within the heading and move the other elements outside the <tt>&lt;h2&gt;...&lt;/h2&gt;</tt>
</p>
grahamarmfieldhttps://core.trac.wordpress.org/ticket/26601
https://core.trac.wordpress.org/ticket/26601Report#28206: Include 'source anchor' in wpLink quicktags modal for improved ui/uxnetwebSun, 11 May 2014 03:04:38 GMTWed, 25 Mar 2015 21:26:13 GMT<p>
Over on bbpress.org a common issue for users is links posted are missing the 'source anchor'.
</p>
<p>
<em>(The issue isn't seen on <a class="ext-link" href="http://wordpress.org/support/"><span class="icon">​</span>http://wordpress.org/support/</a> due to bbPress v1.x as different editor is used)</em>
</p>
<p>
The following behaviour is also seen when creating a post/page in WordPress using the 'text' editor.
</p>
<p>
The default modal for the 'link' quicktag includes form fields for <tt>URL</tt> and <tt>Title</tt>, in many cases users (particularity those unfamiliar with HTML) think the 'Title' will be the text that can be 'clicked' on to take you to the 'destination anchor' when in fact this is the <tt>&lt;a&gt;</tt> elements <tt>title</tt> attribute and not the 'source anchor'.
</p>
<p>
As an example of what we expect to see:
</p>
<pre class="wiki">...some text...
Here's a photo of
&lt;a href="http://example.com/neatstuff.gif" title="Me scuba diving"&gt;me scuba diving last summer&lt;/a&gt;
...some more text...
</pre><p>
This is what we end up seeing <em>(not that you can see these anchors without viewing the source)</em>:
</p>
<pre class="wiki">...some text...
Here's a photo of
&lt;a href="http://example.com/neatstuff.gif" title="Me scuba diving"&gt;&lt;/a&gt;
...some more text...
</pre><p>
Using the modal in it's current state after adding the <tt>URL</tt> and <tt>Title</tt> via the modal the cursor is returned before the closing anchor tag to facilitate the entry of the 'source anchor' though for whatever the reasons might be this is often skipped, ignored, or un-noticed by the user.
</p>
<p>
<a style="padding:0; border:none" href="https://i.cloudup.com/OD27HnfBmt.png"><img src="https://i.cloudup.com/OD27HnfBmt.png" alt="https://i.cloudup.com/OD27HnfBmt.png" title="https://i.cloudup.com/OD27HnfBmt.png" /></a>
</p>
<p>
Per the screenshots in the follow up comment in a moment I propose we extend the existing modal to include a form field for the 'source anchor' to improve usability/user experience.
</p>
netwebhttps://core.trac.wordpress.org/ticket/28206
https://core.trac.wordpress.org/ticket/28206Report#31116: Infinite loop in the media load page, media-models.min.jsVeritaserumSat, 24 Jan 2015 03:59:23 GMTThu, 19 Mar 2015 10:05:36 GMT<p>
The following bug causes infinite loop in the media library grid:
</p>
<p>
<strong>e.paged=Math.floor(this.length/e.posts_per_page)+1</strong>
if this.length = 159;
and e.posts_per_page = 40;
you will always return a e.paged = 4;
</p>
<p>
How is this done, the math before adding one is 3.975 at flooring comes to 3 then add 1.
</p>
<p>
Resolve this with <strong>Math.round(this.length/e.posts_per_page)+1</strong> . This is the only way to be sure that the paged number is safe and will not repeat.
</p>
Veritaserumhttps://core.trac.wordpress.org/ticket/31116
https://core.trac.wordpress.org/ticket/31116Report#6820: Make it possible to manually detach/attach post imagesmattWed, 23 Apr 2008 01:24:09 GMTThu, 19 Mar 2015 03:20:19 GMT<p>
You should be able to change the parent of an attachment to attach it to a different post.
</p>
matthttps://core.trac.wordpress.org/ticket/6820
https://core.trac.wordpress.org/ticket/6820Report#31352: Media icons are not retina friendlyiseuldeMon, 16 Feb 2015 20:28:20 GMTTue, 17 Mar 2015 01:41:12 GMT<p>
See screenshot and <a class="changeset" href="https://core.trac.wordpress.org/changeset/27726" title="Use Dashicon-style images for mime type icons. Actually moving to ...">[27726]</a>.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/31352
https://core.trac.wordpress.org/ticket/31352Report#30599: media views: improve keyboard accessibility avoiding confusing tab stopsaferciaThu, 04 Dec 2014 22:25:39 GMTWed, 25 Mar 2015 18:12:01 GMT<p>
When hiding parts of the UI it's very important to take into consideration side-effects on keyboard accessibility. For example, when media-menu is hidden, e.g. when editing images, it's just positioned out of view but links in the menu are still there and they are focusable. See screenshot.
</p>
<p>
When tabbing, keyboard users get a variable number of confusing tab stops that shouldn't be there.
</p>
<p>
Actually, it's also possible to activate one of the links in the menu (just tab into one of them and press Enter) and break the editing workflow.
Unless I'm missing something, the media menu should be hidden with <tt>display: none</tt> I'm guessing the out of view positioning is there just for historical reasons.
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/tfDzl1O6r0.png"><img src="https://cldup.com/tfDzl1O6r0.png" alt="https://cldup.com/tfDzl1O6r0.png" title="https://cldup.com/tfDzl1O6r0.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/30599
https://core.trac.wordpress.org/ticket/30599Report#31684: media.view.Settings.Gallery.extend doesn't work anymorebduclosWed, 18 Mar 2015 14:39:21 GMTTue, 31 Mar 2015 02:02:37 GMT<p>
I use the code below to add custom parameters to galleries. (Jetpack do the same to add a type parameter). Since Trunk split the javascript files into modules, it doesn't work anymore.
</p>
<pre class="wiki">media.view.Settings.Gallery = media.view.Settings.Gallery.extend({})
</pre>bducloshttps://core.trac.wordpress.org/ticket/31684
https://core.trac.wordpress.org/ticket/31684Report#31755: Notice in admin-bar.php since revision 31448deconfTue, 24 Mar 2015 19:49:49 GMTTue, 24 Mar 2015 20:41:36 GMT<p>
PHP Notice: Trying to get property of non-object in \path\wp-includes\admin-bar.php on line 335
</p>
<p>
If a Super Admin has no sites, <strong>active_blog</strong> is empty and the above notice is thrown.
</p>
deconfhttps://core.trac.wordpress.org/ticket/31755
https://core.trac.wordpress.org/ticket/31755Report#26646: On Appearance themes page ".themes" div is not covering floated elements.5um17Mon, 16 Dec 2013 14:00:37 GMTWed, 25 Mar 2015 20:36:59 GMT<p>
On theme page, all theme's thumbnail wrapper div are floated left but the parent div (div.themes) do not cover any floated element;
Moreover div.themes is also having 100px bottom padding which is not taking any effect on the page.<br />
In <strong>/wp-admin/themes.php</strong> have a clearing element <tt> &lt;br class="clear" /&gt; </tt> inside the div.themes but when rendering is done by tmpl-theme template, the clearing element <tt> &lt;br class="clear" /&gt; </tt> is being inserted outside of the div.themes.<br />
<br />
Also the "add-new-theme" element is being add as last child element of div.themes but last element should be <tt> &lt;br class="clear" /&gt; </tt>
to clear every element, if not then div.add-new-theme will start from new line even though there is room available next to div.theme element.
</p>
5um17https://core.trac.wordpress.org/ticket/26646
https://core.trac.wordpress.org/ticket/26646Report#31144: Options general screen, accessibility improvementsaferciaTue, 27 Jan 2015 16:55:54 GMTMon, 23 Mar 2015 11:14:34 GMT<p>
Splitting this out from <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29955" title="defect (bug): Section 508 issues found on WordPress 4.0 admin page. (closed: invalid)">#29955</a> see points 2. and 3.
</p>
<p>
Basically, the date format and time format radio button labels don't get read out by JAWS. It reads out just "radio button checked". Should read the label text with the date/time example formats.
</p>
<p>
After some testing with IE 8 and JAWS 15, turned out <strong>when in "form mode"</strong>, JAWS doesn't read out the implicit label because there's a <tt>&lt;span&gt;</tt> wrapping the label text. So with this HTML:
</p>
<pre class="wiki">&lt;label&gt;&lt;input type="radio" name="test"&gt; &lt;span&gt;implicit label&lt;span&gt;&lt;/label&gt;
</pre><p>
the label text is just ignored. I guess it make sense: when there's an implicit label, IE 8 and JAWS 15 expect to find a text node and instead they find a <tt>&lt;span&gt;</tt>. <strong>Oddly, looks like this happens just for radio buttons.</strong>
Simple test case: <a class="ext-link" href="http://codepen.io/afercia/full/BydyKx/"><span class="icon">​</span>http://codepen.io/afercia/full/BydyKx/</a>
</p>
<p>
So, lesson learned: <strong>never use a span or other elements to wrap a radio button implicit label text</strong>.
</p>
<p>
In the proposed patch some more issues addressed:
</p>
<ul><li>removed spans wrapping implicit radio buttons label: they make JAWS ignore the label text
</li><li>updated the JavaScript part related to the ".example" text
</li><li>added 2 missing labels for custom formats text fields
</li><li>added "aria-describedby" for elements with a description paragraph
</li><li>added some screen-reader-text
</li><li>small CSS fixes including spinner position
</li></ul><p>
Outstanding accessibility issues:
</p>
<ul><li>moving the focus on the custom format fields makes screen readers skip important information
</li><li>try a better association between the "example" date and time (the ones changed by JavaScript on radio buttons click) and the input fields
</li><li>the link: "to be different from the directory" it's confusing when read out of context, I would propose to change the wording of that sentence and use something like "Learn how to give WordPress its own directory".
</li></ul><p>
Accessibility team testing and any thoughts welcome :)
</p>
aferciahttps://core.trac.wordpress.org/ticket/31144
https://core.trac.wordpress.org/ticket/31144Report#20943: Paragraphs get removed in table cells when Visual editor is refreshedJboyJWWed, 13 Jun 2012 19:06:04 GMTFri, 20 Mar 2015 05:49:41 GMT<p>
As far as I know, this issue has been around since 3.1. It's not a bug in 3.0.4. I even stopped upgrading at 3.0.4 for any sites where I knew the client would need to edit tabular data. For security reasons, it's time to upgrade these and I'd REALLY like this issue to be fixed.
</p>
<p>
The problem happens when using paragraphs in a table cell. When I hit enter to create a new paragraph within a table cell, it looks fine. If I then hit Update/Publish, when the page refreshes, WordPress converts that paragraph break into a single line break. If I then click Update again, WordPress removes that linebreak entirely and the paragraphs are essentially merged.
</p>
<p>
I can also reproduce this behaviour without even clicking Update. If you just switch to HTML mode and then back to Visual mode, the same issue occurs.
</p>
JboyJWhttps://core.trac.wordpress.org/ticket/20943
https://core.trac.wordpress.org/ticket/20943Report#31104: Plugin activation includes plugin file in variable scope of activate_pluginMike_CowoboFri, 23 Jan 2015 06:57:16 GMTMon, 23 Mar 2015 07:45:30 GMT<p>
When a plugin is activated, it is included in <tt>activate_plugin</tt>, with access to the variable scope of <tt>activate_plugin</tt>. This caused a problem with <tt>$plugin</tt> in <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28102" title="defect (bug): is_string check in validate_file (closed: fixed)">#28102</a>, and was fixed in <a class="changeset" href="https://core.trac.wordpress.org/changeset/28644" title="Avoid stomping of the $plugin variable in activate_plugin().
fixes ...">[28644]</a>, but the other variables that are used in the function (<tt>$current</tt>, <tt>$silent</tt> and <tt>$network_wide</tt>) can still potentially cause problems.
</p>
<p>
Overriding <tt>$current</tt> and <tt>$network_wide</tt>, a plugin could potentially deactivate all active plugins on activation or activate itself network wide when activated per-site (or vice-versa).
</p>
<p>
It's not hard to imagine plugins using those var names in the main plugin file. To illustrate, here is an example of a broken plugin file:
</p>
<pre class="wiki">&lt;?php
/*
Plugin Name: Broken Plugin
Plugin URI: http://example.com
Description: This plugin breaks things when it is activated
Version: 0.1
Author: Your Name
Author URI: http://example.com
*/
// Is this a network install?
$network_wide = is_multisite(); // EFFECT: Will turn a per-site activation into a multisite activation
$defaults = array( "my-option" =&gt; 1 );
foreach( $defaults as $option =&gt; $current ) {
if ( !get_option( $option ) ) {
add_option( $option, $current );
}
} // EFFECT: $current is now '1'. This deactivates ALL active plugins.
</pre><p>
Though the occurrence will be rare, these side-effect can be hard to debug for a plugin developer. Instead of saving the variable in a shadow var like in <a class="changeset" href="https://core.trac.wordpress.org/changeset/28644" title="Avoid stomping of the $plugin variable in activate_plugin().
fixes ...">[28644]</a>, it can be easily and definitively fixed by calling the include from a separate function, so the variable scope of activate_plugin is simply out of reach. I have attached a patch. With the patch, the broken plugin above loses all side-effects.
</p>
Mike_Cowobohttps://core.trac.wordpress.org/ticket/31104
https://core.trac.wordpress.org/ticket/31104Report#31784: Plugin update gives noticeKloonFri, 27 Mar 2015 09:58:42 GMTFri, 27 Mar 2015 15:33:50 GMT<p>
When updating a plugin with the new shiny interface on the plugins page it throws a notice of undefined index.
</p>
<p>
PHP Notice: Undefined index: plugin in /srv/www/wordpress-develop/src/wp-admin/includes/update.php on line 279
</p>
Kloonhttps://core.trac.wordpress.org/ticket/31784
https://core.trac.wordpress.org/ticket/31784Report#31768: Press This: Emoji support within the titleocean90Wed, 25 Mar 2015 21:27:29 GMTSun, 29 Mar 2015 03:14:58 GMT<p>
If a browser doesn't support native emojis they are replaced with an image. Since <tt>$titleField.text()</tt> doesn't catch the HTML the placeholder will be still shown.
</p>
ocean90https://core.trac.wordpress.org/ticket/31768
https://core.trac.wordpress.org/ticket/31768Report#30501: Prevent flushing rewrites during page loadjoostdevalkTue, 25 Nov 2014 22:15:16 GMTWed, 25 Mar 2015 06:35:47 GMT<p>
Flushing rewrites during the pageload breaks a lot of plugins. They might not have registered their rewrite yet which would cause issues. I propose preventing the flushing from working and forcing it to be run on shutdown instead.
</p>
joostdevalkhttps://core.trac.wordpress.org/ticket/30501
https://core.trac.wordpress.org/ticket/30501Report#31769: Prevent navigating away while plugins are updating via shiny updatesjohnbillionWed, 25 Mar 2015 22:13:47 GMTSat, 28 Mar 2015 15:29:56 GMT<p>
We should have an <tt>onbeforeunload</tt> event active while a plugin is being updated via shiny updates. Especially for bulk updates.
</p>
johnbillionhttps://core.trac.wordpress.org/ticket/31769
https://core.trac.wordpress.org/ticket/31769Report#28687: Removing background image and/or reverting background color to default doesn't remove custom-background body class and remove theme modsslobodanmanicMon, 30 Jun 2014 06:06:11 GMTMon, 30 Mar 2015 18:48:33 GMT<p>
Scenario:
</p>
<ul><li>Set custom background color, then revert do default or
</li><li>Set custom background image, then remove it
</li></ul><p>
Problem:
</p>
<ul><li>None of the theme mods are removed
</li><li>Because of this <tt>.custom-background</tt> is still being added
</li></ul><p>
This is what I have in theme_mods_twentyfourteen after setting background color and image, then removing them both:
</p>
<pre class="wiki">s:16:"background_color";s:6:"f5f5f5";
s:16:"background_image";s:0:"";
s:22:"background_image_thumb";s:0:"";
s:17:"background_repeat";s:6:"repeat";
s:21:"background_position_x";s:4:"left";
s:21:"background_attachment";s:6:"scroll";
</pre><p>
Sorry if this has been filed before. I checked for tickets that could relate to this, but no luck.
</p>
<p>
I'll work on a patch today, but it would be great if someone could say if there's a reason for this behaviour.
</p>
slobodanmanichttps://core.trac.wordpress.org/ticket/28687
https://core.trac.wordpress.org/ticket/28687Report#31611: Scroll bleed in the attachment details modal on iOSryanThu, 12 Mar 2015 14:46:02 GMTTue, 31 Mar 2015 14:51:43 GMT<p>
Swiping scrolls the page beneath.
</p>
<p>
<a class="ext-link" href="https://make.wordpress.org/flow/2015/03/11/modal-scrolling-on-ios/"><span class="icon">​</span>https://make.wordpress.org/flow/2015/03/11/modal-scrolling-on-ios/</a>
</p>
ryanhttps://core.trac.wordpress.org/ticket/31611
https://core.trac.wordpress.org/ticket/31611Report#31612: Scroll bleed in the link modal on iOSryanThu, 12 Mar 2015 14:47:43 GMTTue, 31 Mar 2015 14:53:40 GMT<p>
Swiping scrolls the page beneath.
</p>
<p>
<a class="ext-link" href="https://make.wordpress.org/flow/2015/03/11/modal-scrolling-on-ios/"><span class="icon">​</span>https://make.wordpress.org/flow/2015/03/11/modal-scrolling-on-ios/</a>
</p>
ryanhttps://core.trac.wordpress.org/ticket/31612
https://core.trac.wordpress.org/ticket/31612Report#31610: Scroll bleed in the session expired log in modal on iOSryanThu, 12 Mar 2015 14:43:59 GMTTue, 31 Mar 2015 16:19:36 GMT<p>
Swiping scrolls the page beneath the modal.
</p>
<p>
<a class="ext-link" href="https://make.wordpress.org/flow/2015/03/05/scroll-bleed-through-in-the-session-expired-log-in-modal-iphone-5/"><span class="icon">​</span>https://make.wordpress.org/flow/2015/03/05/scroll-bleed-through-in-the-session-expired-log-in-modal-iphone-5/</a>
</p>
<p>
<a class="ext-link" href="https://make.wordpress.org/flow/2015/03/11/modal-scrolling-on-ios/"><span class="icon">​</span>https://make.wordpress.org/flow/2015/03/11/modal-scrolling-on-ios/</a>
</p>
ryanhttps://core.trac.wordpress.org/ticket/31610
https://core.trac.wordpress.org/ticket/31610Report#31609: Scroll bleed through and scroll position loss in the view plugin details modal on iOSryanThu, 12 Mar 2015 14:40:41 GMTTue, 31 Mar 2015 15:59:27 GMT<p>
When scrolling the plugin view details modal on an iOS device, the page beneath the modal scrolls. The modal also stomps scroll position. After dismissing the modal, you’re back at the top of the underlying page rather than where you were when you invoked the modal.
</p>
<p>
<a class="ext-link" href="https://make.wordpress.org/flow/2015/02/13/scroll-bleed-through-and-scroll-position-loss-view-plugin-details-iphone-6/"><span class="icon">​</span>https://make.wordpress.org/flow/2015/02/13/scroll-bleed-through-and-scroll-position-loss-view-plugin-details-iphone-6/</a>
</p>
<p>
<a class="ext-link" href="https://make.wordpress.org/flow/2015/03/11/modal-scrolling-on-ios/"><span class="icon">​</span>https://make.wordpress.org/flow/2015/03/11/modal-scrolling-on-ios/</a>
</p>
ryanhttps://core.trac.wordpress.org/ticket/31609
https://core.trac.wordpress.org/ticket/31609Report#30799: Scrutinizer in 4.2wonderboymusicSat, 20 Dec 2014 20:13:59 GMTFri, 27 Mar 2015 16:10:15 GMT<p>
Continued efforts to improve static analysis of the codebase. Most commits will be minor changes that either remove dead code, improve comprehensibility of existing code, or clarify types specified by <tt>@param</tt> docs.
</p>
wonderboymusichttps://core.trac.wordpress.org/ticket/30799
https://core.trac.wordpress.org/ticket/30799Report#26600: Search installed themes input has no submit buttongrahamarmfieldFri, 13 Dec 2013 11:48:43 GMTTue, 31 Mar 2015 18:09:23 GMT<p>
This input field has no corresponding Search button. I can see that adding letters to the field refines the themes shown on the screen. However, when using a screen reader there is no audible feedback to tell the screen reader user that the display is being updated.
</p>
<p>
Provision of a submit button may help with this as users will be more likely to expect the results to be changed based on the characters they have entered.
</p>
<p>
Alternatively (or additionally) a solution using <tt>aria-live</tt> regions could be investigated to give screen readers feedback that the search results have changed. I notice that the number next to the word Themes updates as the search results change. This could be the basis for an <tt>aria-live</tt> solution, but more context would need to be provided.
</p>
grahamarmfieldhttps://core.trac.wordpress.org/ticket/26600
https://core.trac.wordpress.org/ticket/26600Report#31532: Shiny Updates: Don't activate plugins with PHP errorspentoThu, 05 Mar 2015 04:12:28 GMTThu, 19 Mar 2015 03:50:27 GMT<p>
Branched from <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/29820" title="task (blessed): Smooth installation and updating of plugins and themes (closed: fixed)">#29820</a>.
</p>
<p>
When we try to activate a plugin through shiny updates, we shouldn't do it if it causes PHP errors.
</p>
pentohttps://core.trac.wordpress.org/ticket/31532
https://core.trac.wordpress.org/ticket/31532Report#31608: Shiny Updates: fine-tune UI for filesystem credentials request modalericlewisThu, 12 Mar 2015 14:08:47 GMTMon, 30 Mar 2015 08:02:02 GMT<p>
The filesystem credentials request when updating or installing a plugin has been merged.
</p>
<p>
@melchoyce has previously <a href="https://core.trac.wordpress.org/timeline?from=2014-11-11T14%3A54%3A42Z&amp;precision=second">drafted a mockup for a filesystem credentials request</a>.
</p>
<p>
We opted for a modal for the UI of this interaction because a modal is more portable, and avoids customization of the same UI in multiple locations it will be used in (e.g. plugin cards, plugin list table, theme list table, theme cards, core upgrade screen).
</p>
<p>
The FS creds form is typically plopped on its own screen, and has as much room to breathe as any other Settings page, which it shares likeness in both markup and layout. Mel's mockup tightens the request filesystem credentials UI in a constrained space without complicating anything. Let's implement.
</p>
ericlewishttps://core.trac.wordpress.org/ticket/31608
https://core.trac.wordpress.org/ticket/31608Report#31819: Shiny updates: more sophisticated lockingDavidAndersonTue, 31 Mar 2015 11:41:16 GMTTue, 31 Mar 2015 16:43:45 GMT<p>
Now that the "shiny updates" code for 4.2 has settled down, I've been able to have a look.
</p>
<p>
I develop a plugin (UpdraftPlus - the most installed WP backup plugin; 400,000+ current installs) that hooks into plugin updates (in the paid version), and runs a backup before updating. (So, if the update is broken, you have a convenient backup from just before). Communication on the backup state goes between browser and back-end over AJAX. When the back-end completes, the update operation then proceeds.
</p>
<p>
Of course, we want to retain this functionality with shiny updates.
</p>
<p>
Looking at the shiny updates code, it looks like the best way to accomplish this is for my code to set wp.updates.updateLock to prevent the update going ahead, until it's ready ... and then set it back to false and call wp.updates.queueChecker().
</p>
<p>
This looks like it'll work, though the filesystem credentials dialog makes it slightly more complicated (but I think we can work with that too).
</p>
<p>
However, I am concerned that a binary boolean lock is inflexible, and makes the shiny updates process difficult and a bit hack-ish to plug into, possibly setting us up for future complications or unanticipated complications out in the wild.
</p>
<p>
It'd be ideal if WP had JavaScript filters (see: <a class="new ticket" href="https://core.trac.wordpress.org/ticket/21170" title="feature request: JavaScript actions and filters (new)">#21170</a>), but they're not there yet. So, I suggest that instead of a boolean lock, instead wp.updates.updateLock becomes an array of functions. When the lock status needs checking, the functions are each called.
</p>
<p>
Alternatively, and more simply, instead of a boolean, an integer could be used, and different agents wanting to lock could set different bits (the core code would use some, and others would be left for plugins).
</p>
<p>
Thoughts?
</p>
DavidAndersonhttps://core.trac.wordpress.org/ticket/31819
https://core.trac.wordpress.org/ticket/31819Report#31722: Shiny Updates: the aria-label should be updated to reflect the current statusaferciaSat, 21 Mar 2015 13:14:31 GMTTue, 31 Mar 2015 11:53:27 GMT<p>
Please refer to attached screenshots. Not sure this is the only place to check, basically all the aria information should be updated together with the "visual" information to always reflect the current upgrade/install status.
</p>
<p>
In this example, where it still says "Update xx plugin now" or "Install xx plugin now", the value should be updated at least with the final result "Updated" or "Installed". Worth checking also what happens in case of failures.
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/Y5S3b0tV98.png"><img src="https://cldup.com/Y5S3b0tV98.png" alt="https://cldup.com/Y5S3b0tV98.png" title="https://cldup.com/Y5S3b0tV98.png" /></a>
</p>
<p>
<a style="padding:0; border:none" href="https://cldup.com/mCmzrqdAh7.png"><img src="https://cldup.com/mCmzrqdAh7.png" alt="https://cldup.com/mCmzrqdAh7.png" title="https://cldup.com/mCmzrqdAh7.png" /></a>
</p>
aferciahttps://core.trac.wordpress.org/ticket/31722
https://core.trac.wordpress.org/ticket/31722Report#29897: Some focus styles are brokeniseuldeThu, 09 Oct 2014 03:27:42 GMTThu, 19 Mar 2015 17:00:15 GMT<p>
See screenshots below.
</p>
iseuldehttps://core.trac.wordpress.org/ticket/29897
https://core.trac.wordpress.org/ticket/29897Report#28510: Split javascript files in media into modulesericlewisThu, 12 Jun 2014 15:45:02 GMTTue, 31 Mar 2015 02:02:37 GMT<p>
<a class="ext-link" href="http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&amp;day=2014-06-11&amp;sort=asc#m868005"><span class="icon">​</span>Yesterday in dev chat</a>, ideas for splitting up distinct javascript modules in were discussed. As we move towards more and more javascript-heavy administrative interfaces, this will prove quite helpful in readability, and by extension maintainability. A 6000 line file made up of 50-some views is not easy to step into. A folder of well organized modules for one feature would be.
</p>
<p>
This will only affect the src/ directory in the develop repository, which will use our build process to concatenate into the build/ directory, so nothing will change for developers using the build/ directory or the core repo.
</p>
<p>
We'll start this effort with media, and end up with a standardized way of doing this going forward.
</p>
ericlewishttps://core.trac.wordpress.org/ticket/28510
https://core.trac.wordpress.org/ticket/28510Report#29906: Submenus can't be dismissed on mobile.obenlandThu, 09 Oct 2014 15:24:37 GMTTue, 31 Mar 2015 21:34:28 GMT<p>
When the site-name submenu pane is active, it covers the viewport and there is no way to dismiss it. All tapping will lead to a screen in the admin.
</p>
<p>
First reported in: <a class="ext-link" href="https://make.wordpress.org/flow/2014/07/07/the-guises-of-bar-nexus-5-4-0-alpha-20140706/screenshot_2014-07-07-07-41-58/"><span class="icon">​</span>https://make.wordpress.org/flow/2014/07/07/the-guises-of-bar-nexus-5-4-0-alpha-20140706/screenshot_2014-07-07-07-41-58/</a>
</p>
obenlandhttps://core.trac.wordpress.org/ticket/29906
https://core.trac.wordpress.org/ticket/29906Report#31262: Tests_DB_Charset failuresSergeyBiryukovSun, 08 Feb 2015 05:14:14 GMTTue, 31 Mar 2015 10:37:46 GMT<p>
Background: <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/21212" title="task (blessed): MySQL tables should use utf8mb4 character set (closed: fixed)">#21212</a>
</p>
<p>
Seeing two failures in current trunk running <tt>phpunit --group wpdb</tt> on PHP 5.2.17, MySQL 5.0.51a:
</p>
<pre class="wiki">There were 2 failures:
1) Tests_DB_Charset::test_strip_invalid_text with data set #6 (array(array('hebrew', 'ùord÷ress', true)), array(array('hebrew', 'ùord÷ress', true)), 'hebrew')
hebrew
Failed asserting that Array (
0 =&gt; Array (
'charset' =&gt; 'hebrew'
'value' =&gt; '?ord?ress'
'db' =&gt; true
)
) is identical to Array (
0 =&gt; Array (
'charset' =&gt; 'hebrew'
'value' =&gt; 'ùord÷ress'
'db' =&gt; true
)
).
S:\home\wordpress\develop\tests\phpunit\tests\db\charset.php:129
S:\usr\local\php5\phpunit:46
2) Tests_DB_Charset::test_strip_invalid_text with data set #9 (array(array('latin1', 'ðŸŽ·'), array('ascii', 'Hello World'), array('utf8', 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'), array('utf8mb3', 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'), array('utf8mb4', 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'), array('koi8r', 'ýordòress', true), array('hebrew', 'ùord÷ress', true), array(false, 100), array('big5', 'a¦@b')), array(array('latin1', 'ðŸŽ·'), array('ascii', 'Hello World'), array('utf8', 'Hâ‚¬lloWorldÂ¢'), array('utf8mb3', 'Hâ‚¬lloWorldÂ¢'), array('utf8mb4', 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'), array('koi8r', 'ýordòress', true), array('hebrew', 'ùord÷ress', true), array(false, 100), array('big5', 'a¦@b')), 'multiple fields/charsets')
multiple fields/charsets
Failed asserting that Array (
0 =&gt; Array (
'charset' =&gt; 'latin1'
'value' =&gt; 'ðŸŽ·'
)
1 =&gt; Array (
'charset' =&gt; 'ascii'
'value' =&gt; 'Hello World'
)
2 =&gt; Array (
'charset' =&gt; 'utf8'
'value' =&gt; 'Hâ‚¬lloWorldÂ¢'
)
3 =&gt; Array (
'charset' =&gt; 'utf8mb3'
'value' =&gt; 'Hâ‚¬lloWorldÂ¢'
)
4 =&gt; Array (
'charset' =&gt; 'utf8mb4'
'value' =&gt; 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'
)
5 =&gt; Array (
'charset' =&gt; 'koi8r'
'value' =&gt; 'ýordòress'
'db' =&gt; true
)
6 =&gt; Array (
'charset' =&gt; 'hebrew'
'value' =&gt; '?ord?ress'
'db' =&gt; true
)
7 =&gt; Array (
'charset' =&gt; false
'value' =&gt; 100
)
8 =&gt; Array (
'charset' =&gt; 'big5'
'value' =&gt; 'a¦@b'
)
) is identical to Array (
0 =&gt; Array (
'charset' =&gt; 'latin1'
'value' =&gt; 'ðŸŽ·'
)
1 =&gt; Array (
'charset' =&gt; 'ascii'
'value' =&gt; 'Hello World'
)
2 =&gt; Array (
'charset' =&gt; 'utf8'
'value' =&gt; 'Hâ‚¬lloWorldÂ¢'
)
3 =&gt; Array (
'charset' =&gt; 'utf8mb3'
'value' =&gt; 'Hâ‚¬lloWorldÂ¢'
)
4 =&gt; Array (
'charset' =&gt; 'utf8mb4'
'value' =&gt; 'Hâ‚¬lloðŸ˜ˆWorldÂ¢'
)
5 =&gt; Array (
'charset' =&gt; 'koi8r'
'value' =&gt; 'ýordòress'
'db' =&gt; true
)
6 =&gt; Array (
'charset' =&gt; 'hebrew'
'value' =&gt; 'ùord÷ress'
'db' =&gt; true
)
7 =&gt; Array (
'charset' =&gt; false
'value' =&gt; 100
)
8 =&gt; Array (
'charset' =&gt; 'big5'
'value' =&gt; 'a¦@b'
)
)
</pre>SergeyBiryukovhttps://core.trac.wordpress.org/ticket/31262
https://core.trac.wordpress.org/ticket/31262Report#30619: The wpView toolbar is not accessible by keyboardazaozzSun, 07 Dec 2014 00:01:53 GMTMon, 23 Mar 2015 11:14:34 GMT<p>
The (new) image toolbar is fully accessible by keyboard (Alt+F8 to focus, then arrow keys to move to the next button, etc.). However the wpView toolbar is not build in the same way so it is still not accessible.
</p>
azaozzhttps://core.trac.wordpress.org/ticket/30619
https://core.trac.wordpress.org/ticket/30619Report#31794: Theme Switcher: Improve mobile experienceocean90Fri, 27 Mar 2015 21:50:10 GMTMon, 30 Mar 2015 16:39:56 GMT<p>
@ryan spotted some issues on mobile devices, let's fix them.
</p>
<ul><li><a href="https://core.trac.wordpress.org/ticket/31289#comment:16">https://core.trac.wordpress.org/ticket/31289#comment:16</a>
</li><li><a class="ext-link" href="https://wordpress.slack.com/archives/core/p1427472548000863"><span class="icon">​</span>https://wordpress.slack.com/archives/core/p1427472548000863</a>
</li><li><a class="ext-link" href="https://wordpress.slack.com/archives/core/p1427391330000663"><span class="icon">​</span>https://wordpress.slack.com/archives/core/p1427391330000663</a>
</li><li><a class="ext-link" href="https://wordpress.slack.com/archives/core/p1427504927001095"><span class="icon">​</span>https://wordpress.slack.com/archives/core/p1427504927001095</a>
</li></ul>ocean90https://core.trac.wordpress.org/ticket/31794
https://core.trac.wordpress.org/ticket/31794Report#31793: Theme Switcher: Lazy load theme screenshotsocean90Fri, 27 Mar 2015 20:27:30 GMTSat, 28 Mar 2015 07:30:47 GMT<p>
Currently all theme screenshots are loaded, although the section is hidden at first. That needs to be improved.
</p>
ocean90https://core.trac.wordpress.org/ticket/31793
https://core.trac.wordpress.org/ticket/31793Report#31480: TinyMCE resize sandbox iFrame when images loadmattheuFri, 27 Feb 2015 20:49:52 GMTFri, 27 Mar 2015 13:23:17 GMT<p>
Possible bug - If an MCE View contains an image, and the view is sandboxed, the iFrame is not resized correctly to fit the image.
</p>
<p>
The reason for this is that the iFrame is resized using a MutationObserver. This is only triggered when a new element is inserted, or an attribute changes. But not when an image loads.
</p>
<p>
Fix - do resize on image load event. This could be done very simply like so:
</p>
<pre class="wiki">$( iframeDoc.body ).find('img').load( resize );
</pre><p>
However
</p>
<ul><li>This functionality would need to be duplicated inside the MutationObserver callback to handle any images that are added later.
</li><li>I noticed that we can't rely on the MutationObserver callback alone because this is set up AFTER the iframe is created and the content added.
</li></ul><p>
I think the solution here should be
</p>
<ol><li>In the mutation observer calback we should check for new image elements, and trigger <tt>resize</tt> when that image loads.
</li><li>Set the mutation observer BEFORE the content is added to the iFrame so this gets triggered by the main preview body content. To do this the MutationObserver needs to observe <tt>iframeDoc</tt> and not <tt>iframeDoc.body</tt>
</li></ol><p>
Any thoughts?
</p>
mattheuhttps://core.trac.wordpress.org/ticket/31480
https://core.trac.wordpress.org/ticket/31480Report#30968: Title box being partially cropped at the bottom for add/edit post screen on any non-public post type.tyxlaFri, 09 Jan 2015 16:00:17 GMTWed, 18 Mar 2015 23:57:05 GMT<p>
When creating or editing any post of a non-public post type, (e.g. when the permalink section below the title is not visible), the post title box gets partially cropped at the bottom. This results in two minor visual issues (i've attached screenshots):
</p>
<ol><li>When the title field is not focused, the border bottom is not visible - <tt>1.jpg</tt>.
</li><li>When the title field is focused, the border bottom and the bottom highlight (box shadow) is not visible - <tt>2.jpg</tt>.
</li></ol><p>
This issue occurs only in the trunk version, and not in <tt>4.1</tt>.
</p>
<p>
In order to replicate the issue, you can use the code from the <tt>Elaborate</tt> example of the <tt>register_post_type()</tt> function in the Codex: <a class="ext-link" href="http://codex.wordpress.org/Function_Reference/register_post_type#Example"><span class="icon">​</span>http://codex.wordpress.org/Function_Reference/register_post_type#Example</a> . You simply have to change the <tt>public</tt> to <tt>false</tt> to make the post type non-public.
</p>
tyxlahttps://core.trac.wordpress.org/ticket/30968
https://core.trac.wordpress.org/ticket/30968Report#22839: Toggle spinners by adding/removing a class instead of show()/hide()cdogSun, 09 Dec 2012 18:17:02 GMTWed, 25 Mar 2015 15:35:25 GMT<p>
I've noticed a bug with the spinner while updating a previous submission (<a class="accepted ticket" href="https://core.trac.wordpress.org/ticket/19159" title="enhancement: When Inactive Widgets list gets long it is hard to clear (accepted)">ticket:19159</a>). It worked in 3.4 when .ajax-feedback was used instead of .spinner.
</p>
<p>
Elements with class .spinner don't show up in any .sidebar-name (e.g. Main Sidebar, Inactive Widgets etc.) when an action is in progress (e.g. clearing inactive widgets).
</p>
cdoghttps://core.trac.wordpress.org/ticket/22839
https://core.trac.wordpress.org/ticket/22839Report#31234: Update wp-admin default colorshugobaetaWed, 04 Feb 2015 21:50:11 GMTTue, 31 Mar 2015 05:22:08 GMT<p>
In an effort to document and unify the colors of the WordPress brand, I started slightly adjusting the hues in the default wp-admin color scheme. This exercise ended up translating to a subtle but refreshed update to the admin itself, bringing slightly improved contrast, but also a cool overall hue that conveys a bit more elegance and refinement to the admin. Technically, a ever so slightly blue hue was given to the neutral dark greys. On the blues, I removed the red channel completely and adjusted the green/blue channels to retain similar value.
</p>
<p>
Here's a comparison of the colors:
<a style="padding:0; border:none" href="http://f.cl.ly/items/3C2s2E133t1u0r202r0U/WordPress-colors-breforeafter.png"><img src="http://f.cl.ly/items/3C2s2E133t1u0r202r0U/WordPress-colors-breforeafter.png" alt="http://f.cl.ly/items/3C2s2E133t1u0r202r0U/WordPress-colors-breforeafter.png" title="http://f.cl.ly/items/3C2s2E133t1u0r202r0U/WordPress-colors-breforeafter.png" /></a>
</p>
<p>
Here's a comparison of the wp-admin, before and after:
<a style="padding:0; border:none" href="http://cl.ly/image/1n1q0T0N2L2n/WordPress-wpadmin-colors-breforeafter.png"><img src="http://cl.ly/image/1n1q0T0N2L2n/WordPress-wpadmin-colors-breforeafter.png" alt="http://cl.ly/image/1n1q0T0N2L2n/WordPress-wpadmin-colors-breforeafter.png" title="http://cl.ly/image/1n1q0T0N2L2n/WordPress-wpadmin-colors-breforeafter.png" /></a>
</p>
hugobaetahttps://core.trac.wordpress.org/ticket/31234
https://core.trac.wordpress.org/ticket/31234Report#31669: views improvements continuediseuldeTue, 17 Mar 2015 16:13:47 GMTTue, 31 Mar 2015 18:31:40 GMT<p>
See <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/31412" title="enhancement: TinyMCE views improvements (closed: fixed)">#31412</a>.
</p>
<ul><li>Remove all views on hide.
</li><li>Bind and unbind method.
</li></ul>iseuldehttps://core.trac.wordpress.org/ticket/31669
https://core.trac.wordpress.org/ticket/31669Report#30422: Visual Editor Shortcuts for Headings Don't Work in Safari 8.0 on OS XcoffeemickThu, 20 Nov 2014 18:40:22 GMTMon, 30 Mar 2015 21:31:39 GMT<p>
Environment:
</p>
<ul><li>WordPress.org: Stock install without any plugins.
</li><li>Theme: Twenty Fourteen.
</li><li>Browser: Safari 8.0 on OS X 10.10.1.
</li></ul><p>
Steps to reproduce bug:
</p>
<ul><li>Create a new post and use visual editor.
</li><li>While cursor is in text input field press CMD+2 to change styling to h2.
</li></ul><p>
Expected behavior:
</p>
<ul><li>Styling changes to the theme's styling for h2.
</li></ul><p>
Actual behavior:
</p>
<ul><li>Safari opens the second bookmark of your Favorites Bar.
</li></ul><p>
Reason:
</p>
<ul><li>The first nine bookmarks on Safari's Favorites Bar have the shortcuts CMD+[1..9]
</li></ul>coffeemickhttps://core.trac.wordpress.org/ticket/30422
https://core.trac.wordpress.org/ticket/30422Report#31627: Win 8..1 / Chrome 40 Emoji Don't Render Without Saving PostmrwwebFri, 13 Mar 2015 14:49:06 GMTTue, 31 Mar 2015 20:37:36 GMT<p>
Using the Windows 8.1 touch keyboard on a desktop with a mouse (cannot test with actual touch) in Chrome 40, when I insert emoji into the editor, they appear as the unknown entity rectangle character until I save/publish the post.
</p>
<p>
The touch input keyboard with mouse works as expected in Firefox 33 and IE 11.
</p>
mrwwebhttps://core.trac.wordpress.org/ticket/31627
https://core.trac.wordpress.org/ticket/31627Report#30266: wp_mail() can send emails with a blank 'From' addressdrtonybThu, 06 Nov 2014 02:43:09 GMTSat, 28 Mar 2015 01:11:36 GMT<p>
If wp_mail() is used to send an email with a blank 'From' address set, it is not detected and replaced with the default wordpress@mydomainname...
</p>
<p>
Problem as I see it is in wp-includes/pluggable.php, where line 366 contains the test
</p>
<pre class="wiki"> if ( !isset( $from_email ) ) {
</pre><p>
The test using isset does not detect an empty string, allowing a blank 'from' address to be sent. Wouldn't it be better to test using empty?
</p>
<pre class="wiki"> if ( empty( $from_email ) ) {
</pre><p>
The same issue affects the 'from name' test on line 356.
</p>
drtonybhttps://core.trac.wordpress.org/ticket/30266
https://core.trac.wordpress.org/ticket/30266Report#30647: wp_update_user() allows using existing user_email, user_login, and user_nicenamedanielbachhuberWed, 10 Dec 2014 00:55:23 GMTWed, 18 Mar 2015 21:59:23 GMT<p>
When updating a user with <tt>wp_update_user()</tt> (which, in turn, uses <tt>wp_insert_user()</tt>), it's possible to set the <tt>user_email</tt> or <tt>user_nicename</tt> to those of an existing user. It's also possible to supply <tt>user_login</tt>, which gets silently discarded.
</p>
<p>
Each of these values need to be considered unique per user. If the values were supplied and not unique, I'd expect <tt>WP_Error</tt> to be returned.
</p>
<p>
Here's the relevant faulty logic:
</p>
<pre class="wiki">if ( ! $update &amp;&amp; username_exists( $user_login ) ) {
return new WP_Error( 'existing_user_login', __( 'Sorry, that username already exists!' ) );
}
</pre><pre class="wiki">if ( ! $update &amp;&amp; ! defined( 'WP_IMPORTING' ) &amp;&amp; email_exists( $user_email ) ) {
return new WP_Error( 'existing_user_email', __( 'Sorry, that email address is already used!' ) );
}
</pre><p>
Looks like this was introduced in <a class="changeset" href="https://core.trac.wordpress.org/changeset/12778" title="Add email and login dupe checking down into wp_insert_user(). Tidy up ...">r12778</a>.
</p>
<p>
Discovered in:
</p>
<ul><li><a class="ext-link" href="https://github.com/WP-API/WP-API/pull/705"><span class="icon">​</span>https://github.com/WP-API/WP-API/pull/705</a>
</li><li><a class="ext-link" href="https://github.com/WP-API/WP-API/pull/707"><span class="icon">​</span>https://github.com/WP-API/WP-API/pull/707</a>
</li></ul>danielbachhuberhttps://core.trac.wordpress.org/ticket/30647
https://core.trac.wordpress.org/ticket/30647Report#30468: wplink modal accessibilityaferciaSun, 23 Nov 2014 18:00:20 GMTTue, 31 Mar 2015 19:45:04 GMT<p>
After <a class="closed ticket" href="https://core.trac.wordpress.org/ticket/28897" title="defect (bug): TinyMCE wplink modal keyboard navigation (closed: fixed)">#28897</a>, mainly focused on keyboard accessibility, I'd like to propose a second accessibility round for the wplink modal, this time more focused on screen readers. In the proposed patch:
</p>
<ul><li>added aria live region, aria roles, aria attributes
</li><li>use role "application" on the link listings to avoid key strokes conflicts with screen readers, focus is handled
</li><li>better focus management
</li><li>avoid to move focus in one potentially confusing case
</li><li>changed two non-links in buttons
</li><li>use CSS class 'modal-open' on the body
</li><li>CSS refinements
</li><li>wplink.js braces
</li></ul><p>
Tested with Firefox + NVDA and (quickly) with Chrome + ChromeVox.
</p>
<p>
Seems almost everything gets read out nicely. Accessibility Team and everyone interested, please test everything :) Any thoughts more than welcome.
</p>
<p>
Please remember to test when "link to existing content" is open and:
</p>
<ul><li>showing recent items (default view)
</li><li>doing a search with results
</li><li>doing a search with no results
</li></ul>aferciahttps://core.trac.wordpress.org/ticket/30468
https://core.trac.wordpress.org/ticket/30468Report#24916: XML-RPC "wp_author_id" ignored when changing author to selfredsweaterThu, 01 Aug 2013 20:40:00 GMTTue, 24 Mar 2015 17:09:25 GMT<p>
When using the MetaWeblog mw_editPost method to change the author of an existing post from another user to the logged in user, the wp_author_id" field is not read from the content_struct because of a logic error in mw_editPost().
</p>
<p>
The logic error is in this line:
</p>
<pre class="wiki">if ( isset($content_struct['wp_author_id']) &amp;&amp; ($user-&gt;ID != $content_struct['wp_author_id']) )
</pre><p>
Here it is assumed that if the supplied author ID is the same as the logged in user, then the supplied ID does not need to be read. However, this is not true when the post being edited is in fact not currently in the logged in user's authorship.
</p>
<p>
The attached patch fixes the problem and also clarifies the permissions test so that it will reject any effort to change the author ID either to another user's ID or from another user's ID, unless the logged in user has permission to editor others' posts.
</p>
redsweaterhttps://core.trac.wordpress.org/ticket/24916
https://core.trac.wordpress.org/ticket/24916Report