Justin Filip
added a comment - 15/Jan/14 3:43 PM - edited Just an FYI, I did not do the work on this, James McQuillan and Brent Boghosian both did but neither has a developer role so I can't assign the issue to them.

James McQuillan
added a comment - 03/Mar/14 5:48 PM - edited This looks good to me, my tests pass (with some minor modifications to the added unit test). Brent is testing as well and is updating the pull request. He'll update here when it's ready.

Thanks, this seems pretty safe, although I must say the test does not test much. IMO it could be improved, e.g. by assigning some capabilities at a custom context level and then testing some access checks.

Also - I noticed too late for the 26 branch that the commit message was badly formatted. I fixed it for master, but it was not worth rewriting history on the 26 branch.

Damyon Wiese
added a comment - 05/Mar/14 8:04 AM Thanks, this seems pretty safe, although I must say the test does not test much. IMO it could be improved, e.g. by assigning some capabilities at a custom context level and then testing some access checks.
Also - I noticed too late for the 26 branch that the commit message was badly formatted. I fixed it for master, but it was not worth rewriting history on the 26 branch.
Here is the documentation on proper git commit messages:
http://docs.moodle.org/dev/Commit_cheat_sheet
Integrated to 26 and master and tests have been run.