On Sat, Dec 18, 2004 at 04:42:46AM +0000, Mikkel Krautz wrote:> Greg KH wrote:> >On Sat, Dec 18, 2004 at 02:12:50AM +0000, Mikkel Krautz wrote:> >>> >>This patch adds the option "USB HID Mouse Interrupt Polling Interval"> >>to drivers/usb/input/Kconfig, and a few lines of code to> >>drivers/usb/input/hid-core.c, to make the config option function.> >>> >>It allows people to change the interval, at which their USB HID mice> >>are polled at. This is extremely useful for people who require high> >>precision, or just likes the feeling of a very precise mouse. ;)> >>> >>As the Kconfig help implies, setting a lower polling interval is known> >>to work on several mice produced by Logitech and Microsoft. I only> >>have a Logitech MX500 to test it on. My results have been positive,> >>and so have many other people's.> >> >Why not just make it a sysfs file, so you can tune it per device? That> >way you also don't have to make it a Kconfig option.> >> I'm not too familiar with sysfs, so I really don't know.

Poke around in it, I think it's the natural place for stuff like this.

> The interval is set when the device is configured - that's only once.

So it can never change? Why not add that feature at the same time?

> Therefore I think a static value in Kconfig is fine. Wouldn't a sysfs > entry be a little overkill for this?

What about makeing it a module paramater then, that is exported tosysfs? That makes it easier to adjust on the fly (before the mouse isinserted), and doesn't require the kernel to be rebuilt.