GBuella added a comment.
In https://reviews.llvm.org/D46540#1091625, @Hahnfeld wrote:
> Could you maybe add some short summaries to your patches? It's hard for
> non-Intel employees to guess what all these instructions do...
Well, I was thinking I could copy-paste this from

GBuella added a comment.
In https://reviews.llvm.org/D45616#1067492, @efriedma wrote:
> > The fcmp opcode has no defined behavior with NaN operands in the
> > comparisions handled in this patch.
>
> Could you describe the problem here in a bit more detail? As far as I know,
> the LLVM IR fcmp

GBuella added a comment.
In https://reviews.llvm.org/D45616#1093514, @efriedma wrote:
> There is no difference between "signalling" and "non-signalling" unless
> you're using "#pragma STDC FENV_ACCESS", which is currently not supported.
> Presumably the work to implement that will include

GBuella added a comment.
In https://reviews.llvm.org/D46683#1094662, @craig.topper wrote:
> What effect does this have?
Nothing important really, I just guessed it doesn't cost.
One contrived example I could come up with in 2 minutes:
#include
void x(char *restrict a

GBuella created this revision.
GBuella added reviewers: craig.topper, echristo, dblaikie.
Herald added a subscriber: cfe-commits.
When requirement imposed by __target__ attributes on functions
are not satisfied, prefer printing those requirements, which
are explicitly mentioned in the attributes.

GBuella added a comment.
In https://reviews.llvm.org/D47142#1106664, @rnk wrote:
> Why do we need a feature flag for this in the first place? The MSVC model for
> most "instruction" intrinsics is that the exact instruction is emitted
> regardless of the feature enabled. The target attribute

GBuella created this revision.
GBuella added a reviewer: craig.topper.
Herald added subscribers: cfe-commits, mgorny.
An intrinsic for an old instruction, as described in the Intel SDM.
Repository:
rC Clang
https://reviews.llvm.org/D47142
Files:
include/clang/Basic/BuiltinsX86.def

GBuella updated this revision to Diff 147775.
GBuella added a comment.
Fixed a horrible bug in the patch. Adding a ref to temporary string is not a
wise thing to do, so I had to remove this line:
ReqFeatures.push_back(F.substr(1));
Now the ReqFeatures vector can also refer to strings

GBuella added a comment.
In https://reviews.llvm.org/D46541#1106743, @craig.topper wrote:
> I think you can pass StringRef(F).substr(1). That won't create a temporary
> string. It will just create a StringRef pointing into the middle of an
> existing std::string stored in the parsed

GBuella updated this revision to Diff 148341.
GBuella added a comment.
Relocated header inclusion from x86intrin.h -> immintrin.h
I gave up on the MSVC intrinsic idea, it wouldn't work in a way compatible with
MSVC as long as LLVM requires the feature to be enabled anyways. If once we
decide to

GBuella added a comment.
The question still left is, should we remove, auto upgrade the LLVM intrinsics
not used anymore, or keep them around for when the signal behaviour is going to
matter?
https://reviews.llvm.org/D45616
___
cfe-commits

GBuella created this revision.
GBuella added reviewers: beanz, bogner, hintonda.
Herald added subscribers: cfe-commits, mgorny.
This is merely a quickfix, due to being fustrated with waiting
for ~70 objects to be linked each time following `git commit --amend`.
When toggling LLVM_APPEND_VC_REV

GBuella created this revision.
GBuella added reviewers: craig.topper, zvi, echristo.
Herald added a subscriber: cfe-commits.
Cannon Lake does not support CLWB, therefore it
does not include all features listed under SKX.
Repository:
rC Clang
https://reviews.llvm.org/D43459
Files:

GBuella requested review of this revision.
GBuella added a comment.
Well, apparently the test fails with the typo fix.
There is no `declare dllimport void @_ZSt9terminatev()` line that could be
matched for `CHECK-DYNAMIC-IA-DAG`.
Repository:
rC Clang
https://reviews.llvm.org/D48921

GBuella added a comment.
In https://reviews.llvm.org/D45488#1063067, @davezarzycki wrote:
> I don't think this change is correct. To the best of my knowledge, SKL does
> support SGX but SKX does not.
llvm-lit test/Preprocessor/predefined-arch-macros.c passes now.
I didn't know tests are not

GBuella created this revision.
GBuella added a reviewer: craig.topper.
Herald added a subscriber: cfe-commits.
The fcmp opcode has no defined behavior with NaN operands
in the comparisions handled in this patch. Thus, these
intrinsics can only be safe lowered to fcmp opcodes
when fast-math is

GBuella added a comment.
I was not sure about what predefined macros to add for goldmont-plus & tremont.
I found this conversation: https://reviews.llvm.org/D38824 which seems to
suggest no new arch specifix macros.
But apparently atom archs have their own macros.
Repository:
rC Clang