This means that REQ_FSEQ_DATA can only be set if the queue flush_flagsinclude FLUSH and/or FUA. However, the short-circuit for not issuingflushes when the device doesn't need/support them depends onREQ_FSEQ_DATA being set while the other two bits are clear:

Given the code as it stands, I don't think the body of this if statementwill ever be executed. I've attached a fix for this below. It seemslike this could be both a performance and a correctness issue, thoughI've not run into any problems I can directly attribute to this (perhapsdue to file systems not issuing flushes when support is not advertised?).