This comment has been minimized.

The CT tests seemed to pass before, so there might be something wrong with my setup. I'm running Erlang R14B04.

There were a couple other errors in the dialzyer output regarding run_tasks() never returning when using a sleeper task. I think those were already there though. If not, I could use a hint on how I could have introduced that.

The CT tests seemed to pass before, so there might be something wrong with my setup. I'm running Erlang R14B04.

There were a couple other errors in the dialzyer output regarding run_tasks() never returning when using a sleeper task. I think those were already there though. If not, I could use a hint on how I could have introduced that.

This comment has been minimized.

Yes the run_tasks warnings are expected. Dialyzer doesn't like that for some inputs run_tasks never returns (periodic tasks) for some it does return (oneshot). Normally that type of behaviour would indicate a programming error. If you run dialyzer via the Makefile (make dialyzer) it'll compare these expected warnings to the dialyzer_reference file and ignore them.

I pulled down your change locally and fixed the common test (see test/leader_cron_SUITE.erl). The problem was with the task tuple now also returning the name (similar to the change you made to the eunit tests).

I also cleaned up a few other minor things like ensuring the line lengths were not > 80 characters. I've pushed our combined changes to master.

Yes the run_tasks warnings are expected. Dialyzer doesn't like that for some inputs run_tasks never returns (periodic tasks) for some it does return (oneshot). Normally that type of behaviour would indicate a programming error. If you run dialyzer via the Makefile (make dialyzer) it'll compare these expected warnings to the dialyzer_reference file and ignore them.

I pulled down your change locally and fixed the common test (see test/leader_cron_SUITE.erl). The problem was with the task tuple now also returning the name (similar to the change you made to the eunit tests).

I also cleaned up a few other minor things like ensuring the line lengths were not > 80 characters. I've pushed our combined changes to master.