Comments

From: Reinhard Pfau <pfau@gdsys.de>
Extend the tpm library with support for single authorized (AUTH1) commands
as specified in the TCG Main Specification 1.2. (The internally used helper
functions are implemented in a way that they could also be used for double
authorized commands if someone needs it.)
Provide enums with the return codes from the TCG Main specification.
For now only a single OIAP session is supported.
OIAP authorized version of the commands TPM_LoadKey2 and TPM_GetPubKey are
provided. Both features are available using the 'tpm' command, too.
Authorized commands are enabled with CONFIG_TPM_AUTH_SESSIONS. (Note that
this also requires CONFIG_SHA1 to be enabled.)
Signed-off-by: Reinhard Pfau <reinhard.pfau@gdsys.cc>
Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
---
Changes in v5: None
Changes in v4: None
Changes in v3:
- fix email addresses
Changes in v2:
- replace some numeric constants with named constants
- style fixes (as shown by checkpatch.pl) in common/cmd_tpm.c and lib/tpm.c
README | 14 ++
common/cmd_tpm.c | 100 +++++++++++++++
include/tpm.h | 174 +++++++++++++++++++++++++++
lib/tpm.c | 351 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
4 files changed, 638 insertions(+), 1 deletions(-)

Hi,
On Tue, Apr 30, 2013 at 6:54 AM, <dirk.eibach@gdsys.cc> wrote:
> From: Reinhard Pfau <pfau@gdsys.de>>> Extend the tpm library with support for single authorized (AUTH1) commands> as specified in the TCG Main Specification 1.2. (The internally used helper> functions are implemented in a way that they could also be used for double> authorized commands if someone needs it.)>> Provide enums with the return codes from the TCG Main specification.>> For now only a single OIAP session is supported.>> OIAP authorized version of the commands TPM_LoadKey2 and TPM_GetPubKey are> provided. Both features are available using the 'tpm' command, too.>> Authorized commands are enabled with CONFIG_TPM_AUTH_SESSIONS. (Note that> this also requires CONFIG_SHA1 to be enabled.)>> Signed-off-by: Reinhard Pfau <reinhard.pfau@gdsys.cc>>>> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
The same rebase comment applies here, but otherwise it looks good.
Regards,
Simon
> ---> Changes in v5: None> Changes in v4: None> Changes in v3:> - fix email addresses>> Changes in v2:> - replace some numeric constants with named constants> - style fixes (as shown by checkpatch.pl) in common/cmd_tpm.c and lib/tpm.c>> README | 14 ++> common/cmd_tpm.c | 100 +++++++++++++++> include/tpm.h | 174 +++++++++++++++++++++++++++> lib/tpm.c | 351 +++++++++++++++++++++++++++++++++++++++++++++++++++++-> 4 files changed, 638 insertions(+), 1 deletions(-)