5 responses

I’ve noticed my addon for a few days being #13 in the queue. Then today I see it is #14. Not a big deal, but I’m curious to know when that can happen. Thanks!

Also, if I can ask here, I was declined from making an addon upgrade because I modified the SDK (and mentioned this). Why is this the case? It’s not like the addon is suddenly not introspectable… Do your validators simply check that the included SDK is valid and if not, reject it entirely? Or do you not check it and believe that a policy will protect you from malicious modifications? If the latter, that seems to be punishing people who are reporting the truth, and not doing anything for security.

Also, I strongly hope that after waiting all this time for a preliminary review (admittedly in part because I kept updating the addon not realizing for a while that it apparently resets me to the end of the queue), that I can still be given feedback on what I may be able to do to get this accepted at AMO–beyond just “you modified the SDK so do over”. I know I will need to change this, but I am still hoping for a complete enough review that I will not be unpleasantly surprised whenever I may implement all recommendations. Thanks!

Brett, usually, my addon climbs up the queue to the teens and then its position fluctuates between 13 and 18 (for as long as two weeks for a full review). I asked in the IRC channel about it and was told that it had to do with a bug related to review requests being canceled and then resubmitted or something like that. In any case, the reviewers just use the queue position as a rough guide and often review things out of order based on what they feel has highest priority and what they have the expertise to review.

There are some cases where old versions are re-nominated and move immediately to the top of the queue because of the date sorting that the queues implement. This can lead to what you describe.

As for changing SDK files, we don’t allow it for security reasons. We can easily ignore the SDK if it’s unchanged, and then we just need to focus on the non-SDK files. If there’s a really good reason you need to modify it and there’s no way around it, we might be able to make an exception. In these cases it’s best to reply to the review message so we can have the discussion on the mailing list.