Arun C Murthy
added a comment - 04/Oct/11 00:42 Attaching patch on Owen's behalf.
It's incredibly hard to unit test this without multiple versions of hadoop.
Via PIG-2125 pig-dev@ have used this for nearly 2 months now and has no issues.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 04/Oct/11 01:13 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12497570/MAPREDUCE-3138.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/931//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/931//console
This message is automatically generated.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

Hadoop QA
added a comment - 04/Oct/11 02:03 -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12497580/MAPREDUCE-3138.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/932//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/932//console
This message is automatically generated.

I am not positive of the intention of this patch. It provides a bridge where pig can potentially compile against both 0.22 and 0.23 but it does not fix any binary compatibility issues. Pig and Pig loader/storer UDFs compiled against pre-0.21 will need to be recompiled to work on 0.22 and 0.23. The Java linker will throw an error if a class was compiled against a class and sees an interface with the same name or vise versa. If the intention is not to provide binary compatibility we really need a JIRA to do that. We have too many customers that are going to mutiny if they have to maintain two different binary versions of the same code to run on different grids.

Robert Joseph Evans
added a comment - 04/Oct/11 15:34 I am not positive of the intention of this patch. It provides a bridge where pig can potentially compile against both 0.22 and 0.23 but it does not fix any binary compatibility issues. Pig and Pig loader/storer UDFs compiled against pre-0.21 will need to be recompiled to work on 0.22 and 0.23. The Java linker will throw an error if a class was compiled against a class and sees an interface with the same name or vise versa. If the intention is not to provide binary compatibility we really need a JIRA to do that. We have too many customers that are going to mutiny if they have to maintain two different binary versions of the same code to run on different grids.

First of all, I'm really happy to see a move towards helping the downstream clients migrate to .23 smoothly. That said,
I'm not quite sure what is the intent of the patch. It would be very nice to have a clear description of what is it trying to accomplish. As it stands now, I can't really build Pig/Hive (or anything else for that matter) against .23 nor can I run the older binaries. Has this patch been tested?

Roman Shaposhnik
added a comment - 04/Oct/11 19:35 First of all, I'm really happy to see a move towards helping the downstream clients migrate to .23 smoothly. That said,
I'm not quite sure what is the intent of the patch. It would be very nice to have a clear description of what is it trying to accomplish. As it stands now, I can't really build Pig/Hive (or anything else for that matter) against .23 nor can I run the older binaries. Has this patch been tested?

Arun, thanks for the tip.
Do you plan to remove org.apache.hadoop.mapreduce.task.JobContextImpl from trunk and 0.23. Or is it some Pig build magic that excludes the package from the classpath?
Otherwise I don't understand how this patch distinguishes between 0.21 and 0.23.

Konstantin Shvachko
added a comment - 04/Oct/11 19:45 Arun, thanks for the tip.
Do you plan to remove org.apache.hadoop.mapreduce.task.JobContextImpl from trunk and 0.23. Or is it some Pig build magic that excludes the package from the classpath?
Otherwise I don't understand how this patch distinguishes between 0.21 and 0.23.