So as per our discussions last week, I will be moving forward with theconversion of the LIO-Target iSCSI fabric module v4 to use protocol andPDU include/scsi/iscsi_proto.h. As mnc and I agreed privately, this isgoing to the right level of integration for v2.6.37, as making libiscsitarget mode aware does not really make for a target mode iSCSI stacksense due to the amount of logic in place for kernel <-> user with theOpen-iSCSI initiator.

So aside from the main tedious work that will be involved in actuallyproducing a patch for this on my end, I did notice one immediate itemthat will cause an extra headache.. This involves the structiscsi_init_* and struct iscsi_target* structure definitions in:

namely that they all have trailing 'u32 header_digest' member that adecent amount of utility code in iscsi_target.c and iscsi_target_util.ccurrently depends upon.

So, assuming that the conversion of all struct iscsi_init_* and structiscsi_target* to use include/scsi/iscsi_proto.h defs just involveschecking structure size and renaming the member use indrivers/target/lio-target, would it be acceptable to do something like: