City Guard gold is calculated at the end of the shift. The amount will go up if your guild bonus goes up during your City Guard too.

That can't always be the case. I had started a City Guard shift before the server was updated. Afterwards with the server reset and the gold bonuses in place, the city guard was exactly what it said it would be at the beginning of my shift.