On Tuesday 09 Sep 2003 11:01 pm, Jesse Barnes wrote:> On Tue, Sep 09, 2003 at 10:38:26PM +0100, Andrew de Quincey wrote:> > On Tuesday 09 September 2003 22:17, Jesse Barnes wrote:> > > On Tue, Sep 09, 2003 at 09:43:58PM +0100, Andrew de Quincey wrote:> > > > On Tuesday 09 September 2003 21:13, Jesse Barnes wrote:> > > > > Instead of going into an infinite loop because the list isn't setup> > > > > yet, just return NULL if there are no prt entries.> > > >> > > > Ah, this is a patch against the vanilla kernel.. This is> > > > unfortunately incompatible with my recent ACPI patches.> > >> > > Maybe you could include it in your patch then? I noticed that your> > > patch changes some of the IRQ routing code...> >> > I'm not sure it is still needed or not. The patch makes a lot of changes> > as to how the acpi_prt list is generated. What triggers the problem> > exactly, so I can test?>> An SGI Altix system that only supports part of the ACPI spec :). Our> PROM currently doesn't generate any MADT entries other than CPUs (I'm> not even sure how we could add them since we use our own interrupt> controller, not an IOAPIC or IOSAPIC) and lacks an ACPI namespace, so> we're missing all sorts of stuff.

So, exactly as your patch did, you just want it to drop back if there were no PCI routing entries found by ACPI... sounds sensible enough.