-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43880/
-----------------------------------------------------------

Advertising

(Updated March 3, 2016, 5:17 p.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Addressed comments form Alex.
Bugs: MESOS-4720
https://issues.apache.org/jira/browse/MESOS-4720
Repository: mesos
Description (updated)
-------
Added allocator metrics for total and allocated scalar resources.
Diffs (updated)
-----
docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110
src/master/allocator/mesos/hierarchical.hpp
3043888630b066505410d3b32c5b3f813cc458c1
src/master/allocator/mesos/hierarchical.cpp
70291075c00a9a557529c2562dedcfc6c6c3ec32
src/master/allocator/mesos/metrics.hpp PRE-CREATION
src/master/allocator/mesos/metrics.cpp PRE-CREATION
src/tests/hierarchical_allocator_tests.cpp
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1
Diff: https://reviews.apache.org/r/43880/diff/
Testing
-------
make check (OS X)
I confirmed that this does not lead to general performance regressions in the
allocator; this is partially expected since the added code only inserts metrics
in the allocator while the actual work is perform asynchronously. These tests
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an
optimized build under OS X using clang(trunk) as compiler.
Thanks,
Benjamin Bannier