Re: ahc/ahd locking

From:

Peter Avalos <pavalos@xxxxxxxxxxxx>

Date:

Sun, 13 Jan 2008 19:25:38 -0500

Mail-followup-to:

kernel@crater.dragonflybsd.org

On Sun, Jan 13, 2008 at 12:35:44PM -0800, Matthew Dillon wrote:
>
> :I took the changes out, and I'm running a stock kernel, and it seems to
> :be ok. So it's gotta be something going on. Maybe i should just use
> :lockmgr locks, and forget the intr/serializer stuff?
> :
> :--Peter
>
> It's up to you. lockmgr will work. The advantage of using the
> serializer is that the interrupt subsystem can determine whether the
> interlock will block *before* trying to call the interrupt procedure,
> which can be beneficial when multiple devices share the same irq.
>
> I'd say... get it working and stable first, then worry about making
> it efficient.
>
Indeed. I'm running a test kernel now that's using lockmgr locks. This
is the patchset:
http://www.theshell.com/~pavalos/wip/aic7xxx-locking5.patch
--Peter