Reviewreview-ietf-dime-rfc4006bis-07-secdir-lc-mandelberg-2018-04-19

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG. These comments were written primarily for the benefit of the
security area directors. Document editors and WG chairs should treat
these comments just like any other last call comments.
The summary of the review is Ready with nits.
(nit) The term AVP is used extensively, and I don't see a definition.
Would its definition be obvious to anybody implementing this spec? I'm
assuming it means attribute-value pair.
(nit, section 5.1.1) "For time based services, the quota is continuously
consumed at the regular rate of 60 seconds per minute." Are leap seconds
a problem?
--
Freelance cyber security consultant, software developer, and more
https://david.mandelberg.org/