On Thu, Jul 01, 2004 at 11:09:55PM +0200, Xavier Hervy wrote:
> I made a patch for media monitoring that allow MythDialog to intercept
> mediahandler before that mediamonitoring close activewindow and open the
> good plugin.
<snip>
> Actually it's work great in mythvideo.
I agree, it works great when prompted to insert the media in the
browser. Performing a context sensitive handler event is much nicer
than blindly calling the handler again.
> I also update my patch to remove some cout, i have forget to remove, fix
> few little bug in videofilter.
There's still some old code cruft in videoutils.cpp that's commented
out, you should remove that (updatePlayWait).
I isolated the segfault I was seeing when cancelling the insertion
request from the videobrowser. I've attached a patch for that
versus your patchset, please consider including it. Also, with
onMediaEvent(), there's no need to have a Retry button, so I changed
it to just focus on Cancel since onMediaEvent() will emit the
retry signal when the user inserts the media.
I still have a segfault in videogallery, but I'm going to take a
break and look at that in a bit.
-Matt
-------------- next part --------------
--- mythvideo.orig/mythvideo/videoutils.cpp 2004-07-03 11:05:53.000000000 -0700
+++ mythvideo/mythvideo/videoutils.cpp 2004-07-03 11:06:34.000000000 -0700
@@ -99,9 +99,8 @@
.arg(storage->getVolumeID())
);
- QButton * focusButton = popup->addButton(tr("Retry"),
- this, SLOT(slotDoRetry()));
- popup->addButton(tr("Cancel"),this, SLOT(slotDoCancel()));
+ QButton * focusButton = popup->addButton(tr("Cancel"),
+ this, SLOT(slotDoCancel()));
popup->ShowPopup(this,SLOT(slotDoCancel()));
focusButton->setFocus();
connect (popup,SIGNAL(retry()),this,SLOT(slotDoRetry()));
@@ -155,6 +154,7 @@
if (popup)
popup->hide();
delete popup;
+ popup = NULL;
}